Paths

Table of Contentst

Full Restrict Support - single patch
Needs ReviewPublic
Actions

Authored by jeroen.dobbelaere on Oct 28 2019, 6:02 PM.

Details

Reviewers

jdoerfert
deadalnix
jansvoboda11

Summary

This is a convenience patch that covers all 27 patches starting from D68484 through D68523. It implements the support for full C99 restrict in clang/llvm.

Any feedback about how it behaves on your benchmarks and testcases is welcome !

Any help with code review is also welcome. That should happen on the separate patches.
(The part that is currently up for review is on D111159, introducing unknown_provenance and ptr_provenance)

The base version is ffe262a198a9f9030991df6d3ddd812e74fa3523 (July 29, 2022)

NOTE: (June 21, 2021) - full restrict is now again enabled by default - this update also contains a number of bugfixes (triggered by csmith) - llvm.noalias.copy.guard now uses a representation based on offsets for knowing where in memory noalias pointers are stored (documentation is not yet updated) - the separate patches are not yet in sync with this version

Note: (November 17,2021)

Moved NoAliasProvenance out of AAMetadata. Added PtrProvenance to MemoryLocation
Introduced UnknownProvenance constant
Added support for (some) atomic instructions.

Note: (July 29, 2022)

Track ptr_provenance again during selectiondag lowering

Diff Detail

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Rebased to c06b7e2ab5167ad031745a706204abed1aefd823 (July 14, 2020)

Herald added subscribers: dang, nikic. · View Herald TranscriptJul 14 2020, 3:25 AM

Rebased to 9fb46a452d4e5666828c95610ceac8dcd9e4ce16 (September 7, 2020)

Herald added a subscriber: wenlei. · View Herald TranscriptSep 7 2020, 2:39 PM

D68509: Updated to correctly handle inlining when callee == caller. (Triggered by doing a stage2 compile)
D68515: Fixed build warning and testcase failure in Release mode.

Following changes were done:

use 'variant 1' approach for ptr_provenance argument, getting rid of 'NumUserOperandsDelta' (See D68488)
fix issue with new pass manager (See D68507)
fix testcase issue (See D68512)

• ogreenz added a subscriber: • ogreenz.Sep 24 2020, 1:28 PM

mdchen added a subscriber: mdchen.Oct 7 2020, 12:50 AM

slanterns added a subscriber: slanterns.Oct 9 2020, 9:40 PM

tgnottingham added a subscriber: tgnottingham.Oct 30 2020, 4:39 PM

barannikov88 added a subscriber: barannikov88.Dec 10 2020, 10:32 PM

barannikov88 added inline comments.

llvm/lib/Analysis/BasicAliasAnalysis.cpp
1770–1771	Suppose we have `V2` with valid noalias provenance, and `V1` without it. `V1` is a long chain of GEPs (longer than `MaxLookupSearchDepth`), finished with `noalias.arg.guard`. When `aliasCheck` is called the first time, we get into the "then" branch of the "if", strip nothing, and `getUnderlyingObject` finds some base for `V1` at the depth `MaxLookupSearchDepth`. This object will be passed to a recursive call of `aliasCheck` later as `O1`. After that, `aliasCheck` is called recursively from `aliasGEP`, this time with `O1 != nullptr` and empty `V2AAInfo`. We get into the `else` branch of the `if` and strip out `noalias.arg.guard` from `V1` chain. This effectively decreases depth of the expression, and `DecomposeGEP` called later from `aliasGEP` will return _different_ base object from `O1`. This leads to failed assertion in `aliasGEP` which checks that `DecomposeGEP` found the same base as `getUnderlyingObject`.

Herald added a subscriber: lxfind. · View Herald TranscriptDec 10 2020, 10:32 PM

Thanks for the detailed analysis !

barannikov88 added inline comments.Dec 17 2020, 1:38 PM

llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
494	@jeroen.dobbelaere In case the instruction is Load or Store, its provenance operand is set UndefValue upon cloning. Is this behavior appropriate here?

elindsey removed a subscriber: elindsey.Dec 17 2020, 1:39 PM

jeroen.dobbelaere marked an inline comment as not done.Dec 18 2020, 1:07 AM

jeroen.dobbelaere added inline comments.

llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
494	@barannikov88 Good question. The restrict patches have had already a number of iterations. In the earlier versions, ptr_provenance information was dropped when cloning. The main reason was for safety: In a restrict world, you need to think what to do when cloning an instruction wrt the restrict validity: do we need to keep the same scopes/restrict variable or do we need to work on a copy. Dropping the info was a safety guard. But, we needed to keep the same number of arguments, so I used `UndefValue` to indicate a dropped ptr_provenance. At that time, a missing ptr_provenance would result in 'safe analysis', as, both a ptr_provenance and a !noalias metadata were required to perform ScopeNoAliasAA. Later on, it became clear that we should also do analysis if no ptr_provenance was explicitly present (which meant the same as ptr == ptr_provenance) and the rules changed. This probably means that just dropping the ptr_provenance when cloning is probably not the right thing to do any more. And passes that use `clone()` on a load/store instruction should become aware of the potential extra dependency introduced by the ptr_provenance. Dropping it (in a restrict) world should only be done if also the !noalias metadata is removed. In a world where ptr_provenance is also used for tracking actual ptr_provenance, this might also not be true. So no, this behavior is probably not appropriate here. Do you happen to have a testcase that confirms this ?

barannikov88 added inline comments.Dec 18 2020, 1:20 AM

llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
494	Thank you for the quick and detailed answer! I have a testcase, but right now it contains some bits of proprietary information. I'll strip them off and post the test here later.

barannikov88 added inline comments.Dec 18 2020, 5:18 AM

llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
494	Here you go: test.ll3 KBDownload `$ opt test.ll -loop-rotate -S -o -` You should be able to find the following line in the output: `%x.01 = load i8, i8* %src_ptr, ptr_provenance i8* undef, align 1, !tbaa !10, !noalias !9` The patch was aplied to the same base, the project is configured as: -DBUILD_SHARED_LIBS=ON -DLLVM_CCACHE_BUILD=ON -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_USE_LINKER=lld PS I believe I've seen similar behavior of the SimplifyCFG pass, I'll try to prepare a test for that, too.

barannikov88 added inline comments.Dec 18 2020, 6:26 AM

llvm/lib/Transforms/Utils/LoopRotationUtils.cpp
494	I believe I've seen similar behavior of the SimplifyCFG pass, I'll try to prepare a test for that, too. It appeared to be the same pass (LoopRotate). The dump just did not show the change with -print-after-all.

@barannikov88
Thanks ! I have vacation the next two weeks, so things will be slow. But I'll take it into account for the next revision on which I am working.
If you have time you can always join the LLVM Alias Analysis Technical Call. The next one should be on January 5,2021; 12pm central time.

PaulGrandperrin added a subscriber: PaulGrandperrin.Jan 4 2021, 6:26 AM

penzn added a subscriber: penzn.Jan 5 2021, 10:25 AM

Dushistov added a subscriber: Dushistov.Jan 27 2021, 2:56 AM

Herald added a reviewer: jansvoboda11. · View Herald TranscriptJan 27 2021, 2:56 AM

jansvoboda11 resigned from this revision.Feb 19 2021, 5:17 AM

Herald added a subscriber: jansvoboda11. · View Herald TranscriptFeb 19 2021, 5:17 AM

makesource added a subscriber: makesource.May 11 2021, 11:25 PM

Matt added a subscriber: Matt.May 12 2021, 9:08 AM

Rebased to f8dbd61074176bae92ec360a093ac7bc498c9321.

Herald added a subscriber: sstefan1. · View Herald TranscriptMay 18 2021, 4:58 AM

Harbormaster completed remote builds in B105015: Diff 346142.May 18 2021, 8:33 AM

NOTE: the latest update missed two mandatory changes: - in clang/include/clang/Driver/Options.td : the DefaultFalse should become a DefaultTrue in order to enable the full restrict by default. - in clang/lib/Driver/ToolChains/Clang.cpp, '"-use-noalias-intrinsic-during-inlining=0"' must become '"-use-noalias-intrinsic-during-inlining=scopes"'

Herald added a subscriber: ormris. · View Herald TranscriptJun 14 2021, 3:25 PM

NOTE: (June 21, 2021) - full restrict is now again enabled by default - this update also contains a number of bugfixes (triggered by csmith) - llvm.noalias.copy.guard now uses a representation based on offsets for knowing where in memory noalias pointers are stored - the separate patches are not yet in sync with this version

Herald added a subscriber: aheejin. · View Herald TranscriptJun 21 2021, 3:45 PM

Harbormaster completed remote builds in B110304: Diff 353504.Jun 21 2021, 4:59 PM

Rebased to 3c4fad6a69887311f4e9feeca28126a89f314d45 (August 17, 2021)

steven_wu removed a subscriber: steven_wu.Aug 17 2021, 9:27 AM

Compile time impact: https://llvm-compile-time-tracker.com/index.php?config=NewPM-O3&stat=instructions&branch=dobbelaj-snps%2Fperf%2Ffull_restrict-20210817-01

Harbormaster completed remote builds in B119918: Diff 366921.Aug 17 2021, 11:00 AM

gyiu added a subscriber: gyiu.Aug 26 2021, 1:45 PM

gyiu added inline comments.

llvm/lib/Transforms/Scalar/SROA.cpp
3954	Missing this line to make sure NoAlias Instruction doesn't self-reference. NoAlias->setOperand(0, Load);

kito-cheng added a subscriber: kito-cheng.Oct 28 2021, 5:33 PM

Herald added a subscriber: asavonic. · View Herald TranscriptOct 28 2021, 5:33 PM

Rebased to 8924ba3bf8c6b0e8d14dff455e4e449a426a2700 (November 17, 2021)

Note: (November 17,2021)

Moved NoAliasProvenance out of AAMetadata. Added PtrProvenance to MemoryLocation
Introduced UnknownProvenance constant
Added support for (some) atomic instructions.

Herald added a reviewer: deadalnix. · View Herald TranscriptNov 17 2021, 7:51 AM

Harbormaster completed remote builds in B134739: Diff 387940.Nov 17 2021, 8:50 AM

anemet added a subscriber: anemet.Jan 21 2022, 9:40 PM

hkao13 added a subscriber: hkao13.Feb 1 2022, 2:01 PM

hkao13 added inline comments.

llvm/lib/IR/IRBuilder.cpp
579	This is a case when clang codegen creates a bitcast for `NoAliasLoad`, causing the TBAA issue mentioned above. Is it possible to remove this code entirely? Looking into `getMangledTypeStr()`, it seems like literal structs will be prefixed with "sl_". Thank you.

hkao13 added inline comments.Feb 1 2022, 2:09 PM

clang/lib/CodeGen/CGExpr.cpp
1759	Metadata copied over from `Load` to `NoAliasLoad` may include TBAA. `NoAliasLoad` may be a bitcast instruction which will cause IR verifier to assert if TBAA metadata is attached.

Hi @hkao13 You happen to have some reduced testcases that show the problem ? Thanks !

Hi @jeroen.dobbelaere, the above two comments of mine are in the wrong order, sorry.

I have attached a C test case, and the problem I'm seeing related to the above comments can be replicated using:

clang -flegacy-pass-manager -ffull-restrict -fstrict-aliasing -O1 test-verify.c

test-verify.c122 BDownload

The output error I see is on a bitcast instruction:
This instruction shall not have a TBAA access tag!

Thanks.

Hi. I tried to use your patch for my project. My main concern is AA in MachineScheduler.
I noticed what ptr_provenance info is not passed to CodeGen.
It could be fixed by adding it to MemoryMachineOperand constructor in SelectionDAGBuilder::visitLoad and SelectionDAGBuilder::visitStore.
Also invocation of AAResults::alias in Codegen lacks of PtrProvenance argument in MemoryLocation constructors.
After this fixes AA in MachineScheduler is working fine.

Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2022, 10:27 AM

Herald added subscribers: mattd, MaskRay. · View Herald Transcript

In D69542#3465162, @D.Kharlamov wrote:

Hi. I tried to use your patch for my project. My main concern is AA in MachineScheduler.
I noticed what ptr_provenance info is not passed to CodeGen.
It could be fixed by adding it to MemoryMachineOperand constructor in SelectionDAGBuilder::visitLoad and SelectionDAGBuilder::visitStore.

Hi @D.Kharlamov, thanks for notifying this. Originally, the ptr_provenance was part of the AAMDNodes, so it would be automatically part of those places.
When extracting the ptr_provenance support, I moved it out of AAMDNodes, as that was not the logical place for it to reside. This explicit passing should indeed be
added in the SelectionDAGBuilder::visitLoad/visitStore. (Note that MachinePointerInfo already supports the optional ptr_provenance argument).

Any help with reviewing the ptr_provenance patches (See D107354 and related) is appreciated. Getting these reviewed and accepted is the next step in adding full restrict support.

Also invocation of AAResults::alias in Codegen lacks of PtrProvenance argument in MemoryLocation constructors.
After this fixes AA in MachineScheduler is working fine.

Also here, we will need to pass the ptr_provenance explicitely. Could you point me to a file and location for this case ?

Thanks,

Jeroen Dobbelaere

Rebased
Track ptr_provenance also during lowering (this was not working any more when ptr_provenance got moved outside of AAMetaData)

Herald added subscribers: nlopes, jsji, kosarev and 4 others. · View Herald TranscriptWed, Jun 29, 4:33 AM

Harbormaster completed remote builds in B172701: Diff 440936.Wed, Jun 29, 5:40 AM

mgabka added a subscriber: mgabka.Wed, Jun 29, 5:50 AM

dexonsmith removed a subscriber: dexonsmith.Wed, Jun 29, 9:48 AM

huntergr added a subscriber: huntergr.Fri, Jul 1, 6:51 AM

Large Diff

This large diff affects 282 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

AST/

Type.h

4 lines

Basic/

CodeGenOptions.def

2 lines

Driver/

Options.td

13 lines

lib/

AST/

Type.cpp

24 lines

CodeGen/

11 lines

47 lines

125 lines

18 lines

13 lines

42 lines

1 line

103 lines

24 lines

6 lines

7 lines

CodeGenNoAliasOffsets.h

53 lines

CodeGenNoAliasOffsets.cpp

132 lines

Driver/

ToolChains/

Clang.cpp

12 lines

test/

CodeGen/

PowerPC/

builtins-ppc-pair-mma-types.c

76 lines

X86/

avx-builtins.c

22 lines

avx2-builtins.c

2 lines

aarch64-ls64.c

23 lines

arm_neon_intrinsics.c

1 line

restrict/

36 lines

53 lines

130 lines

137 lines

52 lines

74 lines

296 lines

escape_through_volatile.c

31 lines

inlining_01.c

155 lines

inlining_02.c

143 lines

provenance.noalias_reduction_01.c

199 lines

struct.c

129 lines

struct_base_class_09.cpp

172 lines

73 lines

110 lines

100 lines

168 lines

107 lines

108 lines

60 lines

162 lines

CodeGenCUDA/

builtins-amdgcn.cu

48 lines

Driver/

full-restrict.c

23 lines

OpenMP/

cancel_codegen.cpp

288 lines

cancellation_point_codegen.cpp

160 lines

debug-info-complex-byval.cpp

27 lines

debug-info-openmp-array.cpp

211 lines

distribute_parallel_for_reduction_task_codegen.cpp

228 lines

for_reduction_task_codegen.cpp

228 lines

master_taskloop_firstprivate_codegen.cpp

6 lines

master_taskloop_in_reduction_codegen.cpp

258 lines

master_taskloop_lastprivate_codegen.cpp

7 lines

master_taskloop_private_codegen.cpp

6 lines

master_taskloop_simd_firstprivate_codegen.cpp

6 lines

master_taskloop_simd_in_reduction_codegen.cpp

258 lines

master_taskloop_simd_lastprivate_codegen.cpp

6 lines

master_taskloop_simd_private_codegen.cpp

6 lines

nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

3144 lines

parallel_codegen.cpp

364 lines

parallel_for_reduction_task_codegen.cpp

228 lines

parallel_if_codegen_PR51349.cpp

32 lines

parallel_master_reduction_task_codegen.cpp

228 lines

parallel_master_taskloop_codegen.cpp

946 lines

parallel_master_taskloop_firstprivate_codegen.cpp

6 lines

parallel_master_taskloop_lastprivate_codegen.cpp

1078 lines

parallel_master_taskloop_private_codegen.cpp

6 lines

parallel_master_taskloop_simd_codegen.cpp

1804 lines

parallel_master_taskloop_simd_firstprivate_codegen.cpp

6 lines

parallel_master_taskloop_simd_lastprivate_codegen.cpp

1094 lines

parallel_master_taskloop_simd_private_codegen.cpp

6 lines

parallel_reduction_task_codegen.cpp

228 lines

parallel_sections_reduction_task_codegen.cpp

228 lines

sections_reduction_task_codegen.cpp

228 lines

target_in_reduction_codegen.cpp

66 lines

target_parallel_codegen.cpp

240 lines

target_parallel_debug_codegen.cpp

908 lines

target_parallel_for_codegen.cpp

624 lines

target_parallel_for_debug_codegen.cpp

1248 lines

target_parallel_for_reduction_task_codegen.cpp

228 lines

target_parallel_for_simd_codegen.cpp

1624 lines

target_parallel_reduction_task_codegen.cpp

228 lines

target_teams_codegen.cpp

656 lines

target_teams_distribute_codegen.cpp

672 lines

target_teams_distribute_parallel_for_reduction_task_codegen.cpp

228 lines

target_teams_distribute_simd_codegen.cpp

656 lines

task_codegen.cpp

4386 lines

task_firstprivate_codegen.cpp

6 lines

task_if_codegen.cpp

1056 lines

task_in_reduction_codegen.cpp

264 lines

task_member_call_codegen.cpp

152 lines

task_private_codegen.cpp

6 lines

task_target_device_codegen.c

42 lines

taskloop_firstprivate_codegen.cpp

6 lines

taskloop_in_reduction_codegen.cpp

258 lines

taskloop_lastprivate_codegen.cpp

6 lines

taskloop_private_codegen.cpp

6 lines

taskloop_simd_firstprivate_codegen.cpp

6 lines

taskloop_simd_in_reduction_codegen.cpp

258 lines

taskloop_simd_lastprivate_codegen.cpp

6 lines

taskloop_simd_private_codegen.cpp

6 lines

teams_distribute_parallel_for_reduction_task_codegen.cpp

228 lines

llvm/

docs/

LangRef.rst

330 lines

NoAliasInfo.rst

1399 lines

UserGuides.rst

5 lines

include/

llvm-c/

Core.h

16 lines

llvm/

Analysis/

BasicAliasAnalysis.h

7 lines

MemoryLocation.h

43 lines

ScopedNoAliasAA.h

33 lines

TargetTransformInfoImpl.h

5 lines

ValueTracking.h

17 lines

VectorUtils.h

5 lines

AsmParser/

LLParser.h

4 lines

LLToken.h

2 lines

Bitcode/

LLVMBitCodes.h

1 line

CodeGen/

BasicTTIImpl.h

6 lines

MachineMemOperand.h

24 lines

IR/

29 lines

60 lines

2 lines

5 lines

74 lines

19 lines

21 lines

173 lines

42 lines

18 lines

18 lines

19 lines

1 line

2 lines

2 lines

Transforms/

Scalar.h

10 lines

Scalar/

ConnectNoAliasDecl.h

32 lines

PropagateAndConvertNoAlias.h

37 lines

Utils/

Cloning.h

5 lines

NoAliasUtils.h

39 lines

lib/

Analysis/

BasicAliasAnalysis.cpp

21 lines

CaptureTracking.cpp

10 lines

InstructionSimplify.cpp

44 lines

MemoryLocation.cpp

2 lines

ScopedNoAliasAA.cpp

573 lines

TypeBasedAliasAnalysis.cpp

16 lines

ValueTracking.cpp

35 lines

VectorUtils.cpp

7 lines

AsmParser/

LLLexer.cpp

2 lines

LLParser.cpp

59 lines

Bitcode/

Reader/

BitcodeReader.cpp

103 lines

Writer/

BitcodeWriter.cpp

23 lines

CodeGen/

IntrinsicLowering.cpp

9 lines

MachineOperand.cpp

4 lines

SelectionDAG/

SelectionDAGBuilder.cpp

20 lines

IR/

32 lines

18 lines

8 lines

102 lines

24 lines

98 lines

2 lines

1 line

119 lines

1 line

39 lines

154 lines

Passes/

PassBuilder.cpp

2 lines

PassBuilderPipelines.cpp

51 lines

PassRegistry.def

2 lines

Transforms/

IPO/

ArgumentPromotion.cpp

2 lines

DeadArgumentElimination.cpp

8 lines

FunctionAttrs.cpp

6 lines

GlobalOpt.cpp

14 lines

PassManagerBuilder.cpp

51 lines

InstCombine/

InstCombineCalls.cpp

16 lines

InstCombineLoadStoreAlloca.cpp

72 lines

InstCombinePHI.cpp

11 lines

InstructionCombining.cpp

22 lines

Scalar/

CMakeLists.txt

2 lines

ConnectNoAliasDecl.cpp

114 lines

12 lines

5 lines

27 lines

31 lines

PropagateAndConvertNoAlias.cpp

1271 lines

SROA.cpp

866 lines

Scalar.cpp

2 lines

Utils/

1 line

56 lines

329 lines

23 lines

17 lines

LoopRotationUtils.cpp

141 lines

LoopUnroll.cpp

27 lines

NoAliasUtils.cpp

200 lines

PromoteMemoryToRegister.cpp

469 lines

SimplifyCFG.cpp

9 lines

ValueMapper.cpp

2 lines

Vectorize/

LoadStoreVectorizer.cpp

15 lines

LoopVectorize.cpp

21 lines

SLPVectorizer.cpp

65 lines

test/

Analysis/

BasicAA/

noalias-intr.ll

143 lines

ScopedNoAliasAA/

1 line

1 line

62 lines

161 lines

66 lines

113 lines

142 lines

64 lines

230 lines

noalias_phi_in_loop.ll

154 lines

noalias_recursive.ll

127 lines

noalias_select.ll

167 lines

Bitcode/

compatibility.ll

24 lines

loadstore_ptr_provenance.ll

44 lines

CodeGen/

Generic/

noalias.ll

13 lines

provenance.noalias.ll

15 lines

Other/

new-pm-defaults.ll

8 lines

new-pm-lto-defaults.ll

2 lines

new-pm-pgo-preinline.ll

2 lines

new-pm-thinlto-defaults.ll

8 lines

new-pm-thinlto-postlink-pgo-defaults.ll

8 lines

new-pm-thinlto-postlink-samplepgo-defaults.ll

8 lines

new-pm-thinlto-prelink-pgo-defaults.ll

10 lines

new-pm-thinlto-prelink-samplepgo-defaults.ll

8 lines

Transforms/

ConnectNoAliasDecl/

basictest.ll

179 lines

Coroutines/

coro-retcon-opaque-ptr.ll

5 lines

coro-retcon-resume-values.ll

37 lines

coro-retcon-value.ll

12 lines

coro-retcon.ll

8 lines

DeadArgElim/

noalias.ll

27 lines

EarlyCSE/

basic.ll

44 lines

FunctionAttrs/

nocapture.ll

40 lines

nonnull.ll

10 lines

Inline/

launder.invariant.group.ll

30 lines

noalias-calls-always.ll

41 lines

163 lines

4 lines

199 lines

218 lines

154 lines

234 lines

parallel-loop-md-merge.ll

20 lines

pr50589.ll

14 lines

InstCombine/

fold-phi-load-metadata.ll

4 lines

noalias.ll

49 lines

InstSimplify/

noalias.ll

172 lines

JumpThreading/

free_instructions.ll

2 lines

noalias-decl.ll

74 lines

noalias-scope-decl.ll

11 lines

LICM/

noalias.ll

140 lines

noalias02.ll

44 lines

LoopRotate/

noalias.ll

118 lines

noalias2.ll

206 lines

LoopUnroll/

noalias.ll

44 lines

noalias2.ll

196 lines

peel-loop-noalias-scope-decl.ll

2 lines

peel-loop-noalias-scope-decl2.ll

112 lines

LoopVectorize/

noalias.ll

92 lines

PhaseOrdering/

pr39282.ll

40 lines

PropagateAndConvertNoAlias/

153 lines

80 lines

112 lines

126 lines

69 lines

69 lines

47 lines

76 lines

208 lines

117 lines

SLPVectorizer/

noalias.ll

53 lines

SROA/

302 lines

463 lines

41 lines

56 lines

noalias_copy_guard.ll

358 lines

noalias_copy_guard2.ll

72 lines

Verifier/

unknown_provenance.ll

95 lines

tools/

UpdateTestChecks/

update_llc_test_checks/

Inputs/

nvptx-basic.ll.expected

16 lines

tools/

llvm-c-test/

echo.cpp

6 lines

unittests/

IR/

IRBuilderTest.cpp

207 lines

Full Restrict Support - single patchNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 440936

clang/include/clang/AST/Type.h

clang/include/clang/Basic/CodeGenOptions.def

clang/include/clang/Driver/Options.td

clang/lib/AST/Type.cpp

clang/lib/CodeGen/Address.h

clang/lib/CodeGen/CGCall.cpp

clang/lib/CodeGen/CGDecl.cpp

clang/lib/CodeGen/CGExpr.cpp

clang/lib/CodeGen/CGExprAgg.cpp

clang/lib/CodeGen/CGStmt.cpp

clang/lib/CodeGen/CMakeLists.txt

clang/lib/CodeGen/CodeGenFunction.h

clang/lib/CodeGen/CodeGenFunction.cpp

clang/lib/CodeGen/CodeGenModule.h

clang/lib/CodeGen/CodeGenModule.cpp

clang/lib/CodeGen/CodeGenNoAliasOffsets.h

clang/lib/CodeGen/CodeGenNoAliasOffsets.cpp

clang/lib/Driver/ToolChains/Clang.cpp

clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c

clang/test/CodeGen/X86/avx-builtins.c

clang/test/CodeGen/X86/avx2-builtins.c

clang/test/CodeGen/aarch64-ls64.c

clang/test/CodeGen/arm_neon_intrinsics.c

clang/test/CodeGen/restrict/arg_reuse.c

clang/test/CodeGen/restrict/array.c

clang/test/CodeGen/restrict/basic.c

clang/test/CodeGen/restrict/basic_opt_01.c

clang/test/CodeGen/restrict/basic_opt_02.c

clang/test/CodeGen/restrict/basic_opt_03.c

clang/test/CodeGen/restrict/basic_opt_04.c

clang/test/CodeGen/restrict/escape_through_volatile.c

clang/test/CodeGen/restrict/inlining_01.c

clang/test/CodeGen/restrict/inlining_02.c

clang/test/CodeGen/restrict/provenance.noalias_reduction_01.c

clang/test/CodeGen/restrict/struct.c

clang/test/CodeGen/restrict/struct_base_class_09.cpp

clang/test/CodeGen/restrict/struct_member_01.c

clang/test/CodeGen/restrict/struct_member_02.c

clang/test/CodeGen/restrict/struct_member_03.c

clang/test/CodeGen/restrict/struct_member_04.c

clang/test/CodeGen/restrict/struct_member_05.c

clang/test/CodeGen/restrict/struct_member_06.c

clang/test/CodeGen/restrict/struct_member_07.c

clang/test/CodeGen/restrict/struct_member_08.cpp

clang/test/CodeGenCUDA/builtins-amdgcn.cu

clang/test/Driver/full-restrict.c

clang/test/OpenMP/cancel_codegen.cpp

clang/test/OpenMP/cancellation_point_codegen.cpp

clang/test/OpenMP/debug-info-complex-byval.cpp

clang/test/OpenMP/debug-info-openmp-array.cpp

clang/test/OpenMP/distribute_parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/for_reduction_task_codegen.cpp

clang/test/OpenMP/master_taskloop_firstprivate_codegen.cpp

clang/test/OpenMP/master_taskloop_in_reduction_codegen.cpp

clang/test/OpenMP/master_taskloop_lastprivate_codegen.cpp

clang/test/OpenMP/master_taskloop_private_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_firstprivate_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_in_reduction_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_lastprivate_codegen.cpp

clang/test/OpenMP/master_taskloop_simd_private_codegen.cpp

clang/test/OpenMP/nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp

clang/test/OpenMP/parallel_codegen.cpp

clang/test/OpenMP/parallel_for_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_if_codegen_PR51349.cpp

clang/test/OpenMP/parallel_master_reduction_task_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_firstprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_private_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_firstprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_lastprivate_codegen.cpp

clang/test/OpenMP/parallel_master_taskloop_simd_private_codegen.cpp

Full Restrict Support - single patch
Needs ReviewPublic
Actions

Revision Contents
Changeset List