Page MenuHomePhabricator

penzn (Petr Penzin)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2019, 1:12 PM (184 w, 6 d)

Recent Activity

Sep 13 2022

penzn added a comment to D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

Yeah the unrelated test failures can be ignored. Good point about our shuffle combine workaround, @penzn. Would you have time and resources to investigate whether we can remove the workaround now?

Sep 13 2022, 4:04 PM · Restricted Project, Restricted Project
penzn accepted D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

Failed test is found on x64 windows, which seems to be related to mlir. Is there any action needed to fix the test?

Sep 13 2022, 9:28 AM · Restricted Project, Restricted Project

Sep 12 2022

penzn accepted D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

A stray thought: we have disabled combining shuffles because it was producing precisely the masks this change seeks to eliminate, I am wondering if we can reenable some of those optimization based on this.

Sep 12 2022, 5:37 PM · Restricted Project, Restricted Project

Sep 11 2022

penzn added a comment to D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

The code looks good, but I don't know much about native SIMD. Is this strictly better for engine-side codegen on all platforms? LGTM if so.

Sep 11 2022, 10:34 PM · Restricted Project, Restricted Project

Sep 8 2022

penzn added a comment to D133473: [WebAssembly] Improve codegen for shuffles with undefined lane indices.

To me this makes since this applies to undefined indices and should not make any difference in case of valid ones.

Sep 8 2022, 4:56 PM · Restricted Project, Restricted Project

Aug 2 2022

penzn abandoned D127323: Provide SimpleLoopUnswitch binding for legacy pass manager.

Implemented locally instead

Aug 2 2022, 2:43 PM · Restricted Project, Restricted Project

Jul 25 2022

penzn added a comment to D130053: [WebAssembly] Use `localexec` as default TLS model for non-Emscripten targets.

Because TLS data is stored a "passive" segment which has to be loaded using the memory.init instruction. (Both passive segments and this instruction are part of the bulk-memory proposal).

Jul 25 2022, 1:06 PM · Restricted Project, Restricted Project
penzn accepted D130053: [WebAssembly] Use `localexec` as default TLS model for non-Emscripten targets.

Oops, commented on outdated version (also had some issues with UI leaving repeated inline comments, sorry).

Jul 25 2022, 1:21 AM · Restricted Project, Restricted Project
penzn added a comment to D130053: [WebAssembly] Use `localexec` as default TLS model for non-Emscripten targets.
Jul 25 2022, 1:09 AM · Restricted Project, Restricted Project

Jul 19 2022

penzn added inline comments to D130053: [WebAssembly] Use `localexec` as default TLS model for non-Emscripten targets.
Jul 19 2022, 2:41 PM · Restricted Project, Restricted Project

Jul 12 2022

penzn added a comment to D129571: Build Windows releases with libxml enabled, to unbreak llvm-mt.

This change LGTM, can we also add some description of this process to developer docs? Anyone who would building LLVM on Windows is going to be hit by llvm-mt errors in current Visual Studio versions.

Jul 12 2022, 10:11 AM · Restricted Project, Restricted Project

Jun 8 2022

penzn requested review of D127323: Provide SimpleLoopUnswitch binding for legacy pass manager.
Jun 8 2022, 10:24 AM · Restricted Project, Restricted Project

Jun 6 2022

penzn accepted D126873: [OpenMP] Fix the build on Windows.

LGTM

Jun 6 2022, 5:43 PM · Restricted Project, Restricted Project
penzn abandoned D127160: Define OpenMP alloc macros before they are used.

Abandon in favor of D126873

Jun 6 2022, 5:43 PM · Restricted Project, Restricted Project
penzn added a reviewer for D127160: Define OpenMP alloc macros before they are used: JohnTitor.
Jun 6 2022, 3:39 PM · Restricted Project, Restricted Project
penzn requested review of D127160: Define OpenMP alloc macros before they are used.
Jun 6 2022, 3:38 PM · Restricted Project, Restricted Project

Jun 2 2022

penzn accepted D126923: llvm: cmake: set CMP0114 to OLD to avoid warning.

I am personally building with this change already, for extra peace of mind :)

Jun 2 2022, 2:47 PM · Restricted Project, Restricted Project

Nov 30 2021

penzn accepted D109481: [WebAssembly] Custom optimization for truncate.

Looks like the feedback is addressed and overall this is a needed optimization. @tlively what do you think?

Nov 30 2021, 10:56 AM · Restricted Project

May 4 2021

penzn added a comment to D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.

I think there is another dimension to this aside from project composition - intrinsics have a tendency to "interact" with their surroundings, and it better to capture the IR rather than the end result. Even if we can verify that simple calls produce instructions we expect, this might not hold true is the arguments change, or the call is in a different context. IR definitely gives more opportunities to test things through.

May 4 2021, 6:49 PM · Restricted Project, Restricted Project

Apr 23 2021

penzn added a comment to D100717: [InstCombine] Transform memcpy to ptr load/stores if TBAA says so.

I read through the code and I'm not sure if this is even a semantic change. I mean, can't we pick any
type to do the memory transfer expansion? If so, TBAA metadata as a heuristic should be totally fine.
We could also look at uses of the source and target pointers, for example. That said, we should write
in the lang ref that we do use the TBAA names for heuristics and they should be chosen to match the code/intent.

Apr 23 2021, 2:18 PM · Restricted Project
penzn added a comment to D101185: [LangRef] tbaa: type names can be used as hints to optimizations.

I am somewhat confused on performance vs correctness - D100717 refers to a miscompile, would adding this behavior also clear miscompiles?

Apr 23 2021, 12:41 PM · Restricted Project

Apr 22 2021

penzn accepted D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics.

Looks good to me.

Apr 22 2021, 5:25 PM · Restricted Project

Nov 2 2020

penzn abandoned D89919: [LLD] [COFF] Align Extended DLL Characteristics.

Abandoned in favor of D89921

Nov 2 2020, 12:43 PM · Restricted Project

Oct 30 2020

penzn added a comment to D89921: [LLD] [COFF] Align all debug directories.

I think it works. We can keep "less than 4" check or keep it as is.

Oct 30 2020, 4:31 PM · Restricted Project

Oct 27 2020

penzn added inline comments to D89921: [LLD] [COFF] Align all debug directories.
Oct 27 2020, 5:00 PM · Restricted Project

Oct 22 2020

penzn added inline comments to D89921: [LLD] [COFF] Align all debug directories.
Oct 22 2020, 8:31 PM · Restricted Project
penzn updated the diff for D89921: [LLD] [COFF] Align all debug directories.

Fix broken diff.

Oct 22 2020, 8:23 PM · Restricted Project
penzn added a comment to D89921: [LLD] [COFF] Align all debug directories.

Great, looks like I broke the diff.

Oct 22 2020, 8:17 PM · Restricted Project
penzn updated the diff for D89921: [LLD] [COFF] Align all debug directories.

Fix formatting in Writer.cpp.

Oct 22 2020, 8:16 PM · Restricted Project
penzn added a comment to D89921: [LLD] [COFF] Align all debug directories.

do we need to update some tests?

Oct 22 2020, 8:05 PM · Restricted Project

Oct 21 2020

penzn added a reviewer for D89919: [LLD] [COFF] Align Extended DLL Characteristics: vitalybuka.
Oct 21 2020, 7:21 PM · Restricted Project
penzn added a reviewer for D89921: [LLD] [COFF] Align all debug directories: vitalybuka.
Oct 21 2020, 7:21 PM · Restricted Project
penzn updated the summary of D89921: [LLD] [COFF] Align all debug directories.
Oct 21 2020, 7:19 PM · Restricted Project
penzn updated the summary of D89919: [LLD] [COFF] Align Extended DLL Characteristics.
Oct 21 2020, 7:18 PM · Restricted Project
penzn requested review of D89921: [LLD] [COFF] Align all debug directories.
Oct 21 2020, 7:16 PM · Restricted Project
penzn requested review of D89919: [LLD] [COFF] Align Extended DLL Characteristics.
Oct 21 2020, 6:28 PM · Restricted Project

Mar 13 2020

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

I had to edit the comment above, looks like I took snapshot from directory when I was reproducing build instructions, instead of actual test directory. Now the exe and base64 encoding above (in the gist as well) are correct and the test should pass.

Mar 13 2020, 2:01 PM · Restricted Project, lld

Mar 12 2020

penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Formatting; also instructions on building test image.

Mar 12 2020, 7:04 PM · Restricted Project, lld

Mar 4 2020

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Another minor edit, I moved COFF test files for llvm-readobj to the directory where the rest of them are now.

Mar 4 2020, 9:45 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Use write32le to set extended DLL characteristics.

Mar 4 2020, 9:45 PM · Restricted Project, lld

Mar 3 2020

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

I've started the discussion on the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2020-March/139706.html

Mar 3 2020, 7:37 PM · Restricted Project, lld

Feb 12 2020

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Expanding on my previous comment. In its current state yaml2obj is not aware of the section contents, and I think adding this functionality would be a bit more involved than the code we have in this review so far.

Feb 12 2020, 2:24 PM · Restricted Project, lld

Jan 29 2020

penzn updated the summary of D70606: LLD: CET shadow stack support on Windows.
Jan 29 2020, 2:08 PM · Restricted Project, lld
penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

@ruiu can we separate enhancing yaml2obj from this change? I would be more than happy to help with implementing debug directory support as a separate change, to avoid making this change much more involved.

Jan 29 2020, 1:59 PM · Restricted Project, lld

Jan 3 2020

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

yaml2obj is capable of producing binary .rdata section (which would host CET bit) from hex, but not individual debug directories that would go into it. Looks like all the tests dealing wit debug directories are using pre-built binaries - codeview tests are a good example).

Jan 3 2020, 4:47 PM · Restricted Project, lld

Dec 11 2019

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Could you tell me about how you generated has_cet.exe? I wonder if there's a way to create an executable in the test instead of submitting a binary file to the repository.

Dec 11 2019, 10:04 AM · Restricted Project, lld

Dec 3 2019

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Can you help me merge this? I don't have commit access.

Dec 3 2019, 1:58 PM · Restricted Project, lld

Nov 27 2019

penzn added a comment to D70606: LLD: CET shadow stack support on Windows.

Thank you!

Nov 27 2019, 4:35 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Incorporate review feedback

Nov 27 2019, 4:26 PM · Restricted Project, lld

Nov 26 2019

penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 26 2019, 1:44 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Remove unused MinGW flag

Nov 26 2019, 12:43 PM · Restricted Project, lld

Nov 25 2019

penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 25 2019, 6:10 PM · Restricted Project, lld

Nov 22 2019

penzn added inline comments to D70606: LLD: CET shadow stack support on Windows.
Nov 22 2019, 2:43 PM · Restricted Project, lld
penzn updated the diff for D70606: LLD: CET shadow stack support on Windows.

Full(er) patch for the same change.

Nov 22 2019, 2:06 PM · Restricted Project, lld
penzn created D70606: LLD: CET shadow stack support on Windows.
Nov 22 2019, 10:43 AM · Restricted Project, lld

May 23 2019

penzn added inline comments to D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes..
May 23 2019, 10:38 AM · Restricted Project, Restricted Project

May 22 2019

penzn added inline comments to D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes..
May 22 2019, 1:31 PM · Restricted Project, Restricted Project