Page MenuHomePhabricator
People jsji

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (235 w, 13 h)

Recent Activity
View All

Thu, Jun 2

jsji resigned from D65094: [PowerPC] Combine address computation to favour selecting DForm instructions.
Thu, Jun 2, 8:00 AM · Restricted Project, Restricted Project
jsji resigned from D58378: [PowerPC]Leverage the addend in the TOC relocation to do the address calculation.
Thu, Jun 2, 8:00 AM · Restricted Project, Unknown Object (Project), Restricted Project
jsji resigned from D67694: [Power9] Fix the missing pseudo instruction scheduling information for power9.
Thu, Jun 2, 8:00 AM · Restricted Project, Restricted Project
jsji resigned from D105617: [PowerPC] Fix addi-load bias scheduling heuristics.
Thu, Jun 2, 7:59 AM · Restricted Project, Restricted Project
jsji resigned from D75895: [PowerPC] Select the select_cc for f64/f32 as set_cc + vselect if VSX enabled.
Thu, Jun 2, 7:59 AM · Restricted Project, Restricted Project
jsji resigned from D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf.
Thu, Jun 2, 7:59 AM · Restricted Project, Restricted Project
jsji resigned from D117181: [PowerPC] Use IEEE long double in proper toolchain.
Thu, Jun 2, 7:59 AM · Restricted Project, Restricted Project
jsji resigned from D109751: [Clang] Support conversion between PPC double-double and IEEE float128.
Thu, Jun 2, 7:57 AM · Restricted Project, Restricted Project
jsji resigned from D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality.
Thu, Jun 2, 7:56 AM · Restricted Project, Restricted Project
jsji resigned from D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases..
Thu, Jun 2, 7:56 AM · Restricted Project, Restricted Project
jsji resigned from D122198: [PowerPC] Add .ref in backend for AIX XCOFF to support `-bcdtors:csect` linker option.
Thu, Jun 2, 7:52 AM · Restricted Project, Restricted Project
jsji resigned from D123366: [PowerPC] map hardware loop intrinsics to PowerPC pseudo instructions..
Thu, Jun 2, 7:52 AM · Restricted Project, Restricted Project
jsji resigned from D120980: [PowerPC] make splat struct like an array for function arguments.
Thu, Jun 2, 7:52 AM · Restricted Project, Restricted Project
jsji resigned from D107886: [PowerPC] Support huge frame size for PPC64.
Thu, Jun 2, 7:52 AM · Restricted Project, Restricted Project
jsji resigned from D122125: [PowerPC] generate CTR loops instructions after ISEL.
Thu, Jun 2, 7:51 AM · Restricted Project, Restricted Project
jsji resigned from D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option.
Thu, Jun 2, 7:51 AM · Restricted Project, Restricted Project, Restricted Project
jsji resigned from D114419: [XCOFF] change default program code csect alignment to 32.
Thu, Jun 2, 7:51 AM · Restricted Project, Restricted Project
jsji resigned from D92156: [PowerPC] Add support for "tlbiel" with two arguments.
Thu, Jun 2, 7:50 AM · Restricted Project, Restricted Project
jsji resigned from D116092: [XCOFF] make sure same number of paddings are added.
Thu, Jun 2, 7:50 AM · Restricted Project, Restricted Project
jsji resigned from D120113: [PowerPC] Improve i32 and-or-and on BPS.Select64 path to generate single rlwimi.
Thu, Jun 2, 7:50 AM · Restricted Project, Restricted Project
jsji resigned from D120942: [PowerPC] Add support for the canonical version of tlbie.
Thu, Jun 2, 7:50 AM · Restricted Project, Restricted Project
jsji resigned from D116016: [Clang] [PowerPC] Emit module flag for current float abi.
Thu, Jun 2, 7:49 AM · Restricted Project, Restricted Project
jsji resigned from D94467: [PowerPC] Use rldimi/rlwimi instructions to optimize build_vector.
Thu, Jun 2, 7:49 AM · Restricted Project, Restricted Project
jsji resigned from D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Thu, Jun 2, 7:48 AM · Restricted Project, Restricted Project
jsji resigned from D109302: [PowerPC] Check subregister defines before removing XXMFACC/XXMTACC.
Thu, Jun 2, 7:48 AM · Restricted Project, Restricted Project
jsji resigned from D108902: [PowerPC] Enable track-subreg-liveness by default.
Thu, Jun 2, 7:48 AM · Restricted Project, Restricted Project
jsji resigned from D91053: [PowerPC] Lump the constants to save one addis for each constant access.
Thu, Jun 2, 7:48 AM · Restricted Project, Restricted Project
jsji resigned from D97455: [PowerPC][AIX] Enable moving stack update for AIX.
Thu, Jun 2, 7:47 AM · Restricted Project, Restricted Project
jsji resigned from D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Thu, Jun 2, 7:47 AM · Restricted Project, Restricted Project
jsji resigned from D93894: [PowerPC] Expand BitPermutation to handle cases of the single immediate 'and'..
Thu, Jun 2, 7:46 AM · Restricted Project, Restricted Project
jsji resigned from D94211: [NFC][PowerPC] Format and clean the logic for setOperationActions to make it easier to maintain.
Thu, Jun 2, 7:43 AM · Restricted Project, Restricted Project
jsji resigned from D71287: [PowerPC] Use fcti[dw] instructions in additional cases.
Thu, Jun 2, 7:43 AM · Restricted Project, Restricted Project
jsji resigned from D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..
Thu, Jun 2, 7:43 AM · Restricted Project, Restricted Project
jsji resigned from D83466: [PowerPC] Exploit type-J min/max for maximum/minimum intrinsic.
Thu, Jun 2, 7:42 AM · Restricted Project, Restricted Project
jsji resigned from D61250: [PowerPC] Forward the scheduling state for PowerPC target.
Thu, Jun 2, 7:42 AM · Restricted Project, Unknown Object (Project), Restricted Project
jsji removed a reviewer for D62261: [PowerPC][NFC] Add test for comparison between two virtual registers: jsji.
Thu, Jun 2, 7:41 AM · Restricted Project, Restricted Project

May 11 2022

jsji accepted D125386: [clang][ppc] Creating Seperate Install Target for PPC htm Headers.

LGTM

May 11 2022, 6:52 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 3 2022

jsji accepted D124857: [AIX][PGO] Enable linux style PGO on AIX.

LGTM. Thanks.

May 3 2022, 9:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jsji added inline comments to D124857: [AIX][PGO] Enable linux style PGO on AIX.
May 3 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jsji added reviewers for D124857: [AIX][PGO] Enable linux style PGO on AIX: MaskRay, Restricted Project.
May 3 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

jsji added a comment to D124267: [MachinePipeliner] Fix unscheduled instruction.
In D124267#3468434, @thopre wrote:

Adding @jsji to review the changes to PowerPC testcases. I've checked the MIR after the pipeliner for sms-phi-3.ll and the loop still gets pipelined (which makes sense since the modified code executes after the decision to pipeline is made) but the code gets simplified by later pass. Are you happy with the change?

Apr 26 2022, 8:00 AM · Restricted Project, Restricted Project
jsji added inline comments to D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC..
Apr 26 2022, 6:49 AM · Restricted Project, Restricted Project
jsji accepted D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC..

LGTM. Thanks.

Apr 26 2022, 6:36 AM · Restricted Project, Restricted Project

Apr 21 2022

jsji accepted D124046: [AIX] Always pass namedsects option when linking with PGO..

LGTM. Thanks.

Apr 21 2022, 5:38 AM · Restricted Project, Restricted Project

Apr 19 2022

jsji accepted D123372: [PowerPC] add XLC compat builtin __abs.

LGTM. Thanks.

Apr 19 2022, 8:46 PM · Restricted Project, Restricted Project

Apr 11 2022

jsji added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

@qiongsiwu1 Please also add reviewers from other targets. Thanks.

Apr 11 2022, 6:48 AM · Restricted Project, Restricted Project

Apr 1 2022

jsji accepted D122949: [AIX] XFAIL tests because of no big archive writer operation support.

LGTM. Thanks Jake.

Apr 1 2022, 6:40 PM · Restricted Project, Restricted Project
jsji accepted D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation .

LGTM. Thanks @DiggerLin !

Apr 1 2022, 6:41 AM · Restricted Project, Restricted Project

Mar 31 2022

jsji committed rG81f5c6270cdf: [compiler-rt] Implement __clear_cache on FreeBSD/powerpc (authored by carenas).
[compiler-rt] Implement __clear_cache on FreeBSD/powerpc
Mar 31 2022, 7:20 AM · Restricted Project, Restricted Project
jsji closed D122640: [compiler-rt] Implement __clear_cache on FreeBSD/powerpc.
Mar 31 2022, 7:20 AM · Restricted Project, Restricted Project

Mar 28 2022

jsji added a reviewer for D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend: qiucf.
Mar 28 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

jsji added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Mar 24 2022, 8:45 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

jsji accepted D122012: [PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation..

LGTM as long as we have followup patch to prevent similar things happen again. Thanks.

Mar 21 2022, 12:12 PM · Restricted Project, Restricted Project

Mar 18 2022

jsji added inline comments to D122012: [PowerPC] The BL8_NOTOC_RM instruction needs to produce a notoc relocation..
Mar 18 2022, 9:51 AM · Restricted Project, Restricted Project

Mar 16 2022

jsji accepted D120865: [AtomicExpand][PowerPC] Fix all-one mask value.

LGTM. Thanks.

Mar 16 2022, 7:31 PM · Restricted Project, Restricted Project

Mar 15 2022

jsji accepted D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc.

LGTM. Thanks.

Mar 15 2022, 1:41 PM · Restricted Project, Restricted Project

Mar 13 2022

jsji accepted D121082: [PowerPC] Disable perfect shuffle by default.

Please also mention the attempt to avoid perfect shuffle when mask has multiple uses in https://reviews.llvm.org/D116801.

Mar 13 2022, 8:00 PM · Restricted Project, Restricted Project

Mar 11 2022

jsji accepted D121257: [lsan] ppc64: dynamically pick address range for allocator.

LGTM, asan also uses dynamic allocation, so the performance impact should be acceptable.

Mar 11 2022, 7:35 PM · Restricted Project, Restricted Project
jsji added a comment to D121082: [PowerPC] Disable perfect shuffle by default.

Can you please add some comments about why it is bad for vector loops? And some general description about the performance test results with this turned off?

Mar 11 2022, 6:43 AM · Restricted Project, Restricted Project

Mar 8 2022

jsji added inline comments to D121016: [PowerPC] Fix the none tail call in scalar MASS conversion.
Mar 8 2022, 8:09 AM · Unknown Object (Project), Restricted Project, Restricted Project

Mar 7 2022

jsji added inline comments to D121016: [PowerPC] Fix the none tail call in scalar MASS conversion.
Mar 7 2022, 6:54 PM · Unknown Object (Project), Restricted Project, Restricted Project
jsji added a reviewer for D121016: [PowerPC] Fix the none tail call in scalar MASS conversion: Restricted Project.
Mar 7 2022, 11:23 AM · Unknown Object (Project), Restricted Project, Restricted Project
jsji committed rG706e37c8e0e3: [libc++][AIX][test] Enable put_double/long_double locale tests (authored by jsji).
[libc++][AIX][test] Enable put_double/long_double locale tests
Mar 7 2022, 11:21 AM · Restricted Project
jsji closed D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.
Mar 7 2022, 11:21 AM · Restricted Project, Restricted Project
jsji added a comment to D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.
In D120448#3364570, @Mordante wrote:

LGTM, please wait for libc++ approval before landing this patch.

Mar 7 2022, 10:28 AM · Restricted Project, Restricted Project
jsji accepted D121081: [libcxx][AIX] Remove `LIBCXX-AIX-FIXME` in isalwayslockfree check after 86478c7ad8a7.

LGTM. Thanks.

Mar 7 2022, 6:47 AM · Restricted Project, Restricted Project
jsji accepted D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC.

LGTM. Thanks!

Mar 7 2022, 6:43 AM · Restricted Project, Restricted Project

Mar 4 2022

jsji abandoned D120162: [libcxx][test] Test visibility option before using it.

Yes, AIX clang hasn't supported visibility yet, we simply ignore all the visibility for now.

Mar 4 2022, 11:34 AM · Restricted Project, Restricted Project
jsji updated the diff for D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.

Rebased and address comments.

Mar 4 2022, 8:34 AM · Restricted Project, Restricted Project

Mar 3 2022

jsji added reviewers for D120942: [PowerPC] Add support for the canonical version of tlbie: shchenz, Restricted Project.
Mar 3 2022, 7:30 PM · Restricted Project, Restricted Project
jsji updated the summary of D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.
Mar 3 2022, 3:12 PM · Restricted Project, Restricted Project
jsji updated the diff for D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.

Address comments.

Mar 3 2022, 10:44 AM · Restricted Project, Restricted Project
jsji accepted D120907: [docs] Add PowerPC release notes for LLVM 14.

LGTM.

Mar 3 2022, 7:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

jsji added a comment to D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.

put_double.pass.cpp was already fixed (test removed) in https://reviews.llvm.org/D120022.

Mar 2 2022, 8:21 AM · Restricted Project, Restricted Project
jsji added a reviewer for D120448: [libc++][AIX][test] Enable put_double/long_double locale tests: mstorsjo.
Mar 2 2022, 8:21 AM · Restricted Project, Restricted Project
jsji updated the diff for D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.

Address comments.

Mar 2 2022, 8:19 AM · Restricted Project, Restricted Project

Mar 1 2022

jsji added inline comments to D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.
Mar 1 2022, 1:21 PM · Restricted Project, Restricted Project

Feb 28 2022

jsji added inline comments to D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC.
Feb 28 2022, 10:28 AM · Restricted Project, Restricted Project
jsji added a comment to D120162: [libcxx][test] Test visibility option before using it.

gentle ping...

Feb 28 2022, 7:48 AM · Restricted Project, Restricted Project

Feb 25 2022

jsji accepted D119309: [Driver][test] Clean up some AIX tests.

LGTM. Thanks for cleaning up.
BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc might get attention from wider group.

Feb 25 2022, 4:56 PM · Restricted Project
jsji edited reviewers for D119309: [Driver][test] Clean up some AIX tests, added: Restricted Project; removed: jasonliu, Xiangling_L.
Feb 25 2022, 4:55 PM · Restricted Project
jsji accepted D120534: [AIX][cmake][NFC] Customize name of output atomic library.

LGTM. Thanks.

Feb 25 2022, 5:29 AM · Restricted Project

Feb 23 2022

jsji requested review of D120448: [libc++][AIX][test] Enable put_double/long_double locale tests.
Feb 23 2022, 7:01 PM · Restricted Project, Restricted Project
jsji committed rG9bd9cbfa2f7b: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr (authored by jsji).
[libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr
Feb 23 2022, 11:23 AM
jsji closed D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr.
Feb 23 2022, 11:23 AM · Restricted Project
jsji added a comment to D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr.

Thank you so much Nikolas! @philnik

Feb 23 2022, 10:41 AM · Restricted Project
jsji added a comment to D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr.

Ping.. Can someone in libc++ group help to have a quick look? This only affect AIX test. Thank you so much!

Feb 23 2022, 10:00 AM · Restricted Project

Feb 18 2022

jsji accepted D120072: [PowerPC] Add option to disable perfect shuffle.

LGTM. Thanks.

Feb 18 2022, 8:30 PM · Restricted Project
jsji requested review of D120162: [libcxx][test] Test visibility option before using it.
Feb 18 2022, 1:28 PM · Restricted Project, Restricted Project

Feb 16 2022

jsji added inline comments to D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr.
Feb 16 2022, 8:35 AM · Restricted Project
jsji requested review of D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr.
Feb 16 2022, 8:20 AM · Restricted Project

Feb 15 2022

jsji closed D119035: [PowerPC] Option controling scalar MASS convertion.

This was committed in https://reviews.llvm.org/rG8ce13bc93be423d2a368f804ed18edf21b489c2e

Feb 15 2022, 10:49 AM · Restricted Project

Feb 8 2022

jsji accepted D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

but they can be disabled by defining LIBC_NO_CPP_MATH_OVERLOADS

Feb 8 2022, 10:48 AM · Restricted Project, Restricted Project
jsji added a comment to D102172: [libc++][AIX] Use C++ overloads from libc++'s math.h.

@daltenty Can you please update the patch to include more *Context*, looks like the Context not available. Or use arc to update it. Thanks.

Feb 8 2022, 7:50 AM · Restricted Project, Restricted Project

Jan 26 2022

jsji accepted D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC.

LGTM.

Jan 26 2022, 5:28 AM · Restricted Project

Jan 25 2022

jsji added a comment to D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC.
In D118110#3269450, @nemanjai wrote:

It is probably not worth the effort since there won't be that many test cases that test the front end's IR generation for long double, but there should be a way to set up lit to know the default through its configuration files.

Jan 25 2022, 8:39 AM · Restricted Project

Jan 24 2022

jsji added a comment to D117181: [PowerPC] Use IEEE long double in proper toolchain.

Besides, would it be acceptable that we add a variable to cmake to determine default long double semantics (like current GCC)?

Jan 24 2022, 7:04 AM · Restricted Project, Restricted Project

Jan 21 2022

jsji added a comment to D117181: [PowerPC] Use IEEE long double in proper toolchain.

Won't that end up producing a warning on ALL code built on any Linux distro with a GCC toolchain older than 12.1? That would be terrible.

Jan 21 2022, 12:40 PM · Restricted Project, Restricted Project
jsji accepted D117193: [PowerPC] Emit gnu_attribute according to float-abi metadata.

LGTM with some nits.

Jan 21 2022, 12:04 PM · Restricted Project
jsji accepted D115854: [PowerPC] Support parsing GNU attributes in MC.

LGTM. Thanks for adding this feature.

Jan 21 2022, 11:20 AM · Restricted Project