Page MenuHomePhabricator

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (143 w, 4 d)

Recent Activity

Thu, Sep 24

jsji updated the diff for D88044: [llvm-exegesis][PowerPC] Add more register classes.

Address comments.

Thu, Sep 24, 2:23 PM · Restricted Project
jsji added inline comments to D88044: [llvm-exegesis][PowerPC] Add more register classes.
Thu, Sep 24, 11:54 AM · Restricted Project
jsji committed rG29ec5901c9c5: [llvm-exegesis] Add whitespace between words in error message (authored by jsji).
[llvm-exegesis] Add whitespace between words in error message
Thu, Sep 24, 11:23 AM

Wed, Sep 23

jsji updated the diff for D88044: [llvm-exegesis][PowerPC] Add more register classes.

Fix typo in header.

Wed, Sep 23, 6:38 AM · Restricted Project
jsji added inline comments to D88044: [llvm-exegesis][PowerPC] Add more register classes.
Wed, Sep 23, 6:08 AM · Restricted Project
jsji added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Hi @jsji An infinite loop will occur if we handle the scenario 1 (mul X, c2 << c1) -> (mul (shl X, c1), c2) in DAGCombiner, because there exists a reverse conversion (mul (shl X, c1), c2) -> (mul X, c2 << c1).

Wed, Sep 23, 6:06 AM · Restricted Project

Tue, Sep 22

jsji retitled D87850: [ConstantFold] Fold the comparison of bitcasted global values from Fold the comparison of bitcasted global values to [ConstantFold] Fold the comparison of bitcasted global values .
Tue, Sep 22, 1:43 PM · Restricted Project
jsji added reviewers for D87850: [ConstantFold] Fold the comparison of bitcasted global values : hfinkel, eli.friedman, spatel.
Tue, Sep 22, 1:42 PM · Restricted Project
jsji added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

I think we already have similar pattern for scenario 1 as well:

// Change (mul (shl X, C), Y) -> (shl (mul X, Y), C) when the shift has one
// use.
Tue, Sep 22, 11:45 AM · Restricted Project

Mon, Sep 21

jsji updated the summary of D88044: [llvm-exegesis][PowerPC] Add more register classes.
Mon, Sep 21, 1:51 PM · Restricted Project
jsji requested review of D88044: [llvm-exegesis][PowerPC] Add more register classes.
Mon, Sep 21, 1:50 PM · Restricted Project

Thu, Sep 17

jsji added a comment to D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

Why this can NOT be done in DAGCombiner by implementing decomposeMulByConstant target hook?

Thu, Sep 17, 11:27 AM · Restricted Project
jsji committed rG50f1d4517ae4: [PowerPC][AIX] Don't hardcode python invoke command line (authored by jsji).
[PowerPC][AIX] Don't hardcode python invoke command line
Thu, Sep 17, 10:48 AM

Wed, Sep 9

jsji accepted D86865: [Power10] Enable the heuristic for Power10 and switch the sched model with P9 Model.

LGTM. Thanks.

Wed, Sep 9, 7:06 AM · Restricted Project
jsji committed rG818cf30b8330: [MachinePipeliner] Fix II_setByPragma initialization (authored by alonkom).
[MachinePipeliner] Fix II_setByPragma initialization
Wed, Sep 9, 6:39 AM
jsji closed D87088: [MachinePipeliner] Fix II_setByPragma initialization.
Wed, Sep 9, 6:38 AM · Restricted Project

Wed, Sep 2

jsji committed rG0cefaec2e876: [compiler-rt] Don't build llvm-lit in RUNTIMES-BUILD (authored by jsji).
[compiler-rt] Don't build llvm-lit in RUNTIMES-BUILD
Wed, Sep 2, 6:08 PM
jsji closed D87002: [compiler-rt] Don't build llvm-lit in RUNTIMES-BUILD.
Wed, Sep 2, 6:08 PM · Restricted Project
jsji updated the diff for D87002: [compiler-rt] Don't build llvm-lit in RUNTIMES-BUILD.

Move up the condition to avoid unecessary warning about LLVM_EXTERNAL_LIT.

Wed, Sep 2, 2:13 PM · Restricted Project

Tue, Sep 1

jsji requested review of D87002: [compiler-rt] Don't build llvm-lit in RUNTIMES-BUILD.
Tue, Sep 1, 9:28 PM · Restricted Project

Aug 28 2020

jsji added a comment to D86689: [DAGCombine] Don't delete the node if it has uses immediately.

Commit on behalf of @steven.zhang to unblock internal build first..

Aug 28 2020, 9:15 AM · Restricted Project
jsji committed rGdeb4b2580715: [DAGCombine] Don't delete the node if it has uses immediately (authored by steven.zhang).
[DAGCombine] Don't delete the node if it has uses immediately
Aug 28 2020, 9:14 AM
jsji closed D86689: [DAGCombine] Don't delete the node if it has uses immediately.
Aug 28 2020, 9:14 AM · Restricted Project

Jul 30 2020

jsji added a comment to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.

Hi @cebowleratibm, it seems test is located in wrong place: test/CodeGen/PowerPC instead of llvm/test/CodeGen/PowerPC.

Jul 30 2020, 7:30 AM · Restricted Project
jsji committed rGdab8d6104bd7: [PowerPC][AIX] Move the testcase to proper dir (authored by jsji).
[PowerPC][AIX] Move the testcase to proper dir
Jul 30 2020, 7:26 AM
jsji added inline comments to D84308: [PowerPC] Retrieve the offset from load/store if it stores to stack slots .
Jul 30 2020, 6:55 AM · Restricted Project

Jul 29 2020

jsji added a reviewer for D84764: Fix computeHostNumPhysicalCores() for Linux on POWER and Linux on Z: uweigand.

LoZ.

Jul 29 2020, 7:49 AM · Restricted Project

Jul 28 2020

jsji accepted D84308: [PowerPC] Retrieve the offset from load/store if it stores to stack slots .

LGTM, but please update the testcases carefully, especially regarding DAG. -- Unnecessary DAG will hide bugs .

Jul 28 2020, 2:16 PM · Restricted Project
jsji added inline comments to D81360: [PowerPC] Fix RM operands for some instructions.
Jul 28 2020, 11:45 AM · Restricted Project
jsji accepted D81360: [PowerPC] Fix RM operands for some instructions.

LGTM. Thanks.

Jul 28 2020, 11:43 AM · Restricted Project
jsji added a reverting change for rGbf544fa1c3cb: Revert "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support": rGd28f86723f37: Re-land "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support".
Jul 28 2020, 7:01 AM
jsji committed rGd28f86723f37: Re-land "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support" (authored by jsji).
Re-land "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support"
Jul 28 2020, 7:01 AM

Jul 27 2020

jsji committed rGbf544fa1c3cb: Revert "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support" (authored by jsji).
Revert "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support"
Jul 27 2020, 2:07 PM
jsji added a reverting change for rGadffce71538e: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support: rGbf544fa1c3cb: Revert "[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support".
Jul 27 2020, 2:07 PM
jsji committed rGadffce71538e: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support (authored by jsji).
[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support
Jul 27 2020, 12:26 PM
jsji closed D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Jul 27 2020, 12:26 PM · Restricted Project, Restricted Project, Restricted Project

Jul 24 2020

jsji committed rG3554cf4f382c: [compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++ (authored by jsji).
[compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++
Jul 24 2020, 2:05 PM
jsji closed D84543: [compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++.
Jul 24 2020, 2:05 PM · Restricted Project
jsji retitled D84543: [compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++ from [compiler-rt][profile][CMake] Remove unused -stdlib when passing -nostdinc++ to [compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++.
Jul 24 2020, 12:37 PM · Restricted Project
jsji added a reviewer for D84543: [compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++: phosek.
Jul 24 2020, 12:37 PM · Restricted Project
Herald added a project to D84543: [compiler-rt][CMake] Remove unused -stdlib when passing -nostdinc++: Restricted Project.
Jul 24 2020, 12:28 PM · Restricted Project

Jul 23 2020

jsji added a comment to D81360: [PowerPC] Fix RM operands for some instructions.

Please also add tests for mtfsb0 etc.

Jul 23 2020, 1:53 PM · Restricted Project
jsji updated the summary of D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Jul 23 2020, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
jsji updated the diff for D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.

Add a few missing files.

Jul 23 2020, 12:44 PM · Restricted Project, Restricted Project, Restricted Project
jsji updated the diff for D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.

Updated testcases, and also remove CNK support from openmp/polly.

Jul 23 2020, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
jsji added a comment to D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.

Ping ... Any other comments? Thanks.

Jul 23 2020, 6:51 AM · Restricted Project, Restricted Project, Restricted Project

Jul 21 2020

jsji accepted D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.

LGTM with some nits.

Jul 21 2020, 8:16 PM · Restricted Project
jsji accepted D84218: [PowerPC] Fix wrong codegen when stack pointer has to realign in prologue.

LGTM.

Jul 21 2020, 7:07 AM · Restricted Project

Jul 20 2020

jsji added a comment to D84152: [PowerPC] Fix wrong codegen when stack pointer has to realign performing dynalloc.

@lkail Can we split HasBP && MaxAlign > 1 situation into another patch? Thanks.

Jul 20 2020, 7:20 AM · Restricted Project
jsji accepted D82390: [PowerPC] Fix the implicit operands in PPCInstrInfo::PredicateInstruction().
Jul 20 2020, 7:09 AM · Restricted Project
jsji accepted D82390: [PowerPC] Fix the implicit operands in PPCInstrInfo::PredicateInstruction().

LGTM. Please wait a few days in case @efriedma has other comments.

Jul 20 2020, 7:09 AM · Restricted Project
jsji added a comment to D81360: [PowerPC] Fix RM operands for some instructions.

Please add more tests for affected opcodes, not just SETRND. Thanks.

Jul 20 2020, 6:56 AM · Restricted Project

Jul 19 2020

jsji updated subscribers of D81360: [PowerPC] Fix RM operands for some instructions.

Looks like some duplicate work in D83471, can you please sync with @qiucf , and either split the statics out or merge two patches.

Jul 19 2020, 7:56 PM · Restricted Project
jsji accepted D82341: [PowerPC] add store (load float*) pattern to isProfitableToHoist.

LGTM.

Jul 19 2020, 7:52 PM · Restricted Project

Jul 17 2020

jsji requested changes to D82390: [PowerPC] Fix the implicit operands in PPCInstrInfo::PredicateInstruction().

Agree with Eli in general. Although this is the code making that change , current condition code `if (MI.getOpcode() != OpC) ` to fix the reg is too general .
We should only fix it when there is real needs.

Jul 17 2020, 12:14 PM · Restricted Project
jsji requested changes to D71983: [PowerPC] Set the SideEffects of branch & call instructions from 1 to 0.

Set it back , please update with testcases.

Jul 17 2020, 11:59 AM · Restricted Project
jsji requested changes to D83471: [PowerPC] Don't set use to RM for static rounding instructions.

Looks mostly good to me. But please add MIR tests for these.

Jul 17 2020, 11:56 AM · Restricted Project
jsji requested changes to D81360: [PowerPC] Fix RM operands for some instructions.

Please rebase. Also why this depends on D76042?

Jul 17 2020, 11:41 AM · Restricted Project
jsji accepted D76042: [PowerPC] Remove the redundant implicit operands in ppc-early-ret pass.

LGTM. But please update the summary and description to reflect the actual patch -- it is no longer about adding the RM, but removing the redundant implicit operands in ppc-early-ret pass.

Jul 17 2020, 11:36 AM · Restricted Project
jsji added a comment to D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.

Should we indicate planned removal in the Release Notes for version 11 and actual removal in those for version 12?

Good suggestion. https://reviews.llvm.org/D83968 for adding the section in master, will add conent in v11 branch if approved.

Jul 17 2020, 9:02 AM · Restricted Project, Restricted Project, Restricted Project
jsji closed D83968: [docs] Add Deprecated section to ReleaseNotes.
Jul 17 2020, 9:01 AM · Restricted Project
jsji added a comment to D83968: [docs] Add Deprecated section to ReleaseNotes.

Committed to release/11.x in https://reviews.llvm.org/rG297be788a797c0ab98d9677f50e3dc57faab363b

Jul 17 2020, 9:00 AM · Restricted Project
jsji committed rG297be788a797: [docs] Add Deprecated section to ReleaseNotes (authored by jsji).
[docs] Add Deprecated section to ReleaseNotes
Jul 17 2020, 8:49 AM
jsji added inline comments to D82341: [PowerPC] add store (load float*) pattern to isProfitableToHoist.
Jul 17 2020, 8:21 AM · Restricted Project
jsji updated the diff for D83968: [docs] Add Deprecated section to ReleaseNotes.

Update per comments.

Jul 17 2020, 7:01 AM · Restricted Project

Jul 16 2020

jsji updated the summary of D83968: [docs] Add Deprecated section to ReleaseNotes.
Jul 16 2020, 12:07 PM · Restricted Project
jsji added a comment to D83968: [docs] Add Deprecated section to ReleaseNotes.

Thanks @hans ! I have updated it to be in release/11.x only.

Jul 16 2020, 12:04 PM · Restricted Project
jsji updated the diff for D83968: [docs] Add Deprecated section to ReleaseNotes.

This will be committed to v11 branch.

Jul 16 2020, 12:03 PM · Restricted Project
Herald added a reviewer for D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support: sstefan1.
Jul 16 2020, 11:09 AM · Restricted Project, Restricted Project, Restricted Project
jsji added reviewers for D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support: jhibbits, echristo.
Jul 16 2020, 11:09 AM · Restricted Project, Restricted Project, Restricted Project
jsji added a comment to D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.

Should we indicate planned removal in the Release Notes for version 11 and actual removal in those for version 12?

Jul 16 2020, 10:38 AM · Restricted Project, Restricted Project, Restricted Project
jsji added reviewers for D83968: [docs] Add Deprecated section to ReleaseNotes: hans, hfinkel, hubert.reinterpretcast.
Jul 16 2020, 10:37 AM · Restricted Project
Herald added a project to D83968: [docs] Add Deprecated section to ReleaseNotes: Restricted Project.
Jul 16 2020, 10:37 AM · Restricted Project
jsji committed rG32d36d9edce2: [docs] fix ident in llvm-exegesis.rst (authored by jsji).
[docs] fix ident in llvm-exegesis.rst
Jul 16 2020, 10:30 AM
jsji committed rG971dd3f15096: [docs][lldb] Fix lldb item in releasenotes (authored by jsji).
[docs][lldb] Fix lldb item in releasenotes
Jul 16 2020, 10:08 AM
jsji closed D83962: [docs][lldb] Fix lldb item in releasenotes.
Jul 16 2020, 10:08 AM · Restricted Project
Herald added a project to D83962: [docs][lldb] Fix lldb item in releasenotes: Restricted Project.
Jul 16 2020, 9:12 AM · Restricted Project
jsji closed D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .
Jul 16 2020, 9:08 AM
jsji added a comment to D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .

Thanks. Committed in https://github.com/llvm/llvm-test-suite/commit/4bdbe4ad9dd25b432d405d8a6ac6b7410da9b7a2.

Jul 16 2020, 9:08 AM
jsji retitled D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp from [test-suite] Fix random generator to Fix random number generation and floating point comparison in matrix-types-spec.cpp .
Jul 16 2020, 9:01 AM
jsji added a comment to D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .

With this, the case is passing on PowerPC. @fhahn Can you have a look and also try on your platform? Thanks.

Jul 16 2020, 8:30 AM
jsji updated the diff for D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .
  • Rename the function name
Jul 16 2020, 8:22 AM
jsji updated the diff for D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .
  • Use fpcmp to do floating point comparision

I copied the comparision code from fpcmp.c.

Jul 16 2020, 8:20 AM
jsji updated the diff for D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .
  • Add int specification version
Jul 16 2020, 7:38 AM

Jul 15 2020

jsji updated the diff for D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.

Add triples to tests.

Jul 15 2020, 7:58 PM · Restricted Project, Restricted Project, Restricted Project
Herald added projects to D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support: Restricted Project, Restricted Project, Restricted Project.
Jul 15 2020, 3:16 PM · Restricted Project, Restricted Project, Restricted Project
jsji added reviewers for D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp : anemet, rjmccall.
Jul 15 2020, 2:43 PM
jsji updated the summary of D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .
Jul 15 2020, 2:40 PM
jsji created D83910: Fix random number generation and floating point comparison in matrix-types-spec.cpp .
Jul 15 2020, 2:36 PM

Jul 13 2020

jsji added a comment to D83719: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert.

Could you please explain why D83486 broke this test and what does PowerPC have to do with it? I’m just curious.

Ah, and thanks for fixing the issue!

Jul 13 2020, 3:17 PM · Restricted Project
jsji committed rGbf0d060fd4ea: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert (authored by jsji).
[compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert
Jul 13 2020, 3:13 PM
jsji closed D83719: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert.
Jul 13 2020, 3:13 PM · Restricted Project
jsji added a reviewer for D83719: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert: amyk.
Jul 13 2020, 2:12 PM · Restricted Project
Herald added a project to D83719: [compiler-rt][MSAN][test] Update buffersize for UTF-8 to C convert: Restricted Project.
Jul 13 2020, 2:12 PM · Restricted Project
jsji committed rG835c1f9f40ec: [compiler-rt][CMake] Pass down LLVM_LIT_ARGS in runtime build (authored by jsji).
[compiler-rt][CMake] Pass down LLVM_LIT_ARGS in runtime build
Jul 13 2020, 7:38 AM
jsji closed D83565: [compiler-rt][CMake] Pass down LLVM_LIT_ARGS in runtime build.
Jul 13 2020, 7:38 AM · Restricted Project
jsji added a comment to D83276: [PowerPC] Generate CFI directives when probing in prologue.

LG, Thanks.

Jul 13 2020, 7:10 AM · Restricted Project

Jul 10 2020

jsji committed rG3e3acc1cc773: [PowerPC][MachinePipeliner] Enable pipeliner if hasInstrSchedModel (authored by jsji).
[PowerPC][MachinePipeliner] Enable pipeliner if hasInstrSchedModel
Jul 10 2020, 7:35 PM
jsji closed D83590: [PowerPC][MachinePipeliner] Enable pipeliner if hasInstrSchedModel.
Jul 10 2020, 7:34 PM · Restricted Project
Herald added a project to D83590: [PowerPC][MachinePipeliner] Enable pipeliner if hasInstrSchedModel: Restricted Project.
Jul 10 2020, 2:21 PM · Restricted Project