Page MenuHomePhabricator
People jsji

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (81 w, 4 d)

Recent Activity
View All

Thu, Jul 18

jsji added inline comments to rL366339: Fix MSVC 'implicitly capture' compile error. NFCI..
Thu, Jul 18, 7:01 AM

Wed, Jul 17

jsji added a comment to rL366339: Fix MSVC 'implicitly capture' compile error. NFCI..

@RKSimon Looks like this will cause build failure for clang with -Werror . Can you have a look? Thanks.

Wed, Jul 17, 8:34 PM

Tue, Jul 16

jsji committed rG65e34a3143c4: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin (authored by jsji).
[PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin
Tue, Jul 16, 1:26 PM
jsji committed rL366255: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin.
[PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin
Tue, Jul 16, 1:24 PM
jsji closed D64499: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin.
Tue, Jul 16, 1:24 PM · Restricted Project
jsji added a comment to D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.

Please also remember to add [PowerPC] to title for all powerpc related patches. Thanks.

Tue, Jul 16, 1:17 PM · Restricted Project
jsji added a comment to D64499: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin.

Ping..

Tue, Jul 16, 10:22 AM · Restricted Project

Mon, Jul 15

jsji added a comment to D64665: [MachinePipeliner] Refactor schedule emission logic.

Personally, I like the idea of refacting and more abstraction,
but I am a little worry about it might nont handle the complication of Phi well.
And unfortunately, I don't know enough about the cases here, especially for Hexagon.
So I would like to hear the valuable feedback from Brendon @bcahoon as well.

Mon, Jul 15, 8:26 AM · Restricted Project
jsji requested changes to D64195: [PowerPC] Replace float load/store pair with integer load/store pair when it's only used in load/store.

In theory this should be a good idea, especially with P9, we can remove the "restrict" dispatch constraints for lfs/lfd.

Mon, Jul 15, 6:57 AM · Restricted Project

Thu, Jul 11

jsji committed rG957708662875: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle (authored by jsji).
[MachinePipeliner] Fix order for nodes with Anti dependence in same cycle
Thu, Jul 11, 7:01 PM
jsji committed rL365859: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.
[MachinePipeliner] Fix order for nodes with Anti dependence in same cycle
Thu, Jul 11, 7:00 PM
jsji closed D64192: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.
Thu, Jul 11, 7:00 PM · Restricted Project
jsji updated the diff for D64192: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.

Thanks Hal. Fix comments & run clang-format on it.

Thu, Jul 11, 2:10 PM · Restricted Project
jsji committed rG84a2c78082b0: [PowerPC][NFC] Update testcase to avoid dead code (authored by jsji).
[PowerPC][NFC] Update testcase to avoid dead code
Thu, Jul 11, 12:18 PM
jsji committed rL365810: [PowerPC][NFC] Update testcase to avoid dead code.
[PowerPC][NFC] Update testcase to avoid dead code
Thu, Jul 11, 12:16 PM
jsji added a comment to D64192: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.

Ping..

Thu, Jul 11, 11:55 AM · Restricted Project
jsji accepted D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword.

LGTM. Thanks.

Thu, Jul 11, 11:53 AM · Restricted Project

Wed, Jul 10

jsji added inline comments to D64394: [MachineCSE][MachinePRE] Do not hoist common computations into hot BBs.
Wed, Jul 10, 11:30 AM · Restricted Project
jsji created D64499: [PowerPC][HTM] Fix impossible reg-to-reg copy assert with ttest builtin.
Wed, Jul 10, 7:47 AM · Restricted Project

Tue, Jul 9

jsji committed rG06fef0b359b1: Revert "[HardwareLoops] NFC - move hardware loop checking code to… (authored by jsji).
Revert "[HardwareLoops] NFC - move hardware loop checking code to…
Tue, Jul 9, 10:54 AM
jsji added a reverting change for rGd95557306585: [HardwareLoops] NFC - move hardware loop checking code to…: rG06fef0b359b1: Revert "[HardwareLoops] NFC - move hardware loop checking code to….
Tue, Jul 9, 10:54 AM
jsji added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

Reverted in https://reviews.llvm.org/rL365520.

Tue, Jul 9, 10:53 AM · Restricted Project
jsji committed rL365520: Revert "[HardwareLoops] NFC - move hardware loop checking code to….
Revert "[HardwareLoops] NFC - move hardware loop checking code to…
Tue, Jul 9, 10:53 AM
jsji added a comment to D64424: [AIX] Implement LR prolog/epilog save/restore .

FYI. You can Edit Related Revision to set the parent revision to show dependency.

Tue, Jul 9, 9:05 AM · Restricted Project
jsji added a child revision for D63738: [AIX]Enable lowering of MCSymbol MachineOperand: D64424: [AIX] Implement LR prolog/epilog save/restore .
Tue, Jul 9, 9:03 AM · Restricted Project
jsji added a parent revision for D64424: [AIX] Implement LR prolog/epilog save/restore : D63738: [AIX]Enable lowering of MCSymbol MachineOperand.
Tue, Jul 9, 9:03 AM · Restricted Project
jsji updated subscribers of D64412: [Strict FP] Allow more relaxed scheduling.
Tue, Jul 9, 6:41 AM · Restricted Project

Mon, Jul 8

jsji committed rGcbd64f7648fe: [MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue (authored by jsji).
[MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue
Mon, Jul 8, 7:29 PM
jsji committed rG18301fa82bf0: [PowerPC][MachinePipeliner][NFC] Add a testcase for Phi bug. (authored by jsji).
[PowerPC][MachinePipeliner][NFC] Add a testcase for Phi bug.
Mon, Jul 8, 7:29 PM
jsji committed rL365428: [MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue.
[MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue
Mon, Jul 8, 7:29 PM
jsji closed D64035: [MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue.
Mon, Jul 8, 7:29 PM · Restricted Project
jsji committed rL365427: [PowerPC][MachinePipeliner][NFC] Add a testcase for Phi bug..
[PowerPC][MachinePipeliner][NFC] Add a testcase for Phi bug.
Mon, Jul 8, 7:29 PM
jsji requested changes to D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword.

Some comments, but request changes as you will at least need to rebase to pick up non-relevant testcase update in https://reviews.llvm.org/rL365330.

Mon, Jul 8, 2:47 PM · Restricted Project
jsji committed rG41a414cdaa86: [PowerPC][NFC]Update testcases using script. (authored by jsji).
[PowerPC][NFC]Update testcases using script.
Mon, Jul 8, 8:27 AM
jsji committed rL365330: [PowerPC][NFC]Update testcases using script..
[PowerPC][NFC]Update testcases using script.
Mon, Jul 8, 8:26 AM
jsji added a comment to D64035: [MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue.

Ping...

Mon, Jul 8, 7:57 AM · Restricted Project

Thu, Jul 4

jsji added a comment to D64198: [NFC][PowerPC] Add the feature control for PreRA and PostRA scheduler.

As Hal mentioned, enable-misched and enable-post-misched should be able to turn on/off the pre-ra/post-ra scheduler.
Regarding to different subtarget (cpu), why we need to turn on/off with feature at runtime? Shouldn't that be configured in code?

Thu, Jul 4, 7:41 PM · Restricted Project

Wed, Jul 3

jsji updated the diff for D64192: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.

Remove "require asserts" in testcase.

Wed, Jul 3, 9:10 PM · Restricted Project
jsji retitled D64192: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle from [MachinePipeliner][PowerPC] Add a testcase for order in scheduled group. to [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.
Wed, Jul 3, 9:05 PM · Restricted Project
jsji created D64192: [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle.
Wed, Jul 3, 9:01 PM · Restricted Project
jsji accepted D64119: [PowerPC] Support constraint code "ww".

LGTM. Thanks for investigating GCC behavior.

Wed, Jul 3, 8:29 PM · Restricted Project, Restricted Project
jsji added a comment to D64119: [PowerPC] Support constraint code "ww".

It is great to add ww for compatibility.
However if we are going to add ww, looks like we should update ws as well?

Wed, Jul 3, 1:12 PM · Restricted Project, Restricted Project

Mon, Jul 1

jsji created D64035: [MachinePipeliner] Fix Phi refers to Phi in same stage in 1st epilogue.
Mon, Jul 1, 2:16 PM · Restricted Project
jsji accepted D64024: [PowerPC][Altivec] Emit correct builtin for single precision vec_all_ne.

LGTM.
BTW, looks like we are missing test cases all vector float vec_all* and vec_any* and also non-vsx path?

Mon, Jul 1, 11:41 AM · Restricted Project
jsji committed rGee6539341bfc: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments (authored by jsji).
[UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments
Mon, Jul 1, 7:41 AM
jsji committed rL364775: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments.
[UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments
Mon, Jul 1, 7:38 AM
jsji closed D63957: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments.
Mon, Jul 1, 7:37 AM · Restricted Project
jsji updated the diff for D63957: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments.

Update the comments.

Mon, Jul 1, 7:29 AM · Restricted Project

Fri, Jun 28

jsji updated the summary of D63957: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments.
Fri, Jun 28, 2:34 PM · Restricted Project
jsji created D63957: [UpdateTestChecks][PowerPC] Avoid empty string when scrubbing loop comments.
Fri, Jun 28, 2:30 PM · Restricted Project
jsji committed rG7d78e5cc8115: [UpdateChecks] Add support for armv7-apple-darwin (authored by jsji).
[UpdateChecks] Add support for armv7-apple-darwin
Fri, Jun 28, 11:08 AM
jsji committed rL364668: [UpdateChecks] Add support for armv7-apple-darwin.
[UpdateChecks] Add support for armv7-apple-darwin
Fri, Jun 28, 11:07 AM
jsji closed D63939: [UpdateTestChecks] [ARM] Add support for armv7-apple-darwin.
Fri, Jun 28, 11:07 AM · Restricted Project
jsji added a comment to D63939: [UpdateTestChecks] [ARM] Add support for armv7-apple-darwin.
In D63939#1562621, @lebedev.ri wrote:

LG. I trust that you have verified that FileCheck accepts these check lines.

Fri, Jun 28, 10:58 AM · Restricted Project
jsji updated the diff for D63939: [UpdateTestChecks] [ARM] Add support for armv7-apple-darwin.

Update to remove unintended empty lines before body.

Fri, Jun 28, 10:40 AM · Restricted Project
jsji added inline comments to D63939: [UpdateTestChecks] [ARM] Add support for armv7-apple-darwin.
Fri, Jun 28, 10:27 AM · Restricted Project
jsji added inline comments to D60601: [DAGCombiner] Exploiting more about the transformation of TransformFPLoadStorePair function.
Fri, Jun 28, 10:17 AM · Restricted Project
jsji updated the summary of D63939: [UpdateTestChecks] [ARM] Add support for armv7-apple-darwin.
Fri, Jun 28, 10:15 AM · Restricted Project
jsji created D63939: [UpdateTestChecks] [ARM] Add support for armv7-apple-darwin.
Fri, Jun 28, 10:15 AM · Restricted Project
jsji accepted D63804: [PowerPC] Implement the areMemAccessesTriviallyDisjoint hook.

LGTM except for some minor comments update, you can update them before commit.
Thanks for implementing this hook, it should improve scheduling in general.

Fri, Jun 28, 7:23 AM · Restricted Project

Thu, Jun 27

jsji committed rGc627aa2fa9c9: [PowerPC][NFC] Remove unused (and unsupported) fusion feature bits. (authored by jsji).
[PowerPC][NFC] Remove unused (and unsupported) fusion feature bits.
Thu, Jun 27, 12:36 PM
jsji committed rL364581: [PowerPC][NFC] Remove unused (and unsupported) fusion feature bits..
[PowerPC][NFC] Remove unused (and unsupported) fusion feature bits.
Thu, Jun 27, 12:36 PM
jsji committed rG157b073fa54e: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others (authored by jsji).
[PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others
Thu, Jun 27, 7:13 AM
jsji committed rL364544: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.
[PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others
Thu, Jun 27, 7:12 AM
jsji closed D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.
Thu, Jun 27, 7:11 AM · Restricted Project

Wed, Jun 26

jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Thanks, will remove that comment in commit.

Wed, Jun 26, 1:43 PM · Restricted Project
jsji committed rG968a45418200: [UpdateTestChecks][NFC] Remove entries with same prefix (authored by jsji).
[UpdateTestChecks][NFC] Remove entries with same prefix
Wed, Jun 26, 1:39 PM
jsji committed rL364471: [UpdateTestChecks][NFC] Remove entries with same prefix.
[UpdateTestChecks][NFC] Remove entries with same prefix
Wed, Jun 26, 1:35 PM
jsji closed D63732: [UpdateTestChecks][NFC] Remove entries with same prefix.
Wed, Jun 26, 1:35 PM · Restricted Project

Tue, Jun 25

jsji committed rGfee855b5bc1a: [MachinePipeliner] Fix risky iterator usage R++, --R (authored by jsji).
[MachinePipeliner] Fix risky iterator usage R++, --R
Tue, Jun 25, 2:54 PM
jsji committed rL364353: [MachinePipeliner] Fix risky iterator usage R++, --R.
[MachinePipeliner] Fix risky iterator usage R++, --R
Tue, Jun 25, 2:54 PM
jsji closed D63536: [MachinePipeliner] Fix risky iterator usage R++, --R .
Tue, Jun 25, 2:54 PM · Restricted Project
jsji committed rGbc7fc3ecb676: [PowerPC][NFC]Add a test for MachinePipeliner bug (authored by jsji).
[PowerPC][NFC]Add a test for MachinePipeliner bug
Tue, Jun 25, 1:58 PM
jsji committed rL364350: [PowerPC][NFC]Add a test for MachinePipeliner bug.
[PowerPC][NFC]Add a test for MachinePipeliner bug
Tue, Jun 25, 1:57 PM
jsji accepted D63754: [PowerPC][NFC] Move current peephole optimization of RLDICR into a method.

LGTM. Please address the Simplified flag problem in another patch. Thanks.

Tue, Jun 25, 9:26 AM · Restricted Project
jsji resigned from D60601: [DAGCombiner] Exploiting more about the transformation of TransformFPLoadStorePair function.
Tue, Jun 25, 9:26 AM · Restricted Project
jsji requested changes to D62565: [PowerPC] Exploiting to use mtvsrdd instruction when save called-saved GPR register to VSR registers.
Tue, Jun 25, 9:26 AM · Restricted Project
jsji added a comment to D63536: [MachinePipeliner] Fix risky iterator usage R++, --R .

Ping... Any comments or feedback, especially for Hexagon? @bcahoon

Tue, Jun 25, 8:51 AM · Restricted Project

Mon, Jun 24

jsji added inline comments to D63732: [UpdateTestChecks][NFC] Remove entries with same prefix.
Mon, Jun 24, 12:45 PM · Restricted Project
jsji created D63732: [UpdateTestChecks][NFC] Remove entries with same prefix.
Mon, Jun 24, 11:17 AM · Restricted Project
jsji committed rG318b6dafca23: [PowerPC][UpdateTestChecks] powerpc- triple support (authored by jsji).
[PowerPC][UpdateTestChecks] powerpc- triple support
Mon, Jun 24, 11:01 AM
jsji committed rL364213: [PowerPC][UpdateTestChecks] powerpc- triple support.
[PowerPC][UpdateTestChecks] powerpc- triple support
Mon, Jun 24, 11:01 AM
jsji closed D63723: [UpdateTestChecks] [PowerPC] Add powerpc- triple support.
Mon, Jun 24, 11:00 AM · Restricted Project
jsji added inline comments to D63723: [UpdateTestChecks] [PowerPC] Add powerpc- triple support.
Mon, Jun 24, 10:51 AM · Restricted Project
jsji updated the diff for D63723: [UpdateTestChecks] [PowerPC] Add powerpc- triple support.
Mon, Jun 24, 10:47 AM · Restricted Project
jsji created D63723: [UpdateTestChecks] [PowerPC] Add powerpc- triple support.
Mon, Jun 24, 9:24 AM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Ping.. Any other feedback or comments are appreciated. Thanks.

Mon, Jun 24, 7:03 AM · Restricted Project

Sun, Jun 23

jsji updated subscribers of D63692: [LSR] Improved code generation for Zero Compare loops.
Sun, Jun 23, 3:56 PM · Restricted Project

Sat, Jun 22

jsji accepted D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst.

LGTM. Thanks for fixing.

Sat, Jun 22, 1:53 PM · Restricted Project

Jun 21 2019

jsji added a comment to D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst.

A few questions.

Jun 21 2019, 3:06 PM · Restricted Project
jsji accepted D63634: [PowerPC] Mark FCOPYSIGN legal for FP vectors.

LGTM. Thanks for fixing.

Jun 21 2019, 1:47 PM · Restricted Project
jsji added a reviewer for D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others: lei.
Jun 21 2019, 6:49 AM · Restricted Project

Jun 20 2019

jsji committed rG8b1abe568e64: [PowerPC][NFC] Fix comments for AltVSXFMARel mapping. (authored by jsji).
[PowerPC][NFC] Fix comments for AltVSXFMARel mapping.
Jun 20 2019, 2:34 PM
jsji committed rL363987: [PowerPC][NFC] Fix comments for AltVSXFMARel mapping..
[PowerPC][NFC] Fix comments for AltVSXFMARel mapping.
Jun 20 2019, 2:32 PM
jsji updated subscribers of D63624: [PowerPC] Exploit single instruction load-and-splat for word and doubleword.

@amyk FYI, does this cover all the cases you want to do https://reviews.llvm.org/D51750 ?

Jun 20 2019, 2:19 PM · Restricted Project

Jun 18 2019

jsji created D63536: [MachinePipeliner] Fix risky iterator usage R++, --R .
Jun 18 2019, 8:55 PM · Restricted Project
jsji committed rGba43840bfe2e: [MachinePipeliner][NFC] Do resource tracking log only when requested. (authored by jsji).
[MachinePipeliner][NFC] Do resource tracking log only when requested.
Jun 18 2019, 1:22 PM
jsji committed rL363733: [MachinePipeliner][NFC] Do resource tracking log only when requested..
[MachinePipeliner][NFC] Do resource tracking log only when requested.
Jun 18 2019, 1:22 PM

Jun 17 2019

jsji updated the summary of D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.
Jun 17 2019, 7:58 PM · Restricted Project
jsji added a comment to D61935: [PowerPC][HTM] Fix disassembling buffer overflow for tabortdc and others.

Ping...

Jun 17 2019, 7:56 PM · Restricted Project