- User Since
- Dec 27 2017, 10:26 AM (72 w, 3 d)
Thu, May 16
I think we should update the title or summary to indicate that this is P9 only.
You can have a look at llvm/test/MC/Disassembler/PowerPC
Wed, May 15
@catenacyber Can you please include a testcase for MC please?
Tue, May 14
Some more nit-picker, other than that, mostly good to me.
Mon, May 13
Thu, May 9
Have we thought about adding support in DAGCombine or even InstCombine to combine into ISD::VSELECT too?
Tue, May 7
Tue, Apr 30
Mon, Apr 29
Fri, Apr 26
Wed, Apr 24
Tue, Apr 23
Thanks @MaskRay for help fixing and review!
Apr 18 2019
Apr 17 2019
LGTM. Thanks for reducing the testcase and fixing!
Apr 16 2019
Apr 15 2019
LGTM. Thanks for porting!
Some comments related to testcases.
Apr 12 2019
Apr 11 2019
LGTM, Thanks for fixing this.
@ZhangKang Looks like the patch is suggested by you? Do you have any testcases that can validate this?
And also are you able to reproduce (and narrow down) the problem before suggesting the patch?
Apr 9 2019
Please make sure you run all test before updating patch!
Apr 8 2019
LGTM. Thanks for fixing this bug.
Since we are adding new headers that is not originated by this patch,
please also update the description (and commit message) to include who actually contributed to mmintrin.h and other headers.
eg:headers are mostly based on headers developed by Steven Munroe, with some contribution of Paul Clarke, Bill Schmidt, Jinsong, Zeson.
Apr 5 2019
Apr 4 2019
LGTM. Thanks for refactoring.
Apr 3 2019
Mar 29 2019
Mar 28 2019
Might miss some opportunity related to parameters instead. Please have a look. Thanks.
LGTM, with some comment change please. Thanks.
LGTM. Thanks for exploiting.
Mar 27 2019
Mar 26 2019
Looks like this may cause some unexpected failures. See https://bugs.llvm.org/show_bug.cgi?id=41247 for more details.
Mar 25 2019
LGTM, except for some minor comments change.
Thanks for extending this, it will allow us to tune MachineScheduler specifically for PowerPC going forward.
Thanks for updating! @wuzish However, I am even more confused by your new comments.
Mar 21 2019
Thought we are waiting for @nemanjai 's insight about line 167... But LGTM given that you have run full test.
Thanks for improving this.
@sarveshtamba As the author mentioned, yes, this has been upstreamed.
Mar 20 2019
I am not familiar with swift development process,
but looks like you should be able to dump LLVM IR passing -emit-ir -Xfrontend -disable-llvm-optzns according to https://github.com/apple/swift/blob/master/docs/DebuggingTheCompiler.rst#printing-the-intermediate-representations.
And you may try to reduce the SIL first using bug_reducer. https://github.com/apple/swift/blob/master/docs/DebuggingTheCompiler.rst#reducing-sil-test-cases-using-bug-reducer
Mar 18 2019
Mar 15 2019
Comments mostly related to comments and testcases.
Mar 14 2019
Apparently missing some files.
Can you produce a reduced testcase that can show the problem?
Then I can find someone who can help to have a look.
Since this is an assert, I think it should not be too hard to create a reduce testcase using bugpoint.
Mar 12 2019
No-relevant testcase update committed in NFC patch https://reviews.llvm.org/rL355945 first.
Update patch to show relevant changes only.
Update testcases(pr36292.ll) to reflect upstream changes.
Mar 11 2019
Mar 7 2019
Mar 6 2019
Mar 5 2019
Mar 4 2019
LGTM, except some minor update. Thanks for fixing!
Mar 3 2019
Thanks for addressing comments, however, I am still not convinced that this is safe.
Feb 26 2019
I like the idea of trying to use register class to avoid using UseVSXReg flag.
Feb 25 2019
Why is CHECK-NEXT not being used?
Why is ./utils/update_llc_test_checks.py not being used? That dramatically reduces chances of things like this, and spares one from actually having to manually write proper check lines. (thus improves test coverage. one will of course still need to verify that the checks are correct.)
Thanks for quick update, some more comments.
LGTM. Thanks for catching this, I am surprised that those typos slipped through ... FYI. @HLJ2009
Feb 22 2019
LGTM, except minor comments update.