Page MenuHomePhabricator

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (89 w, 6 d)

Recent Activity

Yesterday

jsji committed rG0c8e4a2e0d42: Reland "[docs][Bugpoint]Add notes about multiple crashes" (authored by jsji).
Reland "[docs][Bugpoint]Add notes about multiple crashes"
Tue, Sep 17, 2:12 PM
jsji committed rL372181: Reland "[docs][Bugpoint]Add notes about multiple crashes".
Reland "[docs][Bugpoint]Add notes about multiple crashes"
Tue, Sep 17, 2:11 PM
jsji committed rG6fce46a5f137: [docs][Bugpoint] Revert 5584ead50 a5aa3353 (authored by jsji).
[docs][Bugpoint] Revert 5584ead50 a5aa3353
Tue, Sep 17, 11:44 AM
jsji added a reverting change for rGa5aa3353946d: [docs][Bugpoint]Add notes about multiple crashes: rG6fce46a5f137: [docs][Bugpoint] Revert 5584ead50 a5aa3353.
Tue, Sep 17, 11:44 AM
jsji added a reverting change for rG5584ead50e62: [docs][Bugpoint] Fix build break.: rG6fce46a5f137: [docs][Bugpoint] Revert 5584ead50 a5aa3353.
Tue, Sep 17, 11:44 AM
jsji committed rL372161: [docs][Bugpoint] Revert 5584ead50 a5aa3353.
[docs][Bugpoint] Revert 5584ead50 a5aa3353
Tue, Sep 17, 11:37 AM
jsji committed rG5584ead50e62: [docs][Bugpoint] Fix build break. (authored by jsji).
[docs][Bugpoint] Fix build break.
Tue, Sep 17, 11:22 AM
jsji committed rL372160: [docs][Bugpoint] Fix build break..
[docs][Bugpoint] Fix build break.
Tue, Sep 17, 11:21 AM
jsji committed rGa5aa3353946d: [docs][Bugpoint]Add notes about multiple crashes (authored by jsji).
[docs][Bugpoint]Add notes about multiple crashes
Tue, Sep 17, 11:11 AM
jsji committed rL372157: [docs][Bugpoint]Add notes about multiple crashes.
[docs][Bugpoint]Add notes about multiple crashes
Tue, Sep 17, 11:11 AM
jsji closed D66832: [docs][Bugpoint]Add notes about multiple crashes.
Tue, Sep 17, 11:11 AM · Restricted Project
jsji added inline comments to D62908: [PowerPC] Improve float vector gather codegen.
Tue, Sep 17, 10:27 AM · Restricted Project
jsji added a comment to D66832: [docs][Bugpoint]Add notes about multiple crashes.

Ping? @vsk Do you think it worth updating Bugpoint.rst? If so, any comments? Thanks.

Tue, Sep 17, 7:10 AM · Restricted Project
jsji resigned from D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.

Hmm... OK, too many details that I did not even think of. I would leave this to be reviewed by other experts.

Tue, Sep 17, 6:42 AM · Restricted Project

Mon, Sep 16

jsji accepted D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.

LGTM.

Mon, Sep 16, 6:49 AM · Restricted Project

Sun, Sep 15

jsji created D67595: [PowerPC] Add missing pattern for VSX Scalar Negative Multiply-Subtract Single Precision.
Sun, Sep 15, 1:39 PM · Restricted Project
jsji committed rG07d824a7c39e: [PowerPC][NFC] Add a testcase for fdiv expansion. (authored by jsji).
[PowerPC][NFC] Add a testcase for fdiv expansion.
Sun, Sep 15, 1:03 PM
jsji committed rL371938: [PowerPC][NFC] Add a testcase for fdiv expansion..
[PowerPC][NFC] Add a testcase for fdiv expansion.
Sun, Sep 15, 1:01 PM

Fri, Sep 13

jsji requested changes to D66991: [PowerPC] Fix SH field overflow issue.

Can you please use MIR test instead. Thanks.

Fri, Sep 13, 8:27 AM · Restricted Project
jsji added inline comments to D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.
Fri, Sep 13, 7:29 AM · Restricted Project
jsji committed rG455a0db01a04: [PowerPC][NFC] Move codegen tests to PowerPC from MIR/PowerPC (authored by jsji).
[PowerPC][NFC] Move codegen tests to PowerPC from MIR/PowerPC
Fri, Sep 13, 7:19 AM
jsji committed rL371857: [PowerPC][NFC] Move codegen tests to PowerPC from MIR/PowerPC.
[PowerPC][NFC] Move codegen tests to PowerPC from MIR/PowerPC
Fri, Sep 13, 7:17 AM
jsji added a comment to D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

Thanks for the great feedback Jinsong! I've addressed your comments.

Fri, Sep 13, 6:46 AM · Restricted Project

Thu, Sep 12

jsji retitled D66832: [docs][Bugpoint]Add notes about multiple crashes from [NFC][Bugpoint][CrashDebugger] Add notes about multiple crashes to [docs][Bugpoint]Add notes about multiple crashes.
Thu, Sep 12, 9:06 AM · Restricted Project

Wed, Sep 11

jsji added a comment to D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.

The patch is only updating existing tests in three places -- which to me looks more like a happy coincidence (that LLVM already includes tests that happen to trigger the new behavior) than intentional testing. Thanks!

Wed, Sep 11, 8:44 AM · Restricted Project
jsji requested changes to D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.

Please add more tests as required by @gribozavr . Thanks.

Wed, Sep 11, 8:44 AM · Restricted Project
jsji accepted D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

LGTM. May need @kbarton to have another look, as he should be in the "Must Review" for this.

Wed, Sep 11, 8:38 AM · Restricted Project
jsji accepted D66050: Improve division estimation of floating points..

LGTM.

Wed, Sep 11, 8:19 AM · Restricted Project

Tue, Sep 10

jsji added a comment to D66832: [docs][Bugpoint]Add notes about multiple crashes.

> I see the need to make error validation with bugpoint more beginner-friendly, but am worried about situations in which the mode proposed here could confuse beginners (what if the first error isn't the interesting one? or reductions stop too early?). I don't have a better alternative to suggest. Perhaps we could repost @mehdi_amini's writeup in the "Search for a string in the output" section within http://blog.llvm.org/2015/11/reduce-your-testcases-with-bugpoint-and.html, or link to it from the bugpoint docs.

Tue, Sep 10, 2:24 PM · Restricted Project
jsji retitled D66832: [docs][Bugpoint]Add notes about multiple crashes from [Bugpoint][CrashDebugger] Add --same-error to skip non-relevant CodeGenCrash to [NFC][Bugpoint][CrashDebugger] Add notes about multiple crashes.
Tue, Sep 10, 2:20 PM · Restricted Project
jsji updated the diff for D66832: [docs][Bugpoint]Add notes about multiple crashes.

Abandon the --same-error change, update docs instead.

Tue, Sep 10, 2:19 PM · Restricted Project
jsji added a comment to D66832: [docs][Bugpoint]Add notes about multiple crashes.

I think it would be great to make the powerful bugpoint tool easier to use, especially for beginners, for common simple scenarios.

Tue, Sep 10, 10:49 AM · Restricted Project
jsji added a comment to D66832: [docs][Bugpoint]Add notes about multiple crashes.

Thanks @vsk for the valuable comments.

Tue, Sep 10, 10:44 AM · Restricted Project

Mon, Sep 9

jsji requested changes to D66050: Improve division estimation of floating points..

Please include *Full Context* in newer diff . Thanks.

Mon, Sep 9, 2:56 PM · Restricted Project
jsji added a comment to D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

General idea is great, some comments when I looked at PowerPC part. Thanks.

Mon, Sep 9, 2:51 PM · Restricted Project
jsji added reviewers for D66832: [docs][Bugpoint]Add notes about multiple crashes: vsk, MatzeB.

Ping..
and add the most recent code modifier & patch reviewers . Thanks!

Mon, Sep 9, 1:39 PM · Restricted Project

Wed, Sep 4

jsji committed rGa71c199f82cd: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst* (authored by jsji).
[PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
Wed, Sep 4, 8:23 AM
jsji committed rL370912: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*.
[PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*
Wed, Sep 4, 8:22 AM
jsji closed D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*.
Wed, Sep 4, 8:22 AM · Restricted Project, Restricted Project
jsji updated the diff for D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*.

Rebase to ToT.

Wed, Sep 4, 7:37 AM · Restricted Project, Restricted Project
jsji committed rG5309189d9b3e: [PowerPC][Altivec] Fix constant argument for vec_dss (authored by jsji).
[PowerPC][Altivec] Fix constant argument for vec_dss
Wed, Sep 4, 7:01 AM
jsji committed rL370902: [PowerPC][Altivec] Fix constant argument for vec_dss.
[PowerPC][Altivec] Fix constant argument for vec_dss
Wed, Sep 4, 7:01 AM
jsji closed D66699: [PowerPC][Altivec] Fix constant argument for vec_dss.
Wed, Sep 4, 7:01 AM · Restricted Project, Restricted Project

Tue, Sep 3

jsji accepted D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.

LGTM.

Tue, Sep 3, 7:48 PM · Restricted Project
jsji added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Tue, Sep 3, 2:32 PM · Restricted Project
jsji added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

https://reviews.llvm.org/rL370228 just landed, so I think you should include fptrunc and fpext intrinsics as well.

Tue, Sep 3, 2:29 PM · Restricted Project
jsji added a comment to D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp.

LGTM. Please hold for a few days, in case someone has more comments. Thanks.

Tue, Sep 3, 11:54 AM · Restricted Project
jsji updated the diff for D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*.

Add range check and tests.

Tue, Sep 3, 10:34 AM · Restricted Project, Restricted Project
jsji added inline comments to D66699: [PowerPC][Altivec] Fix constant argument for vec_dss.
Tue, Sep 3, 10:07 AM · Restricted Project, Restricted Project
jsji updated the diff for D66699: [PowerPC][Altivec] Fix constant argument for vec_dss.

Add range check and test.

Tue, Sep 3, 10:06 AM · Restricted Project, Restricted Project
jsji added a comment to D66832: [docs][Bugpoint]Add notes about multiple crashes.

Ping ...

Tue, Sep 3, 5:53 AM · Restricted Project

Mon, Sep 2

jsji added a comment to D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*.

Ping..

Mon, Sep 2, 8:20 AM · Restricted Project, Restricted Project
jsji added a comment to D66699: [PowerPC][Altivec] Fix constant argument for vec_dss.

Ping..

Mon, Sep 2, 8:19 AM · Restricted Project, Restricted Project

Fri, Aug 30

jsji requested changes to D62908: [PowerPC] Improve float vector gather codegen.

My understanding is that the cycle saving come from avoiding unnecessary SP->DP, then DP->SP conversion.
But not the difference merge sequence.

Fri, Aug 30, 8:58 PM · Restricted Project
jsji committed rL370520: Request commit access for jsji.
Request commit access for jsji
Fri, Aug 30, 1:23 PM
jsji committed rGfb4b86af9255: [PowerPC][NFC] Avoid checking non-relevant .cfi instructions (authored by jsji).
[PowerPC][NFC] Avoid checking non-relevant .cfi instructions
Fri, Aug 30, 12:28 PM
jsji committed rL370505: [PowerPC][NFC] Avoid checking non-relevant .cfi instructions.
[PowerPC][NFC] Avoid checking non-relevant .cfi instructions
Fri, Aug 30, 12:28 PM
jsji closed D67016: [PowerPC][NFC] Avoid checking non-relevant .cfi instructions.
Fri, Aug 30, 12:27 PM · Restricted Project
jsji added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Fri, Aug 30, 11:43 AM · Restricted Project
jsji added a reviewer for D67016: [PowerPC][NFC] Avoid checking non-relevant .cfi instructions: Restricted Project.
Fri, Aug 30, 11:36 AM · Restricted Project
jsji created D67016: [PowerPC][NFC] Avoid checking non-relevant .cfi instructions.
Fri, Aug 30, 11:34 AM · Restricted Project

Thu, Aug 29

jsji committed rL370428: [PowerPC][NFC] Use inline Subtarget->isPPC64().
[PowerPC][NFC] Use inline Subtarget->isPPC64()
Thu, Aug 29, 8:18 PM
jsji committed rGa070f12e578e: [PowerPC][NFC] Use inline Subtarget->isPPC64() (authored by jsji).
[PowerPC][NFC] Use inline Subtarget->isPPC64()
Thu, Aug 29, 8:18 PM
jsji committed rG54a1ad5bd78c: [PowerPC][NFC] Use -mtriple in RUN line, remove target triple in tls.ll (authored by jsji).
[PowerPC][NFC] Use -mtriple in RUN line, remove target triple in tls.ll
Thu, Aug 29, 7:58 PM
jsji committed rL370427: [PowerPC][NFC] Use -mtriple in RUN line, remove target triple in tls.ll.
[PowerPC][NFC] Use -mtriple in RUN line, remove target triple in tls.ll
Thu, Aug 29, 7:57 PM
jsji added a comment to D66925: [PPC32] Emit R_PPC_GOT_TPREL16 instead R_PPC_GOT_TPREL16_LO.

I'll take that you accepted the patch, and commit it, so that @adalava can quickly file a merge request to release_90.

Thu, Aug 29, 7:31 PM · Restricted Project
jsji committed rG1ed7d2119ee2: [PowerPC] Support extended mnemonics mffprwz etc. (authored by jsji).
[PowerPC] Support extended mnemonics mffprwz etc.
Thu, Aug 29, 2:55 PM
jsji committed rL370411: [PowerPC] Support extended mnemonics mffprwz etc..
[PowerPC] Support extended mnemonics mffprwz etc.
Thu, Aug 29, 2:54 PM
jsji closed D66963: [PowerPC] Support extended mnemonics mffprwz etc..
Thu, Aug 29, 2:54 PM · Restricted Project
jsji updated subscribers of D66925: [PPC32] Emit R_PPC_GOT_TPREL16 instead R_PPC_GOT_TPREL16_LO.
Thu, Aug 29, 1:46 PM · Restricted Project
jsji updated the diff for D66963: [PowerPC] Support extended mnemonics mffprwz etc..

Added encoding tests.

Thu, Aug 29, 1:12 PM · Restricted Project
jsji added a comment to D66963: [PowerPC] Support extended mnemonics mffprwz etc..

mfvrwz RA,VRS is mfvsrwz RA,VRS+32

The '+32' bit is covered by the added CodeGen/PowerPC/inlineasm-extendedmne.ll test, but I'd really like to see direct encoding tests for all of the instructions. Can you please make sure that they all appear in MC/PowerPC/vsx.s and MC/Disassembler/PowerPC/vsx.txt?

Thu, Aug 29, 1:12 PM · Restricted Project
jsji updated subscribers of D66925: [PPC32] Emit R_PPC_GOT_TPREL16 instead R_PPC_GOT_TPREL16_LO.

The change looks fine to me, as LLVM currently doesn't generate relocation pairs.

Thu, Aug 29, 11:33 AM · Restricted Project
jsji added a reviewer for D66963: [PowerPC] Support extended mnemonics mffprwz etc.: Restricted Project.
Thu, Aug 29, 10:32 AM · Restricted Project
jsji created D66963: [PowerPC] Support extended mnemonics mffprwz etc..
Thu, Aug 29, 10:32 AM · Restricted Project
jsji committed rG8b0317ad7df4: [PowerPC][NFC] Update fp-int-conversions-direct-moves.ll using script (authored by jsji).
[PowerPC][NFC] Update fp-int-conversions-direct-moves.ll using script
Thu, Aug 29, 8:40 AM
jsji committed rL370375: [PowerPC][NFC] Update fp-int-conversions-direct-moves.ll using script.
[PowerPC][NFC] Update fp-int-conversions-direct-moves.ll using script
Thu, Aug 29, 8:40 AM
jsji added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

Yes, the list in VecFuncs.def could be reused in PPCISelLowering. But, PPCISelLowering.cpp is already big as it is. Adding more functions to handle this lowering will only add to its size and a list of features it already supports. Therefore, my preference is to separate out the MASSV lowering functionality into a separate transformation.

Thu, Aug 29, 7:08 AM · Restricted Project

Wed, Aug 28

jsji added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Wed, Aug 28, 2:45 PM · Restricted Project
jsji added a reviewer for D62908: [PowerPC] Improve float vector gather codegen: Restricted Project.
Wed, Aug 28, 12:01 PM · Restricted Project
jsji added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.
  1. *_massv functions serve as place holder for math functions during loop vectorization. They are not actual entries in the MASS library. I think lowering them to actual entries in the MASS library deserves a separate pass rather than polluting the TargetLowering.cpp, which is already big as it is.
Wed, Aug 28, 11:55 AM · Restricted Project
jsji added a comment to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

A separate pass for MASSV lowering is worthwhile because it allows better separation of concerns.
In the future, if need be, other PPC sub-target specific lowering decisions for MASSV may be encapsulated in this pass too.

Wed, Aug 28, 10:28 AM · Restricted Project
jsji added a reviewer for D66891: [PowerPC] Implementing overflow version for XO-Form instructions: Restricted Project.
Wed, Aug 28, 10:27 AM · Restricted Project

Tue, Aug 27

jsji added a reviewer for D64193: [PowerPC] Add constraint fp support about exception part for remaining operations: Restricted Project.
Tue, Aug 27, 7:57 PM · Restricted Project
jsji added a reviewer for D63916: [PowerPC] Add constraint fp support about exception part for operation +-*/ : Restricted Project.
Tue, Aug 27, 7:57 PM · Restricted Project
jsji requested changes to D62993: [PowerPC] Emit scalar min/max instructions with unsafe fp math.

Move out of review queue, need author's action.

Tue, Aug 27, 7:54 PM · Restricted Project
jsji requested changes to D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.

Move out of review queue, need author's action.

Tue, Aug 27, 7:48 PM · Restricted Project
jsji added a reviewer for D66329: [PowerPC] [Peephole] fold frame offset by using index form to save add.: Restricted Project.
Tue, Aug 27, 7:47 PM · Restricted Project
jsji added a comment to D61976: [PowerPC] Reorder CSR reloads in epilogue to follow the same order as CSR saves in the prologue.

Are you still pursuing this Patch?

Tue, Aug 27, 7:43 PM · Restricted Project
jsji updated the diff for D66832: [docs][Bugpoint]Add notes about multiple crashes.

Fix typos in testcase.

Tue, Aug 27, 2:54 PM · Restricted Project
jsji created D66832: [docs][Bugpoint]Add notes about multiple crashes.
Tue, Aug 27, 2:54 PM · Restricted Project
jsji requested changes to D63972: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks.
Tue, Aug 27, 8:22 AM · Restricted Project
jsji reopened D63972: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks.
Tue, Aug 27, 8:22 AM · Restricted Project
jsji committed rL370069: Revert "[CodeGen] Do the Simple Early Return in block-placement pass to….
Revert "[CodeGen] Do the Simple Early Return in block-placement pass to…
Tue, Aug 27, 8:05 AM
jsji committed rG7f536bcf2207: Revert "[CodeGen] Do the Simple Early Return in block-placement pass to… (authored by jsji).
Revert "[CodeGen] Do the Simple Early Return in block-placement pass to…
Tue, Aug 27, 8:03 AM
jsji added a reverting change for rGb3d258fc44b5: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the…: rG7f536bcf2207: Revert "[CodeGen] Do the Simple Early Return in block-placement pass to….
Tue, Aug 27, 8:03 AM
jsji added a comment to D63972: [CodeGen] Do the Simple Early Return in block-placement pass to optimize the blocks.

Please provide a quick fix or revert the patch causing the crash due to transforming to incorrect IR.

Tue, Aug 27, 8:03 AM · Restricted Project

Mon, Aug 26

jsji added a reviewer for D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*: Restricted Project.
Mon, Aug 26, 8:44 AM · Restricted Project, Restricted Project
jsji created D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*.
Mon, Aug 26, 8:44 AM · Restricted Project, Restricted Project

Fri, Aug 23

jsji created D66699: [PowerPC][Altivec] Fix constant argument for vec_dss.
Fri, Aug 23, 9:17 PM · Restricted Project, Restricted Project