User Details
- User Since
- Dec 27 2017, 10:26 AM (235 w, 13 h)
Thu, Jun 2
May 11 2022
LGTM
May 3 2022
LGTM. Thanks.
Apr 26 2022
LGTM. Thanks.
Apr 21 2022
LGTM. Thanks.
Apr 19 2022
LGTM. Thanks.
Apr 11 2022
@qiongsiwu1 Please also add reviewers from other targets. Thanks.
Apr 1 2022
LGTM. Thanks Jake.
LGTM. Thanks @DiggerLin !
Mar 31 2022
Mar 28 2022
Mar 24 2022
Mar 21 2022
LGTM as long as we have followup patch to prevent similar things happen again. Thanks.
Mar 18 2022
Mar 16 2022
LGTM. Thanks.
Mar 15 2022
LGTM. Thanks.
Mar 13 2022
Please also mention the attempt to avoid perfect shuffle when mask has multiple uses in https://reviews.llvm.org/D116801.
Mar 11 2022
LGTM, asan also uses dynamic allocation, so the performance impact should be acceptable.
Can you please add some comments about why it is bad for vector loops? And some general description about the performance test results with this turned off?
Mar 8 2022
Mar 7 2022
LGTM. Thanks.
LGTM. Thanks!
Mar 4 2022
Yes, AIX clang hasn't supported visibility yet, we simply ignore all the visibility for now.
Rebased and address comments.
Mar 3 2022
Address comments.
LGTM.
Mar 2 2022
put_double.pass.cpp was already fixed (test removed) in https://reviews.llvm.org/D120022.
Address comments.
Mar 1 2022
Feb 28 2022
gentle ping...
Feb 25 2022
LGTM. Thanks for cleaning up.
BTW: @jasonliu and @Xiangling_L are no longer working on AIX. #powerpc might get attention from wider group.
LGTM. Thanks.
Feb 23 2022
Thank you so much Nikolas! @philnik
Ping.. Can someone in libc++ group help to have a quick look? This only affect AIX test. Thank you so much!
Feb 18 2022
LGTM. Thanks.
Feb 16 2022
Feb 15 2022
This was committed in https://reviews.llvm.org/rG8ce13bc93be423d2a368f804ed18edf21b489c2e
Feb 8 2022
but they can be disabled by defining LIBC_NO_CPP_MATH_OVERLOADS
@daltenty Can you please update the patch to include more *Context*, looks like the Context not available. Or use arc to update it. Thanks.
Jan 26 2022
LGTM.
Jan 25 2022
Jan 24 2022
Besides, would it be acceptable that we add a variable to cmake to determine default long double semantics (like current GCC)?
Jan 21 2022
Won't that end up producing a warning on ALL code built on any Linux distro with a GCC toolchain older than 12.1? That would be terrible.
LGTM with some nits.
LGTM. Thanks for adding this feature.