Page MenuHomePhabricator
People jsji

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (159 w, 6 d)

Recent Activity
View All

Sun, Jan 17

jsji added a comment to D92069: [NFC] [TargetRegisterInfo] add one use check to lookThruCopyLike..
In D92069#2504002, @echristo wrote:

I'd like to avoid the bool completely if possible.

Sun, Jan 17, 7:45 PM · Restricted Project

Fri, Jan 15

jsji accepted D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

LGTM. Thanks!

Fri, Jan 15, 8:57 AM · Restricted Project, Restricted Project

Thu, Jan 14

jsji accepted D92069: [NFC] [TargetRegisterInfo] add one use check to lookThruCopyLike..

LGTM.

Thu, Jan 14, 8:05 PM · Restricted Project
jsji committed rG0f588ac03e15: [PowerPC] Only use some extend mne if assembler is modern enough (authored by jsji).
[PowerPC] Only use some extend mne if assembler is modern enough
Thu, Jan 14, 1:03 PM
jsji closed D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 1:03 PM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Update encoding testcases.

Thu, Jan 14, 10:20 AM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Rebase and update tests.

Thu, Jan 14, 10:16 AM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Introduce AIX feature bit, and only append this on AIX.

Thu, Jan 14, 9:52 AM · Restricted Project
jsji added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 9:00 AM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Rename the feature name to be AIX specific.

Thu, Jan 14, 8:58 AM · Restricted Project
jsji added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 7:07 AM · Restricted Project

Wed, Jan 13

jsji added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Wed, Jan 13, 9:14 AM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Address comments.

Wed, Jan 13, 9:12 AM · Restricted Project

Tue, Jan 12

jsji added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

@sfertile I have fixed the MC layer feature as well, please have another look. Thanks.

Tue, Jan 12, 1:24 PM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Update feature for MC Layer as well, also update encoding test to test triple.

Tue, Jan 12, 1:22 PM · Restricted Project
jsji added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Yes, this patch should only disable it for AIX.
See the changes in Taget Machine.
I don't know why you get that failure, I will check.

Tue, Jan 12, 10:37 AM · Restricted Project
jsji updated the diff for D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Rebase after landing D94449 to retrigger precommit tests.

Tue, Jan 12, 9:14 AM · Restricted Project
jsji committed rG93b54b7c6733: [PowerPC][NFCI] PassSubtarget to ASMWriter (authored by jsji).
[PowerPC][NFCI] PassSubtarget to ASMWriter
Tue, Jan 12, 8:26 AM
jsji closed D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter.
Tue, Jan 12, 8:26 AM · Restricted Project
jsji updated the summary of D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter.
Tue, Jan 12, 8:07 AM · Restricted Project
jsji retitled D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter from [PowerPC] PassSubtarget to ASMWriter to [PowerPC][NFCI] PassSubtarget to ASMWriter.
Tue, Jan 12, 7:56 AM · Restricted Project

Mon, Jan 11

jsji added a comment to D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

I have added a Predicates in https://reviews.llvm.org/D94458 for a similar mne, maybe you can rebase this to use that.

Mon, Jan 11, 3:13 PM · Restricted Project, Restricted Project
jsji added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

This depends on D94449.

Mon, Jan 11, 3:11 PM · Restricted Project
jsji requested review of D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Mon, Jan 11, 3:10 PM · Restricted Project
jsji requested review of D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter.
Mon, Jan 11, 1:53 PM · Restricted Project
jsji added a comment to D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

Can we try adding Predicates in InstAlias for xxspltd ?

Mon, Jan 11, 8:20 AM · Restricted Project, Restricted Project
jsji added a reviewer for D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX.: Restricted Project.
Mon, Jan 11, 8:19 AM · Restricted Project, Restricted Project
jsji accepted D94385: [NFC] Disallow unused prefixes in CodeGen/PowerPC tests..

LGTM , thanks for cleaning up .

Mon, Jan 11, 6:53 AM · Restricted Project

Tue, Jan 5

jsji committed rGf26bc0ddd508: [RegisterClassInfo] Return non-zero for RC without allocatable reg (authored by jsji).
[RegisterClassInfo] Return non-zero for RC without allocatable reg
Tue, Jan 5, 8:19 AM
jsji closed D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.
Tue, Jan 5, 8:19 AM · Restricted Project
jsji updated the diff for D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.

Update comments.

Tue, Jan 5, 7:51 AM · Restricted Project
jsji updated the diff for D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.

Add comments.

Tue, Jan 5, 7:42 AM · Restricted Project

Mon, Jan 4

jsji updated the diff for D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.

Address comments. Thanks Simon.

Mon, Jan 4, 9:14 AM · Restricted Project
jsji accepted D92071: [PowerPC] support register pressure reduction in machine combiner..

LGTM. Thanks.

Mon, Jan 4, 8:36 AM · Restricted Project
jsji added reviewers for D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg: RKSimon, craig.topper.
Mon, Jan 4, 7:06 AM · Restricted Project
jsji added a comment to D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.

Gentle ping...

Mon, Jan 4, 7:04 AM · Restricted Project
jsji added a reviewer for D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg: lkail.
Mon, Jan 4, 7:04 AM · Restricted Project

Fri, Jan 1

jsji added a comment to rGd1fd72343c6f: Refactor how -fno-semantic-interposition sets dso_local on default visibility….

@MaskRay Looks like this refactoring broke All ppc buildbots, please have a look or revert, thanks.

Fri, Jan 1, 6:46 AM

Wed, Dec 30

jsji added inline comments to D92071: [PowerPC] support register pressure reduction in machine combiner..
Wed, Dec 30, 6:51 AM · Restricted Project

Thu, Dec 24

jsji added a comment to rG759b8c11c398: [InstCombine] Handle different pointer types when folding gep of null.
In rG759b8c11c398c20f12503356f8aef604e0bf82be#967174, @nikic wrote:

@jsji Thanks for letting me know, I've reverted the change for now.

Thu, Dec 24, 7:34 AM

Wed, Dec 23

jsji added a comment to rG759b8c11c398: [InstCombine] Handle different pointer types when folding gep of null.

@nikic Looks like this commit (or previous 2 commits in InstCombine) is causing SEGV in stage2 compiler, breaking ppc64/lld/santizers muli-stage buildbots .

Wed, Dec 23, 8:43 PM
jsji added a comment to D89195: [PowerPC][Power10] Exploit store rightmost vector element instructions..
In D89195#2461459, @amyk wrote:

LGTM. Thanks for the update Albion.

Wed, Dec 23, 7:05 AM · Restricted Project, Restricted Project

Tue, Dec 22

jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

Yes, Clang still reject 5 operands, because that is what this patch should do. 😀

Tue, Dec 22, 4:16 PM · Restricted Project

Dec 17 2020

jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

@nickdesaulniers If you still find kernel using 2 operands tlbiel (not tlbie), can you please help to show what is the reason of using it? for what purpose does the Linux kernel use "tlbiel RB,RS"? Thanks.

Dec 17 2020, 7:33 PM · Restricted Project
jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

tlbie is different from tlbiel.

Dec 17 2020, 4:18 PM · Restricted Project
jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

Hmm...might be a while before we can test. Building ppc64le linux kernel with Clang's integrated assembler is a bit of a mess...
$ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang LLVM_IAS=1 -j71 powernv_defconfig
$ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang LLVM_IAS=1 -j71 arch/powerpc/mm/book3s64/hash_native.o
...(20+ errors emitted)...

Dec 17 2020, 1:51 PM · Restricted Project
jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.
In D92156#2459303, @nickdesaulniers wrote:

Regarding to usage in kernel, I think it depends on which arch are you building for, if it's with -mcpu=pwr9 and above, yes, I would recommend we update the code to use 5 operands basic form.

I haven't verified yet that -mcpu=pwr9 is being used, but it looks like the one TU that's using tlbie with 2 operands mixes the use of 2 and 5 operand variants without any kind of check from what I can tell. If that's the case, we might be able to do:

Dec 17 2020, 11:22 AM · Restricted Project
jsji committed rGab6cb31642fd: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass (authored by jsji).
[PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass
Dec 17 2020, 8:17 AM
jsji closed D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.
Dec 17 2020, 8:16 AM · Restricted Project
jsji updated the diff for D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.

Add comments about NDEBUG

Dec 17 2020, 7:11 AM · Restricted Project

Dec 16 2020

jsji added inline comments to D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.
Dec 16 2020, 8:36 PM · Restricted Project
jsji updated the diff for D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.

Update the NDEBUG

Dec 16 2020, 8:36 PM · Restricted Project
jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

Perhaps GNU assembler has a pseudo-instruction for this? If it's not used significantly throughout the Linux kernel, maybe we should change the kernel to use the canonical form of the instruction?

Dec 16 2020, 3:59 PM · Restricted Project
jsji added a comment to D92156: [PowerPC] Add support for "tlbiel" with two arguments.

I don't know where do you get the syntax of tlbiel with 2 operands.

Dec 16 2020, 1:18 PM · Restricted Project

Dec 15 2020

jsji added inline comments to D92071: [PowerPC] support register pressure reduction in machine combiner..
Dec 15 2020, 8:03 PM · Restricted Project
jsji added inline comments to D93099: [PowerPC] Select the D-Form load if we know its offset meets the requirement.
Dec 15 2020, 5:58 PM · Restricted Project
jsji updated the diff for D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.

Fix the include as well.

Dec 15 2020, 2:15 PM · Restricted Project
jsji updated the summary of D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.
Dec 15 2020, 1:13 PM · Restricted Project
jsji requested review of D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass.
Dec 15 2020, 1:12 PM · Restricted Project
jsji added a comment to D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.

Gentle ping...

Dec 15 2020, 11:24 AM · Restricted Project

Dec 11 2020

jsji committed rG9b05f1889aa8: [lld][PowerPC][test] Avoid flaky failures (authored by jsji).
[lld][PowerPC][test] Avoid flaky failures
Dec 11 2020, 11:47 AM
jsji closed D93128: [lld][PowerPC][test] Avoid flaky failures.
Dec 11 2020, 11:47 AM · Restricted Project
jsji updated the summary of D93128: [lld][PowerPC][test] Avoid flaky failures.
Dec 11 2020, 11:30 AM · Restricted Project
jsji added a comment to D93128: [lld][PowerPC][test] Avoid flaky failures.

Can you elaborate what happens?

Dec 11 2020, 10:09 AM · Restricted Project
jsji requested review of D93128: [lld][PowerPC][test] Avoid flaky failures.
Dec 11 2020, 9:26 AM · Restricted Project
jsji committed rGcf638f84a4ba: [PowerPC] Remove duplicate layout (authored by jsji).
[PowerPC] Remove duplicate layout
Dec 11 2020, 7:53 AM
jsji added a comment to D93099: [PowerPC] Select the D-Form load if we know its offset meets the requirement.

Although a refactor is coming, we should still avoid introducing more confusion if possible.
Please update the name and comments also. Thanks.

Dec 11 2020, 7:20 AM · Restricted Project

Dec 8 2020

jsji requested review of D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.
Dec 8 2020, 8:15 PM · Restricted Project
jsji committed rG45b08c41bfb0: [PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1 (authored by jsji).
[PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1
Dec 8 2020, 7:57 PM
jsji closed D92864: [PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1.
Dec 8 2020, 7:57 PM · Restricted Project
jsji added inline comments to D92089: [PowerPC] Materialize i64 constants by enumerated patterns..
Dec 8 2020, 7:39 PM · Restricted Project
jsji committed rG02b2c024193b: [PowerPC] Precommit testcases for regpressure compute fix (authored by jsji).
[PowerPC] Precommit testcases for regpressure compute fix
Dec 8 2020, 7:37 PM
jsji updated the summary of D92864: [PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1.
Dec 8 2020, 10:16 AM · Restricted Project
jsji added reviewers for D92864: [PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1: bsaleil, Restricted Project.
Dec 8 2020, 10:15 AM · Restricted Project
jsji requested review of D92864: [PowerPC] Set SubRegIndex offset for sub_vsx1/sub_pair1.
Dec 8 2020, 10:15 AM · Restricted Project

Dec 7 2020

jsji accepted D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.

Thanks , LGTM as it is per discussion.

Dec 7 2020, 9:52 AM · Restricted Project
jsji added inline comments to D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.
Dec 7 2020, 7:56 AM · Restricted Project
jsji committed rGb49b8f096c03: [PowerPC][Clang] Remove QPX support (authored by jsji).
[PowerPC][Clang] Remove QPX support
Dec 7 2020, 7:16 AM
jsji closed D92329: [PowerPC][Clang] Remove QPX support.
Dec 7 2020, 7:16 AM · Restricted Project, Restricted Project

Dec 5 2020

jsji added a comment to rG5582a7987662: [TargetMachine] Set dso_local if asan is detected.

In case you missed this due to previous failure in buildbot.

Dec 5 2020, 6:59 PM

Dec 4 2020

jsji added inline comments to D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND.
Dec 4 2020, 2:25 PM · Restricted Project
jsji committed rGc8ec685ca555: [llvm-exegesis][PowerPC] Add more register classes (authored by jsji).
[llvm-exegesis][PowerPC] Add more register classes
Dec 4 2020, 7:02 AM
jsji closed D88044: [llvm-exegesis][PowerPC] Add more register classes.
Dec 4 2020, 7:02 AM · Restricted Project

Dec 1 2020

jsji accepted D92278: [Clang] Don't adjust align for IBM extended double type.

LGTM. Thanks.

Dec 1 2020, 9:05 PM · Restricted Project

Nov 30 2020

jsji accepted D92070: [PowerPC] [NFC] code refactor: split IsReassociable to fma and add. .

LGTM. Please fix the clang-format warning. Thanks.

Nov 30 2020, 1:41 PM · Restricted Project
jsji updated the diff for D92329: [PowerPC][Clang] Remove QPX support.

Fix llvm test as well

Nov 30 2020, 9:35 AM · Restricted Project, Restricted Project
jsji added a comment to D88044: [llvm-exegesis][PowerPC] Add more register classes.

Thanks @qiucf for looking into this.

Nov 30 2020, 9:20 AM · Restricted Project
jsji edited reviewers for D92329: [PowerPC][Clang] Remove QPX support, added: steven.zhang; removed: • qshanz.
Nov 30 2020, 8:31 AM · Restricted Project, Restricted Project
jsji added reviewers for D92329: [PowerPC][Clang] Remove QPX support: Restricted Project, qiucf, • qshanz.
Nov 30 2020, 8:31 AM · Restricted Project, Restricted Project
jsji requested review of D92329: [PowerPC][Clang] Remove QPX support.
Nov 30 2020, 8:30 AM · Restricted Project, Restricted Project
jsji added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Nov 30 2020, 7:37 AM · Restricted Project

Nov 24 2020

jsji accepted D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.

LGTM. Some comment update please.

Nov 24 2020, 8:00 AM · Restricted Project
jsji added a comment to D88044: [llvm-exegesis][PowerPC] Add more register classes.

Ping.. Any further comments?

Nov 24 2020, 6:06 AM · Restricted Project

Nov 9 2020

jsji added a reviewer for D90498: Fix the compilation assertion due to unreachable BB pruning not deleting the associated BB from the jump tables: Restricted Project.
Nov 9 2020, 8:42 AM · Restricted Project

Nov 8 2020

jsji accepted D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics.

LGTM. Thanks.

Nov 8 2020, 7:59 PM · Restricted Project

Nov 6 2020

jsji accepted D87384: [PowerPC] Add ISEL patterns for Mul with Imm..

LGTM. Thanks for improving this!

Nov 6 2020, 7:52 AM · Restricted Project

Nov 4 2020

jsji added a comment to D88044: [llvm-exegesis][PowerPC] Add more register classes.

Ping.. Any further comments?

Nov 4 2020, 7:12 AM · Restricted Project

Nov 2 2020

jsji added a comment to D90645: [zorg][PowerPC] Don't checkout compiler-rt for runtime build.

@gkistanova When do we reconfig build master to pickup new changes? Is it done automatically or manually? Thanks.

Nov 2 2020, 6:43 PM
jsji committed rZORG1564bf28b493: [zorg][PowerPC] Don't checkout compiler-rt for runtime build (authored by jsji).
[zorg][PowerPC] Don't checkout compiler-rt for runtime build
Nov 2 2020, 1:54 PM
jsji closed D90645: [zorg][PowerPC] Don't checkout compiler-rt for runtime build.
Nov 2 2020, 1:54 PM