Page MenuHomePhabricator

jsji (Jinsong Ji)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2017, 10:26 AM (72 w, 3 d)

Recent Activity

Thu, May 16

jsji requested changes to D61930: [PowerPC] Add a specific heuristic to schedule the addi before the load.

I think we should update the title or summary to indicate that this is P9 only.

Thu, May 16, 3:00 PM · Restricted Project
jsji added a comment to D61935: Fixes PPC64 Tbegin disassembling.

You can have a look at llvm/test/MC/Disassembler/PowerPC

Thu, May 16, 12:07 PM · Restricted Project

Wed, May 15

jsji added a comment to D61935: Fixes PPC64 Tbegin disassembling.

@catenacyber Can you please include a testcase for MC please?

Wed, May 15, 2:26 PM · Restricted Project

Tue, May 14

jsji updated subscribers of D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

Some more nit-picker, other than that, mostly good to me.

Tue, May 14, 8:00 AM · Restricted Project

Mon, May 13

jsji committed rGb7b3d866a402: [PowerPC][NFC] Fix typos in triples (authored by jsji).
[PowerPC][NFC] Fix typos in triples
Mon, May 13, 8:11 PM
jsji committed rL360643: [PowerPC][NFC] Fix typos in triples.
[PowerPC][NFC] Fix typos in triples
Mon, May 13, 8:11 PM
jsji removed a reviewer for D61873: [PowerPC] P9 Scheduling Model: dispatching rule fixes: llvm-commits.
Mon, May 13, 1:59 PM · Restricted Project
jsji created D61873: [PowerPC] P9 Scheduling Model: dispatching rule fixes.
Mon, May 13, 1:59 PM · Restricted Project

Thu, May 9

jsji added a comment to D61658: [PowerPC] Emit XXSEL for vec_sel and code that has the same pattern.

Have we thought about adding support in DAGCombine or even InstCombine to combine into ISD::VSELECT too?

Thu, May 9, 9:00 PM · Restricted Project

Tue, May 7

jsji committed rGcc63db4ff0f9: [PowerPC][NFC] Update build-vector-tests.ll using utils/update_llc_test_checks. (authored by jsji).
[PowerPC][NFC] Update build-vector-tests.ll using utils/update_llc_test_checks.
Tue, May 7, 10:29 AM
jsji committed rL360175: [PowerPC][NFC] Update build-vector-tests.ll using utils/update_llc_test_checks..
[PowerPC][NFC] Update build-vector-tests.ll using utils/update_llc_test_checks.
Tue, May 7, 10:28 AM

Tue, Apr 30

jsji added inline comments to D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.
Tue, Apr 30, 7:23 PM · Restricted Project

Mon, Apr 29

jsji added a parent revision for D61228: [PowerPC] Set the innermost hot loop(from PGO) to align 32 bytes: D61227: [NFC]][PowerPC] Use -check-prefixes to simplify the check in code-align.ll.
Mon, Apr 29, 7:33 AM · Restricted Project
jsji added a child revision for D61227: [NFC]][PowerPC] Use -check-prefixes to simplify the check in code-align.ll: D61228: [PowerPC] Set the innermost hot loop(from PGO) to align 32 bytes.
Mon, Apr 29, 7:33 AM · Restricted Project
jsji added parent revisions for D61250: [PowerPC] Forward the scheduling state for PowerPC target: D59480: [NFC] Add SchedState to allow forwarding the Scheduling state between MBB, D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB.
Mon, Apr 29, 7:31 AM · Restricted Project
jsji added a child revision for D59480: [NFC] Add SchedState to allow forwarding the Scheduling state between MBB: D61250: [PowerPC] Forward the scheduling state for PowerPC target.
Mon, Apr 29, 7:31 AM · Restricted Project
jsji added a child revision for D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB: D61250: [PowerPC] Forward the scheduling state for PowerPC target.
Mon, Apr 29, 7:31 AM · Restricted Project
jsji added a child revision for D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB: D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure.
Mon, Apr 29, 7:28 AM · Restricted Project
jsji added a parent revision for D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure: D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB.
Mon, Apr 29, 7:28 AM · Restricted Project
jsji added a reviewer for D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure: jsji.
Mon, Apr 29, 7:28 AM · Restricted Project
jsji added a reviewer for D61250: [PowerPC] Forward the scheduling state for PowerPC target: jsji.
Mon, Apr 29, 7:26 AM · Restricted Project

Fri, Apr 26

jsji retitled D61169: [CodeGenPrepare] Don't split the store if it is volatile from [CodeGen] When split the store, get the volatile flag from the old store to [CodeGenPrepare] When split the store, get the volatile flag from the old store.
Fri, Apr 26, 8:11 AM · Restricted Project

Wed, Apr 24

jsji committed rG12450d51a2fe: [PowerPC][NFC]Update licence to Apache 2 (authored by jsji).
[PowerPC][NFC]Update licence to Apache 2
Wed, Apr 24, 7:39 PM
jsji committed rC359164: [PowerPC][NFC]Update licence to Apache 2.
[PowerPC][NFC]Update licence to Apache 2
Wed, Apr 24, 7:38 PM
jsji committed rL359164: [PowerPC][NFC]Update licence to Apache 2.
[PowerPC][NFC]Update licence to Apache 2
Wed, Apr 24, 7:38 PM

Tue, Apr 23

jsji added a comment to D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.

Thanks @MaskRay for help fixing and review!

Tue, Apr 23, 8:01 AM · Restricted Project
jsji added a comment to D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.

May I ask why the mmintrin.h emulation layer must be added to the clang resource directory? Why can't it be provided as a standalone library like https://github.com/intel/ARM_NEON_2_x86_SSE ?

Tue, Apr 23, 7:44 AM · Restricted Project

Apr 18 2019

jsji added a comment to D60811: [PowerPC] Fix wrong ElemSIze when calling isConsecutiveLS().

please fix the code so it's clear that check is happening.

Apr 18 2019, 3:46 PM · Restricted Project
jsji added a comment to D60811: [PowerPC] Fix wrong ElemSIze when calling isConsecutiveLS().
For vectors where the element type is not byte-sized, loads can't be "consecutive" in the sense of this function; the store size of `<2 x i1>` is one byte.
Apr 18 2019, 3:19 PM · Restricted Project

Apr 17 2019

jsji accepted D60811: [PowerPC] Fix wrong ElemSIze when calling isConsecutiveLS().

LGTM. Thanks for reducing the testcase and fixing!

Apr 17 2019, 8:39 PM · Restricted Project

Apr 16 2019

jsji added inline comments to D60160: [PowerPC] Update P9 vector costs for insert/extract element.
Apr 16 2019, 10:57 AM · Restricted Project

Apr 15 2019

jsji accepted D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.

LGTM. Thanks for porting!

Apr 15 2019, 12:35 PM · Restricted Project
jsji added a comment to D60160: [PowerPC] Update P9 vector costs for insert/extract element.

Some comments related to testcases.

Apr 15 2019, 12:12 PM · Restricted Project

Apr 12 2019

jsji added inline comments to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).
Apr 12 2019, 2:55 PM · Restricted Project

Apr 11 2019

jsji accepted D60248: [PowerPC] Add initialization for some ppc passes .

LGTM, Thanks for fixing this.

Apr 11 2019, 1:13 PM · Restricted Project
jsji retitled D60248: [PowerPC] Add initialization for some ppc passes from [PowerPC] Add initilization for some ppc passes to [PowerPC] Add initialization for some ppc passes .
Apr 11 2019, 1:13 PM · Restricted Project
jsji updated subscribers of D60564: Changes for LLVM PPCISelLowering function combineBVOfConsecutiveLoads.

@ZhangKang Looks like the patch is suggested by you? Do you have any testcases that can validate this?
And also are you able to reproduce (and narrow down) the problem before suggesting the patch?

Apr 11 2019, 8:01 AM · Restricted Project

Apr 9 2019

jsji requested changes to D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.

Please make sure you run all test before updating patch!

Apr 9 2019, 1:04 PM · Restricted Project

Apr 8 2019

jsji accepted D60177: [PowerPC] initialize SchedModel according to platform.

LGTM. Thanks for fixing this bug.

Apr 8 2019, 8:20 AM · Restricted Project
jsji requested changes to D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power.

Since we are adding new headers that is not originated by this patch,
please also update the description (and commit message) to include who actually contributed to mmintrin.h and other headers.
eg:headers are mostly based on headers developed by Steven Munroe, with some contribution of Paul Clarke, Bill Schmidt, Jinsong, Zeson.

Apr 8 2019, 8:09 AM · Restricted Project

Apr 5 2019

jsji added a reviewer for D60181: [PowerPC] More precise exploitation of P9 maddld instruction when operands are constant: shchenz.
Apr 5 2019, 7:48 AM · Restricted Project

Apr 4 2019

jsji accepted D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.

LGTM. Thanks for refactoring.

Apr 4 2019, 8:49 AM · Restricted Project

Apr 3 2019

jsji added inline comments to D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.
Apr 3 2019, 1:16 PM · Restricted Project
jsji added inline comments to D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.
Apr 3 2019, 12:20 PM · Restricted Project

Mar 29 2019

jsji accepted D59633: [PowerPC] Look through copies for compare elimination.

LGTM.

Mar 29 2019, 7:20 AM · Restricted Project

Mar 28 2019

jsji added inline comments to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).
Mar 28 2019, 2:17 PM · Restricted Project
jsji added a parent revision for D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries: D59881: Initial support for vectorization using MASSV (IBM MASS vector library).
Mar 28 2019, 2:10 PM · Restricted Project
jsji added a child revision for D59881: Initial support for vectorization using MASSV (IBM MASS vector library): D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries.
Mar 28 2019, 2:10 PM · Restricted Project
jsji requested changes to D59633: [PowerPC] Look through copies for compare elimination.

Might miss some opportunity related to parameters instead. Please have a look. Thanks.

Mar 28 2019, 2:02 PM · Restricted Project
jsji accepted D59403: [PowerPC] Add the support for __builtin_setrnd() in clang.

LGTM.

Mar 28 2019, 12:18 PM · Restricted Project
jsji accepted D59405: [PowerPC] Add the support for __builtin_setrnd().

LGTM, with some comment change please. Thanks.

Mar 28 2019, 12:17 PM · Restricted Project
jsji accepted D58950: [PowerPC] Strength reduction of multiply by a constant by shift and add/sub in place.

LGTM. Thanks for exploiting.

Mar 28 2019, 7:59 AM · Restricted Project
jsji added reviewers for D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power: kbarton, wschmidt.
Mar 28 2019, 7:00 AM · Restricted Project

Mar 27 2019

jsji added a reviewer for D59874: [PR41247] Fixed parsing of private keyword in C++: hubert.reinterpretcast.
Mar 27 2019, 6:34 AM · Restricted Project

Mar 26 2019

jsji added a comment to D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode.

Looks like this may cause some unexpected failures. See https://bugs.llvm.org/show_bug.cgi?id=41247 for more details.

Mar 26 2019, 2:03 PM · Restricted Project
jsji added inline comments to D58950: [PowerPC] Strength reduction of multiply by a constant by shift and add/sub in place.
Mar 26 2019, 7:41 AM · Restricted Project

Mar 25 2019

jsji accepted D59284: [NFC][PowerPC] Custom PowerPC specific machine-scheduler.

LGTM, except for some minor comments change.
Thanks for extending this, it will allow us to tune MachineScheduler specifically for PowerPC going forward.

Mar 25 2019, 11:53 AM · Restricted Project
jsji added a comment to D58950: [PowerPC] Strength reduction of multiply by a constant by shift and add/sub in place.

Thanks for updating! @wuzish However, I am even more confused by your new comments.

Mar 25 2019, 8:07 AM · Restricted Project
jsji added a reviewer for D59480: [NFC] Add SchedState to allow forwarding the Scheduling state between MBB: jonpa.
Mar 25 2019, 6:53 AM · Restricted Project

Mar 21 2019

jsji accepted D58685: [PowerPC] Remove UseVSXReg.

Thought we are waiting for @nemanjai 's insight about line 167... But LGTM given that you have run full test.
Thanks for improving this.

Mar 21 2019, 11:39 AM · Restricted Project
jsji added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.
Mar 21 2019, 7:01 AM · Restricted Project
jsji added a comment to D56382: Change llvm call once check for building Swift for PowerPC(ppc64le).

@sarveshtamba As the author mentioned, yes, this has been upstreamed.

Mar 21 2019, 6:57 AM · Restricted Project

Mar 20 2019

jsji added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

I am not familiar with swift development process,
but looks like you should be able to dump LLVM IR passing -emit-ir -Xfrontend -disable-llvm-optzns according to https://github.com/apple/swift/blob/master/docs/DebuggingTheCompiler.rst#printing-the-intermediate-representations.
And you may try to reduce the SIL first using bug_reducer. https://github.com/apple/swift/blob/master/docs/DebuggingTheCompiler.rst#reducing-sil-test-cases-using-bug-reducer

Mar 20 2019, 8:06 AM · Restricted Project

Mar 18 2019

jsji added a reviewer for D59480: [NFC] Add SchedState to allow forwarding the Scheduling state between MBB: jsji.
Mar 18 2019, 8:13 AM · Restricted Project

Mar 15 2019

jsji added a comment to D58950: [PowerPC] Strength reduction of multiply by a constant by shift and add/sub in place.

Comments mostly related to comments and testcases.

Mar 15 2019, 2:51 PM · Restricted Project

Mar 14 2019

jsji added a comment to D59403: [PowerPC] Add the support for __builtin_setrnd() in clang.

Apparently missing some files.

Mar 14 2019, 8:16 PM · Restricted Project
jsji added a parent revision for D59403: [PowerPC] Add the support for __builtin_setrnd() in clang: D59405: [PowerPC] Add the support for __builtin_setrnd().
Mar 14 2019, 8:11 PM · Restricted Project
jsji added a child revision for D59405: [PowerPC] Add the support for __builtin_setrnd(): D59403: [PowerPC] Add the support for __builtin_setrnd() in clang.
Mar 14 2019, 8:11 PM · Restricted Project
jsji requested changes to D59403: [PowerPC] Add the support for __builtin_setrnd() in clang.

Apparently missing some files.

Mar 14 2019, 8:01 PM · Restricted Project
jsji added a comment to D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE.

@dblaikie, anyone you know who can help here?

@sarveshtamba
Can you produce a reduced testcase that can show the problem?
Then I can find someone who can help to have a look.
Since this is an assert, I think it should not be too hard to create a reduce testcase using bugpoint.

Mar 14 2019, 11:28 AM · Restricted Project

Mar 12 2019

jsji committed rG9dc2c1d564b2: Set useful flags for vector imm setting instructions (authored by jsji).
Set useful flags for vector imm setting instructions
Mar 12 2019, 11:27 AM
jsji committed rL355948: Set useful flags for vector imm setting instructions.
Set useful flags for vector imm setting instructions
Mar 12 2019, 11:26 AM
jsji closed D58645: [PowerPC] Set useful flags for vector imm setting instructions.
Mar 12 2019, 11:26 AM · Restricted Project
jsji updated the diff for D58645: [PowerPC] Set useful flags for vector imm setting instructions.

No-relevant testcase update committed in NFC patch https://reviews.llvm.org/rL355945 first.
Update patch to show relevant changes only.

Mar 12 2019, 11:15 AM · Restricted Project
jsji committed rGb6bfcfc847af: [NFC][PowerPC] Update testcases using utils/update_llc_test_checks.py (authored by jsji).
[NFC][PowerPC] Update testcases using utils/update_llc_test_checks.py
Mar 12 2019, 10:57 AM
jsji committed rL355945: [NFC][PowerPC] Update testcases using utils/update_llc_test_checks.py.
[NFC][PowerPC] Update testcases using utils/update_llc_test_checks.py
Mar 12 2019, 10:56 AM
jsji updated the diff for D58645: [PowerPC] Set useful flags for vector imm setting instructions.

Update testcases(pr36292.ll) to reflect upstream changes.

Mar 12 2019, 8:20 AM · Restricted Project
jsji committed rG06bee01d2bc7: [NFC][PowerPC]Assert when trying to generate directmove below P8. (authored by jsji).
[NFC][PowerPC]Assert when trying to generate directmove below P8.
Mar 12 2019, 7:01 AM
jsji committed rL355920: [NFC][PowerPC]Assert when trying to generate directmove below P8..
[NFC][PowerPC]Assert when trying to generate directmove below P8.
Mar 12 2019, 7:00 AM

Mar 11 2019

jsji committed rGc6063e83d50a: [NFC][PowerPC] Add comment for PPCAsmPrinter::printOperand (authored by jsji).
[NFC][PowerPC] Add comment for PPCAsmPrinter::printOperand
Mar 11 2019, 10:57 AM
jsji committed rL355848: [NFC][PowerPC] Add comment for PPCAsmPrinter::printOperand.
[NFC][PowerPC] Add comment for PPCAsmPrinter::printOperand
Mar 11 2019, 10:57 AM
jsji added a comment to D58645: [PowerPC] Set useful flags for vector imm setting instructions.

Ping...

Mar 11 2019, 6:53 AM · Restricted Project

Mar 7 2019

jsji committed rGde3348ae3f01: [PowerPC] Run clang format to avoid compiling warning. (authored by jsji).
[PowerPC] Run clang format to avoid compiling warning.
Mar 7 2019, 10:55 AM
jsji committed rL355623: [PowerPC] Run clang format to avoid compiling warning..
[PowerPC] Run clang format to avoid compiling warning.
Mar 7 2019, 10:54 AM

Mar 6 2019

jsji added reviewers for D58645: [PowerPC] Set useful flags for vector imm setting instructions: steven.zhang, wuzish.
Mar 6 2019, 7:28 AM · Restricted Project

Mar 5 2019

jsji added a reviewer for D58949: [NFC] Declare the member data of class PostGenericScheduler as "protected" instead of "private": jonpa.
Mar 5 2019, 11:07 AM · Restricted Project
jsji edited reviewers for D58949: [NFC] Declare the member data of class PostGenericScheduler as "protected" instead of "private", added: MatzeB, javed.absar; removed: jsji.
Mar 5 2019, 6:50 AM · Restricted Project

Mar 4 2019

jsji accepted D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

LGTM, except some minor update. Thanks for fixing!

Mar 4 2019, 8:09 AM · Restricted Project
jsji added a comment to D58645: [PowerPC] Set useful flags for vector imm setting instructions.

Ping~

Mar 4 2019, 6:40 AM · Restricted Project

Mar 3 2019

jsji added a comment to D58685: [PowerPC] Remove UseVSXReg.

Thanks for addressing comments, however, I am still not convinced that this is safe.

Mar 3 2019, 9:04 PM · Restricted Project

Feb 26 2019

jsji added a comment to D58685: [PowerPC] Remove UseVSXReg.

I like the idea of trying to use register class to avoid using UseVSXReg flag.

Feb 26 2019, 3:36 PM · Restricted Project

Feb 25 2019

jsji created D58645: [PowerPC] Set useful flags for vector imm setting instructions.
Feb 25 2019, 1:42 PM · Restricted Project
jsji added a comment to D58614: Fixed a typo in the test s/CEHCK/CHECK/.

Why is CHECK-NEXT not being used?
Why is ./utils/update_llc_test_checks.py not being used? That dramatically reduces chances of things like this, and spares one from actually having to manually write proper check lines. (thus improves test coverage. one will of course still need to verify that the checks are correct.)

Feb 25 2019, 12:52 PM · Restricted Project
Herald added a project to D54649: [FPEnv] Rough out constrained FCmp intrinsics: Restricted Project.
Feb 25 2019, 10:44 AM · Restricted Project
jsji added inline comments to rL354438: [NFC] add/modify wrapper function for findRegisterDefOperand()..
Feb 25 2019, 8:02 AM
jsji requested changes to D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.

Thanks for quick update, some more comments.

Feb 25 2019, 7:37 AM · Restricted Project
jsji accepted D58614: Fixed a typo in the test s/CEHCK/CHECK/.

LGTM. Thanks for catching this, I am surprised that those typos slipped through ... FYI. @HLJ2009

Feb 25 2019, 7:00 AM · Restricted Project

Feb 22 2019

jsji requested changes to D58428: [PowerPC] fix killed/dead flag after reg+reg to reg+imm transformation.
Feb 22 2019, 1:31 PM · Restricted Project
jsji accepted D58430: [PowerPC] Enhance the fast selection of fptoi & fptrunc instruction and clean up related asserts.

LGTM, except minor comments update.

Feb 22 2019, 7:59 AM · Restricted Project

Feb 19 2019

jsji committed rG58bab8e690b5: PowerPC: Fix typos in comments (authored by jsji).
PowerPC: Fix typos in comments
Feb 19 2019, 1:26 PM