User Details
- User Since
- Feb 23 2020, 3:46 PM (123 w, 2 d)
Mon, Jun 27
Wed, Jun 15
LGTM, thanks.
LGTM.
Tue, Jun 14
Thanks for addressing all the comments! Looks good to me now except for a couple minor things.
Mon, Jun 13
A general question about the design as I read more into the code. I was trying to figure out if a FunctionSample, its SampleContext and ContextTrieNode stick together as a whole, as also commented in another place. It seems to me multiple FunctionSamples can share the ContextTrieNode. Am I correct? What is the reason for this?
Sat, Jun 11
Fri, Jun 10
Updating D121651: [llvm-profdata] Convert nested profile to CS flat profile.
LGTM.
LGTM, thanks for addressing the feedbacks!
Thu, Jun 9
Wed, Jun 8
Thanks for sharing more about the context and the background, @kazu
Updating D121651: [llvm-profdata] Convert nested profile to CS flat profile.
Updating D121651: [llvm-profdata] Convert nested profile to CS flat profile.
Updating D126434: [PseudoProbe] Use callee name as callsite identfier for MCDecodedPseudoProbeInlineTree.
Mon, Jun 6
Would be good to have some numbers for build time and memory usage in the summary.
Jun 5 2022
May 25 2022
May 19 2022
May 16 2022
Rebasing.
Performance testing came back neutral, with a 99.962% profile similarity.
May 15 2022
May 13 2022
Updating D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller.
May 12 2022
Updating D122609: [llvm-profgen] Update callsite body samples by summing up all call target samples.
Updating D122609: [llvm-profgen] Update callsite body samples by summing up all call target samples.
Updating D122609: [llvm-profgen] An option to update callsite body samples by summing up all call target samples.
Updating D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller.
May 11 2022
Updating D123361: [llvm-profgen] Filter out oversized LBR ranges.
May 10 2022
LGTM with a minor suggestion.
May 9 2022
Updating D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller.
Extending test to check scaling.
Our experiment on one internal service showed that the context key's memory can be reduced from 80GB to 300MB.