• Address comments + change delegate's opcode

Thanks for the review, and sorry for delayed reply.

Address comments

Fix duplicate __clang_call_terminate call case

CATCH -> CATCH_ALL in comment

Delete declare void @_ZSt9terminatev()

In D94039#2480002, @tlively wrote:

In the description I think "but LLVM does not have a way of that kind of behavior" is missing the word "modeling" => "but LLVM does not have a way of modeling that kind of behavior"

Remove an extra word

Revert clang-format for MachineValueType.h

Thanks for the explanation! LGTM % the alignment nit

Nice!

Nice!

Thanks for the info!

Wow, I didn't know we can do OOP in TableGen! (Are these new functionalities?)

Yeah I think that should be fine.

Oh, I see what you mean. LGTM and I don't think we need a more complicated approach at the moment.

Add missing COPY opcode handling in Peephole

Fix signature

Add tests to test reference types in params and results

Fix a typo

Add missing reference types in utility functions

In D91574#2403954, @shafik wrote:

I think your CMakeLists.txt broke the green dragon build: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/24893/consoleFull#349140555e9a0fee5-ebcc-4238-a641-c5aa112c323e

It is not obvious to me what the problem is though.

LGTM. Do you have commit access? If not, I can commit this for you. You can also provide your name and email address if you want, so that I can use your info for the commit, as described here: https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator

It seems we have inline asm tests here: https://github.com/llvm/llvm-project/blob/master/llvm/test/CodeGen/WebAssembly/inline-asm.ll

I guess that optimization cannot be done here and should be done later? And there's also an existing TODO to generalize this optimization. Maybe we can do it as a part of the 'generalization' later? But I also doubt how worthwhile it will be, given that this bug was found first time 5 years after this part of the code was first written...

• Fix comment wrapping