- User Since
- Jul 29 2016, 12:33 AM (309 w, 5 d)
Tue, Jun 21
Also changed ptr to integer pointers because it requires an additional arguments in the opt command line.
Mon, Jun 20
Fri, Jun 17
(Also we can't just always require the presence of e.g. the
function or global sections, because a binary may just have any functions.
There's only an problem if the name or linking section tries to name a
Wed, Jun 15
Tue, Jun 14
Mon, Jun 13
Wed, Jun 8
Mon, Jun 6
What do you think about this line in https://reviews.llvm.org/D126509#3561435? Not something important either though.....
# CHECK-NOT: - Type: TYPE
May 19 2022
May 18 2022
@CarlosAlbertoEnciso That's great news! Thank you for letting me know.
May 17 2022
May 16 2022
Add getRequiredProperties call to OptimizeLiveIntervals
May 13 2022
The script doesn't generate CHECK lines next to each BB but rather generates the whole function together, making it harder to see changes in each BB for me. Also there are comments for CHECK lines, which will be lost if we use the script. So I'm not sure using it will improve readability in this case.
May 12 2022
Closing in favor of D125515.
Remove a stray line
Thanks! I have one more question but don't want to hold this back with nitpicky things. (The review turnaround time due to time zone doesn't help either)
May 11 2022
Is this tool still planned to be upstreamed? Is this patch the most up-to-date version of this tool, or there is another repo? How is this CL related to https://github.com/SNSystems/DIVA?
May 10 2022
Mar 17 2022
Mar 16 2022
I wasn't able to check performances for real-world programs myself, but there's no changes in our existing tests. I don't think it will have a huge impact because I made the condition fairly specific: we bail out only when it is a build_vector and the DAG is already type-legalized and legalized, meaning it does so only in the very last stage before instruction selection. Also I'm not sure if there's any other way around this at this point.
Mar 15 2022
Feb 28 2022
Feb 17 2022
Oh that fixed my error. Thanks!
Yes, all three also fail with LLVM ToT.
Feb 16 2022
Then I'll just land this first and make the discussed changes as a follow-up. Thanks!
Feb 15 2022
Feb 14 2022
These global TLS symbols are shared across all shared libraries and cannot be assumed to be local to the currently module.