Page MenuHomePhabricator
People aheejin

aheejin (Heejin Ahn)
Bot

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (356 w, 6 d)

Recent Activity
View All

Tue, May 30

aheejin added a comment to D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.

Gentle ping 😀

Tue, May 30, 4:25 PM · Restricted Project, Restricted Project

Mon, May 22

aheejin updated the diff for D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.

Use different variables for different regs

Mon, May 22, 5:32 PM · Restricted Project, Restricted Project
aheejin added inline comments to D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.
Mon, May 22, 5:32 PM · Restricted Project, Restricted Project
aheejin updated the diff for D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.

Make LLVM_ENABLE_EXPENSIVE_CHECKS work

Mon, May 22, 12:06 PM · Restricted Project, Restricted Project
aheejin updated the diff for D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.

Fix tests

Mon, May 22, 11:00 AM · Restricted Project, Restricted Project
aheejin updated the summary of D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.
Mon, May 22, 10:53 AM · Restricted Project, Restricted Project
aheejin requested review of D151125: [WebAssembly] Undef invalid DBG_VALUEs after RegColoring.
Mon, May 22, 10:48 AM · Restricted Project, Restricted Project

Thu, May 18

aheejin committed rG3eccb40fa983: [RegisterCoalescer] Remove DbgMergedVRegNums (NFC) (authored by aheejin).
[RegisterCoalescer] Remove DbgMergedVRegNums (NFC)
Thu, May 18, 4:03 PM · Restricted Project, Restricted Project
aheejin closed D150606: [RegisterCoalescer] Remove DbgMergedVRegNums (NFC).
Thu, May 18, 4:03 PM · Restricted Project, Restricted Project
aheejin committed rG2dd349428bf0: [DebugInfo][InstrRef] Prettyprint metadata (authored by aheejin).
[DebugInfo][InstrRef] Prettyprint metadata
Thu, May 18, 4:02 PM · Restricted Project, Restricted Project
aheejin closed D150620: [DebugInfo][InstrRef] Prettyprint metadata.
Thu, May 18, 4:02 PM · Restricted Project, Restricted Project
aheejin added a comment to D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions..

Nice! Just some drive-by nitpicking, sorry 😅

Thu, May 18, 2:08 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 17

aheejin accepted D150833: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD.
Wed, May 17, 5:59 PM · Restricted Project, Restricted Project

Mon, May 15

aheejin requested review of D150620: [DebugInfo][InstrRef] Prettyprint metadata.
Mon, May 15, 3:20 PM · Restricted Project, Restricted Project
aheejin requested review of D150606: [RegisterCoalescer] Remove DbgMergedVRegNums (NFC).
Mon, May 15, 1:14 PM · Restricted Project, Restricted Project

Fri, May 12

Herald added a project to D64630: [DebugInfo] Address performance regression with r364515: Restricted Project.
Fri, May 12, 5:44 PM · Restricted Project, Restricted Project

Apr 12 2023

aheejin committed rGd20a1b87f689: [WebAssembly] Handle DebugLoc in DebugValueManager (authored by aheejin).
[WebAssembly] Handle DebugLoc in DebugValueManager
Apr 12 2023, 11:48 PM · Restricted Project, Restricted Project
aheejin closed D148115: [WebAssembly] Handle DebugLoc in DebugValueManager.
Apr 12 2023, 11:47 PM · Restricted Project, Restricted Project
aheejin updated the diff for D148115: [WebAssembly] Handle DebugLoc in DebugValueManager.

Typo fix

Apr 12 2023, 11:46 PM · Restricted Project, Restricted Project
aheejin accepted D148054: [WebAssembly] `AsmTypeCheck` support to br instr.
Apr 12 2023, 11:37 PM · Restricted Project, Restricted Project
aheejin added inline comments to D148054: [WebAssembly] `AsmTypeCheck` support to br instr.
Apr 12 2023, 8:50 AM · Restricted Project, Restricted Project
aheejin requested review of D148115: [WebAssembly] Handle DebugLoc in DebugValueManager.
Apr 12 2023, 4:42 AM · Restricted Project, Restricted Project

Apr 11 2023

aheejin added a comment to D148054: [WebAssembly] `AsmTypeCheck` support to br instr.

Thanks for the simplified version!

Apr 11 2023, 11:01 PM · Restricted Project, Restricted Project
aheejin accepted D147884: [NFC] format llvm/lib/Target/WebAssembly/AsmParser.
Apr 11 2023, 3:46 AM · Restricted Project, Restricted Project
aheejin added a comment to D147504: [WebAssembly] `AsmTypeCheck` support to br instr.

D147852 landed, so please rebase onto main and resolve conflicts.

Apr 11 2023, 3:46 AM · Restricted Project, Restricted Project
aheejin committed rG86c65fc4aa78: [WebAssembly] Correctly check end_if/end_try with else/catch (authored by aheejin).
[WebAssembly] Correctly check end_if/end_try with else/catch
Apr 11 2023, 2:08 AM · Restricted Project, Restricted Project
aheejin closed D147881: [WebAssembly] Correctly check end_if/end_try with else/catch.
Apr 11 2023, 2:08 AM · Restricted Project, Restricted Project
aheejin committed rG3e9881b92b09: [WebAssembly] Handle block-like structures consistently in type checker (authored by aheejin).
[WebAssembly] Handle block-like structures consistently in type checker
Apr 11 2023, 2:07 AM · Restricted Project, Restricted Project
aheejin closed D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 11 2023, 2:07 AM · Restricted Project, Restricted Project
aheejin committed rG8c0798f36835: [WebAssembly] Fix type index block type handling in type checker (authored by aheejin).
[WebAssembly] Fix type index block type handling in type checker
Apr 11 2023, 2:06 AM · Restricted Project, Restricted Project
aheejin closed D147837: [WebAssembly] Fix type index block type handling in type checker.
Apr 11 2023, 2:05 AM · Restricted Project, Restricted Project

Apr 9 2023

aheejin updated the diff for D147881: [WebAssembly] Correctly check end_if/end_try with else/catch.

Rename a function

Apr 9 2023, 7:39 AM · Restricted Project, Restricted Project
aheejin added inline comments to D147504: [WebAssembly] `AsmTypeCheck` support to br instr.
Apr 9 2023, 6:26 AM · Restricted Project, Restricted Project
aheejin added inline comments to D147504: [WebAssembly] `AsmTypeCheck` support to br instr.
Apr 9 2023, 6:23 AM · Restricted Project, Restricted Project
aheejin added a comment to D147504: [WebAssembly] `AsmTypeCheck` support to br instr.

This will have conflicts with D147852, so depending on which lands first, the other needs to resolve them. D147852 doesn't intend to add new functionalities (like br checking here) though; it just handles other block-ending instructions in the same way as end_block.

Apr 9 2023, 6:18 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147881: [WebAssembly] Correctly check end_if/end_try with else/catch.

Rebase

Apr 9 2023, 5:10 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

Add one more test

Apr 9 2023, 5:08 AM · Restricted Project, Restricted Project
aheejin updated the summary of D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 9 2023, 5:06 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

Handle delegate too

Apr 9 2023, 5:05 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147881: [WebAssembly] Correctly check end_if/end_try with else/catch.

Small cosmetic fix

Apr 9 2023, 4:51 AM · Restricted Project, Restricted Project
aheejin requested review of D147881: [WebAssembly] Correctly check end_if/end_try with else/catch.
Apr 9 2023, 4:37 AM · Restricted Project, Restricted Project
aheejin added inline comments to D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 9 2023, 3:23 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

More

Apr 9 2023, 3:18 AM · Restricted Project, Restricted Project
aheejin added inline comments to D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 9 2023, 3:07 AM · Restricted Project, Restricted Project
aheejin retitled D147852: [WebAssembly] Handle block-like structures consistently in type checker from [WebAssembly] Handle unreachable in block-like structure in type checker to [WebAssembly] Handle block-like structures consistently in type checker.
Apr 9 2023, 3:06 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

delete newline

Apr 9 2023, 3:05 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

Fix

Apr 9 2023, 3:04 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

More

Apr 9 2023, 12:07 AM · Restricted Project, Restricted Project
aheejin updated the summary of D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 9 2023, 12:06 AM · Restricted Project, Restricted Project

Apr 8 2023

aheejin updated the summary of D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 8 2023, 11:07 PM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

Test name change

Apr 8 2023, 7:26 AM · Restricted Project, Restricted Project
aheejin updated the diff for D147852: [WebAssembly] Handle block-like structures consistently in type checker.

Add one more test

Apr 8 2023, 7:25 AM · Restricted Project, Restricted Project
aheejin requested review of D147852: [WebAssembly] Handle block-like structures consistently in type checker.
Apr 8 2023, 7:17 AM · Restricted Project, Restricted Project
aheejin added a reviewer for D147837: [WebAssembly] Fix type index block type handling in type checker: dschuff.
Apr 8 2023, 7:14 AM · Restricted Project, Restricted Project

Apr 7 2023

aheejin requested review of D147837: [WebAssembly] Fix type index block type handling in type checker.
Apr 7 2023, 9:54 PM · Restricted Project, Restricted Project

Apr 5 2023

aheejin committed rG0e37487df8e0: [WebAssembly] Fix selection of global calls (authored by aheejin).
[WebAssembly] Fix selection of global calls
Apr 5 2023, 1:43 AM · Restricted Project, Restricted Project
aheejin closed D147397: [WebAssembly] Fix selection of global calls.
Apr 5 2023, 1:43 AM · Restricted Project, Restricted Project
aheejin committed rG47fc0186e630: [WebAssembly] Move call_indirect_alloca to call.ll (authored by aheejin).
[WebAssembly] Move call_indirect_alloca to call.ll
Apr 5 2023, 1:42 AM · Restricted Project, Restricted Project
aheejin closed D147396: [WebAssembly] Move call_indirect_alloca to call.ll.
Apr 5 2023, 1:42 AM · Restricted Project, Restricted Project

Apr 4 2023

aheejin updated the diff for D147397: [WebAssembly] Fix selection of global calls.

Improve comments

Apr 4 2023, 8:46 PM · Restricted Project, Restricted Project
aheejin added a comment to D147033: [WebAssembly] Select call_indirect for alloca calls.
In D147033#4227331, @HerrCai0907 wrote:

what about isGlobal, just like #60003 mentioned?

Apr 4 2023, 4:23 PM · Restricted Project, Restricted Project
aheejin accepted D147476: [WebAssembly] Add libcall signatures for roundeven.
Apr 4 2023, 5:09 AM · Restricted Project, Restricted Project

Apr 1 2023

aheejin requested review of D147397: [WebAssembly] Fix selection of global calls.
Apr 1 2023, 9:17 PM · Restricted Project, Restricted Project
aheejin requested review of D147396: [WebAssembly] Move call_indirect_alloca to call.ll.
Apr 1 2023, 9:15 PM · Restricted Project, Restricted Project

Mar 29 2023

aheejin added a comment to D146744: [WebAssembly] Redesign DebugValueManager.

Sorry, I hope https://reviews.llvm.org/rGb02db1dc78eed80c793f148913bd69a4a0ab823e fixed the error.

Mar 29 2023, 2:23 PM · Restricted Project, Restricted Project
aheejin committed rGb02db1dc78ee: [WebAssembly] Fix SmallVector warning (authored by aheejin).
[WebAssembly] Fix SmallVector warning
Mar 29 2023, 1:35 PM · Restricted Project, Restricted Project
aheejin committed rGa4e32ae4cd97: [WebAssembly] Do nothing when sinking to same place (authored by aheejin).
[WebAssembly] Do nothing when sinking to same place
Mar 29 2023, 12:51 PM · Restricted Project, Restricted Project
aheejin closed D146860: [WebAssembly] Do nothing when sinking to same place.
Mar 29 2023, 12:51 PM · Restricted Project, Restricted Project
aheejin committed rG5a55c9507b69: [WebAssembly] Redesign DebugValueManager (authored by aheejin).
[WebAssembly] Redesign DebugValueManager
Mar 29 2023, 12:50 PM · Restricted Project, Restricted Project
aheejin closed D146744: [WebAssembly] Redesign DebugValueManager.
Mar 29 2023, 12:50 PM · Restricted Project, Restricted Project
aheejin committed rGcfd36aa5b773: [WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC) (authored by aheejin).
[WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC)
Mar 29 2023, 12:48 PM · Restricted Project, Restricted Project
aheejin closed D146841: [WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC).
Mar 29 2023, 12:48 PM · Restricted Project, Restricted Project
aheejin committed rGd91c9aef9b37: [WebAssembly] Select call_indirect for alloca calls (authored by aheejin).
[WebAssembly] Select call_indirect for alloca calls
Mar 29 2023, 12:47 PM · Restricted Project, Restricted Project
aheejin closed D147033: [WebAssembly] Select call_indirect for alloca calls.
Mar 29 2023, 12:47 PM · Restricted Project, Restricted Project

Mar 28 2023

aheejin added a comment to D147033: [WebAssembly] Select call_indirect for alloca calls.
In D147033#4227331, @HerrCai0907 wrote:

what about isGlobal, just like #60003 mentioned?

Mar 28 2023, 8:08 PM · Restricted Project, Restricted Project
aheejin added a comment to D146781: [Webassembly] consider invalid CALL_S in removeRegisterOperands.
In D146781#4227396, @HerrCai0907 wrote:

detail fix see https://reviews.llvm.org/D147033, only add assert in this patch to avoid further spread of errors

Mar 28 2023, 12:42 PM · Restricted Project, Restricted Project
aheejin added inline comments to D146084: [WebAssembly] Add comments on local.tee transformation.
Mar 28 2023, 1:29 AM · Restricted Project, Restricted Project
aheejin added a comment to D146781: [Webassembly] consider invalid CALL_S in removeRegisterOperands.

I think the problem is, the call is instruction-selected as CALL, when it is supposed to be selected as CALL_INDIRECT. FastIsel selects it with CALL_INDIRECT; you can see the test passes with -fast-isel. I tried to fix this in ISel in D147033. PTAL.

Mar 28 2023, 1:08 AM · Restricted Project, Restricted Project
aheejin requested review of D147033: [WebAssembly] Select call_indirect for alloca calls.
Mar 28 2023, 1:08 AM · Restricted Project, Restricted Project

Mar 24 2023

aheejin requested review of D146860: [WebAssembly] Do nothing when sinking to same place.
Mar 24 2023, 6:41 PM · Restricted Project, Restricted Project
aheejin added a comment to D146744: [WebAssembly] Redesign DebugValueManager.
In D146744#4220624, @aheejin wrote:

Remove test clone_different_bb_same_place

Mar 24 2023, 1:45 PM · Restricted Project, Restricted Project
aheejin updated the diff for D146744: [WebAssembly] Redesign DebugValueManager.

Remove test clone_different_bb_same_place

Mar 24 2023, 1:44 PM · Restricted Project, Restricted Project
aheejin updated the diff for D146744: [WebAssembly] Redesign DebugValueManager.

Mark two methods const

Mar 24 2023, 1:17 PM · Restricted Project, Restricted Project
aheejin requested review of D146841: [WebAssembly] Use ArrayRef/SmallVectorImpl in parameters (NFC).
Mar 24 2023, 12:23 PM · Restricted Project, Restricted Project

Mar 23 2023

aheejin added inline comments to D146744: [WebAssembly] Redesign DebugValueManager.
Mar 23 2023, 7:12 PM · Restricted Project, Restricted Project
aheejin updated the diff for D146744: [WebAssembly] Redesign DebugValueManager.

Add missing !s in tests + Remove irrelevant line info

Mar 23 2023, 7:12 PM · Restricted Project, Restricted Project
aheejin updated the diff for D146744: [WebAssembly] Redesign DebugValueManager.

Address comments

Mar 23 2023, 7:09 PM · Restricted Project, Restricted Project
aheejin updated the summary of D146744: [WebAssembly] Redesign DebugValueManager.
Mar 23 2023, 6:51 PM · Restricted Project, Restricted Project
aheejin committed rG999643f1513e: [WebAssembly] Tidy up DebugValueManager (NFC) (authored by aheejin).
[WebAssembly] Tidy up DebugValueManager (NFC)
Mar 23 2023, 3:36 PM · Restricted Project, Restricted Project
aheejin closed D146743: [WebAssembly] Tidy up DebugValueManager (NFC).
Mar 23 2023, 3:35 PM · Restricted Project, Restricted Project
aheejin updated the summary of D146744: [WebAssembly] Redesign DebugValueManager.
Mar 23 2023, 3:32 PM · Restricted Project, Restricted Project
aheejin added a comment to D146744: [WebAssembly] Redesign DebugValueManager.

dbg-value-move-reg-stackify.mir was deleted because I think the new dbg-value-reg-stackify.mir covers what it used to cover.

Mar 23 2023, 10:57 AM · Restricted Project, Restricted Project
aheejin retitled D146743: [WebAssembly] Tidy up DebugValueManager (NFC) from [WebAssembly] Tidy up DebugValueManager to [WebAssembly] Tidy up DebugValueManager (NFC).
Mar 23 2023, 10:55 AM · Restricted Project, Restricted Project
aheejin requested review of D146744: [WebAssembly] Redesign DebugValueManager.
Mar 23 2023, 10:54 AM · Restricted Project, Restricted Project
aheejin requested review of D146743: [WebAssembly] Tidy up DebugValueManager (NFC).
Mar 23 2023, 10:52 AM · Restricted Project, Restricted Project

Mar 22 2023

aheejin added a comment to D142615: [WebAssembly] Fix tail call with return_call_indirect instruction.

Thanks for fixing this, but D146569 has landed first.

Mar 22 2023, 10:56 AM · Restricted Project, Restricted Project
aheejin added a reverting change for rGe12a950d90f8: Remove the LINK_COMPONENTS entry from lldb-instr CMakery: rGc4125a37806a: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery".
Mar 22 2023, 10:54 AM · Restricted Project
aheejin committed rGc4125a37806a: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery" (authored by aheejin).
Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"
Mar 22 2023, 10:54 AM · Restricted Project
aheejin added a comment to D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery".

Thanks for the investigation!

Mar 22 2023, 10:54 AM · Restricted Project, Restricted Project
aheejin added a reverting change for D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt: rGc4125a37806a: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery".
Mar 22 2023, 10:54 AM · Restricted Project, Restricted Project