Also changed ptr to integer pointers because it requires an additional arguments in the opt command line.

clang-format

Address comments

(Also we can't just always require the presence of e.g. the
function or global sections, because a binary may just have any functions.
There's only an problem if the name or linking section tries to name a
nonexistent function).

Address comments

What do you think about this line in https://reviews.llvm.org/D126509#3561435? Not something important either though.....

# CHECK-NOT:    - Type: TYPE

@CarlosAlbertoEnciso That's great news! Thank you for letting me know.

Remove getSetProperties

Add getRequiredProperties call to OptimizeLiveIntervals

The script doesn't generate CHECK lines next to each BB but rather generates the whole function together, making it harder to see changes in each BB for me. Also there are comments for CHECK lines, which will be lost if we use the script. So I'm not sure using it will improve readability in this case.

Closing in favor of D125515.

Remove a stray line

Thanks! I have one more question but don't want to hold this back with nitpicky things. (The review turnaround time due to time zone doesn't help either)

Is this tool still planned to be upstreamed? Is this patch the most up-to-date version of this tool, or there is another repo? How is this CL related to https://github.com/SNSystems/DIVA?

I wasn't able to check performances for real-world programs myself, but there's no changes in our existing tests. I don't think it will have a huge impact because I made the condition fairly specific: we bail out only when it is a build_vector and the DAG is already type-legalized and legalized, meaning it does so only in the very last stage before instruction selection. Also I'm not sure if there's any other way around this at this point.

Oh that fixed my error. Thanks!

Yes, all three also fail with LLVM ToT.

In D120013#3329550, @sbc100 wrote:

Can you verify that the core2 and other emscripten test suites both pass with this change

Remove lambda

Then I'll just land this first and make the discussed changes as a follow-up. Thanks!

Simplify

These global TLS symbols are shared across all shared libraries and cannot be assumed to be local to the currently module.