Page MenuHomePhabricator

aheejin (Heejin Ahn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (150 w, 3 d)

Recent Activity

Wed, Jun 12

aheejin accepted D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.

LGTM!

Wed, Jun 12, 1:53 AM · Restricted Project

Sun, Jun 9

aheejin added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Sun, Jun 9, 3:41 PM · Restricted Project

Sat, Jun 8

aheejin added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Sat, Jun 8, 3:26 PM · Restricted Project

Fri, Jun 7

aheejin added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Fri, Jun 7, 11:05 AM · Restricted Project
aheejin added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Fri, Jun 7, 4:05 AM · Restricted Project

Wed, Jun 5

aheejin added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Wed, Jun 5, 4:14 PM · Restricted Project

Tue, Jun 4

aheejin added inline comments to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
Tue, Jun 4, 5:17 PM · Restricted Project
aheejin added a comment to D62877: [WebAssembly] Implement tail calls and unify tablegen call classes.
  • Does the LLVM guarantee tail calls to be placed in the positions in which they can be really tail calls? Can this property change when we move code around in our backend, so tail calls cannot be executed as tail calls anymore?
  • It seems we need to update the Tail call optimization section in the Code Generator doc too.
Tue, Jun 4, 5:17 PM · Restricted Project
aheejin added a comment to D62830: [WebAssembly] Support Leak Sanitizer on Emscripten.

I see. Do you want me to commit this, or you are gonna get a commit access?

Tue, Jun 4, 1:34 PM · Restricted Project, Restricted Project

Mon, Jun 3

aheejin added a comment to D62830: [WebAssembly] Support Leak Sanitizer on Emscripten.

Oh, can we have a test case?

Mon, Jun 3, 7:32 PM · Restricted Project, Restricted Project
aheejin accepted D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.

LGTM

Mon, Jun 3, 6:27 PM · Restricted Project
aheejin accepted D62830: [WebAssembly] Support Leak Sanitizer on Emscripten.
Mon, Jun 3, 5:22 PM · Restricted Project, Restricted Project

Thu, May 30

aheejin requested changes to D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.

Oh, I accidentally accepted the CL, sorry. Will change to Request Changes instead. (It looks there's no option of 'cancelling' the acceptance.)

Thu, May 30, 8:12 PM · Restricted Project
aheejin accepted D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch.
Thu, May 30, 8:09 PM · Restricted Project

Tue, May 28

aheejin accepted D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.
Tue, May 28, 6:21 PM · Restricted Project, Restricted Project
aheejin added inline comments to D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.
Tue, May 28, 6:14 PM · Restricted Project, Restricted Project
aheejin added inline comments to D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.
Tue, May 28, 6:13 PM · Restricted Project, Restricted Project
aheejin added a comment to D44024: [WebAssembly] Validate sections: order, and presence of required CODE.

Also more related patches: D58312

Tue, May 28, 6:11 PM · Restricted Project
aheejin added inline comments to D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.
Tue, May 28, 6:05 PM · Restricted Project, Restricted Project
aheejin added inline comments to D62559: [WebAssembly] Support VPtr sanitizer for Emscripten.
Tue, May 28, 5:38 PM · Restricted Project, Restricted Project
aheejin added inline comments to D50277: [WebAssembly] Support for atomic fences.
Tue, May 28, 5:00 PM · Restricted Project
aheejin added inline comments to D50277: [WebAssembly] Support for atomic fences.
Tue, May 28, 3:31 PM · Restricted Project
aheejin committed rG551465859113: [WebAssembly] Support for atomic fences (authored by aheejin).
[WebAssembly] Support for atomic fences
Tue, May 28, 3:07 PM
aheejin committed rL361884: [WebAssembly] Support for atomic fences.
[WebAssembly] Support for atomic fences
Tue, May 28, 3:07 PM
aheejin closed D50277: [WebAssembly] Support for atomic fences.
Tue, May 28, 3:07 PM · Restricted Project
aheejin added inline comments to D50277: [WebAssembly] Support for atomic fences.
Tue, May 28, 2:44 PM · Restricted Project
aheejin updated the diff for D50277: [WebAssembly] Support for atomic fences.
  • Fix a typo and indentations
Tue, May 28, 2:08 PM · Restricted Project
aheejin updated the diff for D50277: [WebAssembly] Support for atomic fences.
  • test cosmetic change
Tue, May 28, 11:11 AM · Restricted Project
aheejin updated the diff for D50277: [WebAssembly] Support for atomic fences.
  • Predicate behind wasm32-unknown-emscripten flag.
  • Add tests for non-emscripten flags
Tue, May 28, 11:11 AM · Restricted Project

Fri, May 24

aheejin committed rGe6e038c32224: [clangd] tweaks: Add clangBasic dependency to LINK_LIBS (authored by aheejin).
[clangd] tweaks: Add clangBasic dependency to LINK_LIBS
Fri, May 24, 6:34 PM
aheejin committed rCTE361687: [clangd] tweaks: Add clangBasic dependency to LINK_LIBS.
[clangd] tweaks: Add clangBasic dependency to LINK_LIBS
Fri, May 24, 6:34 PM
aheejin committed rL361687: [clangd] tweaks: Add clangBasic dependency to LINK_LIBS.
[clangd] tweaks: Add clangBasic dependency to LINK_LIBS
Fri, May 24, 6:34 PM
aheejin added a comment to D50277: [WebAssembly] Support for atomic fences.

OK I'll predicate this under emscripten triple. But anyway someone approve this!

Fri, May 24, 5:55 PM · Restricted Project
aheejin added a comment to D50277: [WebAssembly] Support for atomic fences.

I agree; this matches the current behavior, so it does not change anything from users' standpoint, and we ever decide do something else in the CG meeting, we can always land another patch later.

Fri, May 24, 5:02 PM · Restricted Project

Thu, May 23

aheejin accepted D62354: [WebAssembly] Expand more SIMD float ops.
Thu, May 23, 4:56 PM · Restricted Project

Tue, May 21

aheejin added a comment to D62047: [WebAssembly] Add multivalue and tail-call target features.

I see. LGTM either way 😂

Tue, May 21, 2:28 PM · Restricted Project, Restricted Project
aheejin added a comment to D62210: [WebAssembly] Implement __builtin_return_address for emscripten.

Nice!

  • Please run clang-format before you submit patches
  • When you did what the review suggested, please click 'Done' checkbox, so that the reviewer will know which one was taken care of and which one was not.
Tue, May 21, 2:19 PM · Restricted Project

May 17 2019

aheejin added inline comments to D61948: Implement call lowering without parameters on AIX.
May 17 2019, 5:02 AM · Restricted Project

May 16 2019

aheejin added a comment to D62047: [WebAssembly] Add multivalue and tail-call target features.

Does it make sense to support the flags before we support the feature?

Otherwise lgtm.

May 16 2019, 5:48 PM · Restricted Project, Restricted Project
aheejin accepted D62047: [WebAssembly] Add multivalue and tail-call target features.

How about using multi-value/MultiValue/MULTI-VALUE (depending on positions)? The repo name is also multi-value. https://github.com/WebAssembly/multi-value
Otherwise LGTM.

May 16 2019, 5:45 PM · Restricted Project, Restricted Project

May 2 2019

aheejin accepted D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash.

Thanks for investigating this! This is getting kind of hard to understand without knowing the context that why signext_inreg is custom lowered for SIMD but actually not custom lowered....

May 2 2019, 7:57 PM · Restricted Project

Apr 24 2019

aheejin added a comment to D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash.

We talked offline and it's maybe better to have a bit more picture on how ReplaceNodeResults is working before committing this.

Apr 24 2019, 6:27 PM · Restricted Project
aheejin added inline comments to D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 24 2019, 12:31 PM · Restricted Project

Apr 23 2019

aheejin committed rGb9f282d384fc: [WebAssembly] Emit br_table for most switch instructions (authored by aheejin).
[WebAssembly] Emit br_table for most switch instructions
Apr 23 2019, 2:32 PM
aheejin committed rL359038: [WebAssembly] Emit br_table for most switch instructions.
[WebAssembly] Emit br_table for most switch instructions
Apr 23 2019, 2:31 PM
aheejin closed D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 23 2019, 2:31 PM · Restricted Project
aheejin committed rGace7a086ca38: [WebAssembly] Make LBB markers not affected by test order (authored by aheejin).
[WebAssembly] Make LBB markers not affected by test order
Apr 23 2019, 2:16 PM
aheejin committed rL359036: [WebAssembly] Make LBB markers not affected by test order.
[WebAssembly] Make LBB markers not affected by test order
Apr 23 2019, 2:15 PM
aheejin closed D60929: [WebAssembly] Make LBB markers not affected by test order.
Apr 23 2019, 2:15 PM · Restricted Project
aheejin added a comment to D60929: [WebAssembly] Make LBB markers not affected by test order.

Ping. I guess I can just commit this, because it's simple anyway

Apr 23 2019, 1:17 PM · Restricted Project

Apr 22 2019

aheejin added a reviewer for D60929: [WebAssembly] Make LBB markers not affected by test order: tlively.
Apr 22 2019, 2:50 PM · Restricted Project
aheejin added a comment to D60929: [WebAssembly] Make LBB markers not affected by test order.

Ping

Apr 22 2019, 11:43 AM · Restricted Project
aheejin updated the summary of D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 22 2019, 11:15 AM · Restricted Project
aheejin updated the diff for D60966: [WebAssembly] Emit br_table for most switch instructions.
  • v8 -> VM
Apr 22 2019, 11:15 AM · Restricted Project
aheejin updated the summary of D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 22 2019, 7:53 AM · Restricted Project
aheejin added inline comments to D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 22 2019, 7:53 AM · Restricted Project
aheejin added a parent revision for D60966: [WebAssembly] Emit br_table for most switch instructions: D60929: [WebAssembly] Make LBB markers not affected by test order.
Apr 22 2019, 7:53 AM · Restricted Project
aheejin added a child revision for D60929: [WebAssembly] Make LBB markers not affected by test order: D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 22 2019, 7:53 AM · Restricted Project
aheejin created D60966: [WebAssembly] Emit br_table for most switch instructions.
Apr 22 2019, 7:48 AM · Restricted Project

Apr 19 2019

aheejin created D60929: [WebAssembly] Make LBB markers not affected by test order.
Apr 19 2019, 5:26 PM · Restricted Project

Apr 13 2019

aheejin committed rG5f3a04510a5d: [WebAssembly] Use Function::hasOptSize() (NFC) (authored by aheejin).
[WebAssembly] Use Function::hasOptSize() (NFC)
Apr 13 2019, 9:56 AM
aheejin committed rL358336: [WebAssembly] Use Function::hasOptSize() (NFC).
[WebAssembly] Use Function::hasOptSize() (NFC)
Apr 13 2019, 9:56 AM
aheejin closed D60651: [WebAssembly] Use Function::hasOptSize() (NFC).
Apr 13 2019, 9:56 AM · Restricted Project
aheejin accepted D60651: [WebAssembly] Use Function::hasOptSize() (NFC).

Thanks! Could you append (NFC) to the CL title?

Apr 13 2019, 9:17 AM · Restricted Project

Apr 8 2019

aheejin added inline comments to D60295: [SelectionDAG] Change the jump table size unit from entry to target.
Apr 8 2019, 5:30 AM · Restricted Project

Mar 30 2019

aheejin committed rGc4ac74fb4987: [WebAssembly] Fix unwind destination mismatches in CFG stackify (authored by aheejin).
[WebAssembly] Fix unwind destination mismatches in CFG stackify
Mar 30 2019, 4:05 AM
aheejin committed rL357343: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
[WebAssembly] Fix unwind destination mismatches in CFG stackify
Mar 30 2019, 4:05 AM
aheejin closed D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Mar 30 2019, 4:05 AM · Restricted Project
aheejin committed rGe9fd9073e490: [WebAssembly] Run ExplicitLocals pass after CFGStackify (authored by aheejin).
[WebAssembly] Run ExplicitLocals pass after CFGStackify
Mar 30 2019, 2:29 AM
aheejin committed rL357342: [WebAssembly] Run ExplicitLocals pass after CFGStackify.
[WebAssembly] Run ExplicitLocals pass after CFGStackify
Mar 30 2019, 2:28 AM
aheejin closed D59652: [WebAssembly] Run ExplicitLocals pass after CFGStackify.
Mar 30 2019, 2:28 AM · Restricted Project

Mar 29 2019

aheejin committed rG7e7aad151068: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG (authored by aheejin).
[WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG
Mar 29 2019, 6:33 PM
aheejin committed rL357337: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG.
[WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG
Mar 29 2019, 6:33 PM
aheejin closed D59462: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG.
Mar 29 2019, 6:33 PM · Restricted Project
aheejin accepted D60013: [WebAssembly] Add mutable globals feature.
Mar 29 2019, 2:39 PM · Restricted Project, Restricted Project
aheejin committed rG67f74aceab19: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify (authored by aheejin).
[WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify
Mar 29 2019, 12:36 PM
aheejin committed rL357303: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
[WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify
Mar 29 2019, 12:36 PM
aheejin closed D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Mar 29 2019, 12:36 PM · Restricted Project
aheejin added a reviewer for D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify: dschuff.
Mar 29 2019, 12:28 PM · Restricted Project
aheejin updated the diff for D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
  • Test comment
Mar 29 2019, 12:00 PM · Restricted Project
aheejin updated the summary of D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Mar 29 2019, 12:00 PM · Restricted Project
aheejin updated the summary of D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Mar 29 2019, 12:00 PM · Restricted Project
aheejin updated the diff for D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.

Fix test name

Mar 29 2019, 11:48 AM · Restricted Project
aheejin retitled D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify from [WebAssembly] Handle END_LOOP is in unreachable BB in CFGStackify to [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Mar 29 2019, 11:46 AM · Restricted Project
aheejin created D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Mar 29 2019, 11:45 AM · Restricted Project

Mar 28 2019

aheejin accepted D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.

LGTM w/ nits. I like we can use module metadata this way.

Mar 28 2019, 11:28 AM · Restricted Project

Mar 27 2019

aheejin added a comment to D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.

Mostly LGTM. Some nits and questions:

Mar 27 2019, 11:28 AM · Restricted Project

Mar 26 2019

aheejin committed rG54551c1df73b: [WebAssembly] Don't analyze branches after CFGStackify (authored by aheejin).
[WebAssembly] Don't analyze branches after CFGStackify
Mar 26 2019, 11:20 AM
aheejin committed rL357015: [WebAssembly] Don't analyze branches after CFGStackify.
[WebAssembly] Don't analyze branches after CFGStackify
Mar 26 2019, 11:20 AM
aheejin closed D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 26 2019, 11:20 AM · Restricted Project
aheejin updated the diff for D59740: [WebAssembly] Don't analyze branches after CFGStackify.
  • Add comment on CFGStackify
Mar 26 2019, 11:18 AM · Restricted Project
aheejin added inline comments to D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.
Mar 26 2019, 10:56 AM · Restricted Project, Restricted Project
aheejin committed rG1aaa481fc1f8: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo (authored by aheejin).
[WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo
Mar 26 2019, 10:48 AM
aheejin committed rL357011: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo.
[WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo
Mar 26 2019, 10:47 AM
aheejin closed D59747: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo.
Mar 26 2019, 10:47 AM · Restricted Project
aheejin committed rG52221d56bcf3: [WebAssembly] Support WebAssemblyFunctionInfo serialization (authored by aheejin).
[WebAssembly] Support WebAssemblyFunctionInfo serialization
Mar 26 2019, 10:35 AM
aheejin committed rL357009: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
[WebAssembly] Support WebAssemblyFunctionInfo serialization
Mar 26 2019, 10:34 AM
aheejin closed D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Mar 26 2019, 10:34 AM · Restricted Project
aheejin committed rG222718fdd205: [WebAssembly] Fix a bug when mixing TRY/LOOP markers (authored by aheejin).
[WebAssembly] Fix a bug when mixing TRY/LOOP markers
Mar 26 2019, 10:30 AM
aheejin committed rL357008: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
[WebAssembly] Fix a bug when mixing TRY/LOOP markers
Mar 26 2019, 10:28 AM