LGTM!

• Does the LLVM guarantee tail calls to be placed in the positions in which they can be really tail calls? Can this property change when we move code around in our backend, so tail calls cannot be executed as tail calls anymore?
• It seems we need to update the Tail call optimization section in the Code Generator doc too.

I see. Do you want me to commit this, or you are gonna get a commit access?

Oh, can we have a test case?

LGTM

Oh, I accidentally accepted the CL, sorry. Will change to Request Changes instead. (It looks there's no option of 'cancelling' the acceptance.)

Also more related patches: D58312

• Fix a typo and indentations

• test cosmetic change

• Predicate behind wasm32-unknown-emscripten flag.
• Add tests for non-emscripten flags

OK I'll predicate this under emscripten triple. But anyway someone approve this!

I agree; this matches the current behavior, so it does not change anything from users' standpoint, and we ever decide do something else in the CG meeting, we can always land another patch later.

I see. LGTM either way 😂

Nice!

• Please run clang-format before you submit patches
• When you did what the review suggested, please click 'Done' checkbox, so that the reviewer will know which one was taken care of and which one was not.

In D62047#1505838, @sbc100 wrote:

Does it make sense to support the flags before we support the feature?

Otherwise lgtm.

How about using multi-value/MultiValue/MULTI-VALUE (depending on positions)? The repo name is also multi-value. https://github.com/WebAssembly/multi-value
Otherwise LGTM.

Thanks for investigating this! This is getting kind of hard to understand without knowing the context that why signext_inreg is custom lowered for SIMD but actually not custom lowered....

We talked offline and it's maybe better to have a bit more picture on how ReplaceNodeResults is working before committing this.

Ping. I guess I can just commit this, because it's simple anyway

Ping

• v8 -> VM

Thanks! Could you append (NFC) to the CL title?

• Test comment

Fix test name

LGTM w/ nits. I like we can use module metadata this way.

Mostly LGTM. Some nits and questions:

• Add comment on CFGStackify