Page MenuHomePhabricator

aheejin (Heejin Ahn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (192 w, 4 d)

Recent Activity

Yesterday

aheejin accepted D77358: [WebAssembly] EmscriptenEHSjLj: Mark more functions as imported.

Thanks! LGTM.

Mon, Apr 6, 4:21 PM · Restricted Project
aheejin committed rGc09acd5dd147: [WebAssembly] Handle event exports (authored by aheejin).
[WebAssembly] Handle event exports
Mon, Apr 6, 11:58 AM
aheejin closed D77566: [WebAssembly] Handle event exports.
Mon, Apr 6, 11:58 AM · Restricted Project
aheejin created D77566: [WebAssembly] Handle event exports.
Mon, Apr 6, 9:44 AM · Restricted Project

Sat, Apr 4

aheejin committed rGfc5d8b672b98: [WebAssembly] Fix a sanitizer error in WasmEHPrepare (authored by aheejin).
[WebAssembly] Fix a sanitizer error in WasmEHPrepare
Sat, Apr 4, 10:05 AM
aheejin closed D77465: [WebAssembly] Fix a sanitizer error in WasmEHPrepare.
Sat, Apr 4, 10:04 AM · Restricted Project
aheejin created D77465: [WebAssembly] Fix a sanitizer error in WasmEHPrepare.
Sat, Apr 4, 10:04 AM · Restricted Project
aheejin added a comment to D77465: [WebAssembly] Fix a sanitizer error in WasmEHPrepare.

Will land this now, because it's a weekend and the previous patch is breaking the buildbots.

Sat, Apr 4, 10:04 AM · Restricted Project
aheejin committed rG2e9839729d37: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare (authored by aheejin).
[WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare
Sat, Apr 4, 7:24 AM
aheejin closed D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Sat, Apr 4, 7:24 AM · Restricted Project
aheejin added inline comments to D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Sat, Apr 4, 7:24 AM · Restricted Project
aheejin updated the diff for D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.

iIsEHPadFunctionsSetup -> IsEHPadFunctionsSetUp

Sat, Apr 4, 7:24 AM · Restricted Project

Fri, Apr 3

aheejin updated the diff for D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
  • Change the static variable init to a class member variable IsEHFunctionsSetup (Not sure whether I should AreEHFunctionsSetup instead, but I think usually variable names start with Is..? Let me know if this sounds weird.)
  • Move class member variable ExecutedLSDA to an auto variable in prepareEHPads. This variable is used only within that function.
Fri, Apr 3, 2:05 PM · Restricted Project
aheejin updated the summary of D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Fri, Apr 3, 1:33 PM · Restricted Project
aheejin updated the summary of D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Fri, Apr 3, 1:33 PM · Restricted Project
aheejin updated the summary of D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Fri, Apr 3, 1:33 PM · Restricted Project
aheejin updated the diff for D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
  • Add more comment
Fri, Apr 3, 12:26 PM · Restricted Project
aheejin updated the diff for D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
  • Comment fix
Fri, Apr 3, 12:25 PM · Restricted Project
aheejin added inline comments to D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Fri, Apr 3, 11:57 AM · Restricted Project
aheejin updated the summary of D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Fri, Apr 3, 11:55 AM · Restricted Project
aheejin updated the diff for D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
  • clang-format
Fri, Apr 3, 11:53 AM · Restricted Project
aheejin created D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare.
Fri, Apr 3, 11:53 AM · Restricted Project
aheejin added a comment to D77358: [WebAssembly] EmscriptenEHSjLj: Mark more functions as imported.

There seem to be several other places in which we use Function::Create in this file.. Should we mark all of them as imported as well?

Fri, Apr 3, 9:07 AM · Restricted Project

Wed, Apr 1

aheejin accepted D77192: [WebAssembly] EmscriptenEHSjLj: Make __invoke_ functions as imported.

Thanks!

Wed, Apr 1, 11:14 AM · Restricted Project
aheejin added a comment to D77192: [WebAssembly] EmscriptenEHSjLj: Make __invoke_ functions as imported.

Yeah then it should be fine to add them in Emscripten side.

Wed, Apr 1, 10:07 AM · Restricted Project
aheejin accepted D77192: [WebAssembly] EmscriptenEHSjLj: Make __invoke_ functions as imported.

(Virtually) talked in person and I have better context for this change now. It'd be better we can add a test for this.

Wed, Apr 1, 9:53 AM · Restricted Project
aheejin accepted D77185: [WebAssembly] Rename SIMD min/max/avgr intrinsics for consistency.
Wed, Apr 1, 9:34 AM · Restricted Project
aheejin added a comment to D77192: [WebAssembly] EmscriptenEHSjLj: Make __invoke_ functions as imported.
  • Is this for static linking or dynamic linking? How did things work before this?
  • Is there any tests?
Wed, Apr 1, 9:01 AM · Restricted Project
aheejin committed rGc87b5e7e22b2: [WebAssembly] Fix subregion relationship in CFGSort (authored by aheejin).
[WebAssembly] Fix subregion relationship in CFGSort
Wed, Apr 1, 8:16 AM
aheejin closed D77181: [WebAssembly] Fix subregion relationship in CFGSort.
Wed, Apr 1, 8:16 AM · Restricted Project
aheejin updated the summary of D77181: [WebAssembly] Fix subregion relationship in CFGSort.
Wed, Apr 1, 8:14 AM · Restricted Project
aheejin added inline comments to D77181: [WebAssembly] Fix subregion relationship in CFGSort.
Wed, Apr 1, 8:14 AM · Restricted Project

Tue, Mar 31

aheejin updated the diff for D77181: [WebAssembly] Fix subregion relationship in CFGSort.
  • Test fix
Tue, Mar 31, 4:00 PM · Restricted Project
aheejin created D77181: [WebAssembly] Fix subregion relationship in CFGSort.
Tue, Mar 31, 3:59 PM · Restricted Project

Thu, Mar 26

aheejin committed rGf033f201a7c8: [WebAssembly] Add test for event section order change (authored by aheejin).
[WebAssembly] Add test for event section order change
Thu, Mar 26, 11:24 AM
aheejin closed D76823: [WebAssembly] Add test for event section order change.
Thu, Mar 26, 11:24 AM · Restricted Project
aheejin updated the diff for D76823: [WebAssembly] Add test for event section order change.
  • Add comment
Thu, Mar 26, 11:22 AM · Restricted Project

Wed, Mar 25

aheejin added a comment to D76752: [WebAssembly] Move event section before global section.

Hmm, come to think of it, I can add a test change that cannot run without this change after all. Thanks for suggestions. Done in D76823.

Wed, Mar 25, 10:11 PM · Restricted Project
aheejin created D76823: [WebAssembly] Add test for event section order change.
Wed, Mar 25, 10:11 PM · Restricted Project
aheejin added a comment to D76752: [WebAssembly] Move event section before global section.

V8 validation fails without this. I'm not sure if there's a way test v8 validation w/ LLVM unit tests?

Wed, Mar 25, 2:38 PM · Restricted Project
aheejin committed rGf93426c5b964: [WebAssembly] Move event section before global section (authored by aheejin).
[WebAssembly] Move event section before global section
Wed, Mar 25, 11:54 AM
aheejin closed D76752: [WebAssembly] Move event section before global section.
Wed, Mar 25, 11:54 AM · Restricted Project
aheejin retitled D76752: [WebAssembly] Move event section before global section from Move event section before global section to [WebAssembly] Move event section before global section.
Wed, Mar 25, 11:21 AM · Restricted Project
aheejin updated the diff for D76752: [WebAssembly] Move event section before global section.

Move inline comments to their own lines

Wed, Mar 25, 11:21 AM · Restricted Project
aheejin added inline comments to D76752: [WebAssembly] Move event section before global section.
Wed, Mar 25, 11:21 AM · Restricted Project

Tue, Mar 24

aheejin added inline comments to D76752: [WebAssembly] Move event section before global section.
Tue, Mar 24, 9:28 PM · Restricted Project
aheejin updated the diff for D76752: [WebAssembly] Move event section before global section.
  • clang-format
Tue, Mar 24, 9:28 PM · Restricted Project
aheejin updated the summary of D76752: [WebAssembly] Move event section before global section.
Tue, Mar 24, 8:56 PM · Restricted Project
aheejin created D76752: [WebAssembly] Move event section before global section.
Tue, Mar 24, 8:56 PM · Restricted Project

Fri, Mar 20

aheejin accepted D76538: [WebAssembly] Add SIMD integer abs builtins.
Fri, Mar 20, 10:45 PM · Restricted Project

Thu, Mar 19

aheejin accepted D76399: [WebAssembly] SIMD integer abs instructions.
Thu, Mar 19, 3:44 AM · Restricted Project
aheejin accepted D76397: [WebAssembly] SIMD bitmask intrinsics and builtin functions.
Thu, Mar 19, 3:44 AM · Restricted Project

Sun, Mar 15

aheejin added a comment to D76049: [WebAssembly] Support swiftself and swifterror for WebAssembly target.

I think the full diff still has not been uploaded yet; everywhere says "Context not available". Could you use arc diff to upload the diff?

Sun, Mar 15, 8:33 AM · Restricted Project

Feb 25 2020

aheejin accepted D75005: [WebAssembly] Simplify extract_vector lowering.

Nice, looks a lot simpler!

Feb 25 2020, 1:34 PM · Restricted Project

Feb 22 2020

aheejin accepted D75005: [WebAssembly] Simplify extract_vector lowering.

This part has kind of complicated history and I hope this can be simplified someday 😂... Btw can the test case be simplified? Do we need all that code to generate the pattern?

Feb 22 2020, 12:29 AM · Restricted Project

Feb 21 2020

aheejin committed rG3648370a7923: [WebAssembly] Fix a non-determinism problem in FixIrreducibleControlFlow (authored by aheejin).
[WebAssembly] Fix a non-determinism problem in FixIrreducibleControlFlow
Feb 21 2020, 5:15 PM
aheejin closed D74999: [WebAssembly] Fix a non-determinism problem in FixIrreducibleControlFlow.
Feb 21 2020, 5:15 PM · Restricted Project
aheejin accepted D74999: [WebAssembly] Fix a non-determinism problem in FixIrreducibleControlFlow.
Feb 21 2020, 4:48 PM · Restricted Project
aheejin added a comment to D74999: [WebAssembly] Fix a non-determinism problem in FixIrreducibleControlFlow.

There seem to be multiple places that call Graph.getLoopEntries(). I guess we should sort all of them..? How about sort LoopEntries at the end of calculate() once and for all?

Feb 21 2020, 4:20 PM · Restricted Project

Feb 14 2020

aheejin accepted D74192: [WebAssembly] Replace all calls with generalized multivalue calls.

Yay! 🎉🎉🎉 It's very simpler and nicer this way.

Feb 14 2020, 6:03 PM · Restricted Project
aheejin accepted D74191: [WebAssembly] Implement multivalue call_indirects.

Nice!

Feb 14 2020, 3:43 PM · Restricted Project
aheejin accepted D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.

Nice work!

Feb 14 2020, 3:34 PM · Restricted Project

Feb 13 2020

aheejin added inline comments to D74191: [WebAssembly] Implement multivalue call_indirects.
Feb 13 2020, 6:37 PM · Restricted Project
aheejin added inline comments to D73943: [WebAssembly] Make stack pointer args inhibit tail calls.
Feb 13 2020, 4:39 PM · Restricted Project
aheejin added inline comments to D73943: [WebAssembly] Make stack pointer args inhibit tail calls.
Feb 13 2020, 4:22 PM · Restricted Project
aheejin accepted D73943: [WebAssembly] Make stack pointer args inhibit tail calls.
Feb 13 2020, 4:22 PM · Restricted Project

Feb 8 2020

aheejin added a comment to D74191: [WebAssembly] Implement multivalue call_indirects.

It looks this assumes D71484 and D71496 have not been reverted, right?

Feb 8 2020, 8:49 PM · Restricted Project

Feb 7 2020

aheejin added a comment to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.
  • Have you had a chance to see my previous round of comments?
  • Do we need to reapply D71484 and D71496?
Feb 7 2020, 10:43 PM · Restricted Project
aheejin added a comment to D74192: [WebAssembly] Replace all calls with generalized multivalue calls.
Feb 7 2020, 10:43 PM · Restricted Project
aheejin accepted D74259: [WebAssembly] Add cbrt function signatures.
Feb 7 2020, 8:07 PM · Restricted Project
aheejin accepted D74274: [WebAssembly] Fix signature of __powitf2 libcall.
Feb 7 2020, 7:58 PM · Restricted Project
aheejin committed rG5b5cbfe13591: [WebAssembly] Add debug info to insts in Emscripten SjLj (authored by aheejin).
[WebAssembly] Add debug info to insts in Emscripten SjLj
Feb 7 2020, 7:14 PM
aheejin closed D74269: [WebAssembly] Add debug info to insts in Emscripten SjLj.
Feb 7 2020, 7:14 PM · Restricted Project
aheejin created D74269: [WebAssembly] Add debug info to insts in Emscripten SjLj.
Feb 7 2020, 5:08 PM · Restricted Project

Feb 5 2020

aheejin added a comment to D73943: [WebAssembly] Make stack pointer args inhibit tail calls.

I also did a quick search for what other backends are doing, and they are all kind of different. Many targets seem to implement some function called isEligibleForTailCallOptimization, even though the superclass TargetLowering does not have that method. Anyway, I think it would be fine if we add things we need on an as-needed basis.

Feb 5 2020, 5:14 PM · Restricted Project

Feb 4 2020

aheejin accepted D73926: [WebAssembly] Enable recently implemented SIMD operations.
Feb 4 2020, 3:09 PM · Restricted Project, Restricted Project
aheejin accepted D73928: Revert "[WebAssembly][InstrEmitter] Foundation for multivalue call lowering".
Feb 4 2020, 2:23 PM · Restricted Project
aheejin accepted D73927: Revert "[WebAssembly] Split and recombine multivalue calls for ISel".

I still don't have 100% understanding of what the def issue was, but I can catch up later!

Feb 4 2020, 2:23 PM · Restricted Project
aheejin accepted D72972: [WebAssembly] Add experimental multivalue calling ABI.
Feb 4 2020, 2:23 PM · Restricted Project

Jan 24 2020

aheejin committed rG65eb11306e92: [WebAssembly] Update bleeding-edge CPU features (authored by aheejin).
[WebAssembly] Update bleeding-edge CPU features
Jan 24 2020, 2:29 PM
aheejin closed D73322: [WebAssembly] Update bleeding-edge CPU features.
Jan 24 2020, 2:29 PM · Restricted Project, Restricted Project
aheejin committed rG764f4089e89e: [WebAssembly] Add reference types target feature (authored by aheejin).
[WebAssembly] Add reference types target feature
Jan 24 2020, 2:27 PM
aheejin closed D73320: [WebAssembly] Add reference types target feature.
Jan 24 2020, 2:26 PM · Restricted Project, Restricted Project
aheejin updated the diff for D73322: [WebAssembly] Update bleeding-edge CPU features.

rebase + test fix

Jan 24 2020, 2:28 AM · Restricted Project, Restricted Project
aheejin updated the diff for D73320: [WebAssembly] Add reference types target feature.

Fix test comments

Jan 24 2020, 2:23 AM · Restricted Project, Restricted Project
aheejin added a parent revision for D73322: [WebAssembly] Update bleeding-edge CPU features: D73320: [WebAssembly] Add reference types target feature.
Jan 24 2020, 2:04 AM · Restricted Project, Restricted Project
aheejin added a child revision for D73320: [WebAssembly] Add reference types target feature: D73322: [WebAssembly] Update bleeding-edge CPU features.
Jan 24 2020, 2:04 AM · Restricted Project, Restricted Project
aheejin updated the diff for D73320: [WebAssembly] Add reference types target feature.

rebase

Jan 24 2020, 2:01 AM · Restricted Project, Restricted Project
aheejin updated the diff for D73320: [WebAssembly] Add reference types target feature.
  • Remove a stray attribute number
Jan 24 2020, 1:54 AM · Restricted Project, Restricted Project
aheejin updated the diff for D73320: [WebAssembly] Add reference types target feature.
  • Test target feature section
Jan 24 2020, 1:51 AM · Restricted Project, Restricted Project
aheejin added inline comments to D73320: [WebAssembly] Add reference types target feature.
Jan 24 2020, 1:51 AM · Restricted Project, Restricted Project

Jan 23 2020

aheejin added a comment to D73322: [WebAssembly] Update bleeding-edge CPU features.

I think their implemention is mostly complete, but please let me know if not.

Jan 23 2020, 7:42 PM · Restricted Project, Restricted Project
aheejin created D73322: [WebAssembly] Update bleeding-edge CPU features.
Jan 23 2020, 7:42 PM · Restricted Project, Restricted Project
aheejin created D73320: [WebAssembly] Add reference types target feature.
Jan 23 2020, 7:28 PM · Restricted Project, Restricted Project
aheejin committed rG580d7838dd08: [WebAssembly] Fix resume-only case in Emscripten EH (authored by aheejin).
[WebAssembly] Fix resume-only case in Emscripten EH
Jan 23 2020, 6:16 PM
aheejin closed D73308: [WebAssembly] Fix resume-only case in Emscripten EH.
Jan 23 2020, 6:16 PM · Restricted Project
aheejin created D73308: [WebAssembly] Fix resume-only case in Emscripten EH.
Jan 23 2020, 4:49 PM · Restricted Project
aheejin added a comment to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.

Nice work! Sorry for the delayed reply. I like the test generation script and the autogenerated test case, and given the nature of the tests, I don't think there will be many changes to the generated results. With larger number of limits we can maybe use the script like a fuzzer or something too.

Jan 23 2020, 9:30 AM · Restricted Project

Jan 21 2020

aheejin added inline comments to D72972: [WebAssembly] Add experimental multivalue calling ABI.
Jan 21 2020, 6:02 PM · Restricted Project
aheejin accepted D71496: [WebAssembly] Split and recombine multivalue calls for ISel.

LGTM. Please rebase this onto https://reviews.llvm.org/D71484; this currently contains diff of that CL too.

Jan 21 2020, 9:41 AM · Restricted Project