Page MenuHomePhabricator
People aheejin

aheejin (Heejin Ahn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (142 w, 5 d)

Recent Activity
View All

Today

aheejin added a comment to D61037: [WebAssembly] Implement ReplaceNodeResults to fix a SIMD crash.

We talked offline and it's maybe better to have a bit more picture on how ReplaceNodeResults is working before committing this.

Wed, Apr 24, 6:27 PM · Restricted Project
aheejin added inline comments to D60966: [WebAssembly] Emit br_table for most switch instructions.
Wed, Apr 24, 12:31 PM · Restricted Project

Yesterday

aheejin committed rGb9f282d384fc: [WebAssembly] Emit br_table for most switch instructions (authored by aheejin).
[WebAssembly] Emit br_table for most switch instructions
Tue, Apr 23, 2:32 PM
aheejin committed rL359038: [WebAssembly] Emit br_table for most switch instructions.
[WebAssembly] Emit br_table for most switch instructions
Tue, Apr 23, 2:31 PM
aheejin closed D60966: [WebAssembly] Emit br_table for most switch instructions.
Tue, Apr 23, 2:31 PM · Restricted Project
aheejin committed rGace7a086ca38: [WebAssembly] Make LBB markers not affected by test order (authored by aheejin).
[WebAssembly] Make LBB markers not affected by test order
Tue, Apr 23, 2:16 PM
aheejin committed rL359036: [WebAssembly] Make LBB markers not affected by test order.
[WebAssembly] Make LBB markers not affected by test order
Tue, Apr 23, 2:15 PM
aheejin closed D60929: [WebAssembly] Make LBB markers not affected by test order.
Tue, Apr 23, 2:15 PM · Restricted Project
aheejin added a comment to D60929: [WebAssembly] Make LBB markers not affected by test order.

Ping. I guess I can just commit this, because it's simple anyway

Tue, Apr 23, 1:17 PM · Restricted Project

Mon, Apr 22

aheejin added a reviewer for D60929: [WebAssembly] Make LBB markers not affected by test order: tlively.
Mon, Apr 22, 2:50 PM · Restricted Project
aheejin added a comment to D60929: [WebAssembly] Make LBB markers not affected by test order.

Ping

Mon, Apr 22, 11:43 AM · Restricted Project
aheejin updated the summary of D60966: [WebAssembly] Emit br_table for most switch instructions.
Mon, Apr 22, 11:15 AM · Restricted Project
aheejin updated the diff for D60966: [WebAssembly] Emit br_table for most switch instructions.
  • v8 -> VM
Mon, Apr 22, 11:15 AM · Restricted Project
aheejin updated the summary of D60966: [WebAssembly] Emit br_table for most switch instructions.
Mon, Apr 22, 7:53 AM · Restricted Project
aheejin added inline comments to D60966: [WebAssembly] Emit br_table for most switch instructions.
Mon, Apr 22, 7:53 AM · Restricted Project
aheejin added a parent revision for D60966: [WebAssembly] Emit br_table for most switch instructions: D60929: [WebAssembly] Make LBB markers not affected by test order.
Mon, Apr 22, 7:53 AM · Restricted Project
aheejin added a child revision for D60929: [WebAssembly] Make LBB markers not affected by test order: D60966: [WebAssembly] Emit br_table for most switch instructions.
Mon, Apr 22, 7:53 AM · Restricted Project
aheejin created D60966: [WebAssembly] Emit br_table for most switch instructions.
Mon, Apr 22, 7:48 AM · Restricted Project

Fri, Apr 19

aheejin created D60929: [WebAssembly] Make LBB markers not affected by test order.
Fri, Apr 19, 5:26 PM · Restricted Project

Sat, Apr 13

aheejin committed rG5f3a04510a5d: [WebAssembly] Use Function::hasOptSize() (NFC) (authored by aheejin).
[WebAssembly] Use Function::hasOptSize() (NFC)
Sat, Apr 13, 9:56 AM
aheejin committed rL358336: [WebAssembly] Use Function::hasOptSize() (NFC).
[WebAssembly] Use Function::hasOptSize() (NFC)
Sat, Apr 13, 9:56 AM
aheejin closed D60651: [WebAssembly] Use Function::hasOptSize() (NFC).
Sat, Apr 13, 9:56 AM · Restricted Project
aheejin accepted D60651: [WebAssembly] Use Function::hasOptSize() (NFC).

Thanks! Could you append (NFC) to the CL title?

Sat, Apr 13, 9:17 AM · Restricted Project

Mon, Apr 8

aheejin added inline comments to D60295: [SelectionDAG] Change the jump table size unit from entry to target.
Mon, Apr 8, 5:30 AM · Restricted Project

Sat, Mar 30

aheejin committed rGc4ac74fb4987: [WebAssembly] Fix unwind destination mismatches in CFG stackify (authored by aheejin).
[WebAssembly] Fix unwind destination mismatches in CFG stackify
Sat, Mar 30, 4:05 AM
aheejin committed rL357343: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
[WebAssembly] Fix unwind destination mismatches in CFG stackify
Sat, Mar 30, 4:05 AM
aheejin closed D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Sat, Mar 30, 4:05 AM · Restricted Project
aheejin committed rGe9fd9073e490: [WebAssembly] Run ExplicitLocals pass after CFGStackify (authored by aheejin).
[WebAssembly] Run ExplicitLocals pass after CFGStackify
Sat, Mar 30, 2:29 AM
aheejin committed rL357342: [WebAssembly] Run ExplicitLocals pass after CFGStackify.
[WebAssembly] Run ExplicitLocals pass after CFGStackify
Sat, Mar 30, 2:28 AM
aheejin closed D59652: [WebAssembly] Run ExplicitLocals pass after CFGStackify.
Sat, Mar 30, 2:28 AM · Restricted Project

Fri, Mar 29

aheejin committed rG7e7aad151068: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG (authored by aheejin).
[WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG
Fri, Mar 29, 6:33 PM
aheejin committed rL357337: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG.
[WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG
Fri, Mar 29, 6:33 PM
aheejin closed D59462: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG.
Fri, Mar 29, 6:33 PM · Restricted Project
aheejin accepted D60013: [WebAssembly] Add mutable globals feature.
Fri, Mar 29, 2:39 PM · Restricted Project, Restricted Project
aheejin committed rG67f74aceab19: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify (authored by aheejin).
[WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify
Fri, Mar 29, 12:36 PM
aheejin committed rL357303: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
[WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify
Fri, Mar 29, 12:36 PM
aheejin closed D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Fri, Mar 29, 12:36 PM · Restricted Project
aheejin added a reviewer for D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify: dschuff.
Fri, Mar 29, 12:28 PM · Restricted Project
aheejin updated the diff for D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
  • Test comment
Fri, Mar 29, 12:00 PM · Restricted Project
aheejin updated the summary of D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Fri, Mar 29, 12:00 PM · Restricted Project
aheejin updated the summary of D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Fri, Mar 29, 12:00 PM · Restricted Project
aheejin updated the diff for D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.

Fix test name

Fri, Mar 29, 11:48 AM · Restricted Project
aheejin retitled D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify from [WebAssembly] Handle END_LOOP is in unreachable BB in CFGStackify to [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Fri, Mar 29, 11:46 AM · Restricted Project
aheejin created D60004: [WebAssembly] Handle END_LOOP in unreachable BB in CFGStackify.
Fri, Mar 29, 11:45 AM · Restricted Project

Thu, Mar 28

aheejin accepted D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.

LGTM w/ nits. I like we can use module metadata this way.

Thu, Mar 28, 11:28 AM · Restricted Project

Wed, Mar 27

aheejin added a comment to D59625: [WebAssembly] Merge used feature sets, update atomics linkage policy.

Mostly LGTM. Some nits and questions:

Wed, Mar 27, 11:28 AM · Restricted Project

Tue, Mar 26

aheejin committed rG54551c1df73b: [WebAssembly] Don't analyze branches after CFGStackify (authored by aheejin).
[WebAssembly] Don't analyze branches after CFGStackify
Tue, Mar 26, 11:20 AM
aheejin committed rL357015: [WebAssembly] Don't analyze branches after CFGStackify.
[WebAssembly] Don't analyze branches after CFGStackify
Tue, Mar 26, 11:20 AM
aheejin closed D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Tue, Mar 26, 11:20 AM · Restricted Project
aheejin updated the diff for D59740: [WebAssembly] Don't analyze branches after CFGStackify.
  • Add comment on CFGStackify
Tue, Mar 26, 11:18 AM · Restricted Project
aheejin added inline comments to D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH.
Tue, Mar 26, 10:56 AM · Restricted Project, Restricted Project
aheejin committed rG1aaa481fc1f8: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo (authored by aheejin).
[WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo
Tue, Mar 26, 10:48 AM
aheejin committed rL357011: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo.
[WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo
Tue, Mar 26, 10:47 AM
aheejin closed D59747: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo.
Tue, Mar 26, 10:47 AM · Restricted Project
aheejin committed rG52221d56bcf3: [WebAssembly] Support WebAssemblyFunctionInfo serialization (authored by aheejin).
[WebAssembly] Support WebAssemblyFunctionInfo serialization
Tue, Mar 26, 10:35 AM
aheejin committed rL357009: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
[WebAssembly] Support WebAssemblyFunctionInfo serialization
Tue, Mar 26, 10:34 AM
aheejin closed D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Tue, Mar 26, 10:34 AM · Restricted Project
aheejin committed rG222718fdd205: [WebAssembly] Fix a bug when mixing TRY/LOOP markers (authored by aheejin).
[WebAssembly] Fix a bug when mixing TRY/LOOP markers
Tue, Mar 26, 10:30 AM
aheejin committed rL357008: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
[WebAssembly] Fix a bug when mixing TRY/LOOP markers
Tue, Mar 26, 10:28 AM
aheejin closed D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
Tue, Mar 26, 10:28 AM · Restricted Project
aheejin committed rG44a5a4b10704: [WebAssembly] Fix bugs in BLOCK/TRY placement (authored by aheejin).
[WebAssembly] Fix bugs in BLOCK/TRY placement
Tue, Mar 26, 10:15 AM
aheejin committed rL357007: [WebAssembly] Fix bugs in BLOCK/TRY placement.
[WebAssembly] Fix bugs in BLOCK/TRY placement
Tue, Mar 26, 10:14 AM
aheejin closed D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Tue, Mar 26, 10:14 AM · Restricted Project
aheejin updated the diff for D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
  • Remove -fast-isel=false
Tue, Mar 26, 9:59 AM · Restricted Project

Mar 25 2019

aheejin added inline comments to D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 25 2019, 5:38 PM · Restricted Project
aheejin added inline comments to D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 25 2019, 4:26 PM · Restricted Project
aheejin added inline comments to D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Mar 25 2019, 10:22 AM · Restricted Project
aheejin added inline comments to D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Mar 25 2019, 10:22 AM · Restricted Project
aheejin updated the summary of D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Mar 25 2019, 10:15 AM · Restricted Project
aheejin updated the diff for D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
  • Deleted all logics related to -wasm-disable-explicit-locals thanks to D59652
  • Fix several bugs
  • Add more tests
Mar 25 2019, 10:13 AM · Restricted Project

Mar 24 2019

aheejin updated the summary of D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
Mar 24 2019, 12:00 PM · Restricted Project
aheejin updated the diff for D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.

delete a newline

Mar 24 2019, 11:52 AM · Restricted Project
aheejin added a parent revision for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
Mar 24 2019, 11:50 AM · Restricted Project
aheejin added a child revision for D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 24 2019, 11:50 AM · Restricted Project
aheejin removed a child revision for D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 24 2019, 11:50 AM · Restricted Project
aheejin removed a parent revision for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Mar 24 2019, 11:50 AM · Restricted Project
aheejin added a child revision for D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement: D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
Mar 24 2019, 11:49 AM · Restricted Project
aheejin added a parent revision for D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers: D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Mar 24 2019, 11:49 AM · Restricted Project
aheejin created D59751: [WebAssembly] Fix a bug when mixing TRY/LOOP markers.
Mar 24 2019, 11:48 AM · Restricted Project
aheejin committed rG803c7782d5c3: [WebAssembly] Rename a variable in CFGSort (NFC) (authored by aheejin).
[WebAssembly] Rename a variable in CFGSort (NFC)
Mar 24 2019, 10:34 AM
aheejin committed rL356861: [WebAssembly] Rename a variable in CFGSort (NFC).
[WebAssembly] Rename a variable in CFGSort (NFC)
Mar 24 2019, 10:34 AM
Herald added a project to D54411: [Codegen] Merge tail blocks with no successors after block placement: Restricted Project.
Mar 24 2019, 9:27 AM · Restricted Project
aheejin added a child revision for D59747: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 24 2019, 6:52 AM · Restricted Project
aheejin removed a parent revision for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Mar 24 2019, 6:52 AM · Restricted Project
aheejin added a parent revision for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D59747: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo.
Mar 24 2019, 6:52 AM · Restricted Project
aheejin edited child revisions for D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization, added: 1; removed: 1.
Mar 24 2019, 6:52 AM · Restricted Project
aheejin added inline comments to D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Mar 24 2019, 6:52 AM · Restricted Project
aheejin added a parent revision for D59747: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo: D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Mar 24 2019, 6:52 AM · Restricted Project
aheejin created D59747: [WebAssembly] Add CFGStacikfied field to WebAssemblyFunctionInfo.
Mar 24 2019, 6:49 AM · Restricted Project
aheejin updated the diff for D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.

Deleted isCFGStackified field and its serialization

Mar 24 2019, 6:47 AM · Restricted Project
aheejin added inline comments to D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 24 2019, 6:01 AM · Restricted Project

Mar 23 2019

aheejin updated the summary of D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 23 2019, 1:00 PM · Restricted Project
aheejin added a parent revision for D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 23 2019, 12:59 PM · Restricted Project
aheejin added a child revision for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D48345: [WebAssembly] Fix unwind destination mismatches in CFG stackify.
Mar 23 2019, 12:59 PM · Restricted Project
aheejin added a child revision for D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 23 2019, 12:58 PM · Restricted Project
aheejin added parent revisions for D59740: [WebAssembly] Don't analyze branches after CFGStackify: D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement, D59737: [WebAssembly] Support WebAssemblyFunctionInfo serialization.
Mar 23 2019, 12:58 PM · Restricted Project
aheejin added a child revision for D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement: D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 23 2019, 12:58 PM · Restricted Project
aheejin created D59740: [WebAssembly] Don't analyze branches after CFGStackify.
Mar 23 2019, 12:58 PM · Restricted Project
aheejin added inline comments to D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Mar 23 2019, 12:31 PM · Restricted Project
aheejin updated the summary of D59739: [WebAssembly] Fix bugs in BLOCK/TRY placement.
Mar 23 2019, 12:26 PM · Restricted Project