User Details
- User Since
- Jul 29 2016, 12:33 AM (233 w, 3 d)
Fri, Jan 15
- Address comments + change delegate's opcode
Thanks for the review, and sorry for delayed reply.
Tue, Jan 12
Mon, Jan 11
Sat, Jan 9
Address comments
Fix duplicate __clang_call_terminate call case
CATCH -> CATCH_ALL in comment
Fri, Jan 8
Delete declare void @_ZSt9terminatev()
Remove an extra word
Mon, Jan 4
Revert clang-format for MachineValueType.h
Tue, Dec 29
Wed, Dec 23
Thanks for the explanation! LGTM % the alignment nit
Nice!
Tue, Dec 22
Nice!
Thanks for the info!
Mon, Dec 21
Wow, I didn't know we can do OOP in TableGen! (Are these new functionalities?)
Dec 9 2020
Dec 8 2020
Yeah I think that should be fine.
Dec 7 2020
Oh, I see what you mean. LGTM and I don't think we need a more complicated approach at the moment.
Dec 1 2020
Nov 30 2020
Add missing COPY opcode handling in Peephole
Fix signature
Add tests to test reference types in params and results
Fix a typo
Add missing reference types in utility functions
Nov 18 2020
LGTM. Do you have commit access? If not, I can commit this for you. You can also provide your name and email address if you want, so that I can use your info for the commit, as described here: https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator
Nov 13 2020
Nov 12 2020
It seems we have inline asm tests here: https://github.com/llvm/llvm-project/blob/master/llvm/test/CodeGen/WebAssembly/inline-asm.ll
Nov 9 2020
Nov 6 2020
Nov 3 2020
I guess that optimization cannot be done here and should be done later? And there's also an existing TODO to generalize this optimization. Maybe we can do it as a part of the 'generalization' later? But I also doubt how worthwhile it will be, given that this bug was found first time 5 years after this part of the code was first written...
Nov 2 2020
- Fix comment wrapping