- User Since
- Jul 29 2016, 12:33 AM (168 w, 3 d)
Fri, Oct 18
Tue, Oct 15
Mon, Oct 14
Fri, Oct 11
Nice! Mostly LGTM.
Wed, Oct 9
Tue, Oct 8
We can make the decision based on whatever heuristic we want, but minimizing number of instructions seems like a good metric for now until we can run experiments to tune the selection algorithm.
Wouldn't minimizing the number of instruction be the same thing as minimizing the number of bytes, only more inaccurate?
LLVM produces a poison value if the dynamic swizzle indices are greater than the vector size, but the WebAssembly instruction sets the corresponding output lane to zero.
Where do we set those undef or poison lanes to zero?
- I remember before we had a somewhat complicated logic to calculate the number of bytes of total instructions of each case of the case we use v128.const and vs. when we use splats. Don't we need that anymore? Can we make the decision solely based the number of swizzles / consts / and splats?
Mon, Oct 7
Thank you! Done in r374015.
Merging this, because this crashes builds.
Sun, Oct 6
Rebase onto D68553
Tue, Oct 1
Mon, Sep 30
- Address comments
Thu, Sep 26
Mon, Sep 23
Mostly LGTM. By the way this contains diff of D67783 as well.
Sep 21 2019
LGTM as long as they are not used, but I'd like to check with @sunfish to be sure as well.
Sep 18 2019
+1 on erroring out on the backend side. And how about "wasm64 is not supported"? wasm64... is still a registered target in the frontend, so...
Sep 16 2019
What are the default values for those if we unset them?
Sep 15 2019
Sep 12 2019
Sep 11 2019
I think that's it.
Sep 10 2019
Can you give the link for the spec of these new instructions?
Sep 6 2019
- Error out when -fwasm-exceptions is specified with -mllvm -enable-emscripten-cxx-exceptions
Sep 5 2019
@tlively @sbc100 What I wanted was to make -fwasm-exceptions as something like -pthreads, which serves as the only flag that needs to be turned on and turns on all other necessary flags, such as +matomics, +mbulk-memory, and --shared-memory. I think all those architectural flags starting with -m can be someday all turned on, when all our existing proposals become the new MVP, and I still want to give users an option to opt out of threads of exception handling at that point. And it also makes sense to have a LangOption of WasmExceptions given that there are LangOptions for all other exception models. I think this covers most of the questions above.
Sep 4 2019
- Remove a blank line
Sep 3 2019
LGTM % nits if tests pass.
- Renamed to lower-em-sjlj-alias.ll
Aug 30 2019
Yeah I think that can be a more generalized solution too.
Should we handle these too?
- There seems to be a generic intrinsic for fused multiply-add: https://github.com/llvm/llvm-project/blob/d21a3e41a4cfd52e3c5c9341f0b5ce8a173198bf/llvm/include/llvm/Target/GenericOpcodes.td#L612-L619
- There are FMA related nodes in ISDOpcode.h, such as