Page MenuHomePhabricator

aheejin (Heejin Ahn)
Bot

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (309 w, 5 d)

Recent Activity

Tue, Jun 21

aheejin committed rG27e4afcea718: [DSE] Don't remove nounwind invokes (authored by aheejin).
[DSE] Don't remove nounwind invokes
Tue, Jun 21, 11:54 AM · Restricted Project, Restricted Project
aheejin closed D128224: [DSE] Don't remove nounwind invokes.
Tue, Jun 21, 11:54 AM · Restricted Project, Restricted Project
aheejin added a comment to D128224: [DSE] Don't remove nounwind invokes.

Also changed ptr to integer pointers because it requires an additional arguments in the opt command line.

Tue, Jun 21, 11:53 AM · Restricted Project, Restricted Project
aheejin updated the diff for D128224: [DSE] Don't remove nounwind invokes.

clang-format

Tue, Jun 21, 11:49 AM · Restricted Project, Restricted Project
aheejin added inline comments to D128224: [DSE] Don't remove nounwind invokes.
Tue, Jun 21, 11:48 AM · Restricted Project, Restricted Project
aheejin updated the diff for D128224: [DSE] Don't remove nounwind invokes.

Address comments

Tue, Jun 21, 11:48 AM · Restricted Project, Restricted Project

Mon, Jun 20

aheejin requested review of D128224: [DSE] Don't remove nounwind invokes.
Mon, Jun 20, 2:03 PM · Restricted Project, Restricted Project

Fri, Jun 17

aheejin accepted D128094: [WebAssembly][Object] Remove requirement that objects must have code sections.

(Also we can't just always require the presence of e.g. the
function or global sections, because a binary may just have any functions.
There's only an problem if the name or linking section tries to name a
nonexistent function).

Fri, Jun 17, 6:07 PM · Restricted Project, Restricted Project

Wed, Jun 15

aheejin committed rGb2f4112f2567: [InstCombine] Improve check for catchswitch BBs (NFC) (authored by aheejin).
[InstCombine] Improve check for catchswitch BBs (NFC)
Wed, Jun 15, 1:06 AM · Restricted Project, Restricted Project
aheejin closed D127810: [InstCombine] Improve check for catchswitch BBs (NFC).
Wed, Jun 15, 1:06 AM · Restricted Project, Restricted Project

Tue, Jun 14

aheejin added inline comments to D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch.
Tue, Jun 14, 4:44 PM · Restricted Project, Restricted Project
aheejin requested review of D127810: [InstCombine] Improve check for catchswitch BBs (NFC).
Tue, Jun 14, 4:44 PM · Restricted Project, Restricted Project

Mon, Jun 13

aheejin committed rGac4006b0d69f: [InstCombine] Don't slice up PHIs when pred BB has catchswitch (authored by aheejin).
[InstCombine] Don't slice up PHIs when pred BB has catchswitch
Mon, Jun 13, 6:32 PM · Restricted Project, Restricted Project
aheejin closed D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch.
Mon, Jun 13, 6:32 PM · Restricted Project, Restricted Project
aheejin added inline comments to D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch.
Mon, Jun 13, 5:02 PM · Restricted Project, Restricted Project
aheejin updated the diff for D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch.

Address comments

Mon, Jun 13, 5:02 PM · Restricted Project, Restricted Project
aheejin added inline comments to D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch.
Mon, Jun 13, 2:42 PM · Restricted Project, Restricted Project
aheejin requested review of D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch.
Mon, Jun 13, 2:39 PM · Restricted Project, Restricted Project

Wed, Jun 8

aheejin accepted D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Wed, Jun 8, 3:07 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 6

aheejin added inline comments to D127170: [WebAssembly] Implement remaining relaxed SIMD instructions.
Mon, Jun 6, 11:00 PM · Restricted Project, Restricted Project, Restricted Project
aheejin added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Mon, Jun 6, 8:33 PM · Restricted Project, Restricted Project
aheejin accepted D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC].
Mon, Jun 6, 8:30 PM · Restricted Project, Restricted Project, Restricted Project
aheejin added inline comments to D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC].
Mon, Jun 6, 5:24 PM · Restricted Project, Restricted Project, Restricted Project
aheejin accepted D127157: [WebAssembly][NFC] RelaxedBinary tablegen multiclass for relaxed SIMD.
Mon, Jun 6, 5:08 PM · Restricted Project, Restricted Project
aheejin added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Mon, Jun 6, 4:58 PM · Restricted Project, Restricted Project
aheejin added inline comments to D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC].
Mon, Jun 6, 4:57 PM · Restricted Project, Restricted Project, Restricted Project
aheejin added a comment to rGe07dab8a4501: Fix typo in wasm objcopy's only-keep-debug.test.

What do you think about this line in https://reviews.llvm.org/D126509#3561435? Not something important either though.....

# CHECK-NOT:    - Type: TYPE
Mon, Jun 6, 3:56 PM · Restricted Project, Restricted Project
aheejin added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Mon, Jun 6, 3:40 PM · Restricted Project, Restricted Project
aheejin added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Mon, Jun 6, 1:36 PM · Restricted Project, Restricted Project

May 19 2022

aheejin committed rGcde083e01095: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow (authored by aheejin).
[WebAssembly] Fix register use-def in FixIrreducibleControlFlow
May 19 2022, 11:14 AM · Restricted Project, Restricted Project
aheejin closed D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 19 2022, 11:14 AM · Restricted Project, Restricted Project
aheejin committed rG44718c5ef2c5: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir (authored by aheejin).
[WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir
May 19 2022, 11:13 AM · Restricted Project, Restricted Project
aheejin closed D125514: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir.
May 19 2022, 11:12 AM · Restricted Project, Restricted Project

May 18 2022

aheejin added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

@CarlosAlbertoEnciso That's great news! Thank you for letting me know.

May 18 2022, 9:11 AM · Restricted Project, Restricted Project, debug-info

May 17 2022

aheejin added inline comments to D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 17 2022, 11:16 AM · Restricted Project, Restricted Project
aheejin added inline comments to D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 17 2022, 10:52 AM · Restricted Project, Restricted Project
aheejin updated the diff for D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.

Remove getSetProperties

May 17 2022, 10:50 AM · Restricted Project, Restricted Project

May 16 2022

aheejin updated the summary of D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 16 2022, 6:04 PM · Restricted Project, Restricted Project
aheejin added inline comments to D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 16 2022, 5:05 PM · Restricted Project, Restricted Project
aheejin updated the diff for D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.

Add getRequiredProperties call to OptimizeLiveIntervals

May 16 2022, 5:05 PM · Restricted Project, Restricted Project
aheejin accepted D125726: [WebAssembly] Update relaxed SIMD opcodes and names.
May 16 2022, 2:45 PM · Restricted Project, Restricted Project

May 13 2022

aheejin added inline comments to D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 13 2022, 3:42 PM · Restricted Project, Restricted Project
aheejin added a comment to D125514: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir.

The script doesn't generate CHECK lines next to each BB but rather generates the whole function together, making it harder to see changes in each BB for me. Also there are comments for CHECK lines, which will be lost if we use the script. So I'm not sure using it will improve readability in this case.

May 13 2022, 1:07 AM · Restricted Project, Restricted Project
aheejin updated the summary of D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 13 2022, 12:59 AM · Restricted Project, Restricted Project

May 12 2022

aheejin abandoned D56091: [WebAssembly] Don't add IMPLICIT_DEFs in PrepareForLiveIntervals.

Closing in favor of D125515.

May 12 2022, 8:37 PM · Restricted Project, Restricted Project
aheejin updated the summary of D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 12 2022, 8:32 PM · Restricted Project, Restricted Project
aheejin updated the diff for D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.

Remove a stray line

May 12 2022, 8:18 PM · Restricted Project, Restricted Project
aheejin added inline comments to D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 12 2022, 8:17 PM · Restricted Project, Restricted Project
aheejin requested review of D125515: [WebAssembly] Fix register use-def in FixIrreducibleControlFlow.
May 12 2022, 8:13 PM · Restricted Project, Restricted Project
aheejin requested review of D125514: [WebAssembly] Use CHECK-NEXT for irreducible-cfg.mir.
May 12 2022, 8:09 PM · Restricted Project, Restricted Project
aheejin accepted D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.

Thanks! I have one more question but don't want to hold this back with nitpicky things. (The review turnaround time due to time zone doesn't help either)

May 12 2022, 11:47 AM · Restricted Project, Restricted Project

May 11 2022

aheejin added inline comments to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
May 11 2022, 4:38 PM · Restricted Project, Restricted Project
Herald added a project to D88661: llvm-dva - Debug Information Visual Analizer: Restricted Project.

Is this tool still planned to be upstreamed? Is this patch the most up-to-date version of this tool, or there is another repo? How is this CL related to https://github.com/SNSystems/DIVA?

May 11 2022, 4:22 PM · Restricted Project, Restricted Project, debug-info

May 10 2022

aheejin added inline comments to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
May 10 2022, 5:10 PM · Restricted Project, Restricted Project

Mar 17 2022

aheejin accepted D121662: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h.
Mar 17 2022, 2:47 PM · Restricted Project, Restricted Project

Mar 16 2022

aheejin committed rGb8038a916df2: [WebAssembly] Disable SimplifyDemandedVectorElts after legalization (authored by aheejin).
[WebAssembly] Disable SimplifyDemandedVectorElts after legalization
Mar 16 2022, 8:53 PM · Restricted Project
aheejin closed D121869: [WebAssembly] Disable SimplifyDemandedVectorElts after legalization.
Mar 16 2022, 8:52 PM · Restricted Project, Restricted Project
aheejin committed rG0ca21320675d: [WebAssembly] Improve EH/SjLj error messages (authored by aheejin).
[WebAssembly] Improve EH/SjLj error messages
Mar 16 2022, 8:52 PM · Restricted Project
aheejin closed D120678: [WebAssembly] Improve EH/SjLj error messages.
Mar 16 2022, 8:52 PM · Restricted Project, Restricted Project
aheejin added a comment to D121869: [WebAssembly] Disable SimplifyDemandedVectorElts after legalization.

I wasn't able to check performances for real-world programs myself, but there's no changes in our existing tests. I don't think it will have a huge impact because I made the condition fairly specific: we bail out only when it is a build_vector and the DAG is already type-legalized and legalized, meaning it does so only in the very last stage before instruction selection. Also I'm not sure if there's any other way around this at this point.

Mar 16 2022, 7:55 PM · Restricted Project, Restricted Project
aheejin requested review of D121869: [WebAssembly] Disable SimplifyDemandedVectorElts after legalization.
Mar 16 2022, 4:23 PM · Restricted Project, Restricted Project

Mar 15 2022

aheejin accepted D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'.
Mar 15 2022, 1:01 PM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

aheejin requested review of D120678: [WebAssembly] Improve EH/SjLj error messages.
Feb 28 2022, 1:27 PM · Restricted Project, Restricted Project

Feb 17 2022

aheejin added a comment to D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.

Oh that fixed my error. Thanks!

Feb 17 2022, 7:14 PM · Restricted Project
aheejin committed rG4f9b8397725c: [WebAssembly] Make EH/SjLj vars unconditionally thread local (authored by aheejin).
[WebAssembly] Make EH/SjLj vars unconditionally thread local
Feb 17 2022, 4:04 PM
aheejin added a reverting change for D88323: [WebAssembly] Check features before making SjLj vars thread-local: rG4f9b8397725c: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 17 2022, 4:04 PM · Restricted Project
aheejin closed D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 17 2022, 4:04 PM · Restricted Project
aheejin added a comment to D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.

Yes, all three also fail with LLVM ToT.

Feb 17 2022, 3:57 PM · Restricted Project
aheejin added a comment to D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.

Can you verify that the core2 and other emscripten test suites both pass with this change

Feb 17 2022, 2:19 PM · Restricted Project
aheejin added inline comments to D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 17 2022, 12:59 PM · Restricted Project
aheejin updated the diff for D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.

Remove lambda

Feb 17 2022, 12:54 PM · Restricted Project

Feb 16 2022

aheejin added inline comments to D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 16 2022, 11:42 PM · Restricted Project
aheejin updated the summary of D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 16 2022, 11:39 PM · Restricted Project
aheejin requested review of D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 16 2022, 11:34 PM · Restricted Project
aheejin added a reverting change for D88323: [WebAssembly] Check features before making SjLj vars thread-local: D120013: [WebAssembly] Make EH/SjLj vars unconditionally thread local.
Feb 16 2022, 11:34 PM · Restricted Project
aheejin committed rGc60d8229651c: [WebAssembly] Make __wasm_lpad_context thread-local (authored by aheejin).
[WebAssembly] Make __wasm_lpad_context thread-local
Feb 16 2022, 3:57 PM
aheejin closed D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 16 2022, 3:57 PM · Restricted Project
aheejin added a comment to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.

Then I'll just land this first and make the discussed changes as a follow-up. Thanks!

Feb 16 2022, 2:07 PM · Restricted Project

Feb 15 2022

aheejin added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 7:32 PM · Restricted Project
aheejin added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 7:17 PM · Restricted Project
aheejin added a reviewer for D119803: [WebAssembly] Make __wasm_lpad_context thread-local: tlively.
Feb 15 2022, 4:10 PM · Restricted Project
aheejin committed rGb8438a697573: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test (authored by aheejin).
[WebAssembly] Add TLS FileCheck lines to Wasm SjLj test
Feb 15 2022, 3:52 PM
aheejin closed D119800: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test.
Feb 15 2022, 3:52 PM · Restricted Project
aheejin added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 3:37 PM · Restricted Project
aheejin added inline comments to D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 3:21 PM · Restricted Project
aheejin updated subscribers of D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 15 2022, 12:11 PM · Restricted Project
aheejin updated the diff for D119803: [WebAssembly] Make __wasm_lpad_context thread-local.

Simplify

Feb 15 2022, 12:11 PM · Restricted Project

Feb 14 2022

aheejin updated the summary of D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 14 2022, 6:32 PM · Restricted Project
aheejin requested review of D119803: [WebAssembly] Make __wasm_lpad_context thread-local.
Feb 14 2022, 6:31 PM · Restricted Project
aheejin added inline comments to D119800: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test.
Feb 14 2022, 6:10 PM · Restricted Project
aheejin retitled D119800: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test from [WebAssembly] Add TLS FileCheck lines to Wasm SjLj to [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test.
Feb 14 2022, 6:08 PM · Restricted Project
aheejin requested review of D119800: [WebAssembly] Add TLS FileCheck lines to Wasm SjLj test.
Feb 14 2022, 6:08 PM · Restricted Project
aheejin accepted D119630: [WebAssembly] Use GeneralDynamic TLS for exception handling builtins..

These global TLS symbols are shared across all shared libraries and cannot be assumed to be local to the currently module.

Feb 14 2022, 11:35 AM · Restricted Project

Jan 27 2022

aheejin committed rG4f1244d7ccb8: [WebAssembly] Nullify unnecessary setjmp invokes (authored by aheejin).
[WebAssembly] Nullify unnecessary setjmp invokes
Jan 27 2022, 9:11 PM
aheejin closed D118408: [WebAssembly] Nullify unnecessary setjmp invokes.
Jan 27 2022, 9:11 PM · Restricted Project
aheejin committed rG20c1d9ce5ece: [WebAssembly] Handle cleanuppad with no parent in Wasm SjLj (authored by aheejin).
[WebAssembly] Handle cleanuppad with no parent in Wasm SjLj
Jan 27 2022, 9:11 PM
aheejin closed D118407: [WebAssembly] Handle cleanuppad with no parent in Wasm SjLj.
Jan 27 2022, 9:10 PM · Restricted Project
aheejin committed rG26d587cf0f15: [WebAssembly] Error out for setjmp within catch clause for Wasm SjLj (authored by aheejin).
[WebAssembly] Error out for setjmp within catch clause for Wasm SjLj
Jan 27 2022, 9:06 PM
aheejin closed D118286: [WebAssembly] Error out for setjmp within catch clause for Wasm SjLj.
Jan 27 2022, 9:06 PM · Restricted Project
aheejin committed rG786da40667dc: [WebAssembly] Don't copy noreturn attr to invokes (authored by aheejin).
[WebAssembly] Don't copy noreturn attr to invokes
Jan 27 2022, 9:05 PM