aheejin (Heejin Ahn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (68 w, 6 d)

Recent Activity

Today

aheejin added a comment to D40170: [llvm-tblgen] - Stop using std::string in RecordKeeper..

I don't know if they have bots with sanitizer enabled. And it looks like -DBUILD_SHARED_LIBS=ON does not always reproduce the failure; it looks like it depends on the system. But I guess the memory sanitizer behavior should be the same. Please let me know if you can reproduce the error. Thank you!

Thu, Nov 23, 5:33 AM

Yesterday

aheejin added a comment to D40170: [llvm-tblgen] - Stop using std::string in RecordKeeper..

When built with memory sanitizer, this change causes many use-of-uninitialized-value errors and also causes compilation failures when built with the cmake option -DBUILD_SHARED_LIBS=ON. AFAIK, StringRef does not store the string contents in itself and just maintains a pointer to an external storage. Are you sure all the string keys supplied to Classes or Defs map in RecordKeeper class are persistent throughout all the uses of those maps?

Wed, Nov 22, 6:16 PM
aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

+ Disabled storing personality function address at every landing pad
+ Removed hardcoding of '_Unwind_Resume' function name
+ Rebased to the tip of the svn

Wed, Nov 22, 1:39 PM

Thu, Nov 16

aheejin added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Thu, Nov 16, 3:16 PM

Oct 17 2017

aheejin added a comment to D38379: Classify llvm-cfi-verify..

@skatkov FYI I had the same problem and updating cmake to the latest version solved the issue.

Oct 17 2017, 11:00 AM

Oct 5 2017

aheejin updated the summary of D37606: [WebAssembly] Add Wasm exception handling prepare pass.
Oct 5 2017, 4:28 PM
aheejin added a comment to D37606: [WebAssembly] Add Wasm exception handling prepare pass.

@dschuff Do you think we can land this? This is not specifically related to the proposed spec change.

Oct 5 2017, 4:00 PM

Oct 3 2017

aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

clang-tidy modernize

Oct 3 2017, 6:32 PM
aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

Rebased to the tip of the svn.

Oct 3 2017, 4:53 PM
aheejin added inline comments to D37606: [WebAssembly] Add Wasm exception handling prepare pass.
Oct 3 2017, 2:44 PM
aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

JS engine -> VM

Oct 3 2017, 2:43 PM

Sep 25 2017

aheejin added a comment to D37606: [WebAssembly] Add Wasm exception handling prepare pass.

For the curious, here is in-progress work of WebAssembly EH scheme documentation, which will be merged to the official WebAssembly tool-convention repo later.

Sep 25 2017, 5:02 AM

Sep 21 2017

aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

Add an optimization: We don't store personality function address and LSDA
address at non-top-level landing pads (landing pads that are dominated by
another landing pad), because they have already been stored before.

Sep 21 2017, 3:34 PM

Sep 16 2017

aheejin added a comment to D37942: [WebAssembly] Restore __builtin_wasm_rethrow builtin.

I didn't close it explicitly. I just committed the change. I don't know why my CLs do not say "closed by commit rxxxx" like other CLs...

Sep 16 2017, 1:52 AM

Sep 15 2017

aheejin committed rL313430: [WebAssembly] Restore __builtin_wasm_rethrow builtin.
[WebAssembly] Restore __builtin_wasm_rethrow builtin
Sep 15 2017, 6:09 PM
aheejin closed D37942: [WebAssembly] Restore __builtin_wasm_rethrow builtin.
Sep 15 2017, 6:09 PM
aheejin created D37942: [WebAssembly] Restore __builtin_wasm_rethrow builtin.
Sep 15 2017, 4:22 PM
aheejin added a comment to D37931: Remove __builtin_wasm_rethrow builtin.

@dschuff I can restore it, and maybe I should, but I don't know how it would make a difference in preserving stack traces. Even if I will change __cxa_rethrow's implementation to use rethrow, only thing that changes is VM will get the argument (thrown object) from a separate storage reserved for rethrow rather than get it from the top of Wasm value stack. __cxa_rethrow does not reallocate exception object no matter which instruction (throw or rethrow) it uses.

Sep 15 2017, 4:14 PM
aheejin added a comment to D37931: Remove __builtin_wasm_rethrow builtin.

Hmm. I somehow thought it's not possible to implement __cxa_rethrow using rethrow instruction, but to think about it, it might be actually possible. I guess I can't restore them within this CL and should open another one...?

Sep 15 2017, 4:08 PM
aheejin committed rL313402: Remove __builtin_wasm_rethrow builtin.
Remove __builtin_wasm_rethrow builtin
Sep 15 2017, 3:03 PM
aheejin closed D37931: Remove __builtin_wasm_rethrow builtin.
Sep 15 2017, 3:02 PM
aheejin created D37931: Remove __builtin_wasm_rethrow builtin.
Sep 15 2017, 2:28 PM

Sep 14 2017

aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

wasm_landingpad_context -> wasm_lpad_context

Sep 14 2017, 11:44 AM

Sep 8 2017

aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

typo

Sep 8 2017, 4:02 PM
aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

add a line in the test

Sep 8 2017, 12:29 AM
aheejin updated the diff for D37606: [WebAssembly] Add Wasm exception handling prepare pass.

delete a stray line

Sep 8 2017, 12:24 AM

Sep 7 2017

aheejin created D37606: [WebAssembly] Add Wasm exception handling prepare pass.
Sep 7 2017, 5:24 PM

Aug 24 2017

aheejin added a comment to D35592: [WebAssembly] Remove duplicated RTLIB names.

Just saw this hasn't been landed. Are you waiting from @dblaikie ?

Aug 24 2017, 6:01 PM
aheejin committed rL311691: [WebAssembly] Update GCC test suite failure expectations.
[WebAssembly] Update GCC test suite failure expectations
Aug 24 2017, 12:44 PM
aheejin closed D37100: [WebAssembly] Update GCC test suite failure expectations.
Aug 24 2017, 12:44 PM
aheejin created D37100: [WebAssembly] Update GCC test suite failure expectations.
Aug 24 2017, 2:31 AM

Aug 16 2017

aheejin resigned from D36764: The following functions and tests work fine for powerpc64, so enable them..

I don't have enough context or knowledge on this code base. Sorry!

Aug 16 2017, 2:50 PM

Aug 11 2017

aheejin added a comment to D36555: Move x86-specific sources to x86-specific source lists..

Looks OK to me, but I haven't worked on this part of code either, so I think someone else should approve it.

Aug 11 2017, 2:58 PM

Jul 20 2017

aheejin accepted D35592: [WebAssembly] Remove duplicated RTLIB names.
Jul 20 2017, 1:46 PM

Jul 18 2017

aheejin added inline comments to D35592: [WebAssembly] Remove duplicated RTLIB names.
Jul 18 2017, 6:28 PM

Jul 12 2017

aheejin committed rL307841: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.
[WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported
Jul 12 2017, 1:50 PM
aheejin closed D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.
Jul 12 2017, 1:50 PM
aheejin added a comment to D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.

@dschuff PTAL

Jul 12 2017, 1:45 PM
aheejin retitled D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported from [WebAssembly] Add element atomic memmove intrinsics to runtime library calls to [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.
Jul 12 2017, 1:45 PM
aheejin updated the diff for D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.

Made atomic memcpy/memmove intrinsics as unsupported for now. And also made the comments consistent with the up-to-date intrinsic names.

Jul 12 2017, 1:42 PM
aheejin created D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.
Jul 12 2017, 12:53 PM

Jun 29 2017

aheejin committed rL306775: [WebAssembly] Add throw/rethrow builtins for exception handling.
[WebAssembly] Add throw/rethrow builtins for exception handling
Jun 29 2017, 5:44 PM
aheejin closed D34783: [WebAssembly] Add throw/rethrow builtins for exception handling.
Jun 29 2017, 5:44 PM
aheejin committed rL306774: [WebAssembly] Add support for exception handling instructions.
[WebAssembly] Add support for exception handling instructions
Jun 29 2017, 5:43 PM
aheejin closed D34826: [WebAssembly] Add support for exception handling instructions.
Jun 29 2017, 5:43 PM
aheejin added a comment to D34783: [WebAssembly] Add throw/rethrow builtins for exception handling.

Uploaded LLVM side patch: https://reviews.llvm.org/D34826

Jun 29 2017, 11:54 AM
aheejin retitled D34826: [WebAssembly] Add support for exception handling instructions from <<Replace this line with your revision title> [WebAssembly] Add support for exception handling instructions to [WebAssembly] Add support for exception handling instructions.
Jun 29 2017, 11:50 AM
aheejin created D34826: [WebAssembly] Add support for exception handling instructions.
Jun 29 2017, 11:50 AM

Jun 28 2017

aheejin updated the diff for D34783: [WebAssembly] Add throw/rethrow builtins for exception handling.

Reverted non-relevant changes

Jun 28 2017, 3:37 PM
aheejin created D34783: [WebAssembly] Add throw/rethrow builtins for exception handling.
Jun 28 2017, 3:35 PM
aheejin abandoned D24440: [WebAssembly] Exception structure recovery in CFGStackify (experimental).

This revision was created just for the record and was not intended for landing.

Jun 28 2017, 3:18 PM

Sep 9 2016

aheejin added a comment to D24440: [WebAssembly] Exception structure recovery in CFGStackify (experimental).

@dschuff: Oh, and this does not implement the special treatment of terminate.lpad.

Sep 9 2016, 7:51 PM
aheejin retitled D24440: [WebAssembly] Exception structure recovery in CFGStackify (experimental) from to [WebAssembly] Exception structure recovery in CFGStackify (experimental).
Sep 9 2016, 7:49 PM
aheejin committed rL281131: [WebAssembly] Fix typos in comments.
[WebAssembly] Fix typos in comments
Sep 9 2016, 7:42 PM

Sep 1 2016

aheejin added a comment to D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).

I didn't manually close this one. This one was automatically closed when I committed the revision.

Sep 1 2016, 5:08 PM
aheejin committed rL280415: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).
[WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302)
Sep 1 2016, 2:13 PM
aheejin closed D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).
Sep 1 2016, 2:13 PM
aheejin updated the diff for D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).

Address comments

Sep 1 2016, 1:30 PM
aheejin added a comment to D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).

Oh, TargetPassConfig::addPassesToHandleExceptions() is not virtual, so it can't be overriden anyway.

Sep 1 2016, 11:09 AM
aheejin added a comment to D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).

In that case, because addPassesToHandleExceptions always runs, createUnreachableBlockEliminationPass() will always run even if neither EH nor SjLj is enabled. And I think this may affect other tests in case there are unreachable blocks in other tests. Shouldn't it be

if (!EnableEmException && EnableEmSjLj) {
  addPass(createLowerInvokePass());
  addPass(createCFGSimplificationPass());
}

As I did in this patch?

Sep 1 2016, 11:02 AM
aheejin added a comment to D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).

Then should I also add SjLj to that addPassesToHandleException? Currently SjLj does not expect any invokes to exist in the module.
I guess we have to, because anyway EH and SjLj are in the same pass.

Sep 1 2016, 9:42 AM
aheejin added a comment to D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).

The reason for the test failure in the previous commit was this part:
In lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp

Sep 1 2016, 12:27 AM
aheejin retitled D24121: [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302) from to [WebAssembly] Add asm.js-style setjmp/longjmp handling for wasm (reland r280302).
Sep 1 2016, 12:21 AM

Aug 31 2016

aheejin committed rL280329: Revert "Add asm.js-style setjmp/longjmp handling for wasm".
Revert "Add asm.js-style setjmp/longjmp handling for wasm"
Aug 31 2016, 5:53 PM
aheejin committed rL280302: Add asm.js-style setjmp/longjmp handling for wasm.
Add asm.js-style setjmp/longjmp handling for wasm
Aug 31 2016, 3:49 PM
aheejin closed D23928: Add asm.js-style setjmp/longjmp handling for wasm.
Aug 31 2016, 3:48 PM
aheejin updated the diff for D23928: Add asm.js-style setjmp/longjmp handling for wasm.

Delete a blank line

Aug 31 2016, 3:14 PM
aheejin added inline comments to D23928: Add asm.js-style setjmp/longjmp handling for wasm.
Aug 31 2016, 3:03 PM
aheejin updated the diff for D23928: Add asm.js-style setjmp/longjmp handling for wasm.

Address comments

Aug 31 2016, 3:03 PM
aheejin added inline comments to D23928: Add asm.js-style setjmp/longjmp handling for wasm.
Aug 31 2016, 6:58 AM
aheejin updated the diff for D23928: Add asm.js-style setjmp/longjmp handling for wasm.

Address comments & fix some typos

Aug 31 2016, 6:58 AM

Aug 28 2016

aheejin added inline comments to D23928: Add asm.js-style setjmp/longjmp handling for wasm.
Aug 28 2016, 11:07 AM
aheejin updated the diff for D23928: Add asm.js-style setjmp/longjmp handling for wasm.

Address comments

Aug 28 2016, 11:07 AM
aheejin updated the diff for D23928: Add asm.js-style setjmp/longjmp handling for wasm.
  • Add a test case for SjLj handling
  • Modify the type of THREW from i1 to i32 (sjlj requires it to be i32)
Aug 28 2016, 6:52 AM

Aug 26 2016

aheejin added a comment to D23928: Add asm.js-style setjmp/longjmp handling for wasm.

WIll add a test case soon.

Aug 26 2016, 9:06 AM
aheejin retitled D23928: Add asm.js-style setjmp/longjmp handling for wasm from to Add asm.js-style setjmp/longjmp handling for wasm.
Aug 26 2016, 9:05 AM

Aug 24 2016

aheejin committed rL279683: [WebAssembly] Change a comment line.
[WebAssembly] Change a comment line
Aug 24 2016, 4:01 PM
aheejin closed D23822: [WebAssembly] Change a comment line.
Aug 24 2016, 3:24 PM

Aug 23 2016

aheejin accepted D23822: [WebAssembly] Change a comment line.

Does it work?

Aug 23 2016, 5:36 PM
aheejin retitled D23822: [WebAssembly] Change a comment line from to [WebAssembly] Change a comment line.
Aug 23 2016, 5:35 PM

Aug 17 2016

aheejin added a comment to D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.
Aug 17 2016, 7:22 PM
aheejin added a comment to D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.
Aug 17 2016, 7:21 PM
aheejin updated the diff for D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.

address comments

Aug 17 2016, 7:20 PM
aheejin added inline comments to D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.
Aug 17 2016, 12:12 AM
aheejin updated the diff for D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.

Address comments

Aug 17 2016, 12:11 AM

Aug 16 2016

aheejin updated the diff for D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.

Member variable initialization

Aug 16 2016, 11:34 PM
aheejin updated the diff for D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.

Shorten Builder to IRB

Aug 16 2016, 10:51 PM
aheejin updated D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.
Aug 16 2016, 4:16 PM
aheejin added a dependent revision for D22958: Add asm.js-style exception handling support for wasm: D23588: Change code structure of WebAssemblyLowerEmscriptenException pass.
Aug 16 2016, 4:15 PM
aheejin retitled D23588: Change code structure of WebAssemblyLowerEmscriptenException pass from to Change code structure of WebAssemblyLowerEmscriptenException pass.
Aug 16 2016, 4:15 PM

Aug 9 2016

aheejin updated the diff for D23292: [WebAssembly] Add -emscripten-cxx-exceptions-whitelist option.

Address comments

Aug 9 2016, 1:59 PM

Aug 8 2016

aheejin retitled D23292: [WebAssembly] Add -emscripten-cxx-exceptions-whitelist option from to [WebAssembly] Add -emscripten-cxx-exceptions-whitelist option.
Aug 8 2016, 7:05 PM
aheejin added inline comments to D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.
Aug 8 2016, 5:41 PM
aheejin updated the diff for D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.

Address comments

Aug 8 2016, 3:54 PM
aheejin updated D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.
Aug 8 2016, 3:25 PM
aheejin updated the diff for D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.

Remove the test case for cxx-exceptions-whitelist option

Aug 8 2016, 3:07 PM
aheejin updated the diff for D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.

Removed the cxx-exceptions-whitelist option from this CL

Aug 8 2016, 3:07 PM
aheejin updated the diff for D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.

Add a test case for -emscripten-cxx-exceptions-whitelist option & Fix a bug

Aug 8 2016, 4:47 AM
aheejin updated D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.
Aug 8 2016, 3:54 AM
aheejin updated D23258: [WebAssembly] Fix bugs in WebAssemblyLowerEmscriptenExceptions pass.
Aug 8 2016, 3:54 AM