aheejin (Heejin Ahn)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2016, 12:33 AM (95 w, 2 d)

Recent Activity

Fri, May 25

aheejin updated the diff for D44134: [WebAssembly] Add WebAssemblyException information analysis.

Updated exception grouping algorithm: now it simply gather all the BBs
dominated by an EH pad, rather than stopping at catchret/cleanupret/unreachable.
CFGStackify seems to work either way, and this makes things simpler:

  1. We don't need to store frontier BBs ourselves and be able to just use existing MachineDominanceFrontier
  2. We can replace catchret/cleanupret earlier in ExceptionPrepare, so we need a single pass rather than two passes.
Fri, May 25, 4:44 AM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
  • Rebased onto D44090
  • Not this pass deletes the following unreachable instruction after adding a rethrow instruction.
Fri, May 25, 4:36 AM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.

Deleted ReplaceFuncletReturns pass and move the routine to ExceptionPrepare.

Fri, May 25, 4:33 AM

Wed, May 23

aheejin updated the diff for D44134: [WebAssembly] Add WebAssemblyException information analysis.
  • One more use of DeleteContainerPointers
Wed, May 23, 10:22 PM

Tue, May 22

aheejin committed rL333045: [WebAssembly] Add functions for EHScopes.
[WebAssembly] Add functions for EHScopes
Tue, May 22, 5:38 PM
aheejin closed D47005: [WebAssembly] Add functions for EHScopes.
Tue, May 22, 5:38 PM
aheejin updated the diff for D46500: [WebAssembly] CFG sort support for exception handling.
  • Use unique_ptr for containers and delete destructors
  • Make wasm.get.exception/ehselector intrinsic take a token argument
Tue, May 22, 4:25 PM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
  • Make wasm.get.exception/ehselector intrinsic take a token argument
Tue, May 22, 4:15 PM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.
  • Make wasm.get.exception/ehselector intrinsic take a token argument
Tue, May 22, 4:07 PM
aheejin added a comment to D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.

@majnemer Continuing the discussion from D44134:

Tue, May 22, 3:36 PM
aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Tue, May 22, 3:14 PM
aheejin updated the diff for D44134: [WebAssembly] Add WebAssemblyException information analysis.
  • Use DeleteContainerPointers
Tue, May 22, 3:13 PM
aheejin added a reviewer for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass: majnemer.
Tue, May 22, 2:28 PM

Mon, May 21

aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 21, 5:15 PM
aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 21, 2:04 PM
aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 21, 4:09 AM

Sun, May 20

aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Sun, May 20, 11:20 PM
aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Sun, May 20, 10:23 PM
aheejin added inline comments to D44134: [WebAssembly] Add WebAssemblyException information analysis.
Sun, May 20, 9:55 PM
aheejin added inline comments to D44931: [WebAssembly] Use Windows EH instructions for Wasm EH.
Sun, May 20, 6:36 PM

Sat, May 19

aheejin updated the diff for D46500: [WebAssembly] CFG sort support for exception handling.
  • clang-format
Sat, May 19, 9:54 PM
aheejin updated the diff for D44134: [WebAssembly] Add WebAssemblyException information analysis.
  • clang-format
Sat, May 19, 9:48 PM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.
  • clang-format
Sat, May 19, 9:30 PM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.
  • clang-format
Sat, May 19, 9:19 PM
aheejin added inline comments to D43746: [WebAssembly] Add Wasm exception handling prepare pass.
Sat, May 19, 9:14 PM
aheejin updated the diff for D43746: [WebAssembly] Add Wasm exception handling prepare pass.
  • Make wasm.get.exception/selector intrinsics take a token argument
Sat, May 19, 9:14 PM
aheejin updated the diff for D44931: [WebAssembly] Use Windows EH instructions for Wasm EH.

Test case fix was missing in the last commit

Sat, May 19, 9:13 PM
aheejin updated the diff for D44931: [WebAssembly] Use Windows EH instructions for Wasm EH.
  • Make wasm.get.exception/selector intrinsics take a token argument
Sat, May 19, 9:05 PM

Fri, May 18

aheejin updated the summary of D47005: [WebAssembly] Add functions for EHScopes.
Fri, May 18, 1:46 PM
aheejin updated the summary of D47005: [WebAssembly] Add functions for EHScopes.
Fri, May 18, 1:46 PM
aheejin updated the summary of D47005: [WebAssembly] Add functions for EHScopes.
Fri, May 18, 1:45 PM
aheejin retitled D47005: [WebAssembly] Add functions for EHScopes from [WebAssembly] Add MachineBasicBlock::isEHScopeEntry & setIsEHScopeEntry to [WebAssembly] Add functions for EHScopes.
Fri, May 18, 1:45 PM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.

comment fix

Fri, May 18, 1:43 PM
aheejin added inline comments to D47005: [WebAssembly] Add functions for EHScopes.
Fri, May 18, 5:04 AM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.
  • getScopeMembership -> getEHScopeMembership
Fri, May 18, 5:02 AM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.
  • collectScopeMembers -> collectEHScopeMembers
Fri, May 18, 5:00 AM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.
  • funclets -> scopes in comments / strings
Fri, May 18, 4:59 AM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.
  • Address comments
Fri, May 18, 4:59 AM
aheejin added inline comments to D43746: [WebAssembly] Add Wasm exception handling prepare pass.
Fri, May 18, 4:14 AM
aheejin updated the diff for D43746: [WebAssembly] Add Wasm exception handling prepare pass.
  • Address comments
Fri, May 18, 3:07 AM

Thu, May 17

aheejin updated the diff for D43746: [WebAssembly] Add Wasm exception handling prepare pass.
  • Move stuff out of doInitialization again
Thu, May 17, 3:45 PM
aheejin committed rL332667: [WebAssembly] Add Wasm personality and isScopedEHPersonality().
[WebAssembly] Add Wasm personality and isScopedEHPersonality()
Thu, May 17, 1:56 PM
aheejin closed D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().
Thu, May 17, 1:56 PM
aheejin added inline comments to D47005: [WebAssembly] Add functions for EHScopes.
Thu, May 17, 1:48 PM
aheejin added a comment to D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().

Thanks a a lot for all your help!

Thu, May 17, 1:35 PM
aheejin added inline comments to D44931: [WebAssembly] Use Windows EH instructions for Wasm EH.
Thu, May 17, 4:28 AM
aheejin added a comment to D44931: [WebAssembly] Use Windows EH instructions for Wasm EH.

Thank you for the reviews!

Thu, May 17, 4:16 AM
aheejin updated the diff for D44931: [WebAssembly] Use Windows EH instructions for Wasm EH.

CatchStartBlock -> WasmCatchStartBlock

Thu, May 17, 4:14 AM
aheejin retitled D47005: [WebAssembly] Add functions for EHScopes from [WebAssembly] Add isEHScopeEntry / setIsEHScopeEntry to [WebAssembly] Add MachineBasicBlock::isEHScopeEntry & setIsEHScopeEntry.
Thu, May 17, 2:01 AM
aheejin added a dependency for D44090: [WebAssembly] Support instruction selection for catching exceptions: D47005: [WebAssembly] Add functions for EHScopes.
Thu, May 17, 2:01 AM
aheejin added a dependent revision for D47005: [WebAssembly] Add functions for EHScopes: D44090: [WebAssembly] Support instruction selection for catching exceptions.
Thu, May 17, 2:01 AM
aheejin added a comment to D44090: [WebAssembly] Support instruction selection for catching exceptions.

I split MachineBasicBlock::isEHFuncletEntry and MachineBasicBlock::setIsEHFuncletEntry into two functions in D47005, as in the same vein with D45559, and rebased this CL onto it. PTAL.

Thu, May 17, 1:58 AM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.

fix sorry

Thu, May 17, 1:56 AM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.

rebased onto D47005

Thu, May 17, 1:55 AM
aheejin added a comment to D47005: [WebAssembly] Add functions for EHScopes.

I don't really know about SEH, but it looks like cleanup pads are treated as funclet entries in all personalities, whereas catchpads should not be treated as funclet entries in SEH, right? So I tried to preserve that semantics, but one thing I don't understand is why we have to set isEHFuncletEntry again in findUnwindDestinations again if we set them in visitCatchPad and visitCleanupPad. Anyway that's what the current code is doing and I tried to preserve the same behavior. I ran all existing tests including SEH ones and all of them passed (except XFAILs).

Thu, May 17, 1:41 AM
aheejin updated the diff for D47005: [WebAssembly] Add functions for EHScopes.

more

Thu, May 17, 1:36 AM
aheejin created D47005: [WebAssembly] Add functions for EHScopes.
Thu, May 17, 1:17 AM

Wed, May 16

aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.

Address comments

Wed, May 16, 11:45 PM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.

rebase

Wed, May 16, 10:25 PM
aheejin updated the diff for D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().

CXX_Wasm -> Wasm_CXX

Wed, May 16, 9:59 PM
aheejin updated the diff for D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().

More switch-case order change; NFC

Wed, May 16, 9:53 PM
aheejin updated the diff for D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().

changed switch-case order. NFC

Wed, May 16, 9:52 PM
aheejin retitled D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality() from [WebAssembly] Add Wasm personality and usesWindowsEHInstructions() to [WebAssembly] Add Wasm personality and isScopedEHPersonality().
Wed, May 16, 9:26 PM
aheejin added a comment to D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().

I renamed usesWindowsEHInstructions to isScopedEHPersonality as @majnemer suggested. But there are still a lot of uses of the term 'funclet' to denote scopes in other function names, local variable names, and comments. I guess we should update all of them together sometime, but that can be a different CL.

Wed, May 16, 9:23 PM
aheejin added inline comments to D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().
Wed, May 16, 9:21 PM
aheejin updated the diff for D45559: [WebAssembly] Add Wasm personality and isScopedEHPersonality().
  • usesWindowsEHInstructions -> isScopedEHPersonality
Wed, May 16, 9:21 PM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
  • debug location fix
Wed, May 16, 2:12 AM
aheejin committed rCTE332438: [clangd] Fix a link failure in unittests.
[clangd] Fix a link failure in unittests
Wed, May 16, 1:58 AM
aheejin committed rL332438: [clangd] Fix a link failure in unittests.
[clangd] Fix a link failure in unittests
Wed, May 16, 1:57 AM
aheejin closed D46906: [clangd] Fix a link failure in unittests.
Wed, May 16, 1:57 AM

Tue, May 15

aheejin updated the diff for D46500: [WebAssembly] CFG sort support for exception handling.

test fixes

Tue, May 15, 3:40 PM
aheejin updated the summary of D46906: [clangd] Fix a link failure in unittests.
Tue, May 15, 3:16 PM
aheejin created D46906: [clangd] Fix a link failure in unittests.
Tue, May 15, 3:16 PM
aheejin updated the diff for D44134: [WebAssembly] Add WebAssemblyException information analysis.
  • Group two terminate pads (catch and catch_all) together
Tue, May 15, 2:30 PM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
  • removed an unnecessary call from a test case
Tue, May 15, 2:01 PM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
  • Deleted successors of catch-all terminatepads
Tue, May 15, 1:28 PM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.

removed setIsEHFuncletEntry

Tue, May 15, 8:46 AM

Mon, May 14

aheejin accepted D46859: Fix debug build by adding missing dependencies on libBinaryFormat.
Mon, May 14, 5:49 PM
aheejin removed a dependent revision for D43746: [WebAssembly] Add Wasm exception handling prepare pass: D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 14, 3:41 AM
aheejin edited dependencies for D44134: [WebAssembly] Add WebAssemblyException information analysis, added: 1; removed: 1.
Mon, May 14, 3:41 AM
aheejin added a dependent revision for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass: D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 14, 3:41 AM
aheejin added a dependent revision for D43746: [WebAssembly] Add Wasm exception handling prepare pass: D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 14, 3:41 AM
aheejin removed a dependent revision for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass: D46500: [WebAssembly] CFG sort support for exception handling.
Mon, May 14, 3:41 AM
aheejin removed a dependency for D46500: [WebAssembly] CFG sort support for exception handling: D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
Mon, May 14, 3:41 AM
aheejin removed a dependent revision for D44090: [WebAssembly] Support instruction selection for catching exceptions: D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 14, 3:41 AM
aheejin removed a dependent revision for D45948: [MIRParser] Allow register class names in the form of integer/scalar: D44134: [WebAssembly] Add WebAssemblyException information analysis.
Mon, May 14, 3:41 AM
aheejin edited dependencies for D44134: [WebAssembly] Add WebAssemblyException information analysis, added: 1; removed: 2.
Mon, May 14, 3:41 AM
aheejin added a dependent revision for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass: D46500: [WebAssembly] CFG sort support for exception handling.
Mon, May 14, 3:29 AM
aheejin added a dependency for D46500: [WebAssembly] CFG sort support for exception handling: D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
Mon, May 14, 3:29 AM
aheejin added a dependent revision for D44090: [WebAssembly] Support instruction selection for catching exceptions: D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
Mon, May 14, 3:28 AM
aheejin removed a dependent revision for D46500: [WebAssembly] CFG sort support for exception handling: D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
Mon, May 14, 3:28 AM
aheejin edited dependencies for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass, added: 1; removed: 1.
Mon, May 14, 3:28 AM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.

rebase

Mon, May 14, 3:28 AM

Sun, May 13

aheejin added a dependency for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass: D46500: [WebAssembly] CFG sort support for exception handling.
Sun, May 13, 4:39 AM
aheejin added a dependent revision for D46500: [WebAssembly] CFG sort support for exception handling: D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
Sun, May 13, 4:39 AM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.

Removed a blank line

Sun, May 13, 4:37 AM
aheejin updated the diff for D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.

fixes

Sun, May 13, 4:36 AM
aheejin created D46803: [WebAssembly] Add WebAssemblyExceptionPrepare pass.
Sun, May 13, 4:03 AM

Sat, May 12

aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.
  • Early exit if a function does not have a personality function
Sat, May 12, 1:38 AM
aheejin updated the diff for D44090: [WebAssembly] Support instruction selection for catching exceptions.
  • tweak test case
Sat, May 12, 1:08 AM