Page MenuHomePhabricator
People ormris

ormris (Matthew Voss)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 10:06 AM (259 w, 2 d)

Recent Activity
View All

Yesterday

ormris committed rGc4960f6363c4: [llvm-reduce] Change initialization order to fix bots. NFC (authored by ormris).
[llvm-reduce] Change initialization order to fix bots. NFC
Thu, Jun 30, 9:58 AM · Restricted Project, Restricted Project
ormris added a comment to D127168: [llvm-reduce] Add support for LTO bitcode files.

Sounds good. Thanks for the review.

Thu, Jun 30, 9:00 AM · Restricted Project, Restricted Project
ormris committed rG6b3956e123db: [llvm-reduce] Add support for LTO bitcode files (authored by ormris).
[llvm-reduce] Add support for LTO bitcode files
Thu, Jun 30, 8:58 AM · Restricted Project, Restricted Project
ormris closed D127168: [llvm-reduce] Add support for LTO bitcode files.
Thu, Jun 30, 8:58 AM · Restricted Project, Restricted Project

Wed, Jun 29

ormris added a comment to D127168: [llvm-reduce] Add support for LTO bitcode files.

ping ping

Wed, Jun 29, 3:59 PM · Restricted Project, Restricted Project

Wed, Jun 22

ormris added a comment to D127168: [llvm-reduce] Add support for LTO bitcode files.

ping

Wed, Jun 22, 11:37 AM · Restricted Project, Restricted Project

Wed, Jun 15

ormris updated the diff for D127168: [llvm-reduce] Add support for LTO bitcode files.
  • Add toolname to errors
  • Remove unnecessary changes
Wed, Jun 15, 10:57 AM · Restricted Project, Restricted Project
ormris added inline comments to D127168: [llvm-reduce] Add support for LTO bitcode files.
Wed, Jun 15, 10:56 AM · Restricted Project, Restricted Project

Mon, Jun 6

ormris updated the diff for D127168: [llvm-reduce] Add support for LTO bitcode files.

Add context

Mon, Jun 6, 5:22 PM · Restricted Project, Restricted Project
ormris requested review of D127168: [llvm-reduce] Add support for LTO bitcode files.
Mon, Jun 6, 5:19 PM · Restricted Project, Restricted Project

May 16 2022

Herald added a project to D105131: Change the phase ordering of SROA in the LTO to enable more cse opportunities: Restricted Project.
May 16 2022, 11:26 AM · Restricted Project, Restricted Project
Herald added a project to D119879: [DSE] Model reads after returning explicitly in MemSSA.: Restricted Project.
May 16 2022, 11:23 AM · Restricted Project, Restricted Project
Herald added a project to D120586: [Attributor] Add AAAddressSpaceInfo to deduce address spaces: Restricted Project.
May 16 2022, 11:22 AM · Restricted Project, Restricted Project

Apr 25 2022

ormris updated the diff for D123971: [clang] Enable SplitLTOUnits by default for SIE targets.

Add context.

Apr 25 2022, 9:38 AM · Restricted Project, Restricted Project

Apr 19 2022

ormris added a comment to D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.

I think this will introduce a correctness issue as it will become possible for two modules that can be linked together to have the same unique module ID.

Apr 19 2022, 4:25 PM · Restricted Project, Restricted Project
ormris added a reviewer for D123971: [clang] Enable SplitLTOUnits by default for SIE targets: probinson.
Apr 19 2022, 4:19 PM · Restricted Project, Restricted Project
ormris planned changes to D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.

This patch causes several test failures. Currently working on resolving those.

Apr 19 2022, 1:31 PM · Restricted Project, Restricted Project
ormris added a reviewer for D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID: Xiangling_L.
Apr 19 2022, 11:58 AM · Restricted Project, Restricted Project
ormris updated the diff for D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.

Update patch with fixes for some PowerPC tests.

Apr 19 2022, 11:56 AM · Restricted Project, Restricted Project

Apr 18 2022

ormris requested review of D123971: [clang] Enable SplitLTOUnits by default for SIE targets.
Apr 18 2022, 5:45 PM · Restricted Project, Restricted Project
ormris requested review of D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.
Apr 18 2022, 5:39 PM · Restricted Project, Restricted Project
ormris abandoned D123805: [WIP][lld] A Unified LTO Bitcode Frontend.

The changes in this patch have been moved to here: https://reviews.llvm.org/D123804

Apr 18 2022, 5:26 PM · Restricted Project, lld
ormris updated the diff for D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.

Add LLD driver changes to this patch. Disable split LTO units by default. As discussed here: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774/15

Apr 18 2022, 5:25 PM · Restricted Project, Restricted Project
ormris updated the diff for D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.

Remove ModuleID changes, as discussed here: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774/15

Apr 18 2022, 5:20 PM · Restricted Project, Restricted Project
ormris added inline comments to D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 18 2022, 1:38 PM · Restricted Project, Restricted Project

Apr 14 2022

ormris updated the summary of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:18 AM · Restricted Project, lld
ormris updated the summary of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:18 AM · Restricted Project, Restricted Project
ormris updated the summary of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:18 AM · Restricted Project, Restricted Project
ormris updated the summary of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:17 AM · Restricted Project, lld
ormris updated the summary of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:17 AM · Restricted Project, Restricted Project
ormris updated the summary of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:16 AM · Restricted Project, Restricted Project
ormris updated the summary of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:48 AM · Restricted Project, lld
ormris updated the summary of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:48 AM · Restricted Project, Restricted Project
ormris updated the summary of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:48 AM · Restricted Project, Restricted Project
ormris requested review of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:43 AM · Restricted Project, lld
ormris requested review of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:41 AM · Restricted Project, Restricted Project
ormris requested review of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:39 AM · Restricted Project, Restricted Project

Feb 17 2022

ormris added a comment to D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments.

Hi Shangwu,

Feb 17 2022, 2:35 PM · Restricted Project
ormris added a reverting change for rG9de4fc0f2d3b: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments: rG9ce09099bba4: Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments".
Feb 17 2022, 2:32 PM
ormris committed rG9ce09099bba4: Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments" (authored by ormris).
Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments"
Feb 17 2022, 2:32 PM
ormris added a reverting change for D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments: rG9ce09099bba4: Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments".
Feb 17 2022, 2:32 PM · Restricted Project

Sep 16 2021

ormris committed rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c (authored by ormris).
[test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c
Sep 16 2021, 9:21 AM
ormris added a comment to D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

Thanks for the review!

Sep 16 2021, 9:20 AM · Restricted Project
ormris closed D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.
Sep 16 2021, 9:20 AM · Restricted Project

Sep 15 2021

ormris added a comment to D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

I think the test fix is all that's needed for now. This is somewhat urgent for us.

Sep 15 2021, 4:57 PM · Restricted Project
ormris updated the diff for D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.
  • Downgrade to C11 and C++11
Sep 15 2021, 4:54 PM · Restricted Project
ormris added a comment to D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

We saw this failure on our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow.

Sep 15 2021, 3:39 PM · Restricted Project
ormris requested review of D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.
Sep 15 2021, 2:54 PM · Restricted Project

Jun 3 2021

Herald added a project to D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set: Restricted Project.
Jun 3 2021, 2:15 PM · Restricted Project, Restricted Project

May 28 2021

ormris added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

This is also failing on several buildbots: https://lab.llvm.org/buildbot/#/builders/139/builds/4812

May 28 2021, 11:54 AM · Restricted Project

May 6 2021

ormris committed rG22aece57beb6: Allow llvm-dis to disassemble multiple files (authored by ormris).
Allow llvm-dis to disassemble multiple files
May 6 2021, 11:09 AM
ormris closed D101110: Allow llvm-dis to disassemble multiple files.
May 6 2021, 11:09 AM · Restricted Project

May 5 2021

ormris added a comment to D101110: Allow llvm-dis to disassemble multiple files.

Thanks for the review!

May 5 2021, 2:54 PM · Restricted Project
ormris updated the diff for D101110: Allow llvm-dis to disassemble multiple files.

Changelog:

  • Fix error condition
  • Remove unneeded test cases
  • Add error prefix
May 5 2021, 10:53 AM · Restricted Project

Apr 29 2021

ormris added a comment to D101110: Allow llvm-dis to disassemble multiple files.

ping

Apr 29 2021, 11:45 AM · Restricted Project

Apr 23 2021

ormris updated the diff for D101110: Allow llvm-dis to disassemble multiple files.
  • Add test
    • Fix output mode
Apr 23 2021, 1:11 PM · Restricted Project

Apr 22 2021

ormris added inline comments to D101110: Allow llvm-dis to disassemble multiple files.
Apr 22 2021, 4:41 PM · Restricted Project
ormris added a comment to D101110: Allow llvm-dis to disassemble multiple files.

Sure, I can add one. What would OutputFilename mean in this context? A prefix for all output files?

Apr 22 2021, 4:41 PM · Restricted Project
ormris requested review of D101110: Allow llvm-dis to disassemble multiple files.
Apr 22 2021, 2:13 PM · Restricted Project

Apr 13 2021

ormris added a comment to D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO.

@hoyFB wrote:

@ormris I'd like to follow up on this. We had a similar change internally which led up to some gains when combined with SPGO, and we'd like to help move forward with this patch here. Would you mind sharing the plan or progress on your side? Thanks!

Sorry for the late reply. Unfortunately, we weren't able to get very far beyond the experiments you see here. Feel free to take it from here.

Apr 13 2021, 5:00 PM · Restricted Project, Restricted Project

Mar 23 2021

ormris accepted D98873: Document -fcrash-diagnostics-dir.

LGTM

Mar 23 2021, 10:03 AM · Restricted Project

Feb 23 2021

ormris committed rG1d7f1d15c517: [LTO] Fix test failures caused by 6da7d3141651 (authored by ormris).
[LTO] Fix test failures caused by 6da7d3141651
Feb 23 2021, 2:59 PM
ormris committed rG6da7d3141651: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm… (authored by ormris).
[llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm…
Feb 23 2021, 12:53 PM
ormris closed D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.
Feb 23 2021, 12:53 PM · Restricted Project

Feb 19 2021

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

Thanks for the review @xur and @davidxl

Feb 19 2021, 7:00 PM · Restricted Project
ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

ping

Feb 19 2021, 9:58 AM · Restricted Project

Feb 18 2021

ormris updated the diff for D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.
  • Change initial value to -1 to avoid false warnings.
Feb 18 2021, 4:11 PM · Restricted Project

Feb 4 2021

ormris added a reviewer for D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata: davidxl.
Feb 4 2021, 1:28 PM · Restricted Project
ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

ping

Feb 4 2021, 12:36 PM · Restricted Project

Jan 27 2021

ormris updated the diff for D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.
  • Update in-pass check to detect all duplicates
  • Remove duplicate from MemOp pass test case
  • Change warning to "Invalid profile"
Jan 27 2021, 4:56 PM · Restricted Project

Jan 26 2021

ormris updated the diff for D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.
  • Add in-pass profile data check
  • Change error to warning in llvm-profdata
  • Update tests
Jan 26 2021, 11:21 AM · Restricted Project

Jan 15 2021

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

OK. That makes sense. I'll go ahead and update the patch.

Jan 15 2021, 3:18 PM · Restricted Project

Jan 14 2021

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

ping

Jan 14 2021, 10:14 AM · Restricted Project

Jan 8 2021

ormris committed rG0386f3d4f418: [NFC] Specify C11 in loop-opt-setup.c (authored by ormris).
[NFC] Specify C11 in loop-opt-setup.c
Jan 8 2021, 12:19 PM
ormris closed D94327: [NFC] Specify C11 in loop-opt-setup.c.
Jan 8 2021, 12:19 PM · Restricted Project
ormris added a comment to D94327: [NFC] Specify C11 in loop-opt-setup.c.

Thanks!

Jan 8 2021, 12:13 PM · Restricted Project
ormris requested review of D94327: [NFC] Specify C11 in loop-opt-setup.c.
Jan 8 2021, 11:24 AM · Restricted Project

Jan 7 2021

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

ping ping ping

Jan 7 2021, 3:49 PM · Restricted Project

Dec 17 2020

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

ping ping

Dec 17 2020, 9:13 AM · Restricted Project

Dec 11 2020

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

ping

Dec 11 2020, 10:32 AM · Restricted Project

Dec 2 2020

ormris added a comment to D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.

I would rather to fix this in the memop size transformation -- to detect this in the heuristic.

Dec 2 2020, 4:24 PM · Restricted Project

Nov 30 2020

ormris added a reviewer for D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata: xur.
Nov 30 2020, 12:36 PM · Restricted Project

Nov 24 2020

ormris requested review of D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata.
Nov 24 2020, 11:23 PM · Restricted Project

Aug 19 2020

ormris accepted D86240: [llvm] Add default constructor of `llvm::ElementCount`..

LGTM

Aug 19 2020, 2:14 PM · Restricted Project
ormris added a comment to D86240: [llvm] Add default constructor of `llvm::ElementCount`..

This builds on Windows. Do the comments need to be updated?

Aug 19 2020, 1:29 PM · Restricted Project

May 25 2020

ormris added a comment to D79961: [PGO] Fix computation of fuction Hash.

There's a few test failures related to this change on the PS4 bot. Could you take a look?

May 25 2020, 10:42 AM · Restricted Project, Restricted Project

Jan 14 2020

ormris added a comment to D72405: Allow /D flags absent during PCH creation under msvc-compat.

Hi Zach,

Jan 14 2020, 6:29 PM · Restricted Project

Dec 13 2019

ormris added a comment to D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO.

Ping @tejohnson

Dec 13 2019, 2:32 PM · Restricted Project, Restricted Project

Dec 5 2019

ormris added a comment to D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO.

I've done testing with the following global parameters.

Dec 5 2019, 4:42 PM · Restricted Project, Restricted Project

Nov 14 2019

ormris committed rGe69a7364f233: [llvm-dis] Fix the disable-output flag (authored by ormris).
[llvm-dis] Fix the disable-output flag
Nov 14 2019, 1:38 PM
ormris committed rG141bb5f308fa: Add support for multi-module bitcode files to llvm-dis (authored by ormris).
Add support for multi-module bitcode files to llvm-dis
Nov 14 2019, 10:43 AM
ormris closed D70153: Add support for multi-module bitcode files to llvm-dis.
Nov 14 2019, 10:43 AM · Restricted Project
ormris added inline comments to D70153: Add support for multi-module bitcode files to llvm-dis.
Nov 14 2019, 10:34 AM · Restricted Project
ormris added a comment to D70153: Add support for multi-module bitcode files to llvm-dis.

Thanks for the review! I'll go ahead and commit this.

Nov 14 2019, 10:15 AM · Restricted Project

Nov 12 2019

ormris created D70153: Add support for multi-module bitcode files to llvm-dis.
Nov 12 2019, 5:40 PM · Restricted Project

Sep 23 2019

ormris committed rL372659: Request commit access for ormris.
Request commit access for ormris
Sep 23 2019, 1:50 PM

Sep 6 2019

ormris committed rGc1779194097f: Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm (authored by ormris).
Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm
Sep 6 2019, 3:52 PM
ormris committed rL371267: Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm.
Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm
Sep 6 2019, 3:52 PM

Aug 21 2019

ormris added a comment to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 21 2019, 1:14 PM · Restricted Project

Jul 19 2019

ormris committed rG407e8375402f: Revert "Fix asan infinite loop on undefined symbol" (authored by ormris).
Revert "Fix asan infinite loop on undefined symbol"
Jul 19 2019, 2:44 PM