Page MenuHomePhabricator
People ormris

ormris (Matthew Voss)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 10:06 AM (297 w, 3 d)

Recent Activity
View All

Fri, Mar 17

ormris added a reverting change for rG03aa02adb03c: [fuzzer] Use puts() rather than printf() in CopyFileToErr(): rGd02ff3d57831: Revert "[fuzzer] Use puts() rather than printf() in CopyFileToErr()".
Fri, Mar 17, 4:02 PM · Restricted Project, Restricted Project
ormris committed rGd02ff3d57831: Revert "[fuzzer] Use puts() rather than printf() in CopyFileToErr()" (authored by ormris).
Revert "[fuzzer] Use puts() rather than printf() in CopyFileToErr()"
Fri, Mar 17, 4:01 PM · Restricted Project, Restricted Project
ormris added a reverting change for D146189: [fuzzer] Use puts() rather than printf() in CopyFileToErr(): rGd02ff3d57831: Revert "[fuzzer] Use puts() rather than printf() in CopyFileToErr()".
Fri, Mar 17, 4:01 PM · Restricted Project, Restricted Project

Fri, Mar 10

ormris added a comment to D145827: [cmake] Quote args when generating /libpath option specifying runtime dir for link/lld-link.

Thanks!

Fri, Mar 10, 2:13 PM · Restricted Project, Restricted Project
ormris committed rG26fa96542d94: [cmake] Quote args when generating /libpath option specifying runtime dir for… (authored by ormris).
[cmake] Quote args when generating /libpath option specifying runtime dir for…
Fri, Mar 10, 2:13 PM · Restricted Project, Restricted Project
ormris closed D145827: [cmake] Quote args when generating /libpath option specifying runtime dir for link/lld-link.
Fri, Mar 10, 2:13 PM · Restricted Project, Restricted Project
ormris requested review of D145827: [cmake] Quote args when generating /libpath option specifying runtime dir for link/lld-link.
Fri, Mar 10, 1:34 PM · Restricted Project, Restricted Project

Mon, Feb 27

ormris committed rG4364e2429cd4: [NFC][PGO] Prefix duplicate profile MemOp entry diagnostic with 'warning:' (authored by ormris).
[NFC][PGO] Prefix duplicate profile MemOp entry diagnostic with 'warning:'
Mon, Feb 27, 2:08 PM · Restricted Project, Restricted Project

Dec 6 2022

ormris added a comment to D139283: [llvm-exegesis] parallel snippet generator: avoid Read-After-Write pitfail for instrs w/ tied variables.

Thanks! LG

Dec 6 2022, 12:39 PM · Restricted Project, Restricted Project
ormris added a comment to D139283: [llvm-exegesis] parallel snippet generator: avoid Read-After-Write pitfail for instrs w/ tied variables.

This doesn't compile on GCC 7.5.0 (it's older but supported). See this buildbot: https://lab.llvm.org/staging/#/builders/235/builds/731

Dec 6 2022, 11:29 AM · Restricted Project, Restricted Project

Nov 4 2022

ormris committed rGa4b543a5a541: [llvm-profdata] Check for all duplicate entries in MemOpSize table (authored by ormris).
[llvm-profdata] Check for all duplicate entries in MemOpSize table
Nov 4 2022, 5:19 PM · Restricted Project, Restricted Project
ormris closed D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.
Nov 4 2022, 5:19 PM · Restricted Project, Restricted Project
ormris added a comment to D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.

Thanks! I'll commit this.

Nov 4 2022, 5:03 PM · Restricted Project, Restricted Project
ormris added a comment to D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.

Ping

Nov 4 2022, 9:30 AM · Restricted Project, Restricted Project

Oct 28 2022

ormris added inline comments to D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.
Oct 28 2022, 11:59 AM · Restricted Project, Restricted Project
ormris updated the diff for D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.
  • Correct existence check
  • Change debug note to an error
  • Update tests to look for error
Oct 28 2022, 11:58 AM · Restricted Project, Restricted Project

Oct 27 2022

ormris added inline comments to D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.
Oct 27 2022, 10:39 AM · Restricted Project, Restricted Project

Oct 25 2022

ormris updated the diff for D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.

Changelist:

  • Roll insertion and existence check into one line.
Oct 25 2022, 3:07 PM · Restricted Project, Restricted Project
ormris added inline comments to D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.
Oct 25 2022, 2:47 PM · Restricted Project, Restricted Project
ormris added a comment to D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.

ping

Oct 25 2022, 12:21 PM · Restricted Project, Restricted Project

Oct 18 2022

ormris requested review of D136211: [llvm-profdata] Check for all duplicate entries in MemOpSize table.
Oct 18 2022, 4:40 PM · Restricted Project, Restricted Project

Oct 17 2022

ormris added a comment to D127403: [clangd] Implement semantic token modifier "definition".

Looks like there are some test failures associated with this commit: https://lab.llvm.org/buildbot/#/builders/123/builds/13698

Oct 17 2022, 3:43 PM · Restricted Project, Restricted Project

Oct 7 2022

ormris committed rGfe50eac85c06: [llvm-reduce] Fix di-metadata pass test failures (authored by ormris).
[llvm-reduce] Fix di-metadata pass test failures
Oct 7 2022, 12:05 PM · Restricted Project, Restricted Project
ormris closed D135473: [llvm-reduce] Fix di-metadata pass test failures.
Oct 7 2022, 12:05 PM · Restricted Project, Restricted Project
ormris added a comment to D135473: [llvm-reduce] Fix di-metadata pass test failures.

Thanks for the review @aeubanks!

Oct 7 2022, 11:57 AM · Restricted Project, Restricted Project
ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

It's pretty trivial, but I also wanted to address @MatzeB's post commit feedback. https://reviews.llvm.org/D135473

Oct 7 2022, 11:27 AM · Restricted Project, Restricted Project
ormris requested review of D135473: [llvm-reduce] Fix di-metadata pass test failures.
Oct 7 2022, 11:26 AM · Restricted Project, Restricted Project
ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

We're seeing a test fail intermittently as well. See below. I have a fix and am about to post a review for it.

Oct 7 2022, 11:00 AM · Restricted Project, Restricted Project

Oct 6 2022

ormris committed rG2c799b7793cc: [llvm-reduce] Add pass that reduces DebugInfo metadata (authored by ormris).
[llvm-reduce] Add pass that reduces DebugInfo metadata
Oct 6 2022, 2:25 PM · Restricted Project, Restricted Project
ormris closed D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Oct 6 2022, 2:25 PM · Restricted Project, Restricted Project
ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Thanks for the review, @aeubanks and @arsenm! I'll committing this shortly.

Oct 6 2022, 2:06 PM · Restricted Project, Restricted Project
ormris added inline comments to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Oct 6 2022, 1:36 PM · Restricted Project, Restricted Project
ormris added inline comments to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Oct 6 2022, 1:35 PM · Restricted Project, Restricted Project
ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Fix header comment and check for visited nodes.

Oct 6 2022, 1:34 PM · Restricted Project, Restricted Project
ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Agreed. I just tested it using your test case and it crashed.

Oct 6 2022, 1:09 PM · Restricted Project, Restricted Project

Oct 5 2022

ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Oct 5 2022, 4:22 PM · Restricted Project, Restricted Project
ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Oct 5 2022, 3:45 PM · Restricted Project, Restricted Project
ormris added inline comments to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Oct 5 2022, 3:44 PM · Restricted Project, Restricted Project
ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Add --abort-on-invalid-reduction to test

Oct 5 2022, 9:13 AM · Restricted Project, Restricted Project

Oct 4 2022

ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Thanks for the example and suggestion, that was really helpful. I've changed the pass to use that strategy. I don't get any verification errors when using my internal test case or the test case you provided, and the code is overall cleaner, I think.

Oct 4 2022, 2:50 PM · Restricted Project, Restricted Project

Sep 23 2022

ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Updating this patch to address verifier issues. From my reading of the verifier, and some internal tests, it looks like removing all elements of the tuple is valid for tuples attached to nodes like DISubprogram and DICompositeType. This also allows the pass to reduce those node types more fully. DICompileUnit nodes are now added to the queue. I've also updated fhahn's test to reflect the changes.

Sep 23 2022, 5:31 PM · Restricted Project, Restricted Project
ormris added inline comments to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Sep 23 2022, 4:06 PM · Restricted Project, Restricted Project

Sep 20 2022

ormris committed rG45c7da241f12: [PS4] Always enable the .debug_aranges section when using LTO (authored by ormris).
[PS4] Always enable the .debug_aranges section when using LTO
Sep 20 2022, 2:47 PM · Restricted Project, Restricted Project
ormris closed D134296: [SIE] Always enable the .debug_aranges section when using LTO.
Sep 20 2022, 2:47 PM · Restricted Project, Restricted Project
ormris added inline comments to D134296: [SIE] Always enable the .debug_aranges section when using LTO.
Sep 20 2022, 2:43 PM · Restricted Project, Restricted Project
ormris requested review of D134296: [SIE] Always enable the .debug_aranges section when using LTO.
Sep 20 2022, 11:23 AM · Restricted Project, Restricted Project

Sep 19 2022

ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Everything should be addressed. Sorry for the delay. Things have been busy over here.

Sep 19 2022, 2:40 PM · Restricted Project, Restricted Project
ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Changelog:

  • clang-format
  • Rename "dimetadata" to "di-metadata"
  • Code and data structure clean-up
  • Add "--abort-on-invalid-reduction" to test
  • Fix header comments
Sep 19 2022, 2:34 PM · Restricted Project, Restricted Project

Sep 1 2022

ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

ping ping

Sep 1 2022, 10:02 AM · Restricted Project, Restricted Project

Aug 25 2022

ormris added a comment to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Gentle ping

Aug 25 2022, 12:14 PM · Restricted Project, Restricted Project

Aug 19 2022

ormris updated the diff for D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.

Change pass pipeline slightly to improve performance.

Aug 19 2022, 11:05 AM · Restricted Project, Restricted Project

Aug 18 2022

ormris added inline comments to D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Aug 18 2022, 5:59 PM · Restricted Project, Restricted Project

Aug 17 2022

ormris requested review of D132077: [llvm-reduce] Add pass that reduces DebugInfo metadata.
Aug 17 2022, 3:15 PM · Restricted Project, Restricted Project

Jun 30 2022

ormris committed rGc4960f6363c4: [llvm-reduce] Change initialization order to fix bots. NFC (authored by ormris).
[llvm-reduce] Change initialization order to fix bots. NFC
Jun 30 2022, 9:58 AM · Restricted Project, Restricted Project
ormris added a comment to D127168: [llvm-reduce] Add support for LTO bitcode files.

Sounds good. Thanks for the review.

Jun 30 2022, 9:00 AM · Restricted Project, Restricted Project
ormris committed rG6b3956e123db: [llvm-reduce] Add support for LTO bitcode files (authored by ormris).
[llvm-reduce] Add support for LTO bitcode files
Jun 30 2022, 8:58 AM · Restricted Project, Restricted Project
ormris closed D127168: [llvm-reduce] Add support for LTO bitcode files.
Jun 30 2022, 8:58 AM · Restricted Project, Restricted Project

Jun 29 2022

ormris added a comment to D127168: [llvm-reduce] Add support for LTO bitcode files.

ping ping

Jun 29 2022, 3:59 PM · Restricted Project, Restricted Project

Jun 22 2022

ormris added a comment to D127168: [llvm-reduce] Add support for LTO bitcode files.

ping

Jun 22 2022, 11:37 AM · Restricted Project, Restricted Project

Jun 15 2022

ormris updated the diff for D127168: [llvm-reduce] Add support for LTO bitcode files.
  • Add toolname to errors
  • Remove unnecessary changes
Jun 15 2022, 10:57 AM · Restricted Project, Restricted Project
ormris added inline comments to D127168: [llvm-reduce] Add support for LTO bitcode files.
Jun 15 2022, 10:56 AM · Restricted Project, Restricted Project

Jun 6 2022

ormris updated the diff for D127168: [llvm-reduce] Add support for LTO bitcode files.

Add context

Jun 6 2022, 5:22 PM · Restricted Project, Restricted Project
ormris requested review of D127168: [llvm-reduce] Add support for LTO bitcode files.
Jun 6 2022, 5:19 PM · Restricted Project, Restricted Project

May 16 2022

Herald added a project to D105131: Change the phase ordering of SROA in the LTO to enable more cse opportunities: Restricted Project.
May 16 2022, 11:26 AM · Restricted Project, Restricted Project
Herald added a project to D119879: [DSE] Model reads after returning explicitly in MemSSA.: Restricted Project.
May 16 2022, 11:23 AM · Restricted Project, Restricted Project
Herald added a project to D120586: [Attributor] Add AAAddressSpaceInfo to deduce address spaces: Restricted Project.
May 16 2022, 11:22 AM · Restricted Project, Restricted Project

Apr 25 2022

ormris updated the diff for D123971: [clang] Enable SplitLTOUnits by default for SIE targets.

Add context.

Apr 25 2022, 9:38 AM · Restricted Project, Restricted Project

Apr 19 2022

ormris added a comment to D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.

I think this will introduce a correctness issue as it will become possible for two modules that can be linked together to have the same unique module ID.

Apr 19 2022, 4:25 PM · Restricted Project, Restricted Project
ormris added a reviewer for D123971: [clang] Enable SplitLTOUnits by default for SIE targets: probinson.
Apr 19 2022, 4:19 PM · Restricted Project, Restricted Project
ormris planned changes to D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.

This patch causes several test failures. Currently working on resolving those.

Apr 19 2022, 1:31 PM · Restricted Project, Restricted Project
ormris added a reviewer for D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID: Xiangling_L.
Apr 19 2022, 11:58 AM · Restricted Project, Restricted Project
ormris updated the diff for D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.

Update patch with fixes for some PowerPC tests.

Apr 19 2022, 11:56 AM · Restricted Project, Restricted Project

Apr 18 2022

ormris requested review of D123971: [clang] Enable SplitLTOUnits by default for SIE targets.
Apr 18 2022, 5:45 PM · Restricted Project, Restricted Project
ormris requested review of D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID.
Apr 18 2022, 5:39 PM · Restricted Project, Restricted Project
ormris abandoned D123805: [WIP][lld] A Unified LTO Bitcode Frontend.

The changes in this patch have been moved to here: https://reviews.llvm.org/D123804

Apr 18 2022, 5:26 PM · lld, Restricted Project
ormris updated the diff for D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.

Add LLD driver changes to this patch. Disable split LTO units by default. As discussed here: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774/15

Apr 18 2022, 5:25 PM · Restricted Project, Restricted Project
ormris updated the diff for D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.

Remove ModuleID changes, as discussed here: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774/15

Apr 18 2022, 5:20 PM · Restricted Project, Restricted Project
ormris added inline comments to D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 18 2022, 1:38 PM · Restricted Project, Restricted Project

Apr 14 2022

ormris updated the summary of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:18 AM · lld, Restricted Project
ormris updated the summary of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:18 AM · Restricted Project, Restricted Project
ormris updated the summary of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:18 AM · Restricted Project, Restricted Project
ormris updated the summary of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:17 AM · lld, Restricted Project
ormris updated the summary of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:17 AM · Restricted Project, Restricted Project
ormris updated the summary of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 10:16 AM · Restricted Project, Restricted Project
ormris updated the summary of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:48 AM · lld, Restricted Project
ormris updated the summary of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:48 AM · Restricted Project, Restricted Project
ormris updated the summary of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:48 AM · Restricted Project, Restricted Project
ormris requested review of D123805: [WIP][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:43 AM · lld, Restricted Project
ormris requested review of D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:41 AM · Restricted Project, Restricted Project
ormris requested review of D123803: [WIP][llvm] A Unified LTO Bitcode Frontend.
Apr 14 2022, 9:39 AM · Restricted Project, Restricted Project

Feb 17 2022

ormris added a comment to D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments.

Hi Shangwu,

Feb 17 2022, 2:35 PM · Restricted Project
ormris added a reverting change for rG9de4fc0f2d3b: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments: rG9ce09099bba4: Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments".
Feb 17 2022, 2:32 PM
ormris committed rG9ce09099bba4: Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments" (authored by ormris).
Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments"
Feb 17 2022, 2:32 PM
ormris added a reverting change for D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments: rG9ce09099bba4: Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments".
Feb 17 2022, 2:32 PM · Restricted Project

Sep 16 2021

ormris committed rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c (authored by ormris).
[test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c
Sep 16 2021, 9:21 AM
ormris added a comment to D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

Thanks for the review!

Sep 16 2021, 9:20 AM · Restricted Project
ormris closed D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.
Sep 16 2021, 9:20 AM · Restricted Project

Sep 15 2021

ormris added a comment to D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

I think the test fix is all that's needed for now. This is somewhat urgent for us.

Sep 15 2021, 4:57 PM · Restricted Project
ormris updated the diff for D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.
  • Downgrade to C11 and C++11
Sep 15 2021, 4:54 PM · Restricted Project
ormris added a comment to D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

We saw this failure on our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow.

Sep 15 2021, 3:39 PM · Restricted Project