- User Since
- Jan 2 2013, 4:34 PM (349 w, 6 d)
From what I understand, the comdat group isn't necessary, so I disabled it on COFF in r372182. Can we simplify ELF to match?
- simplify merging check
@hans has been trying to build clang with PGO on Windows, so I'll defer this to him.
Hm, this broke check-asan on Windows, which exercises some code coverage features:
Mon, Sep 16
- move test
Taking this to move the test around and try the other version...
Fri, Sep 13
Thu, Sep 12
Wed, Sep 11
Tue, Sep 10
I managed to run into this again:
Hm, see rL371513. I'm not sure what the correct fix is.
I see that llvm/.gitattributes already exists, and I assumed that was enough, but I see that it is not. lgtm
Mon, Sep 9
Sorry this got lost for two weeks. :(
Ptal, new patch
- rewrite, abandon unification
Fri, Sep 6
Looks right to me, but let's wait for @inlgorion to take a look on Monday.
Hit send too soon...
Should the _ prefix (for itanium symbols in i386 mode) be stripped by the COFF wrapper function, or by the common demangle function (matching _Z or __Z)?
Thu, Sep 5
Here is some feedback, I apologize for dragging my feet.
lgtm, it's in the LLVM_ namespace, so it couldn't hurt to record it.
- emit an error if we try to clone without a definition
- merge into thunks.cpp
I think what I said applies to your test case. Basically, in the Itanium C++ ABI, virtual method definitions provide all their thunks as weak_odr. We only emit thunks referenced by vtables as an optimization, and they are marked available_externally. In your test case, we hit the early return that I linked to, so we don't try to clone, and we don't need to emit an error.