Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

rnk (Reid Kleckner)
User

Projects

User Details

User Since
Jan 2 2013, 4:34 PM (559 w, 4 d)

Recent Activity

Thu, Sep 21

rnk closed D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency.

Let's close it.

Thu, Sep 21, 1:26 PM · Restricted Project, Restricted Project
rnk closed D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link".

Closing, we left the test alone, it still uses -fuse-ld=lld-link2. Perhaps in the future we should reconsider this, but that's how things stand now, and we aren't going to land this patch as is. + @MaskRay , who has thought about -fuse-ld= semantics.

Thu, Sep 21, 9:27 AM · Restricted Project, Restricted Project

Mon, Sep 18

rnk updated subscribers of D159351: [Sema] Change order of displayed overloads in diagnostics.

+@cjdb , do you have time to review this?

Mon, Sep 18, 9:38 AM · Restricted Project, Restricted Project

Fri, Sep 15

rnk accepted D150297: [X86] Use RIP-relative addressing for data under large data threshold for medium code model.

lgtm

Fri, Sep 15, 1:27 PM · Restricted Project, Restricted Project

Thu, Sep 14

rnk accepted D149288: [X86] Introduce a large data threshold for the medium code model.

lgtm

Thu, Sep 14, 10:01 AM · Restricted Project, Restricted Project

Wed, Sep 13

rnk added inline comments to D149288: [X86] Introduce a large data threshold for the medium code model.
Wed, Sep 13, 3:56 PM · Restricted Project, Restricted Project
rnk added a comment to D149288: [X86] Introduce a large data threshold for the medium code model.

One of our use cases for having a "large" attribute for global data is to have a way to mark instrumentation data as large. We would use this for ASan global metadata and PGO name data, which are not accessed frequently during program execution, but contribute significantly to binary data size.

Wed, Sep 13, 12:43 PM · Restricted Project, Restricted Project
rnk added a reverting change for rG2ca4d136124d: [InlineAsm] wrap ConstraintCode in enum class NFC (#66003): rGee643b706be2: Revert "[InlineAsm] wrap ConstraintCode in enum class NFC (#66003)".
Wed, Sep 13, 9:58 AM · Restricted Project, Restricted Project
rnk added a reverting change for rG8b9bf3a9f715: [InlineAsm] fix botched merge conflict resolution: rGee643b706be2: Revert "[InlineAsm] wrap ConstraintCode in enum class NFC (#66003)".
Wed, Sep 13, 9:58 AM · Restricted Project, Restricted Project
rnk committed rGee643b706be2: Revert "[InlineAsm] wrap ConstraintCode in enum class NFC (#66003)" (authored by rnk).
Revert "[InlineAsm] wrap ConstraintCode in enum class NFC (#66003)"
Wed, Sep 13, 9:58 AM · Restricted Project, Restricted Project
rnk updated subscribers of D157058: [libc++] Remove generic char_traits implementation.

FWIW after speaking with @thakis offline, I do think we did "everything right", in the following sense. We added the deprecated attribute to the class and left it there across one full release (roughly 1 year). This should leave enough time for people to notice the warning when updating libc++, turn it off temporarily with -Wno-deprecated as they fix their code, and then re-enable the warning. I think this is the right model we want to give folks.

Wed, Sep 13, 9:33 AM · Restricted Project, Restricted Project

Thu, Sep 7

rnk added a comment to D152752: [MS] Fix passing aligned records by value in some cases.

Following up, the vararg fix is here: https://github.com/llvm/llvm-project/pull/65692

Thu, Sep 7, 4:05 PM · Restricted Project, Restricted Project

Wed, Sep 6

rnk added a comment to D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.

The reproducer in the commit message no longer asserts for me, maybe we can close this.

Wed, Sep 6, 3:39 PM · Restricted Project, debug-info, Restricted Project

Fri, Sep 1

rnk accepted D159226: Emit line numbers in CodeView for trailing (after `ret`) blocks from inlined functions.

lgtm, thanks!

Fri, Sep 1, 3:45 PM · Restricted Project, Restricted Project
rnk added a comment to D154294: [Windows SEH]: Do not fold branches for MSVC TableSEH function.

The CFG becomes more complicated in the sense that there are more edges... but it becomes simpler in the sense that code which generically supports EH pads should just work without additional SEH-specific knowledge. The latter property seems more valuable because most people working on the backend know nothing about SEH.

Fri, Sep 1, 3:14 PM · Restricted Project, Restricted Project
rnk added a comment to D159226: Emit line numbers in CodeView for trailing (after `ret`) blocks from inlined functions.

Thanks for the patch, this is gnarly code. At the time I was probably thinking that flat vectors are good for performance, and that we'll have tons of line table entries, but as the inline location handling evolved, it's gotten quite complicated.

Fri, Sep 1, 10:15 AM · Restricted Project, Restricted Project

Thu, Aug 31

rnk accepted D159297: [X86] Use 64-bit jump table entries for large code model PIC.

lgtm

Thu, Aug 31, 11:38 AM · Restricted Project, Restricted Project
rnk added a comment to D154294: [Windows SEH]: Do not fold branches for MSVC TableSEH function.

bb.5.invoke.cont4 to landing pad (I assume it's bb.7.ehcleanup) doesn't matter to me here. I analyzed the problem was the edge from bb.3.invoke.cont2 to bb.4.__except was removed in BranchFolding. This is the direct problem I wanted to solve here. It seems we are talking about independent problems. I didn't research the other but I think it doesn't solve my problem.

Thu, Aug 31, 9:36 AM · Restricted Project, Restricted Project
rnk added a comment to D159139: [compiler-rt] [builtins] Remove unused/misnamed x86 chkstk functions.

I think that's reasonable. libgcc probably retains them out of some desire for longer term backward compatibility, and I think we're a little less constrained there.

Thu, Aug 31, 9:11 AM · Restricted Project, Restricted Project
rnk added a comment to D89353: Enable overriding `__libcpp_debug_function` invocation.

+1, this use case has long been addressed by the assertion mode, and then the new safe and hardened modes.

Thu, Aug 31, 9:08 AM · Restricted Project, Restricted Project

Wed, Aug 30

rnk committed rG5bc514b74eed: [bazel] Remove the dependency on CodeGen from MCTargetDesc & Utils (authored by rnk).
[bazel] Remove the dependency on CodeGen from MCTargetDesc & Utils
Wed, Aug 30, 6:22 PM · Restricted Project, Restricted Project
rnk committed rGcacdf3b8c44f: [VE] Remove CodeGen deps from MCTargetDesc, NFC (authored by rnk).
[VE] Remove CodeGen deps from MCTargetDesc, NFC
Wed, Aug 30, 4:27 PM · Restricted Project, Restricted Project
rnk committed rG52abac26ef96: [bazel] Add missing dep from DwarfLinkerParallel to Object (authored by rnk).
[bazel] Add missing dep from DwarfLinkerParallel to Object
Wed, Aug 30, 4:27 PM · Restricted Project
rnk committed rG9f72e3f70fc3: [Lanai] Fix MC CodeGen layering, NFC (authored by rnk).
[Lanai] Fix MC CodeGen layering, NFC
Wed, Aug 30, 4:18 PM · Restricted Project, Restricted Project
rnk committed rGcda23c07328c: [PPC] Fix layering issues between MCTargetDesc and CodeGen (authored by rnk).
[PPC] Fix layering issues between MCTargetDesc and CodeGen
Wed, Aug 30, 4:09 PM · Restricted Project, Restricted Project
rnk closed D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen.
Wed, Aug 30, 4:09 PM · Restricted Project, Restricted Project
rnk added a comment to D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen.

I haven't heard any serious concerns, and I hope I addressed your questions. I plan to go ahead and land this, but feel free to modify or revert if you have concerns.

Wed, Aug 30, 4:05 PM · Restricted Project, Restricted Project
rnk added a comment to D154294: [Windows SEH]: Do not fold branches for MSVC TableSEH function.

hasEHPadSuccessor() is actually false for the block that throws the exception. I think that's a bug... but everybody else who's looked at this code apparently disagrees with me.

Wed, Aug 30, 3:55 PM · Restricted Project, Restricted Project
rnk added a comment to D154294: [Windows SEH]: Do not fold branches for MSVC TableSEH function.

I wanted to follow up on this, it was hiding at the bottom of my inbox.

Wed, Aug 30, 1:58 PM · Restricted Project, Restricted Project
rnk added a comment to D153690: [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier.

@rnk This reproducer code should be accepted for clang to be aligned with msvc's behavior, correct?

Wed, Aug 30, 11:29 AM · Restricted Project, Restricted Project
rnk accepted D159139: [compiler-rt] [builtins] Remove unused/misnamed x86 chkstk functions.

At various points I have tried to untangle the meaning, purpose, and function of these various stack adjustment routines, and I never felt like I had a satisfactory understanding. I trust that you got to the bottom of this.

Wed, Aug 30, 11:08 AM · Restricted Project, Restricted Project

Tue, Aug 29

rnk accepted D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual).

This seems like it will generate warning cleanup work for vendors, so I'll mention #clang-vendors , but I think the code looks good. I don't think it makes sense to add a fine-grained diagnostic category to allow people to clean up incrementally in this case.

Tue, Aug 29, 4:24 PM · Restricted Project, Restricted Project
rnk added a comment to D157136: [LLD][COFF] Handle 'label' symbols when they point to a COMDAT section.

I think this kind of error ("relocation against symbol in discarded section") is really hard to debug, and probably deserves a whole page of documentation. I think the best option would be to emit a short link to online documentation describing the issue category in detail, something like https://lld.llvm.org/missingkeyfunction.html .

Tue, Aug 29, 4:19 PM · Restricted Project, Restricted Project
rnk added a comment to D157136: [LLD][COFF] Handle 'label' symbols when they point to a COMDAT section.

I'm also wondering if instead of this patch, we couldn't craft something simpler, an heuristic that "fixes" the section header and the section symbol. Usually they seems to come in a pair, .text$mn, .text$x or a trio if debug symbols are involved: .text$mn, .debug$S, .text$x. Opinions?

Tue, Aug 29, 2:59 PM · Restricted Project, Restricted Project
rnk added a comment to D152752: [MS] Fix passing aligned records by value in some cases.

I put together a fix here: https://github.com/llvm/llvm-project/compare/main...rnk:llvm-project:fix-vararg-align

Tue, Aug 29, 2:34 PM · Restricted Project, Restricted Project
rnk updated subscribers of D158942: [bazel] Include builtin headers with clang-tidy.

+@rupprecht @aeubanks, can you review this Bazel change?

Tue, Aug 29, 1:00 PM · Restricted Project, Restricted Project
rnk updated subscribers of D152752: [MS] Fix passing aligned records by value in some cases.

I need to get to it, my recollection is that @mstorsjo ran into the same issue here for mingw and made some changes, I wanted to go dig those up as a starting point. I may have completely forgotten things though.

Tue, Aug 29, 12:57 PM · Restricted Project, Restricted Project
rnk accepted D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations..

lgtm

Tue, Aug 29, 12:45 PM · Restricted Project, Restricted Project

Mon, Aug 28

rnk added inline comments to D143108: [Asan] Add "funclet" OpBundle to Asan calls that are generated inside a funclet.
Mon, Aug 28, 3:54 PM · Restricted Project, Restricted Project, Restricted Project
rnk added inline comments to D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations..
Mon, Aug 28, 2:58 PM · Restricted Project, Restricted Project
rnk accepted D158984: [Clang] Allow __declspec(noalias) to access inaccessible memory.

lgtm

Mon, Aug 28, 2:46 PM · Restricted Project, Restricted Project
rnk updated subscribers of D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64.

+@efriedma, since I think we had that ongoing thread about what to do with i128 alignment in data layout. Is this a reasonable way to handle the datalayout migration?

Mon, Aug 28, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
rnk updated subscribers of D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant.
Mon, Aug 28, 2:08 PM · Restricted Project, Restricted Project
rnk added a comment to D157907: [NFC] Refactor X86TargetLowering::getGlobalWrapperKind().

Regarding large code model jump tables, I think I filed an issue for alternative, relocation-less jump table encodings: https://github.com/llvm/llvm-project/issues/62894

Mon, Aug 28, 1:48 PM · Restricted Project, Restricted Project
rnk accepted D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..

lgtm with some tweaks to the test.

Mon, Aug 28, 1:10 PM · Restricted Project, Restricted Project
rnk added a comment to D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..

It took me a while to find this code to understand the issue. The problem is that there is an inconsistency between the GVA linkage and the LLVM IR linkage for these constructors. In this godbolt example, ??0?$TInputDataVertexModel.. is marked internal and marked comdat, and that is uncommon. PGO instrumentation appears to do the wrong thing in that case. Is that more or less what's happening?

Mon, Aug 28, 10:30 AM · Restricted Project, Restricted Project

Aug 23 2023

rnk added inline comments to D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant.
Aug 23 2023, 4:03 PM · Restricted Project, Restricted Project
rnk added a comment to D152752: [MS] Fix passing aligned records by value in some cases.

Thanks, I think this is a clang bug. As I understand MSVC's behavior, we should not pass highly aligned variadic arguments indirectly: https://gcc.godbolt.org/z/Kr67xWTeE

Aug 23 2023, 11:30 AM · Restricted Project, Restricted Project

Aug 22 2023

rnk added inline comments to D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals .
Aug 22 2023, 6:43 PM · Restricted Project, Restricted Project
rnk committed rGba52a10fca6f: [clang-tidy] Fix test to not depend on D153156, which was reverted (authored by rnk).
[clang-tidy] Fix test to not depend on D153156, which was reverted
Aug 22 2023, 6:39 PM · Restricted Project, Restricted Project
rnk added a comment to D153156: [Clang] CWG1473: do not err on the lack of space after operator"".

I went ahead and pushed a revert of this, since this change was pretty disruptive, at least in our experience. I could be convinced that it's worth sunsetting this extension for accepting C-style format string macro code, but that doesn't seem like the original intent of this change. Maybe that's the right thing to do, but it should be an intentionally considered change.

Aug 22 2023, 6:21 PM · Restricted Project, Restricted Project
rnk added a reverting change for rGf2583f3acf59: [Clang] CWG1473: do not err on the lack of space after operator"": rG0d9919d362a7: Revert "[Clang] CWG1473: do not err on the lack of space after operator""".
Aug 22 2023, 6:17 PM · Restricted Project, Restricted Project
rnk committed rG0d9919d362a7: Revert "[Clang] CWG1473: do not err on the lack of space after operator""" (authored by rnk).
Revert "[Clang] CWG1473: do not err on the lack of space after operator"""
Aug 22 2023, 6:17 PM · Restricted Project, Restricted Project
rnk added a reverting change for D153156: [Clang] CWG1473: do not err on the lack of space after operator"": rG0d9919d362a7: Revert "[Clang] CWG1473: do not err on the lack of space after operator""".
Aug 22 2023, 6:17 PM · Restricted Project, Restricted Project
rnk accepted D158569: workflows: Disable repo-lockdown for llvm/utils/git.

lgtm, if @asl is offline, and it's useful

Aug 22 2023, 6:03 PM · Restricted Project, Restricted Project
rnk added a comment to D158221: [llvm-lit] copy CRT/STL DLLs into the output directory.

I'm not that familiar with the typical compatibility requirements for DLLs in the Windows system folder, but it seems pretty disruptive to ship a DLL in the system folder, and then ship ABI incompatible changes without increasing the version number. Wouldn't this all work if the STL increased the version number of msvcp140.dll instead?

Aug 22 2023, 4:15 PM · Restricted Project, Restricted Project

Aug 21 2023

rnk accepted D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..

lgtm, thanks!

Aug 21 2023, 4:05 PM · Restricted Project, Restricted Project
rnk added a comment to D61670: [clang] [MinGW] Add the option -fno-auto-import.
In D61670#4604145, @rnk wrote:

cc +@aeubanks @jyknight to consider using the code model for this purpose

Hmm, I don't quite understand this comment; do you suggest that we after all should use the code model for controlling the use of .refptr stubs too - didn't we conclude earlier that it isn't a great fit for that?

Aug 21 2023, 12:55 PM · Restricted Project, Restricted Project
rnk added inline comments to D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 21 2023, 10:53 AM · Restricted Project, Restricted Project
rnk added inline comments to D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 21 2023, 10:28 AM · Restricted Project, Restricted Project
rnk accepted D61670: [clang] [MinGW] Add the option -fno-auto-import.

cc +@aeubanks @jyknight to consider using the code model for this purpose

Aug 21 2023, 10:16 AM · Restricted Project, Restricted Project

Aug 18 2023

rnk accepted D157038: ASan: Add additional wcs* interceptors on Windows.

lgtm

Aug 18 2023, 2:47 PM · Restricted Project, Restricted Project
rnk accepted D157907: [NFC] Refactor X86TargetLowering::getGlobalWrapperKind().

lgtm

Aug 18 2023, 2:30 PM · Restricted Project, Restricted Project
rnk updated the diff for D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen.
  • rebase
Aug 18 2023, 2:13 PM · Restricted Project, Restricted Project
rnk committed rG984dc4b9cdca: [WebAssembly] Create separation between MC and CodeGen layers (authored by rnk).
[WebAssembly] Create separation between MC and CodeGen layers
Aug 18 2023, 2:13 PM · Restricted Project, Restricted Project
rnk closed D156472: [WebAssembly] Create separation between MC and CodeGen layers.
Aug 18 2023, 2:13 PM · Restricted Project, Restricted Project

Aug 17 2023

rnk added a comment to D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen.

Ping, any outstanding concerns?

Aug 17 2023, 3:32 PM · Restricted Project, Restricted Project
rnk added a comment to D156472: [WebAssembly] Create separation between MC and CodeGen layers.

Thanks for the review, hopefully all comments are addressed.

Aug 17 2023, 3:31 PM · Restricted Project, Restricted Project
rnk updated the diff for D156472: [WebAssembly] Create separation between MC and CodeGen layers.
  • apply fixes
Aug 17 2023, 3:31 PM · Restricted Project, Restricted Project
rnk added a comment to D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set.

Also assuming that /Ze is similar to our -fms-extensions which I believe is the case, but not completely sure

Aug 17 2023, 3:28 PM · Restricted Project, Restricted Project
rnk added a comment to D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant.

So, I'm strongly in favor of the feature, but I want to get feedback on the name.

Aug 17 2023, 3:17 PM · Restricted Project, Restricted Project
rnk updated subscribers of D143108: [Asan] Add "funclet" OpBundle to Asan calls that are generated inside a funclet.

Seeking a code reviewer, +@aeubanks, @vitalybuka

Aug 17 2023, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
rnk added a comment to D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set.

I don't think this is the right thing to do, I think I recall saying as much on some other review. The MSVC docs say that /Za//Ze control _MSC_EXTENSION, and as I understand it, /Za is more like our -fms-compatibility flag, so it makes sense to control this macro with -fms-compatibility.

Aug 17 2023, 11:53 AM · Restricted Project, Restricted Project

Aug 16 2023

rnk accepted D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations..

lgtm, thanks!

Aug 16 2023, 4:23 PM · Restricted Project, Restricted Project
rnk added inline comments to D157907: [NFC] Refactor X86TargetLowering::getGlobalWrapperKind().
Aug 16 2023, 11:43 AM · Restricted Project, Restricted Project
rnk added a comment to D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation.

That doesn't handle the second of your test cases though, where dllimport is put on the member directly:
...
It's not clear to me how we'd want to handle that. I don't think it comes up in libc++, and I can't think of any code that would want to do that either, really.

Aug 16 2023, 10:36 AM · Restricted Project, Restricted Project

Aug 14 2023

rnk added inline comments to D157907: [NFC] Refactor X86TargetLowering::getGlobalWrapperKind().
Aug 14 2023, 12:09 PM · Restricted Project, Restricted Project
rnk accepted D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially.

So, as I understand the discussion, after this patch, it will still be possible to get dwarf and codeview in the same compile, but users will have to resort to cc1 flags.

Aug 14 2023, 11:13 AM · Restricted Project, Restricted Project

Aug 12 2023

rnk updated subscribers of D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially.
Aug 12 2023, 5:07 PM · Restricted Project, Restricted Project

Aug 11 2023

rnk added a comment to D150646: [clang][X86] Add __cpuidex function to cpuid.h.

I think MSVC defines _MSC_EXTENSIONS under one of its compatibility modes as well, so it's not a good indicator of "is this compiler MSVC-like". I think we should be exposing the __cpudex builtin any time we are being MSVC-like, not under fms-compatibility. Would that make things sensible again?

Aug 11 2023, 4:42 PM · Restricted Project, Restricted Project
rnk added a comment to D112921: [clang] Enable sized deallocation by default in C++14 onwards.

What are the next steps here? Have concerns been addressed? The CI failures seem unrelated (libcxx tests is an AIX bot out of disk, clang CI is an interpreter test that seems unrelated, but please confirm).

Aug 11 2023, 4:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rnk accepted D156726: Make globals with mutable members non-constant, even in custom sections.

Thanks! My concerns are addressed, but please confirm that Eli's are too.

Aug 11 2023, 3:49 PM · Restricted Project, Restricted Project
rnk added a comment to D152152: [mlir][sparse] Fix strict weak ordering in sorting.

Any thoughts on this? As I understand it, this is the last remaining strict weak ordering violation in llvm-project, and after that folks can enable the checks for this in libc++. The other two changes (D155811, D155809) landed.

Aug 11 2023, 1:46 PM · Restricted Project, Restricted Project
rnk accepted D153337: [MachineLICM][WinEH] Don't hoist register reloads out of funclets.

This looks correct to me.

Aug 11 2023, 9:50 AM · Restricted Project, Restricted Project

Aug 10 2023

rnk added a comment to D157623: [lld][COFF] Remove incorrect flag from EHcont table.

You can see where the eh cont table was added here: https://reviews.llvm.org/D99078

Aug 10 2023, 3:55 PM · Restricted Project, Restricted Project
rnk added a comment to D157136: [LLD][COFF] Handle 'label' symbols when they point to a COMDAT section.

Here are some comments, I have to run, so it's not complete, but hopefully still useful.

Aug 10 2023, 11:27 AM · Restricted Project, Restricted Project
rnk accepted D157623: [lld][COFF] Remove incorrect flag from EHcont table.

lgtm

Aug 10 2023, 11:04 AM · Restricted Project, Restricted Project
rnk accepted D157566: [SEH] fix assertion when -fasy-exceptions is used..
Aug 10 2023, 10:03 AM · Restricted Project, Restricted Project
rnk added a comment to D157566: [SEH] fix assertion when -fasy-exceptions is used..

lgtm

Aug 10 2023, 10:03 AM · Restricted Project, Restricted Project
rnk added a comment to D157623: [lld][COFF] Remove incorrect flag from EHcont table.

Thanks!

Aug 10 2023, 10:01 AM · Restricted Project, Restricted Project

Aug 9 2023

rnk added a comment to D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations..

I agree that we can't emit all labels with the .L prefix into the object file symbol table. That would be prohibitively expensive.

Aug 9 2023, 2:40 PM · Restricted Project, Restricted Project
rnk updated subscribers of D157499: [IR] Add dead_on_unwind attribute.

This approach makes sense to me.

Aug 9 2023, 2:26 PM · Restricted Project, Restricted Project

Aug 2 2023

rnk added inline comments to D156726: Make globals with mutable members non-constant, even in custom sections.
Aug 2 2023, 10:32 AM · Restricted Project, Restricted Project

Jul 31 2023

rnk added inline comments to D156726: Make globals with mutable members non-constant, even in custom sections.
Jul 31 2023, 12:52 PM · Restricted Project, Restricted Project

Jul 28 2023

rnk added a comment to D154168: [X86] Split SDISel call lowering out to its own file.

Thanks!

Jul 28 2023, 10:24 AM · Restricted Project, Restricted Project
rnk committed rG26a730821d48: [X86] Split SDISel call lowering out to its own file (authored by rnk).
[X86] Split SDISel call lowering out to its own file
Jul 28 2023, 9:25 AM · Restricted Project, Restricted Project
rnk closed D154168: [X86] Split SDISel call lowering out to its own file.
Jul 28 2023, 9:24 AM · Restricted Project, Restricted Project

Jul 27 2023

rnk added a comment to D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen.

Thank you for the patch. This is actually interesting and is a bit of a change to how we thought the code was do be structured. For us the affinity between CodeGen and MCTargetDesc was an indication that the libraries, although separate, are dependent on each other. Of course, this is not necessary so I am in favour of this refactoring.

I don't want to approve this patch immediately, not because I am opposed to it, but because I think it should be seen and reviewed by all interested developers for the PowerPC back end so that we can change the mindset about these libraries.

Jul 27 2023, 4:11 PM · Restricted Project, Restricted Project
rnk updated the summary of D154168: [X86] Split SDISel call lowering out to its own file.
Jul 27 2023, 3:33 PM · Restricted Project, Restricted Project
rnk updated the diff for D154168: [X86] Split SDISel call lowering out to its own file.
  • rebase
  • rename call lowering file
Jul 27 2023, 3:33 PM · Restricted Project, Restricted Project