- User Since
- Jan 2 2013, 4:34 PM (288 w, 6 d)
Mon, Jun 25
Sat, Jun 23
Thanks for finding that!
Fri, Jun 22
- rebase over ELF rtdyld changes
I personally use false, but maybe input would be a good way to go going forward. Honestly, let's go ahead and recommend input. Even if our .gitattributes files don't say the right thing today, we can fix that over time, and then things will be more likely to work out of the box.
I have this change as part of https://reviews.llvm.org/D47211, which I'll try to reland soon.
Thu, Jun 21
So I reverted my change for now.
I investigated, but it is not trivial to fix.
LangOpts.ModulesCodegen is very related in spirit to this, but I think we need a distinct option because that was designed to handle all inline functions (too much), not just dllexport inline functions. + @dblaikie
Wed, Jun 20
- add missing test
@hans, think you'll have time to look at this with your recent dllexport PCH experimentation?
Tue, Jun 19
Mon, Jun 18
Do you think we should go ahead and remove the DefaultIgnore on these warnings as well? At this point, approximately nobody will see them.
Jun 14 2018
Sorry, I haven't had time to read up and respond to this. It's very likely that I will go on vacation shortly, and then not have time to come back to this until August.
Jun 13 2018
Jun 12 2018
Jun 11 2018
Jun 8 2018
Jun 7 2018
Think we should go for it?
Looks good, but @dblaikie has helpful thoughts about testing and he is responsive, so I'd let him take a look.
@dexonsmith is there someone from Apple who can comment on rdar://8678458 and the merits of disabling this warning in macros? I strongly suspect the original report was dealing with code like assert(x || y && "str");, if so we can go forward with this.
Jun 6 2018
Needs a test. I think you can copy llvm/test/MC/COFF/ir-to-imgrel.ll to llvm/test/MC/AArch64/ and modify it accordingly. The test is kind of in the wrong location, though. It should really be in llvm/test/CodeGen/(X86|AArch64), since it's an llc test.
Thanks for the patch!