Page MenuHomePhabricator

jansvoboda11 (Jan Svoboda)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2020, 4:28 AM (85 w, 1 d)

Working on implicitly discovered, explicitly built Clang modules at Apple.

Recent Activity

Today

jansvoboda11 accepted D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

LGTM.

Mon, May 23, 5:24 AM · Restricted Project, Restricted Project
jansvoboda11 accepted D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.

LGTM, nice cleanup! Left a couple of nits.

Mon, May 23, 5:16 AM · Restricted Project, Restricted Project

Thu, May 12

jansvoboda11 accepted D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality.

LGTM.

Thu, May 12, 11:20 AM · Restricted Project, Restricted Project
jansvoboda11 accepted D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens.

LGTM! Thanks for splitting this out.

Thu, May 12, 11:16 AM · Restricted Project, Restricted Project

Wed, May 11

jansvoboda11 accepted D125258: [docs][pp-trace] Remove FileNotFound callback.

LGTM, thanks!

Wed, May 11, 2:52 AM · Restricted Project, Restricted Project

Fri, May 6

jansvoboda11 updated the diff for D121465: WIP: [clang][modules] Do not report declarations without linkage as ambiguous.

Refer to enum constant while defining another

Fri, May 6, 5:13 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D121465: WIP: [clang][modules] Do not report declarations without linkage as ambiguous.

My concern with this approach is I'm not sure if isEquivalentInternalLinkageDeclaration is a desired long-term solution for anonymous C++ enums.

Fri, May 6, 5:13 AM · Restricted Project, Restricted Project

Thu, May 5

jansvoboda11 added inline comments to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.
Thu, May 5, 3:57 AM · Restricted Project, Restricted Project

Wed, May 4

jansvoboda11 accepted D124638: [clang] Track how headers get included generally during lookup time.

LGTM, thanks!

Wed, May 4, 12:47 AM · Restricted Project, Restricted Project

Sun, May 1

jansvoboda11 added a comment to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

I finished an initial pass through the code and it looks good for the most parts. I left a couple of suggestions in-line.

Sun, May 1, 11:43 PM · Restricted Project, Restricted Project

Fri, Apr 29

jansvoboda11 requested changes to D124638: [clang] Track how headers get included generally during lookup time.

Can you describe how come the check is not reliable without this patch? It might be worth fixing the underlying reason for the unreliability first.

Fri, Apr 29, 12:56 AM · Restricted Project, Restricted Project

Thu, Apr 28

jansvoboda11 accepted D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default.

Looks good, thanks!

Thu, Apr 28, 10:55 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl..

Presumably ASTStructuralEquivalence can also be used as a tie-breaker in the case of a hash collision?

Thu, Apr 28, 2:29 AM · Restricted Project, Restricted Project
jansvoboda11 accepted D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default.
Thu, Apr 28, 2:26 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default.

LGTM in general, with some suggestions in-line. Besides those, I think we should be able to remove PPSkipMappings from the condition in MinimizedVFSFile::create (DependencyScanningFilesystem.cpp).

Thu, Apr 28, 2:26 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl..

This sounds reasonable to me. What use-cases does ASTStructuralEquivalence fit better than ODR hashes?

I think the biggest advantage of ASTStructuralEquivalence is that it doesn't affect memory consumption by Decls. But it makes repeated comparisons more expensive.

Another ASTStructuralEquivalence advantage is that it's easier to add new checks. For example, comparing ivars is pretty trivial with ASTStructuralEquivalence but with ODR hash we need to handle that ivar types can be structs/unions, including anonymous and nested structs.

Cannot say that for sure but I think ASTStructuralEquivalence is easier to extend and to adopt for different purposes, while ODR hash seems to be more invasive. But this argument is more hand-wavy.

Most likely ASTStructuralEquivalence has other positive qualities but that's what I was able to come up off the top of my head. And you can see that in my decision-making ASTStructuralEquivalence doesn't look like a compelling option.

Thu, Apr 28, 2:19 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl..
Thu, Apr 28, 2:15 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`..
Thu, Apr 28, 2:10 AM · Restricted Project, Restricted Project

Tue, Apr 26

jansvoboda11 added a comment to D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl..

This sounds reasonable to me. What use-cases does ASTStructuralEquivalence fit better than ODR hashes?

Tue, Apr 26, 4:58 AM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module..

This looks good IMO. Let's see if others have more suggestions besides the Parser/Sema layering.

Tue, Apr 26, 4:47 AM · Restricted Project, Restricted Project
jansvoboda11 accepted D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`..

LGTM with two minor questions.

Tue, Apr 26, 4:39 AM · Restricted Project, Restricted Project

Apr 20 2022

jansvoboda11 added a reverting change for rG1d3ba05e4a28: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*(): rG340654e0f246: Revert "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()".
Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG340654e0f246: Revert "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()" (authored by jansvoboda11).
Revert "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()"
Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG99cfccdcb371: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion() (authored by jansvoboda11).
[clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()
Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
jansvoboda11 added a reverting change for D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*(): rG340654e0f246: Revert "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()".
Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion().
Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
jansvoboda11 reopened D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().
Apr 20 2022, 11:27 AM · Restricted Project, Restricted Project
jansvoboda11 committed rGf43ce5199df3: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry (authored by jansvoboda11).
[clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry
Apr 20 2022, 10:01 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry.
Apr 20 2022, 10:01 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry.
Apr 20 2022, 10:00 AM · Restricted Project, Restricted Project
jansvoboda11 committed rGba118f30676d: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile() (authored by jansvoboda11).
[clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile()
Apr 20 2022, 9:55 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123853: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile().
Apr 20 2022, 9:55 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG1d3ba05e4a28: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*() (authored by jansvoboda11).
[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()
Apr 20 2022, 9:54 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().
Apr 20 2022, 9:54 AM · Restricted Project, Restricted Project

Apr 15 2022

jansvoboda11 committed rG26b0ecb8985b: [clang][deps] NFC: Update documentation (authored by jansvoboda11).
[clang][deps] NFC: Update documentation
Apr 15 2022, 7:25 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG7ed01ba88d67: [clang][deps] NFC: Inline function with single caller (authored by jansvoboda11).
[clang][deps] NFC: Inline function with single caller
Apr 15 2022, 7:25 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion().
Apr 15 2022, 7:22 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry.
Apr 15 2022, 7:08 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123853: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile().
Apr 15 2022, 6:52 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().

Rebase, address review feedback

Apr 15 2022, 6:44 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().
Apr 15 2022, 6:30 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG0b09b5d44837: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry() (authored by jansvoboda11).
[clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry()
Apr 15 2022, 6:17 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG713e716cdaef: [clang] NFCI: Use FileEntryRef in FileManagerTest (authored by jansvoboda11).
[clang] NFCI: Use FileEntryRef in FileManagerTest
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG99b4874a53cf: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH (authored by jansvoboda11).
[clang] NFCI: Use DirectoryEntryRef in collectIncludePCH
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG9d98f58959b1: [clang][CodeGen] NFCI: Use FileEntryRef (authored by jansvoboda11).
[clang][CodeGen] NFCI: Use FileEntryRef
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123772: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry().
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 committed rGf263dac4465c: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport() (authored by jansvoboda11).
[clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport()
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123770: [clang] NFCI: Use FileEntryRef in FileManagerTest.
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH.
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123768: [clang][CodeGen] NFCI: Use FileEntryRef.
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport().
Apr 15 2022, 6:16 AM · Restricted Project, Restricted Project

Apr 14 2022

jansvoboda11 requested review of D123772: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry().
Apr 14 2022, 2:30 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().
Apr 14 2022, 2:12 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123770: [clang] NFCI: Use FileEntryRef in FileManagerTest.
Apr 14 2022, 2:01 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH.
Apr 14 2022, 1:54 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123768: [clang][CodeGen] NFCI: Use FileEntryRef.
Apr 14 2022, 1:52 AM · Restricted Project, Restricted Project
jansvoboda11 updated the summary of D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport().
Apr 14 2022, 1:51 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport().
Apr 14 2022, 1:49 AM · Restricted Project, Restricted Project
jansvoboda11 committed rGd79ad2f1dbc2: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective() (authored by jansvoboda11).
[clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()
Apr 14 2022, 1:46 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 closed D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().
Apr 14 2022, 1:46 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 retitled D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective() from [clang] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective to [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().
Apr 14 2022, 1:28 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 added inline comments to D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().
Apr 14 2022, 1:28 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 updated the diff for D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().

Rebase, apply review suggestions

Apr 14 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

jansvoboda11 updated the summary of D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().
Apr 12 2022, 10:24 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 updated the summary of D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().
Apr 12 2022, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 requested review of D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().
Apr 12 2022, 12:22 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

jansvoboda11 planned changes to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.
Apr 11 2022, 2:03 PM · Restricted Project, Restricted Project
jansvoboda11 reopened D121812: [clang][deps] NFC: De-duplicate clang-cl tests.
Apr 11 2022, 2:03 PM · Restricted Project, Restricted Project

Apr 8 2022

jansvoboda11 committed rGb672638dbc7c: [clang][deps] Ensure deterministic filename case (authored by jansvoboda11).
[clang][deps] Ensure deterministic filename case
Apr 8 2022, 12:18 AM · Restricted Project, Restricted Project
jansvoboda11 closed D123229: [clang][deps] Ensure deterministic filename case.
Apr 8 2022, 12:18 AM · Restricted Project, Restricted Project

Apr 7 2022

jansvoboda11 retitled D123229: [clang][deps] Ensure deterministic filename case from [clang][deps] Ensure deterministic file names on case-insensitive filesystems to [clang][deps] Ensure deterministic filename case.
Apr 7 2022, 8:09 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D123229: [clang][deps] Ensure deterministic filename case.

Windows path separators...

Apr 7 2022, 8:08 AM · Restricted Project, Restricted Project

Apr 6 2022

jansvoboda11 updated the diff for D123229: [clang][deps] Ensure deterministic filename case.

Finish test description.

Apr 6 2022, 8:55 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D123229: [clang][deps] Ensure deterministic filename case.
Apr 6 2022, 8:52 AM · Restricted Project, Restricted Project

Apr 5 2022

jansvoboda11 accepted D123070: [Driver][NFC] Simplify handling of flags in Options.td.

Thank you for working on this!

Apr 5 2022, 7:01 AM · Restricted Project, Restricted Project

Mar 28 2022

jansvoboda11 added a comment to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Thanks for the revert @gulfem. I was hoping I'll be able to quickly forward-fix the issue, but turns out there's more to investigate.

Mar 28 2022, 9:14 AM · Restricted Project, Restricted Project

Mar 24 2022

jansvoboda11 added a comment to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Sorry for the breakage and thanks for reporting this! This is a real bug uncovered by your build using /opt. I have a fix here: D122385.

Mar 24 2022, 5:15 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D122385: [clang][deps] Fix clang-cl output argument parsing.
Mar 24 2022, 5:12 AM · Restricted Project, Restricted Project

Mar 23 2022

jansvoboda11 committed rG30cb49b44e4e: [clang][deps] NFC: De-duplicate clang-cl tests (authored by jansvoboda11).
[clang][deps] NFC: De-duplicate clang-cl tests
Mar 23 2022, 7:42 AM · Restricted Project
jansvoboda11 committed rG26053ce05a87: [clang][deps] Create lit substitution for deps-to-rsp (authored by jansvoboda11).
[clang][deps] Create lit substitution for deps-to-rsp
Mar 23 2022, 7:42 AM · Restricted Project
jansvoboda11 closed D121812: [clang][deps] NFC: De-duplicate clang-cl tests.
Mar 23 2022, 7:42 AM · Restricted Project, Restricted Project
jansvoboda11 closed D121525: [clang][deps] Create lit substitution for deps-to-rsp.
Mar 23 2022, 7:42 AM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.
Mar 23 2022, 7:29 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG59dadd178b0b: [clang][lex] Fix failures with Microsoft header search rules (authored by jansvoboda11).
[clang][lex] Fix failures with Microsoft header search rules
Mar 23 2022, 6:49 AM · Restricted Project
jansvoboda11 closed D122237: [clang][lex] Fix failures with Microsoft header search rules.
Mar 23 2022, 6:49 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D122237: [clang][lex] Fix failures with Microsoft header search rules.

Remove slash from test to make it pass on Windows

Mar 23 2022, 1:43 AM · Restricted Project, Restricted Project

Mar 22 2022

jansvoboda11 added a comment to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Ping.

Mar 22 2022, 1:25 PM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D121525: [clang][deps] Create lit substitution for deps-to-rsp.

Ping.

Mar 22 2022, 1:24 PM · Restricted Project, Restricted Project
jansvoboda11 added a comment to D119721: [clang][lex] Use `ConstSearchDirIterator` in lookup cache.

Thanks for reporting this (also reported here: https://github.com/llvm/llvm-project/issues/54426). I have a fix up for review here: D122237.

Mar 22 2022, 9:22 AM · Restricted Project, Restricted Project
jansvoboda11 added reviewers for D122237: [clang][lex] Fix failures with Microsoft header search rules: Bigcheese, dexonsmith, sberg, mikerice, erichkeane.
Mar 22 2022, 9:21 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D122237: [clang][lex] Fix failures with Microsoft header search rules.
Mar 22 2022, 9:19 AM · Restricted Project, Restricted Project

Mar 21 2022

jansvoboda11 updated the diff for D121997: [clang][driver] Fix compilation database dump with multiple architectures.

Introduce -driver-only to avoid running -cc1s.

Mar 21 2022, 1:34 AM · Restricted Project, Restricted Project

Mar 18 2022

jansvoboda11 updated the diff for D121997: [clang][driver] Fix compilation database dump with multiple architectures.

Avoid buggy driver behavior

Mar 18 2022, 12:37 PM · Restricted Project, Restricted Project
jansvoboda11 added inline comments to D121997: [clang][driver] Fix compilation database dump with multiple architectures.
Mar 18 2022, 12:21 PM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D121997: [clang][driver] Fix compilation database dump with multiple architectures.

Specify the apple-darwin target

Mar 18 2022, 12:16 PM · Restricted Project, Restricted Project
jansvoboda11 requested review of D121997: [clang][driver] Fix compilation database dump with multiple architectures.
Mar 18 2022, 4:52 AM · Restricted Project, Restricted Project

Mar 16 2022

jansvoboda11 updated the summary of D121525: [clang][deps] Create lit substitution for deps-to-rsp.
Mar 16 2022, 2:44 PM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Add -NEXT to a check

Mar 16 2022, 9:00 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Remove backslashes from make output checks

Mar 16 2022, 8:59 AM · Restricted Project, Restricted Project
jansvoboda11 updated the summary of D121812: [clang][deps] NFC: De-duplicate clang-cl tests.
Mar 16 2022, 8:57 AM · Restricted Project, Restricted Project