Page MenuHomePhabricator

jansvoboda11 (Jan Svoboda)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2020, 4:28 AM (28 w, 2 d)

Working on implicitly discovered, explicitly built Clang modules at Apple.

Recent Activity

Today

jansvoboda11 added a comment to D100509: Support GCC's -fstack-usage flag.

This LGTM from command-line perspective, but I'll let others judge the rest of the patch.

Tue, Apr 20, 12:23 AM · Restricted Project, Restricted Project

Yesterday

jansvoboda11 committed rG6a72ed239cc3: [clang] NFC: Fix range-based for loop warnings related to decl lookup (authored by jansvoboda11).
[clang] NFC: Fix range-based for loop warnings related to decl lookup
Mon, Apr 19, 9:32 AM
jansvoboda11 requested review of D100762: [clang][cli] Extract AST dump format into extra option.
Mon, Apr 19, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
jansvoboda11 planned changes to D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.
Mon, Apr 19, 6:46 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.

Rebase, delete RefBase copy assignment

Mon, Apr 19, 6:45 AM · Restricted Project, Restricted Project
jansvoboda11 committed rG95588c0da4ef: [clang][deps] NFC: Remove unused FullDependencies member (authored by jansvoboda11).
[clang][deps] NFC: Remove unused FullDependencies member
Mon, Apr 19, 6:03 AM
jansvoboda11 closed D100536: [clang][deps] NFC: Remove unused FullDependencies member.
Mon, Apr 19, 6:03 AM · Restricted Project
jansvoboda11 committed rG0a92e09c0785: [clang][deps] Generate the full command-line for modules (authored by jansvoboda11).
[clang][deps] Generate the full command-line for modules
Mon, Apr 19, 5:33 AM
jansvoboda11 closed D100534: [clang][deps] Generate the full command-line for modules.
Mon, Apr 19, 5:32 AM · Restricted Project
jansvoboda11 added a comment to D100534: [clang][deps] Generate the full command-line for modules.

Thanks for the review!

Mon, Apr 19, 5:03 AM · Restricted Project
jansvoboda11 committed rG2b73565210ef: [clang][deps] Remove the -full-command-line flag (authored by jansvoboda11).
[clang][deps] Remove the -full-command-line flag
Mon, Apr 19, 3:28 AM
jansvoboda11 closed D100533: [clang][deps] Remove the -full-command-line flag.
Mon, Apr 19, 3:28 AM · Restricted Project
jansvoboda11 committed rG32219c8c4478: [clang][deps] Simplify function discovering .pcm and .modulemap files (authored by jansvoboda11).
[clang][deps] Simplify function discovering .pcm and .modulemap files
Mon, Apr 19, 3:12 AM
jansvoboda11 closed D100531: [clang][deps] Simplify function discovering .pcm and .modulemap files.
Mon, Apr 19, 3:11 AM · Restricted Project
jansvoboda11 committed rGfb2aa63d7dc5: [clang][cli] NFC: Move conditional LangOptions parsing/generation (authored by jansvoboda11).
[clang][cli] NFC: Move conditional LangOptions parsing/generation
Mon, Apr 19, 2:26 AM
jansvoboda11 closed D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation.
Mon, Apr 19, 2:25 AM · Restricted Project
jansvoboda11 committed rG64e4dfd72b42: [clang][cli] NFC: Use Diags to report parsing success/failure (authored by jansvoboda11).
[clang][cli] NFC: Use Diags to report parsing success/failure
Mon, Apr 19, 2:17 AM
jansvoboda11 closed D100644: [clang][cli] NFC: Use Diags to report parsing success/failure.
Mon, Apr 19, 2:17 AM · Restricted Project
jansvoboda11 committed rG26bbb8700bb0: [clang] Implement CompilerInvocation copy assignment (authored by jansvoboda11).
[clang] Implement CompilerInvocation copy assignment
Mon, Apr 19, 2:12 AM
jansvoboda11 closed D100473: [clang] Implement CompilerInvocation copy assignment.
Mon, Apr 19, 2:12 AM · Restricted Project
jansvoboda11 committed rG782b9858882d: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase (authored by jansvoboda11).
[clang] Rename CompilerInvocationBase to RefBase, split out ValueBase
Mon, Apr 19, 1:31 AM
jansvoboda11 closed D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase.
Mon, Apr 19, 1:31 AM · Restricted Project

Fri, Apr 16

jansvoboda11 requested review of D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation.
Fri, Apr 16, 8:21 AM · Restricted Project
jansvoboda11 requested review of D100644: [clang][cli] NFC: Use Diags to report parsing success/failure.
Fri, Apr 16, 6:39 AM · Restricted Project
jansvoboda11 added inline comments to D100534: [clang][deps] Generate the full command-line for modules.
Fri, Apr 16, 5:14 AM · Restricted Project
jansvoboda11 added inline comments to D100534: [clang][deps] Generate the full command-line for modules.
Fri, Apr 16, 5:08 AM · Restricted Project
jansvoboda11 updated the diff for D100534: [clang][deps] Generate the full command-line for modules.

Share ModuleDeps::Invocation

Fri, Apr 16, 5:07 AM · Restricted Project
jansvoboda11 planned changes to D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.
Fri, Apr 16, 2:32 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.

Rebase

Fri, Apr 16, 2:31 AM · Restricted Project, Restricted Project
jansvoboda11 updated the diff for D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.

Rebase

Fri, Apr 16, 2:27 AM · Restricted Project, Restricted Project

Thu, Apr 15

jansvoboda11 updated jansvoboda11.
Thu, Apr 15, 1:16 PM
jansvoboda11 updated jansvoboda11.
Thu, Apr 15, 1:15 PM
jansvoboda11 accepted D99751: Add the TableGen assert statement, step 3.

LGTM then.

Thu, Apr 15, 9:04 AM · Restricted Project
jansvoboda11 added a comment to D99751: Add the TableGen assert statement, step 3.

In order to use a union in the RecordsEntry struct, I will have to add an enumerated value that specifies which kind of pointer is in the union. Is that worth the bother? Especially since I believe I'll have to write a special destructor.

Thu, Apr 15, 5:16 AM · Restricted Project
jansvoboda11 added a comment to D100509: Support GCC's -fstack-usage flag.

I left a couple of comments inline on the command-line parsing aspect of the patch. For more info, check https://clang.llvm.org/docs/InternalsManual.html#adding-new-command-line-option.

Thu, Apr 15, 4:46 AM · Restricted Project, Restricted Project
jansvoboda11 retitled D100533: [clang][deps] Remove the -full-command-line flag from [clang][deps] Always generate full command lines to [clang][deps] Remove the -full-command-line flag.
Thu, Apr 15, 2:45 AM · Restricted Project
jansvoboda11 committed rG06eff02ba18b: [clang][deps] NFC: Improve documentation (authored by jansvoboda11).
[clang][deps] NFC: Improve documentation
Thu, Apr 15, 1:31 AM
jansvoboda11 requested review of D100536: [clang][deps] NFC: Remove unused FullDependencies member.
Thu, Apr 15, 1:25 AM · Restricted Project
jansvoboda11 requested review of D100534: [clang][deps] Generate the full command-line for modules.
Thu, Apr 15, 1:21 AM · Restricted Project
jansvoboda11 updated the summary of D100533: [clang][deps] Remove the -full-command-line flag.
Thu, Apr 15, 1:12 AM · Restricted Project
jansvoboda11 requested review of D100533: [clang][deps] Remove the -full-command-line flag.
Thu, Apr 15, 1:11 AM · Restricted Project
jansvoboda11 requested review of D100531: [clang][deps] Simplify function discovering .pcm and .modulemap files.
Thu, Apr 15, 12:48 AM · Restricted Project

Wed, Apr 14

jansvoboda11 requested changes to D99751: Add the TableGen assert statement, step 3.

Sorry, I didn't realize that by "next step" you were referring to a future patch. I'd like to see my two comments addressed in this (and a prep) patch, instead of in the future.

Wed, Apr 14, 6:50 AM · Restricted Project
jansvoboda11 updated the summary of D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.
Wed, Apr 14, 5:41 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D100473: [clang] Implement CompilerInvocation copy assignment.
Wed, Apr 14, 5:40 AM · Restricted Project
jansvoboda11 planned changes to D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.
Wed, Apr 14, 3:25 AM · Restricted Project, Restricted Project
jansvoboda11 retitled D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone from [clang] Move deep copy into CompilerInvocation::clone to [WIP][clang] Move deep copy into CompilerInvocation::clone.
Wed, Apr 14, 3:25 AM · Restricted Project, Restricted Project
jansvoboda11 updated the summary of D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.
Wed, Apr 14, 3:21 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone.
Wed, Apr 14, 3:19 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase.
Wed, Apr 14, 1:14 AM · Restricted Project
jansvoboda11 committed rG09d1f6e6b74c: [clang] Fix copy constructor of CompilerInvocation (authored by jansvoboda11).
[clang] Fix copy constructor of CompilerInvocation
Wed, Apr 14, 12:13 AM
jansvoboda11 closed D99568: [clang] Fix copy constructor of CompilerInvocation.
Wed, Apr 14, 12:13 AM · Restricted Project
jansvoboda11 retitled D99568: [clang] Fix copy constructor of CompilerInvocation from [clang][invocation] Fix copy constructor of CompilerInvocation to [clang] Fix copy constructor of CompilerInvocation.
Wed, Apr 14, 12:12 AM · Restricted Project

Tue, Apr 13

jansvoboda11 retitled D99568: [clang] Fix copy constructor of CompilerInvocation from [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation to [clang][invocation] Fix copy constructor of CompilerInvocation.
Tue, Apr 13, 8:15 AM · Restricted Project
jansvoboda11 updated the diff for D99568: [clang] Fix copy constructor of CompilerInvocation.

Remove copy-assignment changes

Tue, Apr 13, 8:14 AM · Restricted Project

Mon, Apr 12

jansvoboda11 added a comment to D99568: [clang] Fix copy constructor of CompilerInvocation.

Ping.

Mon, Apr 12, 4:54 AM · Restricted Project

Fri, Apr 9

jansvoboda11 added a comment to D97462: [clang][cli] Round-trip cc1 arguments in assert builds.

I just merged this commit into our CHERI fork and noticed some failing tests due to round tripping:
We add some additional CodeGenOptions and LangOptions, but are not including those in the generated command line.

For example, I added an additional std::string CHERIStatsFile; to CodeGenOptions. This is set inside bool CompilerInvocation::ParseCodeGenArgs using Opts.CHERIStatsFile = Args.getLastArgValue(OPT_cheri_stats_file).str();.
I haven't added logic to round trip this flag (yet). If CC1 argument round tripping is enabled, the flag is stripped and the output goes to stderr instead of the defined file, causing some tests to fail.

Unfortunately this is not caught by any assertions, so I worry that there are other arguments that might be silently removed after this commit. Are there any open reviews/plans to check CodeGenOptions/etc, for equality after round-tripping?

Fri, Apr 9, 2:15 AM · Restricted Project
jansvoboda11 added a comment to D100150: [Sanitizers] Add a flag -f[no-]sanitize-merge-traps.

The CodeGen tests you added are failing pre-merge checks. This is most likely because we recently (D97462) started verifying that all all CC1 command line options can be serialized from a CompilerInvocation instance. To reproduce this locally, you'd need to build with assertions or manually set -DCLANG_ROUND_TRIP_CC1_ARGS=ON when building with CMake.

Fri, Apr 9, 2:00 AM · Restricted Project

Thu, Apr 8

jansvoboda11 added inline comments to D99751: Add the TableGen assert statement, step 3.
Thu, Apr 8, 4:39 AM · Restricted Project
jansvoboda11 added a comment to D99751: Add the TableGen assert statement, step 3.

Thanks for working on this, Paul!

Thu, Apr 8, 3:57 AM · Restricted Project

Tue, Apr 6

jansvoboda11 added a comment to D98884: [IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction.

Back to green after the revert: https://lab.llvm.org/buildbot/#/builders/121/builds/6307

Tue, Apr 6, 8:10 AM · Restricted Project
jansvoboda11 added a reverting change for rG167ea67d76c2: [IR] Ignore bitcasts of function pointers which are only used as callees in…: rGfb6a5237aa73: Revert "[IR] Ignore bitcasts of function pointers which are only used as….
Tue, Apr 6, 7:34 AM
jansvoboda11 committed rGfb6a5237aa73: Revert "[IR] Ignore bitcasts of function pointers which are only used as… (authored by jansvoboda11).
Revert "[IR] Ignore bitcasts of function pointers which are only used as…
Tue, Apr 6, 7:34 AM
jansvoboda11 added a reverting change for D98884: [IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction: rGfb6a5237aa73: Revert "[IR] Ignore bitcasts of function pointers which are only used as….
Tue, Apr 6, 7:34 AM · Restricted Project
jansvoboda11 committed rG2935737da32d: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line… (authored by jansvoboda11).
[clang][tooling] Create SourceManager for DiagnosticsEngine before command-line…
Tue, Apr 6, 1:41 AM
jansvoboda11 closed D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing.
Tue, Apr 6, 1:41 AM · Restricted Project
jansvoboda11 added inline comments to D99683: [HIP] Support ThinLTO.
Tue, Apr 6, 1:31 AM · Restricted Project
jansvoboda11 committed rGcc26943313de: [clang][cli] Ensure plugin args are generated in deterministic order (authored by jansvoboda11).
[clang][cli] Ensure plugin args are generated in deterministic order
Tue, Apr 6, 12:25 AM
jansvoboda11 closed D99879: [clang][cli] Ensure plugin args are generated in deterministic order.
Tue, Apr 6, 12:24 AM · Restricted Project

Mon, Apr 5

jansvoboda11 added a comment to D97462: [clang][cli] Round-trip cc1 arguments in assert builds.

Thanks for reporting that. D99606 fixes one aspect of -plugin-arg, but it seems the order of generation is non-deterministic (most likely related to the underlying storage, std::unordered_map). I can look into it early next week, but I think simple sort in the generation code should do the trick.

Can/should it just be changed to a std::map?

Mon, Apr 5, 3:20 AM · Restricted Project
jansvoboda11 requested review of D99879: [clang][cli] Ensure plugin args are generated in deterministic order.
Mon, Apr 5, 3:18 AM · Restricted Project

Fri, Apr 2

jansvoboda11 added a comment to D97462: [clang][cli] Round-trip cc1 arguments in assert builds.

In Chrome we noticed that plugin flags are not being roundtripped (and build fails with error: Generated arguments do not match in round-trip):

example of the differing args:

"-plugin-arg-blink-gc-plugin"
"no-members-in-stack-allocated"
"-plugin-arg-find-bad-constructs"
"checked-ptr-as-trivial-member"
"-plugin-arg-find-bad-constructs"
"check-ipc"

vs

"-plugin-arg-find-bad-constructs"
"checked-ptr-as-trivial-member"
"-plugin-arg-find-bad-constructs"
"check-ipc"
"-plugin-arg-blink-gc-plugin"
"no-members-in-stack-allocated"
Fri, Apr 2, 10:02 AM · Restricted Project
jansvoboda11 added inline comments to D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1.
Fri, Apr 2, 1:14 AM · Restricted Project, Restricted Project

Wed, Mar 31

jansvoboda11 added a comment to D99568: [clang] Fix copy constructor of CompilerInvocation.

I'm not sure a deep copy is entirely sound, due to odd ownership rules in "remapped buffers" (I forget the subclass that includes those). A few months ago I got most of the way to deleting those (lifting the logic up into the clang tooling that needed it)... maybe we need to push that work over the line before this is safe... or if this is in fact safe, can you explain why?

Wed, Mar 31, 2:44 AM · Restricted Project

Tue, Mar 30

jansvoboda11 accepted D99606: [clang][cli] Fix round-trip of OPT_plugin_arg.

LGTM, thanks!

Tue, Mar 30, 10:17 AM · Restricted Project
jansvoboda11 requested review of D99568: [clang] Fix copy constructor of CompilerInvocation.
Tue, Mar 30, 2:05 AM · Restricted Project

Sat, Mar 27

jansvoboda11 committed rGbb88a5aeee68: [clang][cli] Round-trip cc1 arguments in assert builds (authored by jansvoboda11).
[clang][cli] Round-trip cc1 arguments in assert builds
Sat, Mar 27, 9:24 AM
jansvoboda11 closed D97462: [clang][cli] Round-trip cc1 arguments in assert builds.
Sat, Mar 27, 9:24 AM · Restricted Project
jansvoboda11 updated the summary of D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing.
Sat, Mar 27, 2:19 AM · Restricted Project

Fri, Mar 26

jansvoboda11 added a comment to D84673: [clang][cli] Port DiagnosticOpts to new option parsing system.

Sorry for taking so long. I created a patch that should fix the missing SourceManager: D99414

Fri, Mar 26, 5:40 AM · Restricted Project, Restricted Project
jansvoboda11 requested review of D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing.
Fri, Mar 26, 5:38 AM · Restricted Project

Thu, Mar 25

jansvoboda11 added inline comments to D99305: [docs] Document our norms around reverts.
Thu, Mar 25, 1:03 AM · Restricted Project

Wed, Mar 24

jansvoboda11 added inline comments to D99245: [Driver] Add -fno-split-stack.
Wed, Mar 24, 6:14 AM · Restricted Project
jansvoboda11 committed rG772e9f88dd78: [clang][deps] NFC: Document collector, rename members (authored by jansvoboda11).
[clang][deps] NFC: Document collector, rename members
Wed, Mar 24, 3:59 AM
jansvoboda11 closed D98950: [clang][deps] NFC: Document collector, rename members.
Wed, Mar 24, 3:59 AM · Restricted Project
jansvoboda11 committed rG3190cf201751: [clang][deps] NFC: Extract ModuleID struct (authored by jansvoboda11).
[clang][deps] NFC: Extract ModuleID struct
Wed, Mar 24, 3:58 AM
jansvoboda11 closed D98943: [clang][deps] NFC: Extract ModuleID struct.
Wed, Mar 24, 3:57 AM · Restricted Project
jansvoboda11 added inline comments to D99245: [Driver] Add -fno-split-stack.
Wed, Mar 24, 3:51 AM · Restricted Project
jansvoboda11 added a comment to D97462: [clang][cli] Round-trip cc1 arguments in assert builds.

How expensive are these checks? If it is non-trivial overhead, maybe it should default to ${LLVM_ENABLE_EXPENSIVE_CHECKS} instead?

Wed, Mar 24, 3:36 AM · Restricted Project
jansvoboda11 abandoned D95516: [clang][cli] Benchmark command line round-trip.
Wed, Mar 24, 3:25 AM · Restricted Project
jansvoboda11 updated the summary of D95516: [clang][cli] Benchmark command line round-trip.
Wed, Mar 24, 3:24 AM · Restricted Project
jansvoboda11 updated the diff for D95516: [clang][cli] Benchmark command line round-trip.

Benchmark compilation and preprocessing as well

Wed, Mar 24, 2:30 AM · Restricted Project
jansvoboda11 resigned from D82547: [Debugify] Expose original debug info preservation check as CC1 option.

Thanks for the update. Changes touching the command line LGTM, but I'll let others confirm the changes to CodeGen are fine too.

Wed, Mar 24, 2:27 AM · Restricted Project, Restricted Project, debug-info
jansvoboda11 added a comment to D99245: [Driver] Add -fno-split-stack.

Adding the negative option to the driver makes sense to me. I think we could also simplify the option definitions, see my inline comment.

Wed, Mar 24, 2:17 AM · Restricted Project

Tue, Mar 23

jansvoboda11 requested changes to D82547: [Debugify] Expose original debug info preservation check as CC1 option.
Tue, Mar 23, 2:37 AM · Restricted Project, Restricted Project, debug-info

Mar 19 2021

jansvoboda11 updated the summary of D98950: [clang][deps] NFC: Document collector, rename members.
Mar 19 2021, 7:14 AM · Restricted Project
jansvoboda11 requested review of D98950: [clang][deps] NFC: Document collector, rename members.
Mar 19 2021, 7:13 AM · Restricted Project
jansvoboda11 requested review of D98943: [clang][deps] NFC: Extract ModuleID struct.
Mar 19 2021, 5:29 AM · Restricted Project

Mar 18 2021

jansvoboda11 removed a reviewer for D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist: jansvoboda11.
Mar 18 2021, 6:14 AM · Restricted Project
jansvoboda11 removed a reviewer for D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.: jansvoboda11.
Mar 18 2021, 6:13 AM · Restricted Project