Page MenuHomePhabricator

aaron.ballman (Aaron Ballman)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 14 2013, 3:16 PM (421 w, 4 d)

Recent Activity

Yesterday

aaron.ballman added a comment to D93822: [clang-tidy] Add check for implicit widening of multiplication result.

FWIW, it looks like tests are still failing on Windows according to the CI pipeline.

Mon, Apr 12, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Mon, Apr 12, 8:31 AM · Restricted Project, Restricted Project
aaron.ballman accepted D97683: [clang-tidy] Add <utility> include to misc-uniqueptr-reset-release.

LGTM, thanks!

Mon, Apr 12, 8:20 AM · Restricted Project, Restricted Project

Fri, Apr 9

aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Fri, Apr 9, 12:12 PM · Restricted Project
aaron.ballman added reviewers for D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes: rsmith, erichkeane.

Thank you for this patch, I think it's really useful functionality for plugin authors!

Fri, Apr 9, 6:38 AM · Restricted Project
aaron.ballman added a comment to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..

Mostly just nits from me, but the attribute portions look good to me.

Fri, Apr 9, 5:55 AM · Restricted Project
aaron.ballman added inline comments to D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.
Fri, Apr 9, 5:01 AM · Restricted Project
aaron.ballman accepted D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges.

This continues to LGTM, so I'm accepting it. If @alexfh has any remaining concerns, hopefully he can raise them quickly or we can handle them post-commit. Thanks!

Fri, Apr 9, 4:57 AM · Restricted Project, Restricted Project
aaron.ballman accepted D100136: Allow applying attributes to subset of allowed subjects..

LGTM!

Fri, Apr 9, 3:43 AM · Restricted Project

Thu, Apr 8

aaron.ballman added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

FWIW, this now causes Clang to produce an error on this code, when it didn't before:

using namespace::foo __attribute__((deprecated("message")));

I discussed this with Richard Smith, who points out that GCC does not accept this and it's not permitted according to the C++ standard, so this should probably be considered an accidental fix of a longstanding bug. With that said, would it be useful to add this as a tested case?

Thu, Apr 8, 1:11 PM · Restricted Project
aaron.ballman added a comment to D99877: [Clang] Allow processing of attributes on statements by plugins.

Thank you for the patch! Btw, can you add more context to the patch when you generate it (I usually use -U 999 when making patches)?

Thu, Apr 8, 10:27 AM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Thu, Apr 8, 9:34 AM · Restricted Project
aaron.ballman added inline comments to D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.
Thu, Apr 8, 9:22 AM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Thu, Apr 8, 7:29 AM · Restricted Project

Wed, Apr 7

aaron.ballman added a comment to D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures..

Where would be a good place for testing refersToDefaultCapture support?

Wed, Apr 7, 1:18 PM · Restricted Project, Restricted Project
aaron.ballman committed rG028092eb613e: Correct the tablegen logic for MutualExclusions attribute checking. (authored by aaron.ballman).
Correct the tablegen logic for MutualExclusions attribute checking.
Wed, Apr 7, 11:04 AM

Tue, Apr 6

aaron.ballman added a comment to D99825: [cmake] Enable -Werror=return-type for clang.

Unlike in C, in C++, flowing off the end of a non-void function other than main results in undefined behavior even when the value of the function is not used.

Tue, Apr 6, 2:51 PM · Restricted Project
aaron.ballman added inline comments to D90188: Add support for attribute 'using_if_exists'.
Tue, Apr 6, 2:26 PM
aaron.ballman accepted D99991: [docs] Update documentation for bugprone-misplaced-widening-cast.

LGTM, thank you!

Tue, Apr 6, 2:11 PM · Restricted Project
aaron.ballman requested review of D99983: Provide TreeTransform::TransformAttr the transformed statement; NFC.
Tue, Apr 6, 11:53 AM · Restricted Project
aaron.ballman added a comment to D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes.

I think the behavior is correct, but I do think the original diagnostic was somewhat better -- an attribute list *can* appear there, if you're lucky. Of course, the old diagnostic isn't great either because adding a ; after the attribute isn't going to improve the situation for the user. So I think I'm actually fine either way, but maybe @rsmith has a preference.

Tue, Apr 6, 11:22 AM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Tue, Apr 6, 4:26 AM · Restricted Project
aaron.ballman added inline comments to D99896: Rework the way statement attributes are processed; NFC.
Tue, Apr 6, 4:23 AM · Restricted Project
aaron.ballman committed rG65c22acfa4a4: Silence -Woverloaded-virtual warnings from generated code; NFC (authored by aaron.ballman).
Silence -Woverloaded-virtual warnings from generated code; NFC
Tue, Apr 6, 4:19 AM

Mon, Apr 5

aaron.ballman closed D99896: Rework the way statement attributes are processed; NFC.

I've commit in 9711118d2edf7aed133616de1eb7f633c263c4b5, thanks for the really quick reviews!

Mon, Apr 5, 2:53 PM · Restricted Project
aaron.ballman committed rG9711118d2edf: Rework the way statement attributes are processed; NFC (authored by aaron.ballman).
Rework the way statement attributes are processed; NFC
Mon, Apr 5, 2:52 PM
aaron.ballman added inline comments to D99896: Rework the way statement attributes are processed; NFC.
Mon, Apr 5, 2:50 PM · Restricted Project
aaron.ballman added a comment to D99896: Rework the way statement attributes are processed; NFC.

It is really sad that the attributes can't 'auto transform' themselves. ParsedAttr could (since it has a union of expressions/identifiers), but we don't really seem to have a good way to do it for Attr.

Could we possibly do some table-gen to auto create the 'simple' ones? Basically, any parameter to an attribute that is an 'expr' gets auto-transformed? Similar to how we have handleSimpleAttr, we could have TransformSimpleAttr (or, a generated one).

Mon, Apr 5, 1:18 PM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Mon, Apr 5, 1:08 PM · Restricted Project
aaron.ballman requested review of D99896: Rework the way statement attributes are processed; NFC.
Mon, Apr 5, 1:08 PM · Restricted Project
aaron.ballman added reviewers for D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema: rsmith, Quuxplusone, rjmccall.

Adding a few more reviewers for early feedback.

Mon, Apr 5, 12:34 PM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Mon, Apr 5, 12:15 PM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Mon, Apr 5, 7:30 AM · Restricted Project

Sun, Apr 4

aaron.ballman committed rG241d42c38226: Speculative fix for failing build bot. (authored by aaron.ballman).
Speculative fix for failing build bot.
Sun, Apr 4, 8:00 AM
aaron.ballman added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

The test fails on macOS: http://45.33.8.238/macm1/6821/step_6.txt

Please take a look and revert for now if it takes a while to fix.

Sun, Apr 4, 8:00 AM · Restricted Project
aaron.ballman added inline comments to D93822: [clang-tidy] Add check for implicit widening of multiplication result.
Sun, Apr 4, 7:22 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Sun, Apr 4, 6:30 AM · Restricted Project

Sat, Apr 3

aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Sat, Apr 3, 9:36 AM · Restricted Project
aaron.ballman added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Thank you for the additional test case, this LGTM again.

Sat, Apr 3, 9:25 AM · Restricted Project

Fri, Apr 2

aaron.ballman closed D99809: Use tablegen to diagnose mutually exclusive attributes.

Committed in 4be8a26951da9a6e04de327b38dd158f4c8e3280

Fri, Apr 2, 1:35 PM · Restricted Project
aaron.ballman accepted D99809: Use tablegen to diagnose mutually exclusive attributes.

Accepting on my own authority so I can close in a moment.

Fri, Apr 2, 1:35 PM · Restricted Project
aaron.ballman committed rG4be8a26951da: Use tablegen to diagnose mutually exclusive attributes (authored by aaron.ballman).
Use tablegen to diagnose mutually exclusive attributes
Fri, Apr 2, 1:35 PM
aaron.ballman updated the diff for D99809: Use tablegen to diagnose mutually exclusive attributes.

Correcting lint warnings, adding documentation for the new feature.

Fri, Apr 2, 1:29 PM · Restricted Project
aaron.ballman added a comment to D99809: Use tablegen to diagnose mutually exclusive attributes.

@rsmith -- I am posting the review so that I can see how the CI pipeline likes the functionality (because this impacts so many different attributes), but I intend to commit it on my own authority once CI passes. Feel free to review it if you'd like and I'll address any concerns you have post-commit.

Fri, Apr 2, 11:57 AM · Restricted Project
aaron.ballman requested review of D99809: Use tablegen to diagnose mutually exclusive attributes.
Fri, Apr 2, 11:55 AM · Restricted Project
aaron.ballman added inline comments to D75844: [clang] Set begin loc on GNU attribute parsed attrs.
Fri, Apr 2, 10:49 AM · Restricted Project
aaron.ballman committed rG3ebfa363f356: Remove attribute handling code for simple attributes; NFC (authored by aaron.ballman).
Remove attribute handling code for simple attributes; NFC
Fri, Apr 2, 8:35 AM

Thu, Apr 1

aaron.ballman added a comment to D93822: [clang-tidy] Add check for implicit widening of multiplication result.

The CI is showing build failures and there are some clang-tidy nits to be addressed as well.

Thu, Apr 1, 8:54 AM · Restricted Project, Restricted Project, Restricted Project
aaron.ballman added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Damn. Reverted again for the time being. The libc++ build seems to fail and I won't have time to look into that this week. :(

Thu, Apr 1, 8:37 AM · Restricted Project
aaron.ballman added inline comments to D93095: Introduce -Wreserved-identifier.
Thu, Apr 1, 7:49 AM
aaron.ballman accepted D75844: [clang] Set begin loc on GNU attribute parsed attrs.

LGTM!

Thu, Apr 1, 7:01 AM · Restricted Project
aaron.ballman added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

Thank you for picking this back up!

Thu, Apr 1, 5:12 AM · Restricted Project

Wed, Mar 31

aaron.ballman added inline comments to D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions.
Wed, Mar 31, 11:12 AM · Restricted Project, Restricted Project
aaron.ballman accepted D97362: [clang][parser] Allow attributes in explicit template instantiations.

LGTM, thank you for the fixes!

Wed, Mar 31, 6:07 AM · Restricted Project
aaron.ballman accepted D99456: [C++2b] Support size_t literals.

LGTM, thank you for the patch!

Wed, Mar 31, 6:05 AM · Restricted Project
aaron.ballman added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Wed, Mar 31, 5:48 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D99456: [C++2b] Support size_t literals.

Generally LGTM but I did have a question about the feature testing macro.

Wed, Mar 31, 5:27 AM · Restricted Project

Tue, Mar 30

aaron.ballman added a comment to D97362: [clang][parser] Allow attributes in explicit template instantiations.

Thanks for merging, I think this seems reasonable but is missing some test coverage still.

Tue, Mar 30, 11:16 AM · Restricted Project
aaron.ballman added inline comments to D93095: Introduce -Wreserved-identifier.
Tue, Mar 30, 8:55 AM
aaron.ballman added a comment to D99278: [clang][parser] Allow GNU-style attributes in struct declarations.

This (and https://reviews.llvm.org/D99338) are both NFC changes once https://reviews.llvm.org/D97362 lands (they need the three-parameter version of ProhibitCXX11Attributes()). I can merge the three into one patch if you prefer.

Tue, Mar 30, 8:38 AM · Restricted Project
aaron.ballman added inline comments to D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Tue, Mar 30, 7:11 AM · Restricted Project
aaron.ballman accepted D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list.

LGTM aside from the test case commenting nit. Thank you!

Tue, Mar 30, 4:43 AM · Restricted Project

Mon, Mar 29

aaron.ballman accepted D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

LGTM with a minor improvement for attribute ordering.

Mon, Mar 29, 1:48 PM
aaron.ballman added a comment to D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list.

Mostly looks good, just a few things with the tests.

Mon, Mar 29, 1:25 PM · Restricted Project
aaron.ballman added a comment to D99338: [clang][parser] Allow GNU-style attributes in enum specifiers.

To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to that review and so that we get appropriate CI pre-merge testing.

Mon, Mar 29, 9:40 AM · Restricted Project
aaron.ballman added a comment to D99278: [clang][parser] Allow GNU-style attributes in struct declarations.

To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to that review and so that we get appropriate CI pre-merge testing.

Mon, Mar 29, 9:40 AM · Restricted Project
aaron.ballman added a comment to D99488: [SYCL][Doc] Add address space handling section to SYCL documentation.

Mostly grammar related review comments, nothing substantive.

Mon, Mar 29, 9:02 AM · Restricted Project
aaron.ballman requested changes to D99456: [C++2b] Support size_t literals.

Thanks for working on this! I think the direction is good in general, but I think we should also add tests for use in the preprocessor (#if 1z == 1, etc) as well as tests for the behavior in C.

Mon, Mar 29, 7:53 AM · Restricted Project
aaron.ballman added inline comments to D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list.
Mon, Mar 29, 7:27 AM · Restricted Project

Sun, Mar 28

aaron.ballman committed rG581b429f7d41: Update the documentation for recent changes to statement attributes. (authored by aaron.ballman).
Update the documentation for recent changes to statement attributes.
Sun, Mar 28, 6:55 AM

Fri, Mar 26

aaron.ballman added a comment to D73967: Implement _ExtInt as an extended int type specifier..

An FPGA programmer is hitting this issue from your unit test:

c++
  signed _ExtInt(1) m; // expected-error{{signed _ExtInt must have a bit size of at least 2}}

Why do you not allow a type able to represent {-1, 0}?

Fri, Mar 26, 10:33 AM · Restricted Project

Thu, Mar 25

aaron.ballman closed D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.

Do you need me to commit on your behalf? If so, which email address would you like me to use for attribution?

Yeah, I do not have commit access. davidfromonline@gmail.com, please

Thu, Mar 25, 2:28 PM · Restricted Project
aaron.ballman committed rG4b5baa5b8244: Handle 128-bits IntegerLiterals in StmtPrinter (authored by davidstone).
Handle 128-bits IntegerLiterals in StmtPrinter
Thu, Mar 25, 2:28 PM
aaron.ballman added a comment to D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.

Do you need me to commit on your behalf? If so, which email address would you like me to use for attribution?

Thu, Mar 25, 11:31 AM · Restricted Project
aaron.ballman closed D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

It's been a while and I almost don't remember what this is. But it was a good fix and there is one LGTM.
Can someone please commit this? Alexander Lanin <alex@lanin.de>
Thanks!

Thu, Mar 25, 6:46 AM · Restricted Project, Restricted Project
aaron.ballman committed rG0becc4d721d0: fix readability-braces-around-statements Stmt type dependency (authored by AlexanderLanin).
fix readability-braces-around-statements Stmt type dependency
Thu, Mar 25, 6:46 AM
aaron.ballman accepted D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.

LGTM, thanks!

Thu, Mar 25, 6:39 AM · Restricted Project
aaron.ballman added inline comments to D99291: [AIX] Support init priority attribute.
Thu, Mar 25, 6:36 AM · Restricted Project

Wed, Mar 24

aaron.ballman added inline comments to D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process.
Wed, Mar 24, 12:25 PM · Restricted Project, Restricted Project
aaron.ballman accepted D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process.

LGTM, thanks!

Wed, Mar 24, 12:07 PM · Restricted Project, Restricted Project
aaron.ballman added inline comments to D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'..
Wed, Mar 24, 11:41 AM · Restricted Project, Restricted Project
aaron.ballman added a comment to D98747: Thread safety analysis: Don't warn about managed locks on join points.

I'd really like to hear from @delesley about these changes, specifically because of this bit:

Wed, Mar 24, 9:19 AM · Restricted Project
aaron.ballman accepted D98724: Fix false negative in -Wthread-safety-attributes.

LGTM, thanks!

Wed, Mar 24, 8:59 AM · Restricted Project
aaron.ballman accepted D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ()..

LGTM, thank you!

Wed, Mar 24, 6:12 AM · Restricted Project
aaron.ballman accepted D97362: [clang][parser] Allow attributes in explicit template instantiations.

I think this basically LGTM with a few minor nits, but I'd like to make sure @rsmith doesn't have concerns, so please wait a few days before landing in case he wants to chime in.

Wed, Mar 24, 6:06 AM · Restricted Project

Tue, Mar 23

aaron.ballman accepted D99180: [clang-tidy] Ignore all spaces in the list of checks.

LGTM!

Tue, Mar 23, 9:09 AM · Restricted Project, Restricted Project
aaron.ballman accepted D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor.

LGTM!

Tue, Mar 23, 8:43 AM · Restricted Project
aaron.ballman added inline comments to D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ()..
Tue, Mar 23, 6:03 AM · Restricted Project
aaron.ballman accepted D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

LGTM!

Tue, Mar 23, 5:30 AM · Restricted Project
aaron.ballman added inline comments to D97362: [clang][parser] Allow attributes in explicit template instantiations.
Tue, Mar 23, 5:30 AM · Restricted Project

Mon, Mar 22

aaron.ballman closed D72235: [clang-tidy] new altera unroll loops check.

Thanks! I've commit on your behalf in 5a87f81fe9aee996dfe3a84dd833f0a48e093e7f

Mon, Mar 22, 10:11 AM · Restricted Project, Restricted Project
aaron.ballman committed rG5a87f81fe9ae: new altera unroll loops check (authored by ffrankies).
new altera unroll loops check
Mon, Mar 22, 10:10 AM
aaron.ballman added a comment to D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing.

Windows exceptions code-generation is quite different; I don't know whether Clang supports ObjC on Windows in general. It'd be fine if you add a -triple argument to this test.

Mon, Mar 22, 10:03 AM · Restricted Project
aaron.ballman accepted D55212: Handle alloc_size attribute on function pointers.

I think folks will have a chance to react if we apply it to trunk now, but I am wondering if anyone's had a chance to investigate usage in the wild. @erik.pilkington or @dexonsmith, do either of you have a gut feeling?

I don't see any uses of #pca with alloc_size in our internal codebase. IMO I'd be really quite surprised if anyone actually used these two features together.

Mon, Mar 22, 8:04 AM · Restricted Project
aaron.ballman added a comment to D55212: Handle alloc_size attribute on function pointers.

I completely forgot about this patch. @aaron.ballman are you still happy for me to commit this?

Mon, Mar 22, 7:09 AM · Restricted Project
aaron.ballman added inline comments to D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ()..
Mon, Mar 22, 5:45 AM · Restricted Project
aaron.ballman added inline comments to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Mon, Mar 22, 4:57 AM · Restricted Project

Sun, Mar 21

aaron.ballman accepted D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).

LGTM, thank you!

Sun, Mar 21, 6:48 AM · Restricted Project
aaron.ballman added inline comments to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Sun, Mar 21, 6:41 AM · Restricted Project
aaron.ballman added inline comments to D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level).
Sun, Mar 21, 6:31 AM · Restricted Project