Page MenuHomePhabricator

h-vetinari (H. Vetinari)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2021, 6:33 AM (74 w, 4 d)

Recent Activity

Thu, Feb 2

h-vetinari added a comment to D143196: [Libomptarget] Remove dependency on the DeviceRTL from the GPU plugins.

Thanks for this!

Thu, Feb 2, 4:19 PM · Restricted Project, Restricted Project

Tue, Jan 24

h-vetinari added inline comments to D139771: [libc++][chrono] Add hh_mm_ss formatter..
Tue, Jan 24, 4:20 PM · Restricted Project, Restricted Project
h-vetinari added inline comments to D142063: [libc++][ranges] implement `std::ranges::split_view` (targeting llvm 16).
Tue, Jan 24, 1:11 AM · Restricted Project, Restricted Project

Mon, Jan 23

h-vetinari added a comment to rG12cb1cb3720d: Revert "[clang] Instantiate concepts with sugared template arguments".

Urgh, REALLY!? This is a revert of a serious memory regression. I think I'll need some level of more information? I'm not sure what is going on with it? @ChuanqiXu is one of my modules code owners, and perhaps sees something obvious?

Mon, Jan 23, 8:40 PM · Restricted Project, Restricted Project

Mon, Jan 16

h-vetinari added a comment to D124739: [libc++] Add Mathematical Special Functions status page.

Cool!

Mon, Jan 16, 8:23 PM · Restricted Project, Restricted Project
h-vetinari added a comment to D124739: [libc++] Add Mathematical Special Functions status page.

Why abandon this revision? Wouldn't it be useful for this issue to have more visibility rather than less?

Mon, Jan 16, 8:19 PM · Restricted Project, Restricted Project
h-vetinari added inline comments to D141821: [C++20] [Modules] Deprecate `-fmodules-ts` flag.
Mon, Jan 16, 2:56 AM · Restricted Project

Sun, Jan 15

h-vetinari added a comment to D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4).

Sorry for the misleading and thanks for the quick clarification. So it looks like the status quo is a little bit worse than I imaged...

Sun, Jan 15, 7:37 PM · Restricted Project, Restricted Project
h-vetinari added a comment to D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4).

@h-vetinari said it should be OK to backport these patches to branched 16.x.

Sun, Jan 15, 6:55 PM · Restricted Project, Restricted Project

Thu, Jan 12

h-vetinari added inline comments to D137058: [Driver] [Modules] Support -fmodule-output (1/2).
Thu, Jan 12, 4:58 PM · Restricted Project, Restricted Project, Restricted Project

Jan 8 2023

h-vetinari added a comment to D137058: [Driver] [Modules] Support -fmodule-output (1/2).

BTW, the series of clang-scan-deps patch (https://reviews.llvm.org/D139168) is also necessary [...]

Jan 8 2023, 6:56 PM · Restricted Project, Restricted Project, Restricted Project

Jan 7 2023

h-vetinari added a comment to D137058: [Driver] [Modules] Support -fmodule-output (1/2).

Without undue haste, I just wanted to comment from the peanut gallery that it would be amazing if the patches that are necessary for CMake + Clang to use C++ modules would make the cut-off for LLVM 16 that's coming up around the 24th of January.

Jan 7 2023, 6:28 PM · Restricted Project, Restricted Project, Restricted Project

Dec 25 2022

h-vetinari added a comment to D140632: [NFC][libc++] Removes concepts tests..

Clang trunk doesn't claim support: https://godbolt.org/z/hes3nah8s. I'm actually quite surprised this doesn't break the CI. I remember having problems with at least Clang 15 when trying to use conditionally trivial special member functions.

Dec 25 2022, 7:42 PM · Restricted Project, Restricted Project

Dec 9 2022

h-vetinari added inline comments to D137058: [Driver] [Modules] Support -fmodule-output (1/2).
Dec 9 2022, 8:54 PM · Restricted Project, Restricted Project, Restricted Project

Dec 4 2022

h-vetinari added a comment to D139212: [Clang] make_cxx_dr_status download the issue list automatically.

I've had a small nit/suggestion post-merge of https://reviews.llvm.org/D138901; in case you feel it's worth picking up if you're touching that file already.

Dec 4 2022, 3:10 AM · Restricted Project, Restricted Project

Nov 30 2022

h-vetinari added a comment to D138901: [clang] Propely handle tests for open DRs in make_cxx_dr_status.

I'd also use newlines more liberally since the two-space indentation is pretty dense already.

Nov 30 2022, 5:38 PM · Restricted Project, Restricted Project

Nov 21 2022

h-vetinari added a comment to D120186: [pstl] Implementation of Grand Central Dispatch backend.

@nadiasvertex
Any update on this?

Nov 21 2022, 7:48 PM · Restricted Project, Restricted Project

Oct 27 2022

h-vetinari added a comment to D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters.

Congratulations for landing this!

Oct 27 2022, 6:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

h-vetinari added inline comments to D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters.
Oct 26 2022, 6:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 25 2022

h-vetinari added a comment to D136657: [libc++][ranges][NFC] Revamp the Ranges status page.

Drive-by comments for consistency

Oct 25 2022, 8:16 PM · Restricted Project, Restricted Project

Oct 18 2022

h-vetinari added inline comments to D134036: [libc++][format] Implements string escaping..
Oct 18 2022, 10:16 PM · Restricted Project, Restricted Project
h-vetinari added inline comments to D134742: [libc++][chrono] Implements formatter duration..
Oct 18 2022, 10:05 PM · Restricted Project, Restricted Project

Sep 26 2022

h-vetinari added a comment to D134283: [clang][DR2621] using enum NAME lookup fix.

Seems DR2621 is not yet listed in https://github.com/llvm/llvm-project/blob/main/clang/www/cxx_dr_status.html (but if it were, it should be updated...)

Sep 26 2022, 2:26 AM · Restricted Project, Restricted Project

Sep 22 2022

h-vetinari added a comment to D133853: [AST] Add msvc-specific C++11 attributes.

Now I'm wondering why the attribute exists at all. If it's functionally equivalent to constexpr as a keyword, what are the use cases for the attribute?

Sep 22 2022, 10:11 AM · Restricted Project, Restricted Project

Sep 21 2022

h-vetinari added a comment to D133853: [AST] Add msvc-specific C++11 attributes.

I am afraid it would take me some effort to implement semantics of [[msvc::no_unique_address]], so I'd like to focus only on [[msvc::constexpr]] in current patch.

Sep 21 2022, 3:34 AM · Restricted Project, Restricted Project

Aug 25 2022

h-vetinari added a comment to D131388: [docs] Add "Standard C++ Modules".

Replace C++20 Modules with Standard C++ Modules since @ruoso pointed out that Modules is not specific to certain versions of C++ (for example, Modules may get some big changes in C++23, C++26, ...).

Aug 25 2022, 3:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION.

I have another question, probably mainly for @tstellar (since I don't understand the clang/tools/libclang/libclang.{exports,map} infrastructure). Now that we're defaulting back to the equality case, would we need to reinstate libclang.exports (probably conditional on CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION == ON)?

Aug 25 2022, 1:00 AM · Restricted Project, Restricted Project
h-vetinari added inline comments to D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION.
Aug 25 2022, 12:52 AM · Restricted Project, Restricted Project

Aug 23 2022

h-vetinari added a reviewer for D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION: aaronpuchert.
Aug 23 2022, 10:49 PM · Restricted Project, Restricted Project
h-vetinari added a comment to D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION.

My concerns have already been raised by others in that thread and related issues, I see no point in restating them yet again. I don't see consensus, I see a handful of people discussing reverting a change that broke a whole bunch of assumptions made by real-world code.

Aug 23 2022, 2:09 PM · Restricted Project, Restricted Project
h-vetinari added a comment to D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION.

Thanks for the review. Given that you have concerns, could you voice them in a larger forum (https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground-to-keep-it-behind-option/64410), where so far the direction was in favour of going back to the status of LLVM 14 (but with an opt-out for those who prefer equality).

Aug 23 2022, 12:31 PM · Restricted Project, Restricted Project
h-vetinari added reviewers for D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION: tstellar, isuruf.
Aug 23 2022, 10:26 AM · Restricted Project, Restricted Project
h-vetinari added a comment to D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION.

IMO looks good, thanks!

Aug 23 2022, 10:25 AM · Restricted Project, Restricted Project

Aug 22 2022

h-vetinari added a comment to D123968: docs: Add instructions for stand-alone builds of clang.

Sorry it took me a while to respond, was AFK last week. This looks like a good start, I can try testing the instructions with the LLVM 15 builds (also RCs) and report back with what I find.

Aug 22 2022, 2:20 PM · Restricted Project, Restricted Project

Aug 11 2022

h-vetinari added a comment to D129160: libclang.so: Make SONAME the same as LLVM version.

Maybe this should be a cmake option that is off by default and I can turn it for my builds?

Aug 11 2022, 11:18 AM · Restricted Project, Restricted Project
h-vetinari added a comment to D123967: Disable update_cc_test_checks.py tests in stand-alone builds.

LGTM

Aug 11 2022, 12:36 AM · Restricted Project, Restricted Project

Aug 9 2022

h-vetinari added a comment to rGe64025045457: Update the C status page from the latest working draft.

Are the rowspans here correct? For some reason https://clang.llvm.org/c_status.html is not being updated with this change.

Aug 9 2022, 2:41 AM · Restricted Project, Restricted Project
h-vetinari added inline comments to D131317: [libc++] Implements constexpr <charconv>..
Aug 9 2022, 1:09 AM · Restricted Project, Restricted Project

Aug 8 2022

h-vetinari added inline comments to D131062: [docs] Add "C++20 Modules".
Aug 8 2022, 3:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D131388: [docs] Add "Standard C++ Modules".

Thanks! Repeating a point that might have been overlooked from D131062 (this time not as comments in the diff to avoid the "pollution" that caused the move to this PR):

If you do open a new revision, please also consider breaking the lines at a length that phabricator doesn't overflow (seems to be 122 characters), and change all occurrences of "codes" to "code".

Aug 8 2022, 3:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added inline comments to D131062: [docs] Add "C++20 Modules".
Aug 8 2022, 2:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D131062: [docs] Add "C++20 Modules".

If you do open a new revision, please also consider breaking the lines at a length that phabricator doesn't overflow (seems to be 122 characters), and change all occurrences of "codes" to "code".

Aug 8 2022, 2:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D131062: [docs] Add "C++20 Modules".

Yeah, I am also worrying if the comments may block other reviewers to review. Do you know any method to ignore these comments in phab? If not, I guess I need to create a new page (but this is what we want?)

Aug 8 2022, 2:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D131062: [docs] Add "C++20 Modules".

It gets very confusing that phab now attaches the old review comments in the wrong place.

Aug 8 2022, 12:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 6 2022

h-vetinari added a comment to D131062: [docs] Add "C++20 Modules".

It would be greatly welcome for such comments!

Aug 6 2022, 3:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 4 2022

h-vetinari added a comment to D127194: [libc++][ranges] Implement `ranges::is_permutation`.

That was the last algorithm in RangesAlgorithms.csv - congratulations! :)

Aug 4 2022, 11:35 AM · Restricted Project, Restricted Project
h-vetinari added a comment to D131062: [docs] Add "C++20 Modules".

Aside from a couple typos, I was wondering if it would be welcome to do a pass w.r.t stylistic improvements (e.g. "Modules have a lot of meanings." --> "The term 'modules' has a lot of meanings"). I don't want to be too nit-picky - the sentences are all understandable, but sometimes slightly unusual to a native speaker in their formulation.

Aug 4 2022, 6:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D129859: [libc++][ranges] Implement `ranges::{prev, next}_permutation`.

There are still a few tests for these commented out, e.g. in:
libcxx/test/std/algorithms/ranges_robust_against_dangling.pass.cpp
libcxx/test/std/algorithms/ranges_robust_against_proxy_iterators.pass.cpp
libcxx/test/std/library/description/conventions/customization.point.object/niebloid.compile.pass.cpp

Aug 4 2022, 1:14 AM · Restricted Project, Restricted Project

Aug 1 2022

h-vetinari added a comment to D130827: [clang] Fixed a number of typos.

Thanks for chasing these down!

Aug 1 2022, 11:19 PM · Restricted Project, Restricted Project
h-vetinari added a comment to D130898: [IntelJITEvents] Add missing include..

Tested that this fixes the issue - thanks!

Aug 1 2022, 8:33 AM · Restricted Project, Restricted Project

Jul 29 2022

h-vetinari added a comment to D130689: [LLVM] Update C++ standard to 17.

My point boils down to: "written using standard C++17
code" does not sound at all like "core language, no stdlib", but very much like "core+stdlib".

Jul 29 2022, 1:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D130689: [LLVM] Update C++ standard to 17.

From the text you quoted:

Jul 29 2022, 1:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

h-vetinari added a comment to D130689: [LLVM] Update C++ standard to 17.

It may be worth calling out that this is about C++17 core language and not the standard library?

Jul 28 2022, 1:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to rG98d3d5b5da66: [libc++] Implement P1004R2 (constexpr std::vector).

The commit landed after LLVM 15 branched but still mentions that version in the release notes & CXX status. Is the intention that this'll be backported?

Jul 28 2022, 1:25 AM · Restricted Project, Restricted Project

Jul 25 2022

h-vetinari added a comment to D129160: libclang.so: Make SONAME the same as LLVM version.

@h-vetinari Does the release note look OK?

Jul 25 2022, 9:57 PM · Restricted Project, Restricted Project

Jul 23 2022

h-vetinari added a comment to D103198: [libc++] Add a CI configuration where we test the PSTL integration.

How realistic is it that this still makes it into LLVM 15? I'd really like to start testing the pstl in our ecosystem a bit, happy to file bug reports too if so, but I'd need a way to be able to build it...

Jul 23 2022, 12:49 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

h-vetinari added a comment to D126189: [C++20][Modules] Build module static initializers per P1874R1..

Is it realistic for this to land before LLVM 15 branches? Would be great!

Jul 19 2022, 3:48 AM · Restricted Project, Restricted Project

Jul 17 2022

h-vetinari added inline comments to D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions).
Jul 17 2022, 2:46 PM · Restricted Project, Restricted Project

Jul 14 2022

h-vetinari added a comment to D129195: [libc++] Implement P1423R3 (char8_t backward compatibility remediation).

Though you probably know, there's yet another DR on top of P1423 that has been accepted (only missing plenary vote): https://github.com/cplusplus/papers/issues/1171

Might be worth investigating to not needlessly introduce breakage that will then have to be undone again.

The paper you linked only changes core wording, so it shouldn't make any difference for the library part. Or am I missing something?

Jul 14 2022, 8:26 AM · Restricted Project, Restricted Project

Jul 13 2022

h-vetinari added a comment to D129195: [libc++] Implement P1423R3 (char8_t backward compatibility remediation).

Though you probably know, there's yet another DR on top of P1423 that has been accepted (only missing plenary vote): https://github.com/cplusplus/papers/issues/1171

Jul 13 2022, 11:28 PM · Restricted Project, Restricted Project
h-vetinari added a comment to D124739: [libc++] Add Mathematical Special Functions status page.

We're currently focusing on ranges to get as much as possible into LLVM15. After that I want to work on std::pmr.

Jul 13 2022, 5:12 AM · Restricted Project, Restricted Project
h-vetinari added a comment to D127570: [libc++][format] Use forwarding references..

This PR didn't update the format status page. Is the warning from C++20 status still current?

P0645: The paper is implemented but still marked as an incomplete feature (the feature-test macro is not set and the libary is only available when built with LIBCXX_ENABLE_INCOMPLETE_FEATURES). Not yet implemented LWG-issues will cause API and ABI breakage.

Jul 13 2022, 4:49 AM · Restricted Project, Restricted Project
h-vetinari added a comment to D124739: [libc++] Add Mathematical Special Functions status page.

Any update on this?

Jul 13 2022, 4:37 AM · Restricted Project, Restricted Project

Jul 12 2022

h-vetinari added a comment to D123967: Disable update_cc_test_checks.py tests in stand-alone builds.

Just comments, looks OK otherwise.

Jul 12 2022, 3:16 AM · Restricted Project, Restricted Project
h-vetinari added inline comments to D124079: [libc++] Implement ranges::find_end, ranges::search{, _n}.
Jul 12 2022, 2:38 AM · Restricted Project, Restricted Project

Jul 6 2022

h-vetinari added inline comments to D129138: [clang] [docs] Update the changes of C++20 Modules in clang15.
Jul 6 2022, 5:14 AM · Restricted Project, Restricted Project, Restricted Project
h-vetinari added a comment to D129160: libclang.so: Make SONAME the same as LLVM version.

Forgot to mention it before: would be good to note this in the release notes

Jul 6 2022, 1:36 AM · Restricted Project, Restricted Project

Jul 5 2022

h-vetinari added a comment to D129160: libclang.so: Make SONAME the same as LLVM version.

Thanks for the ping. It's unfortunate that this didn't work out as intended. It's certainly fine though (for our purposes) to go back to the way things were before.

Jul 5 2022, 10:42 PM · Restricted Project, Restricted Project

May 19 2022

h-vetinari added a comment to D121530: [libc++][format] Implement format-string..

Should probably be mentioned in the release notes...?

May 19 2022, 3:00 AM · Restricted Project, Restricted Project

May 17 2022

h-vetinari added a comment to D125788: [flang][driver] Rename `flang-new` as `flang`.

Very happy to see this finally happening! :)

May 17 2022, 10:15 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

Herald added a project to D89057: Add the C++17 <memory_resource> header (mono-patch): Restricted Project.
May 3 2022, 8:32 PM · Restricted Project, Restricted Project

Apr 27 2022

h-vetinari added a comment to D124524: [demangler] Avoid nullptr UB.

2x "Buffer cannot by nullptr" -> "Buffer cannot be nullptr"

Apr 27 2022, 9:03 PM · Restricted Project, Restricted Project

Apr 14 2022

Herald added a project to D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl".: Restricted Project.
Apr 14 2022, 11:17 PM · Restricted Project, Restricted Project, lld

Apr 13 2022

h-vetinari added a comment to D122008: [flang][driver] Add support for generating executables.

Speaking as a relative outside (but who's been waiting for flang in LLVM since well before it joined the monorepo), I'd much prefer code-generation-with-rough-edges in LLVM 15 (to start testing and raising eventual bugs), rather than a more polished flang (realistically still with bugs that need to be shaken out) in LLVM 16.

Apr 13 2022, 3:28 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

Herald added a project to D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.: Restricted Project.
Apr 7 2022, 1:46 AM · Restricted Project, Restricted Project
h-vetinari added inline comments to D122976: Bump minimum toolchain version.
Apr 7 2022, 1:36 AM · Restricted Project, Restricted Project

Mar 26 2022

Herald added a project to D110500: [libc++][format][6/6] Improve vformat.: Restricted Project.
Mar 26 2022, 2:53 PM · Restricted Project, Restricted Project

Mar 22 2022

h-vetinari added inline comments to D122256: [clang][ABI] New C++20 module mangling scheme.
Mar 22 2022, 5:23 PM · Restricted Project, Restricted Project

Mar 9 2022

h-vetinari added a comment to D118352: [clang][ABI] New c++20 modules mangling scheme.

Something must have gone wrong... communication-wise... as @urnathan seems to have abandoned (resp. resigned from) all modules PRs. Hope any misunderstandings or grievances can be worked out!

Mar 9 2022, 3:46 PM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D119544: Deferred Concept Instantiation Implementation: Restricted Project.
Mar 2 2022, 5:57 PM · Restricted Project, Restricted Project
Herald added a project to D110641: Implement P0857R0 -Part B: requires clause for template-template params: Restricted Project.
Mar 2 2022, 5:51 PM · Restricted Project

Feb 27 2022

h-vetinari added a comment to D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions..

A non-actionable comment out of curiosity for the work

Feb 27 2022, 4:01 PM · Restricted Project

Jan 24 2022

h-vetinari added a comment to D115999: [libc++][format] Finish P0645 Text Formatting..

Just a nit/note before LLVM 14 branches: a few bullets in FormatPaper.csv should probably now be updated as well.

Jan 24 2022, 6:17 PM · Restricted Project
h-vetinari added a comment to D115999: [libc++][format] Finish P0645 Text Formatting..

Congratulations on landing this huge piece of work, and even more so in time for LLVM 14!

Jan 24 2022, 11:42 AM · Restricted Project

Jan 13 2022

h-vetinari added a comment to D117230: [openmp][devicertl] Handle missing clang_tool.

Ah, just saw your comment to that exact effect in the meantime. :)

Jan 13 2022, 3:58 PM · Restricted Project
h-vetinari added a comment to D117230: [openmp][devicertl] Handle missing clang_tool.

OK, just taking the second half of the patch in openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt is actually enough for the backport.

Jan 13 2022, 3:57 PM · Restricted Project
h-vetinari added a comment to D117230: [openmp][devicertl] Handle missing clang_tool.

Thanks a lot for the patch! I'm trying to figure out how to apply this to 13.0.0-rc2, but it's not obvious since https://reviews.llvm.org/D111983 has happened in between and reshuffled a bunch of things around.

Jan 13 2022, 3:40 PM · Restricted Project

Nov 8 2021

h-vetinari added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Nov 8 2021, 1:22 AM · Restricted Project

Oct 23 2021

h-vetinari added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Oct 23 2021, 6:31 PM · Restricted Project

Oct 11 2021

h-vetinari added a comment to D88458: [CMake] Cache the compiler-rt library search results.

Given the cross-review of the respective authors, I'm assuming this is compatible / aligned with https://reviews.llvm.org/D111356? I ask because despite the mutual review, this wasn't mentioned in the email to LLVM-dev about the latter.

Oct 11 2021, 8:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 29 2021

h-vetinari added a comment to D110589: [IntelJITListener] Generalize JIT listener test.

I tested this patch in https://github.com/conda-forge/llvmdev-feedstock/pull/131 and it works as intended. Any blockers to landing it?

Sep 29 2021, 4:00 PM · Restricted Project