addressed review comments

fix not closed attributes declaration in a test file

Looks like lack of vscale_range attribute was causing div by 0 exception.

Could you change the commit message? or at least add [LoopLoadElim] ? it does not make clear that these are LoopLoadElimination tests.

It is a fix for https://github.com/llvm/llvm-project/issues/57083

In D127803#3693700, @jyu2 wrote:

In D127803#3693660, @ABataev wrote:

In D127803#3693655, @jyu2 wrote:

In D127803#3693301, @mgabka wrote:

I noticed that this patch is causing now an assertion failure for cases like :

class A{

void a() {
  #pragma omp parallel
  a(b);
}

};

The failed assertion is: "const clang::ValueDecl* getCanonicalDecl(const clang::ValueDecl*): Assertion `FD' failed."

while before it clang was correctly reporting error:
error: use of undeclared identifier 'b'

is it the same assertion you were trying to fix here?

No, the assert I am fixing is when default(firstprivate) is used inside member function.

Could you please investigate and fix it?

Yes, I will fix this.

I noticed that this patch is causing now an assertion failure for cases like :

It looks reasonable to me.
The main issue we saw in the past was assertion failure when the cost for gather/scatter wasn't implemented, but you are saying that now it is simply returning invalid cost so the type based cost model for gather/scatter is not needed.
But I guess it does not hurt to add it.
@david-arm you did some work on the cost model for gather/scatter from what I can see, could you have a look if you agree with the proposed changes?

I think it would be good to explain in the commit message that this patch allows to print cost calculated only based on argument types and that it is useful feature to have for testing purposes.

LGTM