User Details
- User Since
- Dec 17 2020, 1:04 AM (111 w, 5 d)
Tue, Jan 17
Thu, Jan 12
Wed, Jan 11
Dec 14 2022
addressed review comments
Dec 1 2022
Oct 27 2022
Oct 18 2022
fix not closed attributes declaration in a test file
Looks like lack of vscale_range attribute was causing div by 0 exception.
Sep 23 2022
Sep 22 2022
Sep 21 2022
Aug 19 2022
Could you change the commit message? or at least add [LoopLoadElim] ? it does not make clear that these are LoopLoadElimination tests.
Aug 11 2022
It is a fix for https://github.com/llvm/llvm-project/issues/57083
Aug 10 2022
Aug 9 2022
Aug 2 2022
I noticed that this patch is causing now an assertion failure for cases like :
Jul 28 2022
Jul 22 2022
Jul 12 2022
It looks reasonable to me.
The main issue we saw in the past was assertion failure when the cost for gather/scatter wasn't implemented, but you are saying that now it is simply returning invalid cost so the type based cost model for gather/scatter is not needed.
But I guess it does not hurt to add it.
@david-arm you did some work on the cost model for gather/scatter from what I can see, could you have a look if you agree with the proposed changes?
Jul 6 2022
I think it would be good to explain in the commit message that this patch allows to print cost calculated only based on argument types and that it is useful feature to have for testing purposes.
Jun 15 2022
May 30 2022
Jan 28 2022
LGTM