Page MenuHomePhabricator

mgabka (mgabka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2020, 1:04 AM (111 w, 5 d)

Recent Activity

Tue, Jan 17

mgabka updated subscribers of D141924: [IR] Add new intrinsics interleave and deinterleave vectors.
Tue, Jan 17, 8:42 AM · Restricted Project, Restricted Project

Thu, Jan 12

mgabka accepted D141507: [NFC] Fixed a typo in clang help docs.
Thu, Jan 12, 4:28 AM · Restricted Project, Restricted Project

Wed, Jan 11

mgabka added inline comments to D138682: [AArch64][SME]: Generate streaming-compatible code for bit counting/select.
Wed, Jan 11, 5:24 AM · Restricted Project, Restricted Project
mgabka added inline comments to D138682: [AArch64][SME]: Generate streaming-compatible code for bit counting/select.
Wed, Jan 11, 3:57 AM · Restricted Project, Restricted Project
mgabka added inline comments to D138682: [AArch64][SME]: Generate streaming-compatible code for bit counting/select.
Wed, Jan 11, 3:16 AM · Restricted Project, Restricted Project

Dec 14 2022

mgabka updated the diff for D136153: [AArch64] Allow cost computation for interleaved accesses.

addressed review comments

Dec 14 2022, 2:25 AM · Restricted Project, Restricted Project
mgabka requested review of D140003: [AArch64][NFC] Precommit tests for SVE interleaved accesses cost computation.
Dec 14 2022, 2:22 AM · Restricted Project, Restricted Project

Dec 1 2022

mgabka added inline comments to D136153: [AArch64] Allow cost computation for interleaved accesses.
Dec 1 2022, 7:24 AM · Restricted Project, Restricted Project

Oct 27 2022

mgabka added a reviewer for D136153: [AArch64] Allow cost computation for interleaved accesses: bsmith.
Oct 27 2022, 2:01 AM · Restricted Project, Restricted Project

Oct 18 2022

mgabka added reviewers for D136153: [AArch64] Allow cost computation for interleaved accesses: paulwalker-arm, huntergr, david-arm, igor.kirillov.
Oct 18 2022, 9:15 AM · Restricted Project, Restricted Project
mgabka updated the diff for D136153: [AArch64] Allow cost computation for interleaved accesses.

fix not closed attributes declaration in a test file

Oct 18 2022, 8:12 AM · Restricted Project, Restricted Project
mgabka updated the diff for D136153: [AArch64] Allow cost computation for interleaved accesses.

Looks like lack of vscale_range attribute was causing div by 0 exception.

Oct 18 2022, 7:16 AM · Restricted Project, Restricted Project
mgabka requested review of D136153: [AArch64] Allow cost computation for interleaved accesses.
Oct 18 2022, 3:16 AM · Restricted Project, Restricted Project

Sep 23 2022

mgabka added a reviewer for D134438: POC patch to demonstrate how new intrinsics for interleaved load/store could be used in LoopVectorize: reames.
Sep 23 2022, 1:10 AM · Restricted Project, Restricted Project

Sep 22 2022

mgabka added a reviewer for D134438: POC patch to demonstrate how new intrinsics for interleaved load/store could be used in LoopVectorize: dmgreen.
Sep 22 2022, 6:50 AM · Restricted Project, Restricted Project
mgabka requested review of D134438: POC patch to demonstrate how new intrinsics for interleaved load/store could be used in LoopVectorize.
Sep 22 2022, 6:49 AM · Restricted Project, Restricted Project

Sep 21 2022

mgabka added inline comments to D133687: [LoopVectorize][Fix] Crash when invariant store address is calculated inside loop.
Sep 21 2022, 8:22 AM · Restricted Project, Restricted Project

Aug 19 2022

mgabka added a comment to D132239: [NFC] [LoopLoadElim] Extending type-mismatch testing.

Could you change the commit message? or at least add [LoopLoadElim] ? it does not make clear that these are LoopLoadElimination tests.

Aug 19 2022, 9:00 AM · Restricted Project, Restricted Project

Aug 11 2022

mgabka added a comment to D131580: [clang][SVE] Undefine preprocessor macro defined in.

It is a fix for https://github.com/llvm/llvm-project/issues/57083

Aug 11 2022, 5:50 AM · Restricted Project, Restricted Project
mgabka added inline comments to D131580: [clang][SVE] Undefine preprocessor macro defined in.
Aug 11 2022, 3:01 AM · Restricted Project, Restricted Project
mgabka updated the diff for D131580: [clang][SVE] Undefine preprocessor macro defined in.
Aug 11 2022, 3:00 AM · Restricted Project, Restricted Project

Aug 10 2022

mgabka added a reviewer for D131580: [clang][SVE] Undefine preprocessor macro defined in: huntergr.
Aug 10 2022, 8:44 AM · Restricted Project, Restricted Project
mgabka requested review of D131580: [clang][SVE] Undefine preprocessor macro defined in.
Aug 10 2022, 8:42 AM · Restricted Project, Restricted Project

Aug 9 2022

mgabka added inline comments to D130233: [LoopLoadElim] Add stores with matching sizes as load-store candidates.
Aug 9 2022, 2:30 AM · Restricted Project, Restricted Project

Aug 2 2022

mgabka added a comment to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

I noticed that this patch is causing now an assertion failure for cases like :

class A{

void a() {
  #pragma omp parallel
  a(b);
}

};

The failed assertion is: "const clang::ValueDecl* getCanonicalDecl(const clang::ValueDecl*): Assertion `FD' failed."

while before it clang was correctly reporting error:
error: use of undeclared identifier 'b'

is it the same assertion you were trying to fix here?

No, the assert I am fixing is when default(firstprivate) is used inside member function.

Could you please investigate and fix it?

Yes, I will fix this.

Aug 2 2022, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
mgabka added a comment to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

I noticed that this patch is causing now an assertion failure for cases like :

Aug 2 2022, 4:27 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

mgabka added reviewers for D130233: [LoopLoadElim] Add stores with matching sizes as load-store candidates: david-arm, paulwalker-arm.
Jul 28 2022, 12:57 AM · Restricted Project, Restricted Project

Jul 22 2022

mgabka accepted D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 22 2022, 7:39 AM · Restricted Project, Restricted Project
mgabka added inline comments to D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 22 2022, 5:03 AM · Restricted Project, Restricted Project

Jul 12 2022

mgabka added inline comments to D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.
Jul 12 2022, 6:15 AM · Restricted Project, Restricted Project
mgabka updated subscribers of D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.

It looks reasonable to me.
The main issue we saw in the past was assertion failure when the cost for gather/scatter wasn't implemented, but you are saying that now it is simply returning invalid cost so the type based cost model for gather/scatter is not needed.
But I guess it does not hurt to add it.
@david-arm you did some work on the cost model for gather/scatter from what I can see, could you have a look if you agree with the proposed changes?

Jul 12 2022, 2:31 AM · Restricted Project, Restricted Project

Jul 6 2022

mgabka added a comment to D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option.

I think it would be good to explain in the commit message that this patch allows to print cost calculated only based on argument types and that it is useful feature to have for testing purposes.

Jul 6 2022, 1:34 AM · Restricted Project, Restricted Project
mgabka added a reviewer for D129109: [Costmodel] Add "type-based-intrinsic-cost" cli option: mgabka.
Jul 6 2022, 1:13 AM · Restricted Project, Restricted Project

Jun 15 2022

mgabka added reviewers for D127655: [AArch64] Define __FP_FAST_FMA[F]: sdesmalen, peterwaller-arm, paulwalker-arm.
Jun 15 2022, 6:09 AM · Restricted Project, Restricted Project

May 30 2022

mgabka added a reviewer for D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))': paulwalker-arm.
May 30 2022, 12:54 AM · Restricted Project, Restricted Project
mgabka added inline comments to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
May 30 2022, 12:53 AM · Restricted Project, Restricted Project

Jan 28 2022

mgabka accepted D118420: [AArch64] Add isel for bitcasting between bfloat and half types..

LGTM

Jan 28 2022, 3:12 AM · Restricted Project
mgabka added inline comments to D118420: [AArch64] Add isel for bitcasting between bfloat and half types..
Jan 28 2022, 12:43 AM · Restricted Project

Jan 19 2022

mgabka requested review of D117674: Restrict performPostLD1Combine to 64 and 128 bit vectors.
Jan 19 2022, 6:24 AM · Restricted Project

Nov 15 2021

mgabka added inline comments to D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options.
Nov 15 2021, 7:32 AM · Restricted Project, Restricted Project