Page MenuHomePhabricator

JOE1994 (Youngsuk Kim)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 30 2020, 2:29 PM (165 w, 1 d)

Recent Activity

Feb 8 2023

JOE1994 added inline comments to D128998: [libunwind] Handle G in personality string.
Feb 8 2023, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
JOE1994 added inline comments to D128998: [libunwind] Handle G in personality string.
Feb 8 2023, 8:39 AM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2023

JOE1994 added a comment to D138451: [lld/mac] Add support for distributed ThinLTO.

This introduced build failure (due to link time error : undefined reference to "writeIndexToFile"),
and was later fixed by https://github.com/llvm/llvm-project/commit/87bea593626a103ea4d63ab4a027ec956ccc2b56

Jan 25 2023, 12:59 PM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2022

JOE1994 added a reviewer for D139152: [SLPVectorizer] Don't deref std::end() of object: ABataev.
Dec 1 2022, 4:28 PM · Restricted Project, Restricted Project
JOE1994 added a comment to D139152: [SLPVectorizer] Don't deref std::end() of object.

Code that calls find_if_not was added by commit d65cc8597792ab04142cd2214c46c5c167191bcd to improve compile time & scheduling resources.
Thus I expect that using V and OpValue as is when std::end() is returned shouldn't cause any issues.

Dec 1 2022, 4:09 PM · Restricted Project, Restricted Project
JOE1994 added a comment to D139152: [SLPVectorizer] Don't deref std::end() of object.

Could you provide a test case?

Dec 1 2022, 4:01 PM · Restricted Project, Restricted Project
JOE1994 requested review of D139152: [SLPVectorizer] Don't deref std::end() of object.
Dec 1 2022, 3:45 PM · Restricted Project, Restricted Project

Aug 24 2022

JOE1994 abandoned D132521: [AST] Reuse PrintingPolicy from ASTContext.
Aug 24 2022, 2:09 PM · Restricted Project, Restricted Project
JOE1994 updated the diff for D132521: [AST] Reuse PrintingPolicy from ASTContext.

Add missed out 'const'

Aug 24 2022, 4:13 AM · Restricted Project, Restricted Project

Aug 23 2022

JOE1994 requested review of D132521: [AST] Reuse PrintingPolicy from ASTContext.
Aug 23 2022, 6:41 PM · Restricted Project, Restricted Project

Jun 13 2022

JOE1994 abandoned D127701: [docs] Minor fixes to CodeGenerator docs.

@DanielMcIntosh-IBM Thank you so much for taking your time to review this patch.

Jun 13 2022, 4:15 PM · Restricted Project, Restricted Project
JOE1994 added inline comments to D127701: [docs] Minor fixes to CodeGenerator docs.
Jun 13 2022, 4:10 PM · Restricted Project, Restricted Project
JOE1994 added a comment to D127701: [docs] Minor fixes to CodeGenerator docs.

If this commit gets approved:

Jun 13 2022, 3:06 PM · Restricted Project, Restricted Project
JOE1994 requested review of D127701: [docs] Minor fixes to CodeGenerator docs.
Jun 13 2022, 3:03 PM · Restricted Project, Restricted Project

Jun 8 2022

JOE1994 abandoned D113944: [CodeGenAction][NFC] Remove empty comment.
Jun 8 2022, 1:36 PM · Restricted Project, Restricted Project

May 21 2022

Herald added a project to D98152: [InstCombine] Canonicalize SPF to min/max intrinsics: Restricted Project.
May 21 2022, 11:20 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

JOE1994 added a comment to D124305: [docs] Fix typo in 'CodeGenerator' docs.

@myhsu Thank you !

Apr 26 2022, 7:30 AM · Restricted Project, Restricted Project

Apr 24 2022

JOE1994 added a reviewer for D124305: [docs] Fix typo in 'CodeGenerator' docs: seaneveson.
Apr 24 2022, 6:54 PM · Restricted Project, Restricted Project
JOE1994 added a comment to D124305: [docs] Fix typo in 'CodeGenerator' docs.

Since I do not have commit access, it would be great if the reviewer could land this commit for me.
Please use "Youngsuk Kim joseph942010@gmail.com" to commit the change.

Apr 24 2022, 6:49 PM · Restricted Project, Restricted Project

Apr 22 2022

JOE1994 updated the diff for D124305: [docs] Fix typo in 'CodeGenerator' docs.

[docs] Fix typo in 'CodeGenerator' docs

Apr 22 2022, 2:47 PM · Restricted Project, Restricted Project
JOE1994 requested review of D124305: [docs] Fix typo in 'CodeGenerator' docs.
Apr 22 2022, 2:40 PM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D119704: [UpdateTestChecks] Don't skip first line with --filter: Restricted Project.
Mar 2 2022, 5:52 AM · Restricted Project, Restricted Project
JOE1994 awarded D119704: [UpdateTestChecks] Don't skip first line with --filter a Love token.
Mar 2 2022, 5:52 AM · Restricted Project, Restricted Project

Mar 1 2022

Herald added a project to D117694: [UpdateTestChecks] Add --filter and --filter-out options: Restricted Project.

I see 6 non-temporal store instructions in "llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-non-temporal.ll",
but the expected output ("llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-non-temporal.ll.filter.expected") checks for only 5 non-temporal instructions.

Mar 1 2022, 6:23 PM · Restricted Project, Restricted Project

Feb 28 2022

JOE1994 added a comment to rGecd46edd6134: [UpdateTestChecks] Re-add --filter and --filter-out options.

I see 6 non-temporal store instructions in "llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-non-temporal.ll",
but the expected output ("llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-non-temporal.ll.filter.expected") checks for only 5 non-temporal instructions.

Feb 28 2022, 4:36 PM

Nov 15 2021

JOE1994 requested review of D113944: [CodeGenAction][NFC] Remove empty comment.
Nov 15 2021, 2:55 PM · Restricted Project, Restricted Project

Nov 2 2021

JOE1994 added a comment to D112979: Remove duplicate include of 'SimpleLoopUnswitch.h'.

Please let me know if you want me to land this on your behalf (if you don't have commit access yet). In that case, please let me know the name + email to use as commit author.

Nov 2 2021, 5:20 AM · Restricted Project

Nov 1 2021

JOE1994 requested review of D112979: Remove duplicate include of 'SimpleLoopUnswitch.h'.
Nov 1 2021, 7:37 PM · Restricted Project