Page MenuHomePhabricator

jeroen.dobbelaere (Jeroen Dobbelaere)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:47 AM (377 w, 3 d)

Recent Activity

Mon, May 9

jeroen.dobbelaere added a comment to D111159: [UnknownProvenance] Introduce UnknownProvenance constant.

Do you need help merging this?

Mon, May 9, 12:58 AM · Restricted Project, Restricted Project

Thu, May 5

jeroen.dobbelaere added a comment to D107356: [Lowering] Support lowering of llvm.experimental.ptr.provenance..
NOTE: this should not be done here. The ptr_provenance Value in D107354 must still be able to see these intrinsics.
Thu, May 5, 11:50 PM · Restricted Project, Restricted Project
jeroen.dobbelaere added a comment to D107354: [MachineMemOperand] learn about ptr_provenance.

Given that the provenance gets dropped in https://reviews.llvm.org/D107356, how does it end up in machine operands?

Thu, May 5, 11:48 PM · Restricted Project, Restricted Project

Apr 21 2022

jeroen.dobbelaere added a comment to D69542: Full Restrict Support - single patch.

Hi. I tried to use your patch for my project. My main concern is AA in MachineScheduler.
I noticed what ptr_provenance info is not passed to CodeGen.
It could be fixed by adding it to MemoryMachineOperand constructor in SelectionDAGBuilder::visitLoad and SelectionDAGBuilder::visitStore.

Apr 21 2022, 11:37 AM · Restricted Project, Restricted Project

Apr 15 2022

jeroen.dobbelaere added a comment to D123247: Provide a more in-depth reference document for TBAA's implementation..

Looks good. Thanks for documenting this !

Apr 15 2022, 9:03 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107357: [getUnderlyingObject] support ptr_provenance.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:06 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107356: [Lowering] Support lowering of llvm.experimental.ptr.provenance..

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:06 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107355: [ptr_provenance] Introduce llvm.experimental.ptr.provenance.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:05 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107354: [MachineMemOperand] learn about ptr_provenance.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:04 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107352: [MemoryLocation] learn about ptr_provenance.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:03 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111751: [ptr_provenance] Add llvm-c support..

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:03 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104270: [ptr_provenance] Bitcode reader/writer support for the optional ptr_provenance operand of load/store instructions.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:01 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:00 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 7:00 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111163: [UnknownProvenance] add support in ValueMapper.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 6:58 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111161: [UnknownProvenance] Add bitcode support..

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 6:58 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 6:57 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111159: [UnknownProvenance] Introduce UnknownProvenance constant.

Rebase to 49cb4fef02e635bf304906232214166c7531d753

Apr 15 2022, 6:57 AM · Restricted Project, Restricted Project

Mar 22 2022

jeroen.dobbelaere added a comment to D122205: [LoopIdiom] Merge TBAA of adjacent stores when creating memset.

Unfortunately, the context of this patch is not available :(

Whoops, should have explained the context. We were seeing GVN remove a load that had a TBAA that matched the 2nd store because GVN determined that it didn't match the TBAA on the memset that was created. The memset had the TBAA of the first store.

Mar 22 2022, 6:52 AM · Restricted Project, Restricted Project
jeroen.dobbelaere accepted D122205: [LoopIdiom] Merge TBAA of adjacent stores when creating memset.

After looking at the full function and seeing how it is used: 'merge' is indeed the right operation to use here.

Mar 22 2022, 6:36 AM · Restricted Project, Restricted Project
jeroen.dobbelaere requested changes to D122205: [LoopIdiom] Merge TBAA of adjacent stores when creating memset.

Unfortunately, the context of this patch is not available :(

Mar 22 2022, 6:25 AM · Restricted Project, Restricted Project

Feb 3 2022

jeroen.dobbelaere added a comment to D69542: Full Restrict Support - single patch.

Hi @hkao13 You happen to have some reduced testcases that show the problem ? Thanks !

Feb 3 2022, 12:17 AM · Restricted Project, Restricted Project

Jan 31 2022

jeroen.dobbelaere accepted D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove.

LGTM. Thanks !

Jan 31 2022, 12:10 PM · Restricted Project
jeroen.dobbelaere added a comment to D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove.

Sorry about not mentioning it with the previous part.

Jan 31 2022, 11:27 AM · Restricted Project
jeroen.dobbelaere added a comment to D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove.

I checked the testcases for now and found some interesting effects. Can you comment on those ?

Jan 31 2022, 10:14 AM · Restricted Project
jeroen.dobbelaere added a comment to D68484: [PATCH 01/27] [noalias] LangRef: noalias intrinsics and ptr_provenance documentation..
  • the need to implement the 'based on' relationship, also in a a way that clang is producing code, where this dependency is not easily seen. The same restrict pointer usage can appear in different blocks at different places.

You need to elaborate this a bit more, otherwise I don't understand what you mean.

Jan 31 2022, 2:57 AM · Restricted Project
jeroen.dobbelaere added a comment to D68484: [PATCH 01/27] [noalias] LangRef: noalias intrinsics and ptr_provenance documentation..

Access to restrict pointer is bounded by the noalias & noalias.end calls.
Advantages:

  • Much simpler than the current proposal.
  • Perf improvements from day one: by tagging the intrinsics properly, LLVM's AA algorithms can already decide that %p2 doesn't alias anything else.
  • Safe from day one: no memory operations can be moved across the barriers. This is enforced by LLVM IR semantics already, no changes needed!

Further perf improvements can be made, like hoisting llvm.alias intrinsics, teach LLVM that these intrinsics don't actually write to memory, etc.

Essentially, I don't see a need to track provenance explicitly with metadata. It's already easily accessible. Explicit tracking adds overhead, so it has to be very well justified. Right now I don't understand the motivation.

Please let me know what you think, especially what use case wouldn't work with the proposal above. Thanks!

Jan 31 2022, 12:33 AM · Restricted Project

Jan 25 2022

jeroen.dobbelaere added a reviewer for D108221: [LoopIdiom] Keep TBAA when creating memcpy/memmove: jeroen.dobbelaere.
Jan 25 2022, 10:54 AM · Restricted Project
jeroen.dobbelaere added a comment to D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.

Have you considered inverting this patch stack and landing the intrinsic first, as that part seems more straightforward than the IR change? I have a suspicion that actually supporting independent address + provenance will require some significant work for various users of getUnderlyingObject(), which may not account for the possibility of address and provenance being different. Updating all users seems like something we can do using just the intrinsic.

It should be possible, but I am not sure it makes a lot of sense: Looking at the big picture, this proposed set of patches for providing ptr_provenance is a logical next step. My intention is that these patches only go in once all of them have been reviewed and accepted. At that time the basic infrastructure is available for the full restrict patches, which means that the next steps will start making use of this basic infrastructure.
The current users of the 'GetUnderlyingObject' can keep their behavior (for now), being: look for the underlying object following the computational path of the pointer. With more actual usage of the ptr_provenance, some of those GetUnderlyingObject users can switch to the provenance path, which should result in a speedup.
The more tricky changes are related to some of the bugs where the provenance of pointers gets switched and to N2676. Once the base infrastructure is there, we can also fix those.

Jan 25 2022, 5:00 AM · Restricted Project, Restricted Project

Jan 24 2022

jeroen.dobbelaere added a comment to D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.

It's been a while since I looked at this, so please excuse the stupid question...

Why do we model provenance as an additional value on the load/store? Naively, I would think that it would be preferable to have an intrinsic like p' = llvm.with.provenance(p, provenance), because that would work with any use of the pointer -- the ptr_provenance operand is limited to loads and stores, but not with memory-accessing calls or captured pointers, and I don't think it can really be extended in that direction.

Jan 24 2022, 10:26 AM · Restricted Project, Restricted Project

Jan 19 2022

jeroen.dobbelaere accepted D117679: [MemCpyOpt] Fix metadata merging during call slot optimization.

LGTM

Jan 19 2022, 7:32 AM · Restricted Project

Jan 4 2022

jeroen.dobbelaere added a comment to D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.

Yes, the big one being that we don't use GDB and use LLDB instead. @xgupta

Jan 4 2022, 10:07 AM · Restricted Project

Dec 20 2021

jeroen.dobbelaere added a comment to D114141: Allow DataLayout to support arbitrary pointer sizes.

ping2 @stephenneuendorffer : could you check and comment on P.TypeBitWidth vs P.IndexBitWidth on line 715 ?

Dec 20 2021, 12:58 AM · Restricted Project

Dec 14 2021

jeroen.dobbelaere accepted D115320: Avoid setting tbaa information on store of return type of call to inline assember.

LGTM

Dec 14 2021, 8:57 AM · Restricted Project
jeroen.dobbelaere added inline comments to D115320: Avoid setting tbaa information on store of return type of call to inline assember.
Dec 14 2021, 1:09 AM · Restricted Project

Dec 11 2021

jeroen.dobbelaere added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

We're almost there. But the testcase is now not testing what it should be testing. Also the unused CHECK: must be adapted.

Dec 11 2021, 3:48 AM · Restricted Project

Dec 10 2021

jeroen.dobbelaere added inline comments to D115320: Avoid setting tbaa information on store of return type of call to inline assember.
Dec 10 2021, 2:32 AM · Restricted Project

Dec 9 2021

jeroen.dobbelaere added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

When I try out the example on llvm-13, I get a 'omnipotent char' tbaa description. That should be ok in general. When I replace the 'float _Complex' with 'double', I do get the 'double' tbaa. That might be a better example for the testcase ?

Dec 9 2021, 5:15 AM · Restricted Project
jeroen.dobbelaere added a comment to D114141: Allow DataLayout to support arbitrary pointer sizes.

Not sure how you can construct a test that triggers this problem, but in our out-of-tree version, this triggered problems.

Dec 9 2021, 4:22 AM · Restricted Project

Dec 7 2021

jeroen.dobbelaere added a comment to D115320: Avoid setting tbaa information on store of return type of call to inline assember.

Do you have a testcase ?

Dec 7 2021, 11:54 PM · Restricted Project

Dec 2 2021

jeroen.dobbelaere committed rG6f08b55213d8: [flang] GettingInvolved: update LLVM Alias Analysis Technical Call info (authored by jeroen.dobbelaere).
[flang] GettingInvolved: update LLVM Alias Analysis Technical Call info
Dec 2 2021, 5:37 AM
jeroen.dobbelaere closed D114145: [flang] GettingInvolved: update LLVM Alias Analysis Technical Call info.
Dec 2 2021, 5:37 AM · Restricted Project, Restricted Project

Dec 1 2021

jeroen.dobbelaere added a comment to D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.

A number of buildbots started failing after submission. Reverted for now so we can investigate if the new produced errors are valid or not.

Dec 1 2021, 2:21 AM · Restricted Project
jeroen.dobbelaere added a reverting change for rG0c047a8e1332: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template…: rGa4fbae268f67: Revert "[Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in….
Dec 1 2021, 2:20 AM
jeroen.dobbelaere committed rGa4fbae268f67: Revert "[Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in… (authored by jeroen.dobbelaere).
Revert "[Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in…
Dec 1 2021, 2:20 AM
jeroen.dobbelaere added a reverting change for D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation: rGa4fbae268f67: Revert "[Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in….
Dec 1 2021, 2:20 AM · Restricted Project
jeroen.dobbelaere committed rG0c047a8e1332: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template… (authored by jeroen.dobbelaere).
[Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template…
Dec 1 2021, 2:03 AM
jeroen.dobbelaere closed D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.
Dec 1 2021, 2:03 AM · Restricted Project

Nov 18 2021

jeroen.dobbelaere requested review of D114145: [flang] GettingInvolved: update LLVM Alias Analysis Technical Call info.
Nov 18 2021, 12:53 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a comment to D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.

Should there be a verifier change to ensure that it is *actually* only used in the provenance operand, and not as a pure pointer,
or can it be PHI'd/select'ed from multiple variants?

Nov 18 2021, 12:32 AM · Restricted Project, Restricted Project

Nov 17 2021

jeroen.dobbelaere added a comment to D68484: [PATCH 01/27] [noalias] LangRef: noalias intrinsics and ptr_provenance documentation..

I updated and rebased the convenience patch to 8924ba3bf8c6b0e8d14dff455e4e449a426a2700 (November 17, 2021) (See D69542)

Nov 17 2021, 7:55 AM · Restricted Project
jeroen.dobbelaere updated the diff for D69542: Full Restrict Support - single patch.

Rebased to 8924ba3bf8c6b0e8d14dff455e4e449a426a2700 (November 17, 2021)

Nov 17 2021, 7:51 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a comment to D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.

Where is RFC or some high level document?

Nov 17 2021, 7:28 AM · Restricted Project, Restricted Project

Nov 8 2021

jeroen.dobbelaere added a comment to D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.
  • Discussion on why is cloning a load/store setting the ptr_provenance to unknown_provenance? When cloning a load/store instruction, the cloned instruction needs to have the same number of operands. Otherwise crashes were observed in some passes (example given: LoopVectorization). Why can't the number of operands remain the same, but set the ptr_provenance to the (otherwise default) ptr_operand?

@jeroen.dobbelaere: Could you describe using unknown for the cloning question for future reference?

Nov 8 2021, 9:05 AM · Restricted Project, Restricted Project

Nov 5 2021

jeroen.dobbelaere added a comment to D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.
  • Clarified item: If a load/store has 2/3 operands out of which only 1/2 are used, these operands are stored in the last position(s). So when adding provenance, the current operands need to be shifted to the first position(s) and the provenance added as the last operand.
Nov 5 2021, 6:15 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a comment to D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.

Where is RFC or some high level document?

Nov 5 2021, 4:43 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a comment to D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.

Please document this in the LLVM language reference! I for one have trouble following the discussions (since I didn't have the time to read all the C/C++ reports yet)

Nov 5 2021, 4:22 AM · Restricted Project, Restricted Project

Oct 15 2021

jeroen.dobbelaere added a comment to D110511: [BasicAA] Improve scalable vector handling.

This makes sense to me. Are there non-scalable-vector cases where UnderlyingValue[1-2] -> DecompGEP[1-2].Base shows benefits?

Oct 15 2021, 1:23 AM · Restricted Project

Oct 14 2021

jeroen.dobbelaere updated the diff for D111751: [ptr_provenance] Add llvm-c support..

Actual fixed version.

Oct 14 2021, 9:17 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111751: [ptr_provenance] Add llvm-c support..

Fixed test crash issue as suggested by @deadalnix

Oct 14 2021, 9:16 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation: rnk.
Oct 14 2021, 1:08 AM · Restricted Project

Oct 13 2021

jeroen.dobbelaere added a comment to D111159: [UnknownProvenance] Introduce UnknownProvenance constant.

I added a llvm-c echo test in D111751, together with the ptr_provenance support.

Oct 13 2021, 12:09 PM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.

Updated after LLLexer change in D111160

Oct 13 2021, 12:06 PM · Restricted Project, Restricted Project
jeroen.dobbelaere abandoned D111162: [UnknownProvenance] Add llvm-c support.
Oct 13 2021, 12:04 PM · Restricted Project
jeroen.dobbelaere added a comment to D111162: [UnknownProvenance] Add llvm-c support.

Moved into D111159

Oct 13 2021, 12:04 PM · Restricted Project
jeroen.dobbelaere updated the diff for D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.

Added missing LLLexer support.

Oct 13 2021, 12:02 PM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111159: [UnknownProvenance] Introduce UnknownProvenance constant.

Incorporated D111162

Oct 13 2021, 11:47 AM · Restricted Project, Restricted Project
jeroen.dobbelaere requested review of D111751: [ptr_provenance] Add llvm-c support..
Oct 13 2021, 11:41 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added inline comments to D111162: [UnknownProvenance] Add llvm-c support.
Oct 13 2021, 3:20 AM · Restricted Project
jeroen.dobbelaere added a comment to D111159: [UnknownProvenance] Introduce UnknownProvenance constant.

Thanks for the feedback !

Oct 13 2021, 12:01 AM · Restricted Project, Restricted Project

Oct 12 2021

jeroen.dobbelaere added inline comments to D109852: [IR] Return AAMDNodes from Instruction::getMetadata() (NFC).
Oct 12 2021, 9:11 AM · Restricted Project
jeroen.dobbelaere retitled D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation from [PR51855] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation to [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation.
Oct 12 2021, 6:47 AM · Restricted Project

Oct 11 2021

jeroen.dobbelaere updated the diff for D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.

LangRef update. Refer to `unknown_provenance` now.

Oct 11 2021, 8:39 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107357: [getUnderlyingObject] support ptr_provenance.

Refer to UnknownProvenance instead of ConstantPointerNull in comment of getUnderlyingObject.

Oct 11 2021, 8:31 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D107356: [Lowering] Support lowering of llvm.experimental.ptr.provenance.: asbirlea.
Oct 11 2021, 8:30 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D107355: [ptr_provenance] Introduce llvm.experimental.ptr.provenance: asbirlea.
Oct 11 2021, 8:29 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D107354: [MachineMemOperand] learn about ptr_provenance: asbirlea.
Oct 11 2021, 8:29 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D107352: [MemoryLocation] learn about ptr_provenance: asbirlea.
Oct 11 2021, 8:28 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D104270: [ptr_provenance] Bitcode reader/writer support for the optional ptr_provenance operand of load/store instructions: asbirlea.
Oct 11 2021, 8:28 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.

Also test that parsing unknown_provenance works.

Oct 11 2021, 8:27 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D111163: [UnknownProvenance] add support in ValueMapper: asbirlea.
Oct 11 2021, 8:24 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D111162: [UnknownProvenance] Add llvm-c support: asbirlea.
Oct 11 2021, 8:24 AM · Restricted Project
jeroen.dobbelaere added a reviewer for D111161: [UnknownProvenance] Add bitcode support.: asbirlea.
Oct 11 2021, 8:23 AM · Restricted Project, Restricted Project
jeroen.dobbelaere added a reviewer for D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance: asbirlea.
Oct 11 2021, 8:23 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D111159: [UnknownProvenance] Introduce UnknownProvenance constant.
  • Small cleanup of useless comment
  • NOTE: The LangeRef change explaining the purpose of unknown_provenance is done in D104268
Oct 11 2021, 8:22 AM · Restricted Project, Restricted Project

Oct 5 2021

jeroen.dobbelaere added inline comments to D111174: [X86][Costmodel] Improve cost modelling for not-fully-interleaved load.
Oct 5 2021, 12:28 PM · Restricted Project
jeroen.dobbelaere added a comment to D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.

Compile time impact: https://llvm-compile-time-tracker.com/index.php?config=NewPM-O3&stat=instructions&branch=dobbelaj-snps/perf/ptr_provenance-20211005-04

Oct 5 2021, 8:16 AM · Restricted Project, Restricted Project
jeroen.dobbelaere requested review of D111163: [UnknownProvenance] add support in ValueMapper.
Oct 5 2021, 8:10 AM · Restricted Project, Restricted Project
jeroen.dobbelaere requested review of D111162: [UnknownProvenance] Add llvm-c support.
Oct 5 2021, 8:09 AM · Restricted Project
jeroen.dobbelaere requested review of D111161: [UnknownProvenance] Add bitcode support..
Oct 5 2021, 8:08 AM · Restricted Project, Restricted Project
jeroen.dobbelaere requested review of D111160: [UnknownProvenance] Add LLVM-IR support for unknown_provenance.
Oct 5 2021, 8:06 AM · Restricted Project, Restricted Project
jeroen.dobbelaere requested review of D111159: [UnknownProvenance] Introduce UnknownProvenance constant.
Oct 5 2021, 8:04 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107357: [getUnderlyingObject] support ptr_provenance.
  • Rebased
  • Note: still need to update the (obsolete) comment
Oct 5 2021, 8:01 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107356: [Lowering] Support lowering of llvm.experimental.ptr.provenance..
  • Rebased
Oct 5 2021, 7:58 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107355: [ptr_provenance] Introduce llvm.experimental.ptr.provenance.
  • Rebased
Oct 5 2021, 7:58 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107354: [MachineMemOperand] learn about ptr_provenance.
  • Rebased
Oct 5 2021, 7:57 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D107352: [MemoryLocation] learn about ptr_provenance.
  • Rebased
  • use llvm::hash_combine instead of xor for combining the different elements. This avoids hash clashes when ptr == ptr_provenance
Oct 5 2021, 7:56 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104270: [ptr_provenance] Bitcode reader/writer support for the optional ptr_provenance operand of load/store instructions.

Rebased

Oct 5 2021, 7:54 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.

Rebased

Oct 5 2021, 7:53 AM · Restricted Project, Restricted Project
jeroen.dobbelaere updated the diff for D104268: [ptr_provenance] Introduce optional ptr_provenance operand to load/store.
  • rebase
  • make use of UnknownProvenance
Oct 5 2021, 7:52 AM · Restricted Project, Restricted Project