Page MenuHomePhabricator
People khei4

khei4 (Kohei Asano)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 8 2023, 1:38 PM (17 w, 10 h)

Recent Activity
View All

Yesterday

khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

update tests

Wed, Jun 7, 9:35 AM · Restricted Project, Restricted Project
khei4 added inline comments to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Wed, Jun 7, 9:34 AM · Restricted Project, Restricted Project
khei4 added inline comments to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Wed, Jun 7, 6:25 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

rebase for enforced alignment

Wed, Jun 7, 6:24 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

update alignment enforcing test

Wed, Jun 7, 6:24 AM · Restricted Project, Restricted Project
khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Wed, Jun 7, 4:21 AM · Restricted Project, Restricted Project
khei4 added inline comments to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Wed, Jun 7, 3:58 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

rebase
remove redundancy,
fix wrong comments

Wed, Jun 7, 3:58 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

add cases

  • dst modified
  • enforced alignment

remove obsolete comment
replace unnecessary homogeneous scalable aggregate

Wed, Jun 7, 3:57 AM · Restricted Project, Restricted Project

Tue, Jun 6

khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

apply feedback and inverse alignment vs memcpy length comparison.

Tue, Jun 6, 11:03 PM · Restricted Project, Restricted Project
khei4 added inline comments to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Tue, Jun 6, 11:02 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

add

  • smaller alignment failure case
  • address space failure case
  • scalable vector failure case
Tue, Jun 6, 10:58 PM · Restricted Project, Restricted Project
khei4 retitled D152277: (WIP) [MemCpyOpt] precommit tests to add inter-BB stack-move optimization from (WIP) [MemCpyOpt] precommit tes t to add inter-BB stack-move optimization to (WIP) [MemCpyOpt] precommit tests to add inter-BB stack-move optimization.
Tue, Jun 6, 8:23 AM · Restricted Project, Restricted Project
khei4 updated the summary of D152277: (WIP) [MemCpyOpt] precommit tests to add inter-BB stack-move optimization.
Tue, Jun 6, 8:15 AM · Restricted Project, Restricted Project
khei4 requested review of D152277: (WIP) [MemCpyOpt] precommit tests to add inter-BB stack-move optimization.
Tue, Jun 6, 8:13 AM · Restricted Project, Restricted Project
khei4 added a comment to D140089: [MemCpyOpt] Add a stack-move optimization to opportunistically merge allocas together..

@pcwalton Hi! I'm happy to take ownership of fixing this unless someone else is already working on it. I now plan to start with basic block local optimizations!

Tue, Jun 6, 8:09 AM · Restricted Project, Restricted Project

Mon, Jun 5

khei4 committed rG116670d192c6: [InstCombine] add overflow checking on Add ~X + C --> (C-1) - X (authored by khei4).
[InstCombine] add overflow checking on Add ~X + C --> (C-1) - X
Mon, Jun 5, 8:43 PM · Restricted Project, Restricted Project
khei4 committed rG0505fcdccd5d: [InstCombine] precommit test for D152088(NFC) (authored by khei4).
[InstCombine] precommit test for D152088(NFC)
Mon, Jun 5, 8:43 PM · Restricted Project, Restricted Project
khei4 closed D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.
Mon, Jun 5, 8:43 PM · Restricted Project, Restricted Project
khei4 closed D152089: [InstCombine] precommit test for D152088(NFC).
Mon, Jun 5, 8:43 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.

rebase

Mon, Jun 5, 4:06 AM · Restricted Project, Restricted Project
khei4 committed rG4db8d4f83910: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X` (authored by khei4).
[InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`
Mon, Jun 5, 4:05 AM · Restricted Project, Restricted Project
khei4 committed rG41588b5880c8: [InstCombine] precommit test for D152068(NFC) (authored by khei4).
[InstCombine] precommit test for D152068(NFC)
Mon, Jun 5, 4:05 AM · Restricted Project, Restricted Project
khei4 closed D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Mon, Jun 5, 4:05 AM · Restricted Project, Restricted Project
khei4 closed D152091: [InstCombine] precommit test for D152068(NFC).
Mon, Jun 5, 4:05 AM · Restricted Project, Restricted Project
khei4 updated the diff for D152089: [InstCombine] precommit test for D152088(NFC).

rebase

Mon, Jun 5, 4:04 AM · Restricted Project, Restricted Project
khei4 updated the summary of D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.
Mon, Jun 5, 3:53 AM · Restricted Project, Restricted Project
khei4 added a comment to D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.

This looks more complicated than necessary, just this should be enough: https://alive2.llvm.org/ce/z/ZWmZLv

Mon, Jun 5, 3:53 AM · Restricted Project, Restricted Project
khei4 added a comment to D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

In this case, the original pointer (%val1) is dereferenceable to 4 bytes, but the new one (%val) is only known dereferenceable to 1 byte, so we are replacing dereferencable(bigger) with dereferenceable(smaller), no? That wouldn't be valid.

Mon, Jun 5, 3:50 AM · Restricted Project, Restricted Project
khei4 added inline comments to D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Mon, Jun 5, 3:33 AM · Restricted Project, Restricted Project

Sun, Jun 4

khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Sun, Jun 4, 10:25 PM · Restricted Project, Restricted Project
khei4 added a comment to D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

I think if the dest is unescaped alloca, allocasize and memcpy length corresponding is unnecessary, because

  • If alloca length < memcpy length, memcpy is UB so we could transform it anyway?
  • If memcpy length < alloca length, if the alloca is unescaped transformation will widen the dereferenceability for param, but dereferenceable(bigger) subsumes dereferenceable(smaller) so, some UB will non-UB, but inverse doesn't happens. This will be valid?
Sun, Jun 4, 10:24 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

remove smaller memcpy length case temporary

Sun, Jun 4, 10:23 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

fix styles and comments and postpone detailed case

Sun, Jun 4, 10:22 PM · Restricted Project, Restricted Project
khei4 retitled D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes from [MemCpyOpt]remove memcpy on immutable arguments from attributes to [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Sun, Jun 4, 10:20 PM · Restricted Project, Restricted Project
khei4 added inline comments to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Sun, Jun 4, 9:37 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

apply feedbacks.

  • fix styles
Sun, Jun 4, 9:35 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.

rebase for tests update

Sun, Jun 4, 8:59 PM · Restricted Project, Restricted Project
khei4 updated the summary of D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.
Sun, Jun 4, 8:58 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152089: [InstCombine] precommit test for D152088(NFC).

Add nuw case and non-splat vector cases

Sun, Jun 4, 8:57 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152091: [InstCombine] precommit test for D152068(NFC).

fix wrong diff upload

Sun, Jun 4, 8:55 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152091: [InstCombine] precommit test for D152068(NFC).

Add nuw case and non-splat vector cases

Sun, Jun 4, 8:53 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

remove noise test

Sun, Jun 4, 8:31 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

update tests

Sun, Jun 4, 8:29 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152091: [InstCombine] precommit test for D152068(NFC).

fix typo

Sun, Jun 4, 8:28 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152091: [InstCombine] precommit test for D152068(NFC).

add splat vector tests

Sun, Jun 4, 8:17 PM · Restricted Project, Restricted Project
khei4 updated the summary of D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Sun, Jun 4, 7:23 PM · Restricted Project, Restricted Project
khei4 updated the summary of D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Sun, Jun 4, 7:22 PM · Restricted Project, Restricted Project
khei4 added inline comments to D152091: [InstCombine] precommit test for D152068(NFC).
Sun, Jun 4, 7:23 AM · Restricted Project, Restricted Project
khei4 committed rGf4eafba2064d: [MemCpyOpt] Remove unnecessary bitcast and reuse some variables for… (authored by khei4).
[MemCpyOpt] Remove unnecessary bitcast and reuse some variables for…
Sun, Jun 4, 12:12 AM · Restricted Project, Restricted Project
khei4 closed D152056: [MemCpyOpt] Remove unnecessary bitcast and reuse some variables for ByValOptimization (NFC).
Sun, Jun 4, 12:12 AM · Restricted Project, Restricted Project

Sat, Jun 3

khei4 added a comment to D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

Thank you for the review!

Sat, Jun 3, 9:38 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

Apply feedback from @goldstein.w.n

Sat, Jun 3, 9:37 PM · Restricted Project, Restricted Project
khei4 requested review of D152091: [InstCombine] precommit test for D152068(NFC).
Sat, Jun 3, 9:35 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.

Rebase for pre-commit test

Sat, Jun 3, 9:12 PM · Restricted Project, Restricted Project
khei4 requested review of D152089: [InstCombine] precommit test for D152088(NFC).
Sat, Jun 3, 9:10 PM · Restricted Project, Restricted Project
khei4 updated the summary of D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Sat, Jun 3, 9:00 PM · Restricted Project, Restricted Project
khei4 requested review of D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.
Sat, Jun 3, 8:59 PM · Restricted Project, Restricted Project
khei4 updated the diff for D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

apply feedback

Sat, Jun 3, 5:55 PM · Restricted Project, Restricted Project
khei4 added a comment to D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

Thank you for the review!

Sat, Jun 3, 5:54 PM · Restricted Project, Restricted Project
khei4 added a comment to D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

This doesn't seem working.

Res->setHasNoSignedWrap(I.hasNoSignedWrap() &&
                             OBO1->hasNoUnsignedWrap() &&
                             willNotOverflowSignedSub(C, C2, *Res));
Sat, Jun 3, 10:14 AM · Restricted Project, Restricted Project
khei4 updated the diff for D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.

rebase

Sat, Jun 3, 9:57 AM · Restricted Project, Restricted Project
khei4 updated the summary of D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Sat, Jun 3, 9:57 AM · Restricted Project, Restricted Project
khei4 updated the diff for D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Sat, Jun 3, 9:56 AM · Restricted Project, Restricted Project
khei4 requested review of D152068: [InstCombine] add overflow checking on AddSub `C-(X+C2) --> (C-C2)-X`.
Sat, Jun 3, 9:31 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

rebase

Sat, Jun 3, 3:26 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

add cases

  • VLA alloca
  • non-alloca destination
Sat, Jun 3, 3:22 AM · Restricted Project, Restricted Project
khei4 retitled D152056: [MemCpyOpt] Remove unnecessary bitcast and reuse some variables for ByValOptimization (NFC) from [MemCpyOpt] Remove unnecessary bitcast for ByValOptimization (NFC) to [MemCpyOpt] Remove unnecessary bitcast and reuse some variables for ByValOptimization (NFC).
Sat, Jun 3, 2:15 AM · Restricted Project, Restricted Project
khei4 requested review of D152056: [MemCpyOpt] Remove unnecessary bitcast and reuse some variables for ByValOptimization (NFC).
Sat, Jun 3, 2:12 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

fix typo

Sat, Jun 3, 1:41 AM · Restricted Project, Restricted Project
khei4 added a comment to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

@nikic
Thanks for the review! Too much obsolete comments!

Sat, Jun 3, 1:33 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

revert wrong diff update

Sat, Jun 3, 1:31 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

apply feedbacks

Sat, Jun 3, 1:30 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).
Sat, Jun 3, 1:29 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

fix

  • wrong tests
  • bigger alignment assumption
  • comments' initial cases
Sat, Jun 3, 12:58 AM · Restricted Project, Restricted Project

Thu, Jun 1

khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Thu, Jun 1, 10:07 AM · Restricted Project, Restricted Project

Wed, May 31

khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Wed, May 31, 5:59 AM · Restricted Project, Restricted Project
khei4 planned changes to D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).
Wed, May 31, 4:14 AM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

tweak

  • add bigger align case
  • reduce unnecessary branch on some tetst
Wed, May 31, 4:14 AM · Restricted Project, Restricted Project
khei4 committed rG6e1f5ea5ec64: [LangRef] fix the function result attributes location explanation and examples… (authored by khei4).
[LangRef] fix the function result attributes location explanation and examples…
Wed, May 31, 2:38 AM · Restricted Project, Restricted Project
khei4 closed D151772: [LangRef] fix the function result attributes location explanation and example.
Wed, May 31, 2:38 AM · Restricted Project, Restricted Project
khei4 retitled D151772: [LangRef] fix the function result attributes location explanation and example from [LangRef] fix the function result attributes location explanation to [LangRef] fix the function result attributes location explanation and example.
Wed, May 31, 2:37 AM · Restricted Project, Restricted Project
khei4 added inline comments to D151772: [LangRef] fix the function result attributes location explanation and example.
Wed, May 31, 1:40 AM · Restricted Project, Restricted Project
khei4 updated the diff for D151772: [LangRef] fix the function result attributes location explanation and example.

change examples also

Wed, May 31, 1:39 AM · Restricted Project, Restricted Project

Tue, May 30

khei4 requested review of D151772: [LangRef] fix the function result attributes location explanation and example.
Tue, May 30, 8:32 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

apply feedback on call with @nikic

  1. remove noalias argument or unescaped alloca checks
  2. add ModRefCheck for memcpy source
Tue, May 30, 2:02 AM · Restricted Project, Restricted Project
khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Tue, May 30, 12:02 AM · Restricted Project, Restricted Project
khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Tue, May 30, 12:01 AM · Restricted Project, Restricted Project

Mon, May 29

khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Mon, May 29, 11:58 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

rebase

Mon, May 29, 11:27 PM · Restricted Project, Restricted Project
khei4 updated the summary of D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.
Mon, May 29, 11:18 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150967: [MemCpyOpt] precommit test for memcpy removal for immutable arguments from attributes (NFC).

add test cases

  • no noalias attributed arg src
  • unescaped alloca src
  • modified between memcpy and call
Mon, May 29, 11:14 PM · Restricted Project, Restricted Project
khei4 planned changes to D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

need to change test on https://reviews.llvm.org/D150967#4365466 and refine description

Mon, May 29, 10:52 PM · Restricted Project, Restricted Project
khei4 updated the diff for D150970: [MemCpyOpt] Use memcpy source directly if dest is known to be immutable from attributes.

process alignment, handle unescaped alloca and arg with noalias, clobber check on Dest of MDep(MemCpy)

Mon, May 29, 10:51 PM · Restricted Project, Restricted Project
khei4 added inline comments to D151631: [InstSimplify] Simplify select i1 ConstExpr, i1 true, i1 false to ConstExpr.
Mon, May 29, 7:10 PM · Restricted Project, Restricted Project
khei4 committed rG0ad88c156ebd: [MemCpyOpt] remove byval from memcpy size crtical test(NFC) (authored by khei4).
[MemCpyOpt] remove byval from memcpy size crtical test(NFC)
Mon, May 29, 12:56 AM · Restricted Project, Restricted Project
khei4 closed D151626: [MemCpyOpt] Remove byval to clarify test case for smaller sized memcpy(NFC).
Mon, May 29, 12:56 AM · Restricted Project, Restricted Project
khei4 updated the diff for D151626: [MemCpyOpt] Remove byval to clarify test case for smaller sized memcpy(NFC).

rebase

Mon, May 29, 12:25 AM · Restricted Project, Restricted Project

Sun, May 28

khei4 retitled D151626: [MemCpyOpt] Remove byval to clarify test case for smaller sized memcpy(NFC) from [MemCpyOpt] remove byval to clarify test case for smaller sized memcpy(NFC) to [MemCpyOpt] Remove byval to clarify test case for smaller sized memcpy(NFC).
Sun, May 28, 11:51 PM · Restricted Project, Restricted Project
khei4 retitled D151626: [MemCpyOpt] Remove byval to clarify test case for smaller sized memcpy(NFC) from [MemCpyOpt] clarify test case for smaller sized memcpy(NFC) to [MemCpyOpt] remove byval to clarify test case for smaller sized memcpy(NFC).
Sun, May 28, 11:51 PM · Restricted Project, Restricted Project