Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (30 w, 1 d)

Recent Activity

Sun, Sep 15

sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Sun, Sep 15, 11:14 PM · Restricted Project
sstefan1 added a comment to D65408: [Attributor] Heap-To-Stack Conversion.

I think the current implementation needs some important fixes to avoid miscompilation/overflow, can you make it off by default, fix issues, and enable it again?

Thanks.

Sun, Sep 15, 11:10 PM · Restricted Project
sstefan1 committed rG431141c5cc34: [Attributor] Heap-To-Stack Conversion (authored by sstefan1).
[Attributor] Heap-To-Stack Conversion
Sun, Sep 15, 2:49 PM

Sat, Sep 14

sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Sat, Sep 14, 2:24 PM · Restricted Project

Wed, Sep 11

sstefan1 accepted D67232: [Attributor][Fix] Initialize the cache prior to using it.
Wed, Sep 11, 1:40 PM · Restricted Project

Fri, Sep 6

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

fix diff

Fri, Sep 6, 4:50 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

small fix

Fri, Sep 6, 4:45 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

addressing comments

Fri, Sep 6, 4:18 PM · Restricted Project
sstefan1 added inline comments to D67232: [Attributor][Fix] Initialize the cache prior to using it.
Fri, Sep 6, 12:06 AM · Restricted Project

Wed, Sep 4

sstefan1 accepted D67191: [Attributor][Fix] Make sure we do not delete live code.

LGTM

Wed, Sep 4, 1:11 PM · Restricted Project

Mon, Sep 2

sstefan1 added a comment to D65408: [Attributor] Heap-To-Stack Conversion.

@xbolva00 I'm sorry this has dragged on a bit.

Mon, Sep 2, 3:55 AM · Restricted Project

Wed, Aug 28

sstefan1 accepted D66562: [Attributor] Restrict liveness and return information to functions.

LGTM.

Wed, Aug 28, 2:44 AM · Restricted Project

Tue, Aug 27

sstefan1 created D66844: getArgOperandNo helper function.
Tue, Aug 27, 4:13 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
  • Small corrections.
Tue, Aug 27, 3:54 PM · Restricted Project

Mon, Aug 26

sstefan1 accepted D66779: [Attributor] Introduce an API to delete stuff.

LGTM.

Mon, Aug 26, 6:42 PM · Restricted Project
sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Mon, Aug 26, 6:20 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
  • remove mistake
Mon, Aug 26, 6:07 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

addressing comments

Mon, Aug 26, 6:05 PM · Restricted Project

Fri, Aug 23

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

Taking a different approach using nocapture and nofree.

Fri, Aug 23, 3:23 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
remove llvm_debug
Fri, Aug 23, 3:23 PM · Restricted Project

Wed, Aug 21

sstefan1 accepted D66551: [Attributor] Manifest constant return values.

This is nice!

Wed, Aug 21, 2:14 PM · Restricted Project
sstefan1 accepted D66484: [Attributor][NFCI] Avoid lookups when resolving returned values.

LGTM

Wed, Aug 21, 2:09 PM · Restricted Project
sstefan1 accepted D66549: [Attributor] FIX: Treat new attributes as changed ones.

LGTM

Wed, Aug 21, 2:03 PM · Restricted Project
sstefan1 accepted D66554: [Attributor][NFCI] Introduce tight iteration bounds in the tests.

LGTM.

Wed, Aug 21, 1:53 PM · Restricted Project

Aug 20 2019

sstefan1 accepted D63315: [Attributor] Regularly clear dependences to remove spurious ones.

LGTM. Except for lack of tests

Aug 20 2019, 4:45 PM · Restricted Project
sstefan1 accepted D63314: [Attributor] Allow explicit dependence tracking.

LGTM.

Aug 20 2019, 4:32 PM · Restricted Project
sstefan1 committed rG26121ae4d047: [Attributor] Liveness for internal functions. (authored by sstefan1).
[Attributor] Liveness for internal functions.
Aug 20 2019, 4:18 PM
sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
addressing comments
Aug 20 2019, 8:33 AM · Restricted Project
sstefan1 added inline comments to D66155: [Attributor] Liveness for internal functions..
Aug 20 2019, 2:18 AM · Restricted Project

Aug 19 2019

sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • small update
  • Attributor::isAssumedDead() fix
Aug 19 2019, 1:17 PM · Restricted Project
sstefan1 committed rG8682281063d6: [Attributor] -attributor-verify has false positives. Temporarily remove it… (authored by sstefan1).
[Attributor] -attributor-verify has false positives. Temporarily remove it…
Aug 19 2019, 9:46 AM

Aug 18 2019

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
  • minor fix
Aug 18 2019, 2:53 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

Providing an implementation for the conversion. This is few commits behind fromt the latest Attributor, will be rebased.

Aug 18 2019, 2:50 PM · Restricted Project

Aug 16 2019

sstefan1 accepted D66258: [Attributor] Introduce initialize calls and move code to keep attributes concise.

LGTM

Aug 16 2019, 8:45 AM · Restricted Project

Aug 14 2019

sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • add scc test
Aug 14 2019, 4:05 PM · Restricted Project
sstefan1 added inline comments to D66155: [Attributor] Liveness for internal functions..
Aug 14 2019, 3:13 PM · Restricted Project
sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • Replace dead functions with undef
Aug 14 2019, 3:04 PM · Restricted Project
sstefan1 added a comment to D66207: [Attributor] Deduce "noalias" attribute.

Minor comments

Aug 14 2019, 2:56 AM · Restricted Project

Aug 13 2019

sstefan1 accepted D66120: [Attributor] Use liveness during the creation of AAReturnedValues.

LGTM.

Aug 13 2019, 3:47 PM · Restricted Project
sstefan1 accepted D65977: [Attributor] Use IRPosition consistently.

LGTM.

Aug 13 2019, 3:26 PM · Restricted Project
sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • adding tests & helper function
Aug 13 2019, 2:55 PM · Restricted Project
sstefan1 created D66155: [Attributor] Liveness for internal functions..
Aug 13 2019, 11:05 AM · Restricted Project

Aug 12 2019

sstefan1 accepted D66116: [Attributor] Do not update or manifest dead attributes.

LGTM.

Aug 12 2019, 10:22 PM · Restricted Project

Aug 9 2019

sstefan1 added a comment to D65977: [Attributor] Use IRPosition consistently.

Generally looks good to me. Some initial comments inlined. Since it is a big patch I'd also wait for Hideto to read it. (Maybe I'll reread it as well.)

Aug 9 2019, 6:37 AM · Restricted Project

Aug 7 2019

sstefan1 committed rGaaa5270c5362: [Attributor] Introduce checkForAllReadWriteInstructions(...). (authored by sstefan1).
[Attributor] Introduce checkForAllReadWriteInstructions(...).
Aug 7 2019, 11:26 AM
sstefan1 updated the diff for D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...)..
  • address comment.
Aug 7 2019, 10:37 AM · Restricted Project
sstefan1 added inline comments to D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...)..
Aug 7 2019, 5:08 AM · Restricted Project

Aug 6 2019

sstefan1 created D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...)..
Aug 6 2019, 1:20 PM · Restricted Project
sstefan1 added a comment to D65733: [Attributor] Provide easier checkForallReturnedValues functionality.

This looks good. Just one comment inlined:

Aug 6 2019, 9:16 AM · Restricted Project
sstefan1 added a comment to D65786: [Attributor] Introduce a state wrapper class.

LGTM with one question. Maybe this is an overkill, but do we even need to have isAssumed*AAType* as well as isKnown (eg. isAssumedNoFree())? I'm just thinking out loud.

Aug 6 2019, 5:42 AM · Restricted Project

Aug 4 2019

sstefan1 accepted D65731: [Attributor] Provide a generic interface to check live instructions.

LGTM.

Aug 4 2019, 5:07 PM · Restricted Project
sstefan1 accepted D65712: [Attributor] Introduce the IRAttribute helper struct.

LGTM.

Aug 4 2019, 5:07 PM · Restricted Project
sstefan1 accepted D65711: [Attributor][NFCI] Make abstract attributes stateless.

Comment discussed on irc and agreed to be done in another patch.

Aug 4 2019, 5:05 PM · Restricted Project
sstefan1 added a comment to D65711: [Attributor][NFCI] Make abstract attributes stateless.

I really like both this and D65712. This makes things much cleaner imo. One more question, since D65712 also simplifies some things from this patch, wouldn't it be easier to just make it in one review?

Aug 4 2019, 4:46 PM · Restricted Project

Aug 3 2019

sstefan1 accepted D65701: [Attributor][Fix] Resolve various liveness issues.

LGTM.

Aug 3 2019, 12:47 PM · Restricted Project
sstefan1 committed rG7849e4163583: [Attributor][NFC] run clang-format on Attributor.cpp (authored by sstefan1).
[Attributor][NFC] run clang-format on Attributor.cpp
Aug 3 2019, 8:32 AM
sstefan1 added a comment to rGd021617bf7e1: [Attributor] Using liveness in other attributes..

I think this commit is not clang-formatted. Please make sure clang-format before commit.

Aug 3 2019, 8:14 AM

Aug 2 2019

sstefan1 committed rGd021617bf7e1: [Attributor] Using liveness in other attributes. (authored by sstefan1).
[Attributor] Using liveness in other attributes.
Aug 2 2019, 2:32 PM

Aug 1 2019

sstefan1 added a comment to D65243: [Attributor] Using liveness in other attributes..

Could you add one more test case:

internal function foo, called 2 times but one call site is dead. We want to derive something about foo from the call site.

Is this what you had in mind?

Aug 1 2019, 5:10 AM · Restricted Project
sstefan1 updated the diff for D65243: [Attributor] Using liveness in other attributes..
  • Added 1 test case, addressed comments.
Aug 1 2019, 5:04 AM · Restricted Project

Jul 31 2019

sstefan1 updated the diff for D65243: [Attributor] Using liveness in other attributes..
  • removed leftover comments
Jul 31 2019, 9:09 AM · Restricted Project
sstefan1 updated the diff for D65243: [Attributor] Using liveness in other attributes..
  • addressing comments.
Jul 31 2019, 9:09 AM · Restricted Project

Jul 30 2019

sstefan1 added inline comments to D65377: [FunctionAttrs] Annotate intrinsics with nosync.
Jul 30 2019, 10:33 PM · Restricted Project
sstefan1 added a comment to D65408: [Attributor] Heap-To-Stack Conversion.

Top-level functions declarations should have attributes to make them as restricted as needed, e.g. sync_func should probably be nofree or renamed to sync_free_func.

Yes. I'll refine them along the way.

Jul 30 2019, 4:32 AM · Restricted Project
sstefan1 updated the diff for D65243: [Attributor] Using liveness in other attributes..
  • Fixing returnedvalues issues and some minor fixes
Jul 30 2019, 2:23 AM · Restricted Project

Jul 29 2019

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
chenge function names
Jul 29 2019, 1:57 PM · Restricted Project
sstefan1 created D65408: [Attributor] Heap-To-Stack Conversion.
Jul 29 2019, 10:44 AM · Restricted Project

Jul 28 2019

sstefan1 created D65377: [FunctionAttrs] Annotate intrinsics with nosync.
Jul 28 2019, 9:59 AM · Restricted Project

Jul 26 2019

sstefan1 updated the diff for D65243: [Attributor] Using liveness in other attributes..
  • adding instruction-wise is Assumed/Known Dead checks. This resolves FIXME in TEST 2.
  • addressing comments
Jul 26 2019, 1:11 PM · Restricted Project

Jul 25 2019

sstefan1 added inline comments to D59978: [Attributor] Deduce the "no-return" attribute for functions.
Jul 25 2019, 5:01 AM · Restricted Project

Jul 24 2019

sstefan1 created D65243: [Attributor] Using liveness in other attributes..
Jul 24 2019, 2:18 PM · Restricted Project

Jul 22 2019

sstefan1 committed rG6058b8637399: Fixing build error from commit 95cbc3d (authored by sstefan1).
Fixing build error from commit 95cbc3d
Jul 22 2019, 4:59 PM
sstefan1 committed rG5a9ba27c719b: Revert "Fixing build error from commit 9285295." (authored by sstefan1).
Revert "Fixing build error from commit 9285295."
Jul 22 2019, 3:59 PM
sstefan1 added a reverting change for rG95cbc3da8871: Fixing build error from commit 9285295.: rG5a9ba27c719b: Revert "Fixing build error from commit 9285295.".
Jul 22 2019, 3:58 PM
sstefan1 committed rG95cbc3da8871: Fixing build error from commit 9285295. (authored by sstefan1).
Fixing build error from commit 9285295.
Jul 22 2019, 3:15 PM
sstefan1 committed rG9285295f75a2: [Attributor] Liveness analysis. (authored by sstefan1).
[Attributor] Liveness analysis.
Jul 22 2019, 1:55 PM
sstefan1 committed rG69ebb02001f5: [Attributor] NoAlias on return values. (authored by sstefan1).
[Attributor] NoAlias on return values.
Jul 22 2019, 12:40 PM
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • Make changeToCall available from Local.h
  • address comments
Jul 22 2019, 10:46 AM · Restricted Project

Jul 20 2019

sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..
  • removing unnecessary llvm_debug
Jul 20 2019, 1:38 PM · Restricted Project
sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..

Rebased and added more tests.

Jul 20 2019, 1:37 PM · Restricted Project

Jul 19 2019

sstefan1 retitled D64162: [Attributor] Liveness analysis. from Summary: [Attributor] Liveness analysis abstract attribute used to indicate which BasicBlocks are dead and can therefore be ignored. to [Attributor] Liveness analysis..
Jul 19 2019, 3:56 PM · Restricted Project
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • Rebased and added AANoReturn declaration.
  • ninja check-all & test-suite passed fine.
Jul 19 2019, 3:52 PM · Restricted Project
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • addressing comments.
Jul 19 2019, 5:51 AM · Restricted Project

Jul 18 2019

sstefan1 added a comment to D53362: [Prototype] Heap-To-Stack Conversion Pass.

Hi Hal! Are you planning on working on this one? If not maybe I can take over? Now that we have nofree & nosync added and deduced in the Attributor, maybe this can be revisited.

Jul 18 2019, 1:12 PM
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • explorePath now returns false only if starting point is a noreturn call that is still noreturn.
Jul 18 2019, 8:28 AM · Restricted Project
sstefan1 added inline comments to D64162: [Attributor] Liveness analysis..
Jul 18 2019, 8:25 AM · Restricted Project

Jul 16 2019

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • addressing comments
Jul 16 2019, 9:31 AM · Restricted Project
sstefan1 added inline comments to D64162: [Attributor] Liveness analysis..
Jul 16 2019, 9:31 AM · Restricted Project

Jul 15 2019

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • More tests.
  • Small changes.
Jul 15 2019, 3:56 PM · Restricted Project
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • addressing comments
Jul 15 2019, 9:26 AM · Restricted Project
sstefan1 added inline comments to D64162: [Attributor] Liveness analysis..
Jul 15 2019, 9:25 AM · Restricted Project

Jul 13 2019

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • Change initialize, explore paths.
Jul 13 2019, 10:58 AM · Restricted Project

Jul 12 2019

sstefan1 committed rGcb5ecae1f6fe: Addition to rL365925, removing remaining virtuals (authored by sstefan1).
Addition to rL365925, removing remaining virtuals
Jul 12 2019, 11:36 AM
sstefan1 committed rG15e86f707b15: [Attributor] Removing unnecessary `virtual` keywords. (authored by sstefan1).
[Attributor] Removing unnecessary `virtual` keywords.
Jul 12 2019, 10:43 AM
sstefan1 added a comment to D63604: [Attributor] Deduce "nonnull" attribute.

We accumulated some unnecessary virtual declarations in the Attributor. I created D64637 to remove them in already committed patches. It would be good if you remove them in your active patches too.

Jul 12 2019, 8:01 AM · Restricted Project
sstefan1 created D64637: [Attributor] Removing unnecessary `virtual` keywords..
Jul 12 2019, 7:53 AM · Restricted Project

Jul 11 2019

sstefan1 committed rG0626367202ce: [Attributor] Deduce "nosync" function attribute. (authored by sstefan1).
[Attributor] Deduce "nosync" function attribute.
Jul 11 2019, 2:39 PM

Jul 10 2019

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • rebase
  • addressing comments
  • ninja check-all passed
Jul 10 2019, 10:38 AM · Restricted Project

Jul 9 2019

sstefan1 added inline comments to D62766: [Attributor] Deduce "nosync" function attribute..
Jul 9 2019, 1:45 AM · Restricted Project

Jul 8 2019

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • non-convergent and readnone check.
  • Changed handling of intrinsics.
  • Added more tests.
Jul 8 2019, 11:36 AM · Restricted Project