- User Since
- Feb 20 2019, 7:26 AM (82 w, 4 d)
I think you should split this in two patches. One that introduces the IR attribite and one for attributor deduction.
Wed, Sep 9
Sorry for the delay.
Looks like parallel_deletion.ll needs to be updated as well.
Looks same as the failures before. I may be able to do a windows build next week and try to see what is going on.
Mon, Sep 7
Actually windows tests passed, I was looking at the wrong place.
I remember this being windows only issue. I was able to always reproduce it on windows, but never had the chance to look into it.
Thu, Sep 3
Mon, Aug 31
Sun, Aug 30
Sat, Aug 29
Fri, Aug 28
Rebasing after recent changes to AANoUndef
Wed, Aug 26
Don't skip ;\n comments
Sorry for the delay on this.
Are you going to move the AAIsDead query to the update?
Thanks for the explanation. Since the patch is not small and it is a WIP, can you add some more information about the failing tests? Maybe some specific examples?
Tue, Aug 25
Mon, Aug 24
What should be the next step here? There was no response on the RFC update.
Does the fix for the performance issue seem ok?
Sat, Aug 22
Aug 21 2020
We can't delete functions outside of the SCC, the rest should be fine.
Aug 20 2020
Thanks for reporting this.
Numbers are similar in the release mode as well. The problem was that we go through all IntrProperties for every Intrinsic in search for ones that are default. However that can be done only once.
fix slowdown issue
Aug 19 2020
Aug 18 2020
Maybe the commit message could be a bit more descriptive?
Aug 17 2020
update affected tests.
add comment for DisableDefaultAttributes flag.
Can we move forward with this approach?
update gc intrinsics to DefaultIntrinsic
Aug 16 2020
Add DefaultIntrinsic class with default attributes disabled.
- Remove hasTrackedValue()
- Add AAICVTrackerCallSite
- Move manifest to AAICVTrackerCallSite
- Only register callsite AAs for getters.
Aug 15 2020
Aug 14 2020
actually make it work when multiple check prefixes are provided
Aug 13 2020
Aug 12 2020
This can be closed, right?
Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.
Good parts of this are merged in D85544.
Introduce 2 new AAs
Merge good parts of D85052
At first, I thought it wouldn't be very useful to have AAs for multiple positions since we only interact with the function one.
Now that I actually tried to make it work, turns out it is quiet a nice clean up and makes much more sense.
Aug 11 2020
don't track values in weak functions
Unclear if we still want D85052 to go in before this, since most of the login is replaced with this patch.
- worklist approach
- don't use MBEC explorer
- more tests
Aug 10 2020
IMHO, these few lines don't make much of a difference wrt the size of the patch. Maybe just merge them?
Aug 8 2020
adding more tests
Aug 7 2020
Better commit message.
Will add more tests tomorrow.
Note: I've added D85052 as a parent revision. However this can also be considered as a slight change in approach. If needed, those 2 can be merged together.
Aug 3 2020
lgtm, apart from clang tests. Someone else should take a look as well, though.
cover "maybe written" by another unkown call case and add test for that.
Aug 2 2020
Aug 1 2020
We are now able to check if call changes an ICV through function attribute. Follow up should make it possible to get an ICV value for a call.