Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (82 w, 4 d)

Recent Activity

Yesterday

sstefan1 added a comment to D87975: [IR] MaxObjSize Attribute.

I think you should split this in two patches. One that introduces the IR attribite and one for attributor deduction.

Sat, Sep 19, 3:11 PM · Restricted Project

Wed, Sep 9

sstefan1 added a comment to D86127: [Attributor] Make AAMemoryLocationCallSite behavior sane.

Sorry for the delay.

Wed, Sep 9, 11:58 PM · Restricted Project
sstefan1 accepted D87432: [Attributor] Disable the MustBeExecutedContext by default.

Looks like parallel_deletion.ll needs to be updated as well.

Wed, Sep 9, 11:50 PM · Restricted Project
sstefan1 added a comment to D87266: [Attributor] Re-enable a run line in noalias.ll.

Looks same as the failures before. I may be able to do a windows build next week and try to see what is going on.

Wed, Sep 9, 8:54 AM · Restricted Project

Mon, Sep 7

sstefan1 accepted D87266: [Attributor] Re-enable a run line in noalias.ll.

Actually windows tests passed, I was looking at the wrong place.

Mon, Sep 7, 11:56 PM · Restricted Project
sstefan1 added a comment to D87266: [Attributor] Re-enable a run line in noalias.ll.

I remember this being windows only issue. I was able to always reproduce it on windows, but never had the chance to look into it.

Mon, Sep 7, 11:52 PM · Restricted Project

Thu, Sep 3

sstefan1 accepted D87104: [OpenMPOpt] Assume indirect call always changes ICV.

LGTM, thanks!

Thu, Sep 3, 11:01 PM · Restricted Project

Mon, Aug 31

sstefan1 added inline comments to D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
Mon, Aug 31, 11:39 PM · Restricted Project

Sun, Aug 30

sstefan1 committed rG5dfd7cc46c8d: Reland [OpenMPOpt] ICV tracking for calls (authored by sstefan1).
Reland [OpenMPOpt] ICV tracking for calls
Sun, Aug 30, 2:30 AM
sstefan1 closed D85544: [OpenMPOpt] ICV tracking for calls.
Sun, Aug 30, 2:30 AM · Restricted Project
sstefan1 committed rG8d8ce85b235c: [Attributor] Introduce module slice. (authored by sstefan1).
[Attributor] Introduce module slice.
Sun, Aug 30, 1:59 AM
sstefan1 closed D86319: [Attributor] Introduce module slice..
Sun, Aug 30, 1:59 AM · Restricted Project
sstefan1 committed rGef018236945f: [OpenMPOpt][NFC] add reproducer for problem found in D85544 (authored by sstefan1).
[OpenMPOpt][NFC] add reproducer for problem found in D85544
Sun, Aug 30, 1:01 AM

Sat, Aug 29

sstefan1 committed rG6ce5b74b82ab: [Attributor][NFC] rerun update_test_checks without --scrub-attributes (authored by sstefan1).
[Attributor][NFC] rerun update_test_checks without --scrub-attributes
Sat, Aug 29, 10:36 AM
sstefan1 committed rGb5dd2cd27f62: [UpdateTestChecks] Don't skip attributes when comparing functions (authored by sstefan1).
[UpdateTestChecks] Don't skip attributes when comparing functions
Sat, Aug 29, 6:38 AM

Fri, Aug 28

sstefan1 committed rG7128e647063d: [UpdateTestChecks] include { in function signature check line (authored by sstefan1).
[UpdateTestChecks] include { in function signature check line
Fri, Aug 28, 2:45 PM
sstefan1 closed D86769: [UpdateTestChecks] include { in function signature check line.
Fri, Aug 28, 2:45 PM · Restricted Project, Restricted Project
sstefan1 added inline comments to D86319: [Attributor] Introduce module slice..
Fri, Aug 28, 7:47 AM · Restricted Project
sstefan1 updated the diff for D86319: [Attributor] Introduce module slice..

Rebasing after recent changes to AANoUndef

Fri, Aug 28, 7:46 AM · Restricted Project
sstefan1 updated the summary of D86769: [UpdateTestChecks] include { in function signature check line.
Fri, Aug 28, 1:27 AM · Restricted Project, Restricted Project
sstefan1 updated the summary of D86769: [UpdateTestChecks] include { in function signature check line.
Fri, Aug 28, 1:26 AM · Restricted Project, Restricted Project
sstefan1 requested review of D86769: [UpdateTestChecks] include { in function signature check line.
Fri, Aug 28, 1:25 AM · Restricted Project, Restricted Project

Wed, Aug 26

sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Don't skip ;\n comments

Wed, Aug 26, 12:21 PM · Restricted Project
sstefan1 requested review of D86650: [Attributor][NFC] Run update_test_checks.py to check for attributes at the end..
Wed, Aug 26, 12:11 PM · Restricted Project
sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Sorry for the delay on this.

Wed, Aug 26, 11:57 AM · Restricted Project
sstefan1 added a comment to D86565: [Attributor] Do not manifest noundef for dead positions.

Are you going to move the AAIsDead query to the update?

Wed, Aug 26, 6:15 AM · Restricted Project
sstefan1 committed rG99d18f79646c: Reland [IR] Intrinsics default attributes and opt-out flag (authored by sstefan1).
Reland [IR] Intrinsics default attributes and opt-out flag
Wed, Aug 26, 2:41 AM
sstefan1 closed D70365: intrinsics attribute opt-out list proposal..
Wed, Aug 26, 2:41 AM · Restricted Project
sstefan1 added a comment to D86587: [WIP][Attributor] Per function iteration and memory tracking..

Thanks for the explanation. Since the patch is not small and it is a WIP, can you add some more information about the failing tests? Maybe some specific examples?

Wed, Aug 26, 1:48 AM · Restricted Project

Tue, Aug 25

sstefan1 added a comment to D86565: [Attributor] Do not manifest noundef for dead positions.

LGTM, one minor note. The test will be part of the module slice patch, I'm fairly certain this cannot be tested right now but it makes sense.

Tue, Aug 25, 2:12 PM · Restricted Project

Mon, Aug 24

sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

What should be the next step here? There was no response on the RFC update.

Mon, Aug 24, 3:04 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

Does the fix for the performance issue seem ok?

Mon, Aug 24, 3:04 PM · Restricted Project

Sat, Aug 22

sstefan1 accepted D86396: [Attributor] Change AANoUndef not to deduce noundef for dead returned positions.

LGTM, thanks!

Sat, Aug 22, 7:41 AM · Restricted Project

Aug 21 2020

sstefan1 added inline comments to D86300: [OpenMPOpt][SplitMemTransfer] Getting values stored in offload arrays.
Aug 21 2020, 2:56 AM · Restricted Project, Restricted Project
sstefan1 committed rG90e0a0212916: [Attributor][NFC] run update_test_checks with --check-attributes. (authored by sstefan1).
[Attributor][NFC] run update_test_checks with --check-attributes.
Aug 21 2020, 2:14 AM
sstefan1 accepted D86129: [Attributor] Function seed allow list.

LGTM.

Aug 21 2020, 1:25 AM · Restricted Project
sstefan1 added a comment to D86319: [Attributor] Introduce module slice..

This is interesting, I thought you couldn't change the IR outside of the current SCC.

We can't delete functions outside of the SCC, the rest should be fine.

Aug 21 2020, 1:19 AM · Restricted Project

Aug 20 2020

sstefan1 requested review of D86319: [Attributor] Introduce module slice..
Aug 20 2020, 3:25 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

After this patch, llvm-tblgen in debug mode is 10x slower:
Before:

$ time bin/llvm-tblgen -gen-global-isel -I ../llvm/test/TableGen/../../include -I ..//llvm/test/TableGen/Common -optimize-match-table=true ../llvm/test/TableGen/GlobalISelEmitter.td -o /tmp/test.cpp

real	0m1.238s
user	0m0.970s
sys	0m0.274s

After:

$ time bin/llvm-tblgen -gen-global-isel -I ../llvm/test/TableGen/../../include -I ..//llvm/test/TableGen/Common -optimize-match-table=true ../llvm/test/TableGen/GlobalISelEmitter.td -o /tmp/test.cpp

real	0m11.671s
user	0m11.607s
sys	0m0.067s

Thanks for reporting this.
Numbers are similar in the release mode as well. The problem was that we go through all IntrProperties for every Intrinsic in search for ones that are default. However that can be done only once.

Aug 20 2020, 12:56 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

fix slowdown issue

Aug 20 2020, 12:56 AM · Restricted Project

Aug 19 2020

sstefan1 committed rGb0b32e649011: [OpenMPOpt] ICV tracking for calls (authored by sstefan1).
[OpenMPOpt] ICV tracking for calls
Aug 19 2020, 2:45 AM
sstefan1 closed D85544: [OpenMPOpt] ICV tracking for calls.
Aug 19 2020, 2:44 AM · Restricted Project
sstefan1 committed rGeedf18fc1f5f: [IR] Intrinsics default attributes and opt-out flag (authored by sstefan1).
[IR] Intrinsics default attributes and opt-out flag
Aug 19 2020, 1:53 AM
sstefan1 closed D70365: intrinsics attribute opt-out list proposal..
Aug 19 2020, 1:53 AM · Restricted Project
sstefan1 added inline comments to D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
Aug 19 2020, 12:30 AM · Restricted Project
sstefan1 added inline comments to D86155: [OpenMPOpt][SplitMemTransfer] Moving the "wait" down.
Aug 19 2020, 12:28 AM · Restricted Project

Aug 18 2020

sstefan1 added a comment to D86129: [Attributor] Function seed allow list.

Maybe the commit message could be a bit more descriptive?

Aug 18 2020, 1:40 AM · Restricted Project

Aug 17 2020

sstefan1 added inline comments to D85544: [OpenMPOpt] ICV tracking for calls.
Aug 17 2020, 2:14 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

addressing comments

Aug 17 2020, 2:14 PM · Restricted Project
sstefan1 added inline comments to D85932: [UpdateTestChecks] Match 'attributes #' at the end.
Aug 17 2020, 1:42 PM · Restricted Project
sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

addressing comments

Aug 17 2020, 1:42 PM · Restricted Project
sstefan1 updated the summary of D70365: intrinsics attribute opt-out list proposal..
Aug 17 2020, 11:24 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

update affected tests.

Aug 17 2020, 11:21 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

add comment for DisableDefaultAttributes flag.

Aug 17 2020, 10:46 AM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

Ping.
Can we move forward with this approach?

Aug 17 2020, 9:33 AM · Restricted Project
sstefan1 added inline comments to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..
Aug 17 2020, 1:58 AM · Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

update gc intrinsics to DefaultIntrinsic

Aug 17 2020, 1:57 AM · Restricted Project

Aug 16 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Add DefaultIntrinsic class with default attributes disabled.

Aug 16 2020, 4:48 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.
  • Remove hasTrackedValue()
Aug 16 2020, 3:41 PM · Restricted Project
sstefan1 added inline comments to D85544: [OpenMPOpt] ICV tracking for calls.
Aug 16 2020, 3:40 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.
  • Add AAICVTrackerCallSite
  • Move manifest to AAICVTrackerCallSite
  • Only register callsite AAs for getters.
Aug 16 2020, 3:40 PM · Restricted Project

Aug 15 2020

sstefan1 added inline comments to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..
Aug 15 2020, 4:06 PM · Restricted Project
sstefan1 requested review of D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..
Aug 15 2020, 10:28 AM · Restricted Project

Aug 14 2020

sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

actually make it work when multiple check prefixes are provided

Aug 14 2020, 7:15 AM · Restricted Project

Aug 13 2020

sstefan1 added inline comments to D85932: [UpdateTestChecks] Match 'attributes #' at the end.
Aug 13 2020, 1:51 PM · Restricted Project
sstefan1 requested review of D85932: [UpdateTestChecks] Match 'attributes #' at the end.
Aug 13 2020, 1:49 PM · Restricted Project

Aug 12 2020

sstefan1 closed D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

Closed with: https://github.com/llvm/llvm-project/commit/6f0d99d2b9b3b8ae96dd91c8988cc067b9c9afb9

Aug 12 2020, 1:50 PM · Restricted Project, Restricted Project
sstefan1 added inline comments to D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin.
Aug 12 2020, 11:23 AM · Restricted Project
sstefan1 added a comment to D80051: [OpenMPOpt] Test case 1 - Latency Hiding for Host to Device Memory Transfers.

This can be closed, right?

Aug 12 2020, 11:14 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D85840: [OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?.

Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.

Aug 12 2020, 11:12 AM · Restricted Project
sstefan1 updated the summary of D85544: [OpenMPOpt] ICV tracking for calls.
Aug 12 2020, 10:02 AM · Restricted Project
sstefan1 abandoned D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

Good parts of this are merged in D85544.

Aug 12 2020, 10:01 AM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

Introduce 2 new AAs
Merge good parts of D85052

Aug 12 2020, 9:56 AM · Restricted Project
sstefan1 added a comment to D85544: [OpenMPOpt] ICV tracking for calls.

At first, I thought it wouldn't be very useful to have AAs for multiple positions since we only interact with the function one.
Now that I actually tried to make it work, turns out it is quiet a nice clean up and makes much more sense.

Aug 12 2020, 8:41 AM · Restricted Project

Aug 11 2020

sstefan1 accepted D85700: [Attributor][NFC] Reformat tests after D85099.

LGTM

Aug 11 2020, 4:18 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

don't track values in weak functions

Aug 11 2020, 4:17 PM · Restricted Project
sstefan1 added a comment to D85544: [OpenMPOpt] ICV tracking for calls.

Unclear if we still want D85052 to go in before this, since most of the login is replaced with this patch.

Aug 11 2020, 1:16 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.
  • worklist approach
  • don't use MBEC explorer
  • more tests
Aug 11 2020, 1:11 PM · Restricted Project

Aug 10 2020

sstefan1 added a comment to D85639: [Attributor] Fix bug in operator of PotentialValuesState.

IMHO, these few lines don't make much of a difference wrt the size of the patch. Maybe just merge them?

Aug 10 2020, 6:18 AM · Restricted Project

Aug 8 2020

sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

adding more tests

Aug 8 2020, 8:19 AM · Restricted Project

Aug 7 2020

sstefan1 updated the summary of D85544: [OpenMPOpt] ICV tracking for calls.
Aug 7 2020, 2:09 PM · Restricted Project
sstefan1 updated the diff for D85544: [OpenMPOpt] ICV tracking for calls.

Better commit message.
Will add more tests tomorrow.

Aug 7 2020, 2:08 PM · Restricted Project
sstefan1 added a comment to D85544: [OpenMPOpt] ICV tracking for calls.

Note: I've added D85052 as a parent revision. However this can also be considered as a slight change in approach. If needed, those 2 can be merged together.

Aug 7 2020, 12:18 PM · Restricted Project
sstefan1 requested review of D85544: [OpenMPOpt] ICV tracking for calls.
Aug 7 2020, 12:12 PM · Restricted Project

Aug 3 2020

sstefan1 added a comment to D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+".

lgtm, apart from clang tests. Someone else should take a look as well, though.

Aug 3 2020, 2:38 PM · Restricted Project, Restricted Project
sstefan1 updated the diff for D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

cover "maybe written" by another unkown call case and add test for that.

Aug 3 2020, 12:01 PM · Restricted Project
sstefan1 added inline comments to D83283: [Attributor] AAPotentialValues Interface.
Aug 3 2020, 12:58 AM · Restricted Project

Aug 2 2020

sstefan1 added inline comments to D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.
Aug 2 2020, 1:41 PM · Restricted Project
sstefan1 updated the diff for D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

addressing comments

Aug 2 2020, 1:31 PM · Restricted Project

Aug 1 2020

sstefan1 added a comment to D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

This is still "intra-procedural", correct? Or can it replace across function boundaries too?

We are now able to check if call changes an ICV through function attribute. Follow up should make it possible to get an ICV value for a call.

Aug 1 2020, 1:36 PM · Restricted Project

Jul 31 2020

sstefan1 requested review of D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.
Jul 31 2020, 3:17 PM · Restricted Project

Jul 19 2020

sstefan1 committed rGe3d646c699f1: [Attributor][NFC] applying update_test_checks with --check-attributes (authored by sstefan1).
[Attributor][NFC] applying update_test_checks with --check-attributes
Jul 19 2020, 11:19 PM
sstefan1 closed D84130: [Attributor][NFC] applying update_test_checks with --check-attributes.
Jul 19 2020, 11:19 PM · Restricted Project
sstefan1 resigned from D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Jul 19 2020, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D84130: [Attributor][NFC] applying update_test_checks with --check-attributes: Restricted Project.
Jul 19 2020, 12:58 PM · Restricted Project
sstefan1 committed rGcf1105069648: [Utils][Fix] remove unnecessary ; at the end (authored by sstefan1).
[Utils][Fix] remove unnecessary ; at the end
Jul 19 2020, 11:49 AM
sstefan1 committed rG937bad3594e7: [Utils] Check function attributes in update_test_checks (authored by sstefan1).
[Utils] Check function attributes in update_test_checks
Jul 19 2020, 11:22 AM
sstefan1 closed D83629: [Utils] Check function attributes in update_test_checks.
Jul 19 2020, 11:22 AM · Restricted Project, Restricted Project
sstefan1 added inline comments to D83629: [Utils] Check function attributes in update_test_checks.
Jul 19 2020, 4:21 AM · Restricted Project, Restricted Project
sstefan1 updated subscribers of D83629: [Utils] Check function attributes in update_test_checks.
Jul 19 2020, 3:48 AM · Restricted Project, Restricted Project