Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (121 w, 5 d)

Recent Activity

May 13 2021

sstefan1 accepted D102444: [Attributor] Add interface to emit remarks in Attributor.

Maybe we can have a test for this? Otherwise LGTM.

May 13 2021, 11:32 PM · Restricted Project, Restricted Project

May 7 2021

sstefan1 added inline comments to D101701: [nofree] Refine concurrency requirements.
May 7 2021, 7:56 AM · Restricted Project

May 5 2021

sstefan1 added a comment to D101701: [nofree] Refine concurrency requirements.

I am neutral on the proposed change, but I would very much like to hear from @sstefan1, the original author of the nofree attribute.

May 5 2021, 12:33 AM · Restricted Project

Apr 22 2021

sstefan1 accepted D98608: [Attributor] Make sure Heap2Stack works properly on a GPU target.
Apr 22 2021, 12:44 PM · Restricted Project
sstefan1 added inline comments to D98608: [Attributor] Make sure Heap2Stack works properly on a GPU target.
Apr 22 2021, 12:40 PM · Restricted Project

Apr 21 2021

sstefan1 committed rG62cdcd6c5aee: [FuncAttrs] Don't infer willreturn for nonexact definitions (authored by sstefan1).
[FuncAttrs] Don't infer willreturn for nonexact definitions
Apr 21 2021, 12:28 PM
sstefan1 closed D100988: [FuncAttrs] Don't infer willreturn for nonexact definitions.
Apr 21 2021, 12:27 PM · Restricted Project
sstefan1 updated the summary of D100988: [FuncAttrs] Don't infer willreturn for nonexact definitions.
Apr 21 2021, 12:08 PM · Restricted Project
sstefan1 requested review of D100988: [FuncAttrs] Don't infer willreturn for nonexact definitions.
Apr 21 2021, 12:06 PM · Restricted Project
sstefan1 committed rG656ebd519e3f: [SimplifyLibCalls] Don't change alignment when creating memset (authored by sstefan1).
[SimplifyLibCalls] Don't change alignment when creating memset
Apr 21 2021, 11:42 AM
sstefan1 closed D100875: [SimplifyLibCalls] Don't change alignment when creating memset.
Apr 21 2021, 11:42 AM · Restricted Project
sstefan1 added a comment to D100875: [SimplifyLibCalls] Don't change alignment when creating memset.

Looks ok as a fix. I am just wondering if some other places should be checked as well.

Apr 21 2021, 11:02 AM · Restricted Project
sstefan1 added a comment to D100875: [SimplifyLibCalls] Don't change alignment when creating memset.

@lebedev.ri good to go?

Apr 21 2021, 8:20 AM · Restricted Project

Apr 20 2021

sstefan1 updated the diff for D100875: [SimplifyLibCalls] Don't change alignment when creating memset.

update comment

Apr 20 2021, 2:33 PM · Restricted Project
sstefan1 added inline comments to D100875: [SimplifyLibCalls] Don't change alignment when creating memset.
Apr 20 2021, 2:33 PM · Restricted Project
sstefan1 updated the summary of D100875: [SimplifyLibCalls] Don't change alignment when creating memset.
Apr 20 2021, 11:56 AM · Restricted Project
sstefan1 retitled D100875: [SimplifyLibCalls] Don't change alignment when creating memset from [SimplifyLibCalls] Don't change alignment when creating memset Fix for PR49984 to [SimplifyLibCalls] Don't change alignment when creating memset.
Apr 20 2021, 11:09 AM · Restricted Project
sstefan1 requested review of D100875: [SimplifyLibCalls] Don't change alignment when creating memset.
Apr 20 2021, 11:08 AM · Restricted Project

Apr 13 2021

sstefan1 added a comment to D100339: [Attributor] Run lightweight version of the Attributor by default..

I just want to mention that this is just a starting point, as suggested in D99769. It is definitely not our attention to rush and do this without an RFC or numbers that are in favour of the switch.

Apr 13 2021, 12:17 PM · Restricted Project
sstefan1 added a comment to D100339: [Attributor] Run lightweight version of the Attributor by default..

Interesting. Do we have near term plans for adding the Attributor to the default pass pipeline ?

That's the plan. We'll see how it goes.

Consider using @nikic's llvm compile time tracker for this patch and/or for full enablement of attributor.

http://llvm-compile-time-tracker.com/about.php

Apr 13 2021, 8:34 AM · Restricted Project
sstefan1 added a comment to D100339: [Attributor] Run lightweight version of the Attributor by default..

Isn't the PassManagerBuilder part of this patch missing to actually enable the lightweight Attributor by default?

I thought we should flip the switch in a separate patch. We would only need to make -enable-attributor=all (or some other configuration) the default.

Apr 13 2021, 8:31 AM · Restricted Project
sstefan1 added a comment to D100339: [Attributor] Run lightweight version of the Attributor by default..

Interesting. Do we have near term plans for adding the Attributor to the default pass pipeline ?

Apr 13 2021, 4:52 AM · Restricted Project
sstefan1 updated the diff for D100339: [Attributor] Run lightweight version of the Attributor by default..

Removing AAMemory*

Apr 13 2021, 4:51 AM · Restricted Project

Apr 12 2021

sstefan1 requested review of D100339: [Attributor] Run lightweight version of the Attributor by default..
Apr 12 2021, 12:55 PM · Restricted Project

Apr 8 2021

sstefan1 accepted D99769: [funcattrs] Infer nosync from instruction walk.
Apr 8 2021, 1:26 PM · Restricted Project
sstefan1 added a comment to D99769: [funcattrs] Infer nosync from instruction walk.

I'm doing some testing with a lightweight attributor enabled by default. Can this wait few more days, until I get some results? If the numbers are good, maybe we won't need this after all?

That's great, but I think 'using a lightweight attributor pass by default' requires at least the following steps 1) add the pass with option to enable it, 2) have people test it, 3) collect data to make a convincing case for enabling it, 4) flip the default and deal with the fallout. I am not sure this can be done in a few days.

I'd recommend to start with sharing a patch that adds this lightweight attributor pass, so we can start with getting consensus what the scope of this pass should be and go from there (without tying ourselves to any particular timeframe)

Apr 8 2021, 1:24 PM · Restricted Project
sstefan1 added a comment to D99769: [funcattrs] Infer nosync from instruction walk.

I'm doing some testing with a lightweight attributor enabled by default. Can this wait few more days, until I get some results? If the numbers are good, maybe we won't need this after all?

Apr 8 2021, 3:15 AM · Restricted Project

Mar 3 2021

sstefan1 accepted D94741: [Utils] Check for more global information in update_test_checks.

LGTM

Mar 3 2021, 11:12 PM · Restricted Project, Restricted Project
sstefan1 accepted D97906: [Attributor][NFC] Update tests after D94741.

I guess the script should be committed first.

Mar 3 2021, 11:08 PM · Restricted Project

Feb 27 2021

sstefan1 added inline comments to D97238: [Attributor] Conditinoally delete fns.
Feb 27 2021, 10:11 AM · Restricted Project
sstefan1 accepted D97584: [llvm] Mark Transforms/Attributor/ArgumentPromotion/crash.ll as unsupported on Windows.

LGTM

Feb 27 2021, 10:07 AM · Restricted Project

Feb 23 2021

sstefan1 added inline comments to D97238: [Attributor] Conditinoally delete fns.
Feb 23 2021, 1:26 AM · Restricted Project

Jan 14 2021

sstefan1 added a comment to D94687: [AArch64] Make target intrinsics DefaultAttrIntrinsics..

Some notable exceptions I think are exclusive loads and stores as well as the memory barrier intrinsics, for which nosync does not apply I think.

FWIW, that sounds about right.

Really happy people start to use this for target intrinsics as well.

Jan 14 2021, 8:20 AM · Restricted Project

Dec 6 2020

sstefan1 added a comment to D92404: [FileCheck] Enforce --allow-unused-prefixes=false for llvm/test/Transforms.

Gentle reminder - @jdoerfert , is blank-allowing all the Transforms/Attributor to have unused prefixes "as intended"? (I remember you indicating that was the case)

Dec 6 2020, 11:07 PM · Restricted Project

Dec 1 2020

sstefan1 accepted D92411: [Intrinsics] Re-remove experimental_vector_reduce intrinsics.

Definitely not intentional, sorry.

Dec 1 2020, 12:50 PM · Restricted Project

Nov 24 2020

sstefan1 accepted D92050: [OpenMP] Use assumptions during ICV tracking.

Cool :)

Nov 24 2020, 12:36 PM · Restricted Project

Nov 23 2020

sstefan1 added inline comments to D90103: Add OpenMP for optimization.
Nov 23 2020, 3:42 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D90103: Add OpenMP for optimization.

The tests should be in llvm-project/llvm/test/Transforms/OpenMP.

Nov 23 2020, 2:11 AM · Restricted Project, Restricted Project

Nov 21 2020

sstefan1 added a comment to D90103: Add OpenMP for optimization.

On the first look, you should at least clang-format this as it is not very readable right now.

Nov 21 2020, 2:02 AM · Restricted Project, Restricted Project

Oct 29 2020

sstefan1 added a comment to D89826: [FunctionAttrs][NPM] Fix handling of convergent.

Oh, and on the change itself: I'm not familiar enough with the attributor framework to judge the implementation, but the described reasoning (being able to make deductions from indirect calls) is sound.

Oct 29 2020, 1:22 AM · Restricted Project

Oct 20 2020

sstefan1 closed D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Commited in rGfbfb1c790982.

Oct 20 2020, 3:24 AM · Restricted Project, Restricted Project
sstefan1 committed rGfbfb1c790982: [IR] Make nosync, nofree and willreturn default for intrinsics. (authored by sstefan1).
[IR] Make nosync, nofree and willreturn default for intrinsics.
Oct 20 2020, 3:00 AM

Oct 15 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Switch to opt-in approach. Intrinsic class now has the same meaning as bofore.
To get default attributes we now use DefaultAttrsIntrinsic.

Oct 15 2020, 4:09 AM · Restricted Project, Restricted Project

Oct 14 2020

sstefan1 committed rGce16be253c4d: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor (authored by sstefan1).
[Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor
Oct 14 2020, 1:10 AM
sstefan1 closed D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.
Oct 14 2020, 1:10 AM · Restricted Project
sstefan1 added a comment to D75384: OpenMP for loop fusion.

I have been trying to update my patch by following the steps on:

https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

However, I always end up loading nothing.

Oct 14 2020, 12:36 AM · Restricted Project

Oct 13 2020

sstefan1 updated the diff for D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.

Only move the declaration

Oct 13 2020, 2:28 PM · Restricted Project
sstefan1 added inline comments to D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.
Oct 13 2020, 2:20 PM · Restricted Project
sstefan1 requested review of D89342: [Attributor][NFC] Make `createShallowWrapper()` available outside of Attributor.
Oct 13 2020, 2:06 PM · Restricted Project

Oct 12 2020

sstefan1 committed rGa64e8583dafe: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is… (authored by sstefan1).
[IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is…
Oct 12 2020, 2:30 AM
sstefan1 closed D88644: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is specified.
Oct 12 2020, 2:30 AM · Restricted Project

Oct 2 2020

sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

@nikic do you have a preference on any of the suggested names?

Oct 2 2020, 5:03 PM · Restricted Project, Restricted Project

Oct 1 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

opt-out of few more intrinsics
add comment for DefaultIntrinsic class

Oct 1 2020, 2:59 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

update clang tests

Oct 1 2020, 2:48 AM · Restricted Project, Restricted Project
sstefan1 updated the summary of D88644: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is specified.
Oct 1 2020, 2:40 AM · Restricted Project
sstefan1 requested review of D88644: [IR][FIX] Intrinsics - don't apply default willreturn if IntrNoReturn is specified.
Oct 1 2020, 2:35 AM · Restricted Project

Sep 30 2020

sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

I find the naming here confusing: Looking at this patch my expectation was that DefaultIntrinsic is used for intrinsics with default attributes, based on the name. Took me a while to understand it's actually the other way around. Shouldn't the Intrinsic <-> DefaultIntrinsic naming be inverted?

Sep 30 2020, 7:20 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Opt-out of default attributes for llvm.coro.* intrinsics.

Sep 30 2020, 6:38 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Actually coro intrinsics had default attributes, completelly missed that. Sorry for the confusion.
I'll update the patch shortly.

Sep 30 2020, 4:59 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

We probably shouldn't be messing with the attributes on llvm.coro.* intrinsics. The rules for transforms around coroutine intrinsics aren't completely settled (see also https://reviews.llvm.org/D87817), but at least some of them can run arbitrary code.

Sep 30 2020, 12:26 AM · Restricted Project, Restricted Project

Sep 29 2020

sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

precommit (local) coro test changes with update_test_checks

Sep 29 2020, 12:43 PM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Adding @rjmccall as a reviewer as I'm unsure about some coroutine changes that appeared after rebase.

Sep 29 2020, 12:10 PM · Restricted Project, Restricted Project
sstefan1 added a reviewer for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.: rjmccall.
Sep 29 2020, 12:07 PM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Rebase

Sep 29 2020, 12:06 PM · Restricted Project, Restricted Project
sstefan1 added a comment to D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

Its been more than a month now. Are there any additional concern about this?

Sep 29 2020, 7:57 AM · Restricted Project, Restricted Project
sstefan1 updated the diff for D86021: [IR] Make nosync, nofree and willreturn default for intrinsics..

group default properties together

Sep 29 2020, 7:56 AM · Restricted Project, Restricted Project
sstefan1 abandoned D86650: [Attributor][NFC] Run update_test_checks.py to check for attributes at the end..
Sep 29 2020, 7:30 AM · Restricted Project
sstefan1 committed rGcb9cfa0d2fdd: [OpenMPOpt][Fix] Only initialize ICV initial values once. (authored by sstefan1).
[OpenMPOpt][Fix] Only initialize ICV initial values once.
Sep 29 2020, 3:24 AM
sstefan1 closed D88441: [OpenMPOpt][Fix] Only initialize ICV initial values once..
Sep 29 2020, 3:24 AM · Restricted Project

Sep 28 2020

sstefan1 requested review of D88441: [OpenMPOpt][Fix] Only initialize ICV initial values once..
Sep 28 2020, 12:39 PM · Restricted Project
sstefan1 added inline comments to D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def.
Sep 28 2020, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
sstefan1 added inline comments to D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def.
Sep 28 2020, 12:12 PM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

sstefan1 abandoned D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Switched to D88096.

Sep 22 2020, 7:24 AM · Restricted Project
sstefan1 accepted D88096: [UpdateTestChecks] Match 'attributes #' at the end.

Now I see where the problem was. Thanks for taking a look.

Sep 22 2020, 7:24 AM · Restricted Project
sstefan1 accepted D88095: [UpdateTestChecks] Allow extra spaces in command line note.

LGTM

Sep 22 2020, 7:12 AM · Restricted Project

Sep 19 2020

sstefan1 added a comment to D87975: [IR] MaxObjSize Attribute.

I think you should split this in two patches. One that introduces the IR attribite and one for attributor deduction.

Sep 19 2020, 3:11 PM · Restricted Project

Sep 9 2020

sstefan1 added a comment to D86127: [Attributor] Make AAMemoryLocationCallSite behavior sane.

Sorry for the delay.

Sep 9 2020, 11:58 PM · Restricted Project
sstefan1 accepted D87432: [Attributor] Disable the MustBeExecutedContext by default.

Looks like parallel_deletion.ll needs to be updated as well.

Sep 9 2020, 11:50 PM · Restricted Project
sstefan1 added a comment to D87266: [Attributor] Re-enable a run line in noalias.ll.

Looks same as the failures before. I may be able to do a windows build next week and try to see what is going on.

Sep 9 2020, 8:54 AM · Restricted Project

Sep 7 2020

sstefan1 accepted D87266: [Attributor] Re-enable a run line in noalias.ll.

Actually windows tests passed, I was looking at the wrong place.

Sep 7 2020, 11:56 PM · Restricted Project
sstefan1 added a comment to D87266: [Attributor] Re-enable a run line in noalias.ll.

I remember this being windows only issue. I was able to always reproduce it on windows, but never had the chance to look into it.

Sep 7 2020, 11:52 PM · Restricted Project

Sep 3 2020

sstefan1 accepted D87104: [OpenMPOpt] Assume indirect call always changes ICV.

LGTM, thanks!

Sep 3 2020, 11:01 PM · Restricted Project

Aug 31 2020

sstefan1 added inline comments to D86474: [OpenMPOpt][SplitMemTransfer] Grouping the setup instructions for the runtime call..
Aug 31 2020, 11:39 PM · Restricted Project

Aug 30 2020

sstefan1 committed rG5dfd7cc46c8d: Reland [OpenMPOpt] ICV tracking for calls (authored by sstefan1).
Reland [OpenMPOpt] ICV tracking for calls
Aug 30 2020, 2:30 AM
sstefan1 closed D85544: [OpenMPOpt] ICV tracking for calls.
Aug 30 2020, 2:30 AM · Restricted Project
sstefan1 committed rG8d8ce85b235c: [Attributor] Introduce module slice. (authored by sstefan1).
[Attributor] Introduce module slice.
Aug 30 2020, 1:59 AM
sstefan1 closed D86319: [Attributor] Introduce module slice..
Aug 30 2020, 1:59 AM · Restricted Project
sstefan1 committed rGef018236945f: [OpenMPOpt][NFC] add reproducer for problem found in D85544 (authored by sstefan1).
[OpenMPOpt][NFC] add reproducer for problem found in D85544
Aug 30 2020, 1:01 AM

Aug 29 2020

sstefan1 committed rG6ce5b74b82ab: [Attributor][NFC] rerun update_test_checks without --scrub-attributes (authored by sstefan1).
[Attributor][NFC] rerun update_test_checks without --scrub-attributes
Aug 29 2020, 10:36 AM
sstefan1 committed rGb5dd2cd27f62: [UpdateTestChecks] Don't skip attributes when comparing functions (authored by sstefan1).
[UpdateTestChecks] Don't skip attributes when comparing functions
Aug 29 2020, 6:38 AM

Aug 28 2020

sstefan1 committed rG7128e647063d: [UpdateTestChecks] include { in function signature check line (authored by sstefan1).
[UpdateTestChecks] include { in function signature check line
Aug 28 2020, 2:45 PM
sstefan1 closed D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 2:45 PM · Restricted Project, Restricted Project
sstefan1 added inline comments to D86319: [Attributor] Introduce module slice..
Aug 28 2020, 7:47 AM · Restricted Project
sstefan1 updated the diff for D86319: [Attributor] Introduce module slice..

Rebasing after recent changes to AANoUndef

Aug 28 2020, 7:46 AM · Restricted Project
sstefan1 updated the summary of D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 1:27 AM · Restricted Project, Restricted Project
sstefan1 updated the summary of D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 1:26 AM · Restricted Project, Restricted Project
sstefan1 requested review of D86769: [UpdateTestChecks] include { in function signature check line.
Aug 28 2020, 1:25 AM · Restricted Project, Restricted Project

Aug 26 2020

sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Don't skip ;\n comments

Aug 26 2020, 12:21 PM · Restricted Project
sstefan1 requested review of D86650: [Attributor][NFC] Run update_test_checks.py to check for attributes at the end..
Aug 26 2020, 12:11 PM · Restricted Project
sstefan1 updated the diff for D85932: [UpdateTestChecks] Match 'attributes #' at the end.

Sorry for the delay on this.

Aug 26 2020, 11:57 AM · Restricted Project