Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (47 w, 2 d)

Recent Activity

Mon, Jan 13

sstefan1 resigned from D69930: [OpenMP] Introduce the OpenMPOpt transformation pass.
Mon, Jan 13, 9:27 PM · Restricted Project

Sun, Jan 12

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

I see where you are going and we need this, however I just fiddled around with the entire isAssumedDead stuff to make the helper methods aware of dead uses (and instructions). I will see how we can combine this best with H2S and report here, OK?

Sun, Jan 12, 7:39 AM · Restricted Project

Sat, Jan 11

sstefan1 created D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Sat, Jan 11, 1:38 PM · Restricted Project

Tue, Jan 7

sstefan1 resigned from D72331: OpaquePtr: add type to inalloca attribute..
Tue, Jan 7, 10:52 AM · Restricted Project, Restricted Project

Wed, Dec 25

sstefan1 added inline comments to rGfff8ec981393: [Attributor] H2S fix..
Wed, Dec 25, 10:20 AM

Sat, Dec 21

sstefan1 accepted D71787: [Attributor] UB Attribute now handles all instructions that access memory through a pointer.
Sat, Dec 21, 4:41 AM · Restricted Project

Fri, Dec 20

sstefan1 added a comment to D71787: [Attributor] UB Attribute now handles all instructions that access memory through a pointer.

Quick initial comment

Fri, Dec 20, 3:18 PM · Restricted Project

Dec 17 2019

sstefan1 committed rGfff8ec981393: [Attributor] H2S fix. (authored by sstefan1).
[Attributor] H2S fix.
Dec 17 2019, 11:46 AM
sstefan1 closed D71564: [Attributor] H2S fix..
Dec 17 2019, 11:46 AM · Restricted Project
sstefan1 committed rGd020e67575d9: [Attributor][NFC] Add test for sle comparison in h2s. (authored by sstefan1).
[Attributor][NFC] Add test for sle comparison in h2s.
Dec 17 2019, 11:41 AM

Dec 16 2019

sstefan1 added inline comments to D71564: [Attributor] H2S fix..
Dec 16 2019, 2:20 PM · Restricted Project
sstefan1 added inline comments to D71564: [Attributor] H2S fix..
Dec 16 2019, 2:07 PM · Restricted Project
sstefan1 created D71564: [Attributor] H2S fix..
Dec 16 2019, 12:36 PM · Restricted Project

Dec 15 2019

sstefan1 added inline comments to D71521: Support for library function aligned_alloc.
Dec 15 2019, 1:40 PM · Restricted Project

Dec 11 2019

sstefan1 accepted D71349: [Attributor][NFC] Refactoring `AANoFreeArgument::updateImpl`.

lgtm.

Dec 11 2019, 6:17 AM · Restricted Project

Nov 21 2019

sstefan1 added a comment to D70233: [WIP][Attributor] AAReachability Attribute.

This is LGTM from me now, but lets wait for Johaness as well.

Nov 21 2019, 2:40 AM · Restricted Project

Nov 20 2019

sstefan1 added inline comments to D70233: [WIP][Attributor] AAReachability Attribute.
Nov 20 2019, 11:37 AM · Restricted Project

Nov 18 2019

sstefan1 added inline comments to D70365: intrinsics attribute opt-out list proposal..
Nov 18 2019, 11:53 AM · Restricted Project

Nov 17 2019

sstefan1 created D70365: intrinsics attribute opt-out list proposal..
Nov 17 2019, 2:44 PM · Restricted Project
sstefan1 committed rGa516fbac5202: [Attributor] Use nofree argument attribute for heap-to-stack conversion (authored by sstefan1).
[Attributor] Use nofree argument attribute for heap-to-stack conversion
Nov 17 2019, 12:42 PM
sstefan1 closed D70140: Use nofree argument attributr hor heap-to-stack conversion.
Nov 17 2019, 12:42 PM · Restricted Project

Nov 14 2019

sstefan1 added a comment to D70233: [WIP][Attributor] AAReachability Attribute.

Nice to see other people working on this! :)

Nov 14 2019, 11:39 AM · Restricted Project

Nov 13 2019

sstefan1 added a comment to D70140: Use nofree argument attributr hor heap-to-stack conversion.

Typo hor in commit message

Two typos even. Thanks for noticing!

Thanks! Will double check before I commit

Nov 13 2019, 8:55 AM · Restricted Project
sstefan1 added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 13 2019, 2:24 AM · Restricted Project

Nov 12 2019

sstefan1 created D70140: Use nofree argument attributr hor heap-to-stack conversion.
Nov 12 2019, 12:56 PM · Restricted Project

Nov 10 2019

sstefan1 committed rGc250ebf7bcaa: getArgOperandNo helper function. (authored by sstefan1).
getArgOperandNo helper function.
Nov 10 2019, 1:05 PM
sstefan1 closed D66844: getArgOperandNo helper function.
Nov 10 2019, 1:05 PM · Restricted Project

Nov 2 2019

sstefan1 committed rGf35740d6e954: NoFree argument attribute. (authored by sstefan1).
NoFree argument attribute.
Nov 2 2019, 11:52 AM
sstefan1 added a comment to D67886: NoFree argument attribute..

Yes, I missed that one. Sorry for the mess.

Nov 2 2019, 11:52 AM · Restricted Project
sstefan1 committed rG5fb178291840: Revert "NoFree argument attribute." (authored by sstefan1).
Revert "NoFree argument attribute."
Nov 2 2019, 9:35 AM
sstefan1 added a reverting change for rGc12efa2ed054: NoFree argument attribute.: rG5fb178291840: Revert "NoFree argument attribute.".
Nov 2 2019, 9:34 AM
sstefan1 committed rGc12efa2ed054: NoFree argument attribute. (authored by sstefan1).
NoFree argument attribute.
Nov 2 2019, 8:39 AM
sstefan1 closed D67886: NoFree argument attribute..
Nov 2 2019, 8:37 AM · Restricted Project

Oct 30 2019

sstefan1 accepted D69605: [Attributor] Make liveness "edge-based".

LGTM with minor comments.

Oct 30 2019, 7:47 AM · Restricted Project

Oct 14 2019

sstefan1 updated the diff for D67886: NoFree argument attribute..
  • update tests
Oct 14 2019, 4:11 PM · Restricted Project
sstefan1 accepted D68958: [Attributor] Add "free"-based heap2stack deduction.

LGTM

Oct 14 2019, 3:50 PM · Restricted Project
sstefan1 accepted D68925: [Attributor] Liveness for values.

LGTM then!

Oct 14 2019, 1:25 PM · Restricted Project
sstefan1 added a comment to D68925: [Attributor] Liveness for values.

Some comments

Oct 14 2019, 9:57 AM · Restricted Project
sstefan1 updated the diff for D67886: NoFree argument attribute..
  • minor updates.
Oct 14 2019, 1:14 AM · Restricted Project

Oct 13 2019

sstefan1 updated the diff for D67886: NoFree argument attribute..
  • addressing comments
Oct 13 2019, 2:17 PM · Restricted Project
sstefan1 accepted D68929: [Attributor][FIX] Use check line that is actually tested.

lgtm.

Oct 13 2019, 1:30 PM · Restricted Project

Oct 12 2019

sstefan1 added a comment to D68626: [Attributor] Use undef for calls with unused arguments..

I have no problem with this going in as is. I have one question though. Why do we have to wait for ValueSimplify to finish? Wouldn't it be useful for AAIsDead to have isDeadArg(Arg) and then ValueSimplify could use that to decide whether to simplify or not?

Oct 12 2019, 9:50 AM · Restricted Project

Oct 2 2019

sstefan1 updated the diff for D67886: NoFree argument attribute..
  • update tests
Oct 2 2019, 2:43 PM · Restricted Project

Sep 23 2019

sstefan1 added a comment to D66844: getArgOperandNo helper function.

This looks fine but commit it only with the use (one patch maybe).

Should I find another use for the method, or is this one enough?

Sep 23 2019, 12:53 PM · Restricted Project
sstefan1 added inline comments to D67886: NoFree argument attribute..
Sep 23 2019, 12:49 PM · Restricted Project

Sep 21 2019

sstefan1 updated the diff for D66844: getArgOperandNo helper function.

small refactoring to use getArgOperandNo

Sep 21 2019, 3:25 PM · Restricted Project
sstefan1 added a comment to D67886: NoFree argument attribute..

There should be other test changes, will update tomorrow.

Sep 21 2019, 2:59 PM · Restricted Project
sstefan1 added a reviewer for D67886: NoFree argument attribute.: uenoku.
Sep 21 2019, 2:58 PM · Restricted Project
sstefan1 created D67886: NoFree argument attribute..
Sep 21 2019, 2:57 PM · Restricted Project

Sep 15 2019

sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Sep 15 2019, 11:14 PM · Restricted Project
sstefan1 added a comment to D65408: [Attributor] Heap-To-Stack Conversion.

I think the current implementation needs some important fixes to avoid miscompilation/overflow, can you make it off by default, fix issues, and enable it again?

Thanks.

Sep 15 2019, 11:10 PM · Restricted Project
sstefan1 committed rG431141c5cc34: [Attributor] Heap-To-Stack Conversion (authored by sstefan1).
[Attributor] Heap-To-Stack Conversion
Sep 15 2019, 2:49 PM

Sep 14 2019

sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Sep 14 2019, 2:24 PM · Restricted Project

Sep 11 2019

sstefan1 accepted D67232: [Attributor][Fix] Initialize the cache prior to using it.
Sep 11 2019, 1:40 PM · Restricted Project

Sep 6 2019

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

fix diff

Sep 6 2019, 4:50 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

small fix

Sep 6 2019, 4:45 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

addressing comments

Sep 6 2019, 4:18 PM · Restricted Project
sstefan1 added inline comments to D67232: [Attributor][Fix] Initialize the cache prior to using it.
Sep 6 2019, 12:06 AM · Restricted Project

Sep 4 2019

sstefan1 accepted D67191: [Attributor][Fix] Make sure we do not delete live code.

LGTM

Sep 4 2019, 1:11 PM · Restricted Project

Sep 2 2019

sstefan1 added a comment to D65408: [Attributor] Heap-To-Stack Conversion.

@xbolva00 I'm sorry this has dragged on a bit.

Sep 2 2019, 3:55 AM · Restricted Project

Aug 28 2019

sstefan1 accepted D66562: [Attributor] Restrict liveness and return information to functions.

LGTM.

Aug 28 2019, 2:44 AM · Restricted Project

Aug 27 2019

sstefan1 created D66844: getArgOperandNo helper function.
Aug 27 2019, 4:13 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
  • Small corrections.
Aug 27 2019, 3:54 PM · Restricted Project

Aug 26 2019

sstefan1 accepted D66779: [Attributor] Introduce an API to delete stuff.

LGTM.

Aug 26 2019, 6:42 PM · Restricted Project
sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Aug 26 2019, 6:20 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
  • remove mistake
Aug 26 2019, 6:07 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

addressing comments

Aug 26 2019, 6:05 PM · Restricted Project

Aug 23 2019

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

Taking a different approach using nocapture and nofree.

Aug 23 2019, 3:23 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
remove llvm_debug
Aug 23 2019, 3:23 PM · Restricted Project

Aug 21 2019

sstefan1 accepted D66551: [Attributor] Manifest constant return values.

This is nice!

Aug 21 2019, 2:14 PM · Restricted Project
sstefan1 accepted D66484: [Attributor][NFCI] Avoid lookups when resolving returned values.

LGTM

Aug 21 2019, 2:09 PM · Restricted Project
sstefan1 accepted D66549: [Attributor] FIX: Treat new attributes as changed ones.

LGTM

Aug 21 2019, 2:03 PM · Restricted Project
sstefan1 accepted D66554: [Attributor][NFCI] Introduce tight iteration bounds in the tests.

LGTM.

Aug 21 2019, 1:53 PM · Restricted Project

Aug 20 2019

sstefan1 accepted D63315: [Attributor] Regularly clear dependences to remove spurious ones.

LGTM. Except for lack of tests

Aug 20 2019, 4:45 PM · Restricted Project
sstefan1 accepted D63314: [Attributor] Allow explicit dependence tracking.

LGTM.

Aug 20 2019, 4:32 PM · Restricted Project
sstefan1 committed rG26121ae4d047: [Attributor] Liveness for internal functions. (authored by sstefan1).
[Attributor] Liveness for internal functions.
Aug 20 2019, 4:18 PM
sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
addressing comments
Aug 20 2019, 8:33 AM · Restricted Project
sstefan1 added inline comments to D66155: [Attributor] Liveness for internal functions..
Aug 20 2019, 2:18 AM · Restricted Project

Aug 19 2019

sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • small update
  • Attributor::isAssumedDead() fix
Aug 19 2019, 1:17 PM · Restricted Project
sstefan1 committed rG8682281063d6: [Attributor] -attributor-verify has false positives. Temporarily remove it… (authored by sstefan1).
[Attributor] -attributor-verify has false positives. Temporarily remove it…
Aug 19 2019, 9:46 AM

Aug 18 2019

sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.
  • minor fix
Aug 18 2019, 2:53 PM · Restricted Project
sstefan1 updated the diff for D65408: [Attributor] Heap-To-Stack Conversion.

Providing an implementation for the conversion. This is few commits behind fromt the latest Attributor, will be rebased.

Aug 18 2019, 2:50 PM · Restricted Project

Aug 16 2019

sstefan1 accepted D66258: [Attributor] Introduce initialize calls and move code to keep attributes concise.

LGTM

Aug 16 2019, 8:45 AM · Restricted Project

Aug 14 2019

sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • add scc test
Aug 14 2019, 4:05 PM · Restricted Project
sstefan1 added inline comments to D66155: [Attributor] Liveness for internal functions..
Aug 14 2019, 3:13 PM · Restricted Project
sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • Replace dead functions with undef
Aug 14 2019, 3:04 PM · Restricted Project
sstefan1 added a comment to D66207: [Attributor] Deduce "noalias" attribute.

Minor comments

Aug 14 2019, 2:56 AM · Restricted Project

Aug 13 2019

sstefan1 accepted D66120: [Attributor] Use liveness during the creation of AAReturnedValues.

LGTM.

Aug 13 2019, 3:47 PM · Restricted Project
sstefan1 accepted D65977: [Attributor] Use IRPosition consistently.

LGTM.

Aug 13 2019, 3:26 PM · Restricted Project
sstefan1 updated the diff for D66155: [Attributor] Liveness for internal functions..
  • adding tests & helper function
Aug 13 2019, 2:55 PM · Restricted Project
sstefan1 created D66155: [Attributor] Liveness for internal functions..
Aug 13 2019, 11:05 AM · Restricted Project

Aug 12 2019

sstefan1 accepted D66116: [Attributor] Do not update or manifest dead attributes.

LGTM.

Aug 12 2019, 10:22 PM · Restricted Project

Aug 9 2019

sstefan1 added a comment to D65977: [Attributor] Use IRPosition consistently.

Generally looks good to me. Some initial comments inlined. Since it is a big patch I'd also wait for Hideto to read it. (Maybe I'll reread it as well.)

Aug 9 2019, 6:37 AM · Restricted Project

Aug 7 2019

sstefan1 committed rGaaa5270c5362: [Attributor] Introduce checkForAllReadWriteInstructions(...). (authored by sstefan1).
[Attributor] Introduce checkForAllReadWriteInstructions(...).
Aug 7 2019, 11:26 AM
sstefan1 updated the diff for D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...)..
  • address comment.
Aug 7 2019, 10:37 AM · Restricted Project
sstefan1 added inline comments to D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...)..
Aug 7 2019, 5:08 AM · Restricted Project

Aug 6 2019

sstefan1 created D65825: [Attributor] Introduce checkForAllReadWriteInstructions(...)..
Aug 6 2019, 1:20 PM · Restricted Project
sstefan1 added a comment to D65733: [Attributor] Provide easier checkForallReturnedValues functionality.

This looks good. Just one comment inlined:

Aug 6 2019, 9:16 AM · Restricted Project
sstefan1 added a comment to D65786: [Attributor] Introduce a state wrapper class.

LGTM with one question. Maybe this is an overkill, but do we even need to have isAssumed*AAType* as well as isKnown (eg. isAssumedNoFree())? I'm just thinking out loud.

Aug 6 2019, 5:42 AM · Restricted Project

Aug 4 2019

sstefan1 accepted D65731: [Attributor] Provide a generic interface to check live instructions.

LGTM.

Aug 4 2019, 5:07 PM · Restricted Project