Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (58 w, 6 d)

Recent Activity

Tue, Mar 31

sstefan1 accepted D76588: [Attributor] Unify testing (=updates,prefixes,run configurations,...).

LGTM! sorry for the delay

Tue, Mar 31, 5:31 AM · Restricted Project

Sun, Mar 29

sstefan1 added a comment to D76873: [Attributor][NFC] Split AbstractAttribute subclasses out of Attributor.cpp.

I think this looks fine and makes sense. I'll give others a chance to read/comment before accepting.

Sun, Mar 29, 1:23 PM · Restricted Project

Wed, Mar 25

sstefan1 committed rG72b51d6f93b5: OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime… (authored by sstefan1).
OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime…
Wed, Mar 25, 7:32 AM
sstefan1 closed D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..
Wed, Mar 25, 7:32 AM · Restricted Project, Restricted Project

Mon, Mar 23

sstefan1 added a comment to D76588: [Attributor] Unify testing (=updates,prefixes,run configurations,...).

It is a good idea to generalise the way we write tests.

Mon, Mar 23, 1:06 PM · Restricted Project
sstefan1 accepted D76175: [Attributor][NFC] Refactorings and typos in doc.

I'll re-accept :)

Mon, Mar 23, 8:09 AM · Restricted Project

Fri, Mar 20

sstefan1 added inline comments to D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer.
Fri, Mar 20, 3:45 AM · Restricted Project

Thu, Mar 19

sstefan1 added inline comments to D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer.
Thu, Mar 19, 4:27 PM · Restricted Project

Wed, Mar 18

sstefan1 added inline comments to D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer.
Wed, Mar 18, 3:13 PM · Restricted Project
sstefan1 added inline comments to D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer.
Wed, Mar 18, 12:29 PM · Restricted Project

Mon, Mar 16

sstefan1 updated the diff for D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..

more tests

Mon, Mar 16, 10:57 AM · Restricted Project, Restricted Project

Sun, Mar 15

sstefan1 accepted D76175: [Attributor][NFC] Refactorings and typos in doc.
Sun, Mar 15, 3:43 AM · Restricted Project

Sat, Mar 14

sstefan1 added a comment to D76175: [Attributor][NFC] Refactorings and typos in doc.

Today I started reading through the whole Attributor, or at least its core parts, because I think otherwise I won't
have a good enough understanding to proceed. This is the start of a series of small patches that will mostly be NFC
improvements to docs with which I hope I'll have the opportunity to ask questions about different decisions in the Attributor.

This seems fine, as well as the initiative. Few comments though

Sat, Mar 14, 10:11 AM · Restricted Project

Wed, Mar 11

sstefan1 updated the diff for D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..

fix clang test

Wed, Mar 11, 11:19 AM · Restricted Project, Restricted Project

Tue, Mar 10

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

Can we postpone this until we figured out how AAIsDead and AAUB are working together? We need to figure this out and decide how much interaction with AAIsDead we want, e.g., if a rerun is sufficient do we need to integrate it.

Tue, Mar 10, 11:00 PM · Restricted Project
sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

ping

Tue, Mar 10, 1:06 PM · Restricted Project
sstefan1 updated the diff for D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..

tests

Tue, Mar 10, 1:06 PM · Restricted Project, Restricted Project
sstefan1 added inline comments to D75893: [OpenMP] Add !range metadata to loads from omp.(ub/lb).
Tue, Mar 10, 10:53 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D75893: [OpenMP] Add !range metadata to loads from omp.(ub/lb).

Seems like you uploaded a diff against your previous patch version. Also changes from OMPKinds.def are missing. Can you fix that?

Tue, Mar 10, 10:52 AM · Restricted Project, Restricted Project

Mar 3 2020

sstefan1 added a comment to D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..

Tests?

Mar 3 2020, 1:14 PM · Restricted Project, Restricted Project
sstefan1 committed rG13fd50cc2640: Revert "Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on… (authored by sstefan1).
Revert "Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on…
Mar 3 2020, 12:00 PM
sstefan1 added a reverting change for rG9989b859efcc: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime…: rGa8fcf8d21798: Revert "[OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for….
Mar 3 2020, 11:59 AM
sstefan1 committed rGa8fcf8d21798: Revert "[OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for… (authored by sstefan1).
Revert "[OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for…
Mar 3 2020, 11:59 AM
sstefan1 added a reverting change for rG78a734e27920: Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows": rG13fd50cc2640: Revert "Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on….
Mar 3 2020, 11:59 AM
sstefan1 committed rG78a734e27920: Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows" (authored by sstefan1).
Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows"
Mar 3 2020, 11:59 AM
sstefan1 added a reverting change for rG3270ea9042ea: [lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows: rG78a734e27920: Revert "[lldb/Docs] Mark both Python 3.6 and 3.8 as supported on Windows".
Mar 3 2020, 11:59 AM
sstefan1 committed rG9989b859efcc: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime… (authored by sstefan1).
[OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime…
Mar 3 2020, 11:59 AM

Feb 24 2020

sstefan1 updated the diff for D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

small update.

Feb 24 2020, 11:07 AM · Restricted Project

Feb 23 2020

sstefan1 added inline comments to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Feb 23 2020, 2:08 PM · Restricted Project
sstefan1 added inline comments to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Feb 23 2020, 1:37 PM · Restricted Project

Feb 22 2020

sstefan1 added a comment to D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..

Thx! I'll ask more people to look at the barrier/flush stuff to make sure my suggestion wrt. inacc+argmemonly was correct.
The ones I would also love to see are the worksharing loop functions (end with _init_4, _fini etc.). Maybe we should do those and the getters/setters separate to speed things up.

Feb 22 2020, 10:33 AM · Restricted Project, Restricted Project
sstefan1 created D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls..
Feb 22 2020, 5:57 AM · Restricted Project, Restricted Project
sstefan1 resigned from D74994: [LTO] Rename legacy LTO files. NFC..
Feb 22 2020, 3:38 AM · Restricted Project

Feb 19 2020

sstefan1 added inline comments to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Feb 19 2020, 1:59 PM · Restricted Project
sstefan1 updated the diff for D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

small fix

Feb 19 2020, 1:48 PM · Restricted Project

Feb 18 2020

sstefan1 added inline comments to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Feb 18 2020, 12:44 PM · Restricted Project
sstefan1 added inline comments to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Feb 18 2020, 11:49 AM · Restricted Project

Feb 17 2020

sstefan1 updated the diff for D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

small update

Feb 17 2020, 10:40 AM · Restricted Project
sstefan1 updated the diff for D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

addressing comments

Feb 17 2020, 10:03 AM · Restricted Project
sstefan1 added inline comments to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Feb 17 2020, 10:03 AM · Restricted Project
sstefan1 updated the diff for D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

Changing the implementation to use new fine-grained liveness helpers.

Feb 17 2020, 8:09 AM · Restricted Project

Feb 12 2020

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

Done, though I have some minor patches before them I'll commit tomorrow. If you find the time to review the two above I can commit the whole series ;)

Feb 12 2020, 6:22 AM · Restricted Project
sstefan1 accepted D73313: [Attributor] Use fine-grained liveness in all helpers.

Small question, but LGTM

Feb 12 2020, 6:22 AM · Restricted Project
sstefan1 accepted D73311: [Attributor] Use assumed information to determine side-effects.

LGTM

Feb 12 2020, 6:13 AM · Restricted Project

Feb 4 2020

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

I was hoping that after D73313 we could have a check this in AAIsDeadCallSiteReturned. In the init and update we ask H2S (and later others) if they assume to remove the instruction, if so, we consider it dead.

Sorry for the delay.
Ok, I think this makes much more sense now.

Feb 4 2020, 12:12 PM · Restricted Project

Jan 29 2020

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

This needs to be integrated with D73313.

I think there is no integration with D73313 since I only need to change AAIsDeadFunction::IsAssumedDead. If that is correct I think this doesn't depend on D73313.

Also, I'll drop the changes to the existing interfaces, e.g. CheckForAllXXX.

I suggest we ask H2M if we have a call explicitly if it assumes to remove it.

That is kind of the current implementation, but I'll change it a bit so the changes to existing interfaces are not needed.

Jan 29 2020, 11:49 AM · Restricted Project

Jan 27 2020

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

This needs to be integrated with D73313.

I think there is no integration with D73313 since I only need to change AAIsDeadFunction::IsAssumedDead. If that is correct I think this doesn't depend on D73313.

Jan 27 2020, 2:00 AM · Restricted Project
sstefan1 added inline comments to D73313: [Attributor] Use fine-grained liveness in all helpers.
Jan 27 2020, 1:33 AM · Restricted Project
sstefan1 added a comment to D73311: [Attributor] Use assumed information to determine side-effects.

Sorry for the delay.

Jan 27 2020, 12:23 AM · Restricted Project

Jan 13 2020

sstefan1 resigned from D69930: [OpenMP] Introduce the OpenMPOpt transformation pass.
Jan 13 2020, 9:27 PM · Restricted Project

Jan 12 2020

sstefan1 added a comment to D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.

I see where you are going and we need this, however I just fiddled around with the entire isAssumedDead stuff to make the helper methods aware of dead uses (and instructions). I will see how we can combine this best with H2S and report here, OK?

Jan 12 2020, 7:39 AM · Restricted Project

Jan 11 2020

sstefan1 created D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection.
Jan 11 2020, 1:38 PM · Restricted Project

Jan 7 2020

sstefan1 resigned from D72331: OpaquePtr: add type to inalloca attribute..
Jan 7 2020, 10:52 AM · Restricted Project, Restricted Project

Dec 25 2019

sstefan1 added inline comments to rGfff8ec981393: [Attributor] H2S fix..
Dec 25 2019, 10:20 AM

Dec 21 2019

sstefan1 accepted D71787: [Attributor] UB Attribute now handles all instructions that access memory through a pointer.
Dec 21 2019, 4:41 AM · Restricted Project

Dec 20 2019

sstefan1 added a comment to D71787: [Attributor] UB Attribute now handles all instructions that access memory through a pointer.

Quick initial comment

Dec 20 2019, 3:18 PM · Restricted Project

Dec 17 2019

sstefan1 committed rGfff8ec981393: [Attributor] H2S fix. (authored by sstefan1).
[Attributor] H2S fix.
Dec 17 2019, 11:46 AM
sstefan1 closed D71564: [Attributor] H2S fix..
Dec 17 2019, 11:46 AM · Restricted Project
sstefan1 committed rGd020e67575d9: [Attributor][NFC] Add test for sle comparison in h2s. (authored by sstefan1).
[Attributor][NFC] Add test for sle comparison in h2s.
Dec 17 2019, 11:41 AM

Dec 16 2019

sstefan1 added inline comments to D71564: [Attributor] H2S fix..
Dec 16 2019, 2:20 PM · Restricted Project
sstefan1 added inline comments to D71564: [Attributor] H2S fix..
Dec 16 2019, 2:07 PM · Restricted Project
sstefan1 created D71564: [Attributor] H2S fix..
Dec 16 2019, 12:36 PM · Restricted Project

Dec 15 2019

sstefan1 added inline comments to D71521: Introduce support for lib function aligned_alloc.
Dec 15 2019, 1:40 PM · Restricted Project

Dec 11 2019

sstefan1 accepted D71349: [Attributor][NFC] Refactoring `AANoFreeArgument::updateImpl`.

lgtm.

Dec 11 2019, 6:17 AM · Restricted Project

Nov 21 2019

sstefan1 added a comment to D70233: [WIP][Attributor] AAReachability Attribute.

This is LGTM from me now, but lets wait for Johaness as well.

Nov 21 2019, 2:40 AM · Restricted Project

Nov 20 2019

sstefan1 added inline comments to D70233: [WIP][Attributor] AAReachability Attribute.
Nov 20 2019, 11:37 AM · Restricted Project

Nov 18 2019

sstefan1 added inline comments to D70365: intrinsics attribute opt-out list proposal..
Nov 18 2019, 11:53 AM · Restricted Project

Nov 17 2019

sstefan1 created D70365: intrinsics attribute opt-out list proposal..
Nov 17 2019, 2:44 PM · Restricted Project
sstefan1 committed rGa516fbac5202: [Attributor] Use nofree argument attribute for heap-to-stack conversion (authored by sstefan1).
[Attributor] Use nofree argument attribute for heap-to-stack conversion
Nov 17 2019, 12:42 PM
sstefan1 closed D70140: Use nofree argument attributr hor heap-to-stack conversion.
Nov 17 2019, 12:42 PM · Restricted Project

Nov 14 2019

sstefan1 added a comment to D70233: [WIP][Attributor] AAReachability Attribute.

Nice to see other people working on this! :)

Nov 14 2019, 11:39 AM · Restricted Project

Nov 13 2019

sstefan1 added a comment to D70140: Use nofree argument attributr hor heap-to-stack conversion.

Typo hor in commit message

Two typos even. Thanks for noticing!

Thanks! Will double check before I commit

Nov 13 2019, 8:55 AM · Restricted Project
sstefan1 added inline comments to D69891: [VP,Integer,#1] Vector-predicated integer intrinsics.
Nov 13 2019, 2:24 AM · Restricted Project

Nov 12 2019

sstefan1 created D70140: Use nofree argument attributr hor heap-to-stack conversion.
Nov 12 2019, 12:56 PM · Restricted Project

Nov 10 2019

sstefan1 committed rGc250ebf7bcaa: getArgOperandNo helper function. (authored by sstefan1).
getArgOperandNo helper function.
Nov 10 2019, 1:05 PM
sstefan1 closed D66844: getArgOperandNo helper function.
Nov 10 2019, 1:05 PM · Restricted Project

Nov 2 2019

sstefan1 committed rGf35740d6e954: NoFree argument attribute. (authored by sstefan1).
NoFree argument attribute.
Nov 2 2019, 11:52 AM
sstefan1 added a comment to D67886: NoFree argument attribute..

Yes, I missed that one. Sorry for the mess.

Nov 2 2019, 11:52 AM · Restricted Project
sstefan1 committed rG5fb178291840: Revert "NoFree argument attribute." (authored by sstefan1).
Revert "NoFree argument attribute."
Nov 2 2019, 9:35 AM
sstefan1 added a reverting change for rGc12efa2ed054: NoFree argument attribute.: rG5fb178291840: Revert "NoFree argument attribute.".
Nov 2 2019, 9:34 AM
sstefan1 committed rGc12efa2ed054: NoFree argument attribute. (authored by sstefan1).
NoFree argument attribute.
Nov 2 2019, 8:39 AM
sstefan1 closed D67886: NoFree argument attribute..
Nov 2 2019, 8:37 AM · Restricted Project

Oct 30 2019

sstefan1 accepted D69605: [Attributor] Make liveness "edge-based".

LGTM with minor comments.

Oct 30 2019, 7:47 AM · Restricted Project

Oct 14 2019

sstefan1 updated the diff for D67886: NoFree argument attribute..
  • update tests
Oct 14 2019, 4:11 PM · Restricted Project
sstefan1 accepted D68958: [Attributor] Add "free"-based heap2stack deduction.

LGTM

Oct 14 2019, 3:50 PM · Restricted Project
sstefan1 accepted D68925: [Attributor] Liveness for values.

LGTM then!

Oct 14 2019, 1:25 PM · Restricted Project
sstefan1 added a comment to D68925: [Attributor] Liveness for values.

Some comments

Oct 14 2019, 9:57 AM · Restricted Project
sstefan1 updated the diff for D67886: NoFree argument attribute..
  • minor updates.
Oct 14 2019, 1:14 AM · Restricted Project

Oct 13 2019

sstefan1 updated the diff for D67886: NoFree argument attribute..
  • addressing comments
Oct 13 2019, 2:17 PM · Restricted Project
sstefan1 accepted D68929: [Attributor][FIX] Use check line that is actually tested.

lgtm.

Oct 13 2019, 1:30 PM · Restricted Project

Oct 12 2019

sstefan1 added a comment to D68626: [Attributor] Use undef for calls with unused arguments..

I have no problem with this going in as is. I have one question though. Why do we have to wait for ValueSimplify to finish? Wouldn't it be useful for AAIsDead to have isDeadArg(Arg) and then ValueSimplify could use that to decide whether to simplify or not?

Oct 12 2019, 9:50 AM · Restricted Project

Oct 2 2019

sstefan1 updated the diff for D67886: NoFree argument attribute..
  • update tests
Oct 2 2019, 2:43 PM · Restricted Project

Sep 23 2019

sstefan1 added a comment to D66844: getArgOperandNo helper function.

This looks fine but commit it only with the use (one patch maybe).

Should I find another use for the method, or is this one enough?

Sep 23 2019, 12:53 PM · Restricted Project
sstefan1 added inline comments to D67886: NoFree argument attribute..
Sep 23 2019, 12:49 PM · Restricted Project

Sep 21 2019

sstefan1 updated the diff for D66844: getArgOperandNo helper function.

small refactoring to use getArgOperandNo

Sep 21 2019, 3:25 PM · Restricted Project
sstefan1 added a comment to D67886: NoFree argument attribute..

There should be other test changes, will update tomorrow.

Sep 21 2019, 2:59 PM · Restricted Project
sstefan1 added a reviewer for D67886: NoFree argument attribute.: uenoku.
Sep 21 2019, 2:58 PM · Restricted Project
sstefan1 created D67886: NoFree argument attribute..
Sep 21 2019, 2:57 PM · Restricted Project

Sep 15 2019

sstefan1 added inline comments to D65408: [Attributor] Heap-To-Stack Conversion.
Sep 15 2019, 11:14 PM · Restricted Project
sstefan1 added a comment to D65408: [Attributor] Heap-To-Stack Conversion.

I think the current implementation needs some important fixes to avoid miscompilation/overflow, can you make it off by default, fix issues, and enable it again?

Thanks.

Sep 15 2019, 11:10 PM · Restricted Project