Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (21 w, 4 d)

Recent Activity

Yesterday

sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..
  • removing unnecessary llvm_debug
Sat, Jul 20, 1:38 PM · Restricted Project
sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..

Rebased and added more tests.

Sat, Jul 20, 1:37 PM · Restricted Project

Fri, Jul 19

sstefan1 retitled D64162: [Attributor] Liveness analysis. from Summary: [Attributor] Liveness analysis abstract attribute used to indicate which BasicBlocks are dead and can therefore be ignored. to [Attributor] Liveness analysis..
Fri, Jul 19, 3:56 PM · Restricted Project
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • Rebased and added AANoReturn declaration.
  • ninja check-all & test-suite passed fine.
Fri, Jul 19, 3:52 PM · Restricted Project
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • addressing comments.
Fri, Jul 19, 5:51 AM · Restricted Project

Thu, Jul 18

sstefan1 added a comment to D53362: [Prototype] Heap-To-Stack Conversion Pass.

Hi Hal! Are you planning on working on this one? If not maybe I can take over? Now that we have nofree & nosync added and deduced in the Attributor, maybe this can be revisited.

Thu, Jul 18, 1:12 PM
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • explorePath now returns false only if starting point is a noreturn call that is still noreturn.
Thu, Jul 18, 8:28 AM · Restricted Project
sstefan1 added inline comments to D64162: [Attributor] Liveness analysis..
Thu, Jul 18, 8:25 AM · Restricted Project

Tue, Jul 16

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • addressing comments
Tue, Jul 16, 9:31 AM · Restricted Project
sstefan1 added inline comments to D64162: [Attributor] Liveness analysis..
Tue, Jul 16, 9:31 AM · Restricted Project

Mon, Jul 15

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • More tests.
  • Small changes.
Mon, Jul 15, 3:56 PM · Restricted Project
sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • addressing comments
Mon, Jul 15, 9:26 AM · Restricted Project
sstefan1 added inline comments to D64162: [Attributor] Liveness analysis..
Mon, Jul 15, 9:25 AM · Restricted Project

Sat, Jul 13

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..
  • Change initialize, explore paths.
Sat, Jul 13, 10:58 AM · Restricted Project

Fri, Jul 12

sstefan1 committed rGcb5ecae1f6fe: Addition to rL365925, removing remaining virtuals (authored by sstefan1).
Addition to rL365925, removing remaining virtuals
Fri, Jul 12, 11:36 AM
sstefan1 committed rG15e86f707b15: [Attributor] Removing unnecessary `virtual` keywords. (authored by sstefan1).
[Attributor] Removing unnecessary `virtual` keywords.
Fri, Jul 12, 10:43 AM
sstefan1 added a comment to D63604: [Attributor] Deduce "nonnull" attribute.

We accumulated some unnecessary virtual declarations in the Attributor. I created D64637 to remove them in already committed patches. It would be good if you remove them in your active patches too.

Fri, Jul 12, 8:01 AM · Restricted Project
sstefan1 created D64637: [Attributor] Removing unnecessary `virtual` keywords..
Fri, Jul 12, 7:53 AM · Restricted Project

Thu, Jul 11

sstefan1 committed rG0626367202ce: [Attributor] Deduce "nosync" function attribute. (authored by sstefan1).
[Attributor] Deduce "nosync" function attribute.
Thu, Jul 11, 2:39 PM

Wed, Jul 10

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • rebase
  • addressing comments
  • ninja check-all passed
Wed, Jul 10, 10:38 AM · Restricted Project

Tue, Jul 9

sstefan1 added inline comments to D62766: [Attributor] Deduce "nosync" function attribute..
Tue, Jul 9, 1:45 AM · Restricted Project

Mon, Jul 8

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • non-convergent and readnone check.
  • Changed handling of intrinsics.
  • Added more tests.
Mon, Jul 8, 11:36 AM · Restricted Project

Fri, Jul 5

sstefan1 abandoned D63358: [Attributor] Tests for nounwind attribute..

Already committed with: https://reviews.llvm.org/D63379

Fri, Jul 5, 3:45 PM · Restricted Project
sstefan1 added a comment to D63358: [Attributor] Tests for nounwind attribute..

These have been committed, correct?

Fri, Jul 5, 2:37 PM · Restricted Project

Thu, Jul 4

sstefan1 updated the diff for D64162: [Attributor] Liveness analysis..

Addressed comments

Thu, Jul 4, 2:22 PM · Restricted Project

Wed, Jul 3

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • fixed tests & improved definition of nosync in langRef
Wed, Jul 3, 3:34 PM · Restricted Project
sstefan1 added inline comments to D62766: [Attributor] Deduce "nosync" function attribute..
Wed, Jul 3, 2:51 PM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • Add inline assembly test.
Wed, Jul 3, 2:39 PM · Restricted Project
sstefan1 added a comment to D64162: [Attributor] Liveness analysis..

I'm going to add tests tomorrow morning. Posted without so you can have a chance to take a look, as this is not yet complete in my opinion.

Wed, Jul 3, 2:34 PM · Restricted Project
sstefan1 created D64162: [Attributor] Liveness analysis..
Wed, Jul 3, 2:34 PM · Restricted Project

Tue, Jul 2

sstefan1 abandoned D64106: Summary: [Attributor] liveness analysis. This is only a first draft and should be modified heavily..
Tue, Jul 2, 3:27 PM · Restricted Project
sstefan1 updated the diff for D64106: Summary: [Attributor] liveness analysis. This is only a first draft and should be modified heavily..
  • fix diff
Tue, Jul 2, 3:26 PM · Restricted Project
sstefan1 created D64106: Summary: [Attributor] liveness analysis. This is only a first draft and should be modified heavily..
Tue, Jul 2, 3:19 PM · Restricted Project

Thu, Jun 27

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • changed nosync LangRef definition
Thu, Jun 27, 1:46 PM · Restricted Project
sstefan1 updated subscribers of D62766: [Attributor] Deduce "nosync" function attribute..

This does seem useful, although the description is overly narrow (what does nosync on its own have to do with freeing memory?).

Thu, Jun 27, 7:03 AM · Restricted Project
sstefan1 committed rG5360589b7d05: [Attributor] Deducing existing nounwind attribute. (authored by sstefan1).
[Attributor] Deducing existing nounwind attribute.
Thu, Jun 27, 4:29 AM
sstefan1 updated the diff for D63379: [Attributor] Deducing existing nounwind attribute..
  • reformated the code
  • fixed tests
Thu, Jun 27, 2:56 AM · Restricted Project

Wed, Jun 26

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • updated tests
Wed, Jun 26, 4:44 PM · Restricted Project

Mon, Jun 24

sstefan1 added a comment to D63379: [Attributor] Deducing existing nounwind attribute..

Is this sufficient to replace the old nounwind deduction? Can you disable the current one to see if there is something we cannot deduce with this one?

I already tried it on some of the other tests and it worked fine. I am going to that and test it some more, and update tomorrow morning.

Sorry for the late update. I ran all tests with -disable-nounwind-inference -attributor -attributor-disable=false and they pass. Is that enough?

I have now run the test-suite with -disable-nounwind-inference with attributor and functionattrs with nounwind, with attributor disabled. These are the results:

attributor.NumFnNoUnwind: 935 (-disable-nounwind-inference)
functionattrs.NumNoUnwind: 262 (-attributor-disable=true)

That looks good. Do you happen to know if and how many attributes are deduced by the funcattrs pass if we enable both?

Please run clang format on the Attributor.cpp and revert the non-functional changes, e.g., in the comments.

Mon, Jun 24, 5:18 PM · Restricted Project
sstefan1 updated the diff for D63379: [Attributor] Deducing existing nounwind attribute..
  • clang-format
Mon, Jun 24, 4:48 PM · Restricted Project
sstefan1 updated the diff for D63379: [Attributor] Deducing existing nounwind attribute..
  • Small fix
Mon, Jun 24, 4:45 PM · Restricted Project
sstefan1 added a comment to D62766: [Attributor] Deduce "nosync" function attribute..
In D62766#1555926, @jfb wrote:

Please add tests for the things I mention in comments, as well as:

  • relaxed volatile atomic load / store
  • inline assembly
Mon, Jun 24, 4:40 PM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • small fix
  • added include
  • Fix cast
Mon, Jun 24, 4:36 PM · Restricted Project
sstefan1 added a reviewer for D62766: [Attributor] Deduce "nosync" function attribute.: jfb.
Mon, Jun 24, 3:32 PM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • addressing comments.
Mon, Jun 24, 3:30 PM · Restricted Project

Sat, Jun 22

sstefan1 added a comment to D63379: [Attributor] Deducing existing nounwind attribute..

I have now run the test-suite with -disable-nounwind-inference with attributor and functionattrs with nounwind, with attributor disabled. These are the results:

Sat, Jun 22, 3:24 PM · Restricted Project

Jun 19 2019

sstefan1 added a comment to D63379: [Attributor] Deducing existing nounwind attribute..

Is this sufficient to replace the old nounwind deduction? Can you disable the current one to see if there is something we cannot deduce with this one?

I already tried it on some of the other tests and it worked fine. I am going to that and test it some more, and update tomorrow morning.

Jun 19 2019, 11:16 AM · Restricted Project

Jun 18 2019

sstefan1 added a comment to D63379: [Attributor] Deducing existing nounwind attribute..

Is this sufficient to replace the old nounwind deduction? Can you disable the current one to see if there is something we cannot deduce with this one?

I already tried it on some of the other tests and it worked fine. I am going to that and test it some more, and update tomorrow morning.

Jun 18 2019, 11:25 AM · Restricted Project

Jun 15 2019

sstefan1 created D63379: [Attributor] Deducing existing nounwind attribute..
Jun 15 2019, 9:36 AM · Restricted Project

Jun 14 2019

sstefan1 created D63358: [Attributor] Tests for nounwind attribute..
Jun 14 2019, 1:19 PM · Restricted Project

Jun 13 2019

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..

fixing diff

Jun 13 2019, 6:30 AM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • Making nosync an enum attribute.
Jun 13 2019, 6:21 AM · Restricted Project

Jun 12 2019

sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..
  • small changes
  • added some tests.
Jun 12 2019, 8:19 PM · Restricted Project

Jun 11 2019

sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..

fixed diff, addressed comments

Jun 11 2019, 8:12 PM · Restricted Project
sstefan1 added inline comments to D63067: [Attributor] NoAlias on return values..
Jun 11 2019, 9:28 AM · Restricted Project
sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..

addressing comments.

Jun 11 2019, 9:25 AM · Restricted Project
sstefan1 added a comment to D63067: [Attributor] NoAlias on return values..

Why should the return values in nonnull.ll be noalias?

All functions returning pointer never actually capture it, or they return null. Isn't that enough?

Jun 11 2019, 7:17 AM · Restricted Project

Jun 10 2019

sstefan1 updated the diff for D63067: [Attributor] NoAlias on return values..
  • Addressing comments.
  • Updated test cases in nonnull.ll
  • Added noalias.ll which, for now, has only one test case. More will be added with other patches regarding noalias attribute.
Jun 10 2019, 6:34 PM · Restricted Project

Jun 9 2019

sstefan1 retitled D63067: [Attributor] NoAlias on return values. from NoAlias on return values. to [Attributor] NoAlias on return values..
Jun 9 2019, 3:56 PM · Restricted Project
sstefan1 created D63067: [Attributor] NoAlias on return values..
Jun 9 2019, 3:50 PM · Restricted Project

Jun 7 2019

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • fixed isNonRelaxedAtomic
Jun 7 2019, 6:05 PM · Restricted Project
sstefan1 added inline comments to D62766: [Attributor] Deduce "nosync" function attribute..
Jun 7 2019, 8:05 AM · Restricted Project
sstefan1 committed rG128e8e8fb97c: test-commit (authored by sstefan1).
test-commit
Jun 7 2019, 7:17 AM

Jun 6 2019

sstefan1 updated the diff for D62424: Tests for nosync function attribute..

fixed the problem from last comment.

Jun 6 2019, 4:38 PM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • nosync small fixes.
  • fixing tests.
Jun 6 2019, 4:29 PM · Restricted Project

Jun 5 2019

sstefan1 added a comment to D62766: [Attributor] Deduce "nosync" function attribute..

Inline comments are now not in original order, so I'll reply here.

Jun 5 2019, 10:04 AM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..

Addresing comments.

Jun 5 2019, 9:53 AM · Restricted Project

Jun 4 2019

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..

small fixes

Jun 4 2019, 2:13 PM · Restricted Project
sstefan1 added a comment to D62766: [Attributor] Deduce "nosync" function attribute..

Does everything else look ok?

Jun 4 2019, 2:06 PM · Restricted Project

Jun 3 2019

sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..

addressed most of the comments.

Jun 3 2019, 5:43 PM · Restricted Project
sstefan1 added a comment to D62766: [Attributor] Deduce "nosync" function attribute..

Tests almost done. I'll update in couple hours.

Jun 3 2019, 2:34 PM · Restricted Project

Jun 2 2019

sstefan1 added inline comments to D62766: [Attributor] Deduce "nosync" function attribute..
Jun 2 2019, 6:34 PM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • Checking calls first. Adding checks for fences. Now using InfoCache.
Jun 2 2019, 6:28 PM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • removing fixpoint call
Jun 2 2019, 6:31 AM · Restricted Project
sstefan1 updated the diff for D62766: [Attributor] Deduce "nosync" function attribute..
  • small fix
  • comments and LangRef
Jun 2 2019, 6:28 AM · Restricted Project

May 31 2019

sstefan1 created D62766: [Attributor] Deduce "nosync" function attribute..
May 31 2019, 7:50 PM · Restricted Project
sstefan1 abandoned D62762: [Attributor] Deduce "nosync" function attribute.

wrong diff

May 31 2019, 7:35 PM · Restricted Project
sstefan1 updated the diff for D62762: [Attributor] Deduce "nosync" function attribute.

update

May 31 2019, 7:20 PM · Restricted Project
sstefan1 updated the diff for D62762: [Attributor] Deduce "nosync" function attribute.

changed updateImpl, the logic was wrong.

May 31 2019, 7:05 PM · Restricted Project
sstefan1 created D62762: [Attributor] Deduce "nosync" function attribute.
May 31 2019, 6:46 PM · Restricted Project

May 28 2019

sstefan1 added a comment to D62424: Tests for nosync function attribute..

What was the problem there? How does the output actually look?

May 28 2019, 11:43 PM · Restricted Project
sstefan1 updated the diff for D62424: Tests for nosync function attribute..
  • Fixed tests. Removed some 'CHECK-NEXT' directives.
  • Test now passing.
May 28 2019, 2:59 PM · Restricted Project

May 27 2019

sstefan1 updated the diff for D62424: Tests for nosync function attribute..
  • updated tests. Will run lit first thing in the morning.
May 27 2019, 3:32 PM · Restricted Project

May 26 2019

sstefan1 updated the diff for D62424: Tests for nosync function attribute..
  • typo in test 10.
May 26 2019, 1:35 AM · Restricted Project

May 25 2019

sstefan1 added a comment to D62424: Tests for nosync function attribute..

Addressed most of the comments.

May 25 2019, 4:28 PM · Restricted Project
sstefan1 updated the diff for D62424: Tests for nosync function attribute..
  • updated tests for nosync.
May 25 2019, 4:23 PM · Restricted Project

May 24 2019

sstefan1 created D62424: Tests for nosync function attribute..
May 24 2019, 1:37 PM · Restricted Project