Page MenuHomePhabricator

sscalpone (Steve Scalpone)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2018, 10:54 AM (106 w, 1 d)

Recent Activity

Mon, Nov 9

sscalpone accepted D91081: [flang] Avoid calling the linker when "-c" option is used.

Thanks Pete!

Mon, Nov 9, 9:54 AM · Restricted Project, Restricted Project

Sep 7 2020

sscalpone accepted D87226: [flang] Convert release notes to markdown.
Sep 7 2020, 9:02 AM · Restricted Project

Aug 31 2020

sscalpone added a comment to D86875: [Flang][NFC] Remove license comments from files in docs/ folder..

@sameeranjoshi Please consider fixing this issue in the conversion tool (maybe commonmark.py) & propagating the fix to llvm.org?

Aug 31 2020, 9:24 AM · Restricted Project
sscalpone added a comment to D86875: [Flang][NFC] Remove license comments from files in docs/ folder..

Why?

Aug 31 2020, 7:36 AM · Restricted Project

Aug 27 2020

sscalpone accepted D86740: [flang][NFC] Change how error symbols are recorded.
Aug 27 2020, 4:55 PM · Restricted Project, Restricted Project

Aug 25 2020

sscalpone added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

@Meinersbur. Hi Michael, I believe you prefer @klausler to make the patch, so he's going ahead with it.

Aug 25 2020, 8:21 AM · Restricted Project, Restricted Project

Aug 22 2020

sscalpone accepted D86131: [FLANG] Pick `.md` files when building sphinx documentation..

The install target required me to build all of the documentation. I do not think that is related to this change. Otherwise, the web pages rendered nicely.

Aug 22 2020, 8:39 AM · Restricted Project, Restricted Project
sscalpone accepted D86325: [flang][openacc] Fix wait-argument for wait clause + add tests.
Aug 22 2020, 8:29 AM · Restricted Project, Restricted Project

Aug 21 2020

sscalpone accepted D86357: [flang] Fix assert on bad character kind.
Aug 21 2020, 12:07 PM · Restricted Project, Restricted Project

Aug 18 2020

sscalpone requested changes to D86131: [FLANG] Pick `.md` files when building sphinx documentation..

Please add a note to the overview about this requirement:

After this patch the markdown docmentation must be written using guide in-
llvm/docs/MarkdownQuickstartTemplate.md

Aug 18 2020, 8:36 AM · Restricted Project, Restricted Project

Aug 17 2020

sscalpone accepted D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.
Aug 17 2020, 2:53 PM · Restricted Project
sscalpone accepted D86107: [flang] Improve error messages for procedures in expressions.
Aug 17 2020, 2:52 PM · Restricted Project, Restricted Project

Aug 15 2020

sscalpone accepted D85851: [flang][directives] Use TableGen to generate clause unparsing.

Looks good!

Aug 15 2020, 9:02 AM · Restricted Project, Restricted Project
sscalpone added a comment to D84334: [flang] Version information in flang/f18.

Sorry, I'm not sure what to do next. I'm using cmake vesion 3.18.0 and gcc 9.3.0.

Aug 15 2020, 8:44 AM · Restricted Project, Restricted Project

Aug 14 2020

sscalpone requested changes to D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.

I think you missed one.

Aug 14 2020, 8:25 AM · Restricted Project

Aug 13 2020

sscalpone requested changes to D84334: [flang] Version information in flang/f18.

Did this work for you?

Aug 13 2020, 10:23 PM · Restricted Project, Restricted Project
sscalpone reopened D84334: [flang] Version information in flang/f18.
Aug 13 2020, 1:24 PM · Restricted Project, Restricted Project

Aug 12 2020

sscalpone added a comment to D84334: [flang] Version information in flang/f18.

This worked for me:

Aug 12 2020, 10:03 PM · Restricted Project, Restricted Project
sscalpone accepted D85864: [flang] Correct manipulation of mixed complex expressions.
Aug 12 2020, 9:44 PM · Restricted Project, Restricted Project
sscalpone accepted D85862: [flang] Ensure Preprocessor::Define() saves macro names correctly.
Aug 12 2020, 8:57 PM · Restricted Project, Restricted Project
sscalpone requested changes to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

I think md is the wave of the future. Other llvm subproject use md. Let's stick with what we have unless there's a compelling advantage to using rst or another format.

Aug 12 2020, 8:02 AM · Restricted Project

Aug 10 2020

sscalpone accepted D85694: [flang] Disable -Wmaybe-uninitialized for GCC.
Aug 10 2020, 5:52 PM · Restricted Project, Restricted Project
sscalpone added a comment to D84334: [flang] Version information in flang/f18.

This commit has broken the out of tree builds.

Aug 10 2020, 1:18 PM · Restricted Project, Restricted Project

Aug 7 2020

sscalpone accepted D85549: [flang][directives] Use TableGen information for clause classes in parse-tree.
Aug 7 2020, 4:37 PM · Restricted Project, Restricted Project
sscalpone accepted D85560: [flang] Handle DATA initialization of EQUIVALENCE'd objects.
Aug 7 2020, 4:24 PM · Restricted Project, Restricted Project

Aug 6 2020

sscalpone accepted D85483: [flang] Improve message for assignment to subprogram.
Aug 6 2020, 6:50 PM · Restricted Project, Restricted Project
sscalpone accepted D85492: [flang] Support DATA statement initialization of numeric with Hollerith/CHARACTER.
Aug 6 2020, 6:48 PM · Restricted Project, Restricted Project
sscalpone accepted D85491: [flang] Descriptor-based I/O data item transfers.
Aug 6 2020, 6:31 PM · Restricted Project, Restricted Project
sscalpone accepted D85489: [flang][NFC] Reformat files with current clang-format.
Aug 6 2020, 6:27 PM · Restricted Project, Restricted Project

Aug 5 2020

sscalpone added a comment to D85212: [flang] Add parser support for OpenMP allocate clause.

out of place as in for a different directive where it is not supported?

Aug 5 2020, 3:13 PM · Restricted Project, Restricted Project
sscalpone accepted D85363: [flang] Add options to control IMPLICIT NONE.

OK

Aug 5 2020, 3:08 PM · Restricted Project, Restricted Project
sscalpone added a comment to D85363: [flang] Add options to control IMPLICIT NONE.

The gfortran options is -fimplicit-none. It doesn't appear to have an inverse, but following the convention would be -fno-implicit-none. I think there is value using the same spelling for this option.

Aug 5 2020, 2:23 PM · Restricted Project, Restricted Project
sscalpone added a comment to D84334: [flang] Version information in flang/f18.

Here are the clang definitions:

Aug 5 2020, 8:39 AM · Restricted Project, Restricted Project
sscalpone accepted D85104: [flang][NFC] Unify OpenMP and OpenACC structure checker.
Aug 5 2020, 8:17 AM · Restricted Project, Restricted Project
sscalpone accepted D85212: [flang] Add parser support for OpenMP allocate clause.

Do you have a negative test that checks for an out-of-place allocate?

Aug 5 2020, 8:08 AM · Restricted Project, Restricted Project

Aug 3 2020

sscalpone accepted D85136: [flang] Fix bug detecting intrinsic function.

Fix fm324 and fm333. Thanks

Aug 3 2020, 12:17 PM · Restricted Project, Restricted Project

Jul 31 2020

sscalpone added a comment to D84864: [flang] Add release notes for LLVM 11 release.

No objection to first moving documentation to docs. If someone takes this on, there are links that need to be updated, relatively in the project and in for example Gary's call notes.

Jul 31 2020, 10:33 AM · Restricted Project
sscalpone added a comment to D84856: [flang] Add details to --help screen on default behaviour.

Hi Rich, sorry not to have replied to your other review. No one on the NV team needs f18 to read from stdin.

Jul 31 2020, 10:18 AM · Restricted Project

Jul 30 2020

sscalpone requested changes to D84864: [flang] Add release notes for LLVM 11 release.
Jul 30 2020, 7:53 AM · Restricted Project
sscalpone added a comment to D84867: [flang] Add placeholder ReleaseNotes file.

Hi Rich, for clang, for example, what's the process for collecting changes and updating the release notes?

Jul 30 2020, 7:49 AM · Restricted Project

Jul 29 2020

sscalpone added a reviewer for D84851: [flang] Add -h as a synonym for help: sscalpone.
Jul 29 2020, 8:55 AM · Restricted Project, Restricted Project

Jul 25 2020

sscalpone accepted D84588: [flang] Fix implicit declarations in statement functions.

Looks good, Tim. The fcvs tests fm311 passes with this change.

Jul 25 2020, 10:58 AM · Restricted Project, Restricted Project

Jul 24 2020

sscalpone accepted D84340: Order of libraries and source files in the f18 frontend.
Jul 24 2020, 4:15 PM · Restricted Project, Restricted Project

Jul 22 2020

sscalpone accepted D84370: [flang] Add runtime I/O APIs for COMPLEX formatted input.
Jul 22 2020, 5:44 PM · Restricted Project, Restricted Project
sscalpone added a comment to D84022: [flang] Fix multi-config generator builds..

Michael Kruse reports that he has successfully built flang on Windows. Perhaps he could take a look?

Jul 22 2020, 1:06 PM · Restricted Project
sscalpone accepted D84334: [flang] Version information in flang/f18.
Jul 22 2020, 12:59 PM · Restricted Project, Restricted Project

Jul 21 2020

sscalpone accepted D84281: [flang] Replay a FORMAT at the right position.
Jul 21 2020, 6:31 PM · Restricted Project, Restricted Project
sscalpone accepted D84280: [flang] Fix source line continuation in potential macro calls (bugzilla 46768).

Thank you.

Jul 21 2020, 6:17 PM · Restricted Project, Restricted Project
sscalpone accepted D84284: [flang] Implement byte-swapped external unformatted I/O in runtime.
Jul 21 2020, 5:37 PM · Restricted Project, Restricted Project
sscalpone accepted D84282: [flang] Handle leading zeroes after decimal in REAL formatted input.
Jul 21 2020, 5:31 PM · Restricted Project, Restricted Project
sscalpone accepted D84283: [flang] Check for misplaced labels.
Jul 21 2020, 5:31 PM · Restricted Project, Restricted Project
sscalpone accepted D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.

Look good. Thanks. P.S. Is someone going to ask about -r8 soon?

Jul 21 2020, 2:39 PM · Restricted Project, Restricted Project

Jul 20 2020

sscalpone added a comment to D83946: [flang] Run non-gtest unit tests with lit..

The external-hello-world requires input. Does lit handle that well?

Jul 20 2020, 10:32 PM · Restricted Project
sscalpone accepted D83946: [flang] Run non-gtest unit tests with lit..
Jul 20 2020, 9:51 AM · Restricted Project
sscalpone added a comment to D84022: [flang] Fix multi-config generator builds..

Hi David, what is a multi-config generator build? And how do I try it?

Jul 20 2020, 9:48 AM · Restricted Project

Jul 17 2020

sscalpone accepted D84059: Insert leading blanks in LOGICAL formatted output fields.
Jul 17 2020, 6:24 PM · Restricted Project, Restricted Project
sscalpone accepted D84079: [flang] Prevent bogus runtime I/O error message.
Jul 17 2020, 5:12 PM · Restricted Project, Restricted Project
sscalpone accepted D84078: [flang] Treat tabs like spaces in formatted input..

The standard goes out of its way not to define blanks.

Jul 17 2020, 5:11 PM · Restricted Project, Restricted Project
sscalpone accepted D84077: [flang] Support <name>=<integer> syntax in compiler directives.
Jul 17 2020, 4:50 PM · Restricted Project, Restricted Project
sscalpone accepted D84061: [flang] Allow ! and // comments after some preprocessing directives.
Jul 17 2020, 2:43 PM · Restricted Project, Restricted Project
sscalpone accepted D84063: [flang] Rework read/write permission management for runtime file opening.
Jul 17 2020, 2:06 PM · Restricted Project, Restricted Project

Jul 15 2020

sscalpone added a comment to D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.

Hi @jurahul, there's certainly no objection for you to commit this change in llvm-project, especially if the change is required to keep llvm building properly.

Jul 15 2020, 7:08 PM · Restricted Project
sscalpone accepted D83899: [flang] Fix erroneous application of SAVE statement.
Jul 15 2020, 12:42 PM · Restricted Project, Restricted Project
sscalpone accepted D83522: [flang] Adopt NoRegionArguments (WhereOp) and ParentOneOf (ResultOp) traits.
Jul 15 2020, 7:30 AM · Restricted Project
sscalpone added a comment to D83808: [flang] Refine CR handling.

Changing the topic a bit:

Jul 15 2020, 7:28 AM · Restricted Project, Restricted Project
sscalpone added a comment to D83808: [flang] Refine CR handling.

It sounds like this fixes a problem. Would it be possible to add a test?

Jul 15 2020, 6:39 AM · Restricted Project, Restricted Project

Jul 14 2020

sscalpone accepted D83835: [flang] Fix out-of-tree build with missing acc_gen target.

Tested against a build and install directory; both work great. Thanks.

Jul 14 2020, 5:45 PM · Restricted Project
sscalpone accepted D83810: [flang] Fix list-directed input (repeated nulls and LOGICAL).
Jul 14 2020, 2:40 PM · Restricted Project, Restricted Project

Jul 13 2020

sscalpone accepted D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..
Jul 13 2020, 10:11 AM · Restricted Project, Restricted Project

Jul 10 2020

sscalpone accepted D83488: [flang] Change the default F18_FC to gfortran.
Jul 10 2020, 8:15 AM · Restricted Project, Restricted Project

Jul 8 2020

sscalpone accepted D83428: [flang] Fix negative unit number hashing.
Jul 8 2020, 5:09 PM · Restricted Project, Restricted Project

Jul 7 2020

sscalpone accepted D83355: [flang] upstream intrinsic call lowering.
Jul 7 2020, 5:08 PM · Restricted Project, Restricted Project
sscalpone accepted D83352: [flang] Fix CHARACTER length folding problem.
Jul 7 2020, 3:52 PM · Restricted Project, Restricted Project
sscalpone accepted D83112: [flang] Added missing runtime I/O definitions.
Jul 7 2020, 8:14 AM · Restricted Project
sscalpone retitled D83112: [flang] Added missing runtime I/O definitions from Added missing runtime I/O definitions to [flang] Added missing runtime I/O definitions.
Jul 7 2020, 8:14 AM · Restricted Project
sscalpone added a reviewer for D83112: [flang] Added missing runtime I/O definitions: klausler.
Jul 7 2020, 8:09 AM · Restricted Project
sscalpone added a comment to D83227: [flang] Add algorithm include to runtime/file.cpp for std::min.

Is this a dup of 1b183918184ecbcd03898badf8d1789ea0f4ffe4?

Jul 7 2020, 8:06 AM · Restricted Project

Jul 6 2020

sscalpone accepted D83267: [flang] Add lowering of I/O statements.
Jul 6 2020, 9:28 PM · Restricted Project, Restricted Project
sscalpone added a comment to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Any syntax error will lead to chain of errors. It will be tough to add a case for invalid syntax.

Jul 6 2020, 9:21 PM · Restricted Project, Restricted Project

Jul 5 2020

sscalpone accepted D83164: [flang] Basic tests of external I/O runtime (part 9/9).
Jul 5 2020, 3:28 PM · Restricted Project, Restricted Project

Jul 4 2020

sscalpone accepted D83162: [flang] Add fixes and missing stmts to I/O runtime API handlers (ext. I/O part 8).
Jul 4 2020, 11:49 AM · Restricted Project, Restricted Project

Jul 3 2020

sscalpone accepted D83147: [flang] Further implementation of external I/O unit operations (part 6).
Jul 3 2020, 3:07 PM · Restricted Project, Restricted Project
sscalpone accepted D83142: [flang] Make 'num_images()' intrinsic.

Please remove num_images from the list of unimplemented intrinsics in flang/documentation/Intrinsics.md.

Jul 3 2020, 12:31 PM · Restricted Project, Restricted Project
sscalpone accepted D83107: [flang] Add FIR builder.
Jul 3 2020, 11:52 AM · Restricted Project, Restricted Project
sscalpone accepted D83140: [flang] Define new runtime error IOSTAT values (I/O runtime work part 4).
Jul 3 2020, 11:52 AM · Restricted Project, Restricted Project
sscalpone accepted D83141: [flang] Track known file size, add IsATerminal (ext. I/O work part 5).
Jul 3 2020, 11:52 AM · Restricted Project, Restricted Project

Jul 2 2020

sscalpone accepted D83104: [flang] External I/O runtime work, repackaged (part 2).
Jul 2 2020, 4:45 PM · Restricted Project, Restricted Project
sscalpone accepted D83098: [flang] External I/O runtime work, repackaged (part 1).
Jul 2 2020, 3:41 PM · Restricted Project, Restricted Project
sscalpone accepted D83060: [flang] Clean up binary dependences of runtime libraries.
Jul 2 2020, 11:51 AM · Restricted Project, Restricted Project
sscalpone accepted D83063: [flang] Fix bug determining alternate return.
Jul 2 2020, 11:51 AM · Restricted Project, Restricted Project
sscalpone accepted D83051: [flang][NFC] Move and rework pgmath description used in folding.
Jul 2 2020, 8:37 AM · Restricted Project, Restricted Project

Jul 1 2020

sscalpone accepted D83007: [flang] Add more support for alternate returns.
Jul 1 2020, 4:45 PM · Restricted Project, Restricted Project

Jun 30 2020

sscalpone accepted D82795: [flang] Silence some warnings from clang-tidy.

I put out a call on slack for a volunteer to update clang-tidy/llvm/IncludeOrderCheck.cpp

Jun 30 2020, 9:12 AM · Restricted Project, Restricted Project

Jun 29 2020

sscalpone accepted D82790: [flang] Coarray lowering.
Jun 29 2020, 11:04 PM · Restricted Project, Restricted Project
sscalpone requested changes to D82795: [flang] Silence some warnings from clang-tidy.

Perhaps update clang-tools-extra/clang-tidy/llvm/IncludeOrderCheck.cpp to include flang in the llvm-include-order rule?

Jun 29 2020, 11:04 PM · Restricted Project, Restricted Project
sscalpone accepted D82807: [clang-tidy] Allows the prevailing include header guard in Flang ....
Jun 29 2020, 11:04 PM · Restricted Project, Restricted Project

Jun 28 2020

sscalpone accepted D82693: [flang] Upstream two FIR transformation passes.
Jun 28 2020, 10:16 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2020

sscalpone accepted D82309: [flang] Fix bug checking SAVE attribute.
Jun 22 2020, 11:17 AM · Restricted Project, Restricted Project

Jun 19 2020

sscalpone accepted D82140: [flang] Upstream SymbolMap.
Jun 19 2020, 10:52 AM · Restricted Project, Restricted Project

Jun 15 2020

sscalpone added a comment to D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.

We have tracking per OpenMP directives/constructs in a google docs spreadsheet (link below).

Jun 15 2020, 10:55 AM · Restricted Project, Restricted Project