User Details
- User Since
- Mar 18 2014, 10:33 AM (471 w, 6 h)
Sun, Mar 12
I'm not the right person to review this. @Gerolf, perhaps you can suggest an alternate?
Fri, Mar 10
Thu, Mar 9
Wed, Mar 8
Oh, de-refining is pretty nifty / evil. This patch has background:
https://reviews.llvm.org/D18634
Tue, Mar 7
Mon, Mar 6
LGTM too.
Sun, Mar 5
LGTM.
Feb 24 2023
Feb 20 2023
Great to see this making progress; looking forward to seeing the related workarounds removed from the Darwin SDKs.
Jan 26 2023
LGTM
Jan 22 2023
It's nice how simple this is!
Jan 6 2023
Jan 5 2023
Jan 3 2023
LGTM with one bit inline.
Dec 30 2022
Dec 29 2022
Dec 14 2022
Dec 13 2022
Dec 10 2022
I don't know much about this code; resigning as reviewer. But I took a quick look. I wonder if this the right fix, or whether VLIWPacketizerList::VLIWScheduler's type should be ScheduleDAGInstrs, and downcast when necessary on use, allowing DefaultVLIWScheduler to stay private. (Up to others to sort out!)
Dec 8 2022
Dec 7 2022
[Resigning as reviewer, since I was the original author, but feel free ping me explicitly if I can be helpful for something and I'm not volunteering anything...]
Dec 6 2022
Dec 2 2022
Nov 30 2022
LGTM.
Nov 29 2022
Nov 28 2022
Here's a link to a related RFC:
https://discourse.llvm.org/t/rfc-constantdata-should-not-have-use-lists/42606
Separate flags allows vendors (and the default!) to have use-list order on-by-default in bitcode and off-by-default in textual IR.
Nov 24 2022
I just realized @jansvoboda11 is probably out on holiday this week (IIRC, Apple usually gets this week off). Since this was committed almost a month ago, I'm guessing this isn't enough of a blocker that we need to revert rather than wait until next week (and there are some commits on top that rely on this!). But probably reverting the stack would be an option if it's critical.
Nov 18 2022
Nov 16 2022
LGTM!
Nov 14 2022
Nov 11 2022
Nov 9 2022
Nov 8 2022
Would it be simpler to define < for that case? Or, we could define a custom one to send to the std::map:
struct CompareValID { static bool operator<(const ValID &LHS, const ValID &RHS) { if (LHS.Kind != RHS.Kind) return LHS.Kind < RHS.Kind; return LHS < RHS; } };
Nov 2 2022
Consider making the FileEntryRef changes here the default -- it doesn't make sense to me that FileEntryRef == or DenseMap would match FileEntry pointer semantics instead of filename semantics.
Nov 1 2022
LGTM, with one suggestion for the test inline.
LGTM.
LGTM, although I there's format-is-probably-compatible-version as a courtesy for tooling, does that need a bump here?
LGTM.
LGTM.
LGTM.
Oct 28 2022
Oct 27 2022
Oct 19 2022
As an end goal, it seems strictly better for build systems / distribution / artifact storage / caching if the output PCM has been canonicalized as-if the module maps weren't found, rather than tracking both which module maps were discovered and which to ignore. Ideally, we'd find a way to canonicalize the output efficiently and correctly... along the lines of this patch, but with a bug fix somewhere.
Oct 17 2022
Oct 10 2022
I would think we could convert every assert(0) to either llvm::report_fatal_error (guaranteed trap) or llvm_unreachable() (trap or optimize, depending on CMAKE configuration). The C API usage checks seem like good candidates for the former.
Oct 6 2022
Oct 4 2022
Oct 3 2022
Sep 30 2022
SGTM.