Page MenuHomePhabricator

dexonsmith (Duncan P. N. Exon Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 18 2014, 10:33 AM (304 w, 3 d)

Recent Activity

Yesterday

dexonsmith created D72970: clang: Only define OBJC_NEW_PROPERTIES when -x objective-c.
Fri, Jan 17, 5:42 PM

Thu, Jan 16

dexonsmith accepted D72860: [modules] Do not cache invalid state for modules that we attempted to load..

LGTM.

Thu, Jan 16, 12:28 PM · Restricted Project

Wed, Jan 15

dexonsmith added a comment to D72399: [Support] Replace Windows __declspec(thread) with thread_local in LLVM_THREAD_LOCAL.
In D72399#1822902, @rnk wrote:

Honestly, if __thread is available, I wonder if LLVM should prefer that, since it implements the check that the variable is trivially constructible/destructible. But, that has no bearing on which declspec to use.

Is "trivially constructible/destructible" actually a requirement for this? I thought that restriction was due to host platforms which didn't support C++11 thread_local (hence if/when every platform supported C++11 thread_local then the restriction would go away).

Yes, LLVM still supports platforms which do not support C++11 thread_local, so for LLVM, there is still a requirement that things be trivially constructible/destructible. If we used __thread when available, the compiler would enforce that check earlier, rather than letting the contributor commit, push, and find out about this requirement from a buildbot.

Wed, Jan 15, 3:15 PM · Restricted Project

Thu, Jan 9

GitHub <noreply@github.com> committed rG2089a0d09bbc: Merge pull request #314 from dexonsmith/docs/apple-branching-scheme (authored by dexonsmith).
Merge pull request #314 from dexonsmith/docs/apple-branching-scheme
Thu, Jan 9, 3:53 PM
dexonsmith committed rG752558d42de3: apple-docs: Document Apple's branching scheme (authored by dexonsmith).
apple-docs: Document Apple's branching scheme
Thu, Jan 9, 3:53 PM

Dec 12 2019

GitHub <noreply@github.com> committed rG7cc97aaffc5d: Merge pull request #340 from dexonsmith/llvm/arc/cherry-pick-autoreleaserv… (authored by dexonsmith).
Merge pull request #340 from dexonsmith/llvm/arc/cherry-pick-autoreleaserv…
Dec 12 2019, 3:53 PM
dexonsmith committed rG5da777193445: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls (authored by dexonsmith).
llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls
Dec 12 2019, 3:53 PM
dexonsmith committed rG9eda4238fa28: llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls… (authored by dexonsmith).
llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls…
Dec 12 2019, 3:53 PM
dexonsmith committed rG669812befd5f: llvm/ObjCARC: Use continue to reduce some nesting, NFC (authored by dexonsmith).
llvm/ObjCARC: Use continue to reduce some nesting, NFC
Dec 12 2019, 3:53 PM
GitHub <noreply@github.com> committed rGd976623568b3: Merge pull request #328 from MadCoder/eng/PR-2684889-direct (authored by dexonsmith).
Merge pull request #328 from MadCoder/eng/PR-2684889-direct
Dec 12 2019, 3:53 PM
GitHub <noreply@github.com> committed rG7f22c4d4867f: Merge pull request #289 from dexonsmith/clang/Modules/20191106/cherry-picks-for… (authored by dexonsmith).
Merge pull request #289 from dexonsmith/clang/Modules/20191106/cherry-picks-for…
Dec 12 2019, 3:52 PM
dexonsmith committed rGdfb6397de0b8: clang/Modules: Error if ReadASTBlock does not find the main module (authored by dexonsmith).
clang/Modules: Error if ReadASTBlock does not find the main module
Dec 12 2019, 3:51 PM
dexonsmith committed rGd250fb8b68f5: clang/Modules: Clean up modules on error in ReadAST (authored by dexonsmith).
clang/Modules: Clean up modules on error in ReadAST
Dec 12 2019, 3:51 PM
dexonsmith committed rGeea0b7cfcc46: clang/Modules: Add missing diagnostics for malformed AST files (authored by dexonsmith).
clang/Modules: Add missing diagnostics for malformed AST files
Dec 12 2019, 3:51 PM
dexonsmith committed rG5a5a2980ec4c: clang/Modules: Split loop in ReadAST between failable and not (authored by dexonsmith).
clang/Modules: Split loop in ReadAST between failable and not
Dec 12 2019, 3:51 PM
dexonsmith committed rGa08033917c5d: clang/Modules: Use range-based for in ASTReader::ReadAST, NFC (authored by dexonsmith).
clang/Modules: Use range-based for in ASTReader::ReadAST, NFC
Dec 12 2019, 3:51 PM
dexonsmith committed rG9c772f2d7b7b: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight (authored by dexonsmith).
clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight
Dec 12 2019, 3:51 PM
dexonsmith committed rG94f1f0a63411: clang/Modules: Remove unused parameter from ModuleManager::removeModules (authored by dexonsmith).
clang/Modules: Remove unused parameter from ModuleManager::removeModules
Dec 12 2019, 3:51 PM
dexonsmith committed rGd42237e35632: libc: Merge in missing content from 7b9fd37f (authored by dexonsmith).
libc: Merge in missing content from 7b9fd37f
Dec 12 2019, 3:02 PM
dexonsmith committed rGd9a81d068a1d: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by dexonsmith).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:09 PM

Dec 9 2019

dexonsmith added a comment to D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode.

Yeah, the discussion Jin and I had privately was that we should split the Swift ABI version out of the ObjC GC global metadata and update the backend so that it assembles the image info appropriately from different places. I don't know what happened to that.

That will probably require an IR updater, but that shouldn't be a problem.

Dec 9 2019, 2:35 PM · Restricted Project
dexonsmith added reviewers for D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode: ahatanak, steven_wu.
Dec 9 2019, 2:01 PM · Restricted Project

Dec 5 2019

dexonsmith added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

I guess Duncan's comments on https://reviews.llvm.org/D70568 were for this patch. I think it would be good to have:

Dec 5 2019, 11:21 AM · Restricted Project, Restricted Project
dexonsmith added a comment to D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions.
Dec 5 2019, 11:21 AM · Restricted Project, Restricted Project

Dec 3 2019

dexonsmith added a comment to D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions.

Can we make this configurable somehow? (E.g., leave behind an -ffork-cc1 -fno-fork-cc1 and a CMake flag to pick? Or just the CMake flag?)

Dec 3 2019, 4:37 PM · Restricted Project, Restricted Project
dexonsmith added a comment to D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions.

This is really cool; we've wanted this for a long time.

Dec 3 2019, 4:37 PM · Restricted Project, Restricted Project

Dec 2 2019

dexonsmith accepted D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies.

LGTM, although I have a suggested change for one of the comments (and I'm still sad about this).

Dec 2 2019, 6:24 PM · Restricted Project

Nov 22 2019

dexonsmith committed rG20d51b2f14ac: clang/Modules: Rename CompilerInstance::ModuleManager, NFC (authored by dexonsmith).
clang/Modules: Rename CompilerInstance::ModuleManager, NFC
Nov 22 2019, 6:31 PM
dexonsmith closed D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC.

Pushed as 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d.

Nov 22 2019, 6:31 PM
dexonsmith committed rG5cca622310c1: clang/Modules: Refactor CompilerInstance::loadModule, NFC (authored by dexonsmith).
clang/Modules: Refactor CompilerInstance::loadModule, NFC
Nov 22 2019, 6:27 PM
dexonsmith closed D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.

Pushed as 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d.

Nov 22 2019, 6:27 PM

Nov 21 2019

dexonsmith committed rGf7170d17a846: clang/Modules: Move Serialization/Module.{h,cpp} to ModuleFile, NFC (authored by dexonsmith).
clang/Modules: Move Serialization/Module.{h,cpp} to ModuleFile, NFC
Nov 21 2019, 7:12 PM
dexonsmith added a parent revision for D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC: D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.
Nov 21 2019, 6:45 PM
dexonsmith added a child revision for D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC: D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC.
Nov 21 2019, 6:45 PM
dexonsmith created D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC.
Nov 21 2019, 6:45 PM
dexonsmith added inline comments to D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.
Nov 21 2019, 2:39 PM
dexonsmith added inline comments to D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.
Nov 21 2019, 12:22 PM
dexonsmith created D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.
Nov 21 2019, 12:13 PM

Nov 19 2019

dexonsmith committed rG870083173481: clang/Modules: Early return in CompilerInstance::createModuleManager, NFC (authored by dexonsmith).
clang/Modules: Early return in CompilerInstance::createModuleManager, NFC
Nov 19 2019, 6:23 PM
dexonsmith added a comment to D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping.

For some reason this revision is locked down and I'm not allowed to "edit" it, which includes adding inline review comments. Can you add me as a reviewer?

Nov 19 2019, 6:05 PM · Restricted Project
dexonsmith committed rG69242e986823: clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC (authored by dexonsmith).
clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC
Nov 19 2019, 4:14 PM
dexonsmith committed rG8c4840506908: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes (authored by dexonsmith).
Wrap C APIs with pragmas enforcing -Werror=strict-prototypes
Nov 19 2019, 1:20 PM
dexonsmith closed D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

lgtm as long as other compilers don't warn on unknown pragmas by default.

godbolt.org says that GCC doesn't have -Wunknown-pragmas by default, but it is in -Wall. I'd better guard this more closely with __clang__.

Nov 19 2019, 1:20 PM · Restricted Project
dexonsmith added a comment to D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

lgtm as long as other compilers don't warn on unknown pragmas by default.

Nov 19 2019, 1:01 PM · Restricted Project
dexonsmith committed rG3279724905c1: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls (authored by dexonsmith).
llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls
Nov 19 2019, 12:06 PM
dexonsmith closed D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

Pushed as 3279724905c14a8db383ade53af40a0dd49504d8.

Nov 19 2019, 12:06 PM · Restricted Project
dexonsmith accepted D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

@rjmccall gave me an LGTM offline.

Nov 19 2019, 12:06 PM · Restricted Project

Nov 18 2019

dexonsmith updated the diff for D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

It wasn't clear to me, but is the pair deleted only if there are no instructions that return false for isSafeBetweenRVCalls in between?

I thought it was okay to skip over all opaque calls, but I've changed the code to check for this.

Nov 18 2019, 6:53 PM · Restricted Project
dexonsmith updated the diff for D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

Respond to Akira's feedback.

Nov 18 2019, 2:01 PM · Restricted Project
dexonsmith added a comment to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

It wasn't clear to me, but is the pair deleted only if there are no instructions that return false for isSafeBetweenRVCalls in between?

Nov 18 2019, 2:01 PM · Restricted Project
dexonsmith committed rGd4e1ba3fa9df: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)) (authored by MadCoder).
Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))
Nov 18 2019, 11:54 AM
dexonsmith closed D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).

Pushed as d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1.

Nov 18 2019, 11:53 AM · Restricted Project
dexonsmith added inline comments to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.
Nov 18 2019, 11:26 AM · Restricted Project
dexonsmith updated the diff for D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

Adding more testcases. The bitcast tests uncovered problems with the RAUW calls, which I also fixed.

Nov 18 2019, 11:26 AM · Restricted Project

Nov 17 2019

dexonsmith added inline comments to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.
Nov 17 2019, 10:11 PM · Restricted Project
dexonsmith closed D70369: llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls, NFC.

Committed in 783cb86b616d9de59213ea17649d6e2df8c1ebbb.

Nov 17 2019, 10:08 PM · Restricted Project
dexonsmith updated the diff for D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

Added an assertion for clarity and fixed a comment.

Nov 17 2019, 10:08 PM · Restricted Project
dexonsmith committed rG783cb86b616d: llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls… (authored by dexonsmith).
llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls…
Nov 17 2019, 10:03 PM
dexonsmith added a parent revision for D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls: D70369: llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls, NFC.
Nov 17 2019, 8:00 PM · Restricted Project
dexonsmith added a child revision for D70369: llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls, NFC: D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.
Nov 17 2019, 8:00 PM · Restricted Project
dexonsmith created D70369: llvm/ObjCARC: Split OptimizeIndividualCallImpl out of OptimizeIndividualCalls, NFC.
Nov 17 2019, 8:00 PM · Restricted Project
dexonsmith created D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.
Nov 17 2019, 8:00 PM · Restricted Project
dexonsmith committed rGa937a588dd29: llvm/ObjCARC: Use continue to reduce some nesting, NFC (authored by dexonsmith).
llvm/ObjCARC: Use continue to reduce some nesting, NFC
Nov 17 2019, 6:23 PM

Nov 15 2019

dexonsmith updated the diff for D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

s/C_STRING_PROTOTYPES_/C_STRICT_PROTOTYPES_/ to fix some typos.

Nov 15 2019, 1:21 PM · Restricted Project
dexonsmith added inline comments to D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.
Nov 15 2019, 1:12 PM · Restricted Project
dexonsmith updated the diff for D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

Adding guards for _MSC_VER.

Nov 15 2019, 1:12 PM · Restricted Project

Nov 14 2019

dexonsmith added a comment to D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

Note that we have C files including these headers in llvm/tools/llvm-c-test and clang/tools/c-index-test, and I tested that dropping a (void) to just () triggers the error when compiling those.

Nov 14 2019, 6:26 PM · Restricted Project
dexonsmith added a comment to D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping.

The code looks right, but can you add a test for this in CodeGenObjC? Also, when you re-upload the patch with the tests, please use -U9999999 to provide full context in the diff.

Nov 14 2019, 6:08 PM · Restricted Project
dexonsmith created D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.
Nov 14 2019, 5:58 PM · Restricted Project
dexonsmith requested changes to D11833: s/NDEBUG/LLVM_NDEBUG/ in most places.

Stepping back to look at the goals:

Nov 14 2019, 11:48 AM
dexonsmith added inline comments to D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members)).
Nov 14 2019, 10:06 AM · Restricted Project

Nov 13 2019

dexonsmith added a comment to D11833: s/NDEBUG/LLVM_NDEBUG/ in most places.

OK but these NDEBUG aren't necessarily harmful, are they?

IIRC we added LLVM_ENABLE_ABI_BREAKING_CHECKS to cover the cases because previous using NDEBUG in the client was *required* to match the settings at the time LLVM was built.

Nov 13 2019, 1:56 PM

Nov 12 2019

dexonsmith requested changes to D69841: Target Ivy bridge on macOS Mojave and later.

Hi Dave, thanks for checking in on this, but unfortunately we're not ready for this yet.

Nov 12 2019, 10:37 AM · Restricted Project
dexonsmith committed rG83dcb34b6bf4: clang/Modules: Error if ReadASTBlock does not find the main module (authored by dexonsmith).
clang/Modules: Error if ReadASTBlock does not find the main module
Nov 12 2019, 8:46 AM
dexonsmith closed D70063: clang/Modules: Error if ReadASTBlock does not find the main module.

Committed 83dcb34b6bf4c175040b18d3e8c3c468418009fc. Thanks for the reviews!

Nov 12 2019, 8:46 AM

Nov 11 2019

dexonsmith added inline comments to D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 11 2019, 5:59 PM
dexonsmith committed rGc46b3a2abd38: clang/Modules: Clean up modules on error in ReadAST (authored by dexonsmith).
clang/Modules: Clean up modules on error in ReadAST
Nov 11 2019, 4:55 PM
dexonsmith added a comment to D69959: [C-index] Fix test when using Debug target & MSVC STL.
In D69959#1741456, @rnk wrote:

What do you think of making FrontendOptions::Inputs be a SmallVector<*, 0>? It's janky and inconsistent with the rest of that struct, but it seems less invasive in the end.

Nov 11 2019, 4:55 PM · Restricted Project, Restricted Project
dexonsmith closed D70055: clang/Modules: Clean up modules on error in ReadAST.

Committed c46b3a2abd38d6fecd389c97dfa7df54af77fdb9.

Nov 11 2019, 4:55 PM
dexonsmith committed rG8e2c192e2af8: clang/Modules: Add missing diagnostics for malformed AST files (authored by dexonsmith).
clang/Modules: Add missing diagnostics for malformed AST files
Nov 11 2019, 4:09 PM
dexonsmith closed D70057: clang/Modules: Add missing diagnostics for malformed AST files.

Committed 8e2c192e2af8c760152ba3b28e774dbb1548e4aa.

Nov 11 2019, 4:09 PM
dexonsmith committed rG01782c3e4df1: clang/Modules: Split loop in ReadAST between failable and not (authored by dexonsmith).
clang/Modules: Split loop in ReadAST between failable and not
Nov 11 2019, 4:00 PM
dexonsmith committed rGbfd58fc60ff4: clang/Modules: Use range-based for in ASTReader::ReadAST, NFC (authored by dexonsmith).
clang/Modules: Use range-based for in ASTReader::ReadAST, NFC
Nov 11 2019, 4:00 PM
dexonsmith closed D70056: clang/Modules: Split loop in ReadAST between failable and not.

Committed in bfd58fc60ff4b0c081b5b489119c3798d3e2b53c and 01782c3e4df1830d7991e9edfee9119ed41e4c27.

Nov 11 2019, 4:00 PM
dexonsmith committed rGeef690216079: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight (authored by dexonsmith).
clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight
Nov 11 2019, 3:50 PM
dexonsmith closed D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight.

Committed as eef69021607950487a9e4110851a05abb54d0fb6.

Nov 11 2019, 3:50 PM
dexonsmith added inline comments to D70056: clang/Modules: Split loop in ReadAST between failable and not.
Nov 11 2019, 2:47 PM
dexonsmith closed D48518: ADT: Shrink SmallVector by 8B on 64-bit platforms.

Looks like I forgot to close when recommitting in r337514.

Nov 11 2019, 1:43 PM · Restricted Project

Nov 10 2019

dexonsmith updated the diff for D70063: clang/Modules: Error if ReadASTBlock does not find the main module.

Updated to use a new diagnostic (err_module_file_missing_definition) that includes the filename of the PCM.

Nov 10 2019, 1:44 PM
dexonsmith added a child revision for D70056: clang/Modules: Split loop in ReadAST between failable and not: D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 10 2019, 1:41 PM
dexonsmith added a child revision for D70055: clang/Modules: Clean up modules on error in ReadAST: D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 10 2019, 1:41 PM
dexonsmith added parent revisions for D70063: clang/Modules: Error if ReadASTBlock does not find the main module: D70055: clang/Modules: Clean up modules on error in ReadAST, D70056: clang/Modules: Split loop in ReadAST between failable and not, D70057: clang/Modules: Add missing diagnostics for malformed AST files, D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight.
Nov 10 2019, 1:41 PM
dexonsmith added a child revision for D70057: clang/Modules: Add missing diagnostics for malformed AST files: D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 10 2019, 1:41 PM
dexonsmith created D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 10 2019, 1:41 PM
dexonsmith added a child revision for D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight: D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 10 2019, 1:41 PM
dexonsmith updated the diff for D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight.

Updated header docs for the new delayed diagnostic parameter.

Nov 10 2019, 12:02 PM
dexonsmith created D70058: clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight.
Nov 10 2019, 11:44 AM
dexonsmith created D70057: clang/Modules: Add missing diagnostics for malformed AST files.
Nov 10 2019, 11:44 AM
dexonsmith created D70056: clang/Modules: Split loop in ReadAST between failable and not.
Nov 10 2019, 11:44 AM
dexonsmith created D70055: clang/Modules: Clean up modules on error in ReadAST.
Nov 10 2019, 11:44 AM