Page MenuHomePhabricator
People kerbowa

kerbowa (Austin Kerbow)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 31 2018, 12:07 PM (65 w, 5 d)

Recent Activity
View All

Thu, Apr 2

kerbowa committed rG30f18ed387c1: [AMDGPU] Handle SMRD signed offset immediate (authored by kerbowa).
[AMDGPU] Handle SMRD signed offset immediate
Thu, Apr 2, 5:55 PM
kerbowa closed D77082: [AMDGPU] Handle SMRD signed offset immediate.
Thu, Apr 2, 5:55 PM · Restricted Project
kerbowa updated the diff for D77082: [AMDGPU] Handle SMRD signed offset immediate.

Directly check the immediate value.

Thu, Apr 2, 3:11 PM · Restricted Project

Wed, Apr 1

kerbowa added inline comments to D77082: [AMDGPU] Handle SMRD signed offset immediate.
Wed, Apr 1, 10:26 AM · Restricted Project
kerbowa updated the diff for D77082: [AMDGPU] Handle SMRD signed offset immediate.

Address comments.

Wed, Apr 1, 1:36 AM · Restricted Project

Mon, Mar 30

kerbowa added inline comments to D77082: [AMDGPU] Handle SMRD signed offset immediate.
Mon, Mar 30, 3:51 PM · Restricted Project
kerbowa updated the diff for D77082: [AMDGPU] Handle SMRD signed offset immediate.

Rebase.

Mon, Mar 30, 1:37 PM · Restricted Project
kerbowa created D77082: [AMDGPU] Handle SMRD signed offset immediate.
Mon, Mar 30, 12:30 PM · Restricted Project

Sun, Mar 29

kerbowa accepted D76555: AMDGPU/GlobalISel: Hack to fix i24 argument lowering.
Sun, Mar 29, 10:29 PM
kerbowa accepted D76180: AMDGPU/GlobalISel: Legalize 64-bit G_UDIV/G_UREM.

LGTM

Sun, Mar 29, 10:29 PM

Fri, Mar 20

kerbowa committed rG2cbb8c946a6e: [AMDGPU] Reuse register during frame index elimination (authored by kerbowa).
[AMDGPU] Reuse register during frame index elimination
Fri, Mar 20, 12:31 AM
kerbowa closed D76387: [AMDGPU] Reuse register during frame index elimination.
Fri, Mar 20, 12:31 AM · Restricted Project

Thu, Mar 19

kerbowa updated the diff for D76387: [AMDGPU] Reuse register during frame index elimination.

Rebase tests.

Thu, Mar 19, 12:30 AM · Restricted Project

Wed, Mar 18

kerbowa added inline comments to D76387: [AMDGPU] Reuse register during frame index elimination.
Wed, Mar 18, 8:04 PM · Restricted Project
kerbowa retitled D76387: [AMDGPU] Reuse register during frame index elimination from [AMDGPU] Resue register during frame index elimination to [AMDGPU] Reuse register during frame index elimination.
Wed, Mar 18, 8:04 PM · Restricted Project
kerbowa updated the diff for D76387: [AMDGPU] Reuse register during frame index elimination.

Address review comments.

Wed, Mar 18, 8:04 PM · Restricted Project
kerbowa created D76387: [AMDGPU] Reuse register during frame index elimination.
Wed, Mar 18, 2:40 PM · Restricted Project

Sun, Mar 15

kerbowa accepted D75088: AMDGPU/GlobalISel: Fix some illegal scalar argument types.

LGTM

Sun, Mar 15, 10:18 PM · Restricted Project
kerbowa accepted D74928: AMDGPU/GlobalISel: Fix handling of G_ANYEXT with s1 source.

LG

Sun, Mar 15, 10:18 PM · Restricted Project

Mon, Mar 9

kerbowa accepted D75078: AMDGPU/GlobalISel: Improve handling of illegal return types.

LGTM

Mon, Mar 9, 1:02 AM · Restricted Project
kerbowa accepted D75076: AMDGPU: Make signext/zeroext behave more sensibly over > i32.

LGTM

Mon, Mar 9, 12:30 AM · Restricted Project

Mar 4 2020

kerbowa accepted D75155: AMDGPU/GlobalISel: Don't use vector G_EXTRACT in arg lowering.

This LGTM if Jay does not object.

Mar 4 2020, 12:21 PM · Restricted Project

Mar 3 2020

kerbowa created D75547: [AMDGPU][GlobalISel] Revise handling of wide loads in RegBankSelect.
Mar 3 2020, 10:56 AM · Restricted Project

Feb 28 2020

kerbowa committed rG4fa63fd4524c: [VectorCombine] Fix assert on compare extract index (authored by kerbowa).
[VectorCombine] Fix assert on compare extract index
Feb 28 2020, 10:42 AM
kerbowa closed D75327: [VectorCombine] Fix assert on compare extract index.
Feb 28 2020, 10:42 AM · Restricted Project
kerbowa updated the diff for D75327: [VectorCombine] Fix assert on compare extract index.

Add test.

Feb 28 2020, 9:38 AM · Restricted Project
kerbowa updated the summary of D75030: [AMDGPU] Use conservative defaults for XNACK/SRAM ECC.
Feb 28 2020, 7:17 AM · Restricted Project

Feb 27 2020

kerbowa created D75327: [VectorCombine] Fix assert on compare extract index.
Feb 27 2020, 8:52 PM · Restricted Project
kerbowa accepted D74854: AMDGPU/GlobalISel: Fix mishandling SGPR v2s16 add/sub/mul.

LGTM

Feb 27 2020, 2:51 PM · Restricted Project
kerbowa committed rG5078c0e9af93: HCC: Revert 'always produce one-as syncscopes' (authored by kerbowa).
HCC: Revert 'always produce one-as syncscopes'
Feb 27 2020, 1:14 AM

Feb 24 2020

kerbowa accepted D74849: AMDGPU/GlobalISel: Fix incorrect VOP3P fneg folding.

LGTM

Feb 24 2020, 11:25 AM · Restricted Project

Feb 23 2020

kerbowa created D75030: [AMDGPU] Use conservative defaults for XNACK/SRAM ECC.
Feb 23 2020, 11:12 PM · Restricted Project
kerbowa accepted D74728: AMDGPU/GlobalISel: Introduce post-legalize combiner.

LGTM

Feb 23 2020, 9:39 PM · Restricted Project

Feb 21 2020

kerbowa accepted D74710: AMDGPU/GlobalISel: Manually select G_BUILD_VECTOR_TRUNC.

LGTM

Feb 21 2020, 12:14 AM · Restricted Project

Feb 18 2020

kerbowa accepted D74752: AMDGPU/GlobalISel: Select VOP3P instructions.

LGTM

Feb 18 2020, 2:14 AM · Restricted Project
kerbowa accepted D74717: AMDGPU/GlobalISel: Adjust branch target when lowering loop intrinsic.

LGTM

Feb 18 2020, 2:05 AM · Restricted Project
kerbowa added inline comments to D74710: AMDGPU/GlobalISel: Manually select G_BUILD_VECTOR_TRUNC.
Feb 18 2020, 1:56 AM · Restricted Project

Feb 17 2020

kerbowa accepted D71855: AMDGPU/GlobalISel: Skip DAG hack passes on selected functions.

LGTM

Feb 17 2020, 8:32 AM · Restricted Project

Feb 15 2020

kerbowa accepted D74319: AMDGPU/GlobalISel: Run the localizer pass.

LGTM

Feb 15 2020, 12:27 PM · Restricted Project
kerbowa accepted D74272: AMDGPU/GlobalISel: Select llvm.amdgcn.s.buffer.load.

LGTM

Feb 15 2020, 11:29 AM · Restricted Project

Feb 14 2020

kerbowa accepted D74271: AMDGPU/GlobalISel: Fix G_EXTRACT of 96-bit results.

LGTM. Just ran into the same issue.

Feb 14 2020, 2:20 PM · Restricted Project
kerbowa added a comment to D74630: [AMDGPU] Always enable XNACK feature when support is explicitly requested.
In D74630#1876974, @arsenm wrote:

Has no tests and also doesn't fix the set of targets that really support xnack

Feb 14 2020, 12:30 PM · Restricted Project
kerbowa committed rG07824e65bf56: [AMDGPU] Always enable XNACK feature when support is explicitly requested (authored by kerbowa).
[AMDGPU] Always enable XNACK feature when support is explicitly requested
Feb 14 2020, 12:03 PM
kerbowa closed D74630: [AMDGPU] Always enable XNACK feature when support is explicitly requested.
Feb 14 2020, 12:03 PM · Restricted Project
kerbowa created D74630: [AMDGPU] Always enable XNACK feature when support is explicitly requested.
Feb 14 2020, 9:36 AM · Restricted Project

Feb 12 2020

kerbowa updated subscribers of D74524: [Scheduling] Improve memory ops cluster preparation.
Feb 12 2020, 10:22 PM · Restricted Project
kerbowa committed rG5db0b2521c0e: [AMDGPU][GlobalISel] Handle 64byte EltSIze in getRegSplitParts (authored by kerbowa).
[AMDGPU][GlobalISel] Handle 64byte EltSIze in getRegSplitParts
Feb 12 2020, 7:14 PM
kerbowa closed D74518: [AMDGPU][GlobalISel] Handle 64byte EltSIze in getRegSplitParts.
Feb 12 2020, 7:14 PM · Restricted Project
kerbowa created D74518: [AMDGPU][GlobalISel] Handle 64byte EltSIze in getRegSplitParts.
Feb 12 2020, 5:34 PM · Restricted Project
kerbowa accepted D74237: AMDGPU/GlobalISel: Select G_CTTZ_ZERO_UNDEF.

LGTM

Feb 12 2020, 3:18 PM · Restricted Project
kerbowa accepted D74236: AMDGPU/GlobalISel: Select G_CTLZ_ZERO_UNDEF.

LGTM

Feb 12 2020, 3:18 PM · Restricted Project
kerbowa accepted D74182: AMDGPU/GlobalISel: Fix mapping G_ICMP with constrained result.

LGTM

Feb 12 2020, 3:09 PM · Restricted Project

Feb 11 2020

kerbowa committed rG3a312c3ee5f9: [AMDGPU][GlobalISel] Refactor selectDS1Addr1Offset/selectDS64Bit4ByteAligned (authored by kerbowa).
[AMDGPU][GlobalISel] Refactor selectDS1Addr1Offset/selectDS64Bit4ByteAligned
Feb 11 2020, 5:05 PM
kerbowa closed D74261: [AMDGPU][GlobalISel] Refactor selectDS1Addr1Offset/selectDS64Bit4ByteAligned.
Feb 11 2020, 5:05 PM · Restricted Project

Feb 10 2020

kerbowa added a comment to D74261: [AMDGPU][GlobalISel] Refactor selectDS1Addr1Offset/selectDS64Bit4ByteAligned.

This does actually surprising has a functional impact since getPtrBaseWithConstantOffset has "LookThrough" and isBaseWithConstantOffset does not.

Feb 10 2020, 11:13 PM · Restricted Project
kerbowa updated the diff for D74261: [AMDGPU][GlobalISel] Refactor selectDS1Addr1Offset/selectDS64Bit4ByteAligned.

Update tests.

Feb 10 2020, 11:13 PM · Restricted Project

Feb 9 2020

kerbowa accepted D74170: AMDGPU/GlobalISel: Don't mis-select vector index on a constant.

LGTM

Feb 9 2020, 2:54 PM · Restricted Project

Feb 8 2020

kerbowa added inline comments to D74170: AMDGPU/GlobalISel: Don't mis-select vector index on a constant.
Feb 8 2020, 11:01 PM · Restricted Project
kerbowa accepted D74167: AMDGPU/GlobalISel: Look through casts when legalizing vector indexing.

LGTM

Feb 8 2020, 10:52 PM · Restricted Project

Feb 7 2020

kerbowa created D74261: [AMDGPU][GlobalISel] Refactor selectDS1Addr1Offset/selectDS64Bit4ByteAligned.
Feb 7 2020, 3:47 PM · Restricted Project

Feb 6 2020

kerbowa accepted D73879: AMDGPU/GlobalISel: Avoid handling registers twice in waterfall loops.

LGTM

Feb 6 2020, 1:14 AM · Restricted Project

Feb 4 2020

kerbowa committed rG0f116fd9d86d: [AMDGPU] Fix infinite loop with fma combines (authored by kerbowa).
[AMDGPU] Fix infinite loop with fma combines
Feb 4 2020, 1:19 PM
kerbowa closed D73939: [AMDGPU] Fix infinite loop with fma combines.
Feb 4 2020, 1:19 PM · Restricted Project
kerbowa accepted D73393: AMDGPU/GlobalISel: Legalize G_SEXT_INREG.

LGTM

Feb 4 2020, 12:23 PM · Restricted Project
kerbowa added inline comments to D73939: [AMDGPU] Fix infinite loop with fma combines.
Feb 4 2020, 12:03 PM · Restricted Project
kerbowa updated the diff for D73939: [AMDGPU] Fix infinite loop with fma combines.

Handle fmad.

Feb 4 2020, 11:44 AM · Restricted Project
kerbowa added inline comments to D73939: [AMDGPU] Fix infinite loop with fma combines.
Feb 4 2020, 11:08 AM · Restricted Project

Feb 3 2020

kerbowa accepted D73414: AMDGPU/GlobalISel: Do a better job splitting 64-bit G_SEXT_INREG.

LGTM

Feb 3 2020, 9:16 PM · Restricted Project
kerbowa accepted D73396: AMDGPU/GlobalISel: Select G_SEXT_INREG.

LGTM

Feb 3 2020, 8:51 PM · Restricted Project
kerbowa added inline comments to D73939: [AMDGPU] Fix infinite loop with fma combines.
Feb 3 2020, 6:50 PM · Restricted Project
kerbowa created D73939: [AMDGPU] Fix infinite loop with fma combines.
Feb 3 2020, 5:46 PM · Restricted Project

Feb 2 2020

kerbowa accepted D73352: AMDGPU/GlobalISel: Legalize f64 G_FFLOOR for SI.

LGTM

Feb 2 2020, 12:42 AM · Restricted Project

Jan 30 2020

kerbowa accepted D73366: AMDGPU/GlobalISel: Select global MUBUF atomicrmw.

LGTM

Jan 30 2020, 11:29 PM · Restricted Project
kerbowa accepted D73287: AMDGPU/GlobalISel: Combine FMIN_LEGACY/FMAX_LEGACY.

Is anything preventing from adding a post legalizer combiner pass then?

Jan 30 2020, 11:11 PM · Restricted Project

Jan 29 2020

kerbowa committed rG2605adb69c6f: [AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment (authored by kerbowa).
[AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment
Jan 29 2020, 10:44 AM
kerbowa closed D73585: [AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment.
Jan 29 2020, 10:44 AM · Restricted Project
kerbowa accepted D73118: AMDGPU/GlobalISel: Use more wide vector load/stores.

LGTM

Jan 29 2020, 10:07 AM · Restricted Project

Jan 28 2020

kerbowa updated the diff for D73585: [AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment.

Use getPtrBaseWithConstantOffset.

Jan 28 2020, 9:07 PM · Restricted Project
kerbowa added inline comments to D73585: [AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment.
Jan 28 2020, 8:54 PM · Restricted Project
kerbowa created D73585: [AMDGPU][GlobalISel] Select 8-byte LDS Ops with 4-byte alignment.
Jan 28 2020, 2:34 PM · Restricted Project

Jan 27 2020

kerbowa accepted D72430: AMDGPU/GlobalISel: Select llvm.amdcn.raw.buffer.load.

LGTM

Jan 27 2020, 8:22 AM · Restricted Project

Jan 26 2020

kerbowa accepted D73321: AMDPGPU/GlobalISel: Select more MUBUF global addressing modes.

LGTM

Jan 26 2020, 10:03 PM · Restricted Project
kerbowa accepted D73241: AMDGPU/GlobalISel: Initial selection of MUBUF addr64 load/store.

LGTM

Jan 26 2020, 9:56 PM · Restricted Project

Jan 25 2020

kerbowa accepted D73386: [AMDGPU] Attempt to reschedule withou clustering.

LGTM

Jan 25 2020, 4:26 PM · Restricted Project

Jan 24 2020

kerbowa added a comment to D73386: [AMDGPU] Attempt to reschedule withou clustering.

This tries scheduling with all mutations disabled including macro fusion right?

Jan 24 2020, 4:09 PM · Restricted Project
kerbowa accepted D73114: AMDGPU/GlobalISel: Improve legalization of wide stores.

LGTM

Jan 24 2020, 11:10 AM · Restricted Project
kerbowa accepted D72922: AMDGPU/GlobalISel: Select wqm, softwqm and wwm intrinsics.

LGTM

Jan 24 2020, 10:44 AM · Restricted Project
kerbowa committed rGc2266463377a: Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI (authored by kerbowa).
Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI
Jan 24 2020, 10:43 AM
kerbowa closed D73315: Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI.
Jan 24 2020, 10:43 AM · Restricted Project
kerbowa committed rG37aa16ebb713: [DA] Don't propagate from unreachable blocks (authored by kerbowa).
[DA] Don't propagate from unreachable blocks
Jan 24 2020, 10:32 AM
kerbowa closed D73323: [DA] Don't propagate from unreachable blocks.
Jan 24 2020, 10:32 AM · Restricted Project

Jan 23 2020

kerbowa added a parent revision for D73315: Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI: D73323: [DA] Don't propagate from unreachable blocks.
Jan 23 2020, 8:00 PM · Restricted Project
kerbowa added a child revision for D73323: [DA] Don't propagate from unreachable blocks: D73315: Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI.
Jan 23 2020, 8:00 PM · Restricted Project
kerbowa created D73323: [DA] Don't propagate from unreachable blocks.
Jan 23 2020, 7:56 PM · Restricted Project
kerbowa added a comment to D73315: Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI.
In D73315#1837692, @rampitec wrote:

What has caused the failure? Will it happen on Windows in real life?

I saw it was about unreachable loop, is that a real problem of the new DA?

Jan 23 2020, 6:58 PM · Restricted Project
kerbowa created D73315: Resubmit: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI.
Jan 23 2020, 5:20 PM · Restricted Project

Jan 21 2020

kerbowa accepted D72702: AMDGPU/GlobalISel: Select buffer atomics.

LGTM

Jan 21 2020, 9:27 PM · Restricted Project
kerbowa accepted D72678: AMDGPU/GlobalISel: Select llvm.amdgcn.struct.buffer.store[.format].

LGTM

Jan 21 2020, 9:27 PM · Restricted Project
kerbowa committed rGa90a6502ab35: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI (authored by kerbowa).
[DA][TTI][AMDGPU] Add option to select GPUDA with TTI
Jan 21 2020, 9:18 PM
kerbowa closed D73049: [DA][TTI][AMDGPU] Add option to select GPUDA with TTI.
Jan 21 2020, 9:18 PM · Restricted Project