Page MenuHomePhabricator

kerbowa (Austin Kerbow)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 31 2018, 12:07 PM (90 w, 4 d)

Recent Activity

Wed, Sep 16

kerbowa added inline comments to D87621: [AMDGPU] Add XDL resource to scheduling model.
Wed, Sep 16, 8:13 PM · Restricted Project

Mon, Sep 14

kerbowa committed rGf859c30ecbbb: [AMDGPU] Add XDL resource to scheduling model (authored by kerbowa).
[AMDGPU] Add XDL resource to scheduling model
Mon, Sep 14, 1:49 PM
kerbowa closed D87621: [AMDGPU] Add XDL resource to scheduling model.
Mon, Sep 14, 1:49 PM · Restricted Project
kerbowa requested review of D87621: [AMDGPU] Add XDL resource to scheduling model.
Mon, Sep 14, 10:58 AM · Restricted Project

Aug 16 2020

kerbowa requested review of D86042: [AMDGPU] Use correct defaults for xnack and sramecc.
Aug 16 2020, 2:21 PM · Restricted Project

Aug 14 2020

kerbowa added inline comments to D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 14 2020, 8:50 AM · Restricted Project

Aug 13 2020

kerbowa updated the summary of D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 13 2020, 10:51 PM · Restricted Project
kerbowa updated the summary of D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 13 2020, 7:24 PM · Restricted Project
kerbowa updated the diff for D85882: [AMDGPU] Update subtarget features for new target ID support.

Rename "Default" to "Any". Address comments.

Aug 13 2020, 7:21 PM · Restricted Project
kerbowa added inline comments to D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 13 2020, 4:21 PM · Restricted Project
kerbowa committed rG7d1cb187fbee: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded (authored by kerbowa).
[AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded
Aug 13 2020, 2:12 PM
kerbowa closed D85772: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded.
Aug 13 2020, 2:12 PM · Restricted Project
kerbowa updated the diff for D85882: [AMDGPU] Update subtarget features for new target ID support.

Re-add DoesNotSupport features. Use enum class. No fatal error on setting mismatch.

Aug 13 2020, 1:53 PM · Restricted Project
kerbowa updated the diff for D85772: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded.

Fix typo.

Aug 13 2020, 11:08 AM · Restricted Project
kerbowa added a reviewer for D85772: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded: hsmhsm.
Aug 13 2020, 10:53 AM · Restricted Project
kerbowa updated the diff for D85772: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded.

As discussed offline with Mahesha, this and https://reviews.llvm.org/D85767 are fixing the same issue, we decided I would take the fix forward.

Aug 13 2020, 10:52 AM · Restricted Project
kerbowa added inline comments to D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 13 2020, 8:39 AM · Restricted Project
kerbowa requested review of D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 13 2020, 12:21 AM · Restricted Project

Aug 11 2020

kerbowa requested review of D85772: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded.
Aug 11 2020, 12:51 PM · Restricted Project

Aug 7 2020

kerbowa committed rG04bd5b528620: [AMDGPU] Fix not rescheduling without clustering (authored by vangthao95).
[AMDGPU] Fix not rescheduling without clustering
Aug 7 2020, 11:18 AM
kerbowa closed D85498: [AMDGPU] Fix not rescheduling without clustering.
Aug 7 2020, 11:17 AM · Restricted Project

Aug 6 2020

kerbowa requested review of D85498: [AMDGPU] Fix not rescheduling without clustering.
Aug 6 2020, 9:09 PM · Restricted Project
kerbowa added a comment to D85456: Fix instruction counting in post-RA scheduler.

Seems wrong to have a bundle without BUNDLE opcode but the change seems fine obviously. Since it's allowed we should probably just account for the possibility.

Aug 6 2020, 2:00 PM · Restricted Project

Aug 5 2020

kerbowa accepted D84163: AMDGPU/GlobalISel: Fix trying to widen <3 x s1> boolean ops.

LGTM

Aug 5 2020, 8:06 PM · Restricted Project
kerbowa accepted D84249: AMDGPU/GlobalISel: Stop using G_EXTRACT in argument lowering.

LGTM

Aug 5 2020, 7:41 PM · Restricted Project

Jul 29 2020

kerbowa accepted D84883: [AMDGPU] prefer non-mfma in post-RA schedule.

LGTM either way

Jul 29 2020, 12:15 PM · Restricted Project
kerbowa added a comment to D84883: [AMDGPU] prefer non-mfma in post-RA schedule.

Actually MFMA would need more height to ensure post-RA tries to schedule them first and together. You could have their results be implicit uses on later instruction like S_ENDPGM or something.

Jul 29 2020, 12:13 PM · Restricted Project
kerbowa added a comment to D84883: [AMDGPU] prefer non-mfma in post-RA schedule.

Minor nit, but test should disable-power-sched otherwise I think MFMA will be scheduled apart anyway.

Jul 29 2020, 12:01 PM · Restricted Project

Jul 28 2020

kerbowa accepted D84198: AMDGPU/GlobalISel: Refactor special argument management.

LGTM

Jul 28 2020, 8:56 PM · Restricted Project
kerbowa committed rGadeeac9d5a32: [AMDGPU] Spill CSR VGPR which is reserved for SGPR spills (authored by kerbowa).
[AMDGPU] Spill CSR VGPR which is reserved for SGPR spills
Jul 28 2020, 11:54 AM
kerbowa closed D83730: [AMDGPU] Spill CSR VGPR which is reserved for SGPR spills.
Jul 28 2020, 11:53 AM · Restricted Project

Jul 26 2020

kerbowa accepted D84203: AMDGPU/GlobalISel: Select llvm.returnaddress.

LGTM

Jul 26 2020, 4:49 PM · Restricted Project

Jul 25 2020

kerbowa added inline comments to D84198: AMDGPU/GlobalISel: Refactor special argument management.
Jul 25 2020, 2:36 PM · Restricted Project
kerbowa accepted D83988: AMDGPU/GlobalISel: Start trying to handle AGPR bank.

LGTM with parent

Jul 25 2020, 2:24 PM · Restricted Project
kerbowa accepted D84164: AMDGPU/GlobalISel: Pack constant G_BUILD_VECTOR_TRUNCs when selecting.

LGTM

Jul 25 2020, 2:05 PM · Restricted Project

Jul 23 2020

kerbowa updated the diff for D83730: [AMDGPU] Spill CSR VGPR which is reserved for SGPR spills.

Create the stack object in lowerShiftReservedVGPR. Also handle this reserved VGPR not being live-in to all BB. Add more tests. Cleanup some of the existing logic.

Jul 23 2020, 11:42 PM · Restricted Project
kerbowa added inline comments to D83730: [AMDGPU] Spill CSR VGPR which is reserved for SGPR spills.
Jul 23 2020, 7:52 PM · Restricted Project
kerbowa accepted D83323: AMDGPU/GlobalISel: Handle call return values.

LGTM

Jul 23 2020, 1:20 AM · Restricted Project

Jul 19 2020

kerbowa accepted D83258: AMDGPU/GlobalISel: Initial Implementation of calls.

LGTM as far as i can tell

Jul 19 2020, 9:09 PM · Restricted Project

Jul 18 2020

kerbowa added inline comments to D83988: AMDGPU/GlobalISel: Start trying to handle AGPR bank.
Jul 18 2020, 8:46 PM · Restricted Project

Jul 15 2020

kerbowa updated the diff for D83730: [AMDGPU] Spill CSR VGPR which is reserved for SGPR spills.

Workaround MIR emitter issue.

Jul 15 2020, 10:45 AM · Restricted Project

Jul 13 2020

Herald added a project to D83730: [AMDGPU] Spill CSR VGPR which is reserved for SGPR spills: Restricted Project.
Jul 13 2020, 4:40 PM · Restricted Project

Jun 30 2020

kerbowa accepted D82463: [AMDGPU] Spill more than wavesize CSR SGPRs.
Jun 30 2020, 10:12 PM · Restricted Project
kerbowa added inline comments to D82463: [AMDGPU] Spill more than wavesize CSR SGPRs.
Jun 30 2020, 5:23 PM · Restricted Project

Jun 29 2020

kerbowa accepted D82463: [AMDGPU] Spill more than wavesize CSR SGPRs.

LGTM

Jun 29 2020, 2:12 PM · Restricted Project

Jun 26 2020

kerbowa added inline comments to D82463: [AMDGPU] Spill more than wavesize CSR SGPRs.
Jun 26 2020, 9:17 AM · Restricted Project

Jun 24 2020

kerbowa accepted D81576: AMDGPU/GlobalISel: Fix some legalization of < dword vector stores.

LGTM

Jun 24 2020, 11:57 PM · Restricted Project
kerbowa added inline comments to D82463: [AMDGPU] Spill more than wavesize CSR SGPRs.
Jun 24 2020, 11:57 PM · Restricted Project
kerbowa added a reviewer for D82463: [AMDGPU] Spill more than wavesize CSR SGPRs: kerbowa.
Jun 24 2020, 11:57 PM · Restricted Project
kerbowa added inline comments to D82463: [AMDGPU] Spill more than wavesize CSR SGPRs.
Jun 24 2020, 11:57 PM · Restricted Project

Jun 14 2020

kerbowa accepted D81523: AMDGPU/GlobalISel: Workaround some load/store type selection patterns.

LGTM

Jun 14 2020, 8:00 AM · Restricted Project
kerbowa added a comment to D81523: AMDGPU/GlobalISel: Workaround some load/store type selection patterns.

When is inst select using the legalizer anyway? Is there some risk of differences in behavior between what's being tested and the default case without the flag?

Jun 14 2020, 1:01 AM · Restricted Project
kerbowa accepted D80561: AMDGPU/GlobalISel: Select general case for G_PTRMASK.

LGTM

Jun 14 2020, 12:29 AM · Restricted Project

Jun 6 2020

kerbowa accepted D80562: AMDGPU/GlobalISel: Start rewriting load/store legality rules.

LGTM

Jun 6 2020, 12:29 AM · Restricted Project

May 26 2020

kerbowa accepted D80314: AMDGPU/GlobalISel: Fix assert on 16-bit G_EXTRACT results.

LGTM

May 26 2020, 9:11 AM · Restricted Project

May 24 2020

kerbowa accepted D80268: AMDGPU/GlobalISel: Don't select boolean phi by default.

LGTM

May 24 2020, 9:51 PM · Restricted Project

May 17 2020

kerbowa accepted D80095: AMDGPU/GlobalISel: Fix splitting wide VALU, non-vector loads.

LGTM

May 17 2020, 6:05 PM · Restricted Project

May 12 2020

kerbowa committed rG9f0b736126cb: [AMDGPU] Add AGPRs to getRegClassForSizeOnBank (authored by kerbowa).
[AMDGPU] Add AGPRs to getRegClassForSizeOnBank
May 12 2020, 10:44 AM
kerbowa closed D79761: [AMDGPU] Add AGPRs to getRegClassForSizeOnBank.
May 12 2020, 10:44 AM · Restricted Project
kerbowa added a comment to D79761: [AMDGPU] Add AGPRs to getRegClassForSizeOnBank.

Seems obviously fine. I assume you have a use for it!

May 12 2020, 10:43 AM · Restricted Project

May 11 2020

kerbowa created D79761: [AMDGPU] Add AGPRs to getRegClassForSizeOnBank.
May 11 2020, 8:32 PM · Restricted Project
kerbowa committed rG1429e4c3992d: [AMDGPU][GlobalISel] Revise handling of wide loads in RegBankSelect (authored by kerbowa).
[AMDGPU][GlobalISel] Revise handling of wide loads in RegBankSelect
May 11 2020, 6:23 PM
kerbowa closed D75547: [AMDGPU][GlobalISel] Revise handling of wide loads in RegBankSelect.
May 11 2020, 6:23 PM · Restricted Project
kerbowa committed rG09253b608a52: [AMDGPU] Allow spilling FP to memory (authored by kerbowa).
[AMDGPU] Allow spilling FP to memory
May 11 2020, 4:46 PM
kerbowa closed D79610: [AMDGPU] Allow spilling FP to memory.
May 11 2020, 4:46 PM · Restricted Project

May 8 2020

kerbowa updated the diff for D79610: [AMDGPU] Allow spilling FP to memory.

Infer spill type with stack ID.

May 8 2020, 11:14 AM · Restricted Project

May 7 2020

kerbowa created D79610: [AMDGPU] Allow spilling FP to memory.
May 7 2020, 5:23 PM · Restricted Project
kerbowa added inline comments to D70379: [AMDGPU] Reserving VGPR for future SGPR Spill.
May 7 2020, 11:55 AM · Restricted Project, Restricted Project

May 5 2020

kerbowa abandoned D79213: [hip] Add noalias on restrict qualified coerced hip pointers.
May 5 2020, 1:30 PM · Restricted Project

May 4 2020

kerbowa added a comment to D79213: [hip] Add noalias on restrict qualified coerced hip pointers.

Any more comments? As this should be a performance-critical issue, shall we get conclusion and make progress for the next step?

May 4 2020, 3:05 PM · Restricted Project

May 3 2020

kerbowa updated the diff for D75547: [AMDGPU][GlobalISel] Revise handling of wide loads in RegBankSelect.

Don't report breakdown for wide load results.

May 3 2020, 7:06 PM · Restricted Project

Apr 30 2020

kerbowa added inline comments to D79213: [hip] Add noalias on restrict qualified coerced hip pointers.
Apr 30 2020, 6:35 PM · Restricted Project
kerbowa added inline comments to D79213: [hip] Add noalias on restrict qualified coerced hip pointers.
Apr 30 2020, 5:38 PM · Restricted Project
kerbowa updated the diff for D79213: [hip] Add noalias on restrict qualified coerced hip pointers.

Fix test formatting.

Apr 30 2020, 4:39 PM · Restricted Project
kerbowa created D79213: [hip] Add noalias on restrict qualified coerced hip pointers.
Apr 30 2020, 3:38 PM · Restricted Project

Apr 21 2020

kerbowa added a comment to D78312: [AMDGPU] Add 192-bit register classes.

AMDGPUGenRegisterBankInfo.def probably should be updated as well.

Probably, but it is already missing 160-bit classes. Can we leave it for a separate patch?

Apr 21 2020, 8:04 AM · Restricted Project

Apr 20 2020

kerbowa abandoned D78003: [AMDGPU] Fix llvm.amdgcn.div.scale lowering.
Apr 20 2020, 8:37 AM · Restricted Project

Apr 18 2020

kerbowa added a comment to D78312: [AMDGPU] Add 192-bit register classes.

AMDGPUGenRegisterBankInfo.def probably should be updated as well.

Apr 18 2020, 10:45 AM · Restricted Project

Apr 13 2020

kerbowa committed rGa69b3e010c6f: [AMDGPU][GlobalISel] Fix div_scale in FDIV lowering (authored by kerbowa).
[AMDGPU][GlobalISel] Fix div_scale in FDIV lowering
Apr 13 2020, 4:20 PM
kerbowa closed D78004: [AMDGPU][GlobalISel] Fix div_scale in FDIV lowering.
Apr 13 2020, 4:20 PM · Restricted Project
kerbowa accepted D77020: AMDGPU/GlobalISel: Combines for V_CVT_F32_UBYTE[0-3].
Apr 13 2020, 3:20 PM
kerbowa updated the diff for D78004: [AMDGPU][GlobalISel] Fix div_scale in FDIV lowering.

Update to current div_scale intrinsic behavior.

Apr 13 2020, 12:59 PM · Restricted Project
kerbowa committed rGcc4d7dced9fa: [AMDGPU] Fix comment for llvm.amdgcn.div.scale. NFC. (authored by kerbowa).
[AMDGPU] Fix comment for llvm.amdgcn.div.scale. NFC.
Apr 13 2020, 12:27 PM
kerbowa added inline comments to D78003: [AMDGPU] Fix llvm.amdgcn.div.scale lowering.
Apr 13 2020, 11:52 AM · Restricted Project
kerbowa added inline comments to D78003: [AMDGPU] Fix llvm.amdgcn.div.scale lowering.
Apr 13 2020, 8:02 AM · Restricted Project
kerbowa updated the diff for D78003: [AMDGPU] Fix llvm.amdgcn.div.scale lowering.

Use isNull.

Apr 13 2020, 8:01 AM · Restricted Project

Apr 12 2020

kerbowa created D78004: [AMDGPU][GlobalISel] Fix div_scale in FDIV lowering.
Apr 12 2020, 11:57 PM · Restricted Project
kerbowa created D78003: [AMDGPU] Fix llvm.amdgcn.div.scale lowering.
Apr 12 2020, 11:25 PM · Restricted Project
kerbowa committed rGeab9a4f1192a: [AMDGPU] Don't assert on partial exec copy (authored by kerbowa).
[AMDGPU] Don't assert on partial exec copy
Apr 12 2020, 9:23 PM
kerbowa closed D77992: [AMDGPU] Don't assert on partial exec copy.
Apr 12 2020, 9:23 PM · Restricted Project
kerbowa created D77992: [AMDGPU] Don't assert on partial exec copy.
Apr 12 2020, 8:50 PM · Restricted Project

Apr 11 2020

kerbowa added inline comments to D40578: AMDGPU: Make hazard recognizer aware of maximum clause sizes.
Apr 11 2020, 11:57 PM

Apr 9 2020

kerbowa added inline comments to D77547: AMDGPU/GlobalISel: Select llvm.amdgcn.div.scale.
Apr 9 2020, 3:13 AM

Apr 6 2020

kerbowa accepted D77547: AMDGPU/GlobalISel: Select llvm.amdgcn.div.scale.

LGTM
I had this implemented as well, but was trying to get the SD tests to pass first.

Apr 6 2020, 8:38 AM
kerbowa accepted D77518: AMDGPU/GlobalISel: Fix llvm.amdgcn.div.fmas.ll.

LGTM

Apr 6 2020, 8:38 AM

Apr 5 2020

kerbowa accepted D77517: AMDGPU: Use DAG patterns for div_fmas.

LGTM

Apr 5 2020, 11:25 PM

Apr 2 2020

kerbowa committed rG30f18ed387c1: [AMDGPU] Handle SMRD signed offset immediate (authored by kerbowa).
[AMDGPU] Handle SMRD signed offset immediate
Apr 2 2020, 5:55 PM
kerbowa closed D77082: [AMDGPU] Handle SMRD signed offset immediate.
Apr 2 2020, 5:55 PM · Restricted Project
kerbowa updated the diff for D77082: [AMDGPU] Handle SMRD signed offset immediate.

Directly check the immediate value.

Apr 2 2020, 3:11 PM · Restricted Project

Apr 1 2020

kerbowa added inline comments to D77082: [AMDGPU] Handle SMRD signed offset immediate.
Apr 1 2020, 10:26 AM · Restricted Project