Page MenuHomePhabricator

kerbowa (Austin Kerbow)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 31 2018, 12:07 PM (41 w, 1 d)

Recent Activity

Today

kerbowa committed rG527e9f9a3f93: AMDGPU: Fix infinite searches in SIFixSGPRCopies (authored by kerbowa).
AMDGPU: Fix infinite searches in SIFixSGPRCopies
Tue, Oct 15, 1:01 PM
kerbowa committed rL374944: AMDGPU: Fix infinite searches in SIFixSGPRCopies.
AMDGPU: Fix infinite searches in SIFixSGPRCopies
Tue, Oct 15, 1:00 PM
kerbowa closed D68970: AMDGPU: Fix infinite searches in SIFixSGPRCopies.
Tue, Oct 15, 1:00 PM · Restricted Project
kerbowa added inline comments to D68970: AMDGPU: Fix infinite searches in SIFixSGPRCopies.
Tue, Oct 15, 12:50 PM · Restricted Project
kerbowa updated the diff for D68970: AMDGPU: Fix infinite searches in SIFixSGPRCopies.

Cleanup test.

Tue, Oct 15, 11:08 AM · Restricted Project
kerbowa updated the diff for D68970: AMDGPU: Fix infinite searches in SIFixSGPRCopies.

Incorporate reviewer comments.

Tue, Oct 15, 11:08 AM · Restricted Project
kerbowa created D68970: AMDGPU: Fix infinite searches in SIFixSGPRCopies.
Tue, Oct 15, 12:11 AM · Restricted Project

Fri, Oct 11

kerbowa accepted D68895: AMDGPU: Erase redundant redefs of m0 in SIFoldOperands.

LGTM

Fri, Oct 11, 9:07 PM

Tue, Oct 8

kerbowa added inline comments to rL371671: AMDGPU: Move m0 initializations earlier.
Tue, Oct 8, 3:28 PM

Mon, Oct 7

kerbowa added inline comments to rL371671: AMDGPU: Move m0 initializations earlier.
Mon, Oct 7, 10:16 PM
kerbowa accepted D68540: AMDGPU/GlobalISel: Handle more G_INSERT cases.

LGTM

Mon, Oct 7, 11:45 AM
kerbowa accepted D68437: AMDGPU/GlobalISel: Use S_MOV_B64 for inline constants.

LGTM

Mon, Oct 7, 11:44 AM

Sun, Oct 6

kerbowa accepted D68416: AMDGPU/GlobalISel: Select more G_INSERT cases.

LGTM

Sun, Oct 6, 11:42 AM
kerbowa accepted D68308: AMDGPU/GlobalISel: Widen 16-bit G_MERGE_VALUEs sources.

LGTM

Sun, Oct 6, 11:40 AM

Mon, Sep 30

kerbowa accepted D67598: AMDGPU/GlobalISel: Select G_UADDO/G_USUBO.

LGTM

Mon, Sep 30, 7:59 AM

Sun, Sep 29

kerbowa accepted D67600: AMDGPU/GlobalISel: Allow scc/vcc alternative mappings for s1 constants.

LGTM

Sun, Sep 29, 9:30 PM
kerbowa accepted D67597: AMDGPU/GlobalISel: Avoid creating shift of 0 in arg lowering.

LGTM

Sun, Sep 29, 9:26 PM

Sep 12 2019

kerbowa committed rGcf321f48be94: AMDGPU: Fix bug in r371671 on some builds. (authored by kerbowa).
AMDGPU: Fix bug in r371671 on some builds.
Sep 12 2019, 12:12 PM
kerbowa committed rL371761: AMDGPU: Fix bug in r371671 on some builds..
AMDGPU: Fix bug in r371671 on some builds.
Sep 12 2019, 12:11 PM
kerbowa accepted D67045: AMDGPU/GlobalISel: Select llvm.amdgcn.raw.buffer.store.format.

LGTM

Sep 12 2019, 9:24 AM

Sep 11 2019

kerbowa committed rG666af6714c81: AMDGPU: Move m0 initializations earlier (authored by kerbowa).
AMDGPU: Move m0 initializations earlier
Sep 11 2019, 2:29 PM
kerbowa committed rL371671: AMDGPU: Move m0 initializations earlier.
AMDGPU: Move m0 initializations earlier
Sep 11 2019, 2:29 PM
kerbowa closed D67450: AMDGPU: Move m0 initializations earlier.
Sep 11 2019, 2:29 PM · Restricted Project
kerbowa updated the diff for D67450: AMDGPU: Move m0 initializations earlier.

Add TRI to reads/definesRegsiter.

Sep 11 2019, 12:48 PM · Restricted Project
kerbowa updated the diff for D67450: AMDGPU: Move m0 initializations earlier.

Fix test.

Sep 11 2019, 8:44 AM · Restricted Project
kerbowa created D67450: AMDGPU: Move m0 initializations earlier.
Sep 11 2019, 8:44 AM · Restricted Project

Sep 10 2019

kerbowa accepted D67355: AMDGPU/GlobalISel: Select G_CTPOP.

LGTM

Sep 10 2019, 9:56 AM
kerbowa accepted D67055: AMDGPU/GlobalISel: Select G_FABS/G_FNEG.

LGTM

Sep 10 2019, 9:50 AM

Sep 9 2019

kerbowa committed rG06c8cb03caee: AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC (authored by kerbowa).
AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC
Sep 9 2019, 4:11 PM
kerbowa committed rL371467: AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC.
AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC
Sep 9 2019, 4:05 PM
kerbowa closed D67374: AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC.
Sep 9 2019, 4:05 PM · Restricted Project
kerbowa created D67374: AMDGPU/GlobalISel: Rename MIRBuilder to B. NFC.
Sep 9 2019, 3:26 PM · Restricted Project
kerbowa accepted D67059: AMDGPU/GlobalISel: Legalize G_BUILD_VECTOR v2s16.

LGTM

Sep 9 2019, 9:39 AM
kerbowa accepted D67050: AMDGPU/GlobalISel: Legalize G_BUILD_VECTOR_TRUNC.

LGTM

Sep 9 2019, 9:07 AM
kerbowa accepted D67042: AMDGPU/GlobalISel: RegBankSelect for G_ZEXTLOAD/G_SEXTLOAD.

LGTM

Sep 9 2019, 8:56 AM
kerbowa accepted D67041: AMDGPU/GlobalISel: Fix RegBankSelect for unaligned, uniform constant loads.

LGTM

Sep 9 2019, 8:45 AM
kerbowa accepted D67040: AMDGPU/GlobalISel: Fix regbankselect for uniform extloads.

LGTM

Sep 9 2019, 8:41 AM
kerbowa accepted D66952: AMDGPU/GlobalISel: Select G_PTR_MASK.

LGTM

Sep 9 2019, 8:39 AM
kerbowa accepted D66386: AMDGPU/GlobalISel: Fix reg bank for uniform LDS loads.

LGTM

Sep 9 2019, 8:18 AM

Sep 3 2019

kerbowa accepted D67062: AMDGPU/GlobalISel: Make 16-bit constants legal.

LGTM

Sep 3 2019, 12:35 PM
kerbowa accepted D67044: AMDGPU/GlobalISel: Avoid repeating 32-bit type lists.

LGTM

Sep 3 2019, 12:03 PM
kerbowa accepted D66957: AMDGPU/GlobalISel: Use known bits for selection.

LGTM

Sep 3 2019, 11:59 AM

Aug 29 2019

kerbowa accepted D66501: AMDGPU/GlobalISel: Legalize sin/cos.

LGTM

Aug 29 2019, 11:17 AM

Aug 5 2019

kerbowa committed rGa05c384132a2: Re-commit: [AMDGPU] Use S_DENORM_MODE for gfx10 (authored by kerbowa).
Re-commit: [AMDGPU] Use S_DENORM_MODE for gfx10
Aug 5 2019, 7:17 PM
kerbowa committed rL367969: Re-commit: [AMDGPU] Use S_DENORM_MODE for gfx10.
Re-commit: [AMDGPU] Use S_DENORM_MODE for gfx10
Aug 5 2019, 7:15 PM
kerbowa added a comment to D65620: [AMDGPU] Use S_DENORM_MODE for gfx10.
In D65620#1615374, @rnk wrote:

I tried changing the test expectations to match 0 instead of 0x0 in rL367907, since both my Windows machine and Linux machine agree on that output. If that doesn't work and there is some platform variance, we can always use regexes to match both.

Aug 5 2019, 12:04 PM · Restricted Project
kerbowa committed rG8d229dbb47d4: [AMDGPU] Use S_DENORM_MODE for gfx10 (authored by kerbowa).
[AMDGPU] Use S_DENORM_MODE for gfx10
Aug 5 2019, 9:11 AM
kerbowa committed rL367882: [AMDGPU] Use S_DENORM_MODE for gfx10.
[AMDGPU] Use S_DENORM_MODE for gfx10
Aug 5 2019, 9:11 AM
kerbowa closed D65620: [AMDGPU] Use S_DENORM_MODE for gfx10.
Aug 5 2019, 9:11 AM · Restricted Project

Aug 4 2019

kerbowa updated the diff for D65620: [AMDGPU] Use S_DENORM_MODE for gfx10.

Switch to timm.

Aug 4 2019, 10:08 AM · Restricted Project

Aug 1 2019

kerbowa updated the diff for D65620: [AMDGPU] Use S_DENORM_MODE for gfx10.

Reorganize.

Aug 1 2019, 9:46 PM · Restricted Project
kerbowa added inline comments to D65620: [AMDGPU] Use S_DENORM_MODE for gfx10.
Aug 1 2019, 5:29 PM · Restricted Project
kerbowa added reviewers for D65620: [AMDGPU] Use S_DENORM_MODE for gfx10: arsenm, rampitec.
Aug 1 2019, 4:39 PM · Restricted Project
kerbowa created D65620: [AMDGPU] Use S_DENORM_MODE for gfx10.
Aug 1 2019, 4:37 PM · Restricted Project

Jul 30 2019

kerbowa committed rGc99f62e3136c: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization. (authored by kerbowa).
[AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization.
Jul 30 2019, 11:53 AM
kerbowa committed rL367344: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..
[AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization.
Jul 30 2019, 11:53 AM
kerbowa closed D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..

r367344

Jul 30 2019, 11:53 AM · Restricted Project

Jul 29 2019

kerbowa updated the diff for D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..

Remove flags from buildIntrinsic.

Jul 29 2019, 5:01 PM · Restricted Project

Jul 22 2019

kerbowa updated the diff for D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..

Add test for propagating flags.

Jul 22 2019, 6:21 PM · Restricted Project
kerbowa added inline comments to D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..
Jul 22 2019, 6:12 PM · Restricted Project
kerbowa updated the diff for D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..

Add flags to everything.

Jul 22 2019, 11:31 AM · Restricted Project

Jul 20 2019

kerbowa updated the diff for D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..

Fixes.

Jul 20 2019, 10:36 AM · Restricted Project
kerbowa updated the diff for D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..

Address comments.

Jul 20 2019, 12:08 AM · Restricted Project

Jul 18 2019

kerbowa created D64966: [AMDGPU/GlobalISel] Add llvm.amdgcn.fdiv.fast legalization..
Jul 18 2019, 5:58 PM · Restricted Project

Jul 15 2019

kerbowa committed rG423b4a18a49c: [AMDGPU] Enable merging m0 initializations. (authored by kerbowa).
[AMDGPU] Enable merging m0 initializations.
Jul 15 2019, 3:08 PM
kerbowa committed rL366135: [AMDGPU] Enable merging m0 initializations..
[AMDGPU] Enable merging m0 initializations.
Jul 15 2019, 3:07 PM
kerbowa closed D64766: [AMDGPU] Enable merging m0 initializations..
Jul 15 2019, 3:07 PM · Restricted Project
kerbowa updated the diff for D64766: [AMDGPU] Enable merging m0 initializations..

Update test.

Jul 15 2019, 2:37 PM · Restricted Project
kerbowa updated the diff for D64766: [AMDGPU] Enable merging m0 initializations..

Fix indent, prolog->prologue, match increment style, remove attributes from test.

Jul 15 2019, 2:29 PM · Restricted Project
kerbowa created D64766: [AMDGPU] Enable merging m0 initializations..
Jul 15 2019, 1:28 PM · Restricted Project

Jul 14 2019

kerbowa added inline comments to D64709: [AMDGPU] fixed scheduler crash in gfx908.
Jul 14 2019, 12:50 PM · Restricted Project
kerbowa added inline comments to D64709: [AMDGPU] fixed scheduler crash in gfx908.
Jul 14 2019, 12:21 PM · Restricted Project

Jul 2 2019

kerbowa added a comment to D64081: AMDGPU: Look through bundles for existing waitcnts.

LGTM but I will wait for Stas.

Jul 2 2019, 10:03 AM
kerbowa added a comment to D64081: AMDGPU: Look through bundles for existing waitcnts.

What about the possibility of inserting waitcnt into bundles?

Jul 2 2019, 9:09 AM

May 7 2019

kerbowa committed rG8a3d3a9af6f0: [AMDGPU] Check MI bundles for hazards (authored by kerbowa).
[AMDGPU] Check MI bundles for hazards
May 7 2019, 3:12 PM
kerbowa committed rL360199: [AMDGPU] Check MI bundles for hazards.
[AMDGPU] Check MI bundles for hazards
May 7 2019, 3:12 PM
kerbowa closed D61564: [AMDGPU] Check MI bundles for hazards.
May 7 2019, 3:12 PM · Restricted Project
kerbowa committed rG6e6480e216b8: [CodeGen] Rename DEBUG_TYPE for default hazard recognizer. (authored by kerbowa).
[CodeGen] Rename DEBUG_TYPE for default hazard recognizer.
May 7 2019, 3:12 PM
kerbowa committed rL360198: [CodeGen] Rename DEBUG_TYPE for default hazard recognizer..
[CodeGen] Rename DEBUG_TYPE for default hazard recognizer.
May 7 2019, 3:06 PM
kerbowa closed D61359: [CodeGen] Rename DEBUG_TYPE for default hazard recognizer..
May 7 2019, 3:06 PM · Restricted Project
kerbowa added a reviewer for D61359: [CodeGen] Rename DEBUG_TYPE for default hazard recognizer.: rampitec.
May 7 2019, 2:53 PM · Restricted Project
kerbowa updated the diff for D61564: [AMDGPU] Check MI bundles for hazards.

Add new test.

May 7 2019, 2:49 PM · Restricted Project
kerbowa added a comment to D61564: [AMDGPU] Check MI bundles for hazards.

For the test itself, could you please add one more. You have test where hazard instruction follows bundle. Can you add the same, where it is in bundle, and another one precedes it? Thanks!

May 7 2019, 2:05 PM · Restricted Project
kerbowa updated the diff for D61564: [AMDGPU] Check MI bundles for hazards.

Add seperate test files.

May 7 2019, 12:03 AM · Restricted Project

May 5 2019

kerbowa added inline comments to D61564: [AMDGPU] Check MI bundles for hazards.
May 5 2019, 1:12 PM · Restricted Project
kerbowa updated the diff for D61564: [AMDGPU] Check MI bundles for hazards.

Add 'fixHazard' checks.

May 5 2019, 1:08 PM · Restricted Project
kerbowa updated the summary of D61564: [AMDGPU] Check MI bundles for hazards.
May 5 2019, 2:11 AM · Restricted Project
kerbowa created D61564: [AMDGPU] Check MI bundles for hazards.
May 5 2019, 1:57 AM · Restricted Project

Apr 30 2019

kerbowa created D61359: [CodeGen] Rename DEBUG_TYPE for default hazard recognizer..
Apr 30 2019, 6:48 PM · Restricted Project

Apr 24 2019

kerbowa committed rG83e52142d115: Fix spelling error. NFC (authored by kerbowa).
Fix spelling error. NFC
Apr 24 2019, 4:32 PM
kerbowa committed rL359154: Fix spelling error. NFC.
Fix spelling error. NFC
Apr 24 2019, 4:32 PM
kerbowa closed D61093: Fix spelling error. NFC.
Apr 24 2019, 4:32 PM · Restricted Project
kerbowa created D61093: Fix spelling error. NFC.
Apr 24 2019, 2:06 PM · Restricted Project