- User Since
- Jun 22 2020, 11:08 PM (100 w, 4 d)
@iains Do you agree to submit this one first? Since all the discussions/questions I see in this page now it not about the patch itself. The patch itself should be good personally I thought.
Thu, May 26
Wed, May 25
We should generate a patch with option -U9999 to offer more context to review.
Tue, May 24
I think I have a preference to move it to CodeGenCXX anyway however, since we're actually testing the code-generated output (this is not novel, we DO often use CodeGen tests to make sure proper overloads/etc get called).
Mon, May 23
Thu, May 19
@rsmith gentle ping~
Wed, May 18
- Lowering the introduced intrinsic in CodeGen pipelines.
Tue, May 17
I think it is better to add some tests at least.
This is not correct. Any change to the AST node requires change to Serialization too.
What's the reason you removed me as a reviewer? I don't think I did any thing bad.
Mon, May 16
Although this one is marked (2/3) in the title, it is independent with the previous revision logically. We could review and submit this one independently.
This one looks like a workaround for me. It tries to skip a CFG check for the operand of return_value to avoid a potential crash. The true solution should be to construct the CFG correctly.
Sun, May 15
Fri, May 13
Remove invalid character
Thu, May 12
Tue, May 10
Run optimization pass in CoroCleanup conditionally.
Now we prefer https://reviews.llvm.org/D125293
Mon, May 9
@rsmith gentle ping~
Thu, May 5
Wed, May 4
Abandon this one since we prefer the proposal from James in https://discourse.llvm.org/t/address-thread-identification-problems-with-coroutine/62015/21
@aeubanks Would you like to review this one? Although we're discussing the solution in https://discourse.llvm.org/t/address-thread-identification-problems-with-coroutine/62015, I think the change in this revision should be a pure win.
Fri, Apr 29
Oh, I'm busy with coroutines these days. Thanks for reminding me for this. LGTM to me basically. Only comments for style left.
Thu, Apr 28
- Don't add filter for OpenMP
- Add readonly and inaccessiblememonly attribute to llvm.coro.may_change intrinsics.
Apr 28 2022
Plan changes due to the previous patch changes its plan too
Emit coro_readnone in CoroEarly pass instead of frontend.
Apr 27 2022
Emit coro_readnone attribute in the frontend.
Emit llvm.coro.maychange in the frontend according to the discussion in https://discourse.llvm.org/t/address-thread-identification-problems-with-coroutine/62015
Apr 26 2022
@iains gentle ping~
Now it looks good to me.
Thanks for the explanation. This fix LGTM.