Page MenuHomePhabricator

jvesely (Jan Vesely)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2014, 5:35 PM (247 w, 6 d)

Recent Activity

May 9 2019

jvesely added a comment to D61616: [NewPassManager] Add tuning option: SLPVectorization [NFC]..

Are you sure this was enabled by default before? (cl::init(true))
I've traced regressions in r600 and amdgcn to this patch.
While both look like backend bugs, the commit message says NFC.

May 9 2019, 11:46 PM · Restricted Project

Mar 27 2019

jvesely committed rG2abbe2f09119: travis: Add LLVM-8 build (authored by jvesely).
travis: Add LLVM-8 build
Mar 27 2019, 2:28 PM
jvesely committed rL357125: travis: Add LLVM-8 build.
travis: Add LLVM-8 build
Mar 27 2019, 2:28 PM

Mar 13 2019

jvesely committed rG4a725996e5f6: sincos: Simplify declaration headers. (authored by jvesely).
sincos: Simplify declaration headers.
Mar 13 2019, 12:15 AM
jvesely committed rGe7c0c37a315a: fdim: Use binary_decl_tt.inc instead of custom inc file. (authored by jvesely).
fdim: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:15 AM
jvesely committed rG5b0600c27758: nextafter: Use binary_decl_tt.inc instead of custom inc file. (authored by jvesely).
nextafter: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:15 AM
jvesely committed rGe438b58cd00e: copysign: Use binary_decl_tt.inc instead of custom inc file. (authored by jvesely).
copysign: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:15 AM
jvesely committed rG81bc9ee81c9a: atan2pi: Use binary_decl_tt.inc instead of custom inc file. (authored by jvesely).
atan2pi: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:14 AM
jvesely committed rG9526e0202189: atan2: Use binary_decl_tt.inc instead of custom inc file. (authored by jvesely).
atan2: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:14 AM
jvesely committed rG8985c9c212c7: hypot: Use binary_decl_tt.inc instead of custom inc file (authored by jvesely).
hypot: Use binary_decl_tt.inc instead of custom inc file
Mar 13 2019, 12:14 AM
jvesely committed rL356028: sincos: Simplify declaration headers..
sincos: Simplify declaration headers.
Mar 13 2019, 12:14 AM
jvesely committed rL356027: fdim: Use binary_decl_tt.inc instead of custom inc file..
fdim: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:14 AM
jvesely committed rL356026: nextafter: Use binary_decl_tt.inc instead of custom inc file..
nextafter: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:14 AM
jvesely committed rL356025: copysign: Use binary_decl_tt.inc instead of custom inc file..
copysign: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:14 AM
jvesely committed rL356024: atan2pi: Use binary_decl_tt.inc instead of custom inc file..
atan2pi: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:13 AM
jvesely committed rL356023: atan2: Use binary_decl_tt.inc instead of custom inc file..
atan2: Use binary_decl_tt.inc instead of custom inc file.
Mar 13 2019, 12:13 AM
jvesely committed rL356022: hypot: Use binary_decl_tt.inc instead of custom inc file.
hypot: Use binary_decl_tt.inc instead of custom inc file
Mar 13 2019, 12:13 AM
jvesely committed rG5b136ca1258b: Move unary_instrinsic.inc to private headers. (authored by jvesely).
Move unary_instrinsic.inc to private headers.
Mar 13 2019, 12:08 AM
jvesely committed rG2aa333f3d116: Move binary_intrinsic.h to private headers. (authored by jvesely).
Move binary_intrinsic.h to private headers.
Mar 13 2019, 12:08 AM
jvesely committed rG1f4a8a915809: Move ternary_intrinsic.h to private headers. (authored by jvesely).
Move ternary_intrinsic.h to private headers.
Mar 13 2019, 12:08 AM
jvesely committed rGee555aa99299: trunc: Remove llvm intrinsic from the header. (authored by jvesely).
trunc: Remove llvm intrinsic from the header.
Mar 13 2019, 12:08 AM
jvesely committed rG1c395b74bf6d: round: Remove llvm intrinsic from the header (authored by jvesely).
round: Remove llvm intrinsic from the header
Mar 13 2019, 12:08 AM
jvesely committed rGb3d64e4a83e0: rint: Remove llvm intrinsic from the header. (authored by jvesely).
rint: Remove llvm intrinsic from the header.
Mar 13 2019, 12:08 AM
jvesely committed rGfd199f013948: floor: Remove llvm isntrinsic from the header. (authored by jvesely).
floor: Remove llvm isntrinsic from the header.
Mar 13 2019, 12:08 AM
jvesely committed rGfda15e56a637: fabs: Remove llvm intrinsic from the header. (authored by jvesely).
fabs: Remove llvm intrinsic from the header.
Mar 13 2019, 12:08 AM
jvesely committed rG54eb4d3a6d86: ceil: Remove llvm intrinsic from the header. (authored by jvesely).
ceil: Remove llvm intrinsic from the header.
Mar 13 2019, 12:07 AM
jvesely committed rG82c6c846af23: sqrt: Split function generation to a shared inc file. (authored by jvesely).
sqrt: Split function generation to a shared inc file.
Mar 13 2019, 12:07 AM
jvesely committed rG4b0b9a727ebb: mad: Convert to standard ternary header (authored by jvesely).
mad: Convert to standard ternary header
Mar 13 2019, 12:07 AM
jvesely committed rL356021: Move unary_instrinsic.inc to private headers..
Move unary_instrinsic.inc to private headers.
Mar 13 2019, 12:07 AM
jvesely committed rL356020: Move binary_intrinsic.h to private headers..
Move binary_intrinsic.h to private headers.
Mar 13 2019, 12:07 AM
jvesely committed rL356019: Move ternary_intrinsic.h to private headers..
Move ternary_intrinsic.h to private headers.
Mar 13 2019, 12:06 AM
jvesely committed rL356018: trunc: Remove llvm intrinsic from the header..
trunc: Remove llvm intrinsic from the header.
Mar 13 2019, 12:06 AM
jvesely committed rL356017: round: Remove llvm intrinsic from the header.
round: Remove llvm intrinsic from the header
Mar 13 2019, 12:06 AM
jvesely committed rL356016: rint: Remove llvm intrinsic from the header..
rint: Remove llvm intrinsic from the header.
Mar 13 2019, 12:06 AM
jvesely committed rL356015: floor: Remove llvm isntrinsic from the header..
floor: Remove llvm isntrinsic from the header.
Mar 13 2019, 12:06 AM
jvesely committed rL356014: fabs: Remove llvm intrinsic from the header..
fabs: Remove llvm intrinsic from the header.
Mar 13 2019, 12:06 AM
jvesely committed rL356013: ceil: Remove llvm intrinsic from the header..
ceil: Remove llvm intrinsic from the header.
Mar 13 2019, 12:06 AM
jvesely committed rL356012: sqrt: Split function generation to a shared inc file..
sqrt: Split function generation to a shared inc file.
Mar 13 2019, 12:06 AM
jvesely committed rL356011: mad: Convert to standard ternary header.
mad: Convert to standard ternary header
Mar 13 2019, 12:06 AM
jvesely committed rG09ebdc03fefb: travis: Deduplicate LLVM_CONFIG variable (authored by jvesely).
travis: Deduplicate LLVM_CONFIG variable
Mar 13 2019, 12:00 AM
jvesely committed rGedcf4d28b3b2: travis: Use gcc-6 for llvm-7 build (authored by jvesely).
travis: Use gcc-6 for llvm-7 build
Mar 13 2019, 12:00 AM
jvesely committed rL356010: travis: Deduplicate LLVM_CONFIG variable.
travis: Deduplicate LLVM_CONFIG variable
Mar 13 2019, 12:00 AM
jvesely committed rL356009: travis: Use gcc-6 for llvm-7 build.
travis: Use gcc-6 for llvm-7 build
Mar 13 2019, 12:00 AM

Jan 14 2019

jvesely added a comment to D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.

I modified some AMDGPU tests to track more registers where possible as @jvesely suggested, and I added some missing new relevant generated instructions (BFE_INT).

Jan 14 2019, 9:21 AM · Restricted Project

Jan 12 2019

jvesely added inline comments to D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.
Jan 12 2019, 3:13 PM · Restricted Project

Jan 8 2019

jvesely updated subscribers of D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors.

sorry for the delay. afaik r600 does not do any special handling wrt to coalescing loads. There is a general load/store vectorizer by @arsenm, so it looks like this patch is interfering with it, but I'd expect the same to happen for GCN as well.
I'm OK with these pessimizations, R600 loads/stores have bigger problems.

Jan 8 2019, 9:12 AM · Restricted Project

Jan 7 2019

jvesely committed rL350565: cmake: Install libraries to DATADIR from GNUInstallDirs.
cmake: Install libraries to DATADIR from GNUInstallDirs
Jan 7 2019, 12:24 PM

Nov 27 2018

jvesely committed rL347668: travis: Add cmake build.
travis: Add cmake build
Nov 27 2018, 8:10 AM
jvesely committed rL347667: Add cmake build system.
Add cmake build system
Nov 27 2018, 8:10 AM
jvesely committed rL347666: r600: Remove empty OVERRIDES file.
r600: Remove empty OVERRIDES file
Nov 27 2018, 8:04 AM
jvesely committed rL347665: amdgcn: Consolidate atomic minmax helpers.
amdgcn: Consolidate atomic minmax helpers
Nov 27 2018, 8:04 AM
jvesely committed rL347664: configure: Add target specific asm rule..
configure: Add target specific asm rule.
Nov 27 2018, 8:04 AM
jvesely committed rL347663: configure: provide llvm_as helper variable.
configure: provide llvm_as helper variable
Nov 27 2018, 8:04 AM

Nov 10 2018

jvesely committed rL346597: r600: Add datalayout to image builtin implementation.
r600: Add datalayout to image builtin implementation
Nov 10 2018, 1:46 PM

Nov 3 2018

jvesely committed rL346086: Remove redundant OVERRRIDES file.
Remove redundant OVERRRIDES file
Nov 3 2018, 5:58 PM
jvesely committed rL346085: configure: Provide symlink for amdgcn-mesa3d instead of configure hack.
configure: Provide symlink for amdgcn-mesa3d instead of configure hack
Nov 3 2018, 5:58 PM
jvesely committed rL346084: travis: Check tahiti-amdgcn-mesa-mesa3d.bc.
travis: Check tahiti-amdgcn-mesa-mesa3d.bc
Nov 3 2018, 5:58 PM
jvesely committed rL346083: amdgcn-amdhsa: Convert get_{global,local}_size to clc for all llvm versions.
amdgcn-amdhsa: Convert get_{global,local}_size to clc for all llvm versions
Nov 3 2018, 5:43 PM
jvesely committed rL346082: amdgcn: Move __clc_amdgcn_s_waitcnt definition to clc file.
amdgcn: Move __clc_amdgcn_s_waitcnt definition to clc file
Nov 3 2018, 5:43 PM
jvesely committed rL346081: amdgcn: Convert get_num_groups to clc.
amdgcn: Convert get_num_groups to clc
Nov 3 2018, 5:43 PM
jvesely committed rL346080: amdgcn: Convert get_global_size to clc.
amdgcn: Convert get_global_size to clc
Nov 3 2018, 5:43 PM
jvesely committed rL346079: amdgcn: Convert get_local_size to clc.
amdgcn: Convert get_local_size to clc
Nov 3 2018, 5:43 PM
jvesely committed rL346078: r600: Convert barrier to clc.
r600: Convert barrier to clc
Nov 3 2018, 5:37 PM
jvesely committed rL346077: r600: Convert get_num_groups to clc.
r600: Convert get_num_groups to clc
Nov 3 2018, 5:37 PM
jvesely committed rL346076: r600: Convert get_global_size to clc.
r600: Convert get_global_size to clc
Nov 3 2018, 5:37 PM
jvesely committed rL346075: r600: Convert get_local_size to clc.
r600: Convert get_local_size to clc
Nov 3 2018, 5:37 PM

Sep 29 2018

jvesely updated subscribers of D52548: Stop instcombining propagating wider shufflevector arguments to predecessors..
Sep 29 2018, 6:53 AM

Sep 15 2018

jvesely committed rL342341: configure: Rework support for gfx9+ devices that were added post LLVM 3.9.
configure: Rework support for gfx9+ devices that were added post LLVM 3.9
Sep 15 2018, 3:03 PM
jvesely committed rL342338: .travis: Add llvm-7 build.
.travis: Add llvm-7 build
Sep 15 2018, 1:03 PM
jvesely committed rL342337: .travis: Use source whitelist alias for llvm-6 repository.
.travis: Use source whitelist alias for llvm-6 repository
Sep 15 2018, 1:03 PM

Aug 21 2018

jvesely accepted D47261: AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space.

v5: rename MAX_COMMON_ADDRESS to MAX_AMDGPU_ADDRESS

Aug 21 2018, 9:46 AM
jvesely added inline comments to D47261: AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space.
Aug 21 2018, 7:39 AM

Aug 20 2018

jvesely added a comment to D47261: AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space.

Please add a reference to llvm bug https://bugs.llvm.org/show_bug.cgi?id=38113
as well as correct "Differential Revision" tag when committing.

Aug 20 2018, 2:12 PM
jvesely added inline comments to D47261: AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space.
Aug 20 2018, 2:08 PM
jvesely added inline comments to D50974: AMDGPU: fix updating the alias rules since r340171.
Aug 20 2018, 8:36 AM
jvesely abandoned D23923: AMDGPU/R600: Use KCache selection in DAGCombiner.

This patch no longer applies

Aug 20 2018, 7:40 AM
jvesely requested changes to D47261: AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space.

NACK. This patch is clearly wrong.
MAX_COMMON_ADDRESS is used in AMDGPUAAResult::ASAliasRulesTy::getAliasResult to filter indices to the ASAliasRules table which is 6x6. Allowing address space 6 leads to out of bounds access to the array.

Aug 20 2018, 6:50 AM

Aug 7 2018

jvesely committed rL339190: AMDGPU: Remove broken i16 ternary patterns.
AMDGPU: Remove broken i16 ternary patterns
Aug 7 2018, 2:55 PM
jvesely closed D49836: AMDGPU: Remove broken ternary i16 patterns.
Aug 7 2018, 2:55 PM
jvesely updated the diff for D49836: AMDGPU: Remove broken ternary i16 patterns.

rename numbered operations

Aug 7 2018, 2:14 PM

Aug 3 2018

jvesely added a comment to D49836: AMDGPU: Remove broken ternary i16 patterns.

ping.
Can we just have the fix in, and worry about optimizing i16 extends later?

Aug 3 2018, 10:48 AM
jvesely committed rL338898: amdgcn: Use __constant AS for amdgcn builtins..
amdgcn: Use __constant AS for amdgcn builtins.
Aug 3 2018, 8:14 AM

Aug 1 2018

jvesely closed D49962: AMDGPU/R600: Convert kernel param loads to use PARAM_I_ADDRESS.

Merged as r338610

Aug 1 2018, 11:45 AM
jvesely committed rL338610: AMDGPU/R600: Convert kernel param loads to use PARAM_I_ADDRESS.
AMDGPU/R600: Convert kernel param loads to use PARAM_I_ADDRESS
Aug 1 2018, 11:36 AM
jvesely added a comment to D49934: AMDGPU: Allow fp32-denormals feaure for r600 targets.

Merged without the test. thanks

Aug 1 2018, 8:06 AM
jvesely committed rL338569: AMDGPU: Allow fp32-denormals feature for r600 targets.
AMDGPU: Allow fp32-denormals feature for r600 targets
Aug 1 2018, 8:05 AM
jvesely closed D49934: AMDGPU: Allow fp32-denormals feaure for r600 targets.
Aug 1 2018, 8:05 AM

Jul 28 2018

jvesely created D49962: AMDGPU/R600: Convert kernel param loads to use PARAM_I_ADDRESS.
Jul 28 2018, 3:46 PM

Jul 27 2018

jvesely abandoned D49649: AMDGPU/R600: Don't set fp32-denormals feature for r600.

D49934

Jul 27 2018, 2:04 PM
jvesely abandoned D49650: Targets/AMDGPU: Don't set fp32-denormals feature for r600.

According to cayman manual, these registers do exist so we should probably just make the feature accepted on r600 as well

sure, that's the way it was before r335942. I assumed the removal was intentional.

Probably accidental because nothing in r600 was actually using it

given the number of warnings it outputs, I find that unlikely.
@tstellar what was your intention? It's not like someone is going to work on EG/CM denormals any time soon.

I don't mind either way. I just want to avoid another round of bikeshedding.

Jul 27 2018, 2:04 PM
jvesely created D49934: AMDGPU: Allow fp32-denormals feaure for r600 targets.
Jul 27 2018, 1:38 PM
jvesely accepted D49907: AMDGPU: Stop trying to exend arguments for clover.

I've been using a version of this locally and it fixes most, but not all tests with char/uchar/short/ushort kernel arguments.
I thought that fixing the hardcoded alignemnt=4 would help, but it's not enough.
It'll need to be handled separately.

Jul 27 2018, 12:14 PM
jvesely committed rL338127: AMDGPU/R600: Add MOV instructions to BFE patterns.
AMDGPU/R600: Add MOV instructions to BFE patterns
Jul 27 2018, 8:00 AM
jvesely closed D49641: AMDGPU/R600: Add MOV instructions to BFE patterns.
Jul 27 2018, 8:00 AM

Jul 26 2018

jvesely added a comment to D49650: Targets/AMDGPU: Don't set fp32-denormals feature for r600.

According to cayman manual, these registers do exist so we should probably just make the feature accepted on r600 as well

sure, that's the way it was before r335942. I assumed the removal was intentional.

Probably accidental because nothing in r600 was actually using it

Jul 26 2018, 1:45 PM
jvesely added inline comments to D49836: AMDGPU: Remove broken ternary i16 patterns.
Jul 26 2018, 12:10 PM
jvesely added inline comments to D49836: AMDGPU: Remove broken ternary i16 patterns.
Jul 26 2018, 10:00 AM

Jul 25 2018

jvesely created D49836: AMDGPU: Remove broken ternary i16 patterns.
Jul 25 2018, 11:55 PM
jvesely added a comment to D49650: Targets/AMDGPU: Don't set fp32-denormals feature for r600.

According to cayman manual, these registers do exist so we should probably just make the feature accepted on r600 as well

Jul 25 2018, 11:10 AM

Jul 23 2018

jvesely abandoned D49642: AMDGPU: Rework extract-lowbits test.

I'd rather stop trying to share tests with r600 at all. I would like to split out most of the shared tests as-i

Any reason for that? Both bfe instructions use the same patterns so it'd be just a copy paste.

A lot of tests have too many run lines as is, and adding more for r600 increases the mess. In this case you are actually changing the tested content. The original used VGPR inputs for everything, and this changes everything to be SGPR inputs. Both would be useful as separate tests, but we don't try particular hard to match scalar BFEs currently. Also, I want to stop artificially sharing some of the intrinsics.

Jul 23 2018, 8:11 PM