User Details
- User Since
- May 29 2018, 3:20 PM (143 w, 4 d)
Wed, Feb 24
Fixed clang-format remarks.
Tue, Feb 23
Jan 28 2021
Jan 27 2021
Jan 26 2021
offloading/dynamic_module_load.c fails due to this commit in my environment with x86_64 offload. It fails because std::call_once cannot be used without libpthread, and libomptarget.rtl.x86_64.so is not linked with libpthread. Basically, gdb shows that include/c++/7.3.0/x86_64-linux-gnu/bits/gthr-default.h::__gthread_active_p() returns false, when std::call_once is called from libomptarget.rtl.x86_64.so. It does return true, though, when std::call_once is called from libomptarget.so, because libomptarget.so is linked with libpthread.
LGTM
Jan 25 2021
Thank you, @ggeorgakoudis !
Jan 24 2021
Hi @ggeorgakoudis, please try something along these lines:
Jan 22 2021
FYI, libomptarget LIT tests fail with profiling enabled in shared-libs builds, because libLLVMSupport.so.12git dependency cannot be resolved. Apparently, LD_LIBRARY_PATH is only set to <build>/llvm/projects/openmp/libomptarget, which obviously does not contain the support library.
Jan 7 2021
Aug 5 2020
Jun 16 2020
Should be working now. Thanks!
FYI, the tests pass with additional changes in lld/MachO/SyntheticSections.cpp.
Thank you! The patch does not build, since some CPP definitions are still using size_t.
Jun 3 2020
May 27 2020
May 26 2020
It does not work on Windows (msbuild) for me, because ${pathlist_escaped} contains paths like %(build_mode)s/bin (caused by set_llvm_build_mode). This seems to break something so that python process does not produce any output at all: I checked both OUTPUT_VARIABLE and ERROR_VARIABLE and they were empty on any invocation of execute_process. @thakis, do you have any ideas what might be wrong?
Feb 27 2020
LGTM
Feb 26 2020
Aug 19 2019
Aug 16 2019
FYI, llvm.global_dtor fix is in https://reviews.llvm.org/D66373
Aug 7 2019
Aug 6 2019
Jul 10 2019
Jul 8 2019
I changed the tests to use FileCheck variables whenever possible.
ping
Jul 1 2019
Adding more reviewers.
Jun 28 2019
ping
Jun 26 2019
May 17 2019
Apr 29 2019
OK, this should work while clang_generate_header() is used for plain files.
Apr 27 2019
Apr 24 2019
Apr 23 2019
Apr 1 2019
Jan 21 2019
ping
Jan 4 2019
Jan 3 2019
I think I got it, finally, after talking with HJ. As defined in https://github.com/hjl-tools/x86-psABI/blob/hjl/master/dl.tex, the pr_data field consists of 4-byte integers for GNU_PROPERTY_X86_FEATURE_1_AND program property type (pr_type). At the same time, the program property array must be a multiple of 8 bytes on x86-64 (as stated in https://github.com/hjl-tools/linux-abi/blob/hjl/master/object-files.tex), thus, the alignment is computed properly.
Jan 2 2019
Please submit your patch with full context according to LLVM's documentation: https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Dec 28 2018
Dec 27 2018
Nov 27 2018
Nov 26 2018
The incremenetal fix.