User Details
- User Since
- May 29 2018, 3:20 PM (252 w, 3 d)
Thu, Mar 30
LGTM
LGTM. It looks like D147237 was not pulled into the testing.
LGTM
Wed, Mar 29
Tue, Mar 28
Mon, Mar 27
Tue, Mar 21
Mon, Mar 20
LGTM
Please address @awarzynski's comment about the test.
Thank you for the update!
Fri, Mar 17
Yes, I think the option to control ctlz conversion will do. The default is up to you.
Hi @j2kun, welcome to MLIR code base :)
Thank you for working on this!
Thu, Mar 16
Thank you for the update!
Wed, Mar 15
Tue, Mar 14
Got rid of FLANG_BUILD_EXAMPLES in favor of LLVM_BUILD_EXAMPLES.
Mon, Mar 13
FYI, "Invalid shuffle vector instruction operands!" assertion kicks in with both first and second commits: https://github.com/llvm/llvm-project/issues/61395
I wonder whether intermediate computations generated by ComplexToStandard conversion complex::DivOp honor the range of the element's data type. Maybe we can think of replacing the FIR operation with the one from the Complex dialect?
Sun, Mar 12
Wed, Mar 8
Thanks!
Tue, Mar 7
One minor thing, otherwise, looks good.
Mon, Mar 6
LGTM
Mar 1 2023
LGTM
Thanks!
Thanks!
Feb 27 2023
Feb 23 2023
LGTM
Feb 21 2023
The new tests fail to link:
flang-new: warning: The warning option '-Wextra' is not supported /usr/bin/ld: cannot find -lFortran_main /usr/bin/ld: cannot find -lFortranRuntime /usr/bin/ld: cannot find -lFortranDecimal
Thank you for the review, Pete!
FYI, Flang Intrinsics/math-codegen failure should be resolved by D144523
Feb 17 2023
LGTM
Feb 15 2023
Feb 13 2023
LGTM
Thanks!
Feb 10 2023
Feb 9 2023
Thank you, @gysit! LGTM
FYI, the build is failing due to missing dependency: https://lab.llvm.org/buildbot/#/builders/181/builds/14278
I will merge the fix shortly.
Thank you!
Feb 8 2023
Thank you!
Feb 7 2023
Feb 6 2023
Feb 3 2023
Feb 1 2023
Jan 30 2023
LGTM. Thanks!
Fixes the test to work with D142548