Page MenuHomePhabricator

vzakhari (Vyacheslav Zakharin)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 3:20 PM (143 w, 4 d)

Recent Activity

Wed, Feb 24

vzakhari committed rG6baeeb9efa8e: [libomptarget] Fixed MSVC build fail caused by __attribute__((used)). (authored by vzakhari).
[libomptarget] Fixed MSVC build fail caused by __attribute__((used)).
Wed, Feb 24, 10:00 AM
vzakhari closed D97348: [libomptarget] Fixed MSVC build fail caused by __attribute__((used))..
Wed, Feb 24, 10:00 AM · Restricted Project
vzakhari updated the diff for D97348: [libomptarget] Fixed MSVC build fail caused by __attribute__((used))..

Fixed clang-format remarks.

Wed, Feb 24, 9:57 AM · Restricted Project

Tue, Feb 23

vzakhari requested review of D97348: [libomptarget] Fixed MSVC build fail caused by __attribute__((used))..
Tue, Feb 23, 5:00 PM · Restricted Project

Jan 28 2021

vzakhari added inline comments to D93055: [OpenMP] Add time profiling for libomptarget.
Jan 28 2021, 3:52 PM · Restricted Project
vzakhari added inline comments to D93055: [OpenMP] Add time profiling for libomptarget.
Jan 28 2021, 3:11 PM · Restricted Project

Jan 27 2021

vzakhari added a comment to D95572: [libomptarget][NFC] Link plugins with threads support library due to std::call_once usage..

I've tested the change and everything seems to work fine. So let's commit it. Thanks for the patch!

Do you mean I can ignore the pre-merge checks fail? I do not see how my changes could have affected libomp build.

looks to me like that is the C++ dependence problem we discussed this morning. I don't think this patch caused it so I would go ahead.

Jan 27 2021, 7:27 PM · Restricted Project
vzakhari committed rG0fc90873b2ef: [libomptarget][NFC] Link plugins with threads support library due to std… (authored by vzakhari).
[libomptarget][NFC] Link plugins with threads support library due to std…
Jan 27 2021, 7:27 PM
vzakhari closed D95572: [libomptarget][NFC] Link plugins with threads support library due to std::call_once usage..
Jan 27 2021, 7:26 PM · Restricted Project
vzakhari added a comment to D95572: [libomptarget][NFC] Link plugins with threads support library due to std::call_once usage..

I've tested the change and everything seems to work fine. So let's commit it. Thanks for the patch!

Jan 27 2021, 7:14 PM · Restricted Project
vzakhari requested review of D95572: [libomptarget][NFC] Link plugins with threads support library due to std::call_once usage..
Jan 27 2021, 3:48 PM · Restricted Project
vzakhari added a comment to D95483: [OpenMP][WIP] Pass auxiliary YAML along with device image for OpenMP offload..

There are a bunch of side channels for communicating between the compiler and the runtime already. Compiler emitted magic symbols, a msgpack blob for amdgpu, writing extra stuff into the elf in general etc.

What information do you intend to pass along through this new channel, why yaml, and why for all plugins?

Yes there may be many ways to communicate information from compiler to runtime. The proposal is one way and we others wanted to communicate information to runtime and come up with a standard scheme.
We added this to other plugins to show how it can be done. Plugins can opt in,, just dont add the unique signature and the header.

Jan 27 2021, 2:01 PM

Jan 26 2021

vzakhari added a comment to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.

offloading/dynamic_module_load.c fails due to this commit in my environment with x86_64 offload. It fails because std::call_once cannot be used without libpthread, and libomptarget.rtl.x86_64.so is not linked with libpthread. Basically, gdb shows that include/c++/7.3.0/x86_64-linux-gnu/bits/gthr-default.h::__gthread_active_p() returns false, when std::call_once is called from libomptarget.rtl.x86_64.so. It does return true, though, when std::call_once is called from libomptarget.so, because libomptarget.so is linked with libpthread.

Jan 26 2021, 9:05 PM · Restricted Project
vzakhari abandoned D56112: [clang-offload-bundler] Added install component.
Jan 26 2021, 4:15 PM
vzakhari committed rG3caa2d3354e3: [libomptarget][NFC] Avoid gcc 5/6 issue with lambda captures. (authored by vzakhari).
[libomptarget][NFC] Avoid gcc 5/6 issue with lambda captures.
Jan 26 2021, 4:08 PM
vzakhari closed D95486: [libomptarget][NFC] Avoid gcc 5/6 issue with lambda captures..
Jan 26 2021, 4:08 PM · Restricted Project
vzakhari added a comment to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.

Can mark the function itself as ((used)), for slightly less typing. Seems a reasonable workaround to me, with a comment like 'workaround bug in gcc 5.ish'

Yeah, that's an option. Adding a dummy variable would defeat the original purpose of initializing the variables this way, rather than having each plugin initialize it individually and globally. This problem only seems to occur on GCC x86 from the compilers I've checked. The reason It wasn't failing on my machine was because it was GCC 6.3 on PPC. I'm assuming any other compilers will just ignore the attribute if they don't understand it. This should be sufficient.

static inline uint32_t __attribute__((used)) getInfoLevel  () { ... }
static inline uint32_t __attribute__((used)) getDebugLevel  () { ... }
Jan 26 2021, 3:07 PM · Restricted Project
vzakhari requested review of D95486: [libomptarget][NFC] Avoid gcc 5/6 issue with lambda captures..
Jan 26 2021, 3:05 PM · Restricted Project
vzakhari edited reviewers for D95483: [OpenMP][WIP] Pass auxiliary YAML along with device image for OpenMP offload., added: grokos; removed: jdoerfert.
Jan 26 2021, 2:34 PM
vzakhari updated the diff for D95483: [OpenMP][WIP] Pass auxiliary YAML along with device image for OpenMP offload..
Jan 26 2021, 2:34 PM
vzakhari requested review of D95483: [OpenMP][WIP] Pass auxiliary YAML along with device image for OpenMP offload..
Jan 26 2021, 2:32 PM
vzakhari committed rG5f1d4d477902: [libomptarget][NFC] Use portable printf format specifiers. (authored by vzakhari).
[libomptarget][NFC] Use portable printf format specifiers.
Jan 26 2021, 1:57 PM
vzakhari closed D95476: [libomptarget][NFC] Use portable printf format specifiers..
Jan 26 2021, 1:57 PM · Restricted Project
vzakhari requested review of D95476: [libomptarget][NFC] Use portable printf format specifiers..
Jan 26 2021, 1:03 PM · Restricted Project
vzakhari accepted D95376: [OpenMP][Libomptarget] Fix check-libomptarget.

LGTM

Jan 26 2021, 12:51 PM · Restricted Project
vzakhari added inline comments to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Jan 26 2021, 12:49 PM · Restricted Project
vzakhari added inline comments to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Jan 26 2021, 12:03 PM · Restricted Project

Jan 25 2021

vzakhari added inline comments to D95376: [OpenMP][Libomptarget] Fix check-libomptarget.
Jan 25 2021, 2:43 PM · Restricted Project
vzakhari added inline comments to D95376: [OpenMP][Libomptarget] Fix check-libomptarget.
Jan 25 2021, 1:11 PM · Restricted Project
vzakhari added inline comments to D95376: [OpenMP][Libomptarget] Fix check-libomptarget.
Jan 25 2021, 11:03 AM · Restricted Project
vzakhari added a comment to D93055: [OpenMP] Add time profiling for libomptarget.

Thank you, @ggeorgakoudis !

Jan 25 2021, 10:42 AM · Restricted Project
vzakhari added inline comments to D95376: [OpenMP][Libomptarget] Fix check-libomptarget.
Jan 25 2021, 10:42 AM · Restricted Project

Jan 24 2021

vzakhari added a comment to D93055: [OpenMP] Add time profiling for libomptarget.

Hi @ggeorgakoudis, please try something along these lines:

Jan 24 2021, 7:03 PM · Restricted Project

Jan 22 2021

vzakhari added a comment to D93055: [OpenMP] Add time profiling for libomptarget.

FYI, libomptarget LIT tests fail with profiling enabled in shared-libs builds, because libLLVMSupport.so.12git dependency cannot be resolved. Apparently, LD_LIBRARY_PATH is only set to <build>/llvm/projects/openmp/libomptarget, which obviously does not contain the support library.

Thanks for reporting that @vzakhari. Will fix soon.

Jan 22 2021, 3:58 PM · Restricted Project
vzakhari added a comment to D93055: [OpenMP] Add time profiling for libomptarget.

FYI, libomptarget LIT tests fail with profiling enabled in shared-libs builds, because libLLVMSupport.so.12git dependency cannot be resolved. Apparently, LD_LIBRARY_PATH is only set to <build>/llvm/projects/openmp/libomptarget, which obviously does not contain the support library.

@vzakhari Is it an out-of-tree build? If it is, you need to set LIBOMPTARGET_OPENMP_HEADER_FOLDER and DLIBOMPTARGET_OPENMP_HOST_RTL_FOLDER (https://github.com/llvm/llvm-project/tree/main/openmp#id11).

Jan 22 2021, 3:57 PM · Restricted Project
vzakhari added a comment to D93055: [OpenMP] Add time profiling for libomptarget.

FYI, libomptarget LIT tests fail with profiling enabled in shared-libs builds, because libLLVMSupport.so.12git dependency cannot be resolved. Apparently, LD_LIBRARY_PATH is only set to <build>/llvm/projects/openmp/libomptarget, which obviously does not contain the support library.

Jan 22 2021, 12:14 PM · Restricted Project

Jan 7 2021

vzakhari added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Jan 7 2021, 7:24 PM · Restricted Project
vzakhari added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Jan 7 2021, 6:39 PM · Restricted Project
vzakhari added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Jan 7 2021, 5:01 PM · Restricted Project
vzakhari added inline comments to D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed.
Jan 7 2021, 4:25 PM · Restricted Project

Aug 5 2020

vzakhari added inline comments to D85320: [OpenMP] Fix `present` diagnostic for array extension.
Aug 5 2020, 1:19 PM · Restricted Project
vzakhari added inline comments to D85320: [OpenMP] Fix `present` diagnostic for array extension.
Aug 5 2020, 11:29 AM · Restricted Project

Jun 16 2020

vzakhari accepted D81982: [lld-macho] Use uint64_t for getSize() instead of size_t.
Jun 16 2020, 6:41 PM · Restricted Project
vzakhari added a comment to D81982: [lld-macho] Use uint64_t for getSize() instead of size_t.

Should be working now. Thanks!

Jun 16 2020, 6:41 PM · Restricted Project
vzakhari added a comment to D81982: [lld-macho] Use uint64_t for getSize() instead of size_t.

FYI, the tests pass with additional changes in lld/MachO/SyntheticSections.cpp.

Jun 16 2020, 6:05 PM · Restricted Project
vzakhari added a comment to D81982: [lld-macho] Use uint64_t for getSize() instead of size_t.

Thank you! The patch does not build, since some CPP definitions are still using size_t.

Jun 16 2020, 6:05 PM · Restricted Project
vzakhari added a comment to D80177: [lld-macho] Set __PAGEZERO size to 4GB.

rGd767de44bf9527cb5058f5fe16aac2f23c21977c was the referenced fix. Good point about size_t, I'll change that

Jun 16 2020, 4:00 PM · Restricted Project
vzakhari added a comment to D80177: [lld-macho] Set __PAGEZERO size to 4GB.

Thanks for the heads up, just pushed a likely fix and will monitor http://lab.llvm.org:8011/builders/lld-x86_64-win. I'll set up a local Windows VM to catch future such issues earlier...

Jun 16 2020, 2:51 PM · Restricted Project

Jun 3 2020

vzakhari committed rG3a1b07506c1f: Define __SPIR__ macro for spir/spir64 targets. (authored by vzakhari).
Define __SPIR__ macro for spir/spir64 targets.
Jun 3 2020, 12:40 PM
vzakhari closed D80655: Define __SPIR__ macro for spir/spir64 targets..
Jun 3 2020, 12:40 PM · Restricted Project

May 27 2020

vzakhari created D80655: Define __SPIR__ macro for spir/spir64 targets..
May 27 2020, 1:02 PM · Restricted Project

May 26 2020

vzakhari added a comment to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

It does not work on Windows (msbuild) for me, because ${pathlist_escaped} contains paths like %(build_mode)s/bin (caused by set_llvm_build_mode). This seems to break something so that python process does not produce any output at all: I checked both OUTPUT_VARIABLE and ERROR_VARIABLE and they were empty on any invocation of execute_process. @thakis, do you have any ideas what might be wrong?

FWIW, the code does not seem to work as expected for multi-configuration environments, since the %(build_mode) substitution is not done yet and the paths are not real filesystem paths.

May 26 2020, 7:38 PM · Restricted Project, Restricted Project
Herald added a project to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang: Restricted Project.

It does not work on Windows (msbuild) for me, because ${pathlist_escaped} contains paths like %(build_mode)s/bin (caused by set_llvm_build_mode). This seems to break something so that python process does not produce any output at all: I checked both OUTPUT_VARIABLE and ERROR_VARIABLE and they were empty on any invocation of execute_process. @thakis, do you have any ideas what might be wrong?

May 26 2020, 6:33 PM · Restricted Project, Restricted Project

Feb 27 2020

vzakhari added a comment to D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires.

LGTM

Feb 27 2020, 1:04 PM · Restricted Project, Restricted Project

Feb 26 2020

vzakhari added inline comments to D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires.
Feb 26 2020, 5:48 PM · Restricted Project, Restricted Project

Aug 19 2019

vzakhari committed rGf7229ac7d88e: Fixed placement of llvm.global_dtors on Windows. (authored by vzakhari).
Fixed placement of llvm.global_dtors on Windows.
Aug 19 2019, 2:13 PM
vzakhari committed rL369299: Fixed placement of llvm.global_dtors on Windows..
Fixed placement of llvm.global_dtors on Windows.
Aug 19 2019, 2:10 PM
vzakhari closed D66373: Fixed placement of llvm.global_dtors on Windows..
Aug 19 2019, 2:10 PM · Restricted Project

Aug 16 2019

vzakhari added a comment to D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script.

FYI, llvm.global_dtor fix is in https://reviews.llvm.org/D66373

Aug 16 2019, 4:52 PM
vzakhari created D66373: Fixed placement of llvm.global_dtors on Windows..
Aug 16 2019, 4:47 PM · Restricted Project
vzakhari added a comment to D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script.

As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors variables offer similar and platform neutral functionality (http://llvm.org/docs/LangRef.html#the-llvm-global-ctors-global-variable). Why do you think that ‘atexit’ is a better choice?

Because it does not work on Windows, better to have portable solution, if possible.

Is there a bug # ?

@vzakhari?

I do not have bug #, but the issue was introduced with the following commit:
commit f803b23879d9e1d9415ec1875713534dcc203df5
Author: Reid Kleckner <rnk@google.com>
Date: Fri Sep 7 23:07:55 2018 +0000

[COFF] Implement llvm.global_ctors priorities for MSVC COFF targets

Summary:
MSVC and LLD sort sections ASCII-betically, so we need to use section
names that sort between .CRT$XCA (the start) and .CRT$XCU (the default
priority).

In the general case, use .CRT$XCT12345 as the section name, and let the
linker sort the zero-padded digits.

Users with low priorities typically want to initialize as early as
possible, so use .CRT$XCA00199 for prioties less than 200. This number
is arbitrary.

Implements PR38552.

Reviewers: majnemer, mstorsjo

Subscribers: hiraditya, llvm-commits

Differential Revision: https://reviews.llvm.org/D51820

llvm-svn: 341727

The destructors are still in .CRT$XT for default priority (65535) now, but for non-default priority they will go into .CRT$XC. I will upload a fixing patch with a LIT test shortly.

This clang-offload-wrapper commit will work properly, if we use default priority for the destructors.

'IMHO' if there is a problem with lowering of LLVM IR constructs for some
particular targets, that problem must be resolved instead of adding workarounds.

Aug 16 2019, 10:37 AM
vzakhari added a comment to D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script.

As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors variables offer similar and platform neutral functionality (http://llvm.org/docs/LangRef.html#the-llvm-global-ctors-global-variable). Why do you think that ‘atexit’ is a better choice?

Because it does not work on Windows, better to have portable solution, if possible.

Is there a bug # ?

@vzakhari?

Aug 16 2019, 10:17 AM

Aug 7 2019

vzakhari added inline comments to D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script.
Aug 7 2019, 11:43 AM

Aug 6 2019

vzakhari added inline comments to D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script.
Aug 6 2019, 10:51 PM

Jul 10 2019

vzakhari committed rGde811d1f51c9: [clang] Preserve names of addrspacecast'ed values. (authored by vzakhari).
[clang] Preserve names of addrspacecast'ed values.
Jul 10 2019, 10:12 AM
vzakhari committed rL365666: [clang] Preserve names of addrspacecast'ed values..
[clang] Preserve names of addrspacecast'ed values.
Jul 10 2019, 10:10 AM
vzakhari closed D63846: [clang] Preserve names of addrspacecast'ed values..
Jul 10 2019, 10:10 AM · Restricted Project, Restricted Project

Jul 8 2019

vzakhari added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

I changed the tests to use FileCheck variables whenever possible.

Jul 8 2019, 6:16 PM · Restricted Project, Restricted Project
vzakhari updated the diff for D63846: [clang] Preserve names of addrspacecast'ed values..
Jul 8 2019, 6:14 PM · Restricted Project, Restricted Project
vzakhari added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

I don't know what I think about widespread use of -fno-discard-value-names for now; please continue to use FileCheck variables, and we can make a holistic decision about that flag later.

Jul 8 2019, 1:33 PM · Restricted Project, Restricted Project
vzakhari added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

Please don't check IR names in test output. That actually includes anonymous names like %2; these should always be tested with FileCheck variables. I suggest using %.* as the pattern; if you're matching the LHS of an LLVM assignment, that shouldn't have problems with accidentally matching too much.

Jul 8 2019, 1:21 PM · Restricted Project, Restricted Project
vzakhari added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

ping

Jul 8 2019, 10:52 AM · Restricted Project, Restricted Project

Jul 1 2019

vzakhari added reviewers for D63846: [clang] Preserve names of addrspacecast'ed values.: erichkeane, rsmith.

Adding more reviewers.

Jul 1 2019, 11:29 AM · Restricted Project, Restricted Project

Jun 28 2019

vzakhari added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

ping

Jun 28 2019, 6:11 PM · Restricted Project, Restricted Project

Jun 26 2019

vzakhari created D63846: [clang] Preserve names of addrspacecast'ed values..
Jun 26 2019, 3:13 PM · Restricted Project, Restricted Project

May 17 2019

vzakhari added inline comments to D61425: Install import libraries.
May 17 2019, 1:41 PM · Restricted Project

Apr 29 2019

vzakhari accepted D61220: lib/Header: Fix Visual Studio builds try #2.
Apr 29 2019, 5:49 PM · Restricted Project, Restricted Project
vzakhari added a comment to D61220: lib/Header: Fix Visual Studio builds try #2.

OK, this should work while clang_generate_header() is used for plain files.

Apr 29 2019, 5:49 PM · Restricted Project, Restricted Project
vzakhari added inline comments to D61220: lib/Header: Fix Visual Studio builds try #2.
Apr 29 2019, 11:41 AM · Restricted Project, Restricted Project

Apr 27 2019

vzakhari added inline comments to D61220: lib/Header: Fix Visual Studio builds try #2.
Apr 27 2019, 6:24 PM · Restricted Project, Restricted Project

Apr 24 2019

vzakhari added a comment to D58537: lib/Header: Simplify CMakeLists.txt.

Can you test D61054?

Apr 24 2019, 10:11 AM · Restricted Project, Restricted Project

Apr 23 2019

vzakhari added inline comments to D58537: lib/Header: Simplify CMakeLists.txt.
Apr 23 2019, 10:29 AM · Restricted Project, Restricted Project

Apr 1 2019

vzakhari added inline comments to D58537: lib/Header: Simplify CMakeLists.txt.
Apr 1 2019, 2:02 PM · Restricted Project, Restricted Project

Jan 21 2019

vzakhari added a comment to D56112: [clang-offload-bundler] Added install component.

ping

Jan 21 2019, 8:29 PM

Jan 4 2019

vzakhari committed rL350436: Update the pr_datasz of .note.gnu.property section..
Update the pr_datasz of .note.gnu.property section.
Jan 4 2019, 1:28 PM
vzakhari closed D56080: update the pr_datasz of .note.gnu.property section.
Jan 4 2019, 1:28 PM

Jan 3 2019

vzakhari accepted D56080: update the pr_datasz of .note.gnu.property section.
Jan 3 2019, 11:20 AM
vzakhari added a comment to D56080: update the pr_datasz of .note.gnu.property section.

I think I got it, finally, after talking with HJ. As defined in https://github.com/hjl-tools/x86-psABI/blob/hjl/master/dl.tex, the pr_data field consists of 4-byte integers for GNU_PROPERTY_X86_FEATURE_1_AND program property type (pr_type). At the same time, the program property array must be a multiple of 8 bytes on x86-64 (as stated in https://github.com/hjl-tools/linux-abi/blob/hjl/master/object-files.tex), thus, the alignment is computed properly.

Jan 3 2019, 11:18 AM

Jan 2 2019

vzakhari added inline comments to D56080: update the pr_datasz of .note.gnu.property section.
Jan 2 2019, 9:46 PM
vzakhari added a comment to D56080: update the pr_datasz of .note.gnu.property section.

Please submit your patch with full context according to LLVM's documentation: https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Jan 2 2019, 1:15 PM
vzakhari committed rOMP350254: [libomptarget] Added install component for libomptarget.
[libomptarget] Added install component for libomptarget
Jan 2 2019, 11:51 AM
vzakhari committed rL350254: [libomptarget] Added install component for libomptarget.
[libomptarget] Added install component for libomptarget
Jan 2 2019, 11:43 AM
vzakhari closed D56108: [libomptarget] Added install component for libomptarget.
Jan 2 2019, 11:43 AM · Restricted Project

Dec 28 2018

vzakhari added a comment to D56108: [libomptarget] Added install component for libomptarget.

Can you explain the benefit of this change? I would have expected a target like install-omptarget, but applying this patch locally didn't change anything visible.

Dec 28 2018, 10:02 AM · Restricted Project
vzakhari updated the diff for D56108: [libomptarget] Added install component for libomptarget.
Dec 28 2018, 9:57 AM · Restricted Project

Dec 27 2018

vzakhari created D56112: [clang-offload-bundler] Added install component.
Dec 27 2018, 2:36 PM
vzakhari created D56108: [libomptarget] Added install component for libomptarget.
Dec 27 2018, 11:28 AM · Restricted Project

Nov 27 2018

vzakhari committed rL347686: [TableGen] Preprocessing support.
[TableGen] Preprocessing support
Nov 27 2018, 11:00 AM
vzakhari closed D54926: [TableGen] Preprocessing support.
Nov 27 2018, 11:00 AM

Nov 26 2018

vzakhari updated the diff for D54926: [TableGen] Preprocessing support.

The incremenetal fix.

Nov 26 2018, 7:07 PM