User Details
- User Since
- May 29 2018, 3:20 PM (214 w, 5 m)
Today
Sorry for the delay. LGTM.
Tue, Jun 28
Thank you all for the reviews! I will upload the final changes shortly and merge them after pre-merge checks pass.
Latest revision is rebase + Lower/array-expression-slice-1.f90 fix.
Mon, Jun 27
@awarzynski, thank you for the review!
Fri, Jun 24
Thank you for the thorough review! Please see my comments below.
Thu, Jun 23
Thank you for reviewing!
Wed, Jun 22
Please review.
Nov 8 2021
Oct 20 2021
If there are no more comments, I am going to merge this by the end of the week.
Oct 19 2021
Oct 6 2021
Oct 5 2021
Sep 30 2021
Sep 22 2021
Sep 21 2021
Aug 25 2021
Aug 24 2021
Aug 18 2021
Hi Jon, I am about to merge D108246 that disables the notes embedding.
Aug 17 2021
Aug 16 2021
In the latest update I added llvm-objcopy as a dependence for clang-offload-wrapper, because otherwise make check-libomptarget would fail.
Aug 12 2021
Aug 10 2021
Aug 9 2021
ping...
Can someone please review the updated (simplified) patch?
Aug 4 2021
Jul 6 2021
LGTM
Jun 21 2021
Jun 18 2021
Jun 17 2021
Can you please provide the CMake command to reproduce this? I cannot reproduce this with an ordinary in-tree build.
Jun 16 2021
Jun 15 2021
Just a rebase.
Jun 7 2021
Implemented using lib/BinaryFormat/Magic.cpp
Jun 4 2021
Jun 3 2021
Jun 2 2021
Sorry, I do not see where I said that there are no default values. I said that neither default nor zero-initialization works - in this phrase I referred to initialization of POD members of objects, when we use default or zero-initialization. For example, look at struct MipsABIFlags: if we declare an object of this type using default initialization/construction, then members like ISARevision will be default constructed, which in turn causes their value to be undefined (because they use the default constructor of the type defined by LLVM_YAML_STRONG_TYPEDEF). Value/zero-initialization will also not work for such objects, because struct MipsABIFlags has a user-defined constructor.
May 25 2021
ping