Page MenuHomePhabricator

vzakhari (Slava Zakharin)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2018, 3:20 PM (252 w, 3 d)

Recent Activity

Thu, Mar 30

vzakhari accepted D147224: [flang] move ASSOCIATED intrinsic optional TARGET handling.

LGTM

Thu, Mar 30, 7:44 PM · Restricted Project, Restricted Project
vzakhari accepted D147239: [flang] Fix context less NULL() lowering.

LGTM. It looks like D147237 was not pulled into the testing.

Thu, Mar 30, 9:11 AM · Restricted Project, Restricted Project
vzakhari accepted D147237: [flang] allow allocation of scalar TYPE(*) descriptors.

LGTM

Thu, Mar 30, 9:09 AM · Restricted Project, Restricted Project

Wed, Mar 29

vzakhari accepted D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Wed, Mar 29, 9:03 AM · Restricted Project, Restricted Project
vzakhari added a comment to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

@jdoerfert Would using functions from compiler-rt cause issues with target offloading?
Context: We are thinking of using functions from compiler-rt for implementing the complex division operation. The existing implementations in Flang (an inline one) and the one on MLIR both have precision issues whereas the compiler-rt ones work fine.

I think these functions exist for target offloading too, I've used complex numbers in omp regions in C/C++ before and it has worked, and afaict clang just calls these functions. At least for Nvidia there's clang/lib/Headers/__clang_cuda_complex_builtins.h which contains them.

Wed, Mar 29, 8:58 AM · Restricted Project, Restricted Project

Tue, Mar 28

vzakhari committed rGf9e995b4bdce: [flang] Normalize logical values during type conversions. (authored by vzakhari).
[flang] Normalize logical values during type conversions.
Tue, Mar 28, 10:12 AM · Restricted Project, Restricted Project
vzakhari closed D147019: [flang] Normalize logical values during type conversions..
Tue, Mar 28, 10:12 AM · Restricted Project, Restricted Project

Mon, Mar 27

vzakhari requested review of D147019: [flang] Normalize logical values during type conversions..
Mon, Mar 27, 7:54 PM · Restricted Project, Restricted Project
vzakhari added a comment to D141820: [flang] Generate TBAA information..

Hi @vzakhari , are you still working on box/type descriptor such as type_desc_4/5/6? Or do you plan to work on that later? I am studying some optimizations which may benefit from the complete tbaa.

Mon, Mar 27, 10:13 AM · Restricted Project, Restricted Project

Tue, Mar 21

vzakhari committed rGee7b6fd4c1c1: [flang] Set proper source location for the main function. (authored by vzakhari).
[flang] Set proper source location for the main function.
Tue, Mar 21, 12:33 PM · Restricted Project, Restricted Project
vzakhari closed D146445: [flang] Set proper source location for the main function..
Tue, Mar 21, 12:33 PM · Restricted Project, Restricted Project

Mon, Mar 20

vzakhari added a comment to D146278: [flang] add -flang-experimental-hlfir flag to flang-new.

LGTM
Please address @awarzynski's comment about the test.

Mon, Mar 20, 8:03 PM · Restricted Project, Restricted Project, Restricted Project
vzakhari added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

Thank you for the update!

Mon, Mar 20, 7:59 PM · Restricted Project, Restricted Project
vzakhari requested review of D146445: [flang] Set proper source location for the main function..
Mon, Mar 20, 11:10 AM · Restricted Project, Restricted Project

Fri, Mar 17

vzakhari added inline comments to D146278: [flang] add -flang-experimental-hlfir flag to flang-new.
Fri, Mar 17, 5:18 PM · Restricted Project, Restricted Project, Restricted Project
vzakhari added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

Yes, I think the option to control ctlz conversion will do. The default is up to you.

Fri, Mar 17, 12:23 PM · Restricted Project, Restricted Project
vzakhari added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

Hi @j2kun, welcome to MLIR code base :)

Fri, Mar 17, 11:44 AM · Restricted Project, Restricted Project
vzakhari added a comment to D146278: [flang] add -flang-experimental-hlfir flag to flang-new.

Thank you for working on this!

Fri, Mar 17, 10:48 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 16

vzakhari accepted D145957: [flang][hlfir] add hlfir.matmul_transpose operation.
Thu, Mar 16, 9:48 AM · Restricted Project, Restricted Project
vzakhari accepted D145959: [flang][hlfir] add matmul canonicalizer.

Thank you for the update!

Thu, Mar 16, 9:39 AM · Restricted Project, Restricted Project

Wed, Mar 15

vzakhari added inline comments to D145959: [flang][hlfir] add matmul canonicalizer.
Wed, Mar 15, 7:54 PM · Restricted Project, Restricted Project

Tue, Mar 14

vzakhari committed rGe63a600d147b: [flang] Fixed linaro-flang-aarch64-sharedlibs after D145992. (authored by vzakhari).
[flang] Fixed linaro-flang-aarch64-sharedlibs after D145992.
Tue, Mar 14, 1:59 PM · Restricted Project, Restricted Project
vzakhari committed rG1c5d12144058: [flang] Handle Flang examples consistently with LLVM. (authored by vzakhari).
[flang] Handle Flang examples consistently with LLVM.
Tue, Mar 14, 1:09 PM · Restricted Project, Restricted Project
vzakhari closed D145992: [flang] Handle Flang examples consistently with LLVM..
Tue, Mar 14, 1:09 PM · Restricted Project, Restricted Project
vzakhari added inline comments to D145992: [flang] Handle Flang examples consistently with LLVM..
Tue, Mar 14, 1:06 PM · Restricted Project, Restricted Project
vzakhari updated the diff for D145992: [flang] Handle Flang examples consistently with LLVM..

Got rid of FLANG_BUILD_EXAMPLES in favor of LLVM_BUILD_EXAMPLES.

Tue, Mar 14, 11:19 AM · Restricted Project, Restricted Project

Mon, Mar 13

vzakhari added a comment to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..

FYI, "Invalid shuffle vector instruction operands!" assertion kicks in with both first and second commits: https://github.com/llvm/llvm-project/issues/61395

Mon, Mar 13, 9:14 PM · Restricted Project, Restricted Project
vzakhari added a comment to D145992: [flang] Handle Flang examples consistently with LLVM..

Thanks, Slava. You're a prince!

All builds and tests correctly and looks good.

Mon, Mar 13, 3:45 PM · Restricted Project, Restricted Project
vzakhari requested review of D145992: [flang] Handle Flang examples consistently with LLVM..
Mon, Mar 13, 3:04 PM · Restricted Project, Restricted Project
vzakhari committed rGc5363678932a: [flang] Avoid ICE in case of subprogram name clash with runtime namespace. (authored by vzakhari).
[flang] Avoid ICE in case of subprogram name clash with runtime namespace.
Mon, Mar 13, 10:17 AM · Restricted Project, Restricted Project
vzakhari closed D145653: [flang] Avoid ICE in case of subprogram name clash with runtime namespace..
Mon, Mar 13, 10:16 AM · Restricted Project, Restricted Project
vzakhari added a comment to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

I wonder whether intermediate computations generated by ComplexToStandard conversion complex::DivOp honor the range of the element's data type. Maybe we can think of replacing the FIR operation with the one from the Complex dialect?

Mon, Mar 13, 10:10 AM · Restricted Project, Restricted Project
vzakhari added inline comments to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mon, Mar 13, 10:02 AM · Restricted Project, Restricted Project
vzakhari added a comment to D145653: [flang] Avoid ICE in case of subprogram name clash with runtime namespace..

Fine for me if this is the intended behavior.

Mon, Mar 13, 9:26 AM · Restricted Project, Restricted Project
vzakhari added inline comments to D145883: [Flang][RISCV] Emit target features for RISC-V.
Mon, Mar 13, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
vzakhari added inline comments to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mon, Mar 13, 9:12 AM · Restricted Project, Restricted Project

Sun, Mar 12

vzakhari added inline comments to D145653: [flang] Avoid ICE in case of subprogram name clash with runtime namespace..
Sun, Mar 12, 4:21 PM · Restricted Project, Restricted Project
vzakhari added inline comments to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Sun, Mar 12, 3:09 PM · Restricted Project, Restricted Project

Wed, Mar 8

vzakhari requested review of D145653: [flang] Avoid ICE in case of subprogram name clash with runtime namespace..
Wed, Mar 8, 10:40 PM · Restricted Project, Restricted Project
vzakhari accepted D145602: Remove circular dependency between libFIRSupport and libFIRDialect.
Wed, Mar 8, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
vzakhari accepted D145165: [Flang] Give fir.if RegionBranchOpInterface.

Thanks!

Wed, Mar 8, 9:41 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

vzakhari committed rG2c8d33897d90: [flang] Enable target rewrite for int args/rets of bind(c) functions. (authored by vzakhari).
[flang] Enable target rewrite for int args/rets of bind(c) functions.
Tue, Mar 7, 7:11 PM · Restricted Project, Restricted Project
vzakhari closed D145537: [flang] Enable target rewrite for int args/rets of bind(c) functions..
Tue, Mar 7, 7:10 PM · Restricted Project, Restricted Project
vzakhari requested review of D145537: [flang] Enable target rewrite for int args/rets of bind(c) functions..
Tue, Mar 7, 6:48 PM · Restricted Project, Restricted Project
vzakhari accepted D145165: [Flang] Give fir.if RegionBranchOpInterface.
Tue, Mar 7, 2:15 PM · Restricted Project, Restricted Project, Restricted Project
vzakhari added a comment to D145165: [Flang] Give fir.if RegionBranchOpInterface.

One minor thing, otherwise, looks good.

Tue, Mar 7, 2:14 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

vzakhari accepted D144885: [flang] Implement atand intrinsic.

LGTM

Mon, Mar 6, 8:49 AM · Restricted Project, Restricted Project

Mar 1 2023

vzakhari committed rGd80a29a933a0: [flang] Check for BIND(C) through use association. (authored by vzakhari).
[flang] Check for BIND(C) through use association.
Mar 1 2023, 12:03 PM · Restricted Project, Restricted Project
vzakhari closed D145084: [flang] Check for BIND(C) through use association..
Mar 1 2023, 12:03 PM · Restricted Project, Restricted Project
vzakhari accepted D145092: [flang] Fix ISHFTC argument value check.

LGTM

Mar 1 2023, 11:28 AM · Restricted Project, Restricted Project
vzakhari accepted D145089: [flang] Warn about dangerous actual argument association with TARGET dummy arguments.

Thanks!

Mar 1 2023, 11:00 AM · Restricted Project, Restricted Project
vzakhari requested review of D145084: [flang] Check for BIND(C) through use association..
Mar 1 2023, 10:31 AM · Restricted Project, Restricted Project
vzakhari accepted D145044: [flang] Use the newly introduced AliasAnalysisOpInterface..

Thanks!

Mar 1 2023, 8:04 AM · Restricted Project, Restricted Project

Feb 27 2023

vzakhari accepted D144649: [flang] Implement isnan and ieee_is_nan intrinsics.
Feb 27 2023, 11:18 PM · Restricted Project, Restricted Project
vzakhari added inline comments to D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.
Feb 27 2023, 4:18 PM · Restricted Project, Restricted Project
vzakhari added inline comments to D144885: [flang] Implement atand intrinsic.
Feb 27 2023, 9:34 AM · Restricted Project, Restricted Project

Feb 23 2023

vzakhari accepted D144103: [Flang] Add Minloc to simplify intrinsics pass.

LGTM

Feb 23 2023, 8:48 PM · Restricted Project, Restricted Project
vzakhari added inline comments to D144649: [flang] Implement isnan and ieee_is_nan intrinsics.
Feb 23 2023, 9:42 AM · Restricted Project, Restricted Project

Feb 21 2023

vzakhari committed rGcf550e6184df: [flang] Run MathToLLVM conversion as part of math conversion PM. (authored by vzakhari).
[flang] Run MathToLLVM conversion as part of math conversion PM.
Feb 21 2023, 7:16 PM · Restricted Project, Restricted Project
vzakhari closed D144523: [flang] Run MathToLLVM conversion as part of math conversion PM..
Feb 21 2023, 7:16 PM · Restricted Project, Restricted Project
vzakhari committed rG01a2d96ad473: [flang] Avoid linking step for failing LIT tests added in D143301. (authored by vzakhari).
[flang] Avoid linking step for failing LIT tests added in D143301.
Feb 21 2023, 5:05 PM · Restricted Project, Restricted Project
vzakhari added a comment to D143301: [flang] Handle unsupported warning flags.

The new tests fail to link:

flang-new: warning: The warning option '-Wextra' is not supported
/usr/bin/ld: cannot find -lFortran_main
/usr/bin/ld: cannot find -lFortranRuntime
/usr/bin/ld: cannot find -lFortranDecimal
Feb 21 2023, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
vzakhari added a comment to D144523: [flang] Run MathToLLVM conversion as part of math conversion PM..

Thank you for the review, Pete!

Feb 21 2023, 3:59 PM · Restricted Project, Restricted Project
vzakhari added a comment to D144450: [mlir] Clean-up math -> libm/llvm conversion..

FYI, Flang Intrinsics/math-codegen failure should be resolved by D144523

Feb 21 2023, 3:09 PM · Restricted Project, Restricted Project
vzakhari requested review of D144523: [flang] Run MathToLLVM conversion as part of math conversion PM..
Feb 21 2023, 3:08 PM · Restricted Project, Restricted Project

Feb 17 2023

vzakhari accepted D144295: [flang] Adding fir::getSymbolAttrName attribute to the function corresponding to the main program.

LGTM

Feb 17 2023, 3:24 PM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2023

vzakhari added inline comments to D144103: [Flang] Add Minloc to simplify intrinsics pass.
Feb 15 2023, 5:55 PM · Restricted Project, Restricted Project
vzakhari accepted D144134: [flang][runtime] MayAlias() must be false for Unallocated descriptors.
Feb 15 2023, 1:23 PM · Restricted Project, Restricted Project
vzakhari accepted D144117: [flang][runtime] Fix typo in assign.cpp.
Feb 15 2023, 10:11 AM · Restricted Project, Restricted Project
vzakhari added inline comments to D144026: [flang][runtime] Handle aliasing in Assign().
Feb 15 2023, 10:06 AM · Restricted Project, Restricted Project

Feb 13 2023

vzakhari accepted D143836: [flang] Strengthen conformance requirements for allocatable/pointer dummy arguments.

LGTM

Feb 13 2023, 10:26 AM · Restricted Project, Restricted Project
vzakhari accepted D143890: [flang] Disable libc++ assertions in the runtime library.

Thanks!

Feb 13 2023, 10:25 AM · Restricted Project, Restricted Project

Feb 10 2023

vzakhari accepted D143799: [flang] Handle forward references to modules.
Feb 10 2023, 7:24 PM · Restricted Project, Restricted Project
vzakhari accepted D143798: [flang] Warn on overflow folding DIM().
Feb 10 2023, 5:36 PM · Restricted Project, Restricted Project
vzakhari committed rGe8a79dc3d8eb: [flang] Do not print backtrace for most TODOs. (authored by vzakhari).
[flang] Do not print backtrace for most TODOs.
Feb 10 2023, 3:08 PM · Restricted Project, Restricted Project
vzakhari closed D143761: [flang] Do not print backtrace for most TODOs..
Feb 10 2023, 3:08 PM · Restricted Project, Restricted Project
vzakhari requested review of D143761: [flang] Do not print backtrace for most TODOs..
Feb 10 2023, 9:43 AM · Restricted Project, Restricted Project
vzakhari committed rGff8742df9e65: [flang] Fixed selective TargetRewrite. (authored by vzakhari).
[flang] Fixed selective TargetRewrite.
Feb 10 2023, 9:12 AM · Restricted Project, Restricted Project
vzakhari closed D143685: [flang] Fixed selective TargetRewrite..
Feb 10 2023, 9:11 AM · Restricted Project, Restricted Project

Feb 9 2023

vzakhari accepted D143654: [mlir][llvm] Store memory op metadata using op attributes..

Thank you, @gysit! LGTM

Feb 9 2023, 6:45 PM · Restricted Project, Restricted Project, Restricted Project
vzakhari requested review of D143685: [flang] Fixed selective TargetRewrite..
Feb 9 2023, 2:57 PM · Restricted Project, Restricted Project
vzakhari committed rG8c85550549f1: [flang] Fixed build after D142977. Added missing link to HLFIRDialect. (authored by vzakhari).
[flang] Fixed build after D142977. Added missing link to HLFIRDialect.
Feb 9 2023, 2:13 PM · Restricted Project, Restricted Project
vzakhari added a comment to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

FYI, the build is failing due to missing dependency: https://lab.llvm.org/buildbot/#/builders/181/builds/14278
I will merge the fix shortly.

Feb 9 2023, 1:52 PM · Restricted Project, Restricted Project
vzakhari accepted D143653: [mlir][llvm] Fix TBAA verfication crash.

Thank you!

Feb 9 2023, 8:58 AM · Restricted Project, Restricted Project

Feb 8 2023

vzakhari accepted D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Thank you!

Feb 8 2023, 6:45 PM · Restricted Project, Restricted Project

Feb 7 2023

vzakhari added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 7 2023, 4:47 PM · Restricted Project, Restricted Project

Feb 6 2023

vzakhari accepted D143131: [flang] Add LoongArch64 support to lib/Optimizer/CodeGen/Target.cpp.
Feb 6 2023, 8:35 AM · Restricted Project, Restricted Project
vzakhari added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 6 2023, 8:31 AM · Restricted Project, Restricted Project

Feb 3 2023

vzakhari requested changes to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 3 2023, 1:14 PM · Restricted Project, Restricted Project
vzakhari accepted D143132: [flang] Enable LoongArch for x86CompatibleBehavior in floating point flag.
Feb 3 2023, 12:36 PM · Restricted Project, Restricted Project
vzakhari requested changes to D143131: [flang] Add LoongArch64 support to lib/Optimizer/CodeGen/Target.cpp.
Feb 3 2023, 12:35 PM · Restricted Project, Restricted Project

Feb 1 2023

vzakhari added inline comments to D142897: [flang] add hlfir.sum operation.
Feb 1 2023, 5:50 PM · Restricted Project, Restricted Project
vzakhari added a comment to D142279: [cmake] Use LLVM_ENABLE_ASSERTIONS to enable assertions in libstdc++.

EDIT: I asked on the flang slack instance, hopefully we'll get an opinion from someone more actively involved.

Thanks! The consensus on slack seemed to be that we should disable assertions (maybe just libstdc++ assertions?) in the runtime library. Does anyone know how to implement that in cmake? I experimented with remove_definitions(_GLIBCXX_ASSERTIONS) in flang/runtime/CMakeLists.txt but couldn't get it to work.

Feb 1 2023, 9:04 AM · Restricted Project, Restricted Project

Jan 30 2023

vzakhari accepted D142942: [flang] Handle missing substring upper bound better when folding .

LGTM. Thanks!

Jan 30 2023, 4:22 PM · Restricted Project, Restricted Project
vzakhari committed rGff794116f981: [flang] Use proper attributes for runtime calls with 'i1' arguments/returns. (authored by vzakhari).
[flang] Use proper attributes for runtime calls with 'i1' arguments/returns.
Jan 30 2023, 3:40 PM · Restricted Project, Restricted Project
vzakhari closed D142677: [flang] Use proper attributes for runtime calls with 'i1' arguments/returns..
Jan 30 2023, 3:40 PM · Restricted Project, Restricted Project
vzakhari committed rG71456fdc433a: [flang] Fixed Flang LIT testing after D142548. (authored by vzakhari).
[flang] Fixed Flang LIT testing after D142548.
Jan 30 2023, 2:36 PM · Restricted Project, Restricted Project
vzakhari closed D142935: [flang] Fixed Flang LIT testing after D142548..
Jan 30 2023, 2:36 PM · Restricted Project, Restricted Project
vzakhari added a comment to D142935: [flang] Fixed Flang LIT testing after D142548..

Fixes the test to work with D142548

Jan 30 2023, 2:02 PM · Restricted Project, Restricted Project
vzakhari requested review of D142935: [flang] Fixed Flang LIT testing after D142548..
Jan 30 2023, 2:01 PM · Restricted Project, Restricted Project