Page MenuHomePhabricator

chrisjackson (Chris Jackson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2018, 9:11 AM (227 w, 6 d)

Recent Activity

May 3 2022

chrisjackson committed rG0c8c05064d57: [llvm-ar] Modify usage printouts to use the correct toolname (authored by chrisjackson).
[llvm-ar] Modify usage printouts to use the correct toolname
May 3 2022, 9:45 AM · Restricted Project, Restricted Project
chrisjackson closed D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
May 3 2022, 9:45 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
May 3 2022, 8:18 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D124445: [llvm-ar] Modify usage printouts to use the correct toolname.

Address reviewer comments by adding a clarification in the llvm-ar tool-name test.

May 3 2022, 7:08 AM · Restricted Project, Restricted Project

Apr 29 2022

chrisjackson added inline comments to D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 29 2022, 1:26 AM · Restricted Project, Restricted Project

Apr 28 2022

chrisjackson committed rGc792884589b8: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2] (authored by chrisjackson).
[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]
Apr 28 2022, 6:23 AM · Restricted Project, Restricted Project
chrisjackson added a reverting change for rG3f2b76ec90b5: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]: rGcd5f9efc4da6: Revert "[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]".
Apr 28 2022, 6:08 AM · Restricted Project, Restricted Project
chrisjackson committed rGcd5f9efc4da6: Revert "[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]" (authored by chrisjackson).
Revert "[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]"
Apr 28 2022, 6:08 AM · Restricted Project, Restricted Project
chrisjackson added a reverting change for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2]: rGcd5f9efc4da6: Revert "[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]".
Apr 28 2022, 6:07 AM · Restricted Project, Restricted Project
chrisjackson committed rG3f2b76ec90b5: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2] (authored by chrisjackson).
[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]
Apr 28 2022, 5:57 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
  • Add managed DVIRecoveryRecords to address memory leak
Apr 28 2022, 4:48 AM · Restricted Project, Restricted Project
chrisjackson added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Apr 28 2022, 3:15 AM · Restricted Project, Restricted Project

Apr 27 2022

chrisjackson added inline comments to D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 27 2022, 9:47 AM · Restricted Project, Restricted Project
chrisjackson added inline comments to D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 27 2022, 9:25 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D124445: [llvm-ar] Modify usage printouts to use the correct toolname.

Respond to reviewer comments:

  • Add missed llvm-ranlib/tool-name.test update
  • Make ranlib printout consistent with ar
  • Make toolname pattern check more strict
Apr 27 2022, 9:24 AM · Restricted Project, Restricted Project
chrisjackson committed rG74273d575f99: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2] (authored by chrisjackson).
[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]
Apr 27 2022, 5:12 AM · Restricted Project, Restricted Project
chrisjackson added a reverting change for rG8f550368b169: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]: rG855752e563ec: Revert [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics[2/2].
Apr 27 2022, 5:07 AM · Restricted Project, Restricted Project
chrisjackson committed rG855752e563ec: Revert [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics[2/2] (authored by chrisjackson).
Revert [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics[2/2]
Apr 27 2022, 5:07 AM · Restricted Project, Restricted Project
chrisjackson added a reverting change for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2]: rG855752e563ec: Revert [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics[2/2].
Apr 27 2022, 5:07 AM · Restricted Project, Restricted Project
chrisjackson committed rG8f550368b169: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2] (authored by chrisjackson).
[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [2/2]
Apr 27 2022, 4:50 AM · Restricted Project, Restricted Project
chrisjackson closed D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Apr 27 2022, 4:50 AM · Restricted Project, Restricted Project
chrisjackson committed rGc45e4c140f98: [Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [1/2] [NFC] (authored by chrisjackson).
[Debuginfo][LSR] Add salvaging variadic dbg.value intrinsics [1/2] [NFC]
Apr 27 2022, 3:46 AM · Restricted Project, Restricted Project
chrisjackson closed D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Apr 27 2022, 3:45 AM · Restricted Project, Restricted Project, debug-info

Apr 26 2022

chrisjackson added a comment to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Note that this patch also fixes Issue #55097.

Apr 26 2022, 4:45 AM · Restricted Project, Restricted Project
chrisjackson updated the summary of D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 26 2022, 4:38 AM · Restricted Project, Restricted Project
chrisjackson added reviewers for D124445: [llvm-ar] Modify usage printouts to use the correct toolname: JanekvO, akuran.
Apr 26 2022, 4:33 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 26 2022, 4:28 AM · Restricted Project, Restricted Project
chrisjackson added reviewers for D124445: [llvm-ar] Modify usage printouts to use the correct toolname: gbreynoo, rupprecht, jhenderson.
Apr 26 2022, 4:26 AM · Restricted Project, Restricted Project
chrisjackson updated the summary of D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 26 2022, 4:20 AM · Restricted Project, Restricted Project
chrisjackson requested review of D124445: [llvm-ar] Modify usage printouts to use the correct toolname.
Apr 26 2022, 4:20 AM · Restricted Project, Restricted Project

Apr 20 2022

chrisjackson added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Apr 20 2022, 12:16 PM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Made corrections to UpdateDbgValueInst() using @StephenTozer 's help.

Apr 20 2022, 12:15 PM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Removed old comments, clarified messages in some asserts. Added some comments to methods.

Apr 20 2022, 2:56 AM · Restricted Project, Restricted Project

Apr 19 2022

chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Correct diff update file.

Apr 19 2022, 8:27 AM · Restricted Project, Restricted Project
chrisjackson added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Apr 19 2022, 8:22 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Attempt to correct the final overwrite of the dbg.value, based on the count of DW_OP_llvm_arg operands in the expression.

Apr 19 2022, 8:22 AM · Restricted Project, Restricted Project

Apr 6 2022

chrisjackson added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Apr 6 2022, 5:00 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Respond to the very helpful review from @StephenTozer. Includes:

  • SCEVDbgValueBuilder.appendToVectors() now merges location vectors, preventing duplicates
  • Improved check for when a shorter DIExpression can be emitted
  • Use isComplex() instead of the size of the expression vector
Apr 6 2022, 4:59 AM · Restricted Project, Restricted Project

Mar 29 2022

chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Update some variable names and a couple of comments to improve readability.

Mar 29 2022, 5:10 AM · Restricted Project, Restricted Project

Mar 25 2022

chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Change remaining Densemap (for updated location-op indexes) to a SmallVector.

Mar 25 2022, 5:42 AM · Restricted Project, Restricted Project

Mar 22 2022

chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Mar 22 2022, 7:40 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Apply @djtodoro 's change and clang-format.

Mar 22 2022, 5:12 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Mostly refactoring of the functions that write the final salvage dbg.value. Some small corrections after a Clang-3.4 build caught a couple of corner cases (it builds fine now).

Mar 22 2022, 2:37 AM · Restricted Project, Restricted Project

Mar 21 2022

chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

A WIP update only, not ready for a re-review. Incorporated some of @StephenTozer 's suggestions e.g.

Mar 21 2022, 1:54 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.

Restored diff. I accidentally updated this diff with a file intended for a separate issue.

Mar 21 2022, 1:49 AM · Restricted Project, debug-info, Restricted Project
chrisjackson updated the diff for D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.

-EDIT-
Diff changed in error.

Mar 21 2022, 1:43 AM · Restricted Project, debug-info, Restricted Project

Mar 10 2022

chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Add check for empty arglist that was missing from check for nullptr arglist member

Mar 10 2022, 7:40 AM · Restricted Project, Restricted Project, debug-info
chrisjackson retitled D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC] from [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] to [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Mar 10 2022, 6:17 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Restore the the old behaviour for transforming DIArglist location arguments to single- location op:. When trying to determine the type of an undef Value that has become a nullptr, simply abandon the salvage attempt. This restores the NFC status of this patch.

Mar 10 2022, 6:17 AM · Restricted Project, Restricted Project, debug-info

Mar 9 2022

chrisjackson added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Mar 9 2022, 2:11 PM · Restricted Project, Restricted Project
chrisjackson added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Reinstate the check for dbg.value that LSR has changed from single location-op to multi location-op. When LSR makes this change, the single location argument is changed to a DIArglist. This patch now replaces the DIArglist with a single 'undef'. This will prevent the generation of invalid dbg.value that were causing the crash as reported by @Orlando .

If that change makes the patch not-NFC, please could you add a test for this and mention it in the commit message? Lastly, please can you appease the clang-format bot?

Mar 9 2022, 1:40 PM · Restricted Project, Restricted Project, debug-info

Mar 8 2022

chrisjackson added a comment to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Thanks @StephenTozer , these are really helpful. I will be able to address them once patch [1/2] is done, which shouldn't be much longer, so hopefully I can address your comments at the end of the week.

Mar 8 2022, 1:58 AM · Restricted Project, Restricted Project

Mar 7 2022

chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Remove accidental double application of dbg.value expression restoration.

Mar 7 2022, 7:44 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Reinstate the check for dbg.value that LSR has changed from single location-op to multi location-op. When LSR makes this change, the single location argument is changed to a DIArglist. This patch now replaces the DIArglist with a single 'undef'. This will prevent the generation of invalid dbg.value that were causing the crash as reported by @Orlando .

Mar 7 2022, 7:00 AM · Restricted Project, Restricted Project, debug-info
chrisjackson added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

The change SGTM but I found a reproducer that causes clang to crash when this patch is applied:

$ cat reduce.cpp
#include <utility>
template <typename a> class Vec {
public:
  void push(a);
};
void d(int argc, char **argv) {
  Vec<std::pair<char *, unsigned>> e;
  for (int f = 0;;)
    for (; f < argc; ++f)
      e.push(std::make_pair(argv[f], f));
}

$ clang++  -O2 -g reduce.cpp

/home/och/dev/llvm/llvm-project/llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:139: llvm::DbgValueLoc::DbgValueLoc(const llvm::DIExpression*, llvm::ArrayRef<llvm::DbgValueLocEntry>, bool): Assertion `Expr && Expr->isValid() && is_contained(Expr->getElements(), dwarf::DW_OP_stack_value)' failed.
...
Mar 7 2022, 5:59 AM · Restricted Project, Restricted Project, debug-info

Mar 6 2022

chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Removed the naive code to check and add dwarf::DW_OP_stack_value in UpdateDbgValueInst() following @Orlando 's helpful advice and reverted to using DIExpression::prependOpcodes().

Mar 6 2022, 9:08 AM · Restricted Project, Restricted Project, debug-info

Mar 4 2022

chrisjackson added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

I can clarify the comment. It's my understanding that non-empty DIExpressions must have a DW_OP_stack_value terminator. The expressions generated by the SCEVDbgValueBuilder objects do not have these terminators (as the expressions may be inserted into other expressions). If the pre-LSR expression was empty, once the complete salvaging expression has been generated, then the terminator must be appended.

My main confusion was in why the addition of stack_value was necessary in the patch but wasn't added before. I'd missed that you were previously using prependOpcodes with param stackValue=true, but are now adding the opcode yourself. And I agree that adding a stack_value is correct in this instance because you're generating implicit locations (though I think "non-empty DIExpressions must have a DW_OP_stack_value terminator" is not true in general?). In any case, sorry for the protracted review as a result of my misunderstanding!

prependOpcodes also accounts for inserting a stack_value opcode before fragment opcodes, which your implementation doesn't appear to handle. Would it be possible to rearrange the code to use prependOpcodes so that all cases are accounted for?

Mar 4 2022, 1:28 PM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Attempt to make UpdateDbgValueInst() more clear when adding the DW_OP_stack_value terminator.

Mar 4 2022, 8:43 AM · Restricted Project, Restricted Project, debug-info

Mar 3 2022

chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Mar 3 2022, 3:32 AM · Restricted Project, Restricted Project

Mar 2 2022

chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Correction to failed function renaming.

Mar 2 2022, 9:38 AM · Restricted Project, Restricted Project, debug-info
chrisjackson retitled D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC] from [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [1/2] to [Debuginfo][LSR][NFC] Add support for salvaging variadic dbg.value intrinsics [1/2] .
Mar 2 2022, 7:33 AM · Restricted Project, Restricted Project, debug-info
chrisjackson added a comment to D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

I don't think there are "rules" about tagging patches as NFC (just put NFC somewhere in the title). It's definitely helpful to be able to see at a glance though - two examples: if an NFC patch is causing changes in output there's a bug, and if a patch is NFC it probably doesn't need any tests.

Nearly ready to approve but I'm still stuck on one thing (sorry if I'm just missing something obvious!).

Mar 2 2022, 5:02 AM · Restricted Project, Restricted Project, debug-info

Mar 1 2022

chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Responded to review from @Orlando (Thanks!).

Mar 1 2022, 10:04 AM · Restricted Project, Restricted Project, debug-info

Feb 25 2022

chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 25 2022, 3:37 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 25 2022, 3:37 AM · Restricted Project, Restricted Project
chrisjackson added a reviewer for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC]: Orlando.
Feb 25 2022, 3:35 AM · Restricted Project, Restricted Project, debug-info

Feb 23 2022

chrisjackson added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 23 2022, 5:35 AM · Restricted Project, Restricted Project
chrisjackson updated the diff for D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Removed unnecessary lit test contents as per review comments.
Fixed a comment typo in ScalarEvolution.h.

Feb 23 2022, 5:33 AM · Restricted Project, Restricted Project

Feb 22 2022

chrisjackson abandoned D90418: [debuginfo] Vectorizing a loop doesn't terminate all vectorized variable locations.
Feb 22 2022, 1:28 AM · Restricted Project, debug-info

Feb 21 2022

chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 21 2022, 3:20 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 21 2022, 3:20 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 21 2022, 2:56 AM · Restricted Project, Restricted Project
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 21 2022, 2:49 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 21 2022, 2:47 AM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 21 2022, 2:46 AM · Restricted Project, Restricted Project, debug-info

Feb 19 2022

chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 19 2022, 2:45 PM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 19 2022, 1:26 PM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 19 2022, 1:25 PM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 19 2022, 1:17 AM · Restricted Project, Restricted Project
chrisjackson updated the summary of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 19 2022, 1:14 AM · Restricted Project, Restricted Project
chrisjackson updated the summary of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 19 2022, 1:11 AM · Restricted Project, Restricted Project
chrisjackson updated the summary of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 19 2022, 1:05 AM · Restricted Project, Restricted Project, debug-info

Feb 18 2022

chrisjackson updated the diff for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].

Applied clang-format.

Feb 18 2022, 4:22 PM · Restricted Project, Restricted Project, debug-info
chrisjackson added reviewers for D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC]: aprantl, StephenTozer, jmorse, dblaikie, djtodoro, markus.
Feb 18 2022, 4:18 PM · Restricted Project, Restricted Project, debug-info
chrisjackson updated the summary of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 18 2022, 4:15 PM · Restricted Project, Restricted Project
chrisjackson requested review of D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 18 2022, 4:12 PM · Restricted Project, Restricted Project
chrisjackson requested review of D120168: [Debuginfo][LSR] Add support for salvaging variadic dbg.value intrinsics [1/2] [NFC].
Feb 18 2022, 3:35 PM · Restricted Project, Restricted Project, debug-info

Dec 16 2021

chrisjackson added a comment to D115872: [Dexter] Remove the Windows dependency on lld from CMake.

lgtm

Dec 16 2021, 5:23 AM · Restricted Project, debug-info

Nov 10 2021

chrisjackson added a comment to D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.

The lit test that was reviewed here was added with commit c63adfb8.

Nov 10 2021, 12:08 AM · Restricted Project, debug-info

Nov 9 2021

chrisjackson committed rG9c63adfb8be4: [DebugInfo][LSR] Add test for use of IV with a SCEV containing undef (authored by chrisjackson).
[DebugInfo][LSR] Add test for use of IV with a SCEV containing undef
Nov 9 2021, 5:37 AM
chrisjackson committed rG116dc70cf371: [DebugInfo][LSR] Add more stringent checks on IV selection and salvage (authored by chrisjackson).
[DebugInfo][LSR] Add more stringent checks on IV selection and salvage
Nov 9 2021, 5:14 AM
chrisjackson closed D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.
Nov 9 2021, 5:14 AM · Restricted Project, debug-info

Nov 3 2021

chrisjackson updated the diff for D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.

Amended assert and dyn_cast to cast.

Nov 3 2021, 6:13 AM · Restricted Project, debug-info

Oct 29 2021

chrisjackson added inline comments to D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.
Oct 29 2021, 7:32 AM · Restricted Project, debug-info
chrisjackson updated the diff for D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.

Reinstated the assert in GetInductionVariable().

Oct 29 2021, 7:31 AM · Restricted Project, debug-info
chrisjackson added inline comments to D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.
Oct 29 2021, 6:55 AM · Restricted Project, debug-info
chrisjackson added inline comments to D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.
Oct 29 2021, 6:54 AM · Restricted Project, debug-info
chrisjackson added inline comments to D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.
Oct 29 2021, 6:51 AM · Restricted Project, debug-info
chrisjackson updated the diff for D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.

Updated after reviewer comments.

  • Remove double check for SCEVUknown
  • Remove check of opt debug output in lit test
Oct 29 2021, 6:46 AM · Restricted Project, debug-info

Oct 18 2021

chrisjackson updated the summary of D111810: [DebugInfo][LSR] Add more stringent checks on IV selection and cached dbg.value location-op SCEVs.
Oct 18 2021, 3:28 AM · Restricted Project, debug-info