User Details
- User Since
- Sep 5 2014, 5:55 AM (446 w, 6 d)
Yesterday
Thu, Mar 23
Tue, Mar 21
Very much outdated.
Fri, Mar 17
Thu, Mar 16
Ping?
Tue, Mar 7
Mon, Mar 6
Fri, Mar 3
Feb 28 2023
Rebased, made requested changes.
Feb 27 2023
Rebased, amended patch per review comments.
Feb 14 2023
Feb 2 2023
Rebased, addressed latest requests.
Jan 18 2023
Rebased, changed as requested.
Dec 6 2022
Ping?
Nov 25 2022
Tidied up hasMaskedVariant as requested.
Rebased on top of the latest version of D132458, which incorporates the vector function into the vplan recipe instead of looking it up again.
Nov 24 2022
Updated to store the pointer to the vector function in the recipe rather than looking it up again during recipe execution. Forced generation of a plan per VF when there are variants available for those VFs. Added some new tests for masked vs. unmasked variants.
Oct 19 2022
Oct 13 2022
Oct 11 2022
@reames -- is this roughly what you expected for the case of allowing a masked variant to be used when no mask is required? I've added a cost for generating the mask (per-call for now, instead of potentially sharing it) so that we can compare costs for different VFs with and without a masked variant, but I think we would always prefer the non-masked variant for the same VF if a mask is not required.
Sep 22 2022
Sep 21 2022
Sep 13 2022
Thanks for the review. I'm tempted to add a masking equivalent to -force-target-supports-scalable-vectors=true in order to have target-independent tests, but I can add that in another patch.
Split out the functionality for synthesizing a mask when required, added a cost for mask generation.
Sep 9 2022
Sep 7 2022
Changed test to use a non-constant-zero loop limit to remove UB.
Aug 31 2022
Simplified the value names in the test case to improve readability.
Aug 30 2022
Aug 23 2022
Aug 17 2022
Jul 22 2022
Jul 21 2022
Jul 18 2022
Jul 14 2022
Rebased on top of @fhahn 's fixed patch, including changes to detect possible undef/poison.
Jul 13 2022
Jun 17 2022
Rebased on top of Florian's patch from https://reviews.llvm.org/D114487
May 30 2022
May 4 2022
LGTM
Apr 12 2022
Apr 7 2022
Rebased. Ping?
Mar 17 2022
Mar 3 2022
Rebased, added a recursion limit to the SCEV building function.
Feb 8 2022
Rebased and changed to use @fhahn 's lighter-weight approach from D114487 combined with my recursive function to find the SCEVs. Although the simplified tests are handled with a couple levels of checking, the real applications I was working on had additional operations between the ptr value for the load or store and a select.
Nov 26 2021
Revised based on @fhahn 's initial suggestions, rebased.
Nov 24 2021
Nov 22 2021
Rebased, disabled by default, added a couple of different instructions into the tests to ensure those paths are at least covered even if they aren't in a positive case right now; I'm still planning to leave those cases (known strides, g/s, uniform) for a followup patch; I suppose I could start a patch series if people want to see those earlier.
Nov 17 2021
Rebased, and changed the membership of a checking group to be a pair of PointerInfo index and fork so that printing can show which forks are present in a group.
Nov 10 2021
Superseded by @lebedev.ri 's patches. I'll continue looking at the metadata angle separately.
Nov 5 2021
Added the ability to look through GEPs for a call. I've limited this to using indexes of all 0, and only for single value types, so I'm not sure how often we'll encounter that. The limitation on the indexes does match the existing checks for whether promotion is allowed.
Nov 2 2021
Updated the diff based on the suggestion from @lebedev.ri
Oct 21 2021
Rebased, minor fixes from review comments.
Oct 20 2021
Ping.
Oct 12 2021
Rebased, updated based on review comments.
Sep 14 2021
Sep 7 2021
Sep 6 2021
Rebased, ran clang-format over the patch.
Aug 25 2021
Jun 22 2021
I'm fixing up the buildbot failure - other parts of the repo (e.g. openmp) fail to build with -Werror so I don't normally use it.
Jun 17 2021
Ping.
Jun 7 2021
Apologies for not including more of the diff for context, but the test files are large enough that the full diff exceeds the maximum upload size.
Mar 4 2020
Looks good, I agree with @dmgreen that a clang driver test would be nice.
Mar 2 2020
- Removed the ) my editor helpfully added to the CHECK line
- Added a test to declare_simd_aarch64.c
Feb 28 2020
- Added a function body to the test so that it would generate symbols
- Added check lines to ensure the mangled name is present
- Reformatted the params of Sema::CheckOpenMPLinearDecl to comply with coding style.
Jan 23 2020
Superseded by D66302
Superseded by D65448