Page MenuHomePhabricator

huntergr (Graham Hunter)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2014, 5:55 AM (446 w, 6 d)

Recent Activity

Yesterday

huntergr added inline comments to D136251: [LoopVectorize] Use available masked vector functions when required.
Wed, Mar 29, 3:29 AM · Restricted Project, Restricted Project
huntergr committed rGfba2a7c6958b: [LV][AArch64] Precommit interleaved access tests (authored by huntergr).
[LV][AArch64] Precommit interleaved access tests
Wed, Mar 29, 2:27 AM · Restricted Project, Restricted Project

Thu, Mar 23

huntergr added a reviewer for D136251: [LoopVectorize] Use available masked vector functions when required: paulwalker-arm.
Thu, Mar 23, 3:30 AM · Restricted Project, Restricted Project

Tue, Mar 21

huntergr abandoned D47768: [SVE][TableGen] Vector element constraint.

Very much outdated.

Tue, Mar 21, 4:54 AM · Restricted Project

Fri, Mar 17

huntergr committed rG9aa01c4e8917: [LV] Remove scalable constraints on creating bitcasts (authored by huntergr).
[LV] Remove scalable constraints on creating bitcasts
Fri, Mar 17, 9:20 AM · Restricted Project, Restricted Project

Thu, Mar 16

huntergr added a comment to D136251: [LoopVectorize] Use available masked vector functions when required.

Ping?

Thu, Mar 16, 5:00 AM · Restricted Project, Restricted Project
huntergr requested review of D146218: [AArch64][CodeGen] Lower (de)interleave2 intrinsics to ld2/st2.
Thu, Mar 16, 4:53 AM · Restricted Project, Restricted Project

Tue, Mar 7

huntergr committed rG92e0ab937ffd: [AArch64] Don't map llvm sqrt intrinsics to veclib functions (authored by huntergr).
[AArch64] Don't map llvm sqrt intrinsics to veclib functions
Tue, Mar 7, 4:17 AM · Restricted Project, Restricted Project
huntergr closed D145392: [AArch64] Don't map llvm sqrt intrinsics to veclib functions.
Tue, Mar 7, 4:17 AM · Restricted Project, Restricted Project

Mon, Mar 6

huntergr requested review of D145392: [AArch64] Don't map llvm sqrt intrinsics to veclib functions.
Mon, Mar 6, 8:37 AM · Restricted Project, Restricted Project

Fri, Mar 3

huntergr committed rGa180344589ca: [LV] Allow scalarization of function calls when masking is required (authored by huntergr).
[LV] Allow scalarization of function calls when masking is required
Fri, Mar 3, 7:40 AM · Restricted Project, Restricted Project
huntergr closed D134422: Scalarize calls to masked functions in LV.
Fri, Mar 3, 7:40 AM · Restricted Project, Restricted Project

Feb 28 2023

huntergr added inline comments to D136251: [LoopVectorize] Use available masked vector functions when required.
Feb 28 2023, 7:30 AM · Restricted Project, Restricted Project
huntergr updated the diff for D136251: [LoopVectorize] Use available masked vector functions when required.

Rebased, made requested changes.

Feb 28 2023, 7:29 AM · Restricted Project, Restricted Project

Feb 27 2023

huntergr added inline comments to D134422: Scalarize calls to masked functions in LV.
Feb 27 2023, 8:27 AM · Restricted Project, Restricted Project
huntergr updated the diff for D134422: Scalarize calls to masked functions in LV.

Rebased, amended patch per review comments.

Feb 27 2023, 8:21 AM · Restricted Project, Restricted Project

Feb 14 2023

huntergr committed rG0fa5df1959fa: [LV] Synthesize all true masks for masked vector function variants (authored by huntergr).
[LV] Synthesize all true masks for masked vector function variants
Feb 14 2023, 6:52 AM · Restricted Project, Restricted Project
huntergr closed D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.
Feb 14 2023, 6:52 AM · Restricted Project, Restricted Project

Feb 2 2023

huntergr updated the diff for D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

Rebased, addressed latest requests.

Feb 2 2023, 3:25 AM · Restricted Project, Restricted Project

Jan 18 2023

huntergr added inline comments to D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.
Jan 18 2023, 7:58 AM · Restricted Project, Restricted Project
huntergr updated the diff for D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

Rebased, changed as requested.

Jan 18 2023, 7:50 AM · Restricted Project, Restricted Project

Dec 6 2022

huntergr added a comment to D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

Ping?

Dec 6 2022, 7:04 AM · Restricted Project, Restricted Project

Nov 25 2022

huntergr updated the diff for D136251: [LoopVectorize] Use available masked vector functions when required.

Tidied up hasMaskedVariant as requested.

Nov 25 2022, 3:50 AM · Restricted Project, Restricted Project
huntergr updated the diff for D136251: [LoopVectorize] Use available masked vector functions when required.

Rebased on top of the latest version of D132458, which incorporates the vector function into the vplan recipe instead of looking it up again.

Nov 25 2022, 2:31 AM · Restricted Project, Restricted Project

Nov 24 2022

huntergr updated the diff for D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

Updated to store the pointer to the vector function in the recipe rather than looking it up again during recipe execution. Forced generation of a plan per VF when there are variants available for those VFs. Added some new tests for masked vs. unmasked variants.

Nov 24 2022, 3:20 AM · Restricted Project, Restricted Project

Oct 19 2022

huntergr requested review of D136251: [LoopVectorize] Use available masked vector functions when required.
Oct 19 2022, 5:34 AM · Restricted Project, Restricted Project

Oct 13 2022

huntergr added inline comments to D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.
Oct 13 2022, 2:29 AM · Restricted Project, Restricted Project

Oct 11 2022

huntergr added a comment to D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

@reames -- is this roughly what you expected for the case of allowing a masked variant to be used when no mask is required? I've added a cost for generating the mask (per-call for now, instead of potentially sharing it) so that we can compare costs for different VFs with and without a masked variant, but I think we would always prefer the non-masked variant for the same VF if a mask is not required.

Oct 11 2022, 6:01 AM · Restricted Project, Restricted Project

Sep 22 2022

huntergr requested review of D134422: Scalarize calls to masked functions in LV.
Sep 22 2022, 2:16 AM · Restricted Project, Restricted Project

Sep 21 2022

huntergr committed rG7b420a4a8b40: [NFC][LV] Scalarizing test for masked vector calls (authored by huntergr).
[NFC][LV] Scalarizing test for masked vector calls
Sep 21 2022, 7:45 AM · Restricted Project, Restricted Project
huntergr added inline comments to D133020: [LAA] Fix ICE with scAddExpr in forked pointers.
Sep 21 2022, 2:31 AM · Restricted Project, Restricted Project
huntergr committed rG3c74ed9ee323: [LAA] Fix ICE with scAddExpr in forked pointers (authored by huntergr).
[LAA] Fix ICE with scAddExpr in forked pointers
Sep 21 2022, 2:29 AM · Restricted Project, Restricted Project
huntergr closed D133020: [LAA] Fix ICE with scAddExpr in forked pointers.
Sep 21 2022, 2:29 AM · Restricted Project, Restricted Project

Sep 13 2022

huntergr added a comment to D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

Thanks for the review. I'm tempted to add a masking equivalent to -force-target-supports-scalable-vectors=true in order to have target-independent tests, but I can add that in another patch.

Sep 13 2022, 2:09 AM · Restricted Project, Restricted Project
huntergr updated the diff for D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.

Split out the functionality for synthesizing a mask when required, added a cost for mask generation.

Sep 13 2022, 2:04 AM · Restricted Project, Restricted Project

Sep 9 2022

huntergr committed rG1f639d1bd2f2: [NFC][LV] Convert masked call tests to use update script (authored by huntergr).
[NFC][LV] Convert masked call tests to use update script
Sep 9 2022, 2:13 AM · Restricted Project, Restricted Project

Sep 7 2022

huntergr updated the diff for D133020: [LAA] Fix ICE with scAddExpr in forked pointers.

Changed test to use a non-constant-zero loop limit to remove UB.

Sep 7 2022, 7:43 AM · Restricted Project, Restricted Project

Aug 31 2022

huntergr added inline comments to D133020: [LAA] Fix ICE with scAddExpr in forked pointers.
Aug 31 2022, 8:15 AM · Restricted Project, Restricted Project
huntergr updated the diff for D133020: [LAA] Fix ICE with scAddExpr in forked pointers.

Simplified the value names in the test case to improve readability.

Aug 31 2022, 8:14 AM · Restricted Project, Restricted Project
huntergr added inline comments to D133020: [LAA] Fix ICE with scAddExpr in forked pointers.
Aug 31 2022, 7:35 AM · Restricted Project, Restricted Project
huntergr requested review of D133020: [LAA] Fix ICE with scAddExpr in forked pointers.
Aug 31 2022, 7:09 AM · Restricted Project, Restricted Project

Aug 30 2022

huntergr added a comment to D108699: [LAA] Analyze pointers forked by a select.

https://github.com/llvm/llvm-project/issues/57368 is an open bug report describing a regression from this patch.

Aug 30 2022, 1:26 AM · Restricted Project, Restricted Project

Aug 23 2022

huntergr requested review of D132458: [LoopVectorize] Synthesize mask operands for vector variants as needed.
Aug 23 2022, 3:45 AM · Restricted Project, Restricted Project
huntergr committed rG14212c968fcd: [NFC][LoopVectorize] Precommit masked vector function call tests (authored by huntergr).
[NFC][LoopVectorize] Precommit masked vector function call tests
Aug 23 2022, 2:06 AM · Restricted Project, Restricted Project

Aug 17 2022

huntergr added inline comments to D130278: [LAA] Handle forked pointers with add/sub instructions.
Aug 17 2022, 2:01 AM · Restricted Project, Restricted Project
huntergr committed rG70d35443dc8f: [LAA] Handle forked pointers with add/sub instructions (authored by huntergr).
[LAA] Handle forked pointers with add/sub instructions
Aug 17 2022, 1:52 AM · Restricted Project, Restricted Project
huntergr closed D130278: [LAA] Handle forked pointers with add/sub instructions.
Aug 17 2022, 1:52 AM · Restricted Project, Restricted Project

Jul 22 2022

huntergr added a reviewer for D130278: [LAA] Handle forked pointers with add/sub instructions: paulwalker-arm.
Jul 22 2022, 2:18 AM · Restricted Project, Restricted Project

Jul 21 2022

huntergr requested review of D130278: [LAA] Handle forked pointers with add/sub instructions.
Jul 21 2022, 8:11 AM · Restricted Project, Restricted Project
huntergr committed rG0a715c114686: [LAA] Precommit add/sub tests for forked pointers (authored by huntergr).
[LAA] Precommit add/sub tests for forked pointers
Jul 21 2022, 7:17 AM · Restricted Project, Restricted Project

Jul 18 2022

huntergr added a comment to D108699: [LAA] Analyze pointers forked by a select.
In D108699#3659633, @ro wrote:

This patch broke the Solaris/amd64 and Solaris/sparcv9 builds:

/vol/llvm/src/llvm-project/dist/llvm/lib/Analysis/LoopAccessAnalysis.cpp: In function ‘llvm::SmallVector<std::pair<const llvm::SCEV*, bool> > findForkedPointer(llvm::PredicatedScalarEvolution&, const ValueToValueMap&, llvm::Value*, const llvm::Loop*)’:
/vol/llvm/src/llvm-project/dist/llvm/lib/Analysis/LoopAccessAnalysis.cpp:916:12: error: could not convert ‘Scevs’ from ‘SmallVector<[...],2>’ to ‘SmallVector<[...],3>’
  916 |     return Scevs;
      |            ^~~~~
      |            |
      |            SmallVector<[...],2>
Jul 18 2022, 6:51 AM · Restricted Project, Restricted Project
huntergr committed rGdb8fcb2c2537: [LAA] Add recursive IR walker for forked pointers (authored by huntergr).
[LAA] Add recursive IR walker for forked pointers
Jul 18 2022, 4:08 AM · Restricted Project, Restricted Project
huntergr closed D108699: [LAA] Analyze pointers forked by a select.
Jul 18 2022, 4:08 AM · Restricted Project, Restricted Project

Jul 14 2022

huntergr added inline comments to D108699: [LAA] Analyze pointers forked by a select.
Jul 14 2022, 1:14 AM · Restricted Project, Restricted Project
huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased on top of @fhahn 's fixed patch, including changes to detect possible undef/poison.

Jul 14 2022, 1:08 AM · Restricted Project, Restricted Project

Jul 13 2022

huntergr committed rGa19cf47da095: [LAA] Precommit some extra tests for forked pointers (authored by huntergr).
[LAA] Precommit some extra tests for forked pointers
Jul 13 2022, 2:34 AM · Restricted Project, Restricted Project

Jun 17 2022

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased on top of Florian's patch from https://reviews.llvm.org/D114487

Jun 17 2022, 2:15 AM · Restricted Project, Restricted Project

May 30 2022

huntergr added inline comments to D114174: [ARM][CodeGen] Add support for complex deinterleaving.
May 30 2022, 2:03 AM · Restricted Project, Restricted Project

May 4 2022

huntergr accepted D114487: [LAA] Support runtime checks for select GEP base pointers..

LGTM

May 4 2022, 1:42 AM · Restricted Project, Restricted Project

Apr 12 2022

huntergr added a comment to D108699: [LAA] Analyze pointers forked by a select.

Thanks for the update!

I think it would be good to split this up to have a first patch that just adds very limited support in findForkedSCEVs and then gradually add support for more cases separately. This also makes it easier to make sure all code paths in findForkedSCEVs are covered by the unit tests.

I went ahead and rebased D114487 and stripped the fork analysis to the bare minimum. I'd be happy to land the scaffolding in D114487 separately and this patch and following could add the sophisticated fork analysis.

Apr 12 2022, 5:32 AM · Restricted Project, Restricted Project

Apr 7 2022

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased. Ping?

Apr 7 2022, 1:47 AM · Restricted Project, Restricted Project

Mar 17 2022

Herald added a project to D119284: [IR] Add intrinsics to represent complex multiply and divide instructions.: Restricted Project.
Mar 17 2022, 3:05 AM · Restricted Project, Restricted Project

Mar 3 2022

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased, added a recursion limit to the SCEV building function.

Mar 3 2022, 2:19 AM · Restricted Project, Restricted Project

Feb 8 2022

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased and changed to use @fhahn 's lighter-weight approach from D114487 combined with my recursive function to find the SCEVs. Although the simplified tests are handled with a couple levels of checking, the real applications I was working on had additional operations between the ptr value for the load or store and a select.

Feb 8 2022, 2:09 AM · Restricted Project, Restricted Project

Nov 26 2021

huntergr added inline comments to D108699: [LAA] Analyze pointers forked by a select.
Nov 26 2021, 2:27 AM · Restricted Project, Restricted Project
huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Revised based on @fhahn 's initial suggestions, rebased.

Nov 26 2021, 2:22 AM · Restricted Project, Restricted Project

Nov 24 2021

huntergr committed rGdee810e117ad: [NFC][LAA] Precommit tests for forked pointers (authored by huntergr).
[NFC][LAA] Precommit tests for forked pointers
Nov 24 2021, 8:21 AM

Nov 22 2021

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased, disabled by default, added a couple of different instructions into the tests to ensure those paths are at least covered even if they aren't in a positive case right now; I'm still planning to leave those cases (known strides, g/s, uniform) for a followup patch; I suppose I could start a patch series if people want to see those earlier.

Nov 22 2021, 5:23 AM · Restricted Project, Restricted Project

Nov 17 2021

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased, and changed the membership of a checking group to be a pair of PointerInfo index and fork so that printing can show which forks are present in a group.

Nov 17 2021, 2:23 AM · Restricted Project, Restricted Project

Nov 10 2021

huntergr abandoned D109749: Experimental Partial Mem2Reg.

Superseded by @lebedev.ri 's patches. I'll continue looking at the metadata angle separately.

Nov 10 2021, 5:05 AM · Restricted Project

Nov 5 2021

huntergr updated the diff for D109749: Experimental Partial Mem2Reg.

Added the ability to look through GEPs for a call. I've limited this to using indexes of all 0, and only for single value types, so I'm not sure how often we'll encounter that. The limitation on the indexes does match the existing checks for whether promotion is allowed.

Nov 5 2021, 3:46 AM · Restricted Project

Nov 2 2021

huntergr added a comment to D109749: Experimental Partial Mem2Reg.
Nov 2 2021, 3:46 AM · Restricted Project
huntergr added a comment to D109749: Experimental Partial Mem2Reg.

Does this work for you:

diff --git a/llvm/lib/Analysis/CaptureTracking.cpp b/llvm/lib/Analysis/CaptureTracking.cpp
index 8955658cb9e7..41251d2676e6 100644
--- a/llvm/lib/Analysis/CaptureTracking.cpp
+++ b/llvm/lib/Analysis/CaptureTracking.cpp
@@ -373,9 +373,13 @@ void llvm::PointerMayBeCaptured(const Value *V, CaptureTracker *Tracker,
     case Instruction::Store:
       // Stored the pointer - conservatively assume it may be captured.
       // Volatile stores make the address observable.
-      if (U->getOperandNo() == 0 || cast<StoreInst>(I)->isVolatile())
+      if (U->getOperandNo() == 0 || cast<StoreInst>(I)->isVolatile()) {
+        if (auto *AI = dyn_cast<AllocaInst>(I->getOperand(1)->stripInBoundsOffsets()))
+          if (AI->hasMetadata("nocapture_storage"))
+            break;
         if (Tracker->captured(U))
           return;
+      }
       break;
     case Instruction::AtomicRMW: {
       // atomicrmw conceptually includes both a load and store from

And then add !nocapture_storage !0 after the alloca in your example as well as !0 = !{!0} in the end of that file

Ah, the 'nocapture_storage' metadata is what I've been missing, thanks. I'll update the diff once I've added that and adjusted the tests.

Technically, this is not yet something we have in the IR. We can reply to the old thread in which different solutions were discussed and
propose this one again. Then modify Clang to emit the metadata for the reduction case and land the diff I posted. All that said, it works
for your case, right?

Nov 2 2021, 3:28 AM · Restricted Project
huntergr updated the diff for D109749: Experimental Partial Mem2Reg.

Updated the diff based on the suggestion from @lebedev.ri

Nov 2 2021, 3:26 AM · Restricted Project

Oct 21 2021

huntergr added a comment to D109749: Experimental Partial Mem2Reg.
  1. Although the address is loop invariant, the data isn't.

LICM does scalar promotion (controlled by -disable-licm-promotion), as in "promote memory location to register". It doesn't matter whether the value at the location is invariant. Whether this belongs into a pass called "Loop Invariant Code Motion" is a different question.

  1. For this loop in particular, the store is conditional so might never happen. We *could* add a second boolean reduction to determine whether or not to actually perform a store after the loop, but that's a bit more complicated than just letting mem2reg do what it should.

This patch adds another pass, not make mem2reg do it. LICM currently does not handle conditional control flow for scalar promotion, but it should require much less code to change that. See the use of isGuaranteedToExecute in llvm::promoteLoopAccessesToScalars.

Oct 21 2021, 9:14 AM · Restricted Project
huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased, minor fixes from review comments.

Oct 21 2021, 4:43 AM · Restricted Project, Restricted Project
huntergr added a comment to D109749: Experimental Partial Mem2Reg.

I have seen cases where this would be beneficial,
some of those are just due to lack of inlining, but not all.

I strongly believe this should be part of SROA,
it should analyze the alloca's ignoring captures,
and if it is otherwise promoteable, it should:

  1. duplicate the original alloca (only for simplicity, this is fine since we know the old alloca goes away)
  2. before each capture, load contents of the old alloca, and store it into new alloca
  3. after each capture, load contents of the new alloca, and store it into old alloca
  4. change captures to refer to the new alloca
  5. run AggLoadStoreRewriter on the new alloca - so that all the uses of old alloca we've just introduced are analyzeable by SROA
  6. proceed with normal handling of the old alloca - mem2reg will now succeed
Oct 21 2021, 2:18 AM · Restricted Project

Oct 20 2021

huntergr added a comment to D108699: [LAA] Analyze pointers forked by a select.

Ping.

Oct 20 2021, 5:39 AM · Restricted Project, Restricted Project

Oct 12 2021

huntergr added inline comments to D108699: [LAA] Analyze pointers forked by a select.
Oct 12 2021, 2:10 AM · Restricted Project, Restricted Project
huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased, updated based on review comments.

Oct 12 2021, 1:53 AM · Restricted Project, Restricted Project

Sep 14 2021

huntergr requested review of D109749: Experimental Partial Mem2Reg.
Sep 14 2021, 2:32 AM · Restricted Project

Sep 7 2021

huntergr added inline comments to D108699: [LAA] Analyze pointers forked by a select.
Sep 7 2021, 7:31 AM · Restricted Project, Restricted Project

Sep 6 2021

huntergr updated the diff for D108699: [LAA] Analyze pointers forked by a select.

Rebased, ran clang-format over the patch.

Sep 6 2021, 6:18 AM · Restricted Project, Restricted Project

Aug 25 2021

huntergr requested review of D108699: [LAA] Analyze pointers forked by a select.
Aug 25 2021, 6:04 AM · Restricted Project, Restricted Project

Jun 22 2021

huntergr committed rGa83ce95b0976: [clang] Remove unused capture in closure (authored by huntergr).
[clang] Remove unused capture in closure
Jun 22 2021, 7:12 AM
huntergr added a comment to rGc6a91ee6aaaa: [Clang][OpenMP] Monotonic does not apply to SIMD.

I'm fixing up the buildbot failure - other parts of the repo (e.g. openmp) fail to build with -Werror so I don't normally use it.

Jun 22 2021, 3:18 AM
huntergr committed rGc6a91ee6aaaa: [Clang][OpenMP] Monotonic does not apply to SIMD (authored by huntergr).
[Clang][OpenMP] Monotonic does not apply to SIMD
Jun 22 2021, 2:25 AM
huntergr closed D103793: [Clang][OpenMP] Monotonic does not apply to SIMD.
Jun 22 2021, 2:25 AM · Restricted Project

Jun 17 2021

huntergr added a comment to D103793: [Clang][OpenMP] Monotonic does not apply to SIMD.

Ping.

Jun 17 2021, 6:48 AM · Restricted Project

Jun 7 2021

huntergr added a comment to D103793: [Clang][OpenMP] Monotonic does not apply to SIMD.

Apologies for not including more of the diff for context, but the test files are large enough that the full diff exceeds the maximum upload size.

Jun 7 2021, 1:46 AM · Restricted Project
huntergr requested review of D103793: [Clang][OpenMP] Monotonic does not apply to SIMD.
Jun 7 2021, 1:44 AM · Restricted Project

Mar 4 2020

huntergr added a comment to D75594: [AArch64] Add support for Fujitsu A64FX.

Looks good, I agree with @dmgreen that a clang driver test would be nice.

Mar 4 2020, 7:19 AM · Restricted Project, Restricted Project

Mar 2 2020

huntergr committed rGad497658d25a: [OpenMP] Allow const parameters in declare simd linear clause (authored by huntergr).
[OpenMP] Allow const parameters in declare simd linear clause
Mar 2 2020, 6:57 AM
huntergr closed D75350: [OpenMP] Allow const parameters in declare simd linear clause.
Mar 2 2020, 6:57 AM · Restricted Project
huntergr updated the diff for D75350: [OpenMP] Allow const parameters in declare simd linear clause.
  • Removed the ) my editor helpfully added to the CHECK line
  • Added a test to declare_simd_aarch64.c
Mar 2 2020, 6:16 AM · Restricted Project

Feb 28 2020

huntergr updated the diff for D75350: [OpenMP] Allow const parameters in declare simd linear clause.
  • Added a function body to the test so that it would generate symbols
  • Added check lines to ensure the mangled name is present
  • Reformatted the params of Sema::CheckOpenMPLinearDecl to comply with coding style.
Feb 28 2020, 9:37 AM · Restricted Project
huntergr added inline comments to D75350: [OpenMP] Allow const parameters in declare simd linear clause.
Feb 28 2020, 7:17 AM · Restricted Project
huntergr created D75350: [OpenMP] Allow const parameters in declare simd linear clause.
Feb 28 2020, 6:39 AM · Restricted Project

Jan 23 2020

huntergr abandoned D47779: [AArch64][SVE] Implement copying for Z registers.

Superseded by D66302

Jan 23 2020, 6:57 AM
huntergr abandoned D47771: [AArch64][SVE] Scalable arguments and returns passed in Z regs.

Superseded by D65448

Jan 23 2020, 6:48 AM