Page MenuHomePhabricator

dang (Daniel Grumberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2018, 4:28 PM (245 w, 6 d)

Recent Activity

Tue, May 30

dang committed rG06ff9770477d: [clang][ExtractAPI] Refactor serializer to the CRTP (authored by evelez7).
[clang][ExtractAPI] Refactor serializer to the CRTP
Tue, May 30, 11:02 AM · Restricted Project, Restricted Project
dang closed D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.
Tue, May 30, 11:02 AM · Restricted Project, Restricted Project
dang accepted D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.
Tue, May 30, 7:29 AM · Restricted Project, Restricted Project
dang accepted D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset..
Tue, May 30, 7:27 AM · Restricted Project, Restricted Project

Fri, May 26

dang added a comment to D151477: [clang][ExtractAPI] Refactor serializer to the CRTP.

LGTM with minor changes

Fri, May 26, 8:12 AM · Restricted Project, Restricted Project

Wed, May 24

dang requested changes to D151293: [clang][ExtractAPI] Refactor serializer to the CRTP.

Great start but there are still some rough edges to polish!

Wed, May 24, 2:28 AM · Restricted Project, Restricted Project

Tue, May 23

dang requested changes to D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset..
Tue, May 23, 7:50 AM · Restricted Project, Restricted Project

Thu, May 4

dang accepted D149737: [clang][ExtractAPI] Add semicolon to function declaration fragments.

LGTM

Thu, May 4, 6:44 AM · Restricted Project, Restricted Project

Apr 13 2023

dang committed rG3ac550984e83: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in… (authored by Ruturaj4).
[clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in…
Apr 13 2023, 9:56 AM · Restricted Project, Restricted Project
dang closed D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.
Apr 13 2023, 9:56 AM · Restricted Project, Restricted Project

Apr 11 2023

dang added inline comments to D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values.
Apr 11 2023, 4:46 AM · Restricted Project, Restricted Project

Apr 4 2023

dang accepted D146759: [ExtractAPI] Remove extra attributes in property declaration fragments.

LGTM

Apr 4 2023, 9:51 AM · Restricted Project, Restricted Project
dang added a comment to D146759: [ExtractAPI] Remove extra attributes in property declaration fragments.

Do we still have a test that ensures that actually writing the property attributes manually results in them being added to the declaration fragments?

Apr 4 2023, 7:55 AM · Restricted Project, Restricted Project

Mar 30 2023

dang committed rG142c3d9d1414: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements (authored by dang).
[clang][ExtractAPI] Reland ExtractAPI for libclang improvements
Mar 30 2023, 10:14 AM · Restricted Project, Restricted Project
dang closed D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.
Mar 30 2023, 10:14 AM · Restricted Project, Restricted Project
dang accepted D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id.
Mar 30 2023, 7:17 AM · Restricted Project, Restricted Project
dang added inline comments to D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.
Mar 30 2023, 7:07 AM · Restricted Project, Restricted Project
dang requested review of D147234: [clang][ExtractAPI] Reland ExtractAPI for libclang improvements.
Mar 30 2023, 7:06 AM · Restricted Project, Restricted Project
dang accepted D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.
Mar 30 2023, 5:59 AM · Restricted Project, Restricted Project

Mar 29 2023

dang committed rG1cfe1e732ad8: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang (authored by dang).
[clang][ExtractAPI] Add queried symbol to parent contexts in libclang
Mar 29 2023, 8:33 AM · Restricted Project, Restricted Project
dang closed D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang.
Mar 29 2023, 8:32 AM · Restricted Project, Restricted Project
dang added inline comments to D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id.
Mar 29 2023, 8:24 AM · Restricted Project, Restricted Project
dang added a reviewer for D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang: QuietMisdreavus.
Mar 29 2023, 8:16 AM · Restricted Project, Restricted Project
dang added a comment to D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

You will need to rebase this as I made some changes recently to how ExtractAPIVisitor is structured. We can either set up a time to talk about it and do it together or I can handle doing this work once we are happy with this.

Mar 29 2023, 8:15 AM · Restricted Project, Restricted Project
dang requested review of D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang.
Mar 29 2023, 4:06 AM · Restricted Project, Restricted Project
dang added a reverting change for rG158a431227a8: Revert ExtractAPI from https://reviews.llvm.org/D146656: rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656".
Mar 29 2023, 2:52 AM · Restricted Project, Restricted Project
dang committed rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656" (authored by dang).
Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"
Mar 29 2023, 2:52 AM · Restricted Project, Restricted Project

Mar 27 2023

dang committed rG158a431227a8: Revert ExtractAPI from https://reviews.llvm.org/D146656 (authored by dang).
Revert ExtractAPI from https://reviews.llvm.org/D146656
Mar 27 2023, 2:13 PM · Restricted Project, Restricted Project
dang committed rG21750a1ae8c8: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible (authored by dang).
[clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible
Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project
dang committed rGd0dd151eed4b: Address code review feedback (authored by dang).
Address code review feedback
Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project
dang committed rGea35740e7e18: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible (authored by dang).
[clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible
Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project
dang closed D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.
Mar 27 2023, 9:24 AM · Restricted Project, Restricted Project

Mar 24 2023

dang added a comment to D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

LGTM for the ExtractAPIVisitor part.
Remaining:

  • update test with @LINE
  • the libclang side
Mar 24 2023, 10:30 AM · Restricted Project, Restricted Project
dang added inline comments to D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.
Mar 24 2023, 3:38 AM · Restricted Project, Restricted Project

Mar 23 2023

dang accepted D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id.

Yup looks fine to me!

Mar 23 2023, 8:13 AM · Restricted Project, Restricted Project
dang accepted D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id.

LGTM, but you should also check in the test that id still renders as expected.

Mar 23 2023, 4:43 AM · Restricted Project, Restricted Project
dang added a reviewer for D146671: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id: zixuw.
Mar 23 2023, 4:24 AM · Restricted Project, Restricted Project

Mar 22 2023

dang updated the diff for D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Adding back missing diffs.

Mar 22 2023, 4:25 PM · Restricted Project, Restricted Project
dang updated the diff for D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

Addressing code review feedback

Mar 22 2023, 4:24 PM · Restricted Project, Restricted Project
dang added inline comments to D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.
Mar 22 2023, 3:47 PM · Restricted Project, Restricted Project
dang added a reviewer for D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible: arphaman.
Mar 22 2023, 12:18 PM · Restricted Project, Restricted Project
dang requested review of D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.
Mar 22 2023, 12:17 PM · Restricted Project, Restricted Project

Mar 20 2023

dang committed rGafce10c5b60f: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration… (authored by chaitanyav).
[clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration…
Mar 20 2023, 8:43 AM · Restricted Project, Restricted Project
dang closed D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments.
Mar 20 2023, 8:43 AM · Restricted Project, Restricted Project
dang accepted D146354: [clang][ExtractAPI] Add semicolons for enum, typedef, struct declaration fragments.

LGTM! I think it's fine to go ahead and land this (premerge check are not a requirement). Have you contributed to LLVM before? If not I will need to commit it on your behalf. Once that is done you should follow the instructions at https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to gain commit access if you wish to continue contributing to the project and LLVM in general.

Mar 20 2023, 7:09 AM · Restricted Project, Restricted Project
dang requested changes to D146385: [clang][ExtractAPI] Complete declaration fragments for TagDecl types defined in a typedef.

I think there might be some code missing here. Also can you add a test?

Mar 20 2023, 7:05 AM · Restricted Project, Restricted Project

Mar 13 2023

dang accepted D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.

LGTM once you fix the test

Mar 13 2023, 4:36 AM · Restricted Project, Restricted Project
dang added inline comments to D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.
Mar 13 2023, 4:35 AM · Restricted Project, Restricted Project
dang added inline comments to D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores.
Mar 13 2023, 3:26 AM · Restricted Project, Restricted Project

Mar 2 2023

dang committed rG65f7a84cf38b: [clang][ExtractAPI] Handle platform specific unavailability correctly (authored by Arsenic).
[clang][ExtractAPI] Handle platform specific unavailability correctly
Mar 2 2023, 7:51 AM · Restricted Project, Restricted Project
dang closed D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.
Mar 2 2023, 7:50 AM · Restricted Project, Restricted Project

Feb 28 2023

dang accepted D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

LGTM, It's worth noting that if the user specifies that an API is unavailable in a later redeclaration, this will be ignored. For example if I add a line to the test void e(void) __attribute__((availability(macos, unavailable))); it will be ignored. Up to you whether you want to fix it now or at a later date.

Feb 28 2023, 8:34 AM · Restricted Project, Restricted Project
dang added a comment to D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future.

I see a test checking for availability attribute already exists ( clang/test/ExtractAPI/availability.c ) would it be better if I update it with another function having a platform specific unavailability attribute or should I create a new test file ?

Feb 28 2023, 4:48 AM · Restricted Project, Restricted Project
dang requested changes to D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly.

Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future.

Feb 28 2023, 3:57 AM · Restricted Project, Restricted Project

Feb 10 2023

dang committed rG7da2d644e039: [clang] [extract-api] Don't crash for category in libclang APIs (authored by dang).
[clang] [extract-api] Don't crash for category in libclang APIs
Feb 10 2023, 8:31 AM · Restricted Project, Restricted Project
dang closed D142101: [clang] [extract-api] Don't crash for category in libclang APIs.
Feb 10 2023, 8:30 AM · Restricted Project, Restricted Project
dang committed rW5ca8701eaa6d: Add GSoC 2023 clang ExtractAPI projects (authored by dang).
Add GSoC 2023 clang ExtractAPI projects
Feb 10 2023, 7:27 AM · Restricted Project

Jan 24 2023

dang added a comment to D141961: [clang][lex] Pass hash location to more PPCallbacks methods.

LGTM for the ExtractAPI changes.

Jan 24 2023, 6:32 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

dang added inline comments to D142101: [clang] [extract-api] Don't crash for category in libclang APIs.
Jan 19 2023, 2:48 PM · Restricted Project, Restricted Project
dang added a reviewer for D142101: [clang] [extract-api] Don't crash for category in libclang APIs: bnbarham.
Jan 19 2023, 3:41 AM · Restricted Project, Restricted Project
dang updated the diff for D142101: [clang] [extract-api] Don't crash for category in libclang APIs.

Formatting fixes

Jan 19 2023, 3:38 AM · Restricted Project, Restricted Project
dang requested review of D142101: [clang] [extract-api] Don't crash for category in libclang APIs.
Jan 19 2023, 3:32 AM · Restricted Project, Restricted Project

Dec 16 2022

dang committed rG8dcb629aa4cc: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums (authored by dang).
[clang][ExtractAPI] Fix naming of typedef'd anonymous enums
Dec 16 2022, 3:01 AM · Restricted Project, Restricted Project
dang closed D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 16 2022, 3:01 AM · Restricted Project, Restricted Project

Dec 15 2022

dang added inline comments to D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 15 2022, 3:04 AM · Restricted Project, Restricted Project

Dec 14 2022

dang added inline comments to D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 14 2022, 10:45 AM · Restricted Project, Restricted Project
dang requested review of D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums.
Dec 14 2022, 4:15 AM · Restricted Project, Restricted Project

Dec 13 2022

dang committed rG7a85192166b5: [clang][ExtractAPI] Add support for single symbol SGF and libclang support (authored by dang).
[clang][ExtractAPI] Add support for single symbol SGF and libclang support
Dec 13 2022, 3:19 AM · Restricted Project, Restricted Project
dang closed D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 13 2022, 3:19 AM · Restricted Project, Restricted Project

Dec 12 2022

dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Rename new libclang APIs to make the names more readable.

Dec 12 2022, 6:32 AM · Restricted Project, Restricted Project
dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Rebase and fix clang format issue

Dec 12 2022, 6:23 AM · Restricted Project, Restricted Project

Dec 9 2022

dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Address code review feedback regarding libclang specific work.

Dec 9 2022, 4:30 PM · Restricted Project, Restricted Project
dang added inline comments to D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 9 2022, 2:44 PM · Restricted Project, Restricted Project

Dec 8 2022

dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Add comment explaining that the associated declaration in Declaration Fragments
is not intended to be used outside of libclang

Dec 8 2022, 1:29 AM · Restricted Project, Restricted Project

Dec 7 2022

dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Fix whitespace again

Dec 7 2022, 6:36 AM · Restricted Project, Restricted Project
dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Fix whitespace issues

Dec 7 2022, 6:26 AM · Restricted Project, Restricted Project
dang added inline comments to D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 7 2022, 5:37 AM · Restricted Project, Restricted Project
dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Fix code review feedback and ensure that all data is initialized before first
use.

Dec 7 2022, 5:35 AM · Restricted Project, Restricted Project

Dec 5 2022

dang updated the diff for D139115: [clang][ExtractAPI] Add support for single symbol SGF.

Removing some accidental unneeded includes that were tripping up CI.

Dec 5 2022, 11:16 AM · Restricted Project, Restricted Project

Dec 1 2022

dang requested review of D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 1 2022, 7:10 AM · Restricted Project, Restricted Project

Nov 7 2022

dang added a reverting change for rGf63db9159bbb: Only add targetFallback if target is not in defined in current product: rG39dbfa72aaeb: Revert "Only add targetFallback if target is not in defined in current product".
Nov 7 2022, 5:35 AM · Restricted Project, Restricted Project
dang committed rG39dbfa72aaeb: Revert "Only add targetFallback if target is not in defined in current product" (authored by dang).
Revert "Only add targetFallback if target is not in defined in current product"
Nov 7 2022, 5:35 AM · Restricted Project, Restricted Project
dang committed rGf63db9159bbb: Only add targetFallback if target is not in defined in current product (authored by dang).
Only add targetFallback if target is not in defined in current product
Nov 7 2022, 5:13 AM · Restricted Project, Restricted Project
dang committed rG671709f0e7d4: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph (authored by dang).
[clang][ExtractAPI] Add targetFallback to relationships in symbol graph
Nov 7 2022, 5:13 AM · Restricted Project, Restricted Project
dang closed D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph.
Nov 7 2022, 5:12 AM · Restricted Project, Restricted Project

Nov 3 2022

dang accepted D137338: Fix dupe word typos.
Nov 3 2022, 9:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 25 2022

dang committed rG791fe26d7581: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore (authored by dang).
[clang][ExtractAPI] Allow users to specify a list of symbols to ignore
Oct 25 2022, 3:46 AM · Restricted Project, Restricted Project
dang closed D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore.
Oct 25 2022, 3:46 AM · Restricted Project, Restricted Project
dang added a comment to D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph.

However, I am not sure it's worthwhile and we might run into edge cases doing it this way with explicitly ignored symbols.

Oct 25 2022, 2:33 AM · Restricted Project, Restricted Project

Oct 24 2022

dang added a comment to D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph.

Is it easy to/worth checking if the target is actually outside of the current module to keep the output smaller and concise?

Oct 24 2022, 10:47 AM · Restricted Project, Restricted Project

Oct 21 2022

dang requested review of D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph.
Oct 21 2022, 7:38 AM · Restricted Project, Restricted Project
dang requested review of D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore.
Oct 21 2022, 6:53 AM · Restricted Project, Restricted Project

Oct 13 2022

dang committed rGb6da16ffb9d5: [clang][ExtractAPI] Ignore fully anonymous RecordDecls (authored by dang).
[clang][ExtractAPI] Ignore fully anonymous RecordDecls
Oct 13 2022, 3:54 AM · Restricted Project, Restricted Project
dang closed D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls.
Oct 13 2022, 3:54 AM · Restricted Project, Restricted Project

Oct 12 2022

dang requested review of D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls.
Oct 12 2022, 11:55 AM · Restricted Project, Restricted Project

Oct 6 2022

dang accepted D134813: Properly print unnamed TagDecl objects in diagnostics.

With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed USR fix, the diff within ExtractAPI tests is only the wording with anonymous enums, and we can drop the lit change:

658c658
<             "spelling": "(anonymous)"
---
>             "spelling": "enum (unnamed)"
661c661
<         "title": "(anonymous)"
---
>         "title": "enum (unnamed)"
664c664
<         "(anonymous)"
---
>         "enum (unnamed)"
706c706
<         "(anonymous)",
---
>         "enum (unnamed)",
746c746
<             "spelling": "(anonymous)"
---
>             "spelling": "enum (unnamed)"
749c749
<         "title": "(anonymous)"
---
>         "title": "enum (unnamed)"
752c752
<         "(anonymous)"
---
>         "enum (unnamed)"
794c794
<         "(anonymous)",
---
>         "enum (unnamed)",

@dang @QuietMisdreavus for this change.

Oct 6 2022, 1:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 19 2022

dang committed rG57c9780d60b1: [clang][ExtractAPI] Record availability information on all platforms (authored by dang).
[clang][ExtractAPI] Record availability information on all platforms
Aug 19 2022, 2:55 PM · Restricted Project, Restricted Project
dang closed D130918: [clang][ExtractAPI] Record availability information on all platforms.
Aug 19 2022, 2:55 PM · Restricted Project, Restricted Project

Aug 2 2022

dang updated the diff for D130918: [clang][ExtractAPI] Record availability information on all platforms.

Remove doc comments in test

Aug 2 2022, 1:59 AM · Restricted Project, Restricted Project

Aug 1 2022

dang requested review of D130918: [clang][ExtractAPI] Record availability information on all platforms.
Aug 1 2022, 10:55 AM · Restricted Project, Restricted Project