User Details
- User Since
- Sep 13 2018, 4:28 PM (198 w, 18 h)
May 25 2022
May 16 2022
May 4 2022
LGTM! If I understand the issue correctly we gave llvm::Regex::match a string temporary to match against before and now we store it for long enough to process the match results?
Since this is a new test can we use the approach in https://reviews.llvm.org/D124634 to check for diagnostics output.
LGTM
May 3 2022
Minor comment LGTM otherwise
Apr 29 2022
LGTM!
Apr 28 2022
Apr 21 2022
Apr 19 2022
Apr 15 2022
Apr 13 2022
Apr 12 2022
Add a second anonymous enum to the test case to make sure that distinct symbols
are generated for both of them.
Address code review feedback:
Apr 11 2022
Address code review feedback.
Apr 8 2022
Add test to check that ObjC methods with multiple external parameters get the
correct name in subHeadings and navigator.
Apr 7 2022
LGTM
Rebase on top of latest changes.
LGTM thanks for spotting this!
Apr 6 2022
Rebase on top of latest changes.
Remove unnecessary include.
Make SymbolGraphSerializer::serializeAPIRecord const again.
Address code review feedback:
Address code review feedback.
Manage PatchComponents stack manipulation using RAII to avoid forgetting to pop
the stack when returning early from serializeAPIRecord.
Apr 5 2022
Add descriptive method names for manipulating the path component stack.
Address code review feedback:
Whitespace changes
LGTM!
Apr 4 2022
Doing it now!
Mar 31 2022
Mar 30 2022
@thakis I am UK based so I am logging off as it's 9pm over here. The fix I committed has fixed the issue on other buildbots that were failing due to this. If it still fails on Windows, would you be able to revert the change for me?
Committed a revert of the changes in that particular function in commit 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e
I have what should be a NFC fix that should fix the issue, just checking everything still works and will commit it.
Update with code review feedback and the rebased code.
Update using the correct patch this time around.
Rebase on top of latest changes
Mar 29 2022
Address review feedback.
LGTM!
Some errors slipped by when splitting this out of the macros patch.