Page MenuHomePhabricator

dang (Daniel Grumberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2018, 4:28 PM (198 w, 18 h)

Recent Activity

May 25 2022

dang committed rG504736cedff3: [clang][extract-api] Don't emit symbols prefixed with an underscore (authored by dang).
[clang][extract-api] Don't emit symbols prefixed with an underscore
May 25 2022, 11:03 AM · Restricted Project, Restricted Project
dang closed D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.
May 25 2022, 11:02 AM · Restricted Project, Restricted Project
dang added a comment to D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.

clang-format failed:

---  clang-format

changed files:

    clang/test/ExtractAPI/underscored.c

I think it's fine. clang-format always get tripped on split-file tests because of the mixed format and what not.

May 25 2022, 10:26 AM · Restricted Project, Restricted Project

May 16 2022

dang requested review of D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.
May 16 2022, 3:51 AM · Restricted Project, Restricted Project

May 4 2022

dang accepted D124964: Revert "Revert "[clang][extract-api] Use relative includes"".

LGTM! If I understand the issue correctly we gave llvm::Regex::match a string temporary to match against before and now we store it for long enough to process the match results?

May 4 2022, 2:49 PM · Restricted Project, Restricted Project
dang added a comment to D123831: [clang][extract-api] Use relative includes.

Since this is a new test can we use the approach in https://reviews.llvm.org/D124634 to check for diagnostics output.

May 4 2022, 3:35 AM · Restricted Project, Restricted Project
dang accepted D123831: [clang][extract-api] Use relative includes.

LGTM

May 4 2022, 2:15 AM · Restricted Project, Restricted Project

May 3 2022

dang accepted D123831: [clang][extract-api] Use relative includes.

Minor comment LGTM otherwise

May 3 2022, 8:53 AM · Restricted Project, Restricted Project

Apr 29 2022

dang accepted D124634: ExtractAPI: Use %clang_cc1 and -verify in enum.c.

LGTM!

Apr 29 2022, 5:11 AM · Restricted Project, Restricted Project

Apr 28 2022

dang added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 28 2022, 4:13 AM · Restricted Project, Restricted Project

Apr 21 2022

dang added a comment to D123831: [clang][extract-api] Use relative includes.

we might not always want to transform an absolute path because the resulting relative include name might get remapped in a headermap, for example in test known_files_only_hmap.c. But how does it work with modules where we need relative includes? Is the setup in known_files_only_hmap even valid?

I think, in most cases, this shouldn't matter because if the header path input doesn't match the location stored in the header map, they should still have the same source content. The same should be true with header search resolution with modules & vfsoverlay

Agreed, I think it would be classified as a user error to remap to different source content via headermap.

This is happening today in Xcode. Headers that are mapped from the DSTROOT back to the SRCROOT can be different, because they are not simply copied. Xcode also runs unifdef on them.

Apr 21 2022, 6:57 AM · Restricted Project, Restricted Project

Apr 19 2022

dang added a comment to D123831: [clang][extract-api] Use relative includes.

we might not always want to transform an absolute path because the resulting relative include name might get remapped in a headermap, for example in test known_files_only_hmap.c. But how does it work with modules where we need relative includes? Is the setup in known_files_only_hmap even valid?

I think, in most cases, this shouldn't matter because if the header path input doesn't match the location stored in the header map, they should still have the same source content. The same should be true with header search resolution with modules & vfsoverlay

Apr 19 2022, 5:48 AM · Restricted Project, Restricted Project

Apr 15 2022

dang added inline comments to D123831: [clang][extract-api] Use relative includes.
Apr 15 2022, 12:33 AM · Restricted Project, Restricted Project

Apr 13 2022

dang committed rG7443a504bf6c: [clang][extract-api] Add support for true anonymous enums (authored by dang).
[clang][extract-api] Add support for true anonymous enums
Apr 13 2022, 2:32 PM · Restricted Project, Restricted Project
dang closed D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 13 2022, 2:31 PM · Restricted Project, Restricted Project

Apr 12 2022

dang updated the diff for D123533: [clang][extract-api] Add support for true anonymous enums.

Add a second anonymous enum to the test case to make sure that distinct symbols
are generated for both of them.

Apr 12 2022, 10:52 AM · Restricted Project, Restricted Project
dang added inline comments to D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 12 2022, 3:21 AM · Restricted Project, Restricted Project
dang updated the diff for D123533: [clang][extract-api] Add support for true anonymous enums.

Address code review feedback:

Apr 12 2022, 3:20 AM · Restricted Project, Restricted Project

Apr 11 2022

dang requested review of D123533: [clang][extract-api] Add support for true anonymous enums.
Apr 11 2022, 11:54 AM · Restricted Project, Restricted Project
dang committed rG236b6a0eb41a: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods. (authored by dang).
[clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.
Apr 11 2022, 11:08 AM · Restricted Project, Restricted Project
dang closed D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 11 2022, 11:07 AM · Restricted Project, Restricted Project
dang added inline comments to D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 11 2022, 10:29 AM · Restricted Project, Restricted Project
dang added inline comments to D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 11 2022, 8:09 AM · Restricted Project, Restricted Project
dang updated the diff for D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..

Address code review feedback.

Apr 11 2022, 8:02 AM · Restricted Project, Restricted Project

Apr 8 2022

dang committed rG80ae36659292: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph (authored by dang).
[clang][extract-api] Emit "navigator" property of "name" in SymbolGraph
Apr 8 2022, 9:29 AM · Restricted Project, Restricted Project
dang closed D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.
Apr 8 2022, 9:29 AM · Restricted Project, Restricted Project
dang updated the diff for D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.

Add test to check that ObjC methods with multiple external parameters get the
correct name in subHeadings and navigator.

Apr 8 2022, 8:44 AM · Restricted Project, Restricted Project
dang requested review of D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.
Apr 8 2022, 7:59 AM · Restricted Project, Restricted Project

Apr 7 2022

dang committed rG101559225189: [clang][extract-api][NFC] Use dedicated API to check for macro equality (authored by dang).
[clang][extract-api][NFC] Use dedicated API to check for macro equality
Apr 7 2022, 11:11 AM · Restricted Project, Restricted Project
dang closed D123295: [clang][extract-api] Use dedicated API to check for macro equality.
Apr 7 2022, 11:11 AM · Restricted Project, Restricted Project
dang committed rGaebe5fc6e7d8: [clang][extract-api] Process only APIs declared in inputs (authored by dang).
[clang][extract-api] Process only APIs declared in inputs
Apr 7 2022, 9:56 AM · Restricted Project, Restricted Project
dang closed D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 7 2022, 9:56 AM · Restricted Project, Restricted Project
dang accepted D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.

LGTM

Apr 7 2022, 6:08 AM · Restricted Project, Restricted Project
dang requested review of D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods..
Apr 7 2022, 6:01 AM · Restricted Project, Restricted Project
dang requested review of D123295: [clang][extract-api] Use dedicated API to check for macro equality.
Apr 7 2022, 3:18 AM · Restricted Project, Restricted Project
dang updated the diff for D123148: [clang][extract-api] Process only APIs declared in inputs.

Rebase on top of latest changes.

Apr 7 2022, 2:46 AM · Restricted Project, Restricted Project
dang accepted D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.

LGTM thanks for spotting this!

Apr 7 2022, 2:08 AM · Restricted Project, Restricted Project

Apr 6 2022

dang committed rG9fc45ca00a19: [clang][extract-api] Add support for typedefs (authored by dang).
[clang][extract-api] Add support for typedefs
Apr 6 2022, 11:17 AM · Restricted Project, Restricted Project
dang closed D123019: [clang][extract-api] Add support for typedefs.
Apr 6 2022, 11:16 AM · Restricted Project, Restricted Project
dang updated the diff for D123019: [clang][extract-api] Add support for typedefs.

Rebase on top of latest changes.

Apr 6 2022, 11:07 AM · Restricted Project, Restricted Project
dang committed rG28d793144f2a: [clang][extract-api] Fix small issues with SymbolGraphSerializer (authored by dang).
[clang][extract-api] Fix small issues with SymbolGraphSerializer
Apr 6 2022, 10:46 AM · Restricted Project, Restricted Project
dang closed D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 6 2022, 10:46 AM · Restricted Project, Restricted Project
dang updated the diff for D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Remove unnecessary include.

Apr 6 2022, 10:23 AM · Restricted Project, Restricted Project
dang updated the diff for D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Make SymbolGraphSerializer::serializeAPIRecord const again.

Apr 6 2022, 8:26 AM · Restricted Project, Restricted Project
dang added inline comments to D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 6 2022, 8:20 AM · Restricted Project, Restricted Project
dang updated the diff for D123148: [clang][extract-api] Process only APIs declared in inputs.

Address code review feedback:

Apr 6 2022, 8:17 AM · Restricted Project, Restricted Project
dang updated the diff for D123019: [clang][extract-api] Add support for typedefs.

Address code review feedback.

Apr 6 2022, 3:52 AM · Restricted Project, Restricted Project
dang added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 6 2022, 3:40 AM · Restricted Project, Restricted Project
dang updated the diff for D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Manage PatchComponents stack manipulation using RAII to avoid forgetting to pop
the stack when returning early from serializeAPIRecord.

Apr 6 2022, 3:38 AM · Restricted Project, Restricted Project

Apr 5 2022

dang updated the diff for D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Add descriptive method names for manipulating the path component stack.

Apr 5 2022, 12:10 PM · Restricted Project, Restricted Project
dang requested review of D123148: [clang][extract-api] Process only APIs declared in inputs.
Apr 5 2022, 11:55 AM · Restricted Project, Restricted Project
dang updated the diff for D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

Address code review feedback:

Apr 5 2022, 4:42 AM · Restricted Project, Restricted Project
dang added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 5 2022, 3:53 AM · Restricted Project, Restricted Project
dang updated the diff for D123019: [clang][extract-api] Add support for typedefs.

Whitespace changes

Apr 5 2022, 3:49 AM · Restricted Project, Restricted Project
dang added inline comments to D123019: [clang][extract-api] Add support for typedefs.
Apr 5 2022, 3:48 AM · Restricted Project, Restricted Project
dang committed rG8b63622b9fd9: [clang][extract-api] Undefining macros should not result in a crash (authored by dang).
[clang][extract-api] Undefining macros should not result in a crash
Apr 5 2022, 3:43 AM · Restricted Project, Restricted Project
dang closed D123056: [clang][extract-api] Undefining macros should not result in a crash.
Apr 5 2022, 3:43 AM · Restricted Project, Restricted Project
dang added a comment to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them, the last thing i can spot that's "off" is that the "function signature" is currently being serialized under a parameters field instead of the required functionSignature.

Hmm, I was looking at the format specification at https://github.com/apple/swift-docc-symbolkit/blob/0a45209833f4a151212c1aa38e13cfc03b9462e4/openapi.yaml#L307, and I searched the term functionSignature in the spec but found no property with that name (except for the FunctionSignature schema that the parameters property is referring to). But anyway this should be a easy fix.

It seems like the specification and implementation have diverged. The parser in swift-docc-symbolkit is looking for a functionSignature field by virtue of how it names its "coding key". By comparison, here is the functionSignature emitter in the Swift symbol-graph generator.

Apr 5 2022, 3:18 AM · Restricted Project, Restricted Project
dang accepted D122774: [clang][extract-api] Add Objective-C Category support.

LGTM!

Apr 5 2022, 2:55 AM · Restricted Project, Restricted Project

Apr 4 2022

dang committed rG422d05e792db: [clang][extract-api][NFC] Add documentation (authored by dang).
[clang][extract-api][NFC] Add documentation
Apr 4 2022, 11:00 AM · Restricted Project, Restricted Project
dang closed D122798: [clang][extract-api][NFC] Add documentation.
Apr 4 2022, 11:00 AM · Restricted Project, Restricted Project
dang added a comment to D122798: [clang][extract-api][NFC] Add documentation.

Has this landed yet?

Doing it now!

Apr 4 2022, 10:59 AM · Restricted Project, Restricted Project
dang requested review of D123056: [clang][extract-api] Undefining macros should not result in a crash.
Apr 4 2022, 10:56 AM · Restricted Project, Restricted Project
dang requested review of D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 4 2022, 9:21 AM · Restricted Project, Restricted Project
dang retitled D123019: [clang][extract-api] Add support for typedefs from [WIP][clang][extract-api] Add support for typedefs to [clang][extract-api] Add support for typedefs.
Apr 4 2022, 5:54 AM · Restricted Project, Restricted Project
dang added inline comments to D122774: [clang][extract-api] Add Objective-C Category support.
Apr 4 2022, 5:32 AM · Restricted Project, Restricted Project
dang requested review of D123019: [clang][extract-api] Add support for typedefs.
Apr 4 2022, 3:54 AM · Restricted Project, Restricted Project

Mar 31 2022

dang requested review of D122798: [clang][extract-api][NFC] Add documentation.
Mar 31 2022, 3:38 AM · Restricted Project, Restricted Project

Mar 30 2022

dang closed D122611: [clang][extract-api] Add support for macros.

529a0570f7e8c5144bd3ad057e43f00e3af58d1b

Mar 30 2022, 1:28 PM · Restricted Project, Restricted Project
dang closed D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.

a9909d23e9bb8c4649cba1c14d479c28df4ca185

Mar 30 2022, 1:27 PM · Restricted Project, Restricted Project
dang added a comment to D122611: [clang][extract-api] Add support for macros.

@thakis I am UK based so I am logging off as it's 9pm over here. The fix I committed has fixed the issue on other buildbots that were failing due to this. If it still fails on Windows, would you be able to revert the change for me?

Mar 30 2022, 12:56 PM · Restricted Project, Restricted Project
dang added a comment to D122611: [clang][extract-api] Add support for macros.

Committed a revert of the changes in that particular function in commit 985eaa1a3da2a1b88ea70a65ffd5783aa82ea65e

Mar 30 2022, 12:41 PM · Restricted Project, Restricted Project
dang committed rG985eaa1a3da2: [clang][extract-api][NFC] Don't remap the generated input buffer in PPOpts (authored by dang).
[clang][extract-api][NFC] Don't remap the generated input buffer in PPOpts
Mar 30 2022, 12:39 PM · Restricted Project, Restricted Project
dang added a comment to D122611: [clang][extract-api] Add support for macros.

I have what should be a NFC fix that should fix the issue, just checking everything still works and will commit it.

Mar 30 2022, 12:33 PM · Restricted Project, Restricted Project
dang committed rG529a0570f7e8: [clang][extract-api] Add support for macros (authored by dang).
[clang][extract-api] Add support for macros
Mar 30 2022, 10:33 AM · Restricted Project, Restricted Project
dang committed rGa9909d23e9bb: [clang][extractapi] Tie API and serialization to the FrontendAction (authored by dang).
[clang][extractapi] Tie API and serialization to the FrontendAction
Mar 30 2022, 10:33 AM · Restricted Project, Restricted Project
dang updated the diff for D122611: [clang][extract-api] Add support for macros.

Update with code review feedback and the rebased code.

Mar 30 2022, 10:20 AM · Restricted Project, Restricted Project
dang added inline comments to D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.
Mar 30 2022, 10:19 AM · Restricted Project, Restricted Project
dang updated the diff for D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.

Update using the correct patch this time around.

Mar 30 2022, 10:19 AM · Restricted Project, Restricted Project
dang updated the diff for D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.

Rebase on top of latest changes

Mar 30 2022, 10:08 AM · Restricted Project, Restricted Project

Mar 29 2022

dang accepted D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 12:12 PM · Restricted Project, Restricted Project
dang updated the diff for D122611: [clang][extract-api] Add support for macros.

Address review feedback.

Mar 29 2022, 12:05 PM · Restricted Project, Restricted Project
dang added inline comments to D122611: [clang][extract-api] Add support for macros.
Mar 29 2022, 10:13 AM · Restricted Project, Restricted Project
dang accepted D122495: [clang][extract-api] Use correct language info from inputs.

LGTM!

Mar 29 2022, 10:03 AM · Restricted Project, Restricted Project
dang added inline comments to D122611: [clang][extract-api] Add support for macros.
Mar 29 2022, 9:47 AM · Restricted Project, Restricted Project
dang updated the diff for D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.

Some errors slipped by when splitting this out of the macros patch.

Mar 29 2022, 9:44 AM · Restricted Project, Restricted Project
dang requested changes to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 6:16 AM · Restricted Project, Restricted Project
dang added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 5:53 AM · Restricted Project, Restricted Project
dang requested review of D122648: [clang][extractapi] Tie API and serialization to the FrontendAction.
Mar 29 2022, 5:52 AM · Restricted Project, Restricted Project
dang added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 5:31 AM · Restricted Project, Restricted Project
dang accepted D122511: [clang][extract-api] Add Objective-C protocol support.
Mar 29 2022, 3:52 AM · Restricted Project, Restricted Project
dang added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 29 2022, 3:34 AM · Restricted Project, Restricted Project

Mar 28 2022

dang added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 28 2022, 2:02 PM · Restricted Project, Restricted Project
dang requested review of D122611: [clang][extract-api] Add support for macros.
Mar 28 2022, 1:50 PM · Restricted Project, Restricted Project
dang added inline comments to D122511: [clang][extract-api] Add Objective-C protocol support.
Mar 28 2022, 1:49 PM · Restricted Project, Restricted Project
dang added inline comments to D122446: [clang][extract-api] Add Objective-C interface support.
Mar 28 2022, 1:37 PM · Restricted Project, Restricted Project
dang added inline comments to D122495: [clang][extract-api] Use correct language info from inputs.
Mar 28 2022, 4:23 AM · Restricted Project, Restricted Project

Mar 24 2022

dang committed rG0ee06c31aa57: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator (authored by dang).
[clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator
Mar 24 2022, 10:45 AM · Restricted Project
dang closed D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator.
Mar 24 2022, 10:44 AM · Restricted Project, Restricted Project
dang added inline comments to D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator.
Mar 24 2022, 5:04 AM · Restricted Project, Restricted Project