User Details
- User Since
- Sep 13 2018, 4:28 PM (245 w, 6 d)
Tue, May 30
Fri, May 26
LGTM with minor changes
Wed, May 24
Great start but there are still some rough edges to polish!
Tue, May 23
Thu, May 4
LGTM
Apr 13 2023
Apr 11 2023
Apr 4 2023
LGTM
Do we still have a test that ensures that actually writing the property attributes manually results in them being added to the declaration fragments?
Mar 30 2023
Mar 29 2023
You will need to rebase this as I made some changes recently to how ExtractAPIVisitor is structured. We can either set up a time to talk about it and do it together or I can handle doing this work once we are happy with this.
Mar 27 2023
Mar 24 2023
Mar 23 2023
Yup looks fine to me!
LGTM, but you should also check in the test that id still renders as expected.
Mar 22 2023
Adding back missing diffs.
Addressing code review feedback
Mar 20 2023
LGTM! I think it's fine to go ahead and land this (premerge check are not a requirement). Have you contributed to LLVM before? If not I will need to commit it on your behalf. Once that is done you should follow the instructions at https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access to gain commit access if you wish to continue contributing to the project and LLVM in general.
I think there might be some code missing here. Also can you add a test?
Mar 13 2023
LGTM once you fix the test
Mar 2 2023
Feb 28 2023
LGTM, It's worth noting that if the user specifies that an API is unavailable in a later redeclaration, this will be ignored. For example if I add a line to the test void e(void) __attribute__((availability(macos, unavailable))); it will be ignored. Up to you whether you want to fix it now or at a later date.
Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future.
Feb 10 2023
Jan 24 2023
LGTM for the ExtractAPI changes.
Jan 19 2023
Formatting fixes
Dec 16 2022
Dec 15 2022
Dec 14 2022
Dec 13 2022
Dec 12 2022
Rename new libclang APIs to make the names more readable.
Rebase and fix clang format issue
Dec 9 2022
Address code review feedback regarding libclang specific work.
Dec 8 2022
Add comment explaining that the associated declaration in Declaration Fragments
is not intended to be used outside of libclang
Dec 7 2022
Fix whitespace again
Fix whitespace issues
Fix code review feedback and ensure that all data is initialized before first
use.
Dec 5 2022
Removing some accidental unneeded includes that were tripping up CI.
Dec 1 2022
Nov 7 2022
Nov 3 2022
Oct 25 2022
However, I am not sure it's worthwhile and we might run into edge cases doing it this way with explicitly ignored symbols.
Oct 24 2022
Oct 21 2022
Oct 13 2022
Oct 12 2022
Oct 6 2022
Aug 19 2022
Aug 2 2022
Remove doc comments in test