Page MenuHomePhabricator
People dang

dang (Daniel Grumberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 13 2018, 4:28 PM (144 w, 4 d)

Recent Activity
View All

Sep 3 2020

dang added a comment to D86290: Move all fields of '-cc1' option related classes into def file databases.

Yes of course. This is a prerequisite for some other changes that are waiting to land and need polishing. Thanks for doing the revert. I will investigate the failures and recommit it when appropriate.

Sep 3 2020, 10:22 AM · Restricted Project

Sep 2 2020

dang committed rGc4a2a1307484: Move all fields of '-cc1' option related classes into def file databases (authored by dang).
Move all fields of '-cc1' option related classes into def file databases
Sep 2 2020, 5:07 AM
dang closed D86290: Move all fields of '-cc1' option related classes into def file databases.
Sep 2 2020, 5:07 AM · Restricted Project

Aug 28 2020

dang updated the diff for D86290: Move all fields of '-cc1' option related classes into def file databases.

Apply clang-format nit and rebase

Aug 28 2020, 11:56 AM · Restricted Project

Aug 20 2020

dang requested review of D86290: Move all fields of '-cc1' option related classes into def file databases.
Aug 20 2020, 7:26 AM · Restricted Project

Aug 17 2020

dang added a comment to D82756: Port some floating point options to new option marshalling infrastructure.

Ping?

Aug 17 2020, 10:17 AM · Restricted Project, Restricted Project

Aug 5 2020

dang added inline comments to D82756: Port some floating point options to new option marshalling infrastructure.
Aug 5 2020, 10:40 AM · Restricted Project, Restricted Project

Jul 30 2020

dang updated the diff for D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system.

Remove accidental addition

Jul 30 2020, 1:18 AM · Restricted Project, Restricted Project

Jul 29 2020

dang updated the diff for D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo.

Ensure that the default value is assigned even if the option should not get
parsed.

Jul 29 2020, 8:36 AM · Restricted Project, Restricted Project

Jul 27 2020

dang added inline comments to D82756: Port some floating point options to new option marshalling infrastructure.
Jul 27 2020, 10:28 AM · Restricted Project, Restricted Project
Herald added projects to D84676: Add new diagnostic for invalid value provided for enum-based option: Restricted Project, Restricted Project.
Jul 27 2020, 10:03 AM · Restricted Project, Restricted Project
Herald added projects to D84675: [clang][cli] Streamline MarhsallingInfoFlag description: Restricted Project, Restricted Project.
Jul 27 2020, 10:01 AM · Restricted Project, Restricted Project
Herald added projects to D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo: Restricted Project, Restricted Project.
Jul 27 2020, 9:58 AM · Restricted Project, Restricted Project
Herald added projects to D84673: [clang][cli] Port DiagnosticOpts to new option parsing system: Restricted Project, Restricted Project.
Jul 27 2020, 9:57 AM · Restricted Project, Restricted Project
Herald added a project to D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system: Restricted Project.
Jul 27 2020, 9:56 AM · Restricted Project
Herald added projects to D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system: Restricted Project, Restricted Project.
Jul 27 2020, 9:56 AM · Restricted Project, Restricted Project
Herald added a project to D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system: Restricted Project.
Jul 27 2020, 9:54 AM · Restricted Project
Herald added a project to D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system: Restricted Project.
Jul 27 2020, 9:53 AM · Restricted Project
Herald added a project to D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system: Restricted Project.
Jul 27 2020, 9:50 AM · Restricted Project
dang updated the diff for D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system.

Update with latest changes

Jul 27 2020, 9:47 AM · Restricted Project, Restricted Project
dang abandoned D83405: Factor out EXTRACTOR call.
Jul 27 2020, 9:43 AM · Restricted Project
dang reclaimed D83405: Factor out EXTRACTOR call.
Jul 27 2020, 9:43 AM · Restricted Project
dang updated the diff for D83298: Add ability to make fixups to CompilerInvocation after option parsing.

Update with latest changes.

Jul 27 2020, 9:42 AM · Restricted Project
dang updated the diff for D83071: Add support for options with two flags for controlling the same field..

Update with latest changes

Jul 27 2020, 9:40 AM · Restricted Project, Restricted Project
dang abandoned D83695: Port Diagnostic option flags to new option parsing system.
Jul 27 2020, 9:36 AM · Restricted Project

Jul 20 2020

Herald added a project to D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system: Restricted Project.
Jul 20 2020, 10:05 AM · Restricted Project
Herald added projects to D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class: Restricted Project, Restricted Project.
Jul 20 2020, 10:05 AM · Restricted Project, Restricted Project
Herald added a project to D84188: [clang][cli] Port FileSystem options to new option parsing system: Restricted Project.
Jul 20 2020, 10:03 AM · Restricted Project
Herald added a project to D84187: [clang][cli] Port DependencyOutput string based options to new option parsing system: Restricted Project.
Jul 20 2020, 10:03 AM · Restricted Project
Herald added projects to D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system: Restricted Project, Restricted Project.
Jul 20 2020, 10:02 AM · Restricted Project, Restricted Project
Herald added projects to D84185: [clang][cli] Better defaults for MarshallingInfoString: Restricted Project, Restricted Project.
Jul 20 2020, 10:01 AM · Restricted Project, Restricted Project

Jul 18 2020

dang added inline comments to D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347).
Jul 18 2020, 8:54 AM · Restricted Project

Jul 17 2020

dang accepted D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347).
Jul 17 2020, 5:46 AM · Restricted Project
dang added inline comments to D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347).
Jul 17 2020, 5:46 AM · Restricted Project
Herald added a project to D84018: [clang][cli] Port Preprocessor and PreprocessorOutput option flags to new option parsing system: Restricted Project.
Jul 17 2020, 5:13 AM · Restricted Project
dang updated the diff for D83979: [clang][cli] Port LangOpts option flags to new option parsing system.

Fix formatting

Jul 17 2020, 5:11 AM · Restricted Project
dang added a comment to D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347).

Sorry about that. LGTM once you make a decision on my comments.

Jul 17 2020, 4:19 AM · Restricted Project

Jul 16 2020

Herald added a project to D83979: [clang][cli] Port LangOpts option flags to new option parsing system: Restricted Project.
Jul 16 2020, 12:35 PM · Restricted Project
dang added inline comments to rGe5158b52730d: [Driver] Migrate some -f/-fno options to use OptInFFlag and OptOutFFlag.
Jul 16 2020, 5:01 AM
Herald added a project to D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system: Restricted Project.
Jul 16 2020, 3:58 AM · Restricted Project

Jul 15 2020

Herald added a project to D83892: [clang][cli] Port CodeGen option flags to new option parsing system: Restricted Project.
Jul 15 2020, 11:08 AM · Restricted Project, Restricted Project
dang updated the diff for D83698: [clang][cli] Port Target option flags to new option parsing system.

Remove -triple that got duplicated

Jul 15 2020, 7:16 AM · Restricted Project
dang updated the diff for D83697: [clang][cli] Port Frontend option flags to new option parsing system.

Make sure that ast_dump_* are correctly labelled as belonging to Action_Group.

Jul 15 2020, 6:42 AM · Restricted Project, Restricted Project
dang updated the diff for D83695: Port Diagnostic option flags to new option parsing system.

Add back -pg option that was accidentaly removed.

Jul 15 2020, 2:12 AM · Restricted Project

Jul 13 2020

Herald added a project to D83698: [clang][cli] Port Target option flags to new option parsing system: Restricted Project.
Jul 13 2020, 10:15 AM · Restricted Project
Herald added a project to D83697: [clang][cli] Port Frontend option flags to new option parsing system: Restricted Project.
Jul 13 2020, 10:14 AM · Restricted Project, Restricted Project
Herald added a project to D83695: Port Diagnostic option flags to new option parsing system: Restricted Project.
Jul 13 2020, 10:13 AM · Restricted Project
Herald added a project to D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system: Restricted Project.
Jul 13 2020, 10:13 AM · Restricted Project, Restricted Project
Herald added a project to D83693: Port analyzer flags to new option parsing system: Restricted Project.
Jul 13 2020, 10:12 AM · Restricted Project
Herald added a project to D83691: Port Comment option flags to new parsing system: Restricted Project.
Jul 13 2020, 10:11 AM · Restricted Project
Herald added a project to D83690: Port Migator option flags to new option parsing system: Restricted Project.
Jul 13 2020, 10:10 AM · Restricted Project

Jul 11 2020

dang added inline comments to rG0555db0a5df4: Normalize default value for -triple correctly.
Jul 11 2020, 2:00 AM

Jul 10 2020

dang added a comment to D82574: Merge TableGen files used for clang options.

Sorry again, removed the offending options in a2cffb11e287

Jul 10 2020, 9:56 AM · Restricted Project
dang committed rGa2cffb11e287: Remove clang options that were added back when merging the TableGen files (authored by dang).
Remove clang options that were added back when merging the TableGen files
Jul 10 2020, 9:56 AM
dang added a comment to D82574: Merge TableGen files used for clang options.
In D82574#2144140, @jeroen.dobbelaere wrote:

I think that 'clang/include/clang/Driver/CC1Options.td' should also be removed ?

Jul 10 2020, 8:58 AM · Restricted Project
dang committed rG3607aacc5981: Delete CC1Options.td, since it should have happened in D82574 (authored by dang).
Delete CC1Options.td, since it should have happened in D82574
Jul 10 2020, 8:55 AM
dang added inline comments to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jul 10 2020, 6:24 AM · Restricted Project
dang added inline comments to D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support..
Jul 10 2020, 6:05 AM · Restricted Project
dang added inline comments to D82574: Merge TableGen files used for clang options.
Jul 10 2020, 5:59 AM · Restricted Project
dang committed rG0555db0a5df4: Normalize default value for -triple correctly (authored by dang).
Normalize default value for -triple correctly
Jul 10 2020, 5:59 AM
dang added inline comments to D82574: Merge TableGen files used for clang options.
Jul 10 2020, 5:31 AM · Restricted Project

Jul 9 2020

dang committed rG50f24331fd91: Add diagnostic option backing field for -fansi-escape-codes (authored by dang).
Add diagnostic option backing field for -fansi-escape-codes
Jul 9 2020, 11:28 PM
dang closed D82874: Add diagnostic option backing field for -fansi-escape-codes.
Jul 9 2020, 11:28 PM · Restricted Project
dang added a comment to D82574: Merge TableGen files used for clang options.

Yes I committed this a while ago, I duplicated all the functionality in Options.td.

Jul 9 2020, 10:09 PM · Restricted Project
dang committed rGfccd29dddee9: Merge TableGen files used for clang options (authored by dang).
Merge TableGen files used for clang options
Jul 9 2020, 10:30 AM
dang closed D82574: Merge TableGen files used for clang options.
Jul 9 2020, 10:30 AM · Restricted Project
dang planned changes to D83474: Add support for specifying only a denormalizer.
Jul 9 2020, 10:28 AM · Restricted Project, Restricted Project
Herald added projects to D83474: Add support for specifying only a denormalizer: Restricted Project, Restricted Project.
Jul 9 2020, 5:18 AM · Restricted Project, Restricted Project
dang added inline comments to D82756: Port some floating point options to new option marshalling infrastructure.
Jul 9 2020, 2:21 AM · Restricted Project, Restricted Project

Jul 8 2020

Herald added projects to D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead: Restricted Project, Restricted Project.
Jul 8 2020, 9:38 AM · Restricted Project, Restricted Project
dang updated the diff for D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).

Rebase on top of latest changes

Jul 8 2020, 9:37 AM · Restricted Project, Restricted Project
dang abandoned D83405: Factor out EXTRACTOR call.
Jul 8 2020, 9:36 AM · Restricted Project
Herald added a project to D83405: Factor out EXTRACTOR call: Restricted Project.
Jul 8 2020, 9:35 AM · Restricted Project
dang updated the diff for D83315: Turn arcmt-* options into a single option.

Instead of using a Separate option kind (-arcmt-action action) use a Joined kind (-arcmt-action=*)

Jul 8 2020, 7:55 AM · Restricted Project, Restricted Project
dang updated the diff for D83071: Add support for options with two flags for controlling the same field..

Split into two macro kinds.

Jul 8 2020, 6:09 AM · Restricted Project, Restricted Project

Jul 7 2020

Herald added projects to D83315: Turn arcmt-* options into a single option: Restricted Project, Restricted Project.
Jul 7 2020, 8:52 AM · Restricted Project, Restricted Project
dang updated the diff for D83298: Add ability to make fixups to CompilerInvocation after option parsing.

Move the UseANSIEscapeCodes fixup to the correct place.

Jul 7 2020, 5:16 AM · Restricted Project
dang updated the diff for D83071: Add support for options with two flags for controlling the same field..

Rebase on top of some changes to parent patches.

Jul 7 2020, 5:13 AM · Restricted Project, Restricted Project
dang updated the diff for D82860: Port ObjCMTAction to new option parsing system.

Make mergers use values directly instead of constant references.

Jul 7 2020, 5:12 AM · Restricted Project, Restricted Project
dang updated the diff for D83071: Add support for options with two flags for controlling the same field..

Make mergers use values directly instead of constant references

Jul 7 2020, 5:10 AM · Restricted Project, Restricted Project
Herald added a project to D83298: Add ability to make fixups to CompilerInvocation after option parsing: Restricted Project.
Jul 7 2020, 5:06 AM · Restricted Project

Jul 6 2020

dang added inline comments to D83071: Add support for options with two flags for controlling the same field..
Jul 6 2020, 10:12 AM · Restricted Project, Restricted Project
Herald added a project to D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC): Restricted Project.
Jul 6 2020, 4:26 AM · Restricted Project, Restricted Project
dang abandoned D83209: Factor out call to EXTRACTOR in generateCC1CommandLine.
Jul 6 2020, 3:48 AM · Restricted Project, Restricted Project
Herald added projects to D83209: Factor out call to EXTRACTOR in generateCC1CommandLine: Restricted Project, Restricted Project.
Jul 6 2020, 3:47 AM · Restricted Project, Restricted Project

Jul 5 2020

dang updated the diff for D83071: Add support for options with two flags for controlling the same field..

Address some code review feedback.

Jul 5 2020, 11:06 PM · Restricted Project, Restricted Project
dang added inline comments to D83071: Add support for options with two flags for controlling the same field..
Jul 5 2020, 11:05 PM · Restricted Project, Restricted Project
dang updated the diff for D83071: Add support for options with two flags for controlling the same field..

Revert accidental namespace removal.

Jul 5 2020, 10:21 PM · Restricted Project, Restricted Project

Jul 2 2020

dang created D83071: Add support for options with two flags for controlling the same field..
Jul 2 2020, 12:25 PM · Restricted Project, Restricted Project
dang updated the diff for D82874: Add diagnostic option backing field for -fansi-escape-codes.

Make the tablegen description of the new option more consistent with other flags.

Jul 2 2020, 12:25 PM · Restricted Project
dang updated the diff for D82860: Port ObjCMTAction to new option parsing system.

Ensure that mergeForwardValue can accept default values whose type doesn't quite match the associated keypath.

Jul 2 2020, 11:19 AM · Restricted Project, Restricted Project

Jul 1 2020

dang updated the diff for D82860: Port ObjCMTAction to new option parsing system.

Remove the need for the merger and extractor to be macros

Jul 1 2020, 3:44 AM · Restricted Project, Restricted Project

Jun 30 2020

dang updated the diff for D82874: Add diagnostic option backing field for -fansi-escape-codes.

Move the call to UseANSIEscapeCodes to CreateFromArgs

Jun 30 2020, 11:24 AM · Restricted Project
dang updated the summary of D82874: Add diagnostic option backing field for -fansi-escape-codes.
Jun 30 2020, 6:28 AM · Restricted Project
dang created D82874: Add diagnostic option backing field for -fansi-escape-codes.
Jun 30 2020, 6:28 AM · Restricted Project
dang updated the diff for D82860: Port ObjCMTAction to new option parsing system.

Denormalizer should also use the extractor

Jun 30 2020, 5:23 AM · Restricted Project, Restricted Project
dang created D82860: Port ObjCMTAction to new option parsing system.
Jun 30 2020, 4:18 AM · Restricted Project, Restricted Project
dang added inline comments to D82860: Port ObjCMTAction to new option parsing system.
Jun 30 2020, 4:18 AM · Restricted Project, Restricted Project

Jun 29 2020

dang added a reviewer for D82756: Port some floating point options to new option marshalling infrastructure: Anastasia.
Jun 29 2020, 10:32 PM · Restricted Project, Restricted Project
dang created D82756: Port some floating point options to new option marshalling infrastructure.
Jun 29 2020, 4:17 AM · Restricted Project, Restricted Project