- User Since
- Dec 10 2020, 9:54 PM (120 w, 1 d)
Fix the other typo
arc messed up
Nah, it is a typo in both places...
I don't understand what's going on.
Remove unnecessary -Werror.
It appears there is a typo in the use of COMPILER_RT_HAS_BUILTIN_FORMAT_SECURITY_FLAG:
append_list_if(COMPILER_RT_HAS_BUILTIN_FORMAL_SECURITY_FLAG -Werror=format-security flags)
FORMAL vs FORMAT.
This now breaks M68k build https://lab.llvm.org/buildbot#builders/192/builds/1022
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Mention "Reland" in the commit title
Drop changes to -ftrivial-auto-var-init causing build failures
Thu, Mar 30
I briefly glanced at other patches and can't review / accept them without good test coverage.
I like the idea, but the implementation looks more like a PoC than a complete solution.
There is clearly an overlap between RangeList and SliceElements and I don't see why they should be distinct.
I am not a TableGen expert so take my words with a grain of salt. I won't be able to review it well.
Maybe @nhaehnle could take a look?
Wed, Mar 29
Try to refine assertion message.
There seem to be an issue with tsan?
Tue, Mar 28
Abandoned in favor of D147093.
It crashes on the test from D146930.
__USER_LABEL_PREFIX__ is always defined. It is usually defined to nothing though, i.e. just
In this case the file compiles just fine. It does not compile if the prefix is non-empty, e.g.:
#define __USER_LABEL_PREFIX__ _
because it is just a token and not a string.
I don't know if it is valid for the label prefix to be non-empty on ELF platforms (and couldn't find an example),
but I don't see why it couldn't be.
Wait for D147093 resolution.
The prefix has only caused troubles; it will probably go away once I am able to build newlib using clang.
Fix another occurance
The commit message does not make it clear why this change is necessary.
(And the title does not tell anything at all.)
Does it try to solve the same problem as D146930?
Mon, Mar 27
IMHO .gitignore is for files that are strictly project-related. Everything else should go into local .git/info/exclude.
Half of the includes and forward declarations are unused.
I'm not familiar with the ABI to review this part.
However, manual handling of i1, i8, i16 and f32 looks suspicious, because they are all illegal.
Looks like a dead code to me, but I may be wrong.
Drop 'renamable' on the registers that are not really renamable.
Sun, Mar 26
Strip changes that are not necessary for fixing the bug.
They will be in a separate commit.
The change effectively disables BackwardCopyPropagateBlock that folded the first copy into
the preceding load, eliminating definition of s[60-67], which is necessary to reproduce the bug.
Add a positive test
This wont work as llvm-tblgen depends on MachineValueTypes.h.
I'm not sure this is the right thing to do. The regression was introduced in https://github.com/llvm/llvm-project/commit/f051c1ded40970169cda84b0966331ae7ad424ed
Update commit message
Fri, Mar 24
Wed, Mar 15
Thanks for the confirmation.
This still does not look right to me.
Shouldn't PASSTHROUGH_PREFIXES have just been removed in this invocation?
Sun, Mar 12
clang's unwind.h also gets installed and is found first when included from a source file (and it includes_next the libunwind's version, but only for apple platforms).
Not sure I understand the logic, may it be somehow related to the fact that clang driver supports different unwind libraries?
Either way, installing libunwind's header by default does not update clang's version, so the issue persists.
Feb 16 2023
LGTM, great job!
Update the comment
Feb 15 2023
Feb 10 2023
Feb 7 2023
I'm afraid this change will go unnoticed by build bots. They must be updated first, and a deprecation warning could help (before removing the support).
Feb 5 2023
Feb 2 2023
LGTM with one note
I can confirm that MTVRSAVEv change is the only non-comment change in the generated files.
Feb 1 2023
Jan 31 2023
I intent to make make InstAlias with "complex" operands (non-empty MIOperandInfo) more robust (stricter syntax). There is also a couple of bugs I'd like to fix.
The change will clobber most of the code here, and I thought it is a good time to move the class to a dedicated file.
Another weak point is that this class is only used in AsmMatcherEmitter and AsmWriterEmitter, while CodeGenInstruction.h is included everywhere.
The class does not have long history; there were only a few functional changes since initial commit.
Jan 30 2023
Keep both spellings