Page MenuHomePhabricator

kkwli0 (Kelvin Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2014, 8:03 PM (328 w, 4 d)

Recent Activity

Tue, Aug 25

kkwli0 added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

default(firstprivate) was added in https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a

Tue, Aug 25, 3:42 PM · Restricted Project
kkwli0 added a comment to D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x)..

present map type and motion modifier
default(firstprivate)

Tue, Aug 25, 3:28 PM · Restricted Project

Jun 30 2020

kkwli0 added inline comments to D79972: [OpenMP5.0] map item can be non-contiguous for target update.
Jun 30 2020, 1:03 PM · Restricted Project

Mar 14 2020

kkwli0 added a comment to D75001: [OpenMP][cmake] ignore warning on unknown CUDA version .

I like this way better. I was hoping we could do it in our cmake only :)

Give others a day or so to comment before your commit but I'm fine with this.

Well, that doesn't really work if openmp-commits is only subscribed on commit. That said, the solution is a bit ugly but I don't have an alternative right now.

What is the problem with openmp-commits here? I got the emails, didn't you?

@kkwli0 Where are we with this?

Mar 14 2020, 8:33 AM · Restricted Project

Feb 25 2020

kkwli0 abandoned D74571: [OpenMP][CUDA] Add CUDA 10.2 support.
Feb 25 2020, 3:14 PM
kkwli0 added a comment to D75001: [OpenMP][cmake] ignore warning on unknown CUDA version .
In D75001#1891966, @tra wrote:

@tra Will it also include -fopenmp-targets=nvptx64-nvidia-cuda?

If you're asking whether the warning will be disabled for OpenMP, then no. This OpenMP target appears to rely on CUDA, and I think all the reasons for the warning existence do still apply.
If you're asking about the workaround, it would only work for non-CUDA compilations that don't really need CUDA SDK, so the answer is probably 'no' as well as you will need a valid CUDA path.

Feb 25 2020, 12:22 PM · Restricted Project
kkwli0 added a comment to D75001: [OpenMP][cmake] ignore warning on unknown CUDA version .
In D75001#1891742, @tra wrote:

I like this way better. I was hoping we could do it in our cmake only :)

Give others a day or so to comment before your commit but I'm fine with this.

Well, that doesn't really work if openmp-commits is only subscribed on commit. That said, the solution is a bit ugly but I don't have an alternative right now.

Somewhat related, that means Clang issues a warning for every compilation should there be a "unsupported" CUDA version around, even if it's not used? @tra maybe we can only issue the warning if CUDA is going to be used?

This is a good point. It should only affect compilations done with -x cuda. I'll fix that.
Short-term workaround is to specify invalid path to CUDA installation with --cuda-path=/does/not/exist

Feb 25 2020, 11:05 AM · Restricted Project
kkwli0 added a comment to D75001: [OpenMP][cmake] ignore warning on unknown CUDA version .

Somewhat related, that means Clang issues a warning for every compilation should there be a "unsupported" CUDA version around, even if it's not used? @tra maybe we can only issue the warning if CUDA is going to be used?

Feb 25 2020, 9:22 AM · Restricted Project
kkwli0 committed rGe16e267bb6ee: [OpenMP][cmake] ignore warning on unknown CUDA version (authored by kkwli0).
[OpenMP][cmake] ignore warning on unknown CUDA version
Feb 25 2020, 6:30 AM
kkwli0 closed D75001: [OpenMP][cmake] ignore warning on unknown CUDA version .
Feb 25 2020, 6:30 AM · Restricted Project

Feb 21 2020

kkwli0 created D75001: [OpenMP][cmake] ignore warning on unknown CUDA version .
Feb 21 2020, 4:30 PM · Restricted Project
kkwli0 added a comment to D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing.

Since it is a TR8 feature, should we have this guarded by -fopenmp-version=?

Feb 21 2020, 2:20 PM · Restricted Project, Restricted Project
kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

So an alternative is to:

  • patch openmp/runtime/cmake/LibompCheckLinkerFlag.cmake to make the libomp_check_linker_flag function to ignore the "Unknown CUDA version" warning, AND
  • ask users to build with -DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version -DCMAKE_C_FLAGS=-Wno-unknown-cuda-version to get around the C_SUPPORTS_FPIC test in cmake/modules/HandleLLVMOptions.cmake if the system has CUDA10.2 installed.
Feb 21 2020, 1:25 PM
kkwli0 added inline comments to D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing.
Feb 21 2020, 1:15 PM · Restricted Project, Restricted Project
kkwli0 added inline comments to D74956: OpenMP 5.1 omp_display_env function implementation..
Feb 21 2020, 7:09 AM · Restricted Project

Feb 17 2020

kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

Summary

  • In order to avoid the bug in PR44587, one needs to build with >9.0.
  • With CUDA toolkit 10.2, building the trunk will fail because 10.0.0 does not support it yet.
Feb 17 2020, 8:05 AM

Feb 14 2020

kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

I am not sure I understand. Do we need to modify stuff outside of /openmp? I was hoping it is our CMake that can be adjusted to make this work as described earlier. TBH, he warning is even not my biggest problem. As long as we get a libomptarget.bc we should be fine.

Feb 14 2020, 12:31 PM
kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

It turns out that having the warning message also affects the C_SUPPORTS_FPIC test in cmake/modules/HandleLLVMOptions.cmake. As a result, cmake thinks that -fPIC is not supported. Eventually, it leads to error in libclang-cpp.so.

Feb 14 2020, 12:03 PM
kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

Thanks for all the comments. It makes sense to keep the warning there before any ptx65 features are added. The warning should also apply to both the CUDA and OpenMP compile paths. As a result, I will pursue to ignore the warning in the build of libomp (i.e. libomp_check_linker_flag function in LibompCheckLinkerFlag.cmake). I think it is less pervasive and also can avoid similar occurrence when a new version of CUDA toolkit is available.

Feb 14 2020, 8:59 AM

Feb 13 2020

kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

in order to avoid bug 44587 which requires >9.0.1 to be the build compiler?

Do we already require CUDA 10 as part of the libomptarget cmake (with a nice message) to avoid the errors you've seen? We for sure need to.

Feb 13 2020, 11:56 AM
kkwli0 added a comment to D74571: [OpenMP][CUDA] Add CUDA 10.2 support.

Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the same as whether it works but is the closest approximation we have available.

Assuming yes, this patch seems uncontroversial.

Feb 13 2020, 11:47 AM
kkwli0 updated the summary of D74571: [OpenMP][CUDA] Add CUDA 10.2 support.
Feb 13 2020, 11:10 AM
kkwli0 created D74571: [OpenMP][CUDA] Add CUDA 10.2 support.
Feb 13 2020, 11:10 AM

Feb 12 2020

kkwli0 committed rG4f1f2b7a5b57: [OpenMP] update strings output of libomp.so [NFC] (authored by kkwli0).
[OpenMP] update strings output of libomp.so [NFC]
Feb 12 2020, 12:52 PM
kkwli0 closed D74462: [OpenMP] update strings output of libomp.so [NFC].
Feb 12 2020, 12:52 PM · Restricted Project
kkwli0 retitled D74462: [OpenMP] update strings output of libomp.so [NFC] from [OpenMP] modify strings output in libomp.so [NFC} to [OpenMP] update strings output of libomp.so [NFC].
Feb 12 2020, 12:43 PM · Restricted Project

Feb 11 2020

kkwli0 created D74462: [OpenMP] update strings output of libomp.so [NFC].
Feb 11 2020, 10:00 PM · Restricted Project

Feb 3 2020

kkwli0 committed rGac430336318a: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC] (authored by kkwli0).
[OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]
Feb 3 2020, 3:35 PM
kkwli0 closed D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Feb 3 2020, 3:34 PM · Restricted Project
kkwli0 added inline comments to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Feb 3 2020, 1:24 PM · Restricted Project
kkwli0 updated the diff for D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].

Change requires unified_address status to partial.

Feb 3 2020, 1:24 PM · Restricted Project
kkwli0 added a comment to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].

Ping

Feb 3 2020, 8:10 AM · Restricted Project

Jan 23 2020

kkwli0 committed rGad24cf2a9420: [OpenMP] change omp_atk_* and omp_atv_* enumerators to lowercase [NFC] (authored by kkwli0).
[OpenMP] change omp_atk_* and omp_atv_* enumerators to lowercase [NFC]
Jan 23 2020, 8:24 AM
kkwli0 closed D73248: [OpenMP] change OMP_ATK_* and OMP_ATV_* enum to lowercase [NFC].
Jan 23 2020, 8:24 AM · Restricted Project

Jan 22 2020

kkwli0 created D73248: [OpenMP] change OMP_ATK_* and OMP_ATV_* enum to lowercase [NFC].
Jan 22 2020, 8:32 PM · Restricted Project
kkwli0 updated the diff for D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].

Address review comments and rebase.

Jan 22 2020, 3:25 PM · Restricted Project
kkwli0 added inline comments to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Jan 22 2020, 3:07 PM · Restricted Project

Jan 17 2020

kkwli0 added a reviewer for D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]: dreachem.
Jan 17 2020, 5:42 PM · Restricted Project
kkwli0 added inline comments to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Jan 17 2020, 1:36 PM · Restricted Project
kkwli0 added inline comments to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Jan 17 2020, 1:26 PM · Restricted Project
kkwli0 added inline comments to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Jan 17 2020, 1:07 PM · Restricted Project

Jan 16 2020

kkwli0 created D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Jan 16 2020, 11:58 PM · Restricted Project

Jan 6 2020

kkwli0 committed rG19433b199d1c: [OpenMP] Fix incorrect property of __has_attribute() macro (authored by kkwli0).
[OpenMP] Fix incorrect property of __has_attribute() macro
Jan 6 2020, 12:15 PM
kkwli0 closed D72287: [OpenMP] Fix incorrect property of __has_attribute() macro.
Jan 6 2020, 12:14 PM · Restricted Project

Jan 3 2020

kkwli0 committed rGed5fe64581f4: [OpenMP] NFC: Fix trivial typos in comments (authored by kkwli0).
[OpenMP] NFC: Fix trivial typos in comments
Jan 3 2020, 7:27 PM
kkwli0 closed D72171: [OpenMP] NFC: Fix trivial typos in comments.
Jan 3 2020, 7:26 PM · Restricted Project
kkwli0 committed rG427ffa2cdbbc: [OpenMP] diagnose zero-length array section in the depend clause (authored by kkwli0).
[OpenMP] diagnose zero-length array section in the depend clause
Jan 3 2020, 9:09 AM
kkwli0 closed D71969: [OpenMP] diagnose zero-length array section in the depend clause.
Jan 3 2020, 9:09 AM · Restricted Project

Jan 2 2020

kkwli0 updated the diff for D71969: [OpenMP] diagnose zero-length array section in the depend clause.

Update based on suggestion to simply the check and rebase.

Jan 2 2020, 9:30 AM · Restricted Project

Dec 30 2019

kkwli0 added a comment to D71969: [OpenMP] diagnose zero-length array section in the depend clause.

Is there a reason not to put this check right next to the one that issues err_omp_section_length_negative. SemaExpr.cpp +4668

Dec 30 2019, 10:43 AM · Restricted Project

Dec 28 2019

kkwli0 created D71969: [OpenMP] diagnose zero-length array section in the depend clause.
Dec 28 2019, 7:04 PM · Restricted Project

Nov 22 2019

kkwli0 committed rG0c7a1c0cfc2a: [OPENMP] [DOCS] correct status for use_device_addr clause (authored by kkwli0).
[OPENMP] [DOCS] correct status for use_device_addr clause
Nov 22 2019, 12:34 PM
kkwli0 closed D70608: [OPENMP] [DOCS] correct status for use_device_addr clause.
Nov 22 2019, 12:34 PM · Restricted Project
kkwli0 created D70608: [OPENMP] [DOCS] correct status for use_device_addr clause.
Nov 22 2019, 11:02 AM · Restricted Project

Nov 6 2019

kkwli0 committed rG9f10cc2d124c: [OPENMP] [DOCS] fix section formatting issues [NFC] (authored by kkwli0).
[OPENMP] [DOCS] fix section formatting issues [NFC]
Nov 6 2019, 7:11 PM
kkwli0 closed D69909: [OPENMP] [DOCS] fix section formatting issues [NFC].
Nov 6 2019, 7:11 PM · Restricted Project
kkwli0 created D69909: [OPENMP] [DOCS] fix section formatting issues [NFC].
Nov 6 2019, 10:18 AM · Restricted Project

Nov 5 2019

kkwli0 committed rG1e1ae46595b1: [CMake] Prevent adding lld to test dependency (TEST_DEPS) when lld project is… (authored by kkwli0).
[CMake] Prevent adding lld to test dependency (TEST_DEPS) when lld project is…
Nov 5 2019, 1:43 PM
kkwli0 closed D69685: Prevent adding lld to test dependency (TEST_DEPS) when lld project is not built.
Nov 5 2019, 1:43 PM · Restricted Project, Restricted Project

Sep 4 2019

kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Sep 4 2019, 9:05 AM · Restricted Project, Restricted Project

Aug 9 2019

kkwli0 added a comment to D65835: [OpenMP] Permit map with DSA on combined directive.

I want to be sure we're on the same page: For OpenMP 5.0, should we allow is_device_ptr with the private clauses?

Yes, since it is allowed by the standard.

Umm ... I probably missed some earlier discussions! What would be the behavior of the following code?

p = omp_target_alloc(...);
#pragma omp target private(p) is_device_ptr(p)
  p[...] = ...;   // crash or not?

It must crush, I assume. The main problem is that this construct is allowed by the standard.

Yep. We should add a warning message for it.

Upon further reflection, this is not clearly allowed by the standard. My experience is that, when reading standards, sometimes things are disallowed by contradiction (i.e., the standard does not define some behavior, and what the standard does say that's relevant is self contradictory). In this case, 2.19.3 says that list items which are privatized (and which are used) undergo replacement (with new items created as specified) while 2.12.5 says that "The is_device_ptr clause is used to indicate that a list item is a device pointer already in the device data environment and that it should be used directly." A given list item cannot simultaneously be "used directly" (2.12.5) and also undergo replacement: "Inside the construct, all references to the original list item are replaced by references to a new list item received by the task or SIMD lane" (2.19.3). Thus, it may be disallowed.

Aug 9 2019, 4:09 PM · Restricted Project, Restricted Project
kkwli0 added a comment to D65835: [OpenMP] Permit map with DSA on combined directive.

I want to be sure we're on the same page: For OpenMP 5.0, should we allow is_device_ptr with the private clauses?

Yes, since it is allowed by the standard.

Aug 9 2019, 2:56 PM · Restricted Project, Restricted Project

Aug 1 2019

kkwli0 added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

Looks fine to me.

Aug 1 2019, 9:02 AM · Restricted Project, Restricted Project

Jul 29 2019

kkwli0 added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

There's already D55892 with a better set of tests, including target enter data / target exit data.

Better to merge those two patches into one.

How would you like me to proceed? It looks like the other patch has been sitting there approved for many many months.

Yes, the patch has been waiting for the runtime implementation first and then commit.

Jul 29 2019, 8:43 AM · Restricted Project, Restricted Project
kkwli0 added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

There's already D55892 with a better set of tests, including target enter data / target exit data.

Better to merge those two patches into one.

How would you like me to proceed? It looks like the other patch has been sitting there approved for many many months.

Jul 29 2019, 8:34 AM · Restricted Project, Restricted Project

Jul 10 2019

kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Jul 10 2019, 3:56 PM · Restricted Project, Restricted Project
kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Jul 10 2019, 3:42 PM · Restricted Project, Restricted Project

Jul 9 2019

kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Jul 9 2019, 1:17 PM · Restricted Project, Restricted Project

May 2 2019

kkwli0 added a comment to D61379: [OPENMP][NVPTX]Improve omp_get_max_threads() function..

It looks good to me.

May 2 2019, 7:33 AM · Restricted Project
kkwli0 added a comment to D61378: [OPENMP][NVPTX]Improved omp_get_thread_limit() function..

It looks good to me.

May 2 2019, 7:29 AM · Restricted Project, Restricted Project

Feb 21 2019

kkwli0 added inline comments to D58504: [OpenCL][8.0.0 Release] Notes for OpenCL.
Feb 21 2019, 8:04 AM · Restricted Project

Feb 19 2019

kkwli0 added a comment to D58243: [OPENMP] Delay emission of the asm target-specific error messages..

The change looks okay to me.

Feb 19 2019, 2:19 PM · Restricted Project, Restricted Project

Feb 12 2019

kkwli0 added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 12 2019, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2019

kkwli0 added a comment to D57851: Guard a feature that unsupported by old GCC.

I close https://reviews.llvm.org/D57848 and consolidate the review and patch in this one.

Feb 7 2019, 9:19 AM · Restricted Project, Restricted Project
kkwli0 abandoned D57848: [OPENMP] fix build failure with GCC4.8.

Will consolidate the review and patch in https://reviews.llvm.org/D57851 .

Feb 7 2019, 9:16 AM

Feb 6 2019

kkwli0 added a comment to D57851: Guard a feature that unsupported by old GCC.

See https://reviews.llvm.org/D57848. I think we can close either one.

Feb 6 2019, 3:07 PM · Restricted Project, Restricted Project
kkwli0 created D57848: [OPENMP] fix build failure with GCC4.8.
Feb 6 2019, 2:31 PM

Feb 5 2019

kkwli0 closed D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.

Committed: r353186

Feb 5 2019, 8:45 AM
kkwli0 committed rG620ba6035ee7: [OPENMP] issue error messages for multiple teams contructs in a target construct (authored by kkwli0).
[OPENMP] issue error messages for multiple teams contructs in a target construct
Feb 5 2019, 8:44 AM

Feb 4 2019

kkwli0 updated the diff for D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.

Update based on review comment.

Feb 4 2019, 12:33 PM
kkwli0 added inline comments to D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.
Feb 4 2019, 12:32 PM
kkwli0 created D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.
Feb 4 2019, 7:58 AM

Jan 21 2019

kkwli0 added inline comments to D55078: Add omp_pause_resource* API.
Jan 21 2019, 8:03 AM · Restricted Project

Jan 18 2019

kkwli0 updated the diff for D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Addressed reviewer's comment.

Jan 18 2019, 10:37 AM · Restricted Project
kkwli0 added inline comments to D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 18 2019, 10:37 AM · Restricted Project

Jan 17 2019

kkwli0 requested review of D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 17 2019, 1:10 PM · Restricted Project
kkwli0 updated the diff for D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Add changes in D56790.

Jan 17 2019, 1:10 PM · Restricted Project
kkwli0 added a comment to D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Could we add the changes in D56790 to this diff?

Jan 17 2019, 1:08 PM · Restricted Project

Jan 15 2019

kkwli0 updated the diff for D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Add update in OpenMP support release note.

Jan 15 2019, 11:21 AM · Restricted Project
kkwli0 updated subscribers of D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 15 2019, 10:49 AM · Restricted Project
kkwli0 created D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 15 2019, 10:48 AM · Restricted Project

Dec 20 2018

kkwli0 added inline comments to D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
Dec 20 2018, 7:15 AM

Dec 6 2018

kkwli0 added inline comments to D55379: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64 function..
Dec 6 2018, 11:52 AM

Nov 27 2018

kkwli0 added a comment to D52700: [libomptarget-nvptx] Remove dead functions.

The XL compilers do not use these routines. Thanks.

Nov 27 2018, 1:49 PM · Restricted Project
kkwli0 added inline comments to D54967: [OPENMP][NVPTX]Basic support for reductions across the teams..
Nov 27 2018, 1:47 PM

Nov 15 2018

kkwli0 added a comment to D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator.

Please do a rebase. The test case teams_distribute_simd_loop_messages.cpp needs to update too.

Nov 15 2018, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2018

kkwli0 added inline comments to D51624: [libomptarget][CUDA] Use cuDeviceGetAttribute, NFCI..
Sep 4 2018, 6:16 AM

Aug 30 2018

kkwli0 added a comment to D51446: [OpenMP][bugfix] Add missing macros for Power.

Need to update the test too?

Aug 30 2018, 6:50 AM · Restricted Project

Jul 5 2018

kkwli0 changed the visibility for D48984: [OpenMP] Define __STDC_FORMAT_MACROS in callback.h.
Jul 5 2018, 11:26 AM
kkwli0 updated the summary of D48984: [OpenMP] Define __STDC_FORMAT_MACROS in callback.h.
Jul 5 2018, 11:23 AM