Page MenuHomePhabricator

kkwli0 (Kelvin Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2014, 8:03 PM (272 w, 1 d)

Recent Activity

Fri, Aug 9

kkwli0 added a comment to D65835: [OpenMP] Permit map with DSA on combined directive.

I want to be sure we're on the same page: For OpenMP 5.0, should we allow is_device_ptr with the private clauses?

Yes, since it is allowed by the standard.

Umm ... I probably missed some earlier discussions! What would be the behavior of the following code?

p = omp_target_alloc(...);
#pragma omp target private(p) is_device_ptr(p)
  p[...] = ...;   // crash or not?

It must crush, I assume. The main problem is that this construct is allowed by the standard.

Yep. We should add a warning message for it.

Upon further reflection, this is not clearly allowed by the standard. My experience is that, when reading standards, sometimes things are disallowed by contradiction (i.e., the standard does not define some behavior, and what the standard does say that's relevant is self contradictory). In this case, 2.19.3 says that list items which are privatized (and which are used) undergo replacement (with new items created as specified) while 2.12.5 says that "The is_device_ptr clause is used to indicate that a list item is a device pointer already in the device data environment and that it should be used directly." A given list item cannot simultaneously be "used directly" (2.12.5) and also undergo replacement: "Inside the construct, all references to the original list item are replaced by references to a new list item received by the task or SIMD lane" (2.19.3). Thus, it may be disallowed.

Fri, Aug 9, 4:09 PM · Restricted Project, Restricted Project
kkwli0 added a comment to D65835: [OpenMP] Permit map with DSA on combined directive.

I want to be sure we're on the same page: For OpenMP 5.0, should we allow is_device_ptr with the private clauses?

Yes, since it is allowed by the standard.

Fri, Aug 9, 2:56 PM · Restricted Project, Restricted Project

Thu, Aug 1

kkwli0 added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

Looks fine to me.

Thu, Aug 1, 9:02 AM · Restricted Project, Restricted Project

Mon, Jul 29

kkwli0 added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

There's already D55892 with a better set of tests, including target enter data / target exit data.

Better to merge those two patches into one.

How would you like me to proceed? It looks like the other patch has been sitting there approved for many many months.

Yes, the patch has been waiting for the runtime implementation first and then commit.

Mon, Jul 29, 8:43 AM · Restricted Project, Restricted Project
kkwli0 added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

There's already D55892 with a better set of tests, including target enter data / target exit data.

Better to merge those two patches into one.

How would you like me to proceed? It looks like the other patch has been sitting there approved for many many months.

Mon, Jul 29, 8:34 AM · Restricted Project, Restricted Project

Jul 10 2019

kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Jul 10 2019, 3:56 PM · Restricted Project
kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Jul 10 2019, 3:42 PM · Restricted Project

Jul 9 2019

kkwli0 added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Jul 9 2019, 1:17 PM · Restricted Project

May 2 2019

kkwli0 added a comment to D61379: [OPENMP][NVPTX]Improve omp_get_max_threads() function..

It looks good to me.

May 2 2019, 7:33 AM · Restricted Project
kkwli0 added a comment to D61378: [OPENMP][NVPTX]Improved omp_get_thread_limit() function..

It looks good to me.

May 2 2019, 7:29 AM · Restricted Project, Restricted Project

Feb 21 2019

kkwli0 added inline comments to D58504: [OpenCL][8.0.0 Release] Notes for OpenCL.
Feb 21 2019, 8:04 AM · Restricted Project

Feb 19 2019

kkwli0 added a comment to D58243: [OPENMP] Delay emission of the asm target-specific error messages..

The change looks okay to me.

Feb 19 2019, 2:19 PM · Restricted Project, Restricted Project

Feb 12 2019

kkwli0 added inline comments to D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 12 2019, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2019

kkwli0 added a comment to D57851: Guard a feature that unsupported by old GCC.

I close https://reviews.llvm.org/D57848 and consolidate the review and patch in this one.

Feb 7 2019, 9:19 AM · Restricted Project, Restricted Project
kkwli0 abandoned D57848: [OPENMP] fix build failure with GCC4.8.

Will consolidate the review and patch in https://reviews.llvm.org/D57851 .

Feb 7 2019, 9:16 AM

Feb 6 2019

kkwli0 added a comment to D57851: Guard a feature that unsupported by old GCC.

See https://reviews.llvm.org/D57848. I think we can close either one.

Feb 6 2019, 3:07 PM · Restricted Project, Restricted Project
kkwli0 created D57848: [OPENMP] fix build failure with GCC4.8.
Feb 6 2019, 2:31 PM

Feb 5 2019

kkwli0 closed D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.

Committed: r353186

Feb 5 2019, 8:45 AM
kkwli0 committed rG620ba6035ee7: [OPENMP] issue error messages for multiple teams contructs in a target construct (authored by kkwli0).
[OPENMP] issue error messages for multiple teams contructs in a target construct
Feb 5 2019, 8:44 AM

Feb 4 2019

kkwli0 updated the diff for D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.

Update based on review comment.

Feb 4 2019, 12:33 PM
kkwli0 added inline comments to D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.
Feb 4 2019, 12:32 PM
kkwli0 created D57690: [OPENMP] issue error messages for multiple teams contructs in a target constructs.
Feb 4 2019, 7:58 AM

Jan 21 2019

kkwli0 added inline comments to D55078: Add omp_pause_resource* API.
Jan 21 2019, 8:03 AM · Restricted Project

Jan 18 2019

kkwli0 updated the diff for D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Addressed reviewer's comment.

Jan 18 2019, 10:37 AM · Restricted Project
kkwli0 added inline comments to D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 18 2019, 10:37 AM · Restricted Project

Jan 17 2019

kkwli0 requested review of D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 17 2019, 1:10 PM · Restricted Project
kkwli0 updated the diff for D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Add changes in D56790.

Jan 17 2019, 1:10 PM · Restricted Project
kkwli0 added a comment to D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Could we add the changes in D56790 to this diff?

Jan 17 2019, 1:08 PM · Restricted Project

Jan 15 2019

kkwli0 updated the diff for D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Add update in OpenMP support release note.

Jan 15 2019, 11:21 AM · Restricted Project
kkwli0 updated subscribers of D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 15 2019, 10:49 AM · Restricted Project
kkwli0 created D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 15 2019, 10:48 AM · Restricted Project

Dec 20 2018

kkwli0 added inline comments to D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
Dec 20 2018, 7:15 AM

Dec 6 2018

kkwli0 added inline comments to D55379: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64 function..
Dec 6 2018, 11:52 AM

Nov 27 2018

kkwli0 added a comment to D52700: [libomptarget-nvptx] Remove dead functions.

The XL compilers do not use these routines. Thanks.

Nov 27 2018, 1:49 PM · Restricted Project
kkwli0 added inline comments to D54967: [OPENMP][NVPTX]Basic support for reductions across the teams..
Nov 27 2018, 1:47 PM

Nov 15 2018

kkwli0 added a comment to D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator.

Please do a rebase. The test case teams_distribute_simd_loop_messages.cpp needs to update too.

Nov 15 2018, 12:45 PM · Restricted Project, Restricted Project

Sep 4 2018

kkwli0 added inline comments to D51624: [libomptarget][CUDA] Use cuDeviceGetAttribute, NFCI..
Sep 4 2018, 6:16 AM

Aug 30 2018

kkwli0 added a comment to D51446: [OpenMP][bugfix] Add missing macros for Power.

Need to update the test too?

Aug 30 2018, 6:50 AM · Restricted Project

Jul 5 2018

kkwli0 changed the visibility for D48984: [OpenMP] Define __STDC_FORMAT_MACROS in callback.h.
Jul 5 2018, 11:26 AM
kkwli0 updated the summary of D48984: [OpenMP] Define __STDC_FORMAT_MACROS in callback.h.
Jul 5 2018, 11:23 AM
kkwli0 created D48984: [OpenMP] Define __STDC_FORMAT_MACROS in callback.h.
Jul 5 2018, 11:22 AM

Feb 7 2018

Herald updated subscribers of D38798: [OpenMP] Support for implicit "declare target" functions - Sema patch.
Feb 7 2018, 9:54 AM · Restricted Project

Dec 8 2017

kkwli0 updated the diff for D40996: Add --no-cuda-version-check in unknown-std.cpp.

Using a mock CUDA installation works too.

Dec 8 2017, 6:40 PM
kkwli0 updated the diff for D40968: [OpenMP] Diagnose function name on the link clause.
Dec 8 2017, 3:14 PM
kkwli0 added inline comments to D40968: [OpenMP] Diagnose function name on the link clause.
Dec 8 2017, 1:48 PM
kkwli0 added inline comments to D40968: [OpenMP] Diagnose function name on the link clause.
Dec 8 2017, 10:59 AM

Dec 7 2017

kkwli0 created D40996: Add --no-cuda-version-check in unknown-std.cpp.
Dec 7 2017, 6:50 PM
kkwli0 updated the diff for D40968: [OpenMP] Diagnose function name on the link clause.
Dec 7 2017, 1:08 PM
kkwli0 added inline comments to D40968: [OpenMP] Diagnose function name on the link clause.
Dec 7 2017, 1:06 PM
kkwli0 created D40968: [OpenMP] Diagnose function name on the link clause.
Dec 7 2017, 9:47 AM

Nov 29 2017

kkwli0 updated the diff for D40588: [OpenMP] Diagnose undeclared variables on declare target clause.

The assert occurs in VarOrFuncDeclFilterCCC::ValidateCandidate when clang::Sema::CorrectTypo is called.

Nov 29 2017, 1:54 PM
kkwli0 added a comment to D40588: [OpenMP] Diagnose undeclared variables on declare target clause.

The original case has the variables named "foo1" and foo2". Using "foo1" or "foo2" causes the assert! I update the description.

Nov 29 2017, 1:50 PM
kkwli0 updated the summary of D40588: [OpenMP] Diagnose undeclared variables on declare target clause.
Nov 29 2017, 1:48 PM

Nov 28 2017

kkwli0 updated subscribers of D40588: [OpenMP] Diagnose undeclared variables on declare target clause.
Nov 28 2017, 3:54 PM
kkwli0 created D40588: [OpenMP] Diagnose undeclared variables on declare target clause.
Nov 28 2017, 3:53 PM

Sep 1 2017

kkwli0 abandoned D37129: [OpenMP] Capture global variables with combined/composite pragmas containing target.

Already upstreamed.

Sep 1 2017, 10:51 AM

Aug 24 2017

kkwli0 created D37129: [OpenMP] Capture global variables with combined/composite pragmas containing target.
Aug 24 2017, 8:12 PM

Apr 6 2017

kkwli0 added inline comments to D31417: [OpenMP] Add support for omp simd pragmas without runtime.
Apr 6 2017, 10:20 AM

Jan 10 2017

kkwli0 added inline comments to D28252: [OpenMP] Sema and parsing for 'target teams distribute simd' pragma.
Jan 10 2017, 10:15 AM

Jan 6 2017

kkwli0 retitled D28402: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for simd' pragma from to [OpenMP] support the 'is_device_ptr' clause with 'target parallel for simd' pragma.
Jan 6 2017, 9:10 AM

Jan 3 2017

kkwli0 retitled D28255: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for' pragma from to [OpenMP] support the 'is_device_ptr' clause with 'target parallel for' pragma.
Jan 3 2017, 2:29 PM
kkwli0 retitled D28252: [OpenMP] Sema and parsing for 'target teams distribute simd' pragma from to [OpenMP] Sema and parsing for 'target teams distribute simd' pragma.
Jan 3 2017, 1:02 PM

Dec 31 2016

kkwli0 retitled D28205: [OpenMP] Add more tests for the 'teams distribute parallel for' pragma from to [OpenMP] Add more tests for the 'teams distribute parallel for' pragma.
Dec 31 2016, 8:06 PM
kkwli0 retitled D28202: [OpenMP] Sema and parsing for 'target teams distribute parallel for simd' pragma from to [OpenMP] Sema and parsing for 'target teams distribute parallel for simd' pragma.
Dec 31 2016, 9:42 AM

Dec 29 2016

kkwli0 retitled D28160: [OpenMP] Sema and parsing for 'target teams distribute parallel for' pragma from to [OpenMP] Sema and parsing for 'target teams distribute parallel for' pragma.
Dec 29 2016, 9:03 AM

Dec 20 2016

kkwli0 retitled D28015: [OpenMP] Sema and parsing for 'target teams distribute' pragma from to [OpenMP] Sema and parsing for 'target teams distribute' pragma.
Dec 20 2016, 8:16 PM

Dec 15 2016

kkwli0 retitled D27821: [OpenMP] support is_device_ptr clause with 'target parallel' pragma from to [OpenMP] support is_device_ptr clause with 'target parallel' pragma.
Dec 15 2016, 11:34 AM
kkwli0 retitled D27818: [OpenMP] Sema and parsing for 'target teams' pragma from [OpenMP] Sema and parsing for 'target teams' pramga to [OpenMP] Sema and parsing for 'target teams' pragma.
Dec 15 2016, 11:29 AM
kkwli0 retitled D27818: [OpenMP] Sema and parsing for 'target teams' pragma from to [OpenMP] Sema and parsing for 'target teams' pramga.
Dec 15 2016, 9:59 AM

Dec 6 2016

kkwli0 updated the diff for D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma.

Update based on comments in previous review.

Dec 6 2016, 6:02 PM
kkwli0 added inline comments to D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma.
Dec 6 2016, 4:23 PM
kkwli0 added a comment to D27488: Fixing test to work when the compiler defaults to a different c++ standard version..

I am okay with the changes. Thanks. Alexey will have the final say.

Dec 6 2016, 3:43 PM
kkwli0 added reviewers for D27488: Fixing test to work when the compiler defaults to a different c++ standard version.: ABataev, mikerice.
Dec 6 2016, 3:41 PM

Dec 2 2016

kkwli0 retitled D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma from to [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma.
Dec 2 2016, 8:14 AM

Nov 29 2016

kkwli0 updated the diff for D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma.
  • fixes based on comments in the review
  • added if clause test case
Nov 29 2016, 7:16 PM
kkwli0 added inline comments to D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma.
Nov 29 2016, 6:16 PM

Nov 24 2016

kkwli0 updated the diff for D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma.

Fixed a typo and re-format accordingly.

Nov 24 2016, 2:14 PM

Nov 23 2016

kkwli0 retitled D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma from to [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma.
Nov 23 2016, 8:36 PM
kkwli0 retitled D27006: [OpenMP] Remove unnecessary comment [NFC] from [OpenMP] Remove unnecessary comment [NFC} to [OpenMP] Remove unnecessary comment [NFC].
Nov 23 2016, 7:31 PM

Nov 22 2016

kkwli0 retitled D27006: [OpenMP] Remove unnecessary comment [NFC] from to [OpenMP] Remove unnecessary comment [NFC}.
Nov 22 2016, 3:32 PM

Oct 4 2016

kkwli0 added a comment to D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard.

Should we issue a warning message in this case?

Oct 4 2016, 2:37 PM

Aug 16 2016

kkwli0 updated the diff for D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma.

Add teams_distribute_simd_ast_print.cpp.

Aug 16 2016, 10:48 AM

Aug 15 2016

kkwli0 retitled D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma from to [OpenMP] Sema and parsing for 'teams distribute simd' pragma.
Aug 15 2016, 3:27 PM

Aug 5 2016

kkwli0 added a comment to D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma.

Thanks. I will update it when I commit the patch.

Aug 5 2016, 7:37 AM

Aug 4 2016

kkwli0 retitled D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma from to [OpenMP] Sema and parsing for 'teams distribute' pragma.
Aug 4 2016, 6:59 PM

Jul 25 2016

kkwli0 added a comment to D22785: [OpenMP] diagnose orphaned teams construct.

Will add the braces. Thanks.

Jul 25 2016, 9:34 PM
kkwli0 retitled D22785: [OpenMP] diagnose orphaned teams construct from to [OpenMP] diagnose orphaned teams construct.
Jul 25 2016, 3:25 PM

Jul 18 2016

kkwli0 retitled D22479: [OpenMP] Sema and parsing for 'target simd' pragma from to [OpenMP] Sema and parsing for 'target simd' pragma.
Jul 18 2016, 2:31 PM

Jul 17 2016

kkwli0 updated subscribers of D22417: [OpenMP] update test cases for -std=c++11 compile.

Add cfe-commits

Jul 17 2016, 7:50 PM
kkwli0 updated the diff for D22417: [OpenMP] update test cases for -std=c++11 compile.

Add more test paths.

Jul 17 2016, 7:31 PM

Jul 15 2016

kkwli0 added a comment to D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma.

I update the test cases in https://reviews.llvm.org/D22417.

Jul 15 2016, 10:59 AM
kkwli0 retitled D22417: [OpenMP] update test cases for -std=c++11 compile from to [OpenMP] update test cases for -std=c++11 compile.
Jul 15 2016, 10:59 AM

Jul 14 2016

kkwli0 retitled D22384: [OpenMP] add check for both simdlen and safelen clauses specified from to [OpenMP] add check for both simdlen and safelen clauses specified.
Jul 14 2016, 2:49 PM

Jul 8 2016

kkwli0 retitled D22177: [OpenMP] remove duplicate code in ActOnOpenMPRegionStart from to [OpenMP] remove duplicate code in ActOnOpenMPRegionStart.
Jul 8 2016, 3:01 PM
kkwli0 retitled D22176: [OpenMP] add more tests for 'distribute simd' pragma from to [OpenMP] add more tests for 'distribute simd' pragma.
Jul 8 2016, 2:49 PM
kkwli0 retitled D22169: [OpenMP] add more tests for 'distribute parallel for simd' pragma from to [OpenMP] add more tests for 'distribute parallel for simd' pragma.
Jul 8 2016, 2:00 PM

Jul 7 2016

kkwli0 retitled D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma from to [OpenMP] Sema and parsing for 'target parallel for simd' pragma.
Jul 7 2016, 9:25 AM

Jul 5 2016

kkwli0 retitled D22007: [OpenMP] Sema and parsing for 'distribute simd' pragma from to [OpenMP] Sema and parsing for 'distribute simd' pragma.
Jul 5 2016, 12:02 PM

Jul 4 2016

kkwli0 added a comment to D21977: [OpenMP] Sema and parse for 'distribute parallel for simd'.

I will incorporate the comments in the commit version. Thanks.

Jul 4 2016, 8:44 PM
kkwli0 retitled D21977: [OpenMP] Sema and parse for 'distribute parallel for simd' from to [OpenMP] Sema and parse for 'distribute parallel for simd'.
Jul 4 2016, 9:52 AM