Page MenuHomePhabricator

asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (184 w, 2 d)

Recent Activity

Wed, Aug 21

asbirlea committed rG7425179fee9b: [LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to… (authored by asbirlea).
[LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to…
Wed, Aug 21, 10:01 AM
asbirlea committed rL369548: [LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to….
[LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to…
Wed, Aug 21, 10:01 AM
asbirlea closed D66376: [LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to preserve it..
Wed, Aug 21, 10:00 AM · Restricted Project

Tue, Aug 20

asbirlea updated the diff for D66376: [LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to preserve it..

Address comments.

Tue, Aug 20, 4:32 PM · Restricted Project
asbirlea committed rG2863721f0582: [MemorySSA] Make Phi cleanups consistent. (authored by asbirlea).
[MemorySSA] Make Phi cleanups consistent.
Tue, Aug 20, 3:52 PM
asbirlea committed rL369466: [MemorySSA] Make Phi cleanups consistent..
[MemorySSA] Make Phi cleanups consistent.
Tue, Aug 20, 3:52 PM
asbirlea closed D66454: [MemorySSA] Make Phi cleanups consistent..
Tue, Aug 20, 3:51 PM · Restricted Project
asbirlea updated the diff for D66454: [MemorySSA] Make Phi cleanups consistent..

Address comment.

Tue, Aug 20, 3:45 PM · Restricted Project
asbirlea committed rG1c528e8f1b29: [MemorySSA] Fix existing phis when inserting defs. (authored by asbirlea).
[MemorySSA] Fix existing phis when inserting defs.
Tue, Aug 20, 3:34 PM
asbirlea committed rL369464: [MemorySSA] Fix existing phis when inserting defs..
[MemorySSA] Fix existing phis when inserting defs.
Tue, Aug 20, 3:28 PM
asbirlea closed D66495: [MemorySSA] Fix existing phis when inserting defs..
Tue, Aug 20, 3:28 PM · Restricted Project
asbirlea updated the summary of D66454: [MemorySSA] Make Phi cleanups consistent..
Tue, Aug 20, 1:52 PM · Restricted Project
asbirlea created D66495: [MemorySSA] Fix existing phis when inserting defs..
Tue, Aug 20, 1:45 PM · Restricted Project
asbirlea updated the diff for D66454: [MemorySSA] Make Phi cleanups consistent..

Make this purely a cleanup patch.

Tue, Aug 20, 1:45 PM · Restricted Project

Mon, Aug 19

asbirlea created D66454: [MemorySSA] Make Phi cleanups consistent..
Mon, Aug 19, 5:07 PM · Restricted Project
asbirlea committed rG1a3fdaf6a6ee: [MemorySSA] Rename uses when inserting memory uses. (authored by asbirlea).
[MemorySSA] Rename uses when inserting memory uses.
Mon, Aug 19, 12:01 PM
asbirlea committed rL369291: [MemorySSA] Rename uses when inserting memory uses..
[MemorySSA] Rename uses when inserting memory uses.
Mon, Aug 19, 11:57 AM
asbirlea closed D66033: [MemorySSA] Rename uses when inserting memory uses..
Mon, Aug 19, 11:57 AM · Restricted Project
asbirlea updated the diff for D66033: [MemorySSA] Rename uses when inserting memory uses..

Remove verification assert when incoming value from unreachable can be any access.
Add additional test which showcases the above.

Mon, Aug 19, 11:33 AM · Restricted Project
asbirlea updated the diff for D66033: [MemorySSA] Rename uses when inserting memory uses..

Address comments.

Mon, Aug 19, 9:54 AM · Restricted Project

Fri, Aug 16

asbirlea committed rGf92109dc01b8: [MemorySSA] Loop passes should mark MSSA preserved when available. (authored by asbirlea).
[MemorySSA] Loop passes should mark MSSA preserved when available.
Fri, Aug 16, 6:04 PM
asbirlea committed rL369181: [MemorySSA] Loop passes should mark MSSA preserved when available..
[MemorySSA] Loop passes should mark MSSA preserved when available.
Fri, Aug 16, 6:04 PM
asbirlea updated the diff for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..

Rebase on top of D66376.

Fri, Aug 16, 5:55 PM · Restricted Project
asbirlea created D66376: [LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to preserve it..
Fri, Aug 16, 5:55 PM · Restricted Project

Thu, Aug 15

asbirlea updated the diff for D66033: [MemorySSA] Rename uses when inserting memory uses..

Rebase on ToT.

Thu, Aug 15, 2:22 PM · Restricted Project
asbirlea committed rG79ff20428e3c: [MemorySSA] Remove restrictive asserts. (authored by asbirlea).
[MemorySSA] Remove restrictive asserts.
Thu, Aug 15, 2:20 PM
asbirlea committed rL369050: [MemorySSA] Remove restrictive asserts..
[MemorySSA] Remove restrictive asserts.
Thu, Aug 15, 2:19 PM
asbirlea added a comment to D65060: [LICM] Make Loop ICM profile aware.

Let me try to answer some of the question, and my apologies for not catching this in the initial review.

Thu, Aug 15, 12:20 PM · Restricted Project

Tue, Aug 13

asbirlea updated the summary of D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Tue, Aug 13, 10:42 AM · Restricted Project
asbirlea added a comment to D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..

Ping.

Tue, Aug 13, 10:17 AM · Restricted Project
asbirlea updated the diff for D66033: [MemorySSA] Rename uses when inserting memory uses..

Updated move call to also rename Uses.
Removed asserts checking against LoE.
Added two more reduced tests.

Tue, Aug 13, 10:13 AM · Restricted Project

Fri, Aug 9

asbirlea added a comment to D66033: [MemorySSA] Rename uses when inserting memory uses..

Note: this is incomplete.

Fri, Aug 9, 5:08 PM · Restricted Project
asbirlea created D66033: [MemorySSA] Rename uses when inserting memory uses..
Fri, Aug 9, 3:05 PM · Restricted Project

Wed, Aug 7

asbirlea accepted D65806: [MemDep] allow to select block-scan-limit when constructing MemoryDependenceAnalysis.

lgtm.

Wed, Aug 7, 1:21 PM · Restricted Project

Mon, Aug 5

asbirlea updated the diff for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..

Reabse and gentle ping.

Mon, Aug 5, 10:10 AM · Restricted Project

Fri, Aug 2

asbirlea committed rG9f057853580f: [NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change. (authored by asbirlea).
[NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change.
Fri, Aug 2, 11:38 AM
asbirlea committed rL367703: [NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change..
[NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change.
Fri, Aug 2, 11:36 AM
asbirlea closed D65621: [NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change..
Fri, Aug 2, 11:36 AM · Restricted Project
asbirlea committed rG5545e6963f24: [SimplifyCFG] Cleanup redundant conditions [NFC]. (authored by asbirlea).
[SimplifyCFG] Cleanup redundant conditions [NFC].
Fri, Aug 2, 11:11 AM
asbirlea committed rL367699: [SimplifyCFG] Cleanup redundant conditions [NFC]..
[SimplifyCFG] Cleanup redundant conditions [NFC].
Fri, Aug 2, 11:11 AM
asbirlea closed D65596: [SimplifyCFG] Cleanup redundant conditions [NFC]..
Fri, Aug 2, 11:10 AM · Restricted Project

Thu, Aug 1

asbirlea updated the diff for D65621: [NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change..

Update test.

Thu, Aug 1, 4:50 PM · Restricted Project
asbirlea created D65621: [NewPassManager] Resolve assertion in CGSCCPassManager when CallCounts change..
Thu, Aug 1, 4:43 PM · Restricted Project
asbirlea committed rG3af2a69575da: [SimplifyCFG] Mark missed Changed to true. (authored by asbirlea).
[SimplifyCFG] Mark missed Changed to true.
Thu, Aug 1, 11:39 AM
asbirlea committed rL367596: [SimplifyCFG] Mark missed Changed to true..
[SimplifyCFG] Mark missed Changed to true.
Thu, Aug 1, 11:37 AM
asbirlea closed D65490: [SimplifyCFG] Mark missed Changed to true..
Thu, Aug 1, 11:37 AM · Restricted Project
asbirlea created D65596: [SimplifyCFG] Cleanup redundant conditions [NFC]..
Thu, Aug 1, 11:34 AM · Restricted Project
asbirlea committed rG172838df6bc9: [MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis… (authored by asbirlea).
[MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis…
Thu, Aug 1, 11:30 AM
asbirlea committed rL367594: [MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis….
[MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis…
Thu, Aug 1, 11:30 AM
asbirlea closed D65418: [MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis exists..
Thu, Aug 1, 11:30 AM · Restricted Project
asbirlea updated the diff for D65490: [SimplifyCFG] Mark missed Changed to true..

Address comments.

Thu, Aug 1, 11:30 AM · Restricted Project
asbirlea added inline comments to D65490: [SimplifyCFG] Mark missed Changed to true..
Thu, Aug 1, 11:30 AM · Restricted Project
asbirlea updated the diff for D65418: [MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis exists..

Address comment.

Thu, Aug 1, 10:51 AM · Restricted Project
asbirlea accepted D65568: [AliasAnalysis] Initialize a member variable that may be used by unit test..

LGTM, thanks for the patch!

Thu, Aug 1, 10:38 AM · Restricted Project

Wed, Jul 31

asbirlea added inline comments to D65528: [IR] Value: add replaceUsesWithIf() utility.
Wed, Jul 31, 11:56 AM · Restricted Project
asbirlea committed rG7153f2784c11: [SCCP] Update condition to avoid overflow. (authored by asbirlea).
[SCCP] Update condition to avoid overflow.
Wed, Jul 31, 11:23 AM
asbirlea committed rL367461: [SCCP] Update condition to avoid overflow..
[SCCP] Update condition to avoid overflow.
Wed, Jul 31, 11:23 AM
asbirlea closed D65417: [SCCP] Update condition to avoid overflow..
Wed, Jul 31, 11:23 AM · Restricted Project
asbirlea updated the diff for D65417: [SCCP] Update condition to avoid overflow..

Address comments.
Thank you for the review!

Wed, Jul 31, 11:19 AM · Restricted Project
asbirlea committed rG63e97fa0b3e9: [MemorySSA] Add additional verification for phis. (authored by asbirlea).
[MemorySSA] Add additional verification for phis.
Wed, Jul 31, 10:41 AM
asbirlea committed rL367451: [MemorySSA] Add additional verification for phis..
[MemorySSA] Add additional verification for phis.
Wed, Jul 31, 10:41 AM
asbirlea closed D63147: [MemorySSA] Add additional verification for phis..
Wed, Jul 31, 10:41 AM · Restricted Project
asbirlea updated the diff for D65417: [SCCP] Update condition to avoid overflow..

Address comment.

Wed, Jul 31, 9:54 AM · Restricted Project

Tue, Jul 30

asbirlea created D65490: [SimplifyCFG] Mark missed Changed to true..
Tue, Jul 30, 5:01 PM · Restricted Project
asbirlea updated the diff for D65417: [SCCP] Update condition to avoid overflow..

Added needed cast from unsigned to int64_t.

Tue, Jul 30, 1:46 PM · Restricted Project
asbirlea committed rG4bc625cae08a: [MemorySSA] Extend allowed behavior for simplified instructions. (authored by asbirlea).
[MemorySSA] Extend allowed behavior for simplified instructions.
Tue, Jul 30, 1:11 PM
asbirlea committed rL367352: [MemorySSA] Extend allowed behavior for simplified instructions..
[MemorySSA] Extend allowed behavior for simplified instructions.
Tue, Jul 30, 1:11 PM
asbirlea closed D65338: [MemorySSA] Extend allowed behavior for simplified instructions..
Tue, Jul 30, 1:11 PM · Restricted Project
asbirlea updated the diff for D65338: [MemorySSA] Extend allowed behavior for simplified instructions..

Added optional bool CreationMustSucceed.

Tue, Jul 30, 11:22 AM · Restricted Project
asbirlea updated the diff for D65338: [MemorySSA] Extend allowed behavior for simplified instructions..

Address comments.

Tue, Jul 30, 10:52 AM · Restricted Project
asbirlea added inline comments to D65338: [MemorySSA] Extend allowed behavior for simplified instructions..
Tue, Jul 30, 10:52 AM · Restricted Project
asbirlea updated the diff for D65417: [SCCP] Update condition to avoid overflow..

Address comment.

Tue, Jul 30, 10:06 AM · Restricted Project
asbirlea added inline comments to D65417: [SCCP] Update condition to avoid overflow..
Tue, Jul 30, 10:06 AM · Restricted Project

Mon, Jul 29

asbirlea updated the diff for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..

Rebase on ToT.
Ready for review.

Mon, Jul 29, 3:31 PM · Restricted Project
asbirlea added inline comments to D65417: [SCCP] Update condition to avoid overflow..
Mon, Jul 29, 2:43 PM · Restricted Project
asbirlea added a reviewer for D65417: [SCCP] Update condition to avoid overflow.: lebedev.ri.
Mon, Jul 29, 2:19 PM · Restricted Project
asbirlea updated the diff for D65417: [SCCP] Update condition to avoid overflow..

Update per comment suggestion: reorder conditions.

Mon, Jul 29, 2:19 PM · Restricted Project
asbirlea created D65418: [MemorySSA] Set LoopSimplify to preserve MemorySSA in the NPM, if analysis exists..
Mon, Jul 29, 2:00 PM · Restricted Project
asbirlea created D65417: [SCCP] Update condition to avoid overflow..
Mon, Jul 29, 1:56 PM · Restricted Project

Fri, Jul 26

asbirlea committed rGdeea000c9155: [MemorySSA & LoopPassManager] Analysis can be preserved only when all loop… (authored by asbirlea).
[MemorySSA & LoopPassManager] Analysis can be preserved only when all loop…
Fri, Jul 26, 12:01 PM
asbirlea committed rL367143: [MemorySSA & LoopPassManager] Analysis can be preserved only when all loop….
[MemorySSA & LoopPassManager] Analysis can be preserved only when all loop…
Fri, Jul 26, 12:01 PM
asbirlea created D65338: [MemorySSA] Extend allowed behavior for simplified instructions..
Fri, Jul 26, 10:13 AM · Restricted Project

Jul 22 2019

asbirlea accepted D65060: [LICM] Make Loop ICM profile aware.

Thank you for the patch. This LGTM.

Jul 22 2019, 10:07 AM · Restricted Project

Jul 17 2019

asbirlea added a comment to D55107: Prototype BasicAA improvements for discussion on llvm-dev.

Could you add some tests to this?

Jul 17 2019, 11:56 AM

Jul 12 2019

asbirlea committed rGdb101864bdc9: [MemorySSA] Use SetVector to avoid nondeterminism. (authored by asbirlea).
[MemorySSA] Use SetVector to avoid nondeterminism.
Jul 12 2019, 3:31 PM
asbirlea committed rL365970: [MemorySSA] Use SetVector to avoid nondeterminism..
[MemorySSA] Use SetVector to avoid nondeterminism.
Jul 12 2019, 3:30 PM
asbirlea closed D64601: [MemorySSA] Use SetVector to avoid nondeterminism..
Jul 12 2019, 3:30 PM · Restricted Project
asbirlea added a comment to D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

I'm planning to go ahead with the patch as is, and if the test tickles any bots, we can disable/remove/update it.

Jul 12 2019, 3:13 PM · Restricted Project
asbirlea updated the diff for D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

Add comment in test.

Jul 12 2019, 3:13 PM · Restricted Project
asbirlea updated the diff for D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

Add test.
Tested with LLVM_ENABLE_REVERSE_ITERATION enabled and without.

Jul 12 2019, 3:06 PM · Restricted Project
asbirlea added a comment to D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

I don't know if a bot exists with LLVM_ENABLE_REVERSE_ITERATION set to true, but if it does, then the check I proposed for the uselist order would likely fail, no?

; CHECK: uselistorder i16 0, { 3, 2, 4, 1, 5, 0, 6 }
Jul 12 2019, 1:42 PM · Restricted Project
asbirlea added a comment to D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

Hmm, AFAICT, there is no opt flag equivalent for LLVM_ENABLE_REVERSE_ITERATION. Did I miss it?

Jul 12 2019, 11:27 AM · Restricted Project

Jul 11 2019

asbirlea added a comment to D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

You can use SetVector's "getArrayRef" and pass it as "void removeBlocks(ArrayRef<BasicBlock *> DeadBlocks);"

Jul 11 2019, 3:36 PM · Restricted Project
asbirlea added a comment to D64601: [MemorySSA] Use SetVector to avoid nondeterminism..

I'd be interested if there's a better way to use a SmallSetVector, without needing the "8". I don't see an Impl version.
The only alternative I came up with was something like:

template <class OrderedSetT>
void removeBlocks(const OrderedSetT &DeadBlocks);
Jul 11 2019, 3:17 PM · Restricted Project
asbirlea created D64601: [MemorySSA] Use SetVector to avoid nondeterminism..
Jul 11 2019, 3:12 PM · Restricted Project

Jul 10 2019

asbirlea committed rG58a37754bb10: [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map. (authored by asbirlea).
[LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map.
Jul 10 2019, 10:38 AM
asbirlea committed rL365672: [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map..
[LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map.
Jul 10 2019, 10:38 AM
asbirlea closed D63680: [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map..
Jul 10 2019, 10:38 AM · Restricted Project

Jul 9 2019

asbirlea added inline comments to D63680: [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map..
Jul 9 2019, 4:02 PM · Restricted Project

Jul 8 2019

asbirlea added inline comments to D63934: [MIR] Improve PRE condition of MachineCSE optimization.
Jul 8 2019, 3:03 PM · Restricted Project