Page MenuHomePhabricator

asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (154 w, 19 h)

Recent Activity

Yesterday

asbirlea created D57129: [SimpleLoopUnswitch] Early check exit for trivial unswitch with MemorySSA..
Wed, Jan 23, 5:16 PM
asbirlea updated the diff for D56625: [LICM/MSSA] Add promotion to scalars by building an AliasSetTracker with MemorySSA..

Minor update and ping.

Wed, Jan 23, 3:07 PM
asbirlea added inline comments to D56568: [AliasSetTracker] Store AliasResult and pass it on mergeSetIn..
Wed, Jan 23, 2:42 PM

Tue, Jan 22

asbirlea added a comment to D56601: Update CaptureTracker so psub does not capture operands if possible.

I may not be the best to approve this change. Here are some high-level comments though.

Tue, Jan 22, 6:00 PM
asbirlea added inline comments to D56568: [AliasSetTracker] Store AliasResult and pass it on mergeSetIn..
Tue, Jan 22, 5:34 PM

Fri, Jan 11

asbirlea created D56625: [LICM/MSSA] Add promotion to scalars by building an AliasSetTracker with MemorySSA..
Fri, Jan 11, 5:07 PM
asbirlea added a reviewer for D56568: [AliasSetTracker] Store AliasResult and pass it on mergeSetIn.: chandlerc.
Fri, Jan 11, 3:11 PM
asbirlea added a reviewer for D56613: [AliasSetTracker] Pass MustAlias to addPointer more often.: chandlerc.
Fri, Jan 11, 3:11 PM
asbirlea updated the diff for D56613: [AliasSetTracker] Pass MustAlias to addPointer more often..

[format]

Fri, Jan 11, 11:16 AM
asbirlea created D56613: [AliasSetTracker] Pass MustAlias to addPointer more often..
Fri, Jan 11, 11:14 AM

Thu, Jan 10

asbirlea created D56568: [AliasSetTracker] Store AliasResult and pass it on mergeSetIn..
Thu, Jan 10, 4:41 PM
asbirlea committed rL350895: [MemorySSA] Disable checkClobberSanity for SkipSelfWalker..
[MemorySSA] Disable checkClobberSanity for SkipSelfWalker.
Thu, Jan 10, 1:51 PM
asbirlea committed rL350879: Use MemorySSA in LICM to do sinking and hoisting..
Use MemorySSA in LICM to do sinking and hoisting.
Thu, Jan 10, 11:33 AM
asbirlea closed D40375: Use MemorySSA in LICM to do sinking and hoisting..
Thu, Jan 10, 11:33 AM

Wed, Jan 9

asbirlea committed rL350783: [MemorySSA] Remove optimized value when reseting optimized..
[MemorySSA] Remove optimized value when reseting optimized.
Wed, Jan 9, 4:20 PM
asbirlea closed D56467: [MemorySSA] Remove optimized value when reseting optimized..
Wed, Jan 9, 4:20 PM
asbirlea added a comment to D40375: Use MemorySSA in LICM to do sinking and hoisting..

I also cleaned up the usage of EnableLicmCap. It is only used in 2 places now, with no forced calls to getClobbering (the issue in MemorySSA requiring this is now resolved).
FWIW, I'm planning to replace this with an integer cap in a future patch (i.e. allow a limited number of calls to getClobbering, vs all or none like we have now).

Wed, Jan 9, 4:05 PM
asbirlea updated the diff for D40375: Use MemorySSA in LICM to do sinking and hoisting..

Address comments.

Wed, Jan 9, 4:05 PM

Tue, Jan 8

asbirlea updated the diff for D40375: Use MemorySSA in LICM to do sinking and hoisting..

Cleaned up after a series of MemorySSA updates, and rebased with ToT changes.

Tue, Jan 8, 5:29 PM
asbirlea created D56467: [MemorySSA] Remove optimized value when reseting optimized..
Tue, Jan 8, 5:15 PM

Mon, Jan 7

asbirlea accepted D56408: [SimpleLoopUnswitch] Increment stats counter for unswitching switch instruction.

One nit, otherwise LGTM.

Mon, Jan 7, 2:38 PM
asbirlea committed rL350561: [MemorySSA] Add SkipSelfWalker..
[MemorySSA] Add SkipSelfWalker.
Mon, Jan 7, 11:42 AM
asbirlea closed D56285: [MemorySSA] Add SkipSelfWalker..
Mon, Jan 7, 11:42 AM
asbirlea committed rL350558: [MemorySSA] Refactor CachingWalker..
[MemorySSA] Refactor CachingWalker.
Mon, Jan 7, 11:27 AM
asbirlea closed D55957: [MemorySSA] Refactor CachingWalker..
Mon, Jan 7, 11:27 AM
asbirlea committed rL350551: [MemorySSA] Extend the clobber walker with the option to skip the starting….
[MemorySSA] Extend the clobber walker with the option to skip the starting…
Mon, Jan 7, 10:44 AM
asbirlea closed D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..
Mon, Jan 7, 10:44 AM
asbirlea added a comment to D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..

Thank you for the review!

Mon, Jan 7, 10:41 AM

Thu, Jan 3

asbirlea added inline comments to D56285: [MemorySSA] Add SkipSelfWalker..
Thu, Jan 3, 4:18 PM
asbirlea updated the diff for D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..

Update setting of where to stop in getBlockingAccess:

  • dropping the check for block since we may no longer be in the starting block after adding a paused path.
  • adding a second StopAt access in walkToPhiOrClobber, only set when skipping self and for the same location.
  • keeping paused path when the original StopAt is found.
Thu, Jan 3, 3:45 PM
asbirlea added a parent revision for D56285: [MemorySSA] Add SkipSelfWalker.: D55957: [MemorySSA] Refactor CachingWalker..
Thu, Jan 3, 12:00 PM
asbirlea added a child revision for D55957: [MemorySSA] Refactor CachingWalker.: D56285: [MemorySSA] Add SkipSelfWalker..
Thu, Jan 3, 12:00 PM
asbirlea created D56285: [MemorySSA] Add SkipSelfWalker..
Thu, Jan 3, 11:58 AM
asbirlea added a child revision for D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access.: D55957: [MemorySSA] Refactor CachingWalker..
Thu, Jan 3, 10:43 AM
asbirlea added a parent revision for D55957: [MemorySSA] Refactor CachingWalker.: D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..
Thu, Jan 3, 10:43 AM
asbirlea added inline comments to D55957: [MemorySSA] Refactor CachingWalker..
Thu, Jan 3, 10:42 AM
asbirlea updated the diff for D55957: [MemorySSA] Refactor CachingWalker..

Address comments.

Thu, Jan 3, 10:42 AM

Wed, Jan 2

asbirlea retitled D55957: [MemorySSA] Refactor CachingWalker. from [MemorySSA] Create walker that skips starting access. to [MemorySSA] Refactor CachingWalker..
Wed, Jan 2, 5:42 PM
asbirlea updated the diff for D55957: [MemorySSA] Refactor CachingWalker..

Repurpose patch to refactor caching walker.

Wed, Jan 2, 5:40 PM
asbirlea added a comment to D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..

Ack, will hold off on checking this in until the follow-up use (walker) is finalized.

Wed, Jan 2, 11:11 AM
asbirlea updated the diff for D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..

Address comments.

Wed, Jan 2, 11:11 AM

Dec 20 2018

asbirlea created D55957: [MemorySSA] Refactor CachingWalker..
Dec 20 2018, 2:31 PM
asbirlea created D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access..
Dec 20 2018, 12:01 PM

Dec 5 2018

asbirlea committed rL348345: [LICM] *Actually* disable ControlFlowHoisting..
[LICM] *Actually* disable ControlFlowHoisting.
Dec 5 2018, 2:19 AM
asbirlea closed D55313: [LICM] *Actually* disable ControlFlowHoisting..
Dec 5 2018, 2:19 AM
asbirlea created D55313: [LICM] *Actually* disable ControlFlowHoisting..
Dec 5 2018, 2:17 AM

Dec 4 2018

asbirlea committed rL348267: [SimpleLoopUnswitch] Remove debug dump..
[SimpleLoopUnswitch] Remove debug dump.
Dec 4 2018, 6:46 AM
asbirlea committed rL348263: Update MemorySSA in SimpleLoopUnswitch..
Update MemorySSA in SimpleLoopUnswitch.
Dec 4 2018, 6:26 AM
asbirlea closed D47022: Update MemorySSA in SimpleLoopUnswitch..
Dec 4 2018, 6:26 AM
asbirlea added a comment to D47022: Update MemorySSA in SimpleLoopUnswitch..

Thank you for the review!

Dec 4 2018, 6:26 AM
asbirlea added inline comments to D47022: Update MemorySSA in SimpleLoopUnswitch..
Dec 4 2018, 6:04 AM
asbirlea updated the diff for D47022: Update MemorySSA in SimpleLoopUnswitch..

Update MemorySSA when unswitching guard intrinsics.
And ping.

Dec 4 2018, 2:41 AM

Nov 29 2018

asbirlea added a comment to D55050: [LoopSimplifyCFG] Update MemorySSA in terminator folding. PR39783.

Based on the corresponding Phi updates, the MemoryPhi updates look correct.

Nov 29 2018, 10:31 PM

Nov 13 2018

asbirlea committed rL346798: [MemorySSA] Create query after checking if instruction is a fence..
[MemorySSA] Create query after checking if instruction is a fence.
Nov 13 2018, 1:15 PM

Nov 7 2018

asbirlea accepted D54211: [SimpleLoopUnswitch] partial unswitch needs to be careful when replacing invariants with constants.

Great catch, thank you for fixing this and for the additional tests.

Nov 7 2018, 10:13 AM

Nov 5 2018

asbirlea added inline comments to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.
Nov 5 2018, 10:09 AM

Nov 2 2018

asbirlea added a comment to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.

MemorySSA is an analysis, all info is kept "on the side". It's standalone and no info is kept in BBs.
Some doc can be found here: http://releases.llvm.org/6.0.1/docs/MemorySSA.html

Nov 2 2018, 9:59 AM

Nov 1 2018

asbirlea committed rL345911: [AliasSetTracker] Misc cleanup (NFCI).
[AliasSetTracker] Misc cleanup (NFCI)
Nov 1 2018, 4:40 PM
asbirlea added a comment to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.

FWIW, long term DSE should ideally use MemorySSA instead of MemoryDependenceResults.
But this particular optimization has a high chance of being useful even then.

Nov 1 2018, 2:20 PM
asbirlea updated subscribers of D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.
Nov 1 2018, 2:09 PM
asbirlea added a comment to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.

I have mixed feelings here because I understand Chris's point, but there are differences in this case which make this patch worth pushing forward IMO.

Nov 1 2018, 2:09 PM

Oct 31 2018

asbirlea added inline comments to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.
Oct 31 2018, 12:04 PM

Oct 30 2018

asbirlea added a comment to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

Let me re-purpose this patch:
Is there a point to having deleteValue()?
Is there a point to having the ref count (addRef, dropRef) for alias sets?

Oct 30 2018, 4:42 PM

Oct 29 2018

asbirlea added inline comments to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..
Oct 29 2018, 4:25 PM
asbirlea added a comment to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

I agree with all your points! Thank you for following up.

Oct 29 2018, 4:14 PM
asbirlea committed rL345548: [AliasSetTracker] Cleanup addPointer interface. [NFCI].
[AliasSetTracker] Cleanup addPointer interface. [NFCI]
Oct 29 2018, 3:28 PM
asbirlea closed D53836: [AliasSetTracker] Cleanup addPointer interface. [NFCI].
Oct 29 2018, 3:28 PM
asbirlea created D53836: [AliasSetTracker] Cleanup addPointer interface. [NFCI].
Oct 29 2018, 2:50 PM
asbirlea added a reviewer for D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker.: mkazantsev.
Oct 29 2018, 1:52 PM

Oct 26 2018

asbirlea committed rC345446: Revert r345170 [along with its llvm counterpart r345169] as it makes Halide….
Revert r345170 [along with its llvm counterpart r345169] as it makes Halide…
Oct 26 2018, 9:53 PM
asbirlea committed rL345447: Revert r345169 [along with its llvm counterpart r345170] as it makes Halide….
Revert r345169 [along with its llvm counterpart r345170] as it makes Halide…
Oct 26 2018, 9:53 PM
asbirlea committed rL345446: Revert r345170 [along with its llvm counterpart r345169] as it makes Halide….
Revert r345170 [along with its llvm counterpart r345169] as it makes Halide…
Oct 26 2018, 9:53 PM
asbirlea updated the diff for D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

clang-format. Thank you!

Oct 26 2018, 9:31 PM
asbirlea created D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..
Oct 26 2018, 5:21 PM

Oct 24 2018

asbirlea added a comment to D47022: Update MemorySSA in SimpleLoopUnswitch..

Gentle ping.

Oct 24 2018, 4:18 PM
asbirlea committed rL345216: Update MemorySSA in LoopRotate..
Update MemorySSA in LoopRotate.
Oct 24 2018, 3:49 PM
asbirlea closed D51718: Update MemorySSA in LoopRotate..
Oct 24 2018, 3:48 PM

Oct 22 2018

asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Test updated. Thank you for the review!

Oct 22 2018, 5:12 PM

Sep 24 2018

asbirlea added inline comments to D51718: Update MemorySSA in LoopRotate..
Sep 24 2018, 2:36 PM
asbirlea updated the diff for D40375: Use MemorySSA in LICM to do sinking and hoisting..

Rebase patch after resect changes.

Sep 24 2018, 1:11 PM

Sep 20 2018

asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Update pr35210.ll after recent upstream changes.

Sep 20 2018, 2:26 PM
asbirlea added inline comments to D51718: Update MemorySSA in LoopRotate..
Sep 20 2018, 1:28 PM

Sep 17 2018

asbirlea committed rL342422: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures….
[EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures…
Sep 17 2018, 3:37 PM
asbirlea closed D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..
Sep 17 2018, 3:36 PM
asbirlea updated the diff for D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..

Thank you for the review!

Sep 17 2018, 3:10 PM

Sep 11 2018

asbirlea abandoned D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Dropping this, since the issue is not resolvable in general AFAICT. Please see D51960.

Sep 11 2018, 4:49 PM
asbirlea abandoned D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Sep 11 2018, 4:49 PM
asbirlea created D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..
Sep 11 2018, 4:49 PM
asbirlea committed rL341984: Update MemorySSA in LoopUnswitch..
Update MemorySSA in LoopUnswitch.
Sep 11 2018, 12:20 PM
asbirlea closed D45301: Update MemorySSA in LoopUnswitch..
Sep 11 2018, 12:20 PM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Moving the MSSA after cloning earlier to avoid the ValueMap invalidation.
Adding another test.
And ping.

Sep 11 2018, 11:48 AM

Sep 10 2018

asbirlea added a reverting change for rL341674: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely…: rL341883: [InstCombine] Partially revert rL341674 due to PR38897..
Sep 10 2018, 4:48 PM
asbirlea committed rL341883: [InstCombine] Partially revert rL341674 due to PR38897..
[InstCombine] Partially revert rL341674 due to PR38897.
Sep 10 2018, 4:48 PM
asbirlea closed D51897: [InstCombine] Partially revert rL341674 due to PR38897..
Sep 10 2018, 4:48 PM
asbirlea created D51897: [InstCombine] Partially revert rL341674 due to PR38897..
Sep 10 2018, 4:48 PM
asbirlea committed rL341855: API to update MemorySSA for cloned blocks and added CFG edges..
API to update MemorySSA for cloned blocks and added CFG edges.
Sep 10 2018, 1:14 PM
asbirlea closed D45299: API to update MemorySSA for cloned blocks..
Sep 10 2018, 1:14 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Final update before commit: changing a cast_or_null to dyn_cast_or_null for cloned instructions. LoopRotate can place Value in the map, as the clone of an instruction.

Sep 10 2018, 11:49 AM

Sep 7 2018

asbirlea committed rL341733: [MemorySSA] Relax verification of clobbering accesses..
[MemorySSA] Relax verification of clobbering accesses.
Sep 7 2018, 4:52 PM
asbirlea committed rL341709: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if….
[MemorySSA] Update MemoryPhi wiring for block splitting to consider if…
Sep 7 2018, 2:16 PM