Page MenuHomePhabricator

asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (166 w, 1 d)

Recent Activity

Yesterday

asbirlea updated the diff for D59723: [NewPassManager] Adding pass tuning options: loop vectorize..

Address comments. Thank you for the review!

Thu, Apr 18, 5:09 PM · Restricted Project
asbirlea added a comment to D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

It's not as much the ew-ness that bothers me.
It's that, if MemorySSA is to be preserved and widely used in the loop pass, then this infrastructure change is needed anyway.

Thu, Apr 18, 4:59 PM · Restricted Project
asbirlea added inline comments to D60832: [MemorySSA] LCSSA preserves MemorySSA..
Thu, Apr 18, 4:46 PM · Restricted Project
asbirlea committed rGda0f71af7d9a: [LoopUnroll] Move list of params into a struct [NFCI]. (authored by asbirlea).
[LoopUnroll] Move list of params into a struct [NFCI].
Thu, Apr 18, 4:44 PM
asbirlea committed rL358723: [LoopUnroll] Move list of params into a struct [NFCI]..
[LoopUnroll] Move list of params into a struct [NFCI].
Thu, Apr 18, 4:44 PM
asbirlea closed D60638: [LoopUnroll] Move list of params into a struct [NFCI]..
Thu, Apr 18, 4:44 PM · Restricted Project
asbirlea updated the summary of D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..
Thu, Apr 18, 4:15 PM · Restricted Project
asbirlea updated the summary of D60832: [MemorySSA] LCSSA preserves MemorySSA..
Thu, Apr 18, 4:11 PM · Restricted Project
asbirlea updated the diff for D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

Rebase.

Thu, Apr 18, 4:09 PM · Restricted Project
asbirlea updated the diff for D60832: [MemorySSA] LCSSA preserves MemorySSA..

Rebase.

Thu, Apr 18, 4:09 PM · Restricted Project
asbirlea updated the summary of D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Thu, Apr 18, 4:09 PM · Restricted Project
asbirlea added a parent revision for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests.: D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..
Thu, Apr 18, 4:09 PM · Restricted Project
asbirlea added a child revision for D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA.: D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Thu, Apr 18, 4:09 PM · Restricted Project
asbirlea removed a parent revision for D60832: [MemorySSA] LCSSA preserves MemorySSA.: D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Thu, Apr 18, 4:07 PM · Restricted Project
asbirlea removed a child revision for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests.: D60832: [MemorySSA] LCSSA preserves MemorySSA..
Thu, Apr 18, 4:07 PM · Restricted Project
asbirlea updated the diff for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..

Rebase on top of patches updating LCSSA and LoopSimplify.

Thu, Apr 18, 4:06 PM · Restricted Project
asbirlea updated the diff for D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..

Simplify patch to preserve MemorySSA in the old pass manager only when the pass is already available (remove *require*).
New pass manager does not preserve it.

Thu, Apr 18, 3:03 PM · Restricted Project
asbirlea updated the summary of D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..
Thu, Apr 18, 3:03 PM · Restricted Project
asbirlea updated the summary of D60832: [MemorySSA] LCSSA preserves MemorySSA..
Thu, Apr 18, 3:03 PM · Restricted Project
asbirlea updated the summary of D60832: [MemorySSA] LCSSA preserves MemorySSA..
Thu, Apr 18, 3:03 PM · Restricted Project
asbirlea updated the diff for D60832: [MemorySSA] LCSSA preserves MemorySSA..

Simplify patch to only rpeserve and not require.

Thu, Apr 18, 3:03 PM · Restricted Project
asbirlea updated the diff for D59723: [NewPassManager] Adding pass tuning options: loop vectorize..

Rebase after change that parses vectorize flags.

Thu, Apr 18, 10:21 AM · Restricted Project
asbirlea created D60876: [TypeBasedAliasAnalysis] Cache TBAA results in BatchAA..
Thu, Apr 18, 9:42 AM · Restricted Project

Wed, Apr 17

asbirlea added inline comments to D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Wed, Apr 17, 10:39 AM · Restricted Project
asbirlea added a parent revision for D60832: [MemorySSA] LCSSA preserves MemorySSA.: D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Wed, Apr 17, 10:34 AM · Restricted Project
asbirlea added a child revision for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests.: D60832: [MemorySSA] LCSSA preserves MemorySSA..
Wed, Apr 17, 10:34 AM · Restricted Project
asbirlea added a parent revision for D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA.: D60832: [MemorySSA] LCSSA preserves MemorySSA..
Wed, Apr 17, 10:34 AM · Restricted Project
asbirlea added a child revision for D60832: [MemorySSA] LCSSA preserves MemorySSA.: D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..
Wed, Apr 17, 10:34 AM · Restricted Project
asbirlea created D60833: [MemorySSA] Teach LoopSimplify to preserve MemorySSA..
Wed, Apr 17, 10:33 AM · Restricted Project
asbirlea created D60832: [MemorySSA] LCSSA preserves MemorySSA..
Wed, Apr 17, 10:29 AM · Restricted Project

Fri, Apr 12

asbirlea created D60638: [LoopUnroll] Move list of params into a struct [NFCI]..
Fri, Apr 12, 3:36 PM · Restricted Project
asbirlea committed rGf9f073a861da: [MemorySSA] Add previous def to cache when found, even if trivial. (authored by asbirlea).
[MemorySSA] Add previous def to cache when found, even if trivial.
Fri, Apr 12, 3:00 PM
asbirlea committed rL358313: [MemorySSA] Add previous def to cache when found, even if trivial..
[MemorySSA] Add previous def to cache when found, even if trivial.
Fri, Apr 12, 2:57 PM
asbirlea closed D60634: [MemorySSA] Add previous def to cache when found, even if trivial..
Fri, Apr 12, 2:57 PM · Restricted Project
asbirlea updated the diff for D60634: [MemorySSA] Add previous def to cache when found, even if trivial..

Thank you for the review!

Fri, Apr 12, 2:50 PM · Restricted Project
asbirlea created D60634: [MemorySSA] Add previous def to cache when found, even if trivial..
Fri, Apr 12, 1:52 PM · Restricted Project
asbirlea committed rG2312a06c8720: [SCEV] Add option to forget everything in SCEV. (authored by asbirlea).
[SCEV] Add option to forget everything in SCEV.
Fri, Apr 12, 12:17 PM
asbirlea committed rL358304: [SCEV] Add option to forget everything in SCEV..
[SCEV] Add option to forget everything in SCEV.
Fri, Apr 12, 12:17 PM
asbirlea closed D60144: [SCEV] Add option to forget everything in SCEV..
Fri, Apr 12, 12:17 PM · Restricted Project
asbirlea updated the summary of D60144: [SCEV] Add option to forget everything in SCEV..
Fri, Apr 12, 12:05 PM · Restricted Project
asbirlea committed rG57769382b1fb: [MemorySSA] Small fix for the clobber limit. (authored by asbirlea).
[MemorySSA] Small fix for the clobber limit.
Fri, Apr 12, 11:48 AM
asbirlea committed rL358303: [MemorySSA] Small fix for the clobber limit..
[MemorySSA] Small fix for the clobber limit.
Fri, Apr 12, 11:47 AM
asbirlea closed D60479: [MemorySSA] Small fix for the clobber limit..
Fri, Apr 12, 11:47 AM · Restricted Project

Tue, Apr 9

asbirlea added a parent revision for D60490: [LICM & MemorySSA] Make limit flags pass tuning options.: D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Tue, Apr 9, 4:34 PM · Restricted Project
asbirlea added a child revision for D59723: [NewPassManager] Adding pass tuning options: loop vectorize.: D60490: [LICM & MemorySSA] Make limit flags pass tuning options..
Tue, Apr 9, 4:34 PM · Restricted Project
asbirlea created D60490: [LICM & MemorySSA] Make limit flags pass tuning options..
Tue, Apr 9, 4:31 PM · Restricted Project
asbirlea updated the diff for D59723: [NewPassManager] Adding pass tuning options: loop vectorize..

Address comments.

Tue, Apr 9, 2:24 PM · Restricted Project
asbirlea added inline comments to D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Tue, Apr 9, 2:24 PM · Restricted Project
asbirlea created D60479: [MemorySSA] Small fix for the clobber limit..
Tue, Apr 9, 12:00 PM · Restricted Project

Mon, Apr 8

asbirlea added inline comments to D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Mon, Apr 8, 2:38 PM · Restricted Project
asbirlea updated the diff for D59723: [NewPassManager] Adding pass tuning options: loop vectorize..

Attempting to merge defaults to a single cl::opt.
Please note the comments on defaults in lib/Transforms/Vectorize/LoopVectorize.cpp. Feedback there very welcome.

Mon, Apr 8, 12:10 PM · Restricted Project

Fri, Apr 5

asbirlea added inline comments to D60144: [SCEV] Add option to forget everything in SCEV..
Fri, Apr 5, 3:34 PM · Restricted Project
asbirlea added a comment to D60144: [SCEV] Add option to forget everything in SCEV..

IIUC forgetTopmostLoop currently can be quite expensive for loops with lots of subloops/deeply-nested loops, where it has to visit all sub loops and selectively erase a bunch of stuff. And if we manage to unroll a large number of such loops, we have to invalidate most things anyways. Could that be the case in your test case?

Yes, that's almost certain the case.

Fri, Apr 5, 3:34 PM · Restricted Project
asbirlea updated the diff for D60144: [SCEV] Add option to forget everything in SCEV..

Address comments.

Fri, Apr 5, 3:29 PM · Restricted Project

Thu, Apr 4

asbirlea accepted D60171: An unreachable block may have a route to a reachable block, don't fast-path return that it can't..

lgtm.

Thu, Apr 4, 3:30 PM · Restricted Project
asbirlea removed a reviewer for D59065: [BasicAA] Simplify inttoptr(and(ptrtoint(X), C)) to X, if C preserves all significant bits.: asbirlea.
Thu, Apr 4, 9:54 AM · Restricted Project
asbirlea added a comment to D60144: [SCEV] Add option to forget everything in SCEV..

Here are the times I got for compiling the aggregated bitcode files for clang and a few others. Before is ToT, After is with -forget-scev-loop-unroll=true
File Before (s) After (s)
clang-9.bc 7267.91 6639.14
llvm-as.bc 194.12 194.12
llvm-dis.bc 62.50 62.50
opt.bc 1855.85 1857.53

Thu, Apr 4, 9:32 AM · Restricted Project

Tue, Apr 2

asbirlea added a comment to D60144: [SCEV] Add option to forget everything in SCEV..

I'm looking to see if a reduced case I have can be open-sourced in a PR and have this patch point to it.

Tue, Apr 2, 2:37 PM · Restricted Project
asbirlea added a comment to D58560: [AST] Set 'MayAlias' instead of 'MustAlias' in AliasSets for PHI nodes (bugzilla bug#36801).

Following the introduction of BatchAA (https://reviews.llvm.org/D59315), this patch is certainly *not* an option, because it would block using BatchAA in the AliasSetTracker (https://reviews.llvm.org/D59438). Using BatchAA is not correct if there are subsequent alias calls after doing CFG changes. And calling addPointer with anything but true as the next to last argument may make an alias call.

Tue, Apr 2, 2:15 PM · Restricted Project
asbirlea abandoned D35741: Add MemorySSA alternative to AliasSetTracker in LICM..

Stale, no longer applies.

Tue, Apr 2, 12:00 PM
asbirlea created D60144: [SCEV] Add option to forget everything in SCEV..
Tue, Apr 2, 11:55 AM · Restricted Project

Mon, Apr 1

asbirlea accepted D60085: Add an optional list of blocks to avoid when looking for a path in isPotentiallyReachable..

LGTM, modulo one nit. Thank you!

Mon, Apr 1, 5:06 PM · Restricted Project
asbirlea accepted D60082: Not all blocks are reachable from entry. Don't assume they are..

Thank you for this!

Mon, Apr 1, 11:59 AM · Restricted Project
asbirlea accepted D60084: [NFC] Remove dead parameter "FreeInLoop", fix some typos and trailing whitespace..

Thank you for the cleanup!

Mon, Apr 1, 11:56 AM · Restricted Project
asbirlea added a comment to D60056: Hoist/sink malloc/free's in LICM..

A couple of quick comments.
Would you mind splitting the cleanups and bug fix (which will be straightforward to approve) and rebase this on top of that?

Mon, Apr 1, 11:10 AM · Restricted Project

Fri, Mar 29

asbirlea committed rGc8d6e0496dc3: [MemorySSA] Temporary fix assert when reaching 0 limit. (authored by asbirlea).
[MemorySSA] Temporary fix assert when reaching 0 limit.
Fri, Mar 29, 3:55 PM
asbirlea committed rL357327: [MemorySSA] Temporary fix assert when reaching 0 limit..
[MemorySSA] Temporary fix assert when reaching 0 limit.
Fri, Mar 29, 3:54 PM
asbirlea committed rGf085cc5aa7c1: [MemorySSA] Limit clobber walks. (authored by asbirlea).
[MemorySSA] Limit clobber walks.
Fri, Mar 29, 2:57 PM
asbirlea committed rL357319: [MemorySSA] Limit clobber walks..
[MemorySSA] Limit clobber walks.
Fri, Mar 29, 2:57 PM
asbirlea closed D59569: [MemorySSA] Limit clobber walks..
Fri, Mar 29, 2:56 PM · Restricted Project
asbirlea added a comment to D59569: [MemorySSA] Limit clobber walks..

Thank you for the review!

Fri, Mar 29, 2:56 PM · Restricted Project
asbirlea accepted D60010: [SCEV] Check the cache in get{S|U}MaxExpr before doing any work.

Thank you for the fix!

Fri, Mar 29, 2:38 PM · Restricted Project
asbirlea committed rGe589067e618f: [MemorySSA] Don't optimize incomplete phis. (authored by asbirlea).
[MemorySSA] Don't optimize incomplete phis.
Fri, Mar 29, 2:16 PM
asbirlea committed rL357315: [MemorySSA] Don't optimize incomplete phis..
[MemorySSA] Don't optimize incomplete phis.
Fri, Mar 29, 2:16 PM
asbirlea closed D59966: [MemorySSA] Don't optimize incomplete phis..
Fri, Mar 29, 2:15 PM · Restricted Project
asbirlea added inline comments to D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Fri, Mar 29, 1:53 PM · Restricted Project
asbirlea updated the diff for D59723: [NewPassManager] Adding pass tuning options: loop vectorize..

Address comments and asking for clarifications.

Fri, Mar 29, 1:53 PM · Restricted Project
asbirlea added inline comments to D59966: [MemorySSA] Don't optimize incomplete phis..
Fri, Mar 29, 11:52 AM · Restricted Project

Thu, Mar 28

asbirlea added a comment to D59723: [NewPassManager] Adding pass tuning options: loop vectorize..

ping.

Thu, Mar 28, 5:05 PM · Restricted Project
asbirlea updated the diff for D59569: [MemorySSA] Limit clobber walks..

format.

Thu, Mar 28, 4:57 PM · Restricted Project
asbirlea added inline comments to D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..
Thu, Mar 28, 4:52 PM · Restricted Project
asbirlea updated the diff for D59569: [MemorySSA] Limit clobber walks..

Address comments.

Thu, Mar 28, 4:49 PM · Restricted Project
asbirlea created D59966: [MemorySSA] Don't optimize incomplete phis..
Thu, Mar 28, 3:15 PM · Restricted Project
asbirlea accepted D59954: [InterleavedAccessPass] Don't increase the number of bytes loaded..

LGTM. Thank you!

Thu, Mar 28, 1:28 PM · Restricted Project

Fri, Mar 22

asbirlea created D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Fri, Mar 22, 3:29 PM · Restricted Project
asbirlea committed rGbfc779e49109: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state. (authored by asbirlea).
[AliasAnalysis] Second prototype to cache BasicAA / anyAA state.
Fri, Mar 22, 10:23 AM
asbirlea committed rL356783: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..
[AliasAnalysis] Second prototype to cache BasicAA / anyAA state.
Fri, Mar 22, 10:21 AM
asbirlea closed D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..
Fri, Mar 22, 10:21 AM · Restricted Project

Thu, Mar 21

asbirlea added inline comments to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..
Thu, Mar 21, 5:04 PM · Restricted Project
asbirlea updated the diff for D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

Rewrite some of the documentation.

Thu, Mar 21, 4:38 PM · Restricted Project
asbirlea added a comment to D58560: [AST] Set 'MayAlias' instead of 'MustAlias' in AliasSets for PHI nodes (bugzilla bug#36801).

Getting back to this, do you have a suggestion for making progress on fixing this mis-compile?
Is the alternative in D58746 an option?

Thu, Mar 21, 12:19 PM · Restricted Project
asbirlea updated the diff for D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

Creating the QueryInfo on the stack and removing the clear method.

Thu, Mar 21, 11:55 AM · Restricted Project

Wed, Mar 20

asbirlea added a comment to D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..

Thank you for the comments!
Quick answer before addressing the rest of the comments: the missing clear() calls were intentional, since they're redundant. The calls that don't call clear() are just wrappers over the methods that do call clear(). These wrappers are over a single call so there wouldn't be any benefit from not clearing inside the wrapped method, even if we could.
I'm not sure if it's preferable to add the redundant calls for consistency or safety if things change in the future, or add comments explaining why they're not needed today.

Wed, Mar 20, 10:21 PM · Restricted Project
asbirlea updated the summary of D59315: [AliasAnalysis] Second prototype to cache BasicAA / anyAA state..
Wed, Mar 20, 10:11 PM · Restricted Project
asbirlea committed rG4fdbd822fc1a: [BasicAA] Reduce no of map seaches [NFCI]. (authored by asbirlea).
[BasicAA] Reduce no of map seaches [NFCI].
Wed, Mar 20, 10:02 PM
asbirlea committed rL356644: [BasicAA] Reduce no of map seaches [NFCI]..
[BasicAA] Reduce no of map seaches [NFCI].
Wed, Mar 20, 10:01 PM
asbirlea closed D59151: [BasicAA] Reduce no of map searches. Assert map entry exists. [NFCI].
Wed, Mar 20, 10:01 PM · Restricted Project
asbirlea updated the diff for D58311: [MemorySSA & LoopPassManager] Enable MemorySSA as loop dependency. Update tests..

Rebase and ping for comments.

Wed, Mar 20, 1:31 PM · Restricted Project
asbirlea committed rGf69f80732172: [NFC] Fix brace indentation. (authored by asbirlea).
[NFC] Fix brace indentation.
Wed, Mar 20, 12:18 PM
asbirlea committed rL356596: [NFC] Fix brace indentation..
[NFC] Fix brace indentation.
Wed, Mar 20, 12:18 PM