asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (145 w, 17 h)

Recent Activity

Tue, Nov 13

asbirlea committed rL346798: [MemorySSA] Create query after checking if instruction is a fence..
[MemorySSA] Create query after checking if instruction is a fence.
Tue, Nov 13, 1:15 PM

Wed, Nov 7

asbirlea accepted D54211: [SimpleLoopUnswitch] partial unswitch needs to be careful when replacing invariants with constants.

Great catch, thank you for fixing this and for the additional tests.

Wed, Nov 7, 10:13 AM

Mon, Nov 5

asbirlea added inline comments to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.
Mon, Nov 5, 10:09 AM

Fri, Nov 2

asbirlea added a comment to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.

MemorySSA is an analysis, all info is kept "on the side". It's standalone and no info is kept in BBs.
Some doc can be found here: http://releases.llvm.org/6.0.1/docs/MemorySSA.html

Fri, Nov 2, 9:59 AM

Thu, Nov 1

asbirlea committed rL345911: [AliasSetTracker] Misc cleanup (NFCI).
[AliasSetTracker] Misc cleanup (NFCI)
Thu, Nov 1, 4:40 PM
asbirlea added a comment to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.

FWIW, long term DSE should ideally use MemorySSA instead of MemoryDependenceResults.
But this particular optimization has a high chance of being useful even then.

Thu, Nov 1, 2:20 PM
asbirlea updated subscribers of D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.
Thu, Nov 1, 2:09 PM
asbirlea added a comment to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.

I have mixed feelings here because I understand Chris's point, but there are differences in this case which make this patch worth pushing forward IMO.

Thu, Nov 1, 2:09 PM

Wed, Oct 31

asbirlea added inline comments to D53203: Allow MemoryLocation to carry pre-existing knowledge to AA to elide expensive repeated checks.
Wed, Oct 31, 12:04 PM

Tue, Oct 30

asbirlea added a comment to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

Let me re-purpose this patch:
Is there a point to having deleteValue()?
Is there a point to having the ref count (addRef, dropRef) for alias sets?

Tue, Oct 30, 4:42 PM

Mon, Oct 29

asbirlea added inline comments to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..
Mon, Oct 29, 4:25 PM
asbirlea added a comment to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

I agree with all your points! Thank you for following up.

Mon, Oct 29, 4:14 PM
asbirlea committed rL345548: [AliasSetTracker] Cleanup addPointer interface. [NFCI].
[AliasSetTracker] Cleanup addPointer interface. [NFCI]
Mon, Oct 29, 3:28 PM
asbirlea closed D53836: [AliasSetTracker] Cleanup addPointer interface. [NFCI].
Mon, Oct 29, 3:28 PM
asbirlea created D53836: [AliasSetTracker] Cleanup addPointer interface. [NFCI].
Mon, Oct 29, 2:50 PM
asbirlea added a reviewer for D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker.: mkazantsev.
Mon, Oct 29, 1:52 PM

Fri, Oct 26

asbirlea committed rC345446: Revert r345170 [along with its llvm counterpart r345169] as it makes Halide….
Revert r345170 [along with its llvm counterpart r345169] as it makes Halide…
Fri, Oct 26, 9:53 PM
asbirlea committed rL345447: Revert r345169 [along with its llvm counterpart r345170] as it makes Halide….
Revert r345169 [along with its llvm counterpart r345170] as it makes Halide…
Fri, Oct 26, 9:53 PM
asbirlea committed rL345446: Revert r345170 [along with its llvm counterpart r345169] as it makes Halide….
Revert r345170 [along with its llvm counterpart r345169] as it makes Halide…
Fri, Oct 26, 9:53 PM
asbirlea updated the diff for D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

clang-format. Thank you!

Fri, Oct 26, 9:31 PM
asbirlea created D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..
Fri, Oct 26, 5:21 PM

Wed, Oct 24

asbirlea added a comment to D47022: Update MemorySSA in SimpleLoopUnswitch..

Gentle ping.

Wed, Oct 24, 4:18 PM
asbirlea committed rL345216: Update MemorySSA in LoopRotate..
Update MemorySSA in LoopRotate.
Wed, Oct 24, 3:49 PM
asbirlea closed D51718: Update MemorySSA in LoopRotate..
Wed, Oct 24, 3:48 PM

Oct 22 2018

asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Test updated. Thank you for the review!

Oct 22 2018, 5:12 PM

Sep 24 2018

asbirlea added inline comments to D51718: Update MemorySSA in LoopRotate..
Sep 24 2018, 2:36 PM
asbirlea updated the diff for D40375: Use MemorySSA in LICM to do sinking and hoisting..

Rebase patch after resect changes.

Sep 24 2018, 1:11 PM

Sep 20 2018

asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Update pr35210.ll after recent upstream changes.

Sep 20 2018, 2:26 PM
asbirlea added inline comments to D51718: Update MemorySSA in LoopRotate..
Sep 20 2018, 1:28 PM

Sep 17 2018

asbirlea committed rL342422: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures….
[EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures…
Sep 17 2018, 3:37 PM
asbirlea closed D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..
Sep 17 2018, 3:36 PM
asbirlea updated the diff for D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..

Thank you for the review!

Sep 17 2018, 3:10 PM

Sep 11 2018

asbirlea abandoned D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Dropping this, since the issue is not resolvable in general AFAICT. Please see D51960.

Sep 11 2018, 4:49 PM
asbirlea abandoned D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Sep 11 2018, 4:49 PM
asbirlea created D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..
Sep 11 2018, 4:49 PM
asbirlea committed rL341984: Update MemorySSA in LoopUnswitch..
Update MemorySSA in LoopUnswitch.
Sep 11 2018, 12:20 PM
asbirlea closed D45301: Update MemorySSA in LoopUnswitch..
Sep 11 2018, 12:20 PM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Moving the MSSA after cloning earlier to avoid the ValueMap invalidation.
Adding another test.
And ping.

Sep 11 2018, 11:48 AM

Sep 10 2018

asbirlea added a reverting commit for rL341674: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely…: rL341883: [InstCombine] Partially revert rL341674 due to PR38897..
Sep 10 2018, 4:48 PM
asbirlea committed rL341883: [InstCombine] Partially revert rL341674 due to PR38897..
[InstCombine] Partially revert rL341674 due to PR38897.
Sep 10 2018, 4:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sep 10 2018, 4:48 PM
asbirlea created D51897: [InstCombine] Partially revert rL341674 due to PR38897..
Sep 10 2018, 4:48 PM
asbirlea committed rL341855: API to update MemorySSA for cloned blocks and added CFG edges..
API to update MemorySSA for cloned blocks and added CFG edges.
Sep 10 2018, 1:14 PM
asbirlea closed D45299: API to update MemorySSA for cloned blocks..
Sep 10 2018, 1:14 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Final update before commit: changing a cast_or_null to dyn_cast_or_null for cloned instructions. LoopRotate can place Value in the map, as the clone of an instruction.

Sep 10 2018, 11:49 AM

Sep 7 2018

asbirlea committed rL341733: [MemorySSA] Relax verification of clobbering accesses..
[MemorySSA] Relax verification of clobbering accesses.
Sep 7 2018, 4:52 PM
asbirlea committed rL341709: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if….
[MemorySSA] Update MemoryPhi wiring for block splitting to consider if…
Sep 7 2018, 2:16 PM
asbirlea closed D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..
Sep 7 2018, 2:16 PM
asbirlea updated the diff for D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..

Nit: remove braces.

Sep 7 2018, 1:50 PM
asbirlea added inline comments to D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..
Sep 7 2018, 1:45 PM
asbirlea updated the diff for D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..

Address comment. Thank you for the review!

Sep 7 2018, 1:44 PM

Sep 6 2018

asbirlea updated the diff for D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Adding third test-case for new failure.

Sep 6 2018, 4:49 PM
asbirlea updated the diff for D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..

Avoid duplicates (use set).

Sep 6 2018, 4:13 PM
asbirlea updated the diff for D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Add test for second failure.

Sep 6 2018, 3:43 PM
asbirlea updated the diff for D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..

Need to bypass geps when traversing users, use worklist.
Adding test in dependent patch.

Sep 6 2018, 3:43 PM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Update test and format.

Sep 6 2018, 2:20 PM
asbirlea committed rL341587: [LoopPassManager] MemorySSA should be preserved when enabled..
[LoopPassManager] MemorySSA should be preserved when enabled.
Sep 6 2018, 1:55 PM
asbirlea updated the summary of D51718: Update MemorySSA in LoopRotate..
Sep 6 2018, 11:58 AM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Enable tests. Add new tests to check analysis is preserved.

Sep 6 2018, 11:57 AM

Sep 5 2018

asbirlea created D51718: Update MemorySSA in LoopRotate..
Sep 5 2018, 11:31 PM
asbirlea added a dependent revision for D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction.: D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..
Sep 5 2018, 11:25 PM
asbirlea added a dependency for D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions.: D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Sep 5 2018, 11:25 PM
asbirlea created D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..
Sep 5 2018, 11:09 PM
asbirlea created D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Sep 5 2018, 11:00 PM
asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

Thank you for the patience on this review! :)

Sep 5 2018, 5:19 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Small update triggered by a test in rotate (patch to be uploaded soon).

Sep 5 2018, 5:13 PM

Sep 4 2018

asbirlea accepted D51519: [SimpleLoopUnswitch] remove a chain of dead blocks at once.
Sep 4 2018, 10:05 AM

Aug 31 2018

asbirlea created D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..
Aug 31 2018, 5:13 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Fix bug introduced by refactoring.

Aug 31 2018, 2:42 PM

Aug 30 2018

asbirlea added inline comments to D51519: [SimpleLoopUnswitch] remove a chain of dead blocks at once.
Aug 30 2018, 4:32 PM

Aug 29 2018

asbirlea committed rL340995: [MemorySSA] Silence warning..
[MemorySSA] Silence warning.
Aug 29 2018, 4:23 PM
asbirlea committed rL340981: [MemorySSA] Fix checkClobberSanity to skip Start only for Defs and Uses..
[MemorySSA] Fix checkClobberSanity to skip Start only for Defs and Uses.
Aug 29 2018, 3:39 PM
asbirlea committed rL340951: [MemorySSA] Add expesive check for validating clobber accesses..
[MemorySSA] Add expesive check for validating clobber accesses.
Aug 29 2018, 11:28 AM
asbirlea closed D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Aug 29 2018, 11:28 AM
asbirlea updated the diff for D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Missed an update.

Aug 29 2018, 11:15 AM
asbirlea updated the diff for D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Fix nit.

Aug 29 2018, 11:11 AM
asbirlea accepted D51415: [SimpleLoopUnswitch] After unswitch delete dead blocks in parent loops.

This LGTM.
FWIW, I think we're having an underlying problem and this and the previous PRs may be related.
In unswitchTrivialSwitch, at the very beginning we're removing switch cases and querying LoopInfo to get the outer loop for each switch successor without updating it. LoopInfo is updated only at the very end in hoistLoopToNewParent. Adding an artificial assert to check if LI should be updated after removing switch cases, triggers on 2/3 tests from D51375 and existing trivial-unswitch tests. Looking into it further.

Aug 29 2018, 11:00 AM

Aug 28 2018

asbirlea added inline comments to D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Aug 28 2018, 2:54 PM
asbirlea added inline comments to D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Aug 28 2018, 2:51 PM
asbirlea updated the diff for D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Address comments. Undo const-ifies no longer needed.

Aug 28 2018, 2:48 PM
asbirlea committed rL340871: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..
[SimpleLoopUnswitch] Form dedicated exits after trivial unswitches.
Aug 28 2018, 1:42 PM
asbirlea closed D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..
Aug 28 2018, 1:42 PM
asbirlea updated the diff for D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..

Updated test, thank you for the comments!

Aug 28 2018, 1:38 PM
asbirlea created D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..
Aug 28 2018, 12:28 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Address comments.

Aug 28 2018, 11:22 AM
asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

I'm planning to add a few more unittests, but sending the updates now for additional comments.

Aug 28 2018, 11:21 AM

Aug 27 2018

asbirlea created D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Aug 27 2018, 3:01 PM

Aug 23 2018

asbirlea committed rL340581: [IDF] Make GraphDiff a const constructor argument..
[IDF] Make GraphDiff a const constructor argument.
Aug 23 2018, 2:57 PM
asbirlea committed rL340567: Remove the use of pair inside the tuple in concat_iterator..
Remove the use of pair inside the tuple in concat_iterator.
Aug 23 2018, 11:47 AM
asbirlea closed D51067: Remove the use of pair inside the tuple in concat_iterator..
Aug 23 2018, 11:47 AM

Aug 22 2018

asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

Thanks a lot of the comments, working to address them.

Aug 22 2018, 6:03 PM
asbirlea updated the summary of D51067: Remove the use of pair inside the tuple in concat_iterator..
Aug 22 2018, 2:15 PM
asbirlea added a comment to D50911: Update MemorySSA in LoopSimplifyCFG..

Thank you for the review!

Aug 22 2018, 1:13 PM
asbirlea committed rL340445: Update MemorySSA in LoopSimplifyCFG..
Update MemorySSA in LoopSimplifyCFG.
Aug 22 2018, 1:11 PM
asbirlea closed D50911: Update MemorySSA in LoopSimplifyCFG..
Aug 22 2018, 1:11 PM
asbirlea added a comment to D50906: Update MemorySSA in LoopInstSimplify..

Thank you for the review!

Aug 22 2018, 1:07 PM
asbirlea committed rL340444: Update MemorySSA in LoopInstSimplify..
Update MemorySSA in LoopInstSimplify.
Aug 22 2018, 1:06 PM
asbirlea closed D50906: Update MemorySSA in LoopInstSimplify..
Aug 22 2018, 1:06 PM
asbirlea added a reviewer for D47022: Update MemorySSA in SimpleLoopUnswitch.: chandlerc.
Aug 22 2018, 12:16 PM
asbirlea updated the summary of D47022: Update MemorySSA in SimpleLoopUnswitch..
Aug 22 2018, 12:16 PM