Page MenuHomePhabricator

asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (191 w, 6 d)

Recent Activity

Yesterday

asbirlea updated the diff for D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..

Update iterator var names.

Tue, Oct 15, 11:45 AM · Restricted Project
asbirlea updated the diff for D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..

Nit: rename optional argument.
I'd like to check this in, in an effort to clear my patch queue. Please let me know if you have any comments.

Tue, Oct 15, 10:48 AM · Restricted Project
asbirlea committed rG3de89f3416bf: [NewGVN] Check that call has an access. (authored by asbirlea).
[NewGVN] Check that call has an access.
Tue, Oct 15, 10:30 AM
asbirlea committed rL374920: [NewGVN] Check that call has an access..
[NewGVN] Check that call has an access.
Tue, Oct 15, 10:30 AM
asbirlea committed rG35c8af185066: [MemorySSA] Update DomTree before applying MSSA updates. (authored by asbirlea).
[MemorySSA] Update DomTree before applying MSSA updates.
Tue, Oct 15, 10:20 AM
asbirlea committed rL374918: [MemorySSA] Update DomTree before applying MSSA updates..
[MemorySSA] Update DomTree before applying MSSA updates.
Tue, Oct 15, 10:20 AM

Mon, Oct 14

asbirlea committed rGb7a3353061e9: [MemorySSA] Update for partial unswitch. (authored by asbirlea).
[MemorySSA] Update for partial unswitch.
Mon, Oct 14, 5:00 PM
asbirlea committed rL374850: [MemorySSA] Update for partial unswitch..
[MemorySSA] Update for partial unswitch.
Mon, Oct 14, 4:50 PM

Thu, Oct 10

asbirlea committed rG6442b5697433: [MemorySSA] Update Phi simplification. (authored by asbirlea).
[MemorySSA] Update Phi simplification.
Thu, Oct 10, 4:26 PM
asbirlea committed rL374471: [MemorySSA] Update Phi simplification..
[MemorySSA] Update Phi simplification.
Thu, Oct 10, 4:26 PM
asbirlea committed rG67f0c5c08578: [MemorySSA] Additional handling of unreachable blocks. (authored by asbirlea).
[MemorySSA] Additional handling of unreachable blocks.
Thu, Oct 10, 1:46 PM
asbirlea committed rL374447: [MemorySSA] Additional handling of unreachable blocks..
[MemorySSA] Additional handling of unreachable blocks.
Thu, Oct 10, 1:46 PM
asbirlea closed D68809: [MemorySSA] Additional handling of unreachable blocks..
Thu, Oct 10, 1:46 PM · Restricted Project
asbirlea added a comment to D68809: [MemorySSA] Additional handling of unreachable blocks..

Thank you for the review!

Thu, Oct 10, 1:37 PM · Restricted Project
asbirlea created D68809: [MemorySSA] Additional handling of unreachable blocks..
Thu, Oct 10, 9:36 AM · Restricted Project

Wed, Oct 9

asbirlea committed rG7faa14a98bdc: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent. (authored by asbirlea).
[MemorySSA] Make the use of moveAllAfterMergeBlocks consistent.
Wed, Oct 9, 8:54 AM
asbirlea committed rL374177: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent..
[MemorySSA] Make the use of moveAllAfterMergeBlocks consistent.
Wed, Oct 9, 8:54 AM
asbirlea closed D68659: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent..
Wed, Oct 9, 8:54 AM · Restricted Project
asbirlea added inline comments to D68659: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent..
Wed, Oct 9, 8:53 AM · Restricted Project
asbirlea updated the diff for D68659: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent..

Address comments.

Wed, Oct 9, 8:53 AM · Restricted Project

Tue, Oct 8

asbirlea created D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..
Tue, Oct 8, 4:18 PM · Restricted Project
asbirlea created D68659: [MemorySSA] Make the use of moveAllAfterMergeBlocks consistent..
Tue, Oct 8, 12:22 PM · Restricted Project

Mon, Oct 7

asbirlea accepted D68573: [LoopRotate] Unconditionally get ScalarEvolution..

lgtm.

Mon, Oct 7, 1:27 PM · Restricted Project
asbirlea added a comment to D68535: Fix loop unrolling initialization in the new pass manager.

Maybe elaborate in the patch description what determine when and how we will unroll loops. means?
e.g.:
"The default before and after this patch is for LoopUnroll to be enabled, and for it to use a cost model to determine whether to unroll the loop (OnlyWhenForced = false). Before this patch, disabling loop unroll would not run the LoopUnroll pass. After this patch, the LoopUnroll pass is being run, but it restricts unrolling to only the loops marked by a pragma (OnlyWhenForced = true).
In addition, this patch disables the UnrollAndJam pass when disabling unrolling."

Mon, Oct 7, 9:36 AM · Restricted Project, Restricted Project

Thu, Oct 3

asbirlea committed rG145cdad11925: [MemorySSA] Don't hoist stores if interfering uses (as calls) exist. (authored by asbirlea).
[MemorySSA] Don't hoist stores if interfering uses (as calls) exist.
Thu, Oct 3, 3:20 PM
asbirlea committed rL373674: [MemorySSA] Don't hoist stores if interfering uses (as calls) exist..
[MemorySSA] Don't hoist stores if interfering uses (as calls) exist.
Thu, Oct 3, 3:18 PM

Wed, Oct 2

asbirlea committed rG24ae5ce54b98: [MemorySSA] Update Phi creation when inserting a Def. (authored by asbirlea).
[MemorySSA] Update Phi creation when inserting a Def.
Wed, Oct 2, 11:43 AM
asbirlea committed rL373505: [MemorySSA] Update Phi creation when inserting a Def..
[MemorySSA] Update Phi creation when inserting a Def.
Wed, Oct 2, 11:40 AM
asbirlea accepted D68327: [Local] Handle terminators with users in removeUnreachableBlocks..

Thank you for this!
LGTM.

Wed, Oct 2, 10:15 AM · Restricted Project

Tue, Oct 1

asbirlea added inline comments to D68297: [Local] Remove unused LazyValueInfo pointer from removeUnreachableBlock..
Tue, Oct 1, 2:45 PM · Restricted Project
asbirlea added a comment to D68170: Fix MSSA update in MergeBlockIntoPredecessor.

I'm seeing the attached test pass at ToT now.
I may have resolved it in rL373380, which was failing to remove trivial Phis when inserting a backedge block.
Please let me know if you are still seeing issues!

Tue, Oct 1, 12:18 PM
asbirlea committed rG890090f7f58e: [MemorySSA] Check for unreachable blocks when getting last definition. (authored by asbirlea).
[MemorySSA] Check for unreachable blocks when getting last definition.
Tue, Oct 1, 12:09 PM
asbirlea committed rL373383: [MemorySSA] Check for unreachable blocks when getting last definition..
[MemorySSA] Check for unreachable blocks when getting last definition.
Tue, Oct 1, 12:08 PM
asbirlea committed rGae40dfc1e3ce: [MemorySSA] Update last_access_in_block check. (authored by asbirlea).
[MemorySSA] Update last_access_in_block check.
Tue, Oct 1, 11:36 AM
asbirlea committed rL373380: [MemorySSA] Update last_access_in_block check..
[MemorySSA] Update last_access_in_block check.
Tue, Oct 1, 11:36 AM

Mon, Sep 30

asbirlea committed rG0fa07f4276ea: [LegacyPassManager] Deprecate the BasicBlockPass/Manager. (authored by asbirlea).
[LegacyPassManager] Deprecate the BasicBlockPass/Manager.
Mon, Sep 30, 1:20 PM
asbirlea committed rL373254: [LegacyPassManager] Deprecate the BasicBlockPass/Manager..
[LegacyPassManager] Deprecate the BasicBlockPass/Manager.
Mon, Sep 30, 1:15 PM
asbirlea closed D68234: [LegacyPassManager] Deprecate the BasicBlockPass/Manager..
Mon, Sep 30, 1:15 PM · Restricted Project
asbirlea added inline comments to D68234: [LegacyPassManager] Deprecate the BasicBlockPass/Manager..
Mon, Sep 30, 12:27 PM · Restricted Project
asbirlea created D68234: [LegacyPassManager] Deprecate the BasicBlockPass/Manager..
Mon, Sep 30, 10:59 AM · Restricted Project
asbirlea committed rGad888846585f: [LegacyPassManager] Attempt to fix BasicBlockManager (authored by asbirlea).
[LegacyPassManager] Attempt to fix BasicBlockManager
Mon, Sep 30, 10:24 AM
asbirlea committed rL373235: [LegacyPassManager] Attempt to fix BasicBlockManager.
[LegacyPassManager] Attempt to fix BasicBlockManager
Mon, Sep 30, 10:22 AM
asbirlea committed rG8299fd9dee7d: [EarlyCSE] Pass preserves AA. (authored by asbirlea).
[EarlyCSE] Pass preserves AA.
Mon, Sep 30, 10:10 AM
asbirlea committed rL373231: [EarlyCSE] Pass preserves AA..
[EarlyCSE] Pass preserves AA.
Mon, Sep 30, 10:10 AM
asbirlea added a comment to D54730: [DomTree] Fix order of domtree updates in MergeBlockIntoPredecessor..

This already landed in D62981 .

Mon, Sep 30, 10:03 AM · Restricted Project

Wed, Sep 25

asbirlea committed rG6720ed851b04: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks. (authored by asbirlea).
[MemorySSA] Avoid adding Phis in the presence of unreachable blocks.
Wed, Sep 25, 4:29 PM
asbirlea committed rL372932: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..
[MemorySSA] Avoid adding Phis in the presence of unreachable blocks.
Wed, Sep 25, 4:29 PM
asbirlea closed D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..
Wed, Sep 25, 4:28 PM · Restricted Project
asbirlea added inline comments to D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..
Wed, Sep 25, 4:22 PM · Restricted Project
asbirlea updated the diff for D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..

Add testcase.

Wed, Sep 25, 3:25 PM · Restricted Project
asbirlea updated the summary of D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..
Wed, Sep 25, 3:15 PM · Restricted Project

Tue, Sep 24

asbirlea created D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks..
Tue, Sep 24, 4:06 PM · Restricted Project

Mon, Sep 23

asbirlea committed rG2c5e6646ef13: [MemorySSA] Update Phi insertion. (authored by asbirlea).
[MemorySSA] Update Phi insertion.
Mon, Sep 23, 4:51 PM
asbirlea committed rL372673: [MemorySSA] Update Phi insertion..
[MemorySSA] Update Phi insertion.
Mon, Sep 23, 4:49 PM
asbirlea closed D67927: [MemorySSA] Update Phi insertion..
Mon, Sep 23, 4:49 PM · Restricted Project
asbirlea updated the summary of D67927: [MemorySSA] Update Phi insertion..
Mon, Sep 23, 2:00 PM · Restricted Project
asbirlea created D67927: [MemorySSA] Update Phi insertion..
Mon, Sep 23, 12:27 PM · Restricted Project

Fri, Sep 20

asbirlea added a comment to D67777: Improve comments terseness in PassBuilder.h.

Thanks for the cleanup! A couple of small comments inline.

Fri, Sep 20, 10:06 AM · Restricted Project

Thu, Sep 19

asbirlea accepted D67672: Don't use invalidated iterators in FlattenCFGPass.

lgtm.

Thu, Sep 19, 10:47 AM · Restricted Project

Tue, Sep 17

asbirlea committed rG4e9082ef95db: [MemorySSA] Fix phi insertion when inserting a def. (authored by asbirlea).
[MemorySSA] Fix phi insertion when inserting a def.
Tue, Sep 17, 9:34 AM
asbirlea added a comment to D67305: [AliasSetTracker] Update AAInfo check..

Gentle ping on this.

Tue, Sep 17, 9:34 AM · Restricted Project
asbirlea committed rL372138: [MemorySSA] Fix phi insertion when inserting a def..
[MemorySSA] Fix phi insertion when inserting a def.
Tue, Sep 17, 9:34 AM
asbirlea closed D67637: [MemorySSA] Fix phi insertion when inserting a def..
Tue, Sep 17, 9:33 AM · Restricted Project
asbirlea committed rG6b2d1346d8ed: [MemorySSA] Update MSSA for non-conventional AA. (authored by asbirlea).
[MemorySSA] Update MSSA for non-conventional AA.
Tue, Sep 17, 9:33 AM
asbirlea committed rL372137: [MemorySSA] Update MSSA for non-conventional AA..
[MemorySSA] Update MSSA for non-conventional AA.
Tue, Sep 17, 9:33 AM
asbirlea closed D67562: [MemorySSA] Update MSSA for non-conventional AA..
Tue, Sep 17, 9:33 AM · Restricted Project
asbirlea updated the diff for D67637: [MemorySSA] Fix phi insertion when inserting a def..

Added const.

Tue, Sep 17, 9:05 AM · Restricted Project

Mon, Sep 16

asbirlea updated the summary of D67637: [MemorySSA] Fix phi insertion when inserting a def..
Mon, Sep 16, 3:25 PM · Restricted Project
asbirlea created D67637: [MemorySSA] Fix phi insertion when inserting a def..
Mon, Sep 16, 3:16 PM · Restricted Project
asbirlea added a comment to D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..

Perhaps worth mentioning that the walker also does phi translation when walking defs upward.

Mon, Sep 16, 2:10 PM · Restricted Project
asbirlea added a comment to D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..

MSSA should have already done this verification. The walker will skip over stores that do not clobber the load or other MemoryAccess-es that do not interfere with the load.
So if there is a Store with the same pointer and different offset, the aliasing result for the two should be that they don't alias, and the walker will continue until it finds an access that does clobber the load.

Mon, Sep 16, 2:07 PM · Restricted Project
asbirlea updated the diff for D67562: [MemorySSA] Update MSSA for non-conventional AA..

Address comments.

Mon, Sep 16, 1:18 PM · Restricted Project
asbirlea added a comment to D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..

Would something like this work for your purpose?

Mon, Sep 16, 12:52 PM · Restricted Project
asbirlea added a comment to D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..

Here are a couple of answers/discussion points:

First of, could you please elaborate a bit more on what you're trying to check for? Is it stores before the loop, after the loop or both?

The idea here is to check stores before the loop and use the store to determine the loaded value in a specific loop iteration. We only do that if we can determine a base pointer + constant offset for a certain loop iteration.

This is the part I do not understand. It looks like the LoadInst is considered "free" and not marked towards the cost of the unroll if there is a store with the same base pointer + offset.
Is that always the case? If there is an interfering MemoryAccess between the two (the walker's answer), then the LoadInst is not free.
I'm not that familiar with the code here, so feel free to correct me if I misunderstood.

Mon, Sep 16, 12:10 PM · Restricted Project
asbirlea added a comment to D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..

Here are a couple of answers/discussion points:

Mon, Sep 16, 10:40 AM · Restricted Project

Sep 13 2019

asbirlea updated the diff for D67562: [MemorySSA] Update MSSA for non-conventional AA..

Make the update in MemorySSA.

Sep 13 2019, 5:28 PM · Restricted Project
asbirlea added a comment to D67562: [MemorySSA] Update MSSA for non-conventional AA..

Why does an instruction which doesn't read or write memory have an associated MemorySSA memory access? Do we assume everything accesses memory if basicaa is disabled?

Except for a few cases, we rely on getModRefInfo to add MemoryAccesses to Instructions, so, yes, without basicaa, we're creating accesses where we shouldn't.

Would it make sense to fix that, instead of adding checks which always fail normally?

Yes, that would make a lot of sense! I was thinking of adding this as as alternative in the patch description so I'm very happy you suggested it.

Sep 13 2019, 2:14 PM · Restricted Project
asbirlea created D67562: [MemorySSA] Update MSSA for non-conventional AA..
Sep 13 2019, 10:33 AM · Restricted Project

Sep 12 2019

asbirlea accepted D67521: [BasicBlockUtils] Add optional BBName argument, in line with BB:splitBasicBlock.

lgtm with a nit: clang-format (some lines seem longer than 80)

Sep 12 2019, 2:12 PM · Restricted Project
asbirlea committed rG18f5204db4a9: [LICM/AST] Check if the AliasAny set is removed from the tracker. (authored by asbirlea).
[LICM/AST] Check if the AliasAny set is removed from the tracker.
Sep 12 2019, 11:09 AM
asbirlea committed rL371752: [LICM/AST] Check if the AliasAny set is removed from the tracker..
[LICM/AST] Check if the AliasAny set is removed from the tracker.
Sep 12 2019, 11:08 AM
asbirlea closed D67417: [LICM/AST] Check if the AliasAny set is removed from the tracker..
Sep 12 2019, 11:08 AM · Restricted Project
asbirlea committed rG6943472d45aa: [MemorySSA] Pass (for update) MSSAU when hoisting instructions. (authored by asbirlea).
[MemorySSA] Pass (for update) MSSAU when hoisting instructions.
Sep 12 2019, 10:12 AM
asbirlea committed rL371748: [MemorySSA] Pass (for update) MSSAU when hoisting instructions..
[MemorySSA] Pass (for update) MSSAU when hoisting instructions.
Sep 12 2019, 10:11 AM
asbirlea closed D67470: [MemorySSA] Pass (for update) MSSAU when hoisting instructions..
Sep 12 2019, 10:11 AM · Restricted Project
asbirlea updated the diff for D67470: [MemorySSA] Pass (for update) MSSAU when hoisting instructions..

Thank you for the suggestion and review.

Sep 12 2019, 10:11 AM · Restricted Project

Sep 11 2019

asbirlea added inline comments to D67305: [AliasSetTracker] Update AAInfo check..
Sep 11 2019, 4:15 PM · Restricted Project
asbirlea added inline comments to D67417: [LICM/AST] Check if the AliasAny set is removed from the tracker..
Sep 11 2019, 3:22 PM · Restricted Project
asbirlea updated the diff for D67417: [LICM/AST] Check if the AliasAny set is removed from the tracker..

Address comments.

Sep 11 2019, 3:22 PM · Restricted Project
asbirlea created D67470: [MemorySSA] Pass (for update) MSSAU when hoisting instructions..
Sep 11 2019, 2:58 PM · Restricted Project

Sep 10 2019

asbirlea committed rGf9cc0393b341: [MemorySSA] MemorySSA should not model debuginfo, and need not update it. (authored by asbirlea).
[MemorySSA] MemorySSA should not model debuginfo, and need not update it.
Sep 10 2019, 4:38 PM
asbirlea committed rL371573: [MemorySSA] MemorySSA should not model debuginfo, and need not update it..
[MemorySSA] MemorySSA should not model debuginfo, and need not update it.
Sep 10 2019, 4:35 PM
asbirlea committed rGa6e0bef3124b: Update ReleaseNotes: add enabling of MemorySSA. (authored by asbirlea).
Update ReleaseNotes: add enabling of MemorySSA.
Sep 10 2019, 4:22 PM
asbirlea committed rL371569: Update ReleaseNotes: add enabling of MemorySSA..
Update ReleaseNotes: add enabling of MemorySSA.
Sep 10 2019, 4:21 PM
asbirlea created D67417: [LICM/AST] Check if the AliasAny set is removed from the tracker..
Sep 10 2019, 4:07 PM · Restricted Project
asbirlea committed rGf7b4022db174: [MemorySSA] Do not create memoryaccesses for debug info intrinsics. (authored by asbirlea).
[MemorySSA] Do not create memoryaccesses for debug info intrinsics.
Sep 10 2019, 3:36 PM
asbirlea committed rL371565: [MemorySSA] Do not create memoryaccesses for debug info intrinsics..
[MemorySSA] Do not create memoryaccesses for debug info intrinsics.
Sep 10 2019, 3:34 PM
asbirlea closed D67307: [MemorySSA] Do not create memoryaccesses for debug info intrinsics..
Sep 10 2019, 3:34 PM · Restricted Project
asbirlea added inline comments to D67305: [AliasSetTracker] Update AAInfo check..
Sep 10 2019, 1:38 PM · Restricted Project
asbirlea updated the diff for D67305: [AliasSetTracker] Update AAInfo check..

Update based on comments.

Sep 10 2019, 1:38 PM · Restricted Project