Page MenuHomePhabricator

asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (206 w, 4 d)

Recent Activity

Fri, Jan 24

asbirlea committed rG0d90d2457c3b: [LoopStrengthReduce] Teach LoopStrengthReduce to preserve MemorySSA is… (authored by asbirlea).
[LoopStrengthReduce] Teach LoopStrengthReduce to preserve MemorySSA is…
Fri, Jan 24, 10:22 AM

Thu, Jan 23

asbirlea committed rG1d091742908f: [LoopStrengthReduce] Reuse utility method to clean dead instructions. [NFCI] (authored by asbirlea).
[LoopStrengthReduce] Reuse utility method to clean dead instructions. [NFCI]
Thu, Jan 23, 4:31 PM
asbirlea committed rG9e66c4ec127e: [Utils] Use WeakTrackingVH in vector used as scratch storage. (authored by asbirlea).
[Utils] Use WeakTrackingVH in vector used as scratch storage.
Thu, Jan 23, 4:12 PM
asbirlea committed rG6770de9b8d93: [LoopIdiomRecognize] Teach LoopIdiomRecognize to preserve MemorySSA. (authored by asbirlea).
[LoopIdiomRecognize] Teach LoopIdiomRecognize to preserve MemorySSA.
Thu, Jan 23, 11:33 AM
asbirlea committed rGa0f627d58428: [IndVarSimplify] Fix for MemorySSA preserve. (authored by asbirlea).
[IndVarSimplify] Fix for MemorySSA preserve.
Thu, Jan 23, 11:07 AM

Wed, Jan 22

asbirlea committed rGadc4faf532bf: [IndVarSimplify] Teach IndVarSimplify to preserve MemorySSA. (authored by asbirlea).
[IndVarSimplify] Teach IndVarSimplify to preserve MemorySSA.
Wed, Jan 22, 4:47 PM
asbirlea committed rGb5b6126d97eb: [IndVarSimplify] Cleanup spaces and reduce variable scope [NFCI] (authored by asbirlea).
[IndVarSimplify] Cleanup spaces and reduce variable scope [NFCI]
Wed, Jan 22, 3:50 PM
asbirlea committed rG6baf31b7c1e1: [LoopIdiomRecognize] Reduce variable scope. [NFCI] (authored by asbirlea).
[LoopIdiomRecognize] Reduce variable scope. [NFCI]
Wed, Jan 22, 3:49 PM
asbirlea committed rGefb130fc9305: [LoopDeletion] Teach LoopDeletion to preserve MemorySSA if available. (authored by asbirlea).
[LoopDeletion] Teach LoopDeletion to preserve MemorySSA if available.
Wed, Jan 22, 11:47 AM
asbirlea added a comment to D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.

SGTM.

Wed, Jan 22, 10:42 AM · Restricted Project
asbirlea accepted D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision.

Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :).
Thank you!

Wed, Jan 22, 10:23 AM · Restricted Project

Tue, Jan 21

asbirlea accepted D73085: NFC. Remove obsolete SimpleAnalysis infrastructure.

LGTM.

Tue, Jan 21, 9:58 AM · Restricted Project
asbirlea accepted D73089: [SSAUpdater] Don't call ValueIsRAUWd upon single use replacement.

LGTM.

Tue, Jan 21, 9:51 AM · Restricted Project
asbirlea accepted D73084: [LICM] NFC. Remove AST caching infrastructure.

Thank you!

Tue, Jan 21, 9:48 AM · Restricted Project
asbirlea accepted D73081: [LICM] Don't cache AliasSetTrackers when run under legacy PM.

Thanks you for taking this on!

Tue, Jan 21, 9:48 AM · Restricted Project

Fri, Jan 17

asbirlea updated the diff for D72893: [NewPassManager] Add assertions when getting statefull cached analysis..

Minor updates.

Fri, Jan 17, 4:08 PM · Restricted Project
asbirlea committed rG9f6c6ee6b9b6: [MemDepAnalysis/VNCoercion] Move static method to its only use. [NFCI] (authored by asbirlea).
[MemDepAnalysis/VNCoercion] Move static method to its only use. [NFCI]
Fri, Jan 17, 3:21 PM
asbirlea committed rG90bdb037276b: Update clang test. (authored by asbirlea).
Update clang test.
Fri, Jan 17, 11:11 AM
asbirlea committed rG54356b4b8118: [UnitTests] Add invalidate methods. (authored by asbirlea).
[UnitTests] Add invalidate methods.
Fri, Jan 17, 10:52 AM
asbirlea committed rG78d4096d037e: [LazyCallGraph] Add invalidate method. (authored by asbirlea).
[LazyCallGraph] Add invalidate method.
Fri, Jan 17, 10:52 AM
asbirlea committed rG630a8011e468: [CallGraph] Add invalidate method. (authored by asbirlea).
[CallGraph] Add invalidate method.
Fri, Jan 17, 10:52 AM
asbirlea committed rG62a50a95fc64: [BrachProbablityInfo] Add invalidate method. (authored by asbirlea).
[BrachProbablityInfo] Add invalidate method.
Fri, Jan 17, 10:52 AM
asbirlea closed D72817: [LazyCallGraph] Add invalidate method..
Fri, Jan 17, 10:52 AM · Restricted Project
asbirlea closed D72816: [CallGraph] Add invalidate method..
Fri, Jan 17, 10:52 AM · Restricted Project
asbirlea closed D72815: [BrachProbablityInfo] Add invalidate method..
Fri, Jan 17, 10:52 AM · Restricted Project
asbirlea committed rG5cc99d05f563: [GlobalsModRef] Add invalidate method (authored by asbirlea).
[GlobalsModRef] Add invalidate method
Fri, Jan 17, 10:42 AM
asbirlea closed D72818: [GlobalsModRef] Add invalidate method.
Fri, Jan 17, 10:42 AM · Restricted Project

Thu, Jan 16

asbirlea added a child revision for D72816: [CallGraph] Add invalidate method.: D72893: [NewPassManager] Add assertions when getting statefull cached analysis..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea added a child revision for D72818: [GlobalsModRef] Add invalidate method: D72893: [NewPassManager] Add assertions when getting statefull cached analysis..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea added a child revision for D72815: [BrachProbablityInfo] Add invalidate method.: D72893: [NewPassManager] Add assertions when getting statefull cached analysis..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea added parent revisions for D72893: [NewPassManager] Add assertions when getting statefull cached analysis.: D72817: [LazyCallGraph] Add invalidate method., D72816: [CallGraph] Add invalidate method., D72815: [BrachProbablityInfo] Add invalidate method., D72818: [GlobalsModRef] Add invalidate method.
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea added a child revision for D72817: [LazyCallGraph] Add invalidate method.: D72893: [NewPassManager] Add assertions when getting statefull cached analysis..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea added a parent revision for D72893: [NewPassManager] Add assertions when getting statefull cached analysis.: D72891: Compute ORE, BPI, BFI in Loop passes..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea added a child revision for D72891: Compute ORE, BPI, BFI in Loop passes.: D72893: [NewPassManager] Add assertions when getting statefull cached analysis..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea created D72893: [NewPassManager] Add assertions when getting statefull cached analysis..
Thu, Jan 16, 5:00 PM · Restricted Project
asbirlea created D72891: Compute ORE, BPI, BFI in Loop passes..
Thu, Jan 16, 4:50 PM · Restricted Project
asbirlea updated the diff for D72815: [BrachProbablityInfo] Add invalidate method..

Nit: remove F.

Thu, Jan 16, 9:54 AM · Restricted Project
asbirlea updated the diff for D72818: [GlobalsModRef] Add invalidate method.

Add comment explaining invalidate rational.
GlobalsAA is stateless and is preserved, unless it's explicitly invalidated.

Thu, Jan 16, 9:54 AM · Restricted Project
asbirlea updated the diff for D72818: [GlobalsModRef] Add invalidate method.

Address comment.

Thu, Jan 16, 9:44 AM · Restricted Project
asbirlea added a comment to D72818: [GlobalsModRef] Add invalidate method.

Not a bug fix, but a prerequisite for a change I'm working on for the new pass manager, requiring all passes to have an invalidate method.
I sent it for review to get another pair of eyes on the invalidate implementation in case I missed something.

Thu, Jan 16, 9:16 AM · Restricted Project

Wed, Jan 15

asbirlea created D72818: [GlobalsModRef] Add invalidate method.
Wed, Jan 15, 5:20 PM · Restricted Project
asbirlea created D72817: [LazyCallGraph] Add invalidate method..
Wed, Jan 15, 5:20 PM · Restricted Project
asbirlea created D72816: [CallGraph] Add invalidate method..
Wed, Jan 15, 5:20 PM · Restricted Project
asbirlea created D72815: [BrachProbablityInfo] Add invalidate method..
Wed, Jan 15, 5:20 PM · Restricted Project
asbirlea added a comment to D72700: [DSE] Add first version of MemorySSA-backed DSE (Bottom up walk)..

Regarding handling the branching example, the solution fhahn proposes sounds reasonable to me.
I was thinking something similar, along the lines of: do the checks bottom-up from both second and third stores during the main algorithm, both find the dead store but do not postdominate it; don't abandon them, but keep this info (include the checks for no intervening reads) for after the main search. The data structure could be a Hashmap<PotentialDeadStore, ListOfDefsOrBlocksWhoFoundThisPotentialDeadStore>. If all paths are covered in the List for a PotentialDeadStore, then it's truly dead.

Wed, Jan 15, 12:32 PM · Restricted Project

Tue, Jan 14

asbirlea added a comment to D72631: [DSE] Eliminate stores at the end of the function..

Just a general comment here: DSE shouldn't necessarily make all optimizations possible. This one looks like it should be caught by DCE. If it's not, perhaps it would be good to improve DCE. Alternatively, if it's cheap enough, add a comment that it's still worth adding it to DSE.

Tue, Jan 14, 2:17 PM · Restricted Project
asbirlea added a comment to D72732: [GVN] introduce GVNOptions to control GVN pass behavior.

Thanks, this looks useful!

Tue, Jan 14, 1:38 PM · Restricted Project
asbirlea added a comment to D72146: [DSE] Add first version of MemorySSA-backed DSE..

Thank you for the other patch! I added a few comments on the bottom up approach. I think overall it's a better high-level approach.

Tue, Jan 14, 12:40 PM · Restricted Project
asbirlea added inline comments to D72700: [DSE] Add first version of MemorySSA-backed DSE (Bottom up walk)..
Tue, Jan 14, 12:40 PM · Restricted Project

Mon, Jan 13

asbirlea added a comment to D72146: [DSE] Add first version of MemorySSA-backed DSE..

Some comments inline.

Mon, Jan 13, 5:09 PM · Restricted Project

Thu, Jan 2

asbirlea committed rGa0d496d5b06b: [NewPassManager] Rename AM to OuterAM in the OuterAnalysisManagerProxy [NFCI]. (authored by asbirlea).
[NewPassManager] Rename AM to OuterAM in the OuterAnalysisManagerProxy [NFCI].
Thu, Jan 2, 9:49 AM

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG96e96e0243ea: NFC: Add doc for id-punct PiperOrigin-RevId: 265190168 (authored by asbirlea).
NFC: Add doc for id-punct PiperOrigin-RevId: 265190168
Dec 23 2019, 8:50 PM

Dec 12 2019

asbirlea added a comment to D67612: [UnrolledInstAnalyzer] Use MSSA to find stored values outside of loop..

Sorry, I forgot about this one, thank you for the reminder!

Dec 12 2019, 2:20 PM · Restricted Project

Dec 10 2019

asbirlea accepted D71264: [BasicAA] Use GEP as context for computeKnownBits in aliasGEP..

lgtm, thank you!

Dec 10 2019, 10:09 AM · Restricted Project

Dec 6 2019

asbirlea committed rGc7faa6814248: Revert "ARM-Darwin: keep the frame register reserved even if not updated." (authored by asbirlea).
Revert "ARM-Darwin: keep the frame register reserved even if not updated."
Dec 6 2019, 11:01 AM
asbirlea added a reverting change for rGa7d90af1be48: ARM-Darwin: keep the frame register reserved even if not updated.: rGc7faa6814248: Revert "ARM-Darwin: keep the frame register reserved even if not updated.".
Dec 6 2019, 11:01 AM
asbirlea added a comment to rGa7d90af1be48: ARM-Darwin: keep the frame register reserved even if not updated..

This revision appears to be the root-cause of https://bugs.llvm.org/show_bug.cgi?id=44231.

Dec 6 2019, 10:22 AM

Dec 5 2019

asbirlea added a comment to rL373738: ARM-Darwin: keep the frame register reserved even if not updated..

Filed https://bugs.llvm.org/show_bug.cgi?id=44231 with a small reproducer.

Dec 5 2019, 4:33 PM
asbirlea added a comment to rL373738: ARM-Darwin: keep the frame register reserved even if not updated..

This revision came back as the root-cause for an internal iOS crash.
It's hitting the following assertion:
assert.h assertion failed at llvm/lib/Target/ARM/ARMFrameLowering.cpp:468 in virtual void llvm::ARMFrameLowering::emitPrologue(llvm::MachineFunction &, llvm::MachineBasicBlock &) const: getMaxFPOffset(MF.getFunction(), *AFI) <= FPOffset && "Max FP estimation is wrong"

Dec 5 2019, 2:30 PM
asbirlea accepted D71067: [AArch64] Fix MUL/SUB fusing.

I have no expertise here, but this fixes PR44222 (many AArch64 internal crashes caused by D70673), so I'm going to go ahead and approve this to get the fix in tree.

Dec 5 2019, 10:05 AM · Restricted Project

Dec 3 2019

asbirlea accepted D70786: [SimpleLoopUnswitch] Invalidate the topmost loop with ExitBB as exiting..

Thank you for this fix. LGTM.

Dec 3 2019, 9:56 AM · Restricted Project

Nov 25 2019

asbirlea committed rG14a2bbb1ff94: [MemorySSA] Combine verifications. (authored by asbirlea).
[MemorySSA] Combine verifications.
Nov 25 2019, 4:10 PM
asbirlea closed D70618: [MemorySSA] Combine verifications..
Nov 25 2019, 4:10 PM · Restricted Project

Nov 22 2019

asbirlea updated the diff for D70618: [MemorySSA] Combine verifications..

Combine 3 methods.

Nov 22 2019, 3:56 PM · Restricted Project
asbirlea retitled D70618: [MemorySSA] Combine verifications. from [MemorySSA] Combine two verifications into one. to [MemorySSA] Combine verifications..
Nov 22 2019, 3:56 PM · Restricted Project
asbirlea created D70618: [MemorySSA] Combine verifications..
Nov 22 2019, 2:15 PM · Restricted Project

Nov 21 2019

asbirlea committed rGfa09dddd70c5: [LoopInstSimplify] Move MemorySSA verification under flag. (authored by asbirlea).
[LoopInstSimplify] Move MemorySSA verification under flag.
Nov 21 2019, 5:23 PM

Nov 20 2019

asbirlea committed rG5c5cf899ef2f: [MemorySSA] Moving at the end often means before terminator. (authored by asbirlea).
[MemorySSA] Moving at the end often means before terminator.
Nov 20 2019, 5:22 PM
asbirlea committed rGda4baa2a6c96: [MemorySSA] Update analysis when the terminator is a memory instruction. (authored by asbirlea).
[MemorySSA] Update analysis when the terminator is a memory instruction.
Nov 20 2019, 4:43 PM

Nov 13 2019

asbirlea accepted D70211: Sink all InitializePasses.h includes.

This looks like a great improvement, IMO.

Nov 13 2019, 4:22 PM · Restricted Project

Nov 12 2019

asbirlea committed rG793b42a454ac: [GlobalsAA] Reenable test. (authored by asbirlea).
[GlobalsAA] Reenable test.
Nov 12 2019, 4:54 PM
asbirlea committed rG92611da5bfc5: Temporarily disable test. (authored by asbirlea).
Temporarily disable test.
Nov 12 2019, 4:26 PM
asbirlea committed rGdb69f1b22951: [GlobalsAA] Restrict ModRef result if any internal method has its address taken. (authored by asbirlea).
[GlobalsAA] Restrict ModRef result if any internal method has its address taken.
Nov 12 2019, 2:31 PM
asbirlea closed D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken..
Nov 12 2019, 2:31 PM · Restricted Project
asbirlea committed rG4ae74cc99fb9: [GVNHoist] Preserve AAResults. (authored by asbirlea).
[GVNHoist] Preserve AAResults.
Nov 12 2019, 2:12 PM

Nov 5 2019

asbirlea committed rG4b698645d307: [LoopRotationUtils] Check values are newly inserted into maps. (authored by asbirlea).
[LoopRotationUtils] Check values are newly inserted into maps.
Nov 5 2019, 1:43 PM
asbirlea retitled D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken. from [GlobalsAA] Set KnowNothing when nothing is known about a function. to [GlobalsAA] Restrict ModRef result if any internal method has its address taken..
Nov 5 2019, 12:20 PM · Restricted Project
asbirlea updated the diff for D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken..

Remove missed comment.

Nov 5 2019, 12:10 PM · Restricted Project
asbirlea updated the diff for D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken..

I updated the patch to be more generic, while still addressing this usecase.
The condition is: if there are any internal methods whose address is taken but for which we do not conclude that they do not modify globals, then cannot conclude lower than ModRef for any other (LocalLinkageCall, GlobalValue).
Tests included.

Nov 5 2019, 12:01 PM · Restricted Project

Nov 1 2019

asbirlea added a reviewer for D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken.: chandlerc.
Nov 1 2019, 12:54 PM · Restricted Project
asbirlea retitled D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken. from [GlobalsAA] Set MayReadAnyGlobal when nothing is known about a function. to [GlobalsAA] Set KnowNothing when nothing is known about a function..
Nov 1 2019, 12:50 PM · Restricted Project
asbirlea updated the diff for D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken..

Set KnowNothing.

Nov 1 2019, 12:50 PM · Restricted Project

Oct 31 2019

asbirlea created D69691: [GlobalsAA] Set MayReadAnyGlobal as a separate bit from ModRefInfo..
Oct 31 2019, 4:53 PM · Restricted Project
asbirlea created D69690: [GlobalsAA] Restrict ModRef result if any internal method has its address taken..
Oct 31 2019, 4:35 PM · Restricted Project

Oct 30 2019

asbirlea accepted D69369: [NFC] Add a unit test exposing lack of SCEV invalidation in LICM during code hoisting.
Oct 30 2019, 2:31 PM · Restricted Project
asbirlea committed rGbbb43df0111e: [ReleaseNotes] Add item on deleting the BasicBlockPass(Manager). (authored by asbirlea).
[ReleaseNotes] Add item on deleting the BasicBlockPass(Manager).
Oct 30 2019, 2:31 PM
asbirlea added a comment to D69369: [NFC] Add a unit test exposing lack of SCEV invalidation in LICM during code hoisting.

I think this is a great example of a unit test actually.
Getting to the scenario of forcing ScEv to cache the Load, so we can verify it is no longer properly cached after the Load is hoisted is harder to do in a lit test such that it's so easy to understand, like it is in this unit test.

Oct 30 2019, 12:10 PM · Restricted Project
asbirlea committed rG9f0ff0b2634b: [LegacyPassManager] Delete BasicBlockPass/Manager. (authored by asbirlea).
[LegacyPassManager] Delete BasicBlockPass/Manager.
Oct 30 2019, 11:41 AM
asbirlea closed D69121: [LegacyPassManager] Delete BasicBlockPass/Manager..
Oct 30 2019, 11:41 AM · Restricted Project

Oct 24 2019

asbirlea accepted D69370: [LICM] Invalidate SCEV upon instruction hoisting.

Thank you for the patch! This LGTM as is.

Oct 24 2019, 12:24 PM · Restricted Project

Oct 23 2019

asbirlea accepted D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Since I don't really understand the CodeExtractor, I'm relying on the author or another reviewer to confirm the correctness here.
This patch by itself looks good, but please wait to see if there are additional comments for the other reviewers before checking in.

Oct 23 2019, 11:00 AM · Restricted Project

Oct 21 2019

asbirlea added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Some comments, but it looks reasonable overall.

Oct 21 2019, 10:36 AM · Restricted Project

Oct 17 2019

asbirlea created D69121: [LegacyPassManager] Delete BasicBlockPass/Manager..
Oct 17 2019, 10:42 AM · Restricted Project

Oct 16 2019

asbirlea committed rG4eb1a573fab3: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor. (authored by asbirlea).
[Utils] Cleanup similar cases to MergeBlockIntoPredecessor.
Oct 16 2019, 3:27 PM
asbirlea closed D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..
Oct 16 2019, 3:27 PM · Restricted Project
asbirlea committed rL375050: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..
[Utils] Cleanup similar cases to MergeBlockIntoPredecessor.
Oct 16 2019, 3:26 PM
asbirlea committed rGc0e6a92e34d1: Update ReleaseNotes: expand the section on enabling MemorySSA (authored by asbirlea).
Update ReleaseNotes: expand the section on enabling MemorySSA
Oct 16 2019, 2:58 PM
asbirlea committed rL375045: Update ReleaseNotes: expand the section on enabling MemorySSA.
Update ReleaseNotes: expand the section on enabling MemorySSA
Oct 16 2019, 2:58 PM

Oct 15 2019

asbirlea updated the diff for D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..

Update iterator var names.

Oct 15 2019, 11:45 AM · Restricted Project
asbirlea updated the diff for D68670: [Utils] Cleanup similar cases to MergeBlockIntoPredecessor..

Nit: rename optional argument.
I'd like to check this in, in an effort to clear my patch queue. Please let me know if you have any comments.

Oct 15 2019, 10:48 AM · Restricted Project