asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (136 w, 5 d)

Recent Activity

Yesterday

asbirlea added inline comments to D51718: Update MemorySSA in LoopRotate..
Mon, Sep 24, 2:36 PM
asbirlea updated the diff for D40375: Use MemorySSA in LICM to do sinking and hoisting..

Rebase patch after resect changes.

Mon, Sep 24, 1:11 PM

Thu, Sep 20

asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Update pr35210.ll after recent upstream changes.

Thu, Sep 20, 2:26 PM
asbirlea added inline comments to D51718: Update MemorySSA in LoopRotate..
Thu, Sep 20, 1:28 PM

Mon, Sep 17

asbirlea committed rL342422: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures….
[EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures…
Mon, Sep 17, 3:37 PM
asbirlea closed D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..
Mon, Sep 17, 3:36 PM
asbirlea updated the diff for D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..

Thank you for the review!

Mon, Sep 17, 3:10 PM

Tue, Sep 11

asbirlea abandoned D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Dropping this, since the issue is not resolvable in general AFAICT. Please see D51960.

Tue, Sep 11, 4:49 PM
asbirlea abandoned D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Tue, Sep 11, 4:49 PM
asbirlea created D51960: [EarlyCSEwMemorySSA] Add MSSA verification and tests to make EarlyCSE failures easier to track..
Tue, Sep 11, 4:49 PM
asbirlea committed rL341984: Update MemorySSA in LoopUnswitch..
Update MemorySSA in LoopUnswitch.
Tue, Sep 11, 12:20 PM
asbirlea closed D45301: Update MemorySSA in LoopUnswitch..
Tue, Sep 11, 12:20 PM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Moving the MSSA after cloning earlier to avoid the ValueMap invalidation.
Adding another test.
And ping.

Tue, Sep 11, 11:48 AM

Mon, Sep 10

asbirlea added a reverting commit for rL341674: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely…: rL341883: [InstCombine] Partially revert rL341674 due to PR38897..
Mon, Sep 10, 4:48 PM
asbirlea committed rL341883: [InstCombine] Partially revert rL341674 due to PR38897..
[InstCombine] Partially revert rL341674 due to PR38897.
Mon, Sep 10, 4:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Sep 10, 4:48 PM
asbirlea created D51897: [InstCombine] Partially revert rL341674 due to PR38897..
Mon, Sep 10, 4:48 PM
asbirlea committed rL341855: API to update MemorySSA for cloned blocks and added CFG edges..
API to update MemorySSA for cloned blocks and added CFG edges.
Mon, Sep 10, 1:14 PM
asbirlea closed D45299: API to update MemorySSA for cloned blocks..
Mon, Sep 10, 1:14 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Final update before commit: changing a cast_or_null to dyn_cast_or_null for cloned instructions. LoopRotate can place Value in the map, as the clone of an instruction.

Mon, Sep 10, 11:49 AM

Fri, Sep 7

asbirlea committed rL341733: [MemorySSA] Relax verification of clobbering accesses..
[MemorySSA] Relax verification of clobbering accesses.
Fri, Sep 7, 4:52 PM
asbirlea committed rL341709: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if….
[MemorySSA] Update MemoryPhi wiring for block splitting to consider if…
Fri, Sep 7, 2:16 PM
asbirlea closed D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..
Fri, Sep 7, 2:16 PM
asbirlea updated the diff for D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..

Nit: remove braces.

Fri, Sep 7, 1:50 PM
asbirlea added inline comments to D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..
Fri, Sep 7, 1:45 PM
asbirlea updated the diff for D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..

Address comment. Thank you for the review!

Fri, Sep 7, 1:44 PM

Thu, Sep 6

asbirlea updated the diff for D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Adding third test-case for new failure.

Thu, Sep 6, 4:49 PM
asbirlea updated the diff for D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..

Avoid duplicates (use set).

Thu, Sep 6, 4:13 PM
asbirlea updated the diff for D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..

Add test for second failure.

Thu, Sep 6, 3:43 PM
asbirlea updated the diff for D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..

Need to bypass geps when traversing users, use worklist.
Adding test in dependent patch.

Thu, Sep 6, 3:43 PM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Update test and format.

Thu, Sep 6, 2:20 PM
asbirlea committed rL341587: [LoopPassManager] MemorySSA should be preserved when enabled..
[LoopPassManager] MemorySSA should be preserved when enabled.
Thu, Sep 6, 1:55 PM
asbirlea updated the summary of D51718: Update MemorySSA in LoopRotate..
Thu, Sep 6, 11:58 AM
asbirlea updated the diff for D51718: Update MemorySSA in LoopRotate..

Enable tests. Add new tests to check analysis is preserved.

Thu, Sep 6, 11:57 AM

Wed, Sep 5

asbirlea created D51718: Update MemorySSA in LoopRotate..
Wed, Sep 5, 11:31 PM
asbirlea added a dependent revision for D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction.: D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..
Wed, Sep 5, 11:25 PM
asbirlea added a dependency for D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions.: D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Wed, Sep 5, 11:25 PM
asbirlea created D51717: [EarlyCSEwMemorySSA] Fix failure (w/ expensive checks). Need to resetOptimizeUses for replaced instructions..
Wed, Sep 5, 11:09 PM
asbirlea created D51716: [MemorySSA] Add API to reset optimized for uses of a replaced instruction..
Wed, Sep 5, 11:00 PM
asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

Thank you for the patience on this review! :)

Wed, Sep 5, 5:19 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Small update triggered by a test in rotate (patch to be uploaded soon).

Wed, Sep 5, 5:13 PM

Tue, Sep 4

asbirlea accepted D51519: [SimpleLoopUnswitch] remove a chain of dead blocks at once.
Tue, Sep 4, 10:05 AM

Fri, Aug 31

asbirlea created D51563: [MemorySSA] Update MemoryPhi wiring for block splitting to consider if identical edges were merged..
Fri, Aug 31, 5:13 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Fix bug introduced by refactoring.

Fri, Aug 31, 2:42 PM

Thu, Aug 30

asbirlea added inline comments to D51519: [SimpleLoopUnswitch] remove a chain of dead blocks at once.
Thu, Aug 30, 4:32 PM

Wed, Aug 29

asbirlea committed rL340995: [MemorySSA] Silence warning..
[MemorySSA] Silence warning.
Wed, Aug 29, 4:23 PM
asbirlea committed rL340981: [MemorySSA] Fix checkClobberSanity to skip Start only for Defs and Uses..
[MemorySSA] Fix checkClobberSanity to skip Start only for Defs and Uses.
Wed, Aug 29, 3:39 PM
asbirlea committed rL340951: [MemorySSA] Add expesive check for validating clobber accesses..
[MemorySSA] Add expesive check for validating clobber accesses.
Wed, Aug 29, 11:28 AM
asbirlea closed D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Wed, Aug 29, 11:28 AM
asbirlea updated the diff for D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Missed an update.

Wed, Aug 29, 11:15 AM
asbirlea updated the diff for D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Fix nit.

Wed, Aug 29, 11:11 AM
asbirlea accepted D51415: [SimpleLoopUnswitch] After unswitch delete dead blocks in parent loops.

This LGTM.
FWIW, I think we're having an underlying problem and this and the previous PRs may be related.
In unswitchTrivialSwitch, at the very beginning we're removing switch cases and querying LoopInfo to get the outer loop for each switch successor without updating it. LoopInfo is updated only at the very end in hoistLoopToNewParent. Adding an artificial assert to check if LI should be updated after removing switch cases, triggers on 2/3 tests from D51375 and existing trivial-unswitch tests. Looking into it further.

Wed, Aug 29, 11:00 AM

Tue, Aug 28

asbirlea added inline comments to D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Tue, Aug 28, 2:54 PM
asbirlea added inline comments to D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Tue, Aug 28, 2:51 PM
asbirlea updated the diff for D51327: [MemorySSA] Add expesive check for validating clobber accesses..

Address comments. Undo const-ifies no longer needed.

Tue, Aug 28, 2:48 PM
asbirlea committed rL340871: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..
[SimpleLoopUnswitch] Form dedicated exits after trivial unswitches.
Tue, Aug 28, 1:42 PM
asbirlea closed D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..
Tue, Aug 28, 1:42 PM
asbirlea updated the diff for D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..

Updated test, thank you for the comments!

Tue, Aug 28, 1:38 PM
asbirlea created D51375: [SimpleLoopUnswitch] Form dedicated exits after trivial unswitches..
Tue, Aug 28, 12:28 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Address comments.

Tue, Aug 28, 11:22 AM
asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

I'm planning to add a few more unittests, but sending the updates now for additional comments.

Tue, Aug 28, 11:21 AM

Mon, Aug 27

asbirlea created D51327: [MemorySSA] Add expesive check for validating clobber accesses..
Mon, Aug 27, 3:01 PM

Aug 23 2018

asbirlea committed rL340581: [IDF] Make GraphDiff a const constructor argument..
[IDF] Make GraphDiff a const constructor argument.
Aug 23 2018, 2:57 PM
asbirlea committed rL340567: Remove the use of pair inside the tuple in concat_iterator..
Remove the use of pair inside the tuple in concat_iterator.
Aug 23 2018, 11:47 AM
asbirlea closed D51067: Remove the use of pair inside the tuple in concat_iterator..
Aug 23 2018, 11:47 AM

Aug 22 2018

asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

Thanks a lot of the comments, working to address them.

Aug 22 2018, 6:03 PM
asbirlea updated the summary of D51067: Remove the use of pair inside the tuple in concat_iterator..
Aug 22 2018, 2:15 PM
asbirlea added a comment to D50911: Update MemorySSA in LoopSimplifyCFG..

Thank you for the review!

Aug 22 2018, 1:13 PM
asbirlea committed rL340445: Update MemorySSA in LoopSimplifyCFG..
Update MemorySSA in LoopSimplifyCFG.
Aug 22 2018, 1:11 PM
asbirlea closed D50911: Update MemorySSA in LoopSimplifyCFG..
Aug 22 2018, 1:11 PM
asbirlea added a comment to D50906: Update MemorySSA in LoopInstSimplify..

Thank you for the review!

Aug 22 2018, 1:07 PM
asbirlea committed rL340444: Update MemorySSA in LoopInstSimplify..
Update MemorySSA in LoopInstSimplify.
Aug 22 2018, 1:06 PM
asbirlea closed D50906: Update MemorySSA in LoopInstSimplify..
Aug 22 2018, 1:06 PM
asbirlea added a reviewer for D47022: Update MemorySSA in SimpleLoopUnswitch.: chandlerc.
Aug 22 2018, 12:16 PM
asbirlea updated the summary of D47022: Update MemorySSA in SimpleLoopUnswitch..
Aug 22 2018, 12:16 PM
asbirlea updated the diff for D47022: Update MemorySSA in SimpleLoopUnswitch..

Rebase and cleanup. Ready to review.

Aug 22 2018, 12:13 PM

Aug 21 2018

asbirlea abandoned D51015: [MemorySSA] Make the Updater movable..

Dropping this, updater is movable, some mishap on my side.

Aug 21 2018, 4:34 PM
asbirlea committed rL340365: Update MemorySSA in BasicBlockUtils..
Update MemorySSA in BasicBlockUtils.
Aug 21 2018, 4:33 PM
asbirlea closed D45300: Update MemorySSA BasicBlockUtils..
Aug 21 2018, 4:32 PM
asbirlea added a comment to D45300: Update MemorySSA BasicBlockUtils..

Thank you for the review!
I'll submit this one as is, and the usages will follow shortly.

Aug 21 2018, 4:29 PM
asbirlea committed rL340362: [MemorySSA] Update comment for move APIs to clarify behavior (NFC)..
[MemorySSA] Update comment for move APIs to clarify behavior (NFC).
Aug 21 2018, 4:13 PM
asbirlea created D51067: Remove the use of pair inside the tuple in concat_iterator..
Aug 21 2018, 3:26 PM
asbirlea accepted D51024: [LICM] Modernize AliasSetTracker handling. NFC.

This is great, thank you for the cleanup!
LGTM.

Aug 21 2018, 11:08 AM

Aug 20 2018

asbirlea updated the diff for D50906: Update MemorySSA in LoopInstSimplify..

Update to normal constructor.

Aug 20 2018, 6:59 PM
asbirlea updated the diff for D50911: Update MemorySSA in LoopSimplifyCFG..

Update to simple constructor.

Aug 20 2018, 6:57 PM
asbirlea updated the diff for D51015: [MemorySSA] Make the Updater movable..

Nope, don't need that.

Aug 20 2018, 4:52 PM
asbirlea created D51015: [MemorySSA] Make the Updater movable..
Aug 20 2018, 4:44 PM
asbirlea updated the diff for D50911: Update MemorySSA in LoopSimplifyCFG..

Updated to allocate mssaupdater.

Aug 20 2018, 4:06 PM
asbirlea updated the diff for D50906: Update MemorySSA in LoopInstSimplify..

My bad, previous update won't work, updater needs to be allocated. Please comment on the use of make_unique (= operator in Optional does an std::move).

Aug 20 2018, 4:05 PM
asbirlea updated the diff for D50911: Update MemorySSA in LoopSimplifyCFG..

Address comment.

Aug 20 2018, 3:18 PM
asbirlea updated the diff for D50906: Update MemorySSA in LoopInstSimplify..

Address comments.

Aug 20 2018, 3:10 PM
asbirlea added inline comments to D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..
Aug 20 2018, 11:17 AM
asbirlea committed rL340192: [MemorySSA] Update comment to better describe cfg change (NFC)..
[MemorySSA] Update comment to better describe cfg change (NFC).
Aug 20 2018, 11:15 AM

Aug 17 2018

asbirlea committed rL340067: [IDF] Make GD const..
[IDF] Make GD const.
Aug 17 2018, 11:38 AM
asbirlea committed rL340052: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a….
[IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a…
Aug 17 2018, 10:40 AM
asbirlea closed D50675: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a GraphDiff..
Aug 17 2018, 10:40 AM
asbirlea created D50911: Update MemorySSA in LoopSimplifyCFG..
Aug 17 2018, 10:35 AM
asbirlea added a dependent revision for D50675: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a GraphDiff.: D45299: API to update MemorySSA for cloned blocks..
Aug 17 2018, 9:46 AM
asbirlea added a dependency for D45299: API to update MemorySSA for cloned blocks.: D50675: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a GraphDiff..
Aug 17 2018, 9:46 AM
asbirlea added a dependent revision for D45299: API to update MemorySSA for cloned blocks.: D45301: Update MemorySSA in LoopUnswitch..
Aug 17 2018, 9:46 AM