Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

asbirlea (Alina Sbirlea)
Google

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (398 w, 5 d)

Recent Activity

Aug 29 2023

asbirlea added a comment to D157955: [TableGen] Make OpcodeMappings sort comparator strict weak ordering compliant.

I thought the zero count is from the most significant bit but I may be wrong. In any case, your point is valid. I see how you can construct an example where the .first fields are not equal, but then the popcount and countl_zero are both equal, leading to a "false" on the LessThan call for both (a,b) and (b,a) comparison.
The change proposed here does provide an absolute ordering so it resolves the issue you found and it's reasonable to go with it. I'm not sure it's the "desired" one (or if it even matters). It will rely more often on the Idx default, than on the two comparisons, and perhaps that's ok.
A more classical comparison would be for LessThan to provide a full <; so comparing on the .first for equivalency, but then determining the follow up on conditions which defines a strict ordering (e.g. bitsToDouble()?).

Aug 29 2023, 12:04 PM · Restricted Project, Restricted Project
asbirlea added a comment to D124078: [MemCpyOpt] Avoid infinite loop in processMemSetMemCpyDependence (PR54983).

Proving the size is non-zero is a higher bar than proving the zero case and eliminating the memcpy in those cases. So this seems reasonable to me.

Aug 29 2023, 8:20 AM · Restricted Project, Restricted Project

Aug 15 2023

asbirlea accepted D157979: [MSSAU] Clarify that the defining access does not matter.

LGTM.
Another alternative is creating a createMemoryAccess API which does not take the defining access, but likely not worth it.
I'm fairly certain we cannot keep the defining access when inserting Defs in the general case, in particular when needing to insert new Phis.

Aug 15 2023, 7:32 AM · Restricted Project, Restricted Project

Aug 14 2023

asbirlea committed rGf7eb5222acd9: [ConstantHoisting] Limit checks to assertion message. (authored by asbirlea).
[ConstantHoisting] Limit checks to assertion message.
Aug 14 2023, 11:35 AM · Restricted Project, Restricted Project

Aug 10 2023

asbirlea committed rG89fa0dd1fb25: [MemorySSA] Handle queries with empty memory location. (authored by asbirlea).
[MemorySSA] Handle queries with empty memory location.
Aug 10 2023, 9:59 AM · Restricted Project, Restricted Project

Aug 7 2023

asbirlea added a comment to D157263: [NewGVN] Unreachable if block in performSymbolicLoadEvaluation (NFC).

Can you replace this with an assert instead?

Aug 7 2023, 12:04 PM · Restricted Project, Restricted Project

Aug 3 2023

asbirlea accepted D156994: [NewGVN] Only perform symbolic evaluation on instructions (NFC).
Aug 3 2023, 10:59 AM · Restricted Project, Restricted Project

Jun 14 2023

asbirlea accepted D152859: [MemorySSA] Always perform MemoryUses liveOnEntry optimization on MSSA construction.

lgtm

Jun 14 2023, 1:36 PM · Restricted Project, Restricted Project
asbirlea added inline comments to D152859: [MemorySSA] Always perform MemoryUses liveOnEntry optimization on MSSA construction.
Jun 14 2023, 12:31 PM · Restricted Project, Restricted Project

Jun 12 2023

asbirlea added a comment to D152743: [AliasAnalysis] Return NoModRef for loads from constant memory.

I'm concerned that this will cause us problems in the future, e.g. if we want to do MemorySSA-based GVN, because we will no longer have MemoryUses for these loads at all, even though we may want to do load CSE on them.

Jun 12 2023, 3:32 PM · Restricted Project, Restricted Project

May 24 2023

asbirlea accepted D145265: [Pipeline] Remove GlobalCleanupPM.

This went through a few rounds of testing on our internal benchmarks and it's at a point where there are no meaningful run-time regressions observed, but the compile-time improvements remain and are significant enough to move fwd with the change.
Approving to move things forward. If folks do encounter regressions from this change before or after landing, please flag them here.

May 24 2023, 2:50 PM · Restricted Project, Restricted Project, Restricted Project

May 22 2023

asbirlea added a comment to rGd1dc3e13a791: Revert "ValueTracking: Delete body of isKnownNeverInfinity".

Thank you, no issues after the fix patches afaict.

May 22 2023, 10:12 AM · Restricted Project, Restricted Project

May 19 2023

asbirlea added a comment to rGd1dc3e13a791: Revert "ValueTracking: Delete body of isKnownNeverInfinity".

Confirmed test is back to green at d1dc3e1, with 494dee0 reverted. Reverted now.
I'll continue to look into IR differences. Please let me know if the above is helpful in the mean time.

May 19 2023, 10:38 PM · Restricted Project, Restricted Project
asbirlea added a reverting change for rG494dee0f7a77: InstSimplify: Use isKnownNeverInfOrNaN: rGf55224735ed3: Revert "InstSimplify: Use isKnownNeverInfOrNaN".
May 19 2023, 10:33 PM · Restricted Project, Restricted Project
asbirlea committed rGf55224735ed3: Revert "InstSimplify: Use isKnownNeverInfOrNaN" (authored by asbirlea).
Revert "InstSimplify: Use isKnownNeverInfOrNaN"
May 19 2023, 10:33 PM · Restricted Project, Restricted Project
asbirlea added a comment to rGd1dc3e13a791: Revert "ValueTracking: Delete body of isKnownNeverInfinity".

I still don't have all the answers, here's what I know so far:

May 19 2023, 6:28 PM · Restricted Project, Restricted Project
asbirlea updated subscribers of rGd1dc3e13a791: Revert "ValueTracking: Delete body of isKnownNeverInfinity".

Hi Matt,

May 19 2023, 11:13 AM · Restricted Project, Restricted Project

May 18 2023

asbirlea added a reverting change for rG73925ef8b0ea: ValueTracking: Delete body of isKnownNeverInfinity: rGd1dc3e13a791: Revert "ValueTracking: Delete body of isKnownNeverInfinity".
May 18 2023, 11:32 PM · Restricted Project, Restricted Project
asbirlea committed rGd1dc3e13a791: Revert "ValueTracking: Delete body of isKnownNeverInfinity" (authored by asbirlea).
Revert "ValueTracking: Delete body of isKnownNeverInfinity"
May 18 2023, 11:32 PM · Restricted Project, Restricted Project
asbirlea added a reverting change for rGfaa32734bf9a: SimplifyLibCalls: Pass AssumptionCache to isKnownNeverInfinity: rGb357f379c818: Revert "SimplifyLibCalls: Pass AssumptionCache to isKnownNeverInfinity".
May 18 2023, 11:32 PM · Restricted Project, Restricted Project
asbirlea committed rGb357f379c818: Revert "SimplifyLibCalls: Pass AssumptionCache to isKnownNeverInfinity" (authored by asbirlea).
Revert "SimplifyLibCalls: Pass AssumptionCache to isKnownNeverInfinity"
May 18 2023, 11:32 PM · Restricted Project, Restricted Project
asbirlea added a reverting change for rG0012b94a4e8e: InstSimplify: Pass AssumptionCache to isKnownNeverInfinity: rG481191b0a831: Revert "InstSimplify: Pass AssumptionCache to isKnownNeverInfinity".
May 18 2023, 11:32 PM · Restricted Project, Restricted Project
asbirlea committed rG481191b0a831: Revert "InstSimplify: Pass AssumptionCache to isKnownNeverInfinity" (authored by asbirlea).
Revert "InstSimplify: Pass AssumptionCache to isKnownNeverInfinity"
May 18 2023, 11:32 PM · Restricted Project, Restricted Project

Apr 11 2023

asbirlea accepted D107356: [Lowering] Support lowering of llvm.experimental.ptr.provenance..
Apr 11 2023, 4:50 PM · Restricted Project, Restricted Project
asbirlea accepted D128813: [unknown_provenance] Verifier: check it only exists on the ptr_provenance path.

lgtm.

Apr 11 2023, 10:25 AM · Restricted Project, Restricted Project
asbirlea accepted D107354: [MachineMemOperand] learn about ptr_provenance.
Apr 11 2023, 10:13 AM · Restricted Project, Restricted Project

Mar 27 2023

asbirlea added a comment to D145265: [Pipeline] Remove GlobalCleanupPM.

Nit: the diffs would be easier to analyze with "-fno-discard-value-names".

Mar 27 2023, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2023

asbirlea accepted D145196: [CGSCC] Allow creation of no-rerun CGSCC->function adaptor via textual pipeline.
Mar 18 2023, 12:30 AM · Restricted Project, Restricted Project

Mar 16 2023

asbirlea accepted D146200: [PassBuilder] Support O0 in default pipelines.
Mar 16 2023, 1:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
asbirlea added inline comments to D146200: [PassBuilder] Support O0 in default pipelines.
Mar 16 2023, 10:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
asbirlea accepted D146243: [docs] Mention removal of legacy optimization pipeline and inliner alloca merging.
Mar 16 2023, 10:37 AM · Restricted Project, Restricted Project

Mar 15 2023

asbirlea accepted D146091: [Inliner] Remove alloca merging.

Adding a line in release notes might be useful; next to a note with the removal of legacy PM pieces (e.g. PassManagerBuilder).

Mar 15 2023, 2:50 PM · Restricted Project, Restricted Project

Mar 7 2023

asbirlea committed rG3f29b23b1a3c: [lldb] Fix after __SVCount_t added for AArch64 (authored by asbirlea).
[lldb] Fix after __SVCount_t added for AArch64
Mar 7 2023, 6:31 PM · Restricted Project
asbirlea closed D145533: [lldb] Fix after __SVCount_t added for AArch64.
Mar 7 2023, 6:30 PM · Restricted Project, Restricted Project
asbirlea added a comment to D145533: [lldb] Fix after __SVCount_t added for AArch64.

Yeah, I noticed right after I sent this patch out :-).

Mar 7 2023, 6:14 PM · Restricted Project, Restricted Project
asbirlea requested review of D145533: [lldb] Fix after __SVCount_t added for AArch64.
Mar 7 2023, 5:16 PM · Restricted Project, Restricted Project

Mar 2 2023

asbirlea accepted D145130: [Docs] update MemorySSA for opaque ptrs.

Thank you for updating this!

Mar 2 2023, 12:57 PM · Restricted Project, Restricted Project

Feb 28 2023

asbirlea accepted D145015: [PassBuilder] Always enable CountVisitsPass when stats are enabled.

Wondering if having the flag would still be useful if you want this statistic and not everything else in stats. But I don't think we particularly need that now, so works for me and flag can always be re-added.

Feb 28 2023, 11:07 PM · Restricted Project, Restricted Project

Feb 15 2023

asbirlea accepted D98675: Remove -enable-npm-O3-nontrivial-unswitch option.
Feb 15 2023, 10:58 PM · Restricted Project, Restricted Project
asbirlea accepted D144130: [Pipeline] Remove -enable-no-rerun-simplification-pipeline flag.
Feb 15 2023, 10:56 PM · Restricted Project, Restricted Project

Feb 14 2023

asbirlea accepted D143641: [MemorySSA] Iteratively check if gep's pointer operand is a guaranteed loop invariant.

lgtm with comments addressed.

Feb 14 2023, 12:03 AM · Restricted Project, Restricted Project

Feb 9 2023

asbirlea added inline comments to D143641: [MemorySSA] Iteratively check if gep's pointer operand is a guaranteed loop invariant.
Feb 9 2023, 2:22 PM · Restricted Project, Restricted Project

Feb 6 2023

asbirlea added a comment to D135915: [ConstraintElim] Enable pass by default..

SGTM, thank you Florian!

Feb 6 2023, 10:09 AM · Restricted Project, Restricted Project

Jan 30 2023

asbirlea accepted D142853: [CGSCC] Add pass which counts the max number of times we visit a function.
Jan 30 2023, 9:27 AM · Restricted Project, Restricted Project

Jan 26 2023

asbirlea added a comment to D133574: [C2x] reject type definitions in offsetof.

Following this change, the following emits warnings: https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE

Jan 26 2023, 11:56 AM · Restricted Project, Restricted Project

Jan 25 2023

asbirlea accepted D142571: [lld] Remove transitional legacy pass manager flags.
Jan 25 2023, 1:50 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2023

asbirlea added a comment to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Heads-up that we're seeing crashes due to the recommit of this change.
msan reports "use-of-uninitialized-value" in multiple places, where input is clearly initialized.

Jan 24 2023, 2:15 PM · Restricted Project, Restricted Project

Jan 23 2023

asbirlea added a comment to D140184: Fix crash with lambda and variadic template.

Re-ping to current reviewers. Any thoughts on the above @cor3ntin? Is there someone who you recommend look into this issue?

Jan 23 2023, 11:41 AM · Restricted Project

Jan 18 2023

asbirlea added a comment to D135915: [ConstraintElim] Enable pass by default..

Thank you @fhahn!

Jan 18 2023, 11:36 AM · Restricted Project, Restricted Project
asbirlea added a reviewer for D103016: NewGVN: Relax assertion about number of times a value is seen: kmitropoulou.
Jan 18 2023, 10:31 AM · Restricted Project, Restricted Project
asbirlea added a reviewer for D141909: Avoid removing useful loop metadata when striping debug info: dblaikie.
Jan 18 2023, 10:01 AM · Restricted Project, Restricted Project

Jan 17 2023

asbirlea added a comment to D135915: [ConstraintElim] Enable pass by default..

Reverting should be acceptable here.
AFAIU, the norm for work with high impact (adding a pass to the pipeline is one) is to do the work itself under a flag so the work itself does not get reverted if there are issues, and for the flag flip patch (such as this one) to be reverted if issues arise.
When the issue is resolved, the flag flip patch should be re-landed.
Regressing a test by ~1000%, seems like a solid reason to revert if a solution is not immediately available, especially with having a reproducer available that confirms the issue.

Jan 17 2023, 1:21 PM · Restricted Project, Restricted Project

Jan 12 2023

asbirlea accepted D107357: [getUnderlyingObject] support ptr_provenance.

I'm ok to not bikeshed this one at this time :-).

Jan 12 2023, 1:03 PM · Restricted Project, Restricted Project
asbirlea accepted D107352: [MemoryLocation] learn about ptr_provenance.

In my opinion, this is fine.

Jan 12 2023, 12:58 PM · Restricted Project, Restricted Project
asbirlea added inline comments to D128813: [unknown_provenance] Verifier: check it only exists on the ptr_provenance path.
Jan 12 2023, 12:51 PM · Restricted Project, Restricted Project
asbirlea accepted D140097: [MemDep] Reduce block limit.

I did now and it also looks clean. Commit with 200?

Jan 12 2023, 10:42 AM · Restricted Project, Restricted Project

Jan 11 2023

asbirlea added a comment to D141487: [LoopUnroll] Directly update DT instead of DTU..

I'm curious where all the time is spent in the 200s to 2s case. Is Eager strategy just as slow?

Jan 11 2023, 4:11 PM · Restricted Project, Restricted Project
asbirlea added a reviewer for D141487: [LoopUnroll] Directly update DT instead of DTU.: kuhar.
Jan 11 2023, 4:06 PM · Restricted Project, Restricted Project
asbirlea added a comment to D133192: [LICM] Allow load-only scalar promotion in the presence of aliasing loads.

Seeing a regression after this change. Filed: https://github.com/llvm/llvm-project/issues/59951

Jan 11 2023, 2:28 PM · Restricted Project, Restricted Project
asbirlea accepted D141443: [docs][NewPM] Clarify more status of legacy PM + optimization pipeline.
Jan 11 2023, 12:32 PM · Restricted Project, Restricted Project

Jan 10 2023

asbirlea added a comment to D140097: [MemDep] Reduce block limit.

I'm seeing one instance of increase in compile-time with the 100 limit and a couple of small run time regressions. The results look somewhat cleaner with a cap of 300. Could we use 300 as an intermediate step?

Jan 10 2023, 1:59 PM · Restricted Project, Restricted Project

Jan 9 2023

asbirlea added inline comments to D141185: [MemorySSA] Don't check def set when cloning memoryaccesses.
Jan 9 2023, 12:19 PM · Restricted Project, Restricted Project

Jan 6 2023

asbirlea added a comment to D140184: Fix crash with lambda and variadic template.

Gentle ping. Can you propose an alternate patch to fix this crash? The github issue is 6 months old and similar crashes are reported due to this.

Jan 6 2023, 9:34 AM · Restricted Project

Jan 3 2023

asbirlea accepted D140184: Fix crash with lambda and variadic template.
Jan 3 2023, 10:34 AM · Restricted Project

Dec 15 2022

asbirlea accepted D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto().

Rebase to trigger pre-merge checks?

Dec 15 2022, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
asbirlea accepted D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert()..

lgtm.

Dec 15 2022, 9:45 AM · Restricted Project, Restricted Project, Restricted Project
asbirlea added a comment to D140097: [MemDep] Reduce block limit.

Reducing this limit is certainly the right thing to do. To what value so as to not cause large regressions is a question I'd like to answer with some experimental data.
I'll start some experiments and come back to this.

Dec 15 2022, 9:42 AM · Restricted Project, Restricted Project

Dec 13 2022

asbirlea accepted D138857: [llvm-c] Remove legacy pass manager APIs.
Dec 13 2022, 2:39 PM · Restricted Project, Restricted Project

Dec 12 2022

asbirlea accepted D138877: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt()..
Dec 12 2022, 1:10 PM · Restricted Project, Restricted Project, Restricted Project

Dec 5 2022

asbirlea accepted D136164: [MemorySSA] Use BatchAA for clobber walker.

lgtm.

Dec 5 2022, 12:36 PM · Restricted Project, Restricted Project

Dec 1 2022

asbirlea accepted D139096: [DSE] Use precise loc for memcpy_chk during overwrite checks..
Dec 1 2022, 9:57 AM · Restricted Project, Restricted Project
asbirlea accepted D115167: [DSE] Use precise loc for memset_chk during overwrite checks.

Considering the previous reviewer comments, this lgtm.

Dec 1 2022, 9:50 AM · Restricted Project, Restricted Project

Nov 29 2022

asbirlea accepted D138875: [IR][NFC] Adds Instruction::insertAt() for inserting at a specific point in the instr list..
Nov 29 2022, 5:09 PM · Restricted Project, Restricted Project
asbirlea accepted D138605: [NFC] Removed call to getInstList() from range loops on BBs..
Nov 29 2022, 5:07 PM · Restricted Project, Restricted Project
asbirlea accepted D107355: [ptr_provenance] Introduce llvm.experimental.ptr.provenance.
Nov 29 2022, 10:27 AM · Restricted Project, Restricted Project
asbirlea added a comment to D107352: [MemoryLocation] learn about ptr_provenance.

Could you add updated compile-time impact measurements after the latest rebase?

Nov 29 2022, 10:25 AM · Restricted Project, Restricted Project
asbirlea accepted D104269: [ptr_provenance] Parser support for the optional ptr_provenance operand.
Nov 29 2022, 10:22 AM · Restricted Project, Restricted Project

Nov 28 2022

asbirlea accepted D138730: [Analysis] Remove unused fields in MemorySSA.cpp (NFC).
Nov 28 2022, 2:20 PM · Restricted Project, Restricted Project

Nov 17 2022

asbirlea added a comment to D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling.

Green light perf-wise.
I cannot comment on whether the position is "the right" one though. I'm deferring to the other reviewers.

Nov 17 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2022

asbirlea added a comment to D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling.

As far as performance, this looks fine. Not seeing measurable gains.

Nov 16 2022, 4:26 PM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

asbirlea accepted D137553: [MemorySSA] Relax assert condition in createDefinedAccess.
Nov 15 2022, 4:29 PM · Restricted Project, Restricted Project
asbirlea added a comment to D136164: [MemorySSA] Use BatchAA for clobber walker.

Makes sense to use BAA at call sites if the usage is such!

Nov 15 2022, 2:49 PM · Restricted Project, Restricted Project
asbirlea added a comment to D137955: [AST] Make AliasSetTracker work on BatchAA.

Missed the dependent patch on LoopAccessAnalysis, now it makes sense :-)

Nov 15 2022, 2:26 PM · Restricted Project, Restricted Project
asbirlea accepted D137955: [AST] Make AliasSetTracker work on BatchAA.

+1 on making the AST only work on immutable IR.

Nov 15 2022, 2:24 PM · Restricted Project, Restricted Project
asbirlea added a comment to D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling.

IIUC compile time impact for adding another SROA (the one outside LTO) is negligible?

Nov 15 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
asbirlea accepted D137116: [AggressiveInstCombine] Remove legacy PM pass.
Nov 15 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
asbirlea accepted D136617: [opt] Print deprecation warning for use of legacy syntax with new pass manager.
Nov 15 2022, 10:24 AM · Restricted Project, Restricted Project

Nov 11 2022

asbirlea added a comment to D137623: [Hexagon] Use default attributes for intrinsics.

The original starts crashing with -O2 with this revision, but crashes with -O0 before and after this revision, so the issue looks preexisting.
The reduced test from @rupprecht no longer crashes with -O0 before this revision.
If this becomes an issue for resolving, we could share the un-reduced offline.

Nov 11 2022, 4:33 PM · Restricted Project, Restricted Project
asbirlea added a reverting change for rG8a8983b279dd: [Hexagon] Use default attributes for intrinsics: rG57dbca20eae8: Revert "[Hexagon] Use default attributes for intrinsics".
Nov 11 2022, 3:13 PM · Restricted Project, Restricted Project
asbirlea committed rG57dbca20eae8: Revert "[Hexagon] Use default attributes for intrinsics" (authored by asbirlea).
Revert "[Hexagon] Use default attributes for intrinsics"
Nov 11 2022, 3:13 PM · Restricted Project, Restricted Project
asbirlea added a reverting change for D137623: [Hexagon] Use default attributes for intrinsics: rG57dbca20eae8: Revert "[Hexagon] Use default attributes for intrinsics".
Nov 11 2022, 3:13 PM · Restricted Project, Restricted Project

Nov 2 2022

asbirlea added inline comments to D137201: [AggressiveInstCombine] Handle the insert point of the merged load correctly..
Nov 2 2022, 11:12 AM · Restricted Project, Restricted Project

Nov 1 2022

asbirlea added a comment to D136164: [MemorySSA] Use BatchAA for clobber walker.

It seems unnecessary to force all uses to instantiate and pass the BatchAA.
Can this remain part of the ClobberWalkerBase instead? Default the calls to getClobberingMemoryAccess to instantiate a BatchAA internally and pass to the ClobberWalker.
Then, there can be an additional API added to override the above behavior when useful (known as safe): either passing a given BatchAA like current patch, or, keeping a BatchAA in the ClobberWalker itself instead of the AA, and being able to "set" it to not re-initialize it on each call (and perhaps "reset" to reseting each time).
What do you think?

Nov 1 2022, 5:37 PM · Restricted Project, Restricted Project
asbirlea accepted D136616: [opt] Add -p alias for -passes.
Nov 1 2022, 3:13 PM · Restricted Project, Restricted Project
asbirlea accepted D137038: [NewPM][Pipeline] Add PipelineTuningOption to set inliner threshold.

LGTM.

Nov 1 2022, 3:08 PM · Restricted Project, Restricted Project
asbirlea accepted D136626: [docs][NewPM] Move pass plugin documentation into existing new PM docs.

Thank you for adding this!

Nov 1 2022, 2:48 PM · Restricted Project, Restricted Project

Oct 25 2022

asbirlea committed rGd1b19da854fd: [LoopPeeling] Add flag to disable support for peeling loops with non-latch exits (authored by asbirlea).
[LoopPeeling] Add flag to disable support for peeling loops with non-latch exits
Oct 25 2022, 12:20 PM · Restricted Project, Restricted Project
asbirlea closed D136643: [LoopPeeling] Add flag to disable support for peeling loops with non-latch exits.
Oct 25 2022, 12:19 PM · Restricted Project, Restricted Project
asbirlea updated the diff for D136643: [LoopPeeling] Add flag to disable support for peeling loops with non-latch exits.

Simplify conditions in canPeel.

Oct 25 2022, 12:16 PM · Restricted Project, Restricted Project
asbirlea updated the diff for D136643: [LoopPeeling] Add flag to disable support for peeling loops with non-latch exits.

Simplified to only the changes in canPeel.

Oct 25 2022, 10:28 AM · Restricted Project, Restricted Project