asbirlea (Alina Sbirlea)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2016, 9:51 AM (127 w, 4 h)

Recent Activity

Thu, Jul 12

asbirlea added a comment to D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..

Thank you for the review!

Thu, Jul 12, 4:13 PM
asbirlea updated the diff for D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..

Right, updated now.

Thu, Jul 12, 3:52 PM
asbirlea added inline comments to D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..
Thu, Jul 12, 2:19 PM
asbirlea updated the diff for D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..

Address comments.

Thu, Jul 12, 2:19 PM

Wed, Jul 11

asbirlea committed rL336860: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG….
[MemorySSA] Add APIs to move memory accesses between blocks, following CFG…
Wed, Jul 11, 3:16 PM
asbirlea closed D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes..
Wed, Jul 11, 3:16 PM

Tue, Jul 10

asbirlea updated the diff for D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..

Consider multiple edges between blocks. MemoryPhis have an entry for each edge in this case. Move all edges to the new phi to preserve number of edges equal to number of phi entries.

Tue, Jul 10, 3:25 PM
asbirlea updated the diff for D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..

Format.

Tue, Jul 10, 2:45 PM
asbirlea created D49156: [MemorySSA] Add API to update MemoryPhis, following CFG changes..
Tue, Jul 10, 2:39 PM
asbirlea updated the diff for D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes..

Format.

Tue, Jul 10, 1:24 PM
asbirlea updated the diff for D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes..

Address comments and remove movePhi API. There is a use case needing something move generic that I will send in a separate patch.

Tue, Jul 10, 1:21 PM
asbirlea updated the diff for D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes..

Address comments.

Tue, Jul 10, 11:19 AM
asbirlea added inline comments to D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes..
Tue, Jul 10, 11:19 AM

Tue, Jul 3

asbirlea created D48897: [MemorySSA] Add APIs to move memory accesses between blocks, following CFG changes..
Tue, Jul 3, 2:07 PM
asbirlea added a comment to D48851: [PM/LoopUnswitch] Fix the first and immediate components of PR37889..

Some small comments, but otherwise lgtm.

Tue, Jul 3, 1:00 PM

Mon, Jul 2

asbirlea committed rL336133: Replace "Replacable" with "Replaceable". [NFC].
Replace "Replacable" with "Replaceable". [NFC]
Mon, Jul 2, 11:58 AM

Fri, Jun 29

asbirlea updated the diff for D47022: Update MemorySSA in SimpleLoopUnswitch..

Rebase after changes in SimpleLoopUnswitch and MemorySSA API changes.

Fri, Jun 29, 2:38 PM
asbirlea updated the diff for D45301: Update MemorySSA in LoopUnswitch..

Rebase and update after API change.

Fri, Jun 29, 2:37 PM
asbirlea created D48790: Update MemorySSA in Local utils removing blocks..
Fri, Jun 29, 2:35 PM
asbirlea updated the diff for D45300: Update MemorySSA BasicBlockUtils..

Rebase.

Fri, Jun 29, 2:31 PM
asbirlea updated the summary of D45299: API to update MemorySSA for cloned blocks..
Fri, Jun 29, 2:28 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Rebase after checking in delete APIs.
Updated algorithm for updatePhisWhenAddingBBPred to consider any number of predecessors added for each block.
Updated cloneUseDef signature to use an LoopBlocksRPO.
Updated cloneUseDef to include an API with multiple VMaps, per the SimpleLoopUnswitch change.
Other cleanups.

Fri, Jun 29, 2:27 PM
asbirlea committed rL336015: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an….
[MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an…
Fri, Jun 29, 1:51 PM
asbirlea closed D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..
Fri, Jun 29, 1:51 PM

Tue, Jun 26

asbirlea updated the diff for D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..

Address comment. Thank you for the review!

Tue, Jun 26, 5:46 PM
asbirlea accepted D48609: [AliasSet] Fix UnknownInstructions printing.

LGTM.

Tue, Jun 26, 3:07 PM
asbirlea added inline comments to D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..
Tue, Jun 26, 2:16 PM
asbirlea updated the diff for D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..

Address comments.

Tue, Jun 26, 2:15 PM

Fri, Jun 22

asbirlea updated the diff for D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..

nit: format.

Fri, Jun 22, 3:57 PM
asbirlea added inline comments to D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..
Fri, Jun 22, 3:16 PM
asbirlea updated the diff for D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..

Address comments.

Fri, Jun 22, 3:15 PM
asbirlea accepted D47683: [PM/LoopUnswitch] Teach the new unswitch to handle nontrivial unswitching of switches..

LGTM.

Fri, Jun 22, 2:32 PM
asbirlea committed rL335369: [LoopUnswitch]Fix comparison for DomTree updates..
[LoopUnswitch]Fix comparison for DomTree updates.
Fri, Jun 22, 10:19 AM
asbirlea closed D48457: [LoopUnswitch]Fix comparison for DomTree updates..
Fri, Jun 22, 10:19 AM

Thu, Jun 21

asbirlea added a comment to D48457: [LoopUnswitch]Fix comparison for DomTree updates..

Thank you for the review!

Thu, Jun 21, 4:29 PM
asbirlea updated the diff for D48457: [LoopUnswitch]Fix comparison for DomTree updates..

Add assert.

Thu, Jun 21, 4:29 PM
asbirlea added inline comments to D48457: [LoopUnswitch]Fix comparison for DomTree updates..
Thu, Jun 21, 3:37 PM
asbirlea created D48457: [LoopUnswitch]Fix comparison for DomTree updates..
Thu, Jun 21, 2:57 PM

Wed, Jun 20

asbirlea accepted D48414: [RISCV] Fix test/CodeGen/RISCV/indirectbr.ll after D48202.

I'm not clear why my testing didn't catch this test, but the label change looks exactly like what D48202 would change.
Appoving without retesting to unblock this.

Wed, Jun 20, 8:24 PM
asbirlea created D48396: [MemorySSA] Add APIs to MemoryPhis to delete incoming blocks/values, and an updater API to remove blocks..
Wed, Jun 20, 3:20 PM
asbirlea committed rL335183: Generalize MergeBlockIntoPredecessor. Replace uses of….
Generalize MergeBlockIntoPredecessor. Replace uses of…
Wed, Jun 20, 3:06 PM
asbirlea closed D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..
Wed, Jun 20, 3:05 PM
asbirlea committed rL335179: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..
[MemorySSA] Add convenience APIs in updater to avoid needing MSSA.
Wed, Jun 20, 2:35 PM
asbirlea closed D48334: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..
Wed, Jun 20, 2:34 PM
asbirlea added inline comments to D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..
Wed, Jun 20, 2:13 PM
asbirlea committed rL335174: [MemorySSA] Verify Phi incoming blocks are block predecessors..
[MemorySSA] Verify Phi incoming blocks are block predecessors.
Wed, Jun 20, 2:10 PM
asbirlea closed D48333: [MemorySSA] Verify Phi incoming blocks are block predecessors..
Wed, Jun 20, 2:10 PM
asbirlea updated the diff for D48334: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..

Address comments.

Wed, Jun 20, 1:57 PM
asbirlea added a comment to D48334: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..

Thank you for the review!

Wed, Jun 20, 1:57 PM
asbirlea added a comment to D48333: [MemorySSA] Verify Phi incoming blocks are block predecessors..

Thank you for the review!

Wed, Jun 20, 1:48 PM
asbirlea updated the diff for D48333: [MemorySSA] Verify Phi incoming blocks are block predecessors..

Fix nit.

Wed, Jun 20, 1:48 PM
asbirlea added a comment to D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

Thank you for the review!

Wed, Jun 20, 1:42 PM
asbirlea updated the diff for D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

Address comments.

Wed, Jun 20, 1:40 PM

Tue, Jun 19

asbirlea updated the diff for D48334: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..

Rush edit.

Tue, Jun 19, 1:54 PM
asbirlea created D48334: [MemorySSA] Add convenience APIs in updater to avoid needing MSSA..
Tue, Jun 19, 1:50 PM
asbirlea created D48333: [MemorySSA] Verify Phi incoming blocks are block predecessors..
Tue, Jun 19, 1:40 PM
asbirlea added a comment to D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

Updated scev.ll to be fully parametric (vs updating one label). All other tests should use variables as well, but that can be a separate cleanup.

Tue, Jun 19, 11:09 AM
asbirlea updated the diff for D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

format.

Tue, Jun 19, 11:04 AM
asbirlea updated the diff for D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

Address comments and rebase.

Tue, Jun 19, 11:03 AM

Mon, Jun 18

asbirlea accepted D48284: Simplify blockaddress usage before giving up in MergeBlockIntoPredecessor.
Mon, Jun 18, 3:57 PM

Jun 18 2018

asbirlea requested changes to D48284: Simplify blockaddress usage before giving up in MergeBlockIntoPredecessor.

Thank you for adding this!

Jun 18 2018, 3:18 PM
asbirlea accepted D48258: [LoopSimplifyCFG] Preserve Scalar Evolution in LoopSimplifyCFG.

Perhaps a more accurate description is "Invalidate ScEv in LoopSimplifyCFG" (when merging blocks).
LGTM.

Jun 18 2018, 3:03 PM
asbirlea accepted D47522: [PM/LoopUnswitch] Add partial non-trivial unswitching for invariant conditions feeding a chain of `and`s or `or`s for a branch..

LGTM.

Jun 18 2018, 2:57 PM
asbirlea added a comment to D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

Thank you for the comments!

Jun 18 2018, 11:51 AM
asbirlea updated the diff for D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..

Address comments.

Jun 18 2018, 11:51 AM

Jun 14 2018

asbirlea created D48202: Generalize MergeBlockIntoPredecessor. Replace uses of MergeBasicBlockIntoOnlyPred..
Jun 14 2018, 5:09 PM

Jun 8 2018

asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

This update is more a whole rewrite of the APIs.

Jun 8 2018, 6:23 PM

Jun 5 2018

asbirlea added inline comments to D47683: [PM/LoopUnswitch] Teach the new unswitch to handle nontrivial unswitching of switches..
Jun 5 2018, 3:47 PM
asbirlea added a comment to D47522: [PM/LoopUnswitch] Add partial non-trivial unswitching for invariant conditions feeding a chain of `and`s or `or`s for a branch..

Logic lgtm.

Jun 5 2018, 2:54 PM

May 29 2018

asbirlea accepted D47408: [PM/LoopUnswitch] When using the new SimpleLoopUnswitch pass, schedule loop-cleanup passes at the beginning of the loop pass pipeline, and re-enqueue loops after even trivial unswitching..

LG

May 29 2018, 2:12 PM
asbirlea added inline comments to D47407: [LoopInstSimplify] Re-implement the core logic of loop-instsimplify to be both simpler and substantially more efficient..
May 29 2018, 1:10 PM
asbirlea accepted D47407: [LoopInstSimplify] Re-implement the core logic of loop-instsimplify to be both simpler and substantially more efficient..

LGTM. Looks like a clean simplification to me.

May 29 2018, 10:46 AM

May 18 2018

asbirlea updated the diff for D47022: Update MemorySSA in SimpleLoopUnswitch..

Cleanup and clang-format.

May 18 2018, 9:53 AM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Some cleanup and clang-format.

May 18 2018, 9:53 AM

May 17 2018

asbirlea updated the diff for D40375: Use MemorySSA in LICM to do sinking and hoisting..

Rebase and ping.

May 17 2018, 7:00 PM
asbirlea added a dependent revision for D45300: Update MemorySSA BasicBlockUtils.: D47022: Update MemorySSA in SimpleLoopUnswitch..
May 17 2018, 11:47 AM
asbirlea added a dependency for D47022: Update MemorySSA in SimpleLoopUnswitch.: D45300: Update MemorySSA BasicBlockUtils..
May 17 2018, 11:47 AM
asbirlea created D47022: Update MemorySSA in SimpleLoopUnswitch..
May 17 2018, 11:45 AM

May 16 2018

asbirlea updated the diff for D45301: Update MemorySSA in LoopUnswitch..

Update to use new API in dependent patch.

May 16 2018, 5:23 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Update patch with the following:

  • Fix a few bugs that were triggered by tests in SimpleLoopUnswitch
  • Slightly modify current APIs and add a couple APIs motivated by SimpleLoopUnswitch
  • Add APIs to delete blocks (SimpleLoopUnswitch modifies the CFG heavily) and MemoryPhi entries.
May 16 2018, 5:22 PM
asbirlea added a comment to D46928: implantation example for new AliasAnalysis functions (getAddressesDistance + ModRefSameBuffer).

Thank you for the implementation patch!

May 16 2018, 1:30 PM

May 15 2018

asbirlea added a comment to D46864: add 2 functions to the ALiasAnalysis interface (getAddressesDistance + ModRefSameBuffer).

Would be good if you can also add an implementation of this API (in a dependent patch).
I'm not entirely clear on the use yet, e.g. "BuffUseResult sameBuff" in your example is never used. An actual implementation would help with understanding and reviewing.

May 15 2018, 10:27 AM

May 11 2018

asbirlea committed rL332153: [MemorySSA] getIncomingValueForBlock should return a MemoryAccess..
[MemorySSA] getIncomingValueForBlock should return a MemoryAccess.
May 11 2018, 4:03 PM
asbirlea closed D46779: [MemorySSA] getIncomingValueForBlock should return a MemoryAccess..
May 11 2018, 4:03 PM
asbirlea created D46779: [MemorySSA] getIncomingValueForBlock should return a MemoryAccess..
May 11 2018, 3:08 PM

May 3 2018

asbirlea added inline comments to D45299: API to update MemorySSA for cloned blocks..
May 3 2018, 2:55 PM
asbirlea updated the diff for D45300: Update MemorySSA BasicBlockUtils..

Rebase on dependent patch.

May 3 2018, 2:55 PM
asbirlea updated the diff for D45301: Update MemorySSA in LoopUnswitch..

Rebase on dependent patch.

May 3 2018, 2:55 PM
asbirlea updated the diff for D45299: API to update MemorySSA for cloned blocks..

Address comments.

May 3 2018, 2:55 PM

Apr 30 2018

asbirlea accepted D46295: [ubsan] Make the C++ code here not cast floating point values outside the range of an integer type to that integer type..

LGTM. Thanks for the change!

Apr 30 2018, 6:11 PM
asbirlea added inline comments to D38862: Add must alias info to ModRefInfo..
Apr 30 2018, 1:18 PM
asbirlea committed rL331222: [ModRefInfo] Rename local variable IsMustAlias to avoid shadowing MustAlias….
[ModRefInfo] Rename local variable IsMustAlias to avoid shadowing MustAlias…
Apr 30 2018, 1:16 PM

Apr 5 2018

asbirlea added inline comments to D45299: API to update MemorySSA for cloned blocks..
Apr 5 2018, 8:11 AM

Apr 4 2018

asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

First concern is duplicating functionality already present in MemorySSA. I honestly don't understand everything well enough, so it's possible there are chunks that can be factored out from existing methods and the ones in this patch.

Apr 4 2018, 5:46 PM
asbirlea added a comment to D45299: API to update MemorySSA for cloned blocks..

Uploaded D45300 and D45301 to give usage context.

Apr 4 2018, 5:00 PM
asbirlea added a dependency for D45301: Update MemorySSA in LoopUnswitch.: D45300: Update MemorySSA BasicBlockUtils..
Apr 4 2018, 4:55 PM
asbirlea added a dependent revision for D45300: Update MemorySSA BasicBlockUtils.: D45301: Update MemorySSA in LoopUnswitch..
Apr 4 2018, 4:55 PM
asbirlea created D45301: Update MemorySSA in LoopUnswitch..
Apr 4 2018, 4:55 PM
asbirlea added a dependency for D45300: Update MemorySSA BasicBlockUtils.: D45299: API to update MemorySSA for cloned blocks..
Apr 4 2018, 4:54 PM
asbirlea added a dependent revision for D45299: API to update MemorySSA for cloned blocks.: D45300: Update MemorySSA BasicBlockUtils..
Apr 4 2018, 4:54 PM