Page MenuHomePhabricator

asavonic (Andrew Savonichev)
OpenCL Compiler Engineer at Intel

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2016, 11:01 PM (137 w, 6 d)

Recent Activity

Dec 12 2018

asavonic committed rL348919: [OpenCL] Fix for TBAA information of pointer after addresspacecast.
[OpenCL] Fix for TBAA information of pointer after addresspacecast
Dec 12 2018, 1:54 AM
asavonic committed rC348919: [OpenCL] Fix for TBAA information of pointer after addresspacecast.
[OpenCL] Fix for TBAA information of pointer after addresspacecast
Dec 12 2018, 1:54 AM
asavonic closed D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast.
Dec 12 2018, 1:54 AM

Dec 10 2018

asavonic committed rL348752: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.
[OpenCL][CodeGen] Fix replacing memcpy with addrspacecast
Dec 10 2018, 4:06 AM
asavonic committed rC348752: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.
[OpenCL][CodeGen] Fix replacing memcpy with addrspacecast
Dec 10 2018, 4:06 AM
asavonic closed D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast.
Dec 10 2018, 4:06 AM

Nov 26 2018

asavonic added a comment to D54253: [OpenCL] Launch opencl-types.cl test only on x86.

FWIW, I'd vote for the first revision of this patch. From my

understanding, the test verifies that libclang is able to parse OpenCL
code correctly. It doesn't do anything specific to x86: target for x86 just
happens to support a set of OpenCL extensions.

I am trying to understand what exactly does it bring into testing if the code doesn't have anything target specific in there?

Nov 26 2018, 3:10 AM

Nov 22 2018

asavonic added a comment to D54253: [OpenCL] Launch opencl-types.cl test only on x86.

FWIW, I'd vote for the first revision of this patch. From my
understanding, the test verifies that libclang is able to parse OpenCL
code correctly. It doesn't do anything specific to x86: target for x86 just
happens to support a set of OpenCL extensions.

Nov 22 2018, 1:46 AM

Nov 8 2018

asavonic added a comment to D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.

Committed in r346392.

Nov 8 2018, 3:34 AM
asavonic committed rL346392: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Nov 8 2018, 3:28 AM
asavonic committed rC346392: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Nov 8 2018, 3:28 AM
asavonic added a comment to D54253: [OpenCL] Launch opencl-types.cl test only on x86.

LGTM.

Nov 8 2018, 3:01 AM

Nov 7 2018

asavonic added a comment to D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.

I reverted this change in r346338, as it breaks Index/opencl-types.cl LIT test. See http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/21503/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aopencl-types.cl

Nov 7 2018, 10:40 AM
asavonic committed rC346338: Revert r346326 [OpenCL] Add support of….
Revert r346326 [OpenCL] Add support of…
Nov 7 2018, 10:37 AM
asavonic committed rL346338: Revert r346326 [OpenCL] Add support of….
Revert r346326 [OpenCL] Add support of…
Nov 7 2018, 10:37 AM
asavonic committed rC346326: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Nov 7 2018, 7:47 AM
asavonic committed rL346326: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Nov 7 2018, 7:47 AM
asavonic closed D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension.
Nov 7 2018, 7:46 AM
asavonic committed rL346311: [OpenCL] Fix diagnostic message about overload candidates.
[OpenCL] Fix diagnostic message about overload candidates
Nov 7 2018, 5:09 AM
asavonic committed rC346311: [OpenCL] Fix diagnostic message about overload candidates.
[OpenCL] Fix diagnostic message about overload candidates
Nov 7 2018, 5:09 AM
asavonic closed D54152: [OpenCL] Fix diagnostic message about overload candidates.
Nov 7 2018, 5:09 AM

Oct 29 2018

asavonic committed rL345497: [OpenCL] Fix serialization of OpenCLExtensionDecls.
[OpenCL] Fix serialization of OpenCLExtensionDecls
Oct 29 2018, 4:16 AM
asavonic committed rC345497: [OpenCL] Fix serialization of OpenCLExtensionDecls.
[OpenCL] Fix serialization of OpenCLExtensionDecls
Oct 29 2018, 4:16 AM
asavonic closed D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls.
Oct 29 2018, 4:16 AM

Oct 26 2018

asavonic added inline comments to D53023: Prototype OpenCL BIFs using Tablegen.
Oct 26 2018, 8:42 AM
asavonic added a comment to D53023: Prototype OpenCL BIFs using Tablegen.

TODO
Measure the performance / size impact

Oct 26 2018, 8:33 AM

Oct 23 2018

asavonic committed rL345051: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h.
[OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h
Oct 23 2018, 10:07 AM
asavonic committed rC345051: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h.
[OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h
Oct 23 2018, 10:07 AM
asavonic closed D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from opencl-c.h.
Oct 23 2018, 10:07 AM
asavonic closed D51402: [OpenCL] Adding cl_intel_planar_yuv extension.

Committed revision 345044

Oct 23 2018, 9:17 AM
asavonic committed rL345044: [OpenCL] Add cl_intel_planar_yuv extension.
[OpenCL] Add cl_intel_planar_yuv extension
Oct 23 2018, 9:15 AM
asavonic committed rC345044: [OpenCL] Add cl_intel_planar_yuv extension.
[OpenCL] Add cl_intel_planar_yuv extension
Oct 23 2018, 9:15 AM
asavonic committed rL345038: [OpenCL][NFC] Unify ZeroToOCL* cast types.
[OpenCL][NFC] Unify ZeroToOCL* cast types
Oct 23 2018, 8:21 AM
asavonic committed rC345038: [OpenCL][NFC] Unify ZeroToOCL* cast types.
[OpenCL][NFC] Unify ZeroToOCL* cast types
Oct 23 2018, 8:21 AM
asavonic closed D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types.
Oct 23 2018, 8:21 AM

Oct 12 2018

asavonic added a reviewer for D53200: [OpenCL] Fix serialization of OpenCLExtensionDecls: JDevlieghere.
Oct 12 2018, 9:12 AM

Oct 11 2018

asavonic committed rL344246: [Sema][OpenCL] Improve diagnostics for not viable overloadable function….
[Sema][OpenCL] Improve diagnostics for not viable overloadable function…
Oct 11 2018, 6:37 AM
asavonic committed rC344246: [Sema][OpenCL] Improve diagnostics for not viable overloadable function….
[Sema][OpenCL] Improve diagnostics for not viable overloadable function…
Oct 11 2018, 6:37 AM
asavonic closed D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates.
Oct 11 2018, 6:37 AM

Sep 25 2018

asavonic created D52458: [OpenCL] Implement OpenCL math builtins: fp -> fp.
Sep 25 2018, 4:11 AM
asavonic created D52457: [OpenCL] Implement OpenCL convert builtin.
Sep 25 2018, 4:10 AM

Sep 17 2018

asavonic committed rC342370: [OpenCL] Allow blocks to capture arrays in OpenCL.
[OpenCL] Allow blocks to capture arrays in OpenCL
Sep 17 2018, 4:21 AM
asavonic committed rL342370: [OpenCL] Allow blocks to capture arrays in OpenCL.
[OpenCL] Allow blocks to capture arrays in OpenCL
Sep 17 2018, 4:21 AM
asavonic closed D51722: [OpenCL] Allow blocks to capture arrays in OpenCL.
Sep 17 2018, 4:21 AM
asavonic committed rL342367: Merge two attribute diagnostics into one.
Merge two attribute diagnostics into one
Sep 17 2018, 3:41 AM
asavonic committed rC342367: Merge two attribute diagnostics into one.
Merge two attribute diagnostics into one
Sep 17 2018, 3:41 AM
asavonic closed D51853: Merge two attribute diagnostics into one.
Sep 17 2018, 3:41 AM

Sep 11 2018

asavonic added a comment to D51544: [OpenCL] Split opencl-c.h header.

With this setup, we can compile opencl-c-common.h, opencl-c-fp16.h and
opencl-c-fp64.h into PCHs with one set of extensions/OpenCL version,
and use them for any other set of extensions/OpenCL version. Clang
will detect this and throw out an error, which can be safely disabled
by -fno-validate-pch option.

However, keeping this as a permanent solution is unsafe. Because this way can result in unexpected errors to be silent out and allow erroneous configurations to be accepted successfully without any notification.

Sep 11 2018, 3:55 AM

Sep 10 2018

asavonic created D51853: Merge two attribute diagnostics into one.
Sep 10 2018, 4:25 AM

Sep 7 2018

asavonic added a comment to D51544: [OpenCL] Split opencl-c.h header.

Currently the main header still contains everything, so the size of the PCH won't change.

The idea is that we don't pre-compile the whole opencl-c.h, we split
it into several headers (3 of them are target independent) and
pre-compile them instead.

Sep 7 2018, 8:02 AM

Sep 6 2018

asavonic committed rC341553: [OpenCL] Relax diagnostics on OpenCL access qualifiers.
[OpenCL] Relax diagnostics on OpenCL access qualifiers
Sep 6 2018, 8:14 AM
asavonic committed rL341553: [OpenCL] Relax diagnostics on OpenCL access qualifiers.
[OpenCL] Relax diagnostics on OpenCL access qualifiers
Sep 6 2018, 8:14 AM
asavonic closed D51302: [OpenCL] Relax diagnostics on OpenCL access qualifiers.
Sep 6 2018, 8:14 AM
asavonic closed D51302: [OpenCL] Relax diagnostics on OpenCL access qualifiers.
Sep 6 2018, 8:14 AM
asavonic committed rL341539: [OpenCL] Disallow negative attribute arguments.
[OpenCL] Disallow negative attribute arguments
Sep 6 2018, 4:56 AM
asavonic committed rC341539: [OpenCL] Disallow negative attribute arguments.
[OpenCL] Disallow negative attribute arguments
Sep 6 2018, 4:56 AM
asavonic closed D50259: [OpenCL] Disallow negative attribute arguments.
Sep 6 2018, 4:56 AM

Sep 5 2018

asavonic added a comment to D51544: [OpenCL] Split opencl-c.h header.

It seems generally good to partition this big header but I am trying to understand what problem is it trying to solve now?

Sep 5 2018, 8:53 AM

Aug 31 2018

asavonic created D51544: [OpenCL] Split opencl-c.h header.
Aug 31 2018, 8:49 AM

Aug 20 2018

asavonic updated the summary of D50259: [OpenCL] Disallow negative attribute arguments.
Aug 20 2018, 12:36 AM

Aug 3 2018

asavonic created D50259: [OpenCL] Disallow negative attribute arguments.
Aug 3 2018, 8:51 AM

Aug 2 2018

asavonic committed rL338686: [emacs] Indent statement continuation to match clang-format.
[emacs] Indent statement continuation to match clang-format
Aug 2 2018, 1:51 AM
asavonic closed D49726: [emacs] Indent statement continuation to match clang-format.
Aug 2 2018, 1:51 AM

Aug 1 2018

asavonic added a comment to D49726: [emacs] Indent statement continuation to match clang-format.

I've requested a commit access from Chris, and hopefully I will commit this patch soon. Otherwise I'll ask someone to commit it.
Thanks for the review!

Aug 1 2018, 10:38 AM

Jul 31 2018

asavonic updated the summary of D49726: [emacs] Indent statement continuation to match clang-format.
Jul 31 2018, 3:05 AM
asavonic added inline comments to D49726: [emacs] Indent statement continuation to match clang-format.
Jul 31 2018, 3:04 AM
asavonic updated the diff for D49726: [emacs] Indent statement continuation to match clang-format.

Use c-lineup-assignment.

Jul 31 2018, 3:02 AM

Jul 30 2018

asavonic added a reviewer for D49726: [emacs] Indent statement continuation to match clang-format: MaskRay.
Jul 30 2018, 3:53 AM

Jul 27 2018

asavonic updated the diff for D49723: [OpenCL] Check for invalid kernel arguments in array types.

Rollback accidentally squashed commit.

Jul 27 2018, 7:26 AM
asavonic added a comment to D49723: [OpenCL] Check for invalid kernel arguments in array types.

Btw, has this restriction been removed from CL 2.0?

No, it applies for CL2.0 as well.

It seems however the restriction on pointer to pointer was removed (see s6.9.a last item) in CL2.0.

Jul 27 2018, 7:22 AM
asavonic updated the diff for D49723: [OpenCL] Check for invalid kernel arguments in array types.

Fix assert.

Jul 27 2018, 7:22 AM

Jul 26 2018

asavonic added inline comments to D49725: [OpenCL] Forbid size dependent types used as kernel arguments.
Jul 26 2018, 5:57 AM
asavonic updated the diff for D49725: [OpenCL] Forbid size dependent types used as kernel arguments.

Moved unrelated change to https://reviews.llvm.org/D49723.

Jul 26 2018, 5:54 AM
asavonic updated the diff for D49723: [OpenCL] Check for invalid kernel arguments in array types.

Moved another chunk from https://reviews.llvm.org/D49725

Jul 26 2018, 5:52 AM

Jul 25 2018

asavonic added a comment to D49725: [OpenCL] Forbid size dependent types used as kernel arguments.

This patch also adds check for array of structs. Can you include this in title or split to a separate patch?

Jul 25 2018, 4:19 AM
asavonic updated the diff for D49725: [OpenCL] Forbid size dependent types used as kernel arguments.

Added a diagnostic note for typedefs; moved unrelated changes to
https://reviews.llvm.org/D49723.

Jul 25 2018, 4:12 AM
asavonic added a comment to D49723: [OpenCL] Check for invalid kernel arguments in array types.

Btw, has this restriction been removed from CL 2.0?

Jul 25 2018, 4:08 AM
asavonic updated the diff for D49723: [OpenCL] Check for invalid kernel arguments in array types.

Moved a chunk from https://reviews.llvm.org/D49725; added 2 more tests.

Jul 25 2018, 4:06 AM

Jul 24 2018

asavonic created D49726: [emacs] Indent statement continuation to match clang-format.
Jul 24 2018, 5:39 AM
asavonic added reviewers for D49723: [OpenCL] Check for invalid kernel arguments in array types: Anastasia, yaxunl.
Jul 24 2018, 4:40 AM
asavonic added reviewers for D49725: [OpenCL] Forbid size dependent types used as kernel arguments: Anastasia, yaxunl.
Jul 24 2018, 4:39 AM
asavonic created D49725: [OpenCL] Forbid size dependent types used as kernel arguments.
Jul 24 2018, 4:34 AM
asavonic created D49723: [OpenCL] Check for invalid kernel arguments in array types.
Jul 24 2018, 4:34 AM

Jun 4 2018

asavonic updated the diff for D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library.

Addressed CR comments, added a diagnostic if shared library was not loaded.

Jun 4 2018, 7:48 AM

May 23 2018

asavonic updated the diff for D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library.

Fixed warning about void* to function pointer cast.

May 23 2018, 8:31 AM

May 22 2018

asavonic retitled D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library from [Driver] Add -ivfsoverlay-lib option to load VFS from shared to [Driver] Add -ivfsoverlay-lib option to load VFS from shared library.
May 22 2018, 7:54 AM
asavonic added a reviewer for D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library: rsmith.
May 22 2018, 4:23 AM
asavonic updated the diff for D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library.

Add license header.

May 22 2018, 2:55 AM
asavonic added a reviewer for D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library: benlangmuir.
May 22 2018, 2:51 AM
asavonic created D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library.
May 22 2018, 2:44 AM

Oct 24 2016

asavonic updated the diff for D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.
  • Fix comments and code formatting
Oct 24 2016, 4:10 AM

Oct 4 2016

asavonic updated the diff for D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.
  • Describe OpenCLOptions::set() function
  • Move -cl-ext option to cc1
  • Reword -cl-ext option help
  • Move -cl-ext handling out of target-specific code
  • Add two more test cases regarding -cl-ext option
Oct 4 2016, 3:29 AM

Sep 22 2016

asavonic added inline comments to D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.
Sep 22 2016, 1:40 AM
asavonic updated the diff for D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.

Add more test cases and fix minor issues

Sep 22 2016, 1:28 AM

Sep 20 2016

asavonic added a comment to D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.

Sorry for my late reply.

Sep 20 2016, 4:57 AM

Aug 24 2016

asavonic added a comment to D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.

What would be the use case to override the supported extensions for the end user?

Aug 24 2016, 3:35 AM

Aug 19 2016

asavonic updated the diff for D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option.
  • Remove unused test case
Aug 19 2016, 5:43 AM
asavonic retitled D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option from to [OpenCL] Override supported OpenCL extensions with -cl-ext option.
Aug 19 2016, 5:20 AM

Jul 8 2016

asavonic added inline comments to D20948: [OpenCL] Fix access qualifiers handling for typedefs.
Jul 8 2016, 7:38 AM
asavonic added a comment to D20948: [OpenCL] Fix access qualifiers handling for typedefs.
Jul 8 2016, 7:34 AM