- User Since
- Nov 16 2017, 6:22 PM (74 w, 1 d)
Thanks for the review, I addressed your comments:
- Removed the reference, and pass the AST node as a pointer.
- Made a few decls auto
Wed, Apr 17
Tue, Apr 2
LGTM, I'll let @jhenderson weigh-in to see what he says.
LGTM, as long as @rupprecht's comment is addressed.
Mon, Apr 1
Sat, Mar 30
Thu, Mar 28
Fri, Mar 22
Mar 13 2019
Mar 7 2019
Makes sense. LGTM.
Mar 1 2019
Thanks for the reviews everyone. This update addresses the feedback, all of which was incorporated.
Feb 28 2019
Feb 27 2019
I like this and think users will find it very helpful. The changes seem sensible to me; however, I had a few nits... mostly stylistic things, no big deals. Anyways, I'll mark this patch as accept, as long as you cover the suggestions made by @lebedev.ri.
- Fixed the test case (removed underscore typo, and extraneous shstrtab test).
- Emit ANDROID_REL ANDROID_RELA instead of section offsets.
- Modified the range check, allowing us to remove some now redundant code for printing the lower-bound section names.
Feb 26 2019
- Added a more complicated test.
- Made a few variables 'auto' instead of their iterator type.
Feb 20 2019
LGTM. Thanks for adding these.
Feb 19 2019
Feb 18 2019
Feb 14 2019
Feb 12 2019
Feb 11 2019
LGTM. I had a few suggestions but nothing looks wrong to me.
Feb 7 2019
I've updated the patch to replicate GNU's c++filt behavior. This patch now only splits strings that are passed via stdin. It does not split strings that are passed as arguments to llvm-cxxfilt via command line.
Feb 6 2019
The test case in your patch definitely causes a problem, but that's because the -start-before/-stop-after is used. If I run that same test through llc, the UnreachableBlockElim pass kicks-in and drops the dead code.
I took a look at the code in your Janurary 24th comment. I was unable to get the same dead block to surface, but most likely I had the wrong flag set. How did you build the sample in that comment?
Feb 5 2019
Feb 4 2019
Feb 1 2019
Jan 31 2019
- Update two tests to use FileChecks --implicit-check-not
- Remove some cruft that, I think, was in an earlier version of this patch.
- Update the CHECK-COUNT test to simply perform a CHECK followed by a CHECK-NOT.
Jan 30 2019
- I took a hint and decided to more the decision to print the section mapping with the program headers down into the dumper classes. This is similar to how the printSymbols and printDynamicSymbols are handled.
- Removed a test
- Replaced the uses of grep in the tests with CHECK-NOT and CHECK-COUNT
- Update a comment, it was bothering me.
- Updated the test to also look at the presentation of other sections/symbols, not just the debug sections.
- Replaced the use of an auto with the actual type.
- Rebased against master.
Jan 29 2019
Thanks for the feedback, and my apologies for not originally providing as thorough of
testing as I should have.
- Moved the call to printSectionMapping after printSectionHeaders`
- Specifying --program-headers will still print the section mapping; however, the calls to printSectionMapping has been removed from the body of printProgramHeaders