Page MenuHomePhabricator

mdchen (Mindong Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2020, 7:07 AM (40 w, 4 d)

Recent Activity

Fri, Jun 11

mdchen added reviewers for D104148: WIP: [LoopUtils] Fix incorrect runtimechecks: fhahn, reames, nikic.
Fri, Jun 11, 1:24 PM · Restricted Project
mdchen updated the summary of D104148: WIP: [LoopUtils] Fix incorrect runtimechecks.
Fri, Jun 11, 1:24 PM · Restricted Project
mdchen requested review of D104148: WIP: [LoopUtils] Fix incorrect runtimechecks.
Fri, Jun 11, 1:17 PM · Restricted Project

Wed, Jun 2

mdchen added a comment to D102759: [AArch64ISelDAGToDAG] Supplement cases for ORRWrs/ORRXrs when calculating usefulbits.

LGTM, but please wait for a couple of days for experts in this area to review: )

Wed, Jun 2, 12:52 AM · Restricted Project

Tue, Jun 1

mdchen added a comment to D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210).

@lebedev.ri

It fails even if i bump those limits to 0.1M iterations.
This is clearly an infinite combine cycle.

If that's the case, isn't it more reasonable to replace the fatal_error with assert so that only developers sense that?

Tue, Jun 1, 11:48 PM · Restricted Project

Mon, May 31

mdchen updated subscribers of D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210).

Reduced .ll:

$ opt -instcombine -S -o - reduce.ll
LLVM ERROR: Instruction Combining seems stuck in an infinite loop after 100 iterations.
...
Mon, May 31, 6:37 PM · Restricted Project

Sun, May 30

mdchen committed rG71acce68daf4: [NFCI] Move DEBUG_TYPE definition below #includes (authored by mdchen).
[NFCI] Move DEBUG_TYPE definition below #includes
Sun, May 30, 2:32 AM
mdchen closed D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers.
Sun, May 30, 2:32 AM · Restricted Project

Wed, May 19

mdchen added inline comments to D102759: [AArch64ISelDAGToDAG] Supplement cases for ORRWrs/ORRXrs when calculating usefulbits.
Wed, May 19, 4:23 AM · Restricted Project
mdchen added reviewers for D102759: [AArch64ISelDAGToDAG] Supplement cases for ORRWrs/ORRXrs when calculating usefulbits: paulwalker-arm, sdesmalen, eli.friedman.
Wed, May 19, 4:13 AM · Restricted Project

Tue, May 18

mdchen added a comment to D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers.

lgtm. this seems fine to me, but presumably we would have a compile error if there was ever a conflict in practice with one of these files?

Tue, May 18, 6:07 PM · Restricted Project

Mon, May 17

mdchen added reviewers for D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers: kparzysz, tejohnson.
Mon, May 17, 3:18 AM · Restricted Project
mdchen added a reviewer for D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers: jdoerfert.
Mon, May 17, 3:13 AM · Restricted Project
mdchen updated the diff for D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers.

Did a fully scan and modified more files that have the same issue.

Mon, May 17, 3:11 AM · Restricted Project
mdchen added a comment to D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers.
Mon, May 17, 12:37 AM · Restricted Project

Sun, May 16

mdchen requested review of D102594: [NFCI] Move DEBUG_TYPE definition below #include of headers.
Sun, May 16, 11:55 PM · Restricted Project

Apr 21 2021

mdchen added a comment to rG748ae5281d4f: [IR][SVE] Add new llvm.experimental.stepvector intrinsic.

@david-arm Glad to know that. Thank you for the work!

Apr 21 2021, 12:48 AM
mdchen added a comment to rG748ae5281d4f: [IR][SVE] Add new llvm.experimental.stepvector intrinsic.

@david-arm Hi David, there's a tiny issue of the commit that the llvm.experimental.stepvector intrinsic is not well indexed in the changes to Langref.rst, and now it resides under llvm.experimental.vector.splice. I guess it's not intended and leave a message here FYI:)

Apr 21 2021, 12:34 AM

Jan 27 2021

mdchen committed rG00fcc0368731: [SCEV] Fix incorrect loop exit count analysis. (authored by mdchen).
[SCEV] Fix incorrect loop exit count analysis.
Jan 27 2021, 3:38 AM
mdchen closed D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Jan 27 2021, 3:37 AM · Restricted Project

Jan 24 2021

mdchen added a comment to D92367: [SCEV] Fix incorrect exit count calculated in error scope.

ping

Jan 24 2021, 7:09 PM · Restricted Project

Jan 20 2021

mdchen updated the diff for D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Jan 20 2021, 5:03 AM · Restricted Project
mdchen committed rG5d718374a68f: [SCEV] Add a test with wrong exit counts. (NFC) (authored by mdchen).
[SCEV] Add a test with wrong exit counts. (NFC)
Jan 20 2021, 5:00 AM
mdchen closed D94657: [SCEV] Add test for exit count analysis.
Jan 20 2021, 5:00 AM · Restricted Project

Jan 19 2021

mdchen added a comment to D94657: [SCEV] Add test for exit count analysis.

@mkazantsev Could you commit this for me, thanks!
My commit access application has been approved so I'll commit by myself:)

Jan 19 2021, 3:02 AM · Restricted Project

Jan 14 2021

mdchen added inline comments to D93764: [LoopUnswitch] Implement first version of partial unswitching..
Jan 14 2021, 7:20 PM · Restricted Project
mdchen added inline comments to D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Jan 14 2021, 5:25 PM · Restricted Project
mdchen requested review of D94657: [SCEV] Add test for exit count analysis.
Jan 14 2021, 12:34 AM · Restricted Project

Dec 17 2020

mdchen added a comment to D92367: [SCEV] Fix incorrect exit count calculated in error scope.

ping

Dec 17 2020, 10:52 PM · Restricted Project

Dec 8 2020

mdchen added inline comments to D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Dec 8 2020, 10:08 PM · Restricted Project

Dec 7 2020

mdchen updated the diff for D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Dec 7 2020, 1:10 AM · Restricted Project

Dec 5 2020

mdchen added inline comments to D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Dec 5 2020, 8:18 PM · Restricted Project

Dec 1 2020

mdchen updated the diff for D92367: [SCEV] Fix incorrect exit count calculated in error scope.

Add a test case.

Dec 1 2020, 5:37 AM · Restricted Project
mdchen added a comment to D92367: [SCEV] Fix incorrect exit count calculated in error scope.

@lebedev.ri Thanks, will add a test. Besides, the bug fixed in ea7ab5a42cd4 seems to have the same root cause.

Dec 1 2020, 1:06 AM · Restricted Project
mdchen requested review of D92367: [SCEV] Fix incorrect exit count calculated in error scope.
Dec 1 2020, 12:40 AM · Restricted Project

Nov 26 2020

mdchen added a comment to D71673: [InstCombine] Improve infinite loop detection.

@kuhar @lebedev.ri I'm lucky to have a test case which requires exactly 1001 times iteration thus aborts. And would it be better just break out rather than report a fatal error?

Nov 26 2020, 4:32 AM · Restricted Project

Nov 22 2020

mdchen added a comment to D87879: [LoopInterchange] Add dominance check to guarantee output dependency order.

Actually, could we get similar problems for dependencies other than output, eg if we have a conditional load that is later used?

Yes, there're similar cases our team have found related to data dependence that may prohibit interchange. And I'd like to spend more time to see if there's a sophisticated solution.

Nov 22 2020, 6:44 PM · Restricted Project

Oct 12 2020

mdchen added a comment to D87879: [LoopInterchange] Add dominance check to guarantee output dependency order.

ping

Oct 12 2020, 7:13 PM · Restricted Project

Sep 21 2020

mdchen added a comment to D87879: [LoopInterchange] Add dominance check to guarantee output dependency order.

@fhahn Thanks for the suggestions, please take another look.

Sep 21 2020, 1:34 AM · Restricted Project
mdchen updated the diff for D87879: [LoopInterchange] Add dominance check to guarantee output dependency order.
Sep 21 2020, 1:27 AM · Restricted Project

Sep 17 2020

mdchen requested review of D87879: [LoopInterchange] Add dominance check to guarantee output dependency order.
Sep 17 2020, 9:09 PM · Restricted Project

Sep 2 2020

mdchen added inline comments to D86939: [LSR] Canonicalize a formula before insert it into the list.
Sep 2 2020, 8:06 PM · Restricted Project
mdchen added a comment to D86939: [LSR] Canonicalize a formula before insert it into the list.

add a test case

Sep 2 2020, 6:28 AM · Restricted Project
mdchen updated the diff for D86939: [LSR] Canonicalize a formula before insert it into the list.
Sep 2 2020, 6:28 AM · Restricted Project

Sep 1 2020

mdchen requested review of D86939: [LSR] Canonicalize a formula before insert it into the list.
Sep 1 2020, 7:15 AM · Restricted Project