- User Since
- Nov 16 2012, 6:02 PM (348 w, 2 d)
Fri, Jul 19
Thu, Jul 18
Wed, Jul 17
Tue, Jul 16
Mon, Jul 15
Sun, Jul 14
Thu, Jul 11
Wed, Jul 10
Tue, Jul 9
Ah, fun with overloaded, legacy command-line options...
Do we have any policies against using clang-only builtins in the codebase?
However, if CMBB is in a loop body, we might get performance degradation.
Mon, Jul 8
Can you please upload a patch with full context?
Fri, Jul 5
Is this really a PowerPC-specific problem? Do we just want to have a general post-RA cleanup that checks for isMoveImmediate() and does this cleanup?
Do you have any kind of test case? I suppose that you can check the output in a test in test/Analysis/LoopInfo to show the ordering?
Thu, Jul 4
We may need to disable the Pre-RA or Post-RA scheduler. Add the feature control for it.
Wed, Jul 3
I'd prefer we remove the redundant comments in TTIImpl.h (see below), but otherwise, LGTM.
One question below, but otherwise, LGTM.
Tue, Jul 2
Can you please add a test ensuring that -malign-double and -mlong-double-64 interact properly? I think that, in the current patch, they do (as -malign-double is processed first), but I'd prefer that we cover that case explicitly.
If we already search the member instructions, then this seems like the right thing to do. LGTM
Mon, Jul 1
Wed, Jun 26
Tue, Jun 25
Jun 18 2019
Jun 15 2019
I assume that you're posting this for initial feedback, but a patch description explaining the usage model would be helpful.
Can you please update this patch with full context?
The test case does an (out of bounds) load from a global constant with type <3 x float>.
Jun 14 2019
Jun 13 2019
Transform all store nodes into one single node to ensure the order of all store nodes can't be changed. So that the push instruction sequence generated would be correct.
Again, I see no reason to believe that everyone here isn't acting in good faith and working to create the software of the highest possible quality. Thanks!
Sorry, but Johannes did this. "The more patches go through with this kind of "review" the more "suspicious" this looks to me." It is his words. seems to me, he does not think that me or my colleagues are acting in good faith.
Jun 12 2019
I'm specifically asking that this change not be committed - despite Hal's LGTM - before this point is addressed.
This LGTM. I suggest that we commit this along with the implementation.
Jun 11 2019