anemet (Adam Nemet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2014, 12:07 PM (169 w, 1 d)

Recent Activity

Fri, Oct 13

anemet added a comment to D38886: Try to avoid prefetches from disrupting folding of loads..

It's unintuitive why you need to fix this at the IR level. Both the load and the prefetch should be uses of address and there should be no dependence between them.

Fri, Oct 13, 10:37 AM

Thu, Oct 12

anemet committed rL315643: Handle/assert on DK_Remark.
Handle/assert on DK_Remark
Thu, Oct 12, 4:57 PM
anemet committed rL315642: Add DK_Remark to SMDiagnostic.
Add DK_Remark to SMDiagnostic
Thu, Oct 12, 4:56 PM
anemet closed D38865: Add DK_Remark to SMDiagnostic by committing rL315642: Add DK_Remark to SMDiagnostic.
Thu, Oct 12, 4:56 PM
anemet added a comment to D38865: Add DK_Remark to SMDiagnostic.

Seems reasonable to me. I don't know anything about the MIR parser's use of diagnostics, though.

Thu, Oct 12, 4:54 PM
anemet created D38865: Add DK_Remark to SMDiagnostic.
Thu, Oct 12, 4:48 PM

Wed, Oct 11

anemet added inline comments to D38768: Add remarks describing when a pass changes the IR instruction count of a module.
Wed, Oct 11, 11:52 AM
anemet updated subscribers of D38722: Added Remarks for Loop Versioning LICM Pass.
Wed, Oct 11, 8:58 AM

Tue, Oct 10

anemet accepted D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.

LGTM. Thanks!

Tue, Oct 10, 8:46 PM
anemet added a comment to D38722: Added Remarks for Loop Versioning LICM Pass.

Thanks for working on this!

Tue, Oct 10, 9:05 AM
anemet accepted D38289: [opt-viewer] Don't Decode HTML bytes for Python 2.

Sorry about the delay! I remembered something similar also for Python2 so I wanted to doublecheck. Turns out that was https://reviews.llvm.org/D29802 which is unrelated.

Tue, Oct 10, 9:00 AM

Mon, Oct 9

anemet committed rL315253: Rename OptimizationDiagnosticInfo.h to OptimizationRemarkEmitter.h.
Rename OptimizationDiagnosticInfo.h to OptimizationRemarkEmitter.h
Mon, Oct 9, 4:49 PM
anemet committed rL315249: Rename OptimizationDiagnosticInfo.* to OptimizationRemarkEmitter.*.
Rename OptimizationDiagnosticInfo.* to OptimizationRemarkEmitter.*
Mon, Oct 9, 4:19 PM
anemet committed rL315230: Point to bugzilla for opt-remark projects..
Point to bugzilla for opt-remark projects.
Mon, Oct 9, 12:02 PM
anemet added a comment to D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.

One more idea for improvement and then this is ready to go.

Mon, Oct 9, 8:54 AM

Wed, Oct 4

anemet committed rL314909: [OptRemark] Move YAML writing to IR.
[OptRemark] Move YAML writing to IR
Wed, Oct 4, 8:20 AM
anemet committed rL314908: Also update MachineORE after r314874..
Also update MachineORE after r314874.
Wed, Oct 4, 8:20 AM

Tue, Oct 3

anemet committed rL314874: Move verbosity check for remarks to the diag handler.
Move verbosity check for remarks to the diag handler
Tue, Oct 3, 9:28 PM
anemet committed rL314873: Move verbosity check for opt remarks to the diag handler..
Move verbosity check for opt remarks to the diag handler.
Tue, Oct 3, 9:27 PM
anemet added a comment to D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.

Also remember to add llvm-commit/cfe-commit when you create the review.

Tue, Oct 3, 6:06 PM
anemet added inline comments to D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.
Tue, Oct 3, 6:05 PM

Fri, Sep 29

anemet committed rL314537: Display relative hotness with two decimal digits after the decimal point.
Display relative hotness with two decimal digits after the decimal point
Fri, Sep 29, 9:58 AM

Thu, Sep 28

anemet committed rL314491: Make find_opt_files vararg.
Make find_opt_files vararg
Thu, Sep 28, 10:22 PM
anemet added a comment to D38345: [SLP] Added more missed optimiazation remarks.

Thanks for your patch! Please include the full context for the diff and add llvm-commits as subscriber; that should be done when creating the review, otherwise the mailing list does not get the complete picture. See http://llvm.org/docs/Phabricator.html for more details.

Thu, Sep 28, 9:04 AM

Tue, Sep 19

anemet committed rL313693: Add override for ClangDiagnosticHandler::isAnyRemarkEnabled().
Add override for ClangDiagnosticHandler::isAnyRemarkEnabled()
Tue, Sep 19, 4:04 PM
anemet committed rL313691: Allow ORE.emit to take a closure to delay building the remark object.
Allow ORE.emit to take a closure to delay building the remark object
Tue, Sep 19, 4:02 PM
anemet committed rL313653: Fix ClangDiagnosticHandler::is*RemarkEnabled members.
Fix ClangDiagnosticHandler::is*RemarkEnabled members
Tue, Sep 19, 11:01 AM

Sep 15 2017

anemet updated the diff for D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.

Add comment

Sep 15 2017, 2:18 PM
anemet updated the diff for D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.

Implement DiagHandler::isAnyRemarkEnabled(void)

Sep 15 2017, 1:57 PM
anemet committed rL313383: Improve comment.
Improve comment
Sep 15 2017, 12:39 PM
anemet created D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.
Sep 15 2017, 12:33 PM

Sep 13 2017

anemet accepted D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

LGTM.

Sep 13 2017, 4:14 PM
anemet accepted D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Still looks good.

Sep 13 2017, 4:12 PM

Sep 12 2017

anemet added a comment to D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Why? That was inside BackendConsumer.

I was getting incomplete type error.

Sep 12 2017, 5:17 PM

Sep 11 2017

anemet added inline comments to D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.
Sep 11 2017, 9:50 PM
anemet accepted D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

LGTM with the nits below. Thanks!

Sep 11 2017, 9:10 PM

Sep 8 2017

anemet added a comment to D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Please clean this up as well (don't have commented-out lines) so that it's ready to go with the LLVM patch.

Sep 8 2017, 10:21 AM
anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Only minor things at this point. This is very close now.

Sep 8 2017, 10:08 AM

Sep 5 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Not really. The test is actually GVN: test/Transforms/GVN/opt-remarks.ll. I just made some improvements in

Sep 5 2017, 11:05 AM
anemet committed rL312544: Split opt-remark YAML and opt output testing on this test.
Split opt-remark YAML and opt output testing on this test
Sep 5 2017, 11:05 AM
anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

You also need to add a test. You should be able to extend either the LICM's or the Vectorizer's test to also get the remarks due to allowExtraAnalysis with -pass-remarks not just with -pass-remarks-output.

If I understand this correctly then we need to remove -pass-remarks-output from all test which uses it just to return allowExtraAnalysis() true right? Also I think these kind of test uses llc .

Sep 5 2017, 11:00 AM

Sep 1 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

You also need to add a test. You should be able to extend either the LICM's or the Vectorizer's test to also get the remarks due to allowExtraAnalysis with -pass-remarks not just with -pass-remarks-output.

Sep 1 2017, 11:50 PM
anemet updated subscribers of D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.
Sep 1 2017, 11:25 PM

Aug 30 2017

anemet accepted D37085: [MachineOutliner] Add missed optimization remarks based off outliner cost model.

LGTM.

Aug 30 2017, 3:42 PM

Aug 29 2017

anemet added a comment to D37085: [MachineOutliner] Add missed optimization remarks based off outliner cost model.

Nice improvements.

Aug 29 2017, 3:02 PM

Aug 28 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

This is getting close so besides the comments below, please also start cleaning up the patch so that the diff is as tight as possible. Thanks!

Aug 28 2017, 11:37 PM
anemet committed rL311948: Remove an unnecessary const_cast..
Remove an unnecessary const_cast.
Aug 28 2017, 4:01 PM

Aug 23 2017

anemet added a comment to D37085: [MachineOutliner] Add missed optimization remarks based off outliner cost model.

You need a test ;)

Aug 23 2017, 9:41 PM
anemet committed rL311628: Support all integer types in DiagnosticInfoOptimizationBase::Argument.
Support all integer types in DiagnosticInfoOptimizationBase::Argument
Aug 23 2017, 9:06 PM

Aug 21 2017

anemet accepted D36972: [ORE] Remove Old Optimization Remark API.

Yay, LGTM!

Aug 21 2017, 11:43 AM
anemet accepted D36943: Migrate WholeProgramDevirt to new Optimization Remark API.

LGTM with the nits below. We're done migrating!!!! Thanks for your work on this!

Aug 21 2017, 8:51 AM
anemet added a comment to D36054: Emit only A Single Opt Remark When Inlining.

LGTM. Are you going to commit this as is or fix the new PM -pass-remarks-output first and update this? I am fine either way.

Aug 21 2017, 8:47 AM
anemet accepted D36949: [clang] Fix tests for Emitting Single Inline Remark.

LGTM.

Aug 21 2017, 8:42 AM
anemet accepted D36950: [lld] Update Tests for Emitting Single Inline Remark.

LGTM.

Aug 21 2017, 8:41 AM

Aug 20 2017

anemet added inline comments to D36943: Migrate WholeProgramDevirt to new Optimization Remark API.
Aug 20 2017, 7:22 PM

Aug 18 2017

anemet accepted D36906: Keep Optimization Remark Yaml in NewPM.

LGTM, thanks!

Aug 18 2017, 10:24 PM
anemet added a comment to D36054: Emit only A Single Opt Remark When Inlining.

LGTM. Are you going to commit this as is or fix the new PM -pass-remarks-output first and update this? I am fine either way.

I think I'm going to pause on this patch for a moment until the other is accepted and committed.

I think I have that fix (as far as code is concerned), but I think that patch should include updating all tests that currently only use the old pass manager to emit remark yaml files to also make them do exactly the same with the new pass manager, and that will take a little longer. Expect the complete patch of both code and tests some time over the weekend, I think.

Aug 18 2017, 5:15 PM
anemet accepted D36054: Emit only A Single Opt Remark When Inlining.

LGTM. Are you going to commit this as is or fix the new PM -pass-remarks-output first and update this? I am fine either way.

Aug 18 2017, 4:54 PM
anemet added inline comments to D36054: Emit only A Single Opt Remark When Inlining.
Aug 18 2017, 4:32 PM

Aug 14 2017

anemet accepted D36716: [LoopDataPrefetch][AArch64FalkorHWPFFix] Preserve ScalarEvolution.

LGTM. Please watch out for any failures.

Aug 14 2017, 3:57 PM

Aug 11 2017

anemet accepted D36630: [opt-viewer] Listify `dict_items` for Py3 indexing.

LGTM, thanks.

Aug 11 2017, 2:45 PM
anemet accepted D36624: [opt-viewer] Decode HTML bytes for Python 3.

LGTM, with the same note here: as long as it still works with Python2 (which I am less sure of in this case).

Aug 11 2017, 11:01 AM
anemet accepted D36622: [opt-viewer] Use Python 3-compatible `intern()`.

LGTM, assuming it still works with Python2. (I don't see why it wouldn't.)

Aug 11 2017, 10:30 AM
anemet accepted D36623: [opt-viewer] Use Python 3-compatible iteritems.

LGTM, sorry :(.

Aug 11 2017, 10:29 AM

Aug 10 2017

anemet accepted D36127: [OptDiag] Updating Remarks in SampleProfile.

LGTM, thanks!

Aug 10 2017, 7:45 PM
anemet added inline comments to D36127: [OptDiag] Updating Remarks in SampleProfile.
Aug 10 2017, 5:03 PM
anemet added a comment to D36127: [OptDiag] Updating Remarks in SampleProfile.

-pass-remarks-with-hotness doesn't seem to be helping me in getting hotness information in these remarks.

It does something (after applying your patch):

./bin/opt -sample-profile -sample-profile-file=../test/Transforms/SampleProfile/Inputs/remarks.prof -S -pass-remarks-output=- -pass-remarks-with-hotness ../test/Transforms/SampleProfile/remarks.ll -o /dev/null | grep Hotness
Hotness: 0
Hotness: 0

but the 0 values are probably wrong. You probably need to study/debug this. The hotness should come from BFI which sample profiler should be updating.

Aug 10 2017, 9:20 AM

Aug 9 2017

anemet added a comment to D36127: [OptDiag] Updating Remarks in SampleProfile.

-pass-remarks-with-hotness doesn't seem to be helping me in getting hotness information in these remarks.

Aug 9 2017, 9:02 PM

Aug 8 2017

anemet added inline comments to D36054: Emit only A Single Opt Remark When Inlining.
Aug 8 2017, 3:50 PM

Aug 7 2017

anemet added inline comments to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.
Aug 7 2017, 10:11 PM
anemet added a reviewer for D36127: [OptDiag] Updating Remarks in SampleProfile: davidxl.

Thanks very much for working on this! Please assign https://bugs.llvm.org/show_bug.cgi?id=33794 to you. Also check out my note in the bug.

Aug 7 2017, 11:39 AM

Jul 30 2017

anemet added a reviewer for D36054: Emit only A Single Opt Remark When Inlining: davidxl.
Jul 30 2017, 10:19 PM

Jul 29 2017

anemet accepted D35981: Migrate PGOMemOptSizeOpt to use new OptimizationRemarkEmitter Pass.

LGTM, I suppose there is already a -pass-remark test for this. Of course it would be great to also have a YAML test.

Jul 29 2017, 9:00 AM

Jul 27 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

I only have high-level comments at this point because I don't think we're quite on the same page yet.

Jul 27 2017, 2:43 PM
anemet committed rL309297: Relax the matching in these tests.
Relax the matching in these tests
Jul 27 2017, 10:45 AM
anemet committed rL309294: [ICP] Migrate to OptimizationRemarkEmitter.
[ICP] Migrate to OptimizationRemarkEmitter
Jul 27 2017, 9:55 AM
anemet closed D35929: [ICP] Migrate to OptimizationRemarkEmitter by committing rL309294: [ICP] Migrate to OptimizationRemarkEmitter.
Jul 27 2017, 9:54 AM
anemet committed rL309293: [OptRemark] Allow streaming of 64-bit integers.
[OptRemark] Allow streaming of 64-bit integers
Jul 27 2017, 9:54 AM

Jul 26 2017

anemet created D35929: [ICP] Migrate to OptimizationRemarkEmitter.
Jul 26 2017, 10:22 PM
anemet committed rL309158: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter.
Migrate SimplifyLibCalls to new OptimizationRemarkEmitter
Jul 26 2017, 12:04 PM
anemet closed D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter by committing rL309158: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter.
Jul 26 2017, 12:03 PM
anemet added a comment to D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter.

@anemet I don't have commit privileges, and apparently something is broken with -pass-remarks-output=... (when used with -passes=...) in that -pass-remarks-output=- works when i test it at the command line (ie the yaml is printed to stdout), but if i give it a filename, then it doesn't actually leave a file with that name behind. It seems out-of-scope of this commit to trace that issue.

Jul 26 2017, 11:00 AM

Jul 25 2017

anemet accepted D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter.

Really minor nit below. No need to upload the patch after this change, just go ahead and land it.

Jul 25 2017, 10:31 PM
anemet accepted D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter.

LGTM with a minor request. Thanks!

Jul 25 2017, 10:11 PM

Jul 19 2017

anemet added a comment to D35534: [opt-viewer] Reduce memory consumption.

Also with https://reviews.llvm.org/rL308537, opt-stats now prints a metric for memory consumption if you have guppy (a.k.a. heapy) installed. The metric is the total memory allocated divided by the number of remarks -- average in-memory remark size (~3KB currently). This is printed once all the remarks are loaded.

Jul 19 2017, 3:17 PM
anemet committed rL308538: [opt-viewer] Reduce memory consumption by another 20-25%.
[opt-viewer] Reduce memory consumption by another 20-25%
Jul 19 2017, 3:07 PM
anemet closed D35611: [opt-viewer] Reduce memory consumption by another 20-25% by committing rL308538: [opt-viewer] Reduce memory consumption by another 20-25%.
Jul 19 2017, 3:07 PM
anemet committed rL308537: [opt-viewer] Print allocated memory per remark in opt-stats.py.
[opt-viewer] Print allocated memory per remark in opt-stats.py
Jul 19 2017, 3:07 PM
anemet committed rL308536: [opt-viewer] Reduce memory consumption.
[opt-viewer] Reduce memory consumption
Jul 19 2017, 3:07 PM
anemet closed D35534: [opt-viewer] Reduce memory consumption by committing rL308536: [opt-viewer] Reduce memory consumption.
Jul 19 2017, 3:07 PM
anemet accepted D35645: [PEI] Add basic opt-remarks support.

I am not really familiar with MIR test files but this looks straight-forward. LGTM.

Jul 19 2017, 2:51 PM
anemet added a comment to D35645: [PEI] Add basic opt-remarks support.

Looks good, how hard would be to add a test for this?

Jul 19 2017, 2:16 PM
anemet accepted D35570: [ORE] Port TailRecursionElimination to the new API.

LGTM once we clear the question below. Thanks!

Jul 19 2017, 2:06 PM
anemet updated the diff for D35611: [opt-viewer] Reduce memory consumption by another 20-25%.

Before writing out the difference YAML file in opt-diff, we need to recover
the YAML-friendly data structure for the remarks.

Jul 19 2017, 10:15 AM
anemet added a comment to D35608: Migrate SimplifyLibCalls to new OptimizationRemarkEmitter.

I have no further comment beyond Florian's and Davide's comments. Thanks for working on this!

Jul 19 2017, 9:24 AM

Jul 18 2017

anemet created D35611: [opt-viewer] Reduce memory consumption by another 20-25%.
Jul 18 2017, 11:25 PM
anemet updated subscribers of D35606: Move TailRecursionElimination to new OptimizationRemarkEmitter API.

Bummer, looks like you and @davide both worked on the same pass: D35570 and came up with very similar patches. @davide did you make progress since the last rev?

Jul 18 2017, 9:15 PM
anemet added a comment to D35570: [ORE] Port TailRecursionElimination to the new API.

Yep, looks good.

Jul 18 2017, 10:07 AM
anemet added a reviewer for D35534: [opt-viewer] Reduce memory consumption: davidxl.

Forgot David Li from the original list.

Jul 18 2017, 9:59 AM
anemet created D35534: [opt-viewer] Reduce memory consumption.
Jul 18 2017, 1:01 AM