anemet (Adam Nemet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2014, 12:07 PM (177 w, 2 d)

Recent Activity

Wed, Dec 6

anemet committed rL319979: [LV] Interleaved access vectorization: fix computing new alias info.
[LV] Interleaved access vectorization: fix computing new alias info
Wed, Dec 6, 2:43 PM
anemet closed D40617: [LV] Interleaved access vectorization: fix computing new alias info by committing rL319979: [LV] Interleaved access vectorization: fix computing new alias info.
Wed, Dec 6, 2:43 PM
anemet added inline comments to D40617: [LV] Interleaved access vectorization: fix computing new alias info.
Wed, Dec 6, 1:10 PM
anemet added a comment to D40617: [LV] Interleaved access vectorization: fix computing new alias info.

@hfinkel, @mkuper, could you guys look at this please. We are experiencing a serious miscompile due to this bug. Thanks!

Wed, Dec 6, 8:59 AM
anemet committed rL319902: [opt-viewer] Suppress noisy Swift remarks.
[opt-viewer] Suppress noisy Swift remarks
Wed, Dec 6, 8:51 AM

Fri, Dec 1

anemet committed rL319581: [opt-remarks] If hotness threshold is set, ignore remarks without hotness.
[opt-remarks] If hotness threshold is set, ignore remarks without hotness
Fri, Dec 1, 12:42 PM
anemet added a comment to D34082: [Frontend] 'Show hotness' can be used with a sampling profile.

Sorted these out in rL319576, rL319577 and rL319578.

Fri, Dec 1, 12:03 PM
anemet committed rC319578: Fix the second part of the broken comment from r306079.
Fix the second part of the broken comment from r306079
Fri, Dec 1, 12:00 PM
anemet committed rC319577: Fix opt-remark with hotness testcase for sample-based PGO.
Fix opt-remark with hotness testcase for sample-based PGO
Fri, Dec 1, 12:00 PM
anemet committed rC319576: Partially fix comment in test broken in r306079 and r306948.
Partially fix comment in test broken in r306079 and r306948
Fri, Dec 1, 12:00 PM
anemet committed rL319578: Fix the second part of the broken comment from r306079.
Fix the second part of the broken comment from r306079
Fri, Dec 1, 12:00 PM
anemet committed rL319577: Fix opt-remark with hotness testcase for sample-based PGO.
Fix opt-remark with hotness testcase for sample-based PGO
Fri, Dec 1, 12:00 PM
anemet committed rL319576: Partially fix comment in test broken in r306079 and r306948.
Partially fix comment in test broken in r306079 and r306948
Fri, Dec 1, 12:00 PM
anemet added a comment to D34082: [Frontend] 'Show hotness' can be used with a sampling profile.

Looks like it's a test problem. When I tweak the sample profile file according to https://clang.llvm.org/docs/UsersManual.html#sample-profile-text-format, I do get hotness on the remarks.

Fri, Dec 1, 11:11 AM
anemet updated subscribers of D34082: [Frontend] 'Show hotness' can be used with a sampling profile.

@modocache, @davide, are you guys sure this feature is working? The test does not actually check whether hotness is included in the remarks and when I run it manually they are missing. In D40678, I am filtering out remarks with no hotness when any threshold is set all the remarks are filtered out in this new test.

Fri, Dec 1, 10:31 AM
anemet committed rL319562: Revert "[opt-remarks] If hotness threshold is set, ignore remarks without….
Revert "[opt-remarks] If hotness threshold is set, ignore remarks without…
Fri, Dec 1, 10:13 AM
anemet committed rL319556: [opt-remarks] If hotness threshold is set, ignore remarks without hotness.
[opt-remarks] If hotness threshold is set, ignore remarks without hotness
Fri, Dec 1, 9:02 AM
anemet closed D40678: [opt-remarks] If hotness threshold is set, ignore remarks without hotness by committing rL319556: [opt-remarks] If hotness threshold is set, ignore remarks without hotness.
Fri, Dec 1, 9:02 AM
anemet added a comment to D40678: [opt-remarks] If hotness threshold is set, ignore remarks without hotness.

Thanks, @davide!

Fri, Dec 1, 8:42 AM

Thu, Nov 30

anemet committed rL319511: [cmake] Expose opt-viewer availability.
[cmake] Expose opt-viewer availability
Thu, Nov 30, 5:45 PM
anemet created D40678: [opt-remarks] If hotness threshold is set, ignore remarks without hotness.
Thu, Nov 30, 2:27 PM

Wed, Nov 29

anemet created D40617: [LV] Interleaved access vectorization: fix computing new alias info.
Wed, Nov 29, 11:10 AM
anemet committed rL319324: Add opt-viewer testing.
Add opt-viewer testing
Wed, Nov 29, 9:08 AM

Tue, Nov 28

anemet committed rL319262: Revert "Add opt-viewer testing".
Revert "Add opt-viewer testing"
Tue, Nov 28, 4:11 PM
anemet committed rL319242: Remove this test.
Remove this test
Tue, Nov 28, 2:40 PM
anemet committed rL319235: Demote this opt remark to DEBUG..
Demote this opt remark to DEBUG.
Tue, Nov 28, 2:11 PM
anemet added inline comments to D38722: Added Remarks for Loop Versioning LICM Pass.
Tue, Nov 28, 11:10 AM
anemet committed rL319188: Add opt-viewer testing.
Add opt-viewer testing
Tue, Nov 28, 9:27 AM

Mon, Nov 27

anemet committed rL319146: Revert "Add opt-viewer testing".
Revert "Add opt-viewer testing"
Mon, Nov 27, 10:23 PM
anemet committed rL319073: Add opt-viewer testing.
Add opt-viewer testing
Mon, Nov 27, 11:00 AM
anemet committed rL319072: [opt-viewer] Fix option name.
[opt-viewer] Fix option name
Mon, Nov 27, 11:00 AM
anemet closed D40202: Add opt-viewer testing by committing rL319073: Add opt-viewer testing.
Mon, Nov 27, 11:00 AM
anemet updated the diff for D40202: Add opt-viewer testing.

Thanks, Chris! This moves the cmake bits to config-ix.cmake.

Mon, Nov 27, 10:03 AM

Fri, Nov 17

anemet created D40202: Add opt-viewer testing.
Fri, Nov 17, 5:22 PM

Wed, Nov 15

anemet committed rL318307: [SLP] Added more missed optimization remarks.
[SLP] Added more missed optimization remarks
Wed, Nov 15, 9:06 AM
anemet closed D38367: [SLP] Added more missed optimiazation remarks by committing rL318307: [SLP] Added more missed optimization remarks.
Wed, Nov 15, 9:05 AM

Tue, Nov 14

anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

I get two failures, can you please take a look?

Tue, Nov 14, 3:31 PM
anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

Thanks for your time, anemet. I've just fixed these issues you told.
Can you please commit this patch? I haven't got r+w access.

Sure, will do after lunch.

This does not apply cleanly for me. There are 4 rejects in SLPVectorizer.cpp. Can you please rebase the patch?

Tue, Nov 14, 3:18 PM
anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

Thanks for your time, anemet. I've just fixed these issues you told.
Can you please commit this patch? I haven't got r+w access.

Sure, will do after lunch.

Tue, Nov 14, 1:14 PM
anemet committed rL318170: Adjust test after r318159.
Adjust test after r318159
Tue, Nov 14, 11:03 AM
anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

Thanks for your time, anemet. I've just fixed these issues you told.
Can you please commit this patch? I haven't got r+w access.

Tue, Nov 14, 11:03 AM
anemet accepted D38367: [SLP] Added more missed optimiazation remarks.

This looks great with some minor nits (go ahead and commit after fixing them). Thanks for your work! And sorry about the delay.

Tue, Nov 14, 10:19 AM
anemet committed rL318160: Adjust test after r318159.
Adjust test after r318159
Tue, Nov 14, 9:12 AM
anemet committed rL318159: [llvm-profdata] Report if profile data file is IR- or FE-level.
[llvm-profdata] Report if profile data file is IR- or FE-level
Tue, Nov 14, 8:59 AM
anemet closed D39997: [llvm-profdata] Report if profile data file is IR- or FE-level by committing rL318159: [llvm-profdata] Report if profile data file is IR- or FE-level.
Tue, Nov 14, 8:59 AM

Mon, Nov 13

anemet created D39997: [llvm-profdata] Report if profile data file is IR- or FE-level.
Mon, Nov 13, 9:49 PM
anemet committed rL318136: [opt-viewer] Truncate long remark text in source view.
[opt-viewer] Truncate long remark text in source view
Mon, Nov 13, 8:49 PM
anemet committed rL318135: [opt-viewer] With hotness only show max 1000 entries on the index page.
[opt-viewer] With hotness only show max 1000 entries on the index page
Mon, Nov 13, 8:39 PM

Nov 6 2017

anemet abandoned D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.

This was committed a while ago.

Nov 6 2017, 2:19 PM

Nov 3 2017

anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

Also by any chance, did you run this on some real code base? Some of these may trigger quite a bit and I want to make sure they are not on the top of the list. You can use opt-viewer/opt-stats.py to get a sense how frequently your remark is generated.

Yep, I did, it did not produced much noise on our applications.
I've just compiled ~100 random files from LLVM, opt-stats.py says only slp-vectorizer/InequableTypes is in top 10 remarks with 3% of all remarks (that is ~2000 out of 68000). I suppose it's okay.

Nov 3 2017, 12:24 PM
anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

Also by any chance, did you run this on some real code base? Some of these may trigger quite a bit and I want to make sure they are not on the top of the list. You can use opt-viewer/opt-stats.py to get a sense how frequently your remark is generated.

Nov 3 2017, 9:49 AM
anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

I will look at the rest of the patch in more detail later unless Florian beats me to it. Thanks for tackling this!

Nov 3 2017, 9:45 AM
anemet added a comment to D38367: [SLP] Added more missed optimiazation remarks.

Please use the new closure API to emit remarks.

Nov 3 2017, 8:55 AM

Oct 13 2017

anemet added a comment to D38886: Try to avoid prefetches from disrupting folding of loads..

It's unintuitive why you need to fix this at the IR level. Both the load and the prefetch should be uses of address and there should be no dependence between them.

Oct 13 2017, 10:37 AM

Oct 12 2017

anemet committed rL315643: Handle/assert on DK_Remark.
Handle/assert on DK_Remark
Oct 12 2017, 4:57 PM
anemet committed rL315642: Add DK_Remark to SMDiagnostic.
Add DK_Remark to SMDiagnostic
Oct 12 2017, 4:56 PM
anemet closed D38865: Add DK_Remark to SMDiagnostic by committing rL315642: Add DK_Remark to SMDiagnostic.
Oct 12 2017, 4:56 PM
anemet added a comment to D38865: Add DK_Remark to SMDiagnostic.

Seems reasonable to me. I don't know anything about the MIR parser's use of diagnostics, though.

Oct 12 2017, 4:54 PM
anemet created D38865: Add DK_Remark to SMDiagnostic.
Oct 12 2017, 4:48 PM

Oct 11 2017

anemet added inline comments to D38768: Add remarks describing when a pass changes the IR instruction count of a module.
Oct 11 2017, 11:52 AM
anemet updated subscribers of D38722: Added Remarks for Loop Versioning LICM Pass.
Oct 11 2017, 8:58 AM

Oct 10 2017

anemet accepted D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.

LGTM. Thanks!

Oct 10 2017, 8:46 PM
anemet added a comment to D38722: Added Remarks for Loop Versioning LICM Pass.

Thanks for working on this!

Oct 10 2017, 9:05 AM
anemet accepted D38289: [opt-viewer] Don't Decode HTML bytes for Python 2.

Sorry about the delay! I remembered something similar also for Python2 so I wanted to doublecheck. Turns out that was https://reviews.llvm.org/D29802 which is unrelated.

Oct 10 2017, 9:00 AM

Oct 9 2017

anemet committed rL315253: Rename OptimizationDiagnosticInfo.h to OptimizationRemarkEmitter.h.
Rename OptimizationDiagnosticInfo.h to OptimizationRemarkEmitter.h
Oct 9 2017, 4:49 PM
anemet committed rL315249: Rename OptimizationDiagnosticInfo.* to OptimizationRemarkEmitter.*.
Rename OptimizationDiagnosticInfo.* to OptimizationRemarkEmitter.*
Oct 9 2017, 4:19 PM
anemet committed rL315230: Point to bugzilla for opt-remark projects..
Point to bugzilla for opt-remark projects.
Oct 9 2017, 12:02 PM
anemet added a comment to D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.

One more idea for improvement and then this is ready to go.

Oct 9 2017, 8:54 AM

Oct 4 2017

anemet committed rL314909: [OptRemark] Move YAML writing to IR.
[OptRemark] Move YAML writing to IR
Oct 4 2017, 8:20 AM
anemet committed rL314908: Also update MachineORE after r314874..
Also update MachineORE after r314874.
Oct 4 2017, 8:20 AM

Oct 3 2017

anemet committed rL314874: Move verbosity check for remarks to the diag handler.
Move verbosity check for remarks to the diag handler
Oct 3 2017, 9:28 PM
anemet committed rL314873: Move verbosity check for opt remarks to the diag handler..
Move verbosity check for opt remarks to the diag handler.
Oct 3 2017, 9:27 PM
anemet added a comment to D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.

Also remember to add llvm-commit/cfe-commit when you create the review.

Oct 3 2017, 6:06 PM
anemet added inline comments to D38285: Convert OptimizationRemarkEmitter old emit() calls to new closure parameterized emit() calls.
Oct 3 2017, 6:05 PM

Sep 29 2017

anemet committed rL314537: Display relative hotness with two decimal digits after the decimal point.
Display relative hotness with two decimal digits after the decimal point
Sep 29 2017, 9:58 AM

Sep 28 2017

anemet committed rL314491: Make find_opt_files vararg.
Make find_opt_files vararg
Sep 28 2017, 10:22 PM
anemet added a comment to D38345: [SLP] Added more missed optimiazation remarks.

Thanks for your patch! Please include the full context for the diff and add llvm-commits as subscriber; that should be done when creating the review, otherwise the mailing list does not get the complete picture. See http://llvm.org/docs/Phabricator.html for more details.

Sep 28 2017, 9:04 AM

Sep 19 2017

anemet committed rL313693: Add override for ClangDiagnosticHandler::isAnyRemarkEnabled().
Add override for ClangDiagnosticHandler::isAnyRemarkEnabled()
Sep 19 2017, 4:04 PM
anemet committed rL313691: Allow ORE.emit to take a closure to delay building the remark object.
Allow ORE.emit to take a closure to delay building the remark object
Sep 19 2017, 4:02 PM
anemet committed rL313653: Fix ClangDiagnosticHandler::is*RemarkEnabled members.
Fix ClangDiagnosticHandler::is*RemarkEnabled members
Sep 19 2017, 11:01 AM

Sep 15 2017

anemet updated the diff for D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.

Add comment

Sep 15 2017, 2:18 PM
anemet updated the diff for D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.

Implement DiagHandler::isAnyRemarkEnabled(void)

Sep 15 2017, 1:57 PM
anemet committed rL313383: Improve comment.
Improve comment
Sep 15 2017, 12:39 PM
anemet created D37921: Proof of Concept: Allow ORE.emit to take a closure to delay building the remark object.
Sep 15 2017, 12:33 PM

Sep 13 2017

anemet accepted D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

LGTM.

Sep 13 2017, 4:14 PM
anemet accepted D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Still looks good.

Sep 13 2017, 4:12 PM

Sep 12 2017

anemet added a comment to D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Why? That was inside BackendConsumer.

I was getting incomplete type error.

Sep 12 2017, 5:17 PM

Sep 11 2017

anemet added inline comments to D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.
Sep 11 2017, 9:50 PM
anemet accepted D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

LGTM with the nits below. Thanks!

Sep 11 2017, 9:10 PM

Sep 8 2017

anemet added a comment to D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Please clean this up as well (don't have commented-out lines) so that it's ready to go with the LLVM patch.

Sep 8 2017, 10:21 AM
anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Only minor things at this point. This is very close now.

Sep 8 2017, 10:08 AM

Sep 5 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

Not really. The test is actually GVN: test/Transforms/GVN/opt-remarks.ll. I just made some improvements in

Sep 5 2017, 11:05 AM
anemet committed rL312544: Split opt-remark YAML and opt output testing on this test.
Split opt-remark YAML and opt output testing on this test
Sep 5 2017, 11:05 AM
anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

You also need to add a test. You should be able to extend either the LICM's or the Vectorizer's test to also get the remarks due to allowExtraAnalysis with -pass-remarks not just with -pass-remarks-output.

If I understand this correctly then we need to remove -pass-remarks-output from all test which uses it just to return allowExtraAnalysis() true right? Also I think these kind of test uses llc .

Sep 5 2017, 11:00 AM

Sep 1 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

You also need to add a test. You should be able to extend either the LICM's or the Vectorizer's test to also get the remarks due to allowExtraAnalysis with -pass-remarks not just with -pass-remarks-output.

Sep 1 2017, 11:50 PM
anemet updated subscribers of D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.
Sep 1 2017, 11:25 PM

Aug 30 2017

anemet accepted D37085: [MachineOutliner] Add missed optimization remarks based off outliner cost model.

LGTM.

Aug 30 2017, 3:42 PM

Aug 29 2017

anemet added a comment to D37085: [MachineOutliner] Add missed optimization remarks based off outliner cost model.

Nice improvements.

Aug 29 2017, 3:02 PM

Aug 28 2017

anemet added a comment to D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled.

This is getting close so besides the comments below, please also start cleaning up the patch so that the diff is as tight as possible. Thanks!

Aug 28 2017, 11:37 PM
anemet committed rL311948: Remove an unnecessary const_cast..
Remove an unnecessary const_cast.
Aug 28 2017, 4:01 PM