- User Since
- Jul 21 2014, 12:07 PM (177 w, 2 d)
Wed, Dec 6
Fri, Dec 1
Looks like it's a test problem. When I tweak the sample profile file according to https://clang.llvm.org/docs/UsersManual.html#sample-profile-text-format, I do get hotness on the remarks.
@modocache, @davide, are you guys sure this feature is working? The test does not actually check whether hotness is included in the remarks and when I run it manually they are missing. In D40678, I am filtering out remarks with no hotness when any threshold is set all the remarks are filtered out in this new test.
Thu, Nov 30
Wed, Nov 29
Tue, Nov 28
Mon, Nov 27
Thanks, Chris! This moves the cmake bits to config-ix.cmake.
Fri, Nov 17
Wed, Nov 15
Tue, Nov 14
I get two failures, can you please take a look?
This looks great with some minor nits (go ahead and commit after fixing them). Thanks for your work! And sorry about the delay.
Mon, Nov 13
Nov 6 2017
This was committed a while ago.
Nov 3 2017
Also by any chance, did you run this on some real code base? Some of these may trigger quite a bit and I want to make sure they are not on the top of the list. You can use opt-viewer/opt-stats.py to get a sense how frequently your remark is generated.
I will look at the rest of the patch in more detail later unless Florian beats me to it. Thanks for tackling this!
Please use the new closure API to emit remarks.
Oct 13 2017
It's unintuitive why you need to fix this at the IR level. Both the load and the prefetch should be uses of address and there should be no dependence between them.
Oct 12 2017
Seems reasonable to me. I don't know anything about the MIR parser's use of diagnostics, though.
Oct 11 2017
Oct 10 2017
Thanks for working on this!
Sorry about the delay! I remembered something similar also for Python2 so I wanted to doublecheck. Turns out that was https://reviews.llvm.org/D29802 which is unrelated.
Oct 9 2017
One more idea for improvement and then this is ready to go.
Oct 4 2017
Oct 3 2017
Also remember to add llvm-commit/cfe-commit when you create the review.
Sep 29 2017
Sep 28 2017
Sep 19 2017
Sep 15 2017
Sep 13 2017
Still looks good.
Sep 12 2017
Sep 11 2017
LGTM with the nits below. Thanks!
Sep 8 2017
Please clean this up as well (don't have commented-out lines) so that it's ready to go with the LLVM patch.
Only minor things at this point. This is very close now.
Sep 5 2017
Sep 1 2017
You also need to add a test. You should be able to extend either the LICM's or the Vectorizer's test to also get the remarks due to allowExtraAnalysis with -pass-remarks not just with -pass-remarks-output.
Aug 30 2017
Aug 29 2017
Aug 28 2017
This is getting close so besides the comments below, please also start cleaning up the patch so that the diff is as tight as possible. Thanks!