Page MenuHomePhabricator

anemet (Adam Nemet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2014, 12:07 PM (321 w, 6 d)

Recent Activity

Aug 14 2020

anemet added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

@hnrklssn hi, are you panning to get back to this at some point?

Yes, sorry about the delay!
Currently finishing the last bits of the thesis that this work is part of has taken priority, which doesn't leave too much time since I'm now also working full time.
After that's done though I intend to come back and do the cleanup necessary to upstream as much of the work as possible. It's all related to improving optimisation remarks in one way or another. :)

Oh cool, are you planning to publish/publicize this work once it's done?

Yup, it will be published in LUP Student Papers afaict! I can send you a rough draft if you're interested. Most of the final content is in place already, but it's a bit rough around the edges.

Aug 14 2020, 2:38 PM · Restricted Project
anemet added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

@hnrklssn hi, are you panning to get back to this at some point?

Yes, sorry about the delay!
Currently finishing the last bits of the thesis that this work is part of has taken priority, which doesn't leave too much time since I'm now also working full time.
After that's done though I intend to come back and do the cleanup necessary to upstream as much of the work as possible. It's all related to improving optimisation remarks in one way or another. :)

Aug 14 2020, 11:21 AM · Restricted Project
anemet added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

@hnrklssn hi, are you panning to get back to this at some point?

Aug 14 2020, 10:20 AM · Restricted Project

Jul 29 2020

anemet accepted D84608: [LAA] Avoid adding pointers to the checks if they are not needed..

Looks reasonable to me.

Jul 29 2020, 2:40 PM · Restricted Project

Jul 20 2020

anemet accepted D81308: [Matrix] Use TileInfo to create tiled loop nest for matrix multiply..

LGTM.

Jul 20 2020, 9:54 AM · Restricted Project
anemet accepted D77550: [Matrix] Add TileInfo abstraction for tiled matrix code-gen..

BTW, will this be shared between .cpp's? I.e. what is the justification for a header?

I guess they could in theory also be added directly to LowerMatrixIntrinsics.cpp. But I think it makes sense to have a separate file for various matrix-related utilities that are not directly tied to the intrinsics. I don't anticipate users outside of LowerMatrixIntrinsics.cpp anytime soon upstream, so I could also move them there. I think in the long-term we want to specify specialized, target-specific lowerings outside of LowerMatrixIntrinsics.cpp, so we might as well start with more generally accessible helpers.

Jul 20 2020, 9:47 AM · Restricted Project

Jul 17 2020

anemet accepted D76867: [Matrix] Add minimal lowering pass that only requires TTI..

Is this used anywhere in the patch? If not please explain the plan in the description.

I've updated the O0 case to use it (just committed that today). D76858 will use it in the backend pipeline. I think the description should already mention that the intention is to use it in the backend pipeline, without having to compute DT/AA there. Should I add more details?

Jul 17 2020, 1:36 PM · Restricted Project

Jul 15 2020

anemet added a comment to D76867: [Matrix] Add minimal lowering pass that only requires TTI..

Is this used anywhere in the patch? If not please explain the plan in the description.

Jul 15 2020, 8:37 PM · Restricted Project

Jul 14 2020

anemet added a comment to D77550: [Matrix] Add TileInfo abstraction for tiled matrix code-gen..

BTW, will this be shared between .cpp's? I.e. what is the justification for a header?

Jul 14 2020, 2:46 PM · Restricted Project

Jul 13 2020

anemet added inline comments to D81308: [Matrix] Use TileInfo to create tiled loop nest for matrix multiply..
Jul 13 2020, 10:33 AM · Restricted Project
anemet requested changes to D77550: [Matrix] Add TileInfo abstraction for tiled matrix code-gen..
Jul 13 2020, 10:11 AM · Restricted Project
anemet added inline comments to D77550: [Matrix] Add TileInfo abstraction for tiled matrix code-gen..
Jul 13 2020, 10:10 AM · Restricted Project

Jul 8 2020

anemet accepted D72770: Add matrix types extension tests ..

LGTM.

Jul 8 2020, 2:32 PM · Restricted Project

Jun 16 2020

anemet accepted D81472: [Matrix] Update load/store intrinsics..

LGTM! @nicolasvasilache can you please OK the MLIR parts if you're happy with them?

Jun 16 2020, 11:00 AM · Restricted Project, Restricted Project

Jun 15 2020

anemet accepted D81498: [Matrix] Preserve volatile when loading loads/stores..

LGTM

Jun 15 2020, 10:23 AM · Restricted Project
anemet added a comment to D81472: [Matrix] Update load/store intrinsics..

Is there a test for passing alignment?

Jun 15 2020, 10:23 AM · Restricted Project, Restricted Project

May 13 2020

anemet added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

Sorry about the delay, just a few small nits on the tests, this is pretty close. Thanks for pushing this!

May 13 2020, 7:07 PM · Restricted Project

Apr 29 2020

anemet updated subscribers of D79097: [GVN] Improve analysis for missed optimization remark.

Thanks for improving this. Can you please add a small test highlighting where your change improve the diagnostics? TIA!

Apr 29 2020, 9:38 AM · Restricted Project

Apr 28 2020

anemet added inline comments to D78458: [LAA] Move CheckingPtrGroup/PointerCheck outside class (NFC)..
Apr 28 2020, 9:38 AM · Restricted Project

Apr 5 2020

anemet accepted D75566: [Matrix] Add initial tiling for load/multiply/store chains..

LGTM!

Apr 5 2020, 2:25 PM · Restricted Project
anemet accepted D76325: [Matrix] Add option to use row-major matrix layout as default..

LGTM!

Apr 5 2020, 1:55 PM · Restricted Project
anemet requested changes to D75566: [Matrix] Add initial tiling for load/multiply/store chains..
Apr 5 2020, 1:53 PM · Restricted Project

Mar 31 2020

anemet accepted D77129: [Verifier] Verify matrix dimensions operands match vector size..

Nice, LGTM!

Mar 31 2020, 9:57 AM · Restricted Project

Mar 29 2020

anemet requested changes to D76325: [Matrix] Add option to use row-major matrix layout as default..
Mar 29 2020, 12:50 PM · Restricted Project
anemet added a comment to D76325: [Matrix] Add option to use row-major matrix layout as default..

TODO: additional tests.

Mar 29 2020, 12:50 PM · Restricted Project
anemet requested changes to D75566: [Matrix] Add initial tiling for load/multiply/store chains..
Mar 29 2020, 12:50 PM · Restricted Project
anemet added a comment to D75566: [Matrix] Add initial tiling for load/multiply/store chains..

Very nice!

Mar 29 2020, 11:45 AM · Restricted Project

Mar 23 2020

anemet added a comment to D75566: [Matrix] Add initial tiling for load/multiply/store chains..

I have a few specific comments below but overall it would be great if we could simplify VisitBBFusion to avoid recursion and invalidating the iterator...

Mar 23 2020, 11:28 AM · Restricted Project

Mar 19 2020

anemet accepted D76324: [Matrix] Generalize ColumnMatrixTy to MatrixTy (NFC)..

LGTM

Mar 19 2020, 10:52 AM · Restricted Project
anemet added a comment to D75566: [Matrix] Add initial tiling for load/multiply/store chains..

Can you please describe the approach in the description/in a comment?

Mar 19 2020, 10:52 AM · Restricted Project
anemet accepted D75565: [Matrix] Move multiply-add code generation into separate function (NFC)..

LGTM, thanks for splitting these up like this!

Mar 19 2020, 10:17 AM · Restricted Project
anemet accepted D75564: [Matrix] Hoist load/store generation logic, add helpers for tiled access..

LGTM

Mar 19 2020, 10:17 AM · Restricted Project

Mar 11 2020

anemet accepted D73600: [Matrix] Add remark propagation along the inlined-at chain..

In the description when you say:

Mar 11 2020, 9:04 AM · Restricted Project

Feb 26 2020

anemet accepted D75161: [ReleaseNotes] Mention new matrix intrinsics..

LGTM

Feb 26 2020, 8:32 AM · Restricted Project

Jan 31 2020

anemet added a comment to D73600: [Matrix] Add remark propagation along the inlined-at chain..

On the description: I would first explain what you do and then how to do, i.e. have "To motivate" and the example before the paragprah "For a given function, we traverse".

Jan 31 2020, 4:44 PM · Restricted Project

Jan 23 2020

anemet accepted D72526: [Matrix] Mark expressions shared between multiple remarks..

LGTM.

Jan 23 2020, 11:55 AM · Restricted Project
anemet accepted D72480: [Matrix] Add info about number of operations to remarks..

LGTM!

Jan 23 2020, 11:51 AM · Restricted Project
anemet accepted D72453: [Matrix] Add optimization remarks for matrix expression..

I think that in the description/commit log you want to say a bit on the motivation, like why it's useful to observe these matrix expression in this form.

Jan 23 2020, 11:41 AM · Restricted Project

Jan 17 2020

anemet accepted D72280: [Matrix] Add IR MatrixBuilder..

LGTM, however it would better if this patch also converted existing code to use this new API.

Jan 17 2020, 5:33 PM · Restricted Project

Jan 8 2020

anemet added a comment to D72425: [OptRemark] RFC: Introduce a message table for OptRemarks.

As Francis mentioned it before it would be good derive the pass name from the remark type (diag::remark_gvn_load_elim -> gvn) . I.e. I would drop the DEBUG_TYPE argument.

Jan 8 2020, 4:42 PM · Restricted Project

Jan 7 2020

anemet accepted D70900: [Matrix] Propagate and use shape information for loads..

LGTM.

Jan 7 2020, 6:21 PM · Restricted Project
anemet accepted D70899: [Matrix] Implement back-propagation of shape information..

LGTM.

Jan 7 2020, 6:19 PM · Restricted Project

Dec 20 2019

anemet accepted D70951: [Matrix] Use fmuladd for matrix.multiply if allowed..

LGTM

Dec 20 2019, 2:08 PM · Restricted Project
anemet accepted D70897: [Matrix] Add forward shape propagation and first shape aware lowerings..

LGTM

Dec 20 2019, 9:29 AM · Restricted Project
anemet added inline comments to D70951: [Matrix] Use fmuladd for matrix.multiply if allowed..
Dec 20 2019, 9:10 AM · Restricted Project

Dec 19 2019

anemet requested changes to D70951: [Matrix] Use fmuladd for matrix.multiply if allowed..
Dec 19 2019, 3:20 PM · Restricted Project
anemet requested changes to D70897: [Matrix] Add forward shape propagation and first shape aware lowerings..
Dec 19 2019, 3:20 PM · Restricted Project
anemet requested changes to D70900: [Matrix] Propagate and use shape information for loads..
Dec 19 2019, 3:20 PM · Restricted Project
anemet accepted D70901: [Matrix] Update shape propagation to iterate until done..

LGTM.

Dec 19 2019, 3:13 PM · Restricted Project
anemet added a comment to D70900: [Matrix] Propagate and use shape information for loads..

I am confused about this patch and the previous one (D70899). Looks like they both introduce VisitLoad. Is this intentional?

Dec 19 2019, 2:49 PM · Restricted Project
anemet accepted D70898: [Matrix] Propagate and use shape info for binary operators..

LGTM!

Dec 19 2019, 2:40 PM · Restricted Project
anemet added a comment to D70897: [Matrix] Add forward shape propagation and first shape aware lowerings..

Also the existing test diffs are hard to read, please explain what's going on there.

I've added comments to break up the check lines

Dec 19 2019, 2:40 PM · Restricted Project
anemet added inline comments to D70951: [Matrix] Use fmuladd for matrix.multiply if allowed..
Dec 19 2019, 2:01 PM · Restricted Project

Dec 17 2019

anemet added a comment to D70951: [Matrix] Use fmuladd for matrix.multiply if allowed..

We should be able to use fmuladd instead of fmul/fadd, as this just
reduces the rounding error between operations.

Dec 17 2019, 8:47 AM · Restricted Project

Dec 12 2019

anemet committed rGca3cce75ba06: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:29 PM
anemet committed rG51578922f596: Revert "[analyzer] Fix test/Analysis/padding_cpp.cpp after merge conflict." (authored by anemet).
Revert "[analyzer] Fix test/Analysis/padding_cpp.cpp after merge conflict."
Dec 12 2019, 12:24 PM
anemet committed rG85395296ef11: Fix up local changes after r349125 (authored by anemet).
Fix up local changes after r349125
Dec 12 2019, 12:23 PM

Dec 9 2019

anemet added inline comments to D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass..
Dec 9 2019, 1:30 PM · Restricted Project

Dec 5 2019

anemet accepted D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass..

LGTM too. You may want to a wait a few days to give other people a chance to comment further.

Dec 5 2019, 12:47 PM · Restricted Project

Dec 3 2019

anemet added a comment to D70897: [Matrix] Add forward shape propagation and first shape aware lowerings..

Also the existing test diffs are hard to read, please explain what's going on there.

Dec 3 2019, 9:30 PM · Restricted Project

Nov 20 2019

anemet added inline comments to D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass..
Nov 20 2019, 7:57 AM · Restricted Project

Oct 29 2019

anemet committed rGc6a5e890b9da: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 3:54 PM
anemet committed rGeb5f331581bf: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 3:53 PM
anemet committed rG39227645c336: Fix incorrect merge conflict resolution (authored by anemet).
Fix incorrect merge conflict resolution
Oct 29 2019, 3:52 PM
anemet committed rGef0f24b95685: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 3:52 PM
anemet committed rG782dc0119505: Handle/assert DK_Remark in SourceMgrAdapter (authored by anemet).
Handle/assert DK_Remark in SourceMgrAdapter
Oct 29 2019, 3:26 PM
anemet committed rG865d7ae3c729: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 2:47 PM
anemet committed rG8f1f78d8ceb7: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 1:08 PM
anemet committed rG2749b939a1e3: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 1:08 PM
anemet committed rGff20f106e44c: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 1:07 PM
anemet committed rG896206ad5d92: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by anemet).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 1:06 PM

Sep 24 2019

anemet accepted D67955: [AArch64] Convert neon_ushl and neon_sshl with positive constants to VSHL..

LGTM

Sep 24 2019, 3:13 PM · Restricted Project
anemet added inline comments to D67955: [AArch64] Convert neon_ushl and neon_sshl with positive constants to VSHL..
Sep 24 2019, 2:53 PM · Restricted Project
anemet added inline comments to D67955: [AArch64] Convert neon_ushl and neon_sshl with positive constants to VSHL..
Sep 24 2019, 2:51 PM · Restricted Project

Sep 20 2019

anemet added a comment to D62308: [AArch64] support neon_sshl and neon_ushl in performIntrinsicCombine..

I'll submit a separate patch for turning ushl -> shl, if the shift is all constant.

Sep 20 2019, 8:23 AM · Restricted Project

Sep 17 2019

anemet accepted D62308: [AArch64] support neon_sshl and neon_ushl in performIntrinsicCombine..

Some minor test questions/suggestions. Feel free to commit after addressing.

Sep 17 2019, 10:21 PM · Restricted Project

Sep 6 2019

anemet added a comment to D62308: [AArch64] support neon_sshl and neon_ushl in performIntrinsicCombine..

Does this also apply to right shifts?

Sep 6 2019, 5:59 PM · Restricted Project

Aug 20 2019

anemet accepted D65983: Autogenerate the shebang lines for tools/opt-viewer.

No, concerns. Looks good to me too.

Aug 20 2019, 4:56 PM · Restricted Project

Apr 18 2019

anemet added inline comments to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.
Apr 18 2019, 6:18 PM · debug-info, Restricted Project

Mar 27 2019

anemet accepted D59895: [opt-viewer] Teach optrecord.py about !Failure tags.

LGTM.

Mar 27 2019, 11:32 AM · Restricted Project
anemet accepted D59894: [opt-viewer] Make filter_=None by default in get_remarks and gather_results.

LGTM, thanks for fixing this!

Mar 27 2019, 11:10 AM · Restricted Project
anemet added inline comments to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.
Mar 27 2019, 10:07 AM · Restricted Project
anemet added a comment to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.

This might be a more general problem, other passes might expect a normalized form as well, such as UnrollAndJam and LoopDistribute.

For LoopVectorizer, I am somewhat surprised. It calls simplifyLoop itself (instead of relying on LoopSimplifyPass). Could the same be done for LoopRotation?

Mar 27 2019, 9:49 AM · Restricted Project
anemet added a comment to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.

This makes sense to me, given that loops with bottom checks are a precondition for LV. I think it would be good to also update the section about llvm.loop.vectorize.enable in LangRef to say it might also enable transformations like LoopRotate, in preparation for LV.

In case LV fails to vectorize the loop, it might be a bit surprising the loop has been rotated. But the way things are structured at the moment, there's nothing we can do about that (we cannot tell in LoopRotate if LV will be able to vectorize). By documenting that behavior, we can push the responsibility for that to the user. Maybe a remark in LoopRotate would be helpful to indicate that we only rotated because of the metadata.

Mar 27 2019, 8:01 AM · Restricted Project

Mar 26 2019

anemet created D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.
Mar 26 2019, 11:47 AM · Restricted Project

Mar 14 2019

anemet accepted D57828: Add geomean summary row to output from utils/compare.py..

Seems reasonable.

Mar 14 2019, 9:29 AM · Restricted Project

Feb 26 2019

anemet added a reviewer for D58632: [X86] Improve lowering of idemptotent RMW operations: jfb.
Feb 26 2019, 1:01 PM · Restricted Project
anemet edited reviewers for D58632: [X86] Improve lowering of idemptotent RMW operations, added: craig.topper; removed: jfb.
Feb 26 2019, 1:01 PM · Restricted Project

Feb 8 2019

anemet accepted D57985: [test-suite] Add cmake option to use IR PGO (TEST_SUITE_USE_IR_PGO).

LGTM

Feb 8 2019, 4:24 PM · Restricted Project

Feb 6 2019

anemet accepted D57827: [opt-viewer] Add --filter option to select remarks for displaying..

LGTM with the comment.

Feb 6 2019, 9:44 AM · Restricted Project

Jan 25 2019

anemet added a comment to D57089: Provide reason messages for unviable inlining.

This is great, please add some tests or check for remarks in existing tests (e.g. for the recursive case).

Jan 25 2019, 9:24 AM · Restricted Project
anemet accepted D57220: Test fix for isViableInline remark message.

LGTM

Jan 25 2019, 9:24 AM · Restricted Project
anemet accepted D57167: [opt-viewer] Add javascript to expand/hide full message for multiline remarks..

Awesome and thanks for the test. LGTM!

Jan 25 2019, 8:10 AM

Jan 24 2019

anemet added a comment to D57167: [opt-viewer] Add javascript to expand/hide full message for multiline remarks..

Can you please describe the user experience?

Jan 24 2019, 1:35 PM
anemet accepted D57159: [DiagnosticInfo] Add support for preserving newlines in remark arguments..

LGTM, thanks!

Jan 24 2019, 9:58 AM
anemet updated subscribers of D57159: [DiagnosticInfo] Add support for preserving newlines in remark arguments..
Jan 24 2019, 9:18 AM

Dec 13 2018

anemet added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Actually this has been failing for 8 hours. So reverted in r349117. Also reverted your attempt to update the test. It wasn't updating the right test: r349118

Dec 13 2018, 4:47 PM
anemet committed rL349118: Revert "Try to update the test to fix the breakage With the new warning, we are….
Revert "Try to update the test to fix the breakage With the new warning, we are…
Dec 13 2018, 4:47 PM
anemet committed rL349117: Revert "Make -Wstring-plus-int warns even if when the result is not out of….
Revert "Make -Wstring-plus-int warns even if when the result is not out of…
Dec 13 2018, 4:46 PM
anemet committed rC349117: Revert "Make -Wstring-plus-int warns even if when the result is not out of….
Revert "Make -Wstring-plus-int warns even if when the result is not out of…
Dec 13 2018, 4:46 PM