Page MenuHomePhabricator

wenlei (Wenlei He)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2019, 5:55 PM (169 w, 6 d)

Recent Activity

Mon, Jun 27

wenlei accepted D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

lgtm, thanks.

Mon, Jun 27, 10:08 PM · Restricted Project, Restricted Project
wenlei accepted D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.

lgtm, thanks.

Mon, Jun 27, 6:11 PM · Restricted Project, Restricted Project
wenlei added a comment to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.

Thanks for the change, and the iterator cleans up quite a bit of duplication. There's one more case left, see inline comment.

Mon, Jun 27, 6:06 PM · Restricted Project, Restricted Project

Thu, Jun 23

wenlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Thu, Jun 23, 5:59 PM · Restricted Project, Restricted Project
wenlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Thu, Jun 23, 5:54 PM · Restricted Project, Restricted Project

Wed, Jun 22

wenlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Wed, Jun 22, 11:24 PM · Restricted Project, Restricted Project
wenlei accepted D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

lgtm, thanks.

Wed, Jun 22, 10:51 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Wed, Jun 22, 10:29 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Wed, Jun 22, 10:09 PM · Restricted Project, Restricted Project
wenlei added a comment to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.

Thanks for the change -- good work. I can see how it improves performance of llvm-profgen. A few minor comments.

Wed, Jun 22, 4:01 PM · Restricted Project, Restricted Project

Fri, Jun 10

wenlei added inline comments to D121651: [llvm-profdata] Convert nested profile to CS flat profile..
Fri, Jun 10, 3:29 PM · Restricted Project, Restricted Project

Wed, Jun 8

wenlei added inline comments to D125743: [outliner] Use profile data to avoid outlining hot blocks.
Wed, Jun 8, 12:24 PM · Restricted Project, Restricted Project
wenlei added inline comments to D121651: [llvm-profdata] Convert nested profile to CS flat profile..
Wed, Jun 8, 12:05 PM · Restricted Project, Restricted Project
wenlei accepted D127330: [CSSPGO][Preinliner] Set default value of sample-profile-inline-limit-max to 3000.
Wed, Jun 8, 11:52 AM · Restricted Project, Restricted Project
wenlei accepted D126434: [PseudoProbe] Use callee name as callsite identfier for MCDecodedPseudoProbeInlineTree..

lgtm, thanks

Wed, Jun 8, 10:27 AM · Restricted Project, Restricted Project
wenlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

I think we also need to decide what should always be emitted. Now there's only one warning that is always emitted. I think we can benefit from another always emit warning that can tells us when profile/binary mismatch and/or the issues like the skylake PMU bug happens. Do we get any indicator now for these issues?

Wed, Jun 8, 8:13 AM · Restricted Project, Restricted Project
wenlei added inline comments to D126434: [PseudoProbe] Use callee name as callsite identfier for MCDecodedPseudoProbeInlineTree..
Wed, Jun 8, 12:29 AM · Restricted Project, Restricted Project
wenlei added inline comments to D126827: [llvm-profgen] Fix a loading address bug for pseudo probe profile.
Wed, Jun 8, 12:08 AM · Restricted Project, Restricted Project

Tue, Jun 7

wenlei added a comment to D121862: [ProfSampleLoader] When disable-sample-loader-inlining is true, merge profiles of inlined instances to outlining versions..

The combined size of .text.hot and .text of the AutoFDO executable is 8 times as big as that of the FDO executable (even with the machine function splitting turned off).

Tue, Jun 7, 11:30 PM · Restricted Project, Restricted Project
wenlei added a comment to D121862: [ProfSampleLoader] When disable-sample-loader-inlining is true, merge profiles of inlined instances to outlining versions..

Thanks for sharing your insights @kazu.

Tue, Jun 7, 11:18 PM · Restricted Project, Restricted Project

Mon, Jun 6

wenlei added inline comments to D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie.
Mon, Jun 6, 11:38 PM · Restricted Project, Restricted Project
wenlei added inline comments to D127026: [CSSPGO][llvm-profgen] Reimplement computeSummaryAndThreshold using context trie.
Mon, Jun 6, 4:15 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125246: [CSSPGO][llvm-profgen] Reimplement CS profile generator using context trie.
Mon, Jun 6, 8:39 AM · Restricted Project, Restricted Project

May 25 2022

wenlei updated subscribers of D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable.

+@weiwang

May 25 2022, 9:21 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

wenlei accepted D122609: [llvm-profgen] Update callsite body samples by summing up all call target samples..

lgtm, thanks.

May 12 2022, 11:52 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122609: [llvm-profgen] Update callsite body samples by summing up all call target samples..
May 12 2022, 11:45 PM · Restricted Project, Restricted Project
wenlei accepted D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller..

lgtm except nits.

May 12 2022, 11:17 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122609: [llvm-profgen] Update callsite body samples by summing up all call target samples..
May 12 2022, 5:16 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller..
May 12 2022, 5:03 PM · Restricted Project, Restricted Project
wenlei updated subscribers of D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

there's also an always inline pass (AlwaysInliner.cpp).

May 12 2022, 3:34 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 12 2022, 10:35 AM · Restricted Project, Restricted Project
wenlei accepted D125448: [llvm-profgen] Filter out oversized LBR ranges..

lgtm, thanks.

May 12 2022, 9:35 AM · Restricted Project, Restricted Project

May 11 2022

wenlei added inline comments to D125448: [llvm-profgen] Filter out oversized LBR ranges..
May 11 2022, 11:04 PM · Restricted Project, Restricted Project
wenlei accepted D124796: [CSSPGO][llvm-profgen] Do not duplicate context profiles into base profile when converting CS flat profile to nested..

lgtm, thanks.

May 11 2022, 2:19 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller..
May 11 2022, 11:35 AM · Restricted Project, Restricted Project

May 10 2022

wenlei added a comment to D125266: [CSSPGO][CSProfileConverter] Remove call target samples when including callee samples into caller..

When a flat CS profile is converted to a nested profile, the call target samples for inlined callee contexts are left over in the callsite target map.

May 10 2022, 1:30 PM · Restricted Project, Restricted Project

May 9 2022

wenlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

add a parameter to emitWarningSummary to customize value for critical warning, default value increase to 20%.

Do we even need a threshold for emitting critical ones? If it's critical, we should always emit them?

Sorry for the confusing, " customize value for critical warning" is wrong, I meant the parameter is used to treat warnings of different importance differently. For critical warning, the threshold is 0, then it's always emitted. For non-critical ones, developer can still set a threshold or use the default one, then emit it if it's above it.

May 9 2022, 7:53 PM · Restricted Project, Restricted Project
wenlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

add a parameter to emitWarningSummary to customize value for critical warning, default value increase to 20%.

May 9 2022, 6:15 PM · Restricted Project, Restricted Project
wenlei added a comment to D125255: [llvm-profgen] Support a threshold to control hiding warning summaries.

I'm not sure if a universal threshold for filtering warning is a good way to deal with this. Maybe look at this from a different angle -- for some warnings, any instance is bad, for others, we can tolerate them. Hence, an alternative: for critical ones, we should always print out any non-zero value; for others, print them only under a "verbose" mode?

May 9 2022, 3:45 PM · Restricted Project, Restricted Project
wenlei added a comment to D125249: [Inliner] Preserve !prof metadata when converting call to invoke..

Does the data need to be scaled first?

May 9 2022, 11:47 AM · Restricted Project, Restricted Project

May 6 2022

wenlei accepted D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..

thanks, lgtm assuming performance is still good with the final version.

May 6 2022, 11:01 AM · Restricted Project, Restricted Project
wenlei added inline comments to D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..
May 6 2022, 10:43 AM · Restricted Project, Restricted Project

May 5 2022

wenlei added inline comments to D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..
May 5 2022, 11:58 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..
May 5 2022, 11:14 PM · Restricted Project, Restricted Project
wenlei added inline comments to D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..
May 5 2022, 10:12 PM · Restricted Project, Restricted Project
wenlei updated the summary of D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..
May 5 2022, 3:16 PM · Restricted Project, Restricted Project
wenlei added a comment to D125023: [CSSPGO][Preinliner] Use linear threshold to drive inline decision..

In general, we should include code size and perf numbers for benchmarks for such changes.

May 5 2022, 10:15 AM · Restricted Project, Restricted Project

May 3 2022

wenlei accepted D124788: [CSSPGO][NFC] Replace SampleProfileLoader::ProfileIsCS with FunctionSamples::ProfileIsCS..

lgtm, thanks.

May 3 2022, 6:24 PM · Restricted Project, Restricted Project
wenlei added inline comments to D124788: [CSSPGO][NFC] Replace SampleProfileLoader::ProfileIsCS with FunctionSamples::ProfileIsCS..
May 3 2022, 6:21 PM · Restricted Project, Restricted Project
wenlei accepted D124793: [CSSPGO] Relax size limitation for priority inlining with preinlined profile.

lgtm, thanks.

May 3 2022, 6:15 PM · Restricted Project, Restricted Project

Apr 28 2022

wenlei accepted D124632: [CSSPGO] Turn on priority inlining for probe-only profile.

Let's evaluate ignoring size limit for preinline case; otherwise lgtm, thanks.

Apr 28 2022, 11:40 PM · Restricted Project, Restricted Project
wenlei added inline comments to D124632: [CSSPGO] Turn on priority inlining for probe-only profile.
Apr 28 2022, 11:29 PM · Restricted Project, Restricted Project
wenlei accepted D122602: [CSSPGO] Rename ProfileIsCSNested and ProfileIsCSFlat.
Apr 28 2022, 11:05 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122602: [CSSPGO] Rename ProfileIsCSNested and ProfileIsCSFlat.
Apr 28 2022, 10:01 PM · Restricted Project, Restricted Project
wenlei added inline comments to D124632: [CSSPGO] Turn on priority inlining for probe-only profile.
Apr 28 2022, 9:54 PM · Restricted Project, Restricted Project
wenlei added inline comments to D124632: [CSSPGO] Turn on priority inlining for probe-only profile.
Apr 28 2022, 4:29 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122602: [CSSPGO] Rename ProfileIsCSNested and ProfileIsCSFlat.
Apr 28 2022, 4:26 PM · Restricted Project, Restricted Project
wenlei accepted D118177: [llvm-profgen] Decouple artificial branch from LBR parser and fix external address related issues.

lgtm, thanks.

Apr 28 2022, 3:49 PM · Restricted Project, Restricted Project
wenlei added inline comments to D118177: [llvm-profgen] Decouple artificial branch from LBR parser and fix external address related issues.
Apr 28 2022, 9:55 AM · Restricted Project, Restricted Project

Apr 26 2022

wenlei added inline comments to D118177: [llvm-profgen] Decouple artificial branch from LBR parser and fix external address related issues.
Apr 26 2022, 3:40 PM · Restricted Project, Restricted Project

Apr 20 2022

wenlei updated subscribers of D124121: [DebugInfo] Give warning instead of error for premature terminator in .debug_aranges section..

Looks like this is extending https://reviews.llvm.org/D85313. Makes sense to me, but @dblaikie @jhenderson are probably better reviewers.

Apr 20 2022, 4:38 PM · Restricted Project, Restricted Project
wenlei added a comment to D124121: [DebugInfo] Give warning instead of error for premature terminator in .debug_aranges section..

The description is a bit unclear. llvm-profgen giving an error isn't a reason to make this change. But if the error doesn't make sense in general, that's a reason. That's something worth explaining.

Apr 20 2022, 2:31 PM · Restricted Project, Restricted Project

Apr 18 2022

wenlei updated subscribers of D123925: [Pipelines] Hoist CoroEarly as a module pass.

cc @weiwang

Apr 18 2022, 7:29 PM · Restricted Project, Restricted Project
wenlei added inline comments to D123869: [llvm-profgen] Add process filter for perf reader.
Apr 18 2022, 11:03 AM · Restricted Project, Restricted Project
wenlei committed rG526af13ebaa9: Fix llvm-profgen breakage (authored by wenlei).
Fix llvm-profgen breakage
Apr 18 2022, 11:03 AM · Restricted Project, Restricted Project
wenlei committed rG17f6cba30d94: [llvm-profgen] Add process filter for perf reader (authored by wenlei).
[llvm-profgen] Add process filter for perf reader
Apr 18 2022, 9:58 AM · Restricted Project, Restricted Project
wenlei closed D123869: [llvm-profgen] Add process filter for perf reader.
Apr 18 2022, 9:58 AM · Restricted Project, Restricted Project

Apr 17 2022

wenlei updated the diff for D123869: [llvm-profgen] Add process filter for perf reader.

Use Optional<> for PIDFilter

Apr 17 2022, 8:56 PM · Restricted Project, Restricted Project
wenlei added inline comments to D123869: [llvm-profgen] Add process filter for perf reader.
Apr 17 2022, 8:55 PM · Restricted Project, Restricted Project

Apr 16 2022

wenlei added inline comments to D123869: [llvm-profgen] Add process filter for perf reader.
Apr 16 2022, 9:00 PM · Restricted Project, Restricted Project
wenlei added inline comments to D123869: [llvm-profgen] Add process filter for perf reader.
Apr 16 2022, 4:30 PM · Restricted Project, Restricted Project

Apr 15 2022

wenlei added inline comments to D123869: [llvm-profgen] Add process filter for perf reader.
Apr 15 2022, 10:13 PM · Restricted Project, Restricted Project
wenlei requested review of D123869: [llvm-profgen] Add process filter for perf reader.
Apr 15 2022, 12:32 PM · Restricted Project, Restricted Project

Apr 13 2022

wenlei added inline comments to D120073: [LLD] Fix for race condition..
Apr 13 2022, 3:35 PM · Restricted Project, Restricted Project
wenlei added inline comments to D120073: [LLD] Fix for race condition..
Apr 13 2022, 2:21 PM · Restricted Project, Restricted Project

Apr 8 2022

wenlei added inline comments to D123361: [llvm-profgen] Filter out oversized LBR ranges..
Apr 8 2022, 10:31 AM · Restricted Project, Restricted Project

Apr 7 2022

wenlei accepted D123271: [llvm-profgen] Filter out invalid LBR ranges..

lgtm, thanks.

Apr 7 2022, 8:28 PM · Restricted Project, Restricted Project
wenlei added inline comments to D123271: [llvm-profgen] Filter out invalid LBR ranges..
Apr 7 2022, 6:14 PM · Restricted Project, Restricted Project
wenlei added inline comments to D123271: [llvm-profgen] Filter out invalid LBR ranges..
Apr 7 2022, 4:47 PM · Restricted Project, Restricted Project

Apr 6 2022

wenlei added inline comments to D123271: [llvm-profgen] Filter out invalid LBR ranges..
Apr 6 2022, 8:39 PM · Restricted Project, Restricted Project

Mar 31 2022

wenlei accepted D122844: [llvm-profgen] Fixing a context attribure update issue due to a non-derministic processing order on different platforms..
Mar 31 2022, 5:08 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122844: [llvm-profgen] Fixing a context attribure update issue due to a non-derministic processing order on different platforms..
Mar 31 2022, 1:50 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122844: [llvm-profgen] Fixing a context attribure update issue due to a non-derministic processing order on different platforms..
Mar 31 2022, 1:40 PM · Restricted Project, Restricted Project

Mar 29 2022

wenlei accepted D121655: [llvm-profgen] Read sample profiles for post-processing..
Mar 29 2022, 11:44 PM · Restricted Project, Restricted Project
wenlei added inline comments to D121651: [llvm-profdata] Convert nested profile to CS flat profile..
Mar 29 2022, 11:28 PM · Restricted Project, Restricted Project

Mar 28 2022

wenlei added inline comments to D121655: [llvm-profgen] Read sample profiles for post-processing..
Mar 28 2022, 11:32 PM · Restricted Project, Restricted Project

Mar 25 2022

wenlei added inline comments to D121655: [llvm-profgen] Read sample profiles for post-processing..
Mar 25 2022, 3:28 PM · Restricted Project, Restricted Project
wenlei added inline comments to D121655: [llvm-profgen] Read sample profiles for post-processing..
Mar 25 2022, 1:52 PM · Restricted Project, Restricted Project
wenlei accepted D121737: [PseudoProbe] Do not emit pseudo probes when module is not probed..

lgtm, thanks.

Mar 25 2022, 12:47 PM · Restricted Project, Restricted Project

Mar 24 2022

wenlei added a comment to D121651: [llvm-profdata] Convert nested profile to CS flat profile..

Some linter seems legit.

Mar 24 2022, 10:58 PM · Restricted Project, Restricted Project
wenlei added inline comments to D121655: [llvm-profgen] Read sample profiles for post-processing..
Mar 24 2022, 10:26 PM · Restricted Project, Restricted Project
wenlei added inline comments to D121737: [PseudoProbe] Do not emit pseudo probes when module is not probed..
Mar 24 2022, 10:03 PM · Restricted Project, Restricted Project
wenlei accepted D122442: [CSSPGO] Turn on profi and ext-tsp when using probe-based profile..

lgtm, thanks.

Mar 24 2022, 5:35 PM · Restricted Project, Restricted Project
wenlei added inline comments to D122442: [CSSPGO] Turn on profi and ext-tsp when using probe-based profile..
Mar 24 2022, 4:34 PM · Restricted Project, Restricted Project

Mar 23 2022

wenlei committed rG0ca8ff4da1bd: [llvm-profdata] Unify default cutoffs for detailed summary printing (authored by wenlei).
[llvm-profdata] Unify default cutoffs for detailed summary printing
Mar 23 2022, 2:57 PM · Restricted Project
wenlei closed D122210: [llvm-profdata] Unify default cutoffs for detailed summary printing.
Mar 23 2022, 2:57 PM · Restricted Project, Restricted Project
wenlei accepted D121643: [llvm-profgen] Decoding pseudo probe for profiled function only..

Thanks for working through the changes, this looks great now. Please update the summary to reflect the latest version (we can also make it clear that this is not "on-demand" but "decode probes for profiled context only").

Mar 23 2022, 1:49 PM · Restricted Project, Restricted Project
wenlei added inline comments to D121643: [llvm-profgen] Decoding pseudo probe for profiled function only..
Mar 23 2022, 12:23 PM · Restricted Project, Restricted Project
wenlei added a comment to D121737: [PseudoProbe] Do not emit pseudo probes when module is not probed..

It is possible to let users know when this happens? Ideally it's something user need to fix - pass flags consistently.

Mar 23 2022, 11:58 AM · Restricted Project, Restricted Project
wenlei added inline comments to D121655: [llvm-profgen] Read sample profiles for post-processing..
Mar 23 2022, 10:51 AM · Restricted Project, Restricted Project