Page MenuHomePhabricator

wenlei (Wenlei He)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 3 2019, 5:55 PM (93 w, 6 d)

Recent Activity

Today

wenlei updated the diff for D94001: [CSSPGO] Call site prioritized inlining for sample PGO.

Address Wei's feedback. Clean up ICPCallee from InlineCandidate now that we don't check InlineCost before ICP.

Tue, Jan 19, 6:01 PM · Restricted Project
wenlei added inline comments to D94001: [CSSPGO] Call site prioritized inlining for sample PGO.
Tue, Jan 19, 5:59 PM · Restricted Project
wenlei accepted D95009: [llvm-profgen][NFC] Fix the incorrect computation of callsite sample count.

lgtm, thanks!

Tue, Jan 19, 5:35 PM · Restricted Project
wenlei added inline comments to D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it.
Tue, Jan 19, 12:59 PM · Restricted Project, Restricted Project

Yesterday

wenlei added inline comments to D94334: [InlineAdvisor] Allow replay of inline decisions for the CGSCC inliner from optimization remarks.
Mon, Jan 18, 11:34 PM · Restricted Project
wenlei accepted D94435: [SampleFDO] Add the support to split the function profiles with context into separate sections..
Mon, Jan 18, 11:09 PM · Restricted Project
wenlei added inline comments to D94435: [SampleFDO] Add the support to split the function profiles with context into separate sections..
Mon, Jan 18, 8:20 AM · Restricted Project

Thu, Jan 14

wenlei added inline comments to D94435: [SampleFDO] Add the support to split the function profiles with context into separate sections..
Thu, Jan 14, 11:01 PM · Restricted Project

Wed, Jan 13

wenlei accepted D94613: [NFC] Rename ThinLTOPhase to PhaseInAllLTO and move it from PassBuilder.h to Pass.h.

lgtm

Wed, Jan 13, 1:58 PM · Restricted Project
wenlei added a comment to D94613: [NFC] Rename ThinLTOPhase to PhaseInAllLTO and move it from PassBuilder.h to Pass.h.

Thanks for refactoring. We had internal change to add IsFullLTOPreLink alongside with IsThinLTOPreLink for a few places. And we always wanted clean it up too. :)

Wed, Jan 13, 10:12 AM · Restricted Project

Tue, Jan 12

wenlei added a comment to D94435: [SampleFDO] Add the support to split the function profiles with context into separate sections..

Thanks for the change.

Tue, Jan 12, 11:43 PM · Restricted Project
wenlei retitled D94001: [CSSPGO] Call site prioritized inlining for sample PGO from [CSSPGO] Call site prioritized BFS inlining for sample PGO to [CSSPGO] Call site prioritized inlining for sample PGO.
Tue, Jan 12, 11:01 PM · Restricted Project
wenlei updated the diff for D94001: [CSSPGO] Call site prioritized inlining for sample PGO.

retitle, rename inlineCandidate.

Tue, Jan 12, 11:01 PM · Restricted Project
wenlei added a comment to D94001: [CSSPGO] Call site prioritized inlining for sample PGO.
In D94001#2494594, @wmi wrote:

Sorry for the delay in review. It makes a lot of sense to have a priority based inliner for CSSPGO since its profile annotation doesn't rely on replaying the inlining. But I don't understand why we rely on BFS/DFS strategy to expose the hottest callsite for priority based inliner. In my mind, CSSPGO can know the hotness of each callsite with full context information. Can we just sort all the callsites based on CSSPGO profile then try to inline the hottest callsite under a specific context first in a top down manner? We may actually need to inline some parent callsites before we can inline the hottest callsite, but it is all driven by the target to inline the hottest callsite first. If we worry some callsite is too deep and we need to inline through a deep path before we can inline the specific callsite, we may add the depth into priority computation. What do you think?

Tue, Jan 12, 10:58 PM · Restricted Project
wenlei added inline comments to D94334: [InlineAdvisor] Allow replay of inline decisions for the CGSCC inliner from optimization remarks.
Tue, Jan 12, 9:07 PM · Restricted Project
wenlei added inline comments to D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it.
Tue, Jan 12, 9:07 PM · Restricted Project, Restricted Project

Fri, Jan 8

wenlei added inline comments to D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it.
Fri, Jan 8, 2:33 PM · Restricted Project, Restricted Project
wenlei added inline comments to D94334: [InlineAdvisor] Allow replay of inline decisions for the CGSCC inliner from optimization remarks.
Fri, Jan 8, 2:17 PM · Restricted Project

Tue, Jan 5

wenlei added a comment to D94001: [CSSPGO] Call site prioritized inlining for sample PGO.

A few high level questions:

  1. Can the size bloat problem be handled in llvm-profgen time ? Basically using hotness information to prune/merge profiles properly?
Tue, Jan 5, 12:49 PM · Restricted Project

Mon, Jan 4

wenlei added reviewers for D94001: [CSSPGO] Call site prioritized inlining for sample PGO: wmi, davidxl, hoy.
Mon, Jan 4, 10:24 AM · Restricted Project

Sun, Jan 3

wenlei updated the diff for D94001: [CSSPGO] Call site prioritized inlining for sample PGO.

Fix test and linter.

Sun, Jan 3, 11:50 PM · Restricted Project
wenlei updated the summary of D94001: [CSSPGO] Call site prioritized inlining for sample PGO.
Sun, Jan 3, 4:54 PM · Restricted Project
wenlei requested review of D94001: [CSSPGO] Call site prioritized inlining for sample PGO.
Sun, Jan 3, 4:45 PM · Restricted Project

Dec 16 2020

wenlei accepted D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

LBRSample will be added when AutoFDO support is moved into llvm-profgen, right? For AutoFDO, we could use the same infrastructure except that context will always be empty.

Good question, Yes, my initial thought is to decouple this by using separated LBRSample when it comes to AutoFDO, perhaps this's good for readability. I guess your suggestion is for the performance since we won't have virtual call. That's good. If so and we don't have other kinds of perf sample, we might don't need the base class PerfSample and can just name HybridSample to more general name(like PerfSample).

Dec 16 2020, 1:57 PM · Restricted Project
wenlei added a comment to D92584: [CSSPGO][llvm-profgen] Refactor to unify hashable interface for trace sample and context-sensitive counter.

Thanks for the refactoring and clean up, looks great!

Dec 16 2020, 10:10 AM · Restricted Project

Dec 14 2020

wenlei added a comment to D93254: [NFC][SampleFDO] Preparation to support multiple sections with the same type in ExtBinary format..

To reduce the profile loading time during postlink phase when ThinLTO is enabled, we are going to split profile into two parts. One part contains profiles with inline instance and another part contains flattened profiles without inline instance in them.

Dec 14 2020, 9:08 PM · Restricted Project

Dec 7 2020

wenlei accepted D92816: [llvm-profgen][NFC] Fix test failure by making unwinder's output deterministic.

Thanks for quick fix!

Dec 7 2020, 10:15 PM · Restricted Project
wenlei accepted D92621: [SampleFDO] Store fixed length MD5 in NameTable instead of using ULEB128 if MD5 is used..
In D92621#2437658, @wmi wrote:

We find that after this change, the elapsed time to build a large application distributively is reduced by 5% and the accumulative cpu time used for building is also reduced by 5%.

This is great, thanks for the patch! Just to clarify, did you mean 5% of end to end ThinLTO+AutoFDO build? I'm curious what is the total profile reading time your saw in terms of %? and how different that % is between md5 profile vs non-md5 profile? Currently we mostly use non-md5 profile, assuming md5 profile is more about saving profile size.

Yes, it is 5% saving of end to end ThinLTO + AutoFDO build time.

Each module compiling has different % of profile reading time. The percentage is negligible for large source module but can be significant for small source module. I tried it on a very small file.

The build time using md5 profile was 0.55 second. 
The build time using non-md5 profile was 0.75 second. 
The build time using fixlenmd5 profile was 0.15 second. 
The build time not using any profile was 0.1 second.

Because for a large project, many source files are small or medium sizes so the building time for small files matters especially for build cpu resource. It also matters for end-to-end build time but usually not as significant. For the experiment I did (a 20M binary profile), the end-to-end build time saving was about the same as the aggregate build cpu resource saving (both were 5%), but from our experience using larger profile (like 300M profile), it will affect aggregate build cpu resource more than end-to-end build time.

Dec 7 2020, 8:54 PM · Restricted Project

Dec 6 2020

wenlei committed rG6b989a171073: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining (authored by wenlei).
[CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining
Dec 6 2020, 12:12 PM
wenlei closed D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Dec 6 2020, 12:12 PM · Restricted Project
wenlei updated the diff for D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

rebase

Dec 6 2020, 12:00 PM · Restricted Project
wenlei added a comment to D92706: [coroutine] should disable inline before calling coro split.

I believe it's not worth doing just to be able to use one constant string in one place.
If we move them into Attributes.td, we would be adding 3 new attributes to EnumAttr, just to support this, which I think is an overkill.

Dec 6 2020, 11:22 AM · Restricted Project
wenlei added a comment to D92621: [SampleFDO] Store fixed length MD5 in NameTable instead of using ULEB128 if MD5 is used..

We find that after this change, the elapsed time to build a large application distributively is reduced by 5% and the accumulative cpu time used for building is also reduced by 5%.

Dec 6 2020, 6:58 AM · Restricted Project

Dec 3 2020

wenlei accepted D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.

This looks great. Thanks for working on this and making all the changes!

Dec 3 2020, 8:34 PM · Restricted Project

Dec 2 2020

wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Dec 2 2020, 6:53 PM · Restricted Project
wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Dec 2 2020, 1:38 PM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Dec 2 2020, 9:56 AM · Restricted Project
wenlei updated the diff for D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

rebase

Dec 2 2020, 8:53 AM · Restricted Project

Dec 1 2020

wenlei updated the diff for D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

Address Wei's feedback.

Dec 1 2020, 11:40 PM · Restricted Project
wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Dec 1 2020, 11:34 PM · Restricted Project

Nov 20 2020

wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Nov 20 2020, 2:24 PM · Restricted Project
wenlei accepted D89715: [CSSPGO][llvm-profgen] Instruction symbolization.
Nov 20 2020, 10:59 AM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Nov 20 2020, 10:55 AM · Restricted Project
wenlei accepted D89712: [CSSPGO][llvm-profgen] Disassemble text sections.
Nov 20 2020, 10:39 AM · Restricted Project
wenlei added inline comments to D89712: [CSSPGO][llvm-profgen] Disassemble text sections.
Nov 20 2020, 10:19 AM · Restricted Project
wenlei accepted D89707: [CSSPGO][llvm-profgen] Parse mmap events from perf script.

LGTM.

Nov 20 2020, 9:58 AM · Restricted Project
wenlei added a comment to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

Thanks for reviewing and the feedbacks. I think I've addressed all of the current ones. Please take a look, thanks!

Nov 20 2020, 9:53 AM · Restricted Project

Nov 19 2020

wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 19 2020, 2:59 PM · Restricted Project

Nov 18 2020

wenlei updated subscribers of D61540: [PGO] Use sum of count values to fix func entry count and add a check to verify BFI counts.

We record function entry count and branch weights and use them to compute the count when needed. This mechanism works well in a perfect world, but often breaks in real programs

Nov 18 2020, 5:48 PM · Restricted Project

Nov 13 2020

wenlei added a comment to D90507: [Driver] Add DWARF64 flag: -gdwarf64.

This change covers non-LTO cases. For LTO, I think we would need to pass it from driver to LTO. Something like this: tools::addLTOOptions -> lld -> lto::Config (Config->TargetOptions->MCTargetOptions) ->LTO Backend.

Nov 13 2020, 8:21 AM · Restricted Project

Nov 11 2020

wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 11 2020, 3:30 PM · Restricted Project
wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 11 2020, 12:58 PM · Restricted Project
wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 11 2020, 9:08 AM · Restricted Project

Nov 10 2020

wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 10 2020, 6:17 PM · Restricted Project
wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 10 2020, 1:10 PM · Restricted Project

Nov 9 2020

wenlei added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

At least in LLD, it's not quite as simple as being added after the user's code: if a library appears on the link line it will be included in the output order as soon as it is determined it is needed. Thus if you have have three modules 1.o, 2.o, and 3.o, with 3.o in an archive 3.a and 1.o requiring 3.o, you end up with an output order of 1.o 3.o 2.o if the input order was 1.o 3.a 2.o or 3.a 1.o 2.o or an output order of 1.o 2.o 3.o if the input order was 1.o 2.o 3.a. In fact, with use of the --undefined linker switch, you can even force 3.o to appear first.

I accept using --undefined or rearranging the command-line order is less than ideal, but I'm really not convinced LLD should have any place in parsing the DWARF to determine output order. Furthermore, it's not even a reliable solution - if the objects built with DWARF32 (potentially all of which might have come from libraries) are large enough, no amount of reordering will fix the behaviour. I think users who need DWARF64 in their libraries are just going to have to request DWARF64 versions of the libraries, if the --undefined and reordering command line options are insufficient.

I'd guess that for a large-scale project the recommendation to use -u would be unrealistic. We are talking about projects where debugging information in a single section can easily go beyond the 4GiB limit; it is impossible for the developer to adjust the command line manually.

By the way, from a semantic point of view, I don't think it matters if the DWARF is in a different order to the data it represents - I'm just concerned about the maintenance and performance burden of having to parse the DWARF to achieve this reordering.

There is no need to parse the debug info sections. Reading only the first 4 bytes of .debug_info is enough to assess the format (there might be input files with format intermixing, but we can ignore them in the sack of simplicity). And we do not need any automatic sorting if the size of an output section is less than 4GiB.

Exactly. Not to mention, I think for users that actually worry about 4Gig limit they have pretty complex build system that will need to be modified to get build order right. Probably doable, but looking at overall compilation pipeline, is it really the best approach? Within lld we don't have to parse entire debug section, just read few bytes in each CU to determine if it's 32 or 64 bit.
Yes theoretically it is possible that there are just so many third party libraries that they will over flow 4gig by themselves, but I think common case is they will be under 4 gigs.

FWIW, this is probably a big enough discussion to deserve it's own review, probably even it's own llvm-dev thread. My personal take would be: Unless there's a specific user who needs this, probably not worth building it. If you personally have a need or support users who need it, that swings the discussion a fair bit into "what's the best way we can help these users".

Nov 9 2020, 10:38 AM · debug-info, Restricted Project

Nov 5 2020

wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Nov 5 2020, 3:06 PM · Restricted Project

Nov 4 2020

wenlei added inline comments to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Nov 4 2020, 11:47 PM · Restricted Project

Nov 3 2020

wenlei added a comment to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

If CSSPGO has the priority based inliner, does it mean it will do most inliner work and CGSCC inliner will mostly be used as an iterative clean up pass?

Nov 3 2020, 10:03 AM · Restricted Project

Nov 2 2020

wenlei added a comment to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
In D90125#2365948, @wmi wrote:

Another question. Have you ever evaluated the performance by comparing this patch "CSSPGO profile working with existing AFDO pipeline" with the default SPGO? I understand CSSPGO's benefit has not been used without the change of CGSCC inliner. The intention of the comparison is to understand how well existing AFDO pipeline work with CSSPGO profile. It may expose problem in existing SPGO profile or CSSPGO.

Nov 2 2020, 10:44 AM · Restricted Project
wenlei updated the diff for D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

Fix typo and linter, add getCanonicalFnName.

Nov 2 2020, 10:04 AM · Restricted Project
wenlei added a comment to D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

Thanks for quick review! I've update the patch, also see replies inline.

Nov 2 2020, 10:02 AM · Restricted Project
wenlei updated the diff for D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

address feedback from Wei and David

Nov 2 2020, 8:38 AM · Restricted Project

Oct 30 2020

wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 30 2020, 4:42 PM · Restricted Project
wenlei added inline comments to D89715: [CSSPGO][llvm-profgen] Instruction symbolization.
Oct 30 2020, 2:32 PM · Restricted Project
wenlei added a comment to D89712: [CSSPGO][llvm-profgen] Disassemble text sections.

If it's not too much work, I'd suggest squash the refactoring of your later patch (RVA->Offset etc from https://reviews.llvm.org/D89715) into this one. Upstream patch does not have to map 1:1 to internal patch - squashing, minimizing code churn and grouping by functionality helps make it easier for other reviewers. Thanks.

Oct 30 2020, 11:24 AM · Restricted Project
wenlei added inline comments to D89712: [CSSPGO][llvm-profgen] Disassemble text sections.
Oct 30 2020, 11:03 AM · Restricted Project
wenlei added inline comments to D89707: [CSSPGO][llvm-profgen] Parse mmap events from perf script.
Oct 30 2020, 11:00 AM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 30 2020, 12:51 AM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 30 2020, 12:26 AM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 30 2020, 12:10 AM · Restricted Project

Oct 29 2020

wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 29 2020, 5:08 PM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 29 2020, 4:02 PM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 29 2020, 3:21 PM · Restricted Project

Oct 28 2020

wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 28 2020, 12:35 AM · Restricted Project

Oct 25 2020

wenlei updated the diff for D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.

format, separate change in ControlHeightReduction, remove remaining internal markers.

Oct 25 2020, 1:15 PM · Restricted Project
wenlei updated the summary of D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Oct 25 2020, 1:07 PM · Restricted Project
wenlei requested review of D90125: [CSSPGO] Infrastructure for context-sensitive Sample PGO and Inlining.
Oct 25 2020, 1:02 PM · Restricted Project

Oct 23 2020

wenlei accepted D90056: [AutoFDO] Remove a broken assert in merging inlinee samples.

Thanks for tracking down the assertion. The context profile adjustment and merging for AutoFDO today is a best effort approximation. Given the case we ran into, which is hard to handle perfectly and also very rare, removing the assertion makes sense to me.

Oct 23 2020, 10:14 AM · Restricted Project

Oct 21 2020

wenlei accepted D89524: [NFC][SampleFDO] Move some common stuff from SampleProfileReaderExtBinary/SampleProfileWriterExtBinary to their parent classes..

LGTM. Thanks!

Oct 21 2020, 8:20 PM · Restricted Project
wenlei added inline comments to D89723: [CSSPGO][llvm-profgen] Context-sensitive profile data generation.
Oct 21 2020, 11:16 AM · Restricted Project

Oct 20 2020

wenlei added a comment to D89524: [NFC][SampleFDO] Move some common stuff from SampleProfileReaderExtBinary/SampleProfileWriterExtBinary to their parent classes..

Thanks for the context! So the intention is to use subclass to hide extra complexity of uncommon sections/variants and its reader/writer into subclass. Then this refactoring makes sense.

Oct 20 2020, 11:31 PM · Restricted Project

Oct 18 2020

wenlei added a comment to D89524: [NFC][SampleFDO] Move some common stuff from SampleProfileReaderExtBinary/SampleProfileWriterExtBinary to their parent classes..

Thanks for the refactoring. I'm wondering what is most flexible way for us to take advantage of extended binary format. I thought being able to mix and use different section is really flexible, but if we tie non-common section to specific new format/sub class, it may restrict the way we use this format. E.g. if ExtFormatA has SecProfileSymbolList, and ExtFormatB has something like SecFuncMetadata (which is what have for CSSPGO internally), then consider if there's a need for a profile to have both SecProfileSymbolList and SecFuncMetadata - implementing that through inheritance could be a bit cumbersome.

Oct 18 2020, 9:54 AM · Restricted Project

Oct 13 2020

wenlei added a comment to D89341: [X86] Encode global symbol address in small code model.

Would be good to share benchmark/performance numbers you have for this change too. Thanks.

Oct 13 2020, 5:26 PM · Restricted Project

Oct 12 2020

wenlei accepted D89269: [Coroutine] Rename coro-semmetric-transfer.cpp and fix test failure.
Oct 12 2020, 3:11 PM · Restricted Project
wenlei accepted D89066: [Coroutine][Sema] Only tighten the suspend call temp lifetime for final awaiter.

LGTM. I think we can get this in first to address the fall out from https://reviews.llvm.org/D87470, while investigating ASAN failure.

Oct 12 2020, 11:28 AM · Restricted Project

Oct 5 2020

wenlei committed rG89e8a8b223b2: Revert SVML support for sqrt (authored by wenlei).
Revert SVML support for sqrt
Oct 5 2020, 8:19 AM
wenlei closed D88620: Revert SVML support for sqrt.
Oct 5 2020, 8:19 AM · Restricted Project

Sep 20 2020

wenlei added a comment to D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile.

Landed the change on behalf of @wlei.

Sep 20 2020, 5:00 PM · Restricted Project
wenlei committed rGa8b8a9374a3c: [llvm-profdata]Fix llvm-profdata crash on compact binary profile (authored by wlei).
[llvm-profdata]Fix llvm-profdata crash on compact binary profile
Sep 20 2020, 5:00 PM
wenlei closed D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile.
Sep 20 2020, 4:59 PM · Restricted Project

Sep 16 2020

wenlei added inline comments to D87777: [ASAN] Properly deal with musttail calls in ASAN.
Sep 16 2020, 5:53 PM · Restricted Project
wenlei accepted D87777: [ASAN] Properly deal with musttail calls in ASAN.

LGTM except a minor comment.

Sep 16 2020, 5:25 PM · Restricted Project
wenlei accepted D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile.

LGTM. A small nit: the code snippet in the description could be removed as it's indeed in the codebase already. :)

Sep 16 2020, 5:02 PM · Restricted Project

Sep 15 2020

wenlei updated subscribers of D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults.

Just saw this. Thanks @Alina Sbirlea for fixing the tests, much appreciated!

Sep 15 2020, 9:26 PM · Restricted Project, Restricted Project
wenlei added a comment to D87169: SVML support for log10, sqrt.

Committed on behalf of @ayermolo.

Sep 15 2020, 5:44 PM · Restricted Project
wenlei committed rG056534dc2b15: SVML support for log10, sqrt (authored by wenlei).
SVML support for log10, sqrt
Sep 15 2020, 5:41 PM
wenlei closed D87169: SVML support for log10, sqrt.
Sep 15 2020, 5:41 PM · Restricted Project
wenlei added a comment to D87551: [LICM] Make Loop ICM profile aware again.

Committed on behalf of @modimo.

Sep 15 2020, 5:28 PM · Restricted Project
wenlei committed rG2c391a5a14ae: [LICM] Make Loop ICM profile aware again (authored by wenlei).
[LICM] Make Loop ICM profile aware again
Sep 15 2020, 5:26 PM