This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Use `https` instead of `http` in the `LLVM.org` URLs
AbandonedPublic

Authored by sunshaoce on Jun 13 2022, 12:45 PM.

Diff Detail

Event Timeline

sunshaoce created this revision.Jun 13 2022, 12:45 PM
Herald added a reviewer: bollu. · View Herald Transcript
Herald added a reviewer: ldionne. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: MaskRay. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: rafauler. · View Herald Transcript
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
sunshaoce requested review of this revision.Jun 13 2022, 12:46 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript

Could you do this on a per-project basis? More than 1000 files is way to much to sift through.

A couple notes skimming the changes:

  1. If you're going to update URLs, please verify the new URLs are actually valid.
  2. Some of the "URLs" you're updating aren't actually URLs. For example, the xmlns attribute in SVG files must be the exact string written in the standard; changing it could make the file unreadable.
martong removed a subscriber: martong.Jun 13 2022, 11:54 PM
sunshaoce updated this revision to Diff 436738.Jun 14 2022, 4:59 AM

Change to only modify *.llvm.org

sunshaoce retitled this revision from [NFC] Use `https` instead of `http` in the urls to [NFC] Use `https` instead of `http` in the `LLVM.org` URLs.Jun 14 2022, 5:00 AM
JDevlieghere requested changes to this revision.Jun 14 2022, 8:40 AM

+1 on breaking this down per sub-project and creating separate patches for review.

I sampled the patch and about a quarter or so of the links I tried didn't work, even before the change. There's no point in generating churn by changing those, but there's also little value in keeping them around, and fixing them is beyond the scope of this patch. I'm inclined to say let's leave them be, but I'm curious to hear what others think about that.

This revision now requires changes to proceed.Jun 14 2022, 8:40 AM
sunshaoce abandoned this revision.Jun 14 2022, 8:46 AM

Thanks for comments!