Page MenuHomePhabricator

sunshaoce (Shao-Ce SUN)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2022, 7:21 PM (12 w, 6 d)

Recent Activity

Today

sunshaoce requested review of D128604: [WIP][RISCV] Support Zbpbo extension.
Sun, Jun 26, 3:32 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

sunshaoce added a comment to D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Hi @Jim , are you still working on this?

Fri, Jun 24, 8:30 PM · Restricted Project, Restricted Project
sunshaoce committed rG529f05cdbbe9: [RISCV][MC] Fold UIMM related code (authored by sunshaoce).
[RISCV][MC] Fold UIMM related code
Fri, Jun 24, 7:51 PM · Restricted Project, Restricted Project
sunshaoce closed D128495: [RISCV][MC] Fold UIMM related code.
Fri, Jun 24, 7:51 PM · Restricted Project, Restricted Project
sunshaoce retitled D128495: [RISCV][MC] Fold UIMM related code from [RISCV][MC] Fold UIMM related code and add the missing isUImm functions to [RISCV][MC] Fold UIMM related code.
Fri, Jun 24, 2:38 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D128495: [RISCV][MC] Fold UIMM related code.

Address comment

Fri, Jun 24, 2:38 AM · Restricted Project, Restricted Project

Thu, Jun 23

sunshaoce requested review of D128495: [RISCV][MC] Fold UIMM related code.
Thu, Jun 23, 10:49 PM · Restricted Project, Restricted Project

Mon, Jun 20

sunshaoce removed a reviewer for D121670: [RISCV] Add zihintntl instructions: s.
Mon, Jun 20, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
sunshaoce commandeered D121670: [RISCV] Add zihintntl instructions.
Mon, Jun 20, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
sunshaoce updated the diff for D121670: [RISCV] Add zihintntl instructions.

Rebase

Mon, Jun 20, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
sunshaoce retitled D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen from [RISCV][CodeGen] Support Zfinx codegen to [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.
Mon, Jun 20, 10:47 PM · Restricted Project, Restricted Project
sunshaoce updated the diff for D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

Support zdinx,zhinx codegen

Mon, Jun 20, 10:47 PM · Restricted Project, Restricted Project

Wed, Jun 15

sunshaoce committed rGe180cc5ff1a1: [Driver][test] Make RISCV tests robust with PATH= (authored by sunshaoce).
[Driver][test] Make RISCV tests robust with PATH=
Wed, Jun 15, 7:25 AM · Restricted Project, Restricted Project
sunshaoce closed D127589: [Driver][test] Make RISCV tests robust with PATH=.
Wed, Jun 15, 7:25 AM · Restricted Project, Restricted Project

Tue, Jun 14

sunshaoce added inline comments to D127721: [RISCV][NFC] Add load/store instructions in rv64*-invalid.s.
Tue, Jun 14, 9:23 AM · Restricted Project, Restricted Project
sunshaoce abandoned D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs.

Thanks for comments!

Tue, Jun 14, 8:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
sunshaoce retitled D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs from [NFC] Use `https` instead of `http` in the urls to [NFC] Use `https` instead of `http` in the `LLVM.org` URLs.
Tue, Jun 14, 5:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
sunshaoce updated the diff for D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs.

Change to only modify *.llvm.org

Tue, Jun 14, 4:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

sunshaoce requested review of D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs.
Mon, Jun 13, 12:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
sunshaoce updated the diff for D127589: [Driver][test] Make RISCV tests robust with PATH=.

Address @StephenFan's comment.

Mon, Jun 13, 10:34 AM · Restricted Project, Restricted Project

Sun, Jun 12

sunshaoce added reviewers for D127589: [Driver][test] Make RISCV tests robust with PATH=: kito-cheng, MaskRay, khchen, asb, StephenFan.
Sun, Jun 12, 2:42 AM · Restricted Project, Restricted Project
sunshaoce requested review of D127589: [Driver][test] Make RISCV tests robust with PATH=.
Sun, Jun 12, 2:40 AM · Restricted Project, Restricted Project

Fri, Jun 10

sunshaoce committed rG117e10304b54: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo` (authored by sunshaoce).
[RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`
Fri, Jun 10, 9:28 AM · Restricted Project, Restricted Project
sunshaoce closed D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.
Fri, Jun 10, 9:28 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.

Address @reames's comment.

Fri, Jun 10, 9:12 AM · Restricted Project, Restricted Project
sunshaoce added a reverting change for D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`: rG93116374e73b: Revert "[RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`".
Fri, Jun 10, 9:04 AM · Restricted Project, Restricted Project
sunshaoce added a reverting change for rGe018e493c1ac: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`: rG93116374e73b: Revert "[RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`".
Fri, Jun 10, 9:04 AM · Restricted Project, Restricted Project
sunshaoce committed rG93116374e73b: Revert "[RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`" (authored by sunshaoce).
Revert "[RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`"
Fri, Jun 10, 9:03 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.

Reopen

Fri, Jun 10, 8:51 AM · Restricted Project, Restricted Project
sunshaoce reopened D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.
Fri, Jun 10, 8:50 AM · Restricted Project, Restricted Project
sunshaoce added a comment to D126794: [RISCV] Lower VLEFF/VLSEGFF SDNodes to MachineInstrs with VL outputs..

I've landed it.

Fri, Jun 10, 6:05 AM · Restricted Project, Restricted Project
sunshaoce committed rGe018e493c1ac: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo` (authored by sunshaoce).
[RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`
Fri, Jun 10, 6:04 AM · Restricted Project, Restricted Project
sunshaoce closed D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.
Fri, Jun 10, 6:04 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.

Address comments.

Fri, Jun 10, 1:55 AM · Restricted Project, Restricted Project
sunshaoce added inline comments to D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.
Fri, Jun 10, 1:36 AM · Restricted Project, Restricted Project
sunshaoce added a comment to D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.

I am sorry to create the trouble, but I didn't encounter this problem in my local. Could you provide me your cmake command?
My cmake command:

cmake -G "Ninja" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_BUILD_EXAMPLES=False -DLLVM_PARALLEL_LINK_JOBS=2 -DCMAKE_BUILD_TYPE=Debug ../llvm
Fri, Jun 10, 1:33 AM · Restricted Project, Restricted Project
sunshaoce updated the summary of D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.
Fri, Jun 10, 1:02 AM · Restricted Project, Restricted Project
sunshaoce requested review of D127477: [RISCV] move `isFaultFirstLoad` into `RISCVInstrInfo`.
Fri, Jun 10, 12:58 AM · Restricted Project, Restricted Project

Wed, Jun 8

sunshaoce added inline comments to D127376: [RISCV] Teach RISCVMergeBaseOffset about cases where we use SHXADD to add some immediates..
Wed, Jun 8, 10:37 PM · Restricted Project, Restricted Project
sunshaoce added a comment to D126222: [libcxx] Fix wrong messages of git version.

ping

Wed, Jun 8, 8:18 AM · Restricted Project, Restricted Project
sunshaoce committed rG862f30a42852: [RISCV] Add ISD::EH_DWARF_CFA (authored by sunshaoce).
[RISCV] Add ISD::EH_DWARF_CFA
Wed, Jun 8, 7:04 AM · Restricted Project, Restricted Project
sunshaoce closed D126181: [RISCV] Add ISD::EH_DWARF_CFA.
Wed, Jun 8, 7:03 AM · Restricted Project, Restricted Project

Mon, Jun 6

sunshaoce committed rG84bacb18c6c5: [RISCV] Use check-prefixes to reduce check lines (authored by sunshaoce).
[RISCV] Use check-prefixes to reduce check lines
Mon, Jun 6, 12:59 AM · Restricted Project, Restricted Project
sunshaoce closed D125083: [RISCV] Use check-prefixes to reduce check lines.
Mon, Jun 6, 12:59 AM · Restricted Project, Restricted Project

Fri, Jun 3

sunshaoce updated the diff for D125083: [RISCV] Use check-prefixes to reduce check lines.

Address comments.

Fri, Jun 3, 10:33 AM · Restricted Project, Restricted Project

Mon, May 30

sunshaoce accepted D126652: [RISCV] Change GPRPF64's hwmode and spill alignment.

LGTM

Mon, May 30, 8:20 PM · Restricted Project, Restricted Project

May 26 2022

sunshaoce updated the diff for D126181: [RISCV] Add ISD::EH_DWARF_CFA.

Address @luismarques's comments.

May 26 2022, 11:51 AM · Restricted Project, Restricted Project

May 25 2022

sunshaoce added a comment to D125083: [RISCV] Use check-prefixes to reduce check lines.

ping

May 25 2022, 7:42 PM · Restricted Project, Restricted Project

May 23 2022

sunshaoce added a reviewer for D126222: [libcxx] Fix wrong messages of git version: Restricted Project.
May 23 2022, 9:37 PM · Restricted Project, Restricted Project
sunshaoce abandoned D123654: [NFC][X86][CodeGen] Use ArrayRef in TargetLowering functions.
May 23 2022, 9:08 PM · Restricted Project, Restricted Project
sunshaoce abandoned D124506: [NFC][AArch64][CodeGen] Use ArrayRef in TargetLowering functions.
May 23 2022, 9:07 PM · Restricted Project, Restricted Project
sunshaoce requested review of D126222: [libcxx] Fix wrong messages of git version.
May 23 2022, 9:51 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D126181: [RISCV] Add ISD::EH_DWARF_CFA.

Address @StephenFan's comments.

May 23 2022, 1:11 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D126181: [RISCV] Add ISD::EH_DWARF_CFA.
May 23 2022, 12:05 AM · Restricted Project, Restricted Project

May 22 2022

sunshaoce updated the diff for D126181: [RISCV] Add ISD::EH_DWARF_CFA.

Address comments.

May 22 2022, 10:56 PM · Restricted Project, Restricted Project
sunshaoce requested review of D126181: [RISCV] Add ISD::EH_DWARF_CFA.
May 22 2022, 8:51 PM · Restricted Project, Restricted Project

May 19 2022

sunshaoce updated the diff for D125083: [RISCV] Use check-prefixes to reduce check lines.

Address @frasercrmck's comments.

May 19 2022, 12:49 AM · Restricted Project, Restricted Project

May 17 2022

sunshaoce updated the diff for D125083: [RISCV] Use check-prefixes to reduce check lines.

Address @frasercrmck's comments.

May 17 2022, 9:39 PM · Restricted Project, Restricted Project
sunshaoce added a reviewer for D125083: [RISCV] Use check-prefixes to reduce check lines: frasercrmck.
May 17 2022, 9:38 PM · Restricted Project, Restricted Project
sunshaoce committed rG25af3afa6761: [NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions (authored by sunshaoce).
[NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions
May 17 2022, 7:50 PM · Restricted Project, Restricted Project
sunshaoce closed D124508: [NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions.
May 17 2022, 7:50 PM · Restricted Project, Restricted Project
sunshaoce updated the diff for D124508: [NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions.

Address comments.

May 17 2022, 5:59 PM · Restricted Project, Restricted Project
sunshaoce added a comment to D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

ping

May 17 2022, 9:29 AM · Restricted Project, Restricted Project

May 11 2022

sunshaoce added a comment to D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s .

LGTM, but I didn't find load/store instructions in other rv64*-invalid.s, could you add those either?

May 11 2022, 7:35 PM · Restricted Project, Restricted Project
sunshaoce committed rGb049eb1fec92: [RISCV] Remove some TODOs in tests (authored by sunshaoce).
[RISCV] Remove some TODOs in tests
May 11 2022, 7:54 AM · Restricted Project, Restricted Project
sunshaoce closed D125289: [RISCV] Remove some TODOs in tests.
May 11 2022, 7:54 AM · Restricted Project, Restricted Project

May 9 2022

sunshaoce updated the diff for D125289: [RISCV] Remove some TODOs in tests.

rebase

May 9 2022, 10:30 PM · Restricted Project, Restricted Project
sunshaoce requested review of D125289: [RISCV] Remove some TODOs in tests.
May 9 2022, 10:14 PM · Restricted Project, Restricted Project

May 8 2022

sunshaoce added inline comments to D125157: [clang][Driver] Add more tests for riscv.
May 8 2022, 11:53 PM · Restricted Project, Restricted Project, Restricted Project
sunshaoce updated the diff for D123654: [NFC][X86][CodeGen] Use ArrayRef in TargetLowering functions.

Address comments

May 8 2022, 10:49 PM · Restricted Project, Restricted Project
sunshaoce updated the diff for D125083: [RISCV] Use check-prefixes to reduce check lines.

Add more tests

May 8 2022, 8:26 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

Fix errors

May 8 2022, 7:00 AM · Restricted Project, Restricted Project
sunshaoce retitled D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen from [RISCV][CodeGen] Support float-arith in Zfinx to [RISCV][CodeGen] Support Zfinx codegen.
May 8 2022, 6:19 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

Fully support zfinx codegen

May 8 2022, 6:17 AM · Restricted Project, Restricted Project

May 6 2022

sunshaoce updated the diff for D125083: [RISCV] Use check-prefixes to reduce check lines.

Address @frasercrmck's comments. Thanks!

May 6 2022, 6:58 AM · Restricted Project, Restricted Project
sunshaoce requested review of D125083: [RISCV] Use check-prefixes to reduce check lines.
May 6 2022, 1:41 AM · Restricted Project, Restricted Project

Apr 27 2022

sunshaoce added a comment to D124506: [NFC][AArch64][CodeGen] Use ArrayRef in TargetLowering functions.

IMO, at least some of these modifications can be employed.

Apr 27 2022, 3:17 AM · Restricted Project, Restricted Project
sunshaoce requested review of D124508: [NFC][AMDGPU][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 27 2022, 1:53 AM · Restricted Project, Restricted Project
sunshaoce requested review of D124506: [NFC][AArch64][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 27 2022, 1:21 AM · Restricted Project, Restricted Project

Apr 26 2022

sunshaoce updated the diff for D123654: [NFC][X86][CodeGen] Use ArrayRef in TargetLowering functions.

Rebase

Apr 26 2022, 9:32 AM · Restricted Project, Restricted Project
sunshaoce committed rGc59473aacce3: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions (authored by sunshaoce).
[NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions
Apr 26 2022, 8:53 AM · Restricted Project, Restricted Project
sunshaoce closed D123653: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 26 2022, 8:53 AM · Restricted Project, Restricted Project

Apr 25 2022

sunshaoce added a comment to D123653: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions.

ping

Apr 25 2022, 11:53 AM · Restricted Project, Restricted Project
sunshaoce added a reviewer for D123653: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions: frasercrmck.
Apr 25 2022, 11:53 AM · Restricted Project, Restricted Project

Apr 18 2022

sunshaoce updated the diff for D123653: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions.

Address @craig.topper's comments

Apr 18 2022, 6:52 AM · Restricted Project, Restricted Project

Apr 14 2022

sunshaoce updated the diff for D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

Fix crash

Apr 14 2022, 7:40 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D123653: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions.

Address @frasercrmck's comments.

Apr 14 2022, 6:27 AM · Restricted Project, Restricted Project

Apr 13 2022

sunshaoce added a comment to D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

Ok, I've since learned that this PR doesnt handle load/store. Only arithmetic.

However note that immediate float arithmetic also seems to be missing, e.g. the following crashes

define noundef float @_Z4funcf(float noundef %0) #0 {
  %2 = fadd float %0, 3.000000e+00
  ret float %2
}

Compiled with:

bin/llc --march riscv32 -mattr +zfinx test_fadd_imm.ll

Gives:

LLVM ERROR: Cannot select: t15: f32,ch = load<(load (s32) from constant-pool)> t0, t19, undef:i32
  t19: i32 = ADDI t18, TargetConstantPool:i32<float 3.000000e+00> 0 [TF=3]
    t18: i32 = LUI TargetConstantPool:i32<float 3.000000e+00> 0 [TF=4]
      t16: i32 = TargetConstantPool<float 3.000000e+00> 0 [TF=4]
    t17: i32 = TargetConstantPool<float 3.000000e+00> 0 [TF=3]
  t14: i32 = undef
In function: _Z4funcf

(but compiles ok with +f)

Apr 13 2022, 3:53 AM · Restricted Project, Restricted Project
sunshaoce added inline comments to D123656: [CodeGen] Use ArrayRef in TargetLowering functions.
Apr 13 2022, 12:16 AM · Restricted Project, Restricted Project
sunshaoce added reviewers for D123656: [CodeGen] Use ArrayRef in TargetLowering functions: asb, RKSimon, craig.topper.
Apr 13 2022, 12:16 AM · Restricted Project, Restricted Project

Apr 12 2022

sunshaoce requested review of D123654: [NFC][X86][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 12 2022, 10:40 PM · Restricted Project, Restricted Project
sunshaoce requested review of D123653: [NFC][RISCV][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 12 2022, 10:29 PM · Restricted Project, Restricted Project
sunshaoce committed rGe90110e696c7: [NFC][CodeGen] Use ArrayRef in TargetLowering functions (authored by sunshaoce).
[NFC][CodeGen] Use ArrayRef in TargetLowering functions
Apr 12 2022, 9:46 AM · Restricted Project, Restricted Project
sunshaoce closed D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 12 2022, 9:46 AM · Restricted Project, Restricted Project
sunshaoce added inline comments to D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 12 2022, 8:57 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.

Split revision

Apr 12 2022, 8:40 AM · Restricted Project, Restricted Project
sunshaoce updated the diff for D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.

Revert some changes

Apr 12 2022, 5:59 AM · Restricted Project, Restricted Project

Apr 10 2022

sunshaoce updated the diff for D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.

Address comments

Apr 10 2022, 11:39 PM · Restricted Project, Restricted Project
sunshaoce requested review of D123467: [NFC][CodeGen] Use ArrayRef in TargetLowering functions.
Apr 10 2022, 10:44 AM · Restricted Project, Restricted Project

Apr 6 2022

sunshaoce updated the diff for D122918: [RISCV][CodeGen] Support Zfinx,Zdinx,Zhinx,Zhinxmin codegen.

Rebase

Apr 6 2022, 11:24 PM · Restricted Project, Restricted Project