Page MenuHomePhabricator

bollu (Siddharth Bhat)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2017, 1:20 PM (274 w, 4 d)

Recent Activity

Yesterday

bollu added a comment to D126551: [MLIR] Make `print-op-generic` print generic DialectSymbol..

@rriddle as an external consumer of MLIR, it is quite annoying to have to parse both foo<"..."> as well as foo.bar<balanced-parens>.

Fri, May 27, 11:49 AM · Restricted Project, Restricted Project
bollu updated the diff for D126538: [MLIR] [LangRef] Clarify `dialect-item` parsing.

Rebase patch to latest MLIR

Fri, May 27, 11:47 AM · Restricted Project, Restricted Project
bollu updated the diff for D126551: [MLIR] Make `print-op-generic` print generic DialectSymbol..

Rebase on latest build, fix tests

Fri, May 27, 11:42 AM · Restricted Project, Restricted Project
bollu added a reviewer for D126551: [MLIR] Make `print-op-generic` print generic DialectSymbol.: mehdi_amini.
Fri, May 27, 8:28 AM · Restricted Project, Restricted Project
bollu requested review of D126551: [MLIR] Make `print-op-generic` print generic DialectSymbol..
Fri, May 27, 8:23 AM · Restricted Project, Restricted Project
bollu added reviewers for D126538: [MLIR] [LangRef] Clarify `dialect-item` parsing: ayrivera, mehdi_amini, stephenneuendorffer.
Fri, May 27, 6:55 AM · Restricted Project, Restricted Project
bollu requested review of D126538: [MLIR] [LangRef] Clarify `dialect-item` parsing.
Fri, May 27, 6:54 AM · Restricted Project, Restricted Project

Sun, May 8

bollu requested review of D125202: [Polly] Disable matmul pattern-match + -polly-parallel.
Sun, May 8, 8:42 PM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2022

bollu abandoned D122979: [MLIR] Add (un)ranked memrefs into LangRef.
Apr 2 2022, 11:45 AM · Restricted Project, Restricted Project
bollu requested review of D122979: [MLIR] Add (un)ranked memrefs into LangRef.
Apr 2 2022, 7:51 AM · Restricted Project, Restricted Project
bollu requested review of D122978: [MLIR] Add booleans to dense element list in LangRef.
Apr 2 2022, 7:41 AM · Restricted Project, Restricted Project
bollu requested review of D122977: [MLIR] Add nested symbols into LangRef.
Apr 2 2022, 7:31 AM · Restricted Project, Restricted Project

Mar 5 2022

bollu updated the summary of D121048: [MLIR] [LangRef] Clarify parsing of dense<...>.
Mar 5 2022, 8:49 AM · Restricted Project, Restricted Project
bollu requested review of D121048: [MLIR] [LangRef] Clarify parsing of dense<...>.
Mar 5 2022, 8:47 AM · Restricted Project, Restricted Project

Feb 16 2022

bollu added reviewers for D119950: [MLIR] add entry block to MLIR grammar.: mehdi_amini, rriddle, silvas, stephenneuendorffer, kiszk, ftynse.
Feb 16 2022, 8:11 AM · Restricted Project
bollu requested review of D119950: [MLIR] add entry block to MLIR grammar..
Feb 16 2022, 8:08 AM · Restricted Project

Jan 19 2022

bollu requested review of D117668: [mlir][LangRef] Add top-level production to the MLIR grammar.
Jan 19 2022, 6:04 AM · Restricted Project

Jan 22 2021

bollu added inline comments to D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..
Jan 22 2021, 7:21 AM · Restricted Project

Jan 21 2021

bollu accepted D72088: [polly] NFC: Fix trivial typos in comments.
Jan 21 2021, 12:48 AM · Restricted Project

Jan 20 2021

bollu added inline comments to D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..
Jan 20 2021, 1:16 PM · Restricted Project

Jan 15 2021

bollu removed a reviewer for D36926: [Polly][WIP] Clear DependenceInfo after expansion: bollu.
Jan 15 2021, 8:48 PM
bollu removed a reviewer for D88353: [BasicAA] Integrate MaxObjSize for NoAlias: bollu.
Jan 15 2021, 8:46 PM · Restricted Project
bollu removed a reviewer for D90338: [SCEV] Infer addrec nowrap flags while calculating ranges (WIP): bollu.
Jan 15 2021, 8:46 PM · Restricted Project
bollu removed a reviewer for D40122: Add isl to LLVM repository.: bollu.
Jan 15 2021, 8:44 PM · Restricted Project
bollu removed a reviewer for D40369: Support sext instruction in SCEV delinearization algorithm (new revision): bollu.
Jan 15 2021, 8:44 PM
bollu removed a reviewer for D40783: [Polly] Drop overapproximation of kernel arguments: bollu.
Jan 15 2021, 8:43 PM
bollu removed a reviewer for D42142: [Polly] [WIP] Adding Live-Range Reordering for Polly: bollu.
Jan 15 2021, 8:43 PM
bollu removed a reviewer for D48162: [GSoC] Schedule tree performance.: bollu.
Jan 15 2021, 8:43 PM · Restricted Project
bollu removed a reviewer for D90338: [SCEV] Infer addrec nowrap flags while calculating ranges (WIP): bollu.
Jan 15 2021, 8:43 PM · Restricted Project
bollu removed a reviewer for D88353: [BasicAA] Integrate MaxObjSize for NoAlias: bollu.
Jan 15 2021, 8:42 PM · Restricted Project
bollu removed a reviewer for D94266: [polly][NewPM][test] Fix polly tests under -enable-new-pm: bollu.
Jan 15 2021, 8:42 PM · Restricted Project
bollu added a comment to D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.

Out of curiosity: may I please have some context for what this base class is being created for? Ie, what consumers other than the existing PatternRewriter will soon exist? :)

Jan 15 2021, 7:38 PM · Restricted Project

Jan 13 2021

bollu added inline comments to D94272: Support emptiness checks for unbounded FlatAffineConstraints..
Jan 13 2021, 11:42 AM · Restricted Project

Jul 16 2020

Herald added a project to D75433: [MLIR] Add llvm.switch: Restricted Project.

I was curious on the progress of this patch: May I pick it up if work has stalled, @uenoku?

Jul 16 2020, 2:43 PM · Restricted Project

Nov 14 2018

bollu added a comment to D54498: AbstractCallSite -- A unified interface for (in)direct and callback calls.

Thanks for the answer! That clears up a lot.

Nov 14 2018, 10:35 AM
bollu added a comment to D54498: AbstractCallSite -- A unified interface for (in)direct and callback calls.

I have a question in the context of optimising sequential programs -- I'm interested in optimising across a trampoline call, since I have a haskell-like lazy language, which lowers CPS into LLVM-IR by constructing a trampoline. Example IR here Some salient features are:

Nov 14 2018, 9:57 AM

Jul 20 2018

bollu added inline comments to D49609: [isl] Typesafe user pointers.
Jul 20 2018, 1:06 PM
bollu added inline comments to D49609: [isl] Typesafe user pointers.
Jul 20 2018, 11:50 AM
bollu added a comment to D49609: [isl] Typesafe user pointers.

Looks good, I haven't looked too much into how Any works, which I will.

Jul 20 2018, 11:49 AM
bollu added a comment to D49609: [isl] Typesafe user pointers.

Looks good, I haven't looked too much into how Any works, which I will.

Jul 20 2018, 11:49 AM

Jul 12 2018

bollu accepted D49154: Extend CFGPrinter and CallPrinter with Heat Colors: Polly changes.

So, how do we coordinate this? :) Or do you push the patches at the same time?

Jul 12 2018, 9:01 AM
bollu added a comment to D49154: Extend CFGPrinter and CallPrinter with Heat Colors: Polly changes.

Thanks! However, I am a little confused: when do I merge this, precisely? It breaks on current LLVM HEAD.

Jul 12 2018, 8:40 AM

Jul 9 2018

bollu added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 9 2018, 8:34 AM

Jul 8 2018

bollu added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 8 2018, 4:30 AM
bollu added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 8 2018, 3:56 AM
bollu added inline comments to D49024: [Polly] [WIP] Introduce ShapeInfo into polly for sizes and strides..
Jul 8 2018, 3:22 AM
bollu abandoned D48874: [Polly] [WIP] Introduce ShapeInfo into polly..

Abandoned in favour of D49024.

Jul 8 2018, 3:17 AM · Restricted Project

Jul 4 2018

bollu committed rL336288: [PPCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].
[PPCGCodeGen] Change printf to outs() to prevent garbled output. [NFC]
Jul 4 2018, 9:56 AM
bollu closed D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].
Jul 4 2018, 9:56 AM
bollu committed rL336251: [Polly-ACC] Add isl_space.h to gpu_tree.c.
[Polly-ACC] Add isl_space.h to gpu_tree.c
Jul 4 2018, 2:45 AM
bollu closed D48883: [Polly-ACC] Add isl_space.h to gpu_tree.c.
Jul 4 2018, 2:45 AM
bollu accepted D48883: [Polly-ACC] Add isl_space.h to gpu_tree.c.
Jul 4 2018, 2:12 AM

Jul 3 2018

bollu added a comment to D48874: [Polly] [WIP] Introduce ShapeInfo into polly..

@Meinersbur in polly, we use sizes per dimension, so the sizes data structure actually stores the size of a dimension. In the "stride" version, we rather store the "block size" of each dimension, which is akin to the Fortran representation, and the representation (if I understand the chapel representation correctly).

Jul 3 2018, 9:19 AM · Restricted Project
bollu updated the diff for D48874: [Polly] [WIP] Introduce ShapeInfo into polly..

Extract out codegen as well.

Jul 3 2018, 9:13 AM · Restricted Project
bollu updated the diff for D48874: [Polly] [WIP] Introduce ShapeInfo into polly..
  • Backport code to detect chapel/fortran style indexing. TODO: Codegen.
Jul 3 2018, 8:42 AM · Restricted Project
bollu added a project to D48874: [Polly] [WIP] Introduce ShapeInfo into polly.: Restricted Project.
Jul 3 2018, 4:41 AM · Restricted Project
bollu updated the summary of D48874: [Polly] [WIP] Introduce ShapeInfo into polly..
Jul 3 2018, 4:41 AM · Restricted Project
bollu created D48874: [Polly] [WIP] Introduce ShapeInfo into polly..
Jul 3 2018, 4:39 AM · Restricted Project

Jun 27 2018

bollu added a comment to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

As mentioned, I don't have the bandwidth :( If you could fix the issues that were raised during the review, it would be awesome.

Jun 27 2018, 12:39 PM · debug-info
bollu accepted D48136: [Polly] Implement an iterator for isl maps, basic_maps, sets, basic_sets.

Sorry, I meant to accept this last week. I accept this as an acceptable "software engineering" compromise, while I still hold the philosophical reservations I have mentioned.

Jun 27 2018, 12:33 PM
bollu added a comment to D48136: [Polly] Implement an iterator for isl maps, basic_maps, sets, basic_sets.

@Meinersbur If you are opposed to merging this, please request changes.

Jun 27 2018, 12:33 PM

Jun 26 2018

bollu added a comment to D48136: [Polly] Implement an iterator for isl maps, basic_maps, sets, basic_sets.

@Meinersbur even assuming that such a concept exists (since one could argue such a concept does exist for a range-based for loop to work), I still don't think it allows the compiler to optimise away iterators based on the interpretation of the spec I outlined (== is an equivalence relation whose domain is mutable).

Jun 26 2018, 6:27 AM

Jun 22 2018

bollu updated subscribers of D48026: [ScopHelper] Provide support for recognising collective invariant loads.

Also, please run the file through instnamer. That way, we will have "named" instructions and not "numbered" instructions. This is useful to modify the testcase in the future (it is less brittle): "numbered" instructions must be sequential, while named instructions need to be.

Jun 22 2018, 9:04 AM
bollu added inline comments to D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 22 2018, 6:55 AM
bollu added inline comments to D48026: [ScopHelper] Provide support for recognising collective invariant loads.
Jun 22 2018, 4:59 AM
bollu added inline comments to D48136: [Polly] Implement an iterator for isl maps, basic_maps, sets, basic_sets.
Jun 22 2018, 4:52 AM

Jun 17 2018

bollu requested changes to D48162: [GSoC] Schedule tree performance..

I'm going to request changes so this does not show up on the feed. I added two more comments regarding constructors :)

Jun 17 2018, 3:13 AM · Restricted Project

Jun 16 2018

bollu added a comment to D48162: [GSoC] Schedule tree performance..

Thanks for the patch! I've added some comments about general LLVM style, and some personal choices. Feel free to ignore the personal choices :)

Jun 16 2018, 12:15 PM · Restricted Project
bollu updated subscribers of D48162: [GSoC] Schedule tree performance..

Thanks for the patch! I've added some comments about general LLVM style, and some personal choices. Feel free to ignore the personal choices :)

Jun 16 2018, 12:15 PM · Restricted Project

Jun 4 2018

bollu added a comment to D47604: [Polly] Add isl C++ list iterators.

This might be too much to ask for, but is it possible to report_fatal_error() at the earliest when accessing out of bounds using the iterator? If ISL performs inbounds checks, then disregard this.

Jun 4 2018, 3:11 AM
bollu added a comment to D47604: [Polly] Add isl C++ list iterators.

This might be too much to ask for, but is it possible to report_fatal_error() at the earliest when accessing out of bounds using the iterator? If ISL performs inbounds checks, then disregard this.

Jun 4 2018, 3:11 AM

Apr 20 2018

bollu added inline comments to D45743: [Polly] Print executed statement instances at runtime..
Apr 20 2018, 8:47 AM · Restricted Project

Mar 21 2018

bollu added a comment to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

I'm sorry. I don't have the bandwidth for this right now. Please do take it up, it'd be great to see this upstreamed! If we can get the base version upstreamed, I don't mind quickly iterating on smaller features / tests / things like that.

Mar 21 2018, 7:47 AM · debug-info

Jan 17 2018

bollu added a comment to D42142: [Polly] [WIP] Adding Live-Range Reordering for Polly.

@Meinersbur I agree. However, I don't think that this is the right place for the code either. It is more a DependenceInfo thing, and maybe it makes sense to teach DependenceInfo to generate this information for us?

Jan 17 2018, 9:00 AM

Jan 16 2018

bollu added a comment to D42142: [Polly] [WIP] Adding Live-Range Reordering for Polly.

Thanks a lot for the patch! I took a shot at a first round of review :) I can be nitpicky, so we can hash out the details as we go along with the review.

Jan 16 2018, 9:37 PM

Dec 5 2017

bollu added a comment to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

Regarding StripDebugInfo, I did not know it existed. I should refactor the code to use it, I assume? I'll check this out.

Dec 5 2017, 1:50 PM · debug-info

Dec 4 2017

bollu committed rL319718: Update to latest clang-format. [NFC].
Update to latest clang-format. [NFC]
Dec 4 2017, 4:06 PM
bollu closed D40791: [Polly] update to latest clang-format. [NFC] by committing rL319718: Update to latest clang-format. [NFC].
Dec 4 2017, 4:06 PM · Restricted Project
bollu added a comment to D40791: [Polly] update to latest clang-format. [NFC].

No, unfortunately, I'm not sure. I didn't want to guess, so I didn't write a particular clang revision.

Dec 4 2017, 4:04 PM · Restricted Project
bollu added reviewers for D40791: [Polly] update to latest clang-format. [NFC]: grosser, philip.pfaffe, Meinersbur.
Dec 4 2017, 8:32 AM · Restricted Project
bollu created D40791: [Polly] update to latest clang-format. [NFC].
Dec 4 2017, 8:32 AM · Restricted Project
bollu updated the diff for D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

Removed expletives from patch that arose due to frustration with debug metadata. Run clang-format on file.

Dec 4 2017, 5:47 AM · debug-info

Dec 3 2017

bollu abandoned D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

Sorry for the delay, I resubmitted the patch as D40778. I'm closing this in favor of continuing the discussion there. Ping, @vsk, and thanks for all the help so far!

Dec 3 2017, 1:47 PM
bollu created D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].
Dec 3 2017, 1:46 PM · debug-info

Nov 28 2017

bollu accepted D40492: Handle Top-Level-Regions in polly::isHoistableLoad.
Nov 28 2017, 5:35 AM · Restricted Project
bollu added a comment to D40492: Handle Top-Level-Regions in polly::isHoistableLoad.

Other than request for documentation, LGTM. I did not test it, but I reduced the test case with bugpoint, so it should be the right fix. If not, I can complain again ;)

Nov 28 2017, 5:35 AM · Restricted Project
bollu added a comment to D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

@vsk In that case, I think we agree. Bugpoint is useful, but a debugger is really helpful in certain contexts. It's easier for me (and I suspect others) to debug on the IR level when they would like to do so. Does that provide enough of a motivation to go ahead with the review of the patch? You mentioned that there are technical issues, I'd like to sort them out :)

Nov 28 2017, 5:01 AM

Nov 27 2017

bollu added a comment to D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

@vsk Bugpoint does has four weaknesses that I have noticed not work (as far as I know, please do let me know if bugpoint can do this)

Nov 27 2017, 1:49 PM
bollu added a comment to D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

@vsk I do use the same technique for testing my frontend. However, this is useful when stuff _breaks_ in the frontend.g I'm not as good at reading asm as I'd like to be, so being able to debug at the IR level is a boon.

Nov 27 2017, 11:07 AM

Nov 18 2017

bollu added reviewers for D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM.: grosser, philip.pfaffe.
Nov 18 2017, 5:54 AM
bollu added reviewers for D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM.: dexonsmith, echristo, aprantl, vsk.
Nov 18 2017, 5:34 AM
bollu created D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..
Nov 18 2017, 5:30 AM

Nov 16 2017

bollu updated the diff for D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].
  • remove unrelated files.
Nov 16 2017, 6:21 AM
bollu created D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].
Nov 16 2017, 6:14 AM
bollu updated the diff for D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
  • update code and test case
Nov 16 2017, 6:02 AM

Nov 13 2017

bollu added inline comments to D37135: [Polly] [PPCGCodeGeneration] Allow PPCGCodeGeneration to run without libdevice..
Nov 13 2017, 5:01 PM

Nov 11 2017

bollu updated the diff for D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
  • [NFC wrt patch] remove debug code
Nov 11 2017, 5:07 AM
bollu updated the diff for D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
  • add changes in PPCGCodeGen that were missed due to incorrect rebase.
Nov 11 2017, 5:07 AM
bollu added a comment to D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..

@efriedma Thanks, I totally screwed up the rebase :)

Nov 11 2017, 5:07 AM

Nov 10 2017

bollu created D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
Nov 10 2017, 8:45 AM