bollu (Siddharth)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2017, 1:20 PM (47 w, 2 d)

Recent Activity

Yesterday

bollu added a comment to D42142: Adding Live-range reordering for Polly.

@Meinersbur I agree. However, I don't think that this is the right place for the code either. It is more a DependenceInfo thing, and maybe it makes sense to teach DependenceInfo to generate this information for us?

Wed, Jan 17, 9:00 AM

Tue, Jan 16

bollu added a comment to D42142: Adding Live-range reordering for Polly.

Thanks a lot for the patch! I took a shot at a first round of review :) I can be nitpicky, so we can hash out the details as we go along with the review.

Tue, Jan 16, 9:37 PM

Dec 5 2017

bollu added a comment to D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

Regarding StripDebugInfo, I did not know it existed. I should refactor the code to use it, I assume? I'll check this out.

Dec 5 2017, 1:50 PM · debug-info

Dec 4 2017

bollu committed rL319718: Update to latest clang-format. [NFC].
Update to latest clang-format. [NFC]
Dec 4 2017, 4:06 PM
bollu closed D40791: [Polly] update to latest clang-format. [NFC] by committing rL319718: Update to latest clang-format. [NFC].
Dec 4 2017, 4:06 PM · Restricted Project
bollu added a comment to D40791: [Polly] update to latest clang-format. [NFC].

No, unfortunately, I'm not sure. I didn't want to guess, so I didn't write a particular clang revision.

Dec 4 2017, 4:04 PM · Restricted Project
bollu added reviewers for D40791: [Polly] update to latest clang-format. [NFC]: grosser, philip.pfaffe, Meinersbur.
Dec 4 2017, 8:32 AM · Restricted Project
bollu created D40791: [Polly] update to latest clang-format. [NFC].
Dec 4 2017, 8:32 AM · Restricted Project
bollu updated the diff for D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].

Removed expletives from patch that arose due to frustration with debug metadata. Run clang-format on file.

Dec 4 2017, 5:47 AM · debug-info

Dec 3 2017

bollu abandoned D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

Sorry for the delay, I resubmitted the patch as D40778. I'm closing this in favor of continuing the discussion there. Ping, @vsk, and thanks for all the help so far!

Dec 3 2017, 1:47 PM
bollu created D40778: [DebugIR] Revive the Debug IR pass. [Added llvm-commits].
Dec 3 2017, 1:46 PM · debug-info

Nov 28 2017

bollu accepted D40492: Handle Top-Level-Regions in polly::isHoistableLoad.
Nov 28 2017, 5:35 AM · Restricted Project
bollu added a comment to D40492: Handle Top-Level-Regions in polly::isHoistableLoad.

Other than request for documentation, LGTM. I did not test it, but I reduced the test case with bugpoint, so it should be the right fix. If not, I can complain again ;)

Nov 28 2017, 5:35 AM · Restricted Project
bollu added a comment to D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

@vsk In that case, I think we agree. Bugpoint is useful, but a debugger is really helpful in certain contexts. It's easier for me (and I suspect others) to debug on the IR level when they would like to do so. Does that provide enough of a motivation to go ahead with the review of the patch? You mentioned that there are technical issues, I'd like to sort them out :)

Nov 28 2017, 5:01 AM

Nov 27 2017

bollu added a comment to D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

@vsk Bugpoint does has four weaknesses that I have noticed not work (as far as I know, please do let me know if bugpoint can do this)

Nov 27 2017, 1:49 PM
bollu added a comment to D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..

@vsk I do use the same technique for testing my frontend. However, this is useful when stuff _breaks_ in the frontend.g I'm not as good at reading asm as I'd like to be, so being able to debug at the IR level is a boon.

Nov 27 2017, 11:07 AM

Nov 18 2017

bollu added reviewers for D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM.: grosser, philip.pfaffe.
Nov 18 2017, 5:54 AM
bollu added reviewers for D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM.: dexonsmith, echristo, aprantl, vsk.
Nov 18 2017, 5:34 AM
bollu created D40207: [WIP] [DebugIR] Revive the old DebugIR pass for tip-of-tree LLVM..
Nov 18 2017, 5:30 AM

Nov 16 2017

bollu updated the diff for D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].
  • remove unrelated files.
Nov 16 2017, 6:21 AM
bollu created D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].
Nov 16 2017, 6:14 AM
bollu updated the diff for D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
  • update code and test case
Nov 16 2017, 6:02 AM

Nov 13 2017

bollu added inline comments to D37135: [Polly] [PPCGCodeGeneration] Allow PPCGCodeGeneration to run without libdevice..
Nov 13 2017, 5:01 PM

Nov 11 2017

bollu updated the diff for D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
  • [NFC wrt patch] remove debug code
Nov 11 2017, 5:07 AM
bollu updated the diff for D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
  • add changes in PPCGCodeGen that were missed due to incorrect rebase.
Nov 11 2017, 5:07 AM
bollu added a comment to D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..

@efriedma Thanks, I totally screwed up the rebase :)

Nov 11 2017, 5:07 AM

Nov 10 2017

bollu created D39904: [Polly] [PPCGCodeGeneration] Teach `SubtreeValues` to include possibly required base pointers, not remove all base pointers blindly..
Nov 10 2017, 8:45 AM

Oct 30 2017

bollu added inline comments to D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Oct 30 2017, 3:29 AM · Restricted Project

Oct 16 2017

bollu accepted D38953: Updating the TipsAndTricks.rst documentation of Polly related to bugpoint.

LGTM! Thanks, I didn't realize that the options could interact with bugs in llc.

Oct 16 2017, 7:51 AM · Restricted Project

Oct 4 2017

bollu added a comment to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..

Thanks for the very clean patch :) I really like reviewing your code, it's always really well written.

Oct 4 2017, 5:15 PM · Restricted Project
bollu added inline comments to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Oct 4 2017, 7:13 AM · Restricted Project

Sep 29 2017

bollu added inline comments to D35471: [Polly] [RFC] Calculate AST expression type.
Sep 29 2017, 8:33 AM
bollu added inline comments to D35471: [Polly] [RFC] Calculate AST expression type.
Sep 29 2017, 8:27 AM
bollu added inline comments to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Sep 29 2017, 8:00 AM · Restricted Project

Sep 28 2017

bollu committed rL314422: [Docs] fix rendering of alpha and beta.
[Docs] fix rendering of alpha and beta
Sep 28 2017, 8:34 AM
bollu committed rL314423: [Docs] Replace 0-byte incorrect GEMM_double image with the one from www/images.
[Docs] Replace 0-byte incorrect GEMM_double image with the one from www/images
Sep 28 2017, 8:34 AM
bollu committed rL314419: [Docs] Add a performance document..
[Docs] Add a performance document.
Sep 28 2017, 8:12 AM
bollu closed D38330: [docs] Add a performance doc by committing rL314419: [Docs] Add a performance document..
Sep 28 2017, 8:12 AM · Restricted Project
bollu created D38353: [Polly] [PPCGCodeGeneration] Fix offset computation for managed arrays..
Sep 28 2017, 5:09 AM

Sep 25 2017

bollu added a comment to D38255: [WIP] Polyhedral Value Analysis.

@jdoerfert: Thanks for putting this up. I'm trying to read and understand the ideas behind this. I've left a few questions, could you please clarify them for me?

Sep 25 2017, 3:37 PM
bollu added a comment to D38255: [WIP] Polyhedral Value Analysis.

@jdoerfert: Thanks for putting this up. I'm trying to read and understand the ideas behind this. I've left a few questions, could you please clarify them for me?

Sep 25 2017, 3:36 PM

Sep 15 2017

bollu created D37901: [Polly] [Strided arrays, multidimensional indexing, fortran support] Teach Polly multidimensional strided array indexing. [WIP].
Sep 15 2017, 7:06 AM

Sep 7 2017

bollu committed rL312715: [PPCGCodeGen] Document pre-composition with Zero in getExtent. [NFC].
[PPCGCodeGen] Document pre-composition with Zero in getExtent. [NFC]
Sep 7 2017, 5:00 AM

Sep 1 2017

bollu added a comment to D37379: [Polly] [ISLNodeBuilder] [Fortran Arrays] Materialize Fortran array sizes of arrays without memory accesses..

Review please, this was a quick bugfix.

Sep 1 2017, 7:33 AM
bollu created D37379: [Polly] [ISLNodeBuilder] [Fortran Arrays] Materialize Fortran array sizes of arrays without memory accesses..
Sep 1 2017, 7:31 AM

Aug 31 2017

bollu closed D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible. by committing rL312239: [PPCGCodeGen] Convert intrinsics to libdevice functions whenever possible..
Aug 31 2017, 6:06 AM

Aug 29 2017

bollu committed rL311995: [ScopInfo] Fix comment grammar. "..to be build" -> "..to be built". [NFC].
[ScopInfo] Fix comment grammar. "..to be build" -> "..to be built". [NFC]
Aug 29 2017, 4:47 AM

Aug 28 2017

bollu added a comment to D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..

@efriedma I made the changes you requested. Could you have a final look, please?

Aug 28 2017, 3:31 AM
bollu updated the diff for D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
  • [Diff update] Update diff with latest master.
Aug 28 2017, 2:37 AM
bollu updated the diff for D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
  • Don't parse the function name, keep a static map from intrinsic names to libdevice names
Aug 28 2017, 2:19 AM

Aug 27 2017

bollu accepted D37191: [Polly][GPGPU] Fixed undefined reference for CUDA's managed memory in Runtime library..

LGTM, thanks for generalising it :) I'm sorry, I'll keep the mixed CUDA/OpenCL thing in mind next time I mess with GPUJIt.

Aug 27 2017, 4:58 AM

Aug 25 2017

bollu added a comment to D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..

@grosser ping, review please.

Aug 25 2017, 8:18 AM
bollu added a comment to D37061: [Polly] Third Updated translating the function Scop::foldSizeConstantsToRight() to isl C++.

Also, for future reference, note that an old review can be updated: There is an update diff option to the right hand side at the top of the web page. That way, we won't have multiple revisions like D37061 and D36843. This reduces the number of places someone needs to look to see the total change :). Thanks!

Aug 25 2017, 2:52 AM
bollu created D37135: [Polly] [PPCGCodeGeneration] Allow PPCGCodeGeneration to run without libdevice..
Aug 25 2017, 2:24 AM

Aug 24 2017

bollu added a comment to D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..

@efriedma - The NVPTX backend does not lower either llvm.exp.* or llvm.powi.* (Unless I am doing something wrong).

Aug 24 2017, 3:01 AM
bollu committed rL311648: [Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions….
[Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions…
Aug 24 2017, 2:55 AM
bollu closed D37058: [Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions in a kernel. by committing rL311648: [Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions….
Aug 24 2017, 2:55 AM

Aug 23 2017

bollu created D37067: [Polly] [WIP] [ManagedMemoryRewrite] Rewrite global structs to managed memory..
Aug 23 2017, 9:00 AM
bollu updated the diff for D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
  • [Test] upadte tests to refect state of exp, powi in PPCGCodeGen
Aug 23 2017, 5:21 AM
bollu added a comment to D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..

I should probably split this into two patches, but I wanted to run the idea by. I can split it when I commit (or split it now). Review, please.

Aug 23 2017, 4:50 AM
bollu retitled D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible. from [Polly] [PPCGCodeGeneration] [WIP] Convert intrinsics to libdevice functions whenever possible. to [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
Aug 23 2017, 4:48 AM
bollu updated the diff for D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
  • [Bugfix] add powi to the list of instructions that the NVPTX backend cannot lower.
  • [NFC] remove debug code
Aug 23 2017, 4:47 AM
bollu created D37058: [Polly] [PPCGCodeGeneration] Mild refactoring of checking validity of functions in a kernel..
Aug 23 2017, 4:37 AM
bollu created D37056: [Polly] [PPCGCodeGeneration] Convert intrinsics to libdevice functions whenever possible..
Aug 23 2017, 3:11 AM

Aug 22 2017

bollu committed rL311471: [GPUJIT] Make max managed pointers an environment variable..
[GPUJIT] Make max managed pointers an environment variable.
Aug 22 2017, 10:33 AM
bollu closed D37012: [GPUJIT] Make max managed pointers an environment variable by committing rL311471: [GPUJIT] Make max managed pointers an environment variable..
Aug 22 2017, 10:33 AM
bollu added inline comments to D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 22 2017, 9:36 AM · Restricted Project
bollu added inline comments to D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
Aug 22 2017, 6:46 AM
bollu updated the diff for D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
  • [Diff fix] Upload correct arc diff.
Aug 22 2017, 6:42 AM
bollu added inline comments to D35992: [Polly] [PPCGCodeGeneration] [NFC] [WIP] Add option to fail if a store to a scalar occursin a kernel..
Aug 22 2017, 6:40 AM
bollu created D37012: [GPUJIT] Make max managed pointers an environment variable.
Aug 22 2017, 6:37 AM
bollu updated the diff for D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
  • Use LegacyInlinerBase as the starting point for our inliner pass.
  • Cache inlining results because polyhedral analysis is expensive.
Aug 22 2017, 6:31 AM
bollu committed rL311440: [ManagedMemoryRewrite] Use `unit64_t` to store size, not `int`..
[ManagedMemoryRewrite] Use `unit64_t` to store size, not `int`.
Aug 22 2017, 2:31 AM
bollu committed rL311439: [ManagedMemoryRewrite] Get size in bytes rather than in bits and dividing by 8..
[ManagedMemoryRewrite] Get size in bytes rather than in bits and dividing by 8.
Aug 22 2017, 2:28 AM

Aug 21 2017

bollu committed rL311361: [ManagedMemoryRewrite] slightly tweak debug output style. [NFC].
[ManagedMemoryRewrite] slightly tweak debug output style. [NFC]
Aug 21 2017, 11:59 AM
bollu committed rL311360: [ManagedMemoryRewrite] Print reasons for skipping global array to dbgs(). [NFC].
[ManagedMemoryRewrite] Print reasons for skipping global array to dbgs(). [NFC]
Aug 21 2017, 11:53 AM
bollu committed rL311331: [ManagedMemoryRewrite] hide debug output behing DEBUG(...). [NFC].
[ManagedMemoryRewrite] hide debug output behing DEBUG(...). [NFC]
Aug 21 2017, 5:53 AM
bollu abandoned D35988: [Polly] [WIP] [PPCGCodeGeneration] Failing test case from COSMO.

Test now passes. Probably succeeds due to rL311042

Aug 21 2017, 5:20 AM
bollu abandoned D35486: [Polly] [PPCGCodeGeneration] [WIP] Do not consider writes to killable scalars as scalar stores.

Abandoned because rL311259 contains changes that this patch was supposed to perform.

Aug 21 2017, 5:15 AM
bollu committed rL311329: [ScopInfo] Add option to treat all function parameters as dereferencible..
[ScopInfo] Add option to treat all function parameters as dereferencible.
Aug 21 2017, 4:58 AM
bollu closed D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable by committing rL311329: [ScopInfo] Add option to treat all function parameters as dereferencible..
Aug 21 2017, 4:58 AM
bollu updated the diff for D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.
  • [NFC] fix whitespace and debug print (Fix screwed up diff due to rebase).
Aug 21 2017, 4:51 AM
bollu updated the diff for D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.
  • [NFC] fix whitespace and debug print
Aug 21 2017, 4:49 AM
bollu committed rL311328: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
[PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen.
Aug 21 2017, 4:45 AM
bollu closed D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen. by committing rL311328: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
Aug 21 2017, 4:45 AM
bollu added a comment to D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..

@annanay25 - I believe that was changed by people upstream due to the PostDomTree changes. (specifically, D35851).

Aug 21 2017, 4:43 AM
bollu added a comment to D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.

@grosser - review please.

Aug 21 2017, 4:32 AM
bollu updated the diff for D36461: [Polly] [Fortran Support] [Hack] [WIP] add option to treat function parameters as dereferencable.
  • Update code and add test case.
Aug 21 2017, 4:32 AM
bollu added a comment to D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..

@grosser @philip.pfaffe @Meinersbur @singam-sanjay ping, review please.

Aug 21 2017, 2:28 AM

Aug 20 2017

bollu added a comment to D36939: [Polly] Codegen for simple full function Scops.

Thanks a lot for the patch! I have some stylistic comments to make. However, I do not understand the related codebase well enough, so I'll leave that for the others :).

Aug 20 2017, 4:26 PM
bollu created D36934: [PPCGCodeGeneration] Enable `polly-codegen-perf-monitoring` for PPCGCodegen..
Aug 20 2017, 8:11 AM
bollu committed rL311289: [GPUJIT] Switch from Runtime API calls for managed memory to Driver API calls..
[GPUJIT] Switch from Runtime API calls for managed memory to Driver API calls.
Aug 20 2017, 6:39 AM
bollu closed D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls. by committing rL311289: [GPUJIT] Switch from Runtime API calls for managed memory to Driver API calls..
Aug 20 2017, 6:39 AM
bollu retitled D36921: [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls. from [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls. [NFC] to [Polly] [GPUJIT] [Untested] Switch from Runtime API calls for managed memory to Driver API calls..
Aug 20 2017, 6:34 AM

Aug 19 2017

bollu committed rL311261: [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not….
[ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not…
Aug 19 2017, 1:53 PM
bollu closed D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself. by committing rL311261: [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not….
Aug 19 2017, 1:53 PM
bollu accepted D36929: [GPGPU] Correctly initialize array order and fixed_element information.

Please add the comment I requested for cc->isLatestScalarKind() ? isl_bool_true : isl_bool_false; and the test cases. LGTM.

Aug 19 2017, 1:18 PM · Restricted Project
bollu requested changes to D36929: [GPGPU] Correctly initialize array order and fixed_element information.

It's cool that invariant-load-hoisting-with-failing-scop.ll now succeeds, but that's not the purpose of the test case :)

Aug 19 2017, 12:45 PM · Restricted Project
bollu updated the diff for D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
  • [NFC] reorder statements
Aug 19 2017, 11:01 AM
bollu updated the diff for D36923: [Polly] [ManagedMemoryRewrite] Iterate over operands of the expanded instruction, not the constantexpr itself..
  • [NFC] remove empty line
Aug 19 2017, 11:00 AM