Page MenuHomePhabricator

anna (Anna Thomas)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2016, 11:13 AM (327 w, 20 h)

Recent Activity

Jun 1 2022

anna added a comment to rG993b166debd1: Reapply [SimplifyCFG] Handle branch on same condition in pred more directly.

@nikic, this change caused major degradations to our downstream benchmarks. Basically, in the good case, we used to have selects (which got converted to BLENDVPD instruction). I wonder if there's a reverse transform somewhere when we have branches without profile and change them into selects.

Jun 1 2022, 9:56 AM · Restricted Project, Restricted Project
anna accepted D126777: [SLP]Fix PR55796: insert point for extractelements from different basic blocks..
Jun 1 2022, 8:53 AM · Restricted Project, Restricted Project
anna abandoned D126713: [SLPVectorizer] Fix extractelement insertion point.

Abandoned in favour of D126777.

Jun 1 2022, 7:49 AM · Restricted Project, Restricted Project
anna added a comment to D126777: [SLP]Fix PR55796: insert point for extractelements from different basic blocks..

This patch works for the crashes we saw downstream. Thanks!

Jun 1 2022, 7:42 AM · Restricted Project, Restricted Project

May 31 2022

anna updated the diff for D126713: [SLPVectorizer] Fix extractelement insertion point.

simplified test case

May 31 2022, 2:34 PM · Restricted Project, Restricted Project
anna added a comment to D126713: [SLPVectorizer] Fix extractelement insertion point.

Thanks for the patch.

  1. Would be good to check if it affects the vectorization of the SPECs.

Could you pls elaborate? Unfortunately, I don't know what needs to be done here and I think irrespective of any vectorization "performance issue", we would need to fix the *functional problem*.

May 31 2022, 1:31 PM · Restricted Project, Restricted Project
anna added a comment to D126713: [SLPVectorizer] Fix extractelement insertion point.

JFI: It also requires updating a lot of tests, around 25 in X86 with CHECK lines updated since the insertion point changed. I have not tested the other targets, but there would be others as well.

May 31 2022, 11:46 AM · Restricted Project, Restricted Project
anna updated the summary of D126713: [SLPVectorizer] Fix extractelement insertion point.
May 31 2022, 11:45 AM · Restricted Project, Restricted Project
anna updated the summary of D126713: [SLPVectorizer] Fix extractelement insertion point.
May 31 2022, 11:45 AM · Restricted Project, Restricted Project
anna added a comment to D111574: [SLP]Improve reductions vectorization..

@ABataev, we are getting an assertion failure downstream in setInsertPointAfterBundle which is bisected to this patch and reproducible with it.

May 31 2022, 11:44 AM · Restricted Project, Restricted Project
anna requested review of D126713: [SLPVectorizer] Fix extractelement insertion point.
May 31 2022, 11:42 AM · Restricted Project, Restricted Project

May 30 2022

anna abandoned D124115: [Attributes] Update Attribute::get API to consider zero value for int attributes.

went another path.

May 30 2022, 7:51 AM · Restricted Project, Restricted Project

May 26 2022

anna added a comment to D125690: [MemIntrinsics] Add an API to get elementtype attribute value. NFC..

does using the size parameter not work for your use case? do you specifically need the type?

May 26 2022, 9:39 AM · Restricted Project, Restricted Project

Apr 29 2022

anna committed rG205246cb6435: [CompileTime] [Passes] Avoid computing unnecessary analyses. NFC (authored by anna).
[CompileTime] [Passes] Avoid computing unnecessary analyses. NFC
Apr 29 2022, 7:00 AM · Restricted Project, Restricted Project
anna closed D124529: [CompileTime] [Passes] Avoid computing unnecessary analyses. NFC.
Apr 29 2022, 7:00 AM · Restricted Project, Restricted Project

Apr 28 2022

anna updated the diff for D124529: [CompileTime] [Passes] Avoid computing unnecessary analyses. NFC.

addressed review comments.

Apr 28 2022, 1:54 PM · Restricted Project, Restricted Project
anna added inline comments to D124529: [CompileTime] [Passes] Avoid computing unnecessary analyses. NFC.
Apr 28 2022, 7:01 AM · Restricted Project, Restricted Project

Apr 27 2022

anna closed D123546: Check users of instrinsics instead of traversing entire function..
Apr 27 2022, 8:46 AM · Restricted Project, Restricted Project
anna accepted D123546: Check users of instrinsics instead of traversing entire function..

already landed. closing as done.

Apr 27 2022, 8:45 AM · Restricted Project, Restricted Project
anna added a comment to D124529: [CompileTime] [Passes] Avoid computing unnecessary analyses. NFC.

When tested on a large method from our internal workload, I see about 12% reduction in BranchFrequencyAnalysis (other analyses time also dropped to a lower degree). Overall opt time also dropped about 4%.

Apr 27 2022, 8:14 AM · Restricted Project, Restricted Project
anna requested review of D124529: [CompileTime] [Passes] Avoid computing unnecessary analyses. NFC.
Apr 27 2022, 8:11 AM · Restricted Project, Restricted Project
anna committed rGc515b2f39e77: [IRCE] Avoid computing potentially unnecessary analyses. NFC (authored by anna).
[IRCE] Avoid computing potentially unnecessary analyses. NFC
Apr 27 2022, 6:22 AM · Restricted Project, Restricted Project
anna closed D124478: [IRCE] Avoid computing potentially unnecessary analyses. NFC.
Apr 27 2022, 6:22 AM · Restricted Project, Restricted Project

Apr 26 2022

anna added a comment to D124478: [IRCE] Avoid computing potentially unnecessary analyses. NFC.

thanks for the quick review!

Apr 26 2022, 7:18 PM · Restricted Project, Restricted Project
anna added a reviewer for D124478: [IRCE] Avoid computing potentially unnecessary analyses. NFC: fhahn.
Apr 26 2022, 2:28 PM · Restricted Project, Restricted Project
anna requested review of D124478: [IRCE] Avoid computing potentially unnecessary analyses. NFC.
Apr 26 2022, 2:27 PM · Restricted Project, Restricted Project

Apr 21 2022

anna abandoned D124116: Change Attribute::get to consider 0 value as IntValue.
Apr 21 2022, 11:59 AM · Restricted Project, Restricted Project
anna added a comment to D124115: [Attributes] Update Attribute::get API to consider zero value for int attributes.

The current approach leaves behind a footgun if we start actually using zero values for int attributes (something that we are careful not to do currently).

I'm confused why we cannot have zero values for int attributes? The change here was to specifically allow zero values for any int attribute (because we have a downstream attribute where the value can be zero).
Is this a verifier issue - for example, we cannot have derferenceable_or_null with 0.

I don't think there is a strong technical reason for this restriction, it's just an artifact of the API design. For some int attributes we perform an encode/decode step to translate between a "raw value" (which is never zero) and a semantic value (which can be zero). I do think we should lift this restriction, though I'm not sure if just adjusting this one constructor will be sufficient.

Apr 21 2022, 11:36 AM · Restricted Project, Restricted Project

Apr 20 2022

anna added a comment to D124115: [Attributes] Update Attribute::get API to consider zero value for int attributes.

I would prefer to split this into two overloads, one without the uint64_t argument creating an enum attribute and one with creating always an int attribute, and fix up any problematic uses accordingly. The current approach leaves behind a footgun if we start actually using zero values for int attributes (something that we are careful not to do currently).

Apr 20 2022, 12:38 PM · Restricted Project, Restricted Project
anna updated the summary of D124115: [Attributes] Update Attribute::get API to consider zero value for int attributes.
Apr 20 2022, 12:33 PM · Restricted Project, Restricted Project
anna requested review of D124116: Change Attribute::get to consider 0 value as IntValue.
Apr 20 2022, 12:32 PM · Restricted Project, Restricted Project
anna requested review of D124115: [Attributes] Update Attribute::get API to consider zero value for int attributes.
Apr 20 2022, 12:26 PM · Restricted Project, Restricted Project

Apr 13 2022

anna committed rG28f27dd26417: Check users of instrinsics instead of traversing entire function.NFC (authored by anna).
Check users of instrinsics instead of traversing entire function.NFC
Apr 13 2022, 9:29 AM · Restricted Project, Restricted Project

Apr 11 2022

anna requested review of D123546: Check users of instrinsics instead of traversing entire function..
Apr 11 2022, 1:56 PM · Restricted Project, Restricted Project

Mar 11 2022

anna committed rGa4aa97d57849: [InlineCost] Add cl::opt for target attributes compatibility check. NFC (authored by anna).
[InlineCost] Add cl::opt for target attributes compatibility check. NFC
Mar 11 2022, 3:05 PM · Restricted Project

Feb 24 2022

anna added a comment to D116825: [GVN] MemorySSA for GVN: use MemorySSA for redundant loads elimination.

Do we have any compile time measurements for this change with O3?

Feb 24 2022, 7:29 AM · Restricted Project, Restricted Project

Feb 14 2022

anna accepted D119712: [Safepoint Verifier] gc.relocate does not change the constant property..

LGTM with a comment. Great job on root causing and fixing this!

Feb 14 2022, 6:43 AM · Restricted Project

Feb 2 2022

anna committed rGa73e4ce6a59b: [LoopFuse] Change DT to reference in FusionCandidate struct. NFC (authored by anna).
[LoopFuse] Change DT to reference in FusionCandidate struct. NFC
Feb 2 2022, 11:57 AM

Feb 1 2022

anna committed rGf50821cff048: [LoopFuse] Add assertion for non-null DT in fusion candidate (authored by anna).
[LoopFuse] Add assertion for non-null DT in fusion candidate
Feb 1 2022, 2:00 PM
anna committed rGbc48a2665547: [LoopPeel] Use reference instead of pointer for DT argument (authored by anna).
[LoopPeel] Use reference instead of pointer for DT argument
Feb 1 2022, 2:00 PM
anna added inline comments to D118472: [LoopPeel] Check for non-LCSSA form loops.
Feb 1 2022, 1:17 PM · Restricted Project
anna committed rG4fc52db11603: [InstCombine] Remove weaker fence adjacent to a stronger fence (authored by anna).
[InstCombine] Remove weaker fence adjacent to a stronger fence
Feb 1 2022, 11:06 AM
anna closed D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.
Feb 1 2022, 11:06 AM · Restricted Project
anna added a comment to D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.

I spend sometime trying to see if the failing premerge tests seem related or maybe false positives, but I have no idea where these are from. Also, other completed unrelated review show the same failures: https://reviews.llvm.org/D94928

Feb 1 2022, 8:12 AM · Restricted Project

Jan 31 2022

anna added inline comments to D118472: [LoopPeel] Check for non-LCSSA form loops.
Jan 31 2022, 2:05 PM · Restricted Project
anna updated the diff for D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.

support system and singlethread syncscopes. Added test for target-dependent syncscope to showcase need for isIdenticalTo check.

Jan 31 2022, 1:04 PM · Restricted Project
anna added inline comments to D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.
Jan 31 2022, 12:12 PM · Restricted Project
anna added inline comments to D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.
Jan 31 2022, 12:08 PM · Restricted Project
anna updated the diff for D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.

addressed review comments. Added extra tests.

Jan 31 2022, 11:38 AM · Restricted Project
anna planned changes to D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.

fix based on Philip's comments about scopes.

Jan 31 2022, 10:31 AM · Restricted Project
anna requested review of D118607: [InstCombine] Remove weaker fence adjacent to a stronger fence.
Jan 31 2022, 7:28 AM · Restricted Project

Jan 28 2022

anna abandoned D56449: [UnrollRuntime] Support multi-exiting blocks to LatchExit.
Jan 28 2022, 7:53 AM · Restricted Project
anna abandoned D114648: [InstCombine] Sink noaliasing calls that can have side-effects.

already handled as needed.

Jan 28 2022, 7:53 AM · Restricted Project
anna requested review of D118472: [LoopPeel] Check for non-LCSSA form loops.
Jan 28 2022, 7:36 AM · Restricted Project

Jan 18 2022

anna resigned from D114423: [VP] Propagate align parameter attr on VP gather/scatter to ISel.

Looks like the comments have been addressed regarding the split. Thank you! Moving myself out of blocking state.

Jan 18 2022, 9:00 AM · Restricted Project

Jan 11 2022

anna abandoned D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

At this point, everything necessary is landed upstream through the different approach. See linked patches from Philip.

Jan 11 2022, 7:56 AM · Restricted Project

Jan 5 2022

anna added a comment to rG4d58d1d5af31: DWARFVerifier: Print the CU name and CU count to help visualize progress.

There are 14 test failures in trunk, which disappear once this change is reverted. I wonder why the Buildbot didn't catch it.
Here's 13 of them with the .yaml extension:

Failed Tests (13):
  LLVM :: tools/llvm-dwarfdump/X86/verify_curanges_incomplete.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_die_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_cu_ref.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_die_range.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_ref_addr.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_ref_addr_between.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_rnglists.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_stmt_list.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_strp.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_lexical_block_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_overlapping_function_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_overlapping_lexical_block_ranges.yaml

Once the change is reverted, these tests pass. @dblaikie could you pls fix? It just needs testcase updates to add the Verifying unit: line (at least for the few I manually checked).

Are you testing with current HEAD? A bunch of these were fixed in a follow-up commit 09f43c107fc7688639346d3beead72472cdadbdb

Jan 5 2022, 12:10 PM
anna added a comment to rG4d58d1d5af31: DWARFVerifier: Print the CU name and CU count to help visualize progress.

There are 14 test failures in trunk, which disappear once this change is reverted. I wonder why the Buildbot didn't catch it.
Here's 13 of them with the .yaml extension:

Failed Tests (13):
  LLVM :: tools/llvm-dwarfdump/X86/verify_curanges_incomplete.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_die_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_cu_ref.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_die_range.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_ref_addr.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_ref_addr_between.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_rnglists.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_stmt_list.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_invalid_strp.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_lexical_block_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_overlapping_function_ranges.yaml
  LLVM :: tools/llvm-dwarfdump/X86/verify_overlapping_lexical_block_ranges.yaml
Jan 5 2022, 8:59 AM

Jan 4 2022

anna added a comment to D116322: [Analysis] allow caller to choose signed/unsigned when computing constant range.

@spatel: inline comment added about incorrect arguments for one of the callsites. Pls fix.

Jan 4 2022, 7:16 AM · Restricted Project

Jan 2 2022

anna added inline comments to D116200: [instcombine] Allow sinking of calls with known writes to uses.
Jan 2 2022, 6:24 PM · Restricted Project

Dec 16 2021

anna accepted D115898: Allow calls with known writes when trying to remove allocas [part 2].

Good catch!

Dec 16 2021, 12:53 PM · Restricted Project
anna accepted D115829: Allow calls with known writes when trying to remove allocas.

LGTM

Dec 16 2021, 10:00 AM · Restricted Project
anna added inline comments to D115829: Allow calls with known writes when trying to remove allocas.
Dec 16 2021, 7:33 AM · Restricted Project

Dec 13 2021

anna added a comment to D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

I see that you've added the writeonly argument handling to this patch. I would prefer to split that off into a separate one, because it's not directly related. Even if it means that this lands without any upstream test changes at first.

I don't think we generally do this. I will need to add either the allocations or the paramcase soon-ish after this. But I see your point (since the change as-is does not affect any upstream code). Will wait if @reames has any concerns.

Dec 13 2021, 10:41 AM · Restricted Project

Dec 9 2021

anna added a comment to D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

Note that this is a rewrite of original patch to handle sinking of function call with outparam(s). I have also added allocation test cases to show that these are not affected by the patch.

Dec 9 2021, 7:08 AM · Restricted Project
anna updated the diff for D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

rewrote for outparam usecase in simplest form

Dec 9 2021, 7:06 AM · Restricted Project
anna added a comment to D115161: [IR] Allow the 'align' param attr on vectors of pointers.

Change LGTM. @jdoerfert any additional comments?

Dec 9 2021, 6:39 AM · Restricted Project
anna accepted D115362: Compute estimated trip counts for multiple exit loops.

LGTM.

Nice find! This is obviously a good thing to do for unrolling. Any ideas why there's no vectorization test cases to update since we do support multi-exit vectorization?

Well, purely because I didn't write one. The unrolling test change didn't exist either before I wrote the one showing a diff this morning. Note that even that one requires a non-default flag value to show up.

I don't think the change in vectorization is likely to be interesting, and crafting a test will be tedious. Do you want me to bother?

Dec 9 2021, 6:35 AM · Restricted Project

Dec 8 2021

anna committed rG1225c8a06103: Update sink instruction testcase (authored by anna).
Update sink instruction testcase
Dec 8 2021, 1:54 PM
anna added a comment to D115362: Compute estimated trip counts for multiple exit loops.

Nice find! This is obviously a good thing to do for unrolling. Any ideas why there's no vectorization test cases to update since we do support multi-exit vectorization?

Dec 8 2021, 1:10 PM · Restricted Project
anna committed rG287fa2e16432: Update with additional tests for sinking calls to uses (authored by anna).
Update with additional tests for sinking calls to uses
Dec 8 2021, 1:01 PM

Dec 7 2021

anna added inline comments to D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.
Dec 7 2021, 7:27 AM · Restricted Project

Dec 6 2021

anna requested changes to D114423: [VP] Propagate align parameter attr on VP gather/scatter to ISel.

Actually looking at the patch again, you're mixing two concepts here:

  1. fixing the LangRef and Attributes.cpp for align attribute on vector of pointers should be done as an independent patch. It is orthogonal to the SelectionDAGBuilder code and avoids the false dependency created by the parent patch linked to this patch.
  2. ABI intrinsics and SelectionDAG builder changes can depend on the parent patch.
Dec 6 2021, 7:08 AM · Restricted Project
anna added a comment to D114423: [VP] Propagate align parameter attr on VP gather/scatter to ISel.

Aha I just found D87304 - maybe @jdoerfert @fhahn @anna @dantrushin would be interested in this patch.

Dec 6 2021, 7:02 AM · Restricted Project

Dec 3 2021

anna committed rG72750f00121e: [TrivialDeadness] Introduce API separating two different usages (authored by anna).
[TrivialDeadness] Introduce API separating two different usages
Dec 3 2021, 7:10 AM
anna closed D114647: [TrivialDeadness] Introduce API separating two different usages.
Dec 3 2021, 7:10 AM · Restricted Project
anna added a comment to D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

Thinking about it a bit, I think there are some interesting cases where we can sink something with an analyzeable side effect. An example I came up with is a large function with out-params which are unused in the caller.

Thanks Philip. This is a definitely interesting example worth handling. Let me update the code to consider this use case and precommit some of the tests. The use case we have downstream (as mentioned is object.hashCode), but this example makes a good usecase for upstream IMO.

Dec 3 2021, 6:23 AM · Restricted Project

Dec 1 2021

anna added a comment to D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

Do you have a use case for this apart from sinking allocations? If not, I would recommend restricting this to allocations only, because the generalized reasoning seems pretty subtle to me, and I'm not sure in which cases (apart from allocations) it would help.

Dec 1 2021, 12:29 PM · Restricted Project
anna updated the diff for D114647: [TrivialDeadness] Introduce API separating two different usages.

updated to correct diff.

Dec 1 2021, 11:11 AM · Restricted Project
anna updated the diff for D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

rebased

Dec 1 2021, 11:10 AM · Restricted Project
anna updated the diff for D114647: [TrivialDeadness] Introduce API separating two different usages.

rebased

Dec 1 2021, 11:09 AM · Restricted Project
anna updated the diff for D114647: [TrivialDeadness] Introduce API separating two different usages.

addressed review comments

Dec 1 2021, 11:05 AM · Restricted Project
anna added inline comments to D114647: [TrivialDeadness] Introduce API separating two different usages.
Dec 1 2021, 10:53 AM · Restricted Project

Nov 26 2021

anna requested review of D114648: [InstCombine] Sink noaliasing calls that can have side-effects.
Nov 26 2021, 9:52 AM · Restricted Project
anna updated the diff for D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead.

separated out API

Nov 26 2021, 9:49 AM · Restricted Project
anna requested review of D114647: [TrivialDeadness] Introduce API separating two different usages.
Nov 26 2021, 9:36 AM · Restricted Project

Nov 23 2021

anna added a comment to D113939: [runtime-unroll] Remove restriction about unrolling multiple exit loops.

This change looks good to me and thank you for taking this through!

Nov 23 2021, 7:02 AM · Restricted Project, Restricted Project
anna edited reviewers for D113939: [runtime-unroll] Remove restriction about unrolling multiple exit loops, added: anna; removed: annatom.
Nov 23 2021, 6:47 AM · Restricted Project, Restricted Project

Oct 19 2021

anna committed rG9403514e7649: [LoopPredication] Calculate profitability without BPI (authored by anna).
[LoopPredication] Calculate profitability without BPI
Oct 19 2021, 11:25 AM
anna closed D111668: [LoopPredication] Calculate profitability without BPI.
Oct 19 2021, 11:25 AM · Restricted Project
anna updated the diff for D111668: [LoopPredication] Calculate profitability without BPI.

addressed review comment about naming. Updated a comment in the testcase to parse better.

Oct 19 2021, 6:04 AM · Restricted Project
anna added a comment to D111668: [LoopPredication] Calculate profitability without BPI.

Looks reasonable, assuming you're seeing similar results to using BPI. I'm not very familiar with BPI itself, so if others reviewers are, I'll let them chime in.

Does it make sense to make isValidProfileData and ComputeBranchProbability static utilities in BranchProbability? (nit: consistent case-ing on the names)

I think that's a good idea. Will do as a follow-up after landing patch.

Oct 19 2021, 5:46 AM · Restricted Project
anna added inline comments to D111668: [LoopPredication] Calculate profitability without BPI.
Oct 19 2021, 5:43 AM · Restricted Project

Oct 15 2021

anna added a comment to D111668: [LoopPredication] Calculate profitability without BPI.

ping

Oct 15 2021, 8:39 AM · Restricted Project
anna updated the diff for D111668: [LoopPredication] Calculate profitability without BPI.

minor changes in naming, clang format. NFC w.r.t. previous version.

Oct 15 2021, 8:39 AM · Restricted Project

Oct 12 2021

anna requested review of D111668: [LoopPredication] Calculate profitability without BPI.
Oct 12 2021, 12:13 PM · Restricted Project

Oct 8 2021

anna added a reviewer for D111448: [BPI] Handle incomplete state in BPI: kazu.
Oct 8 2021, 11:44 AM · Restricted Project
anna added a comment to D111448: [BPI] Handle incomplete state in BPI.

I'm confused how the intermittent assert occurs. Is the compilation non-deterministic?

Oct 8 2021, 11:35 AM · Restricted Project
anna requested review of D111448: [BPI] Handle incomplete state in BPI.
Oct 8 2021, 11:05 AM · Restricted Project

Oct 1 2021

anna committed rGf98a918d3495: [TrivialDeadness] Update function comment (authored by anna).
[TrivialDeadness] Update function comment
Oct 1 2021, 9:09 AM