Page MenuHomePhabricator

anna (Anna Thomas)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2016, 11:13 AM (209 w, 6 d)

Recent Activity

Yesterday

anna added a comment to D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.

ping.

Mon, Apr 6, 9:11 AM · Restricted Project

Sun, Apr 5

anna committed rG1d0f75790491: [InlineFunction] Update metadata on loads that are return values (authored by anna).
[InlineFunction] Update metadata on loads that are return values
Sun, Apr 5, 12:17 PM
anna closed D76792: [InlineFunction] Update metadata on loads that are return values.
Sun, Apr 5, 12:17 PM · Restricted Project

Thu, Apr 2

anna committed rGbf7a16a76871: [InlineFunction] Update valid return attributes at callsite within callee body (authored by anna).
[InlineFunction] Update valid return attributes at callsite within callee body
Thu, Apr 2, 11:24 AM
anna closed D76140: [InlineFunction] update attributes during inlining.
Thu, Apr 2, 11:23 AM · Restricted Project, Restricted Project
anna added a comment to D76792: [InlineFunction] Update metadata on loads that are return values.

thanks for the review @jdoerfert . Will incorporate these changes and rebase on landed D76140.

Thu, Apr 2, 11:22 AM · Restricted Project
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

LGTM again, with minor change.

will update it.

p.s. Sorry for missing the functional issue the first time. All of the test changes should have made the issue obvious, but despite reading the LangRef description of signext, I somehow managed to miss the separation between ABI and optimization attributes.

thanks for the review Philip and pointing out the problem. All of us had missed the functional issue the first time around.

Thu, Apr 2, 10:17 AM · Restricted Project, Restricted Project

Wed, Apr 1

anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

fixed missing code left out during rebase.

Wed, Apr 1, 9:01 AM · Restricted Project, Restricted Project
anna requested review of D76140: [InlineFunction] update attributes during inlining.

fixed buildbot failure. see above comments and added testcase test8.

Wed, Apr 1, 8:27 AM · Restricted Project, Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

whitelist valid return attributes and only add those. Added testcase for signext.

Wed, Apr 1, 8:27 AM · Restricted Project, Restricted Project

Tue, Mar 31

anna added inline comments to D76140: [InlineFunction] update attributes during inlining.
Tue, Mar 31, 2:17 PM · Restricted Project, Restricted Project
anna added a comment to D44429: [BinaryFormat] MessagePack reader/writer.

Hi,

It looks like there's some UB in this code. Pls see this failure: https://reviews.llvm.org/D76140#1953201
I'm not sure how to go about fixing the MsgPackReader code.
@scott.linder Could you PTAL?

Tue, Mar 31, 2:17 PM
anna planned changes to D76140: [InlineFunction] update attributes during inlining.

see above comment.

Tue, Mar 31, 2:17 PM · Restricted Project, Restricted Project
anna reopened D76140: [InlineFunction] update attributes during inlining.

I got a failure in one of the binaryFormats:
lib/BinaryFormat/CMakeFiles/LLVMBinaryFormat.dir/MsgPackReader.cpp

Attributes 'zeroext and signext' are incompatible!
  %rev.i.i.i.i.i.i.i.i = tail call signext zeroext i16 @llvm.bswap.i16(i16 %ret.0.copyload.i.i.i.i) #6
in function _ZN4llvm7msgpack6Reader7readIntIsEENS_8ExpectedIbEERNS0_6ObjectE
fatal error: error in backend: Broken function found, compilation aborted!

I believe this just showcases undefined behaviour since we were having a returnValue (i.e. call) with an incomptable attribute compared to the return attribute on the callsite.

Tue, Mar 31, 2:17 PM · Restricted Project, Restricted Project
anna committed rG58a05675daf4: Revert "[InlineFunction] Handle return attributes on call within inlined body" (authored by anna).
Revert "[InlineFunction] Handle return attributes on call within inlined body"
Tue, Mar 31, 1:47 PM
anna added a reverting change for rG28518d9ae39f: [InlineFunction] Handle return attributes on call within inlined body: rG58a05675daf4: Revert "[InlineFunction] Handle return attributes on call within inlined body".
Tue, Mar 31, 1:47 PM
anna added a comment to D44429: [BinaryFormat] MessagePack reader/writer.

It looks like there's some UB in this code. Pls see this failure: https://reviews.llvm.org/D76140#1953201
I'm not sure how to go about fixing the MsgPackReader code.
@scott.linder Could you PTAL?

Tue, Mar 31, 1:07 PM
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

I got a failure in one of the binaryFormats:
lib/BinaryFormat/CMakeFiles/LLVMBinaryFormat.dir/MsgPackReader.cpp

Attributes 'zeroext and signext' are incompatible!
  %rev.i.i.i.i.i.i.i.i = tail call signext zeroext i16 @llvm.bswap.i16(i16 %ret.0.copyload.i.i.i.i) #6
in function _ZN4llvm7msgpack6Reader7readIntIsEENS_8ExpectedIbEERNS0_6ObjectE
fatal error: error in backend: Broken function found, compilation aborted!
Tue, Mar 31, 1:07 PM · Restricted Project, Restricted Project
anna committed rG28518d9ae39f: [InlineFunction] Handle return attributes on call within inlined body (authored by anna).
[InlineFunction] Handle return attributes on call within inlined body
Tue, Mar 31, 12:00 PM
anna closed D76140: [InlineFunction] update attributes during inlining.
Tue, Mar 31, 11:59 AM · Restricted Project, Restricted Project

Mon, Mar 30

anna added inline comments to D76140: [InlineFunction] update attributes during inlining.
Mon, Mar 30, 3:16 PM · Restricted Project, Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

addressed review comments. Added two test cases: deref value being different, inlined callee body better optimized compared to callee.

Mon, Mar 30, 2:44 PM · Restricted Project, Restricted Project
anna added inline comments to D76140: [InlineFunction] update attributes during inlining.
Mon, Mar 30, 11:56 AM · Restricted Project, Restricted Project

Thu, Mar 26

anna updated the diff for D76792: [InlineFunction] Update metadata on loads that are return values.

addressed review comments

Thu, Mar 26, 1:39 PM · Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

NFC w.r.t prev diff. Use VMap.lookup instead of a lambda which does the same.

Thu, Mar 26, 9:11 AM · Restricted Project, Restricted Project
anna added inline comments to D76792: [InlineFunction] Update metadata on loads that are return values.
Thu, Mar 26, 6:28 AM · Restricted Project

Wed, Mar 25

anna added a parent revision for D76792: [InlineFunction] Update metadata on loads that are return values: D76140: [InlineFunction] update attributes during inlining.
Wed, Mar 25, 11:53 AM · Restricted Project
anna added a child revision for D76140: [InlineFunction] update attributes during inlining: D76792: [InlineFunction] Update metadata on loads that are return values.
Wed, Mar 25, 11:53 AM · Restricted Project, Restricted Project
anna created D76792: [InlineFunction] Update metadata on loads that are return values.
Wed, Mar 25, 11:53 AM · Restricted Project
anna added reviewers for D76792: [InlineFunction] Update metadata on loads that are return values: reames, jdoerfert, apilipenko.
Wed, Mar 25, 11:53 AM · Restricted Project
anna added a comment to D63525: LangRef: Attempt to formulate some rules for addrspacecast.

Just chiming in here. We are planning to use addrspacecast for pointer width conversion (32 to 64 bit and vice-versa). Does not change the memory in anyway, i.e. if we lowered the addrspacecast into an IR call, that call could be marked argmemonly readnone. However, it is *not* a simple sign-extend/truncate either.
I've added some comments inline. Also, I think we have the scope to improve optimizations for addrspacecast at IR level, which is currently limited because different targets have varying lowering for addrspacecast.

Wed, Mar 25, 11:21 AM
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

ping.

Wed, Mar 25, 6:27 AM · Restricted Project, Restricted Project

Mon, Mar 23

anna added inline comments to D76140: [InlineFunction] update attributes during inlining.
Mon, Mar 23, 7:03 AM · Restricted Project, Restricted Project

Sun, Mar 22

anna added inline comments to D76140: [InlineFunction] update attributes during inlining.
Sun, Mar 22, 11:13 AM · Restricted Project, Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

Noticed while adding couple more tests, there were 2 bugs:

Sun, Mar 22, 11:12 AM · Restricted Project, Restricted Project
anna added inline comments to D76140: [InlineFunction] update attributes during inlining.
Sun, Mar 22, 9:36 AM · Restricted Project, Restricted Project

Fri, Mar 20

anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

use isGuaranteedToTransferExecutionToSuccessor instead of MayThrow

Fri, Mar 20, 5:23 AM · Restricted Project, Restricted Project
Herald added a reviewer for D76140: [InlineFunction] update attributes during inlining: aartbik.
Fri, Mar 20, 4:51 AM · Restricted Project, Restricted Project

Thu, Mar 19

anna updated the diff for D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.

refactored code, made asserts cleaner.

Thu, Mar 19, 1:09 PM · Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

fixed clang tests. rot-intrinsics.c testcase has 5 different RUNs with 3 prefixes. Depending on target-triple, the attribute is added to the caller, so I've disabled the optimization for that specific test with -update-return-attrs=false

Thu, Mar 19, 12:36 PM · Restricted Project, Restricted Project
anna added inline comments to D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.
Thu, Mar 19, 8:04 AM · Restricted Project
anna planned changes to D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.

Will avoid confusing usage with cleaner asserts.

Thu, Mar 19, 8:04 AM · Restricted Project
anna updated the diff for D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.

addressed review comments. fixed CI failure related to clang-tidy.

Thu, Mar 19, 6:59 AM · Restricted Project
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

the test failures are related to attributes now being added to the calls in clang tests. All of these tests are using llvm intrinsics. Should we just disable this for intrinsic calls for now? Not sure how to update clang tests in the same patch as llvm project. Should be doable though.

Er, git is monorepo. Those tests should be checked out alongside your LLVM copy. You just need to build clang. You can and should simply update the tests in the same patch.

ah yes, I'd build llvm within it's own subdir without enabling any other projects. Build worked. thanks.

Thu, Mar 19, 6:26 AM · Restricted Project, Restricted Project

Tue, Mar 17

anna added a comment to D76140: [InlineFunction] update attributes during inlining.

the test failures are related to attributes now being added to the calls in clang tests. All of these tests are using llvm intrinsics. Should we just disable this for intrinsic calls for now? Not sure how to update clang tests in the same patch as llvm project. Should be doable though.

Tue, Mar 17, 4:46 PM · Restricted Project, Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

addressed review comments. The analysis is conservative and test cases added show the negative cases where we should not backward propagate the attribute to the call (i.e. return value operand).

Tue, Mar 17, 2:35 PM · Restricted Project, Restricted Project
anna updated the diff for D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.

fixed clang format. NFC w.r.t. prev diff.

Tue, Mar 17, 12:56 PM · Restricted Project
anna created D76305: [RS4GC] Fix algorithm to avoid setting vector BDV for scalar derived pointer.
Tue, Mar 17, 11:49 AM · Restricted Project

Mon, Mar 16

anna planned changes to D76140: [InlineFunction] update attributes during inlining.

will update patch and place for review.

Mon, Mar 16, 1:40 PM · Restricted Project, Restricted Project
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

talked with Philip offline. We just need the check for non-trapping instructions between the return value (i.e. the call) and the return instruction. In other cases, it is either correct to propagate the nonnull-ness or it showcased a UB that already existed in the program.

Mon, Mar 16, 1:07 PM · Restricted Project, Restricted Project

Fri, Mar 13

anna added a comment to D76140: [InlineFunction] update attributes during inlining.

Anna, I'd encourage you to go very narrow here. We can resolve the correlated throw case with the following: require operand of return to be call instruction which is less than small constant window of non-trapping instructions before the return. (i.e. start with previous node) If we allow bitcasts, that provides reasonable coverage. We can always fallback to assumes as noted.

We don't need to be hugely general analysis wise to be very useful. Calls in tail positions or loads in analogous are very common. We should handle that obvious case.

Fri, Mar 13, 6:22 PM · Restricted Project, Restricted Project
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

hmm. yes, I can see this getting complicated for design and correctness. Thanks for the example @jdoerfert.

Fri, Mar 13, 2:34 PM · Restricted Project, Restricted Project
anna retitled D76140: [InlineFunction] update attributes during inlining from [InlineFunction] update nonnnull attribute during inlining to [InlineFunction] update attributes during inlining.
Fri, Mar 13, 2:01 PM · Restricted Project, Restricted Project
anna added a comment to D76140: [InlineFunction] update attributes during inlining.

In addition to @reames correctness concerns this is not valid for a different reason. You cannot backwards propagate information in the general case:

__attribute__((nonnull)) int *foo(int c) {
   int *A = unknown();
   int *B = unknown();
   do_sth_with_ptr_and_may_use_nonnull(A, B);
   return c ? A : B; // or if (C) return A; else return B;
}

Knowing foo returns a nonnull value cannot be used to annotate A or B.

Good catch, I'd missed that.

Just noticed this. I think we can special case this to: the return and def call are in the same basic block (it will take care of the if-else in the example) and has only one use which is the return. The latter takes care of avoiding incorrect semantics in that call do_sth_with_ptr_and_may_use_nonnull or any other use that depends on knowing which of the ptr is non-null.

Fri, Mar 13, 2:01 PM · Restricted Project, Restricted Project
anna updated the diff for D76140: [InlineFunction] update attributes during inlining.

addressed review comments. This handles all attributes on the call and only done after the cloning of the inlined body.
Tests added for attributes and making sure the original callee does not have the attributes added within its body.

Fri, Mar 13, 2:01 PM · Restricted Project, Restricted Project
anna created D76140: [InlineFunction] update attributes during inlining.
Fri, Mar 13, 9:39 AM · Restricted Project, Restricted Project

Mar 6 2020

anna committed rG59029b9eef23: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base (authored by anna).
[RS4GC] Handle uses of extractelement for conversion from vector to scalar base
Mar 6 2020, 1:50 PM
anna closed D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.
Mar 6 2020, 1:49 PM · Restricted Project
anna updated the diff for D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.

removed extra line. cleaned up whiitespace. NFC w.r.t. prev diff.

Mar 6 2020, 9:53 AM · Restricted Project
anna updated the diff for D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.

changed to early-return, updated comments and test.

Mar 6 2020, 8:46 AM · Restricted Project
anna added a comment to D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.

LGTM, but what about test failure? Please fix it

Mar 6 2020, 8:13 AM · Restricted Project

Mar 5 2020

anna updated the diff for D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.

fixed dominator error.

Mar 5 2020, 7:07 PM · Restricted Project
anna added inline comments to D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.
Mar 5 2020, 3:21 PM · Restricted Project
anna abandoned D52362: [CloneFunction] Simplify previously unsimplifiable instructions.

abandon revision - too old and context lost.

Mar 5 2020, 12:07 PM · Restricted Project
anna abandoned D50644: [WIP] [LAA] Allow runtime checks when strides different but address space does not wrap around.

abandoning this change - lost context.

Mar 5 2020, 11:33 AM · Restricted Project
anna created D75704: [RS4GC] Handle uses of extractelement for conversion from vector to scalar base.
Mar 5 2020, 11:32 AM · Restricted Project

Dec 4 2019

anna abandoned D57180: [LV] Avoid adding into interleaved group in presence of WAW dependency.
Dec 4 2019, 11:18 AM · Restricted Project
anna added a comment to D57180: [LV] Avoid adding into interleaved group in presence of WAW dependency.

hi, thanks guys. Sorry for the abnormally late response (was on mat leave). Yes, looks like this can be abandoned.

Dec 4 2019, 11:18 AM · Restricted Project

Jan 29 2019

anna added a comment to D57180: [LV] Avoid adding into interleaved group in presence of WAW dependency.

ping

Jan 29 2019, 12:50 PM · Restricted Project

Jan 24 2019

anna created D57180: [LV] Avoid adding into interleaved group in presence of WAW dependency.
Jan 24 2019, 12:29 PM · Restricted Project
anna accepted D57161: [RS4GC] Be slightly less conservative for gep vector_base, scalar_idx.

lgtm.

Jan 24 2019, 8:32 AM
anna added a comment to D57161: [RS4GC] Be slightly less conservative for gep vector_base, scalar_idx.

The scalar indices don't appear to be a problem on a scalar gep, we even had a test for that.

just to note it is not a scalar gep - this is a vector gep which has a scalar index.

Jan 24 2019, 8:30 AM
anna accepted D57138: [RS4GC] Avoid crashing on gep scalar, vector_idx.

LGTM w/ comments.

Jan 24 2019, 7:44 AM

Jan 22 2019

anna planned changes to D56449: [UnrollRuntime] Support multi-exiting blocks to LatchExit.

need to update comments and address review comments. moving out of queue for now.

Jan 22 2019, 5:40 AM

Jan 18 2019

anna accepted D55678: [CVP] Use LVI to constant fold deopt operands.

LGTM!

Jan 18 2019, 4:00 PM

Jan 8 2019

anna created D56449: [UnrollRuntime] Support multi-exiting blocks to LatchExit.
Jan 8 2019, 12:43 PM
anna added a comment to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

thanks for reviewing the change Brian! Will land it soon.

Jan 8 2019, 9:02 AM
anna added a comment to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

This has passed all internal fuzzer runs - the DT verification failure tests have been added as test cases here after reduction.

Jan 8 2019, 8:45 AM
anna updated the diff for D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

we need to update domInfo for exits and those reachable from the exits.

Jan 8 2019, 8:44 AM

Jan 7 2019

anna added a comment to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

I've got a naive question about the DTU: Does the automatic updater handle the ImmediateDominator "automatically" for the remaining nodes in the dom tree once identify that one of the nodes in the DT has a change in IDom?

Exactly. Given a set of CFG updates, if figures out how to change the DomTree and PostDomTree such that they match the CFG.

This will drastically help with #2 because what I have as a local fix using the old DT is something like this:

+   if (DT) {
+    // Check the dom children of each block in loop and if it is outside the
+    // current loop, update it to the preheader.
+    for (auto *BB: L->blocks()) {
+      auto *DomNodeBB = DT->getNode(BB);
+      for (auto *DomChild: DomNodeBB->getChildren()) {
+        if (!L->contains(LI->getLoopFor(DomChild->getBlock()))) {
+          DT->changeImmediateDominator(DomChild, DT->getNode(PreHeader));
+        }    
+      }    
+    }
+   }

This is a more general fix using the old DT to handle the non-immediate successors of an exit block in the loop.

Doesn't this loop have to be run until you reach a fixpoint?

Jan 7 2019, 2:04 PM
anna added a comment to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

the same bug can happen with:

  1. latch exit
  2. non-immediate successors of latchexit/otherexit.

    I have simplified test cases for each of these and we need a more general fix. Working on this.

... these things are extremely bug-prone; I really do suggest using the automatic updater instead of trying to deal with all tricky corner-cases here :)

Jan 7 2019, 1:18 PM
anna planned changes to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

the same bug can happen with:

  1. latch exit
  2. non-immediate successors of latchexit/otherexit.
Jan 7 2019, 12:13 PM

Jan 4 2019

anna updated the diff for D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

The IDom can be any block within the loop (as mentioned in the comment).
So, we need to check for IDom *contained* in the loop.
Added test case shows where the IDom is within the inner loop of the original loop.
Both test cases pass now with the fix.

Jan 4 2019, 10:18 AM

Jan 3 2019

anna added a comment to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

@anna Can this be rewritten to use the DomTreeUpdater utility?

@kuhar, I have not looked at the DTU uttility yet, but I'd think it can be rewritten (unless there are some limitations for the DomTreeUpdater utility). However, that would be a large enough change and I think it's better to do it as a separate change at a later point rather than as part of fixing this bug. Also, there are enough DT updates through out this code that it will take a while to get through the whole process of porting over for runtime unrolling.

Jan 3 2019, 3:14 PM
anna added a comment to D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.

Context and history for runtime unrolling: https://reviews.llvm.org/D35304

Jan 3 2019, 11:53 AM
anna created D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling.
Jan 3 2019, 11:53 AM

Dec 21 2018

anna added inline comments to D55678: [CVP] Use LVI to constant fold deopt operands.
Dec 21 2018, 10:34 AM

Dec 5 2018

anna accepted D54023: [LoopSimplifyCFG] Delete dead in-loop blocks.

LGTM. Thanks for working through the revisions.

Dec 5 2018, 12:20 PM

Dec 4 2018

anna requested changes to D54023: [LoopSimplifyCFG] Delete dead in-loop blocks.

Pls add -verify-memoryssa to the RUN command as well, now that MSSA is getting updated.
Comment inline.

Dec 4 2018, 7:15 AM

Nov 26 2018

anna accepted D54849: [LoopSimplifyCFG] Fix corner case with duplicating successors.

LGTM.

Nov 26 2018, 1:45 PM

Nov 22 2018

anna added a comment to D54023: [LoopSimplifyCFG] Delete dead in-loop blocks.

There's an LCSSA not being preserved bug in the original landed change (@dmgreen added the test case). As part of fixing it, pls add the following options to your RUN command in the test "-verify-loop-info -verify-dom-info -verify-loop-lcssa". This will make sure all forms of verification are checked.

Nov 22 2018, 10:26 AM

Nov 20 2018

anna added inline comments to D54023: [LoopSimplifyCFG] Delete dead in-loop blocks.
Nov 20 2018, 8:34 AM

Nov 19 2018

anna added inline comments to D54538: [LV] Avoid vectorizing unsafe dependencies in uniform address.
Nov 19 2018, 7:17 AM

Nov 16 2018

anna accepted D54021: [LoopSimplifyCFG] Teach LoopSimplifyCFG to constant-fold branches and switches.

LGTM. Thanks for working through the comments.

Nov 16 2018, 9:27 AM

Nov 15 2018

anna added inline comments to D54538: [LV] Avoid vectorizing unsafe dependencies in uniform address.
Nov 15 2018, 8:01 AM
anna updated the diff for D54538: [LV] Avoid vectorizing unsafe dependencies in uniform address.

addressed review comments

Nov 15 2018, 7:59 AM
anna planned changes to D54538: [LV] Avoid vectorizing unsafe dependencies in uniform address.

based on above comments.

Nov 15 2018, 6:50 AM
anna added inline comments to D54538: [LV] Avoid vectorizing unsafe dependencies in uniform address.
Nov 15 2018, 6:32 AM

Nov 14 2018

anna created D54538: [LV] Avoid vectorizing unsafe dependencies in uniform address.
Nov 14 2018, 12:43 PM
anna requested changes to D54021: [LoopSimplifyCFG] Teach LoopSimplifyCFG to constant-fold branches and switches.

Forgot to mark request changes. See previous inline comments.

Nov 14 2018, 6:49 AM