Page MenuHomePhabricator

HazardyKnusperkeks (Björn Schäpers)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2020, 2:35 AM (15 w, 4 d)

Recent Activity

Yesterday

HazardyKnusperkeks added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Do you need someone to push it?

Yes, I need someone to do that. I don't have write permissions. I'm new here.

Sun, Feb 28, 3:48 AM · Restricted Project, Restricted Project

Sat, Feb 27

HazardyKnusperkeks updated the diff for D96896: [clang-format] Respect spaces in line comment section without an active column limit.
  • Work with ::max instead of many checks for == 0.
  • Additional Testcase
Sat, Feb 27, 2:25 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Is this acceptable to the others? Do you need someone to push it?

Sat, Feb 27, 2:00 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Do you need someone to push this?

Sat, Feb 27, 1:59 PM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rGe0b1df924ae0: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers (authored by darwin).
[clang-format] Fix AlignConsecutiveDeclarations handling of pointers
Sat, Feb 27, 1:57 PM
HazardyKnusperkeks closed D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.
Sat, Feb 27, 1:57 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D96760: [clang-format] Suppress diagnostics on second parse.

Ping.

Sat, Feb 27, 1:39 PM · Restricted Project, Restricted Project

Thu, Feb 25

HazardyKnusperkeks added a comment to D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.

Hi guys, thanks for accepting the change. But I don't have commit access of LLVM. Can someone commit it for me?

Thu, Feb 25, 1:40 AM · Restricted Project, Restricted Project

Tue, Feb 23

HazardyKnusperkeks accepted D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.

You should mark comments as done, if they are.

Does your modification maybe add something to the alignment which is not a declaration?

int a;
double b;
a * b;

How is that formatted? Yeah unlikely that something like that is in code, but it could be if operator* has side effects and one does not need the result.

Good question.

I've tested the original code and the modified code, both will generate the same result:

int    a;
double b;
a*     b;

I understand the expected format should be:

int    a;
double b;
a* b;

Maybe we can register another bug to track it.

Tue, Feb 23, 8:42 AM · Restricted Project, Restricted Project

Mon, Feb 22

HazardyKnusperkeks added a comment to D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.

You should mark comments as done, if they are.

Mon, Feb 22, 12:01 PM · Restricted Project, Restricted Project

Sun, Feb 21

HazardyKnusperkeks added a comment to D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers.

Just out of curiosity, in which language is Const used?

Sun, Feb 21, 12:43 PM · Restricted Project, Restricted Project

Fri, Feb 19

HazardyKnusperkeks added a comment to D95017: [clang-format] Add case aware include sorting..

Do you have an idea for better names?
I see that e.g. MS documentation uses ascending order and case-sensitive order.

I'm okay with the names, it just seems to me that they are reversed, where CaseSensitive should sort using ASCIIbetic order, and CaseInsensitive should ignore case entirely in the same way that most case-insensitive string compares would.

Fri, Feb 19, 10:56 AM · Restricted Project, Restricted Project

Thu, Feb 18

HazardyKnusperkeks planned changes to D96896: [clang-format] Respect spaces in line comment section without an active column limit.
Thu, Feb 18, 11:17 AM · Restricted Project, Restricted Project

Wed, Feb 17

HazardyKnusperkeks requested review of D96896: [clang-format] Respect spaces in line comment section without an active column limit.
Wed, Feb 17, 1:20 PM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D96760: [clang-format] Suppress diagnostics on second parse.

Added DiagHandlerCtxt.

Wed, Feb 17, 1:15 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D96760: [clang-format] Suppress diagnostics on second parse.

I did have another plan for a different way to go about this, not sure if its really any better though.
It involved building a vector of the edits the config would apply to its parent. Then after the parent is parsed just applying those edits.
It results in only 1 pass over the config file however it's a little more involved to get it to work.

Wed, Feb 17, 11:08 AM · Restricted Project, Restricted Project

Tue, Feb 16

HazardyKnusperkeks added inline comments to D96760: [clang-format] Suppress diagnostics on second parse.
Tue, Feb 16, 1:27 AM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D96760: [clang-format] Suppress diagnostics on second parse.
Tue, Feb 16, 1:19 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix.
Tue, Feb 16, 12:02 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Feb 14

HazardyKnusperkeks committed rG25f753c51e7b: [clang-format] Add possibility to be based on parent directory (authored by HazardyKnusperkeks).
[clang-format] Add possibility to be based on parent directory
Sun, Feb 14, 10:56 AM
HazardyKnusperkeks closed D93844: [clang-format] Add possibility to be based on parent directory.
Sun, Feb 14, 10:56 AM · Restricted Project, Restricted Project

Fri, Feb 12

HazardyKnusperkeks accepted D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Although I would put it in one test, this is fine by me.

Fri, Feb 12, 4:54 AM · Restricted Project, Restricted Project

Wed, Feb 10

HazardyKnusperkeks accepted D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Wed, Feb 10, 12:53 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Wed, Feb 10, 12:51 PM · Restricted Project, Restricted Project
HazardyKnusperkeks requested changes to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Have you rebased your change? It seems that your release notes are still for LLVM 12.

Wed, Feb 10, 1:07 AM · Restricted Project, Restricted Project

Tue, Feb 9

HazardyKnusperkeks added a comment to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!)

Tue, Feb 9, 12:50 PM · Restricted Project, Restricted Project

Tue, Feb 2

HazardyKnusperkeks updated the diff for D93844: [clang-format] Add possibility to be based on parent directory.

Silence unused variable warnings in release and using llvm::reverse with range based for.

Tue, Feb 2, 12:42 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

As a follow up it may be wise to pass a diag handler to parseConfiguration as when we parse it a second time, we probably want to disregard any warnings (like unknown key) detected as they will have been printed on the first pass.

Tue, Feb 2, 12:40 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

You need to supply a full diff (with context).
Please also add it to the release notes.

Tue, Feb 2, 11:50 AM · Restricted Project, Restricted Project

Mon, Feb 1

HazardyKnusperkeks updated the diff for D93844: [clang-format] Add possibility to be based on parent directory.

Fixed documentation (and rebased).

Mon, Feb 1, 1:50 PM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rG772eb24e0062: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks).
[clang-format] Add option to control the spaces in a line comment
Mon, Feb 1, 1:49 PM
HazardyKnusperkeks closed D92257: [clang-format] Add option to control the space at the front of a line comment.
Mon, Feb 1, 1:49 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D93844: [clang-format] Add possibility to be based on parent directory.
Mon, Feb 1, 1:38 PM · Restricted Project, Restricted Project

Sun, Jan 31

HazardyKnusperkeks added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

I have a script that runs clang-format -n on various directories in clang
that are clang format clean, polly is one of them because they have clang
format as a unit test

I use this to ensure I don’t regress behaviour

Maybe we should formalise this with some sort of clang-format-check cmake
rule

Mydeveloperday

Sun, Jan 31, 8:01 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D69764: [clang-format] Add East/West Const fixer capability.

What can be done to move this change along?

I feel there has to be a fundamental acceptance that it is ok for clang-format to alter code (something it already does with sorting of includes, namespace comments).

There were fairly strong opinions that clang-format isn't the best tool to do this (which actually I don't agree with, I think it is, as long as those capabilities are off by default and there is an acceptance they won't be perfect especially in the presence of macros due to lack of AST)

My only thought about building another tool would be if it was a drop in replacement for clang-format (tooling allows setting of a path), but it would need to inherit all of clang-format.

but to me, this just feels like extra grunt work just to work around why some community don't like it.

I guess a consensus is hard to come by, but I don't really know who owns the decision around the future direction of clang-format.

Sun, Jan 31, 8:00 AM · Restricted Project, Restricted Project

Jan 30 2021

HazardyKnusperkeks added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

LGTM. Could you please give us a link to the failing test in Polly? May be GitHub or buildbot.

Jan 30 2021, 2:04 AM · Restricted Project, Restricted Project

Jan 29 2021

HazardyKnusperkeks reopened D92257: [clang-format] Add option to control the space at the front of a line comment.
Jan 29 2021, 1:06 PM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D92257: [clang-format] Add option to control the space at the front of a line comment.

The previous one broke a (format) test in polly. This lead me to change the one breaking behavior, no it is not breaking anymore.
A comment starting with } will only be indented if it is in a comment section which will get an indention. Test case is adapted.

Jan 29 2021, 1:06 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a reverting change for rG078f30e04d1f: [clang-format] Add option to control the spaces in a line comment: rG4ad41f1daf0f: Revert "[clang-format] Add option to control the spaces in a line comment".
Jan 29 2021, 12:32 AM
HazardyKnusperkeks committed rG4ad41f1daf0f: Revert "[clang-format] Add option to control the spaces in a line comment" (authored by HazardyKnusperkeks).
Revert "[clang-format] Add option to control the spaces in a line comment"
Jan 29 2021, 12:31 AM
HazardyKnusperkeks added a reverting change for D92257: [clang-format] Add option to control the space at the front of a line comment: rG4ad41f1daf0f: Revert "[clang-format] Add option to control the spaces in a line comment".
Jan 29 2021, 12:31 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D95128: [clang-format] [NFC] Remove unused arguments.

I did add the commit here, but I can give you the hash explicitly: 9aa38a0615119a7a9f3bee33a2b8915c45f1cab9

Jan 29 2021, 12:02 AM · Restricted Project, Restricted Project

Jan 28 2021

HazardyKnusperkeks updated the diff for D93844: [clang-format] Add possibility to be based on parent directory.

Rebased and Ping.

Jan 28 2021, 11:33 PM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rG078f30e04d1f: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks).
[clang-format] Add option to control the spaces in a line comment
Jan 28 2021, 10:00 PM
HazardyKnusperkeks closed D92257: [clang-format] Add option to control the space at the front of a line comment.
Jan 28 2021, 10:00 PM · Restricted Project, Restricted Project
HazardyKnusperkeks closed D95128: [clang-format] [NFC] Remove unused arguments.

Commited but forgot the Differential Link in the Message.

Jan 28 2021, 9:53 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 28 2021, 12:42 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D95017: [clang-format] Add case aware include sorting..
Jan 28 2021, 12:40 PM · Restricted Project, Restricted Project

Jan 26 2021

HazardyKnusperkeks added inline comments to D95017: [clang-format] Add case aware include sorting..
Jan 26 2021, 11:44 AM · Restricted Project, Restricted Project

Jan 25 2021

HazardyKnusperkeks committed rG60bf5826cfd3: [clang-format] PR16518 Add flag to suppress empty line insertion before access… (authored by thezbyg).
[clang-format] PR16518 Add flag to suppress empty line insertion before access…
Jan 25 2021, 12:03 PM
HazardyKnusperkeks committed rGf02eca0f3fef: [clang-format] [NFC] Rerun dump_format_style.py (authored by HazardyKnusperkeks).
[clang-format] [NFC] Rerun dump_format_style.py
Jan 25 2021, 12:03 PM
HazardyKnusperkeks committed rG9aa38a061511: [clang-format] [NFC] Remove unsued arguments (authored by HazardyKnusperkeks).
[clang-format] [NFC] Remove unsued arguments
Jan 25 2021, 12:03 PM
HazardyKnusperkeks committed rG7c8b9c102f38: [clang-format] [NFC] Restructure getLineCommentIndentPrefix (authored by HazardyKnusperkeks).
[clang-format] [NFC] Restructure getLineCommentIndentPrefix
Jan 25 2021, 12:03 PM
HazardyKnusperkeks closed D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Jan 25 2021, 12:03 PM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rG6cb288797122: [clang-format] [NFC] Use some constexpr StringRef (authored by HazardyKnusperkeks).
[clang-format] [NFC] Use some constexpr StringRef
Jan 25 2021, 12:03 PM
HazardyKnusperkeks closed D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix.
Jan 25 2021, 12:03 PM · Restricted Project, Restricted Project
HazardyKnusperkeks closed D95078: [clang-format] [NFC] Use some constexpr StringRef instead of const char*..
Jan 25 2021, 12:03 PM · Restricted Project, Restricted Project

Jan 24 2021

HazardyKnusperkeks added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

Do you need someone to push this? If so please post email and name to use for the commit.

Jan 24 2021, 12:53 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

I did not re-accept this, because of the script change. I'm okay with it, but I never looked really at the script. I think it should be changed afterwards to error or warn again, but not on this enum. Maybe one could annotate enums which don't have to be fully documented?

Jan 24 2021, 11:52 AM · Restricted Project, Restricted Project

Jan 22 2021

HazardyKnusperkeks added a comment to D95017: [clang-format] Add case aware include sorting..

I can push that, but will wait a bit longer so the others have time to object.

Jan 22 2021, 8:17 AM · Restricted Project, Restricted Project

Jan 21 2021

HazardyKnusperkeks requested review of D95128: [clang-format] [NFC] Remove unused arguments.
Jan 21 2021, 4:54 AM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix.

Empty lines removed.

Jan 21 2021, 4:41 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D95017: [clang-format] Add case aware include sorting..

LGTM.

Jan 21 2021, 4:27 AM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix.

Now with assert.

Jan 21 2021, 4:11 AM · Restricted Project, Restricted Project

Jan 20 2021

HazardyKnusperkeks added a comment to D95017: [clang-format] Add case aware include sorting..

Please expand the test case to different options like grouping. Otherwise looks good.

Jan 20 2021, 9:33 PM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix.
Jan 20 2021, 12:52 PM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D95078: [clang-format] [NFC] Use some constexpr StringRef instead of const char*..
Jan 20 2021, 12:37 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this.

Sorry, much to do work-wise currently. I'll get to the last details today and finish this!

Jan 20 2021, 7:16 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this.

Jan 20 2021, 12:50 AM · Restricted Project, Restricted Project

Jan 19 2021

HazardyKnusperkeks added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

Is there a test with indentation within a namespace? If not maybe you should add one.

Jan 19 2021, 11:31 PM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D93844: [clang-format] Add possibility to be based on parent directory.

Found and fixed the case when no BasedOnStyle apart from InheritParentConfig is used.

Jan 19 2021, 1:45 PM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rGcbdde495ba28: [clang-format] Apply Allman style to lambdas (authored by HazardyKnusperkeks).
[clang-format] Apply Allman style to lambdas
Jan 19 2021, 9:18 AM
HazardyKnusperkeks closed D94906: [clang-format] Apply Allman style to lambdas.
Jan 19 2021, 9:18 AM · Restricted Project, Restricted Project

Jan 18 2021

HazardyKnusperkeks added a comment to D94906: [clang-format] Apply Allman style to lambdas.

I think that would have helped me also. I think it's not that easy, but honestly never checked.

Jan 18 2021, 12:19 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style.

Yes I do, but I will try to make it clearer in the tests.

Jan 18 2021, 10:13 AM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D94906: [clang-format] Apply Allman style to lambdas.

Formatting corrected.

Jan 18 2021, 7:52 AM · Restricted Project, Restricted Project
HazardyKnusperkeks requested review of D94906: [clang-format] Apply Allman style to lambdas.
Jan 18 2021, 4:20 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style.

Jan 18 2021, 2:45 AM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D93844: [clang-format] Add possibility to be based on parent directory.
  • Rebased
  • Renamed to InhteritParentConfig
  • Reworked to remove the recursion of getStyle
  • Now supports the command line style options
  • Test cases extended for the latter
Jan 18 2021, 2:16 AM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D92257: [clang-format] Add option to control the space at the front of a line comment.
  • Rebased
  • Fixed(?) the last UnitTest, please take a look @krasimir
Jan 18 2021, 2:11 AM · Restricted Project, Restricted Project
HazardyKnusperkeks committed rGb43075e34a59: [clang-format] Fix documentation of bcc1dee600 (authored by HazardyKnusperkeks).
[clang-format] Fix documentation of bcc1dee600
Jan 18 2021, 2:03 AM
HazardyKnusperkeks updated the diff for D93776: [clang-format] Add StatementAttributeLikeMacros option.

Fix documentation.

Jan 18 2021, 2:01 AM · Restricted Project, Restricted Project

Jan 17 2021

HazardyKnusperkeks committed rGbcc1dee60019: [clang-format] Add StatementAttributeLikeMacros option (authored by HazardyKnusperkeks).
[clang-format] Add StatementAttributeLikeMacros option
Jan 17 2021, 10:02 PM
HazardyKnusperkeks closed D93776: [clang-format] Add StatementAttributeLikeMacros option.
Jan 17 2021, 10:02 PM · Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D93776: [clang-format] Add StatementAttributeLikeMacros option.

Sorting corrected.

Jan 17 2021, 10:00 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 17 2021, 11:42 AM · Restricted Project, Restricted Project

Jan 16 2021

HazardyKnusperkeks added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Not what I had in mind, but for me that's okay. I can not say anything to the change of the script though.

Jan 16 2021, 6:24 AM · Restricted Project, Restricted Project

Jan 15 2021

HazardyKnusperkeks requested changes to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Jan 15 2021, 2:59 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

I think I would remove the code examples from the "AlignConsecutive style" to avoid confusion (that would be the first change)

then perhaps regenerate and update the documentation so we can then see, its seems most have a "code block", can the specific examples not go into that area?

And just have the enum explain its different configuration options?

/// \brief If ``true``, aligns consecutive C/C++ preprocessor macros.
///
/// This will align C/C++ preprocessor macros of consecutive lines.
/// Will result in formattings like
/// \code
///   #define SHORT_NAME       42
///   #define LONGER_NAME      0x007f
///   #define EVEN_LONGER_NAME (2)
///   #define foo(x)           (x * x)
///   #define bar(y, z)        (y + z)
/// \endcode
bool AlignConsecutiveMacros;
Jan 15 2021, 2:58 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93776: [clang-format] Add StatementAttributeLikeMacros option.

*ping*
And I don't have a better name.

Jan 15 2021, 2:56 PM · Restricted Project, Restricted Project

Jan 14 2021

HazardyKnusperkeks accepted D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Jan 14 2021, 7:51 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

I would add a test where you have a member before the first access modifier.
Also this is not exactly what they wanted in the bug, as far as I can see members of structs or classes with no access modifier at all should only be indented once.

Jan 14 2021, 4:03 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

My assumption is that you want to stick with the minimum and maximum is that correct?

Jan 14 2021, 2:13 AM · Restricted Project, Restricted Project

Jan 13 2021

HazardyKnusperkeks added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 13 2021, 10:17 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Jan 13 2021, 2:18 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Jan 13 2021, 11:59 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

Apart from that last naming issue looks good to me.

Jan 13 2021, 11:53 AM · Restricted Project, Restricted Project

Jan 10 2021

HazardyKnusperkeks added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.)

Jan 10 2021, 12:44 PM · Restricted Project, Restricted Project

Jan 9 2021

HazardyKnusperkeks added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

Diff updated. Previous diff was generated after rebase, and Phabricator change preview did not show any unrelated changes, so I thought that everything is fine.

Jan 9 2021, 5:46 AM · Restricted Project, Restricted Project

Jan 7 2021

HazardyKnusperkeks added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

I think your base for the diff is wrong, there are many "added" things which are already in clang-format. Could you update the diff?

Jan 7 2021, 12:57 AM · Restricted Project, Restricted Project