User Details
- User Since
- Nov 12 2020, 2:35 AM (149 w, 5 d)
Thu, Aug 31
Wed, Aug 30
But please wait for other opinions.
Tue, Aug 29
Mon, Aug 28
@kadircet shouldn't you at least say why it got reverted? Even better state your problem and give a chance to fix before you revert?
Sun, Aug 27
Aug 26 2023
Aug 25 2023
Aug 23 2023
Will be fixed on commit.
Aug 22 2023
Aug 21 2023
Please upload the patch with the full context. And add a test case. (From your issue.)
Aug 17 2023
Aug 15 2023
Aug 13 2023
Aug 6 2023
Aug 3 2023
Aug 2 2023
Aug 1 2023
Jul 31 2023
Jul 28 2023
Jul 27 2023
Jul 26 2023
Does this result in a different annotation? Could you add a test for that?
You need some tests to show that the new options really apply like intended.
Jul 25 2023
Jul 24 2023
All of those variants are fine by me, but I'd stick with the current version, because it is linked to AllowShortCaseLabelsOnASingleLine.
Jul 23 2023
Jul 21 2023
For the replacement part, I refer to @owenpan and/or @MyDeveloperDay hoping they have more insight.
The rest look good to me.
Jul 20 2023
Nice work.
Everything is fine, I just need to know how the attribute stuff is formatted with plain LLVM style.
Apart from that I'm okay.
Please provide a diff with the full context (-U999999 will do the trick).
Jul 19 2023
D155529#inline-1505573
But what does clang-format without this patch format? I just want to make sure, that we don't have a regression when this lands, but D155529 not.
Jul 18 2023
If you limit it to Never I don't see any value in the differentiation. You could just always use Custom (by dropping the custom and only having the nested options).
Jul 15 2023
Jul 12 2023
Can you mark this change as closed?
If you'd put "Differential Revision: https://reviews.llvm.org/D153589" in your commit message this would have happened automatically.
Jul 10 2023
Jul 9 2023
Jul 8 2023
Thanks for the patience, I'm really looking forward to use this.
Jul 7 2023
Please wait for other opinions.
Jul 6 2023
Jul 1 2023
Give the author some time is okay, but I think we can and should commandeer at some point and abandon.
I'd really prefer you put what you need to modify mutable instead of removing the const from everything else. But that's just my opinion.
Jun 28 2023
Is this still an issue?