- User Since
- Nov 12 2020, 2:35 AM (31 w, 1 d)
Nice trick! :)
Wed, Jun 16
Tue, Jun 15
Just asking: Would it be different if there is auto, decltype(auto), decltype(a+b), typename or template as trailing return type?
Mon, Jun 14
Could you split this into two diffs? Or are those two changes in any way related?
Sun, Jun 13
Then I would like to use the LLVM style in the tests, otherwise it suggests that the issue is a result of using google style.
Wouldn't this suggest that this issue is a result of using LLVM style?
Sat, Jun 12
Thanks for the work!
Fri, Jun 11
Can you also add tests with the alignment of declarations? We already have such for pointers.
Going the full way, to fix the number of empty lines after/before/between elements would be real nice. But even nicer would be if you can state a range.
Thu, Jun 10
Then we can push it, do you need some one to do that? If yes please post name and email.
Do you need some one to commit this? If yes please state name and email, some one will chime in to commit it.
I think this would be a nice addition, and in the past I would have used it. I really like the option Pointer.
Fri, Jun 4
Remains the issue with the alignment, I would like to know @MyDeveloperDay 's opinion on that. Should the values be right aligned, or left aligned? As far as I see all alignment in clang-format is left until now.
Thu, Jun 3
Seems reasonable. :)
Wed, Jun 2
I've added a few comments, and I would like to hear the opinion of others regarding the left or right alignment of the elements.
Tue, Jun 1
Will do on Thursday.
Mon, May 31
Under "Related Objects" you can add the commit, so that one can navigate to it.
Forgot about that: Please add an entry in the ReleaseNotes.rst, I can imagine there are some people out there waiting for this.
Looks good to me, I would just change the wording a bit. Could you please also add a entry in the ReleaseNotes.rst?
Thank you very much. :)
Do you have commit access, or do you need someone to land it? If the latter please state name and email for the commit.
Sat, May 29
Please just check continue, I would like to make it a separate commit, because it seems unrelated to me. Otherwise this is good.
Fri, May 28
Looks quite solid for me.
LGTM, but please wait for more responses.
Thu, May 27
Wed, May 26
Although verifyFormat is nice, I would add some EXPECT_EQ to show that the braces are really inserted.
Tue, May 25
Mon, May 24
Sat, May 22
Thu, May 20
For me it's good, but please wait for @MyDeveloperDay .
Looks good, but please add a test with the else IF and just else case.
May 18 2021
Maybe a bit more test cases with smaller lambdas? Or without the outer parenthesis?
Apart from that comment I don't have any objections. :)
May 13 2021
I second that ColumnLimit breaking test case. :)
May 8 2021
Something which just came to my mind. Since you wrote your own LineFormatter, you have to add test cases for all kinds of indention and wrapping. It seems that the string wrapping does not happen, how about comments? Are classes, namespaces, functions, etc. correctly indented with various configurations?
May 6 2021
Looks good, but please wait for others to state their opinion.
May 5 2021
I have not a great knowledge about python, but it looks okay.
I really like alignment! :)
May 3 2021
Jep, that would also confuse myself.
Apr 29 2021
Apr 28 2021
Looks good, and I'm always in favor of having a Leave Option. :)
Apr 26 2021
Apr 23 2021
LGTM but please wait for @MyDeveloperDay opinion.
Looks okay for me, but please fix the formatting notes.
Apr 21 2021
Looks good, but please fix the clang-format notes.
Apr 19 2021
Apr 18 2021
if (a) return; else return;
formatted with the different options?
Apr 16 2021
Apr 15 2021
I don't know if you did elsewhere, but you have to give a name and email for the commit, so that someone can push it for you.
Apr 14 2021
This looks okay, I think. But it should definitely add a release note and extend the documentation on statement macros.
Now I'm thinking maybe it should add a new flag to activate that behavior?
Look good in general, only the few comments.