Page MenuHomePhabricator

HazardyKnusperkeks (Björn Schäpers)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2020, 2:35 AM (85 w, 6 d)

Recent Activity

Yesterday

HazardyKnusperkeks accepted D128706: [Clang] Disable clang-format entirely for clang/test tree..
Tue, Jul 5, 12:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker.
Tue, Jul 5, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D129064: [clang-format] Avoid crash in LevelIndentTracker..
Tue, Jul 5, 12:35 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 4

HazardyKnusperkeks accepted D129064: [clang-format] Avoid crash in LevelIndentTracker..
Mon, Jul 4, 3:43 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D129057: [clang-format] Break on AfterColon only if not followed by comment.
Mon, Jul 4, 3:38 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a project to D128786: [clang-format] Fix incorrect isspace input (NFC): Restricted Project.
Mon, Jul 4, 3:34 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 28

HazardyKnusperkeks added inline comments to D128714: [clang-format] Handle Verilog case statements.
Tue, Jun 28, 2:30 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D128713: [clang-format] Handle Verilog user-defined primitives.
Tue, Jun 28, 2:25 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D128712: [clang-format] Handle Verilog modules.
Tue, Jun 28, 2:24 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D128711: [clang-format] Handle Verilog blocks.
Tue, Jun 28, 2:09 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D128709: [clang-format] Handle Verilog attributes.

Seems straight forward.

Tue, Jun 28, 1:54 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

Sorry, I don't have commit access. @HazardyKnusperkeks, could you help me commit it?

If I want to contribute to LLVM in the future, how do I get the commit permission? Does it depend on the number of patches I submit?

Tue, Jun 28, 1:50 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 25

HazardyKnusperkeks added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

But for now you should wait for @MyDeveloperDay that he at least removes the changes needed, or state what you have to change, or even better accept it.

Sat, Jun 25, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

Hi. I passed the unit tests on my computer. But the build status here is failed. The build log only shows the issue is related to git reset --hard. So, I don't know where the bug is. Could you give me some hints to fix this issue? Thanks!

Sat, Jun 25, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D128574: [clang-format] Quit analyzing solution space for large state count.
Sat, Jun 25, 12:20 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

HazardyKnusperkeks committed rGb3aeca3962bb: [clang-format] Further improve requires clause detection (authored by HazardyKnusperkeks).
[clang-format] Further improve requires clause detection
Fri, Jun 24, 7:44 PM · Restricted Project, Restricted Project
HazardyKnusperkeks closed D128496: [clang-format] Further improve requires clause detection.
Fri, Jun 24, 7:43 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D128496: [clang-format] Further improve requires clause detection.
Fri, Jun 24, 3:30 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks updated the diff for D128496: [clang-format] Further improve requires clause detection.
Fri, Jun 24, 3:29 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 23

HazardyKnusperkeks requested review of D128496: [clang-format] Further improve requires clause detection.
Thu, Jun 23, 11:11 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

HazardyKnusperkeks accepted D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Wed, Jun 22, 12:06 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

HazardyKnusperkeks accepted D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Tue, Jun 21, 12:54 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D127270: [clang-format] Add space in placement new expression.
Tue, Jun 21, 12:52 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 20

HazardyKnusperkeks accepted D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Mon, Jun 20, 2:13 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 17

HazardyKnusperkeks added inline comments to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Fri, Jun 17, 12:13 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D127270: [clang-format] Add space in placement new expression.

Nice work adding the capability to the dump script.

Fri, Jun 17, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

I think it's a good idea. When does MatchingParen bind? The value of PrevToken->MatchingParen is still NULL in determineStarAmpUsage function.

Fri, Jun 17, 9:24 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 16

HazardyKnusperkeks added inline comments to D127270: [clang-format] Add space in placement new expression.
Thu, Jun 16, 12:39 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

HazardyKnusperkeks added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

Could you please either directly link to the github issue or better use llvm.org/pr55810 than just #55810 ?

Wed, Jun 15, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

what about (may not be useful but compiles)

struct {
    int foo;    
} &&ptr2 = {};

https://godbolt.org/z/rbb8x3hKP

Wed, Jun 15, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp.
Wed, Jun 15, 12:05 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

HazardyKnusperkeks accepted D127685: [clang-format] Never analyze insert/remove braces in the same pass.
Tue, Jun 14, 1:07 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

HazardyKnusperkeks added inline comments to D127270: [clang-format] Add space in placement new expression.
Mon, Jun 13, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks removed a reviewer for D127484: [clang-format] Use tabs on GNU style: Restricted Project.
Mon, Jun 13, 3:51 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D124749: [clang-format] Handle Verilog preprocessor directives.
Mon, Jun 13, 3:48 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D123450: [clang-format] Parse Verilog if statements.
Mon, Jun 13, 3:42 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D126934: [clang-format] NFC Sort names of format token types.
Mon, Jun 13, 3:36 AM · Restricted Project, Restricted Project

Wed, Jun 8

HazardyKnusperkeks added inline comments to D127270: [clang-format] Add space in placement new expression.
Wed, Jun 8, 5:03 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a project to D127270: [clang-format] Add space in placement new expression: Restricted Project.
Wed, Jun 8, 5:00 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D127260: [clang-format] Remove braces of else blocks that embody an if block.
Wed, Jun 8, 4:59 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2022

HazardyKnusperkeks accepted D127054: [clang-format] Handle attributes for for/while loops.
Jun 5 2022, 1:56 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

HazardyKnusperkeks added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
Jun 3 2022, 1:07 PM · Restricted Project, Restricted Project

Jun 2 2022

HazardyKnusperkeks added a project to D124748: [clang-format] Fix whitespace counting stuff: Restricted Project.
Jun 2 2022, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D124748: [clang-format] Fix whitespace counting stuff.

Can there be a test case, not related to Verilog? Or do we need to wait until you pump up the support for that?

Jun 2 2022, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D126845: [clang-format] Handle Verilog numbers and operators.
Jun 2 2022, 3:27 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a project to D126845: [clang-format] Handle Verilog numbers and operators: Restricted Project.
Jun 2 2022, 3:16 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
Jun 2 2022, 12:57 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM.
Jun 2 2022, 12:41 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

HazardyKnusperkeks added inline comments to D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM.
Jun 1 2022, 12:06 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

HazardyKnusperkeks added a comment to D126132: [clang-format] Fix a crash on lambda trailing return type.

@HazardyKnusperkeks I think you know this better than any of us as you added the assertion to setType(). Does this look ok to you?

May 31 2022, 12:17 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2022

HazardyKnusperkeks accepted D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine".
May 21 2022, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D126052: [clang-format] Handle "complex" conditionals in RemoveBracesLLVM.
May 21 2022, 1:47 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2022

HazardyKnusperkeks added inline comments to D124748: [clang-format] Fix whitespace counting stuff.
May 16 2022, 2:35 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily.
May 16 2022, 2:31 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D124749: [clang-format] Handle Verilog preprocessor directives.

The two parents of this revision change the same file, so the build bot says patch does not apply. Does that mean I have to submit the parent patches with less context?

May 16 2022, 2:27 AM · Restricted Project, Restricted Project

May 12 2022

HazardyKnusperkeks accepted D125451: [clang-format] Handle comments below r_brace in RemoveBracesLLVM.
May 12 2022, 3:35 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D125137: [clang-format] Don't remove braces if a 1-statement body would wrap.
May 12 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

HazardyKnusperkeks added inline comments to D125162: [clang-format] fix alignment w/o binpacked args.
May 10 2022, 12:27 PM · Restricted Project, Restricted Project, Restricted Project

May 7 2022

HazardyKnusperkeks added a comment to D125162: [clang-format] fix alignment w/o binpacked args.

For me there needs no bug report, but could you comment on the misformatting without the patch?

May 7 2022, 4:48 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D125137: [clang-format] Don't remove braces if a 1-statement body would wrap.
May 7 2022, 3:50 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

HazardyKnusperkeks accepted D125064: [clang-format][NFC] Make all TokenAnnotator member functions const.
May 6 2022, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..
May 6 2022, 1:48 PM · Restricted Project, Restricted Project

May 4 2022

HazardyKnusperkeks accepted D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments.
May 4 2022, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D124868: [clang-format] Fix a bug in AlignConsecutiveAssignments.
May 4 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

HazardyKnusperkeks accepted D124818: [clang-format][NFC] Clean up tryToParseLambdaIntroducer().
May 3 2022, 11:28 AM · Restricted Project, Restricted Project, Restricted Project

May 1 2022

HazardyKnusperkeks added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
May 1 2022, 11:42 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D124748: [clang-format] Fix whitespace counting stuff.
May 1 2022, 11:35 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D124589: [clang-format] Fix a bug that misformats Access Specifier after *[].
May 1 2022, 11:27 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

HazardyKnusperkeks accepted D124589: [clang-format] Fix a bug that misformats Access Specifier after *[].

I currently don't know exactly how isSimpleTypeSpecifier works, but what is with
auto x = Foo * []{return 5;}();
auto x = Foo * *[]{static y = 5; return &y;}();

Apr 28 2022, 2:25 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

HazardyKnusperkeks accepted D124452: [clang-format] Adjust editor cursor position past #include blocks.
Apr 27 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

HazardyKnusperkeks accepted D124452: [clang-format] Adjust editor cursor position past #include blocks.
Apr 26 2022, 12:49 PM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2022

HazardyKnusperkeks added a comment to D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624.

There seem to be failing tests. Did you run the FormatTests?

Apr 24 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

HazardyKnusperkeks requested changes to D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624.
Apr 22 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624.

could you please reupload your patch with the full diff context? And please add a regression test.

Apr 22 2022, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D124215: [clang-format][NFC] Use isComment() in setCommentLineLevels().
Apr 22 2022, 12:48 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

HazardyKnusperkeks accepted D123896: [clang-format] fix nested angle brackets parse inside concept definition.

No I think it is a step in the right direction. It will help in common cases, and I still don't know when I will have the time to work on that.
But you are very welcome to join the review, and of course adding patches. :)

Apr 21 2022, 11:33 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D124152: [clang-format] Fix a crash on AllowShortFunctionsOnASingleLine.
Apr 21 2022, 3:03 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D123896: [clang-format] fix nested angle brackets parse inside concept definition.

Not yet: https://reviews.llvm.org/D120034

Apr 21 2022, 3:02 AM · Restricted Project, Restricted Project
HazardyKnusperkeks removed a reviewer for D123896: [clang-format] fix nested angle brackets parse inside concept definition: Restricted Project.
Apr 21 2022, 2:40 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D123896: [clang-format] fix nested angle brackets parse inside concept definition.

As this is still on my todo list: Have you considered

concept X = Bar<5 < 4, 5 > 8>;
concept X = Bar<5 < 4, false>;

Or stuff like that?

Apr 21 2022, 2:40 AM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D123741: [clang-format][NFC] Clean up code in token annotator.
Apr 21 2022, 2:36 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D123450: [clang-format] Parse Verilog if statements.
Apr 21 2022, 2:29 AM · Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..
Apr 21 2022, 2:06 AM · Restricted Project, Restricted Project

Apr 12 2022

HazardyKnusperkeks accepted D123571: [clang-format] Clean up unit tests for AlignArrayOfStructures.
Apr 12 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added inline comments to D123450: [clang-format] Parse Verilog if statements.
Apr 12 2022, 1:00 PM · Restricted Project, Restricted Project
HazardyKnusperkeks accepted D123535: [clang-format] Allow empty .clang-format file.
Apr 12 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2022

HazardyKnusperkeks added inline comments to D123450: [clang-format] Parse Verilog if statements.
Apr 10 2022, 11:43 AM · Restricted Project, Restricted Project

Apr 8 2022

HazardyKnusperkeks accepted D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker.
Apr 8 2022, 2:55 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

HazardyKnusperkeks accepted D121757: [clang-format] Take out common code for parsing blocks NFC.
Apr 6 2022, 11:59 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers.

Kind reminder, please deliver this revision. I don't have write access.

Apr 6 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2022

HazardyKnusperkeks accepted D122756: [clang-format] Fix a crash in qualifier alignment.
Mar 31 2022, 11:40 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

HazardyKnusperkeks accepted D121754: [clang-format] Refactor determineStarAmpUsage NFC.

I cannot view the diff between the last two revisions:

Mar 30 2022, 11:39 AM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D121756: [clang-format] Clean up code looking for if statements.
Mar 30 2022, 11:34 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2022

HazardyKnusperkeks accepted D122548: [clang-format] Don't format qualifiers in PPDirective.
Mar 28 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2022

HazardyKnusperkeks accepted D122468: [clang-format] Fix SeparateDefinitionBlocks breaking up function-try-block..
Mar 27 2022, 12:36 PM · Restricted Project, Restricted Project
HazardyKnusperkeks added a comment to D121756: [clang-format] Clean up code looking for if statements.

It turned out this patch does change behavior.

-  while (
-      FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) {
+  while (FormatTok->isOneOf(tok::identifier, tok::kw_requires,
+                            tok::coloncolon)) {

So what do I do?

IMO, refactoring and cleaning up code should be NFC. You can first add while, switch, etc (if it makes sense) in one patch and then refactor in another patch (or vice versa). It would be much easier to review.

Mar 27 2022, 12:28 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

HazardyKnusperkeks accepted D122301: [clang-format] Fix invalid code generation with comments in lambda.
Mar 23 2022, 12:21 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

HazardyKnusperkeks added a comment to D121754: [clang-format] Refactor determineStarAmpUsage NFC.

Just a side note, I often get this on your changes:
Unhandled Exception ("Exception")
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file
.

Mar 22 2022, 1:07 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks requested changes to D121756: [clang-format] Clean up code looking for if statements.

Just a formality.

Mar 22 2022, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
HazardyKnusperkeks accepted D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 22 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project