- User Since
- Nov 12 2020, 2:35 AM (15 w, 4 d)
Sat, Feb 27
- Work with ::max instead of many checks for == 0.
- Additional Testcase
Is this acceptable to the others? Do you need someone to push it?
Do you need someone to push this?
Thu, Feb 25
Tue, Feb 23
Mon, Feb 22
You should mark comments as done, if they are.
Sun, Feb 21
Just out of curiosity, in which language is Const used?
Fri, Feb 19
Thu, Feb 18
Wed, Feb 17
Tue, Feb 16
Sun, Feb 14
Fri, Feb 12
Although I would put it in one test, this is fine by me.
Wed, Feb 10
Have you rebased your change? It seems that your release notes are still for LLVM 12.
Tue, Feb 9
Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!)
Tue, Feb 2
Silence unused variable warnings in release and using llvm::reverse with range based for.
You need to supply a full diff (with context).
Please also add it to the release notes.
Mon, Feb 1
Fixed documentation (and rebased).
Sun, Jan 31
Jan 30 2021
Jan 29 2021
The previous one broke a (format) test in polly. This lead me to change the one breaking behavior, no it is not breaking anymore.
A comment starting with } will only be indented if it is in a comment section which will get an indention. Test case is adapted.
I did add the commit here, but I can give you the hash explicitly: 9aa38a0615119a7a9f3bee33a2b8915c45f1cab9
Jan 28 2021
Rebased and Ping.
Commited but forgot the Differential Link in the Message.
Jan 26 2021
Jan 25 2021
Jan 24 2021
Do you need someone to push this? If so please post email and name to use for the commit.
I did not re-accept this, because of the script change. I'm okay with it, but I never looked really at the script. I think it should be changed afterwards to error or warn again, but not on this enum. Maybe one could annotate enums which don't have to be fully documented?
Jan 22 2021
I can push that, but will wait a bit longer so the others have time to object.
Jan 21 2021
Empty lines removed.
Now with assert.
Jan 20 2021
Please expand the test case to different options like grouping. Otherwise looks good.
How is it going? I would like to add some new alignment options and it would be stupid not to do it on top of this.
Jan 19 2021
Is there a test with indentation within a namespace? If not maybe you should add one.
Found and fixed the case when no BasedOnStyle apart from InheritParentConfig is used.
Jan 18 2021
I think that would have helped me also. I think it's not that easy, but honestly never checked.
- Renamed to InhteritParentConfig
- Reworked to remove the recursion of getStyle
- Now supports the command line style options
- Test cases extended for the latter
- Fixed(?) the last UnitTest, please take a look @krasimir
Jan 17 2021
Jan 16 2021
Not what I had in mind, but for me that's okay. I can not say anything to the change of the script though.
Jan 15 2021
And I don't have a better name.
Jan 14 2021
I would add a test where you have a member before the first access modifier.
Also this is not exactly what they wanted in the bug, as far as I can see members of structs or classes with no access modifier at all should only be indented once.
Jan 13 2021
Apart from that last naming issue looks good to me.
Jan 10 2021
Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.)
Jan 9 2021
Jan 7 2021
I think your base for the diff is wrong, there are many "added" things which are already in clang-format. Could you update the diff?