Page MenuHomePhabricator

aartbik (Aart Bik)
PhD

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2020, 10:13 AM (124 w, 22 h)

Aart J.C. Bik received his PhD from the Leiden University in 1996. From 1998 to 2007, he worked at Intel, where he was the lead compiler architect of automatic vectorization in the Intel C++/Fortran compilers. In 2007, he moved to Google, where he has worked on compilers for ART and the Dart VM. He is now a member of the MLIR codegen team, focusing on compiler support for sparse tensor computations.

Recent Activity

Yesterday

aartbik accepted D126253: [mlir][bufferize] Decouple promoteBufferResultsToOutParams from One-Shot Bufferize.
Fri, May 27, 4:00 PM · Restricted Project, Restricted Project
aartbik accepted D126573: [mlir][bufferization] Add TensorCopyInsertion pass.
Fri, May 27, 3:25 PM · Restricted Project, Restricted Project
aartbik added inline comments to D126570: [mlir][bufferization] Add optional `copy` operand to AllocTensorOp.
Fri, May 27, 3:20 PM · Restricted Project, Restricted Project
aartbik accepted D126572: [mlir][bufferize][NFC] Split analysis+bufferization of ModuleBufferization.
Fri, May 27, 3:15 PM · Restricted Project, Restricted Project
aartbik accepted D126571: [mlir][bufferization][NFC] Remove post-analysis step infrastructure.
Fri, May 27, 3:14 PM · Restricted Project, Restricted Project
aartbik accepted D126568: [mlir][bufferization][NFC] Move OpFilter out of BufferizationOptions.
Fri, May 27, 3:10 PM · Restricted Project, Restricted Project
aartbik accepted D126569: [mlir][bufferization] Add extra filter mechanism to bufferizeOp.
Fri, May 27, 3:08 PM · Restricted Project, Restricted Project
aartbik accepted D126233: [mlir][sparse] Factoring out SparseTensorFile class for readSparseTensorShape.
Fri, May 27, 2:07 PM · Restricted Project, Restricted Project
aartbik accepted D126514: [mlir][sparse] Improving the FATAL macro.
Fri, May 27, 2:04 PM · Restricted Project, Restricted Project
aartbik accepted D126561: [mlir][sparse] Fixes C++98 warning.
Fri, May 27, 1:20 PM · Restricted Project, Restricted Project
aartbik added a comment to D126180: [mlir][sparse][NFC] Switch InitOp to bufferization::AllocTensorOp.

I really like the direction this is going in, so we have one centralized mechanism to reason on allocation (and deallocation) of the buffers for tensors!
In the long run, it would be nice to have bufferization.de_alloc_tensor() as well, and have one mechanism that inserts those, independent of dense/sparse tensors.

Fri, May 27, 10:51 AM · Restricted Project, Restricted Project
aartbik added a comment to D126333: [mlir][sparse] Add optional start_value to sparse_tensor.init.

Note that there is this parallel effort to unify our tensor initialization ops (see https://reviews.llvm.org/D126180).
So let's brainstorm offline to come up with another solution.

Fri, May 27, 10:40 AM · Restricted Project, Restricted Project
aartbik committed rGa5d7e2a8ac7e: [OpenMP][mlir] fix broken build (authored by aartbik).
[OpenMP][mlir] fix broken build
Fri, May 27, 10:06 AM · Restricted Project, Restricted Project
aartbik closed D126556: [OpenMP][mlir] fix broken build.
Fri, May 27, 10:06 AM · Restricted Project, Restricted Project
aartbik added a reviewer for D126556: [OpenMP][mlir] fix broken build: peixin.
Fri, May 27, 9:50 AM · Restricted Project, Restricted Project
aartbik requested review of D126556: [OpenMP][mlir] fix broken build.
Fri, May 27, 9:50 AM · Restricted Project, Restricted Project

Thu, May 26

aartbik added inline comments to D126333: [mlir][sparse] Add optional start_value to sparse_tensor.init.
Thu, May 26, 5:17 PM · Restricted Project, Restricted Project
aartbik accepted D126106: [mlir][sparse] Moving some functions around.
Thu, May 26, 4:49 PM · Restricted Project, Restricted Project
aartbik accepted D126105: [mlir][sparse] Improving ExecutionEngine/SparseTensorUtils.h.
Thu, May 26, 4:48 PM · Restricted Project, Restricted Project
aartbik updated the diff for D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.

rebased with main

Thu, May 26, 4:22 PM · Restricted Project, Restricted Project
aartbik added a comment to D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.

added tests for c128 and c64, ranked and unranked, memrefs

Thu, May 26, 3:37 PM · Restricted Project, Restricted Project
aartbik updated the diff for D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.

added tests for c128 and c64, ranked and unranked, memrefs

Thu, May 26, 3:37 PM · Restricted Project, Restricted Project

Wed, May 25

aartbik updated the summary of D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.
Wed, May 25, 2:37 PM · Restricted Project, Restricted Project
aartbik updated the summary of D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.
Wed, May 25, 1:48 PM · Restricted Project, Restricted Project
aartbik requested review of D126422: [mlir][python][ctypes] fix ctype python binding complication for complex.
Wed, May 25, 1:46 PM · Restricted Project, Restricted Project
aartbik accepted D126393: [mlir][sparse] Add more complex operations..

Onward to feature completeness!

Wed, May 25, 1:46 PM · Restricted Project, Restricted Project
aartbik added a comment to D126409: Lower complex.expm1 to standard dialect..

Very neat. The general idea LGTM but I leave to it our math experts to approve.

Wed, May 25, 1:44 PM · Restricted Project, Restricted Project
aartbik added a reviewer for D126409: Lower complex.expm1 to standard dialect.: aartbik.
Wed, May 25, 1:43 PM · Restricted Project, Restricted Project

Tue, May 24

aartbik committed rGa9e354c83b9e: [mlir][sparse] complex lowering (authored by aartbik).
[mlir][sparse] complex lowering
Tue, May 24, 4:06 PM · Restricted Project, Restricted Project
aartbik closed D126335: [mlir][sparse] complex lowering.
Tue, May 24, 4:06 PM · Restricted Project, Restricted Project
aartbik updated the diff for D126335: [mlir][sparse] complex lowering.

added CMake

Tue, May 24, 4:00 PM · Restricted Project, Restricted Project
aartbik requested review of D126335: [mlir][sparse] complex lowering.
Tue, May 24, 3:18 PM · Restricted Project, Restricted Project
aartbik committed rG5799f843a220: [mlir][sparse] add new complex ops to reduction recognition (authored by aartbik).
[mlir][sparse] add new complex ops to reduction recognition
Tue, May 24, 3:01 PM · Restricted Project, Restricted Project
aartbik closed D126318: [mlir][sparse] add new complex ops to reduction recognition.
Tue, May 24, 3:01 PM · Restricted Project, Restricted Project
aartbik requested review of D126318: [mlir][sparse] add new complex ops to reduction recognition.
Tue, May 24, 12:38 PM · Restricted Project, Restricted Project
aartbik added inline comments to D126105: [mlir][sparse] Improving ExecutionEngine/SparseTensorUtils.h.
Tue, May 24, 9:06 AM · Restricted Project, Restricted Project

Fri, May 20

aartbik accepted D126027: [mlir][sparse] Support more complex operations..

Excellent work, Bixia!

Fri, May 20, 12:08 PM · Restricted Project, Restricted Project
aartbik added a comment to D126027: [mlir][sparse] Support more complex operations..

Nice progress. One comment.

Fri, May 20, 8:57 AM · Restricted Project, Restricted Project
aartbik committed rG28b6d412afc5: [mlir][sparse] add support for complex zero/one building (authored by aartbik).
[mlir][sparse] add support for complex zero/one building
Fri, May 20, 8:54 AM · Restricted Project, Restricted Project
aartbik closed D126039: [mlir][sparse] add support for complex zero/one building.
Fri, May 20, 8:54 AM · Restricted Project, Restricted Project

Thu, May 19

aartbik added reviewers for D126039: [mlir][sparse] add support for complex zero/one building: bixia, wrengr.
Thu, May 19, 7:39 PM · Restricted Project, Restricted Project
aartbik requested review of D126039: [mlir][sparse] add support for complex zero/one building.
Thu, May 19, 7:35 PM · Restricted Project, Restricted Project
aartbik accepted D126026: [mlir][sparse] Adding x-macros for OverheadType.
Thu, May 19, 3:36 PM · Restricted Project, Restricted Project
aartbik accepted D126016: [mlir][sparse] Using the name "dimSizes" more consistently.
Thu, May 19, 3:10 PM · Restricted Project, Restricted Project
aartbik accepted D126019: [mlir][sparse] Simplifying closure.

Oh, nice, I wonder if that makes reading the very large tensors slightly faster again!

Thu, May 19, 3:09 PM · Restricted Project, Restricted Project
aartbik accepted D126022: [mlir][sparse] Factored out a "FATAL" macro for unrecoverable assertion failure.
Thu, May 19, 3:07 PM · Restricted Project, Restricted Project
aartbik committed rG3b13f8805c02: [mlir][sparse] fix unsigned comparison bug in assert (authored by aartbik).
[mlir][sparse] fix unsigned comparison bug in assert
Thu, May 19, 1:32 PM · Restricted Project, Restricted Project
aartbik closed D126007: [mlir][sparse] fix unsigned comparison bug in assert.
Thu, May 19, 1:32 PM · Restricted Project, Restricted Project
aartbik added a reviewer for D126007: [mlir][sparse] fix unsigned comparison bug in assert: wrengr.
Thu, May 19, 12:38 PM · Restricted Project, Restricted Project
aartbik requested review of D126007: [mlir][sparse] fix unsigned comparison bug in assert.
Thu, May 19, 12:27 PM · Restricted Project, Restricted Project

Tue, May 17

aartbik accepted D125834: [mlir][sparse] Add support for complex.im and complex.re to the sparse compiler..

Nice! Very fast. A few nits, but good to go.

Tue, May 17, 4:08 PM · Restricted Project, Restricted Project

Mon, May 16

aartbik accepted D125087: [mlir][bufferize] Better propagation of errors.
Mon, May 16, 1:26 PM · Restricted Project, Restricted Project
aartbik accepted D125432: [mlir][sparse] Moved _mlir_ciface_newSparseTensor closer to its macros.

Good to go after the required rebasing and merging.

Mon, May 16, 1:20 PM · Restricted Project, Restricted Project
aartbik accepted D125431: [mlir][sparse] Restyling macros in the runtime library.

I like this a lot! You will have to rebase for my complex change (sorry), but good to submit without review after that.

Mon, May 16, 1:19 PM · Restricted Project, Restricted Project
aartbik committed rG736c1b66ef33: [mlir][sparse] introduce complex type to sparse tensor support (authored by aartbik).
[mlir][sparse] introduce complex type to sparse tensor support
Mon, May 16, 1:18 PM · Restricted Project, Restricted Project
aartbik closed D125596: [mlir][sparse] introduce complex type to sparse tensor support.
Mon, May 16, 1:17 PM · Restricted Project, Restricted Project
aartbik accepted D122061: [mlir][sparse] Enhancing sparse=>sparse conversion..
Mon, May 16, 1:16 PM · Restricted Project, Restricted Project
aartbik updated the diff for D125596: [mlir][sparse] introduce complex type to sparse tensor support.

correct include for complex type

Mon, May 16, 12:57 PM · Restricted Project, Restricted Project
aartbik updated the diff for D125596: [mlir][sparse] introduce complex type to sparse tensor support.

addressed comments

Mon, May 16, 10:59 AM · Restricted Project, Restricted Project
aartbik added inline comments to D125596: [mlir][sparse] introduce complex type to sparse tensor support.
Mon, May 16, 10:58 AM · Restricted Project, Restricted Project
aartbik updated the diff for D125596: [mlir][sparse] introduce complex type to sparse tensor support.

CMake fix

Mon, May 16, 10:24 AM · Restricted Project, Restricted Project

Fri, May 13

aartbik added reviewers for D125596: [mlir][sparse] introduce complex type to sparse tensor support: bixia, penpornk, wrengr, burmako.
Fri, May 13, 6:51 PM · Restricted Project, Restricted Project
aartbik requested review of D125596: [mlir][sparse] introduce complex type to sparse tensor support.
Fri, May 13, 6:45 PM · Restricted Project, Restricted Project
aartbik accepted D125428: [mlir][sparse] Adding "final" keyword wherever appropriate.

Jumping a bit ahead in the stack, but this delta is good to go once base goes in as well.

Fri, May 13, 6:27 PM · Restricted Project, Restricted Project

Thu, May 12

aartbik committed rG6f3c7dfb7746: [mlir][sparse] add sparse sign integration test (authored by aartbik).
[mlir][sparse] add sparse sign integration test
Thu, May 12, 3:57 PM · Restricted Project, Restricted Project
aartbik closed D125494: [mlir][sparse] add sparse sign integration test.
Thu, May 12, 3:57 PM · Restricted Project, Restricted Project
aartbik updated the diff for D125494: [mlir][sparse] add sparse sign integration test.

discussed offline: only one padding element

Thu, May 12, 2:51 PM · Restricted Project, Restricted Project
aartbik updated the diff for D125494: [mlir][sparse] add sparse sign integration test.

TAB -> spaces

Thu, May 12, 2:48 PM · Restricted Project, Restricted Project
aartbik retitled D123876: [mlir][sparse] Expose SparseTensor passes as enums instead of opaque numbers for vectorization and parallelization options. from [mlir][sparse] Expose SpareTensor passes as enums instead of opaque numbers for vectorization and parallelization options. to [mlir][sparse] Expose SparseTensor passes as enums instead of opaque numbers for vectorization and parallelization options..
Thu, May 12, 2:31 PM · Restricted Project, Restricted Project
aartbik added a comment to D125501: [mlir] Remove the `type` keyword from type alias definitions.

LGTM for sparse

Thu, May 12, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
aartbik added reviewers for D125494: [mlir][sparse] add sparse sign integration test: wrengr, jim22k.
Thu, May 12, 12:28 PM · Restricted Project, Restricted Project
aartbik requested review of D125494: [mlir][sparse] add sparse sign integration test.
Thu, May 12, 12:26 PM · Restricted Project, Restricted Project
aartbik accepted D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Thanks for your patience during the review, Wren. It has been a long road, but nice to see this new abstraction!

Thu, May 12, 12:00 PM · Restricted Project, Restricted Project
aartbik accepted D125466: [mlir][sparse][NFC] Use RewriterBase/OpBuilder when possible.

Changes look good, and it is of course good to require the minimum required type. But is there a major advantage of doing it this way? (follow up or otherwise)?

Thu, May 12, 11:54 AM · Restricted Project, Restricted Project
aartbik accepted D125361: [mlir][bufferize][NFC] Make getContiguousMemRefType a static function.
Thu, May 12, 11:53 AM · Restricted Project, Restricted Project

Wed, May 11

aartbik added a comment to rG298d2fa1c5f1: Apply clang-tidy fixes for readability-identifier-naming in SparseTensorUtils..

Thanks for the fix. I always fall back to my 90ties C style ;-)

Wed, May 11, 12:43 PM · Restricted Project, Restricted Project
aartbik accepted D125356: [mlir][bufferize] Fix op filter.

The reported failure seems unrelated but please double-check too.
Thanks for fixing this so quickly!

Wed, May 11, 9:13 AM · Restricted Project, Restricted Project

Fri, May 6

aartbik added a comment to rG6a9c1029f845: Fix build with shared libs: add missing CMake dep to MLIR sparse pipeline.

Thank you kindly, Mehdi, as always, for watching our BUILD so closely and proactively fixing it!

Fri, May 6, 1:34 PM · Restricted Project, Restricted Project
aartbik committed rG5b122a7310e8: [mlir][sparse] integration test for zero preserving math op (authored by aartbik).
[mlir][sparse] integration test for zero preserving math op
Fri, May 6, 10:43 AM · Restricted Project, Restricted Project
aartbik closed D125104: [mlir][sparse] integration test for zero preserving math op.
Fri, May 6, 10:42 AM · Restricted Project, Restricted Project
aartbik requested review of D125104: [mlir][sparse] integration test for zero preserving math op.
Fri, May 6, 10:10 AM · Restricted Project, Restricted Project

Thu, May 5

aartbik committed rG952fa3018e73: [mlir][sparse] add more zero-preserving unary ops to sparse compiler (authored by aartbik).
[mlir][sparse] add more zero-preserving unary ops to sparse compiler
Thu, May 5, 3:36 PM · Restricted Project, Restricted Project
aartbik closed D125043: [mlir][sparse] add more zero-preserving unary ops to sparse compiler.
Thu, May 5, 3:35 PM · Restricted Project, Restricted Project
aartbik added a comment to D122060: [mlir][sparse] Factoring out an enumerator over elements of SparseTensorStorage.

Do you have some experimental validation to report before we proceed with this?

Thu, May 5, 2:39 PM · Restricted Project, Restricted Project
aartbik requested review of D125043: [mlir][sparse] add more zero-preserving unary ops to sparse compiler.
Thu, May 5, 2:16 PM · Restricted Project, Restricted Project

Wed, May 4

aartbik accepted D124925: [mlir][sparse][taco] Support more data types..

Nice! Thank you for doing this so quickly!

Wed, May 4, 8:59 AM · Restricted Project, Restricted Project

Tue, May 3

aartbik committed rG2617f2f70826: [mlir][sparse] fix build issue with unused local under opt builds (authored by aartbik).
[mlir][sparse] fix build issue with unused local under opt builds
Tue, May 3, 2:56 PM · Restricted Project, Restricted Project
aartbik closed D124883: [mlir][sparse] fix build issue with unused local under opt builds.
Tue, May 3, 2:55 PM · Restricted Project, Restricted Project
aartbik added reviewers for D124883: [mlir][sparse] fix build issue with unused local under opt builds: jim22k, bixia, wrengr.
Tue, May 3, 2:50 PM · Restricted Project, Restricted Project
aartbik requested review of D124883: [mlir][sparse] fix build issue with unused local under opt builds.
Tue, May 3, 2:49 PM · Restricted Project, Restricted Project
aartbik committed rG1abcdc677cfd: [mlir][sparse] add missing types to from/to-MLIR conversion routines (authored by aartbik).
[mlir][sparse] add missing types to from/to-MLIR conversion routines
Tue, May 3, 2:37 PM · Restricted Project, Restricted Project
aartbik closed D124875: [mlir][sparse] add missing types to from/to-MLIR conversion routines.
Tue, May 3, 2:36 PM · Restricted Project, Restricted Project
aartbik requested review of D124875: [mlir][sparse] add missing types to from/to-MLIR conversion routines.
Tue, May 3, 2:05 PM · Restricted Project, Restricted Project

Mon, May 2

aartbik accepted D123057: [mlir][sparse] Lowering for unary and binary.

A few last comments, but I am giving you the LGTM, since I think this is ready to go in, so we can work on refining the few remaining issues.
Thanks for your patience during the review, and thanks for this contribution!

Mon, May 2, 5:20 PM · Restricted Project, Restricted Project

Thu, Apr 28

aartbik added inline comments to D123057: [mlir][sparse] Lowering for unary and binary.
Thu, Apr 28, 9:56 AM · Restricted Project, Restricted Project

Apr 27 2022

aartbik added a comment to D123057: [mlir][sparse] Lowering for unary and binary.

A few last comments. Sorry for being nitpicky on this, rest assured I really like the work, I am just a bit particular on certain things.
Also, can you please make a pass over all my comments and mark them "Done" (or comment on them otherwise).
That makes the re-review a bit easier, since a lot of my past comments still show up as unresolv.ed

Apr 27 2022, 1:00 PM · Restricted Project, Restricted Project
aartbik added a comment to D123876: [mlir][sparse] Expose SparseTensor passes as enums instead of opaque numbers for vectorization and parallelization options..

Additionally, I have commit access now thanks to Chris :-)

Apr 27 2022, 10:23 AM · Restricted Project, Restricted Project
aartbik committed rGccd047cba4f1: [mlir][sparse] optimize COO index handling (authored by aartbik).
[mlir][sparse] optimize COO index handling
Apr 27 2022, 10:21 AM · Restricted Project, Restricted Project
aartbik closed D124502: [mlir][sparse] optimize COO index handling.
Apr 27 2022, 10:21 AM · Restricted Project, Restricted Project
aartbik updated the diff for D124502: [mlir][sparse] optimize COO index handling.

added note on change to struct

Apr 27 2022, 10:15 AM · Restricted Project, Restricted Project