Page MenuHomePhabricator

aartbik (Aart Bik)
PhD

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2020, 10:13 AM (168 w, 1 d)

Aart J.C. Bik received his PhD from the Leiden University in 1996. From 1998 to 2007, he worked at Intel, where he was the lead compiler architect of automatic vectorization in the Intel C++/Fortran compilers. In 2007, he moved to Google, where he has worked on compilers for ART and the Dart VM. He is now a member of the MLIR codegen team, focusing on compiler support for sparse tensor computations.

Recent Activity

Yesterday

aartbik accepted D147358: [mlir][sparse] support sparse bufferization.alloc_tensor with copy argument..
Fri, Mar 31, 3:13 PM · Restricted Project, Restricted Project

Thu, Mar 30

aartbik accepted D147291: [mlir][sparse] Correcting some terminology / naming-scheme errors..
Thu, Mar 30, 6:23 PM · Restricted Project, Restricted Project
aartbik accepted D147272: [mlir][sparse] Fix a problem in handling data type conversion..
Thu, Mar 30, 2:02 PM · Restricted Project, Restricted Project
aartbik accepted D147196: [mlir][sparse] Cleaning up some usage of SparseTensorType.
Thu, Mar 30, 9:53 AM · Restricted Project, Restricted Project

Wed, Mar 29

aartbik accepted D147192: [mlir][sparse] avoid creating temporary unordered COO buffer when reshape sparse tensor..
Wed, Mar 29, 6:19 PM · Restricted Project, Restricted Project
aartbik added inline comments to D147192: [mlir][sparse] avoid creating temporary unordered COO buffer when reshape sparse tensor..
Wed, Mar 29, 6:05 PM · Restricted Project, Restricted Project
aartbik accepted D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 29, 5:56 PM · Restricted Project, Restricted Project
aartbik added inline comments to D147011: [mlir][sparse] Replace Element with ElementId for sorting..
Wed, Mar 29, 12:30 PM · Restricted Project, Restricted Project
aartbik added inline comments to D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 29, 12:23 PM · Restricted Project, Restricted Project
aartbik added inline comments to D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.
Wed, Mar 29, 10:06 AM · Restricted Project, Restricted Project

Tue, Mar 28

aartbik accepted D147090: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp.
Tue, Mar 28, 3:59 PM · Restricted Project, Restricted Project
aartbik accepted D147074: [mlir][sparse] convert a sparse tensor slice to sparse tensor correctly..
Tue, Mar 28, 1:48 PM · Restricted Project, Restricted Project
aartbik added inline comments to D147074: [mlir][sparse] convert a sparse tensor slice to sparse tensor correctly..
Tue, Mar 28, 12:59 PM · Restricted Project, Restricted Project

Mon, Mar 27

aartbik accepted D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:15 PM · Restricted Project, Restricted Project
aartbik accepted D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.
Mon, Mar 27, 4:10 PM · Restricted Project, Restricted Project
aartbik added inline comments to D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:05 PM · Restricted Project, Restricted Project
aartbik added inline comments to D147010: [mlir][sparse] add create-sparse-deallocs options to match the create-deallocs in BufferizationOption..
Mon, Mar 27, 4:01 PM · Restricted Project, Restricted Project

Wed, Mar 22

aartbik accepted D146673: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind.
Wed, Mar 22, 8:32 PM · Restricted Project, Restricted Project
aartbik accepted D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.
Wed, Mar 22, 6:35 PM · Restricted Project, Restricted Project
aartbik accepted D146674: [mlir][sparse] moving kInvalidId into "detail" namespace.
Wed, Mar 22, 6:34 PM · Restricted Project, Restricted Project
aartbik added inline comments to D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.
Wed, Mar 22, 1:48 PM · Restricted Project, Restricted Project
aartbik accepted D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.
Wed, Mar 22, 12:59 PM · Restricted Project, Restricted Project

Tue, Mar 21

aartbik accepted D146563: [mlir][sparse] fix crash when using pure constant index in indexing mapping (fixes #61530).

can you add a before fail/after pass test?

Tue, Mar 21, 1:49 PM · Restricted Project, Restricted Project
aartbik accepted D146562: [mlir][sparse] Misc cleanup in Merger.h.
Tue, Mar 21, 1:46 PM · Restricted Project, Restricted Project
aartbik accepted D146559: [mlir][sparse] Adding new `Merger::addLat` overload.
Tue, Mar 21, 1:44 PM · Restricted Project, Restricted Project
aartbik committed rGa2c63d7f0b77: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs (authored by aartbik).
[mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs
Tue, Mar 21, 1:33 PM · Restricted Project, Restricted Project
aartbik closed D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.
Tue, Mar 21, 1:32 PM · Restricted Project, Restricted Project
aartbik updated the diff for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.

rebased with main

Tue, Mar 21, 11:58 AM · Restricted Project, Restricted Project

Mon, Mar 20

aartbik accepted D146474: [mlir][sparse] Fixing -Wunused-variable in Sparsification.cpp.
Mon, Mar 20, 4:45 PM · Restricted Project, Restricted Project
aartbik added inline comments to D146086: [mlir][sparse] Making `TensorExp::Kind` a nested enum-class.
Mon, Mar 20, 3:52 PM · Restricted Project, Restricted Project
aartbik accepted D142929: [mlir][sparse] extend loop emitter and optimize lattices with the awareness of slice based iteration.
Mon, Mar 20, 2:41 PM · Restricted Project, Restricted Project
aartbik accepted D146086: [mlir][sparse] Making `TensorExp::Kind` a nested enum-class.
Mon, Mar 20, 2:26 PM · Restricted Project, Restricted Project
aartbik added inline comments to D146086: [mlir][sparse] Making `TensorExp::Kind` a nested enum-class.
Mon, Mar 20, 2:24 PM · Restricted Project, Restricted Project
aartbik added inline comments to D142929: [mlir][sparse] extend loop emitter and optimize lattices with the awareness of slice based iteration.
Mon, Mar 20, 2:10 PM · Restricted Project, Restricted Project
aartbik accepted D142928: [mlir][sparse] add merger/topo sort support for slice-based affine sparse index codegen.

Wait to see if Wren is also okay with how her comments were addressed.

Mon, Mar 20, 2:05 PM · Restricted Project, Restricted Project
aartbik added inline comments to D142928: [mlir][sparse] add merger/topo sort support for slice-based affine sparse index codegen.
Mon, Mar 20, 12:42 PM · Restricted Project, Restricted Project

Fri, Mar 17

aartbik updated the diff for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.

bit of code cleanup, also used smaller values to avoid fp16 issues

Fri, Mar 17, 6:26 PM · Restricted Project, Restricted Project
aartbik added inline comments to D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.
Fri, Mar 17, 6:25 PM · Restricted Project, Restricted Project
aartbik retitled D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs from [WIP] [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs to [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.
Fri, Mar 17, 5:52 PM · Restricted Project, Restricted Project
aartbik added a reviewer for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs: K-Wu.
Fri, Mar 17, 5:24 PM · Restricted Project, Restricted Project
aartbik updated the summary of D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.
Fri, Mar 17, 5:20 PM · Restricted Project, Restricted Project
aartbik updated the diff for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.

dotted all the i's (thanks to Chris); ready for review!

Fri, Mar 17, 5:19 PM · Restricted Project, Restricted Project
aartbik committed rGa3bb693420c5: [mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp (authored by aartbik).
[mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp
Fri, Mar 17, 3:51 PM · Restricted Project, Restricted Project
aartbik closed D146319: [mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp.
Fri, Mar 17, 3:50 PM · Restricted Project, Restricted Project
aartbik updated the diff for D146319: [mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp.

rebased with main (old main was broken)

Fri, Mar 17, 12:26 PM · Restricted Project, Restricted Project
aartbik added reviewers for D146319: [mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp: ThomasRaoux, christopherbate, guraypp.
Fri, Mar 17, 11:44 AM · Restricted Project, Restricted Project
aartbik updated the diff for D146319: [mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp.

rebased with main

Fri, Mar 17, 11:42 AM · Restricted Project, Restricted Project
aartbik requested review of D146319: [mlir][gpu][nvvm] refined sparsity selector test and verification of mma.sp.
Fri, Mar 17, 11:42 AM · Restricted Project, Restricted Project
aartbik committed rG4e4af1338da5: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction (authored by aartbik).
[mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction
Fri, Mar 17, 9:23 AM · Restricted Project, Restricted Project
aartbik closed D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.
Fri, Mar 17, 9:22 AM · Restricted Project, Restricted Project
aartbik added a comment to D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.

It would be nice to test 0x1 case as well.

Fri, Mar 17, 9:20 AM · Restricted Project, Restricted Project

Thu, Mar 16

aartbik updated the diff for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.

made code actually running, still needs a few i's dotted....

Thu, Mar 16, 6:55 PM · Restricted Project, Restricted Project
aartbik added inline comments to D142928: [mlir][sparse] add merger/topo sort support for slice-based affine sparse index codegen.
Thu, Mar 16, 4:54 PM · Restricted Project, Restricted Project
aartbik added inline comments to D142928: [mlir][sparse] add merger/topo sort support for slice-based affine sparse index codegen.
Thu, Mar 16, 11:37 AM · Restricted Project, Restricted Project
aartbik accepted D142927: [mlir][sparse] add new sparisification option for dependent index reduction-based codegen.
Thu, Mar 16, 11:30 AM · Restricted Project, Restricted Project
aartbik added a reviewer for D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction: guraypp.
Thu, Mar 16, 11:15 AM · Restricted Project, Restricted Project
aartbik accepted D146074: [mlir][sparse] add test cases for sparse tensor slices on COO tensors.
Thu, Mar 16, 9:40 AM · Restricted Project, Restricted Project

Wed, Mar 15

aartbik updated the diff for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.

rebased with main, updated RUN command to get into actual running state

Wed, Mar 15, 6:38 PM · Restricted Project, Restricted Project
aartbik added a comment to D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.

LGTM but it would be good to have @christopherbate's opinion

Wed, Mar 15, 10:07 AM · Restricted Project, Restricted Project
aartbik accepted D146082: [mlir][sparse] Updating `Merger::foreachTensorLoopId` to take `LatPointId`.
Wed, Mar 15, 9:08 AM · Restricted Project, Restricted Project

Tue, Mar 14

aartbik updated the diff for D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.

typo

Tue, Mar 14, 10:37 PM · Restricted Project, Restricted Project
aartbik updated the diff for D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.

typo

Tue, Mar 14, 9:50 PM · Restricted Project, Restricted Project
aartbik retitled D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction from [mlir][gpu][nvvm] fix bug with literal for inline asm for mma instruction to [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.
Tue, Mar 14, 9:46 PM · Restricted Project, Restricted Project
aartbik added a reviewer for D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction: ThomasRaoux.
Tue, Mar 14, 9:46 PM · Restricted Project, Restricted Project
aartbik requested review of D146110: [mlir][gpu][nvvm] fixed bug with literal for inline asm for mma instruction.
Tue, Mar 14, 9:46 PM · Restricted Project, Restricted Project
aartbik accepted D145756: [mlir][sparse] Cleaning up names in {Merger,LoopEmitter,CodegenEnv}.{h,cpp}.
Tue, Mar 14, 10:30 AM · Restricted Project, Restricted Project
aartbik added a comment to D146052: [mlir][Interfaces] Add ReifyShapeDimTypeInterface.

LG for sparse

Tue, Mar 14, 10:25 AM · Restricted Project, Restricted Project
aartbik added a comment to D146053: [mlir][tensor/memref] Replace various redundant helpers with `reifyShapeDims`.

LG for sparse with one nit

Tue, Mar 14, 10:24 AM · Restricted Project, Restricted Project
aartbik accepted D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values..
Tue, Mar 14, 10:16 AM · Restricted Project, Restricted Project
aartbik accepted D145534: [mlir][sparse] Modify the pivot selection method for quick sort..

We should perhaps start thinking about moving all sorted related codegen to a more general place and in its own file.
(not know, but this is becoming a powerful utility that others may want to use too)

Tue, Mar 14, 10:12 AM · Restricted Project, Restricted Project

Mon, Mar 13

aartbik accepted D145975: [mlir][vector] Clarify OOB semantics of remaining load/store ops.
Mon, Mar 13, 5:55 PM · Restricted Project, Restricted Project
aartbik added a comment to D145756: [mlir][sparse] Cleaning up names in {Merger,LoopEmitter,CodegenEnv}.{h,cpp}.

are we really going to follow up on all the TODO's and notes?
is it really worth putting them *all* in our codebase?

Mon, Mar 13, 9:45 AM · Restricted Project, Restricted Project

Fri, Mar 10

aartbik accepted D141532: [mlir][sparse] support dynamic sparse tensor slices..
Fri, Mar 10, 2:19 PM · Restricted Project, Restricted Project
aartbik added inline comments to D145824: [mlir][vector] Clarify OOB semantics for `gather` and `scatter`.
Fri, Mar 10, 12:48 PM · Restricted Project, Restricted Project
aartbik accepted D141641: [mlir][sparse] extend storage specifier operations for slices..
Fri, Mar 10, 10:46 AM · Restricted Project, Restricted Project
aartbik added inline comments to D141641: [mlir][sparse] extend storage specifier operations for slices..
Fri, Mar 10, 10:14 AM · Restricted Project, Restricted Project
aartbik accepted D145440: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition..
Fri, Mar 10, 10:09 AM · Restricted Project, Restricted Project
aartbik added inline comments to D141532: [mlir][sparse] support dynamic sparse tensor slices..
Fri, Mar 10, 9:56 AM · Restricted Project, Restricted Project

Thu, Mar 9

aartbik updated the summary of D145708: [sparse][mlir] test transposition on sorted COO.
Thu, Mar 9, 2:06 PM · Restricted Project, Restricted Project
aartbik committed rGe1b3c5c403b8: [sparse][mlir] test transposition on sorted COO (authored by aartbik).
[sparse][mlir] test transposition on sorted COO
Thu, Mar 9, 2:02 PM · Restricted Project, Restricted Project
aartbik closed D145708: [sparse][mlir] test transposition on sorted COO.
Thu, Mar 9, 2:02 PM · Restricted Project, Restricted Project
aartbik accepted D145621: [mlir][sparse] deduplicate non-unique coordinates unconditionally.
Thu, Mar 9, 1:36 PM · Restricted Project, Restricted Project
aartbik updated the diff for D145708: [sparse][mlir] test transposition on sorted COO.

works for direct IR now

Thu, Mar 9, 1:36 PM · Restricted Project, Restricted Project
aartbik accepted D145728: [mlir][sparse] add a check test for foreach operation on constant sparse tensor.
Thu, Mar 9, 1:23 PM · Restricted Project, Restricted Project
aartbik accepted D145723: [mlir][sparse] fix bugs when convert coo to coo but with different dim ordering.
Thu, Mar 9, 12:48 PM · Restricted Project, Restricted Project
aartbik requested review of D145708: [sparse][mlir] test transposition on sorted COO.
Thu, Mar 9, 10:57 AM · Restricted Project, Restricted Project
aartbik accepted D145532: [mlir][sparse] deduplicate non-unique coordinates when coiterating collapsed COO tensors..
Thu, Mar 9, 10:00 AM · Restricted Project, Restricted Project
aartbik added inline comments to D145532: [mlir][sparse] deduplicate non-unique coordinates when coiterating collapsed COO tensors..
Thu, Mar 9, 9:30 AM · Restricted Project, Restricted Project

Wed, Mar 8

aartbik accepted D145620: [mlir][sparse] Factoring out Merger::expIsTensor.
Wed, Mar 8, 3:50 PM · Restricted Project, Restricted Project
aartbik accepted D145603: [mlir][sparse] fix a bug in unpack op that used wrong compare predicate..
Wed, Mar 8, 11:50 AM · Restricted Project, Restricted Project

Tue, Mar 7

aartbik accepted D145518: [mlir][sparse] deduplicate non-unique coordinates when coiterating COO tensors.
Tue, Mar 7, 12:00 PM · Restricted Project, Restricted Project
aartbik added inline comments to D145518: [mlir][sparse] deduplicate non-unique coordinates when coiterating COO tensors.
Tue, Mar 7, 10:52 AM · Restricted Project, Restricted Project
aartbik added a comment to D145440: [mlir][sparse] Improve quick sort by using a loop to sort the bigger partition..

any perf results?

Tue, Mar 7, 9:55 AM · Restricted Project, Restricted Project
aartbik added a comment to D145442: [mlir][sparse] Improve sort operation by generating inlined code to compare values..

any perf result you can put in the description?

Tue, Mar 7, 9:54 AM · Restricted Project, Restricted Project
aartbik accepted D145432: [mlir][sparse] Cleaning up code style for genCast.
Tue, Mar 7, 9:51 AM · Restricted Project, Restricted Project

Mon, Mar 6

aartbik added a reviewer for D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs: christopherbate.
Mon, Mar 6, 3:56 PM · Restricted Project, Restricted Project
aartbik requested review of D145447: [mlir][sparse][gpu] end-to-end test for 2:4 sparsity on NVidia GPUs.
Mon, Mar 6, 3:55 PM · Restricted Project, Restricted Project
aartbik accepted D145420: [mlir][sparse] Fixing -Wsign-compare error in D144773.
Mon, Mar 6, 1:53 PM · Restricted Project, Restricted Project

Fri, Mar 3

aartbik accepted D144773: [mlir][sparse] Renaming "pointer/index" to "position/coordinate".
Fri, Mar 3, 12:48 PM · Restricted Project, Restricted Project
aartbik committed rG657f60a07b2d: [mlir][vector] add support for printing f16 and bf16 (authored by aartbik).
[mlir][vector] add support for printing f16 and bf16
Fri, Mar 3, 8:58 AM · Restricted Project, Restricted Project