Page MenuHomePhabricator

aartbik (Aart Bik)
PhD

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2020, 10:13 AM (65 w, 3 d)

Aart J.C. Bik received his PhD from the Leiden University in 1996. From 1998 to 2007, he worked at Intel, where he was the lead compiler architect of automatic vectorization in the Intel C++/Fortran compilers. In 2007, he moved to Google, where he has worked on compilers for ART and the Dart VM. He is now a member of the TensorFlow codegen team.

Recent Activity

Today

aartbik committed rG0b63e3222b2d: [mlir] X86Vector: Add AVX Rsqrt (authored by cota).
[mlir] X86Vector: Add AVX Rsqrt
Tue, Apr 13, 8:44 AM
aartbik closed D99818: [mlir] X86Vector: Add AVX Rsqrt.
Tue, Apr 13, 8:44 AM · Restricted Project

Yesterday

aartbik accepted D99818: [mlir] X86Vector: Add AVX Rsqrt.
Mon, Apr 12, 10:39 PM · Restricted Project
aartbik committed rG1310a19af062: [mlir] Use MCJIT to fix integration tests (authored by cota).
[mlir] Use MCJIT to fix integration tests
Mon, Apr 12, 6:26 PM
aartbik closed D100344: [mlir] Use MCJIT to fix integration tests.
Mon, Apr 12, 6:25 PM · Restricted Project
aartbik accepted D100344: [mlir] Use MCJIT to fix integration tests.

ship it!

Mon, Apr 12, 3:26 PM · Restricted Project
aartbik added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Mon, Apr 12, 3:23 PM · Restricted Project
aartbik accepted D100344: [mlir] Use MCJIT to fix integration tests.

aren't the AMX test affected by this as well then?

Mon, Apr 12, 2:53 PM · Restricted Project
aartbik added a comment to D99818: [mlir] X86Vector: Add AVX Rsqrt.

can you please rebase so we can continue the review in the context of the new dialect name?

Mon, Apr 12, 1:17 PM · Restricted Project
aartbik committed rG7714b405a0de: [mlir] introduce "encoding" attribute to tensor type (authored by aartbik).
[mlir] introduce "encoding" attribute to tensor type
Mon, Apr 12, 10:37 AM
aartbik closed D99548: [mlir] introduce "encoding" attribute to tensor type.
Mon, Apr 12, 10:37 AM · Restricted Project
aartbik updated the diff for D99548: [mlir] introduce "encoding" attribute to tensor type.

typos

Mon, Apr 12, 9:54 AM · Restricted Project
aartbik added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

To me there is nothing about property that makes it discardable, quite the contrary actually,

Mon, Apr 12, 9:35 AM · Restricted Project

Fri, Apr 9

aartbik updated the diff for D99548: [mlir] introduce "encoding" attribute to tensor type.

renamed tests too

Fri, Apr 9, 5:08 PM · Restricted Project
aartbik retitled D99548: [mlir] introduce "encoding" attribute to tensor type from [mlir] introduce "format" attribute to tensor type to [mlir] introduce "encoding" attribute to tensor type.
Fri, Apr 9, 3:54 PM · Restricted Project
aartbik updated the diff for D99548: [mlir] introduce "encoding" attribute to tensor type.

format -> encoding

Fri, Apr 9, 3:54 PM · Restricted Project
aartbik added a comment to D100233: [mlir] Add support for adding attribute+type traits/interfaces to tablegen defs.

I am most likely not the right person to LG this, but, wow, thank you for adding this so quickly!!!

Fri, Apr 9, 3:43 PM · Restricted Project
aartbik added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

I'd recommend going with something active sounding, perhaps layout or encoding?

Fri, Apr 9, 1:42 PM · Restricted Project
aartbik accepted D100119: [mlir] Rename AVX512 dialect to X86Vector.
Fri, Apr 9, 12:48 PM · Restricted Project, Restricted Project
aartbik added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Fri, Apr 9, 11:26 AM · Restricted Project
aartbik added inline comments to D100119: [mlir] Rename AVX512 dialect to X86Vector.
Fri, Apr 9, 11:18 AM · Restricted Project, Restricted Project

Thu, Apr 8

aartbik added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Thu, Apr 8, 4:58 PM · Restricted Project
aartbik added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Thu, Apr 8, 4:52 PM · Restricted Project
aartbik added a reviewer for D99548: [mlir] introduce "encoding" attribute to tensor type: silvas.
Thu, Apr 8, 4:03 PM · Restricted Project
aartbik added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

Uday, can you please verify that you are happy with the doc changes (autogen from td) that describe the format syntax.
Next are the interfaces (happy to include these here, but probably easier to review as next CL)....

Thu, Apr 8, 2:28 PM · Restricted Project
aartbik added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

This revision is missing an update to the tensor type documentation in mlir/doc/LangRef.md.

Thu, Apr 8, 12:45 PM · Restricted Project
aartbik removed a reviewer for D95475: [mlir][DO NOT COMMIT] Demonstrate i1 memref data layout issue.: aartbik.
Thu, Apr 8, 10:16 AM · Restricted Project
aartbik added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

I don't think we have so many clients that renaming isn't possible, do we? We have done that before with much more heavily used files.
It's not a super big deal, but this way we lose the revision history of all copied files.

Thu, Apr 8, 10:11 AM · Restricted Project, Restricted Project

Wed, Apr 7

aartbik updated the summary of D99548: [mlir] introduce "encoding" attribute to tensor type.
Wed, Apr 7, 7:20 PM · Restricted Project
aartbik updated the summary of D99548: [mlir] introduce "encoding" attribute to tensor type.
Wed, Apr 7, 7:19 PM · Restricted Project
aartbik added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Wed, Apr 7, 7:18 PM · Restricted Project
aartbik updated the diff for D99548: [mlir] introduce "encoding" attribute to tensor type.

first round of comments

Wed, Apr 7, 2:47 PM · Restricted Project
aartbik added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

figured someone else was more authoritative than me and would take this.

Wed, Apr 7, 2:47 PM · Restricted Project
aartbik committed rG3acf49829c00: [mlir][sparse] support integral types i32,i16,i8 for *numerical* values (authored by aartbik).
[mlir][sparse] support integral types i32,i16,i8 for *numerical* values
Wed, Apr 7, 10:02 AM
aartbik closed D99999: [mlir][sparse] support integral types i32,i16,i8 for *numerical* values.
Wed, Apr 7, 10:01 AM · Restricted Project

Tue, Apr 6

aartbik updated the summary of D99999: [mlir][sparse] support integral types i32,i16,i8 for *numerical* values.
Tue, Apr 6, 5:22 PM · Restricted Project
aartbik requested review of D99999: [mlir][sparse] support integral types i32,i16,i8 for *numerical* values.
Tue, Apr 6, 5:21 PM · Restricted Project
aartbik added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

any early feedback on this? can I go ahead polishing this CL for review?

Tue, Apr 6, 4:44 PM · Restricted Project
aartbik added a comment to D99948: [mlir] add support for index type in vectors..

Very pleased to see this happen! This will also remove some artificial bail out in sparse compiler vectorization due to "index" as base type!

Tue, Apr 6, 2:04 PM · Restricted Project
aartbik added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Tue, Apr 6, 1:59 PM · Restricted Project

Mon, Apr 5

aartbik committed rGa46f59a747a7: [mlir][sparse] move new test to right directory structure (authored by aartbik).
[mlir][sparse] move new test to right directory structure
Mon, Apr 5, 2:42 PM
aartbik closed D99899: [mlir][sparse] move new test to right directory structure.
Mon, Apr 5, 2:41 PM · Restricted Project
aartbik added reviewers for D99899: [mlir][sparse] move new test to right directory structure: bixia, mehdi_amini, penpornk.
Mon, Apr 5, 1:57 PM · Restricted Project
aartbik requested review of D99899: [mlir][sparse] move new test to right directory structure.
Mon, Apr 5, 1:56 PM · Restricted Project

Fri, Apr 2

aartbik added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Fri, Apr 2, 3:56 PM · Restricted Project

Thu, Apr 1

aartbik committed rGa0c5b7e3b523: [mlir][sparse] support for very narrow index and pointer types (authored by aartbik).
[mlir][sparse] support for very narrow index and pointer types
Thu, Apr 1, 6:22 PM
aartbik closed D99777: [mlir][sparse] support for very narrow index and pointer types.
Thu, Apr 1, 6:21 PM · Restricted Project
aartbik added reviewers for D99777: [mlir][sparse] support for very narrow index and pointer types: bixia, penpornk, tatianashp.
Thu, Apr 1, 4:49 PM · Restricted Project
aartbik requested review of D99777: [mlir][sparse] support for very narrow index and pointer types.
Thu, Apr 1, 4:48 PM · Restricted Project

Tue, Mar 30

aartbik updated the summary of D99548: [mlir] introduce "encoding" attribute to tensor type.
Tue, Mar 30, 1:20 PM · Restricted Project
aartbik updated the summary of D99548: [mlir] introduce "encoding" attribute to tensor type.
Tue, Mar 30, 1:19 PM · Restricted Project
aartbik retitled D99548: [mlir] introduce "encoding" attribute to tensor type from [WIP][mlir] introduce "format" attribute to tensor type to [mlir] introduce "format" attribute to tensor type.
Tue, Mar 30, 1:19 PM · Restricted Project
aartbik added reviewers for D99548: [mlir] introduce "encoding" attribute to tensor type: stellaraccident, nicolasvasilache.
Tue, Mar 30, 10:14 AM · Restricted Project

Mon, Mar 29

aartbik updated the diff for D99548: [mlir] introduce "encoding" attribute to tensor type.

pass python bindings tests

Mon, Mar 29, 4:23 PM · Restricted Project
aartbik updated the diff for D99548: [mlir] introduce "encoding" attribute to tensor type.

fixed typos

Mon, Mar 29, 3:53 PM · Restricted Project
aartbik added a reviewer for D99548: [mlir] introduce "encoding" attribute to tensor type: mehdi_amini.
Mon, Mar 29, 3:42 PM · Restricted Project
aartbik requested review of D99548: [mlir] introduce "encoding" attribute to tensor type.
Mon, Mar 29, 3:41 PM · Restricted Project

Fri, Mar 19

aartbik accepted D99001: Update syntax for amx.tile_muli to use two Unit attr to mark the zext case.
Fri, Mar 19, 6:55 PM · Restricted Project
aartbik added inline comments to D99001: Update syntax for amx.tile_muli to use two Unit attr to mark the zext case.
Fri, Mar 19, 6:44 PM · Restricted Project
aartbik abandoned D99002: [mlir][amx] improved documentation on sign/zero-extension attributes.

seems you were changing this in parallel, abandoning this one

Fri, Mar 19, 6:37 PM · Restricted Project
aartbik added a comment to D99001: Update syntax for amx.tile_muli to use two Unit attr to mark the zext case.

please update integration tests too!

Fri, Mar 19, 6:35 PM · Restricted Project
aartbik added a reviewer for D99002: [mlir][amx] improved documentation on sign/zero-extension attributes: mehdi_amini.
Fri, Mar 19, 6:30 PM · Restricted Project
aartbik requested review of D99002: [mlir][amx] improved documentation on sign/zero-extension attributes.
Fri, Mar 19, 6:30 PM · Restricted Project

Wed, Mar 17

aartbik committed rGf2557cf7ed39: [mlir][cpu-runner] register all llvm ir dialects (authored by aartbik).
[mlir][cpu-runner] register all llvm ir dialects
Wed, Mar 17, 10:06 AM
aartbik closed D98727: [mlir][cpu-runner] register all llvm ir dialects.
Wed, Mar 17, 10:06 AM · Restricted Project
aartbik committed rG9705cafc0ffa: [mlir][amx] regression test for tile-muli (all zero/sign-extension combinations) (authored by aartbik).
[mlir][amx] regression test for tile-muli (all zero/sign-extension combinations)
Wed, Mar 17, 10:04 AM
aartbik closed D98742: [mlir][amx] regression test for tile-muli (all zero/sign-extension combinations).
Wed, Mar 17, 10:04 AM · Restricted Project

Tue, Mar 16

aartbik updated the diff for D98742: [mlir][amx] regression test for tile-muli (all zero/sign-extension combinations).

fixed layout of parameters

Tue, Mar 16, 4:13 PM · Restricted Project
aartbik added inline comments to D98742: [mlir][amx] regression test for tile-muli (all zero/sign-extension combinations).
Tue, Mar 16, 4:09 PM · Restricted Project
aartbik added reviewers for D98742: [mlir][amx] regression test for tile-muli (all zero/sign-extension combinations): penpornk, ftynse, dcaballe.
Tue, Mar 16, 1:58 PM · Restricted Project
aartbik requested review of D98742: [mlir][amx] regression test for tile-muli (all zero/sign-extension combinations).
Tue, Mar 16, 1:57 PM · Restricted Project
aartbik added reviewers for D98727: [mlir][cpu-runner] register all llvm ir dialects: ftynse, mehdi_amini, nicolasvasilache.
Tue, Mar 16, 11:20 AM · Restricted Project
aartbik requested review of D98727: [mlir][cpu-runner] register all llvm ir dialects.
Tue, Mar 16, 11:19 AM · Restricted Project
aartbik committed rGb85d3e27ad77: [mlir][amx] reformatted examples (authored by aartbik).
[mlir][amx] reformatted examples
Tue, Mar 16, 10:25 AM
aartbik closed D98723: [mlir][amx] reformatted examples.
Tue, Mar 16, 10:25 AM · Restricted Project
aartbik added reviewers for D98723: [mlir][amx] reformatted examples: nicolasvasilache, ftynse.
Tue, Mar 16, 9:46 AM · Restricted Project
aartbik requested review of D98723: [mlir][amx] reformatted examples.
Tue, Mar 16, 9:45 AM · Restricted Project
aartbik committed rGb388bbd3f9d0: [mlir][amx] blocked tilezero integration test (authored by aartbik).
[mlir][amx] blocked tilezero integration test
Tue, Mar 16, 8:50 AM
aartbik closed D98680: [mlir][amx] blocked tilezero integration test.
Tue, Mar 16, 8:49 AM · Restricted Project

Mon, Mar 15

aartbik added reviewers for D98680: [mlir][amx] blocked tilezero integration test: mehdi_amini, dcaballe, penpornk.
Mon, Mar 15, 9:48 PM · Restricted Project
aartbik requested review of D98680: [mlir][amx] blocked tilezero integration test.
Mon, Mar 15, 9:47 PM · Restricted Project
aartbik committed rG6ad7b97e20c2: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect) (authored by aartbik).
[mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect)
Mon, Mar 15, 5:59 PM
aartbik closed D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mon, Mar 15, 5:59 PM · Restricted Project
aartbik updated the diff for D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).

removed commented out code

Mon, Mar 15, 4:02 PM · Restricted Project
aartbik updated the diff for D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).

better error messages, more doc on ops, new asserts, stride checks

Mon, Mar 15, 3:48 PM · Restricted Project
aartbik added inline comments to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mon, Mar 15, 3:32 PM · Restricted Project

Mar 12 2021

aartbik updated the diff for D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).

merged LLVM IR AMX dialect with AMX dialect (other comments still to be addressed....)

Mar 12 2021, 7:42 PM · Restricted Project
aartbik committed rGe7ee4eaaf7f0: [mlir][sparse] disable nonunit stride dense vectorization (authored by aartbik).
[mlir][sparse] disable nonunit stride dense vectorization
Mar 12 2021, 4:50 PM
aartbik closed D98563: [mlir][sparse] disable nonunit stride dense vectorization.
Mar 12 2021, 4:49 PM · Restricted Project
aartbik added reviewers for D98563: [mlir][sparse] disable nonunit stride dense vectorization: bixia, dcaballe.
Mar 12 2021, 3:28 PM · Restricted Project
aartbik requested review of D98563: [mlir][sparse] disable nonunit stride dense vectorization.
Mar 12 2021, 3:27 PM · Restricted Project
aartbik added inline comments to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mar 12 2021, 1:50 PM · Restricted Project
aartbik added inline comments to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mar 12 2021, 1:19 PM · Restricted Project
aartbik added inline comments to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mar 12 2021, 11:58 AM · Restricted Project
aartbik added a comment to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).

Thanks for working on this, Aart! I think the progressive lowering approach that you are taking here is very on point! I’m not working with AMX but it would be great if you could add me as a reviewer to the related code reviews. It would be very educational for me since this approach is also applicable to similar internal problems we have.

Mar 12 2021, 10:05 AM · Restricted Project
aartbik added inline comments to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mar 12 2021, 9:56 AM · Restricted Project

Mar 11 2021

aartbik added a comment to D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).

This is a large drop, so I added some background on discourse:

Mar 11 2021, 4:52 PM · Restricted Project
aartbik added reviewers for D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect): mehdi_amini, penpornk, rriddle.
Mar 11 2021, 4:36 PM · Restricted Project
aartbik requested review of D98470: [mlir][amx] Add Intel AMX dialect (architectural-specific vector dialect).
Mar 11 2021, 4:35 PM · Restricted Project

Mar 8 2021

aartbik added inline comments to D97442: [mlir][Vector][Affine] Improve affine vectorizer algorithm.
Mar 8 2021, 6:02 PM · Restricted Project