Page MenuHomePhabricator

philnik (Nikolas Klauser)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2021, 4:00 AM (61 w, 2 d)

Recent Activity

Today

philnik added inline comments to D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator.
Wed, Nov 30, 12:32 PM · Restricted Project, Restricted Project
philnik updated the diff for D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator.

Address comments

Wed, Nov 30, 12:32 PM · Restricted Project, Restricted Project
philnik updated the diff for D131963: [libc++] Add custom clang-tidy checks.

Use the latest llvm-dev version

Wed, Nov 30, 9:28 AM · Restricted Project, Restricted Project, Restricted Project
philnik added a comment to D138629: [libc++][math.h] Add double overloads.
  1. More generally speaking, what's the purpose of -fno-builtins?

To disable all builtins regardless of whether you're in freestanding mode or not. Sometimes the builtins do things you don't want them to do and so you want to disable them (perhaps you don't like the behavior of __builtin_memcpy for some reason), and sometimes the builtins expose names you want to use (https://godbolt.org/z/cMxzojcr1).

__buitin_memcpy works the same whether -fno-builtins is used or not, right? It's just that memcpy doesn't behave like __builtin_memcpy?

Wed, Nov 30, 7:18 AM · Restricted Project, Restricted Project
philnik added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Wed, Nov 30, 4:14 AM · Restricted Project, Restricted Project

Yesterday

philnik committed rGba1e13d52459: [libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT… (authored by philnik).
[libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT…
Tue, Nov 29, 3:50 PM · Restricted Project, Restricted Project
philnik closed D137502: [libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT instead.
Tue, Nov 29, 3:50 PM · Restricted Project, Restricted Project
philnik committed rG650da4a690f9: [libc++][math.h] Use builtins for all the functions (authored by philnik).
[libc++][math.h] Use builtins for all the functions
Tue, Nov 29, 3:50 PM · Restricted Project, Restricted Project
philnik closed D136393: [libc++][math.h] Use builtins for all the functions.
Tue, Nov 29, 3:50 PM · Restricted Project, Restricted Project
philnik committed rGf48f9614536c: [libc++] Install llvm-dev in the docker image (authored by philnik).
[libc++] Install llvm-dev in the docker image
Tue, Nov 29, 3:49 PM · Restricted Project, Restricted Project
philnik closed D138728: [libc++] Install llvm-dev in the docker image.
Tue, Nov 29, 3:49 PM · Restricted Project, Restricted Project
philnik updated the diff for D131963: [libc++] Add custom clang-tidy checks.
  • Address comments
  • Make the checks optional for now
Tue, Nov 29, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
philnik updated the diff for D138728: [libc++] Install llvm-dev in the docker image.

Address comments

Tue, Nov 29, 11:08 AM · Restricted Project, Restricted Project
philnik updated the diff for D137502: [libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT instead.

Rebased

Tue, Nov 29, 10:56 AM · Restricted Project, Restricted Project
philnik updated the diff for D136393: [libc++][math.h] Use builtins for all the functions.
  • Remove AIX workaround
  • Rebased
Tue, Nov 29, 10:48 AM · Restricted Project, Restricted Project
philnik committed rG65df5bf2d1fb: [lbc++] Implement the rest of P0600R1 (nodiscard in the library) (authored by philnik).
[lbc++] Implement the rest of P0600R1 (nodiscard in the library)
Tue, Nov 29, 10:43 AM · Restricted Project, Restricted Project
philnik closed D137597: [lbc++] Implement the rest of P0600R1 (nodiscard in the library).
Tue, Nov 29, 10:42 AM · Restricted Project, Restricted Project
philnik committed rGad79455fad9f: [libc++] Don't pass the allocator in substr() (authored by philnik).
[libc++] Don't pass the allocator in substr()
Tue, Nov 29, 10:40 AM · Restricted Project, Restricted Project
philnik closed D138069: [libc++] Don't pass the allocator in substr().
Tue, Nov 29, 10:40 AM · Restricted Project, Restricted Project
philnik updated the diff for D133661: [libc++] Improve binary size when using __transaction.

Address comments

Tue, Nov 29, 6:51 AM · Restricted Project, Restricted Project
philnik abandoned D135779: [libc++][NFC] Remove unnecessary std:: uses in math.h.
Tue, Nov 29, 6:33 AM · Restricted Project, Restricted Project
philnik abandoned D135777: [libc++] Move functions in math.h into the versioned namespace.
Tue, Nov 29, 6:31 AM · Restricted Project, Restricted Project
philnik updated the diff for D136393: [libc++][math.h] Use builtins for all the functions.

Rebased

Tue, Nov 29, 6:21 AM · Restricted Project, Restricted Project
philnik updated the diff for D137739: [libc++] Implement P0339R6 (polymorphic_allocator<> as a vocabulary type).

Address comments

Tue, Nov 29, 6:16 AM · Restricted Project, Restricted Project
philnik updated the diff for D137597: [lbc++] Implement the rest of P0600R1 (nodiscard in the library).

Rebased

Tue, Nov 29, 5:36 AM · Restricted Project, Restricted Project
philnik added inline comments to D138069: [libc++] Don't pass the allocator in substr().
Tue, Nov 29, 5:33 AM · Restricted Project, Restricted Project
philnik updated the diff for D138069: [libc++] Don't pass the allocator in substr().

Address comments

Tue, Nov 29, 5:33 AM · Restricted Project, Restricted Project
philnik updated the diff for D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.

Try to fix CI

Tue, Nov 29, 3:58 AM · Restricted Project, Restricted Project
philnik added a comment to D137739: [libc++] Implement P0339R6 (polymorphic_allocator<> as a vocabulary type).

The implementation of polymorphic_allocator::allocate_object here doesn't follow the changes in LWG 3237 and LWG 3310. SIZE_MAX should be replaced with numeric_limits<size_t>::max() (perhaps using a templated version of __max_size()), and the error condition should throw bad_array_new_length instead of length_error.

Thanks for the info! I'll apply them in this patch, since they are almost trivial. It looks like we accidentally marked LWG3237 as done already.

Also, on the topic of LWG 3304, it looks like polymorphic_allocator::allocate is supposed to be marked as [[nodiscard]] in C++20. Would it make sense for this patch to also include that change as well?

See D137597 for that.

Lastly, I noticed that the existing code is using #if _LIBCPP_STD_VER > 14, but the code added here is using #if _LIBCPP_STD_VER >= 20. Would it make more sense to use #if _LIBCPP_STD_VER > 17 instead?

We decided to use _LIBCPP_STD_VER >= x for new code.

Tue, Nov 29, 2:18 AM · Restricted Project, Restricted Project
philnik added inline comments to D136268: [libc++][ranges] implement `std::views::elements_view`.
Tue, Nov 29, 2:08 AM · Restricted Project, Restricted Project

Mon, Nov 28

philnik updated the diff for D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.

Address comments

Mon, Nov 28, 3:38 PM · Restricted Project, Restricted Project

Sun, Nov 27

philnik added a comment to D125394: [libc++] Implement LWG3657 (std::hash<std::filesystem::path> is not enabled).

Is there anything still missing? As far as I can tell, I've implemented the feedback.

Sun, Nov 27, 6:37 AM · Restricted Project, Restricted Project

Fri, Nov 25

philnik added a comment to D138731: [libc++] Refactor std::function tests.

Could you mention in the commit message that you are refactoring the .fail.cpp tests specifically?

Fri, Nov 25, 2:01 PM · Restricted Project, Restricted Project
philnik requested review of D138728: [libc++] Install llvm-dev in the docker image.
Fri, Nov 25, 9:25 AM · Restricted Project, Restricted Project

Thu, Nov 24

philnik added inline comments to D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.
Thu, Nov 24, 8:11 AM · Restricted Project, Restricted Project
philnik updated the diff for D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.
  • Address comments
  • Try to fix CI
Thu, Nov 24, 8:11 AM · Restricted Project, Restricted Project
philnik committed rGc418dccdbd76: [libc++] Remove P1908 from the status page (authored by philnik).
[libc++] Remove P1908 from the status page
Thu, Nov 24, 5:10 AM · Restricted Project, Restricted Project
philnik closed D138128: [libc++] Remove P1908 from the status page.
Thu, Nov 24, 5:10 AM · Restricted Project, Restricted Project

Wed, Nov 23

philnik updated the diff for D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.

Try to fix CI

Wed, Nov 23, 6:28 PM · Restricted Project, Restricted Project
philnik requested review of D138629: [libc++][math.h] Add double overloads.
Wed, Nov 23, 5:07 PM · Restricted Project, Restricted Project
philnik updated the diff for D137502: [libc++][math.h] move #undefs to the top and guard explicitly against MSVCRT instead.
  • Rebased
  • Address comments
Wed, Nov 23, 4:23 PM · Restricted Project, Restricted Project
philnik updated the diff for D136393: [libc++][math.h] Use builtins for all the functions.

Rebased

Wed, Nov 23, 4:17 PM · Restricted Project, Restricted Project
philnik updated the diff for D137597: [lbc++] Implement the rest of P0600R1 (nodiscard in the library).

Update tests

Wed, Nov 23, 4:12 PM · Restricted Project, Restricted Project
philnik updated the diff for D137597: [lbc++] Implement the rest of P0600R1 (nodiscard in the library).

Address comments

Wed, Nov 23, 4:08 PM · Restricted Project, Restricted Project
philnik committed rG3574b800cf72: [libc++][clang-tidy] Enable readability-simplify-boolean-expr (authored by philnik).
[libc++][clang-tidy] Enable readability-simplify-boolean-expr
Wed, Nov 23, 3:42 PM · Restricted Project, Restricted Project
philnik closed D137804: [libc++][clang-tidy] Enable readability-simplify-boolean-expr.
Wed, Nov 23, 3:42 PM · Restricted Project, Restricted Project
philnik updated the diff for D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.

Rebased

Wed, Nov 23, 3:13 PM · Restricted Project, Restricted Project
philnik updated the summary of D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.
Wed, Nov 23, 12:58 PM · Restricted Project, Restricted Project
philnik requested review of D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.
Wed, Nov 23, 12:54 PM · Restricted Project, Restricted Project
philnik added inline comments to D136393: [libc++][math.h] Use builtins for all the functions.
Wed, Nov 23, 8:58 AM · Restricted Project, Restricted Project
philnik added a comment to D120186: [pstl] Implementation of Grand Central Dispatch backend.

No. I suppose it's been so long that it won't apply cleanly. I would really like some help getting a builder to turn this on for macOS automatically so that it can run as part of the normal test suite. I can try to carve out some time to rebase it and re-test it. I'm not really sure what anyone is waiting for...

Wed, Nov 23, 8:51 AM · Restricted Project, Restricted Project
philnik updated the diff for D132505: [libc++] Refactor deque::iterator algorithm optimizations.

Address comments

Wed, Nov 23, 3:09 AM · Restricted Project, Restricted Project

Tue, Nov 22

philnik updated the diff for D133661: [libc++] Improve binary size when using __transaction.
  • Rebased
  • Address comments
Tue, Nov 22, 11:45 AM · Restricted Project, Restricted Project
philnik committed rGb816b526741c: [libc++][math.h][NFC] Refactor enable_ifs (authored by philnik).
[libc++][math.h][NFC] Refactor enable_ifs
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik committed rGc702264762e2: [libc++][math.h] Remove some code duplication (authored by philnik).
[libc++][math.h] Remove some code duplication
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik committed rGb0a29f691154: [libc++][math.h] Remove __libcpp_<func> functions and instead call builtins… (authored by philnik).
[libc++][math.h] Remove __libcpp_<func> functions and instead call builtins…
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik committed rGecef6b1cb143: [libc++] Remove duplication in math_h.pass.cpp and improve coverage (authored by philnik).
[libc++] Remove duplication in math_h.pass.cpp and improve coverage
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik committed rG40d8f87809dc: [libc++] Assume that builtins for math.h functions are available (authored by philnik).
[libc++] Assume that builtins for math.h functions are available
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik closed D137501: [libc++][math.h][NFC] Refactor enable_ifs.
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik closed D137500: [libc++][math.h] Remove some code duplication.
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik closed D137499: [libc++][math.h] Remove __libcpp_<func> functions and instead call builtins directly.
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik closed D135781: [libc++] Assume that builtins for math.h functions are available.
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik closed D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage.
Tue, Nov 22, 11:36 AM · Restricted Project, Restricted Project
philnik added inline comments to D137804: [libc++][clang-tidy] Enable readability-simplify-boolean-expr.
Tue, Nov 22, 11:29 AM · Restricted Project, Restricted Project
philnik updated the diff for D137804: [libc++][clang-tidy] Enable readability-simplify-boolean-expr.

Address comments

Tue, Nov 22, 11:29 AM · Restricted Project, Restricted Project
philnik accepted D138512: [libc++] Add missing __has_include checks for C headers not provided by libc++.

LGTM with green CI.

Tue, Nov 22, 11:07 AM · Restricted Project, Restricted Project

Mon, Nov 21

philnik updated the diff for D137501: [libc++][math.h][NFC] Refactor enable_ifs.

Rebased

Mon, Nov 21, 2:13 PM · Restricted Project, Restricted Project
philnik added a comment to D137501: [libc++][math.h][NFC] Refactor enable_ifs.

Why is this a cleanup?

Mon, Nov 21, 2:11 PM · Restricted Project, Restricted Project
philnik updated the diff for D137500: [libc++][math.h] Remove some code duplication.

Rebased

Mon, Nov 21, 2:07 PM · Restricted Project, Restricted Project
philnik updated the diff for D137499: [libc++][math.h] Remove __libcpp_<func> functions and instead call builtins directly.

Rebased

Mon, Nov 21, 2:05 PM · Restricted Project, Restricted Project
philnik updated the diff for D135781: [libc++] Assume that builtins for math.h functions are available.

Rebased

Mon, Nov 21, 2:02 PM · Restricted Project, Restricted Project
philnik updated the diff for D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage.

Rebased

Mon, Nov 21, 2:00 PM · Restricted Project, Restricted Project
philnik updated the diff for D135781: [libc++] Assume that builtins for math.h functions are available.

Rebased

Mon, Nov 21, 1:55 PM · Restricted Project, Restricted Project
philnik committed rGe1e1cad6fd75: [libc++][math.h][NFC] Reformat functions (authored by philnik).
[libc++][math.h][NFC] Reformat functions
Mon, Nov 21, 1:52 PM · Restricted Project, Restricted Project
philnik closed D137498: [libc++][math.h][NFC] Reformat functions.
Mon, Nov 21, 1:52 PM · Restricted Project, Restricted Project
philnik updated the diff for D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage.

Rebased

Mon, Nov 21, 12:12 PM · Restricted Project, Restricted Project
philnik committed rG1323461fe7cf: [libc++] Add utilites for instantiating functions with multiple types (authored by philnik).
[libc++] Add utilites for instantiating functions with multiple types
Mon, Nov 21, 11:35 AM · Restricted Project, Restricted Project
philnik closed D137476: [libc++] Add utilites for instantiating functions with multiple types.
Mon, Nov 21, 11:35 AM · Restricted Project, Restricted Project
philnik accepted D138195: [libc++] Fix __regex_word value when using newlib/picolibc.

LGTM, since everybody seems to be on the same page here. @ldionne do you agree with this?

Mon, Nov 21, 6:26 AM · Restricted Project, Restricted Project
philnik added a comment to D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator.

Here are the benchmark results:

------------------------------------------------------------
Benchmark                                old             new
------------------------------------------------------------
BM_join_view_in_vectors/0           0.701 ns         3.47 ns
BM_join_view_in_vectors/1            16.6 ns         3.75 ns
BM_join_view_in_vectors/2            33.7 ns         5.66 ns
BM_join_view_in_vectors/64           1052 ns          172 ns
BM_join_view_in_vectors/512          8255 ns         1400 ns
BM_join_view_in_vectors/1024        16603 ns         2858 ns
BM_join_view_in_vectors/4000        64662 ns        12452 ns
BM_join_view_in_vectors/4096        66348 ns        12795 ns
BM_join_view_in_vectors/5500        89765 ns        17645 ns
BM_join_view_in_vectors/64000     1234386 ns       617878 ns
BM_join_view_in_vectors/65536     1269340 ns       600301 ns
BM_join_view_in_vectors/70000     1343142 ns       684041 ns
BM_join_view_out_vectors/0          0.699 ns        0.736 ns
BM_join_view_out_vectors/1           16.1 ns         3.79 ns
BM_join_view_out_vectors/2           31.6 ns         5.93 ns
BM_join_view_out_vectors/64           999 ns          161 ns
BM_join_view_out_vectors/512         7932 ns         1457 ns
BM_join_view_out_vectors/1024       15976 ns         2920 ns
BM_join_view_out_vectors/4000       62218 ns        13179 ns
BM_join_view_out_vectors/4096       63710 ns        13419 ns
BM_join_view_out_vectors/5500       85663 ns        18292 ns
BM_join_view_out_vectors/64000    1207589 ns       559316 ns
BM_join_view_out_vectors/65536    1242416 ns       590786 ns
BM_join_view_out_vectors/70000    1257713 ns       683171 ns
BM_join_view_deques/0                3.08 ns         16.1 ns
BM_join_view_deques/1                92.9 ns         19.4 ns
BM_join_view_deques/2                 195 ns         26.2 ns
BM_join_view_deques/64               5703 ns          251 ns
BM_join_view_deques/512             43109 ns         2188 ns
BM_join_view_deques/1024            88938 ns         5401 ns
BM_join_view_deques/4000           360749 ns        27811 ns
BM_join_view_deques/4096           371800 ns        28080 ns
BM_join_view_deques/5500           501057 ns        38059 ns
BM_join_view_deques/64000        10414050 ns      2155094 ns
BM_join_view_deques/65536        10813164 ns      2132998 ns
BM_join_view_deques/70000        11620544 ns      2395421 ns
Mon, Nov 21, 3:47 AM · Restricted Project, Restricted Project
philnik requested review of D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator.
Mon, Nov 21, 3:44 AM · Restricted Project, Restricted Project

Sun, Nov 20

philnik added a comment to D138189: [libcxx] adds an include-what-you-use (IWYU) mapping file.

Thanks!

LGTM, but can you please undo the formatting-only changes in libcxx/utils/generate_header_tests.py? I don't want to block the review on this so I'm approving right away, but I'd like those to be undone and pursued in a separate patch (if at all -- IMO the previous formatting was fine).

Yeah, sorry about that: my browser autoformats on save and since there's no .pyformat yapf just does whatever. I'll fix it up!

Before submitting: is the clang-cl static CI job a concern?

Sun, Nov 20, 4:56 PM · Restricted Project, Restricted Project
philnik updated the diff for D132505: [libc++] Refactor deque::iterator algorithm optimizations.

Fix C++03

Sun, Nov 20, 2:33 PM · Restricted Project, Restricted Project
philnik added a comment to D137804: [libc++][clang-tidy] Enable readability-simplify-boolean-expr.

I am not against this, but it's not clear to me that this really increases readability that much, since 50% of the changes suggested by the tool are not improvements IMO.

Sun, Nov 20, 12:18 PM · Restricted Project, Restricted Project
philnik updated the diff for D137804: [libc++][clang-tidy] Enable readability-simplify-boolean-expr.
  • Rebased
  • Address coment
Sun, Nov 20, 3:53 AM · Restricted Project, Restricted Project

Sat, Nov 19

philnik added inline comments to D138307: [libc++] Remove default definition of std::char_traits.
Sat, Nov 19, 2:24 PM · Restricted Project, Restricted Project
philnik accepted D138307: [libc++] Remove default definition of std::char_traits.

LGTM with green CI.

Sat, Nov 19, 2:09 PM · Restricted Project, Restricted Project
philnik accepted D138268: [libcxx] Fix std::equal not accepting volatile types by refactoring __equal_to.

LGTM with comments addressed and green CI.

Sat, Nov 19, 6:13 AM · Restricted Project, Restricted Project
philnik accepted D135469: [libc++] <type_traits>: Avoid instantiating a pointer type..

LGTM with green CI.

Sat, Nov 19, 5:58 AM · Restricted Project, Restricted Project
philnik added a comment to D138327: [libc++] Introduce a setting to remove fstream from the library.

Why does this need it's own flag, and isn't just under _LIBCPP_HAS_NO_FILESYSTEM?

Sat, Nov 19, 5:42 AM · Restricted Project, Restricted Project

Fri, Nov 18

philnik updated subscribers of D138195: [libc++] Fix __regex_word value when using newlib/picolibc.

I think this could be considered an ABI break. I don't see an alternative and given that the static assert has been failing for some time maybe no-one cares. But just in case, would it be worth noting in the release notes?

This is definitely an ABI break, but I'm not sure we care for newlib about that. We don't officially support it and most people that are using newlib + libc++ are probably in an environment where ABI stability isn't much of a concern. It's mostly used in embedded environments, right? It's probably a good idea to add a note to the ABI Affecting Changes section though.

I agree this is technically an ABI break, but I believe there can't be any affected code since the static_assert would have failed previously when including <regex> for a libc++ build with locale support? And even if it is, I would assume this should not matter for newlib where you generally don't have a system libc++.so that is being linked against.
Happy to add a release note though.

Fri, Nov 18, 10:20 AM · Restricted Project, Restricted Project
philnik added a comment to D138195: [libc++] Fix __regex_word value when using newlib/picolibc.

I think this could be considered an ABI break. I don't see an alternative and given that the static assert has been failing for some time maybe no-one cares. But just in case, would it be worth noting in the release notes?

Fri, Nov 18, 9:29 AM · Restricted Project, Restricted Project
philnik added inline comments to D138307: [libc++] Remove default definition of std::char_traits.
Fri, Nov 18, 9:18 AM · Restricted Project, Restricted Project
philnik added a comment to D138268: [libcxx] Fix std::equal not accepting volatile types by refactoring __equal_to.

The implementation changes look pretty much good to me, but the test needs some more work.

Fri, Nov 18, 8:28 AM · Restricted Project, Restricted Project
philnik accepted D138286: [libcxx] Fix link to Buildbot interface.
Fri, Nov 18, 5:03 AM · Restricted Project, Restricted Project
philnik added inline comments to D138268: [libcxx] Fix std::equal not accepting volatile types by refactoring __equal_to.
Fri, Nov 18, 4:46 AM · Restricted Project, Restricted Project
philnik updated the diff for D137476: [libc++] Add utilites for instantiating functions with multiple types.

Try to fix CI

Fri, Nov 18, 12:49 AM · Restricted Project, Restricted Project

Thu, Nov 17

philnik updated the diff for D137476: [libc++] Add utilites for instantiating functions with multiple types.

Rebase

Thu, Nov 17, 11:26 PM · Restricted Project, Restricted Project
philnik updated the summary of D137476: [libc++] Add utilites for instantiating functions with multiple types.
Thu, Nov 17, 11:20 PM · Restricted Project, Restricted Project
philnik updated the diff for D137476: [libc++] Add utilites for instantiating functions with multiple types.

Rebased

Thu, Nov 17, 11:18 PM · Restricted Project, Restricted Project