Page MenuHomePhabricator

philnik (Nikolas Klauser)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 27 2021, 4:00 AM (10 w, 2 d)

Recent Activity

Today

philnik updated the diff for D115291: [libc++] `= delete` member functions with // = delete;.

Style changes that were requested

Wed, Dec 8, 1:58 AM · Restricted Project

Yesterday

philnik requested review of D115291: [libc++] `= delete` member functions with // = delete;.
Tue, Dec 7, 3:00 PM · Restricted Project
philnik updated subscribers of D114425: [clang] Add __builtin_bswap128.

ping

Tue, Dec 7, 2:16 PM · Restricted Project
philnik committed rG4955095fe69f: [libc++] Remove _LIBCPP_DEFAULT (authored by philnik).
[libc++] Remove _LIBCPP_DEFAULT
Tue, Dec 7, 1:19 PM
philnik closed D115275: [libc++] Remove _LIBCPP_DEFAULT.
Tue, Dec 7, 1:19 PM · Restricted Project
philnik added inline comments to D115275: [libc++] Remove _LIBCPP_DEFAULT.
Tue, Dec 7, 12:29 PM · Restricted Project
philnik requested review of D115275: [libc++] Remove _LIBCPP_DEFAULT.
Tue, Dec 7, 11:43 AM · Restricted Project
philnik added inline comments to D115122: [libc++] [ranges] Implement views::take, views::drop, ranges::equal. [WIP, needs tests].
Tue, Dec 7, 10:54 AM · Restricted Project

Mon, Dec 6

philnik updated the diff for D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).
  • rebased
  • Updated tests
Mon, Dec 6, 5:48 AM · Restricted Project

Sun, Dec 5

philnik committed rGf50be8eb0a12: [libc++][NFC] Disable clang-tidy checks (authored by philnik).
[libc++][NFC] Disable clang-tidy checks
Sun, Dec 5, 4:52 PM
philnik closed D114985: [libc++][NFC] Disable clang-tidy checks.
Sun, Dec 5, 4:52 PM · Restricted Project

Thu, Dec 2

philnik added a reviewer for D114425: [clang] Add __builtin_bswap128: Restricted Project.
Thu, Dec 2, 4:08 PM · Restricted Project
philnik added a comment to D114985: [libc++][NFC] Disable clang-tidy checks.

You are right, llvm-else-after-return is the check for that.

Thu, Dec 2, 12:57 PM · Restricted Project
philnik abandoned D114915: [libc++][NFC] Address clang-tidy warnings in include/.
Thu, Dec 2, 12:12 PM · Restricted Project
philnik requested review of D114985: [libc++][NFC] Disable clang-tidy checks.
Thu, Dec 2, 12:12 PM · Restricted Project
philnik committed rGd2b0df35afb7: [libc++][NFC] Update namespace comments in include/ (authored by philnik).
[libc++][NFC] Update namespace comments in include/
Thu, Dec 2, 12:08 PM
philnik closed D114947: [libc++][NFC] Update namespace comments in include/.
Thu, Dec 2, 12:08 PM · Restricted Project
philnik added inline comments to D114915: [libc++][NFC] Address clang-tidy warnings in include/.
Thu, Dec 2, 5:54 AM · Restricted Project
philnik updated the diff for D114915: [libc++][NFC] Address clang-tidy warnings in include/.
  • factored out namespace comments into D114947
  • disabled misc-unconventional-assign-operator
  • refactored minmax_element
Thu, Dec 2, 5:53 AM · Restricted Project
philnik requested review of D114947: [libc++][NFC] Update namespace comments in include/.
Thu, Dec 2, 5:15 AM · Restricted Project
philnik added inline comments to D114912: [libc++] [P1614] Hidden-friend operator<=> for string_view..
Thu, Dec 2, 2:50 AM · Restricted Project

Wed, Dec 1

philnik requested review of D114915: [libc++][NFC] Address clang-tidy warnings in include/.
Wed, Dec 1, 3:26 PM · Restricted Project
philnik added inline comments to D114912: [libc++] [P1614] Hidden-friend operator<=> for string_view..
Wed, Dec 1, 3:02 PM · Restricted Project
philnik committed rG6146e4cf89db: [libc++] Make __wrap_iter constexpr (authored by philnik).
[libc++] Make __wrap_iter constexpr
Wed, Dec 1, 2:30 PM
philnik closed D114733: [libc++] Make __wrap_iter constexpr.
Wed, Dec 1, 2:30 PM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • Some formatting changes
Wed, Dec 1, 6:42 AM · Restricted Project

Tue, Nov 30

philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • rebased
  • debug iterators should work now
Tue, Nov 30, 3:58 PM · Restricted Project
philnik updated the diff for D114733: [libc++] Make __wrap_iter constexpr.

Initializing pointer in all C++ versions now

Tue, Nov 30, 3:03 AM · Restricted Project

Mon, Nov 29

philnik added a comment to D114733: [libc++] Make __wrap_iter constexpr.

This seems like probably a good idea.
Can you expand on whether this is strictly needed for the constexpr-string and constexpr-vector stuff, or just a nice-to-have, or what? Basically what doesn't work today, that this enables? (And can we regression-test that thing whatever it is?)

Mon, Nov 29, 4:41 PM · Restricted Project
philnik updated the diff for D114733: [libc++] Make __wrap_iter constexpr.

Minor changes

Mon, Nov 29, 4:41 PM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • Rebased onto D114425
  • Make test pass
Mon, Nov 29, 12:20 PM · Restricted Project
philnik requested review of D114733: [libc++] Make __wrap_iter constexpr.
Mon, Nov 29, 12:10 PM · Restricted Project

Sun, Nov 28

philnik planned changes to D110598: [libc++] P0980R1 (constexpr std::string).
Sun, Nov 28, 3:54 PM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • Added check
  • Using __wrap_iter now only during runtime
Sun, Nov 28, 2:35 PM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • Removed debugging stuff for constant evaluation
  • fixed some tests
Sun, Nov 28, 12:39 PM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).

removed XFAIL for GCC

Sun, Nov 28, 11:04 AM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • Rebased
  • check for nullptr
Sun, Nov 28, 10:35 AM · Restricted Project

Tue, Nov 23

philnik added a reviewer for D114425: [clang] Add __builtin_bswap128: rsmith.
Tue, Nov 23, 2:10 AM · Restricted Project
philnik requested review of D114425: [clang] Add __builtin_bswap128.
Tue, Nov 23, 2:09 AM · Restricted Project

Mon, Nov 22

philnik added a comment to D114281: [libc++] Granularize the <random> header..

Since you move the stuff around anyways, maybe now it would be a good time to reformat it?

Mon, Nov 22, 9:14 AM · Restricted Project
philnik committed rG04a6dc06a07b: [libc++] [NFC] Mark P0858R0 as implemented (authored by philnik).
[libc++] [NFC] Mark P0858R0 as implemented
Mon, Nov 22, 8:59 AM
philnik closed D114344: [libc++] [NFC] Mark P0858R0 as implemented.
Mon, Nov 22, 8:59 AM · Restricted Project
philnik updated the summary of D114344: [libc++] [NFC] Mark P0858R0 as implemented.
Mon, Nov 22, 8:55 AM · Restricted Project
philnik planned changes to D110598: [libc++] P0980R1 (constexpr std::string).
Mon, Nov 22, 6:50 AM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).

Rebased

Mon, Nov 22, 6:37 AM · Restricted Project

Sun, Nov 21

philnik requested review of D114344: [libc++] [NFC] Mark P0858R0 as implemented.
Sun, Nov 21, 6:25 PM · Restricted Project
philnik committed rG1dc62f2653f8: [libc++] Implement P1272R4 (std::byteswap) (authored by philnik).
[libc++] Implement P1272R4 (std::byteswap)
Sun, Nov 21, 4:29 PM
philnik closed D114074: [libc++] Implement P1272R4 (std::byteswap).
Sun, Nov 21, 4:29 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Moved endif and corrected comment

Sun, Nov 21, 3:24 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Rebased again

Sun, Nov 21, 1:29 PM · Restricted Project
philnik updated the diff for D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).

Rebased

Sun, Nov 21, 1:23 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Rebased

Sun, Nov 21, 1:02 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).
  • added <utility> to test
Sun, Nov 21, 11:27 AM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Updated test and added braces

Sun, Nov 21, 9:46 AM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).
  • Use if constexpr() now
Sun, Nov 21, 8:03 AM · Restricted Project

Thu, Nov 18

philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Replaced erroneous _LIBCPP_HAS_NO_CONCEPTS with _LIBCPP_HAS_NO_IN128

Thu, Nov 18, 3:28 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Added explicit casts and conditionally allowing __int128_t now

Thu, Nov 18, 11:59 AM · Restricted Project
philnik planned changes to D110598: [libc++] P0980R1 (constexpr std::string).
Thu, Nov 18, 4:33 AM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).

Rebased and added GCC workaround

Thu, Nov 18, 4:07 AM · Restricted Project

Wed, Nov 17

philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Added static_assert

Wed, Nov 17, 1:53 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Updated test

Wed, Nov 17, 1:32 PM · Restricted Project
philnik added inline comments to D114074: [libc++] Implement P1272R4 (std::byteswap).
Wed, Nov 17, 12:16 PM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Updated tests and supporting int128_t/uint128_t now

Wed, Nov 17, 12:16 PM · Restricted Project
philnik added inline comments to D114094: [libc++] Refactor tests for trivially copyable atomics.
Wed, Nov 17, 8:57 AM · Restricted Project
philnik updated the diff for D114074: [libc++] Implement P1272R4 (std::byteswap).

Doing a byteswap now instead of a bitswap - I already wondered why it was called byteswap :D

Wed, Nov 17, 5:23 AM · Restricted Project
philnik requested review of D114074: [libc++] Implement P1272R4 (std::byteswap).
Wed, Nov 17, 2:33 AM · Restricted Project

Tue, Nov 16

philnik added inline comments to D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms..
Tue, Nov 16, 12:55 PM · Restricted Project
philnik committed rG1ff87ec235b8: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check (authored by philnik).
[libc++] [NFC] Disable clang-tidy's readability-identifier-naming check
Tue, Nov 16, 11:15 AM
philnik closed D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check.
Tue, Nov 16, 11:14 AM · Restricted Project
philnik added a reviewer for D110598: [libc++] P0980R1 (constexpr std::string): ldionne.

Maybe @ldionne should take a look at this PR too, since it's his paper.

Tue, Nov 16, 9:34 AM · Restricted Project
philnik accepted D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms..
Tue, Nov 16, 9:16 AM · Restricted Project
philnik added a comment to D110598: [libc++] P0980R1 (constexpr std::string).

ping

Tue, Nov 16, 2:08 AM · Restricted Project

Mon, Nov 15

philnik updated the summary of D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check.
Mon, Nov 15, 3:38 PM · Restricted Project
philnik added inline comments to D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms..
Mon, Nov 15, 9:20 AM · Restricted Project
philnik updated the diff for D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).

Moved constructor

Mon, Nov 15, 4:16 AM · Restricted Project
philnik updated the diff for D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).

Added sfinae tests and changed remove_cvfet_t to remove_cv_t

Mon, Nov 15, 2:00 AM · Restricted Project
philnik added a comment to D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check.

I don't think it is enabling anything automagically. At least that's not the intention.

Mon, Nov 15, 1:21 AM · Restricted Project
philnik retitled D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check from [libc++] Make clang-tidy usable in libc++ to [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check.
Mon, Nov 15, 1:07 AM · Restricted Project

Sun, Nov 14

philnik updated the summary of D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check.
Sun, Nov 14, 3:28 PM · Restricted Project
philnik requested review of D113849: [libc++] [NFC] Disable clang-tidy's readability-identifier-naming check.
Sun, Nov 14, 9:46 AM · Restricted Project
philnik added inline comments to D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).
Sun, Nov 14, 6:39 AM · Restricted Project
philnik updated the diff for D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).

Updated tests and implemented transform() correctly

Sun, Nov 14, 6:39 AM · Restricted Project

Tue, Nov 9

philnik added a comment to D113482: [libc++] Implement P1147R1 (Printing volatile T*).

I don't have commit permissions, so someone else has to commit it for me. "Nikolas Klauser" <nikolasklauser@berlin.de>

Tue, Nov 9, 7:51 AM · Restricted Project
philnik updated the diff for D113482: [libc++] Implement P1147R1 (Printing volatile T*).

Moved tests into new file

Tue, Nov 9, 7:46 AM · Restricted Project
philnik updated the diff for D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).

Updated Status and added feature-test macro

Tue, Nov 9, 7:27 AM · Restricted Project
philnik updated the diff for D113482: [libc++] Implement P1147R1 (Printing volatile T*).

Added synopsis and updated status

Tue, Nov 9, 7:20 AM · Restricted Project
philnik requested review of D113482: [libc++] Implement P1147R1 (Printing volatile T*).
Tue, Nov 9, 5:37 AM · Restricted Project
philnik retitled D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional) from Implement P0798R8 (Monadic operations for std::optional) to [libc++] Implement P0798R8 (Monadic operations for std::optional).
Tue, Nov 9, 5:25 AM · Restricted Project
philnik added a comment to D112869: [libc++] Implement P2186R2 (Remove Garbage Collection).

I don't have commit permissions, so someone else has to commit it for me. "Nikolas Klauser" <nikolasklauser@berlin.de>

Tue, Nov 9, 4:58 AM · Restricted Project
philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).
  • Changed split non-/constexpr tests into one and used TEST_IS_CONSTANT_EVALUATED
  • replaced main() with main(int, char**)
  • Updated feature-test macro
Tue, Nov 9, 12:51 AM · Restricted Project

Mon, Nov 8

philnik updated the diff for D113013: [libc++] Implement P1072R10 (std::basic_string::resize_and_overwrite).

Added feature-test macro and some minor changes

Mon, Nov 8, 10:29 AM · Restricted Project

Nov 8 2021

philnik requested review of D113408: [libc++] Implement P0798R8 (Monadic operations for std::optional).
Nov 8 2021, 8:30 AM · Restricted Project
philnik updated the diff for D113013: [libc++] Implement P1072R10 (std::basic_string::resize_and_overwrite).

Rebased and updated test

Nov 8 2021, 4:37 AM · Restricted Project

Nov 7 2021

philnik updated the diff for D110598: [libc++] P0980R1 (constexpr std::string).

Rebased onto main and some cleanup

Nov 7 2021, 3:51 PM · Restricted Project

Nov 3 2021

philnik updated the diff for D112869: [libc++] Implement P2186R2 (Remove Garbage Collection).
  • Removed .
Nov 3 2021, 11:40 AM · Restricted Project
philnik added inline comments to D113013: [libc++] Implement P1072R10 (std::basic_string::resize_and_overwrite).
Nov 3 2021, 11:36 AM · Restricted Project
philnik updated the diff for D113013: [libc++] Implement P1072R10 (std::basic_string::resize_and_overwrite).
  • Added move only tests
Nov 3 2021, 11:35 AM · Restricted Project

Nov 2 2021

philnik updated the diff for D113013: [libc++] Implement P1072R10 (std::basic_string::resize_and_overwrite).
  • Using __resize_default_init now and extended tests
Nov 2 2021, 2:43 PM · Restricted Project
philnik updated the diff for D112869: [libc++] Implement P2186R2 (Remove Garbage Collection).

Applied comments

Nov 2 2021, 10:44 AM · Restricted Project
philnik updated the diff for D113013: [libc++] Implement P1072R10 (std::basic_string::resize_and_overwrite).
  • Remove unused includes
Nov 2 2021, 6:40 AM · Restricted Project