Emilia Kond <emilia@rymiel.space>
User Details
- User Since
- Aug 16 2022, 7:52 AM (57 w, 5 d)
Fri, Sep 1
Jul 28 2023
Jul 18 2023
Shouldn't that regression already be handled by D155358?
Jul 15 2023
Was caused by 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37, thank you for fixing it up!
Jul 13 2023
Jun 30 2023
Thanks, this probably makes more sense than what I did before
Jun 29 2023
Address comments
Jun 28 2023
Jun 26 2023
It appears other operators aren't affected, after D153641 I would have not been surprised if && had become unary :)
Jun 24 2023
Add annotator test cases involving a lambda
Jun 23 2023
@HazardyKnusperkeks I'm not sure why it didn't recurse already, given that you even documented that it doesn't, but I chose to trust in the Beyoncé rule.
Jun 12 2023
Apply suggestions from review
May 20 2023
This patch also fixes https://github.com/llvm/llvm-project/issues/52911 (which is probably a duplicate anyway)
May 18 2023
May 17 2023
May 16 2023
Add annotator tests
May 15 2023
Start iteration from second token
I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for requires clauses, and I think it definitely beats the current buggy behavior where behaviour is conflated with BraceWrapping.AfterFunction.
But I'd like other reviewers to maybe have another look?
May 6 2023
Apr 24 2023
Apr 19 2023
(looks like you linked the same issue twice in the summary)
Apr 16 2023
Apr 11 2023
Apr 3 2023
Apr 2 2023
update commit message
Use MightBeFunctionDecl instead
Apr 1 2023
Mar 31 2023
Mar 30 2023
This is great!
Mar 29 2023
didn't go via the normal clang-format reviewers
Mar 25 2023
Mar 24 2023
Could this possibly be an issue for more esoteric underscore-less UDLs, like i?
Does the code need to search for a suffix, could it not detect the absence of a digit? Sorry if the questions are silly, I haven't really looked at this part of the formatter in depth
Mar 23 2023
So, it took me a while but I finally found where the logic is that makes the lambda braces stay on one line, but, now I'm not so sure if I should change it:
Mar 22 2023
Reduce column limit for macro test
Remove unnecessary musing
Fix true edge case
Mar 19 2023
Annotator tests (copied from format tests)
Yes, good point, I will do that
Mar 17 2023
Add release note
Okay, I planned changes because I had more ambitious plans for fixing this, but those didn't work out, so instead I made a separate issue (https://github.com/llvm/llvm-project/issues/61469).
This patch in its current state is a simple fix, so it's probably fine as is
Mar 15 2023
Use dyn_cast_if_present, otherwise we segfault in some tests
utilize getCurFunction()
Slightly rewrite CheckForNonPrimary for slightly better clarity
Mar 14 2023
Mar 11 2023
Mar 10 2023
Could you please clarify what you mean by "regressions" here? Isn't the behaviour of this syntax broken to begin with? It doesn't change anything about lambdas without requires-clauses
Mar 9 2023
Improve code flow in parseConstraintExpression