Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

rymiel (Emilia Kond)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 16 2022, 7:52 AM (57 w, 5 d)

Emilia Kond <emilia@rymiel.space>

Recent Activity

Fri, Sep 1

rymiel abandoned D140267: [clang-format] Allow line break between template closer and right paren.
Fri, Sep 1, 3:13 PM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2023

rymiel accepted D156228: [clang-format][NFCish] Obey debug settings.
Jul 28 2023, 1:22 AM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2023

rymiel added a comment to D154184: [clang-format] Correctly annotate */&/&& in operator function calls.

Shouldn't that regression already be handled by D155358?

Jul 18 2023, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2023

rymiel accepted D155358: [clang-format] Correctly annotate overloaded operator function name.

Was caused by 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37, thank you for fixing it up!

Jul 15 2023, 2:44 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2023

rymiel accepted D154550: [clang-format] Allow empty loops on a single line..
Jul 13 2023, 1:35 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2023

rymiel accepted D154184: [clang-format] Correctly annotate */&/&& in operator function calls.

Thanks, this probably makes more sense than what I did before

Jun 30 2023, 4:57 AM · Restricted Project, Restricted Project, Restricted Project

Jun 29 2023

rymiel committed rG4986f3f2f220: [clang-format] Correctly annotate operator free function call (authored by rymiel).
[clang-format] Correctly annotate operator free function call
Jun 29 2023, 9:53 AM · Restricted Project, Restricted Project
rymiel closed D153798: [clang-format] Correctly annotate operator free function call.
Jun 29 2023, 9:53 AM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D153798: [clang-format] Correctly annotate operator free function call.

Address comments

Jun 29 2023, 9:45 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2023

rymiel added inline comments to D153798: [clang-format] Correctly annotate operator free function call.
Jun 28 2023, 7:53 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2023

rymiel requested review of D153798: [clang-format] Correctly annotate operator free function call.
Jun 26 2023, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
rymiel committed rG15e14f129fe2: [clang-format] Preserve AmpAmpTokenType in nested parentheses (authored by rymiel).
[clang-format] Preserve AmpAmpTokenType in nested parentheses
Jun 26 2023, 2:30 AM · Restricted Project, Restricted Project
rymiel closed D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses.
Jun 26 2023, 2:30 AM · Restricted Project, Restricted Project, Restricted Project
rymiel accepted D153745: [clang-format] Fix bugs in annotating r_paren as C-style cast.

It appears other operators aren't affected, after D153641 I would have not been surprised if && had become unary :)

Jun 26 2023, 2:25 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added inline comments to D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm.
Jun 26 2023, 2:20 AM · Restricted Project, Restricted Project, Restricted Project
rymiel committed rG6e39b0ddf08a: [clang-format][NFC] Use correct test method for new tests (authored by rymiel).
[clang-format][NFC] Use correct test method for new tests
Jun 26 2023, 2:19 AM · Restricted Project, Restricted Project

Jun 24 2023

rymiel updated the diff for D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses.

Add annotator test cases involving a lambda

Jun 24 2023, 8:28 AM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2023

rymiel added a comment to D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses.

@HazardyKnusperkeks I'm not sure why it didn't recurse already, given that you even documented that it doesn't, but I chose to trust in the Beyoncé rule.

Jun 23 2023, 9:02 AM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses.
Jun 23 2023, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
rymiel committed rG7a38b3bfeb56: [clang-format] Respect ColumnLimit 0 line breaks in inline asm (authored by rymiel).
[clang-format] Respect ColumnLimit 0 line breaks in inline asm
Jun 23 2023, 7:35 AM · Restricted Project, Restricted Project
rymiel closed D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm.
Jun 23 2023, 7:35 AM · Restricted Project, Restricted Project, Restricted Project

Jun 12 2023

rymiel retitled D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm from [clang-format] Respect ColumnLimit 0 lines breaks in inline asm to [clang-format] Respect ColumnLimit 0 line breaks in inline asm.
Jun 12 2023, 6:21 AM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm.

Apply suggestions from review

Jun 12 2023, 6:19 AM · Restricted Project, Restricted Project, Restricted Project

May 20 2023

rymiel added a comment to D150403: [clang-format] Adjust braced list detection (try 2).

This patch also fixes https://github.com/llvm/llvm-project/issues/52911 (which is probably a duplicate anyway)

May 20 2023, 5:30 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2023

rymiel requested review of D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm.
May 18 2023, 12:29 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2023

rymiel committed rG06763ea5d8f9: [clang-format] Ignore first token when finding MustBreak (authored by rymiel).
[clang-format] Ignore first token when finding MustBreak
May 17 2023, 7:53 PM · Restricted Project, Restricted Project
rymiel closed D150614: [clang-format] Ignore first token when finding MustBreak.
May 17 2023, 7:52 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2023

rymiel committed rGe4d3e8880239: [clang-format] Don't allow template to be preceded by closing brace (authored by rymiel).
[clang-format] Don't allow template to be preceded by closing brace
May 16 2023, 3:39 PM · Restricted Project, Restricted Project
rymiel closed D150629: [clang-format] Don't allow template to be preceded by closing brace.
May 16 2023, 3:38 PM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D150629: [clang-format] Don't allow template to be preceded by closing brace.

Add annotator tests

May 16 2023, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
rymiel added inline comments to D150614: [clang-format] Ignore first token when finding MustBreak.
May 16 2023, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
rymiel added inline comments to D150614: [clang-format] Ignore first token when finding MustBreak.
May 16 2023, 12:56 PM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

rymiel added inline comments to D150614: [clang-format] Ignore first token when finding MustBreak.
May 15 2023, 11:35 PM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D150614: [clang-format] Ignore first token when finding MustBreak.

Start iteration from second token

May 15 2023, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D150629: [clang-format] Don't allow template to be preceded by closing brace.
May 15 2023, 6:23 PM · Restricted Project, Restricted Project, Restricted Project
rymiel accepted D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine.

I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for requires clauses, and I think it definitely beats the current buggy behavior where behaviour is conflated with BraceWrapping.AfterFunction.
But I'd like other reviewers to maybe have another look?

May 15 2023, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D150614: [clang-format] Ignore first token when finding MustBreak.
May 15 2023, 2:10 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2023

rymiel added inline comments to D150057: [clang-format] Fix consecutive alignments in #else blocks.
May 6 2023, 7:36 PM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2023

rymiel updated rymiel.
Apr 24 2023, 1:54 PM

Apr 19 2023

rymiel added a comment to D148777: [clang-format] Hanlde leading whitespaces for JSON files.

(looks like you linked the same issue twice in the summary)

Apr 19 2023, 8:21 PM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2023

rymiel accepted D148482: [clang-format][NFC] Output tokens on test assert.
Apr 16 2023, 3:05 PM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2023

rymiel committed rG5dc94b3356bd: [clang-format] Don't modify template arguments on the LHS of assignment (authored by rymiel).
[clang-format] Don't modify template arguments on the LHS of assignment
Apr 11 2023, 2:36 PM · Restricted Project, Restricted Project
rymiel closed D148024: [clang-format] Don't modify template arguments on the LHS of assignment.
Apr 11 2023, 2:36 PM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D148024: [clang-format] Don't modify template arguments on the LHS of assignment.
Apr 11 2023, 9:28 AM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2023

rymiel committed rGfd8678996296: [clang-format] Don't allow variable decls to have trailing return arrows (authored by rymiel).
[clang-format] Don't allow variable decls to have trailing return arrows
Apr 3 2023, 5:49 AM · Restricted Project, Restricted Project
rymiel closed D147377: [clang-format] Don't allow variable decls to have trailing return arrows.
Apr 3 2023, 5:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2023

rymiel updated the diff for D147377: [clang-format] Don't allow variable decls to have trailing return arrows.

update commit message

Apr 2 2023, 1:17 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added inline comments to D147377: [clang-format] Don't allow variable decls to have trailing return arrows.
Apr 2 2023, 1:16 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added inline comments to D147377: [clang-format] Don't allow variable decls to have trailing return arrows.
Apr 2 2023, 1:13 AM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D147377: [clang-format] Don't allow variable decls to have trailing return arrows.

Use MightBeFunctionDecl instead

Apr 2 2023, 1:13 AM · Restricted Project, Restricted Project, Restricted Project

Apr 1 2023

rymiel committed rG50acd67018a5: [clang-format] Don't format typename template parameters as expression (authored by rymiel).
[clang-format] Don't format typename template parameters as expression
Apr 1 2023, 6:48 AM · Restricted Project, Restricted Project
rymiel closed D147318: [clang-format] Don't format typename template parameters as expression.
Apr 1 2023, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D147377: [clang-format] Don't allow variable decls to have trailing return arrows.
Apr 1 2023, 6:43 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2023

rymiel added inline comments to D146101: [clang-format] Add BracedInitializerIndentWidth option..
Mar 31 2023, 5:22 AM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D147318: [clang-format] Don't format typename template parameters as expression.
Mar 31 2023, 5:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2023

rymiel accepted D147295: [clang-format] Don't misannotate left squares as lambda introducers.

This is great!

Mar 30 2023, 9:22 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2023

rymiel added inline comments to D146101: [clang-format] Add BracedInitializerIndentWidth option..
Mar 29 2023, 6:53 PM · Restricted Project, Restricted Project, Restricted Project
rymiel added a comment to D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing.

didn't go via the normal clang-format reviewers

Mar 29 2023, 2:05 PM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2023

rymiel committed rGbb4f6c4dca98: [clang-format] Treat NTTP default values as expressions (authored by rymiel).
[clang-format] Treat NTTP default values as expressions
Mar 25 2023, 6:43 PM · Restricted Project, Restricted Project
rymiel committed rGa8d2bff290e1: [clang-format] Don't wrap struct return types as structs (authored by rymiel).
[clang-format] Don't wrap struct return types as structs
Mar 25 2023, 6:43 PM · Restricted Project, Restricted Project
rymiel committed rG5409fb38372d: [clang-format] Annotate lambdas with requires clauses. (authored by rymiel).
[clang-format] Annotate lambdas with requires clauses.
Mar 25 2023, 6:43 PM · Restricted Project, Restricted Project
rymiel closed D146760: [clang-format] Treat NTTP default values as expressions.
Mar 25 2023, 6:43 PM · Restricted Project, Restricted Project, Restricted Project
rymiel closed D146281: [clang-format] Don't wrap struct return types as structs.
Mar 25 2023, 6:42 PM · Restricted Project, Restricted Project, Restricted Project
rymiel closed D145642: [clang-format] Annotate lambdas with requires clauses..
Mar 25 2023, 6:42 PM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2023

rymiel accepted D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator.

Could this possibly be an issue for more esoteric underscore-less UDLs, like i?
Does the code need to search for a suffix, could it not detect the absence of a digit? Sorry if the questions are silly, I haven't really looked at this part of the formatter in depth

Mar 24 2023, 4:34 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2023

rymiel requested review of D146760: [clang-format] Treat NTTP default values as expressions.
Mar 23 2023, 2:36 PM · Restricted Project, Restricted Project, Restricted Project
rymiel committed rGc70e360b355a: [clang-format] Allow trailing return types in macros (authored by rymiel).
[clang-format] Allow trailing return types in macros
Mar 23 2023, 10:39 AM · Restricted Project, Restricted Project
rymiel closed D141811: [clang-format] Allow trailing return types in macros.
Mar 23 2023, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added a comment to D145642: [clang-format] Annotate lambdas with requires clauses..

So, it took me a while but I finally found where the logic is that makes the lambda braces stay on one line, but, now I'm not so sure if I should change it:

Mar 23 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2023

rymiel updated the diff for D141811: [clang-format] Allow trailing return types in macros.

Reduce column limit for macro test

Mar 22 2023, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
rymiel committed rGead9644684e8: [clang-format] Annotate noexcept, explicit specifiers as containing expressions (authored by rymiel).
[clang-format] Annotate noexcept, explicit specifiers as containing expressions
Mar 22 2023, 11:25 AM · Restricted Project, Restricted Project
rymiel closed D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions.
Mar 22 2023, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added inline comments to D145642: [clang-format] Annotate lambdas with requires clauses..
Mar 22 2023, 11:18 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added a comment to D145642: [clang-format] Annotate lambdas with requires clauses..

Another point:
While testing this patch, the following still fails to recognise. Might be something special with true.

auto y = [&]<typename Callable>
    requires true(Callable && callable)
  { static_cast<void>(callable); };
Mar 22 2023, 11:18 AM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D145642: [clang-format] Annotate lambdas with requires clauses..

Remove unnecessary musing

Mar 22 2023, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D145642: [clang-format] Annotate lambdas with requires clauses..

Fix true edge case

Mar 22 2023, 11:16 AM · Restricted Project, Restricted Project, Restricted Project

Mar 19 2023

rymiel updated the diff for D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions.

Annotator tests (copied from format tests)

Mar 19 2023, 2:57 AM · Restricted Project, Restricted Project, Restricted Project
rymiel added a comment to D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions.

Yes, good point, I will do that

Mar 19 2023, 2:43 AM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2023

rymiel committed rG6acdf58919d5: [clang] Properly parse variable template requires clause in lambda (authored by rymiel).
[clang] Properly parse variable template requires clause in lambda
Mar 17 2023, 1:32 PM · Restricted Project, Restricted Project
rymiel closed D146140: [clang] Properly parse variable template requires clause in lambda.
Mar 17 2023, 1:31 PM · Restricted Project, Restricted Project
rymiel updated the diff for D146140: [clang] Properly parse variable template requires clause in lambda.

Add release note

Mar 17 2023, 9:54 AM · Restricted Project, Restricted Project
rymiel requested review of D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions.
Mar 17 2023, 3:59 AM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D146281: [clang-format] Don't wrap struct return types as structs.
Mar 17 2023, 3:30 AM · Restricted Project, Restricted Project, Restricted Project
rymiel requested review of D141811: [clang-format] Allow trailing return types in macros.

Okay, I planned changes because I had more ambitious plans for fixing this, but those didn't work out, so instead I made a separate issue (https://github.com/llvm/llvm-project/issues/61469).
This patch in its current state is a simple fix, so it's probably fine as is

Mar 17 2023, 2:46 AM · Restricted Project, Restricted Project, Restricted Project
rymiel accepted D145888: [clang-format] Fix non-case colons in Verilog case lines.
Mar 17 2023, 2:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2023

rymiel added a comment to D146140: [clang] Properly parse variable template requires clause in lambda.

Ah, also, before commit, ensure that pre-commit CI passes.

Mar 15 2023, 9:30 AM · Restricted Project, Restricted Project
rymiel updated the diff for D146140: [clang] Properly parse variable template requires clause in lambda.

Use dyn_cast_if_present, otherwise we segfault in some tests

Mar 15 2023, 9:28 AM · Restricted Project, Restricted Project
rymiel added inline comments to D146140: [clang] Properly parse variable template requires clause in lambda.
Mar 15 2023, 9:12 AM · Restricted Project, Restricted Project
rymiel updated the diff for D146140: [clang] Properly parse variable template requires clause in lambda.

utilize getCurFunction()

Mar 15 2023, 9:10 AM · Restricted Project, Restricted Project
rymiel added inline comments to D146140: [clang] Properly parse variable template requires clause in lambda.
Mar 15 2023, 8:25 AM · Restricted Project, Restricted Project
rymiel updated the diff for D146140: [clang] Properly parse variable template requires clause in lambda.

Slightly rewrite CheckForNonPrimary for slightly better clarity

Mar 15 2023, 8:24 AM · Restricted Project, Restricted Project
rymiel added inline comments to D146140: [clang] Properly parse variable template requires clause in lambda.
Mar 15 2023, 8:07 AM · Restricted Project, Restricted Project
rymiel requested review of D146140: [clang] Properly parse variable template requires clause in lambda.
Mar 15 2023, 7:50 AM · Restricted Project, Restricted Project

Mar 14 2023

rymiel committed rGc9163901c8e1: [clang-format] Treat &/&& as reference when followed by requires clause (authored by rymiel).
[clang-format] Treat &/&& as reference when followed by requires clause
Mar 14 2023, 3:46 AM · Restricted Project, Restricted Project
rymiel closed D145656: [clang-format] Treat &/&& as reference when followed by requires clause.
Mar 14 2023, 3:46 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2023

rymiel added inline comments to D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine.
Mar 11 2023, 12:11 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2023

rymiel added a comment to D145642: [clang-format] Annotate lambdas with requires clauses..

Could you please clarify what you mean by "regressions" here? Isn't the behaviour of this syntax broken to begin with? It doesn't change anything about lambdas without requires-clauses

Mar 10 2023, 11:52 PM · Restricted Project, Restricted Project, Restricted Project
rymiel added a comment to D145642: [clang-format] Annotate lambdas with requires clauses..

Would this patch make the end result look worse without "making the requires clause formatting of lambdas
match the formatting for functions"? If yes, then we should not land it just yet.

Mar 10 2023, 5:36 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2023

rymiel added inline comments to D145642: [clang-format] Annotate lambdas with requires clauses..
Mar 9 2023, 6:37 AM · Restricted Project, Restricted Project, Restricted Project
rymiel updated the diff for D145642: [clang-format] Annotate lambdas with requires clauses..

Improve code flow in parseConstraintExpression

Mar 9 2023, 6:36 AM · Restricted Project, Restricted Project, Restricted Project