Page MenuHomePhabricator

rymiel (Emilia Dreamer)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 16 2022, 7:52 AM (6 w, 4 d)

Emilia Dreamer <emilia@rymiel.space>

Recent Activity

Yesterday

rymiel committed rG1fa115b56979: [clang-format] Correctly indent closing brace of compound requires (authored by rymiel).
[clang-format] Correctly indent closing brace of compound requires
Fri, Sep 30, 10:35 PM · Restricted Project, Restricted Project
rymiel closed D134626: [clang-format] Correctly indent closing brace of compound requires.
Fri, Sep 30, 10:35 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks.

Extra consteval checks in SimplifyBooleanExprCheck

Fri, Sep 30, 1:18 AM · Restricted Project, Restricted Project
rymiel added a comment to D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks.

Thank you for pointing those out, I was indeed able to cause crashes from those locations

Fri, Sep 30, 1:18 AM · Restricted Project, Restricted Project

Thu, Sep 29

rymiel published D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator for review.

While this patch fixes the linked bug, but I encountered more questions that I would like second opinions on (see notes above)

Thu, Sep 29, 11:20 PM · Restricted Project, Restricted Project
rymiel updated the diff for D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks.

Add release note

Thu, Sep 29, 10:42 PM · Restricted Project, Restricted Project
rymiel added a comment to D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks.

Ping? This is fixing a segmentation fault. Please let me know if there are other people I should add as reviewers

Thu, Sep 29, 1:06 AM · Restricted Project, Restricted Project
rymiel updated the diff for D129443: [clang-format] Add option for aligning requires clause body.

Missed a spot when re-sorting

Thu, Sep 29, 12:44 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D129443: [clang-format] Add option for aligning requires clause body.

Resolve nits:

Thu, Sep 29, 12:42 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel commandeered D129443: [clang-format] Add option for aligning requires clause body.

Commandeering to finish the final nits as per https://github.com/llvm/llvm-project/issues/56283#issuecomment-1261653291

Thu, Sep 29, 12:38 AM · Unknown Object (Project), Restricted Project, Restricted Project

Tue, Sep 27

rymiel added a comment to D134626: [clang-format] Correctly indent closing brace of compound requires.

I built 2 versions of clang-format, before and after this patch, and made 2 separate clones of all of LLVM+clang and ran them through either, removing all .clang-formats, then ran a recursive diff.

Tue, Sep 27, 12:02 AM · Unknown Object (Project), Restricted Project, Restricted Project

Sun, Sep 25

rymiel added a comment to D134626: [clang-format] Correctly indent closing brace of compound requires.

Note: I don't have the historical insight to know why the code order was as it was. I simply tried yoinking the place where the level was being set to occur earlier, and it surprisingly seemed to work, and also seemed to not break any other tests; I hope it doesn't break something in some subtle way

Sun, Sep 25, 11:22 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a project to D134626: [clang-format] Correctly indent closing brace of compound requires: Unknown Object (Project).
Sun, Sep 25, 11:20 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D134626: [clang-format] Correctly indent closing brace of compound requires.
Sun, Sep 25, 11:20 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel committed rG39e6077d9723: [clang-format] Look ahead before consuming `bool` in requires clause. (authored by rymiel).
[clang-format] Look ahead before consuming `bool` in requires clause.
Sun, Sep 25, 11:16 AM · Restricted Project, Restricted Project
rymiel committed rG7847225576d5: [clang-format] Correctly annotate static and consteval lambdas (authored by rymiel).
[clang-format] Correctly annotate static and consteval lambdas
Sun, Sep 25, 11:16 AM · Restricted Project, Restricted Project
rymiel closed D134325: [clang-format] Look ahead before consuming `bool` in requires clause..
Sun, Sep 25, 11:16 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel closed D134587: [clang-format] Correctly annotate static and consteval lambdas.
Sun, Sep 25, 11:16 AM · Unknown Object (Project), Restricted Project, Restricted Project

Sat, Sep 24

rymiel updated the summary of D134587: [clang-format] Correctly annotate static and consteval lambdas.
Sat, Sep 24, 7:34 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D134587: [clang-format] Correctly annotate static and consteval lambdas.
Sat, Sep 24, 7:32 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D134325: [clang-format] Look ahead before consuming `bool` in requires clause..

Remove redundant assert

Sat, Sep 24, 7:08 AM · Unknown Object (Project), Restricted Project, Restricted Project

Tue, Sep 20

rymiel added a project to D134325: [clang-format] Look ahead before consuming `bool` in requires clause.: Unknown Object (Project).
Tue, Sep 20, 4:34 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D134325: [clang-format] Look ahead before consuming `bool` in requires clause..
Tue, Sep 20, 4:33 PM · Unknown Object (Project), Restricted Project, Restricted Project

Sun, Sep 18

rymiel committed rG8dab45274000: [clang-format] Disallow requires clauses to become function declarations (authored by rymiel).
[clang-format] Disallow requires clauses to become function declarations
Sun, Sep 18, 6:06 PM · Restricted Project, Restricted Project
rymiel committed rG0bf63f0d1b6b: [clang-format] Disallow trailing return arrows to be operators (authored by rymiel).
[clang-format] Disallow trailing return arrows to be operators
Sun, Sep 18, 6:06 PM · Restricted Project, Restricted Project
rymiel closed D134052: [clang-format] Disallow requires clauses to become function declarations.
Sun, Sep 18, 6:06 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel closed D134049: [clang-format] Disallow trailing return arrows to be operators.
Sun, Sep 18, 6:06 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a comment to D134049: [clang-format] Disallow trailing return arrows to be operators.

Thank you for the vote of confidence!! It went way more quickly than I expected; I now already have commit access!

Sun, Sep 18, 4:21 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a comment to D134049: [clang-format] Disallow trailing return arrows to be operators.
Sun, Sep 18, 11:58 AM · Unknown Object (Project), Restricted Project, Restricted Project

Fri, Sep 16

rymiel updated the diff for D134049: [clang-format] Disallow trailing return arrows to be operators.

Address review comments

Fri, Sep 16, 5:01 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D134049: [clang-format] Disallow trailing return arrows to be operators.

Also test the annotated value of the arrow

Fri, Sep 16, 9:57 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added inline comments to D134049: [clang-format] Disallow trailing return arrows to be operators.
Fri, Sep 16, 9:54 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a project to D134052: [clang-format] Disallow requires clauses to become function declarations: Unknown Object (Project).
Fri, Sep 16, 8:50 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D134052: [clang-format] Disallow requires clauses to become function declarations.
Fri, Sep 16, 8:49 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated rymiel.
Fri, Sep 16, 7:57 AM
rymiel added a project to D134049: [clang-format] Disallow trailing return arrows to be operators: Unknown Object (Project).
Fri, Sep 16, 7:52 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D134049: [clang-format] Disallow trailing return arrows to be operators.
Fri, Sep 16, 7:52 AM · Unknown Object (Project), Restricted Project, Restricted Project

Thu, Sep 15

rymiel added inline comments to D132061: [libc++] static_assert preconditions in vector.
Thu, Sep 15, 10:56 AM · Restricted Project, Restricted Project

Wed, Sep 7

rymiel added a comment to D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks.

Note for reviewing:

Wed, Sep 7, 4:46 AM · Restricted Project, Restricted Project
rymiel requested review of D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks.
Wed, Sep 7, 4:42 AM · Restricted Project, Restricted Project

Mon, Sep 5

rymiel updated the diff for D132295: [clang-format] Change heuristic for locating lambda template arguments.

Rebase on main

Mon, Sep 5, 8:23 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a comment to D132189: [clang-format] Don't put `noexcept` on empty line following constructor.

Emilia Dreamer <emilia@rymiel.space>

Mon, Sep 5, 12:44 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 29 2022

rymiel updated the diff for D132762: [clang-format] Allow `throw` to be a keyword in front of casts.

Add extra tests for spacing options

Aug 29 2022, 3:43 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D132762: [clang-format] Allow `throw` to be a keyword in front of casts.

Add a few token annotator tests

Aug 29 2022, 10:43 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 26 2022

rymiel added a project to D132762: [clang-format] Allow `throw` to be a keyword in front of casts: Unknown Object (Project).
Aug 26 2022, 2:35 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D132762: [clang-format] Allow `throw` to be a keyword in front of casts.
Aug 26 2022, 2:35 PM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 22 2022

rymiel updated the diff for D132295: [clang-format] Change heuristic for locating lambda template arguments.

Remove trailing newlines in added format tests

Aug 22 2022, 8:39 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 21 2022

rymiel updated the diff for D132295: [clang-format] Change heuristic for locating lambda template arguments.

Add a few format tests in addition to the annotator tests

Aug 21 2022, 6:19 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 20 2022

rymiel added a project to D132295: [clang-format] Change heuristic for locating lambda template arguments: Unknown Object (Project).
Aug 20 2022, 6:49 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D132295: [clang-format] Change heuristic for locating lambda template arguments.
Aug 20 2022, 6:49 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D132189: [clang-format] Don't put `noexcept` on empty line following constructor.

Extra tests, including token annotator tests

Aug 20 2022, 3:37 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 18 2022

rymiel added a comment to D132189: [clang-format] Don't put `noexcept` on empty line following constructor.

Note for reviewing:
The criteria for reaching this misformat are extremely specific, requiring a single-character type or a type of a type consisting of all-uppercase letter, which are poor style on their own.
I am also unsure how often this all-uppercase macro-like attribute syntax is relied upon

Aug 18 2022, 4:34 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a project to D132189: [clang-format] Don't put `noexcept` on empty line following constructor: Unknown Object (Project).
Aug 18 2022, 4:28 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D132189: [clang-format] Don't put `noexcept` on empty line following constructor.
Aug 18 2022, 4:28 PM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 17 2022

rymiel added a comment to D131978: [clang-format] Concepts: allow identifiers after negation.

It seems that even with this patch, there is seemingly weird formatting with the negation in requires clauses, such as:

Aug 17 2022, 11:34 AM · Unknown Object (Project), Restricted Project, Restricted Project

Aug 16 2022

rymiel added a comment to D131978: [clang-format] Concepts: allow identifiers after negation.

It's late (where I am). I thought we had something like ClosesRequiresClause for concepts too.
But on the other hand, this should affect requires clauses, right? So a test for that would fail before your patch.

Aug 16 2022, 2:00 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel updated the diff for D131978: [clang-format] Concepts: allow identifiers after negation.

Added negation unary operator check to TokenAnnotatorTest

Aug 16 2022, 1:13 PM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel added a project to D131978: [clang-format] Concepts: allow identifiers after negation: Unknown Object (Project).
Aug 16 2022, 10:06 AM · Unknown Object (Project), Restricted Project, Restricted Project
rymiel requested review of D131978: [clang-format] Concepts: allow identifiers after negation.
Aug 16 2022, 10:04 AM · Unknown Object (Project), Restricted Project, Restricted Project