Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

ldionne (Louis Dionne)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (450 w, 6 d)
Roles
Administrator

Recent Activity

Today

ldionne updated the diff for D101206: [libc++] Remove UB in list, forward_list and __hash_table.

Fix gnu_cxx test on GCC. Remove CFI tests which are unnecessary according to EricWF (after offline discussion).

Wed, Oct 4, 2:25 PM · Restricted Project, Restricted Project
ldionne updated the diff for D99567: [libc++] Make future_error constructor standard-compliant.

Fix XFAIL for real.

Wed, Oct 4, 1:45 PM · Restricted Project, Restricted Project
ldionne committed rGd32edcb86dfd: [libc++][NFC] Fix broken formatting in comment (authored by ldionne).
[libc++][NFC] Fix broken formatting in comment
Wed, Oct 4, 1:39 PM · Restricted Project, Restricted Project
ldionne committed rG7a73a2c24121: [libc++][NFC] Document missing __pstl_merge function in PSTL basis operations (authored by ldionne).
[libc++][NFC] Document missing __pstl_merge function in PSTL basis operations
Wed, Oct 4, 10:39 AM · Restricted Project, Restricted Project

Yesterday

ldionne added inline comments to D101206: [libc++] Remove UB in list, forward_list and __hash_table.
Tue, Oct 3, 11:17 AM · Restricted Project, Restricted Project
ldionne updated the diff for D101206: [libc++] Remove UB in list, forward_list and __hash_table.

Fix CI issues.

Tue, Oct 3, 11:16 AM · Restricted Project, Restricted Project
ldionne committed rG3a44223711ec: [libc++] Fix test failing on macOS with modules enabled (authored by ldionne).
[libc++] Fix test failing on macOS with modules enabled
Tue, Oct 3, 10:54 AM · Restricted Project, Restricted Project
ldionne requested changes to D67086: Implement syncstream (p0053).

Thanks a lot for picking up this patch! I have a bunch of comments but this is starting to look pretty good.

Tue, Oct 3, 10:41 AM · Restricted Project, Restricted Project
ldionne updated the diff for D99567: [libc++] Make future_error constructor standard-compliant.

XFAIL test on Windows

Tue, Oct 3, 5:48 AM · Restricted Project, Restricted Project

Mon, Oct 2

ldionne committed rG705d21f6ca50: Revert "[ci] Diff against main when determining what files have changed for pre… (authored by ldionne).
Revert "[ci] Diff against main when determining what files have changed for pre…
Mon, Oct 2, 8:03 AM · Restricted Project
ldionne added a reverting change for rGec9d80ec43f5: [ci] Diff against main when determining what files have changed for pre-commit…: rG705d21f6ca50: Revert "[ci] Diff against main when determining what files have changed for pre….
Mon, Oct 2, 8:03 AM · Restricted Project
ldionne committed rG6fe4e033f07d: [libc++] Optimize vector push_back to avoid continuous load and store of end… (authored by mvels).
[libc++] Optimize vector push_back to avoid continuous load and store of end…
Mon, Oct 2, 6:13 AM · Restricted Project, Restricted Project
ldionne closed D80588: [libc++] Optimize vector push_back to avoid continuous load and store of end pointer.
Mon, Oct 2, 6:13 AM · Restricted Project, Restricted Project

Thu, Sep 28

ldionne updated the diff for D99567: [libc++] Make future_error constructor standard-compliant.

Adjust ignore_format.txt

Thu, Sep 28, 12:03 PM · Restricted Project, Restricted Project
ldionne requested changes to D154246: [libc++] Add check for building with picolibc.

This looks pretty clean, a lot cleaner than I would have expected for an embedded c library. I have a few questions and comments but I don't see major blockers at this point.

Thu, Sep 28, 11:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne committed rG6b03d8aa9432: [libc++][NFC] Remove spurious check for is-constant-evaluated (authored by ldionne).
[libc++][NFC] Remove spurious check for is-constant-evaluated
Thu, Sep 28, 11:21 AM · Restricted Project, Restricted Project
ldionne updated the diff for D101206: [libc++] Remove UB in list, forward_list and __hash_table.

Update after discussion with Eric. This allows fixing the UB in all standard modes and simplifies the code quite a bit!

Thu, Sep 28, 11:13 AM · Restricted Project, Restricted Project
ldionne added inline comments to D101206: [libc++] Remove UB in list, forward_list and __hash_table.
Thu, Sep 28, 10:49 AM · Restricted Project, Restricted Project
ldionne added inline comments to D156956: [libc++] Optimize ranges::count for __bit_iterators.
Thu, Sep 28, 9:31 AM · Restricted Project, Restricted Project
ldionne accepted D156956: [libc++] Optimize ranges::count for __bit_iterators.

LGTM with comments applied and CI passing.

Thu, Sep 28, 9:31 AM · Restricted Project, Restricted Project
ldionne updated subscribers of D155312: [libc++] Use _Complex for multiplication and division of complex floating point types.

@mstorsjo Do you know what's the state of things for compiler-rt on Windows?

Thu, Sep 28, 9:16 AM · Restricted Project, Restricted Project
ldionne added inline comments to D154796: [libc++] Recategorize additional instantiations in the dylib as availability macros.
Thu, Sep 28, 9:01 AM · Restricted Project, Restricted Project

Wed, Sep 27

ldionne added a comment to D157809: [libc++] Optimize std::find for segmented iterators.

This is now https://github.com/llvm/llvm-project/pull/67224

Wed, Sep 27, 11:26 AM · Restricted Project, Restricted Project
ldionne accepted D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

LGTM with minor nitpick. You can ignore the CI failures since they are unrelated and have been fixed since then. Thanks!

Wed, Sep 27, 8:44 AM · Restricted Project, Restricted Project
ldionne updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

Format added test.

Wed, Sep 27, 6:57 AM · Restricted Project, Restricted Project
ldionne committed rG6e1dcc933511: [libc++] Refactor string unit tests to ease addition of new allocators (authored by ldionne).
[libc++] Refactor string unit tests to ease addition of new allocators
Wed, Sep 27, 6:02 AM · Restricted Project, Restricted Project
ldionne closed D140550: [libc++] Refactor string unit tests to ease addition of new allocators.
Wed, Sep 27, 6:02 AM · Restricted Project, Restricted Project

Tue, Sep 26

ldionne updated the diff for D140550: [libc++] Refactor string unit tests to ease addition of new allocators.

Update ignore_format.txt

Tue, Sep 26, 4:10 PM · Restricted Project, Restricted Project
ldionne updated subscribers of D99567: [libc++] Make future_error constructor standard-compliant.

Heads up for vendors. I'll ship this at the end of the week if nobody chimes in. If this causes problems after being landed, there's a few ways to try and reduce the scope of breakage.

Tue, Sep 26, 11:14 AM · Restricted Project, Restricted Project
ldionne updated the diff for D99567: [libc++] Make future_error constructor standard-compliant.

Update patch message.

Tue, Sep 26, 11:06 AM · Restricted Project, Restricted Project
ldionne updated the diff for D99567: [libc++] Make future_error constructor standard-compliant.

Rebase the patch, avoid ABI break, make 100% conforming (at the cost of potential breakage).

Tue, Sep 26, 11:05 AM · Restricted Project, Restricted Project
ldionne commandeered D99567: [libc++] Make future_error constructor standard-compliant.

[Github PR transition cleanup]

Tue, Sep 26, 9:57 AM · Restricted Project, Restricted Project
ldionne updated the diff for D140550: [libc++] Refactor string unit tests to ease addition of new allocators.

Go over all the tests and fix some refactorings that weren't the way they should.

Tue, Sep 26, 9:37 AM · Restricted Project, Restricted Project
ldionne updated the diff for D63230: [libc++] Implement std::experimental::observer_ptr.

Fix formatting.

Tue, Sep 26, 6:58 AM · Restricted Project, Restricted Project
ldionne accepted D145376: [libc++] add declval failure assertion for instantiation.
Tue, Sep 26, 6:48 AM · Restricted Project, Restricted Project
ldionne updated the diff for D145376: [libc++] add declval failure assertion for instantiation.

Rebase and apply comments. I will merge this if CI is green. Per the update in https://github.com/llvm/llvm-project/issues/61254, I don't think this causes any well-formed code to be rejected, and it fixes a real bug (https://github.com/llvm/llvm-project/issues/61202).

Tue, Sep 26, 6:48 AM · Restricted Project, Restricted Project
ldionne commandeered D145376: [libc++] add declval failure assertion for instantiation.

Is this code ODR used? I suspect it is, and so it's not valid, but I'm not sure and I ran into a bunch of different instances of this pattern while testing this change.

template <class T>
decltype(auto) compute_return_type() {
    // ...
    // stuff that makes this function look reasonable...
    // ...
    return std::declval<T>();
}

using MyT = decltype(compute_return_type<int>());
Tue, Sep 26, 6:33 AM · Restricted Project, Restricted Project
ldionne abandoned D84045: [libcxx][lit] Add a new executor to collect test binaries.
Tue, Sep 26, 6:30 AM · Restricted Project, Restricted Project
ldionne commandeered D84045: [libcxx][lit] Add a new executor to collect test binaries.

[Github PR Transition Cleanup]

Tue, Sep 26, 6:30 AM · Restricted Project, Restricted Project
ldionne committed rG0106ae3cce01: [libc++] Use _Lazy in tuple constructors (authored by ldionne).
[libc++] Use _Lazy in tuple constructors
Tue, Sep 26, 6:24 AM · Restricted Project, Restricted Project
ldionne closed D132509: [libc++] Use _Lazy in tuple constructors.
Tue, Sep 26, 6:24 AM · Restricted Project, Restricted Project
ldionne accepted D132509: [libc++] Use _Lazy in tuple constructors.
Tue, Sep 26, 6:23 AM · Restricted Project, Restricted Project
ldionne updated the diff for D64818: [libc++] Implement missing filesystem::path constructors with locale.

Fix C++03 build.

Tue, Sep 26, 6:22 AM · Restricted Project, Restricted Project

Mon, Sep 25

ldionne updated the diff for D63230: [libc++] Implement std::experimental::observer_ptr.

Add missing include to test.

Mon, Sep 25, 3:36 PM · Restricted Project, Restricted Project
ldionne updated the diff for D132509: [libc++] Use _Lazy in tuple constructors.

Reduce to tuples of size 512, otherwise we don't have enough memory on some builders.

Mon, Sep 25, 3:32 PM · Restricted Project, Restricted Project
ldionne updated the diff for D64818: [libc++] Implement missing filesystem::path constructors with locale.

Add missing _LIBCPP_HIDE_FROM_ABI

Mon, Sep 25, 3:26 PM · Restricted Project, Restricted Project
ldionne accepted D80588: [libc++] Optimize vector push_back to avoid continuous load and store of end pointer.

A little more digging into this assembly can be found here: https://godbolt.org/z/TrWY7YMWW (or with LLVM IR: https://godbolt.org/z/69xzf7r74)

I think this change is good and safe. Still pondering the "how to test this" question.

Mon, Sep 25, 3:07 PM · Restricted Project, Restricted Project
ldionne added a comment to D155562: [libcxx] [test] Use -fms-runtime-lib= for picking the CRT to use.

@mstorsjo Can you rebase this now? I just dropped support for Clang 15.

Mon, Sep 25, 2:56 PM · Restricted Project, Restricted Project
ldionne committed rGba94646c76e3: [libc++][NFC] Qualify mention of va_list with std:: in documentation (authored by ldionne).
[libc++][NFC] Qualify mention of va_list with std:: in documentation
Mon, Sep 25, 10:40 AM · Restricted Project, Restricted Project
ldionne committed rG273ece4640e2: [libc++] Add missing files to ignore_format.txt (authored by ldionne).
[libc++] Add missing files to ignore_format.txt
Mon, Sep 25, 9:09 AM · Restricted Project, Restricted Project
ldionne abandoned D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.
Mon, Sep 25, 7:10 AM · Restricted Project, Restricted Project, Restricted Project
ldionne commandeered D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

Abandoning to clean up the review queue.

Mon, Sep 25, 7:10 AM · Restricted Project, Restricted Project, Restricted Project
ldionne added inline comments to D158919: [libunwind][WebAssembly] Support Wasm EH.
Mon, Sep 25, 6:39 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 21

ldionne added inline comments to D100005: [libc++] Use the default initializer for char_type in std::num_get::do_get..
Thu, Sep 21, 2:38 PM · Restricted Project, Restricted Project
ldionne requested changes to D154796: [libc++] Recategorize additional instantiations in the dylib as availability macros.

Requesting changes since I'd like to discuss the latest changes to the patch during our next 1:1

Thu, Sep 21, 2:35 PM · Restricted Project, Restricted Project
ldionne committed rG0065d75099cd: [runtimes][NFC] Remove old Lit annotations for gcc-12 and clang-14 (authored by ldionne).
[runtimes][NFC] Remove old Lit annotations for gcc-12 and clang-14
Thu, Sep 21, 2:13 PM · Restricted Project, Restricted Project
ldionne committed rG2ab31b6bab14: [libc++] When run in verbose mode, ssh.py should print to stderr, not stdout (authored by ldionne).
[libc++] When run in verbose mode, ssh.py should print to stderr, not stdout
Thu, Sep 21, 1:37 PM · Restricted Project, Restricted Project
ldionne committed rG1ce70139ff28: [libc++] Simplify ssh.py by not passing args everywhere (authored by ldionne).
[libc++] Simplify ssh.py by not passing args everywhere
Thu, Sep 21, 1:37 PM · Restricted Project, Restricted Project
ldionne committed rGd2b71c7a1aef: [libc++] Fix how we run codesign in the test suite when --codesign_identity is… (authored by ldionne).
[libc++] Fix how we run codesign in the test suite when --codesign_identity is…
Thu, Sep 21, 10:35 AM · Restricted Project, Restricted Project
ldionne committed rG77d8ce5bb841: [libc++] Add a --verbose option to ssh.py to help debug failures (authored by ldionne).
[libc++] Add a --verbose option to ssh.py to help debug failures
Thu, Sep 21, 10:35 AM · Restricted Project, Restricted Project
ldionne committed rG7fcbb64fca5e: [runtimes] Workaround a subtle linker issue on macOS in the CI (authored by ldionne).
[runtimes] Workaround a subtle linker issue on macOS in the CI
Thu, Sep 21, 8:30 AM · Restricted Project, Restricted Project
ldionne committed rG24161bcc4448: [libc++] Move a few XFAILs to UNSUPPORTED for consistency (authored by ldionne).
[libc++] Move a few XFAILs to UNSUPPORTED for consistency
Thu, Sep 21, 4:43 AM · Restricted Project, Restricted Project
ldionne committed rG354c99bb5f80: [libc++] Temporarily disable std::cin tests on Windows -> Linux cross compiler (authored by ldionne).
[libc++] Temporarily disable std::cin tests on Windows -> Linux cross compiler
Thu, Sep 21, 4:40 AM · Restricted Project, Restricted Project
ldionne updated the diff for D150897: [runtimes] Use LLVM libunwind from libc++abi and compiler-rt by default.

Rebase and try to fix CI.

Thu, Sep 21, 4:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne committed rG910b76a00271: [libc++] Implement LWG-3655: The INVOKE operation and union types (authored by fsb4000).
[libc++] Implement LWG-3655: The INVOKE operation and union types
Thu, Sep 21, 2:24 AM · Restricted Project, Restricted Project
ldionne closed D144645: [libc++] Implement LWG-3655: The INVOKE operation and union types..
Thu, Sep 21, 2:23 AM · Restricted Project, Restricted Project
ldionne accepted D144645: [libc++] Implement LWG-3655: The INVOKE operation and union types..
Thu, Sep 21, 2:23 AM · Restricted Project, Restricted Project

Wed, Sep 20

ldionne committed rG0740b7e3e2fa: [libc++abi][NFC] Remove mentions of LIBCXXABI_SHARED_LIBRARIES (authored by ldionne).
[libc++abi][NFC] Remove mentions of LIBCXXABI_SHARED_LIBRARIES
Wed, Sep 20, 11:52 AM · Restricted Project
ldionne closed D57646: [libcxx] Specify unwind lib before other system libraries..

[Github PR transition cleanup]

Wed, Sep 20, 11:48 AM · Restricted Project, Restricted Project
ldionne committed rGe3b166229ffe: [libc++] Sort available features before printing them (authored by ldionne).
[libc++] Sort available features before printing them
Wed, Sep 20, 6:53 AM · Restricted Project, Restricted Project

Tue, Sep 19

ldionne committed rG2b7f11a6523b: [libc++] Warn if an unsupported compiler is used (authored by philnik).
[libc++] Warn if an unsupported compiler is used
Tue, Sep 19, 8:46 PM · Restricted Project, Restricted Project
ldionne closed D158214: [libc++] Warn if an unsupported compiler is used.
Tue, Sep 19, 8:46 PM · Restricted Project, Restricted Project
ldionne updated the diff for D158214: [libc++] Warn if an unsupported compiler is used.

Encode the real version of Clang that we support right now.

Tue, Sep 19, 3:11 PM · Restricted Project, Restricted Project
ldionne commandeered D158214: [libc++] Warn if an unsupported compiler is used.

Commandeering cause I want to land this.

Tue, Sep 19, 3:10 PM · Restricted Project, Restricted Project
ldionne added inline comments to D158214: [libc++] Warn if an unsupported compiler is used.
Tue, Sep 19, 3:08 PM · Restricted Project, Restricted Project
ldionne added a comment to D137640: [libc++] Implement P2467R1: Support exclusive mode for fstreams.

Blocked on https://github.com/llvm/llvm-project/pull/66824.

Tue, Sep 19, 2:30 PM · Restricted Project, Restricted Project
ldionne updated the diff for D132509: [libc++] Use _Lazy in tuple constructors.

Address comments.

Tue, Sep 19, 2:13 PM · Restricted Project, Restricted Project
ldionne updated the diff for D144645: [libc++] Implement LWG-3655: The INVOKE operation and union types..

Rebase and address comments.

Tue, Sep 19, 2:08 PM · Restricted Project, Restricted Project
ldionne commandeered D144645: [libc++] Implement LWG-3655: The INVOKE operation and union types..

[Github PR transition cleanup]

Tue, Sep 19, 1:54 PM · Restricted Project, Restricted Project
ldionne committed rGbe8c2df2b15b: [libc++][NFC] Clean up std::__call_once (authored by DanielMcIntosh-IBM).
[libc++][NFC] Clean up std::__call_once
Tue, Sep 19, 1:17 PM · Restricted Project, Restricted Project
ldionne closed D112319: [libc++][NFC] Clean up std::__call_once.
Tue, Sep 19, 1:17 PM · Restricted Project, Restricted Project
ldionne accepted D112319: [libc++][NFC] Clean up std::__call_once.
Tue, Sep 19, 1:16 PM · Restricted Project, Restricted Project
ldionne updated the diff for D132509: [libc++] Use _Lazy in tuple constructors.

Rebase. Fix tests and comments.

Tue, Sep 19, 12:12 PM · Restricted Project, Restricted Project
ldionne added inline comments to D132509: [libc++] Use _Lazy in tuple constructors.
Tue, Sep 19, 12:12 PM · Restricted Project, Restricted Project
ldionne abandoned D154873: [runtimes] Simplify the layout of backdeployment testing roots.

[Github PR transition cleanup]

Tue, Sep 19, 11:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne abandoned D158694: [libc++] Re-enable the __std_module test.

[Github PR transition cleanup]

Tue, Sep 19, 11:43 AM · Restricted Project, Restricted Project, Restricted Project
ldionne abandoned D158297: [libc++] Re-enable back-deployment testing on arm64.

[Github PR transition cleanup]

Tue, Sep 19, 11:43 AM · Restricted Project, Restricted Project
ldionne abandoned D158282: [libc++] Stop using strict availability markup on Apple.

[Github PR transition cleanup]

Tue, Sep 19, 11:39 AM · Restricted Project, Restricted Project
ldionne added a comment to D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang.

Gentle ping. Are we waiting on anything to ship this?

Tue, Sep 19, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
ldionne removed reviewers for D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.: Restricted Project, ldionne.
Tue, Sep 19, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D64818: [libc++] Implement missing filesystem::path constructors with locale.

Rebase. Simplify the implementation a bit. Remove some tests for SFINAE-friendliness that are not necessary according to my reading of the spec.

Tue, Sep 19, 11:32 AM · Restricted Project, Restricted Project
ldionne commandeered D64818: [libc++] Implement missing filesystem::path constructors with locale.

[Github PR transition cleanup]

Tue, Sep 19, 11:31 AM · Restricted Project, Restricted Project
ldionne abandoned D123979: [msan][libcxx] Enable -fsanitize-memory-param-retval.
Tue, Sep 19, 9:36 AM · Restricted Project, Restricted Project
ldionne commandeered D123979: [msan][libcxx] Enable -fsanitize-memory-param-retval.

[Github PR transition cleanup]

Tue, Sep 19, 9:36 AM · Restricted Project, Restricted Project
ldionne added a comment to D157283: [clang] Match -isysroot behaviour with system compiler on Darwin.

@ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa (I don't know what it is)?
Alternatively I can figure out what to do with this test (it is just copies of the same test with minimal modifications) with a hint how it was resolved to make sure that it worn diverse from want it should be on Darwin.

Tue, Sep 19, 9:34 AM · Restricted Project, Restricted Project
ldionne added a comment to D89001: [clang] Don't look into <sysroot> for C++ headers if they are found alongside the toolchain.

I just did some digging. We completed the transition to the libcxx-headers-in-the-SDK already, and now upstream and downstream Clang are the same with respect to those search paths. I think it might just be the case that you need the very latest AppleClang for that to be reflected (as you know AppleClang always lags a bit behind). So I think there's nothing special to do here, upstream behaves properly and downstream will catch up automatically.

Tue, Sep 19, 9:30 AM · Restricted Project, Restricted Project
ldionne abandoned D58879: Implement uses-allocator (P0591R4).
Tue, Sep 19, 9:09 AM · Restricted Project
ldionne commandeered D58879: Implement uses-allocator (P0591R4).

[Github PR transition cleanup]

Tue, Sep 19, 9:09 AM · Restricted Project
ldionne abandoned D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py.

Please open as a github PR is you still want to do this (I think it makes sense but we have to drain our review queue here).

Tue, Sep 19, 9:07 AM · Restricted Project, Restricted Project
ldionne commandeered D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py.

[Github PR transition cleanup]

Tue, Sep 19, 9:07 AM · Restricted Project, Restricted Project