Page MenuHomePhabricator

ldionne (Louis Dionne)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (380 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

ldionne updated the diff for D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.

Rebase onto main.

Fri, May 27, 2:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne added inline comments to D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.
Fri, May 27, 2:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne accepted D126098: [libc++] Remove unused __functional includes.

This needs a release note to mention that we removed some includes of <functional>, since this may break users. Other than that, LGTM.

Fri, May 27, 1:51 PM · Restricted Project, Restricted Project
ldionne accepted D126244: [libc++] Granularize more of <type_traits>.
Fri, May 27, 1:50 PM · Restricted Project, Restricted Project
ldionne added a comment to D126469: [libc++] Use __enable_if_t and is_integral in cstddef.

Oops, but the CI is failing due to a circular dependency.

Fri, May 27, 1:48 PM · Restricted Project, Restricted Project
ldionne accepted D126469: [libc++] Use __enable_if_t and is_integral in cstddef.
Fri, May 27, 1:47 PM · Restricted Project, Restricted Project
ldionne committed rGa7f9895cc189: [runtimes] Rename various libcpp-has-no-XYZ Lit features to just no-XYZ (authored by ldionne).
[runtimes] Rename various libcpp-has-no-XYZ Lit features to just no-XYZ
Fri, May 27, 12:25 PM · Restricted Project, Restricted Project
ldionne closed D126482: [runtimes] Rename various libcpp-has-no-XYZ Lit features to just no-XYZ.
Fri, May 27, 12:25 PM · Restricted Project, Restricted Project, Restricted Project
ldionne accepted D126482: [runtimes] Rename various libcpp-has-no-XYZ Lit features to just no-XYZ.
Fri, May 27, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
ldionne requested changes to D126249: [libc++] Remove _LIBCPP_ALIGNOF.

As much as I don't like having ugly macros like _LIBCPP_ALIGNOF, I dislike even more defining a keyword as a macro, especially in the library:

  • If the compiler ever wants to support alignof as an extension in C++03, we'll need coordination between the library and the compiler.
  • This is technically a breaking change for C++03 users because they are allowed to use alignof as a name, and we're not allowed to define identifiers outside of our namespace. Concretely, I do suspect this may break some C-first codebases that try to be clever.
  • This breaks the symmetry between _LIBCPP_PREFERRED_ALIGNOF and _LIBCPP_ALIGNOF.
  • We have experience that defining compiler stuff in the library isn't a great idea -- for example, we've yet to figure out a way to get rid of our char16_t typedef, and it's not even a macro.
Fri, May 27, 12:22 PM · Restricted Project, Restricted Project
ldionne accepted D126221: [libc++][NFC] Rename rand.dis to rand.dist.
Fri, May 27, 12:15 PM · Restricted Project, Restricted Project
ldionne added inline comments to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".
Fri, May 27, 12:14 PM · Restricted Project, Restricted Project
ldionne committed rG719bf2d9d9fd: [runtimes] Officially deprecate the legacy testing configuration system (authored by ldionne).
[runtimes] Officially deprecate the legacy testing configuration system
Fri, May 27, 10:17 AM · Restricted Project, Restricted Project
ldionne closed D126478: [runtimes] Officially deprecate the legacy testing configuration system.
Fri, May 27, 10:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne accepted D126478: [runtimes] Officially deprecate the legacy testing configuration system.
Fri, May 27, 10:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne added a comment to D126478: [runtimes] Officially deprecate the legacy testing configuration system.

@ldionne ,
I have checked out our cmake cache for win-to-linux cross builds and I found that we already use the "new-style" test configuration files all libs accordingly: llvm-libc++-static.cfg.in, llvm-libc++abi-static.cfg.in and llvm-libunwind-static.cfg.in. It works fine for the builds currently.
We provide <lib>_TARGET_INFO=libcxx.test.target_info.LinuxRemoteTI and <lib>_EXECUTOR cmake vars only for these configurations.
Actually, the tests work without <lib>_TARGET_INFO also, but because there is still an appropriate parameter I did keep them there just in case.

So, it looks fine for now I guess.

Fri, May 27, 10:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne committed rGc358d98b998f: [libc++] Add various missing _LIBCPP_HIDE_FROM_ABI (authored by ldionne).
[libc++] Add various missing _LIBCPP_HIDE_FROM_ABI
Fri, May 27, 10:16 AM · Restricted Project, Restricted Project
ldionne closed D126496: [libc++] Add various missing _LIBCPP_HIDE_FROM_ABI.
Fri, May 27, 10:15 AM · Restricted Project, Restricted Project
ldionne accepted D126496: [libc++] Add various missing _LIBCPP_HIDE_FROM_ABI.
Fri, May 27, 10:14 AM · Restricted Project, Restricted Project

Thu, May 26

ldionne committed rGeb1b1f2411bf: [libc++][NFC] Fix whitespace (authored by ldionne).
[libc++][NFC] Fix whitespace
Thu, May 26, 1:52 PM · Restricted Project, Restricted Project
ldionne updated the diff for D126478: [runtimes] Officially deprecate the legacy testing configuration system.

Rebase. I will ship this if CI passes, since it's effectively non-breaking. It's just a heads up.

Thu, May 26, 12:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne committed rG92bbcfaa9740: [libunwind] Tidy-up the testing configuration for libunwind (authored by ldionne).
[libunwind] Tidy-up the testing configuration for libunwind
Thu, May 26, 12:30 PM · Restricted Project, Restricted Project
ldionne closed D126470: [libunwind] Tidy-up the testing configuration for libunwind.
Thu, May 26, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
ldionne accepted D126470: [libunwind] Tidy-up the testing configuration for libunwind.

libc++ CI passed.

Thu, May 26, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
ldionne requested review of D126496: [libc++] Add various missing _LIBCPP_HIDE_FROM_ABI.
Thu, May 26, 12:26 PM · Restricted Project, Restricted Project
ldionne added a comment to D126478: [runtimes] Officially deprecate the legacy testing configuration system.

Hi @ldionne. Got it, thank you! I'll check our cmake cache file out and remove any deprecated variables.

Thu, May 26, 12:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D108697: [libc++] Remove <experimental/coroutine>.

Remove parent revision and rebase to trigger CI properly.

Thu, May 26, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rG3bba72e65326: [libc++] Time tests during CI (authored by ldionne).
[libc++] Time tests during CI
Thu, May 26, 11:58 AM · Restricted Project, Restricted Project
ldionne added a comment to D120244: [clang][sema] Enable first-class bool support for C2x.

The system header including a header that's explicitly deprecated is dubious practice, but that does still require some amount of timing coordination.

Thu, May 26, 11:20 AM · Restricted Project, Restricted Project
ldionne updated the diff for D108697: [libc++] Remove <experimental/coroutine>.

Remove the -fcoroutines-ts Lit feature

Thu, May 26, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D108697: [libc++] Remove <experimental/coroutine>.

Rebase onto main

Thu, May 26, 9:18 AM · Restricted Project, Restricted Project, Restricted Project
ldionne requested review of D126482: [runtimes] Rename various libcpp-has-no-XYZ Lit features to just no-XYZ.
Thu, May 26, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
ldionne updated subscribers of D126478: [runtimes] Officially deprecate the legacy testing configuration system.

@vvereschaka I was going through the CMake caches looking for variables that implied usage of the legacy testing configuration system, and clang/cmake/caches/CrossWinToARMLinux.cmake seems to contain several of those. Just making sure you don't miss this.

Thu, May 26, 8:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne requested review of D126478: [runtimes] Officially deprecate the legacy testing configuration system.
Thu, May 26, 8:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne accepted D123016: [libc++] Implement ranges::{all, any, none}_of.

I don't think we have any tests that these algorithms are actually function objects that can be e.g. passed as a function argument. Didn't we have a test file that checked all algorithms and views for being niebloids? If so, let's update it. If not, let's create one.

Thu, May 26, 7:34 AM · Restricted Project, Restricted Project
ldionne requested review of D126470: [libunwind] Tidy-up the testing configuration for libunwind.
Thu, May 26, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rGf8c8bda965dd: [libc++] Remove temporary workaround for existing CMake caches (authored by ldionne).
[libc++] Remove temporary workaround for existing CMake caches
Thu, May 26, 6:36 AM · Restricted Project, Restricted Project
ldionne added a comment to D120244: [clang][sema] Enable first-class bool support for C2x.

We've started having several internal user complaints because their system headers are suddenly triggering a warning for using <stdbool.h>. This seems to be caused by the fact that #warning is surfaced to users even when the #warning is present in a system header (which makes sense, because otherwise there would be no way to issue a #warning from a system header). This ends up causing problems because users have no way to suppress the warning in the system headers they use without also disabling deprecation warnings in their own code. Is this intended? Instead, it seems to me like what we'd want is some way to mark the header as deprecated such that Clang will not flag uses of <stdbool.h> from within system headers, but will flag them from user code. This would be consistent with how the deprecated attributes work for classes and functions.

Thoughts?

This is what _CLANG_DISABLE_CRT_DEPRECATION_WARNINGS is for. We documented it here: https://clang.llvm.org/docs/UsersManual.html#controlling-deprecation-diagnostics-in-clang-provided-c-runtime-headers but the basic idea is, if that's defined before including the header, we don't issue those warnings. Does that suffice?

Thu, May 26, 6:32 AM · Restricted Project, Restricted Project
ldionne committed rG851bfc07c86e: [libc++abi] Use from-scratch testing configs for libc++abi by default (authored by ldionne).
[libc++abi] Use from-scratch testing configs for libc++abi by default
Thu, May 26, 6:09 AM · Restricted Project
ldionne closed D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default.
Thu, May 26, 6:08 AM · Restricted Project, Restricted Project

Wed, May 25

ldionne added a comment to D120244: [clang][sema] Enable first-class bool support for C2x.

We've started having several internal user complaints because their system headers are suddenly triggering a warning for using <stdbool.h>. This seems to be caused by the fact that #warning is surfaced to users even when the #warning is present in a system header (which makes sense, because otherwise there would be no way to issue a #warning from a system header). This ends up causing problems because users have no way to suppress the warning in the system headers they use without also disabling deprecation warnings in their own code. Is this intended? Instead, it seems to me like what we'd want is some way to mark the header as deprecated such that Clang will not flag uses of <stdbool.h> from within system headers, but will flag them from user code. This would be consistent with how the deprecated attributes work for classes and functions.

Wed, May 25, 1:22 PM · Restricted Project, Restricted Project
ldionne added inline comments to D122276: [libc++] Implement P0154R1 (Hardware inference size).
Wed, May 25, 9:40 AM · Restricted Project, Restricted Project
ldionne requested review of D126384: [libc++] Fix the dectection of lockfree atomics.
Wed, May 25, 8:06 AM · Restricted Project, Restricted Project
ldionne committed rG8383351d4517: [libc++] Remove conditional include (authored by ldionne).
[libc++] Remove conditional include
Wed, May 25, 7:05 AM · Restricted Project, Restricted Project
ldionne accepted D122276: [libc++] Implement P0154R1 (Hardware inference size).

Let's rebase this, apply my comments and land this if CI is green.

Wed, May 25, 6:55 AM · Restricted Project, Restricted Project
ldionne added a comment to D126210: [libcxx] Fix allocator<void>::pointer in C++20 with removed members.

@ldionne friendly ping. Just want to make sure this does not fall off your radar.
Let me know if you need more time, no rush here from our side.

Wed, May 25, 6:50 AM · Restricted Project, Restricted Project
ldionne added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

If you can add tests to show that distributions work with these types, I'd be OK with that. We still have until June 8th to cherry-pick to LLVM 14, so we could even backport to LLVM 14 and avoid breaking users for just one release (which would be very annoying indeed).

Given the poor state of testing for the current random implementation, and given that writing really really high quality tests to prove the disctributions is hard, can you say what level of testing you would find sufficient?

Wed, May 25, 6:44 AM · Restricted Project, Restricted Project
ldionne added inline comments to D123462: [libc++] Implement ranges::fill{, _n}.
Wed, May 25, 6:34 AM · Restricted Project, Restricted Project
ldionne committed rGd8afac7a2b73: [libc++] Use Python subprocess instead of libc++'s own utilities (authored by ldionne).
[libc++] Use Python subprocess instead of libc++'s own utilities
Wed, May 25, 6:33 AM · Restricted Project, Restricted Project
ldionne closed D126303: [libc++] Use Python subprocess instead of libc++'s own utilities.
Wed, May 25, 6:33 AM · Restricted Project, Restricted Project
ldionne updated the diff for D126303: [libc++] Use Python subprocess instead of libc++'s own utilities.

Fix broken sym_diff.

Wed, May 25, 6:32 AM · Restricted Project, Restricted Project
ldionne added inline comments to D126303: [libc++] Use Python subprocess instead of libc++'s own utilities.
Wed, May 25, 6:32 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default.

Fix bootstrapping build CI failure.

Wed, May 25, 6:14 AM · Restricted Project, Restricted Project
ldionne added a comment to D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default.

I'm not sure I understand what "from scratch" means given this patch, but I don't need to understand to see that to LGTM it. LGTM once the inline comments are addressed.

Wed, May 25, 6:13 AM · Restricted Project, Restricted Project
ldionne committed rG643df8fa8ef5: [libc++] Make sure that all headers can be included with modules enabled (authored by ldionne).
[libc++] Make sure that all headers can be included with modules enabled
Wed, May 25, 12:45 AM · Restricted Project, Restricted Project
ldionne closed D125331: [libc++] Make sure that all headers can be included with modules enabled.
Wed, May 25, 12:45 AM · Restricted Project, Restricted Project

Tue, May 24

ldionne added a comment to D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

I'm not sure why there's so much resistance to reverting. libc++:

  1. has users with broken code right now;
  2. actively supports uniform_int_distribution<__int128_t>, which is also undefined (I don't get why you consider signed char, unsigned char, char, and bool to be problematic, but not __int128_t and unsigned __int128_t);
  3. has licence to make it an extension without Microsoft/STL's support;

You can also propose standardising this right now.

Tue, May 24, 12:18 PM · Restricted Project, Restricted Project
ldionne added inline comments to D125331: [libc++] Make sure that all headers can be included with modules enabled.
Tue, May 24, 11:54 AM · Restricted Project, Restricted Project
ldionne accepted D126053: [libc++][ranges] Finish LWG issues directly related to the One Ranges Proposal..

LGTM with comments applied and CI passing.

Tue, May 24, 11:34 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default.

Rebase onto main -- I'm not seeing the CI issue locally, maybe rebasing will fix it?

Tue, May 24, 11:20 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125331: [libc++] Make sure that all headers can be included with modules enabled.

Fix CI with bootstrapping build -- hopefully this doesn't break another job.

Tue, May 24, 10:28 AM · Restricted Project, Restricted Project
ldionne committed rG632518404942: [libc++][NFC] Whitespace refactoring of string.cpp for consistency and… (authored by ldionne).
[libc++][NFC] Whitespace refactoring of string.cpp for consistency and…
Tue, May 24, 8:32 AM · Restricted Project, Restricted Project
ldionne committed rGdc8a9a03ecdb: [libc++][NFC] Move definitions around in string.cpp to reduce… (authored by ldionne).
[libc++][NFC] Move definitions around in string.cpp to reduce…
Tue, May 24, 8:32 AM · Restricted Project, Restricted Project
ldionne requested review of D126303: [libc++] Use Python subprocess instead of libc++'s own utilities.
Tue, May 24, 8:15 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default.

Try to fix CI.

Tue, May 24, 7:53 AM · Restricted Project, Restricted Project
ldionne committed rGa9a6e200125e: [libc++] Rename the generic-singlethreaded CI job to generic-no-threads for… (authored by ldionne).
[libc++] Rename the generic-singlethreaded CI job to generic-no-threads for…
Tue, May 24, 6:59 AM · Restricted Project, Restricted Project
ldionne added a comment to D125827: [cmake] Don't try creating an executable when detecting the linker.

LGTM, thanks.

I think this might potentially break cross-compilation on Windows. We're in a NOT WIN32 block here, but that means you're not targeting Windows; you could still be targeting e.g. Linux but building on a Windows machine. I think NUL is the Windows equivalent, and you could have a CMAKE_HOST_WIN32 block, but it'll depend on how CMake invokes an execute_process command. (I have a Windows machine handy and can experiment with that, if you'd like.) That being said

Hmm, I just tried it out on a Windows machine and it seems to work.

To be clear, were you building for Windows on a Windows machine, or targeting some other platform? The NOT WIN32 above would have already taken care of the building for Windows on Windows case.

Tue, May 24, 6:54 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125331: [libc++] Make sure that all headers can be included with modules enabled.

Hopefully fix CI.

Tue, May 24, 6:53 AM · Restricted Project, Restricted Project

Mon, May 23

ldionne committed rG6cb3fdc278b9: [libc++] Remove duplicate tests for callable concepts (authored by ldionne).
[libc++] Remove duplicate tests for callable concepts
Mon, May 23, 12:39 PM · Restricted Project, Restricted Project
ldionne added a comment to D126167: [libc++] Add ranges::max_element to the synopsis and ADL-proof the __min_element_impl calls.

@philnik just made me aware of https://wg21.link/P2538, so we can't use ADL-proof tests. Hence LGTM as-is.

Mon, May 23, 10:33 AM · Restricted Project, Restricted Project
ldionne accepted D126167: [libc++] Add ranges::max_element to the synopsis and ADL-proof the __min_element_impl calls.

LGTM with tests. We have several ADL proofing tests, see for example libcxx/test/std/strings/basic.string/string.modifiers/robust_against_adl.pass.cpp.

Mon, May 23, 10:28 AM · Restricted Project, Restricted Project
ldionne added inline comments to D126167: [libc++] Add ranges::max_element to the synopsis and ADL-proof the __min_element_impl calls.
Mon, May 23, 10:27 AM · Restricted Project, Restricted Project
ldionne accepted D126165: [libc++] Add auto to the list of required extensions in C++03.
Mon, May 23, 10:27 AM · Restricted Project, Restricted Project
ldionne accepted D124011: [libc++] Always enable the ranges concepts.

Ship it. Please ping me when this is committed and I will cherry-pick to the LLVM 14 release branch.

Mon, May 23, 10:26 AM · Restricted Project, Restricted Project
ldionne accepted D124755: [libc++] Granularize parts of <type_traits>.

LGTM, and it would be nice to do the cleanup suggested in https://reviews.llvm.org/D124755#inline-1207727.

Mon, May 23, 10:24 AM · Restricted Project, Restricted Project
ldionne accepted D126073: [libc++] Assume that push_macro and pop_macro are available.
Mon, May 23, 10:21 AM · Restricted Project, Restricted Project
ldionne added a comment to D126098: [libc++] Remove unused __functional includes.

I don't understand this review's title in relationship with the diff. Is it an error?

Mon, May 23, 10:21 AM · Restricted Project, Restricted Project
ldionne updated subscribers of D125283: reverts "[libc++] Explicitly reject `uniform_int_distribution<bool>` and `<char>`.".

GCC ships this as an extension. I can't find a reason why the extension would be non-conforming or dangerous, and it seems like a safer way for users to generate char values, rather than expecting the user to correctly pass the numerical_limits<char>::max() to the constructor.
I think we should reach out to someone at Microsoft (maybe STL), and see how open they are to shipping this as an extension. If they're willing then we avoid the portability trap that we're trying to protect users from.

Mon, May 23, 9:35 AM · Restricted Project, Restricted Project

Fri, May 20

ldionne added inline comments to D122002: [libc++][ranges] Implement ranges::max.
Fri, May 20, 9:08 AM · Restricted Project, Restricted Project
ldionne added inline comments to D117523: [libc++][ranges] Implement ranges::max_element.
Fri, May 20, 9:08 AM · Restricted Project, Restricted Project
ldionne added inline comments to D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.
Fri, May 20, 6:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne committed rG1c4b31c38b3c: [libc++] Improve error messages for disabled modes (authored by ldionne).
[libc++] Improve error messages for disabled modes
Fri, May 20, 6:37 AM · Restricted Project, Restricted Project
ldionne closed D125910: [libc++] Improve error messages for disabled modes.
Fri, May 20, 6:37 AM · Restricted Project, Restricted Project
ldionne committed rG422ec524388b: [libunwind] Introduce a cmake-bridge.cfg.in file to reduce test config… (authored by ldionne).
[libunwind] Introduce a cmake-bridge.cfg.in file to reduce test config…
Fri, May 20, 6:37 AM · Restricted Project, Restricted Project
ldionne closed D125981: [libunwind] Introduce a cmake-bridge.cfg.in file to reduce test config duplication.
Fri, May 20, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
ldionne accepted D125981: [libunwind] Introduce a cmake-bridge.cfg.in file to reduce test config duplication.

The only CI failure is a nit I just fixed, so shipping this.

Fri, May 20, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rGe3f990b4e997: [libc++abi] Add missing XFAIL on test (authored by ldionne).
[libc++abi] Add missing XFAIL on test
Fri, May 20, 6:36 AM · Restricted Project
ldionne added a comment to D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..

c218fd3d7d3764eb123c8429bbcd33bacfe2e633 added libcxxabi/test/native/AArch64/ra_sign_state.pass.cpp -- was that intended, or should it have been added to libunwind/test/[...]? It also started failing in the CI in the -fno-exceptions configuration -- I think it is just missing a XFAIL so I'll add it, but please investigate whether the file needs to be moved (I think it does). If so, please make sure to open a code review for that change since it will cause our pre-commit CI to run, and please don't commit the change until it is green :-).

Fri, May 20, 6:34 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 19

ldionne added inline comments to D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.
Thu, May 19, 12:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.

Address some comments (but not @phosek's yet).

Thu, May 19, 12:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D125827: [cmake] Don't try creating an executable when detecting the linker.

Try to handle Windows hosts.

Thu, May 19, 9:00 AM · Restricted Project, Restricted Project
ldionne added a comment to D125827: [cmake] Don't try creating an executable when detecting the linker.

I think this might potentially break cross-compilation on Windows. We're in a NOT WIN32 block here, but that means you're not targeting Windows; you could still be targeting e.g. Linux but building on a Windows machine. I think NUL is the Windows equivalent, and you could have a CMAKE_HOST_WIN32 block, but it'll depend on how CMake invokes an execute_process command. (I have a Windows machine handy and can experiment with that, if you'd like.) That being said

Thu, May 19, 8:57 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125242: [libc++abi] Use from-scratch testing configs for libc++abi by default.

Rebase and try to fix CI.

Thu, May 19, 8:47 AM · Restricted Project, Restricted Project
ldionne accepted D125910: [libc++] Improve error messages for disabled modes.
Thu, May 19, 8:27 AM · Restricted Project, Restricted Project
ldionne added inline comments to D125910: [libc++] Improve error messages for disabled modes.
Thu, May 19, 8:27 AM · Restricted Project, Restricted Project
ldionne updated the diff for D125910: [libc++] Improve error messages for disabled modes.

Fix CI issues.

Thu, May 19, 8:27 AM · Restricted Project, Restricted Project
ldionne committed rG4431e8c84e62: [libc++] Override the value of LIBCXX_CXX_ABI in the cache (authored by ldionne).
[libc++] Override the value of LIBCXX_CXX_ABI in the cache
Thu, May 19, 8:21 AM · Restricted Project, Restricted Project
ldionne requested review of D125981: [libunwind] Introduce a cmake-bridge.cfg.in file to reduce test config duplication.
Thu, May 19, 8:16 AM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rGa5f36259a205: [libunwind] Remove unused _LIBUNWIND_HAS_NO_THREADS macro in tests (authored by ldionne).
[libunwind] Remove unused _LIBUNWIND_HAS_NO_THREADS macro in tests
Thu, May 19, 7:58 AM · Restricted Project
ldionne committed rGfa7ce8e685fa: [runtimes] Fix the build of merged ABI/unwinder libraries (authored by ldionne).
[runtimes] Fix the build of merged ABI/unwinder libraries
Thu, May 19, 7:50 AM · Restricted Project, Restricted Project