Page MenuHomePhabricator

ldionne (Louis Dionne)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (331 w, 23 h)
Roles
Administrator

Recent Activity

Today

ldionne requested review of D104486: [libc++] Make sure std::allocator<void> is always trivial.
Thu, Jun 17, 1:19 PM · Restricted Project
ldionne committed rG71e4d434dc83: [libc++] Make sure std::allocator<void> is always trivial (authored by ldionne).
[libc++] Make sure std::allocator<void> is always trivial
Thu, Jun 17, 1:12 PM
ldionne closed D104398: [libc++] Make sure std::allocator<void> is always trivial.
Thu, Jun 17, 1:12 PM · Restricted Project
ldionne accepted D102798: [SystemZ][z/OS] XFAIL aligned allocation tests on z/OS.

LGTM, but just out of curiosity, will this stay unsupported forever, or will this be implemented eventually?

Thu, Jun 17, 1:03 PM · Restricted Project
ldionne updated subscribers of D104328: [libc++] Always build libc++ and libc++abi with -fPIC.

Furthermore, there is apparently basically no downside to building the libraries with position independent code, since modern toolchains are sufficiently clever.

FWIW it's not necessarily so much about modern toolchains, as it is about modern architectures. AFAIK position independent code is measurably less efficient on e.g. i386, while the overhead on e.g. x86_64 and arm64 is much much smaller (possibly also on 32 bit arm). Therefore I think the other patch (D104327) makes more sense out of these two, as the choice of PIC is more of a choice for how one configures and distributes it, than an intrinsic property of the project itself.

Thu, Jun 17, 11:22 AM · Restricted Project, Restricted Project
ldionne accepted D104456: [libc++] add `inline` for __open's definition in ifstream and ofstream.

Associated release blocking bug: http://llvm.org/PR50734

Thu, Jun 17, 9:44 AM · Restricted Project
ldionne accepted D104458: [libc++] Make feature-test macros consistent with availability macros.

Associated release blocker bug: http://llvm.org/PR50758

Thu, Jun 17, 9:41 AM · Restricted Project
ldionne accepted D104457: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..

Associated release blocker bug: http://llvm.org/PR50757

Thu, Jun 17, 9:39 AM · Restricted Project
ldionne added a comment to D103983: [libc++][rfc] Improve atomic_fetch_(add|sub).*..

Just to record this publicly:

Thu, Jun 17, 9:32 AM · Restricted Project
ldionne added a reviewer for D103583: [libcxx][gardening] Move all algorithms into their own headers.: phosek.

@phosek Could you please apply this change locally and run whatever you ran that caused you to revert last week? I think we should have fixed our stuff, but I really want to make sure we're not going to break you again, because it's extremely painful for us to revert and re-apply such a large change (and it messes up the history pretty badly, too).

Thu, Jun 17, 9:18 AM · Restricted Project
ldionne updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..

Update to https://reviews.llvm.org/D104171.

Thu, Jun 17, 9:16 AM · Restricted Project
ldionne commandeered D103583: [libcxx][gardening] Move all algorithms into their own headers..

Commandeering as I'm getting ready to re-apply this change (well, really D104171 which is a mix of D103330, this and additional work).

Thu, Jun 17, 9:15 AM · Restricted Project
ldionne reopened D103583: [libcxx][gardening] Move all algorithms into their own headers..
Thu, Jun 17, 8:49 AM · Restricted Project
ldionne requested review of D104458: [libc++] Make feature-test macros consistent with availability macros.
Thu, Jun 17, 6:31 AM · Restricted Project
ldionne requested review of D104457: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
Thu, Jun 17, 6:29 AM · Restricted Project
ldionne requested review of D104456: [libc++] add `inline` for __open's definition in ifstream and ofstream.
Thu, Jun 17, 6:24 AM · Restricted Project
ldionne closed D104400: Cherry-pick a few changes to unbreak libc++ testing on release/12.x.

Merged.

Thu, Jun 17, 5:50 AM · Restricted Project
ldionne accepted D104400: Cherry-pick a few changes to unbreak libc++ testing on release/12.x.
Thu, Jun 17, 5:48 AM · Restricted Project

Yesterday

ldionne added a comment to D104398: [libc++] Make sure std::allocator<void> is always trivial.

Thanks, will ship once CI is green. I'll also cherry-pick this one to release/12.x.

Wed, Jun 16, 1:30 PM · Restricted Project
ldionne added a comment to D102809: [libcxx][ranges] Add `ranges::iter_swap`..

(and CI passing once you rebase)

Wed, Jun 16, 1:25 PM · Restricted Project
ldionne accepted D102809: [libcxx][ranges] Add `ranges::iter_swap`..

LGTM with my comments applied.

Wed, Jun 16, 1:24 PM · Restricted Project
ldionne accepted D104415: [libcxx][module-map] 🎨 updates module map to account for ranges headers.

LGTM if CI passes!

Wed, Jun 16, 1:03 PM · Restricted Project
ldionne accepted D104414: [libcxx][iwyu] 🎨 adds more headers to IWYU.

Thanks!

Wed, Jun 16, 1:02 PM · Restricted Project
ldionne accepted D104372: [libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS.
Wed, Jun 16, 12:55 PM · Restricted Project
ldionne committed rZORG24c65f311973: [libc++] Remove build bots that are handled on BuildKite now (authored by ldionne).
[libc++] Remove build bots that are handled on BuildKite now
Wed, Jun 16, 12:47 PM
ldionne added a comment to D104400: Cherry-pick a few changes to unbreak libc++ testing on release/12.x.

@tstellar Permission to merge this into release/12.x once the CI is passing.

I'm trying to get on top of the release story for libc++ and I'd like to merge a few bug fixes to the 12.0.1 release, but I want to do that on top of clean CI, which is what these 3 small patches do.

Sure, no problem. Is the bot you are trying to fix: libcxx-libcxxabi-x86_64-linux-debian-release ?

Wed, Jun 16, 12:30 PM · Restricted Project
ldionne updated subscribers of D104400: Cherry-pick a few changes to unbreak libc++ testing on release/12.x.

@tstellar Permission to merge this into release/12.x once the CI is passing.

Wed, Jun 16, 12:24 PM · Restricted Project
ldionne requested review of D104400: Cherry-pick a few changes to unbreak libc++ testing on release/12.x.
Wed, Jun 16, 10:41 AM · Restricted Project
ldionne closed D104324: [libc++][🍒] Un-deprecate std::allocator<void>.
commit e7dac564cd0ed9dee74ef972c46622743d90915d (HEAD -> release/12.x, origin/release/12.x)
Author: Louis Dionne <ldionne.2@gmail.com>
Date:   Tue Jun 15 17:55:27 2021 -0400
Wed, Jun 16, 10:18 AM · Restricted Project
ldionne accepted D104324: [libc++][🍒] Un-deprecate std::allocator<void>.

The remaining CI issues already exist before this patch. I'll try fixing them subsequently, but this is good to go.

Wed, Jun 16, 10:14 AM · Restricted Project
ldionne added inline comments to D104398: [libc++] Make sure std::allocator<void> is always trivial.
Wed, Jun 16, 10:13 AM · Restricted Project
ldionne requested review of D104398: [libc++] Make sure std::allocator<void> is always trivial.
Wed, Jun 16, 10:08 AM · Restricted Project
ldionne accepted D104170: Revert "Revert "[libcxx][module-map] creates submodules for private headers"".
Wed, Jun 16, 9:31 AM · Restricted Project
ldionne committed rG87784cc6fb34: [libc++] Undeprecate the std::allocator<void> specialization (authored by ldionne).
[libc++] Undeprecate the std::allocator<void> specialization
Wed, Jun 16, 6:55 AM
ldionne closed D104323: [libc++] Undeprecate the std::allocator<void> specialization.
Wed, Jun 16, 6:54 AM · Restricted Project

Tue, Jun 15

ldionne added a comment to D104324: [libc++][🍒] Un-deprecate std::allocator<void>.

This is a manual cherry-pick because the codebase has diverged quite a bit.

@tstellar Once this is passing CI, I'd like to have your permission to merge this to release/12.x because this is a pretty vexing issue.

@ldionne Go ahead and merge when it's ready, and make sure to use git cherry-pick -x.

Tue, Jun 15, 6:03 PM · Restricted Project
ldionne updated the diff for D104324: [libc++][🍒] Un-deprecate std::allocator<void>.

Fix CI issues.

Tue, Jun 15, 6:01 PM · Restricted Project
ldionne updated the diff for D104323: [libc++] Undeprecate the std::allocator<void> specialization.

Fix CI failures

Tue, Jun 15, 5:59 PM · Restricted Project
ldionne committed rG4f194d0db78f: [libc++] Promote GCC 11 to mandatory CI (authored by ldionne).
[libc++] Promote GCC 11 to mandatory CI
Tue, Jun 15, 5:56 PM
ldionne closed D104315: [libc++] Promote GCC 11 to mandatory CI.
Tue, Jun 15, 5:55 PM · Restricted Project, Restricted Project
ldionne accepted D104315: [libc++] Promote GCC 11 to mandatory CI.
Tue, Jun 15, 5:54 PM · Restricted Project, Restricted Project
ldionne added a comment to D104327: [release] Build the LLVM releases with Position Independent Code enabled.

I created another take on this here: https://reviews.llvm.org/D104328.

Tue, Jun 15, 3:52 PM · Restricted Project
ldionne requested review of D104328: [libc++] Always build libc++ and libc++abi with -fPIC.
Tue, Jun 15, 3:51 PM · Restricted Project, Restricted Project
ldionne requested review of D104327: [release] Build the LLVM releases with Position Independent Code enabled.
Tue, Jun 15, 3:45 PM · Restricted Project
ldionne added inline comments to D104170: Revert "Revert "[libcxx][module-map] creates submodules for private headers"".
Tue, Jun 15, 3:01 PM · Restricted Project
ldionne added a comment to D104324: [libc++][🍒] Un-deprecate std::allocator<void>.

This is a manual cherry-pick because the codebase has diverged quite a bit.

Tue, Jun 15, 2:57 PM · Restricted Project
ldionne requested review of D104324: [libc++][🍒] Un-deprecate std::allocator<void>.
Tue, Jun 15, 2:56 PM · Restricted Project
ldionne added inline comments to D104315: [libc++] Promote GCC 11 to mandatory CI.
Tue, Jun 15, 2:49 PM · Restricted Project, Restricted Project
ldionne updated the diff for D104315: [libc++] Promote GCC 11 to mandatory CI.

Address review comments and clarify intent about supported versions.

Tue, Jun 15, 2:48 PM · Restricted Project, Restricted Project
ldionne updated the diff for D104315: [libc++] Promote GCC 11 to mandatory CI.

Update XFAIL for libc++abi on recent GCC

Tue, Jun 15, 2:35 PM · Restricted Project, Restricted Project
ldionne requested review of D104323: [libc++] Undeprecate the std::allocator<void> specialization.
Tue, Jun 15, 2:30 PM · Restricted Project
ldionne updated subscribers of D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
Tue, Jun 15, 12:55 PM · Restricted Project
ldionne requested review of D104315: [libc++] Promote GCC 11 to mandatory CI.
Tue, Jun 15, 12:13 PM · Restricted Project, Restricted Project

Mon, Jun 14

ldionne committed rG1b87573aaf8a: [libc++][ci] Enable modules in the Runtimes build (authored by ldionne).
[libc++][ci] Enable modules in the Runtimes build
Mon, Jun 14, 8:05 PM
ldionne closed D104252: [libc++][ci] Enable modules in the Runtimes build.
Mon, Jun 14, 8:05 PM · Restricted Project
ldionne accepted D104252: [libc++][ci] Enable modules in the Runtimes build.
Mon, Jun 14, 8:05 PM · Restricted Project
ldionne added inline comments to D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
Mon, Jun 14, 3:13 PM · Restricted Project
ldionne accepted D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..

Thanks a lot! Indeed, we don't have access to FileCheck in the libc++ tests. I had once looked into doing that but I ran into issues and we didn't have a clear use case so I decided not to spend more time on it. Looks like this will do for the time being.

Mon, Jun 14, 3:12 PM · Restricted Project
ldionne requested changes to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
Mon, Jun 14, 3:00 PM · Restricted Project
ldionne accepted D104228: [libc++] [test] Fix some GCC 11 errors/warnings in these tests. NFCI..

Good catch on the end.cpp rename - we were not running that test.

Mon, Jun 14, 2:59 PM · Restricted Project
ldionne requested changes to D102809: [libcxx][ranges] Add `ranges::iter_swap`..
Mon, Jun 14, 2:35 PM · Restricted Project
ldionne added inline comments to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
Mon, Jun 14, 1:20 PM · Restricted Project
ldionne committed rGd9d20802d0ce: [libc++] Clean up scripts to setup CI on macOS (authored by ldionne).
[libc++] Clean up scripts to setup CI on macOS
Mon, Jun 14, 12:56 PM
ldionne accepted D104235: [libc++abi] NFC: avoid a -Wunused-parameter warning.

Thanks!

Mon, Jun 14, 11:53 AM · Restricted Project, Restricted Project
ldionne requested review of D104252: [libc++][ci] Enable modules in the Runtimes build.
Mon, Jun 14, 11:45 AM · Restricted Project
ldionne requested changes to D104235: [libc++abi] NFC: avoid a -Wunused-parameter warning.
Mon, Jun 14, 11:01 AM · Restricted Project, Restricted Project
ldionne accepted D104175: [libcxx][iwyu] ensures we IWYU as prep for modules.

LGTM but can you please move the operator& changes to the other patch? Also, I think this does reduce the usefulness of __function_like by quite a bit, cause now we have to think about adding a declaration in the function objects *and* derive from __function_like. I think we should fix the underlying modules bug (seriously, modules shouldn't have anything to do with this!) and more operator& back into __function_like.

Mon, Jun 14, 10:58 AM · Restricted Project
ldionne accepted D104172: [libc++] Remove some obsolete _LIBCPP_CXX03_LANG.

Thanks for the cleanup.

Mon, Jun 14, 6:02 AM · Restricted Project
ldionne requested changes to D104175: [libcxx][iwyu] ensures we IWYU as prep for modules.

Include changes LGTM, but I don't understand the change to __function_like.

Mon, Jun 14, 5:58 AM · Restricted Project
ldionne accepted D104166: [libc++] [test] No longer rely on std::hash<T>::argument_type..

Did we have any uses of test_hash with a hash that's not std::hash?

Mon, Jun 14, 5:46 AM · Restricted Project
ldionne committed rG9f967eed89e6: [libc++] NFC: More refactoring in the prev/next/advance tests per review… (authored by ldionne).
[libc++] NFC: More refactoring in the prev/next/advance tests per review…
Mon, Jun 14, 5:43 AM
ldionne added inline comments to D103272: [libc++] Refactor the ranges::prev and ranges::next tests.
Mon, Jun 14, 5:43 AM · Restricted Project
ldionne committed rG8e93aa304b3f: [libc++] Refactor the tests for std::prev, next and advance (authored by ldionne).
[libc++] Refactor the tests for std::prev, next and advance
Mon, Jun 14, 5:13 AM
ldionne closed D103272: [libc++] Refactor the ranges::prev and ranges::next tests.
Mon, Jun 14, 5:13 AM · Restricted Project

Fri, Jun 11

ldionne accepted D103753: [libc++] [P0619] Add _LIBCPP_ABI_NO_BINDER_BASES and remove binder typedefs in C++20..
  1. CI needs to pass
  2. Please put the GCC-next CI fixes in a different patch, and don't touch the iterator.ops failures (I'm doing that in D103272).
  3. We normally add .verify.cpp tests to check that we've applied the deprecated attribute properly to stuff -- here this should apply to the typedefs. It's kinda nitpicky but I'd like it if you could add them.
Fri, Jun 11, 2:16 PM · Restricted Project
ldionne added inline comments to D103272: [libc++] Refactor the ranges::prev and ranges::next tests.
Fri, Jun 11, 2:02 PM · Restricted Project
ldionne updated the diff for D103272: [libc++] Refactor the ranges::prev and ranges::next tests.

Address review comments and tweak tests for advance too.

Fri, Jun 11, 2:02 PM · Restricted Project
ldionne committed rGc54d3050f7b9: [libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h (authored by ldionne).
[libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h
Fri, Jun 11, 9:57 AM
ldionne closed D104048: [libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h.
Fri, Jun 11, 9:57 AM · Restricted Project
ldionne added a comment to D104048: [libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h.

LGTM. But btw, what's going on with these GCC failures? I thought you (@ldionne) were going to fix them, but it's been like a month now. Should I make a PR for it? Some of these failures are just straight up typos in the test cases; others might require some digging, I don't know (which is why I was happy to let you deal with it, I thought).

Fri, Jun 11, 9:56 AM · Restricted Project
ldionne committed rGf84dbd2f2bef: [libc++] Enable the synchronization library on Apple platforms (authored by ldionne).
[libc++] Enable the synchronization library on Apple platforms
Fri, Jun 11, 9:45 AM
ldionne closed D96790: [libc++] Enable the synchronization library on Apple platforms.
Fri, Jun 11, 9:45 AM · Restricted Project
ldionne requested changes to D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.
Fri, Jun 11, 6:38 AM · Restricted Project
ldionne added a comment to D102020: [libcxx][ranges] Add class ref_view..

Pending passing CI, of course.

Fri, Jun 11, 6:00 AM · Restricted Project
ldionne accepted D102020: [libcxx][ranges] Add class ref_view..
Fri, Jun 11, 6:00 AM · Restricted Project
ldionne requested changes to D103753: [libc++] [P0619] Add _LIBCPP_ABI_NO_BINDER_BASES and remove binder typedefs in C++20..

I think it's necessary to have the ABI macro, however I really think we should stop adding those _LIBCPP_ENABLE_CXX20_REMOVED_XYZ macros. If someone is opting into using C++20, then they are opting into these removals as well. At that point fixing their code is probably not much harder than flipping that macro.

Fri, Jun 11, 4:17 AM · Restricted Project

Thu, Jun 10

ldionne committed rG859c924c5fd5: [libc++] Remove unnecessary header in enable_view.h (which caused a cycle) (authored by ldionne).
[libc++] Remove unnecessary header in enable_view.h (which caused a cycle)
Thu, Jun 10, 1:35 PM
ldionne added a comment to D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view.

Ship-it. I'll be looking forward to a patch that makes insert_iterator up-to-spec for C++20.

Thu, Jun 10, 1:19 PM · Restricted Project
ldionne added inline comments to D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view.
Thu, Jun 10, 1:04 PM · Restricted Project
ldionne added a comment to D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view.

I missed that un-applied comment in my LGTM a second ago. Still LGTM, but why not fix the FIXME now?

Thu, Jun 10, 1:02 PM · Restricted Project
ldionne accepted D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view.

Thanks! Now we'll be able to update all the in-progress views to this paper.

Thu, Jun 10, 1:00 PM · Restricted Project
ldionne added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

I’d say wait a day or so to make sure that @ldionne doesn’t have any concerns, but this seems like it should be safe. Rebasing a pointer seems like a useful enough thing and this don’t impact the public interfaces.

Thu, Jun 10, 12:03 PM · Restricted Project, Restricted Project
ldionne requested changes to D89353: Enable overriding `__libcpp_debug_function` invocation.

For some reason this went entirely under my radar.

Thu, Jun 10, 11:47 AM · Restricted Project
ldionne updated the diff for D96790: [libc++] Enable the synchronization library on Apple platforms.

Rebase onto main with the new triple-based availability.

Thu, Jun 10, 11:25 AM · Restricted Project
ldionne accepted D96790: [libc++] Enable the synchronization library on Apple platforms.
In D96790#2734482, @jfb wrote:

I would recommend checking with @MadCoder about the implementation and ABI, since the kernel has Opinions on this. IIRC he looked at Olivier's original patch.

Thu, Jun 10, 11:25 AM · Restricted Project
ldionne requested review of D104048: [libc++] NFC: Move indirect_concepts.h to __iterator/concepts.h.
Thu, Jun 10, 10:43 AM · Restricted Project
ldionne added inline comments to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
Thu, Jun 10, 10:26 AM · Restricted Project
ldionne requested changes to D102020: [libcxx][ranges] Add class ref_view..

Per offline discussion,

Thu, Jun 10, 10:20 AM · Restricted Project
ldionne committed rGa0ae3b078914: [libc++abi] Remove the LIBCXXABI_ENABLE_PIC option (authored by ldionne).
[libc++abi] Remove the LIBCXXABI_ENABLE_PIC option
Thu, Jun 10, 9:28 AM
ldionne closed D103973: [libc++abi] Remove the LIBCXXABI_ENABLE_PIC option.
Thu, Jun 10, 9:27 AM · Restricted Project, Restricted Project