- User Since
- Feb 11 2015, 3:26 PM (188 w, 5 d)
You did not get a thumbs up from any of the code owners for libc++. Reverted in r342938.
Was this true pre-C11 too? If not, then this needs to be guarded by #if _LIBCPP_STD_VER >= 17, because C++ is only on top of C11 in C++17 and above (Marshall can double-check this).
Sat, Sep 22
LGTM and has been committed -- you can close this.
Clarify that version 2 of the ABI is _currently_ unstable, it is not _the_ unstable version.
Are we waiting for anything to ship this?
Remove the change to the Darwin ABI list file, which was meant for a different commit.
Fri, Sep 21
Fix warnings on undefined entities
Wed, Sep 19
Marshall, can you confirm that the change does not break check-cxx-abilist on OS X. I'm fine with the change if that's not broken.
Marshall, what's the error we get with GCC in C++03 mode that this patch is fixing? Is there a bug.llvm.org associated to that?
Tue, Sep 18
I'm thinking about this some more, and I'm wondering whether it would be a viable solution to just exclude members marked with hidden visibility from explicit template instantiations (and declarations thereof). I thought I had been convinced by Hubert that visibility and this attribute should be left separate, but now I'm not sure anymore. I don't think there's a single case of a member function with hidden visibility that we don't want to exclude from explicit instantiations. @rsmith Thoughts?
Mon, Sep 17
Add example of how to use the attribute, per Aaron's comment.
Reformat warning message and run clang-format on changed lines.
Fri, Sep 14
Change no_extern_template to exclude_from_explicit_instantiation
I think now's a good time to bikeshed the name of the attribute if you have other suggestions.
Fix the tests and remove some warnings that I wasn't able to generate properly
(to avoid false positives).
Thu, Sep 13
I created https://bugs.llvm.org/show_bug.cgi?id=38942 to keep track of the problem for partial specializations and explicit specializations. Moving forward with this patch will allow me to land the no_extern_template attribute.
Drop support for partial specializations and explicit specializations.
Address comments by Erik.
Wed, Sep 12
This patch is missing support for partial specializations and explicit specializations. The part I don't understand is how to get the CXXRecordDecls to have the right attribute below. Here's the AST dump for the test file with the current patch:
Thanks! I don't like feature test macros either, but we should still strive for conformance.
Mon, Sep 10
I think that works because memcpy this way is valid IFF To and From are trivially copyable. LGTM.
Fri, Sep 7
This patch is an early WIP -- I'm just uploading it to serve as a support for a message I'm about to post on cfe-dev. No need to review seriously for now.
Thu, Sep 6
Aug 24 2018
Aug 23 2018
LGTM. Don't forget to update https://reviews.llvm.org/D48896 so it uncomments this. Also, this should be merged into LLVM 7.
Aug 21 2018
Aug 17 2018
LGTM with the __clz you missed.
Aug 16 2018
Aug 15 2018
If that's possible at all, I would like for the Chromium people to build with this patch applied. The expectation is that we'll cherry-pick this patch onto LLVM 7, and it would suck if that did not solve Chromium's problem for some stupid reason.
Allow picking a custom default behavior for vendors, per Duncan's comment.