Page MenuHomePhabricator

ldionne (Louis Dionne)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (292 w, 3 d)

Recent Activity

Fri, Sep 18

ldionne requested changes to D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS.

Assuming you already have them, I'd love to see the rest of the patches in the queue to know what we're getting into.

Fri, Sep 18, 1:52 PM · Restricted Project
ldionne updated subscribers of D68364: Implement C++20's P0784 (More constexpr containers).
Fri, Sep 18, 1:30 PM · Restricted Project, Restricted Project
ldionne accepted D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl..
Fri, Sep 18, 12:40 PM · Restricted Project, Restricted Project
ldionne requested changes to D60368: Add bind_front function (P0356R5).

A few more comments, but this is looking pretty good.

Fri, Sep 18, 12:33 PM · Restricted Project

Thu, Sep 17

ldionne added inline comments to D68364: Implement C++20's P0784 (More constexpr containers).
Thu, Sep 17, 2:32 PM · Restricted Project, Restricted Project
ldionne added a comment to D68364: Implement C++20's P0784 (More constexpr containers).

The mechanism by which this interacts with Clang looks good to me.

Thu, Sep 17, 1:28 PM · Restricted Project, Restricted Project
Herald added a reviewer for D69803: [libc++][P0784] Marked allocator_traits constexpr.: Restricted Project.

This is superseded by D68364. Thanks a lot for your work on this @mpark, I based my patch on top of yours. I tried taking all the comments from this review and incorporating them into D68364.

Thu, Sep 17, 1:15 PM · Restricted Project
Herald added a reviewer for D69132: [libc++][P0784] Marked the default allocator constexpr.: Restricted Project.

This is superseded by https://reviews.llvm.org/D68364. Thanks a lot for your work on this @mpark, I based my patch on top of yours. I tried taking all the comments from this review and incorporating them into D68364.

Thu, Sep 17, 1:15 PM · Restricted Project
ldionne retitled D68364: Implement C++20's P0784 (More constexpr containers) from Prototype implementation of P0784R7: mark all members of std::allocator and std::allocator_traits as constexpr. to Implement C++20's P0784 (More constexpr containers).
Thu, Sep 17, 1:13 PM · Restricted Project, Restricted Project
ldionne updated the diff for D68364: Implement C++20's P0784 (More constexpr containers).

Complete implementation of P0784 with tests

Thu, Sep 17, 1:12 PM · Restricted Project, Restricted Project
ldionne accepted D62779: [2/2] Fix complexity of map insert_or_assign with a hint..
  1. Reduce your commit message to get rid of the benchmark output
  2. Run: for std in c++03 c++11 c++14 c++17 c++2a; do <build-dir>/bin/llvm-lit -sv libcxx/test/std/containers/associative/map --param std=$std; done to make sure it all works
Thu, Sep 17, 11:56 AM · Restricted Project
ldionne requested changes to D62779: [2/2] Fix complexity of map insert_or_assign with a hint..

This looks really good, thanks! Just one comment about structured bindings, and I think we're good to go.

Thu, Sep 17, 11:34 AM · Restricted Project
ldionne committed rGa3c28ccd4939: [libc++] Remove some workarounds for missing variadic templates (authored by ldionne).
[libc++] Remove some workarounds for missing variadic templates
Thu, Sep 17, 8:06 AM
ldionne added a comment to D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

Yes, and the way I would handle this is to change the init_priority value checking to allow values <= 100 if the attribute location is within a system header. This would allow libc++ to use the reserved priority but would still give errors when attempted from user code.

Thu, Sep 17, 7:58 AM · Restricted Project

Wed, Sep 16

ldionne added inline comments to D60368: Add bind_front function (P0356R5).
Wed, Sep 16, 2:57 PM · Restricted Project
ldionne added a comment to D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

What was the conclusion for the comments about the priority level (100 vs. 101)?

Wed, Sep 16, 2:56 PM · Restricted Project
ldionne added a reviewer for D62779: [2/2] Fix complexity of map insert_or_assign with a hint.: Restricted Project.
Wed, Sep 16, 11:34 AM · Restricted Project
ldionne added a comment to D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors.

Abandoned in favour of https://reviews.llvm.org/D31413

Wed, Sep 16, 10:33 AM
ldionne abandoned D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors.
Wed, Sep 16, 10:32 AM
ldionne commandeered D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors.

This is superseded by https://reviews.llvm.org/D31413. Closing to clear up the review queue.

Wed, Sep 16, 10:31 AM
ldionne updated subscribers of D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

@hans Is there still time to cherry-pick this to the 11 release?

Wed, Sep 16, 10:30 AM · Restricted Project
ldionne committed rG39faf428164a: [libc++] Ensure streams are initialized early (authored by ldionne).
[libc++] Ensure streams are initialized early
Wed, Sep 16, 10:19 AM
ldionne closed D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.
Wed, Sep 16, 10:19 AM · Restricted Project
ldionne added inline comments to D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.
Wed, Sep 16, 10:18 AM · Restricted Project
ldionne updated the diff for D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

Add tests.

Wed, Sep 16, 10:18 AM · Restricted Project
ldionne added a comment to D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

Added a test. I can't reproduce the issue, so I don't know whether the test is useful or not. Please help with that!

There are tests in https://reviews.llvm.org/D12689 .

Wed, Sep 16, 9:59 AM · Restricted Project
ldionne added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

That's one hell of a commit message :-)

Wed, Sep 16, 9:51 AM · Restricted Project
ldionne updated the diff for D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

Added a test. I can't reproduce the issue, so I don't know whether the test is useful or not. Please help with that!

Wed, Sep 16, 9:30 AM · Restricted Project
ldionne abandoned D74885: [libcxx] Construct __start_std_streams at high init priority.

This is abandoned for https://reviews.llvm.org/D31413.

Wed, Sep 16, 9:17 AM · Restricted Project
ldionne commandeered D74885: [libcxx] Construct __start_std_streams at high init priority.

Let's close this in favour of https://reviews.llvm.org/D31413 to clean things up.

Wed, Sep 16, 9:17 AM · Restricted Project
ldionne commandeered D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early.

I did some work on trying to reproduce this a while ago but never got to reproducing it on macOS.

Wed, Sep 16, 9:11 AM · Restricted Project

Tue, Sep 15

ldionne committed rG583c8ce30c12: [libc++] Fix broken test for std::any and allocators (authored by ldionne).
[libc++] Fix broken test for std::any and allocators
Tue, Sep 15, 12:02 PM
ldionne committed rGd9c9a74d0dc5: [libc++] Add missing friend keyword (authored by ldionne).
[libc++] Add missing friend keyword
Tue, Sep 15, 11:21 AM
ldionne requested changes to D62779: [2/2] Fix complexity of map insert_or_assign with a hint..
Tue, Sep 15, 9:59 AM · Restricted Project
ldionne committed rG4ddd985ca941: NFC: Add whitespace change to .git-blame-ignore-revs (authored by ldionne).
NFC: Add whitespace change to .git-blame-ignore-revs
Tue, Sep 15, 9:30 AM
ldionne added inline comments to rG3444e9fa1579: config: disable thread safety analysis on COFF.
Tue, Sep 15, 9:22 AM
ldionne committed rG74a9c6d7e1c4: [libc++] Add a benchmark for std::map operations (authored by Mordante).
[libc++] Add a benchmark for std::map operations
Tue, Sep 15, 9:10 AM
ldionne closed D62778: [1/2] Add a benchmark for map operations..
Tue, Sep 15, 9:10 AM · Restricted Project
ldionne added a comment to D62778: [1/2] Add a benchmark for map operations..

I'll ship this now. Thanks.

Tue, Sep 15, 8:08 AM · Restricted Project
ldionne committed rG39c879514170: [libc++] Use allocator_traits to consistently… (authored by mclow.lists).
[libc++] Use allocator_traits to consistently…
Tue, Sep 15, 8:05 AM
ldionne closed D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.
Tue, Sep 15, 8:05 AM · Restricted Project
ldionne added a comment to D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.

@tkoeppe Does this look like a suitable resolution to PR45099?

Without speaking for the dense implementationese, the direction looks good. Thanks!

Tue, Sep 15, 8:01 AM · Restricted Project
ldionne abandoned D66800: Some notes in `LLVM_ENABLE_LIBCXX`.
Tue, Sep 15, 7:58 AM · Restricted Project, Restricted Project
ldionne commandeered D66800: Some notes in `LLVM_ENABLE_LIBCXX`.

No answer in a while -- it looks like this isn't relevant anymore. Cleaning up the review queue.

Tue, Sep 15, 7:58 AM · Restricted Project, Restricted Project
ldionne accepted D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.

@tkoeppe Does this look like a suitable resolution to PR45099?

Tue, Sep 15, 7:53 AM · Restricted Project
ldionne updated the diff for D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.

Add tests

Tue, Sep 15, 7:52 AM · Restricted Project
ldionne commandeered D81133: Use allocator_traits to consistently allocate/deallocate/construct/destroy objects in std::any.

I like this change. It's simple but I think it makes sense. I'll add tests and finish it up.

Tue, Sep 15, 6:58 AM · Restricted Project
ldionne committed rGda104444fafb: [libc++] Allow building without threads in standalone builds (authored by ldionne).
[libc++] Allow building without threads in standalone builds
Tue, Sep 15, 5:45 AM
ldionne closed D60743: Allow building without threads in standalone builds.
Tue, Sep 15, 5:45 AM · Restricted Project, Restricted Project
ldionne added a comment to D59930: Parallel STL version updated.

Abandoned to clear up the review queue.

Tue, Sep 15, 5:41 AM
ldionne abandoned D59930: Parallel STL version updated.
Tue, Sep 15, 5:41 AM
ldionne commandeered D59930: Parallel STL version updated.

This review isn't relevant anymore, the _PSTL_VERSION is now tied to LLVM's version.

Tue, Sep 15, 5:41 AM
ldionne added a comment to D85051: Improve the representation of <compare>'s zero-only type..

@rsmith Would you like me to commit this?

Tue, Sep 15, 5:39 AM · Restricted Project
ldionne accepted D87682: [libcxx] Disable failing test for no-exceptions build.

Please add a comment explaining why it's disabled for no-exceptions, and commit. It's far from obvious.

Tue, Sep 15, 4:59 AM · Restricted Project
ldionne added a comment to D86920: [libcxxabi] Provide options to set compiler/link flags for test programs..

The approach to be taken for all runtime libraries is the one I described with specifying a custom config file. Please abandon!

Tue, Sep 15, 4:58 AM · Restricted Project

Mon, Sep 14

ldionne added a comment to D79888: libc++: include unistd.h if available to get some preprocessor macros.

Is this review still relevant? If not, let's abandon it to clear up the review queue.

Mon, Sep 14, 5:12 PM · Restricted Project
ldionne committed rG8bd0dc5bfe23: [libc++abi] Do not declare __cxa_finalize and __cxa_atexit in <cxxabi.h> (authored by ldionne).
[libc++abi] Do not declare __cxa_finalize and __cxa_atexit in <cxxabi.h>
Mon, Sep 14, 5:11 PM
ldionne closed D75795: [libc++abi] Change __cxa_finalize return type to void.
Mon, Sep 14, 5:10 PM · Restricted Project, Restricted Project, Restricted Project
ldionne accepted D75795: [libc++abi] Change __cxa_finalize return type to void.
Mon, Sep 14, 5:10 PM · Restricted Project, Restricted Project, Restricted Project
ldionne added inline comments to D75795: [libc++abi] Change __cxa_finalize return type to void.
Mon, Sep 14, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D75795: [libc++abi] Change __cxa_finalize return type to void.

Change __cxa_atexit back to returning int

Mon, Sep 14, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
ldionne added a comment to D65721: Make rotate a constexpr.

Re-committed as 3ed89b51da38f081fedb57727076262abb81d149 with UNSUPPORTED markup.

Mon, Sep 14, 5:00 PM · Restricted Project
ldionne committed rG3ed89b51da38: [Take 2] [libc++] Make rotate a constexpr. (authored by zoecarver).
[Take 2] [libc++] Make rotate a constexpr.
Mon, Sep 14, 3:15 PM
ldionne added a comment to D75795: [libc++abi] Change __cxa_finalize return type to void.

Is everyone happy with this?

Mon, Sep 14, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D75795: [libc++abi] Change __cxa_finalize return type to void.

Remove the declarations of cxa_finalize and cxa_atexit

Mon, Sep 14, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
ldionne commandeered D75795: [libc++abi] Change __cxa_finalize return type to void.

Trying to clean up the review queue. Commandeering to propose what seems to be the consensus here.

Mon, Sep 14, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rGb3445c839fac: [libc++][test] Portability fix of std::strstreambuf constructor test (authored by ldionne).
[libc++][test] Portability fix of std::strstreambuf constructor test
Mon, Sep 14, 2:09 PM
ldionne closed D72465: [libcxx] [test] Portability fix of std::strstreambuf constructor test..
Mon, Sep 14, 2:09 PM · Restricted Project
ldionne committed rGb552a30283ce: [libc++] Finish implementing P0202R3 (authored by Nicholas-Baron).
[libc++] Finish implementing P0202R3
Mon, Sep 14, 2:03 PM
ldionne closed D84275: [Libcxx] Finish implementing Paper 0202R3.
Mon, Sep 14, 2:03 PM · Restricted Project
ldionne added a comment to D84275: [Libcxx] Finish implementing Paper 0202R3.

For the record, I tested this in all standard modes using

Mon, Sep 14, 2:03 PM · Restricted Project
ldionne accepted D84275: [Libcxx] Finish implementing Paper 0202R3.
Mon, Sep 14, 2:02 PM · Restricted Project
ldionne updated the diff for D84275: [Libcxx] Finish implementing Paper 0202R3.

Finish up the tests

Mon, Sep 14, 2:00 PM · Restricted Project
ldionne commandeered D84275: [Libcxx] Finish implementing Paper 0202R3.

Commandeering to show exactly what we meant by the requested test changes, however we're very very close here. Thanks a lot for your contribution @Nicholas-Baron !

Mon, Sep 14, 2:00 PM · Restricted Project
ldionne abandoned D78245: [LIT] Make `%T` unique for every test.

Abandoning since this was implemented in 4e813bbdf335626a741398314709a535ef52fe8e. Thanks @EricWF for the improvement, which turned out to simplify a bunch of things!

Mon, Sep 14, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
ldionne commandeered D78245: [LIT] Make `%T` unique for every test.

Commandeering so I can abandon to clean up the review queue.

Mon, Sep 14, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
ldionne requested changes to D69344: [libcxx] Add move constructor to compressed pair.

This sounds reasonable to me, however = default is not going to work in C++03 (unless there's a Clang extension I'm not aware of). @zoecarver Do you still need this?

Mon, Sep 14, 1:24 PM · Restricted Project
ldionne added a comment to D61915: [libcxx] change dylib- XFAILs to UNSUPPORTED.

Is this still relevant? If not, can we close this to clean up the review queue?

Mon, Sep 14, 1:20 PM · Restricted Project
Herald added a reviewer for D60750: [libc++][CMake] Clean up logic for choosing which unwinder lib to link with tests: Restricted Project.

Is this still relevant? You should now be able to specify your own linker flags in the config file by modelling your file on something like libcxx/test/configs/libcxx-trunk-shared.cfg.in.

Mon, Sep 14, 1:18 PM · Restricted Project
ldionne added a comment to D86920: [libcxxabi] Provide options to set compiler/link flags for test programs..

Please take a look at libcxx/test/configs/libcxx-trunk-shared.cfg.in and LIBCXX_TEST_CONFIG in CMake for how to customize exactly how you're running the test suite. This is a lot more powerful and simple than stringing options through CMake!

Mon, Sep 14, 1:15 PM · Restricted Project
ldionne committed rGbecf15527583: [libc++] Add comment in atomic test to explain why part of it is disabled on… (authored by ldionne).
[libc++] Add comment in atomic test to explain why part of it is disabled on…
Mon, Sep 14, 1:13 PM
ldionne closed D87323: Bring atomic header closer to C++20.

This was committed in fc4bff0cd37fa84ee74e6dff7170b643df3ffa42.

Mon, Sep 14, 1:11 PM · Restricted Project
ldionne requested changes to D60368: Add bind_front function (P0356R5).

I'm not seeing any issues with the perfect forwarding anymore. This looks pretty good, with a few comments.

Mon, Sep 14, 1:07 PM · Restricted Project
ldionne accepted D65721: Make rotate a constexpr.

This almost LGTM. You can commit after fixing those comments and I'll adjust the markup for AppleClang as needed.

Mon, Sep 14, 12:43 PM · Restricted Project
ldionne added inline comments to D72240: Implement C++20 std::atomic_ref and test.
Mon, Sep 14, 12:38 PM · Restricted Project
ldionne committed rGf06090243d87: [libc++] Use LLVM 11 instead of trunk on build bots (authored by ldionne).
[libc++] Use LLVM 11 instead of trunk on build bots
Mon, Sep 14, 12:13 PM
ldionne requested changes to D84421: [libcxx][lit] Support shared directories in ssh executor.

I like to keep these executors really simple and doing only a single thing. Would you consider splitting this out into a separate executor instead? Here's what I got, roughly:

Mon, Sep 14, 12:00 PM · Restricted Project
ldionne added a comment to D84097: [libcxx][lit] Add support for custom ssh/scp flags in ssh.py.

LGTM, but based on D84421, do you actually need the extra scp args?

Mon, Sep 14, 11:55 AM · Restricted Project
ldionne accepted D84097: [libcxx][lit] Add support for custom ssh/scp flags in ssh.py.
Mon, Sep 14, 11:51 AM · Restricted Project
ldionne added a reviewer for D72240: Implement C++20 std::atomic_ref and test: __simt__.

Thanks for working on that! I left some general comments, however I believe the best person to give you an in-depth review about this is @__simt__, as a co-author of the paper and as being the de-facto owner of <atomic>.

Mon, Sep 14, 11:23 AM · Restricted Project
ldionne committed rG7235326fb234: [libc++] Upgrade the Clang on build bots (authored by ldionne).
[libc++] Upgrade the Clang on build bots
Mon, Sep 14, 10:52 AM
ldionne committed rG71a16e40f78a: [libcxx] ostream{,buf}_iterator::difference_type changes in C++20 (authored by ldionne).
[libcxx] ostream{,buf}_iterator::difference_type changes in C++20
Mon, Sep 14, 8:09 AM
ldionne closed D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.
Mon, Sep 14, 8:08 AM · Restricted Project
ldionne accepted D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.
Mon, Sep 14, 8:08 AM · Restricted Project

Fri, Sep 11

ldionne committed rGf980ed4184f9: [libcxx] Remove the 'availability' Lit feature (authored by ldionne).
[libcxx] Remove the 'availability' Lit feature
Fri, Sep 11, 8:35 AM
ldionne updated the diff for D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.

Implement the changes for libc++.

Fri, Sep 11, 7:30 AM · Restricted Project
ldionne committed rG4d12d6149ced: [libc++] NFC: Add missing license to test (authored by ldionne).
[libc++] NFC: Add missing license to test
Fri, Sep 11, 7:15 AM
ldionne accepted D87508: [libcxx] Handle target triples with dashes in platform name.

I thought use_system_cxx_lib was only used on Apple platforms!

Fri, Sep 11, 5:52 AM · Restricted Project

Thu, Sep 10

ldionne commandeered D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.

Ah, I see it. I'll add that bit to libc++ so we don't need special casing in the tests.

Feel free to steal this for your test changes. Shall I close this differential then?

Thu, Sep 10, 9:31 AM · Restricted Project
ldionne committed rGb0ae5332dc2b: [libcxx] Make sure we pass -isysroot when linking AND when compiling (authored by ldionne).
[libcxx] Make sure we pass -isysroot when linking AND when compiling
Thu, Sep 10, 9:24 AM