Page MenuHomePhabricator

ldionne (Louis Dionne)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (235 w, 3 d)

Recent Activity

Thu, Aug 15

ldionne abandoned D54810: [libcxx] Apply namespace-scope hidden visibility to libc++.

Abandoning since we should use #pragma clang attribute push with a visibility attribute instead.

Thu, Aug 15, 10:43 AM
ldionne added inline comments to D66262: Constrain tuple/unique_ptr move constructors (2899).
Thu, Aug 15, 10:43 AM
ldionne added inline comments to D66262: Constrain tuple/unique_ptr move constructors (2899).
Thu, Aug 15, 8:48 AM

Wed, Aug 14

ldionne committed rG3f274d4a5596: [libc++] Mark <chrono> test as unsupported on AppleClang 9 (authored by ldionne).
[libc++] Mark <chrono> test as unsupported on AppleClang 9
Wed, Aug 14, 1:28 PM
ldionne committed rL368914: [libc++] Mark <chrono> test as unsupported on AppleClang 9.
[libc++] Mark <chrono> test as unsupported on AppleClang 9
Wed, Aug 14, 1:27 PM
ldionne committed rGb4aebff4f1a6: [libc++] Mark std::tuple CTAD test as failing on AppleClang 9 (authored by ldionne).
[libc++] Mark std::tuple CTAD test as failing on AppleClang 9
Wed, Aug 14, 1:18 PM
ldionne committed rL368911: [libc++] Mark std::tuple CTAD test as failing on AppleClang 9.
[libc++] Mark std::tuple CTAD test as failing on AppleClang 9
Wed, Aug 14, 1:18 PM
ldionne committed rG619172a8184e: [libc++] Enable <chrono> ""d and ""y literals for AppleClang 10 and up (authored by ldionne).
[libc++] Enable <chrono> ""d and ""y literals for AppleClang 10 and up
Wed, Aug 14, 10:05 AM
ldionne committed rL368882: [libc++] Enable <chrono> ""d and ""y literals for AppleClang 10 and up.
[libc++] Enable <chrono> ""d and ""y literals for AppleClang 10 and up
Wed, Aug 14, 10:04 AM
ldionne committed rG3555af7120b9: [libc++] Do not define _LIBCPP_CLANG_VER for non-LLVM Clang (authored by ldionne).
[libc++] Do not define _LIBCPP_CLANG_VER for non-LLVM Clang
Wed, Aug 14, 10:02 AM
ldionne committed rL368880: [libc++] Do not define _LIBCPP_CLANG_VER for non-LLVM Clang.
[libc++] Do not define _LIBCPP_CLANG_VER for non-LLVM Clang
Wed, Aug 14, 10:00 AM
ldionne added a comment to D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared.

Please make sure this passes tests in C++03, C++11, C++14, and C++17.

Wed, Aug 14, 8:55 AM
ldionne accepted D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared.

I checked that the variadic versions of std::allocate_shared and std::make_shared were good. If you did the same mechanical transformation for the non-variadic ones (which it looks like you did), this LGTM.

Wed, Aug 14, 8:55 AM

Tue, Aug 13

ldionne committed rG10f0668b572d: [libc++] Mark two <chrono> tests as unsupported on AppleClang 11 (authored by ldionne).
[libc++] Mark two <chrono> tests as unsupported on AppleClang 11
Tue, Aug 13, 2:38 PM
ldionne committed rL368749: [libc++] Mark two <chrono> tests as unsupported on AppleClang 11.
[libc++] Mark two <chrono> tests as unsupported on AppleClang 11
Tue, Aug 13, 2:34 PM
ldionne added a comment to D62233: General shared_ptr cleanup.

This patch touches a lot of code, and the code it touches is very sensitive (std::shared_ptr is used literally everywhere). That's why I like being able to easily verify its correctness, which reducing the diff or just moving code around (without modifying it -- as much as possible) will make easier in this case.

Tue, Aug 13, 1:58 PM
ldionne added inline comments to D64939: Add a proposal for a libc project under the LLVM umbrella..
Tue, Aug 13, 12:28 PM · Restricted Project
ldionne added inline comments to D64939: Add a proposal for a libc project under the LLVM umbrella..
Tue, Aug 13, 11:34 AM · Restricted Project
ldionne committed rG8a033a9e3fb9: [libc++] Always build with -fvisibility=hidden (authored by ldionne).
[libc++] Always build with -fvisibility=hidden
Tue, Aug 13, 8:05 AM
ldionne committed rL368703: [libc++] Always build with -fvisibility=hidden.
[libc++] Always build with -fvisibility=hidden
Tue, Aug 13, 8:05 AM
ldionne closed D62868: [libc++] Always build with -fvisibility=hidden.
Tue, Aug 13, 8:05 AM · Restricted Project, Restricted Project
ldionne added a comment to D62868: [libc++] Always build with -fvisibility=hidden.

I finally did the test on a docker image mirroring the build bot configuration, and it doesn't appear to break anything. I'll submit this now.

Tue, Aug 13, 7:36 AM · Restricted Project, Restricted Project
ldionne requested changes to D62233: General shared_ptr cleanup.

Could you please split this patch into one that removes the variadic stuff, and one that does the rest (so we can look at them separately). I think we can get rid of the variadic stuff because of Clang extensions, but it's not clear to me the rest is worth doing.

Tue, Aug 13, 7:29 AM
ldionne committed rG1b6d6e595b5e: [pstl] Allow customizing whether per-TU insulation is provided (authored by ldionne).
[pstl] Allow customizing whether per-TU insulation is provided
Tue, Aug 13, 5:50 AM
ldionne committed rL368684: [pstl] Allow customizing whether per-TU insulation is provided.
[pstl] Allow customizing whether per-TU insulation is provided
Tue, Aug 13, 5:49 AM
ldionne committed rG5065e7817393: [pstl] Rename PARALLELSTL_BACKEND to PSTL_PARALLEL_BACKEND (authored by ldionne).
[pstl] Rename PARALLELSTL_BACKEND to PSTL_PARALLEL_BACKEND
Tue, Aug 13, 4:52 AM
ldionne committed rL368672: [pstl] Rename PARALLELSTL_BACKEND to PSTL_PARALLEL_BACKEND.
[pstl] Rename PARALLELSTL_BACKEND to PSTL_PARALLEL_BACKEND
Tue, Aug 13, 4:51 AM
ldionne committed rGfa8cb90e6f1f: [libc++] Fix incorrect UNSUPPORTED annotation (authored by ldionne).
[libc++] Fix incorrect UNSUPPORTED annotation
Tue, Aug 13, 4:27 AM
ldionne committed rL368666: [libc++] Fix incorrect UNSUPPORTED annotation.
[libc++] Fix incorrect UNSUPPORTED annotation
Tue, Aug 13, 4:24 AM
ldionne committed rG86dd28a54714: [libc++] Use [[nodiscard]] for lock_guard, as an extension (authored by ldionne).
[libc++] Use [[nodiscard]] for lock_guard, as an extension
Tue, Aug 13, 4:13 AM
ldionne committed rL368664: [libc++] Use [[nodiscard]] for lock_guard, as an extension.
[libc++] Use [[nodiscard]] for lock_guard, as an extension
Tue, Aug 13, 4:12 AM
ldionne closed D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.
Tue, Aug 13, 4:12 AM · Restricted Project, Restricted Project

Mon, Aug 12

ldionne updated the diff for D65161: [libc++] Implement LWG 2510.

Rebase on top of master. This doesn't have a dependency anymore.

Mon, Aug 12, 11:34 AM · Restricted Project
ldionne committed rG1308011e1b5c: [libc++] Implement CTAD for std::tuple (authored by ldionne).
[libc++] Implement CTAD for std::tuple
Mon, Aug 12, 11:32 AM
ldionne committed rL368599: [libc++] Implement CTAD for std::tuple.
[libc++] Implement CTAD for std::tuple
Mon, Aug 12, 11:29 AM
ldionne closed D65225: [libc++] Implement CTAD for std::tuple.
Mon, Aug 12, 11:29 AM · Restricted Project, Restricted Project
ldionne updated the diff for D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.

Avoid introducing a special macro for [[nodiscard]] on constructors.

Mon, Aug 12, 9:49 AM · Restricted Project, Restricted Project
ldionne added inline comments to D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.
Mon, Aug 12, 8:26 AM

Thu, Aug 8

ldionne added inline comments to D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.
Thu, Aug 8, 1:03 PM · Restricted Project, Restricted Project
ldionne requested changes to D65895: Fix a layering violation in mutex - prep for fixing PR42918.

Apart from my comment, this LGTM.

Thu, Aug 8, 11:40 AM
ldionne committed rG5f92cb70149c: [libc++] Fix environment variable passing in libc++'s `SSHExecutor` `lit`… (authored by ldionne).
[libc++] Fix environment variable passing in libc++'s `SSHExecutor` `lit`…
Thu, Aug 8, 10:34 AM
ldionne committed rL368317: [libc++] Fix environment variable passing in libc++'s `SSHExecutor` `lit`….
[libc++] Fix environment variable passing in libc++'s `SSHExecutor` `lit`…
Thu, Aug 8, 10:33 AM
ldionne closed D65960: Fix environment variable passing in libc++'s `SSHExecutor` `lit` utility.
Thu, Aug 8, 10:33 AM · Restricted Project, Restricted Project
ldionne accepted D65960: Fix environment variable passing in libc++'s `SSHExecutor` `lit` utility.
Thu, Aug 8, 10:33 AM · Restricted Project, Restricted Project
ldionne committed rG09a7a627af08: [NFC][pstl] Run clang-format (authored by ldionne).
[NFC][pstl] Run clang-format
Thu, Aug 8, 10:11 AM
ldionne committed rL368312: [NFC][pstl] Run clang-format.
[NFC][pstl] Run clang-format
Thu, Aug 8, 10:10 AM
ldionne added a comment to D65225: [libc++] Implement CTAD for std::tuple.

The existing tests are missing any deduct.fail.cpp. I guess actually we don't expect std::tuple t(random, args...) to ever fail to compile; but maybe you can imagine a corner case that I haven't.

Thu, Aug 8, 9:34 AM · Restricted Project, Restricted Project
ldionne updated the diff for D65225: [libc++] Implement CTAD for std::tuple.

Address Arthur's comments

Thu, Aug 8, 9:30 AM · Restricted Project, Restricted Project
ldionne updated the diff for D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.

Update the list of entities to which we apply [[nodiscard]]

Thu, Aug 8, 7:54 AM · Restricted Project, Restricted Project
ldionne committed rG215360737941: [pstl] Remove stray semicolon (authored by ldionne).
[pstl] Remove stray semicolon
Thu, Aug 8, 7:50 AM
ldionne committed rL368302: [pstl] Remove stray semicolon.
[pstl] Remove stray semicolon
Thu, Aug 8, 7:48 AM
ldionne committed rGdf13b9393de6: [libc++abi] Fix tests when pstl is enabled (authored by ldionne).
[libc++abi] Fix tests when pstl is enabled
Thu, Aug 8, 5:44 AM
ldionne committed rGa8a436ef9590: [pstl] Error out when the backend is left unspecified (authored by ldionne).
[pstl] Error out when the backend is left unspecified
Thu, Aug 8, 5:43 AM
ldionne committed rGbf4808439f10: [pstl] Add a __pstl_config_site header to record the CMake configuration (authored by ldionne).
[pstl] Add a __pstl_config_site header to record the CMake configuration
Thu, Aug 8, 5:43 AM
ldionne committed rL368286: [libc++abi] Fix tests when pstl is enabled.
[libc++abi] Fix tests when pstl is enabled
Thu, Aug 8, 5:42 AM
ldionne committed rL368285: [pstl] Error out when the backend is left unspecified.
[pstl] Error out when the backend is left unspecified
Thu, Aug 8, 5:42 AM
ldionne committed rL368284: [pstl] Add a __pstl_config_site header to record the CMake configuration.
[pstl] Add a __pstl_config_site header to record the CMake configuration
Thu, Aug 8, 5:42 AM

Wed, Aug 7

ldionne committed rG80ef2f05d878: Revert "[libc++] Take 3: Do not cleverly link against libc++abi just because it… (authored by ldionne).
Revert "[libc++] Take 3: Do not cleverly link against libc++abi just because it…
Wed, Aug 7, 5:29 PM
ldionne committed rL368238: Revert "[libc++] Take 3: Do not cleverly link against libc++abi just because it….
Revert "[libc++] Take 3: Do not cleverly link against libc++abi just because it…
Wed, Aug 7, 5:27 PM
ldionne committed rG127af283abee: [libc++] Remove temporary hack for D63883 (authored by ldionne).
[libc++] Remove temporary hack for D63883
Wed, Aug 7, 2:51 PM
ldionne committed rL368216: [libc++] Remove temporary hack for D63883.
[libc++] Remove temporary hack for D63883
Wed, Aug 7, 2:50 PM
ldionne committed rGe0eed65e068e: [libc++] Take 3: Do not cleverly link against libc++abi just because it happens… (authored by ldionne).
[libc++] Take 3: Do not cleverly link against libc++abi just because it happens…
Wed, Aug 7, 2:38 PM
ldionne added a comment to D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

I'll monitor the bots, but if someone gets here because their build is broken by this commit, it's fine to revert it (but please notify me)!

Wed, Aug 7, 2:38 PM · Restricted Project, Restricted Project
ldionne committed rL368213: [libc++] Take 3: Do not cleverly link against libc++abi just because it happens….
[libc++] Take 3: Do not cleverly link against libc++abi just because it happens…
Wed, Aug 7, 2:35 PM
ldionne closed D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.
Wed, Aug 7, 2:35 PM · Restricted Project, Restricted Project
ldionne committed rG762e662582dd: [pstl] Make sure we install all of PSTL's include/ directory (authored by ldionne).
[pstl] Make sure we install all of PSTL's include/ directory
Wed, Aug 7, 1:30 PM
ldionne committed rL368203: [pstl] Make sure we install all of PSTL's include/ directory.
[pstl] Make sure we install all of PSTL's include/ directory
Wed, Aug 7, 1:29 PM
ldionne created D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension.
Wed, Aug 7, 1:03 PM · Restricted Project, Restricted Project
ldionne accepted D65365: Implement `hh_mm_ss` from P1466R3.

LGTM with my requested changes.

Wed, Aug 7, 9:13 AM

Tue, Aug 6

ldionne committed rG956892433f7c: [pstl][libc++] Provide uglified header names for interface headers (authored by ldionne).
[pstl][libc++] Provide uglified header names for interface headers
Tue, Aug 6, 2:15 PM
ldionne committed rL368088: [pstl][libc++] Provide uglified header names for interface headers.
[pstl][libc++] Provide uglified header names for interface headers
Tue, Aug 6, 2:14 PM
ldionne committed rG53e9c2d76be1: [libc++] Use the monorepo for the back-deployment testing scripts (authored by ldionne).
[libc++] Use the monorepo for the back-deployment testing scripts
Tue, Aug 6, 1:03 PM
ldionne committed rL368077: [libc++] Use the monorepo for the back-deployment testing scripts.
[libc++] Use the monorepo for the back-deployment testing scripts
Tue, Aug 6, 1:03 PM
ldionne added inline comments to D60027: Add shift functions (P0769).
Tue, Aug 6, 12:51 PM
ldionne added a comment to D65816: [libcxx] Mark unsupported tests under root user.

@ldionne Got it. Thank you for your explanation!

Tue, Aug 6, 12:08 PM · Restricted Project
ldionne added a comment to D65365: Implement `hh_mm_ss` from P1466R3.

We have a "power of 10" table in charconv, but I don't think that coupling <chrono> and <charconv> is worth the benefit of removing this small routine.

Tue, Aug 6, 12:06 PM
ldionne added a comment to D65816: [libcxx] Mark unsupported tests under root user.
Tue, Aug 6, 11:45 AM · Restricted Project
ldionne added inline comments to D65721: Make rotate a constexpr.
Tue, Aug 6, 11:32 AM
ldionne requested changes to D65816: [libcxx] Mark unsupported tests under root user.

I would suggest not running the tests under sudo.

Tue, Aug 6, 11:21 AM · Restricted Project
ldionne committed rG8442252c4908: [libc++] Use the monorepo in the macos-trunk CI script (authored by ldionne).
[libc++] Use the monorepo in the macos-trunk CI script
Tue, Aug 6, 8:31 AM
ldionne committed rL368051: [libc++] Use the monorepo in the macos-trunk CI script.
[libc++] Use the monorepo in the macos-trunk CI script
Tue, Aug 6, 8:31 AM

Mon, Aug 5

ldionne requested changes to D65365: Implement `hh_mm_ss` from P1466R3.
Mon, Aug 5, 2:44 PM
ldionne committed rGd1317133071e: [libc++] Accept any non-zero return for .fail.cpp tests (authored by ldionne).
[libc++] Accept any non-zero return for .fail.cpp tests
Mon, Aug 5, 2:28 PM
ldionne committed rL367930: [libc++] Accept any non-zero return for .fail.cpp tests.
[libc++] Accept any non-zero return for .fail.cpp tests
Mon, Aug 5, 2:26 PM
ldionne committed rG23f073100d5c: [NFC][pstl] Remove stray semi-colon (authored by ldionne).
[NFC][pstl] Remove stray semi-colon
Mon, Aug 5, 2:21 PM
ldionne committed rL367928: [NFC][pstl] Remove stray semi-colon.
[NFC][pstl] Remove stray semi-colon
Mon, Aug 5, 2:21 PM
ldionne added a comment to D65225: [libc++] Implement CTAD for std::tuple.

Ping.

Mon, Aug 5, 11:42 AM · Restricted Project, Restricted Project
ldionne committed rG0a06eb911b83: [libc++] Take 2: Integrate the PSTL into libc++ (authored by ldionne).
[libc++] Take 2: Integrate the PSTL into libc++
Mon, Aug 5, 11:30 AM
ldionne committed rL367903: [libc++] Take 2: Integrate the PSTL into libc++.
[libc++] Take 2: Integrate the PSTL into libc++
Mon, Aug 5, 11:30 AM
ldionne closed D60480: [libc++] Integrate the PSTL into libc++.
Mon, Aug 5, 11:29 AM · Restricted Project, Restricted Project
ldionne accepted D62228: Make `vector` unconditionally move elements when exceptions are disabled..
Mon, Aug 5, 10:32 AM · Restricted Project
ldionne requested changes to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Please also add installation, since pretty-printers should be shipped with libc++, same as GCC does with libstdc++ and its pretty-printers.

Did these pretty-printers exist for libc++ before this patch? If so, how were they shipped?

There is separate project on GitHub. It was mentioned in libcxx/docs/UsingLibcxx.rst.

Mon, Aug 5, 10:21 AM · Restricted Project
ldionne requested changes to D60027: Add shift functions (P0769).
Mon, Aug 5, 10:13 AM
ldionne added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Please also add installation, since pretty-printers should be shipped with libc++, same as GCC does with libstdc++ and its pretty-printers.

Mon, Aug 5, 10:11 AM · Restricted Project
ldionne added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

I want to echo this. This is really cool. I _really_ hope we can get something similar for LLDB.

LLDB has pretty-printers. They are implemented in C++ instead of scripting.

Mon, Aug 5, 9:50 AM · Restricted Project
ldionne added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

Mon, Aug 5, 9:33 AM · Restricted Project
ldionne requested changes to D65721: Make rotate a constexpr.
Mon, Aug 5, 9:30 AM

Tue, Jul 30

ldionne updated the diff for D60480: [libc++] Integrate the PSTL into libc++.
  • Invert the logic to avoid defining a __config_site all the time
  • Remove calls to find_package to make it obvious we're version-locked with the PSTL
Tue, Jul 30, 2:08 PM · Restricted Project, Restricted Project
ldionne added inline comments to D60480: [libc++] Integrate the PSTL into libc++.
Tue, Jul 30, 2:08 PM · Restricted Project, Restricted Project
ldionne updated subscribers of D65348: enable <atomic> header on systems without thread-support.

Adding @EricWF and @mclow.lists for awareness.

Tue, Jul 30, 11:08 AM