Page MenuHomePhabricator

ldionne (Louis Dionne)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (228 w, 4 h)

Recent Activity

Today

ldionne planned changes to D60480: [libc++] Integrate the PSTL into libc++.
Wed, Jun 26, 3:54 PM · Restricted Project, Restricted Project

Yesterday

ldionne added a comment to D61340: [pstl] Move the dummy standard library headers to extra/.

Louis,
thanks for the alternative proposal.

A couple of question:

  1. What's motivation to change "stdlib" to "extra"? To avoid some confusing? (because "stdlib" is not a part of the standard library here)
  2. Can we keep "pstl" name (instead of proposed "include")? The fact is many people have already use PSTL code (as "third party" headers) and a usage model is following:

    #include "pstl/execution" #include "pstl/algorithm" #include "pstl/numeric" #include "pstl/memory"

    We would not like to force them changing #include "pstl/execution" to #include "include/execution"
Tue, Jun 25, 1:36 PM · Restricted Project
ldionne added a comment to D60480: [libc++] Integrate the PSTL into libc++.

Please note that this review is really about integrating pstl into libc++, not pstl itself. I know there are changed needed before pstl is ready for prime time (and LIBCXX_ENABLE_PARALLEL_ALGORITHMS becomes ON by default).

Tue, Jun 25, 1:21 PM · Restricted Project, Restricted Project

Thu, Jun 20

ldionne committed rGf2f7d72f0052: [libc++] Take 2: Implement CTAD for map and multimap (authored by ldionne).
[libc++] Take 2: Implement CTAD for map and multimap
Thu, Jun 20, 12:30 PM
ldionne committed rL363968: [libc++] Take 2: Implement CTAD for map and multimap.
[libc++] Take 2: Implement CTAD for map and multimap
Thu, Jun 20, 12:29 PM
ldionne closed D58587: Implement P0433: deduction guides for <map>.
Thu, Jun 20, 12:29 PM · Restricted Project
ldionne abandoned D60537: [pstl] Do not inject execution policies into namespace ::pstl in the tests.
Thu, Jun 20, 11:27 AM · Restricted Project
ldionne abandoned D61340: [pstl] Move the dummy standard library headers to extra/.
Thu, Jun 20, 11:25 AM · Restricted Project
ldionne retitled D60480: [libc++] Integrate the PSTL into libc++ from [WIP] integration of pstl into libc++ to [libc++] Integrate the PSTL into libc++.
Thu, Jun 20, 11:20 AM · Restricted Project, Restricted Project
ldionne updated the diff for D60480: [libc++] Integrate the PSTL into libc++.

Non-draft version of the patch.

Thu, Jun 20, 11:19 AM · Restricted Project, Restricted Project
ldionne committed rG04c5bc989a31: [pstl] Default to the serial backend when unspecified (authored by ldionne).
[pstl] Default to the serial backend when unspecified
Thu, Jun 20, 10:56 AM
ldionne committed rL363958: [pstl] Default to the serial backend when unspecified.
[pstl] Default to the serial backend when unspecified
Thu, Jun 20, 10:55 AM
ldionne committed rG6ab35c9dc0bc: [pstl] Mark pstl tests as unsupported before C++17 (authored by ldionne).
[pstl] Mark pstl tests as unsupported before C++17
Thu, Jun 20, 9:22 AM
ldionne committed rL363942: [pstl] Mark pstl tests as unsupported before C++17.
[pstl] Mark pstl tests as unsupported before C++17
Thu, Jun 20, 9:19 AM

Wed, Jun 19

ldionne committed rG3491119f9ba4: [pstl] Remove warnings in tests and headers (authored by ldionne).
[pstl] Remove warnings in tests and headers
Wed, Jun 19, 1:15 PM
ldionne committed rL363872: [pstl] Remove warnings in tests and headers.
[pstl] Remove warnings in tests and headers
Wed, Jun 19, 1:14 PM
ldionne committed rG205ead8c16f9: [NFC][libc++] Remove stray semi-colon after function definition (authored by ldionne).
[NFC][libc++] Remove stray semi-colon after function definition
Wed, Jun 19, 9:33 AM
ldionne committed rL363835: [NFC][libc++] Remove stray semi-colon after function definition.
[NFC][libc++] Remove stray semi-colon after function definition
Wed, Jun 19, 9:30 AM
ldionne added a comment to D63328: [libc++] Avoid using timespec when it might not be available.

From my perspective, this patch is fine since we already have __libcpp_condvar_t and __libcpp_mutex_t, so in some way we're even making things more consistent. I'll commit this tomorrow unless there are reasons why this is harmful.

Wed, Jun 19, 8:59 AM · Restricted Project, Restricted Project

Tue, Jun 18

ldionne committed rG64fbefde6eb6: [libcxxabi] Remove the unused buildit script (authored by ldionne).
[libcxxabi] Remove the unused buildit script
Tue, Jun 18, 1:41 PM
ldionne committed rL363737: [libcxxabi] Remove the unused buildit script.
[libcxxabi] Remove the unused buildit script
Tue, Jun 18, 1:41 PM
ldionne closed D63297: [libcxxabi] Remove the unused buildit script.
Tue, Jun 18, 1:40 PM · Restricted Project, Restricted Project
ldionne committed rG050b804b139e: [pstl] Disable workarounds for broken ICC versions when using Clang (authored by ldionne).
[pstl] Disable workarounds for broken ICC versions when using Clang
Tue, Jun 18, 12:46 PM
ldionne committed rL363726: [pstl] Disable workarounds for broken ICC versions when using Clang.
[pstl] Disable workarounds for broken ICC versions when using Clang
Tue, Jun 18, 12:46 PM
ldionne committed rG9d54063c8239: [pstl] Remove stray usage of pstl::execution instead of std::execution (authored by ldionne).
[pstl] Remove stray usage of pstl::execution instead of std::execution
Tue, Jun 18, 12:34 PM
ldionne committed rL363723: [pstl] Remove stray usage of pstl::execution instead of std::execution.
[pstl] Remove stray usage of pstl::execution instead of std::execution
Tue, Jun 18, 12:30 PM
ldionne accepted D58587: Implement P0433: deduction guides for <map>.
Tue, Jun 18, 12:03 PM · Restricted Project
ldionne committed rG91185b69d12e: [libc++] Re-apply XFAIL to is_base_of test that was inadvertently reverted (authored by ldionne).
[libc++] Re-apply XFAIL to is_base_of test that was inadvertently reverted
Tue, Jun 18, 7:59 AM
ldionne committed rL363689: [libc++] Re-apply XFAIL to is_base_of test that was inadvertently reverted.
[libc++] Re-apply XFAIL to is_base_of test that was inadvertently reverted
Tue, Jun 18, 7:59 AM
ldionne requested changes to D58590: Implement P0433: deduction guides for <unordered_map>.

Can you test this against Clang trunk and confirm that it works?

Tue, Jun 18, 7:41 AM
ldionne committed rG1fab01f92bdb: [libc++] Revert the addition of map/multimap CTAD (authored by ldionne).
[libc++] Revert the addition of map/multimap CTAD
Tue, Jun 18, 7:39 AM
ldionne committed rL363688: [libc++] Revert the addition of map/multimap CTAD.
[libc++] Revert the addition of map/multimap CTAD
Tue, Jun 18, 7:37 AM
ldionne added inline comments to D63457: [libc++] Re-export libc++abi as a whole instead of using lists.
Tue, Jun 18, 7:26 AM · Restricted Project
ldionne added a comment to D63457: [libc++] Re-export libc++abi as a whole instead of using lists.

Did sym_extract.py remove those symbols from the list, or were they removed manually? Because they should still be present in the libc++ symbol table as imported definitions (I think).

Tue, Jun 18, 7:26 AM · Restricted Project
ldionne accepted D63328: [libc++] Avoid using timespec when it might not be available.

__libcpp_condvar_timedwait needs to be implemented in a different TU, so it can't be a template and at the same time it needs some sort of time point. I think timespec was chosen because it is what pthread_cond_timedwait expects. Do you think a specialization of chrono::time_point (like chrono::time_point<chrono::system_clock, chrono::nanoseconds> used by condition_variable::__do_timed_wait) would make more sense here?

Tue, Jun 18, 5:20 AM · Restricted Project, Restricted Project

Mon, Jun 17

ldionne created D63457: [libc++] Re-export libc++abi as a whole instead of using lists.
Mon, Jun 17, 1:44 PM · Restricted Project
ldionne requested changes to D63328: [libc++] Avoid using timespec when it might not be available.

I don't mind the change (it's safe, simple, etc.). However, I don't understand why timespec is being tied to threads and < __external_threading>. Is is possible that it's only a convenient way of doing it right now?

Mon, Jun 17, 1:38 PM · Restricted Project, Restricted Project
ldionne committed rG15722626e329: [NFC] Assign a couple of LWG issues to myself (authored by ldionne).
[NFC] Assign a couple of LWG issues to myself
Mon, Jun 17, 12:38 PM
ldionne committed rL363605: [NFC] Assign a couple of LWG issues to myself.
[NFC] Assign a couple of LWG issues to myself
Mon, Jun 17, 12:37 PM
ldionne committed rGbe8c669af056: [libc++] Update ABI list for ABI v2 (authored by ldionne).
[libc++] Update ABI list for ABI v2
Mon, Jun 17, 12:37 PM
ldionne committed rL363603: [libc++] Update ABI list for ABI v2.
[libc++] Update ABI list for ABI v2
Mon, Jun 17, 12:36 PM
ldionne added inline comments to D60666: Fix some constexpr members in array<T, 0>.
Mon, Jun 17, 8:42 AM

Fri, Jun 14

ldionne added a comment to D63345: [libcxxabi] Use an explicit list to export symbols from the dylib.

add_llvm_symbol_exports in the LLVM CMake files have a cross-platform way of doing export files: http://llvm-cs.pcc.me.uk/cmake/modules/AddLLVM.cmake#71

It compiles to exported_symbols_list on mac, creates a linker script on posix, and creates a def file on Windows.

Fri, Jun 14, 10:54 AM · Restricted Project
ldionne added a comment to D63345: [libcxxabi] Use an explicit list to export symbols from the dylib.

I couldn't find an equivalent to -exported_symbols_lists on GNU ld, but I'm all ears.

Fri, Jun 14, 10:22 AM · Restricted Project
ldionne added a reviewer for D63345: [libcxxabi] Use an explicit list to export symbols from the dylib: phosek.
Fri, Jun 14, 10:22 AM · Restricted Project
ldionne created D63345: [libcxxabi] Use an explicit list to export symbols from the dylib.
Fri, Jun 14, 10:22 AM · Restricted Project
ldionne committed rG0feebef501fc: [libcxx] Add XFAIL for facet test when back-deploying to older macOS (authored by ldionne).
[libcxx] Add XFAIL for facet test when back-deploying to older macOS
Fri, Jun 14, 7:39 AM
ldionne committed rL363405: [libcxx] Add XFAIL for facet test when back-deploying to older macOS.
[libcxx] Add XFAIL for facet test when back-deploying to older macOS
Fri, Jun 14, 7:37 AM
ldionne requested changes to D60666: Fix some constexpr members in array<T, 0>.
Fri, Jun 14, 7:18 AM

Thu, Jun 13

ldionne added a comment to D63297: [libcxxabi] Remove the unused buildit script.

I'll leave this open for a little while so that people have a chance to say if they're still using it -- but I think this is just dead code now.

Thu, Jun 13, 2:20 PM · Restricted Project, Restricted Project
ldionne created D63297: [libcxxabi] Remove the unused buildit script.
Thu, Jun 13, 2:18 PM · Restricted Project, Restricted Project
ldionne committed rG64c1d456c1b2: [libc++] Add missing #include in <cwchar> tests (authored by ldionne).
[libc++] Add missing #include in <cwchar> tests
Thu, Jun 13, 11:26 AM
ldionne committed rL363290: [libc++] Add missing #include in <cwchar> tests.
[libc++] Add missing #include in <cwchar> tests
Thu, Jun 13, 11:21 AM
ldionne closed D63289: [libc++] Add missing #include in tests.
Thu, Jun 13, 11:21 AM · Restricted Project, Restricted Project
ldionne accepted D63289: [libc++] Add missing #include in tests.
Thu, Jun 13, 11:01 AM · Restricted Project, Restricted Project
ldionne accepted D63284: [libc++] Keep __regex_word in sync with ctype_base.

I looked at it and I don't think this is an ABI break. Because of the way __regex_word is used (it's never passed through an ABI boundary, instead we use "w". Also this doesn't impact Apple platforms, so I'm personally fine with it.

Thu, Jun 13, 10:58 AM · Restricted Project, Restricted Project

Wed, Jun 12

ldionne committed rGc45f592b98f9: [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10 (authored by ldionne).
[libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10
Wed, Jun 12, 2:59 PM
ldionne committed rL363209: [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10.
[libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10
Wed, Jun 12, 2:58 PM
ldionne requested changes to D62454: SFINAE on pair/tuple assignment operators 2729.
Wed, Jun 12, 1:46 PM
ldionne accepted D63154: Make GCC in C++03 Unsupported.
Wed, Jun 12, 1:30 PM · Restricted Project
ldionne committed rG782fff1bf879: [libcxx] XFAIL some CTAD tests on AppleClang 10 (authored by ldionne).
[libcxx] XFAIL some CTAD tests on AppleClang 10
Wed, Jun 12, 1:11 PM
ldionne committed rL363197: [libcxx] XFAIL some CTAD tests on AppleClang 10.
[libcxx] XFAIL some CTAD tests on AppleClang 10
Wed, Jun 12, 1:11 PM

Tue, Jun 11

ldionne committed rGc06943b67d14: [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple… (authored by ldionne).
[libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple…
Tue, Jun 11, 3:35 PM
ldionne committed rL363107: [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple….
[libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple…
Tue, Jun 11, 3:33 PM
ldionne committed rGe20865c387e0: [libc++] Implement deduction guides for <set> (authored by ldionne).
[libc++] Implement deduction guides for <set>
Tue, Jun 11, 11:20 AM
ldionne committed rL363090: [libc++] Implement deduction guides for <set>.
[libc++] Implement deduction guides for <set>
Tue, Jun 11, 11:20 AM
ldionne closed D58582: Implement P0433: deduction guides for <set>.
Tue, Jun 11, 11:20 AM · Restricted Project
ldionne accepted D58582: Implement P0433: deduction guides for <set>.
Tue, Jun 11, 8:32 AM · Restricted Project
ldionne accepted D63053: Add nullptr output operator overload (2221).
Tue, Jun 11, 8:27 AM
ldionne committed rG405570dc7a95: [libcxx] Make std::tuple<> trivially constructible (authored by ldionne).
[libcxx] Make std::tuple<> trivially constructible
Tue, Jun 11, 8:01 AM
ldionne committed rL363075: [libcxx] Make std::tuple<> trivially constructible.
[libcxx] Make std::tuple<> trivially constructible
Tue, Jun 11, 7:59 AM
ldionne closed D62618: [libcxx] Make std::tuple<> trivially constructible.
Tue, Jun 11, 7:59 AM · Restricted Project, Restricted Project
ldionne committed rG776acf225b37: [libcxx] Slightly improved policy for handling experimental features (authored by ldionne).
[libcxx] Slightly improved policy for handling experimental features
Tue, Jun 11, 7:48 AM
ldionne committed rL363072: [libcxx] Slightly improved policy for handling experimental features.
[libcxx] Slightly improved policy for handling experimental features
Tue, Jun 11, 7:48 AM
ldionne closed D62428: [libcxx] Slightly improved policy for handling experimental features.
Tue, Jun 11, 7:48 AM · Restricted Project, Restricted Project

Thu, Jun 6

ldionne added inline comments to D62719: A hot fix for exclusive_scan.
Thu, Jun 6, 4:29 PM

Wed, Jun 5

ldionne committed rG8f500a6f9ca0: [libcxx][test] Include test_workarounds.h where needed (authored by ldionne).
[libcxx][test] Include test_workarounds.h where needed
Wed, Jun 5, 2:54 PM
ldionne committed rL362660: [libcxx][test] Include test_workarounds.h where needed.
[libcxx][test] Include test_workarounds.h where needed
Wed, Jun 5, 2:51 PM
ldionne closed D62920: Included `test/support/test_workarounds.h` which actually defines `TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT` for variant tests..
Wed, Jun 5, 2:51 PM · Restricted Project
ldionne added inline comments to D62928: Constrain function assignment operator (2574).
Wed, Jun 5, 2:40 PM
ldionne accepted D62932: Update status.

2750 nothing to do because std::experimental::optional no longer exists.

Wed, Jun 5, 2:36 PM
ldionne accepted D62920: Included `test/support/test_workarounds.h` which actually defines `TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT` for variant tests..
Wed, Jun 5, 2:29 PM · Restricted Project
ldionne requested changes to D62928: Constrain function assignment operator (2574).

Thanks for working on this.

Wed, Jun 5, 2:27 PM
ldionne added a comment to D62868: [libc++] Always build with -fvisibility=hidden.

I'll ship this next week once I've tested it on a Linux Docker image (I don't have access to that right now). I'm not sure, but I think I remember trying to make this change a while back and breaking the bots.

Wed, Jun 5, 2:18 PM · Restricted Project
ldionne accepted D59925: The optimized parallel versions of sort, stable_sort algorithms..
Wed, Jun 5, 9:31 AM · Restricted Project

Tue, Jun 4

ldionne added a comment to D62618: [libcxx] Make std::tuple<> trivially constructible.

Just to confirm, @mclow.lists are we OK with this since the LWG issue has been filed?

Tue, Jun 4, 1:48 PM · Restricted Project, Restricted Project
ldionne accepted D62874: Fix libc++'s lit configuration language dialect inference for GCC 5 and GCC 6.

I'm okay with this (I don't care much about GCC), but I want to point out you're basically reducing the usefulness of the test suite on GCC 5/6 by just wholesale removing all C++17 tests, when GCC5/6 can actually run a large subset of the tests.

Tue, Jun 4, 1:16 PM
ldionne added a comment to D62868: [libc++] Always build with -fvisibility=hidden.

This is in response to https://bugs.llvm.org/show_bug.cgi?id=38138, correct?

Tue, Jun 4, 10:58 AM · Restricted Project
ldionne updated subscribers of D62868: [libc++] Always build with -fvisibility=hidden.

@phosek You may want to take a look too.

Tue, Jun 4, 10:40 AM · Restricted Project
ldionne created D62868: [libc++] Always build with -fvisibility=hidden.
Tue, Jun 4, 10:39 AM · Restricted Project
ldionne committed rGc3c23b27a4d1: [libcxx] Add test to check min/max requirement to regular expression (authored by ldionne).
[libcxx] Add test to check min/max requirement to regular expression
Tue, Jun 4, 9:46 AM
ldionne committed rL362525: [libcxx] Add test to check min/max requirement to regular expression.
[libcxx] Add test to check min/max requirement to regular expression
Tue, Jun 4, 9:46 AM
ldionne closed D62816: [libcxx] Add test to check min/max requirement to regular expression..
Tue, Jun 4, 9:46 AM · Restricted Project
ldionne accepted D62816: [libcxx] Add test to check min/max requirement to regular expression..

I'll fix it when applying the patch.

Tue, Jun 4, 9:46 AM · Restricted Project
ldionne added a comment to D62816: [libcxx] Add test to check min/max requirement to regular expression..

I don't understand the request. Please, clarify. Also, it would help if you use the terms from the comments in the suggested test.

Tue, Jun 4, 9:31 AM · Restricted Project
ldionne added a comment to D62770: [libcxx] Use libtool when merging archives on Apple platforms.

LGTM

Tue, Jun 4, 9:24 AM · Restricted Project

Mon, Jun 3

ldionne requested changes to D62816: [libcxx] Add test to check min/max requirement to regular expression..

I think separate tests for a >= b and a <= max would be better, though.

Mon, Jun 3, 5:29 PM · Restricted Project
ldionne accepted D62816: [libcxx] Add test to check min/max requirement to regular expression..

This seems reasonable to me. We seem to already be passing this test.

Mon, Jun 3, 5:23 PM · Restricted Project

Fri, May 31

ldionne added inline comments to D62428: [libcxx] Slightly improved policy for handling experimental features.
Fri, May 31, 12:39 PM · Restricted Project, Restricted Project
ldionne updated the diff for D62428: [libcxx] Slightly improved policy for handling experimental features.

Address reviewer's comments

Fri, May 31, 12:36 PM · Restricted Project, Restricted Project