- User Since
- Feb 11 2015, 3:26 PM (235 w, 3 d)
Thu, Aug 15
Abandoning since we should use #pragma clang attribute push with a visibility attribute instead.
Wed, Aug 14
Please make sure this passes tests in C++03, C++11, C++14, and C++17.
I checked that the variadic versions of std::allocate_shared and std::make_shared were good. If you did the same mechanical transformation for the non-variadic ones (which it looks like you did), this LGTM.
Tue, Aug 13
This patch touches a lot of code, and the code it touches is very sensitive (std::shared_ptr is used literally everywhere). That's why I like being able to easily verify its correctness, which reducing the diff or just moving code around (without modifying it -- as much as possible) will make easier in this case.
I finally did the test on a docker image mirroring the build bot configuration, and it doesn't appear to break anything. I'll submit this now.
Could you please split this patch into one that removes the variadic stuff, and one that does the rest (so we can look at them separately). I think we can get rid of the variadic stuff because of Clang extensions, but it's not clear to me the rest is worth doing.
Mon, Aug 12
Rebase on top of master. This doesn't have a dependency anymore.
Avoid introducing a special macro for [[nodiscard]] on constructors.
Thu, Aug 8
Apart from my comment, this LGTM.
Address Arthur's comments
Update the list of entities to which we apply [[nodiscard]]
Wed, Aug 7
I'll monitor the bots, but if someone gets here because their build is broken by this commit, it's fine to revert it (but please notify me)!
LGTM with my requested changes.
Tue, Aug 6
I would suggest not running the tests under sudo.
Mon, Aug 5
Tue, Jul 30
- Invert the logic to avoid defining a __config_site all the time
- Remove calls to find_package to make it obvious we're version-locked with the PSTL