Page MenuHomePhabricator

ldionne (Louis Dionne)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (257 w, 4 d)

Recent Activity

Tue, Jan 14

ldionne created D72708: [libc++] Make sure std::is_object returns true for block types.
Tue, Jan 14, 8:12 AM · Restricted Project

Dec 12 2019

ldionne committed rG3665104f1f35: Merge remote-tracking branch 'mirror/master' (authored by ldionne).
Merge remote-tracking branch 'mirror/master'
Dec 12 2019, 11:32 AM

Dec 10 2019

ldionne committed rGdd37e24ae623: [libc++] Hide some functions and types in <future> and <thread> as hidden (authored by ldionne).
[libc++] Hide some functions and types in <future> and <thread> as hidden
Dec 10 2019, 4:27 PM
ldionne requested changes to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

Thanks a lot for your work (and anyone else that's participated). I've left a few comments, but obviously this patch is huge. @STL_MSFT How do you want to proceed with this? We can either back-and-forth on this review until we're happy and we can ship it (my preference), or if you prefer someone from libc++ can take over the patch from here. My preference is clearly the former, but I want to avoid annoying you in case you don't have time for this.

Dec 10 2019, 2:28 PM · Restricted Project
ldionne committed rG8bd9d0bff21b: [libcxx] [test] Query the target platform, not the host one (authored by ldionne).
[libcxx] [test] Query the target platform, not the host one
Dec 10 2019, 1:42 PM
ldionne closed D68275: [libcxx] [test] Query the target platform, not the host one.
Dec 10 2019, 1:42 PM · Restricted Project
ldionne requested changes to D70991: [libc++][test] Replace platform.linux_distribution by distro.linux_distribution.

Is import distro supported in Python 2.x?

Dec 10 2019, 1:42 PM · Restricted Project

Nov 18 2019

ldionne committed rG991831268285: [libc++] Separate -include and path to the site config file (authored by ldionne).
[libc++] Separate -include and path to the site config file
Nov 18 2019, 1:34 PM
ldionne requested changes to D68480: Implementation of C++20's P1135R6 for libcxx.

It would be great to document these macros somewhere in the code or in a .rst document.

Nov 18 2019, 1:15 PM
ldionne accepted D70336: Explicitly enumerate std::string external instantiations..

I love this. It's more verbose but it also gives us more explicit control over our ABI list, which is great. We'll run into problems when wanting to explicitly instantiate the vtable of types that have one (if we eventually generalize this approach to other types). This is one of the reasons why I wrote http://wg21.link/p1263. However, none of this is needed for just std::string.

Nov 18 2019, 9:56 AM

Nov 14 2019

ldionne committed rG1466335cf4b2: [libc++][P1872] span should have size_type, not index_type. (authored by ldionne).
[libc++][P1872] span should have size_type, not index_type.
Nov 14 2019, 6:17 AM
ldionne closed D70206: [libc++] [P1872] span should have size_type, not index_type..
Nov 14 2019, 6:17 AM · Restricted Project
ldionne accepted D70206: [libc++] [P1872] span should have size_type, not index_type..

Thanks!

Nov 14 2019, 6:17 AM · Restricted Project
ldionne added a comment to D56398: Add new EINTEGRITY errno.
In D56398#1744453, @dim wrote:

Sorry if this is a basic question, but why are we trying to provide EINTEGRITY in libc++'s errno.h header at all? I don't see this being part of the C or C++ Standard.

That is a very good question, this review has been sitting for so long that the reason also slipped my mind. :) @emaste any idea? As far as I remember, this "new" errno value was added by Kirk McKusick after he added integrity checks to the BSD FFS file system, and I suspect he just went through all headers that referred to file system specific errno values to extend them.

That said, doesn't libc++'s errno.h also provide lots of errno values that are not standardized anywhere? (I'm not even sure if there *is* a standardized list of "must support" errno values...)

Nov 14 2019, 6:08 AM
ldionne committed rG8b77a3a0f4ef: [libc++] [P1612] Add missing feature-test macro __cpp_lib_endian. (authored by ldionne).
[libc++] [P1612] Add missing feature-test macro __cpp_lib_endian.
Nov 14 2019, 5:59 AM
ldionne closed D70221: [libc++] [P1612] Add missing feature-test macro __cpp_lib_endian..
Nov 14 2019, 5:59 AM · Restricted Project
ldionne requested changes to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Except for the nitpick, LGTM.

Nov 14 2019, 5:58 AM · Restricted Project
ldionne accepted D70221: [libc++] [P1612] Add missing feature-test macro __cpp_lib_endian..

Thanks!

Nov 14 2019, 5:58 AM · Restricted Project

Nov 13 2019

ldionne requested changes to D56398: Add new EINTEGRITY errno.

Sorry if this is a basic question, but why are we trying to provide EINTEGRITY in libc++'s errno.h header at all? I don't see this being part of the C or C++ Standard.

Nov 13 2019, 9:32 AM
ldionne added inline comments to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
Nov 13 2019, 9:32 AM · Restricted Project
ldionne resigned from D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Nov 13 2019, 9:04 AM · Restricted Project
ldionne requested changes to D70117: [libc++][P0174] Deprecated/removed parts of default allocator..
Nov 13 2019, 8:58 AM · Restricted Project
ldionne requested changes to D69132: [libc++][P0784] Marked the default allocator constexpr..
Nov 13 2019, 8:37 AM · Restricted Project
ldionne requested changes to D69803: [libc++][P0784] Marked allocator_traits constexpr..
Nov 13 2019, 8:18 AM · Restricted Project
ldionne requested changes to D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..
Nov 13 2019, 8:18 AM · Restricted Project
ldionne requested changes to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
Nov 13 2019, 8:08 AM · Restricted Project

Nov 11 2019

ldionne committed rG48b7068beca9: [libc++] Mark __call_once_proxy as hidden and internal (authored by ldionne).
[libc++] Mark __call_once_proxy as hidden and internal
Nov 11 2019, 7:36 AM
ldionne added a comment to D54439: CMake: Make most target symbols hidden by default.

Rebase on trunk.

The warnings are still present on OS X. Here is a build log:
https://github.com/tstellar/llvm-project/pull/11/checks?check_run_id=275366813

@tstellar Can you add _LIBCPP_INLINE_VISIBILITY to __call_once_proxy and see whether that fixes the warning? I believe that is the correct fix, now that we don't use always_inline anymore to implement _LIBCPP_INLINE_VISIBILITY.

I've added _LIBCPP_INLINE_VISIBILITY to __call_once_proxy locally and everything works, but I don't have your specific patch to test locally.

Nov 11 2019, 7:36 AM · Restricted Project
ldionne added a comment to D54439: CMake: Make most target symbols hidden by default.

Rebase on trunk.

The warnings are still present on OS X. Here is a build log:
https://github.com/tstellar/llvm-project/pull/11/checks?check_run_id=275366813

Nov 11 2019, 7:09 AM · Restricted Project

Nov 7 2019

ldionne committed rG0ec6a4882eeb: [libc++] Fix potential OOB in poisson_distribution (authored by ldionne).
[libc++] Fix potential OOB in poisson_distribution
Nov 7 2019, 5:33 AM
ldionne committed rG83901cbe5e21: [libc++] Fixed copy/copy_n/copy_backward for compilers that do not support… (authored by ldionne).
[libc++] Fixed copy/copy_n/copy_backward for compilers that do not support…
Nov 7 2019, 4:47 AM
ldionne closed D69940: [libc++] Fixed copy/copy_n/copy_backward for compilers that do not support is_constant_evaluated..
Nov 7 2019, 4:46 AM · Restricted Project
ldionne accepted D69940: [libc++] Fixed copy/copy_n/copy_backward for compilers that do not support is_constant_evaluated..
Nov 7 2019, 4:46 AM · Restricted Project
ldionne added a comment to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

https://reviews.llvm.org/D69940 should fix the problems.

Nov 7 2019, 4:46 AM · Restricted Project
ldionne committed rGe9612e9e851c: [libc++] Fix some constexpr tests broken by D68837 (authored by ldionne).
[libc++] Fix some constexpr tests broken by D68837
Nov 7 2019, 4:30 AM
ldionne added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Once you guys have figured out how you want to proceed, please say it here and abandon one of the two revisions. I'll review the one you decide to keep.

Nov 7 2019, 3:03 AM · Restricted Project
ldionne added a comment to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Folks, we're aware of the CI failures, and we're working on fixing them. It's taking a bit longer than usual since we're at a committee meeting right now.

Nov 7 2019, 3:03 AM · Restricted Project
ldionne accepted D69917: Update the docs for building libc++..

In addition, I'd like us to remove support for the out-of-tree build (I'll make a separate PR for that).

Nov 7 2019, 1:28 AM · Restricted Project

Nov 6 2019

ldionne committed rGfd02a4685522: [libcxx] Make generate_feature_test_macro_components script compatible with… (authored by ldionne).
[libcxx] Make generate_feature_test_macro_components script compatible with…
Nov 6 2019, 8:54 AM
ldionne closed D69884: [libcxx] Make generate_feature_test_macro_components script compatible with Python 3..
Nov 6 2019, 8:54 AM · Restricted Project
ldionne accepted D69884: [libcxx] Make generate_feature_test_macro_components script compatible with Python 3..

Tested locally and it gives the same results as the previous script.

Nov 6 2019, 8:45 AM · Restricted Project
ldionne requested changes to D68275: [libcxx] [test] Query the target platform, not the host one.

When running the tests locally, I see errors that are probably a result of messing around with the environment:

Nov 6 2019, 8:26 AM · Restricted Project
ldionne accepted D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken.

This looks good to me, but I must admit I'm surprised this problem has never come up before (this code is very old), and also I don't know what the code is trying to do. Adding Saleem and Nick who have more experience with libunwind just to double-check.

Nov 6 2019, 7:50 AM · Restricted Project
ldionne added a reviewer for D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken: compnerd.
Nov 6 2019, 7:40 AM · Restricted Project
ldionne committed rG13c90a57165b: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr (authored by ldionne).
[libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr
Nov 6 2019, 4:04 AM
ldionne closed D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..
Nov 6 2019, 4:04 AM · Restricted Project

Nov 5 2019

ldionne requested changes to D68275: [libcxx] [test] Query the target platform, not the host one.
Nov 5 2019, 8:19 AM · Restricted Project
ldionne accepted D68275: [libcxx] [test] Query the target platform, not the host one.

This looks fine to me, but like I said I don't run the tests on Windows so I can't test locally. Since no one else seems objected, I'll commit this and folks can chime in if they're unhappy. Otherwise we're just blocking you for no good reason.

Nov 5 2019, 8:10 AM · Restricted Project
ldionne requested changes to D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..
Nov 5 2019, 5:51 AM · Restricted Project

Nov 4 2019

ldionne added a comment to D69132: [libc++][P0784] Marked the default allocator constexpr..

Woops, it also looks like you are missing the feature test macros:

Nov 4 2019, 9:31 AM · Restricted Project
ldionne requested changes to D69803: [libc++][P0784] Marked allocator_traits constexpr..
Nov 4 2019, 8:17 AM · Restricted Project
ldionne requested changes to D69132: [libc++][P0784] Marked the default allocator constexpr..
Nov 4 2019, 6:32 AM · Restricted Project
ldionne accepted D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..
Nov 4 2019, 6:14 AM · Restricted Project
ldionne accepted D69134: [libc++][P0784] Added construct_at and marked destroy_at/destroy/destroy_n constexpr..
Nov 4 2019, 6:00 AM · Restricted Project
ldionne accepted D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Nov 4 2019, 5:55 AM · Restricted Project

Oct 30 2019

ldionne committed rGadadc665f83a: [libc++] Add test and remove workaround for PR13592 (authored by ldionne).
[libc++] Add test and remove workaround for PR13592
Oct 30 2019, 3:55 PM
ldionne requested changes to D62454: SFINAE on pair/tuple assignment operators 2729.
Oct 30 2019, 11:31 AM

Oct 29 2019

ldionne committed rG3c9063f5d2df: [libc++] Force the ABI namespace to be a reserved identifier (authored by ldionne).
[libc++] Force the ABI namespace to be a reserved identifier
Oct 29 2019, 11:04 AM
ldionne closed D69408: [libc++] Force the ABI namespace to be a reserved identifier.
Oct 29 2019, 11:04 AM · Restricted Project, Restricted Project, Restricted Project

Oct 25 2019

ldionne committed rGfd667b860e9d: [libcxx] [test] Run `chmod +x` on executables when testing via SSH (authored by ldionne).
[libcxx] [test] Run `chmod +x` on executables when testing via SSH
Oct 25 2019, 9:48 AM
ldionne closed D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH.
Oct 25 2019, 9:48 AM · Restricted Project

Oct 24 2019

ldionne accepted D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH.

LGTM with the requested change.

Oct 24 2019, 3:49 PM · Restricted Project
ldionne created D69408: [libc++] Force the ABI namespace to be a reserved identifier.
Oct 24 2019, 2:26 PM · Restricted Project, Restricted Project, Restricted Project

Oct 23 2019

ldionne accepted D69363: [www] Change URLs to HTTPS..

Nice!

Oct 23 2019, 8:15 PM · Restricted Project, Restricted Project
ldionne committed rG6b77ebdc919d: [NFC] Strip trailing whitespace from libc++ (authored by ldionne).
[NFC] Strip trailing whitespace from libc++
Oct 23 2019, 11:19 AM

Oct 22 2019

ldionne requested changes to D60491: Fix fpos requirements & cleanup.

Some of the tests you added are already present in other files, for example libcxx/test/std/input.output/iostreams.base/fpos/fpos.operations/subtraction.pass.cpp. Any reason why you're duplicating those checks in test/std/input.output/iostreams.base/fpos/fpos.operations/fpos.pass.cpp?

Oct 22 2019, 4:25 PM · Restricted Project
ldionne requested changes to D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS.

Good find! The following drivers (at least) appear to have the same problem:

Oct 22 2019, 3:45 PM · Restricted Project
ldionne committed rG19e95ab4210b: [NFC] Strip trailing whitespace in test to test Github committing (authored by ldionne).
[NFC] Strip trailing whitespace in test to test Github committing
Oct 22 2019, 3:09 PM
ldionne requested changes to D66177: Update shared_ptr's constructor.
Oct 22 2019, 12:21 PM · Restricted Project

Oct 21 2019

ldionne committed rG3292facc0a2a: [NFC] Fix typos in CMake comment (authored by ldionne).
[NFC] Fix typos in CMake comment
Oct 21 2019, 4:43 PM
ldionne committed rL375469: [NFC] Fix typos in CMake comment.
[NFC] Fix typos in CMake comment
Oct 21 2019, 4:43 PM
ldionne accepted D68805: [libcxx] Remove shared_ptr::make_shared.
Oct 21 2019, 4:43 PM · Restricted Project

Oct 18 2019

ldionne added inline comments to D69195: [libcxx] Fix .gitignore to not exclude test directories.
Oct 18 2019, 2:23 PM · Restricted Project
ldionne accepted D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 2:05 PM · Restricted Project
ldionne added inline comments to D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 12:21 PM · Restricted Project
ldionne added inline comments to D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH.
Oct 18 2019, 10:39 AM · Restricted Project
ldionne requested changes to D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH.

Requesting changes so it shows up properly in my review queue.

Oct 18 2019, 10:39 AM · Restricted Project

Oct 16 2019

ldionne added inline comments to D66262: Constrain tuple/unique_ptr move constructors (2899).
Oct 16 2019, 12:12 PM · Restricted Project
ldionne added a comment to D68833: [CMake] Re-order runtimes in the order of dependencies.

That is a much better approach. CMake 3.11 is when the TARGET_EXISTS generator expression was added, although the documentation wasn't updated until CMake 3.15, so this change would require a CMake version update, which I don't think is unreasonable.

I've tested D68880 which requires newer CMake but it does seem to be working. Shall we start the discussion about bumping the minimum CMake version requirement on llvm-dev?

Oct 16 2019, 12:03 PM · Restricted Project
ldionne requested changes to D69062: Resolve LWG issue 2426.

If we want to mark the LWG issue as being resolved for libc++, I think the test should be moved to the libc++ test suite. Otherwise, we're only assessing that libc++ implements LWG2426 on Clang.

Oct 16 2019, 11:42 AM · Restricted Project, Restricted Project
ldionne accepted D68879: P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type..

Let's not block this because I have questions about the warning implemented in Clang. Richard, you can ship this. Thanks for the fix and sorry for the delay.

Oct 16 2019, 9:22 AM · Restricted Project
ldionne added inline comments to D68805: [libcxx] Remove shared_ptr::make_shared.
Oct 16 2019, 9:13 AM · Restricted Project
ldionne added inline comments to D68617: partially inline copy constructor basic_string(const basic_string&[, allocator]).
Oct 16 2019, 8:55 AM · Restricted Project
ldionne closed D68000: [libc++] Remove C++03 variadics in shared_ptr (v2).

Confirmed, this has been applied in r373971 so I'm closing this.

Oct 16 2019, 7:59 AM · Restricted Project
ldionne accepted D67675: [libc++] Remove C++03 variadics in shared_ptr.
Oct 16 2019, 7:59 AM · Restricted Project
ldionne removed a reviewer for D67675: [libc++] Remove C++03 variadics in shared_ptr: EricWF.

Sorry for the spam, I'm trying to close this and it won't let me. Now I'm trying to remove Eric (who had requested changes).

Oct 16 2019, 7:59 AM · Restricted Project
ldionne closed D67675: [libc++] Remove C++03 variadics in shared_ptr.

Closing since the patch has been applied. We couldn't close it before because there were pending changes requested by Eric.

Oct 16 2019, 7:59 AM · Restricted Project
ldionne commandeered D67675: [libc++] Remove C++03 variadics in shared_ptr.

Commandeering revision to try to close it (I'm doing some cleanup in the review queue).

Oct 16 2019, 7:59 AM · Restricted Project
ldionne requested changes to D68805: [libcxx] Remove shared_ptr::make_shared.

Can you confirm this is the bit of the patch that we suspect had caused a SEGFAULT for @phosek?

Oct 16 2019, 7:59 AM · Restricted Project
ldionne added a comment to D68000: [libc++] Remove C++03 variadics in shared_ptr (v2).

I think this has been committed (r373971)? If so, can you please close?

Oct 16 2019, 7:59 AM · Restricted Project
ldionne added inline comments to D68617: partially inline copy constructor basic_string(const basic_string&[, allocator]).
Oct 16 2019, 7:50 AM · Restricted Project
ldionne requested changes to D68617: partially inline copy constructor basic_string(const basic_string&[, allocator]).
Oct 16 2019, 7:50 AM · Restricted Project
ldionne requested changes to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

Looks good, except for the duplicated test() functions. I'd also like to have a short discussion about how to test this (and more importantly the lack of regression w.r.t. codegen). Apart from that, I think this is good to go.

Oct 16 2019, 7:04 AM · Restricted Project
ldionne added inline comments to D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..
Oct 16 2019, 6:55 AM · Restricted Project
ldionne requested changes to D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr..

This is looking good. I especially like how the tests require only minimal change between the runtime and the compile-time version. I think this is what we should strive for pretty much every time we constexpr-ify something going forward.

Oct 16 2019, 6:51 AM · Restricted Project

Oct 15 2019

ldionne requested changes to D68617: partially inline copy constructor basic_string(const basic_string&[, allocator]).

Note: There does not appear to be anything at https://github.com/llvm/llvm-project/compare/master...martijnvels:string-optimize-copy-ctor

Oct 15 2019, 11:35 AM · Restricted Project

Oct 11 2019

ldionne added inline comments to D68879: P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type..
Oct 11 2019, 2:50 PM · Restricted Project
ldionne added inline comments to D68879: P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type..
Oct 11 2019, 12:23 PM · Restricted Project
ldionne created D68880: [libc++] Use generator expression in Linker script generation.
Oct 11 2019, 11:46 AM · Restricted Project
Herald added a reviewer for D68880: [libc++] Use generator expression in Linker script generation: mclow.lists.

@phosek Can you please confirm this also fixes your issue in the Runtimes build?

Oct 11 2019, 11:46 AM · Restricted Project