Page MenuHomePhabricator

ldionne (Louis Dionne)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (268 w, 6 d)

Recent Activity

Today

ldionne committed rG82bec931814d: [libc++] Update the documentation for running Lit to reflect reality (authored by ldionne).
[libc++] Update the documentation for running Lit to reflect reality
Wed, Apr 8, 12:31 PM
ldionne closed D77673: [libc++] Update the documentation for running Lit to reflect reality.
Wed, Apr 8, 12:30 PM · Restricted Project
ldionne accepted D77673: [libc++] Update the documentation for running Lit to reflect reality.
Wed, Apr 8, 12:30 PM · Restricted Project
ldionne added a comment to D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.

I don't think there's any point in delaying until after the 11 release. We just branched LLVM 10. I believe we should make the change between now and the September LLVM 11 release, rather than afterwards.

Wed, Apr 8, 11:57 AM · Restricted Project
ldionne added inline comments to D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types..
Wed, Apr 8, 10:18 AM · Restricted Project, Restricted Project
ldionne created D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4.
Wed, Apr 8, 9:45 AM · Restricted Project
ldionne added a reviewer for D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4: smeenai.

Not sure who to add -- I'm sending an email to the list with a link to this review.

Wed, Apr 8, 9:45 AM · Restricted Project
ldionne added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

Ok, let's go step by step to make sure we don't talk past each other. Here's some facts (feel free to correct me if you see a mistake):

Wed, Apr 8, 9:45 AM · Unknown Object (Project), Restricted Project
ldionne added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

Could you please chime in on http://lists.llvm.org/pipermail/libcxx-dev/2020-April/000793.html? I'd like to better understand why we even need to support a standalone build -- I thought we were not supporting those anymore since the monorepo.

Wed, Apr 8, 9:12 AM · Restricted Project
ldionne committed rG6f1d558db42c: [libunwind] Fix incorrect lit substitutions in tests (authored by ldionne).
[libunwind] Fix incorrect lit substitutions in tests
Wed, Apr 8, 8:08 AM
ldionne created D77733: [libunwind] Enable the new libc++ testing format by default.
Wed, Apr 8, 8:07 AM · Unknown Object (Project), Restricted Project
ldionne accepted D77708: [lit] Improve naming of test result categories.

I like this.

Wed, Apr 8, 7:02 AM · Restricted Project
ldionne added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

My preference would be to set nothing at all. Just let users say -DCMAKE_POSITION_INDEPENDENT_CODE=ON/OFF in their own caches. Why doesn't that work?

Wed, Apr 8, 7:02 AM · Unknown Object (Project), Restricted Project
ldionne added a comment to D77697: libc++: adjust modulemap for non-modular C.

This fixes the module build of clang for me.

Wed, Apr 8, 7:02 AM · Restricted Project
ldionne committed rGf3bf25eb663c: [libc++] Explicitly specify that we use libc++abi in Apple's cache (authored by ldionne).
[libc++] Explicitly specify that we use libc++abi in Apple's cache
Wed, Apr 8, 6:28 AM

Yesterday

ldionne accepted D76093: Don't expose unavailable cstdio functions..
Tue, Apr 7, 3:16 PM · Restricted Project
ldionne committed rGa092e3833bee: [libc++] Remove the %{not} substitution (authored by ldionne).
[libc++] Remove the %{not} substitution
Tue, Apr 7, 2:44 PM
ldionne committed rG3fefda6e578b: [libc++] Run tests in a directory related to %t instead of /tmp (authored by ldionne).
[libc++] Run tests in a directory related to %t instead of /tmp
Tue, Apr 7, 1:37 PM
ldionne updated subscribers of D77673: [libc++] Update the documentation for running Lit to reflect reality.

Adding folks who might be interested. I'm especially interested to know if anyone's workflow differs from what I'm documenting in my changes, and if so, how does it differ.

Tue, Apr 7, 12:31 PM · Restricted Project
ldionne created D77673: [libc++] Update the documentation for running Lit to reflect reality.
Tue, Apr 7, 12:31 PM · Restricted Project
ldionne committed rGf8b6529218f2: [libc++] Translate MODULES_DEFINES annotations to ADDITIONAL_COMPILE_FLAGS (authored by ldionne).
[libc++] Translate MODULES_DEFINES annotations to ADDITIONAL_COMPILE_FLAGS
Tue, Apr 7, 11:57 AM
ldionne added a comment to D77657: [WIP][libc++] Add an executor that bundles tests for deferred execution.

Also, just to explain how I'm currently running the tests with this patch applied:

Tue, Apr 7, 9:12 AM · Restricted Project
ldionne created D77657: [WIP][libc++] Add an executor that bundles tests for deferred execution.
Tue, Apr 7, 9:12 AM · Restricted Project
ldionne updated subscribers of D77657: [WIP][libc++] Add an executor that bundles tests for deferred execution.

This review is a WIP for solving remote execution of libc++ tests with lit better than we currently do. See the review summary for the initial discussion.

Tue, Apr 7, 9:12 AM · Restricted Project
ldionne committed rG2eb8864be282: [libc++abi] Enable the new libc++ testing format by default (authored by ldionne).
[libc++abi] Enable the new libc++ testing format by default
Tue, Apr 7, 6:29 AM
ldionne committed rGf75ebe1ab37b: [libc++] Support .sh.s tests in the new format (authored by ldionne).
[libc++] Support .sh.s tests in the new format
Tue, Apr 7, 6:29 AM
ldionne committed rG9949cfbd05a0: [libc++] Make sure the source file appears before link libraries when compiling… (authored by ldionne).
[libc++] Make sure the source file appears before link libraries when compiling…
Tue, Apr 7, 6:28 AM
ldionne requested changes to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.
Tue, Apr 7, 5:55 AM · Restricted Project
ldionne added inline comments to D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types..
Tue, Apr 7, 5:55 AM · Restricted Project, Restricted Project
ldionne accepted D77563: [libc++] Move C++17 check around optional only in ObjC is_scalar test..
Tue, Apr 7, 5:55 AM · Restricted Project

Mon, Apr 6

ldionne committed rG276d2b78ce4d: [libc++] 2/N: Enable the new libc++ testing format by default (authored by ldionne).
[libc++] 2/N: Enable the new libc++ testing format by default
Mon, Apr 6, 3:50 PM
ldionne committed rGbcf14f375e29: [libc++] Only support std::to_chars availability test when back-deploying (authored by ldionne).
[libc++] Only support std::to_chars availability test when back-deploying
Mon, Apr 6, 3:17 PM
ldionne committed rG46c38761886f: [libc++] Add availability markup for the C++20 Synchronization Library on Apple (authored by ldionne).
[libc++] Add availability markup for the C++20 Synchronization Library on Apple
Mon, Apr 6, 3:17 PM
ldionne added inline comments to D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types..
Mon, Apr 6, 2:10 PM · Restricted Project, Restricted Project
ldionne accepted D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types..
Mon, Apr 6, 2:10 PM · Restricted Project, Restricted Project
ldionne committed rG8a42bf24ae99: [lit] Move the recursiveExpansionLimit setting to TestingConfig (authored by ldionne).
[lit] Move the recursiveExpansionLimit setting to TestingConfig
Mon, Apr 6, 11:26 AM
ldionne closed D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig.
Mon, Apr 6, 11:26 AM · Restricted Project, Restricted Project
ldionne requested changes to D77563: [libc++] Move C++17 check around optional only in ObjC is_scalar test..
Mon, Apr 6, 11:25 AM · Restricted Project
ldionne committed rG267273563dd9: [libc++] Make sure we execute tests with the current environment (authored by ldionne).
[libc++] Make sure we execute tests with the current environment
Mon, Apr 6, 10:52 AM
ldionne added a comment to D77497: [libc++] Capture the current environment in the new test format.

As discussed offline, done as 267273563dd974abe1d7cda4513fef884cf0eb3e.

Mon, Apr 6, 10:51 AM · Restricted Project
ldionne committed rG7662ad67c5d1: [libc++] Mark two std::timed_mutex tests as flaky (authored by ldionne).
[libc++] Mark two std::timed_mutex tests as flaky
Mon, Apr 6, 9:46 AM
ldionne committed rG2c1c4777a5a6: [libc++] Always use -fsyntax-only in .fail.cpp tests (authored by ldionne).
[libc++] Always use -fsyntax-only in .fail.cpp tests
Mon, Apr 6, 8:39 AM
ldionne committed rG4e52944ef119: [libc++] Make sure we include %{flags} when building with the new format (authored by ldionne).
[libc++] Make sure we include %{flags} when building with the new format
Mon, Apr 6, 8:39 AM
ldionne committed rG38e07204749b: [libc++] Mark is_scalar test as unsupported in C++11 and C++14 (authored by ldionne).
[libc++] Mark is_scalar test as unsupported in C++11 and C++14
Mon, Apr 6, 8:39 AM
ldionne committed rGb00a874b7c73: [libc++] SSH: Fix tarring of dependencies on Windows (authored by ldionne).
[libc++] SSH: Fix tarring of dependencies on Windows
Mon, Apr 6, 7:01 AM
ldionne added a comment to D77500: [libc++] [ssh] Fix tarring test dependencies on Windows.

After offline discussion with @broadwaylamb, we went ahead with b00a874b7c7371 instead. The main difference is that b00a874b7c7371 makes sure to close the NamedTemporaryFile before it tries to scp it, which is more in-line with the Python documentation:

Mon, Apr 6, 7:00 AM · Restricted Project
ldionne requested changes to D77497: [libc++] Capture the current environment in the new test format.
Mon, Apr 6, 7:00 AM · Restricted Project
ldionne committed rGa41cd6bb897b: [libc++] [test] Add missing FILE_DEPENDENCIES to align.pass.sh.cpp (authored by broadwaylamb).
[libc++] [test] Add missing FILE_DEPENDENCIES to align.pass.sh.cpp
Mon, Apr 6, 6:28 AM
ldionne closed D77541: [libc++] [test] Add missing FILE_DEPENDENCIES to align.pass.sh.cpp.
Mon, Apr 6, 6:28 AM · Restricted Project
ldionne requested changes to D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types..

Thanks for looking into this!

Mon, Apr 6, 6:27 AM · Restricted Project, Restricted Project
ldionne added a comment to D77501: [libunwind] Support the new libc++ test format.

This is a no-op change unless one opts into the new format. Just to follow protocol, I'll still wait for a libunwind owner to approve.

Mon, Apr 6, 6:27 AM · Unknown Object (Project), Restricted Project
ldionne accepted D77501: [libunwind] Support the new libc++ test format.
Mon, Apr 6, 6:27 AM · Unknown Object (Project), Restricted Project
ldionne accepted D77541: [libc++] [test] Add missing FILE_DEPENDENCIES to align.pass.sh.cpp.
Mon, Apr 6, 6:27 AM · Restricted Project

Sun, Apr 5

ldionne added a comment to D77466: libcxx 'LLVM_USE_SANITIZER=Address;Undefined'.

@modocache We have a libcxx review group that gets added as a blocking reviewer on libcxx patches automatically, that's for a reason. Please don't commit without an approval from the group anymore.

Sun, Apr 5, 5:51 AM · Restricted Project

Sat, Apr 4

ldionne committed rG1580c76c4a08: [libc++] Enable the new libc++ testing format by default (authored by ldionne).
[libc++] Enable the new libc++ testing format by default
Sat, Apr 4, 2:22 PM

Fri, Apr 3

ldionne added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

@ldionne yeah, thats why I would prefer that we just do the following in the top level CMakeLists.txt for libunwind:

set(CMAKE_POSITION_INDEPENDENT_CODE YES CACHE BOOL "")

The user can then specify this on the commandline to override the default behaviour.

Fri, Apr 3, 3:43 PM · Unknown Object (Project), Restricted Project
ldionne committed rGceb58ad61d26: [libc++] Lit: Add default values for most arguments of test executors (authored by ldionne).
[libc++] Lit: Add default values for most arguments of test executors
Fri, Apr 3, 3:12 PM
ldionne added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.

Would two flags LIBUNWIND_ENABLE_SHARED_PIC and LIBUNWIND_ENABLE_STATIC_PIC sound good to you? Then we could default shared to ON, but static to OFF.
Enabling PIC in static builds is something I need.

Fri, Apr 3, 12:57 PM · Unknown Object (Project), Restricted Project
ldionne added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.

Fri, Apr 3, 12:30 PM · Unknown Object (Project), Restricted Project
ldionne committed rG5d14c7b6d1fc: [libc++] NFC: Remove unused CMake option (authored by ldionne).
[libc++] NFC: Remove unused CMake option
Fri, Apr 3, 11:56 AM
ldionne accepted D73245: Avoid using std::max_align_t in pre-C++11 mode.

LGTM

Fri, Apr 3, 11:53 AM · Restricted Project
ldionne committed rGb4b7c989d6f1: [libc++] Remove support for specifying LIBCXX_CXX_ABI_SYSTEM manually (authored by ldionne).
[libc++] Remove support for specifying LIBCXX_CXX_ABI_SYSTEM manually
Fri, Apr 3, 11:21 AM
ldionne committed rGaaaa25e23db7: [libc++] Remove useless nothing_to_do.pass.cpp tests (authored by ldionne).
[libc++] Remove useless nothing_to_do.pass.cpp tests
Fri, Apr 3, 10:49 AM
ldionne accepted D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig.

Like I mentioned in the commit message, this simply fixes the place where the recursiveExpansionLimit is set. Regardless of that, I still plan to explore addressing concerns raised in https://reviews.llvm.org/D76178, which is somewhat orthogonal.

Fri, Apr 3, 10:15 AM · Restricted Project, Restricted Project
ldionne added reviewers for D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig: yln, delcypher.
Fri, Apr 3, 10:15 AM · Restricted Project, Restricted Project
ldionne created D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig.
Fri, Apr 3, 10:15 AM · Restricted Project, Restricted Project
ldionne committed rG80a2ddf65ccd: [libc++] Add an alternative Lit test format (authored by ldionne).
[libc++] Add an alternative Lit test format
Fri, Apr 3, 8:37 AM
ldionne closed D77338: [libc++] Add an alternative Lit test format.
Fri, Apr 3, 8:36 AM · Restricted Project, Restricted Project
ldionne committed rG3d94f3060c4c: [libc++] Fix is_pointer support for Objective-C++ (authored by ldionne).
[libc++] Fix is_pointer support for Objective-C++
Fri, Apr 3, 8:36 AM
ldionne committed rG937040d18196: [libc++] Add REQUIRES for tests that need -fblocks and -fobjc-arc (authored by ldionne).
[libc++] Add REQUIRES for tests that need -fblocks and -fobjc-arc
Fri, Apr 3, 7:30 AM

Thu, Apr 2

ldionne added a comment to D77338: [libc++] Add an alternative Lit test format.

This is mostly a heads-up review. I welcome comments and improvement suggestions. This patch is a no-op unless one opts into the new format, and in particular this doesn't change the interaction between CMake and config.py at all. Because of this, I will not hold off committing this in order to start adopting it more widely right away -- improvements can be made as follow-up patches as I get more feedback from people who try it out.

Thu, Apr 2, 2:39 PM · Restricted Project, Restricted Project
ldionne committed rG90455dbe2e74: [libc++] NFC: Add documentation for writing tests (authored by ldionne).
[libc++] NFC: Add documentation for writing tests
Thu, Apr 2, 2:39 PM
ldionne created D77338: [libc++] Add an alternative Lit test format.
Thu, Apr 2, 2:38 PM · Restricted Project, Restricted Project
ldionne committed rGa6a841e0d7c0: [libc++] Refer to the Filesystem static test env as relative paths (authored by ldionne).
[libc++] Refer to the Filesystem static test env as relative paths
Thu, Apr 2, 2:07 PM
ldionne added a comment to D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

Don't know why Phab thinks compnerd's accepting the revision March 1, at 9:54 left it in an unaccepted state. Happy to revert it if necessary, but I don't think so.

Thu, Apr 2, 1:00 PM · Unknown Object (Project), Restricted Project
ldionne added a comment to D77294: [libc++] Fix linking libc++abi in standalone builds.

LGTM, but is there some documentation about how to build libc++ standalone? How do you build it? Do we have any bots that exercise this code path?

I'd be happy to write some documentation for this. I do builds like this for assembling a toolchain at work using an internal tool. Main reason being that I don't want to crosscompile LLVM for my target platform (ARM64), just the libraries (compiler-rt, libunwind, libcxxabi, libcxx).
I'm skeptical that there would be bots for this, as building LLVM with subprojects seems to be the most common setup. But I'm new so I don't know much.

Thu, Apr 2, 1:00 PM · Restricted Project
ldionne added a comment to D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

Is @mstorsjo, @phosek and @compnerd a suitable set of members? I'll coordinate with @benhamilton to create it (he's the Phabricator magician).

I'm not comfortable reviewing/approving everything in libunwind, but I've spent some time debugging it at least, so I can at least review things that touch some bits, and the windows aspect.

Thu, Apr 2, 11:55 AM · Unknown Object (Project), Restricted Project
ldionne added a comment to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

Just trying to wrap my head around this. Basically, this makes lit.cfg files relocatable, however doesn't everything else need to be relocatable too for anything to work? For example, if you set the rpath on some executable, that needs to be relative too, right?

Thu, Apr 2, 11:22 AM · Restricted Project
ldionne committed rGc3b5c98e3953: [libc++abi] NFC: Add link to review in workaround comment (authored by ldionne).
[libc++abi] NFC: Add link to review in workaround comment
Thu, Apr 2, 10:50 AM
ldionne added a comment to D77298: [libc++abi] Default LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS to OFF.

Ah, I see. Might be worth updating the comment at least to point to that review.

Thu, Apr 2, 10:50 AM · Restricted Project
ldionne committed rGf5c1d4409e01: [libc++] Try to fix Chromium's build (authored by ldionne).
[libc++] Try to fix Chromium's build
Thu, Apr 2, 10:18 AM
ldionne added a comment to D77140: [libc++] Reimplement the dynamic filesystem helper without using Python.

Thank you very much for working in this @ldionne ! We (the CHERI project, https://github.com/CTSRD-CHERI/llvm-project/) can only sensibly test libc++ using the SSH executor since we use FPGA and QEMU implementations of CHERI MIPS/RISCV.
So far I completely skipped the filesystem tests since our minimal test images don't contain python and I'm looking forward to being able to also run those tests.

Thu, Apr 2, 10:17 AM · Restricted Project
ldionne committed rG322b53239d47: [libc++] Attempt to fix the 'runtimes' build (authored by ldionne).
[libc++] Attempt to fix the 'runtimes' build
Thu, Apr 2, 9:45 AM
ldionne committed rGd5fa8b11205c: [libc++] Reimplement the dynamic filesystem helper without using Python (authored by ldionne).
[libc++] Reimplement the dynamic filesystem helper without using Python
Thu, Apr 2, 8:07 AM
ldionne closed D77140: [libc++] Reimplement the dynamic filesystem helper without using Python.
Thu, Apr 2, 8:06 AM · Restricted Project
ldionne accepted D77140: [libc++] Reimplement the dynamic filesystem helper without using Python.

Got offline approval from Eric to land this, with the intent of doing a post-commit review.

Thu, Apr 2, 7:33 AM · Restricted Project
ldionne added a comment to D77298: [libc++abi] Default LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS to OFF.

There is a patch for this: https://reviews.llvm.org/D68269

Thu, Apr 2, 7:33 AM · Restricted Project
ldionne updated subscribers of D77099: Exit unwinding early when at the top of the stack and additional info won't be found..

Is @mstorsjo, @phosek and @compnerd a suitable set of members? I'll coordinate with @benhamilton to create it (he's the Phabricator magician).

Thu, Apr 2, 7:33 AM · Unknown Object (Project), Restricted Project
ldionne committed rGbcaa01752f5e: [libc++] Fix linking libc++abi in standalone builds (authored by tambre).
[libc++] Fix linking libc++abi in standalone builds
Thu, Apr 2, 7:01 AM
ldionne closed D77294: [libc++] Fix linking libc++abi in standalone builds.
Thu, Apr 2, 7:01 AM · Restricted Project
ldionne accepted D77294: [libc++] Fix linking libc++abi in standalone builds.

LGTM, but is there some documentation about how to build libc++ standalone? How do you build it? Do we have any bots that exercise this code path?

Thu, Apr 2, 6:28 AM · Restricted Project

Wed, Apr 1

ldionne committed rG61e89737c5da: [libc++] Simplify the configuration of the C++ ABI library (authored by ldionne).
[libc++] Simplify the configuration of the C++ ABI library
Wed, Apr 1, 11:23 PM
ldionne requested changes to D72959: Relative VTables ABI on Fuchsia.
Wed, Apr 1, 10:18 PM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rGff09135fc2b7: [libc++] Execute tests from the Lit execution root instead of the test tree (authored by ldionne).
[libc++] Execute tests from the Lit execution root instead of the test tree
Wed, Apr 1, 7:37 PM
ldionne committed rGdf88d80337d5: [libc++] Add missing FILE_DEPENDENCIES markup (authored by ldionne).
[libc++] Add missing FILE_DEPENDENCIES markup
Wed, Apr 1, 7:37 PM
ldionne committed rG92e563bc05d4: [libc++] SSH: Create a tarball of dependencies and scp that instead (authored by ldionne).
[libc++] SSH: Create a tarball of dependencies and scp that instead
Wed, Apr 1, 1:41 PM
ldionne committed rG160b01c9ef67: [libc++] SSH: Use -p when scp'ing to preserve modes and modification times (authored by ldionne).
[libc++] SSH: Use -p when scp'ing to preserve modes and modification times
Wed, Apr 1, 9:34 AM
ldionne committed rG0489d39ead2b: [libc++] SSH: Properly handle test-executables that are not the first argument (authored by ldionne).
[libc++] SSH: Properly handle test-executables that are not the first argument
Wed, Apr 1, 8:47 AM
ldionne committed rG64acef386ec6: [libc++] Handle SSH errors more gracefully and make sure we clean up the tmp… (authored by ldionne).
[libc++] Handle SSH errors more gracefully and make sure we clean up the tmp…
Wed, Apr 1, 8:15 AM
ldionne committed rGfee0026fc7eb: [libc++abi] Fix remote execution of .sh.cpp tests (authored by broadwaylamb).
[libc++abi] Fix remote execution of .sh.cpp tests
Wed, Apr 1, 7:41 AM