Page MenuHomePhabricator

ldionne (Louis Dionne)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2015, 3:26 PM (423 w, 1 d)
Roles
Administrator

Recent Activity

Today

ldionne updated the diff for D146837: [libc++] Don't try to provide source_location on AppleClang 1403.

Generate files.

Fri, Mar 24, 11:47 AM · Restricted Project, Restricted Project
ldionne requested review of D146837: [libc++] Don't try to provide source_location on AppleClang 1403.
Fri, Mar 24, 11:43 AM · Restricted Project, Restricted Project
ldionne accepted D146821: [libc++] Qualifies intmax_t and uintmax_t..
Fri, Mar 24, 9:33 AM · Restricted Project, Restricted Project

Yesterday

ldionne updated subscribers of D141882: [libc++] Remove #pragma GCC system_header.

Adding libc++ vendors for awareness. Once the CI is green, I will take this for a spin and I suggest at least Google does it as well because I suspect this may lead to a lot of small and easy to fix issues. But I expect the number to be quite large. Depending on what we find out, we will be able to tell whether this is reasonable or not.

Thu, Mar 23, 10:25 AM · Restricted Project, Restricted Project
ldionne added inline comments to D144394: [libc++] Forward to std::{,w}memcmp in std::find.
Thu, Mar 23, 10:20 AM · Restricted Project, Restricted Project
ldionne updated the diff for D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.

Rebase to re-trigger CI

Thu, Mar 23, 7:01 AM · Restricted Project, Restricted Project

Wed, Mar 22

ldionne updated the diff for D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.

Rebase for CI

Wed, Mar 22, 4:11 PM · Restricted Project, Restricted Project
ldionne updated the diff for D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.

Rebase

Wed, Mar 22, 1:45 PM · Restricted Project, Restricted Project
ldionne committed rG3d334df58742: [libc++] Remove availability markup for std::format (authored by ldionne).
[libc++] Remove availability markup for std::format
Wed, Mar 22, 1:33 PM · Restricted Project, Restricted Project
ldionne closed D134598: [libc++] Remove availability markup for std::format.
Wed, Mar 22, 1:33 PM · Restricted Project, Restricted Project
ldionne added a comment to D134598: [libc++] Remove availability markup for std::format.

Looks like this passed, shipping.

Wed, Mar 22, 1:32 PM · Restricted Project, Restricted Project
ldionne accepted D146643: [libc++] Qualifies intptr_t and uintptr_t..
Wed, Mar 22, 1:05 PM · Restricted Project, Restricted Project
ldionne added inline comments to D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.
Wed, Mar 22, 11:19 AM · Restricted Project, Restricted Project
ldionne added a reviewer for D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests: aaron.ballman.

Gentle ping, this was likely a copy-paste error.

Wed, Mar 22, 10:00 AM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Try to re-trigger CI. I don't understand why the job is skipped and the CI reports as green.

Wed, Mar 22, 9:29 AM · Restricted Project, Restricted Project
ldionne accepted D146550: [libc++] Qualifies ptrdiff_t and max_align_t..
Wed, Mar 22, 9:07 AM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Rebase and fix formatting.

Wed, Mar 22, 8:55 AM · Restricted Project, Restricted Project
ldionne added inline comments to D134598: [libc++] Remove availability markup for std::format.
Wed, Mar 22, 8:35 AM · Restricted Project, Restricted Project

Mon, Mar 20

ldionne accepted D144323: [libunwind][Modules] Add unwind_arm_ehabi.h and unwind_itanium.h to the unwind module).

LGTM, the failures in the libc++ CI are known flakes and the Windows one is a Clangd issue, most likely unrelated.

Mon, Mar 20, 3:11 PM · Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Remove format-specific availability markup, which isn't actually needed.

Mon, Mar 20, 2:56 PM · Restricted Project, Restricted Project
ldionne added inline comments to D134598: [libc++] Remove availability markup for std::format.
Mon, Mar 20, 2:55 PM · Restricted Project, Restricted Project
ldionne accepted D146088: [libc++] Qualifies size_t..

I just went through the patch and it LGTM. The table of contents was really useful here.

Mon, Mar 20, 11:17 AM · Restricted Project, Restricted Project
ldionne planned changes to D146421: [libc++] Disable the __insertion_sort_unguarded optimization.

Okay so unfortunately, that didn't fix the issue like we were expecting. I tried a few things and the only thing that reliably fixed the issue we were seeing was reverting 4eddbf9f10a6d1881c93d84f4363d6d881daf848 (aka D122780) entirely. I think I will need to get a reproducer before deciding what's the next step (i.e. whether the issue is sufficiently vexing that it's worth reverting or not).

Mon, Mar 20, 9:34 AM · Restricted Project, Restricted Project
ldionne updated the diff for D146421: [libc++] Disable the __insertion_sort_unguarded optimization.

Fix clang-tidy

Mon, Mar 20, 8:28 AM · Restricted Project, Restricted Project
ldionne updated subscribers of D146421: [libc++] Disable the __insertion_sort_unguarded optimization.
Mon, Mar 20, 7:19 AM · Restricted Project, Restricted Project
ldionne requested review of D146421: [libc++] Disable the __insertion_sort_unguarded optimization.
Mon, Mar 20, 7:18 AM · Restricted Project, Restricted Project

Sun, Mar 19

ldionne committed rGa6a74fa5b37a: [libc++][NFC] Clean up the ABI changelog (authored by ldionne).
[libc++][NFC] Clean up the ABI changelog
Sun, Mar 19, 7:38 AM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Rebase onto main.

Sun, Mar 19, 7:26 AM · Restricted Project, Restricted Project
ldionne committed rG47aa1fe376a4: [libc++][Apple] Update availability markup for std::to_chars(floating-point) (authored by ldionne).
[libc++][Apple] Update availability markup for std::to_chars(floating-point)
Sun, Mar 19, 7:25 AM · Restricted Project, Restricted Project
ldionne closed D146367: [libc++][Apple] Update availability markup for std::to_chars(floating-point).
Sun, Mar 19, 7:25 AM · Restricted Project, Restricted Project
ldionne accepted D146367: [libc++][Apple] Update availability markup for std::to_chars(floating-point).

CI failures are flukes.

Sun, Mar 19, 7:24 AM · Restricted Project, Restricted Project
ldionne updated the diff for D145587: [libc++] Remove symbols for a std::allocator_arg & friends from the dylib.

Rebase onto main after applying comments.

Sun, Mar 19, 7:22 AM · Restricted Project, Restricted Project
ldionne added a comment to D145587: [libc++] Remove symbols for a std::allocator_arg & friends from the dylib.

It would still be possible if we make this an extra library, which uses can link to manually, or automatically when invoking clang with std=c++98 -stdlib=libc++. (In a similar fashion we do for the experimental library.)

Note that is something we can do, I'm not convinced we should.

Sun, Mar 19, 7:21 AM · Restricted Project, Restricted Project
ldionne committed rGc0cde79e9e3b: [libc++] Remove C++03 extensions for std::allocator_arg & friends (authored by ldionne).
[libc++] Remove C++03 extensions for std::allocator_arg & friends
Sun, Mar 19, 7:15 AM · Restricted Project, Restricted Project
ldionne closed D145422: [libc++] Remove C++03 extensions for std::allocator_arg & friends.
Sun, Mar 19, 7:15 AM · Restricted Project, Restricted Project
ldionne added a comment to D145422: [libc++] Remove C++03 extensions for std::allocator_arg & friends.

Okay, so I got the results of building a large codebase with this change and I didn't see any regressions. I strongly think this won't be noticed by many users, if at all.

Sun, Mar 19, 7:14 AM · Restricted Project, Restricted Project

Sat, Mar 18

ldionne updated the diff for D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.

Fix a couple more incorrect XFAILs

Sat, Mar 18, 2:15 PM · Restricted Project, Restricted Project
ldionne requested review of D146367: [libc++][Apple] Update availability markup for std::to_chars(floating-point).
Sat, Mar 18, 1:47 PM · Restricted Project, Restricted Project
ldionne updated the diff for D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.

Trigger CI with parent diff.

Sat, Mar 18, 1:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne updated the diff for D146365: [libc++] Also support target triples that end with .0 in backdeployment tests.

Re-upload with parent to trigger CI properly.

Sat, Mar 18, 1:35 PM · Restricted Project, Restricted Project
ldionne requested review of D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.
Sat, Mar 18, 1:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ldionne requested review of D146365: [libc++] Also support target triples that end with .0 in backdeployment tests.
Sat, Mar 18, 1:27 PM · Restricted Project, Restricted Project
ldionne committed rGd6c12cbee314: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for… (authored by ldionne).
[libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for…
Sat, Mar 18, 1:22 PM · Restricted Project, Restricted Project
ldionne closed D146361: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for Apple.
Sat, Mar 18, 1:22 PM · Restricted Project, Restricted Project
ldionne accepted D146361: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for Apple.

CI failures are unrelated.

Sat, Mar 18, 1:21 PM · Restricted Project, Restricted Project
ldionne committed rG16fe61ac7ba5: [libc++][Apple] Make sure we install libc++experimental.a (authored by ldionne).
[libc++][Apple] Make sure we install libc++experimental.a
Sat, Mar 18, 1:21 PM · Restricted Project, Restricted Project
ldionne closed D146360: [libc++][Apple] Make sure we install libc++experimental.a.
Sat, Mar 18, 1:20 PM · Restricted Project, Restricted Project
ldionne accepted D146360: [libc++][Apple] Make sure we install libc++experimental.a.

CI failures are unrelated and we're on them, landing.

Sat, Mar 18, 1:20 PM · Restricted Project, Restricted Project
ldionne updated the diff for D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.

Fix incorrect markup in libcxx/test/std/strings/basic.string/string.capacity/reserve_size.pass.cpp

Sat, Mar 18, 1:10 PM · Restricted Project, Restricted Project
ldionne requested review of D146361: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for Apple.
Sat, Mar 18, 9:10 AM · Restricted Project, Restricted Project
ldionne updated the diff for D146360: [libc++][Apple] Make sure we install libc++experimental.a.

Match downstream

Sat, Mar 18, 9:02 AM · Restricted Project, Restricted Project
ldionne requested review of D146360: [libc++][Apple] Make sure we install libc++experimental.a.
Sat, Mar 18, 8:57 AM · Restricted Project, Restricted Project
ldionne added a comment to D144323: [libunwind][Modules] Add unwind_arm_ehabi.h and unwind_itanium.h to the unwind module).

Can you please just rebase onto main and re-upload to give this one last CI spin? There's a Windows failure I don't understand. I think it's unrelated but rebasing and running the CI again should confirm that.

Sat, Mar 18, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
ldionne accepted D144323: [libunwind][Modules] Add unwind_arm_ehabi.h and unwind_itanium.h to the unwind module).
Sat, Mar 18, 8:50 AM · Restricted Project, Restricted Project, Restricted Project
ldionne requested review of D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.
Sat, Mar 18, 7:42 AM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Fix a few filesystem tests failing on old deployment targets

Sat, Mar 18, 5:08 AM · Restricted Project, Restricted Project

Fri, Mar 17

ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Fix CI issue and rebase.

Fri, Mar 17, 3:11 PM · Restricted Project, Restricted Project
ldionne added inline comments to D134598: [libc++] Remove availability markup for std::format.
Fri, Mar 17, 3:07 PM · Restricted Project, Restricted Project
ldionne committed rG72f0edf3f429: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify. (authored by ldionne).
[libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.
Fri, Mar 17, 2:57 PM · Restricted Project, Restricted Project
ldionne closed D146236: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests.
Fri, Mar 17, 2:56 PM · Restricted Project, Restricted Project
ldionne added a comment to D146236: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests.

The no-exceptions configuration is failing due to a clang bug that Mark is still bisecting AFAIK, so this is green.

Fri, Mar 17, 2:56 PM · Restricted Project, Restricted Project
ldionne requested changes to D132769: [2b/3][ASan][libcxx] std::basic_string annotations.

Could you give a really simple example of issues this allows catching? Like the "Hello world" for this new functionality. I think that would be useful for folks (at least for me) to understand concretely what we're gaining (I have no doubt we're gaining something, I just don't see it clearly in my mind).

Fri, Mar 17, 2:52 PM · Restricted Project, Restricted Project, Restricted Project
ldionne added a comment to D136765: [ASan][libcxx] Annotating std::vector with all allocators.

Considering that this won't be cherry-picked back to release/16.x (right?), then whether we use _LIBCPP_CLANG_VER >= 1600 or _LIBCPP_CLANG_VER >= 1700 is irrelevant for all practical purposes, since libc++ gets released in sync with Clang and the next release this will get in will have Clang 17. I do agree however that if someone (in this case Chrome) is using a not-yet-released snapshot of trunk that happens to have _LIBCPP_CLANG_VER >= 1600 yet isn't something we've released as LLVM 16, then it's probably not reasonable for us to try to support that. Imagine coming up with that policy, I think it would mean that we can't ever rely on _LIBCPP_CLANG_VER >= 1600 during the libc++ 16 release, which would be pretty unfortunate.

Fri, Mar 17, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rG8ae4f833354d: [libc++][NFC] Move the stdlib= test suite configuration for Apple into the cfg. (authored by ldionne).
[libc++][NFC] Move the stdlib= test suite configuration for Apple into the cfg.
Fri, Mar 17, 12:09 PM · Restricted Project, Restricted Project
ldionne committed rGeba76ec99489: [libc++][NFC] Precise comments in test suite setup (authored by ldionne).
[libc++][NFC] Precise comments in test suite setup
Fri, Mar 17, 11:53 AM · Restricted Project, Restricted Project
ldionne added inline comments to D144994: [Draft][libc++][modules] Adds std module..
Fri, Mar 17, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
ldionne committed rGc54c90da4fb3: [libc++][NFC] Fix typo in comment (authored by ldionne).
[libc++][NFC] Fix typo in comment
Fri, Mar 17, 8:58 AM · Restricted Project, Restricted Project
ldionne updated the diff for D146236: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests.

Also tackle .verify.cpp tests

Fri, Mar 17, 8:14 AM · Restricted Project, Restricted Project
ldionne added a comment to D146236: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests.

LGTM, did you also verify the verify and fail tests? If not, then that would be nice as a followup.

Fri, Mar 17, 8:02 AM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Add test to check that availability markup triggers appropriately and fix clang-format.

Fri, Mar 17, 7:30 AM · Restricted Project, Restricted Project

Thu, Mar 16

ldionne added inline comments to D134598: [libc++] Remove availability markup for std::format.
Thu, Mar 16, 1:53 PM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Update with commit message.

Thu, Mar 16, 1:47 PM · Restricted Project, Restricted Project
ldionne updated the diff for D134598: [libc++] Remove availability markup for std::format.

Update

Thu, Mar 16, 1:47 PM · Restricted Project, Restricted Project
ldionne commandeered D134598: [libc++] Remove availability markup for std::format.

Commandeering per offline discussion.

Thu, Mar 16, 1:45 PM · Restricted Project, Restricted Project
ldionne requested review of D146236: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests.
Thu, Mar 16, 9:52 AM · Restricted Project, Restricted Project
ldionne requested changes to D144394: [libc++] Forward to std::{,w}memcmp in std::find.
Thu, Mar 16, 9:27 AM · Restricted Project, Restricted Project
ldionne published D144394: [libc++] Forward to std::{,w}memcmp in std::find for review.
Thu, Mar 16, 9:27 AM · Restricted Project, Restricted Project
ldionne accepted D121213: [libc++] Enable modernize-use-equals-delete.

I just looked at everything again with the understanding that adding a *copy* assignment operator doesn't have any impact on the generation of a copy constructor by the compiler (which frankly is bonkers), and I think this patch is correct without a doubt. The rules are just crazy though.

Thu, Mar 16, 8:52 AM · Restricted Project, Restricted Project
ldionne accepted D144568: [libc++][NFC] Refactor the __enable_ifs in <string>.

I am fine with this since:

Thu, Mar 16, 8:27 AM · Restricted Project, Restricted Project
ldionne accepted D146097: [libc++] Granularize <exception> includes.

I am fine with this in principle, but there seems to be a bit of work needed still. LGTM once CI is green. Also, when you remove transitive includes from a public header, let's add it to a _LIBCPP_REMOVE_TRANSITIVE_INCLUDES block (even if it might not be needed strictly speaking because the transitive include still exists via a private header). That documents what the public header is including and for what reasons (e.g. _LIBCPP_REMOVE_TRANSITIVE_INCLUDES implies the reason is legacy), and that's useful to know.

Thu, Mar 16, 8:16 AM · Restricted Project, Restricted Project
ldionne accepted D146076: [libc++] Remove <cstdlib> includes.

Can you explain that those are not necessary anymore since we moved to __verbose_abort in your commit message? Thanks for the patch, LGTM!

Thu, Mar 16, 8:12 AM · Restricted Project, Restricted Project
ldionne accepted D146227: [libc++] Use the _LIBCPP_VERBOSE_ABORT macro instead of calling the function directly.

Thanks for the catch.

Thu, Mar 16, 7:11 AM · Restricted Project, Restricted Project

Wed, Mar 15

ldionne added reviewers for D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests: phosek, MaskRay.
Wed, Mar 15, 10:51 AM · Restricted Project, Restricted Project
ldionne requested review of D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests.
Wed, Mar 15, 10:49 AM · Restricted Project, Restricted Project
Herald added a project to D35820: [Driver] Search compiler-rt paths in -print-file-name=: Restricted Project.
Wed, Mar 15, 6:53 AM · Restricted Project

Tue, Mar 14

ldionne added inline comments to D144994: [Draft][libc++][modules] Adds std module..
Tue, Mar 14, 10:04 AM · Restricted Project, Restricted Project, Restricted Project
ldionne accepted D145847: [libc++][format] Implements LWG3892..

LGTM, it would be great if @vitaut could have a quick look as well.

Tue, Mar 14, 8:59 AM · Restricted Project, Restricted Project
ldionne added a comment to D144499: [libc++][format] Improves width estimate..

I'd like the other folks on the review take a look first since they are more knowledgeable about Unicode.

Tue, Mar 14, 8:55 AM · Restricted Project, Restricted Project
ldionne accepted D144327: [libc++][format] Addresses LWG3825..
Tue, Mar 14, 8:54 AM · Restricted Project, Restricted Project
ldionne added inline comments to D144326: [libc++][format] Addresses LWG3720..
Tue, Mar 14, 8:53 AM · Restricted Project, Restricted Project
ldionne accepted D144325: [NFC][libc++][format] Improves diagnostics..

That's a really nice catch! Could we perhaps add a libc++ specific .verify.cpp test to lock in this behavior?

Tue, Mar 14, 8:50 AM · Restricted Project, Restricted Project
ldionne accepted D145798: [libc++] Disables transitive includes in library..

LGTM once set within CMake

Tue, Mar 14, 8:43 AM · Restricted Project, Restricted Project
ldionne accepted D145590: [libc++][charconv] Granularizes the header..

LGTM -- I am fine with either splitting the floating point to_chars and the integral ones or not splitting them. I think the current approach with a combined header that includes the floating-point/integral headers is a fine compromise.

Tue, Mar 14, 8:40 AM · Restricted Project, Restricted Project
ldionne accepted D144575: [libc++][CI] Improves Dockerfile.
Tue, Mar 14, 8:35 AM · Restricted Project, Restricted Project
ldionne accepted D145880: [libc++] Qualifies uint32_t and friends..
Tue, Mar 14, 8:34 AM · Restricted Project, Restricted Project

Mon, Mar 13

ldionne updated the diff for D145422: [libc++] Remove C++03 extensions for std::allocator_arg & friends.

Remove a stray use of allocator_arg in C++03

Mon, Mar 13, 11:15 AM · Restricted Project, Restricted Project
ldionne added inline comments to D145508: [libc++] Reject standard attributes which are extensions in libcpp-uglify-attributes.
Mon, Mar 13, 9:57 AM · Restricted Project, Restricted Project
ldionne updated subscribers of D141779: [libc++][PSTL] Copy the headers into libc++.

Thanks for the stack of patches! This is a really nice start. Before we commit to going into a specific direction, I think it is useful to lay out how we envision things being at the end, and then roughly how we're going to get there.

Mon, Mar 13, 9:39 AM · Restricted Project, Restricted Project
ldionne accepted D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions.

LGTM w/ passing CI. Please ping me again if you have to change the patch non-trivially to make CI pass.

Mon, Mar 13, 8:17 AM · Restricted Project, Restricted Project
ldionne updated the diff for D145422: [libc++] Remove C++03 extensions for std::allocator_arg & friends.

Fix test failures in C++03 mode. The CI had actually not run on the previous iteration of the patch, I think that's because I uploaded child patches after uploading the parent patch.

Mon, Mar 13, 7:52 AM · Restricted Project, Restricted Project