Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Amir (Amir Ayupov)
BOLT @ Meta

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2019, 10:17 AM (201 w, 5 d)

Recent Activity

Thu, Sep 21

Amir accepted D159526: [CodeLayout] Refactor std::vector uses, namespace, and EdgeCountT. NFC.
Thu, Sep 21, 12:31 PM · Restricted Project, Restricted Project
Amir added a comment to D159526: [CodeLayout] Refactor std::vector uses, namespace, and EdgeCountT. NFC.

Thank you for the refactoring. Looks good, but let me retrigger testing with the latest changes.
ping @spupyrev

Thu, Sep 21, 11:07 AM · Restricted Project, Restricted Project
Amir accepted D159520: [BOLT][AArch64] Fix instrumentation deadloop.

Thanks!

Thu, Sep 21, 11:04 AM · Restricted Project, Restricted Project

Wed, Sep 20

Amir added inline comments to D159520: [BOLT][AArch64] Fix instrumentation deadloop.
Wed, Sep 20, 10:57 AM · Restricted Project, Restricted Project

Mon, Sep 18

Amir committed rG6a1cf545cc0b: [BOLT][YAML] Only read first profile per function (authored by Amir).
[BOLT][YAML] Only read first profile per function
Mon, Sep 18, 8:41 PM · Restricted Project
Amir closed D159529: [BOLT][YAML] Only read first profile per function.
Mon, Sep 18, 8:41 PM · Restricted Project, Restricted Project
Amir added inline comments to D159529: [BOLT][YAML] Only read first profile per function.
Mon, Sep 18, 8:11 PM · Restricted Project, Restricted Project
Amir added inline comments to D159529: [BOLT][YAML] Only read first profile per function.
Mon, Sep 18, 8:07 PM · Restricted Project, Restricted Project
Amir added inline comments to D159529: [BOLT][YAML] Only read first profile per function.
Mon, Sep 18, 6:36 PM · Restricted Project, Restricted Project
Amir requested review of D159529: [BOLT][YAML] Only read first profile per function.
Mon, Sep 18, 6:17 PM · Restricted Project, Restricted Project
Amir added inline comments to D159520: [BOLT][AArch64] Fix instrumentation deadloop.
Mon, Sep 18, 10:50 AM · Restricted Project, Restricted Project
Amir accepted D159521: [BOLT][runtime] Test for outline-atomics support.
Mon, Sep 18, 10:35 AM · Restricted Project, Restricted Project
Amir added a comment to D159513: [Bolt] fix a relocation bug for R_AARCH64_CALL26.

@sinan – please properly capitalize the title and use 50-72 commit formatting rule to align with the rest of BOLT commits for your future commits. Thank you for the fix!

Mon, Sep 18, 10:33 AM · Restricted Project, Restricted Project
Amir accepted D159524: [BOLT] Speedup symbol table sort.
Mon, Sep 18, 10:30 AM · Restricted Project, Restricted Project

Fri, Sep 15

Amir accepted D159407: [BOLT] Incorporate umask into the output file permission.

Thank you for the fix and the test!

Fri, Sep 15, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 14

Amir committed rG4a6426a802c0: [BOLT][NFC] Simplify RI::selectFunctionsToProcess (authored by Amir).
[BOLT][NFC] Simplify RI::selectFunctionsToProcess
Thu, Sep 14, 11:58 AM · Restricted Project
Amir closed D159516: [BOLT][NFC] Simplify RI::selectFunctionsToProcess.
Thu, Sep 14, 11:57 AM · Restricted Project, Restricted Project
Amir requested review of D159516: [BOLT][NFC] Simplify RI::selectFunctionsToProcess.
Thu, Sep 14, 10:25 AM · Restricted Project, Restricted Project

Wed, Sep 13

Amir added a comment to D159089: [BOLT][RISCV] Add support for linker relaxation.

Note that since this relies on a fix in lld (D159082), this patch will probably cause CI problems again (since the system's clang is used there).

Wed, Sep 13, 12:30 PM · Restricted Project, Restricted Project
Amir added a reviewer for D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options: jobnoorman.
Wed, Sep 13, 11:53 AM · Restricted Project, Restricted Project

Tue, Sep 12

Amir committed rG4627446d38b2: [BOLT] Fix AutoFDO output format after D154120 (authored by Amir).
[BOLT] Fix AutoFDO output format after D154120
Tue, Sep 12, 1:58 PM · Restricted Project
Amir closed D159507: [BOLT] Fix AutoFDO output format after D154120.
Tue, Sep 12, 1:58 PM · Restricted Project, Restricted Project
Amir requested review of D159507: [BOLT] Fix AutoFDO output format after D154120.
Tue, Sep 12, 11:48 AM · Restricted Project, Restricted Project

Mon, Sep 11

Amir committed rG7b750943d722: [BOLT][NFC] Speedup YAML profile processing (authored by Amir).
[BOLT][NFC] Speedup YAML profile processing
Mon, Sep 11, 4:08 PM · Restricted Project
Amir closed D159460: [BOLT][NFC] Speedup YAML profile processing.
Mon, Sep 11, 4:08 PM · Restricted Project, Restricted Project
Amir committed rGffef4fe0dbb9: [BOLT][NFC] Use formatv in DataAggregator/DataReader prints (authored by Amir).
[BOLT][NFC] Use formatv in DataAggregator/DataReader prints
Mon, Sep 11, 4:01 PM · Restricted Project
Amir closed D154120: [BOLT][NFC] Use formatv in DataAggregator/DataReader prints.
Mon, Sep 11, 4:01 PM · Restricted Project, Restricted Project
Amir updated the diff for D154120: [BOLT][NFC] Use formatv in DataAggregator/DataReader prints.

clang-format

Mon, Sep 11, 3:55 PM · Restricted Project, Restricted Project
Amir added a comment to D159460: [BOLT][NFC] Speedup YAML profile processing.

Nice - good improvement. Do you know where the majority of the profile-processing time is spent with this change?

Mon, Sep 11, 3:41 PM · Restricted Project, Restricted Project
Amir added inline comments to D159460: [BOLT][NFC] Speedup YAML profile processing.
Mon, Sep 11, 3:28 PM · Restricted Project, Restricted Project
Amir updated the diff for D159460: [BOLT][NFC] Speedup YAML profile processing.

Address comments

Mon, Sep 11, 3:27 PM · Restricted Project, Restricted Project

Fri, Sep 8

Amir added a comment to D159488: [BOLT] Always match stale entry blocks.

Can you please retitle as imperative statement before landing?

Fri, Sep 8, 2:55 PM · Restricted Project, Restricted Project
Amir accepted D159488: [BOLT] Always match stale entry blocks.

Thanks. We recently discussed a case where stale matching was unable to match any block in a function and so function exec count was not set. We thought it's still beneficial to set exec count in this case for function reordering. I assume the entry block match will also make stale matching set function exec count in this scenario?

Fri, Sep 8, 2:51 PM · Restricted Project, Restricted Project

Thu, Sep 7

Amir added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

(Please make sure to amend your local commit before pushing - use arc land)

Thu, Sep 7, 10:31 AM · Restricted Project, Restricted Project
Amir accepted D159094: [BOLT][test] Fix cross-compilation tests after D151920.
Thu, Sep 7, 10:30 AM · Restricted Project, Restricted Project
Amir retitled D159094: [BOLT][test] Fix cross-compilation tests after D151920 from [BOLT][test] Fix failed tests to [BOLT][test] Fix cross-compilation tests after D151920.
Thu, Sep 7, 10:29 AM · Restricted Project, Restricted Project

Wed, Sep 6

Amir added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

Can you please also tidy up the summary using 50-72 rule?

Wed, Sep 6, 9:23 PM · Restricted Project, Restricted Project
Amir added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

@Elvina – please update the title and summary. Looks good otherwise.

Wed, Sep 6, 12:56 PM · Restricted Project, Restricted Project

Tue, Sep 5

Amir requested review of D159460: [BOLT][NFC] Speedup YAML profile processing.
Tue, Sep 5, 6:54 PM · Restricted Project, Restricted Project

Sep 3 2023

Amir added a comment to D159407: [BOLT] Incorporate umask into the output file permission.
Sep 3 2023, 4:36 PM · Restricted Project, Restricted Project, Restricted Project
Amir added a comment to D159407: [BOLT] Incorporate umask into the output file permission.

Thank you for taking care of it. Can you please also add a test?

Sep 3 2023, 4:35 PM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2023

Amir committed rG7248e57a4bf7: [BOLT][NFC] Fix duplicate word typo (authored by Amir).
[BOLT][NFC] Fix duplicate word typo
Sep 1 2023, 1:30 PM · Restricted Project
Amir committed rZORGa3e4cd49a2d9: [BOLT] Enable RISCV target testing (authored by Amir).
[BOLT] Enable RISCV target testing
Sep 1 2023, 1:23 PM · Restricted Project
Amir closed D159318: [BOLT] Enable RISCV target testing.
Sep 1 2023, 1:23 PM · Restricted Project

Aug 31 2023

Amir added a comment to D159094: [BOLT][test] Fix cross-compilation tests after D151920.

Please update the title and summary.

Aug 31 2023, 5:02 PM · Restricted Project, Restricted Project
Amir requested review of D159318: [BOLT] Enable RISCV target testing.
Aug 31 2023, 4:26 PM · Restricted Project
Amir committed rG8f9006bfa078: [BOLT][test] Move asm-dump.c to runtime/X86 (authored by Amir).
[BOLT][test] Move asm-dump.c to runtime/X86
Aug 31 2023, 10:59 AM · Restricted Project
Amir closed D159298: [BOLT][test] Move asm-dump.c to runtime/X86.
Aug 31 2023, 10:59 AM · Restricted Project, Restricted Project
Amir requested review of D159298: [BOLT][test] Move asm-dump.c to runtime/X86.
Aug 31 2023, 10:48 AM · Restricted Project, Restricted Project

Aug 30 2023

Amir added a comment to D151920: [BOLT] Instrumentation: Fix tests.

Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.

Hi! I'm trying to disable these tests in case they're building on aarch64, but I'm not sure this is the right way. Could you please take a look? https://reviews.llvm.org/D159094

Aug 30 2023, 10:37 AM · Restricted Project, Restricted Project

Aug 29 2023

Amir committed rGd1bc6f9953cc: [Clang][CMake] Remove GCC option override in BOLT.cmake (authored by Amir).
[Clang][CMake] Remove GCC option override in BOLT.cmake
Aug 29 2023, 7:41 PM · Restricted Project, Restricted Project
Amir accepted D156278: [BOLT] Fine-tuning hash computation for stale matching.

Looks good. Thank you for updating it.

Aug 29 2023, 10:11 AM · Restricted Project, Restricted Project

Aug 28 2023

Amir added a comment to D151920: [BOLT] Instrumentation: Fix tests.

Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.

Aug 28 2023, 2:47 PM · Restricted Project, Restricted Project

Aug 16 2023

Amir updated the diff for D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED.

Bugfixes

Aug 16 2023, 10:21 PM · Restricted Project, Restricted Project, Restricted Project

Aug 15 2023

Amir updated the diff for D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED.

perf2prof

Aug 15 2023, 9:52 PM · Restricted Project, Restricted Project, Restricted Project
Amir updated the diff for D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED.

Append to PGO_OPT

Aug 15 2023, 4:32 PM · Restricted Project, Restricted Project, Restricted Project
Amir retitled D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED from [Clang][CMake][WIP] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED to [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED.
Aug 15 2023, 4:31 PM · Restricted Project, Restricted Project, Restricted Project

Aug 14 2023

Amir accepted D157908: [BOLT][DWARF] Fix location list order.
Aug 14 2023, 4:06 PM · Restricted Project, Restricted Project
Amir accepted D157746: [BOLT][DWARF] Fix handling of invalid DIE references.

LGTM with minor nits. Tricky issue but thanks for handling it gracefully.

Aug 14 2023, 3:35 PM · Restricted Project, Restricted Project

Aug 9 2023

Amir committed rGec129c28af58: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs (authored by Amir).
[YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs
Aug 9 2023, 4:42 PM · Restricted Project, Restricted Project
Amir closed D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.
Aug 9 2023, 4:42 PM · Restricted Project, Restricted Project
Amir updated the summary of D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.
Aug 9 2023, 4:39 PM · Restricted Project, Restricted Project
Amir added inline comments to D156018: [BOLT] Implement createRelocation for AArch64.
Aug 9 2023, 4:37 PM · Restricted Project, Restricted Project, Restricted Project
Amir updated the diff for D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.

clang-format

Aug 9 2023, 3:47 PM · Restricted Project, Restricted Project
Amir updated the summary of D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.
Aug 9 2023, 3:46 PM · Restricted Project, Restricted Project
Amir added a comment to D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.

SGTM

Aug 9 2023, 3:45 PM · Restricted Project, Restricted Project
Amir updated the diff for D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.

Call DestroyAll from setCurrentDocument

Aug 9 2023, 2:59 PM · Restricted Project, Restricted Project
Amir added a comment to D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.

What are the codepaths that currently destroy these nodes?

Aug 9 2023, 12:51 PM · Restricted Project, Restricted Project
Amir accepted D157217: [BOLT][NFC] Split createRelocation in X86 and share the second part.

Please add "[BOLT][NFC]" to the title.

Aug 9 2023, 7:27 AM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2023

Amir updated the diff for D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.

Remove Input destructor override

Aug 8 2023, 3:15 PM · Restricted Project, Restricted Project
Amir updated the summary of D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs.
Aug 8 2023, 3:13 PM · Restricted Project, Restricted Project
Amir published D155006: [YAML][NFC] Use BumpPtrAllocator instead of unique_ptrs for review.
Aug 8 2023, 3:09 PM · Restricted Project, Restricted Project
Amir accepted D157357: [BOLT][DWARF][NFC] Remove addIndexAddress.
Aug 8 2023, 3:01 PM · Restricted Project, Restricted Project
Amir accepted D157354: [BOLT][DWARF][NFC] Add function to print DIE.

LGTM with nits

Aug 8 2023, 3:01 PM · Restricted Project, Restricted Project
Amir accepted D157356: [BOLT][DWARF] Always use new low_pc for call_site.

Looks sane/safe.

Aug 8 2023, 2:45 PM · Restricted Project, Restricted Project
Amir accepted D157355: [BOLT][DWARF] Always use new low_pc for exprloc.

LGTM sans nits.

Aug 8 2023, 2:35 PM · Restricted Project, Restricted Project

Aug 1 2023

Amir added a comment to D156018: [BOLT] Implement createRelocation for AArch64.

Can you please retitle it as "[BOLT] Implement createRelocation for AArch64"?

Aug 1 2023, 7:51 PM · Restricted Project, Restricted Project, Restricted Project
Amir accepted D152959: [BOLT] Fix sorting functions by execution count.
Aug 1 2023, 7:47 PM · Restricted Project, Restricted Project
Amir added a comment to D156278: [BOLT] Fine-tuning hash computation for stale matching.

Please fix a couple of nits, LGTM otherwise.

Aug 1 2023, 1:08 PM · Restricted Project, Restricted Project

Jul 31 2023

Amir added a comment to D156765: [BOLT][DWARF] Opt out test from aarch64.

Or rather please retitle it as “[BOLT][test] Require x86_64-linux for <test>”

Jul 31 2023, 6:23 PM · Restricted Project, Restricted Project
Amir added a comment to D156765: [BOLT][DWARF] Opt out test from aarch64.

Please remove the dot from the title

Jul 31 2023, 6:19 PM · Restricted Project, Restricted Project
Amir accepted D156765: [BOLT][DWARF] Opt out test from aarch64.
Jul 31 2023, 6:19 PM · Restricted Project, Restricted Project
Amir committed rG2dea832ef064: [BOLT][test] Add missing stderr redirections (authored by Amir).
[BOLT][test] Add missing stderr redirections
Jul 31 2023, 4:17 PM · Restricted Project
Amir closed D156340: [BOLT][test] Add missing stderr redirections.
Jul 31 2023, 4:17 PM · Restricted Project, Restricted Project
Amir committed rGd796f36fbc51: [BOLT][NFC] Simplify DataAggregator (authored by Amir).
[BOLT][NFC] Simplify DataAggregator
Jul 31 2023, 2:55 PM · Restricted Project
Amir closed D154749: [BOLT][NFC] Simplify DataAggregator.
Jul 31 2023, 2:54 PM · Restricted Project, Restricted Project
Amir updated the summary of D154749: [BOLT][NFC] Simplify DataAggregator.
Jul 31 2023, 2:53 PM · Restricted Project, Restricted Project
Amir retitled D154749: [BOLT][NFC] Simplify DataAggregator from [BOLT][NFC] Simplify DataAggregator/YAMLProfileReader to [BOLT][NFC] Simplify DataAggregator.
Jul 31 2023, 2:52 PM · Restricted Project, Restricted Project
Amir updated the diff for D154749: [BOLT][NFC] Simplify DataAggregator.

Rebase

Jul 31 2023, 2:52 PM · Restricted Project, Restricted Project
Amir committed rG70e76e0982a9: [BOLT] Fix instrumenting conditional tail calls (authored by Amir).
[BOLT] Fix instrumenting conditional tail calls
Jul 31 2023, 1:53 PM · Restricted Project
Amir closed D156389: [BOLT] Fix instrumenting conditional tail calls.
Jul 31 2023, 1:53 PM · Restricted Project, Restricted Project
Amir committed rGb0b566b5da23: [BOLT][YAML] Only read first profile per function (authored by Amir).
[BOLT][YAML] Only read first profile per function
Jul 31 2023, 1:48 PM · Restricted Project
Amir closed D156644: [BOLT][YAML] Only read first profile per function.
Jul 31 2023, 1:48 PM · Restricted Project, Restricted Project
Amir accepted D156734: [BOLT] Fixing macOS build.
Jul 31 2023, 1:46 PM · Restricted Project, Restricted Project
Amir requested review of D156697: [BOLT] Split missed macro-fusion counting around removeConditionalTailCalls.
Jul 31 2023, 7:50 AM · Restricted Project, Restricted Project

Jul 30 2023

Amir requested review of D156644: [BOLT][YAML] Only read first profile per function.
Jul 30 2023, 9:45 PM · Restricted Project, Restricted Project

Jul 29 2023

Amir updated the diff for D156607: [Clang][CMake] Allow using passthrough BOLT in BOLT-PGO.cmake.

Add clang-bolt-profile-deps dependency

Jul 29 2023, 11:11 PM · Restricted Project, Restricted Project
Amir requested review of D156607: [Clang][CMake] Allow using passthrough BOLT in BOLT-PGO.cmake.
Jul 29 2023, 11:03 PM · Restricted Project, Restricted Project

Jul 28 2023

Amir retitled D156389: [BOLT] Fix instrumenting conditional tail calls from [BOLT] Add support for instrumenting conditional tail calls to [BOLT] Fix instrumenting conditional tail calls.
Jul 28 2023, 12:16 PM · Restricted Project, Restricted Project
Amir updated the diff for D156389: [BOLT] Fix instrumenting conditional tail calls.

Move Offset annotation from former CTC to the tail call.

Jul 28 2023, 12:13 PM · Restricted Project, Restricted Project