- User Since
- Nov 22 2019, 10:17 AM (201 w, 5 d)
Thu, Sep 21
Thank you for the refactoring. Looks good, but let me retrigger testing with the latest changes.
Wed, Sep 20
Mon, Sep 18
@sinan – please properly capitalize the title and use 50-72 commit formatting rule to align with the rest of BOLT commits for your future commits. Thank you for the fix!
Fri, Sep 15
Thank you for the fix and the test!
Thu, Sep 14
Wed, Sep 13
Tue, Sep 12
Mon, Sep 11
Fri, Sep 8
Can you please retitle as imperative statement before landing?
Thanks. We recently discussed a case where stale matching was unable to match any block in a function and so function exec count was not set. We thought it's still beneficial to set exec count in this case for function reordering. I assume the entry block match will also make stale matching set function exec count in this scenario?
Thu, Sep 7
(Please make sure to amend your local commit before pushing - use arc land)
Wed, Sep 6
Can you please also tidy up the summary using 50-72 rule?
@Elvina – please update the title and summary. Looks good otherwise.
Tue, Sep 5
Sep 3 2023
Thank you for taking care of it. Can you please also add a test?
Sep 1 2023
Aug 31 2023
Please update the title and summary.
Aug 30 2023
Aug 29 2023
Looks good. Thank you for updating it.
Aug 28 2023
Hi Elvina, this stack broke aarch64 buildbot: https://lab.llvm.org/buildbot/#/builders/221/builds/17715. You should've received a notification. Please prioritize fixing it or revert if it can't be fixed quickly.
Aug 16 2023
Aug 15 2023
Append to PGO_OPT
Aug 14 2023
LGTM with minor nits. Tricky issue but thanks for handling it gracefully.
Aug 9 2023
Call DestroyAll from setCurrentDocument
Please add "[BOLT][NFC]" to the title.
Aug 8 2023
Remove Input destructor override
LGTM with nits
LGTM sans nits.
Aug 1 2023
Can you please retitle it as "[BOLT] Implement createRelocation for AArch64"?
Please fix a couple of nits, LGTM otherwise.
Jul 31 2023
Or rather please retitle it as “[BOLT][test] Require x86_64-linux for <test>”
Please remove the dot from the title
Jul 30 2023
Jul 29 2023
Add clang-bolt-profile-deps dependency
Jul 28 2023
Move Offset annotation from former CTC to the tail call.