User Details
- User Since
- Nov 22 2019, 10:17 AM (130 w, 3 d)
Today
I thought about it and now I don't think embedding html and javascript code into BOLT binary is a good idea.
A better approach would be to embed dot file into html template using an external tool: D126218.
Sat, May 21
The msvc build is still broken. https://lab.llvm.org/buildbot/#/builders/222/builds/532
Fri, May 20
Would it make sense to factor equalizeBBCounts out into a pass or BF method? (can do as a follow-up)
LGTM but didn't check every new line.
I'm concerned that the fix is an overkill and doesn't address the root cause.
From what I understand, evaluateSimple can only evaluate a constant when given an instruction it understands and a pair of <reg, val> for use in evaluation. So the problem must be with the calling code – that the value of rsp is considered a constant while it's actually not (at least not in this case).
Thu, May 19
Looks like this commit breaks msvc build: https://lab.llvm.org/buildbot/#/builders/222/builds/532
Wed, May 18
LGTM with one comment
Tue, May 17
Mon, May 16
Fri, May 13
LGTM
Thu, May 12
Wed, May 11
Keep override in {X86,AArch64}/asm-func-debug.test
Thu, May 5
Wed, May 4
Vladislav, thank you for adding this support! It's a massive change, so let's make it easier to review. Can you please split this diff up into small isolated chunks?
I would suggest having separate diffs for:
- Core interface changes/additions
- Instrumentation changes
- MCPlusBuilder changes
- Passes changes
- Base Golang passes/functions/data structures
- Interaction between Golang stuff and existing passes
- Documentation changes
Move initAliases to MCPlusBuilder ctor
Move AliasMap and SmallerAliasMap into MCPlusBuilder object;
split initAliases from getAliases.
Tue, May 3
Remove extra line
Move puts to stub.h
Fix build with upstream clang
This change breaks testing with an upstream clang:
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-bolttests/llvm-project/bolt/test/Inputs/icf-jump-tables.c:3:13: error: call to undeclared function 'puts'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
Reverted the change for now, will figure out the proper fix and re-land.