Page MenuHomePhabricator

Amir (Amir Ayupov)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2019, 10:17 AM (130 w, 3 d)

Recent Activity

Today

Amir added inline comments to D126237: [BOLT][NFC] Print block instructions in dumpGraph as part of node label.
Mon, May 23, 1:23 PM · Restricted Project, Restricted Project
Amir published D126232: [BOLT][NFC] Customize endline character for printInstruction(s) for review.
Mon, May 23, 1:23 PM · Restricted Project, Restricted Project
Amir abandoned D125945: [BOLT][NFC] Dump function CFG into html, rendered in browser using d3-graphviz.

I thought about it and now I don't think embedding html and javascript code into BOLT binary is a good idea.
A better approach would be to embed dot file into html template using an external tool: D126218.

Mon, May 23, 1:17 PM · Restricted Project, Restricted Project
Amir published D126237: [BOLT][NFC] Print block instructions in dumpGraph as part of node label for review.
Mon, May 23, 1:16 PM · Restricted Project, Restricted Project
Amir published D126218: [BOLT][UTILS] Add dot2html helper tool to embed dot into html for review.
Mon, May 23, 1:15 PM · Restricted Project, Restricted Project

Sat, May 21

Amir added a comment to D124836: [AArch64] Add support for -fzero-call-used-regs.

The msvc build is still broken. https://lab.llvm.org/buildbot/#/builders/222/builds/532

Sat, May 21, 2:39 PM · Restricted Project, Restricted Project, Restricted Project

Fri, May 20

Amir accepted D126113: [BOLT] Increase coverage of shrink wrapping [3/5].

Would it make sense to factor equalizeBBCounts out into a pass or BF method? (can do as a follow-up)

Fri, May 20, 11:56 PM · Restricted Project, Restricted Project
Amir accepted D126112: [BOLT] Increase coverage of shrink wrapping [2/5].

LGTM but didn't check every new line.

Fri, May 20, 11:39 PM · Restricted Project, Restricted Project
Amir added a comment to D126110: [BOLT] Fix AND evaluation bug in shrink wrapping.

I'm concerned that the fix is an overkill and doesn't address the root cause.
From what I understand, evaluateSimple can only evaluate a constant when given an instruction it understands and a pair of <reg, val> for use in evaluation. So the problem must be with the calling code – that the value of rsp is considered a constant while it's actually not (at least not in this case).

Fri, May 20, 9:36 PM · Restricted Project, Restricted Project

Thu, May 19

Amir added a comment to D124836: [AArch64] Add support for -fzero-call-used-regs.

Looks like this commit breaks msvc build: https://lab.llvm.org/buildbot/#/builders/222/builds/532

Thu, May 19, 6:47 PM · Restricted Project, Restricted Project, Restricted Project
Amir accepted D125941: [BOLT] Testcase to repro dyn reloc bug.
Thu, May 19, 1:04 PM · Restricted Project, Restricted Project
Amir published D125945: [BOLT][NFC] Dump function CFG into html, rendered in browser using d3-graphviz for review.
Thu, May 19, 11:43 AM · Restricted Project, Restricted Project

Wed, May 18

Amir accepted D125843: [BOLT] Testcase to repro R_X86_64_REX_GOTPCRELX bug.

LGTM with one comment

Wed, May 18, 8:06 AM · Restricted Project, Restricted Project

Tue, May 17

Amir committed rGc907d6e0e9fd: [BOLT][NFC] Suppress unused variable warnings (authored by Amir).
[BOLT][NFC] Suppress unused variable warnings
Tue, May 17, 2:30 PM · Restricted Project
Amir closed D125733: [BOLT][NFC] Suppress unused variable warnings.
Tue, May 17, 2:30 PM · Restricted Project, Restricted Project
Amir committed rGa7b69dbdd10f: [BOLT][NFC] Move BinaryDominatorTree out of BinaryLoop header (authored by Amir).
[BOLT][NFC] Move BinaryDominatorTree out of BinaryLoop header
Tue, May 17, 2:20 PM · Restricted Project
Amir closed D125664: [BOLT][NFC] Move BinaryDominatorTree out of BinaryLoop header.
Tue, May 17, 2:20 PM · Restricted Project, Restricted Project

Mon, May 16

Amir published D125664: [BOLT][NFC] Move BinaryDominatorTree out of BinaryLoop header for review.
Mon, May 16, 4:27 PM · Restricted Project, Restricted Project
Amir updated the summary of D125733: [BOLT][NFC] Suppress unused variable warnings.
Mon, May 16, 4:26 PM · Restricted Project, Restricted Project
Amir requested review of D125733: [BOLT][NFC] Suppress unused variable warnings.
Mon, May 16, 4:26 PM · Restricted Project, Restricted Project

Fri, May 13

Amir accepted D125591: [BOLT] Fix merge-fdata handling of BAT profiles.

LGTM

Fri, May 13, 4:05 PM · Restricted Project, Restricted Project
Amir accepted D125577: [14.x][BOLT][CMAKE] Fix DYLIB build.
Fri, May 13, 1:37 PM · Restricted Project, Restricted Project
Amir committed rGbdba3d091c66: [BOLT][CMAKE] Fix DYLIB build (authored by Amir).
[BOLT][CMAKE] Fix DYLIB build
Fri, May 13, 1:27 PM · Restricted Project
Amir closed D125568: [BOLT][CMAKE] Fix DYLIB build.
Fri, May 13, 1:27 PM · Restricted Project, Restricted Project
Amir committed rGda766cea56df: [BOLT][TEST] Fix testing on macos (authored by Amir).
[BOLT][TEST] Fix testing on macos
Fri, May 13, 1:04 PM · Restricted Project
Amir closed D125548: [BOLT][TEST] Fix testing on macos.
Fri, May 13, 1:03 PM · Restricted Project, Restricted Project
Amir added a comment to D125568: [BOLT][CMAKE] Fix DYLIB build.

LGTM, I've backported this to the release/14.x branch at https://reviews.llvm.org/D125577 (but not sure how to make Phabricator realize that one is supposed to go on a branch).

Fri, May 13, 12:44 PM · Restricted Project, Restricted Project
Amir committed rG253b8f0abd66: [BOLT][NFC] Use refs for loop variables to avoid copies (authored by Amir).
[BOLT][NFC] Use refs for loop variables to avoid copies
Fri, May 13, 12:18 PM · Restricted Project
Amir closed D125483: [BOLT][NFC] Use refs for loop variables to avoid copies.
Fri, May 13, 12:18 PM · Restricted Project, Restricted Project
Amir committed rG139744ac5388: [BOLT][NFC] Suppress unused variable warnings (authored by Amir).
[BOLT][NFC] Suppress unused variable warnings
Fri, May 13, 12:10 PM · Restricted Project
Amir closed D125475: [BOLT][NFC] Suppress unused variable warnings.
Fri, May 13, 12:10 PM · Restricted Project, Restricted Project
Amir committed rGc1532ac4aae2: [BOLT][CMAKE] Add missing clauses to bolt/runtime/CMakeLists.txt (authored by Amir).
[BOLT][CMAKE] Add missing clauses to bolt/runtime/CMakeLists.txt
Fri, May 13, 11:52 AM · Restricted Project
Amir closed D125480: [BOLT][CMAKE] Add missing clauses to bolt/runtime/CMakeLists.txt.
Fri, May 13, 11:52 AM · Restricted Project, Restricted Project
Amir published D125568: [BOLT][CMAKE] Fix DYLIB build for review.
Fri, May 13, 11:20 AM · Restricted Project, Restricted Project
Amir published D125548: [BOLT][TEST] Fix testing on macos for review.
Fri, May 13, 9:52 AM · Restricted Project, Restricted Project

Thu, May 12

Amir requested review of D125483: [BOLT][NFC] Use refs for loop variables to avoid copies.
Thu, May 12, 10:56 AM · Restricted Project, Restricted Project
Amir published D125475: [BOLT][NFC] Suppress unused variable warnings for review.
Thu, May 12, 10:40 AM · Restricted Project, Restricted Project
Amir requested review of D125480: [BOLT][CMAKE] Add missing clauses to bolt/runtime/CMakeLists.txt.
Thu, May 12, 10:40 AM · Restricted Project, Restricted Project

Wed, May 11

Amir committed rGd63c5a38fe0d: [BOLT][NFC] Use BitVector::set_bits (authored by Amir).
[BOLT][NFC] Use BitVector::set_bits
Wed, May 11, 4:24 PM · Restricted Project
Amir closed D125374: [BOLT][NFC] Use BitVector::set_bits.
Wed, May 11, 4:24 PM · Restricted Project, Restricted Project
Amir committed rG8cb7a873ab85: [BOLT][NFC] Add MCPlus::primeOperands iterator_range (authored by Amir).
[BOLT][NFC] Add MCPlus::primeOperands iterator_range
Wed, May 11, 9:35 AM · Restricted Project
Amir closed D125397: [BOLT][NFC] Add MCPlus::primeOperands iterator_range.
Wed, May 11, 9:35 AM · Restricted Project, Restricted Project
Amir requested review of D125397: [BOLT][NFC] Add MCPlus::primeOperands iterator_range.
Wed, May 11, 9:02 AM · Restricted Project, Restricted Project
Amir published D125374: [BOLT][NFC] Use BitVector::set_bits for review.
Wed, May 11, 6:20 AM · Restricted Project, Restricted Project
Amir committed rG4a58eb9e4e52: [BOLT][TEST] Remove -gdwarf-4 override from %cflags (authored by Amir).
[BOLT][TEST] Remove -gdwarf-4 override from %cflags
Wed, May 11, 3:38 AM · Restricted Project
Amir closed D125366: [BOLT][TEST] Remove -gdwarf-4 override from %cflags.
Wed, May 11, 3:38 AM · Restricted Project, Restricted Project
Amir committed rGc2d40f1dfb64: [BOLT] Add icp-inline option (authored by Amir).
[BOLT] Add icp-inline option
Wed, May 11, 3:22 AM · Restricted Project
Amir closed D124900: [BOLT] Add icp-inline option.
Wed, May 11, 3:21 AM · Restricted Project, Restricted Project
Amir retitled D125366: [BOLT][TEST] Remove -gdwarf-4 override from %cflags from [BOLT][TEST] Remove -gdwarf-4 override to [BOLT][TEST] Remove -gdwarf-4 override from %cflags.
Wed, May 11, 3:15 AM · Restricted Project, Restricted Project
Amir updated the diff for D125366: [BOLT][TEST] Remove -gdwarf-4 override from %cflags.

Keep override in {X86,AArch64}/asm-func-debug.test

Wed, May 11, 3:14 AM · Restricted Project, Restricted Project
Amir requested review of D125366: [BOLT][TEST] Remove -gdwarf-4 override from %cflags.
Wed, May 11, 2:54 AM · Restricted Project, Restricted Project

Thu, May 5

Amir committed rZORGcaf99f348004: [BOLT] Enable ccache for msvc builder (authored by Amir).
[BOLT] Enable ccache for msvc builder
Thu, May 5, 11:27 AM · Restricted Project
Amir committed rGaff52d1f08d2: [BOLT][CMAKE] Check build target architecture for runtime libs (authored by Amir).
[BOLT][CMAKE] Check build target architecture for runtime libs
Thu, May 5, 10:40 AM · Restricted Project
Amir closed D124712: [BOLT][CMAKE] Check build target architecture for runtime libs.
Thu, May 5, 10:40 AM · Restricted Project, Restricted Project

Wed, May 4

Amir committed rGf8d2d8b587db: [BOLT][NFC] Move getInliningInfo out of Inliner class (authored by Amir).
[BOLT][NFC] Move getInliningInfo out of Inliner class
Wed, May 4, 2:08 PM · Restricted Project
Amir closed D124899: [BOLT][NFC] Move getInliningInfo out of Inliner class.
Wed, May 4, 2:08 PM · Restricted Project, Restricted Project
Amir committed rG2ad1c7540eb0: [BOLT][NFC] Minor cleanup in ICP getCallTargets and canPromoteCallsite (authored by Amir).
[BOLT][NFC] Minor cleanup in ICP getCallTargets and canPromoteCallsite
Wed, May 4, 2:07 PM · Restricted Project
Amir closed D124898: [BOLT][NFC] Minor cleanup in ICP getCallTargets and canPromoteCallsite.
Wed, May 4, 2:07 PM · Restricted Project, Restricted Project
Amir added a comment to D124347: [BOLT] RFC: Add golang support.

Vladislav, thank you for adding this support! It's a massive change, so let's make it easier to review. Can you please split this diff up into small isolated chunks?
I would suggest having separate diffs for:

  1. Core interface changes/additions
  2. Instrumentation changes
  3. MCPlusBuilder changes
  4. Passes changes
  5. Base Golang passes/functions/data structures
  6. Interaction between Golang stuff and existing passes
  7. Documentation changes
Wed, May 4, 1:45 PM · Restricted Project, Restricted Project
Amir committed rG68c7299f16aa: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior (authored by Amir).
[BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior
Wed, May 4, 12:53 PM · Restricted Project
Amir closed D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.
Wed, May 4, 12:53 PM · Restricted Project, Restricted Project
Amir added inline comments to D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.
Wed, May 4, 11:24 AM · Restricted Project, Restricted Project
Amir updated the diff for D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.

Move initAliases to MCPlusBuilder ctor

Wed, May 4, 11:24 AM · Restricted Project, Restricted Project
Amir retitled D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior from [BOLT][TEST] Fix MCPlusBuilder::getAliases caching behavior to [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.
Wed, May 4, 11:12 AM · Restricted Project, Restricted Project
Amir updated the diff for D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.

Move AliasMap and SmallerAliasMap into MCPlusBuilder object;
split initAliases from getAliases.

Wed, May 4, 11:11 AM · Restricted Project, Restricted Project
Amir added inline comments to D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.
Wed, May 4, 10:43 AM · Restricted Project, Restricted Project
Amir retitled D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior from [BOLT][TEST] Fix MCPlusBuilder::getAliases with two targets to [BOLT][TEST] Fix MCPlusBuilder::getAliases caching behavior.
Wed, May 4, 10:41 AM · Restricted Project, Restricted Project
Amir requested review of D124942: [BOLT][NFC] Fix MCPlusBuilder::getAliases caching behavior.
Wed, May 4, 10:13 AM · Restricted Project, Restricted Project

Tue, May 3

Amir retitled D124900: [BOLT] Add icp-inline option from [BOLT] Add icp-inline mode to [BOLT] Add icp-inline option.
Tue, May 3, 7:40 PM · Restricted Project, Restricted Project
Amir updated the diff for D124896: [BOLT][NFC] Make ICP::verifyProfile static.

Remove extra line

Tue, May 3, 7:37 PM · Restricted Project, Restricted Project
Amir committed rG60957a5a08a5: [BOLT] Fix ICPJumpTablesTopN option use (authored by Amir).
[BOLT] Fix ICPJumpTablesTopN option use
Tue, May 3, 7:34 PM · Restricted Project
Amir closed D124880: [BOLT] Fix ICPJumpTablesTopN option use.
Tue, May 3, 7:34 PM · Restricted Project, Restricted Project
Amir committed rGc3d53720933b: [BOLT][NFC] Make ICP options naming uniform (authored by Amir).
[BOLT][NFC] Make ICP options naming uniform
Tue, May 3, 7:33 PM · Restricted Project
Amir closed D124879: [BOLT][NFC] Make ICP options naming uniform.
Tue, May 3, 7:33 PM · Restricted Project, Restricted Project
Amir committed rGd0b1c98c960b: [BOLT][NFC] ICP: simplify findTargetsIndex (authored by Amir).
[BOLT][NFC] ICP: simplify findTargetsIndex
Tue, May 3, 7:32 PM · Restricted Project
Amir closed D124877: [BOLT][NFC] ICP: simplify findTargetsIndex.
Tue, May 3, 7:31 PM · Restricted Project, Restricted Project
Amir committed rGec02227bf7c3: [BOLT][NFC] Refactor ICP::findCallTargetSymbols (authored by Amir).
[BOLT][NFC] Refactor ICP::findCallTargetSymbols
Tue, May 3, 7:30 PM · Restricted Project
Amir closed D124876: [BOLT][NFC] Refactor ICP::findCallTargetSymbols.
Tue, May 3, 7:29 PM · Restricted Project, Restricted Project
Amir committed rGf9db6d2d5b24: [BOLT][CMAKE] Fix llvm-bolt-fuzzer build (authored by Amir).
[BOLT][CMAKE] Fix llvm-bolt-fuzzer build
Tue, May 3, 7:26 PM · Restricted Project
Amir closed D124886: [BOLT][CMAKE] Fix llvm-bolt-fuzzer build.
Tue, May 3, 7:26 PM · Restricted Project, Restricted Project
Amir requested review of D124900: [BOLT] Add icp-inline option.
Tue, May 3, 7:18 PM · Restricted Project, Restricted Project
Amir requested review of D124899: [BOLT][NFC] Move getInliningInfo out of Inliner class.
Tue, May 3, 7:14 PM · Restricted Project, Restricted Project
Amir requested review of D124898: [BOLT][NFC] Minor cleanup in ICP getCallTargets and canPromoteCallsite.
Tue, May 3, 7:09 PM · Restricted Project, Restricted Project
Amir requested review of D124896: [BOLT][NFC] Make ICP::verifyProfile static.
Tue, May 3, 7:05 PM · Restricted Project, Restricted Project
Amir committed rG1d5263c554cb: [BOLT][TEST] Fix test failures on AArch64 builder (authored by Amir).
[BOLT][TEST] Fix test failures on AArch64 builder
Tue, May 3, 3:40 PM · Restricted Project
Amir closed D124863: [BOLT][TEST] Fix test failures on AArch64 builder.
Tue, May 3, 3:39 PM · Restricted Project, Restricted Project
Amir requested review of D124886: [BOLT][CMAKE] Fix llvm-bolt-fuzzer build.
Tue, May 3, 3:37 PM · Restricted Project, Restricted Project
Amir added a comment to D124863: [BOLT][TEST] Fix test failures on AArch64 builder.

@Amir Consider to add puts to stub.h and include the header

Tue, May 3, 3:14 PM · Restricted Project, Restricted Project
Amir updated the diff for D124863: [BOLT][TEST] Fix test failures on AArch64 builder.

Move puts to stub.h

Tue, May 3, 3:13 PM · Restricted Project, Restricted Project
Amir updated the diff for D124863: [BOLT][TEST] Fix test failures on AArch64 builder.

Fix build with upstream clang

Tue, May 3, 2:59 PM · Restricted Project, Restricted Project
Amir requested review of D124880: [BOLT] Fix ICPJumpTablesTopN option use.
Tue, May 3, 2:26 PM · Restricted Project, Restricted Project
Amir requested review of D124879: [BOLT][NFC] Make ICP options naming uniform.
Tue, May 3, 2:21 PM · Restricted Project, Restricted Project
Amir requested review of D124877: [BOLT][NFC] ICP: simplify findTargetsIndex.
Tue, May 3, 2:16 PM · Restricted Project, Restricted Project
Amir requested review of D124876: [BOLT][NFC] Refactor ICP::findCallTargetSymbols.
Tue, May 3, 2:14 PM · Restricted Project, Restricted Project
Amir abandoned D123759: UnifiedTreeBuilder: only add cmake steps if clean build is requested.

By the way, we had a conditional cmake run before, and removed that because of some dependencies were not forced by ninja.
https://github.com/llvm/llvm-zorg/commit/a9f92433031343bfbb6b2160e2829b89d39ab461

Tue, May 3, 1:04 PM · Restricted Project
Amir reopened D124863: [BOLT][TEST] Fix test failures on AArch64 builder.
Tue, May 3, 12:48 PM · Restricted Project, Restricted Project
Amir added a comment to D124863: [BOLT][TEST] Fix test failures on AArch64 builder.

This change breaks testing with an upstream clang:

/home/worker/bolt-worker2/bolt-x86_64-ubuntu-bolttests/llvm-project/bolt/test/Inputs/icf-jump-tables.c:3:13: error: call to undeclared function 'puts'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Reverted the change for now, will figure out the proper fix and re-land.

Tue, May 3, 12:47 PM · Restricted Project, Restricted Project
Amir added a reverting change for rG88b6d3211c83: [BOLT][TEST] Fix test failures on AArch64 builder: rG39492ba5d69e: Revert "[BOLT][TEST] Fix test failures on AArch64 builder".
Tue, May 3, 12:46 PM · Restricted Project
Amir committed rG39492ba5d69e: Revert "[BOLT][TEST] Fix test failures on AArch64 builder" (authored by Amir).
Revert "[BOLT][TEST] Fix test failures on AArch64 builder"
Tue, May 3, 12:46 PM · Restricted Project
Amir added a reverting change for D124863: [BOLT][TEST] Fix test failures on AArch64 builder: rG39492ba5d69e: Revert "[BOLT][TEST] Fix test failures on AArch64 builder".
Tue, May 3, 12:45 PM · Restricted Project, Restricted Project