I thought about it and now I don't think embedding html and javascript code into BOLT binary is a good idea.
A better approach would be to embed dot file into html template using an external tool: D126218.

The msvc build is still broken. https://lab.llvm.org/buildbot/#/builders/222/builds/532

Would it make sense to factor equalizeBBCounts out into a pass or BF method? (can do as a follow-up)

LGTM but didn't check every new line.

I'm concerned that the fix is an overkill and doesn't address the root cause.
From what I understand, evaluateSimple can only evaluate a constant when given an instruction it understands and a pair of <reg, val> for use in evaluation. So the problem must be with the calling code – that the value of rsp is considered a constant while it's actually not (at least not in this case).

Looks like this commit breaks msvc build: https://lab.llvm.org/buildbot/#/builders/222/builds/532

LGTM with one comment

LGTM

In D125568#3512462, @bero wrote:

LGTM, I've backported this to the release/14.x branch at https://reviews.llvm.org/D125577 (but not sure how to make Phabricator realize that one is supposed to go on a branch).

Keep override in {X86,AArch64}/asm-func-debug.test

Vladislav, thank you for adding this support! It's a massive change, so let's make it easier to review. Can you please split this diff up into small isolated chunks?
I would suggest having separate diffs for:

1. Core interface changes/additions
2. Instrumentation changes
3. MCPlusBuilder changes
4. Passes changes
5. Base Golang passes/functions/data structures
6. Interaction between Golang stuff and existing passes
7. Documentation changes

Move initAliases to MCPlusBuilder ctor

Move AliasMap and SmallerAliasMap into MCPlusBuilder object;
split initAliases from getAliases.

Remove extra line

In D124863#3489705, @yota9 wrote:

@Amir Consider to add puts to stub.h and include the header

Move puts to stub.h

Fix build with upstream clang

In D123759#3489297, @gkistanova wrote:

By the way, we had a conditional cmake run before, and removed that because of some dependencies were not forced by ninja.
https://github.com/llvm/llvm-zorg/commit/a9f92433031343bfbb6b2160e2829b89d39ab461

This change breaks testing with an upstream clang:

/home/worker/bolt-worker2/bolt-x86_64-ubuntu-bolttests/llvm-project/bolt/test/Inputs/icf-jump-tables.c:3:13: error: call to undeclared function 'puts'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Reverted the change for now, will figure out the proper fix and re-land.