Details
Details
- Reviewers
deadalnix bollu JDevlieghere lebedev.ri ldionne jhenderson aartbik MaskRay sscalpone ftynse aaron.ballman rafauler Amir maksfb jdoerfert sstefan1 nicolasvasilache - Group Reviewers
Restricted Project Restricted Project Restricted Project
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Could you do this on a per-project basis? More than 1000 files is way to much to sift through.
Comment Actions
A couple notes skimming the changes:
- If you're going to update URLs, please verify the new URLs are actually valid.
- Some of the "URLs" you're updating aren't actually URLs. For example, the xmlns attribute in SVG files must be the exact string written in the standard; changing it could make the file unreadable.
Comment Actions
+1 on breaking this down per sub-project and creating separate patches for review.
I sampled the patch and about a quarter or so of the links I tried didn't work, even before the change. There's no point in generating churn by changing those, but there's also little value in keeping them around, and fixing them is beyond the scope of this patch. I'm inclined to say let's leave them be, but I'm curious to hear what others think about that.