Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (213 w, 5 d)
Roles
Administrator

Recent Activity

Today

MyDeveloperDay updated the diff for D67888: [clang-format] NFC clang-format the clang-format unit tests.

wrong patch file

Sun, Sep 22, 5:21 AM · Restricted Project, Restricted Project
MyDeveloperDay created D67888: [clang-format] NFC clang-format the clang-format unit tests.
Sun, Sep 22, 5:11 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGa506ed256aeb: Clang-format: Add Whitesmiths indentation style (authored by MyDeveloperDay).
Clang-format: Add Whitesmiths indentation style
Sun, Sep 22, 5:02 AM

Yesterday

MyDeveloperDay added a project to D67843: DisableFormat also now disables SortIncludes: Restricted Project.
Sat, Sep 21, 10:31 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D67843: DisableFormat also now disables SortIncludes.

I assume the intention was that users could have DisableFormat=true and SortIncludes=true when they want to sort the includes but not perform any additional formatting in the code.

Sat, Sep 21, 10:31 AM · Restricted Project, Restricted Project

Fri, Sep 20

MyDeveloperDay added inline comments to D67501: [clang-tidy] Fix relative path in header-filter..
Fri, Sep 20, 2:08 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 19

MyDeveloperDay created D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style .
Thu, Sep 19, 12:52 PM · Restricted Project, Restricted Project

Wed, Sep 18

MyDeveloperDay committed rGa767a0688b09: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda… (authored by MyDeveloperDay).
[clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda…
Wed, Sep 18, 12:18 PM
MyDeveloperDay committed rG79983be5a027: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and… (authored by MyDeveloperDay).
[clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and…
Wed, Sep 18, 11:58 AM
MyDeveloperDay created D67718: [clang-format][PR41899] PointerAlignment: Left leads to useless space in lambda intializer expression.
Wed, Sep 18, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D67627: Clang-format: Add Whitesmiths indentation style.

LGTM

Wed, Sep 18, 12:48 AM · Restricted Project, Restricted Project

Tue, Sep 17

MyDeveloperDay updated the diff for D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab.

I should have known it was more involved.

Tue, Sep 17, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab.
Tue, Sep 17, 12:21 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay created D67670: [clang-format][PR41964] Fix crash with SIGFPE when TabWidth is set to 0 and line starts with tab.
Tue, Sep 17, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords.
Tue, Sep 17, 7:56 AM · Restricted Project
MyDeveloperDay retitled D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords from [clang-format] to [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords.
Tue, Sep 17, 7:53 AM · Restricted Project
MyDeveloperDay created D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords.
Tue, Sep 17, 7:51 AM · Restricted Project
MyDeveloperDay added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

when/if you commit can you abandon D6833: Clang-format: Braces Indent Style Whitesmith

Tue, Sep 17, 4:30 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D67627: Clang-format: Add Whitesmiths indentation style.
Tue, Sep 17, 4:25 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D67627: Clang-format: Add Whitesmiths indentation style.

Thank you for this patch

Tue, Sep 17, 4:25 AM · Restricted Project, Restricted Project

Mon, Sep 16

MyDeveloperDay retitled D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes from [clang-format] Fix C# breaking before function name when using Attributes to [clang-format] [PR43333] Fix C# breaking before function name when using Attributes.
Mon, Sep 16, 1:08 PM · Restricted Project, Restricted Project
MyDeveloperDay created D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes.
Mon, Sep 16, 1:02 PM · Restricted Project, Restricted Project

Thu, Sep 12

MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Yes, it would be good if it is landed. And can I know the procedure for getting commit access

Thu, Sep 12, 6:46 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Does this need landing? given that you have a number of patches in flight perhaps it would be good to request commit access

Thu, Sep 12, 6:32 AM · Restricted Project
MyDeveloperDay committed rG719087bbb775: [clang-format] [PR43100] clang-format C# support does not add a space between… (authored by MyDeveloperDay).
[clang-format] [PR43100] clang-format C# support does not add a space between…
Thu, Sep 12, 3:19 AM
MyDeveloperDay committed rG3867a2d51076: [clang-format] Add new style option IndentGotoLabels (authored by MyDeveloperDay).
[clang-format] Add new style option IndentGotoLabels
Thu, Sep 12, 3:07 AM

Tue, Sep 10

MyDeveloperDay accepted D67395: [clang-format] Apply BAS_AlwaysBreak to C++11 braced lists.

Thank you for this patch, i've seen a number of PRs raise to this effect.. this looks to be a great start in this area

Tue, Sep 10, 12:53 PM · Restricted Project, Restricted Project

Sat, Sep 7

MyDeveloperDay accepted D67037: [ClangFormat] Add new style option IndentGotoLabels.

This LGTM, just some minor Nits

Sat, Sep 7, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a project to D67037: [ClangFormat] Add new style option IndentGotoLabels: Restricted Project.
Sat, Sep 7, 5:02 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 2

MyDeveloperDay added a comment to D50147: clang-format: support external styles.

but perhaps I'm really just agreeing to @sammccall 's suggestion of "-style=<filename>" which kind of feels sufficient to me..

Mon, Sep 2, 9:28 AM · Restricted Project
MyDeveloperDay added a comment to D50147: clang-format: support external styles.

I am not opposed to this idea, I actually think this has some mileage based on a use case I've encountered:

Mon, Sep 2, 9:25 AM · Restricted Project

Mon, Aug 26

MyDeveloperDay updated the diff for D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren.
Mon, Aug 26, 8:41 AM · Restricted Project, Restricted Project

Aug 23 2019

MyDeveloperDay created D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren.
Aug 23 2019, 8:58 AM · Restricted Project, Restricted Project

Aug 22 2019

MyDeveloperDay accepted D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

LGTM

Aug 22 2019, 3:58 AM · Restricted Project

Aug 18 2019

MyDeveloperDay added a comment to D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs.

This patch is needs rebasing

Aug 18 2019, 2:43 AM · Restricted Project
MyDeveloperDay accepted D66384: [clang-format] Fix a bug that joins template closer and =.

LGTM

Aug 18 2019, 2:20 AM · Restricted Project, Restricted Project

Aug 16 2019

MyDeveloperDay accepted D66332: [clang-format] Fix the bug that joins template closer and > or >>.

LGTM

Aug 16 2019, 10:59 AM · Restricted Project

Aug 11 2019

MyDeveloperDay accepted D66059: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit.
Aug 11 2019, 5:13 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D66059: [clang-format] Expand AllowShortBlocksOnASingleLine for WebKit.

LGTM

Aug 11 2019, 5:13 AM · Restricted Project, Restricted Project

Aug 10 2019

MyDeveloperDay added inline comments to D65149: [Format] Add test demonstrating PR42722.
Aug 10 2019, 6:43 AM · Restricted Project

Aug 5 2019

MyDeveloperDay requested changes to D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments..
Aug 5 2019, 2:56 AM · Restricted Project
MyDeveloperDay accepted D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..
Aug 5 2019, 2:45 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Assuming this works and the other unit tests don't show issues then this LGTM. Please consider running this on your NetBSD code base before committing, if possible please also run on clang code based to ensure existing sorted headers aren't sorted unexpectedly.

Aug 5 2019, 2:45 AM · Restricted Project

Jul 24 2019

MyDeveloperDay added inline comments to D65043: [Format] Add C++20 standard to style options.
Jul 24 2019, 9:04 AM · Restricted Project
MyDeveloperDay requested changes to D65149: [Format] Add test demonstrating PR42722.
Jul 24 2019, 8:41 AM · Restricted Project
MyDeveloperDay added a comment to D65149: [Format] Add test demonstrating PR42722.

We don't normally commit a failing test alone, otherwise the build machines will be broken until it gets fixed.. just add this test with your fix.

Jul 24 2019, 8:41 AM · Restricted Project

Jul 15 2019

MyDeveloperDay added inline comments to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.
Jul 15 2019, 11:57 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

I appreciate what you've done to make this patch less duplicated code..but now you've almost got to the point where being able to control it all via configuration.

Jul 15 2019, 11:52 AM · Restricted Project
MyDeveloperDay added inline comments to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..
Jul 15 2019, 1:28 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

There also seems like alot of duplication between the existing sortCppIncludes

I think the only difference here is really just

SmallVector<unsigned, 16> Indices;
  SmallVector<unsigned, 16> Includes_p;
  for (unsigned i = 0, e = Includes.size(); i != e; ++i) {
    unsigned pl = getNetBSDIncludePriority(Includes[i].Filename);
    Includes_p.push_back(pl);
    Indices.push_back(i);
  }

vs the original

SmallVector<unsigned, 16> Indices;
for (unsigned i = 0, e = Includes.size(); i != e; ++i)
  Indices.push_back(i);

plus way the sorting is performed, are we sure we couldn't have just made the original sorting more powerful based on style settings?

Does it mean that adding the priority to sort based on style?
like this:

if (Style== NetBSD)
   // set priority to netbsd's priority
else if(Style == X)
  // set X's priority

I didn't want to mess up the original sorting and made up this patch, if we have parameterise this solution, I will go for it.

Jul 15 2019, 1:26 AM · Restricted Project

Jul 14 2019

MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

There also seems like alot of duplication between the existing sortCppIncludes

Jul 14 2019, 8:25 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category..

Do you think there is anything about this algorithm that could be parameterized so that other projects could utilize it? I guess its not completely clear how this differs from just using the IncludeCategories?

Jul 14 2019, 4:05 AM · Restricted Project

Jul 10 2019

MyDeveloperDay accepted D61001: [clang-format][tests] Explicitly specify style in some tests.
Jul 10 2019, 12:34 PM · Restricted Project

Jun 25 2019

MyDeveloperDay added a comment to D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.

It was more about not having time to pursue it at this time.. I didn't feel I should hog the PR if someone else wanted to take a look.

Jun 25 2019, 2:03 AM · Restricted Project

Jun 20 2019

MyDeveloperDay abandoned D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Jun 20 2019, 11:19 AM · Restricted Project
MyDeveloperDay abandoned D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Jun 20 2019, 11:18 AM · Restricted Project
MyDeveloperDay abandoned D59332: [clang-format] AlignConsecutiveDeclarations fails with attributes.
Jun 20 2019, 11:18 AM · Restricted Project
MyDeveloperDay abandoned D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted).
Jun 20 2019, 11:18 AM · Restricted Project, Restricted Project

Jun 13 2019

MyDeveloperDay added inline comments to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.
Jun 13 2019, 2:49 PM · Restricted Project

Jun 12 2019

MyDeveloperDay added a comment to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.

Nit: if you going for "OnePerLine" in the name rather than "Break" can you keep it consistent with ConstructorInitializerAllOnOneLineOrOnePerLine and put the type first and then the operation i.e. BitFieldOnePerLine (this will help keep all BitField options together if there are ever more than one), I also think either don't use Decl at all or use the full word Declarations as in AlignConsecutiveDeclarations , AlwaysBreakTemplateDeclarations etc

Jun 12 2019, 8:03 AM · Restricted Project

Jun 11 2019

MyDeveloperDay added a comment to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.

mark sure you mark off the comments as you consider them done.

Jun 11 2019, 6:03 AM · Restricted Project

Jun 10 2019

MyDeveloperDay requested changes to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.
Jun 10 2019, 12:49 PM · Restricted Project

Jun 9 2019

MyDeveloperDay requested changes to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.

You need to add a unit test in clang/unittests

Jun 9 2019, 2:46 PM · Restricted Project

May 21 2019

MyDeveloperDay added a comment to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..

Just a passing comment, Is this:

May 21 2019, 11:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 15 2019

MyDeveloperDay accepted D61281: [clang-format] Fixed self assignment.

LGTM

May 15 2019, 1:38 AM · Restricted Project

May 14 2019

MyDeveloperDay requested changes to D61281: [clang-format] Fixed self assignment.

please simply remove line 249

May 14 2019, 12:13 PM · Restricted Project

May 10 2019

MyDeveloperDay accepted D28462: clang-format: Add new style option AlignConsecutiveMacros.

@klimek responded via the mailing list

May 10 2019, 8:09 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

When I spoke with one of the code owners, they seemed to have a problem accepting this review based on there not being a general description/understanding of how this algorithm works.

May 10 2019, 3:30 AM · Restricted Project, Restricted Project

May 3 2019

MyDeveloperDay accepted D61276: [clang-format] Fix bug in block comment reflow that joins * and /.

LGTM

May 3 2019, 10:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D61281: [clang-format] Fixed self assignment.

Did this cause some issue? Does this fix something if so can we add a test, because maybe the line isn't needed

I would think we'd want to keep this as an identifier. we are just treating arg? the same as we would arg

@MyDeveloperDay didn't you write this code in D58404?

May 3 2019, 10:16 AM · Restricted Project

May 1 2019

MyDeveloperDay added inline comments to D58404: [clang-format] Add basic support for formatting C# files.
May 1 2019, 4:43 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations.

LGTM

May 1 2019, 4:43 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs.

Thanks for the patch, thanks also for changing to https as I believe this was a change suggested in clang tidy docs too

May 1 2019, 2:49 AM · Restricted Project
MyDeveloperDay added a comment to D61276: [clang-format] Fix bug in block comment reflow that joins * and /.

Thanks for the patch, is this case only limited to *<tab>

May 1 2019, 2:46 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D61281: [clang-format] Fixed self assignment.

Did this case some issue? Does this fix something if so can we add a test, because maybe the line isn't needed

May 1 2019, 2:45 AM · Restricted Project
MyDeveloperDay accepted D61297: [clang-format] Fix bug that misses some function-like macro usages.

LGTM

May 1 2019, 2:42 AM · Restricted Project, Restricted Project

Apr 27 2019

MyDeveloperDay accepted D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations.

LGTM

Apr 27 2019, 5:09 AM · Restricted Project, Restricted Project

Apr 23 2019

MyDeveloperDay accepted D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF.

This looks logical to me, seems to fit with what `WhitespaceManager::appendNewlineText` is doing

Apr 23 2019, 1:28 AM · Restricted Project

Apr 18 2019

MyDeveloperDay abandoned D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.

Abandoning in favor of D60853: clang-format converts a keyword macro definition to a macro function

Apr 18 2019, 3:15 AM · Restricted Project
MyDeveloperDay accepted D60853: clang-format converts a keyword macro definition to a macro function.
Apr 18 2019, 3:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60853: clang-format converts a keyword macro definition to a macro function.

LGTM

Apr 18 2019, 3:15 AM · Restricted Project, Restricted Project

Apr 17 2019

MyDeveloperDay added a comment to D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.

@klimek one possible solution to this might be to replace the "keyword" back to an identifier in a '#define <keywoord>' scenario

Apr 17 2019, 6:03 AM · Restricted Project

Apr 15 2019

MyDeveloperDay committed rGbd8a1ce7bbb9: [clang-format] [PR41170] Break after return type ignored with certain comments… (authored by MyDeveloperDay).
[clang-format] [PR41170] Break after return type ignored with certain comments…
Apr 15 2019, 12:46 AM

Apr 14 2019

MyDeveloperDay updated the diff for D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

use endsWith() as it ignored comments

Apr 14 2019, 5:28 AM · Restricted Project, Restricted Project

Apr 11 2019

MyDeveloperDay added a comment to D60151: [clang-tidy] Rename llvm checkers to llvm-project .

I suppose we could keep the names and directory structure and just change the namespace. That would just be a special case in the scripts. Haven't looked into it yet, but will do so as soon as I can.

Isn't that matching done on strings? I.e. is there difference between -llvm-* and -ll* ?

Apr 11 2019, 2:43 PM · Restricted Project
MyDeveloperDay added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

I agree and would be happy with the change if it would only change the line-filtered workflow, but this afaict (unless I'm missing something :) will also affect the workflow where the provided range is 0-length range, which has an implicit "format stuff around this" request from the user inside it. I'd be happy with a patch that differentiates these two sides.

Apr 11 2019, 9:10 AM · Restricted Project
MyDeveloperDay added a comment to D60151: [clang-tidy] Rename llvm checkers to llvm-project .

are we supporting "-llvm-*" in existing .clang-tidy files?

Apr 11 2019, 8:56 AM · Restricted Project

Apr 9 2019

MyDeveloperDay set the repository for D59332: [clang-format] AlignConsecutiveDeclarations fails with attributes to rC Clang.
Apr 9 2019, 12:33 AM · Restricted Project
MyDeveloperDay set the repository for D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present to rC Clang.
Apr 9 2019, 12:33 AM · Restricted Project
MyDeveloperDay set the repository for D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers to rC Clang.
Apr 9 2019, 12:32 AM · Restricted Project
MyDeveloperDay added a comment to D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

Please either subscribe the correct lists or set the correct repo in differential params.

Apr 9 2019, 12:32 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.
Apr 9 2019, 12:25 AM · Restricted Project, Restricted Project

Apr 8 2019

MyDeveloperDay planned changes to D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.
Apr 8 2019, 5:48 AM · Restricted Project
MyDeveloperDay updated the diff for D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

Addressing review comments
Reduce test cases

Apr 8 2019, 5:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

+1 to quite some overlap in the tests. I'd have expected three test cases:

  1. ; line comment
  2. ; C-comment
  3. no semi
Apr 8 2019, 3:57 AM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.

@ownenpan might be worth checking with @reuk who has been adding some options for the JUCE style guide and looking at the JUCE code it seems this style might match their style.

Apr 8 2019, 3:53 AM · Restricted Project
MyDeveloperDay added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

I believe there is no such thing as an "short else statement". The else is part of the if statement and if it is present, I don't consider the whole if statement short. As such, IMO the bug is invalid.

Apr 8 2019, 2:08 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.
Apr 8 2019, 2:02 AM · Restricted Project

Apr 7 2019

MyDeveloperDay accepted D60374: clang-format incorrectly indents wrapped closing parenthesis.
Apr 7 2019, 1:50 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60374: clang-format incorrectly indents wrapped closing parenthesis.

LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough

Thanks! I just got the alternative patch ready. Should I discard it and just commit this one?

Apr 7 2019, 1:27 PM · Restricted Project, Restricted Project