Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (283 w, 3 d)
Roles
Administrator

Recent Activity

Tue, Jan 19

MyDeveloperDay added a comment to D94891: [Coroutine] Remain alignment information when merging frame variables.

Thanks for explaining! I visited the his profile. It is really confusing.

Tue, Jan 19, 1:36 AM · Restricted Project
MyDeveloperDay updated subscribers of D94891: [Coroutine] Remain alignment information when merging frame variables.
Tue, Jan 19, 1:21 AM · Restricted Project
MyDeveloperDay updated subscribers of D94891: [Coroutine] Remain alignment information when merging frame variables.
Tue, Jan 19, 1:20 AM · Restricted Project
MyDeveloperDay added a comment to D94891: [Coroutine] Remain alignment information when merging frame variables.

@231084fg may I ask why you remove the reviews for the patch?

Tue, Jan 19, 1:18 AM · Restricted Project

Mon, Jan 18

MyDeveloperDay planned changes to D93528: [clang-format] Add basic support for formatting JSON.
Mon, Jan 18, 10:10 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay planned changes to D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.
Mon, Jan 18, 10:10 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D94906: [clang-format] Apply Allman style to lambdas.
Mon, Jan 18, 10:09 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D94906: [clang-format] Apply Allman style to lambdas.

Similarly I see users having to define everything just to turn one thing off

Mon, Jan 18, 10:08 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D94906: [clang-format] Apply Allman style to lambdas.

I think this is LGTM, however..

Mon, Jan 18, 10:07 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

What I can't easily tell from the tests is if you are overriding any styles defined in the parent with a local style.

Mon, Jan 18, 2:38 AM · Unknown Object (Project), Unknown Object (Project)

Sun, Jan 17

MyDeveloperDay requested changes to D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration.

I think the revision whilst it does what is needed to structs doesn't address the many other times this forms appear. I think we need something a little more extensive. It can't just be when a line starts with struct

Sun, Jan 17, 3:22 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D92257: [clang-format] Add option to control the space at the front of a line comment.
Sun, Jan 17, 3:20 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D91950: [clang-format] Add BreakBeforeInlineASMColon configuration.
Sun, Jan 17, 3:18 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reviewer for D94661: [clang-format] [PR19056] Add support for access modifiers indentation: curdeius.
Sun, Jan 17, 3:17 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Sun, Jan 17, 3:17 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D93776: [clang-format] Add StatementAttributeLikeMacros option.

Please address the "not done" comment (regarding the sorting), but other than that its LGTM

Sun, Jan 17, 3:16 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay committed rG00dc97f16708: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates (authored by MyDeveloperDay).
[clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates
Sun, Jan 17, 3:15 AM
MyDeveloperDay closed D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.
Sun, Jan 17, 3:15 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario.

Sorry but due to the following issue raised by @RatTac , I'm reverting this prior to the LLVM 12 branch out so I can work on it further.

Sun, Jan 17, 3:11 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reverting change for rGe9e6e3b34a8e: [clang-format] Add IndentPragma style to eliminate common clang-format off…: rG9af03864df74: [clang-format] Revert e9e6e3b34a8e.
Sun, Jan 17, 3:09 AM
MyDeveloperDay committed rG9af03864df74: [clang-format] Revert e9e6e3b34a8e (authored by MyDeveloperDay).
[clang-format] Revert e9e6e3b34a8e
Sun, Jan 17, 3:09 AM
MyDeveloperDay added a reverting change for D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario: rG9af03864df74: [clang-format] Revert e9e6e3b34a8e.
Sun, Jan 17, 3:09 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 17, 3:00 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Thank you for changing the dump_style to make this clearer

Sun, Jan 17, 2:58 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Thie LGTM, just to check a few nits

Sun, Jan 17, 2:54 AM · Unknown Object (Project), Unknown Object (Project)

Thu, Jan 14

MyDeveloperDay added inline comments to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Thu, Jan 14, 12:00 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D92257: [clang-format] Add option to control the space at the front of a line comment.

My assumption is that you want to stick with the minimum and maximum is that correct?

Thu, Jan 14, 1:53 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Thu, Jan 14, 1:48 AM · Unknown Object (Project), Unknown Object (Project)

Wed, Jan 13

MyDeveloperDay added inline comments to D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.
Wed, Jan 13, 10:59 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reviewer for D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser: curdeius.
Wed, Jan 13, 10:55 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Wed, Jan 13, 10:53 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

I think I would remove the code examples from the "AlignConsecutive style" to avoid confusion (that would be the first change)

Wed, Jan 13, 4:30 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay accepted D93938: [clang-format] Fixed AfterEnum handling.

LGTM

Wed, Jan 13, 1:18 AM · Unknown Object (Project), Unknown Object (Project)

Sun, Jan 10

MyDeveloperDay accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

This LGTM

Sun, Jan 10, 8:04 AM · Unknown Object (Project), Unknown Object (Project)

Thu, Jan 7

MyDeveloperDay added a comment to rGe9e6e3b34a8e: [clang-format] Add IndentPragma style to eliminate common clang-format off….

@RatTac Would you please consider copying the comment onto the review D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario and not the commit, I have a reply but don't want to write it here.

Thu, Jan 7, 7:00 AM

Tue, Jan 5

MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Tue, Jan 5, 3:50 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Tue, Jan 5, 2:34 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

Thank you for submitting this patch?

Tue, Jan 5, 2:32 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Tue, Jan 5, 1:27 AM · Unknown Object (Project), Unknown Object (Project)

Mon, Jan 4

MyDeveloperDay accepted D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

This LGTM, I'm not sure if others have any further comments

Mon, Jan 4, 8:31 AM · Unknown Object (Project), Unknown Object (Project)

Sun, Jan 3

MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 10:53 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93938: [clang-format] Fixed AfterEnum handling.
Sun, Jan 3, 1:27 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D93938: [clang-format] Fixed AfterEnum handling.

I'm sorry, but now you are missing the files from the review, I think you diffing against your own commits and not commit that are in the repo. This makes the review very difficult to understand.

Sun, Jan 3, 12:36 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 12:26 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

we don't commit with failing tests so lets understand why it fails.

Sun, Jan 3, 12:20 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 9:30 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added reviewers for D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments: HazardyKnusperkeks, JakeMerdichAMD, klimek.
Sun, Jan 3, 9:27 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments.

by and large, this looks pretty good to me..

Sun, Jan 3, 9:27 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay retitled D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments from [format] Add the possibility to align assignments spanning empty lines or comments to [clang-format] Add the possibility to align assignments spanning empty lines or comments.
Sun, Jan 3, 9:22 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93938: [clang-format] Fixed AfterEnum handling.
Sun, Jan 3, 6:39 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

You need to have these conversations by adding new unit tests that prove your point, I highly doubt I'll personally be willing to accept any revision without more unit tests than this one line change

Sun, Jan 3, 6:34 AM · Unknown Object (Project), Unknown Object (Project)

Sat, Jan 2

MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I think we are missing some clarity in this bug as to what the actual problem is, I do agree the test looks wrong,

Sat, Jan 2, 3:09 AM · Unknown Object (Project), Unknown Object (Project)

Fri, Jan 1

MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Fri, Jan 1, 10:15 AM · Unknown Object (Project), Unknown Object (Project)

Thu, Dec 31

MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Thu, Dec 31, 7:11 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

ok so this looks ok, but before we commit can we have a discussion about why you think it fails for the comment case?

Thu, Dec 31, 7:05 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested changes to D93938: [clang-format] Fixed AfterEnum handling.
Thu, Dec 31, 7:04 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

Take the following example:

Thu, Dec 31, 7:04 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I think if you think you have a bug that you log it in the bug tracker and we track it with this issue.

Thu, Dec 31, 6:56 AM · Unknown Object (Project), Unknown Object (Project)

Wed, Dec 30

MyDeveloperDay updated the diff for D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.

Address review comments

Wed, Dec 30, 2:50 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Wed, Dec 30, 2:34 AM · Unknown Object (Project), Unknown Object (Project)

Tue, Dec 29

MyDeveloperDay added a comment to rGc5c487f0d4c6: Revert "[clang-format] Add option to specify explicit config file" There were a….

@mitchell-stellar do you plan to bring this back?

Tue, Dec 29, 2:50 PM
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Tue, Dec 29, 3:45 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

I like what you are suggesting, do you think BasedOnStyle: File is the best terminology as the term File is used elsewhere to mean read from the .clang_format file, how about

Tue, Dec 29, 3:42 AM · Unknown Object (Project), Unknown Object (Project)

Mon, Dec 28

MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Mon, Dec 28, 9:25 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.
Mon, Dec 28, 7:29 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added inline comments to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Mon, Dec 28, 7:28 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay updated the diff for D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.

Addressing additional usecase found issues in C# tests too

Mon, Dec 28, 6:44 AM · Unknown Object (Project), Unknown Object (Project)

Sun, Dec 27

MyDeveloperDay added a comment to D93844: [clang-format] Add possibility to be based on parent directory.

I'm a little confused why this is needed as clang-format always read up the directory tree until it see a .clang-format file, perhaps I don't quite understand the use case. Can't you just have a different .clang-format in the subdirectory?

Sun, Dec 27, 2:21 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay retitled D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier from Add flag to suppress empty line insertion before access modifier to [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.
Sun, Dec 27, 2:19 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier.

Thank you for this patch, a few process issues.

Sun, Dec 27, 2:17 PM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a reviewer for D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates: JohelEGP.
Sun, Dec 27, 7:29 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay requested review of D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates.
Sun, Dec 27, 7:29 AM · Unknown Object (Project), Unknown Object (Project)

Sat, Dec 26

MyDeveloperDay committed rGc7dcc4c72588: [clang-format] PR48569 clang-format fails to align case label with `switch`… (authored by MyDeveloperDay).
[clang-format] PR48569 clang-format fails to align case label with `switch`…
Sat, Dec 26, 7:19 AM
MyDeveloperDay closed D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation.
Sat, Dec 26, 7:19 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation.

This is the closest I could find thus far http://bitsavers.informatik.uni-stuttgart.de/pdf/chromatics/CGC_7900_C_Programmers_Manual_Mar82.pdf

Sat, Dec 26, 4:13 AM · Unknown Object (Project), Unknown Object (Project)

Thu, Dec 24

MyDeveloperDay requested review of D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation.
Thu, Dec 24, 8:41 AM · Unknown Object (Project), Unknown Object (Project)

Wed, Dec 23

MyDeveloperDay accepted D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle.
Wed, Dec 23, 9:50 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle.

I don't have any major issues with this other than it makes Format.h a bit more ugly. (there are more ugly and harder to understand pieces of code than this change!)

Wed, Dec 23, 8:07 AM · Unknown Object (Project)
MyDeveloperDay committed rG031743cb5b3c: [clang-format] PR48539 ReflowComments breaks Qt translation comments (authored by MyDeveloperDay).
[clang-format] PR48539 ReflowComments breaks Qt translation comments
Wed, Dec 23, 6:46 AM
MyDeveloperDay committed rG5426b2f9ed9f: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style… (authored by MyDeveloperDay).
[clang-format] PR48535 clang-format Incorrectly Removes Space After C Style…
Wed, Dec 23, 6:46 AM
MyDeveloperDay closed D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.
Wed, Dec 23, 6:45 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay closed D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.
Wed, Dec 23, 6:45 AM · Unknown Object (Project), Unknown Object (Project)
MyDeveloperDay added a comment to D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle.

We should probably check the docs/tools/dump_format_style.py still works

Wed, Dec 23, 6:02 AM · Unknown Object (Project)

Dec 22 2020

MyDeveloperDay accepted D93633: [format] Add overload to parseConfiguration that accept llvm::MemoryBufferRef.

LGTM

Dec 22 2020, 6:43 AM · Unknown Object (Project)
MyDeveloperDay added a comment to D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.

LGTM now. I tried to find other cases where this change may change the behaviour but couldn't. Have you tried applying to some bigger repo and see what you get? The best would be a repo with SpaceAfterCStyleCast=true.

Dec 22 2020, 6:37 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGc4fc8a21d1db: [clang-format] NFC keep the code clang-formatted (authored by MyDeveloperDay).
[clang-format] NFC keep the code clang-formatted
Dec 22 2020, 4:46 AM
MyDeveloperDay updated the diff for D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.

remove = and ~ cases

Dec 22 2020, 4:44 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.

remove unrelated change

Dec 22 2020, 4:36 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.
Dec 22 2020, 4:35 AM · Restricted Project, Restricted Project

Dec 21 2020

MyDeveloperDay requested review of D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer.
Dec 21 2020, 3:48 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.
Dec 21 2020, 2:21 AM · Restricted Project, Restricted Project

Dec 19 2020

MyDeveloperDay accepted D87587: [clang-format][PR47290] Add ShortNamespaceLines format option.

Thanks for making the changes, this LGTM

Dec 19 2020, 9:28 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D93240: [clang-format] Add SpaceBeforeCaseColon option.
Dec 19 2020, 6:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93528: [clang-format] Add basic support for formatting JSON.

With my maintainer-of-Support/JSON hat on, I don't like the idea of these features being shoehorned into the library to make clang-format an incrementally more featureful JSON formatter. They're likely to lead to a lot of conceptual+implementation+API complexity in a library that solves its primary use cases quite well and simply.

Dec 19 2020, 5:48 AM · Restricted Project, Restricted Project

Dec 18 2020

MyDeveloperDay added a comment to D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.

Maybe @JVApen can help as they logged https://bugs.llvm.org/show_bug.cgi?id=48539

Dec 18 2020, 7:11 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93528: [clang-format] Add basic support for formatting JSON.

Why not using clang-format's support for JavaScript? It seems more complicated now, but it will probably allow to more easily change/add style options. WDYT?
And what happens when reformatting only a part of a JSON? Should there be some tests for that?

Dec 18 2020, 6:19 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D93528: [clang-format] Add basic support for formatting JSON.
Dec 18 2020, 3:34 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D93528: [clang-format] Add basic support for formatting JSON.
Dec 18 2020, 2:32 AM · Restricted Project, Restricted Project

Dec 17 2020

MyDeveloperDay requested review of D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments.
Dec 17 2020, 1:20 PM · Restricted Project, Restricted Project
MyDeveloperDay accepted D93459: Fix -Wno-error= parsing in clang-format..

LGTM

Dec 17 2020, 12:19 PM · Restricted Project, Restricted Project