I appreciate what you've done to make this patch less duplicated code..but now you've almost got to the point where being able to control it all via configuration.

In D64695#1584740, @Manikishan wrote:

In D64695#1584706, @MyDeveloperDay wrote:

There also seems like alot of duplication between the existing sortCppIncludes

I think the only difference here is really just

SmallVector<unsigned, 16> Indices;
  SmallVector<unsigned, 16> Includes_p;
  for (unsigned i = 0, e = Includes.size(); i != e; ++i) {
    unsigned pl = getNetBSDIncludePriority(Includes[i].Filename);
    Includes_p.push_back(pl);
    Indices.push_back(i);
  }

vs the original

SmallVector<unsigned, 16> Indices;
for (unsigned i = 0, e = Includes.size(); i != e; ++i)
  Indices.push_back(i);

plus way the sorting is performed, are we sure we couldn't have just made the original sorting more powerful based on style settings?

Does it mean that adding the priority to sort based on style?
like this:

if (Style== NetBSD)
   // set priority to netbsd's priority
else if(Style == X)
  // set X's priority

I didn't want to mess up the original sorting and made up this patch, if we have parameterise this solution, I will go for it.

There also seems like alot of duplication between the existing sortCppIncludes

Do you think there is anything about this algorithm that could be parameterized so that other projects could utilize it? I guess its not completely clear how this differs from just using the IncludeCategories?

It was more about not having time to pursue it at this time.. I didn't feel I should hog the PR if someone else wanted to take a look.

Nit: if you going for "OnePerLine" in the name rather than "Break" can you keep it consistent with ConstructorInitializerAllOnOneLineOrOnePerLine and put the type first and then the operation i.e. BitFieldOnePerLine (this will help keep all BitField options together if there are ever more than one), I also think either don't use Decl at all or use the full word Declarations as in AlignConsecutiveDeclarations , AlwaysBreakTemplateDeclarations etc

mark sure you mark off the comments as you consider them done.

You need to add a unit test in clang/unittests

Just a passing comment, Is this:

LGTM

please simply remove line 249

@klimek responded via the mailing list

When I spoke with one of the code owners, they seemed to have a problem accepting this review based on there not being a general description/understanding of how this algorithm works.

LGTM

In D61281#1488022, @RKSimon wrote:

In D61281#1485833, @MyDeveloperDay wrote:

Did this cause some issue? Does this fix something if so can we add a test, because maybe the line isn't needed

I would think we'd want to keep this as an identifier. we are just treating arg? the same as we would arg

@MyDeveloperDay didn't you write this code in D58404?

LGTM

Thanks for the patch, thanks also for changing to https as I believe this was a change suggested in clang tidy docs too

Thanks for the patch, is this case only limited to *<tab>

Did this case some issue? Does this fix something if so can we add a test, because maybe the line isn't needed

LGTM

LGTM

This looks logical to me, seems to fit with what `WhitespaceManager::appendNewlineText` is doing

Abandoning in favor of D60853: clang-format converts a keyword macro definition to a macro function

LGTM

@klimek one possible solution to this might be to replace the "keyword" back to an identifier in a '#define <keywoord>' scenario

use endsWith() as it ignored comments

I suppose we could keep the names and directory structure and just change the namespace. That would just be a special case in the scripts. Haven't looked into it yet, but will do so as soon as I can.

Isn't that matching done on strings? I.e. is there difference between -llvm-* and -ll* ?

I agree and would be happy with the change if it would only change the line-filtered workflow, but this afaict (unless I'm missing something :) will also affect the workflow where the provided range is 0-length range, which has an implicit "format stuff around this" request from the user inside it. I'd be happy with a patch that differentiates these two sides.

are we supporting "-llvm-*" in existing .clang-tidy files?

In D60363#1459297, @lebedev.ri wrote:

Please either subscribe the correct lists or set the correct repo in differential params.

Addressing review comments
Reduce test cases

In D60363#1458034, @klimek wrote:

+1 to quite some overlap in the tests. I'd have expected three test cases:

1. ; line comment
2. ; C-comment
3. no semi

@ownenpan might be worth checking with @reuk who has been adding some options for the JUCE style guide and looking at the JUCE code it seems this style might match their style.

In D59087#1456129, @krasimir wrote:

I believe there is no such thing as an "short else statement". The else is part of the if statement and if it is present, I don't consider the whole if statement short. As such, IMO the bug is invalid.

In D60374#1457705, @owenpan wrote:

In D60374#1457693, @MyDeveloperDay wrote:

LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough

Thanks! I just got the alternative patch ready. Should I discard it and just commit this one?

LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough

maybe add the following as a test because I think it shows the inconsistency

LGTM (minor nit)

In D60320#1457568, @reuk wrote:

I updated ClangFormatStyleOptions.rst by hand, is there a way to do that automatically instead (for future patches)?

@owenpan can I help you bring this back up to date and review, I think I saw another issue in the bugzilla requesting this.

Thanks for doing this, it LGTM, I like your solution better ;-)

I actually also tend to change doc/ClangFormatStyleOptions.rst too

just a few nits, apart form that it LG

friendly ping

friendly ping

In D59932#1446533, @JonasToth wrote:

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

We normally add something to the documentation about the checker and/or the release notes to say what had changed

LGTM

@lebedev.ri Are we talking about a general ideology of the long term cost to allow any new things in? or to not allow things in this specific case?

Address comment nits

LGTM

Addressing Review Comments

• Remove all non Format only code (i.e. changes to clang/Basic and clang/Lexer to support verbatim interpolated strings C# 6)
• For the most part the need to for them is removed by merging of tokens during the FormatLexer phase
• There is one obscure failure scenario, but for a first pass I think it can be ignored (tests commented out) where a \ is used unescaped just before a " (because of paths can be more common than you think)
  • string s = @"ABC\" + ToString("B");";

The cost is financial, as it's developer time, which costs real money to companies. In the end, to support this, people like myself who are doing this as part of their job spend time that they'd otherwise spend to make other things better that might be more important.

Sorry for the spam:

• write this a little better

Addressing code review comment

@klimek I think is what you meant, a much smaller and neater version of what I had before.