Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (178 w, 6 d)

Recent Activity

Today

MyDeveloperDay added a project to D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️: Restricted Project.
Mon, Jan 21, 12:49 AM · Restricted Project

Yesterday

MyDeveloperDay added a project to D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods: Restricted Project.
Sun, Jan 20, 7:42 AM · Restricted Project

Sat, Jan 19

MyDeveloperDay accepted D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.

LGTM

Sat, Jan 19, 2:39 AM · Restricted Project

Fri, Jan 18

MyDeveloperDay added a comment to D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.

the closest I can see is

Fri, Jan 18, 12:21 PM · Restricted Project
MyDeveloperDay added inline comments to D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.
Fri, Jan 18, 12:12 PM · Restricted Project
MyDeveloperDay added inline comments to D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.
Fri, Jan 18, 6:36 AM
MyDeveloperDay abandoned D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.

Abandoning revision on the basis of perhaps going for a more clang-tidy only directed error message.

Fri, Jan 18, 6:36 AM
MyDeveloperDay added a comment to D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.

Where does this problem come from?

Fri, Jan 18, 6:33 AM
MyDeveloperDay added a comment to D54141: [clang-tidy] add deduplication support for run-clang-tidy.py.

LLVM is very chatty as well, I don't consider LLVM to be a bad code-base. Take readability-braces-around-statements for example.

Fri, Jan 18, 3:56 AM · Restricted Project
MyDeveloperDay abandoned D56882: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.

Abandoning...recreated as D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments

Fri, Jan 18, 1:08 AM
MyDeveloperDay created D56901: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.
Fri, Jan 18, 1:08 AM

Thu, Jan 17

MyDeveloperDay created D56882: [Support] Fix Windows Command Shell Command line parsing for quoted arguments.
Thu, Jan 17, 3:25 PM

Wed, Jan 16

MyDeveloperDay added a comment to D56424: [clang-tidy] Add check for underscores in googletest names..

Hi all, ping on this patch. I've addressed all comments to the best of my ability. Is there anything outstanding that needs to be changed?

Round about this time of a review we normally hear @JonasToth asking if you've run this on a large C++ code base like LLVM (with fix-its), and seen if the project still builds afterwards..might be worth doing that ahead of time if you haven't done so already

From docs: This check does not propose any fixes..

Thats a great suggestion for the future then.... transform

TEST(TestCase_Name, Test_Name) {}

into

TEST(TestCaseName, TestName) {}

I considered doing this for the check, but decided against it based on the cases in which I've seen underscores in use. I've seen a few cases in the style of this:

SuccessfullyWrites_InfiniteDeadline
SuccessfullyWrites_DefaultDeadline

changing these to:

SuccessfullyWritesInfiniteDeadline
SuccessfullyWritesDefaultDeadline

has a subtle difference to the reader. In the first case, underscore functions like "with", whereas in the fix it sounds like the test is for writing the deadline.

While removing the underscore does seem to work for a large portion of the cases, based on the cases like that above, I didn't think it was appropriate to make these modifications.

Please let me know what you think.

Wed, Jan 16, 1:12 PM · Restricted Project

Tue, Jan 15

MyDeveloperDay added a comment to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.
Tue, Jan 15, 11:34 AM · Restricted Project
MyDeveloperDay updated the diff for D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.

Addressing review comment

Tue, Jan 15, 11:34 AM · Restricted Project
MyDeveloperDay added a comment to D56424: [clang-tidy] Add check for underscores in googletest names..

Hi all, ping on this patch. I've addressed all comments to the best of my ability. Is there anything outstanding that needs to be changed?

Round about this time of a review we normally hear @JonasToth asking if you've run this on a large C++ code base like LLVM (with fix-its), and seen if the project still builds afterwards..might be worth doing that ahead of time if you haven't done so already

From docs: This check does not propose any fixes..

Tue, Jan 15, 12:15 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

I do not have commit rights. I'm not sure what constitutes someone who can commit, but let me contribute a little more before taking that step, I have another idea for a checker I'd like to try after this one, I just wanted to get one under my belt first.

See this: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

I will commit for you then. More patches always welcome ;)

Tue, Jan 15, 12:12 AM · Restricted Project
MyDeveloperDay added a comment to D56424: [clang-tidy] Add check for underscores in googletest names..

Hi all, ping on this patch. I've addressed all comments to the best of my ability. Is there anything outstanding that needs to be changed?

Tue, Jan 15, 12:06 AM · Restricted Project

Mon, Jan 14

MyDeveloperDay added inline comments to D55523: [clang-tidy] Linting .rst documentation.
Mon, Jan 14, 1:16 AM · Restricted Project
MyDeveloperDay updated the diff for D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.

Fix review comments

Mon, Jan 14, 12:02 AM · Restricted Project

Sun, Jan 13

MyDeveloperDay added a project to D56644: [clang-tidy] readability-container-size-empty handle std::string length(): Restricted Project.
Sun, Jan 13, 5:44 AM · Restricted Project

Fri, Jan 11

MyDeveloperDay added a comment to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.

I think will be good idea to create generic Case/Prefix/Suffix description to reduce size of documentation.

Fri, Jan 11, 2:02 AM · Restricted Project
MyDeveloperDay updated the diff for D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.

Address review comments

  • clang-format the code examples
  • replace "ensure" with "check"
Fri, Jan 11, 1:54 AM · Restricted Project

Thu, Jan 10

MyDeveloperDay created D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.
Thu, Jan 10, 2:56 PM · Restricted Project
MyDeveloperDay added a comment to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

nit's come from running running validate_check.py on the rst file from D55523: [clang-tidy] Linting .rst documentation

Thu, Jan 10, 9:43 AM · Restricted Project
MyDeveloperDay created D56536: [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker.
Thu, Jan 10, 3:17 AM
MyDeveloperDay updated the diff for D55523: [clang-tidy] Linting .rst documentation.

Addressing some formatting review comments

  • add ability to run with --rst to perform on a single .rst file (useful for validating docs not in clang-tidy)
  • add ability to ignore the 80 character rulles (with -no-maximize), (some of the other documentation has lots of this violations and we might want to fix the obvious checks first)
Thu, Jan 10, 2:08 AM · Restricted Project
MyDeveloperDay added a comment to rCTE350765: [clang-tidy] another take at fixing doc.

Thanks @JonasToth for the help (again) and sorry to break the build like that.

Thu, Jan 10, 1:31 AM

Wed, Jan 9

MyDeveloperDay added a comment to rCTE350765: [clang-tidy] another take at fixing doc.

I'd like to understand what went wrong here? is it just the missing tabs then 80 characters?

Wed, Jan 9, 1:41 PM
MyDeveloperDay added a comment to rCTE350761: [clang-tidy] fix-up failing tests.

@JonasToth thanks...

Wed, Jan 9, 1:16 PM
MyDeveloperDay added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..

In a later change it might be worth mentioning...

Wed, Jan 9, 12:38 PM
MyDeveloperDay added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..

! In D56482#1350874, @kristina wrote:

I only added a section, all the warnings are from existing bits below. Not sure if it's a good idea to reformat it as part of the diff as it will make it harder to see the added section. Can do it afterwards but that's what's currently being used to generate documentation.

Wed, Jan 9, 12:14 PM
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

LGTM!
You verified that your fixes, fix the issues in LLVM? But it looks good to go.

Wed, Jan 9, 6:54 AM · Restricted Project
MyDeveloperDay abandoned D55594: [clang-tidy] update readability-* and zircon-* check documentation to remove extraneous characters.
Wed, Jan 9, 2:26 AM · Restricted Project
MyDeveloperDay planned changes to D55523: [clang-tidy] Linting .rst documentation.
Wed, Jan 9, 2:26 AM · Restricted Project
MyDeveloperDay added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..

$ ./validate_check.py --rst ../../../../../docs/Phabricator.rst
Checking ..\..\..\..\..\docs\Phabricator.rst...
warning: line 97 multiple blank lines
warning: line 166 is in excess of 80 characters (82) : as it will retrieve reviewers, the `Differential Revision`, etc from the review
...
warning: line 175 contains double spaces
warning: line 188 is in excess of 80 characters (97) : The first command will take the latest version of the reviewed patch and apply it to the working
...
warning: line 194 is in excess of 80 characters (111) : This presumes that the git repository has been configured as described in :ref:developers-work-with-git-svn.
...
warning: line 203 multiple blank lines
warning: line 205 is in excess of 80 characters (84) : current `master and will create a commit corresponding to D<Revision>` with a
...
warning: line 208 is in excess of 80 characters (85) : Check you are happy with the commit message and amend it if necessary. Now switch to
...
warning: line 218 multiple blank lines
warning: line 219 multiple blank lines

Wed, Jan 9, 2:22 AM
MyDeveloperDay added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Wed, Jan 9, 1:49 AM · Restricted Project
MyDeveloperDay added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Wed, Jan 9, 1:40 AM · Restricted Project

Tue, Jan 8

MyDeveloperDay added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Tue, Jan 8, 10:39 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

No problem, thats why we test on real projects first, because there is always something hidden in C++ :)

Is there a test for the lambdas?

Tue, Jan 8, 10:29 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Address review comments

  • add more lambda tests
  • add nested lambda test
  • remove hasParent() call, (seems isConversionOperator()) seems to detect the CXXMethodsDecls within a lambda that were causing [[nodiscard]] to be added before the []{... )
Tue, Jan 8, 9:43 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

No problem, thats why we test on real projects first, because there is always something hidden in C++ :)

Is there a test for the lambdas?

Tue, Jan 8, 8:41 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

No problem, thats why we test on real projects first, because there is always something hidden in C++ :)

Is there a test for the lambdas?

Tue, Jan 8, 8:28 AM · Restricted Project
MyDeveloperDay added inline comments to D56160: [clang-tidy] modernize-use-trailing-return check.
Tue, Jan 8, 3:59 AM · Restricted Project
MyDeveloperDay added inline comments to D56160: [clang-tidy] modernize-use-trailing-return check.
Tue, Jan 8, 3:39 AM · Restricted Project
MyDeveloperDay added inline comments to D56160: [clang-tidy] modernize-use-trailing-return check.
Tue, Jan 8, 2:01 AM · Restricted Project
MyDeveloperDay added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Tue, Jan 8, 1:53 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Sorry to add another revision but, rerunning no-discard checker on LLVM code base threw up other [[nodiscard]] placements which whilst they MAY be correct, I don't think we should handle in this first pass.

  • conversion functions e.g. operator bool()
  • lambdas
  • add tests to validate both
Tue, Jan 8, 1:40 AM · Restricted Project

Sun, Jan 6

MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

libprotobuf still builds cleanly with just the one expected warning..despite adding over 500 [[nodiscards]]

Sun, Jan 6, 6:48 AM · Restricted Project

Fri, Jan 4

MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Fri, Jan 4, 10:07 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Update with view comments from @JonasToth

  • remove unnecessary static functions
  • move checks into matchers
  • remove duplicated diag call
Fri, Jan 4, 10:02 AM · Restricted Project
MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Fri, Jan 4, 4:39 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Address review comments

  • remove using strings to locate std::function and boost::function arguments using matcher with `hasAnyName()` instead
  • add tests to check for const, const & for above
Fri, Jan 4, 2:59 AM · Restricted Project

Thu, Jan 3

MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

let me look further into that, it works for std::function but not for const std::function or std::function &, const std::function &

Thu, Jan 3, 11:10 AM · Restricted Project
MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Thu, Jan 3, 7:25 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Rebase

  • update to address most review comments from @JonasToth
  • simplify matcher (with less unless)
  • remove the need to look for "type-parameter-" string
Thu, Jan 3, 7:23 AM · Restricted Project

Sun, Dec 23

MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
  • Rebase
  • Add a couple of extra test cases to ensure we don't add the NO_DISCARD macro when a clang or gcc attribute is present
  • Ping to ask code owners to review and possibly commit if happy.
Sun, Dec 23, 7:22 AM · Restricted Project

Dec 18 2018

MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Remove unused matcher variable

Dec 18 2018, 6:20 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

LGTM.
Any ideas for improvement, @JonasToth?
I'd rather have it merged and improve on it later if there are ideas on how to do it better.

Dec 18 2018, 6:17 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Fix review comments

  • Fix minor spelling mistakes
  • add additional boost::function unit test
Dec 18 2018, 6:15 AM · Restricted Project

Dec 15 2018

MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

-Refactor the checker to remove the llvm::any_of by using a QualType ast-matcher with hasAnyParameter(hasType(x))

  • i.e. ...unless(hasAnyParameter(hasType(isNonConstReferenceOrPointer())))...
Dec 15 2018, 8:06 AM · Restricted Project
MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 15 2018, 5:02 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
  • Rebase
  • Reduce false-positives by not adding [[nodiscard]] to functions if the class has mutable fields (removed as known issues) and add tests
Dec 15 2018, 4:27 AM · Restricted Project

Dec 14 2018

MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 14 2018, 4:54 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Fix review comments

  • minor changes to code comments
  • add more unit tests for typedef'd template types
Dec 14 2018, 4:26 AM · Restricted Project

Dec 13 2018

MyDeveloperDay updated subscribers of D55523: [clang-tidy] Linting .rst documentation.

I think will be good idea to rename script to validate_documentation.py. Or may be lint?

Dec 13 2018, 2:19 PM · Restricted Project
MyDeveloperDay retitled D55523: [clang-tidy] Linting .rst documentation from [clang-tidy] Looking for feedback on add_new_check.py functionality to [clang-tidy] Linting .rst documentation.
Dec 13 2018, 1:56 PM · Restricted Project
MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 13 2018, 1:21 PM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Add additional constraints on member functions

  • do not add [[nodiscard]] to variadic function
  • do not add [[nodiscard]] to std::function templates argument functions
  • do not add [[nodiscard]] to functions returning template types
  • add unit test to ensure above
Dec 13 2018, 1:17 PM · Restricted Project
MyDeveloperDay added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 13 2018, 11:56 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Addressing review comments

  • don't add [[nodiscard]] onto function taking template arguments
  • add more unit tests to cover other discard possibilities [[clang::warn_unused_result]],[[gcc::warn_unused_result]]
  • improve the documentation to help explain when the [[nodiscard]] will/will not be applied
Dec 13 2018, 11:54 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
unsigned BlockOrCode = 0;
llvm::ErrorOr<Cursor> Res = skipUntilRecordOrBlock(Stream, BlockOrCode);
if (!Res)
  Res.getError();

AFAIK llvm::Error must be consumed because if it goes out of scope unhandled it will assert. Not sure how to handle that.

Dec 13 2018, 9:49 AM · Restricted Project

Dec 12 2018

MyDeveloperDay updated the diff for D55523: [clang-tidy] Linting .rst documentation.

Address review comments

Dec 12 2018, 10:44 AM · Restricted Project
MyDeveloperDay added a comment to D55594: [clang-tidy] update readability-* and zircon-* check documentation to remove extraneous characters.

I thought I would just correct readability-* and zircon-* to get some feedback if you think this is improving the documentation the way you think it should, if this is OK I can follow up with the other checks (not sure if they are better in separate commits or all together)

Dec 12 2018, 12:19 AM · Restricted Project
MyDeveloperDay edited reviewers for D55594: [clang-tidy] update readability-* and zircon-* check documentation to remove extraneous characters, added: aaron.ballman; removed: Aaron1011.
Dec 12 2018, 12:14 AM · Restricted Project
MyDeveloperDay created D55594: [clang-tidy] update readability-* and zircon-* check documentation to remove extraneous characters.
Dec 12 2018, 12:13 AM · Restricted Project

Dec 11 2018

MyDeveloperDay added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

  • Ensure same length of headers titles and markup.

Could you explain what you mean by this? I'm assuming you mean that when you see a title with --- or === or ^^^ then you expect the line about to be the exact same length, is that correct?

Example
-------

Yes, you understood correctly.

Dec 11 2018, 9:13 AM · Restricted Project
MyDeveloperDay updated the diff for D55523: [clang-tidy] Linting .rst documentation.

Reduce false positives

Dec 11 2018, 5:47 AM · Restricted Project
MyDeveloperDay added a comment to D55523: [clang-tidy] Linting .rst documentation.

Example output from running with validate_check.py --check-all

Dec 11 2018, 5:28 AM · Restricted Project
MyDeveloperDay updated the diff for D55523: [clang-tidy] Linting .rst documentation.

Add capability to check all the checks in one go (suitable for a build step)

Dec 11 2018, 5:26 AM · Restricted Project
MyDeveloperDay added a comment to D55523: [clang-tidy] Linting .rst documentation.

in looking closer at an example of the output..

Dec 11 2018, 5:08 AM · Restricted Project
MyDeveloperDay updated the diff for D55523: [clang-tidy] Linting .rst documentation.

Added new checks to help reduce review comments in documentation

  • check for unnecessary empty lines at the end of the rst files
  • check for double spaces
  • check for extraneous multiple blank lines
  • check for extraneous trailing whitespace
  • ensure markup title and markup characters --- === ^^^ match in lengh
  • exclude lines containing <clang-tidy
  • reformat message to look like a compiler warning
Dec 11 2018, 5:00 AM · Restricted Project
MyDeveloperDay added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

Dec 11 2018, 4:29 AM · Restricted Project
MyDeveloperDay added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

  • Double spaces
  • Empty lines at end of file
  • Ensure same length of headers titles and markup.
Dec 11 2018, 3:47 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

I wanted to leave a comment regarding running the [[nodiscard]] checker over all of clang... as requested by @JonasToth, @lebedev.ri and @Szelethus

Dec 11 2018, 3:44 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Resolving some (not all yet) review comments, and looking for help on template parameter exclusion

  • add additional template argument tests
  • add additional clang-warn-unused-result tests
  • add additional gcc-warn-unused-result tests
  • exclude template parameters
  • improve nodiscard wordage in documentation regarding conditions of checker
Dec 11 2018, 3:19 AM · Restricted Project

Dec 10 2018

MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Addressing review comments

  • grammatical errors in documentation and comments
  • prevent adding [[nodiscard]] to macros
  • clean up list.rst
Dec 10 2018, 12:26 PM · Restricted Project
MyDeveloperDay added inline comments to D55523: [clang-tidy] Linting .rst documentation.
Dec 10 2018, 11:51 AM · Restricted Project
MyDeveloperDay added a comment to D55508: [clang-tidy] insert release notes for new checkers alphabetically.

LGTM. Do you have commit access?

Dec 10 2018, 10:48 AM · Restricted Project
MyDeveloperDay added a comment to D55508: [clang-tidy] insert release notes for new checkers alphabetically.

I think this patch is fine, AFAIK these utility scripts are not tested directly but are just adjusted if they dont work as expected :)

Did you test it with a fake new-check? If it does what we expect its fine :)

Dec 10 2018, 10:17 AM · Restricted Project
MyDeveloperDay updated the summary of D55523: [clang-tidy] Linting .rst documentation.
Dec 10 2018, 10:12 AM · Restricted Project
MyDeveloperDay added reviewers for D55523: [clang-tidy] Linting .rst documentation: hokein, JonasToth, alexfh, Eugene.Zelenko.
Dec 10 2018, 10:12 AM · Restricted Project
MyDeveloperDay created D55523: [clang-tidy] Linting .rst documentation.
Dec 10 2018, 10:09 AM · Restricted Project
MyDeveloperDay added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

@curdeius Thanks, I don't have commit access so I'm happy wait for a CODE_OWNER, they could likely have more input.

Dec 10 2018, 9:24 AM · Restricted Project
MyDeveloperDay updated the diff for D55508: [clang-tidy] insert release notes for new checkers alphabetically.

Fix review comments

Dec 10 2018, 9:17 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Addressing review comments,

  • additional unit tests for no ReplacementString and C++ 11 case
  • more expressive hasNonConstReferenceOrPointerArguments matcher
  • minor documentation typos and spacing
Dec 10 2018, 8:49 AM · Restricted Project
MyDeveloperDay updated the diff for D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Update the documentation to utilize 80 character lines

Dec 10 2018, 6:21 AM · Restricted Project
MyDeveloperDay added a comment to D55508: [clang-tidy] insert release notes for new checkers alphabetically.

Thank you for this fix!

Dec 10 2018, 6:09 AM · Restricted Project
MyDeveloperDay updated the summary of D55508: [clang-tidy] insert release notes for new checkers alphabetically.
Dec 10 2018, 6:06 AM · Restricted Project
MyDeveloperDay updated the summary of D55508: [clang-tidy] insert release notes for new checkers alphabetically.
Dec 10 2018, 6:01 AM · Restricted Project