Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (359 w, 3 h)
Roles
Administrator

Recent Activity

Yesterday

MyDeveloperDay accepted D129057: [clang-format] Break on AfterColon only if not followed by comment.

LGTM

Mon, Jul 4, 4:19 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D129064: [clang-format] Avoid crash in LevelIndentTracker..

LGTM

Mon, Jul 4, 4:18 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Jul 2

MyDeveloperDay accepted D128984: [clang-format] Tweak help text a bit.

LGTM

Sat, Jul 2, 12:30 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 29

MyDeveloperDay accepted D128786: [clang-format] Fix incorrect isspace input (NFC).

LGTM

Wed, Jun 29, 8:00 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 26

MyDeveloperDay accepted D128574: [clang-format] Quit analyzing solution space for large state count.
Sun, Jun 26, 7:55 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D128607: [clang-format] NFC Fix uninitialized memory problem.
Sun, Jun 26, 7:53 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

LGTM

Sun, Jun 26, 7:52 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

MyDeveloperDay accepted D127270: [clang-format] Add space in placement new expression.

Thanks for the Screenshot, please remember to mark your comments as "Done" once you've addressed them. From what I can tell this looks good.

Tue, Jun 21, 2:02 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 20

MyDeveloperDay added inline comments to D127270: [clang-format] Add space in placement new expression.
Mon, Jun 20, 12:36 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Mon, Jun 20, 12:35 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 16

MyDeveloperDay added inline comments to D127270: [clang-format] Add space in placement new expression.
Thu, Jun 16, 3:37 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Thu, Jun 16, 3:31 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D127270: [clang-format] Add space in placement new expression.

I think you are missing a PARSE unit test

Thu, Jun 16, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

MyDeveloperDay requested changes to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

Thank you for the patch, just some observations

Wed, Jun 15, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.

what about (may not be useful but compiles)

Wed, Jun 15, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay edited reviewers for D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct, added: MyDeveloperDay; removed: Restricted Project.
Wed, Jun 15, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp.
Wed, Jun 15, 7:09 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 12

MyDeveloperDay accepted D127578: [clang-format] Handle deprecated options in dump_format_style.py.

Great thanks

Sun, Jun 12, 12:19 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 11

MyDeveloperDay requested changes to D127270: [clang-format] Add space in placement new expression.
Sat, Jun 11, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D127270: [clang-format] Add space in placement new expression.
Sat, Jun 11, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D127270: [clang-format] Add space in placement new expression.

Thank you for the patch, was there a github issue for this? Can we just validate that those requirements are covered here too while we are at it?

Sat, Jun 11, 9:14 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D127484: [clang-format] Use tabs on GNU style.
Sat, Jun 11, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D127484: [clang-format] Use tabs on GNU style.

We get heavily criticized for changing defaults between versions, I think if someone want to use GNU style, and they choose to now have this option set it should be done so in their own .clang-format file

Sat, Jun 11, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D127390: [clang-format][NFC] Remove unused FormatStyle members.

If we remove it from here, then it will get removed from the documentation

Sat, Jun 11, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 10

MyDeveloperDay accepted D127532: [clang-format] Fix a bug in RemoveBracesLLVM.
Fri, Jun 10, 11:59 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D127484: [clang-format] Use tabs on GNU style.

Oh gosh! It hard to make such changes and someone else not call them a regression, I’m not sure how I feel. We do kind of have to be able to fix bugs and if this gets closer to gnu style then I guess it’s better

Fri, Jun 10, 4:19 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 6

MyDeveloperDay added a comment to D127054: [clang-format] Handle attributes for for/while loops.

nice!

Mon, Jun 6, 2:04 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D126845: [clang-format] Handle Verilog numbers and operators.
Mon, Jun 6, 2:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D127005: [clang-format][NFC] Clean up the unwrapped line parser.

LGTM

Mon, Jun 6, 1:55 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

MyDeveloperDay accepted D126365: [git-clang-format] Stop ignoring changes for files with space in path.
Jun 1 2022, 5:03 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0.

@stasm thank you for taking it on, "Commandeer" the revision via the Revision actions.

Jun 1 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM.

LGTM

Jun 1 2022, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

MyDeveloperDay added inline comments to D125961: [clang-format] Don't break lines after pragma region.
May 23 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D126132: [clang-format] Fix a crash on lambda trailing return type.

LGTM (sorry I've been slow on the reviews, my day job keeps getting in the way ;-))

May 23 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/.

LGTM too.. @owenpan this is one of my favourite features!!

May 23 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D125848: [clang-format] Handle attributes in enum declaration..

This looks good to me, but let the others chime in..

May 23 2022, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay edited projects for D125848: [clang-format] Handle attributes in enum declaration., added: Restricted Project; removed Restricted Project.
May 23 2022, 8:45 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D125848: [clang-format] Handle attributes in enum declaration.: curdeius, owenpan, HazardyKnusperkeks.
May 23 2022, 8:45 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2022

MyDeveloperDay accepted D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types..

Brilliant thank you, LGTM

May 21 2022, 3:42 PM · Restricted Project, Restricted Project

May 4 2022

MyDeveloperDay added a comment to D124749: [clang-format] Handle Verilog preprocessor directives.

You add significant number of keywords here but I don't see any of them being tested? can you add a unit tests to cover what you are adding

May 4 2022, 5:25 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D124748: [clang-format] Fix whitespace counting stuff.

Is there any way you could add a unit test for this?

May 4 2022, 5:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

MyDeveloperDay accepted D124625: [clang-format][docs] Fix incorrect 'clang-format 7' option markers.
Apr 28 2022, 12:40 PM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

MyDeveloperDay accepted D124513: [clang-format] add a regression test for include sorting.
Apr 27 2022, 8:20 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

MyDeveloperDay added a comment to D123450: [clang-format] Parse Verilog if statements.

As first passes for adding a new language I think this looks pretty good.

Apr 21 2022, 9:26 AM · Restricted Project, Restricted Project

Apr 20 2022

MyDeveloperDay accepted D123571: [clang-format] Clean up unit tests for AlignArrayOfStructures.

Thanks for taking this on.

Apr 20 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

MyDeveloperDay accepted D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Apr 19 2022, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

Accepting but please wait for @owenpan

Apr 19 2022, 6:56 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.

The hard part about doing 2 separate cases is where we miss-interpret a .hpp or .h file as being the wrong language (C/C++/ObjC/ObjC++), I don't think I have a problem with a single regex (its not like we change it that often).

Apr 19 2022, 6:53 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

MyDeveloperDay accepted D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker.

LGTM

Apr 8 2022, 12:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2022

MyDeveloperDay accepted D122548: [clang-format] Don't format qualifiers in PPDirective.

LGTM thank you for the patch

Mar 27 2022, 2:05 PM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2022

MyDeveloperDay accepted D121906: [clang-format] Indent import statements in JavaScript..
Mar 26 2022, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

MyDeveloperDay added a comment to D121451: [clang-format] Add space to comments starting with '#'..

I'm a little uncomfortable with

//#<preprocessor directive>

becoming

// #<preprocessor directive>

At least without an option for it to not make changes

Don't you think that //#PPdirective should be indented the same way as other code?
E.g. in:

#include <header.h>

int something;

You comment the whole block and it becomes (with this patch):

// #include <header.h>
//
// int something;

whereas it was:

//#include <header.h>
//
// int something;

which seems inconsistent at least.

Mar 23 2022, 2:42 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121451: [clang-format] Add space to comments starting with '#'..

I'm a little uncomfortable with

Mar 23 2022, 2:53 AM · Restricted Project, Restricted Project

Mar 22 2022

MyDeveloperDay added inline comments to D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst..
Mar 22 2022, 8:49 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D122230: [clang-format] don't break up #-style comment sections.
Mar 22 2022, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D122230: [clang-format] don't break up #-style comment sections.

I hit something like this today with some code which was

Mar 22 2022, 7:25 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121756: [clang-format] Clean up code looking for if statements.

FWIW I'm not a fan of the while( \n case, so assuming this fix, fixes that then that would be good I think.

Mar 22 2022, 2:37 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121756: [clang-format] Clean up code looking for if statements.

It turned out this patch does change behavior.

Mar 22 2022, 2:36 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121756: [clang-format] Clean up code looking for if statements.

It turned out this patch does change behavior.

-  while (
-      FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) {
+  while (FormatTok->isOneOf(tok::identifier, tok::kw_requires,
+                            tok::coloncolon)) {

So what do I do?

And what's the regression suite?

Mar 22 2022, 2:28 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

MyDeveloperDay added a comment to D121754: [clang-format] Refactor determineStarAmpUsage NFC.

But we can: https://gcc.godbolt.org/z/8Mb1xo7oP

Mar 21 2022, 4:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 19 2022

MyDeveloperDay accepted D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers.
Mar 19 2022, 10:48 AM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

MyDeveloperDay added a comment to D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween.

I think you can spin it any number of ways, but bottom line its a massive truth table and I sort of feel however you change it, it will just become a different equally incomprehensible pattern.

Mar 18 2022, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121907: [clang-format] Use an enum for context types. NFC.

LGTM

Mar 18 2022, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D121906: [clang-format] Indent import statements in JavaScript..
Mar 18 2022, 9:08 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121907: [clang-format] Use an enum for context types. NFC.

Please wait for the other reviewers if you have commit access.

Mar 18 2022, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D121907: [clang-format] Use an enum for context types. NFC.

I think fundamentally this look ok? @curdeius and @owenpan I feel I want to bow to your better judgement.

Mar 18 2022, 4:26 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D121906: [clang-format] Indent import statements in JavaScript..
Mar 18 2022, 4:20 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121758: [clang-format] Add support for formatting Verilog code.

Yes. I am surprised that you asked since everyone asked me to break it apart.

Mar 18 2022, 2:22 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 18 2022, 1:54 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121756: [clang-format] Clean up code looking for if statements.

Sorry I don't believe we've covered the changes with unit tests.

Mar 18 2022, 1:48 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween.

This just made a 300 lines function and a 500 line function with minimal comments into a 800 line function.. For no real benefit?

Mar 18 2022, 1:43 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121753: [clang-format] Use a macro for non-C keywords.
Mar 18 2022, 1:38 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121906: [clang-format] Indent import statements in JavaScript..

Can you please supply full context diff "Context not available."

Mar 18 2022, 1:32 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D121906: [clang-format] Indent import statements in JavaScript..
Mar 18 2022, 1:29 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay edited reviewers for D121906: [clang-format] Indent import statements in JavaScript., added: MyDeveloperDay, curdeius, HazardyKnusperkeks, owenpan, krasimir; removed: Restricted Project.
Mar 18 2022, 1:29 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst..

Wow! Now that’s what I’m talking about!! Awesome! Thank you so much!

Mar 18 2022, 12:16 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst.

I’m not blocking it just using the observation to highlight that the rst generated isn’t conformant with best practices. The solution being that a volunteer offers to fix the dump_format_style.py or enduring Format.h isn’t making those mistakes

Mar 18 2022, 12:13 AM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2022

MyDeveloperDay updated subscribers of D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst.
Mar 17 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay edited reviewers for D121907: [clang-format] Use an enum for context types. NFC, added: curdeius, MyDeveloperDay, HazardyKnusperkeks, owenpan; removed: Restricted Project.
Mar 17 2022, 12:46 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121907: [clang-format] Use an enum for context types. NFC.

So out of interest, what is the reason? my assumption is that you wanted to add more for Verilog and you felt adding the extra bools was the wrong design and its better an an enum

Mar 17 2022, 12:46 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D121890: [clang-format] Copy help options to the doc directory..
Mar 17 2022, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121890: [clang-format] Copy help options to the doc directory..

The issue is #54418.

Actually I don't know who I should add as reviewers. The patches for clang-format don't always seem to have the same reviewers. Who are the main developers and how do you decide who you add each time?

I give up making the doc generated. It would require either integrating into the build process or writing a parser script like for the style options. Besides, that file is not entirely generated.

Mar 17 2022, 12:35 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

For the new stuff I have the option of still adding the function parseIndentedBlock but only using it in new code. Please be more blunt about whether I should close this revision and do it that way. I guess I might have misunderstood you before from how you reacted when I closed the large patch.

Mar 17 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst.
Mar 17 2022, 6:03 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

Just an observation, I have this in my Day Job all the time..

Mar 17 2022, 6:00 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121758: [clang-format] Add support for formatting Verilog code.

Abandoned? huh? are you breaking it apart?

Mar 17 2022, 5:50 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121890: [clang-format] Copy help options to the doc directory..
  1. Please log a github issue showing us what you are fixing.
  2. Please add the main clang-formatter developers as reviewers and not the clang-format project (I think we see it but I like to see the individual reviewers so I know there opinion)
  3. How about you change this so it autogenerates the rst so its never out of date.
Mar 17 2022, 5:47 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay edited reviewers for D121890: [clang-format] Copy help options to the doc directory., added: curdeius, MyDeveloperDay, HazardyKnusperkeks, owenpan; removed: Restricted Project.
Mar 17 2022, 5:45 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

MyDeveloperDay requested changes to D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C.
Mar 16 2022, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

Can you add a summary as to why you are making this change? the code doesn't look the same before/after so whats changing and why? is there no unit tests that perhaps need to be added?

Mar 16 2022, 2:54 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121758: [clang-format] Add support for formatting Verilog code.

You need to rebase the patch, it doesn't apply.

Mar 16 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121758: [clang-format] Add support for formatting Verilog code.

I'm very much a "clang-format all the things" kind of person which is why I added C# and JSON support, as someone who moves between languages all day every day I want one tool to rule them all.. I'd love it if it would format YAML (but thats another story)..

Mar 16 2022, 2:22 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D121758: [clang-format] Add support for formatting Verilog code.
Mar 16 2022, 2:14 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D121758: [clang-format] Add support for formatting Verilog code.
Mar 16 2022, 1:48 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D121758: [clang-format] Add support for formatting Verilog code.
Mar 16 2022, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D121758: [clang-format] Add support for formatting Verilog code.

Firstly thank you for taking the time to submit the patch, I've only taken a cursory view at first and I definitely have some comments, I've added the main clang-format reviewers

Mar 16 2022, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay edited reviewers for D121758: [clang-format] Add support for formatting Verilog code, added: MyDeveloperDay, curdeius, HazardyKnusperkeks, aaron.ballman, krasimir, owenpan, klimek; removed: Restricted Project.
Mar 16 2022, 1:15 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

MyDeveloperDay added a comment to D121576: [clang-format] Don't unwrap lines preceded by line comments.

Please do, to be honest I spent enough time on this and I got to the same conclusion, it needs a rethink. Please go ahead, I don't use this feature myself so I'm not likely to see all the issues.

Mar 15 2022, 2:03 AM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

MyDeveloperDay accepted D121596: [clang-format] Fix crash with ObjC Blocks.
Mar 14 2022, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D121584: [clang-format] Correctly recognize arrays in template parameter list..
Mar 14 2022, 12:42 PM · Restricted Project, Restricted Project