Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (304 w, 6 d)
Roles
Administrator

Recent Activity

Today

MyDeveloperDay accepted D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

LGTM

Mon, Jun 21, 7:06 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93528: [clang-format] Add basic support for formatting JSON.

something @sammccall said about support foo["name"] made me realise that our javascript support doesn't always support what all the options

Mon, Jun 21, 4:39 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.
Mon, Jun 21, 1:42 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93528: [clang-format] Add basic support for formatting JSON.

Add more unit tests and ensure clang-format-diff is setup to check json

Mon, Jun 21, 1:28 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93528: [clang-format] Add basic support for formatting JSON.

Ensure git clang-format can handle json

Mon, Jun 21, 1:04 AM · Restricted Project, Restricted Project

Yesterday

MyDeveloperDay added inline comments to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.
Sun, Jun 20, 8:30 AM · Restricted Project, Restricted Project

Thu, Jun 17

MyDeveloperDay updated the diff for D93528: [clang-format] Add basic support for formatting JSON.

JSON strings can't be split when the line is too long like c++ strings

Thu, Jun 17, 9:56 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93528: [clang-format] Add basic support for formatting JSON.

Missing new test file

Thu, Jun 17, 9:06 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D93528: [clang-format] Add basic support for formatting JSON.

I have reworked this patch to utilise the fact that clang-format can format a JSON object in javascript reasonably well.

Thu, Jun 17, 8:56 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104096: [Clang-Format] Add ReferenceAlignment directive.

This patch needs rebasing, please also make comments as "Done" once you have addressed them.

Thu, Jun 17, 1:43 AM · Restricted Project
MyDeveloperDay committed rG873308fd8c96: [Format] Fix incorrect pointer/reference detection (authored by Nuullll).
[Format] Fix incorrect pointer/reference detection
Thu, Jun 17, 1:35 AM
MyDeveloperDay closed D103678: [Format] Fix incorrect pointer/reference detection.
Thu, Jun 17, 1:35 AM · Restricted Project, Restricted Project

Wed, Jun 16

MyDeveloperDay updated the diff for D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.

I wanted to add some more tests and this really only manifested itself using lock and using although the use of them is not generally broken when not using them in a Lambda expression

Wed, Jun 16, 8:19 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect.
Wed, Jun 16, 8:12 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

@MyDeveloperDay
Of course, sorry for the delay, here it is: https://github.com/christophe-calmejane/Hive/blob/master/.clang-format

Wed, Jun 16, 1:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Just asking: Would it be different if there is auto, decltype(auto), decltype(a+b), typename or template as trailing return type?

Wed, Jun 16, 12:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

For this case:

Wed, Jun 16, 12:25 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

And also another different in that case (without lambda):

	ASSERT_NO_THROW(
		{
			iterator += 507408;
		});

is now format like this:

	ASSERT_NO_THROW({ iterator += 507408; });
Wed, Jun 16, 12:22 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Part of the problem here is we are not really parsing the Lambda but trying to break based on token annotation only. This can tend to be a bit fragile (normally around corner cases)

Wed, Jun 16, 12:19 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

This has been landed in the 12.0.1 RC https://github.com/llvm/llvm-project/commit/c7d7ace46258b04aa4b5df08952bfebc6fc4ce94

Wed, Jun 16, 12:03 AM · Restricted Project, Restricted Project

Tue, Jun 15

MyDeveloperDay updated the diff for D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Add support for TemplateCloser before LambdaBrace

Tue, Jun 15, 11:02 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Add some of the failing cases identified by @Wawha

Tue, Jun 15, 7:44 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

@christophe-calmejane are you able to post your .clang-format styles that you are using, I'm struggling to see where its not matching your style (other than brace styles on the function and argument placing)

Tue, Jun 15, 7:38 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

@Wawha your cases could be covered by the following (in mustBreakBefore)

Tue, Jun 15, 7:23 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D104295: removes redundant test.
Tue, Jun 15, 7:04 AM · Restricted Project
MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Do we actually need this lit test? Mostly we only add lit tests when we add a new command line argument, I feel your are just testing what we also test in the unittests.

Tue, Jun 15, 3:34 AM · Restricted Project, Restricted Project

Mon, Jun 14

MyDeveloperDay updated subscribers of D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

I think we've missed the deadline for 12.0.1 which I believe was last friday. I did a practice merge and it didn't quite go in cleanly to 12.0.X branch

Mon, Jun 14, 10:58 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

Remove unused functions

Mon, Jun 14, 9:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.

@Wawha do you have a project that perhaps uses this work your did? I would like to ensure I didn't break anything

Mon, Jun 14, 9:00 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace.
Mon, Jun 14, 6:11 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Mon, Jun 14, 4:28 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Mon, Jun 14, 4:09 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
namespace test {
  class Test {
  public:
    Test() = default;
  };
} // namespace test
Mon, Jun 14, 4:05 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Tracking a possible bug, https://bugs.llvm.org/show_bug.cgi?id=50702

Mon, Jun 14, 4:02 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set.

This issue was resolved by https://github.com/llvm/llvm-project/commit/d5e9ff4fe20e66d53a245645c95f0bb816b747cb could you please close out this review

Mon, Jun 14, 3:10 AM
MyDeveloperDay added a comment to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

I think we can agree its complicated, how about you take your unit tests and show us what the "code change" looks like to fix the bug

Mon, Jun 14, 3:04 AM · Restricted Project, Restricted Project

Sat, Jun 12

MyDeveloperDay added a comment to D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser.

A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by your changes here when merged to the 12 branch, I'm not sure if this needs to be backported to 12 I guess it might depend on if we think it's critical enough or if there will more 12 release candidates before 13 @timwoj any thoughts?

Sat, Jun 12, 4:03 AM · Restricted Project, Restricted Project
MyDeveloperDay abandoned D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options.
Sat, Jun 12, 3:13 AM · Restricted Project
MyDeveloperDay commandeered D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options.
Sat, Jun 12, 3:13 AM · Restricted Project
MyDeveloperDay added a project to D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options: Restricted Project.
Sat, Jun 12, 3:12 AM · Restricted Project
MyDeveloperDay added reviewers for D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options: MyDeveloperDay, curdeius.
Sat, Jun 12, 3:12 AM · Restricted Project
MyDeveloperDay added a comment to D19066: clang-format: `SpaceAfterTemplate` and `SpacesInBraces` options.

This is already resolved with SpaceAfterTemplateKeyword and SpaceInEmptyBlock I'm going to commandeer and abandon

Sat, Jun 12, 3:12 AM · Restricted Project
MyDeveloperDay accepted D104096: [Clang-Format] Add ReferenceAlignment directive.

LGTM

Sat, Jun 12, 2:58 AM · Restricted Project

Fri, Jun 11

MyDeveloperDay added a comment to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

My point being there is inconsistency between how different types of blocks of code are handled, and rather than trying to fix another corner case maybe we should take a more holistic approach, all these KeepEmptyLines and EmptyLineAfterXXX options and what you'll need in order to fix this issue are all addressing what is effectively the same issue, and that is that the addition and/or removal of empty lines is a little hit or miss depending on your combination and permutation of settings and the type of block

Fri, Jun 11, 10:40 AM · Restricted Project, Restricted Project
MyDeveloperDay awarded D104096: [Clang-Format] Add ReferenceAlignment directive a Like token.
Fri, Jun 11, 9:50 AM · Restricted Project
MyDeveloperDay added a comment to D104096: [Clang-Format] Add ReferenceAlignment directive.

A new nits but I'd say it was pretty good.

Fri, Jun 11, 9:46 AM · Restricted Project
MyDeveloperDay added a comment to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

We should have perhaps though about this when we added `EmptyLineAfterAccessModifier ` and `EmptyLineBeforeAccessModifier `

Fri, Jun 11, 9:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

Do we need a set options for when we want to insert/retain/add a newline after various constructs? frankly I've been mulling over the concept of adding a

Fri, Jun 11, 9:01 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

Devils advocate how is this any different from

Fri, Jun 11, 8:53 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace.

Just so I'm clear are you proposing that a newlines should always be added or that single blank lines should be ignored? I can't tell if the bug is that the line isn't being removed or sometimes not being added, either way there will be someone who wants it the other way around correct?

Fri, Jun 11, 1:17 AM · Restricted Project, Restricted Project

Thu, Jun 10

MyDeveloperDay updated subscribers of D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635).

@curdeius , @HazardyKnusperkeks any thoughts, personally I don't have any problems with this even if its not my personal preference. @skirkovski if this is something you need we might need for you to take over the revision and bring it upto date and address the comments? is that something yo would be interesting in helping out with?

Thu, Jun 10, 4:04 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D101868: [clang-format] Adds a formatter for aligning arrays of structs.

LGTM

Thu, Jun 10, 1:00 AM · Restricted Project, Restricted Project

Wed, Jun 9

MyDeveloperDay accepted D103678: [Format] Fix incorrect pointer/reference detection.
Wed, Jun 9, 12:56 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Wed, Jun 9, 12:55 AM · Restricted Project, Restricted Project

Tue, Jun 8

MyDeveloperDay added inline comments to D103678: [Format] Fix incorrect pointer/reference detection.
Tue, Jun 8, 8:42 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D103678: [Format] Fix incorrect pointer/reference detection.
Tue, Jun 8, 8:39 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Save the name. I should have it rolled up shortly.

Tue, Jun 8, 8:32 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Better still how about having

Tue, Jun 8, 4:21 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Ok. Given @HazardyKnusperkeks comment I'll make the default be left alignment and update the tests accordingly

Tue, Jun 8, 4:17 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D103678: [Format] Fix incorrect pointer/reference detection.
Tue, Jun 8, 4:15 AM · Restricted Project, Restricted Project

Sun, Jun 6

MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

Remains the issue with the alignment, I would like to know @MyDeveloperDay 's opinion on that. Should the values be right aligned, or left aligned? As far as I see all alignment in clang-format is left until now.

Sun, Jun 6, 4:05 AM · Restricted Project, Restricted Project

Fri, Jun 4

MyDeveloperDay committed rGb5f0a14fc7b4: [clang-format] NFC, 2% improvement in overall clang-formatted status (now 50%) (authored by MyDeveloperDay).
[clang-format] NFC, 2% improvement in overall clang-formatted status (now 50%)
Fri, Jun 4, 7:03 AM
MyDeveloperDay added inline comments to D103678: [Format] Fix incorrect pointer/reference detection.
Fri, Jun 4, 4:47 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D103678: [Format] Fix incorrect pointer/reference detection.
Fri, Jun 4, 4:47 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D103678: [Format] Fix incorrect pointer/reference detection.
Fri, Jun 4, 4:45 AM · Restricted Project, Restricted Project

Tue, Jun 1

MyDeveloperDay added a comment to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

It maybe that others think that the PAS_Right IS that option. If thats is the case I'm fine with that too.

Tue, Jun 1, 2:44 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.
Tue, Jun 1, 12:41 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484).

A small task that will make a lot of people happy

Tue, Jun 1, 2:18 AM · Restricted Project, Restricted Project

Sun, May 30

MyDeveloperDay added a comment to D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines.

We can't rename options without giving some form of backwards compatibility, personally, I think we need to start again with this review if its still of interest, this one is 6 years old.

Sun, May 30, 4:28 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D103286: [clang-format] Add PPIndentWidth option.
Sun, May 30, 4:25 AM · Restricted Project, Restricted Project

Sat, May 29

MyDeveloperDay committed rGffb48d48e45c: [clang-format] successive C# attributes cause line breaking issues (authored by MyDeveloperDay).
[clang-format] successive C# attributes cause line breaking issues
Sat, May 29, 8:44 AM
MyDeveloperDay closed D103307: [clang-format] successive C# attributes cause line breaking issues.
Sat, May 29, 8:44 AM · Restricted Project, Restricted Project

Fri, May 28

MyDeveloperDay accepted D103204: [clang-format] New BreakInheritanceList style AfterComma.

LGTM

Fri, May 28, 5:15 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D103307: [clang-format] successive C# attributes cause line breaking issues.

Add additional unit test, and an additional check to ensure multiple attributes are broken, while @jbcoe this looks very similar to the original rule, the original rule actually had an || in the expression and not an &&, this I believe caused and issue where the adjacent [] [] caused an issue because we were breaking on an attribute and and array. By virtue of the fact the attributes are not correctly identified. Which concerns me a little,

Fri, May 28, 5:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D103307: [clang-format] successive C# attributes cause line breaking issues.

Thanks for this!

Fri, May 28, 4:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D74265: [clang-format] Improve handling of C# attributes.

The second property in a class is putting the property on the same line

[XmlIgnore] 
public string property1 { get; set; }
Fri, May 28, 3:35 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D103307: [clang-format] successive C# attributes cause line breaking issues.
Fri, May 28, 3:34 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D74265: [clang-format] Improve handling of C# attributes.

This issue seems to have caused a regression https://bugs.llvm.org/show_bug.cgi?id=50515, I understand we removed the rule because it was too aggressive, now its not aggressive enough.

Fri, May 28, 2:59 AM · Restricted Project, Restricted Project

Thu, May 27

MyDeveloperDay added a comment to D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration.

Are we happy with the way this behaves? I realise some of this needs semantic information but I think the fact it only handles 1 of these 4 cases leaves me feeling a little cold. (I just don't want to be having to defend this as to why it doesn't work in all cases.)

Thu, May 27, 4:47 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D103204: [clang-format] New BreakInheritanceList style AfterComma.

Adding such a feature like this needs unit tests, it won't be let in without them, you need to add them to clang/unittest/Format/Format.cpp

Thu, May 27, 3:17 AM · Restricted Project, Restricted Project

Wed, May 26

MyDeveloperDay accepted D102989: Align documentation in Format.h and ClangFormatStyleOptions.rst for EmptyLineAfterAccessModifier.

LGTM thank you!

Wed, May 26, 3:06 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D95168: [clang-format] Add InsertBraces option.
Wed, May 26, 3:06 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D95168: [clang-format] Add InsertBraces option.
Wed, May 26, 3:04 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration.

This patch still only considers structs? @krasimir and I are I think saying that really this should it support class in the same way? I mean isn't a struct and a class almost identical in this context why would we want treat them differently.

Wed, May 26, 1:54 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
Wed, May 26, 1:30 AM · Restricted Project
MyDeveloperDay added a comment to D92168: [clang-format] Handle statement macro expressions in switch block.

I'm not sure of the reason for the failure without debugging it, We cannot commit with failing tests so we have to determine the reason why.

Wed, May 26, 1:26 AM · Restricted Project

Mon, May 24

MyDeveloperDay added a comment to D92168: [clang-format] Handle statement macro expressions in switch block.

@MyDeveloperDay could you please clarify why unit tests are failed on Phabricator and there is no diff in logs (what is expected), but locally I tested the same tests and the result was successful?

Mon, May 24, 10:29 AM · Restricted Project

May 22 2021

MyDeveloperDay added a comment to rG8d93d7ffedeb: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to….

Whoops, we also here forgot to regenerate the ClangFormatStyleOptions.rst once we changed the Format.h

May 22 2021, 9:16 AM
MyDeveloperDay added a comment to D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is..

Whoops, We forgot to regenerate ClangFormatStyleOptions.rst here following the change to Format.h

May 22 2021, 9:14 AM · Restricted Project
MyDeveloperDay added a comment to D98237: [clang-format] Option for empty lines after an access modifier..

When you made this commit you didn't regenerate the ClangFormatStyleOptions.rst from the Format.h using clang/docs/tool/dump_format_style.py now anyone else using the tool hit issues with code which is incorrect, we need to update Format.h to match what you expect in ClangFormatStyleOptions.rst

May 22 2021, 9:11 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D102706: [clang-format] Add new LambdaBodyIndentation option.

I personally like to keep clang-format and clang-format tests clang formatted all the time so we have a reasonable set of "clang-format-clean" code we can sanity check any change against, the more of LLVM that can be clean the better our testing can be.

May 22 2021, 9:04 AM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D102730: [clang-format] Support custom If macros.

This kind of looks ok to me, I'm not sure about the "lexer" part, I guess I don't know the impact but I'd expect it to be small because it's conditional on your IfMacro

May 22 2021, 9:01 AM · Restricted Project, Restricted Project

May 21 2021

MyDeveloperDay added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
May 21 2021, 10:37 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This is a valiant effort, and I definitely don't want to discourage..especially as you shown a good understand of clang-format. Its been a long asked for feature.. but we should really ensure this covers the bulk of the complaints if possible..

May 21 2021, 10:34 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

This looks like a good start..

May 21 2021, 9:40 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D92168: [clang-format] Handle statement macro expressions in switch block.
class FOO(x) : public x {
  public:
    int x;
May 21 2021, 9:31 AM · Restricted Project
MyDeveloperDay added a comment to D92168: [clang-format] Handle statement macro expressions in switch block.

Did you prove that CLASS(x) : won't be an issue?

May 21 2021, 9:17 AM · Restricted Project
MyDeveloperDay added a comment to D102706: [clang-format] Add new LambdaBodyIndentation option.

Could you clang-format the tests please so I can more easily read them.

May 21 2021, 9:12 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D102706: [clang-format] Add new LambdaBodyIndentation option.

Is `Signature``` effectively as is?

May 21 2021, 9:09 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D102730: [clang-format] Support custom If macros.
May 21 2021, 9:04 AM · Restricted Project, Restricted Project