Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (204 w, 2 d)
Roles
Administrator

Recent Activity

Mon, Jul 15

MyDeveloperDay added inline comments to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.
Mon, Jul 15, 11:57 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

I appreciate what you've done to make this patch less duplicated code..but now you've almost got to the point where being able to control it all via configuration.

Mon, Jul 15, 11:52 AM · Restricted Project
MyDeveloperDay added inline comments to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.
Mon, Jul 15, 1:28 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

There also seems like alot of duplication between the existing sortCppIncludes

I think the only difference here is really just

SmallVector<unsigned, 16> Indices;
  SmallVector<unsigned, 16> Includes_p;
  for (unsigned i = 0, e = Includes.size(); i != e; ++i) {
    unsigned pl = getNetBSDIncludePriority(Includes[i].Filename);
    Includes_p.push_back(pl);
    Indices.push_back(i);
  }

vs the original

SmallVector<unsigned, 16> Indices;
for (unsigned i = 0, e = Includes.size(); i != e; ++i)
  Indices.push_back(i);

plus way the sorting is performed, are we sure we couldn't have just made the original sorting more powerful based on style settings?

Does it mean that adding the priority to sort based on style?
like this:

if (Style== NetBSD)
   // set priority to netbsd's priority
else if(Style == X)
  // set X's priority

I didn't want to mess up the original sorting and made up this patch, if we have parameterise this solution, I will go for it.

Mon, Jul 15, 1:26 AM · Restricted Project

Sun, Jul 14

MyDeveloperDay added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

There also seems like alot of duplication between the existing sortCppIncludes

Sun, Jul 14, 8:25 AM · Restricted Project
MyDeveloperDay added a comment to D64695: [clang-format] Added new style rule: SortNetBSDIncludes.

Do you think there is anything about this algorithm that could be parameterized so that other projects could utilize it? I guess its not completely clear how this differs from just using the IncludeCategories?

Sun, Jul 14, 4:05 AM · Restricted Project

Wed, Jul 10

MyDeveloperDay accepted D61001: [clang-format][tests] Explicitly specify style in some tests.
Wed, Jul 10, 12:34 PM · Restricted Project

Tue, Jun 25

MyDeveloperDay added a comment to D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.

It was more about not having time to pursue it at this time.. I didn't feel I should hog the PR if someone else wanted to take a look.

Tue, Jun 25, 2:03 AM · Restricted Project

Thu, Jun 20

MyDeveloperDay abandoned D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Thu, Jun 20, 11:19 AM · Restricted Project
MyDeveloperDay abandoned D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Thu, Jun 20, 11:18 AM · Restricted Project
MyDeveloperDay abandoned D59332: [clang-format] AlignConsecutiveDeclarations fails with attributes.
Thu, Jun 20, 11:18 AM · Restricted Project
MyDeveloperDay abandoned D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted).
Thu, Jun 20, 11:18 AM · Restricted Project, Restricted Project

Jun 13 2019

MyDeveloperDay added inline comments to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.
Jun 13 2019, 2:49 PM · Restricted Project

Jun 12 2019

MyDeveloperDay added a comment to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.

Nit: if you going for "OnePerLine" in the name rather than "Break" can you keep it consistent with ConstructorInitializerAllOnOneLineOrOnePerLine and put the type first and then the operation i.e. BitFieldOnePerLine (this will help keep all BitField options together if there are ever more than one), I also think either don't use Decl at all or use the full word Declarations as in AlignConsecutiveDeclarations , AlwaysBreakTemplateDeclarations etc

Jun 12 2019, 8:03 AM · Restricted Project

Jun 11 2019

MyDeveloperDay added a comment to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.

mark sure you mark off the comments as you consider them done.

Jun 11 2019, 6:03 AM · Restricted Project

Jun 10 2019

MyDeveloperDay requested changes to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.
Jun 10 2019, 12:49 PM · Restricted Project

Jun 9 2019

MyDeveloperDay requested changes to D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine.

You need to add a unit test in clang/unittests

Jun 9 2019, 2:46 PM · Restricted Project

May 21 2019

MyDeveloperDay added a comment to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..

Just a passing comment, Is this:

May 21 2019, 11:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 15 2019

MyDeveloperDay accepted D61281: [clang-format] Fixed self assignment.

LGTM

May 15 2019, 1:38 AM · Restricted Project

May 14 2019

MyDeveloperDay requested changes to D61281: [clang-format] Fixed self assignment.

please simply remove line 249

May 14 2019, 12:13 PM · Restricted Project

May 10 2019

MyDeveloperDay accepted D28462: clang-format: Add new style option AlignConsecutiveMacros.

@klimek responded via the mailing list

May 10 2019, 8:09 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

When I spoke with one of the code owners, they seemed to have a problem accepting this review based on there not being a general description/understanding of how this algorithm works.

May 10 2019, 3:30 AM · Restricted Project, Restricted Project

May 3 2019

MyDeveloperDay accepted D61276: [clang-format] Fix bug in block comment reflow that joins * and /.

LGTM

May 3 2019, 10:18 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D61281: [clang-format] Fixed self assignment.

Did this cause some issue? Does this fix something if so can we add a test, because maybe the line isn't needed

I would think we'd want to keep this as an identifier. we are just treating arg? the same as we would arg

@MyDeveloperDay didn't you write this code in D58404?

May 3 2019, 10:16 AM · Restricted Project

May 1 2019

MyDeveloperDay added inline comments to D58404: [clang-format] Add basic support for formatting C# files.
May 1 2019, 4:43 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations.

LGTM

May 1 2019, 4:43 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs.

Thanks for the patch, thanks also for changing to https as I believe this was a change suggested in clang tidy docs too

May 1 2019, 2:49 AM · Restricted Project
MyDeveloperDay added a comment to D61276: [clang-format] Fix bug in block comment reflow that joins * and /.

Thanks for the patch, is this case only limited to *<tab>

May 1 2019, 2:46 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D61281: [clang-format] Fixed self assignment.

Did this case some issue? Does this fix something if so can we add a test, because maybe the line isn't needed

May 1 2019, 2:45 AM · Restricted Project
MyDeveloperDay accepted D61297: [clang-format] Fix bug that misses some function-like macro usages.

LGTM

May 1 2019, 2:42 AM · Restricted Project, Restricted Project

Apr 27 2019

MyDeveloperDay accepted D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations.

LGTM

Apr 27 2019, 5:09 AM · Restricted Project, Restricted Project

Apr 23 2019

MyDeveloperDay accepted D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF.

This looks logical to me, seems to fit with what `WhitespaceManager::appendNewlineText` is doing

Apr 23 2019, 1:28 AM · Restricted Project

Apr 18 2019

MyDeveloperDay abandoned D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.

Abandoning in favor of D60853: clang-format converts a keyword macro definition to a macro function

Apr 18 2019, 3:15 AM · Restricted Project
MyDeveloperDay accepted D60853: clang-format converts a keyword macro definition to a macro function.
Apr 18 2019, 3:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60853: clang-format converts a keyword macro definition to a macro function.

LGTM

Apr 18 2019, 3:15 AM · Restricted Project, Restricted Project

Apr 17 2019

MyDeveloperDay added a comment to D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.

@klimek one possible solution to this might be to replace the "keyword" back to an identifier in a '#define <keywoord>' scenario

Apr 17 2019, 6:03 AM · Restricted Project

Apr 15 2019

MyDeveloperDay committed rGbd8a1ce7bbb9: [clang-format] [PR41170] Break after return type ignored with certain comments… (authored by MyDeveloperDay).
[clang-format] [PR41170] Break after return type ignored with certain comments…
Apr 15 2019, 12:46 AM

Apr 14 2019

MyDeveloperDay updated the diff for D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

use endsWith() as it ignored comments

Apr 14 2019, 5:28 AM · Restricted Project, Restricted Project

Apr 11 2019

MyDeveloperDay added a comment to D60151: [clang-tidy] Rename llvm checkers to llvm-project .

I suppose we could keep the names and directory structure and just change the namespace. That would just be a special case in the scripts. Haven't looked into it yet, but will do so as soon as I can.

Isn't that matching done on strings? I.e. is there difference between -llvm-* and -ll* ?

Apr 11 2019, 2:43 PM · Restricted Project
MyDeveloperDay added a comment to D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

I agree and would be happy with the change if it would only change the line-filtered workflow, but this afaict (unless I'm missing something :) will also affect the workflow where the provided range is 0-length range, which has an implicit "format stuff around this" request from the user inside it. I'd be happy with a patch that differentiates these two sides.

Apr 11 2019, 9:10 AM · Restricted Project
MyDeveloperDay added a comment to D60151: [clang-tidy] Rename llvm checkers to llvm-project .

are we supporting "-llvm-*" in existing .clang-tidy files?

Apr 11 2019, 8:56 AM · Restricted Project

Apr 9 2019

MyDeveloperDay set the repository for D59332: [clang-format] AlignConsecutiveDeclarations fails with attributes to rC Clang.
Apr 9 2019, 12:33 AM · Restricted Project
MyDeveloperDay set the repository for D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present to rC Clang.
Apr 9 2019, 12:33 AM · Restricted Project
MyDeveloperDay set the repository for D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers to rC Clang.
Apr 9 2019, 12:32 AM · Restricted Project
MyDeveloperDay added a comment to D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

Please either subscribe the correct lists or set the correct repo in differential params.

Apr 9 2019, 12:32 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.
Apr 9 2019, 12:25 AM · Restricted Project, Restricted Project

Apr 8 2019

MyDeveloperDay planned changes to D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.
Apr 8 2019, 5:48 AM · Restricted Project
MyDeveloperDay updated the diff for D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

Addressing review comments
Reduce test cases

Apr 8 2019, 5:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.

+1 to quite some overlap in the tests. I'd have expected three test cases:

  1. ; line comment
  2. ; C-comment
  3. no semi
Apr 8 2019, 3:57 AM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping.

@ownenpan might be worth checking with @reuk who has been adding some options for the JUCE style guide and looking at the JUCE code it seems this style might match their style.

Apr 8 2019, 3:53 AM · Restricted Project
MyDeveloperDay added a comment to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

I believe there is no such thing as an "short else statement". The else is part of the if statement and if it is present, I don't consider the whole if statement short. As such, IMO the bug is invalid.

Apr 8 2019, 2:08 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.
Apr 8 2019, 2:02 AM · Restricted Project

Apr 7 2019

MyDeveloperDay accepted D60374: clang-format incorrectly indents wrapped closing parenthesis.
Apr 7 2019, 1:50 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60374: clang-format incorrectly indents wrapped closing parenthesis.

LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough

Thanks! I just got the alternative patch ready. Should I discard it and just commit this one?

Apr 7 2019, 1:27 PM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro: owenpan.
Apr 7 2019, 12:52 PM · Restricted Project
MyDeveloperDay added a reviewer for D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions: owenpan.
Apr 7 2019, 12:52 PM · Restricted Project, Restricted Project
MyDeveloperDay accepted D60374: clang-format incorrectly indents wrapped closing parenthesis.

LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough

Apr 7 2019, 12:49 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60374: clang-format incorrectly indents wrapped closing parenthesis.

maybe add the following as a test because I think it shows the inconsistency

Apr 7 2019, 9:03 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D60374: clang-format incorrectly indents wrapped closing parenthesis.
Apr 7 2019, 5:42 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D60320: [clang-format]: Add option to insert space after locical not operator.

LGTM (minor nit)

Apr 7 2019, 5:31 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60320: [clang-format]: Add option to insert space after locical not operator.

I updated ClangFormatStyleOptions.rst by hand, is there a way to do that automatically instead (for future patches)?

Apr 7 2019, 5:29 AM · Restricted Project, Restricted Project

Apr 6 2019

Herald added a project to D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping: Restricted Project.

@owenpan can I help you bring this back up to date and review, I think I saw another issue in the bugzilla requesting this.

Apr 6 2019, 2:25 PM · Restricted Project
MyDeveloperDay abandoned D60361: [clang-format] [PR41407] Constructor initializer list indented incorrectly.
Apr 6 2019, 1:59 PM · Restricted Project
MyDeveloperDay accepted D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list.

Thanks for doing this, it LGTM, I like your solution better ;-)

Apr 6 2019, 1:59 PM · Restricted Project, Restricted Project
MyDeveloperDay created D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions.
Apr 6 2019, 7:26 AM · Restricted Project, Restricted Project
MyDeveloperDay created D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro.
Apr 6 2019, 5:43 AM · Restricted Project
MyDeveloperDay created D60361: [clang-format] [PR41407] Constructor initializer list indented incorrectly.
Apr 6 2019, 4:43 AM · Restricted Project
MyDeveloperDay committed rG1db96ac88b6d: [clang-format] BreakAfterReturnType ignored on functions with numeric template… (authored by MyDeveloperDay).
[clang-format] BreakAfterReturnType ignored on functions with numeric template…
Apr 6 2019, 3:14 AM

Apr 5 2019

MyDeveloperDay added a comment to D60320: [clang-format]: Add option to insert space after locical not operator.

I actually also tend to change doc/ClangFormatStyleOptions.rst too

Apr 5 2019, 12:09 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D60320: [clang-format]: Add option to insert space after locical not operator.

just a few nits, apart form that it LG

Apr 5 2019, 12:09 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.

friendly ping

Apr 5 2019, 2:40 AM · Restricted Project
MyDeveloperDay added a comment to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

friendly ping

Apr 5 2019, 2:37 AM · Restricted Project, Restricted Project

Apr 3 2019

MyDeveloperDay added inline comments to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.
Apr 3 2019, 12:38 PM · Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Apr 3 2019, 12:29 PM · Restricted Project
MyDeveloperDay updated the summary of D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Apr 3 2019, 12:25 PM · Restricted Project
MyDeveloperDay created D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers.
Apr 3 2019, 12:24 PM · Restricted Project

Apr 1 2019

MyDeveloperDay added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

Apr 1 2019, 6:45 AM · Restricted Project, Restricted Project

Mar 30 2019

MyDeveloperDay committed rG88335c21a466: [clang-format] [PR41187] moves Java import statements to the wrong location if… (authored by MyDeveloperDay).
[clang-format] [PR41187] moves Java import statements to the wrong location if…
Mar 30 2019, 6:05 AM

Mar 27 2019

MyDeveloperDay added a comment to D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced..

We normally add something to the documentation about the checker and/or the release notes to say what had changed

Mar 27 2019, 7:12 AM · Restricted Project, Restricted Project

Mar 23 2019

MyDeveloperDay committed rGf5e52738fe9d: [clang-format] Keep protobuf "package" statement on one line (authored by MyDeveloperDay).
[clang-format] Keep protobuf "package" statement on one line
Mar 23 2019, 7:44 AM
MyDeveloperDay committed rGc6deae452197: Clang-format: add finer-grained options for putting all arguments on one line (authored by MyDeveloperDay).
Clang-format: add finer-grained options for putting all arguments on one line
Mar 23 2019, 7:39 AM
MyDeveloperDay committed rGa87ba1c59cb9: [clang-format] correctly format protobuf fields named "enum". (authored by MyDeveloperDay).
[clang-format] correctly format protobuf fields named "enum".
Mar 23 2019, 7:24 AM
MyDeveloperDay accepted D59627: [clang-format] Keep protobuf "package" statement on one line.

LGTM

Mar 23 2019, 7:23 AM · Restricted Project, Restricted Project

Mar 22 2019

MyDeveloperDay committed rGccc6f838f748: [clang-format][NFC] correct the release notes (authored by MyDeveloperDay).
[clang-format][NFC] correct the release notes
Mar 22 2019, 3:47 PM
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

@lebedev.ri Are we talking about a general ideology of the long term cost to allow any new things in? or to not allow things in this specific case?

Mar 22 2019, 12:00 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay created D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import.
Mar 22 2019, 3:01 AM · Restricted Project, Restricted Project

Mar 21 2019

MyDeveloperDay committed rGcbb726d0c538: [clang-format] Add basic support for formatting C# files (authored by MyDeveloperDay).
[clang-format] Add basic support for formatting C# files
Mar 21 2019, 6:10 AM
MyDeveloperDay added inline comments to D58404: [clang-format] Add basic support for formatting C# files.
Mar 21 2019, 3:51 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D58404: [clang-format] Add basic support for formatting C# files.

Address comment nits

Mar 21 2019, 3:51 AM · Restricted Project, Restricted Project
MyDeveloperDay added a project to D59528: [clang-tidy] Expand modular headers for PPCallbacks: Restricted Project.
Mar 21 2019, 3:26 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a project to D59629: [clang-format] correctly format protobuf fields named "enum".: Restricted Project.
Mar 21 2019, 3:22 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D59627: [clang-format] Keep protobuf "package" statement on one line.
Mar 21 2019, 3:20 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D59629: [clang-format] correctly format protobuf fields named "enum"..

LGTM

Mar 21 2019, 3:16 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D58404: [clang-format] Add basic support for formatting C# files.

Addressing Review Comments

  • Remove all non Format only code (i.e. changes to clang/Basic and clang/Lexer to support verbatim interpolated strings C# 6)
  • For the most part the need to for them is removed by merging of tokens during the FormatLexer phase
  • There is one obscure failure scenario, but for a first pass I think it can be ignored (tests commented out) where a \ is used unescaped just before a " (because of paths can be more common than you think)
    • string s = @"ABC\" + ToString("B");";
Mar 21 2019, 3:06 AM · Restricted Project, Restricted Project
Herald added a project to D42034: [clang-format] In tests, expected code should be format-stable: Restricted Project.
Mar 21 2019, 1:55 AM · Restricted Project

Mar 20 2019

MyDeveloperDay committed rG7c6ce35c1d21: [clang-format][NFC] fix release notes build issue (authored by MyDeveloperDay).
[clang-format][NFC] fix release notes build issue
Mar 20 2019, 2:04 PM
MyDeveloperDay committed rG701a0d7e47ca: [clang-format] BeforeHash added to IndentPPDirectives (authored by MyDeveloperDay).
[clang-format] BeforeHash added to IndentPPDirectives
Mar 20 2019, 1:50 PM
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

The cost is financial, as it's developer time, which costs real money to companies. In the end, to support this, people like myself who are doing this as part of their job spend time that they'd otherwise spend to make other things better that might be more important.

Mar 20 2019, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

Sorry for the spam:

  • write this a little better
Mar 20 2019, 10:42 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

Addressing code review comment

@klimek I think is what you meant, a much smaller and neater version of what I had before.
Mar 20 2019, 10:37 AM · Restricted Project, Restricted Project