Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (407 w, 2 d)
Roles
Administrator

Recent Activity

Yesterday

MyDeveloperDay added a comment to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.

did you consider a case where the case falls through? (i.e. no return)

"case log::info :    return \"info\";\n"
"case log::warning :\n"
"default :           return \"default\";\n"

That's a great point. I didn't really consider this, and currently this particular case won't align the case statements if they have an empty case block, however if you had some tokens (e.g. // fallthrough) it would. It's not immediately clear to me what the expectation would be. I guess to align as if there was an invisible trailing token, but it's a bit awkward if the cases missing a body are the 'long' cases that push out the alignment. Also, I don't think it's possible to use AlignTokens and get this behavior, as there is no token on those lines to align, so it's not straightforward to handle. I guess I'll be curious to see if there is feedback or cases where this behavior is desired, and if so, I can look into adding that functionality later. Since right now it would involve a completely custom AlignTokens clone, my preference would be to just leave this as not supported.

Wed, Jun 7, 2:28 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D152305: [clang-format] Add the KeepEmptyLinesAtEOF option.

LGTM

Wed, Jun 7, 2:24 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 5

MyDeveloperDay added a comment to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.

did you consider a case where the case falls through? (i.e. no return)

Mon, Jun 5, 1:12 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.
Mon, Jun 5, 1:09 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.

Apart from the documentation this looks fine.. thats probably outside the scope of this change

Mon, Jun 5, 1:07 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.
Mon, Jun 5, 1:05 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 2

MyDeveloperDay accepted D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective.
Fri, Jun 2, 2:22 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 1

MyDeveloperDay added inline comments to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.
Thu, Jun 1, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 31

MyDeveloperDay added inline comments to D151761: clang-format: Add AlignConsecutiveShortCaseStatements.
Wed, May 31, 3:19 PM · Restricted Project, Restricted Project, Restricted Project

Sun, May 28

MyDeveloperDay accepted D151632: [clang-format] Parse the Verilog language option in configuration.
Sun, May 28, 9:23 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 26

MyDeveloperDay accepted D151578: [Format/ObjC] Support NS_ASSUME_NONNULL_BEGIN and FOUNDATION_EXPORT in ObjC language guesser.

LGTM

Fri, May 26, 4:30 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 24

MyDeveloperDay added a comment to D151047: [clang-format] Fix indentation for selective formatting..

I think we need to extract the context of the test from RenameTests to ensure we have it covered here. I don't personally normally run the entire LLVM suite.

Wed, May 24, 12:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D151145: Add disabled unittest reproducing TextProto formatting issue..

We don't normally land broken tests, even if they are disabled, its better for us if we get a fix at the same time ;-)

Wed, May 24, 12:11 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 22

MyDeveloperDay accepted D151047: [clang-format] Fix indentation for selective formatting..

Thank you for the indepth explaination in https://github.com/llvm/llvm-project/issues/59178, that was really helpful for me trying to understand what the problem was.

Mon, May 22, 1:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, May 16

MyDeveloperDay accepted D150629: [clang-format] Don't allow template to be preceded by closing brace.
Tue, May 16, 3:15 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D150539: [clang-format] Handle <chrono> ud suffixes in IntegerLiteralSeparator.
Tue, May 16, 2:28 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D150614: [clang-format] Ignore first token when finding MustBreak.
Tue, May 16, 2:26 AM · Restricted Project, Restricted Project, Restricted Project

Sun, May 14

MyDeveloperDay added inline comments to D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes.
Sun, May 14, 8:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D150506: Migrate {starts,ends}with_insensitive to {starts,ends}_with_insensitive (NFC).

no concerns from the clang-format front.

Sun, May 14, 8:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D145262: [clang-format] Treat AttributeMacros more like attribute macros.
Sun, May 14, 8:26 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 11

MyDeveloperDay added inline comments to D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes.
Thu, May 11, 2:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, May 9

MyDeveloperDay accepted D150116: clang-format: [JS] support import/export type.
Tue, May 9, 10:41 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes.

Interesting

Tue, May 9, 10:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 3 2023

MyDeveloperDay added inline comments to D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values.
May 3 2023, 11:19 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values.

ok! I'm not a massive lambda expert, but aren't we passing by const reference e.g. const FormatStyle &Style, can someone give me a lession as to why it thinks its by value? maybe I'm looking at the wrong "pass by"

May 3 2023, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the summary of D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values.
May 3 2023, 11:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values.

Can you link to the Coverity issue so we can see what it was complaining about?

May 3 2023, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment.
May 3 2023, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment.

Thanks for the patch...this tells me people are starting to use this feature in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) which means you have the code modifying features perhaps on my default...

May 3 2023, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

Just an update on this, it works well but some of the cases are not tolerant to comments, I'm working my way through those issues

May 3 2023, 12:11 AM · Restricted Project, Restricted Project, Restricted Project

May 1 2023

MyDeveloperDay added inline comments to D149562: [clang-format] Stop comment disrupting indentation of Verilog ports.
May 1 2023, 7:40 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters.
May 1 2023, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D149561: [clang-format] Recognize Verilog edge identifiers.

Could you add anotator tests?

May 1 2023, 6:14 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2023

MyDeveloperDay accepted D149352: [clang-format] Recognize Verilog type dimension in module header.
Apr 28 2023, 12:53 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2023

MyDeveloperDay added inline comments to D149088: [clang-format] Add run-clang-format.py script..
Apr 25 2023, 5:16 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D149088: [clang-format] Add run-clang-format.py script..

is it possible to pass other arguments like -n if not running in place is there any protection from prevent stdout/stderr from overlapping..?

Apr 25 2023, 5:14 AM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2023

MyDeveloperDay accepted D148484: [clang-format] Correctly format goto labels followed by blocks.
Apr 24 2023, 10:41 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D145262: [clang-format] Treat AttributeMacros more like attribute macros.
Apr 24 2023, 2:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D145262: [clang-format] Treat AttributeMacros more like attribute macros.
Apr 24 2023, 2:00 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters.
Apr 24 2023, 12:15 AM · Restricted Project, Restricted Project, Restricted Project

Apr 20 2023

MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

Handle the case

Apr 20 2023, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay planned changes to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

There is another case I need to cover

Apr 20 2023, 8:08 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

Address review comment, add convenience functions to simplify conditions

Apr 20 2023, 5:57 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D148777: [clang-format] Hanlde leading whitespaces for JSON files.

LGTM

Apr 20 2023, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2023

MyDeveloperDay added a comment to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

In my C# project, these settings give me just what we tend to use.

Apr 19 2023, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

Sorry had a clang-format reflow comments moment, revert the unrelated comment changes
simplify the if's a little

Apr 19 2023, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

Adds additional options to give us much greater control over how we format C# properties especially auto properties

Apr 19 2023, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

There is more to this than meets the eye.. what we have so far, from existing AfterFunction use and the propsed here AfterCSharpProperty is...

Apr 19 2023, 3:50 AM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2023

MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

upload the correct patch file

Apr 18 2023, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

add init support and fix indentation issue when only one property is defined but the is an auto-property

Apr 18 2023, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.
public Foo {
    set;
    get;
}

At least from my experience, the getter is specified before the setter, though I'm unsure how important this is in your eyes.

Apr 18 2023, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay planned changes to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

need to handle init;
need to handle public|private|internal accessors

Apr 18 2023, 5:18 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

Address review comments, still would like to solve the indenting issue.

Apr 18 2023, 3:09 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay committed rG799b794d7699: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable (authored by MyDeveloperDay).
[clang-format] C# short ternary operator misinterpreted as a CSharpNullable
Apr 18 2023, 2:19 AM · Restricted Project, Restricted Project
MyDeveloperDay closed D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable.
Apr 18 2023, 2:19 AM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2023

MyDeveloperDay updated the diff for D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable.

simplify negative if

Apr 17 2023, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay committed rG63395cb0b69d: [clang-format] CSharp don't allow there not to be a space between `is` and `[` (authored by MyDeveloperDay).
[clang-format] CSharp don't allow there not to be a space between `is` and `[`
Apr 17 2023, 11:40 AM · Restricted Project, Restricted Project
MyDeveloperDay closed D148472: [clang-format] CSharp don't allow there not to be a space between `is` and `[`.
Apr 17 2023, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D143870: [clang-format] Remove all include duplicates not only those in the same block.

Regarding the comment that I must not change existing tests: I think this rule is too strict, because those tests are mostly regression tests.
But a regression tests does not test for correctness. So if a test had already a wrong assumption, it must be changeable.

Apr 17 2023, 5:26 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.
Apr 17 2023, 2:53 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a reviewer for D132256: [clang-format] Add DefinitionBlockSpacing option: rymiel.

Cloud you include a test that contains multiple levels of nested scope, I'm assuming we won't add an additonal line at every {} level (or will we?)

Apr 17 2023, 12:43 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D143870: [clang-format] Remove all include duplicates not only those in the same block.

I know it might not seem an obvious use case but there really isn't a requirement to not include header files more than once.. imagine if I have

Apr 17 2023, 12:40 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D148484: [clang-format] Correctly format goto labels followed by blocks.
Apr 17 2023, 12:35 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.
Apr 17 2023, 12:14 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2023

MyDeveloperDay updated subscribers of D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable.
Apr 16 2023, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable.

@exv any thoughts on this one? given that you were the author of D101860: [clang-format] Fix C# nullable-related errors and
@jbcoe as you were the author of D75983: [clang-format] Improved identification of C# nullables

Apr 16 2023, 10:06 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable: exv.
Apr 16 2023, 10:06 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable.

The exclusions are not complete for example cond? foo() : "B"; would still fail. but this moves us a little closer

Apr 16 2023, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested review of D148473: [clang-format] C# short ternary operator misinterpreted as a CSharpNullable.
Apr 16 2023, 10:01 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested review of D148472: [clang-format] CSharp don't allow there not to be a space between `is` and `[`.
Apr 16 2023, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

re clang-format

Apr 16 2023, 9:08 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

for default set;get or get;set for when AfterCSharpProperty is true,

Apr 16 2023, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.

I'm not convinced AfterCSharpProperty is a good name, open for suggestions

Apr 16 2023, 8:23 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.
Apr 16 2023, 8:21 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.
Apr 16 2023, 8:20 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested review of D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping.
Apr 16 2023, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D148447: [clang-format] Fix regression with AlignTrailingComments set to true.

If this was the functionality pre 16 then LGTM

Apr 16 2023, 3:38 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D148437: [clang-format] Dont interpret variable named interface as keyword for C++.
Apr 16 2023, 2:10 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2023

MyDeveloperDay added a comment to D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing.

we should be good now

Thanks! I really like these new rules!

Apr 14 2023, 12:39 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D137327: [clang-format] Handle object instansiation in if-statements.

This was released in LLVM 16.0.0.

The prior behaviour was there before, it’s marked in GitHub as a regression, can you please revert, we’ll mark the issue to be cherry picked, then let’s go back and rework a solution that means your issue can be resolved

Sorry this slipped under my radar. Can you please push a revert to main and then file a issue to backport this to the release branch if it's something you still want to do. It's hard for me to keep track of the issues unless they are added to the 16.x milestone.

Apr 14 2023, 12:38 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2023

MyDeveloperDay added inline comments to D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters.
Apr 13 2023, 7:02 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay removed reviewers for D144328: [libc++][format][chrono] Addresses LWG3842.: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
Apr 13 2023, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay removed reviewers for D146240: [libc++][format] Use granularized charconv.: rymiel, HazardyKnusperkeks, MyDeveloperDay, owenpan.
Apr 13 2023, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing.

we should be good now

Apr 13 2023, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay removed reviewers for D144331: [libc++][format] Implements formatter thread::id.: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
Apr 13 2023, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing.

@MyDeveloperDay We keep getting "spammed" by [libc++][format] patches. Can you delete the rule in H987:

"field": "differential.revision.title",
"condition": "contains",
"value": "[Format]"

or change "contains" to something equivalent to "starts with"?

Apr 13 2023, 6:46 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D148200: [clang-format] Correctly indent comment above finalized PPDirective.

LGTM

Apr 13 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2023

MyDeveloperDay added a comment to D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters.

is it possible to point to a github issue that this related to in the review summary, if not please can you make one so we can track the issue its trying to solve

Apr 12 2023, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay retitled D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters from Add a new clang-format option AlwaysBreakBeforeFunctionParameters to [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters.
Apr 12 2023, 5:48 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay accepted D146101: [clang-format] Add BracedInitializerIndentWidth option..

If all comments and concerns are done, then I'm inclined to accept, but I'd like @owenpan and @HazardyKnusperkeks to give their opinion before we land this.

Apr 12 2023, 5:47 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2023

MyDeveloperDay accepted D148024: [clang-format] Don't modify template arguments on the LHS of assignment.
Apr 11 2023, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D147969: Add InsertBraces to ChromiumStyle.
Apr 11 2023, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D147969: Add InsertBraces to ChromiumStyle.
Apr 11 2023, 12:50 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D147969: Add InsertBraces to ChromiumStyle.

RFC https://groups.google.com/g/llvm-dev/c/wka1Bnrd-aU?pli=1

Apr 11 2023, 12:41 AM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2023

MyDeveloperDay accepted D147894: [clang-format][doc] SortIncludes documentation: remove contradiction in its description.

Yes I didn’t see them repeated below

Apr 10 2023, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D147969: Add InsertBraces to ChromiumStyle.

These features tend to have an additional performance penalty that not all may want to pay, even if they did base their style on your style. I.E. chromium isn’t likely the only ones using chromium style

Apr 10 2023, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D147969: Add InsertBraces to ChromiumStyle.

This was the agreement reached when we pushed for clang format to start being allowed to add or rearrange tokens, I.E. in this case we add {} as such we could, as you saw yourselves make mistakes if our assumptions are not 100% correct and break code, we prefer people opt into this by turning it on in your .clang-format file

Apr 10 2023, 4:16 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D147969: Add InsertBraces to ChromiumStyle.
Apr 10 2023, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D93240: [clang-format] Add SpaceBeforeCaseColon option.

A goto label isn't affected by this option. Is it intentional?

Apr 10 2023, 7:36 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D147894: [clang-format][doc] SortIncludes documentation: remove contradiction in its description.

Sorry I don’t get how this change helps. Removing the option values doesn’t make it clearer IMHO

Apr 10 2023, 1:23 AM · Restricted Project, Restricted Project, Restricted Project