Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (241 w, 13 h)
Roles
Administrator

Recent Activity

Thu, Mar 26

MyDeveloperDay added a comment to D33029: [clang-format] add option for dangling parenthesis.

@MyDeveloperDay Is someone working on fixing the breaking tests and merging it? I need this feature so if someone isn't working on it already, I can take it.

Thu, Mar 26, 3:47 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D76781: [clang-format] Fix segfault when printing diagnostic.

see the discussion at D68969: [clang-format] Remove the dependency on frontendD69854: [clang-format] [RELAND] Remove the dependency on frontendD68554: [clang-format] Proposal for clang-format to give compiler style warnings

Thu, Mar 26, 8:06 AM · Restricted Project
MyDeveloperDay requested changes to D76781: [clang-format] Fix segfault when printing diagnostic.

We specifically dropped clangFrontEnd from clang-format, please don't include it again

Thu, Mar 26, 8:06 AM · Restricted Project
MyDeveloperDay requested changes to D76197: clang-format: Use block indentation for braced initializations.

New implementation that breaks fewer tests.

Thu, Mar 26, 8:06 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Could the default be Style.IndentExternBlock = Style.BraceWrapping.AfterExternBlock

Thu, Mar 26, 7:33 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107).

LGTM

Thu, Mar 26, 7:33 AM · Restricted Project

Wed, Mar 25

MyDeveloperDay added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Wed, Mar 25, 1:35 AM · Restricted Project, Restricted Project

Tue, Mar 24

MyDeveloperDay added a comment to D76621: [clang-format] No space inserted between commas in C#.

nice, thank you.

Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay removed a reviewer for D53482: Add clang-format stability check with FormatTests: MyDeveloperDay.
Tue, Mar 24, 2:07 AM · Restricted Project
MyDeveloperDay added a comment to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.

is there overlap here D76197: clang-format: Use block indentation for braced initializations

Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D76197: clang-format: Use block indentation for braced initializations: fickert.
Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D76197: clang-format: Use block indentation for braced initializations: krasimir, mitchell-stellar.
Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.

I want to believe that it was a mistake on the original developers part, but I just can't tell.

Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Not sure if tagging is considered rude, I figure that @MyDeveloperDay's notification fell off your radar.

Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75791: [clang-format] Added new option IndentExternBlock.

@MarcusJohnson91 To get a review past its better that you mark the comments as done so the reviewers know when the comments have been addressed and not missed. (this is important as the number of comments grows)

Tue, Mar 24, 1:35 AM · Restricted Project, Restricted Project

Sat, Mar 14

MyDeveloperDay added reviewers for D75791: [clang-format] Added new option IndentExternBlock: krasimir, klimek, mitchell-stellar.
Sat, Mar 14, 4:47 AM · Restricted Project, Restricted Project

Wed, Mar 11

MyDeveloperDay added a comment to D75791: [clang-format] Added new option IndentExternBlock.

your patch seems to be missing the other files

Wed, Mar 11, 1:01 PM · Restricted Project, Restricted Project

Sat, Mar 7

MyDeveloperDay added a comment to D75791: [clang-format] Added new option IndentExternBlock.

you need documentation and release note changes too

Sat, Mar 7, 6:20 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Sat, Mar 7, 6:20 AM · Restricted Project, Restricted Project

Thu, Mar 5

MyDeveloperDay added a project to D75675: [clang-format] do not insert spaces around inline asm symbolic names: Restricted Project.
Thu, Mar 5, 7:40 AM · Restricted Project, Restricted Project

Tue, Mar 3

MyDeveloperDay added a comment to D75194: [clang-format] Do not merge very long C# automatic properties.

@krasimir, well I learned something new, so thanks for taking the time to explain that to help improve our understanding.

Tue, Mar 3, 1:47 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75465: [clang-format] Do not merge target-name and : for C# attributes.

This feels better than merging

Tue, Mar 3, 3:04 AM · Restricted Project, Restricted Project

Mar 1 2020

MyDeveloperDay requested changes to D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.

This needs a full context diff, before we can even look at it properly.

Mar 1 2020, 2:37 PM · Restricted Project, Restricted Project

Feb 28 2020

MyDeveloperDay accepted D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..

LGTM, thank you for adding the extra test, please mark the inline comments as done

Feb 28 2020, 1:04 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

LGTM

Feb 28 2020, 1:04 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D75261: [clang-format] Recognize C# nullable types.
Feb 28 2020, 1:04 AM · Restricted Project, Restricted Project

Feb 25 2020

MyDeveloperDay accepted D75006: [clang-format] Wrap lines for C# property accessors.

LGTM

Feb 25 2020, 5:47 AM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation: sammccall, mitchell-stellar, klimek.
Feb 25 2020, 12:32 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.

I tend to agree with your assessment, I think its worth waiting for some others to comment.

Feb 25 2020, 12:32 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..

I think its look good, please add the extra tests, then lets give people a couple of days

Feb 25 2020, 12:23 AM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.: krasimir, mitchell-stellar, sammccall.
Feb 25 2020, 12:23 AM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.: klimek.
Feb 25 2020, 12:23 AM · Restricted Project, Restricted Project

Feb 24 2020

MyDeveloperDay updated subscribers of D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.

Is this intentional, or is it an oversight?

Feb 24 2020, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.
Feb 24 2020, 5:46 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay abandoned D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.
Feb 24 2020, 4:15 AM · Restricted Project
MyDeveloperDay abandoned D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style .
Feb 24 2020, 4:14 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay requested changes to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.
Feb 24 2020, 4:14 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.

you need to add any diff as a full context diff (normally by adding -U 9999999) to the diff command

Feb 24 2020, 4:09 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation.

If you are changing unit tests then I'm nervous, imagine if this many tests change what the impact is on a large code base. I think we need to understand more about why you are making this change and why you think its ok to change/remove existing tests which assert some behavior which up to now we have considered correct.

Feb 24 2020, 4:05 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..

You need to add unit tests

Feb 24 2020, 4:05 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops..
Feb 24 2020, 4:05 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D75006: [clang-format] Wrap lines for C# property accessors.

This LGTM, thank you for the patch

Feb 24 2020, 4:05 AM · Restricted Project, Restricted Project

Feb 23 2020

MyDeveloperDay added inline comments to D75006: [clang-format] Wrap lines for C# property accessors.
Feb 23 2020, 6:43 AM · Restricted Project, Restricted Project

Feb 13 2020

MyDeveloperDay added a comment to rGfa0118e6e588: [clang-format] Add new option BeforeLambdaBody in Allman style..

maybe a unix2dos thing going on on the release notes

Feb 13 2020, 1:29 PM

Feb 12 2020

MyDeveloperDay added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Correct follow that description on how to request commit access

Feb 12 2020, 1:47 AM · Restricted Project, Restricted Project

Feb 11 2020

MyDeveloperDay accepted D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

This patch is nearly 2 years old, and there has been a lot of discussion and I can see you've put a lot of work into adding the tests which prove it works, from my perspective this LGTM as long as you are prepared to help resolve any issues that might come up as a result of this change.

Feb 11 2020, 12:59 AM · Restricted Project, Restricted Project

Feb 9 2020

MyDeveloperDay accepted D74265: [clang-format] Improve handling of C# attributes.

LGTM, thanks

Feb 9 2020, 8:47 AM · Restricted Project, Restricted Project

Feb 5 2020

MyDeveloperDay accepted D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

In the absence of any other comments, This LGTM, this may help to resolve D68569: [clang-format] Also look for .{ext}.clang-format file, I think I prefer this solution.

Feb 5 2020, 12:11 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D74043: [clang-format] Do not treat C# attribute targets as labels.

LGTM, thanks for the patch (I've seen this in the wild where the AssemblyInfo.cs gets a bit messed up.

Feb 5 2020, 12:10 PM · Restricted Project, Restricted Project

Feb 4 2020

MyDeveloperDay added a comment to D73977: [clang-format] Allow a comment to follow a C# attribute specifier.

Nit: please give the revision a description

Feb 4 2020, 10:12 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D73977: [clang-format] Allow a comment to follow a C# attribute specifier.
Feb 4 2020, 10:12 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D73354: clang-format: insert trailing commas into containers..

This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this hasn't closed automatically).

Feb 4 2020, 3:21 AM · Restricted Project, Restricted Project

Feb 3 2020

MyDeveloperDay added a comment to rGdc04c54fc1f6: clang-format: [JS] document InsertTrailingCommas..

Did you mean to commit D73354: clang-format: insert trailing commas into containers. too?

Feb 3 2020, 12:56 AM

Feb 1 2020

MyDeveloperDay committed rG70c98671fa7b: [clang-format] Add option for not breaking line before ObjC params (authored by MyDeveloperDay).
[clang-format] Add option for not breaking line before ObjC params
Feb 1 2020, 9:42 AM
MyDeveloperDay closed D70926: [clang-format] Add option for not breaking line before ObjC params.
Feb 1 2020, 9:42 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D73768: clang-format: [JS] document InsertTrailingCommas..

LGTM thank you

Feb 1 2020, 3:39 AM · Restricted Project

Jan 30 2020

MyDeveloperDay added a comment to D73354: clang-format: insert trailing commas into containers..

Nit: don't forget the ClangFormatStyleOption.rst and ReleaseNote.rst changes

Jan 30 2020, 12:22 PM · Restricted Project, Restricted Project
MyDeveloperDay accepted D73354: clang-format: insert trailing commas into containers..

I'm happy if you are, I think given that you've really been one of the main contributors of clang-format [JS] for the last number of years you are the best person to probably assess the impact on Javascript code.

Jan 30 2020, 12:22 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D73622: [clang-format] Improve support for multiline C# strings.

these are great patches you are making...

Jan 30 2020, 6:04 AM · Restricted Project, Restricted Project

Jan 28 2020

MyDeveloperDay added a comment to D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst (if there are any changes because you modified Format.h).

Jan 28 2020, 11:58 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D73354: clang-format: insert trailing commas into containers..
Jan 28 2020, 11:58 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D73354: clang-format: insert trailing commas into containers..

Nit: Could you add an entry for ReleaseNotes.rst and regenerate the ClangFormatStyleOption.rst with the docs/tools/dump_style.py

Jan 28 2020, 6:22 AM · Restricted Project, Restricted Project

Jan 27 2020

MyDeveloperDay added a comment to D73492: [clang-format] Handle quotes and escaped braces in C# interpolated strings.

Just for reference, take a look at D58404: [clang-format] Add basic support for formatting C# files especially the historical diff

Jan 27 2020, 10:28 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D73492: [clang-format] Handle quotes and escaped braces in C# interpolated strings.

This looks good, I had lots of problems when I first started the C# support around this which the initial C# support tried to address by adding support in the lexer, but we pulled back from that implementation. So its no surprise to me we are hitting a few errors in this area, one issue I've had problems with is a string ending with \ e.g.

Jan 27 2020, 10:00 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D73354: clang-format: insert trailing commas into containers..

FYI maybe related D33029: [clang-format] add option for dangling parenthesis

Jan 27 2020, 6:49 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D70926: [clang-format] Add option for not breaking line before ObjC params.
Jan 27 2020, 6:49 AM · Restricted Project, Restricted Project
MyDeveloperDay added a project to D70926: [clang-format] Add option for not breaking line before ObjC params: Restricted Project.
Jan 27 2020, 6:49 AM · Restricted Project, Restricted Project
MyDeveloperDay added a project to D73354: clang-format: insert trailing commas into containers.: Restricted Project.
Jan 27 2020, 6:49 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D73335: clang-format: [JS] options for arrow functions..
Jan 27 2020, 6:49 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D73354: clang-format: insert trailing commas into containers..

I'm a little uncomfortable about all the tests changing, and I'm unsure if we should be changing the default behaviour.

Jan 27 2020, 12:42 AM · Restricted Project, Restricted Project

Jan 26 2020

MyDeveloperDay added a project to D73353: [clang-format] Handle escaped " in C# string-literals: Restricted Project.
Jan 26 2020, 2:18 AM · Restricted Project, Restricted Project

Jan 23 2020

MyDeveloperDay awarded rG1e0174a93cfd: Treat C# `using` as a control statement a Like token.
Jan 23 2020, 4:59 AM

Jan 22 2020

MyDeveloperDay requested changes to D72144: Treat C# `using` as a control statement.

Removed test snippets that did not exercise new code.

Jan 22 2020, 12:05 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D70926: [clang-format] Add option for not breaking line before ObjC params.
Jan 22 2020, 11:56 AM · Restricted Project, Restricted Project

Jan 21 2020

MyDeveloperDay added a comment to D72911: clang-format: fix spacing in `operator const char*()`.

@krasimir Thanks for fixing this, as it looks like I broke it.. its much appreciated

Jan 21 2020, 2:47 AM · Restricted Project

Jan 20 2020

MyDeveloperDay added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

I think if you can fix the missing documentation it looks pretty good to go.

Jan 20 2020, 11:10 PM · Restricted Project, Restricted Project
MyDeveloperDay retitled D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style) from [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style) to [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).
Jan 20 2020, 11:10 PM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style): MyDeveloperDay.
Jan 20 2020, 11:10 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

Please can you regenerate the ClangFormatStyleOptions.rst using docs/tools/dump_style.py and add an entry into the clang release notes in the clang-format section

Jan 20 2020, 11:01 PM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D71512: [clang-format] Fix short block when braking after control statement.
Jan 20 2020, 7:24 AM · Restricted Project, Restricted Project

Jan 19 2020

MyDeveloperDay updated subscribers of D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements.

I know that 10.0 was branch recently. Any chance this can make it over?

Jan 19 2020, 11:58 PM · Restricted Project, Restricted Project
MyDeveloperDay added a project to D72326: [clang-format] Rebased on master: Add option to specify explicit config file: Restricted Project.
Jan 19 2020, 8:13 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGea2be452542c: [clang-format] Expand the SpacesAroundConditions option to include catch… (authored by MyDeveloperDay).
[clang-format] Expand the SpacesAroundConditions option to include catch…
Jan 19 2020, 8:04 AM
MyDeveloperDay closed D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements.
Jan 19 2020, 8:04 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D70926: [clang-format] Add option for not breaking line before ObjC params.

I need you to rebase this fix, also you need to clang-format it as well. Format.h/ContinuationIndenter.cpp and FormatTestObjC.cpp all failed clang-format check

Jan 19 2020, 8:03 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rG14c044756e77: [clang-format] Add IndentCaseBlocks option (authored by MyDeveloperDay).
[clang-format] Add IndentCaseBlocks option
Jan 19 2020, 7:54 AM
MyDeveloperDay closed D72276: [clang-format] Add IndentCaseBlocks option.
Jan 19 2020, 7:54 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGd82adf328fb5: Allow space after C-style cast in C# code (authored by MyDeveloperDay).
Allow space after C-style cast in C# code
Jan 19 2020, 7:45 AM
MyDeveloperDay closed D72150: Allow space after C-style cast in C# code.
Jan 19 2020, 7:45 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements.

LGTM

Jan 19 2020, 4:41 AM · Restricted Project, Restricted Project

Jan 16 2020

MyDeveloperDay accepted D72827: clang-format: [JS] Handle keyword-named methods..

LGTM thanks for the patch

Jan 16 2020, 6:23 AM · Restricted Project, Restricted Project

Jan 15 2020

MyDeveloperDay updated subscribers of D72326: [clang-format] Rebased on master: Add option to specify explicit config file.

In principle, I think this is something that might help a lot of people as I've seen people asking for a better mechanism to be able to load a centrally stored .clang-format file.

Jan 15 2020, 4:38 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D72401: Fixes for spaces around C# object initializers.
Jan 15 2020, 4:29 AM · Restricted Project, Restricted Project

Jan 9 2020

MyDeveloperDay accepted D72401: Fixes for spaces around C# object initializers.

LGTM, thanks once again for the C# patch!

Jan 9 2020, 12:16 AM · Restricted Project, Restricted Project

Jan 8 2020

MyDeveloperDay accepted D72276: [clang-format] Add IndentCaseBlocks option.
Jan 8 2020, 5:23 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D72276: [clang-format] Add IndentCaseBlocks option.

This LGTM, thanks for the patch

Jan 8 2020, 5:23 AM · Restricted Project, Restricted Project

Jan 7 2020

MyDeveloperDay added inline comments to D72216: [clang-format] [PR44189] Remove space between identifier and scope resolution operator unless the identifier is a macro.
Jan 7 2020, 3:35 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D72276: [clang-format] Add IndentCaseBlocks option.
Jan 7 2020, 12:49 PM · Restricted Project, Restricted Project