Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (187 w, 4 d)

Recent Activity

Today

MyDeveloperDay committed rGf5e52738fe9d: [clang-format] Keep protobuf "package" statement on one line (authored by MyDeveloperDay).
[clang-format] Keep protobuf "package" statement on one line
Sat, Mar 23, 7:44 AM
MyDeveloperDay committed rGc6deae452197: Clang-format: add finer-grained options for putting all arguments on one line (authored by MyDeveloperDay).
Clang-format: add finer-grained options for putting all arguments on one line
Sat, Mar 23, 7:39 AM
MyDeveloperDay committed rGa87ba1c59cb9: [clang-format] correctly format protobuf fields named "enum". (authored by MyDeveloperDay).
[clang-format] correctly format protobuf fields named "enum".
Sat, Mar 23, 7:24 AM
MyDeveloperDay accepted D59627: [clang-format] Keep protobuf "package" statement on one line.

LGTM

Sat, Mar 23, 7:23 AM · Restricted Project, Restricted Project

Yesterday

MyDeveloperDay committed rGccc6f838f748: [clang-format][NFC] correct the release notes (authored by MyDeveloperDay).
[clang-format][NFC] correct the release notes
Fri, Mar 22, 3:47 PM
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

@lebedev.ri Are we talking about a general ideology of the long term cost to allow any new things in? or to not allow things in this specific case?

Fri, Mar 22, 12:00 PM · Restricted Project, Restricted Project
MyDeveloperDay created D59684: [clang-format] [PR41187] moves Java import statements to the wrong location if code contains statements that start with the word import.
Fri, Mar 22, 3:01 AM · Restricted Project

Thu, Mar 21

MyDeveloperDay committed rGcbb726d0c538: [clang-format] Add basic support for formatting C# files (authored by MyDeveloperDay).
[clang-format] Add basic support for formatting C# files
Thu, Mar 21, 6:10 AM
MyDeveloperDay added inline comments to D58404: [clang-format] Add basic support for formatting C# files.
Thu, Mar 21, 3:51 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D58404: [clang-format] Add basic support for formatting C# files.

Address comment nits

Thu, Mar 21, 3:51 AM · Restricted Project, Restricted Project
MyDeveloperDay added a project to D59528: [clang-tidy] Expand modular headers for PPCallbacks: Restricted Project.
Thu, Mar 21, 3:26 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a project to D59629: [clang-format] correctly format protobuf fields named "enum".: Restricted Project.
Thu, Mar 21, 3:22 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D59627: [clang-format] Keep protobuf "package" statement on one line.
Thu, Mar 21, 3:20 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D59629: [clang-format] correctly format protobuf fields named "enum"..

LGTM

Thu, Mar 21, 3:16 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D58404: [clang-format] Add basic support for formatting C# files.

Addressing Review Comments

  • Remove all non Format only code (i.e. changes to clang/Basic and clang/Lexer to support verbatim interpolated strings C# 6)
  • For the most part the need to for them is removed by merging of tokens during the FormatLexer phase
  • There is one obscure failure scenario, but for a first pass I think it can be ignored (tests commented out) where a \ is used unescaped just before a " (because of paths can be more common than you think)
    • string s = @"ABC\" + ToString("B");";
Thu, Mar 21, 3:06 AM · Restricted Project, Restricted Project
Herald added a project to D42034: [clang-format] In tests, expected code should be format-stable: Restricted Project.
Thu, Mar 21, 1:55 AM · Restricted Project

Wed, Mar 20

MyDeveloperDay committed rG7c6ce35c1d21: [clang-format][NFC] fix release notes build issue (authored by MyDeveloperDay).
[clang-format][NFC] fix release notes build issue
Wed, Mar 20, 2:04 PM
MyDeveloperDay committed rG701a0d7e47ca: [clang-format] BeforeHash added to IndentPPDirectives (authored by MyDeveloperDay).
[clang-format] BeforeHash added to IndentPPDirectives
Wed, Mar 20, 1:50 PM
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

The cost is financial, as it's developer time, which costs real money to companies. In the end, to support this, people like myself who are doing this as part of their job spend time that they'd otherwise spend to make other things better that might be more important.

Wed, Mar 20, 11:05 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

Sorry for the spam:

  • write this a little better
Wed, Mar 20, 10:42 AM · Restricted Project
MyDeveloperDay updated the diff for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

Addressing code review comment

@klimek I think is what you meant, a much smaller and neater version of what I had before.
Wed, Mar 20, 10:37 AM · Restricted Project
MyDeveloperDay added a comment to D52150: [clang-format] BeforeHash added to IndentPPDirectives.

I checked out the git repository and applied the patch to head and reran all tests.
The diff produced by git is basically the same, should I upload the new diff?

Wed, Mar 20, 10:28 AM · Restricted Project
MyDeveloperDay committed rGdb1974197072: [clang-format] structured binding in range for detected as Objective C (authored by MyDeveloperDay).
[clang-format] structured binding in range for detected as Objective C
Wed, Mar 20, 10:11 AM
MyDeveloperDay added inline comments to D58404: [clang-format] Add basic support for formatting C# files.
Wed, Mar 20, 10:02 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Wed, Mar 20, 10:02 AM · Restricted Project

Tue, Mar 19

MyDeveloperDay added inline comments to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.
Tue, Mar 19, 11:58 AM · Restricted Project
MyDeveloperDay updated the diff for D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.

Address review comments
This may not be a more satisfactory solution but it at least now covers the other cases raised by @JonasToth
Add more tests around this area.

Tue, Mar 19, 11:56 AM · Restricted Project
MyDeveloperDay planned changes to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.
Tue, Mar 19, 8:42 AM · Restricted Project
MyDeveloperDay updated the diff for D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.

Minor modification to improve the [=] case

Tue, Mar 19, 8:34 AM · Restricted Project
MyDeveloperDay planned changes to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.

What happens on [=]() ..., direct capture [&Columns]()... and [Columns]()...?

Tue, Mar 19, 7:52 AM · Restricted Project
MyDeveloperDay added a project to D59546: [clang-format] structured binding in range for detected as Objective C: Restricted Project.
Tue, Mar 19, 7:42 AM · Restricted Project, Restricted Project
MyDeveloperDay created D59546: [clang-format] structured binding in range for detected as Objective C.
Tue, Mar 19, 7:42 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D55170: [clang-format]: Add NonEmptyParentheses spacing option.

(landed here too https://github.com/mydeveloperday/clang-experimental/releases)

Tue, Mar 19, 5:25 AM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D59292: [clang-format] messes up indentation when using JavaScript private fields and methods.

ping @mprobst,@mitchellwills noticed you just reviewed another clang-format-js commit, wondered if you were interested in reviewing this for me?, finding it hard to get any review traction.

Tue, Mar 19, 4:37 AM · Restricted Project
MyDeveloperDay created D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.
Tue, Mar 19, 3:59 AM · Restricted Project

Mon, Mar 18

MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

I don't think risk is what matters - in the end it's about cost, and cost is a very technical reason

Mon, Mar 18, 4:15 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Mon, Mar 18, 3:09 AM · Restricted Project

Sun, Mar 17

MyDeveloperDay added inline comments to D55170: [clang-format]: Add NonEmptyParentheses spacing option.
Sun, Mar 17, 3:21 PM · Restricted Project, Restricted Project

Sat, Mar 16

MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

I'm sorry for not having a positive answer here, but I'm not in favor of this change. The style rule looks like it introduces arbitrary complexity at a point where I don't understand at all how it matters. We cannot possibly support all style guides that come up with random variance. I do not think this option pulls its weight.

Sat, Mar 16, 2:17 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

I'm happy to be wrong, but In current master, SpaceBeforeCpp11BracedList is a boolean not an enum (but I think I've seen a review changing it somewhere which maybe isn't landed)

Sat, Mar 16, 1:44 AM · Restricted Project, Restricted Project

Fri, Mar 15

MyDeveloperDay added a comment to D40988: Clang-format: add finer-grained options for putting all arguments on one line.

nobody being able to make changes

Fri, Mar 15, 2:40 AM · Restricted Project
MyDeveloperDay created D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Fri, Mar 15, 2:22 AM · Restricted Project
MyDeveloperDay accepted D40988: Clang-format: add finer-grained options for putting all arguments on one line.

So @russellmcc you've been bumping along this road nicely for 6 months, doing what people say... pinging every week or so in order to get your code reviewed, and you are getting no response.

Fri, Mar 15, 1:32 AM · Restricted Project
MyDeveloperDay accepted D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range.

From what I can tell this looks OK as you seem to be mainly only passing down the boolean, my guess is that while most people don't use the -lines directly that often but it probably gets called by some of the formatting tools that work over selections, maybe something like git-clang-format

Fri, Mar 15, 1:01 AM · Restricted Project

Thu, Mar 14

MyDeveloperDay updated the diff for D58404: [clang-format] Add basic support for formatting C# files.

Remove non related clang-format changes
run git clang-format
Add a Microsoft style (trying to match most closely the more traditional Microsoft style used for C#)
This will allow, CSharp to be added to the config by

Thu, Mar 14, 3:09 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D52150: [clang-format] BeforeHash added to IndentPPDirectives.

@to-miz do you have permission to commit?

Thu, Mar 14, 12:36 PM · Restricted Project
MyDeveloperDay requested changes to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

Pulling this revision down to build it caused build issues with missing SBBLO_Always, could you investigate before committing?

Thu, Mar 14, 12:36 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

That works because the argument list is just tok::identifier and TT_StartOfName

Should we fix isStartOfName then?

In A<bool> or A<8> A should be TT_StartOfName, too, right?

Thu, Mar 14, 5:13 AM · Restricted Project
MyDeveloperDay added a comment to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

That works because the argument list is just tok::identifier and TT_StartOfName

Should we fix isStartOfName then?

In A<bool> or A<8> A should be TT_StartOfName, too, right?

Thu, Mar 14, 5:07 AM · Restricted Project
MyDeveloperDay added a comment to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

of course, this isn't legal

Thu, Mar 14, 4:56 AM · Restricted Project
MyDeveloperDay added a comment to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

That works because the argument list is just tok::identifier and TT_StartOfName

Thu, Mar 14, 4:26 AM · Restricted Project
MyDeveloperDay added a comment to D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.

Why did the numeric constant break this? Which path would the function run through?

Thu, Mar 14, 2:57 AM · Restricted Project
MyDeveloperDay added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Thu, Mar 14, 12:40 AM · Restricted Project
MyDeveloperDay added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Thu, Mar 14, 12:37 AM · Restricted Project, Restricted Project

Wed, Mar 13

MyDeveloperDay created D59332: [clang-format] AlignConsecutiveDeclarations fails with attributes.
Wed, Mar 13, 2:12 PM · Restricted Project
MyDeveloperDay added a reviewer for D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters: alexfh.
Wed, Mar 13, 1:24 PM · Restricted Project
MyDeveloperDay added a reviewer for D59292: [clang-format] messes up indentation when using JavaScript private fields and methods: alexfh.
Wed, Mar 13, 1:20 PM · Restricted Project
MyDeveloperDay created D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters.
Wed, Mar 13, 10:26 AM · Restricted Project
MyDeveloperDay created D59292: [clang-format] messes up indentation when using JavaScript private fields and methods.
Wed, Mar 13, 3:53 AM · Restricted Project
MyDeveloperDay committed rG15000a127a31: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an… (authored by MyDeveloperDay).
[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an…
Wed, Mar 13, 1:26 AM
MyDeveloperDay reopened D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Wed, Mar 13, 1:20 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGd74c055fe640: Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not… (authored by MyDeveloperDay).
Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not…
Wed, Mar 13, 1:14 AM
MyDeveloperDay added a comment to rG6d294f28e9a2: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an….

sorry incorrect files in the merge reverting...

Wed, Mar 13, 1:12 AM
MyDeveloperDay committed rG6d294f28e9a2: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an… (authored by MyDeveloperDay).
[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an…
Wed, Mar 13, 1:09 AM

Tue, Mar 12

MyDeveloperDay updated the diff for D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

run git clang-format

Tue, Mar 12, 3:39 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D59251: [Documentation] Proposal for plan to change variable names.
Tue, Mar 12, 7:49 AM · Restricted Project

Mon, Mar 11

MyDeveloperDay added a comment to D59210: clang-format: distinguish ObjC call subexpressions after r355434.

most of the cases that we were adding here were for a templated return types

Mon, Mar 11, 7:37 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D59210: clang-format: distinguish ObjC call subexpressions after r355434.

LGTM

Mon, Mar 11, 7:31 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Address review comment

  • add document and comment spelling and punctuation
  • add additional unit tests to show non compound else clause case
Mon, Mar 11, 2:41 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Address review comments

  • collapse two options into one
Mon, Mar 11, 1:21 AM · Restricted Project, Restricted Project

Sun, Mar 10

MyDeveloperDay added a comment to D33029: [clang-format] add option for dangling parenthesis.

Adding the unit tests lets us see how this option will work in various cases, it will let us understand that its not breaking anything else.

I personally don't like to see revisions like this sit for 2 years with nothing happening, I don't see anything wrong with this that would prevent it going in so I don't understand whats blocking it?,

if you had some tests and a release note I'd give it a LGTM (but as I've said before I'm not the code owner, but someone wanting to address defects and add capabilities. but I think we need to be able to move forward, people will object soon enough if they don't like it.)

Generally I don't understand why clang-format is so reluctant to change anything, As such we don't have many people involved and getting anything done (even defects) is extremely hard.

It looks like you met the criteria, and reviewers have been given ample opportunity to make an objection. the number of subscribers and like tokens would suggest this is wanted,

Please also add a line the in the release notes to say what you are adding. In the absence of any other constructive input all we can do is follow the guidance on doing a review, for what its worth I notice in the rest of LLVM there seems to be a much larger amount of commits that go in even without a review, I'm not sure what makes this area so strict, so reluctant to change especailly when revisions do seem to be reviewed.

I don't have any stake here, but i just want to point out that no tool (including clang-format)
will ever support all the things all the people out there will want it to support. But every
new knob is not just a single knob, it needs to work well with all the other existing knobs
(and all of the combination of knob params), and every new knob after that.

It's a snowball effect. Things can (and likely will, unless there is at least a *very* strict testing/quality policy
(which is https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options about))
get out of hand real quickly..

Just 2c.

Sun, Mar 10, 6:26 AM · Restricted Project
MyDeveloperDay planned changes to D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Does it make sense to allow AllowShortIfElseStatementsOnASingleLine to be enabled when AllowShortIfStatementsOnASingleLine is not?

Perhaps it would be better to have AllowShortIfStatementsOnASingleLine be represented by an enum with values Never, WithoutElse, Always. The old true/false values from config files prior to this change would need to be made to map to the appropriate enum keys.

Sun, Mar 10, 5:59 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D33029: [clang-format] add option for dangling parenthesis.

Adding the unit tests lets us see how this option will work in various cases, it will let us understand that its not breaking anything else.

Sun, Mar 10, 5:51 AM · Restricted Project
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

Thanks for the review, and for approving this PR. It's very much appreciated!

I don't have merge rights - could someone commit this for me please?

Sun, Mar 10, 5:35 AM · Restricted Project, Restricted Project

Sat, Mar 9

MyDeveloperDay added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

Please add unit tests to show this working, otherwise later someone will come along and break the behavior

Sat, Mar 9, 7:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D33029: [clang-format] add option for dangling parenthesis.

This review lack unit tests, please add some for FormatTest to show its use cases, otherwise someone else will come along and break this later

Sat, Mar 9, 7:01 AM · Restricted Project
Herald added a project to D38636: [clang-format] Cannot disable array initializer bin packing: Restricted Project.

This review needs unit tests

Sat, Mar 9, 2:59 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D55170: [clang-format]: Add NonEmptyParentheses spacing option.

I'm not the code owner but this LGTM,

Sat, Mar 9, 2:44 AM · Restricted Project, Restricted Project

Fri, Mar 8

MyDeveloperDay updated the diff for D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Fix spelling typo in documentation and comment

Fri, Mar 8, 6:51 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.

Add missing Format.h from the review

Fri, Mar 8, 2:06 AM · Restricted Project, Restricted Project

Thu, Mar 7

MyDeveloperDay added a comment to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.

I definately been burnt by not handling all the cases, but imagine a string class

Thu, Mar 7, 11:21 AM · Restricted Project, Restricted Project
MyDeveloperDay created D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present.
Thu, Mar 7, 3:31 AM · Restricted Project, Restricted Project

Tue, Mar 5

MyDeveloperDay committed rG10de39548976: [clang-format] broken after lambda with return type template with boolean… (authored by MyDeveloperDay).
[clang-format] broken after lambda with return type template with boolean…
Tue, Mar 5, 2:20 PM

Mon, Mar 4

MyDeveloperDay accepted D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter.

I'm not sure I personally would ever write code like that ;-) , but if its legal C++ and it compiles we should handle it the same as foo<1>,foo<true>,foo<!true>

Mon, Mar 4, 11:51 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D58922: [clang-format] broken after lambda with return type template with boolean literal.

BTW I suggest you also add the original test case since the test cases you added fail the expectation at FormatTest.cpp:74 and the message is a bit unclear whether the testcase or the actual implementation is at fault.

EXPECT_EQ(Expected.str(), format(Expected, Style))
    << "Expected code is not stable";

The original reported case IMO gives a better idea what is broken since it duplicates the end-of-namespace comment.
https://bugs.llvm.org/show_bug.cgi?id=40910

Mon, Mar 4, 11:40 PM · Restricted Project, Restricted Project
MyDeveloperDay created D58922: [clang-format] broken after lambda with return type template with boolean literal.
Mon, Mar 4, 12:48 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine.

It might be a good idea to add the nested lambda tests from D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style) into your review to show how this patch copes with those (and the examples from the comments of that review)

Mon, Mar 4, 10:34 AM · Restricted Project

Sat, Mar 2

MyDeveloperDay accepted D52150: [clang-format] BeforeHash added to IndentPPDirectives.

Thank you for helping to address one of the many clang-format issues from bugzilla, I'm not the code owner here but this looks good to me. If we want to address the many issues we need to be able to move forwards.

Sat, Mar 2, 7:35 AM · Restricted Project
MyDeveloperDay committed rG9b468c0b1e3f: [clang-format] clang-format off/on not respected when using C Style comments (authored by MyDeveloperDay).
[clang-format] clang-format off/on not respected when using C Style comments
Sat, Mar 2, 1:09 AM

Fri, Mar 1

MyDeveloperDay added inline comments to D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Fri, Mar 1, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D58819: [clang-format] clang-format off/on not respected when using C Style comments.

Fix negative test case
support the same /*<space>clang-format off<space>*/ in the sort includes that the TokenLexer supports.

Fri, Mar 1, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Fri, Mar 1, 6:50 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.

This looks good to me but I would wait for one of @JonasToth or @alexfh to perhaps take a look,

Fri, Mar 1, 6:20 AM · Restricted Project
MyDeveloperDay added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Fri, Mar 1, 4:42 AM · Restricted Project
MyDeveloperDay created D58819: [clang-format] clang-format off/on not respected when using C Style comments.
Fri, Mar 1, 4:34 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay committed rG5bcf99b4bda6: [clang-format] [NFC] clang-format the Format library (authored by MyDeveloperDay).
[clang-format] [NFC] clang-format the Format library
Fri, Mar 1, 1:10 AM

Thu, Feb 28

MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

sorry to be critical, just trying to help get traction on your review...

Thu, Feb 28, 3:09 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D55170: [clang-format]: Add NonEmptyParentheses spacing option.

I'm trying to go over old reviews and see if they are still desired, I stumbled on your review and want to see if its still important. Here is some initial feedback.

Thu, Feb 28, 3:02 PM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D55170: [clang-format]: Add NonEmptyParentheses spacing option: djasper, klimek.
Thu, Feb 28, 2:23 PM · Restricted Project, Restricted Project
MyDeveloperDay committed rG68f5e5456f85: [clang-tidy] add OverrideMacro to modernize-use-override check (authored by MyDeveloperDay).
[clang-tidy] add OverrideMacro to modernize-use-override check
Thu, Feb 28, 12:00 PM