Page MenuHomePhabricator

MyDeveloperDay (MyDeveloperDay)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:16 AM (265 w, 5 d)
Roles
Administrator

Recent Activity

Fri, Sep 18

MyDeveloperDay accepted D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py.

LGTM

Fri, Sep 18, 12:37 PM · Restricted Project
MyDeveloperDay accepted D86137: Add -Wno-error=unknown flag to clang-format..
Fri, Sep 18, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

it certainly LGTM, like I said I've had met this issue before and I think this does get around that situation where perhaps your not even using the option it's complaining about (especially if its a C++ option and you are using clang-format for C#)

Fri, Sep 18, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay committed rGa16e4a63ae7c: [clang-format] NFC ensure the clang-format tests remain clang-formatted (authored by MyDeveloperDay).
[clang-format] NFC ensure the clang-format tests remain clang-formatted
Fri, Sep 18, 10:17 AM
MyDeveloperDay committed rG2e7add812eb7: [clang-format] Add a option for the position of Java static import (authored by MyDeveloperDay).
[clang-format] Add a option for the position of Java static import
Fri, Sep 18, 10:13 AM
MyDeveloperDay closed D87201: [clang-format] Add a option for the position of Java static import.
Fri, Sep 18, 10:12 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

IMHO I feel that given that these changes are more wide reaching than just clang-format that it might be more correct for your to request commit access yourself.

Fri, Sep 18, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 17

MyDeveloperDay committed rG40e771c1c0d3: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function (authored by MyDeveloperDay).
[clang-format][regression][PR47461] ifdef causes catch to be seen as a function
Thu, Sep 17, 5:23 AM
MyDeveloperDay closed D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.
Thu, Sep 17, 5:23 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

LGTM.
Don't we risk any other side effects?

Thu, Sep 17, 4:00 AM · Restricted Project, Restricted Project

Wed, Sep 16

MyDeveloperDay added a comment to D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.

Thanks @MyDeveloperDay, I appreciate your input in this review. You're a good reviewer. :)
Also, I think you've made some good points there and I'm going to turn this review into "non-breaking the world" one. I'll be back in a few days with a new diff.

Wed, Sep 16, 7:45 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rG4dd9c709ef1b: [clang-format] [NFC] Fix spelling mistake in the documentation (authored by MyDeveloperDay).
[clang-format] [NFC] Fix spelling mistake in the documentation
Wed, Sep 16, 5:47 AM
MyDeveloperDay closed D87352: Fix typo.
Wed, Sep 16, 5:47 AM · Restricted Project
MyDeveloperDay added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

ping

Wed, Sep 16, 5:38 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D87352: Fix typo.
Wed, Sep 16, 5:34 AM · Restricted Project
MyDeveloperDay updated subscribers of D87352: Fix typo.
Wed, Sep 16, 5:34 AM · Restricted Project

Tue, Sep 15

MyDeveloperDay added a comment to D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.

Firstly let me say thank you for the patch, and taking the time to listen to the reviewers. Please don't be discouraged by my reply/opinon.

Tue, Sep 15, 8:14 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D87352: Fix typo.
Tue, Sep 15, 7:47 AM · Restricted Project
MyDeveloperDay added a comment to D87352: Fix typo.

Ok almost...

Tue, Sep 15, 4:25 AM · Restricted Project
MyDeveloperDay requested changes to D87352: Fix typo.

I have realized this is the wrong change

Tue, Sep 15, 1:03 AM · Restricted Project

Mon, Sep 14

MyDeveloperDay requested changes to D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation.

I have a hard time when people change tests! just because one person wants them this way doesn't mean everyone will.

Mon, Sep 14, 8:44 AM · Restricted Project, Restricted Project

Sun, Sep 13

MyDeveloperDay updated the diff for D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

Minimize other places where try could be incorrectly seen as an identifier

Sun, Sep 13, 3:00 AM · Restricted Project, Restricted Project

Wed, Sep 9

MyDeveloperDay accepted D87352: Fix typo.

LGTM, thank you for doing this..

Wed, Sep 9, 7:00 AM · Restricted Project
MyDeveloperDay accepted D87201: [clang-format] Add a option for the position of Java static import.

LGTM, I'm happy if @JakeMerdichAMD is

Wed, Sep 9, 6:59 AM · Restricted Project, Restricted Project

Tue, Sep 8

MyDeveloperDay added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

Note to self, other things could cause the same issue

Tue, Sep 8, 9:55 AM · Restricted Project, Restricted Project
MyDeveloperDay requested review of D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.
Tue, Sep 8, 9:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86581: [clang-format] Handle shifts within conditions.

@Saldivarcher this should be landed now, please validate

Tue, Sep 8, 8:42 AM · Restricted Project, Restricted Project
MyDeveloperDay committed rGc81dd3d159ab: [clang-format] Handle shifts within conditions (authored by MyDeveloperDay).
[clang-format] Handle shifts within conditions
Tue, Sep 8, 8:40 AM
MyDeveloperDay closed D86581: [clang-format] Handle shifts within conditions.
Tue, Sep 8, 8:40 AM · Restricted Project, Restricted Project
MyDeveloperDay abandoned D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer.

Better solution here D86581: [clang-format] Handle shifts within conditions

Tue, Sep 8, 8:31 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D87201: [clang-format] Add a option for the position of Java static import.
Tue, Sep 8, 7:51 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D87201: [clang-format] Add a option for the position of Java static import.
Tue, Sep 8, 7:50 AM · Restricted Project, Restricted Project

Mon, Sep 7

MyDeveloperDay added a comment to D87028: [clang-format] Improve heuristic for detecting function declarations.

Thanks for the patch, I think this looks like a comprehensive improvement, a new nits only

Mon, Sep 7, 1:46 AM · Restricted Project
MyDeveloperDay updated subscribers of D86137: Add -Wno-error=unknown flag to clang-format..

Regarding not touching the LLVM support library: I'd love to find a way, but as clang-format uses the >> operator

Mon, Sep 7, 1:39 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D87201: [clang-format] Add a option for the position of Java static import: JakeMerdichAMD.
Mon, Sep 7, 1:30 AM · Restricted Project, Restricted Project
MyDeveloperDay requested changes to D87201: [clang-format] Add a option for the position of Java static import.

Thanks for the patch, You need to generate a fill context diff (see Contributing to LLVM)

Mon, Sep 7, 1:30 AM · Restricted Project, Restricted Project

Sat, Sep 5

MyDeveloperDay added a comment to D86137: Add -Wno-error=unknown flag to clang-format..

This has caught me out from time to time, but the presence of such an option can lead to users mixing clang-format versions which could lead to flip/flopping of changes, so I'm not 100% sure it won't drive bad behaviour.

Sat, Sep 5, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay removed a project from D86137: Add -Wno-error=unknown flag to clang-format.: Restricted Project.
Sat, Sep 5, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added a project to D86137: Add -Wno-error=unknown flag to clang-format.: Restricted Project.
Sat, Sep 5, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D86137: Add -Wno-error=unknown flag to clang-format.: MyDeveloperDay, JakeMerdichAMD.
Sat, Sep 5, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 4

MyDeveloperDay accepted D86930: [clang-format] Handle typename macros inside cast expressions.

LGTM

Fri, Sep 4, 10:23 AM · Restricted Project
MyDeveloperDay accepted D86782: [clang-format] Allow configuring list of macros that map to attributes.

LGTM, I think we need something like this for those keywords/macros

Fri, Sep 4, 10:22 AM · Restricted Project
MyDeveloperDay accepted D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield.

Assuming it builds with minimum required c++ compiler

Fri, Sep 4, 10:21 AM · Restricted Project
MyDeveloperDay accepted D87007: [clang-format] Correctly parse function declarations with TypenameMacros.

LGTM

Fri, Sep 4, 10:20 AM · Restricted Project
MyDeveloperDay accepted D86950: [clang-format] Check that */& after typename macros are pointers/references.

LGTM

Fri, Sep 4, 10:19 AM · Restricted Project
MyDeveloperDay accepted D86959: [clang-format] Fix formatting of _Atomic() qualifier.

This LGTM

Fri, Sep 4, 8:07 AM · Restricted Project
MyDeveloperDay added a comment to D87006: [clang-format][NFC] Store FormatToken::Type as an enum instead of bitfield.

I'm not a C++ language lawyer so I'm not sure which standard introduce enum inheritance? (maybe its something we could always do?), if its a recent change we just need to ensure we are conforming to the C++ version that is needed to build clang.

Fri, Sep 4, 8:05 AM · Restricted Project
MyDeveloperDay accepted D86941: [clang-format] Add a test showing the current config file list parsing.

LGTM

Fri, Sep 4, 7:58 AM · Restricted Project
MyDeveloperDay accepted D86926: FormatTest: Provide real line number in failure messages.

This LGTM, I've certainly been bit myself in the past with not knowing which test actually failed especially when they are all foo() something.. thank you

Fri, Sep 4, 7:57 AM · Restricted Project
MyDeveloperDay accepted D86775: [clang-format] Parse __ptr32/__ptr64 as a pointer qualifier.

LGTM

Fri, Sep 4, 7:53 AM · Restricted Project

Wed, Sep 2

MyDeveloperDay accepted D86960: [clang-format] Parse __underlying_type(T) as a type.

LGTM

Wed, Sep 2, 4:15 AM · Restricted Project

Tue, Sep 1

MyDeveloperDay added a comment to D86782: [clang-format] Allow configuring list of macros that map to attributes.

I'm wondering if this could be used to help the CUDA usages of clang-format

Tue, Sep 1, 7:03 AM · Restricted Project
MyDeveloperDay added inline comments to D86926: FormatTest: Provide real line number in failure messages.
Tue, Sep 1, 7:02 AM · Restricted Project

Fri, Aug 28

MyDeveloperDay accepted D86716: [clang-format] Detect pointer qualifiers in cast expressions.

This LGTM thank you

Fri, Aug 28, 3:01 AM · Restricted Project
MyDeveloperDay accepted D86711: [clang-format] Parse __attribute((foo)) as a pointer qualifier.

LGTM thank you for these updates

Fri, Aug 28, 2:58 AM · Restricted Project

Thu, Aug 27

MyDeveloperDay added a comment to D86581: [clang-format] Handle shifts within conditions.

@Saldivarcher do you have commit access?

Thu, Aug 27, 5:11 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D86581: [clang-format] Handle shifts within conditions.

I think this LGTM and the solution is much more elegant than mine! You were not stepping on my toes, I'm always happy for someone else to take things over and this is a much smarter solution than mine.

Thu, Aug 27, 1:27 AM · Restricted Project, Restricted Project

Wed, Aug 26

MyDeveloperDay added reviewers for D86581: [clang-format] Handle shifts within conditions: JakeMerdichAMD, krasimir.
Wed, Aug 26, 7:07 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D86581: [clang-format] Handle shifts within conditions.

I think I like your solution better than mine D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer, could you look at my unit tests and consider adding them here?

Wed, Aug 26, 7:06 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D86597: [Tooling][Format] Treat compound extensions (foo.bar.cc) as matching foo.h.

LGTM

Wed, Aug 26, 7:04 AM · Restricted Project

Jul 28 2020

MyDeveloperDay accepted D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Thank you for the patch, this LGTM, I think this kind of change should help reduce memory usage and I feel improves the readability.

Jul 28 2020, 2:01 AM · Restricted Project, Restricted Project

Jul 27 2020

MyDeveloperDay added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

a new minor Nits but looks good.

Jul 27 2020, 2:33 AM · Restricted Project, Restricted Project

Jul 23 2020

MyDeveloperDay added reviewers for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.: JakeMerdichAMD, wanders, curdeius.
Jul 23 2020, 2:37 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Thank you for the patch, I'm generally in agreement but I think we should let some others comment

Jul 23 2020, 2:37 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..
Jul 23 2020, 2:27 AM · Restricted Project, Restricted Project
MyDeveloperDay added reviewers for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.: krasimir, sammccall.
Jul 23 2020, 2:14 AM · Restricted Project, Restricted Project

Jul 21 2020

MyDeveloperDay closed D84090: [clang-format] Add BitFieldColonSpacing option.
Jul 21 2020, 2:10 AM · Restricted Project, Restricted Project
MyDeveloperDay accepted D84090: [clang-format] Add BitFieldColonSpacing option.

just reopening to formally accept

Jul 21 2020, 2:10 AM · Restricted Project, Restricted Project
MyDeveloperDay reopened D84090: [clang-format] Add BitFieldColonSpacing option.
Jul 21 2020, 2:10 AM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D84090: [clang-format] Add BitFieldColonSpacing option.

Thanks for assistance and review. And sorry about the extra noise.

Jul 21 2020, 2:08 AM · Restricted Project, Restricted Project

Jul 20 2020

MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

Nit:clang-format the patch

Jul 20 2020, 8:33 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D84103: [clang-format] Make sure rst documentation matches comments.

Thanks for doing this..

Jul 20 2020, 1:41 AM · Restricted Project, Restricted Project

Jul 19 2020

MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

Let’s do all 4, None, Both, Left, Right

Jul 19 2020, 12:26 AM · Restricted Project, Restricted Project

Jul 18 2020

MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

you need to make a full contextdiff git diff -U 99999999

Jul 18 2020, 7:02 AM · Restricted Project, Restricted Project
MyDeveloperDay added a reviewer for D84090: [clang-format] Add BitFieldColonSpacing option: krasimir.
Jul 18 2020, 6:47 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

In principle, this looks ok.

Jul 18 2020, 6:47 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

please clang-format

Jul 18 2020, 6:45 AM · Restricted Project, Restricted Project

Jul 16 2020

MyDeveloperDay added a comment to D83901: [clang] Disable a few formatting options for test/.

clang-format -n warnings before this change in clang/test/Analysis/*.cpp (clang-format -n *.cpp |& grep warning | wc -l)

Jul 16 2020, 1:43 AM · Restricted Project

Jul 13 2020

MyDeveloperDay added inline comments to D83296: [clang-format] Add a MacroExpander..
Jul 13 2020, 6:06 AM · Restricted Project, Restricted Project

Jul 12 2020

MyDeveloperDay added a comment to rG7a1bcf9f9a95: [polly] NFC clang-format change following D83564.

Apologies our clang-format fix D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack broke the buildbots for Polly. Hope this is ok to fix this.

Jul 12 2020, 11:01 AM
MyDeveloperDay committed rG7a1bcf9f9a95: [polly] NFC clang-format change following D83564 (authored by MyDeveloperDay).
[polly] NFC clang-format change following D83564
Jul 12 2020, 10:59 AM
MyDeveloperDay committed rG65dc97b79eb1: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for… (authored by MyDeveloperDay).
[clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for…
Jul 12 2020, 10:45 AM
MyDeveloperDay closed D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack.
Jul 12 2020, 10:44 AM · Restricted Project, Restricted Project

Jul 10 2020

MyDeveloperDay added a reviewer for D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack: hubert.reinterpretcast.
Jul 10 2020, 9:22 AM · Restricted Project, Restricted Project
MyDeveloperDay created D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack.
Jul 10 2020, 9:01 AM · Restricted Project, Restricted Project

Jul 9 2020

MyDeveloperDay updated subscribers of D79773: [clang-format] Improve clang-formats handling of concepts.

This issue is caused by the presence of the ; in the requires clause (0)>;) inside the template declaration

Jul 9 2020, 1:54 AM · Restricted Project, Restricted Project

Jul 7 2020

MyDeveloperDay added a project to D83296: [clang-format] Add a MacroExpander.: Restricted Project.
Jul 7 2020, 5:32 AM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

https://reviews.llvm.org/D79773#2131680 has something to do with your .clang-format file, the base LLVM style seems fine.

Jul 7 2020, 12:48 AM · Restricted Project, Restricted Project

Jul 6 2020

MyDeveloperDay added a comment to D82767: clang-format: Explicitly use python3.

We may not be consistent across all of LLVM

Jul 6 2020, 6:12 AM · Restricted Project
MyDeveloperDay added a project to D82767: clang-format: Explicitly use python3: Restricted Project.
Jul 6 2020, 6:09 AM · Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Thank you @JohelEGP please keep them coming, I'll try and update the patch as soon as I have some fixes, I kind of feel like we are addressing what would have just been downstream bugs anyway. (some are quite bizarre!) so lets squish as many of them as we can before we land this.

Jul 6 2020, 3:03 AM · Restricted Project, Restricted Project

Jul 3 2020

MyDeveloperDay added a project to D52676: [clang-format] tweaked another case of lambda formatting: Restricted Project.
Jul 3 2020, 12:24 PM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D82620: [clang-format] Preserve whitespace in selected macros.
Jul 3 2020, 9:06 AM · Restricted Project, Restricted Project
MyDeveloperDay updated the diff for D79773: [clang-format] Improve clang-formats handling of concepts.

Addressed review comments
Added one or two more tests

Jul 3 2020, 4:49 AM · Restricted Project, Restricted Project
MyDeveloperDay added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
Jul 3 2020, 2:07 AM · Restricted Project, Restricted Project

Jul 2 2020

MyDeveloperDay updated the diff for D79773: [clang-format] Improve clang-formats handling of concepts.

Still a work in progress but covers I think the case @JohelEGP found.

Jul 2 2020, 1:31 PM · Restricted Project, Restricted Project

Jul 1 2020

MyDeveloperDay added a comment to D82989: [flang][NFC] Get formatting in sync with latest clang-format.

I'd be interested to know if you felt any of those changes were an unwanted surprise

Jul 1 2020, 12:59 PM · Restricted Project, Restricted Project
MyDeveloperDay updated subscribers of D82980: [NFC] Run clang-format on llvm-objcopy..
Jul 1 2020, 12:26 PM · Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.

Thank you I see now... super subtle but I'll take a look.

Jul 1 2020, 12:26 PM · Restricted Project, Restricted Project
MyDeveloperDay added a comment to D79773: [clang-format] Improve clang-formats handling of concepts.
constexpr plane(const plane& other) noexcept(
    (detail::default_allocator_is_nothrow &&
     std::is_nothrow_copy_constructible_v<T>)) requires(std::copyable<T>)
  : plane{to1d(other), other.sz.w}
{
}

Without the parentheses in trailing requires-clauses, all code following the constructor initializer list is further indented.

Jul 1 2020, 4:17 AM · Restricted Project, Restricted Project