cfe-commits (Mailing List "cfe-commits")Mailing List
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2015, 4:54 AM (111 w, 1 d)
Roles
Mailing List

Recent Activity

Jul 11 2016

cfe-commits added a comment to D21823: [Driver] Add flags for enabling both types of PGO Instrumentation.
Jul 11 2016, 8:41 AM

Jul 5 2016

cfe-commits added a comment to D21031: [OpenCL] Allow -cl-std and other standard -cl- options in driver.

We will add it. Thanks.

Jul 5 2016, 11:27 AM

Jun 29 2016

cfe-commits added a comment to D21830: Remove -mrelax-all from Clang -O0.

We need to benchmark this to see if it still makes a difference.

Jun 29 2016, 8:00 AM

Jun 23 2016

cfe-commits added a comment to D19932: [OpenCL] Add to_{global|local|private} builtin functions..

The returned pointer should point to the same pointee type as the argument. Header file cannot guarantee that.

Jun 23 2016, 11:08 AM

Jun 1 2016

cfe-commits added a comment to D20844: FixIt: use getLocForEndOfToken to insert fix-it after a type name..
Jun 1 2016, 1:18 PM

May 5 2016

cfe-commits added a comment to D19754: Allow 'nodebug' on local variables.

This would be a great conversation to have at the social, sadly I will
have to miss it this month.

May 5 2016, 8:50 AM

Apr 25 2016

cfe-commits added a comment to D19336: Repair redeclaration chain of friend template functions..
Apr 25 2016, 12:01 PM

Apr 13 2016

cfe-commits added a comment to D18970: Add functions in ctype.h to builtin function database.

Sure, I'll take a look.
Thanks!

Apr 13 2016, 8:02 AM

Apr 4 2016

cfe-commits added a comment to D18708: Set C99 as default C Standard for PS4 target.
Apr 4 2016, 4:27 PM

Mar 21 2016

cfe-commits added a comment to D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling..

Just wanted to check if there are existing test cases for format::getStyle.
If there is no test for it, I'll add test cases for sure :=)

Mar 21 2016, 1:27 PM

Mar 18 2016

cfe-commits added a comment to D18271: Avoid -Wshadow warnings about constructor parameters named after fields.

+Lang, because he was asking me recently about this improvement & thinking
of chipping in

Mar 18 2016, 11:03 AM

Mar 17 2016

cfe-commits added a comment to D17950: Implement is_always_lock_free.

I know that MIPS does that, and an out-of-tree implementation of hexagon
implements 1-byte cmpxchg in terms of the 4-byte version. The emulation
code isn't particularly small, and it seems reasonable to make it a
libcall. The emulation code seems sketchy from a correctness
perspective, as you end up generating unsolicited loads and stores on
adjacent bytes. Take a look at the thread on cfe-dev and llvm-dev named
"the as-if rule / perf vs. security" for some of the ramifications and
concerns surrounding unsolicited loads and stores.

Mar 17 2016, 9:55 AM

Mar 14 2016

cfe-commits added a comment to D17852: Added formatAndApplyAllReplacements that works on multiple files in libTooling..

Friendly PING.

Mar 14 2016, 7:31 AM

Mar 11 2016

cfe-commits added a comment to D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end.

Hi Aaron, Hi Juergen,

Mar 11 2016, 12:05 PM

Feb 22 2016

cfe-commits added a comment to D16821: Add whole-program vtable optimization feature to Clang..
Feb 22 2016, 1:38 PM

Feb 9 2016

cfe-commits added a comment to D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h).

It's best not to commit things without approval once they've been sent for
review (the assumption being that if you asked for review it's because the
change needed review - time doesn't change that fact) - if approval was
given off-list (eg: on IRC) it's best to mention who gave it & where (&
ideally the person should provide it on-list just for record keeping)

Feb 9 2016, 4:41 PM

Jan 25 2016

cfe-commits added a comment to D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null.

Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?

Jan 25 2016, 10:20 AM
cfe-commits added a comment to D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang.

Thanks for working on this!

Jan 25 2016, 8:35 AM

Jan 22 2016

cfe-commits added a comment to D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs.

I'll upload a new patch in a moment. Replies inline below.

Jan 22 2016, 3:01 PM

Jan 14 2016

cfe-commits added a comment to D16171: Warning on redeclaring with a conflicting asm label.

I agree what you said about different code generated with clang and GCC
generates. In this case, we should throw an error (err_late_asm_label).

Jan 14 2016, 3:05 PM

Jan 8 2016

cfe-commits added a comment to D15911: Move ownership of Action objects into Compilation..
Jan 8 2016, 10:55 AM

Dec 7 2015

cfe-commits added a comment to D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation..
Dec 7 2015, 3:20 PM

Nov 4 2015

cfe-commits added a comment to D14358: DWARF's forward decl of a template should have template parameters..

Would citing PR20455 help? It wasn't actually my primary motivation but it's not too far off. Having the template parameters there lets you know what's going on in the DWARF, without having to fetch and parse the name string of every struct you come across. Actually I'm not sure parsing the name string is unambiguous either; each parameter is either a typename, or an expression, but without the parameter DIEs you don't know which, a-priori. (What does <foo> mean? Depends on whether you think it should be a type name or a value; you can't tell, syntactically, you have to do some lookups. Ah, but if you had the parameter DIEs, you would Just Know.)

Nov 4 2015, 11:32 PM

Sep 8 2015

cfe-commits added a comment to D12358: [Analyzer] Widening loops which do not exit.

Hi Sean,

Sep 8 2015, 11:23 AM

Aug 30 2015

cfe-commits added a comment to D12473: [clang-tidy] Add old style function check.

@Aaron: Yes, I'm aware of that. I wanted to show that my check does not
take this into account.

Aug 30 2015, 1:53 PM

Aug 26 2015

cfe-commits added a comment to D12358: [Analyzer] Widening loops which do not exit.
Aug 26 2015, 9:47 PM
cfe-commits added a comment to D12375: [PATCH] Relax parse ordering rules for attributes.
Aug 26 2015, 1:30 PM

Aug 25 2015

cfe-commits added a comment to D12134: [DEBUG INFO] Source correlation for lambda captured values..

Looks like the initial mail didn't hit the mailing list? Does someone want
to restart this review and/or forward that initial mail with the
patch/description/etc?

Aug 25 2015, 8:06 AM

Aug 21 2015

cfe-commits added a comment to D12221: [RFC] Introduce `__attribute__((nontemporal))`..
Aug 21 2015, 1:22 PM

Aug 18 2015

cfe-commits added a comment to D12052: [X86][SSE] Add _mm_undefined_* intrinsics.

I’m not sure how much people actually use these, but the AVX-512 versions of these, at least, can be very useful internally to implement AVX-512 intrinsics.
For AVX-512, we use the same GCC builtin for all 3 versions of the intrinsic (pass-through masked, set to zero masked, and unmasked). This is the same implementation that’s used in GCC, and is fairly clean, since the only difference is in the desired pass-through values (actual value, zero, or undef).

Aug 18 2015, 12:42 AM