Page MenuHomePhabricator

davidvc1 (David Van Cleve)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 6:10 PM (24 w, 11 h)

Recent Activity

Sun, Apr 24

Herald added a project to D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types: Restricted Project.

@curdeius , the PR description mentions the reason: when you pipe input from stdin, clang-format has to run through the "is it objective C?" codepath, and this is the codepath with the bug.

Sun, Apr 24, 11:25 AM · Restricted Project, Restricted Project

Jan 17 2022

davidvc1 removed a reviewer for D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types: curdeius.
Jan 17 2022, 9:27 AM · Restricted Project, Restricted Project
davidvc1 added a comment to D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types.

+ @rsmith from CODE_OWNERS.txt: Hi Richard, could you please suggest a reviewer for this change? Thanks!

Jan 17 2022, 9:26 AM · Restricted Project, Restricted Project
davidvc1 added a reviewer for D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types: rsmith.
Jan 17 2022, 9:25 AM · Restricted Project, Restricted Project

Nov 30 2021

davidvc1 added a comment to D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types.

Hi @curdeius, I'm new to the project and I'm adding you as a reviewer because I noticed you reviewed a number of recent changes in this directory. Are you a good reviewer for this change? Thanks!

Nov 30 2021, 6:28 PM · Restricted Project, Restricted Project
davidvc1 requested review of D114837: format: Remove redundant calls to guessIsObjC to speed up clang-format on unknown file types.
Nov 30 2021, 6:26 PM · Restricted Project, Restricted Project