Try building with shared libraries (-DBUILD_SHARED_LIBS=On).

It looks like the diff was updated the wrong way: now it only contains the difference between the initial version and the updated version, rather than the difference between the updated version and the mainline. If you created a separate git commit for the changes, you need to do arc diff HEAD^^ (as many ^ as commits in your branch) or arc diff <hash-of-the-commit-on-the-main-branch>.

In D104397#2824440, @awarzynski wrote:

Hi @ftynse ,

It looks like this change is causing all our Flang BuildBot workers to fail :( You can take a look here:

• https://lab.llvm.org/buildbot/#/builders/79/builds/11159
• https://lab.llvm.org/buildbot/#/builders/21/builds/17456

Would you be able to either fix or revert? Thank you!

Address review

Could we update the doc of the index cast op while we are here? It current says "casts between <...> scalars".

Extend the documentation.

Address feedback.

A bit more cmake.

LGTM with comments addressed.

Drop some irrelevant changes

git-add :(

I suppose this now belongs to the memref dialect.

Add forgotten verify-diagnostics to the test.

In D103827#2804814, @rriddle wrote:

In D103827#2803378, @ftynse wrote:

In D103827#2803248, @rriddle wrote:

Can you add a link to the discussion for this?

https://llvm.discourse.group/t/rfc-memref-of-custom-types/3558

Sorry, I meant can you add it in the commit description?

Address review.

In D103827#2803248, @rriddle wrote:

Can you add a link to the discussion for this?

Address review.

cmake

cmake

Please make the rewriter aware of the inplace mutation. Otherwise LGTM.