Page MenuHomePhabricator

ftynse (Alex Zinenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 2:24 AM (156 w, 18 h)

Recent Activity

Today

ftynse accepted D104865: [MLIR][SCF] Inline single block ExecuteRegionOp.
Thu, Jun 24, 10:13 AM · Restricted Project
ftynse accepted D104864: Update Bazel build for 929189a499.
Thu, Jun 24, 9:43 AM · Restricted Project
ftynse committed rG10b8eb482cb6: [mlir] remove repeated use of TypeToLLVM.cpp in cmake targets (authored by ftynse).
[mlir] remove repeated use of TypeToLLVM.cpp in cmake targets
Thu, Jun 24, 9:35 AM
ftynse accepted D104780: [mlir:Async] Add the size parameter to the async.group.
Thu, Jun 24, 8:37 AM · Restricted Project
ftynse accepted D104845: [mlir][Linalg] NFC - Drop AliasInfo::existsNonDominatingRead.
Thu, Jun 24, 8:32 AM · Restricted Project
ftynse accepted D104834: [MLIR][LLVM] Expose type translator from LLVM to MLIR Type.

Try building with shared libraries (-DBUILD_SHARED_LIBS=On).

Thu, Jun 24, 12:49 AM · Restricted Project

Yesterday

ftynse accepted D104769: [mlir][LLVMIR] Fold ExtractValueOp coming from InsertValueOp.
Wed, Jun 23, 2:10 AM · Restricted Project
ftynse added inline comments to D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.
Wed, Jun 23, 1:32 AM · Restricted Project
ftynse accepted D104726: [MLIR][LLVM] Expose type translator from LLVM to MLIR Type.
Wed, Jun 23, 1:10 AM · Restricted Project

Mon, Jun 21

ftynse accepted D104289: Implement an scf.for range folding optimization pass..
Mon, Jun 21, 4:25 AM · Restricted Project
ftynse accepted D72223: [MLIR] Introduce affine.execute_region op.
Mon, Jun 21, 4:16 AM · Restricted Project, Restricted Project
ftynse added inline comments to D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.
Mon, Jun 21, 4:11 AM · Restricted Project
ftynse accepted D104499: [mlir][NFC] Move SubTensorOp and SubTensorInsertOp to TensorDialect.
Mon, Jun 21, 3:54 AM · Restricted Project
ftynse added a comment to D104289: Implement an scf.for range folding optimization pass..

It looks like the diff was updated the wrong way: now it only contains the difference between the initial version and the updated version, rather than the difference between the updated version and the mainline. If you created a separate git commit for the changes, you need to do arc diff HEAD^^ (as many ^ as commits in your branch) or arc diff <hash-of-the-commit-on-the-main-branch>.

Mon, Jun 21, 3:53 AM · Restricted Project
ftynse accepted D104490: [mlir][Linalg] Add support for scf::ForOp in comprehensive bufferization (7/n).
Mon, Jun 21, 3:49 AM · Restricted Project

Fri, Jun 18

ftynse accepted D75837: [MLIR] Introduce scf.execute_region op.
Fri, Jun 18, 1:05 AM · Restricted Project, Restricted Project
ftynse added inline comments to D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).
Fri, Jun 18, 12:31 AM · Restricted Project

Thu, Jun 17

ftynse added a comment to D104397: [mlir] Enable delayed registration of attribute/operation/type interfaces.

Hi @ftynse ,

It looks like this change is causing all our Flang BuildBot workers to fail :( You can take a look here:

Would you be able to either fix or revert? Thank you!

Thu, Jun 17, 7:12 AM · Restricted Project
ftynse committed rG6b6338195c1b: [mlir] define a customized DEBUG_TYPE in InterfaceSupport.h (authored by ftynse).
[mlir] define a customized DEBUG_TYPE in InterfaceSupport.h
Thu, Jun 17, 4:25 AM
ftynse committed rGd7e891213444: [mlir] Enable delayed registration of attribute/operation/type interfaces (authored by ftynse).
[mlir] Enable delayed registration of attribute/operation/type interfaces
Thu, Jun 17, 4:19 AM
ftynse closed D104397: [mlir] Enable delayed registration of attribute/operation/type interfaces.
Thu, Jun 17, 4:19 AM · Restricted Project
ftynse updated the diff for D104397: [mlir] Enable delayed registration of attribute/operation/type interfaces.

Address review

Thu, Jun 17, 4:18 AM · Restricted Project
ftynse committed rG23cdf7b6ed97: [mlir] separable registration of operation interfaces (authored by ftynse).
[mlir] separable registration of operation interfaces
Thu, Jun 17, 3:00 AM
ftynse closed D104294: [mlir] separable registration of operation interfaces.
Thu, Jun 17, 3:00 AM · Restricted Project
ftynse accepted D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).
Thu, Jun 17, 2:55 AM · Restricted Project
ftynse committed rGa4f81b2054c3: [mlir] ODS: emit interface traits outside of the interface class (authored by ftynse).
[mlir] ODS: emit interface traits outside of the interface class
Thu, Jun 17, 1:25 AM
ftynse closed D104384: [mlir] ODS: emit interface traits outside of the interface class.
Thu, Jun 17, 1:25 AM · Restricted Project

Wed, Jun 16

ftynse requested review of D104397: [mlir] Enable delayed registration of attribute/operation/type interfaces.
Wed, Jun 16, 9:56 AM · Restricted Project
ftynse requested review of D104384: [mlir] ODS: emit interface traits outside of the interface class.
Wed, Jun 16, 7:38 AM · Restricted Project
ftynse committed rG61cf7c72587f: [mlir] ODS: temporarily disbale external model in presence of extra class… (authored by ftynse).
[mlir] ODS: temporarily disbale external model in presence of extra class…
Wed, Jun 16, 3:21 AM

Tue, Jun 15

ftynse accepted D104280: Support lowering of index-cast on vector types..

Could we update the doc of the index cast op while we are here? It current says "casts between <...> scalars".

Tue, Jun 15, 8:00 AM · Restricted Project
ftynse accepted D104297: [mlir] Avoid GCC naming conflict..
Tue, Jun 15, 7:37 AM · Restricted Project
ftynse updated the diff for D104294: [mlir] separable registration of operation interfaces.

Extend the documentation.

Tue, Jun 15, 6:34 AM · Restricted Project
ftynse requested review of D104294: [mlir] separable registration of operation interfaces.
Tue, Jun 15, 6:27 AM · Restricted Project
ftynse committed rG9b2a1bcf6fbe: [mlir] separable registration of attribute and type interfaces (authored by ftynse).
[mlir] separable registration of attribute and type interfaces
Tue, Jun 15, 6:20 AM
ftynse closed D104234: [mlir] separable registration of attribute and type interfaces.
Tue, Jun 15, 6:20 AM · Restricted Project
ftynse accepted D104292: [mlir] Add SignOp to complex dialect..
Tue, Jun 15, 5:25 AM · Restricted Project
ftynse added inline comments to D104234: [mlir] separable registration of attribute and type interfaces.
Tue, Jun 15, 5:17 AM · Restricted Project
ftynse updated the diff for D104234: [mlir] separable registration of attribute and type interfaces.

Address feedback.

Tue, Jun 15, 5:17 AM · Restricted Project
ftynse added a reviewer for D104289: Implement an scf.for range folding optimization pass.: ftynse.
Tue, Jun 15, 5:16 AM · Restricted Project
ftynse added inline comments to D104289: Implement an scf.for range folding optimization pass..
Tue, Jun 15, 5:16 AM · Restricted Project
ftynse committed rG8ed88559582f: [mlir] ODS: do not emit trailing const for static methods (authored by ftynse).
[mlir] ODS: do not emit trailing const for static methods
Tue, Jun 15, 4:34 AM
ftynse closed D104233: [mlir] ODS: do not emit trailing const for static methods.
Tue, Jun 15, 4:34 AM · Restricted Project
ftynse updated the diff for D104234: [mlir] separable registration of attribute and type interfaces.

A bit more cmake.

Tue, Jun 15, 3:02 AM · Restricted Project
ftynse accepted D104284: [mlir] Add NegOp to complex dialect..
Tue, Jun 15, 2:51 AM · Restricted Project
ftynse accepted D104273: [mlir][SCF] Remove empty else blocks of `scf.if` operations..

LGTM with comments addressed.

Tue, Jun 15, 1:19 AM · Restricted Project

Mon, Jun 14

ftynse updated the diff for D104234: [mlir] separable registration of attribute and type interfaces.

Drop some irrelevant changes

Mon, Jun 14, 8:27 AM · Restricted Project
ftynse requested review of D104234: [mlir] separable registration of attribute and type interfaces.
Mon, Jun 14, 8:22 AM · Restricted Project
ftynse added reviewers for D104233: [mlir] ODS: do not emit trailing const for static methods: rriddle, antiagainst.
Mon, Jun 14, 8:22 AM · Restricted Project
ftynse requested review of D104233: [mlir] ODS: do not emit trailing const for static methods.
Mon, Jun 14, 8:20 AM · Restricted Project
ftynse committed rGc83e696732fd: Add AutomaticAllocationScope to memref.alloca_scope (authored by shabalin).
Add AutomaticAllocationScope to memref.alloca_scope
Mon, Jun 14, 7:09 AM
ftynse closed D104227: Add AutomaticAllocationScope to memref.alloca_scope.
Mon, Jun 14, 7:09 AM · Restricted Project
ftynse accepted D104227: Add AutomaticAllocationScope to memref.alloca_scope.
Mon, Jun 14, 7:05 AM · Restricted Project

Fri, Jun 11

ftynse committed rGfdc0d4360b4e: Introduce alloca_scope op (authored by shabalin).
Introduce alloca_scope op
Fri, Jun 11, 10:29 AM
ftynse closed D97768: Introduce alloca_scope op.
Fri, Jun 11, 10:28 AM · Restricted Project
ftynse accepted D104108: [mlir] Add ExpOp to Complex dialect..
Fri, Jun 11, 10:09 AM · Restricted Project
ftynse committed rGad381e39a526: [mlir] Provide minimal Python bindings for the math dialect (authored by ftynse).
[mlir] Provide minimal Python bindings for the math dialect
Fri, Jun 11, 4:21 AM
ftynse closed D104045: [mlir] Provide minimal Python bindings for the math dialect.
Fri, Jun 11, 4:21 AM · Restricted Project
ftynse accepted D97768: Introduce alloca_scope op.
Fri, Jun 11, 4:12 AM · Restricted Project

Thu, Jun 10

ftynse updated the diff for D104045: [mlir] Provide minimal Python bindings for the math dialect.

git-add :(

Thu, Jun 10, 10:01 AM · Restricted Project
ftynse requested review of D104045: [mlir] Provide minimal Python bindings for the math dialect.
Thu, Jun 10, 9:58 AM · Restricted Project
ftynse added a comment to D97768: Introduce alloca_scope op.

I suppose this now belongs to the memref dialect.

Thu, Jun 10, 4:51 AM · Restricted Project
ftynse committed rG7325aaefa52a: [mlir] make LLVMPointerType implement the data layout type interface (authored by ftynse).
[mlir] make LLVMPointerType implement the data layout type interface
Thu, Jun 10, 2:24 AM
ftynse closed D103946: [mlir] make LLVMPointerType implement the data layout type interface.
Thu, Jun 10, 2:24 AM · Restricted Project

Wed, Jun 9

ftynse committed rGf6faa71eafbc: [mlir] fix a crash if the dialect is missing a data layout interface (authored by ftynse).
[mlir] fix a crash if the dialect is missing a data layout interface
Wed, Jun 9, 8:46 AM
ftynse closed D103945: [mlir] fix a crash if the dialect is missing a data layout interface.
Wed, Jun 9, 8:46 AM · Restricted Project
ftynse updated the diff for D103946: [mlir] make LLVMPointerType implement the data layout type interface.

Add forgotten verify-diagnostics to the test.

Wed, Jun 9, 2:51 AM · Restricted Project
ftynse requested review of D103946: [mlir] make LLVMPointerType implement the data layout type interface.
Wed, Jun 9, 1:24 AM · Restricted Project
ftynse requested review of D103945: [mlir] fix a crash if the dialect is missing a data layout interface.
Wed, Jun 9, 1:23 AM · Restricted Project

Tue, Jun 8

ftynse committed rG7116468ca9d0: [mlir] fix shared-libs build (authored by ftynse).
[mlir] fix shared-libs build
Tue, Jun 8, 2:31 AM
ftynse committed rGc59ce1f6257c: [mlir] support memref of memref in standard-to-llvm conversion (authored by ftynse).
[mlir] support memref of memref in standard-to-llvm conversion
Tue, Jun 8, 2:12 AM
ftynse committed rGada9aa5a2282: [mlir] Make MemRef element type extensible (authored by ftynse).
[mlir] Make MemRef element type extensible
Tue, Jun 8, 2:11 AM
ftynse committed rG3c70a82e2891: [mlir] fix integer type mismatch in alloc conversion to LLVM (authored by ftynse).
[mlir] fix integer type mismatch in alloc conversion to LLVM
Tue, Jun 8, 2:11 AM
ftynse closed D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Tue, Jun 8, 2:11 AM · Restricted Project
ftynse closed D103827: [mlir] Make MemRef element type extensible.
Tue, Jun 8, 2:11 AM · Restricted Project
ftynse closed D103826: [mlir] fix integer type mismatch in alloc conversion to LLVM.
Tue, Jun 8, 2:11 AM · Restricted Project
ftynse added a comment to D103827: [mlir] Make MemRef element type extensible.

Can you add a link to the discussion for this?

https://llvm.discourse.group/t/rfc-memref-of-custom-types/3558

Sorry, I meant can you add it in the commit description?

Tue, Jun 8, 2:09 AM · Restricted Project
ftynse updated the summary of D103827: [mlir] Make MemRef element type extensible.
Tue, Jun 8, 2:00 AM · Restricted Project
ftynse added inline comments to D103869: Add a static assertions for custom Op<> to not defined data members (NFC).
Tue, Jun 8, 12:27 AM · Restricted Project
ftynse accepted D103869: Add a static assertions for custom Op<> to not defined data members (NFC).
Tue, Jun 8, 12:27 AM · Restricted Project
ftynse accepted D103839: [MLIR] Remove LLVM_AnyInteger type constraint and replace with AnyInteger.
Tue, Jun 8, 12:18 AM · Restricted Project

Mon, Jun 7

ftynse added inline comments to D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Mon, Jun 7, 11:33 AM · Restricted Project
ftynse updated the diff for D103828: [mlir] support memref of memref in standard-to-llvm conversion.

Address review.

Mon, Jun 7, 11:32 AM · Restricted Project
ftynse added a comment to D103827: [mlir] Make MemRef element type extensible.

Can you add a link to the discussion for this?

Mon, Jun 7, 11:04 AM · Restricted Project
ftynse updated the diff for D103827: [mlir] Make MemRef element type extensible.

Address review.

Mon, Jun 7, 11:04 AM · Restricted Project
ftynse accepted D103830: [MLIR][GPU] Simplify memcpy of cast.
Mon, Jun 7, 10:58 AM · Restricted Project
ftynse updated the diff for D103828: [mlir] support memref of memref in standard-to-llvm conversion.

cmake

Mon, Jun 7, 10:02 AM · Restricted Project
ftynse updated the diff for D103827: [mlir] Make MemRef element type extensible.

cmake

Mon, Jun 7, 9:53 AM · Restricted Project
ftynse requested review of D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Mon, Jun 7, 9:31 AM · Restricted Project
ftynse requested review of D103827: [mlir] Make MemRef element type extensible.
Mon, Jun 7, 9:30 AM · Restricted Project
ftynse requested review of D103826: [mlir] fix integer type mismatch in alloc conversion to LLVM.
Mon, Jun 7, 9:29 AM · Restricted Project
ftynse added inline comments to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Mon, Jun 7, 8:43 AM · Restricted Project, Restricted Project
ftynse added inline comments to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Mon, Jun 7, 8:10 AM · Restricted Project, Restricted Project
ftynse accepted D103712: [mlir][openacc] Add canonicalization for standalone data operations for if condition.
Mon, Jun 7, 8:08 AM · Restricted Project
ftynse added inline comments to D102816: [MLIR][OpenMP]Basic OpenMP target operation.
Mon, Jun 7, 1:26 AM · Restricted Project, Restricted Project
ftynse accepted D103337: [mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect.
Mon, Jun 7, 1:24 AM · Restricted Project, Restricted Project
ftynse accepted D103473: [mlir][ArmSVE] Add basic mask generation operation.
Mon, Jun 7, 1:24 AM · Restricted Project
ftynse accepted D103535: [mlir][ArmSVE] Add basic load/store operations.
Mon, Jun 7, 1:22 AM · Restricted Project
ftynse accepted D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

Please make the rewriter aware of the inplace mutation. Otherwise LGTM.

Mon, Jun 7, 12:46 AM · Restricted Project, Restricted Project
ftynse added inline comments to D103712: [mlir][openacc] Add canonicalization for standalone data operations for if condition.
Mon, Jun 7, 12:45 AM · Restricted Project