Page MenuHomePhabricator

ftynse (Alex Zinenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 2:24 AM (204 w, 1 d)

Recent Activity

Today

ftynse abandoned D126541: [mlir] add interchange, pad and scalarize to structured transform dialect.

Accidental duplicate.

Fri, May 27, 7:34 AM · Restricted Project, Restricted Project
ftynse requested review of D126542: [mlir] add VectorizeOp to structured transform ops.
Fri, May 27, 7:34 AM · Restricted Project, Restricted Project
ftynse requested review of D126541: [mlir] add interchange, pad and scalarize to structured transform dialect.
Fri, May 27, 7:33 AM · Restricted Project, Restricted Project
ftynse accepted D126530: [mlir][llvm] Fix compiler error on GCC 9.
Fri, May 27, 4:53 AM · Restricted Project, Restricted Project
ftynse added inline comments to D126530: [mlir][llvm] Fix compiler error on GCC 9.
Fri, May 27, 4:44 AM · Restricted Project, Restricted Project
ftynse added inline comments to D126530: [mlir][llvm] Fix compiler error on GCC 9.
Fri, May 27, 4:24 AM · Restricted Project, Restricted Project

Yesterday

ftynse committed rG73c3dff1b3e4: [mlir] Use-after-free checker for the Transform dialect (authored by ftynse).
[mlir] Use-after-free checker for the Transform dialect
Thu, May 26, 3:29 AM · Restricted Project, Restricted Project
ftynse closed D126381: [mlir] Use-after-free checker for the Transform dialect.
Thu, May 26, 3:28 AM · Restricted Project, Restricted Project
ftynse updated the diff for D126381: [mlir] Use-after-free checker for the Transform dialect.

Review.

Thu, May 26, 3:27 AM · Restricted Project, Restricted Project
ftynse added inline comments to D126381: [mlir] Use-after-free checker for the Transform dialect.
Thu, May 26, 3:26 AM · Restricted Project, Restricted Project

Wed, May 25

ftynse added inline comments to D126328: [MLIR][Presburger] Add intersectDomain/Range to IntegerRelation.
Wed, May 25, 9:31 AM · Restricted Project, Restricted Project
ftynse requested review of D126381: [mlir] Use-after-free checker for the Transform dialect.
Wed, May 25, 7:39 AM · Restricted Project, Restricted Project
ftynse accepted D126326: [MLIR][Presburger] Add getDomainSet, getRangeSet to IntegerRelation.
Wed, May 25, 7:01 AM · Restricted Project, Restricted Project
ftynse accepted D126161: [mlir][LLVM] Add support for Calling Convention in LLVMFuncOp.
Wed, May 25, 6:39 AM · Restricted Project, Restricted Project
ftynse requested review of D126374: [mlir] add interchange, pad and scalarize to structured transform dialect.
Wed, May 25, 6:13 AM · Restricted Project, Restricted Project
ftynse added inline comments to D126161: [mlir][LLVM] Add support for Calling Convention in LLVMFuncOp.
Wed, May 25, 6:10 AM · Restricted Project, Restricted Project
ftynse accepted D126339: [MLIR][Presburger] Add applyDomain/Range to IntegerRelation.
Wed, May 25, 5:57 AM · Restricted Project, Restricted Project
ftynse added inline comments to D126328: [MLIR][Presburger] Add intersectDomain/Range to IntegerRelation.
Wed, May 25, 5:55 AM · Restricted Project, Restricted Project
ftynse added inline comments to D126326: [MLIR][Presburger] Add getDomainSet, getRangeSet to IntegerRelation.
Wed, May 25, 5:20 AM · Restricted Project, Restricted Project
ftynse accepted D126327: [MLIR][Presburger] Add inverse to IntegerRelation.
Wed, May 25, 5:10 AM · Restricted Project, Restricted Project
ftynse accepted D126370: [MLIR][Linalg] Adjust documentation (NFC).
Wed, May 25, 4:56 AM · Restricted Project, Restricted Project

Mon, May 23

ftynse updated the diff for D126208: [mlir] provide Python bindings for the Transform dialect.

Rebase

Mon, May 23, 7:49 AM · Restricted Project, Restricted Project
ftynse requested review of D126208: [mlir] provide Python bindings for the Transform dialect.
Mon, May 23, 7:43 AM · Restricted Project, Restricted Project

Fri, May 20

ftynse accepted D126050: [mlir][NFC] Replace some nested if with logical and..
Fri, May 20, 4:37 AM · Restricted Project, Restricted Project
ftynse committed rG122e68587899: [mlir] do not elide dialect prefix for ops with dots in the name (authored by ftynse).
[mlir] do not elide dialect prefix for ops with dots in the name
Fri, May 20, 3:55 AM · Restricted Project, Restricted Project
ftynse closed D125975: [mlir] do not elide dialect prefix for ops with dots in the name.
Fri, May 20, 3:55 AM · Restricted Project, Restricted Project

Thu, May 19

ftynse added inline comments to D125098: [mlir][bufferization] Add OneShotBufferize transform op.
Thu, May 19, 8:42 AM · Restricted Project, Restricted Project
ftynse accepted D125955: [mlir][Arithmetic] fold overlapping negf..
Thu, May 19, 8:26 AM · Restricted Project, Restricted Project
ftynse requested review of D125975: [mlir] do not elide dialect prefix for ops with dots in the name.
Thu, May 19, 7:23 AM · Restricted Project, Restricted Project

Wed, May 18

ftynse accepted D125818: [mlir][LLVMIR] Use the correct way to determine if it's a scalable vector.
Wed, May 18, 1:21 AM · Restricted Project, Restricted Project
ftynse accepted D125817: [mlir][LLVMIR] Add support for translating from some simple LLVM instructions.
Wed, May 18, 1:20 AM · Restricted Project, Restricted Project
ftynse added a comment to D125817: [mlir][LLVMIR] Add support for translating from some simple LLVM instructions.

Nit: could you please update the commit message to specify the translation _from LLVM IR_. Otherwise, it may trick a casual reader into thinking that we haven't supported translating simple instructions _to LLVM IR_ until this point.

Wed, May 18, 1:19 AM · Restricted Project, Restricted Project
ftynse added a comment to D125855: [mlir][ArmSVE] Remove unnecessary ops.

I am not very convinced by the motivation of LLVM backend selecting the appropriate instructions. On other platforms, we have repeatedly seen the selection being fragile and sensitive to factors beyond our control, so I would rather have the possibility to target these directly even if it is not being used by some compilations pipelnes.

Wed, May 18, 1:15 AM · Restricted Project, Restricted Project

Tue, May 17

ftynse accepted D124935: [mlir][LLVMIR] Use a new way to verify GEPOp indices.

Thanks!

Tue, May 17, 7:40 AM · Restricted Project, Restricted Project
ftynse accepted D125550: [mlir][complex] Add pow/sqrt/tanh ops and lowering to libm.
Tue, May 17, 7:31 AM · Restricted Project, Restricted Project
ftynse committed rG1075c8ca49b4: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again (authored by ftynse).
[mlir] support isa/cast/dyn_cast<Operation *>(operation) again
Tue, May 17, 2:15 AM · Restricted Project, Restricted Project
ftynse closed D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.
Tue, May 17, 2:15 AM · Restricted Project, Restricted Project
ftynse added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

Actually it'd probably be easier to just add an if (std::is_same<T, ::mlir::Operation *>::value) return true; condition to isPossible in the non-const casts, everything else should "just work".

Tue, May 17, 2:02 AM · Restricted Project, Restricted Project
ftynse added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

This will not happen for a random class that does not have CastInfo specialized though. For Operation *, the compiler picks the CastInfo<T, ::mlir::Operation *> specialization over the more generic CastInfo<T, T>, I don't think there is an easy way around this.

Tue, May 17, 1:58 AM · Restricted Project, Restricted Project
ftynse added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

The minimal example is

Tue, May 17, 1:47 AM · Restricted Project, Restricted Project

Mon, May 16

ftynse committed rG18fc39590978: [mlir] allow for re-registering extension ops (authored by ftynse).
[mlir] allow for re-registering extension ops
Mon, May 16, 3:04 PM · Restricted Project, Restricted Project
ftynse closed D125554: [mlir] allow for re-registering extension ops.
Mon, May 16, 3:04 PM · Restricted Project, Restricted Project

Fri, May 13

ftynse requested review of D125554: [mlir] allow for re-registering extension ops.
Fri, May 13, 9:05 AM · Restricted Project, Restricted Project
ftynse requested review of D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.
Fri, May 13, 6:11 AM · Restricted Project, Restricted Project
ftynse accepted D125217: [mlir] Fix declaration of nano time function in benchmark infra.
Fri, May 13, 2:46 AM · Restricted Project, Restricted Project
ftynse committed rG7deed49ab9f0: [mlir] use dynamic sections in MLIR Doxygen (authored by ftynse).
[mlir] use dynamic sections in MLIR Doxygen
Fri, May 13, 2:44 AM · Restricted Project, Restricted Project

Thu, May 12

ftynse added a comment to D125098: [mlir][bufferization] Add OneShotBufferize transform op.

Nice, thank you!

Thu, May 12, 9:19 AM · Restricted Project, Restricted Project
ftynse accepted D125039: [mlir] translate memref.reshape ops that have static shapes.
Thu, May 12, 9:12 AM · Restricted Project, Restricted Project
ftynse added a comment to D125217: [mlir] Fix declaration of nano time function in benchmark infra.

Could you please reference the commit that changed the function name in the description of this commit?

Thu, May 12, 9:05 AM · Restricted Project, Restricted Project

Fri, May 6

ftynse requested changes to D125039: [mlir] translate memref.reshape ops that have static shapes.

Since reshape ops don't have offsets, sizes, or strides, this

patch simply sets the allocated and aligned pointers of the MemRef
descriptor.

Fri, May 6, 2:22 AM · Restricted Project, Restricted Project
ftynse added a comment to D124935: [mlir][LLVMIR] Use a new way to verify GEPOp indices.

I'm incline to rewrite the algorithm used in GEPOp::findKnownStructIndices (and recordStructIndices) to adopt the better solution I mentioned previously.

Fri, May 6, 2:17 AM · Restricted Project, Restricted Project

Wed, May 4

ftynse requested changes to D124935: [mlir][LLVMIR] Use a new way to verify GEPOp indices.

Thanks, something might be off with the check, but I'm not sure I agree with your current assessment. The verifier does recurse into structs - https://github.com/llvm/llvm-project/blob/ff8d0b338f48ab26919ac84aef2c79e1e1a20ef2/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp#L406-L429. My another suspicion is that build methods are not matching your expectation, it would be helpful to have a MLIR-only test that demonstrates the problem by parsing IR, rather than building it (use the generic form to bypass parser checks). If this proves impossible, the issue is in the build method.

Wed, May 4, 9:33 AM · Restricted Project, Restricted Project

Tue, May 3

ftynse committed rG6c57b0debeda: [mlir] improve and test TransformState::Extension (authored by ftynse).
[mlir] improve and test TransformState::Extension
Tue, May 3, 2:33 AM · Restricted Project, Restricted Project
ftynse closed D124778: [mlir] improve and test TransformState::Extension.
Tue, May 3, 2:33 AM · Restricted Project, Restricted Project
ftynse accepted D124795: [mlir][MemRef] Return `0` for the canonical strided layout expr of a 0d memref.
Tue, May 3, 1:41 AM · Restricted Project, Restricted Project
ftynse accepted D124628: [mlir][LLVMIR] Add support for translating Switch instruction.
Tue, May 3, 1:34 AM · Restricted Project, Restricted Project

Mon, May 2

ftynse requested review of D124778: [mlir] improve and test TransformState::Extension.
Mon, May 2, 9:24 AM · Restricted Project, Restricted Project
ftynse added a comment to D124675: [mlir] support isa/cast/dyn_cast<Operation *>(operation).

This is indeed sad, but seemed like least worst solution compared to enable_if.

Mon, May 2, 1:08 AM · Restricted Project, Restricted Project
ftynse committed rG946311b89381: [mlir] support isa/cast/dyn_cast<Operation *>(operation) (authored by ftynse).
[mlir] support isa/cast/dyn_cast<Operation *>(operation)
Mon, May 2, 1:08 AM · Restricted Project, Restricted Project
ftynse closed D124675: [mlir] support isa/cast/dyn_cast<Operation *>(operation).
Mon, May 2, 1:07 AM · Restricted Project, Restricted Project
ftynse accepted D124720: [mlir] Update LLVMIR Fastmath flags use of MLIR BitEnum functionality.
Mon, May 2, 1:04 AM · Restricted Project, Restricted Project

Fri, Apr 29

ftynse requested review of D124675: [mlir] support isa/cast/dyn_cast<Operation *>(operation).
Fri, Apr 29, 8:22 AM · Restricted Project, Restricted Project
ftynse accepted D124661: [mlir][linalg][transform] Add TileOp to transform dialect.
Fri, Apr 29, 5:30 AM · Restricted Project, Restricted Project
ftynse added inline comments to D124661: [mlir][linalg][transform] Add TileOp to transform dialect.
Fri, Apr 29, 3:57 AM · Restricted Project, Restricted Project
ftynse requested changes to D124628: [mlir][LLVMIR] Add support for translating Switch instruction.

Please add tests for user-visible error messages.

Fri, Apr 29, 1:37 AM · Restricted Project, Restricted Project
ftynse added a comment to D124627: [mlir][LLVMIR] Do not update instMap via assignments to map entry references.

The complexity of the test is scary. Is it just a matter of having a sufficient amount of instructions and/or constants in a vector?

Fri, Apr 29, 1:35 AM · Restricted Project, Restricted Project

Thu, Apr 28

ftynse accepted D124574: [mlir][msan][test] Disable jit tests.
Thu, Apr 28, 2:08 AM · Restricted Project, Restricted Project

Apr 27 2022

ftynse accepted D124404: [mlir][LLVMIR] Do not cache llvm::Constant into instMap.
Apr 27 2022, 3:49 AM · Restricted Project, Restricted Project

Apr 26 2022

ftynse accepted D124458: Fixed the types of AffineExpr methods in MLIR Python bindings.
Apr 26 2022, 8:54 AM · Restricted Project, Restricted Project
ftynse added a comment to D124007: [mlir] Connect Transform dialect to PDL.

Yes, it will be required. b84f95fe5348ac97d33ffd2f6845b7f1b17b389c should silence the warning.

Apr 26 2022, 5:08 AM · Restricted Project, Restricted Project
ftynse committed rGb84f95fe5348: [mlir] Fix -Wunused-private-field in the Transform dialect (authored by ftynse).
[mlir] Fix -Wunused-private-field in the Transform dialect
Apr 26 2022, 5:05 AM · Restricted Project, Restricted Project
ftynse committed rG2b985a7ae81f: [mlir] Add a title to the Transform Dialect doc (authored by ftynse).
[mlir] Add a title to the Transform Dialect doc
Apr 26 2022, 4:05 AM · Restricted Project, Restricted Project
ftynse added a comment to D124142: [mlir][OpenMP] Restrict types for omp.parallel args.

Any reason to restrict num_threads to be 32-bit specifically? The spec says it must evaluate to a positive integer value, nothing about its size. I would rather keep it as AnyInteger, and maybe even allowed Index.

Apr 26 2022, 1:26 AM · Restricted Project, Restricted Project, Restricted Project
ftynse accepted D124402: [mlir][LLVMIR] Do not cache Instruction generated on-the-fly.

Nice catch, thanks!

Apr 26 2022, 1:23 AM · Restricted Project, Restricted Project
ftynse added a comment to D124404: [mlir][LLVMIR] Do not cache llvm::Constant into instMap.

I edited the description a bit. Please also note that phabricator-style markup (e.g., using // for italic) looks weird in git commit messages (e.g., C-style comment).

Apr 26 2022, 1:22 AM · Restricted Project, Restricted Project
ftynse updated the summary of D124404: [mlir][LLVMIR] Do not cache llvm::Constant into instMap.
Apr 26 2022, 1:16 AM · Restricted Project, Restricted Project
ftynse accepted D124399: [mlir][LLVMIR] Add support for importing struct-type ConstantAggregate(Zero).

Nice, thank you!

Apr 26 2022, 1:14 AM · Restricted Project, Restricted Project

Apr 25 2022

ftynse updated subscribers of D124366: [mlir][vector] insert `alloca`s outside of loops.

We should add a facility (a pass presumably) that hoists allocas up to some user-specified level. Maybe the allocation scope that is not nested in another allocation scope, but is nested in the closest isolated-from-above operation. I believe @wsmoses has a prototype for this.

Apr 25 2022, 5:25 AM · Restricted Project, Restricted Project
ftynse committed rG4c807f2f579f: [mlir][vector] insert `alloca`s outside of loops (authored by ftynse).
[mlir][vector] insert `alloca`s outside of loops
Apr 25 2022, 1:49 AM · Restricted Project, Restricted Project
ftynse closed D124366: [mlir][vector] insert `alloca`s outside of loops.
Apr 25 2022, 1:49 AM · Restricted Project, Restricted Project
ftynse added a reviewer for D124366: [mlir][vector] insert `alloca`s outside of loops: hanchung.
Apr 25 2022, 1:27 AM · Restricted Project, Restricted Project
ftynse requested review of D124366: [mlir][vector] insert `alloca`s outside of loops.
Apr 25 2022, 1:26 AM · Restricted Project, Restricted Project
ftynse accepted D124333: [mlir][LLVM] Support opaque pointers in `llvm.mlir.addressof`.
Apr 25 2022, 1:09 AM · Restricted Project, Restricted Project

Apr 22 2022

ftynse accepted D124290: [mlir][LLVM] Fix `DataLayoutTypeInterface` for opqaue pointers with non-default address space.
Apr 22 2022, 2:31 PM · Restricted Project, Restricted Project
ftynse committed rG40a8bd635b08: [mlir] use side effects in the Transform dialect (authored by ftynse).
[mlir] use side effects in the Transform dialect
Apr 22 2022, 2:29 PM · Restricted Project, Restricted Project
ftynse closed D124181: [mlir] use side effects in the Transform dialect.
Apr 22 2022, 2:29 PM · Restricted Project, Restricted Project
ftynse accepted D124291: [mlir][LLVM] Fix crash when using opaque pointers in function signatures.
Apr 22 2022, 2:27 PM · Restricted Project, Restricted Project
ftynse accepted D124236: [mlir][Arithmetic] Use common constant fold function in RemSI and RemUI to cover splat..
Apr 22 2022, 1:30 AM · Restricted Project, Restricted Project
ftynse added a comment to D124181: [mlir] use side effects in the Transform dialect.

Does allowing the reordering of transform operations really make sense if they do not declare all their pattern inputs and outputs? E.g.

alloc/write(%1) = transform.foo read(%0) 
alloc/write(%2) = transform.bar read(%0)

What if foo creates other ops for which bar optionally checks and which, if present, change what bar does? Reordering these two operations becomes invalid. Any transform op that corresponds to a pattern, for example, that is not purely functional (i.e. that does not declare all of its input ops and output ops) will need to be annotated with a generic MemoryRead and MemoryWrite.

Apr 22 2022, 1:28 AM · Restricted Project, Restricted Project
ftynse updated the diff for D124181: [mlir] use side effects in the Transform dialect.

Address review.

Apr 22 2022, 1:28 AM · Restricted Project, Restricted Project
ftynse added a comment to D124235: [mlir][Arithmetic] Use matchPattern to simplify code..

Thanks for the cleanup!

Apr 22 2022, 12:56 AM · Restricted Project, Restricted Project
ftynse accepted D124235: [mlir][Arithmetic] Use matchPattern to simplify code..
Apr 22 2022, 12:55 AM · Restricted Project, Restricted Project

Apr 21 2022

ftynse committed rG0edb262d914a: [mlir] enable doc generation for the transform dialect (authored by ftynse).
[mlir] enable doc generation for the transform dialect
Apr 21 2022, 9:52 AM · Restricted Project, Restricted Project
ftynse requested review of D124181: [mlir] use side effects in the Transform dialect.
Apr 21 2022, 9:15 AM · Restricted Project, Restricted Project
ftynse committed rG30f22429d389: [mlir] Connect Transform dialect to PDL (authored by ftynse).
[mlir] Connect Transform dialect to PDL
Apr 21 2022, 7:23 AM · Restricted Project, Restricted Project
ftynse closed D124007: [mlir] Connect Transform dialect to PDL.
Apr 21 2022, 7:23 AM · Restricted Project, Restricted Project
ftynse updated the diff for D124007: [mlir] Connect Transform dialect to PDL.

Try fixing Windows.

Apr 21 2022, 4:35 AM · Restricted Project, Restricted Project

Apr 20 2022

ftynse accepted D123919: [mlir][OpenMP] omp.task translation to LLVM IR.
Apr 20 2022, 11:51 PM · Restricted Project, Restricted Project, Restricted Project
ftynse updated the diff for D124007: [mlir] Connect Transform dialect to PDL.

Fix misrebase.

Apr 20 2022, 5:51 AM · Restricted Project, Restricted Project
ftynse added inline comments to D124007: [mlir] Connect Transform dialect to PDL.
Apr 20 2022, 5:43 AM · Restricted Project, Restricted Project