Page MenuHomePhabricator

ftynse (Alex Zinenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 2:24 AM (117 w, 3 d)

Recent Activity

Thu, Sep 24

ftynse added inline comments to D88162: [mlir] Expose Dialect class and registration/loading to C API.
Thu, Sep 24, 3:18 AM · Restricted Project
ftynse updated the diff for D88162: [mlir] Expose Dialect class and registration/loading to C API.

review and more questions

Thu, Sep 24, 3:16 AM · Restricted Project
ftynse added a comment to D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .

Consider adding a test.

Thu, Sep 24, 2:41 AM · Restricted Project
ftynse accepted D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .
Thu, Sep 24, 2:41 AM · Restricted Project

Wed, Sep 23

ftynse requested review of D88162: [mlir] Expose Dialect class and registration/loading to C API.
Wed, Sep 23, 9:34 AM · Restricted Project
ftynse committed rGc538169ee995: [mlir] Add insert before/after to list-like constructs in C API (authored by ftynse).
[mlir] Add insert before/after to list-like constructs in C API
Wed, Sep 23, 8:29 AM
ftynse closed D88148: [mlir] Add insert before/after to list-like constructs in C API.
Wed, Sep 23, 8:29 AM · Restricted Project
ftynse accepted D88155: Remove MLIR C-API explicit registration of standard ops..
Wed, Sep 23, 8:15 AM · Restricted Project
ftynse committed rG969180684060: [mlir] Fix typos in Dialect.h. NFC. (authored by ftynse).
[mlir] Fix typos in Dialect.h. NFC.
Wed, Sep 23, 6:38 AM
ftynse accepted D88111: [mlir][openacc] Use OptionalParseResult in loop op parser instead of bool variables.

Thanks for following up on this!

Wed, Sep 23, 6:16 AM · Restricted Project
ftynse accepted D87996: Add mlir python APIs for creating operations, regions and blocks..
Wed, Sep 23, 6:10 AM · Restricted Project
ftynse requested review of D88148: [mlir] Add insert before/after to list-like constructs in C API.
Wed, Sep 23, 6:03 AM · Restricted Project
ftynse accepted D88143: [mlir] Added support for f64 memref printing in runner utils.
Wed, Sep 23, 4:56 AM · Restricted Project
ftynse accepted D87982: Implement python iteration over the operation/region/block hierarchy..

Looks great!

Wed, Sep 23, 4:31 AM · Restricted Project
ftynse accepted D87958: Add Operation to python bindings..
Wed, Sep 23, 3:58 AM · Restricted Project
ftynse added inline comments to D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types.
Wed, Sep 23, 12:36 AM · Restricted Project

Tue, Sep 22

ftynse added a comment to D87724: [mlir] Support unranked memrefs, return and call ops in bare-ptr calling convention.

The noalias issue is one problem but I think we also need to model some kind of memref that is lowered to a bare pointer (e.g., if we want to pass a pointer to an external function). Creating specific dialects to cover each and every one of these special case doesn't scale well.

Tue, Sep 22, 1:51 AM · Restricted Project
ftynse requested changes to D88042: [mlir] Fix LLVM lowering of memory space in unranked memrefs.
Tue, Sep 22, 1:15 AM · Restricted Project
ftynse added a comment to D88042: [mlir] Fix LLVM lowering of memory space in unranked memrefs.

Hmm, this may not be as straightforward as it seems. The pointer in the unranked memref descriptor is to the ranked descriptor struct rather than to the data. Since we don't have two memory spaces in the type, we need to at least define a convention. One can be that the descriptor of the memref is allocated in the same memory space as the memref itself, which requires changes to memref_cast lowering and thinking about what it means for descriptors that live in registers. Another convention can be that the descriptor itself lives in the default memory space, and then this change isn't necessary, only making sure that memref_cast produces the llvm.bitcast to a descriptor struct with correct memory spaces inside.

Tue, Sep 22, 1:15 AM · Restricted Project

Mon, Sep 21

ftynse added a comment to D88012: WIP: DSL-style builder generator.

I have sent an RFC to which this diff is in illustration. Please do not review diffs with work-in-progress / WIP in the title.

Mon, Sep 21, 9:49 AM · Restricted Project
ftynse accepted D88025: [NFC][mlir] Remove llvm:: prefix from SmallVector in parallel pretty printer..

Thanks for the cleanup!

Mon, Sep 21, 9:48 AM · Restricted Project
ftynse accepted D87991: [mlir][openacc] Add attributes to parallel op async, wait and self clauses.
Mon, Sep 21, 8:17 AM · Restricted Project
ftynse requested review of D88012: WIP: DSL-style builder generator.
Mon, Sep 21, 3:41 AM · Restricted Project
ftynse accepted D88008: Add a dump() method on the pass manager for debugging purpose (NFC).
Mon, Sep 21, 2:45 AM · Restricted Project
ftynse added a comment to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.

There are review comments that remain unaddressed on this. Please address or comment as to why you chose not to address them.

Mon, Sep 21, 2:28 AM · Restricted Project
ftynse added inline comments to D87991: [mlir][openacc] Add attributes to parallel op async, wait and self clauses.
Mon, Sep 21, 1:27 AM · Restricted Project
ftynse accepted D88000: Fix crash in the pass pipeline when local reproducer is enabled.
Mon, Sep 21, 1:14 AM · Restricted Project

Fri, Sep 18

ftynse added inline comments to D87617: [mlir] expose affine map to C API.
Fri, Sep 18, 1:47 AM · Restricted Project
ftynse accepted D87874: [mlir][openacc] Add missing operands for acc.data operation.
Fri, Sep 18, 1:27 AM · Restricted Project
ftynse accepted D87848: [mlir][openacc] Support Index and AnyInteger in loop op.
Fri, Sep 18, 1:24 AM · Restricted Project
ftynse accepted D87886: First pass on MLIR python context lifetime management..

As discussed on the forum. Thanks!

Fri, Sep 18, 1:21 AM · Restricted Project
ftynse accepted D87776: [mlir][ODS] Add TypeRef directive in Declarative Assembly Format to allow custom UserDirective parser to receive previously parsed types..

By naming the patterns "properly" I am able to put them in the right position so that the Filecheck agrees.

Fri, Sep 18, 12:28 AM · Restricted Project

Thu, Sep 17

ftynse added a comment to D87724: [mlir] Support unranked memrefs, return and call ops in bare-ptr calling convention.

As a general observation, do you folks actually want the bare-pointer convention, or is it only there to attach noalias argument attribute? Maybe we should consider investing into expressing aliasing information in MLIR rather than keep the maintenance burden.

Thu, Sep 17, 8:12 AM · Restricted Project
ftynse added a comment to D87776: [mlir][ODS] Add TypeRef directive in Declarative Assembly Format to allow custom UserDirective parser to receive previously parsed types..

This looks useful.

Thu, Sep 17, 7:32 AM · Restricted Project
ftynse retitled D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition from [mlir]Add Allocate Clause to MLIR Parallel Operation Definition to [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Thu, Sep 17, 7:10 AM · Restricted Project
ftynse accepted D87767: [mlir][Linalg] Evolve named ops to use assembly form and support linalg on tensors..
Thu, Sep 17, 6:07 AM · Restricted Project
ftynse requested changes to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Thu, Sep 17, 5:16 AM · Restricted Project
ftynse accepted D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Thu, Sep 17, 4:40 AM · Restricted Project, Restricted Project
ftynse added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Thu, Sep 17, 4:35 AM · Restricted Project
ftynse committed rG68cfb0266855: [mlir] turn clang-format back on in C API test (authored by ftynse).
[mlir] turn clang-format back on in C API test
Thu, Sep 17, 4:01 AM
ftynse added inline comments to D87617: [mlir] expose affine map to C API.
Thu, Sep 17, 3:58 AM · Restricted Project
ftynse accepted D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Thu, Sep 17, 1:45 AM · Restricted Project
ftynse accepted D87766: [MLIR] Turns swapId into a FlatAffineConstraints member func.
Thu, Sep 17, 1:29 AM · Restricted Project

Wed, Sep 16

ftynse accepted D87617: [mlir] expose affine map to C API.

Thanks for iterating!

Wed, Sep 16, 7:08 AM · Restricted Project
ftynse committed rG855ec517a300: [mlir] Model StringRef in C API (authored by ftynse).
[mlir] Model StringRef in C API
Wed, Sep 16, 7:05 AM
ftynse closed D87677: [mlir] Model StringRef in C API.
Wed, Sep 16, 7:04 AM · Restricted Project
ftynse added inline comments to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Wed, Sep 16, 4:14 AM · Restricted Project
ftynse added a comment to D87677: [mlir] Model StringRef in C API.

Do you want to update those in this patch or have me do them in a follow-up?

Wed, Sep 16, 3:47 AM · Restricted Project
ftynse updated the diff for D87677: [mlir] Model StringRef in C API.

Also update Python bindings

Wed, Sep 16, 3:45 AM · Restricted Project
ftynse added a comment to D87617: [mlir] expose affine map to C API.

Is my understanding correct? Or I missed somthing important?

Wed, Sep 16, 3:34 AM · Restricted Project
ftynse accepted D86108: [MLIR][mlir-spirv-cpu-runner] A SPIR-V cpu runner prototype.
Wed, Sep 16, 1:28 AM · Restricted Project
ftynse accepted D87733: [mlir][openacc] Add missing operands for acc.parallel operation.
Wed, Sep 16, 12:58 AM · Restricted Project
ftynse added inline comments to D87617: [mlir] expose affine map to C API.
Wed, Sep 16, 12:55 AM · Restricted Project
ftynse requested changes to D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Wed, Sep 16, 12:51 AM · Restricted Project, Restricted Project

Tue, Sep 15

ftynse accepted D87546: [mlir][openacc] Add loop op verifier.
Tue, Sep 15, 8:26 AM · Restricted Project
ftynse added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Tue, Sep 15, 8:14 AM · Restricted Project
ftynse accepted D87696: [mlir][Standard] Canonicalize chains of tensor_cast operations.
Tue, Sep 15, 8:11 AM · Restricted Project
ftynse added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Tue, Sep 15, 8:07 AM · Restricted Project
ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

You can lower scf.parallel into omp parallel for/do *if* you prove the body does not contain (certain) OpenMP runtime calls and directives. So without analysis you cannot.

Tue, Sep 15, 8:00 AM · Restricted Project, Restricted Project
ftynse added inline comments to D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Tue, Sep 15, 6:54 AM · Restricted Project
ftynse added inline comments to D87676: [mlir][Linalg] Convolution tiling added to ConvOp vectorization pass.
Tue, Sep 15, 6:03 AM · Restricted Project
ftynse added inline comments to D87684: [mlir]Add Allocate Clause to OMP Parallel Operation Definition.
Tue, Sep 15, 4:42 AM · Restricted Project
ftynse committed rG967c7b6936a6: [mlir] check for failures when packing function sigunatures in std->llvm… (authored by ftynse).
[mlir] check for failures when packing function sigunatures in std->llvm…
Tue, Sep 15, 3:31 AM
ftynse closed D87605: [mlir] check for failures when packing function sigunatures in std->llvm conversion.
Tue, Sep 15, 3:30 AM · Restricted Project
ftynse accepted D87678: [mlir][integration_test] Linalg Conv folder renamed to CPU.
Tue, Sep 15, 3:12 AM · Restricted Project
ftynse updated the diff for D87605: [mlir] check for failures when packing function sigunatures in std->llvm conversion.

Rebase

Tue, Sep 15, 3:11 AM · Restricted Project
ftynse requested review of D87677: [mlir] Model StringRef in C API.
Tue, Sep 15, 3:05 AM · Restricted Project
ftynse accepted D87630: [mlir][openacc] Add missing print of vector_length in parallel op.
Tue, Sep 15, 1:51 AM · Restricted Project
ftynse added inline comments to D87546: [mlir][openacc] Add loop op verifier.
Tue, Sep 15, 1:48 AM · Restricted Project
ftynse requested changes to D87617: [mlir] expose affine map to C API.
Tue, Sep 15, 1:40 AM · Restricted Project

Mon, Sep 14

ftynse added inline comments to D87546: [mlir][openacc] Add loop op verifier.
Mon, Sep 14, 9:47 AM · Restricted Project
ftynse requested changes to D87617: [mlir] expose affine map to C API.
Mon, Sep 14, 9:45 AM · Restricted Project
ftynse added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Mon, Sep 14, 9:29 AM · Restricted Project
ftynse requested changes to D87546: [mlir][openacc] Add loop op verifier.
Mon, Sep 14, 7:43 AM · Restricted Project
ftynse requested review of D87605: [mlir] check for failures when packing function sigunatures in std->llvm conversion.
Mon, Sep 14, 4:47 AM · Restricted Project
ftynse committed rG5cac85c931d9: [mlir] Check for type conversion success in std->llvm function conversion (authored by ftynse).
[mlir] Check for type conversion success in std->llvm function conversion
Mon, Sep 14, 4:17 AM
ftynse closed D87075: [mlir] Check for type conversion success in std->llvm function conversion.
Mon, Sep 14, 4:16 AM · Restricted Project
ftynse accepted D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..
Mon, Sep 14, 12:27 AM · Restricted Project

Fri, Sep 11

ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

Sure: http://lists.flang-compiler.org/pipermail/flang-dev_lists.flang-compiler.org/2019-May/000197.html

@jdoerfert This is probably the old flang-dev mailing list.

Is it OK for @jdoerfert and @ftynse If I initiate the discussion in discourse?

I'm not following discourse.

Fri, Sep 11, 10:42 AM · Restricted Project, Restricted Project
ftynse requested changes to D87206: [MLIR][SPIRV] Support identified and recursive structs..
Fri, Sep 11, 10:40 AM · Restricted Project
ftynse accepted D87509: [MLIR][Linalg] Add minimal support for linalg on tensors with one reduction and one result..
Fri, Sep 11, 9:47 AM · Restricted Project
ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

I'm fine with anything that is not a code review, which most people would just ignore

Fri, Sep 11, 9:25 AM · Restricted Project, Restricted Project
ftynse added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Fri, Sep 11, 9:24 AM · Restricted Project
ftynse accepted D87492: [mlir] Fix some edge cases around 0-element TensorFromElementsOp.
Fri, Sep 11, 8:47 AM · Restricted Project
ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

It has to be the OpenMPIRBuilder that lowers it into a CFG (eventually) because it is not "a fortran/mlir/affine/... loop" but an OpenMP worksharing loop with all what that entails.

If there is an OpenMPIRBuilder::CreateForLoop or a plan to have it? So far, it looks a there is a non-negligible amount of code in Clang that emits the IR for loops, and replicating that code in mlir-translate is a no go.

It has to be the OpenMPIRBuilder that lowers it into a CFG (eventually) because it is not "a fortran/mlir/affine/... loop" but an OpenMP worksharing loop with all what that entails.

If there is an OpenMPIRBuilder::CreateForLoop or a plan to have it?

Yes.

Is there a written version somewhere we can see?

A written version of the plan? Yes. A written version of the code, not yet.

Fri, Sep 11, 5:21 AM · Restricted Project, Restricted Project
ftynse accepted D87440: [mlir][Linalg] Refactor StructuredOpInterface - NFC.
Fri, Sep 11, 4:34 AM · Restricted Project
ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

It has to be the OpenMPIRBuilder that lowers it into a CFG (eventually) because it is not "a fortran/mlir/affine/... loop" but an OpenMP worksharing loop with all what that entails.

If there is an OpenMPIRBuilder::CreateForLoop or a plan to have it? So far, it looks a there is a non-negligible amount of code in Clang that emits the IR for loops, and replicating that code in mlir-translate is a no go.

It has to be the OpenMPIRBuilder that lowers it into a CFG (eventually) because it is not "a fortran/mlir/affine/... loop" but an OpenMP worksharing loop with all what that entails.

If there is an OpenMPIRBuilder::CreateForLoop or a plan to have it?

Yes.

Fri, Sep 11, 1:49 AM · Restricted Project, Restricted Project

Thu, Sep 10

ftynse added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Thu, Sep 10, 10:39 AM · Restricted Project
ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

It has to be the OpenMPIRBuilder that lowers it into a CFG (eventually) because it is not "a fortran/mlir/affine/... loop" but an OpenMP worksharing loop with all what that entails.

Thu, Sep 10, 10:25 AM · Restricted Project, Restricted Project
ftynse added inline comments to D87440: [mlir][Linalg] Refactor StructuredOpInterface - NFC.
Thu, Sep 10, 9:30 AM · Restricted Project
ftynse added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

What exactly do you expect to do with OpenMP worksharing loops on this level which is problematic with CFGs?

Thu, Sep 10, 9:15 AM · Restricted Project, Restricted Project
ftynse added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Thu, Sep 10, 9:08 AM · Restricted Project
ftynse requested changes to D86071: [MLIR][OpenMP] Add omp.do operation.

I guess for the general workshare loop design issues we can have an RFC in discourse. But this patch can go ahead.

Thu, Sep 10, 8:54 AM · Restricted Project, Restricted Project

Tue, Sep 8

ftynse accepted D87284: Rename MemRefDescriptor::getElementType() to MemRefDescriptor::getElementPtrType()..
Tue, Sep 8, 6:35 AM · Restricted Project
ftynse added inline comments to D86619: [mlir] Conv ops vectorization pass.
Tue, Sep 8, 2:36 AM · Restricted Project

Mon, Sep 7

ftynse added inline comments to D87213: Preliminary python API for constructing operations..
Mon, Sep 7, 7:30 AM · Restricted Project
ftynse committed rG1e1a4a481987: [mlir] Take ValueRange instead of ArrayRef<Value> in StructuredIndexed (authored by ftynse).
[mlir] Take ValueRange instead of ArrayRef<Value> in StructuredIndexed
Mon, Sep 7, 6:18 AM
ftynse closed D87127: [mlir] Take ValueRange instead of ArrayRef<Value> in StructuredIndexed.
Mon, Sep 7, 6:17 AM · Restricted Project
ftynse accepted D87230: [MLIR] Fix Win test due to partial order of CHECK directives.
Mon, Sep 7, 3:43 AM · Restricted Project

Fri, Sep 4

ftynse committed rGaec9e20a3e9a: [mlir] introduce type constraints for operands of LLVM dialect operations (authored by ftynse).
[mlir] introduce type constraints for operands of LLVM dialect operations
Fri, Sep 4, 1:02 AM