Page MenuHomePhabricator
People curdeius

curdeius (Marek Kurdej)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2013, 1:59 AM (412 w, 16 h)

Recent Activity
View All

Wed, Jun 16

curdeius accepted D104372: [libcxx] Fix a case of -Wundef warnings regarding _POSIX_TIMERS.

LGTM.

Wed, Jun 16, 8:30 AM · Restricted Project

Wed, Jun 9

curdeius accepted D101868: [clang-format] Adds a formatter for aligning arrays of structs.

LGTM. That's a great piece work @feg208. Thank you!

Wed, Jun 9, 12:47 PM · Restricted Project, Restricted Project
curdeius added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Wed, Jun 9, 11:25 AM · Restricted Project, Restricted Project
curdeius added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Wed, Jun 9, 12:43 AM · Restricted Project, Restricted Project

Tue, Jun 8

curdeius accepted D103678: [Format] Fix incorrect pointer/reference detection.

LGTM modulo nits.

Tue, Jun 8, 5:09 AM · Restricted Project, Restricted Project
curdeius added a comment to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
In D101868#2805180, @MyDeveloperDay wrote:

Better still how about having

ArraryMemberAligmentEnum AlignArrayOfStructures

of "None, Left and Right"

I find boolean options don't stay boolean for long!

Tue, Jun 8, 4:56 AM · Restricted Project, Restricted Project

Sun, Jun 6

curdeius closed D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right.

This has been superseded by D103245. Closing.

Sun, Jun 6, 12:07 AM · Restricted Project, Restricted Project

Fri, Jun 4

curdeius committed rG21c18d5a0431: [Format] Fix incorrect pointer detection (authored by Nuullll).
[Format] Fix incorrect pointer detection
Fri, Jun 4, 12:39 AM
curdeius closed D103589: [Format] Fix incorrect pointer detection.
Fri, Jun 4, 12:39 AM · Restricted Project, Restricted Project

Thu, Jun 3

curdeius accepted D103589: [Format] Fix incorrect pointer detection.

LGTM. Thanks for fixing this!
Do you have commit rights or you need somebody to land it for you?

Thu, Jun 3, 5:13 AM · Restricted Project, Restricted Project
curdeius updated the summary of D103589: [Format] Fix incorrect pointer detection.
Thu, Jun 3, 5:03 AM · Restricted Project, Restricted Project

Wed, Jun 2

curdeius requested changes to D103589: [Format] Fix incorrect pointer detection.

Thanks for looking into this, but please add a test case that demonstrates the bug to FormatTests.cpp
Also, is there, by any chance, an associated bugzilla ticket?

Wed, Jun 2, 10:31 PM · Restricted Project, Restricted Project
curdeius added reviewers for D103589: [Format] Fix incorrect pointer detection: MyDeveloperDay, HazardyKnusperkeks.
Wed, Jun 2, 10:29 PM · Restricted Project, Restricted Project
curdeius added a comment to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

Thanks for adding the tests. 👍

Wed, Jun 2, 8:52 AM · Restricted Project, Restricted Project
curdeius added inline comments to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.
Wed, Jun 2, 4:48 AM · Restricted Project, Restricted Project

Sat, May 29

curdeius accepted D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

LGTM. But please wait for @HazardyKnusperkeks to land.

Sat, May 29, 5:14 AM · Restricted Project, Restricted Project

Fri, May 28

curdeius added a comment to D102730: [clang-format] Support custom If macros.

Thanks for working on this!
Looks pretty nice, but please clang-format the changes and add some more test cases (cf. inline comment).

Fri, May 28, 1:26 PM · Restricted Project, Restricted Project
curdeius accepted D103307: [clang-format] successive C# attributes cause line breaking issues.

LGTM.

Fri, May 28, 1:07 PM · Restricted Project, Restricted Project
curdeius added a comment to D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations.

Seems really nice. Just some nits & question.
Thanks for resuscitating the other review!

Fri, May 28, 1:03 PM · Restricted Project, Restricted Project
curdeius added a comment to D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is..
In D101344#2775517, @MyDeveloperDay wrote:

Whoops, We forgot to regenerate ClangFormatStyleOptions.rst here following the change to Format.h

Fri, May 28, 12:50 PM · Restricted Project
curdeius committed rG8702c6da162b: [clang-format] [docs] Regenerate style options documentation. (authored by curdeius).
[clang-format] [docs] Regenerate style options documentation.
Fri, May 28, 12:49 PM
curdeius accepted D103204: [clang-format] New BreakInheritanceList style AfterComma.

LGTM.

Fri, May 28, 12:31 PM · Restricted Project, Restricted Project

May 19 2021

curdeius added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
May 19 2021, 4:10 AM · Restricted Project

May 14 2021

curdeius accepted D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED".
May 14 2021, 8:28 AM · Restricted Project
curdeius accepted D102360: [libcxx] [test] Change the generic_string_alloc test to do a conversion that also does something on windows.
May 14 2021, 12:15 AM · Restricted Project
curdeius added a comment to D102359: [libc++] [test] Fix a few tests for 32-bit x86.

Also, please update https://bugs.llvm.org/show_bug.cgi?id=48939 and add it to the description.

May 14 2021, 12:14 AM · Restricted Project
curdeius accepted D102359: [libc++] [test] Fix a few tests for 32-bit x86.

LGTM. But please rebase to rerun CI (the commit that provoked the failures has been reverted).
It would be cool if @saugustine could have a look at gdb part though. @ldionne, this patch should unblock adding 32-bit buildbots to CI in D92508.

May 14 2021, 12:12 AM · Restricted Project
curdeius added a reviewer for D102359: [libc++] [test] Fix a few tests for 32-bit x86: saugustine.
May 14 2021, 12:08 AM · Restricted Project

May 13 2021

curdeius accepted D102360: [libcxx] [test] Change the generic_string_alloc test to do a conversion that also does something on windows.

LGTM. What do you think, would there be any value in testing different char types?

May 13 2021, 10:35 AM · Restricted Project
curdeius accepted D102365: [libcxx] Fix the function name in exceptions from create_directories.

LGTM.

May 13 2021, 10:29 AM · Restricted Project
curdeius added inline comments to D102357: [libcxx] [test] Explain an XFAIL LIBCXX-WINDOWS-FIXME and convert into "UNSUPPORTED".
May 13 2021, 10:14 AM · Restricted Project
curdeius accepted D102414: [libc++] Improve make_string test support..

LGTM. I second what Arthur said.

May 13 2021, 10:12 AM · Restricted Project
curdeius accepted D102392: [clang-format] PR50326 AlignAfterOpenBracket AlwaysBreak does not keep to the ColumnLimit.

LGTM. Not blocking, but I'd add foo4 example from the description as a test case (with a link to the bug maybe).

May 13 2021, 6:45 AM · Restricted Project, Restricted Project

May 12 2021

curdeius added inline comments to D102332: [libc++][nfc] remove duplicated __to_unsigned..
May 12 2021, 12:00 PM · Restricted Project

May 7 2021

curdeius added inline comments to D92168: [clang-format] Handle statement macro expressions in switch block.
May 7 2021, 2:33 AM · Restricted Project
curdeius added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
May 7 2021, 1:04 AM · Restricted Project, Restricted Project
curdeius added inline comments to D102048: [libc++] Run `substitutes-in-compile-flags.sh.cpp` test on Windows..
May 7 2021, 12:43 AM · Restricted Project

May 6 2021

curdeius accepted D101978: [libcxx] Fix a case of -Wundef warnings. NFC..

LGTM.

May 6 2021, 3:22 AM · Restricted Project
curdeius committed rGcdf33962d976: [clang-format] Rename common types between C#/JS (authored by exv).
[clang-format] Rename common types between C#/JS
May 6 2021, 3:13 AM
curdeius closed D101862: [clang-format] Rename common types between C#/JS.
May 6 2021, 3:13 AM · Restricted Project, Restricted Project
curdeius committed rGec725b307f3f: [clang-format] Fix C# nullable-related errors (authored by exv).
[clang-format] Fix C# nullable-related errors
May 6 2021, 3:11 AM
curdeius closed D101860: [clang-format] Fix C# nullable-related errors.
May 6 2021, 3:11 AM · Restricted Project, Restricted Project
curdeius committed rGa437befa8f85: [clang-format] Add more support for C# 8 nullables (authored by exv).
[clang-format] Add more support for C# 8 nullables
May 6 2021, 2:58 AM
curdeius closed D101702: [clang-format] Add more support for C# 8 nullables.
May 6 2021, 2:58 AM · Restricted Project, Restricted Project

May 5 2021

curdeius added a comment to D101878: [git-clang-format] Do not apply clang-format to symlinks.

Oh, I forgot, please add a release note.

May 5 2021, 2:03 PM · Restricted Project, Restricted Project
curdeius accepted D101878: [git-clang-format] Do not apply clang-format to symlinks.

LGTM but let's wait a day or two before landing, so that others can chime in.
Btw, do you have commit rights? If no, please provide "Name <email>" for commit attribution.

May 5 2021, 1:54 PM · Restricted Project, Restricted Project
curdeius added inline comments to D101878: [git-clang-format] Do not apply clang-format to symlinks.
May 5 2021, 1:40 PM · Restricted Project, Restricted Project
curdeius requested changes to D101868: [clang-format] Adds a formatter for aligning arrays of structs.

I like the idea, but we need more tests.

May 5 2021, 2:32 AM · Restricted Project, Restricted Project
curdeius added reviewers for D101868: [clang-format] Adds a formatter for aligning arrays of structs: MyDeveloperDay, HazardyKnusperkeks.
May 5 2021, 2:16 AM · Restricted Project, Restricted Project
curdeius retitled D101868: [clang-format] Adds a formatter for aligning arrays of structs from Adds a formatter for aligning arrays of structs to [clang-format] Adds a formatter for aligning arrays of structs.
May 5 2021, 2:15 AM · Restricted Project, Restricted Project
curdeius accepted D101862: [clang-format] Rename common types between C#/JS.

LGTM pending CI.

May 5 2021, 2:15 AM · Restricted Project, Restricted Project
curdeius accepted D101860: [clang-format] Fix C# nullable-related errors.

LGTM pending CI.

May 5 2021, 12:44 AM · Restricted Project, Restricted Project
curdeius added a comment to D101860: [clang-format] Fix C# nullable-related errors.

You can add a parent revision so that this patch will be applied upon its parent.

May 5 2021, 12:39 AM · Restricted Project, Restricted Project
curdeius added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Could you please rebase to re-run the CI (that failed for sum unrelated reason)?

May 5 2021, 12:38 AM · Restricted Project, Restricted Project

May 4 2021

curdeius added a comment to D101702: [clang-format] Add more support for C# 8 nullables.

Preferably a new one unless it's something really minor.

May 4 2021, 2:18 PM · Restricted Project, Restricted Project
curdeius added a comment to D101702: [clang-format] Add more support for C# 8 nullables.
In D101702#2736886, @exv wrote:

According to the wiki, it seems like someone who has commit access must now submit this change.

May 4 2021, 12:17 PM · Restricted Project, Restricted Project
curdeius accepted D101628: [Format] Don't sort includes if DisableFormat is true.

LGTM. Thanks!

May 4 2021, 10:26 AM · Restricted Project, Restricted Project
curdeius accepted D101702: [clang-format] Add more support for C# 8 nullables.

LGTM. That's great. Thanks for working on this and for the cleanup.

May 4 2021, 12:14 AM · Restricted Project, Restricted Project

May 3 2021

curdeius requested changes to D101702: [clang-format] Add more support for C# 8 nullables.

Looks very good already. Just some questions and test requests.

May 3 2021, 2:25 PM · Restricted Project, Restricted Project
curdeius added a comment to D101628: [Format] Don't sort includes if DisableFormat is true.

Is it testable?

May 3 2021, 1:36 PM · Restricted Project, Restricted Project
curdeius committed rG31751ce1b923: [clang-format] Fix build on gcc < 7 introduced in rG8d93d7ff. (authored by curdeius).
[clang-format] Fix build on gcc < 7 introduced in rG8d93d7ff.
May 3 2021, 9:54 AM
curdeius committed rG40f783434b0b: [docs] Automatically update copyright year in libc++. (authored by curdeius).
[docs] Automatically update copyright year in libc++.
May 3 2021, 9:46 AM
curdeius committed rG9d669e859b80: [docs] Bump the trunk major version to 13 and update copyright year. (authored by curdeius).
[docs] Bump the trunk major version to 13 and update copyright year.
May 3 2021, 9:45 AM
curdeius committed rGb2be167a4952: [docs] Fix title overline. (authored by curdeius).
[docs] Fix title overline.
May 3 2021, 9:33 AM
curdeius committed rGd492532b8c3a: [docs] Fix syntax typo. (authored by curdeius).
[docs] Fix syntax typo.
May 3 2021, 9:29 AM
curdeius committed rG8d93d7ffedeb: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to… (authored by curdeius).
[clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to…
May 3 2021, 9:11 AM
curdeius closed D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
May 3 2021, 9:11 AM · Restricted Project
curdeius updated the diff for D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
  • Fix format.
May 3 2021, 2:13 AM · Restricted Project
curdeius added a comment to D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++.

Still LGTM.

May 3 2021, 1:31 AM · Restricted Project

May 1 2021

curdeius added a comment to D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..

I went a different way in order to keep backward compatibility.
I renamed Alwayss to OnlyFirstIf and added AllIfsAndElse that behaves as Always in my initial patch.
@MyDeveloperDay, please have another look.

May 1 2021, 1:17 PM · Restricted Project
curdeius retitled D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else". from [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch. to [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
May 1 2021, 1:14 PM · Restricted Project
curdeius updated the diff for D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..
  • [clang-format] Apply AllowShortIfStatementsOnASingleLine: AllIfsAndElse to "else if" and "else". Keep backward-compatibility.
May 1 2021, 1:13 PM · Restricted Project

Apr 30 2021

curdeius accepted D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++.

LGTM. Nice!

Apr 30 2021, 4:39 AM · Restricted Project
curdeius accepted D101613: [libcxx] Reenable ranges for clang-cl.

LGTM pending CI.

Apr 30 2021, 4:27 AM · Restricted Project

Apr 29 2021

curdeius added inline comments to D101565: [libcxx] [ci] Add a Windows CI configuration for a statically linked libc++.
Apr 29 2021, 1:33 PM · Restricted Project
curdeius committed rG40c2d6188b08: [clang-format] Fix build on gcc < 7 introduced in rG9363aa9. (authored by curdeius).
[clang-format] Fix build on gcc < 7 introduced in rG9363aa9.
Apr 29 2021, 1:09 AM
curdeius committed rG6e5082bbc498: [clang-format] Fix build on gcc < 7 introduced in rG9363aa9. (authored by curdeius).
[clang-format] Fix build on gcc < 7 introduced in rG9363aa9.
Apr 29 2021, 12:58 AM

Apr 28 2021

curdeius committed rG9363aa90bfe6: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle… (authored by curdeius).
[clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle…
Apr 28 2021, 11:59 PM
curdeius closed D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is..
Apr 28 2021, 11:59 PM · Restricted Project
curdeius accepted D101436: [libcxx] Stop hardcoding the bash path in the Windows CI.

LGTM. Cool!

Apr 28 2021, 9:17 AM · Restricted Project
curdeius accepted D101434: [libcxx] [test] Include more libraries that normally are linked automatically.

LGTM. Is there any other option on clang-cl to avoid linking MSVCRT but linking other stuff? Is there going to be any change in clang 13?

Apr 28 2021, 3:04 AM · Restricted Project
curdeius accepted D101420: [libc++] [test] Don't assume iterators are class types..

FWIW, LGTM.

Apr 28 2021, 1:25 AM · Restricted Project

Apr 27 2021

curdeius accepted D101293: [libc++] Move <__sso_allocator> out of include/ into src/. NFCI..

LGTM.

Apr 27 2021, 12:58 PM · Restricted Project
curdeius accepted D101303: [libc++][CI] Fix check-generated-output..

LGTM. I have no strong feelings about the order of commands (per Arthur's comment). Both are OK for me.

Apr 27 2021, 9:20 AM · Restricted Project
curdeius committed rG7f98209da634: [libc++] Fix set-but-not-used warning. NFC. (authored by curdeius).
[libc++] Fix set-but-not-used warning. NFC.
Apr 27 2021, 3:23 AM
curdeius accepted D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled.

LGTM. I also consider it a bug. LLVM should not be affected as it uses AllowShortEnumsOnASingleLine: true whereas this problem arises only with AllowShortEnumsOnASingleLine: false.
Anyway, those that find the new behaviour problematic, can always set BreakBeforeBraces: Custom and BraceWrapping.AfterEnum: true to get the old behaviour.
@lunasorcery, please update release notes before landing.
If you don't have commit rights, please provide "Your Name <email@address>" for commit attribution, otherwise we'll use the name/email associated with you Phabricator account.

Apr 27 2021, 1:45 AM · Restricted Project, Restricted Project
curdeius requested review of D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is..
Apr 27 2021, 1:11 AM · Restricted Project
curdeius committed rG3feb84a36f51: [clang-format] Merge SpacesInAngles tests. NFC. (authored by curdeius).
[clang-format] Merge SpacesInAngles tests. NFC.
Apr 27 2021, 12:33 AM
curdeius committed rG17139b2b21a0: [clang-format] Reformat. NFC. (authored by curdeius).
[clang-format] Reformat. NFC.
Apr 27 2021, 12:11 AM

Apr 24 2021

curdeius accepted D101233: [libc++] Adds __utility/to_underlying.h..

LGTM. Please update the filename in the comment as indicated by Arthur before landing.

Apr 24 2021, 12:52 PM · Restricted Project
curdeius added a comment to D101183: [libc++] Make sure __bit_iterator does not use deprecated SMF generation.

Stupid question... but what's SMF?

Apr 24 2021, 6:23 AM · Restricted Project

Apr 21 2021

curdeius added inline comments to D100866: Add a buildkite for _LIBCPP_DEBUG=1..
Apr 21 2021, 6:59 AM · Restricted Project

Apr 20 2021

curdeius added inline comments to D100595: [libcxx][test] Attempt to make debug mode tests more bulletproof.
Apr 20 2021, 4:16 AM · Restricted Project
curdeius accepted D100789: [libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs.

LGTM. IIUC these tests will unexpectedly pass when this bug is fixed in clang, right? And then, we would be able to remove XFAIL annotations. If it's so, then it's good.

Apr 20 2021, 2:50 AM · Restricted Project
curdeius accepted D100221: [libcxx] [test] Add a separate 'windows-dll' feature to check for.

LGTM.

Apr 20 2021, 2:41 AM · Restricted Project
curdeius added inline comments to D100828: Remove if-else to make branch predictor happy.
Apr 20 2021, 2:37 AM · Restricted Project

Apr 19 2021

curdeius accepted D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set.

LGTM.

Apr 19 2021, 10:57 PM · Restricted Project
curdeius accepted D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons.

LGTM.

Apr 19 2021, 1:43 PM · Restricted Project
curdeius planned changes to D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else"..

More I look at the current state of this option, more I think it's misleading.
I would expect that the if after else is also controlled by this option. And, the last else as well (adding yet another option for that seems to be a bit an overkill)

Apr 19 2021, 6:27 AM · Restricted Project
curdeius added inline comments to D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set.
Apr 19 2021, 12:45 AM · Restricted Project, Restricted Project