Page MenuHomePhabricator

curdeius (Marek Kurdej)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2013, 1:59 AM (348 w, 6 d)

Recent Activity

Fri, Apr 3

curdeius added a comment to D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Ping.

Fri, Apr 3, 1:02 AM · Unknown Object (Project)

Thu, Mar 12

curdeius committed rG05343588e3bf: [libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type. (authored by curdeius).
[libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type.
Thu, Mar 12, 3:47 AM
curdeius closed D70275: [libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type..
Thu, Mar 12, 3:47 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Avoid using std::distance.

Thu, Mar 12, 3:46 AM · Unknown Object (Project)
curdeius added a comment to D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

It would be nice if we could remove the calls to std::difference and replace them with a count variable so that we only have to iterate once. It may require adding a __libcpp_ erase function, though.

Thu, Mar 12, 3:46 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Fix typo.

Thu, Mar 12, 3:03 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Avoid using overloaded comma operator.

Thu, Mar 12, 3:03 AM · Unknown Object (Project)
curdeius updated the diff for D70275: [libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type..

Rebase to master.

Thu, Mar 12, 2:19 AM · Unknown Object (Project)

Wed, Mar 11

curdeius added a comment to D70275: [libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type..

Ping.

Wed, Mar 11, 1:35 AM · Unknown Object (Project)

Tue, Mar 10

curdeius added a comment to D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

The pre-merge build results show this build as failed because of failing clang-format linter tests (https://reviews.llvm.org/harbormaster/build/52549/, https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-4604/summary.html).
However, these "failures" are all misindentations of preprocessor directives in generated files in libcxx/test/std/language.support/support.limits/support.limits.general/.
That's out of scope of this patch, but isn't the real fix modifying .clang-format config file to indent PP directives (or having a local copy of .clang-format in tests)?

Tue, Mar 10, 7:32 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Fix __cpp_lib_erase_if value.

Tue, Mar 10, 6:23 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Fix tests with custom allocators. Fix assert in map test.

Tue, Mar 10, 6:23 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Fix string.

Tue, Mar 10, 5:12 AM · Unknown Object (Project)
curdeius updated the diff for D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..

Fixed forgotten return type tests.

Tue, Mar 10, 5:12 AM · Unknown Object (Project)
curdeius added inline comments to D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..
Tue, Mar 10, 4:29 AM · Unknown Object (Project)
curdeius updated the summary of D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..
Tue, Mar 10, 4:29 AM · Unknown Object (Project)
curdeius created D75905: [libc++][P1115][C++20] Improving the Return Value of Erase-Like Algorithms II: Free erase/erase if..
Tue, Mar 10, 4:29 AM · Unknown Object (Project)

Jan 31 2020

curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

I've fixed the expected error mesages and relanded it in commit 5e7017273f40a48453ebb758e54123e31f751806 (https://reviews.llvm.org/rGe93e58c6c40a365bc9275dd8a8242598343cc835).

Jan 31 2020, 4:37 AM · Unknown Object (Project)
curdeius committed rGe93e58c6c40a: Reland [libc++] [P0325] Implement to_array from LFTS with updates. (authored by curdeius).
Reland [libc++] [P0325] Implement to_array from LFTS with updates.
Jan 31 2020, 2:54 AM
curdeius committed rG5e7017273f40: Revert "[libc++] [P0325] Implement to_array from LFTS with updates." (authored by curdeius).
Revert "[libc++] [P0325] Implement to_array from LFTS with updates."
Jan 31 2020, 12:48 AM
curdeius added a reverting change for rG86aae78268f3: [libc++] [P0325] Implement to_array from LFTS with updates.: rG5e7017273f40: Revert "[libc++] [P0325] Implement to_array from LFTS with updates.".
Jan 31 2020, 12:47 AM
curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Reverted.

Jan 31 2020, 12:47 AM · Unknown Object (Project)

Jan 30 2020

curdeius committed rG86aae78268f3: [libc++] [P0325] Implement to_array from LFTS with updates. (authored by curdeius).
[libc++] [P0325] Implement to_array from LFTS with updates.
Jan 30 2020, 4:39 AM
curdeius closed D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
Jan 30 2020, 4:39 AM · Unknown Object (Project)

Dec 6 2019

curdeius added a comment to D70346: [libc++] [LWG3321] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..

Ping. :)

Dec 6 2019, 1:13 AM · Unknown Object (Project)
curdeius added a comment to D70275: [libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type..

Ping. :)

Dec 6 2019, 1:13 AM · Unknown Object (Project)
curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Ping. :)

Dec 6 2019, 1:13 AM · Unknown Object (Project)

Nov 18 2019

curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

What's the usual way of proceeding, should I land the patch or wait for Louis' approval?

Nov 18 2019, 12:54 AM · Unknown Object (Project)

Nov 15 2019

curdeius created D70346: [libc++] [LWG3321] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..
Nov 15 2019, 3:25 PM · Unknown Object (Project)
curdeius committed rG8e34be2f2511: [libc++] [chrono] Fix year_month_weekday::ok() implementation. (authored by curdeius).
[libc++] [chrono] Fix year_month_weekday::ok() implementation.
Nov 15 2019, 9:57 AM
curdeius closed D70282: [libc++] [chrono] Fix year_month_weekday::ok() implementation..
Nov 15 2019, 9:56 AM · Unknown Object (Project)
curdeius updated the diff for D70282: [libc++] [chrono] Fix year_month_weekday::ok() implementation..
  • Add tests. Update Returns commment according to [time.cal.ymwd.members]/21.
Nov 15 2019, 4:08 AM · Unknown Object (Project)

Nov 14 2019

curdeius created D70282: [libc++] [chrono] Fix year_month_weekday::ok() implementation..
Nov 14 2019, 4:26 PM · Unknown Object (Project)
curdeius committed rG76ac1660f767: [libc++] [P0920] [P1661] Update status page. (authored by curdeius).
[libc++] [P0920] [P1661] Update status page.
Nov 14 2019, 3:22 PM
curdeius created D70275: [libc++] [P0646] Add feature-test macro for __cpp_lib_list_remove_return_type..
Nov 14 2019, 2:36 PM · Unknown Object (Project)
curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Just as a side-note, @ldionne, I have commit access, so I can land the patches, but do as you prefer (when the patch gets accepted) :).

Nov 14 2019, 2:16 PM · Unknown Object (Project)
curdeius added inline comments to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
Nov 14 2019, 1:29 PM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Make return type consistent.
Nov 14 2019, 1:29 PM · Unknown Object (Project)

Nov 13 2019

curdeius retitled D70221: [libc++] [P1612] Add missing feature-test macro __cpp_lib_endian. from P1612 Add missing feature-test macro for __cpp_lib_endian. to [libc++] [P1612] Add missing feature-test macro __cpp_lib_endian..
Nov 13 2019, 10:52 PM · Unknown Object (Project)
curdeius retitled D69882: [libc++] [P0325] Implement to_array from LFTS with updates. from [libcxx] Implement P0325: to_array from LFTS with updates. to [libc++] [P0325] Implement to_array from LFTS with updates..
Nov 13 2019, 10:52 PM · Unknown Object (Project)
curdeius created D70221: [libc++] [P1612] Add missing feature-test macro __cpp_lib_endian..
Nov 13 2019, 10:52 PM · Unknown Object (Project)
curdeius updated the diff for D70206: [libc++] [P1872] span should have size_type, not index_type..

Rebase.

Nov 13 2019, 2:01 PM · Unknown Object (Project)
curdeius committed rGd94f63758a69: libc++ status page: Fix HTML. (authored by curdeius).
libc++ status page: Fix HTML.
Nov 13 2019, 1:52 PM
curdeius added reviewers for D70206: [libc++] [P1872] span should have size_type, not index_type.: lichray, ldionne.
Nov 13 2019, 1:47 PM · Unknown Object (Project)
curdeius created D70206: [libc++] [P1872] span should have size_type, not index_type..
Nov 13 2019, 1:47 PM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Fix typo in comment.
Nov 13 2019, 1:23 PM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Readd noexcept.
  • Fix message.
Nov 13 2019, 1:19 PM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Fix patch diff.

Nov 13 2019, 12:50 PM · Unknown Object (Project)
curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Adressed comments.

Nov 13 2019, 12:27 PM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Add synopsis.
Nov 13 2019, 10:11 AM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Fix constexpr and return type.
  • Fix tests.
Nov 13 2019, 10:11 AM · Unknown Object (Project)
curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

I'm still not sure what to do about noexcept for to_array.
libstdc++ adds noexcept: https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/array#L361
MSVC STL does not add noexcept: https://github.com/microsoft/STL/blob/master/stl/inc/array#L429
It seems to be a low-hanging fruit to add noexcept(is_nothrow_copy_constructible_v<_Tp>) / noexcept(is_nothrow_move_constructible_v<_Tp>).
What do you think?

Nov 13 2019, 1:47 AM · Unknown Object (Project)
curdeius added a reviewer for D69882: [libc++] [P0325] Implement to_array from LFTS with updates.: ldionne.
Nov 13 2019, 1:46 AM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Fix typos.
Nov 13 2019, 1:37 AM · Unknown Object (Project)
curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Updated with tests from D66103. Answered issues from comments.

Nov 13 2019, 1:37 AM · Unknown Object (Project)
curdeius updated the diff for D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
  • Clean up to_array implementation.
  • Add tests from D66103. Clean up.
Nov 13 2019, 1:28 AM · Unknown Object (Project)

Nov 7 2019

curdeius added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Oh, I didn't know it, I only searched for to_array in master branch before starting.
How should I proceed? I let you take out of my patch what can be useful?
I see that you didn't touch feature test macros at all for instance. And as you said, you might add some tests I added and you seem not having (e.g. fail tests).

Nov 7 2019, 12:40 AM · Unknown Object (Project)

Nov 6 2019

curdeius updated the summary of D69884: [libcxx] Make generate_feature_test_macro_components script compatible with Python 3..
Nov 6 2019, 2:13 AM · Unknown Object (Project)
curdeius created D69884: [libcxx] Make generate_feature_test_macro_components script compatible with Python 3..
Nov 6 2019, 2:13 AM · Unknown Object (Project)
curdeius retitled D69882: [libc++] [P0325] Implement to_array from LFTS with updates. from [libcxx] Add P0325 - to_array. to [libcxx] Implement P0325: to_array from LFTS with updates..
Nov 6 2019, 1:46 AM · Unknown Object (Project)
curdeius created D69882: [libc++] [P0325] Implement to_array from LFTS with updates..
Nov 6 2019, 1:37 AM · Unknown Object (Project)

Nov 5 2019

curdeius accepted D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted.

LGTM. Just a small typo in comment. Otherwise, great job!

Nov 5 2019, 1:24 PM · Restricted Project, Unknown Object (Project), Unknown Object (Project)
curdeius added inline comments to D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted.
Nov 5 2019, 12:44 AM · Restricted Project, Unknown Object (Project), Unknown Object (Project)

Nov 4 2019

curdeius added a comment to D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted.

Minor comments.

Nov 4 2019, 8:35 AM · Restricted Project, Unknown Object (Project), Unknown Object (Project)

Oct 24 2019

curdeius committed rG73cebfe4128c: [libFuzzer] docs: update note to include REDUCE event. (authored by curdeius).
[libFuzzer] docs: update note to include REDUCE event.
Oct 24 2019, 3:07 AM

Dec 18 2018

curdeius added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

LGTM.
Any ideas for improvement, @JonasToth?
I'd rather have it merged and improve on it later if there are ideas on how to do it better.

Dec 18 2018, 1:42 AM · Unknown Object (Project)

Dec 14 2018

curdeius added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 14 2018, 12:49 AM · Unknown Object (Project)

Dec 11 2018

curdeius added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 11 2018, 2:40 AM · Unknown Object (Project)
curdeius added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

A few more ideas for enhancements.

Dec 11 2018, 1:01 AM · Unknown Object (Project)

Dec 10 2018

curdeius accepted D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

LGTM. But I'm not a code owner here and I don't know if you need an acceptance of one of them.
Great job.

Dec 10 2018, 8:57 AM · Unknown Object (Project)
curdeius requested changes to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 10 2018, 8:36 AM · Unknown Object (Project)
curdeius added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Some more minor remarks. I'll give this check a try to see how it behaves on some of my projects.
I agree that a high rate of false positives is possible (and is a bit of spoiler) but I wouldn't reject this IMO useful check because of that.
Anyway, everything looks pretty clean for me.

Dec 10 2018, 7:00 AM · Unknown Object (Project)
curdeius requested changes to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Just a few minor remarks and a possible workaround for testing CHECK-FIXES: [[nodiscard]].

Dec 10 2018, 1:29 AM · Unknown Object (Project)

Oct 19 2018

curdeius updated the diff for D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

Fixed diff.

Oct 19 2018, 12:21 AM

Oct 18 2018

curdeius updated the diff for D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

Applied changes as per comments.

Oct 18 2018, 9:11 AM
curdeius added a comment to D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

Actually, I can make it an option for this check to skip or not constexpr ifs, WDYT?

Oct 18 2018, 2:02 AM
curdeius added a comment to D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

I think it would be good to add some more explanation as to *why* that else has to be kept.

Oct 18 2018, 2:01 AM

Oct 17 2018

curdeius created D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..
Oct 17 2018, 6:28 AM

Sep 28 2017

curdeius created D38357: [Support/Regex] Handle tabulators and escaped chars in square brackets..
Sep 28 2017, 7:10 AM

Sep 27 2017

curdeius closed D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..
Sep 27 2017, 12:53 AM

Sep 26 2017

curdeius accepted D35743: [clang-format] Adjust space around &/&& of structured bindings.

Thanks for the changes. LGTM.

Sep 26 2017, 3:30 PM · Unknown Object (Project)
curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

Any thoughts on this?

Sep 26 2017, 3:30 PM

Sep 21 2017

curdeius added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

Could you add just one more test for PAS_Middle please? A single line will be just enough.
Otherwise, LGTM.

Sep 21 2017, 4:25 AM · Unknown Object (Project)

Sep 20 2017

curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

That's precisely what I've written, but, as I'd said before, such tests pass already without any modification in NamespaceEndCommentsFixer.

Sep 20 2017, 8:16 AM
curdeius abandoned D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman..

This was fixed by https://reviews.llvm.org/rL312904 and other commits.

Sep 20 2017, 5:44 AM

Sep 19 2017

curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

I confirm what I observed before: when invoking tests in unittests/Format/NamespaceEndCommentsFixerTest.cpp, the const AnnotatedLine *line parameter in getNamespaceToken gets one big line that includes both namespace and { (something like namespace\n{\n..., whereas in tests invoked from unittests/Format/FormatTests.cpp, there is a separate line with namespace\n and another one with {\n.

Sep 19 2017, 8:41 AM
curdeius abandoned D37980: [clang-format] Better parsing of lambda captures with initializer expressions..

Ok. Nice patch. You can close https://bugs.llvm.org/show_bug.cgi?id=19986 now.

Sep 19 2017, 7:25 AM
curdeius updated the diff for D37980: [clang-format] Better parsing of lambda captures with initializer expressions..

Minor: use FormatToken::isNot instead of !FormatToken::is.

Sep 19 2017, 2:59 AM
curdeius added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

There is one big missing thing here: PointerAlignment. Actually only PAS_Left is taken into account.
There are 3 possible options:
Left: auto& [a, b] = f();
Middle: auto & [a, b] = f();
Right: auto &[a, b] = f();

Sep 19 2017, 2:48 AM · Unknown Object (Project)

Sep 18 2017

curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

Could you please move the test that adds a namespace end comment to unittests/Format/NamespaceEndCommentsFixerTest.cpp?

Sep 18 2017, 9:02 AM
curdeius created D37980: [clang-format] Better parsing of lambda captures with initializer expressions..
Sep 18 2017, 8:48 AM

Sep 15 2017

curdeius updated the summary of D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..
Sep 15 2017, 7:50 AM
curdeius created D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..
Sep 15 2017, 7:48 AM

Sep 7 2017

curdeius abandoned D31334: [clang-format] Add options for indenting preprocessor directives.

Superseded by rL312125.

Sep 7 2017, 7:33 AM
curdeius closed D37132: [clang-format] Add support for C++17 structured bindings..
Sep 7 2017, 7:30 AM

Aug 29 2017

curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Fix: use do-while loop.

Aug 29 2017, 6:43 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Extract method.

Aug 29 2017, 6:25 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Fix line endings again.

Aug 29 2017, 6:17 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Revert unintended format changes.

Aug 29 2017, 6:15 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Fix line endings.

Aug 29 2017, 5:52 AM