Page MenuHomePhabricator

curdeius (Marek Kurdej)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2013, 1:59 AM (373 w, 5 d)

Recent Activity

Yesterday

curdeius added a comment to D88296: [clang-format] De-duplicate includes with leading or trailing whitespace..

Finally I've opted for creating a small revision just fixing this particular bug report.
Mind however that the problem is a bit more complex and to solve all possible cases we would need to first reformat the source code, then sort the includes and then again, possibly reformat parts of the source code modified by sorting, so that the comments get re-aligned etc.

Fri, Sep 25, 6:03 AM · Restricted Project
curdeius updated the diff for D88296: [clang-format] De-duplicate includes with leading or trailing whitespace..
  • Ooops. Revert unwanted test changes.
Fri, Sep 25, 6:02 AM · Restricted Project
curdeius updated the summary of D88296: [clang-format] De-duplicate includes with leading or trailing whitespace..
Fri, Sep 25, 5:58 AM · Restricted Project
curdeius requested review of D88296: [clang-format] De-duplicate includes with leading or trailing whitespace..
Fri, Sep 25, 5:57 AM · Restricted Project

Wed, Sep 23

curdeius updated subscribers of D52676: [clang-format] tweaked another case of lambda formatting.

Hi,
I know it's an old revision, but I confirm that it provoked the bug https://bugs.llvm.org/show_bug.cgi?id=45141.
The problem is in the TokenAnnotator::mustBreakBefore as @jaafar pointed out:

if (!Next->isOneOf(TT_LambdaLSquare, tok::l_brace, tok::caret))
  return true; // << HERE

It should return false if everything fits on a single line.
I'm not sure how to check this though.
@MyDeveloperDay, would you have an idea?

Wed, Sep 23, 2:18 AM · Restricted Project, Restricted Project

Thu, Sep 17

curdeius accepted D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.
Thu, Sep 17, 2:16 AM · Restricted Project, Restricted Project
curdeius added a comment to D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function.

LGTM.
Don't we risk any other side effects?

Thu, Sep 17, 2:16 AM · Restricted Project, Restricted Project

Aug 11 2020

curdeius committed rGb18c63e85aa8: [clang-format] use spaces for alignment of binary/ternary expressions with… (authored by fickert).
[clang-format] use spaces for alignment of binary/ternary expressions with…
Aug 11 2020, 5:57 AM
curdeius closed D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.
Aug 11 2020, 5:57 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.

LGTM. Thank you for the patch!

Aug 11 2020, 4:13 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.
Aug 11 2020, 3:43 AM · Restricted Project, Restricted Project, Restricted Project

Aug 7 2020

curdeius added a comment to D85466: [libcxx] Add C++20 source_location header.

Please take a look at the discussion in https://reviews.llvm.org/D80376 that has been put on standby because the desired ABI needs compiler support.

Aug 7 2020, 12:45 AM · Unknown Object (Project)

Jul 30 2020

curdeius added inline comments to D84943: [libc++] Remove workarounds for missing rvalue references.
Jul 30 2020, 7:18 AM · Unknown Object (Project)

Jul 22 2020

curdeius added inline comments to D83296: [clang-format] Add a MacroExpander..
Jul 22 2020, 2:18 PM · Restricted Project, Restricted Project

Jul 18 2020

curdeius added a comment to D84090: [clang-format] Add BitFieldColonSpacing option.

The changes look good to me in general. I share your doubt though about whether a bool flag is sufficient here. We've seen in the past a few times that at some time a false/true flag is not enough. I'd rather go for a Before/After/Both/None flag (or similar, naming probably should be coherent with other flags). But I'm not really aware of the projects/coding styles that use bit fields. Maybe a small research on this would be good to confirm or infirm a necessity of higher complexity.

Jul 18 2020, 9:47 AM · Restricted Project, Restricted Project

Jul 12 2020

curdeius accepted D83564: [clang-format] PR46609 clang-format does not obey `PointerAlignment: Right` for ellipsis in declarator for pack.

LGTM! Thanks for fixing this.

Jul 12 2020, 5:34 AM · Restricted Project, Restricted Project

Jul 2 2020

curdeius added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
Jul 2 2020, 2:03 PM · Restricted Project, Restricted Project

Jun 26 2020

curdeius accepted D82620: [clang-format] Preserve whitespace in selected macros.

LGTM. Thank you for taking my comments into account.

Jun 26 2020, 12:02 PM · Restricted Project, Restricted Project
curdeius added inline comments to D82620: [clang-format] Preserve whitespace in selected macros.
Jun 26 2020, 1:04 AM · Restricted Project, Restricted Project
curdeius added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
Jun 26 2020, 12:31 AM · Restricted Project, Restricted Project

Jun 23 2020

curdeius added a comment to D80902: [libcxx] adds lexicographical_compare_three_way.

As a general remark, it would be call if you added a link to standard draft or proposal (or both) in the summary of each revision. It would make reviewing a bit easier :).

Jun 23 2020, 1:00 AM · Unknown Object (Project)
curdeius added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
Jun 23 2020, 1:00 AM
curdeius added inline comments to D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 23 2020, 1:00 AM
curdeius added inline comments to D80899: [libcxx] adds std::compare_three_way.
Jun 23 2020, 1:00 AM · Unknown Object (Project)
curdeius added inline comments to D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 23 2020, 1:00 AM
curdeius added a comment to D80899: [libcxx] adds std::compare_three_way.

My 2 cents.

Jun 23 2020, 12:29 AM · Unknown Object (Project)
curdeius added inline comments to D80891: [libcxx] adds operator<=> for basic_string_view.
Jun 23 2020, 12:28 AM

Jun 19 2020

curdeius added inline comments to D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
Jun 19 2020, 1:34 AM · Unknown Object (Project)
curdeius planned changes to D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..

I've updated the "unsupported" comments with precise compiler versions. I cannot test apple-clang though.
Anyway, I'll put this revision into hibernation until there's a builtin for a single-pointer source location (whether it be __bultin_source_location or T* __builtin_static_storage_duration(T)).

Jun 19 2020, 1:02 AM · Unknown Object (Project)
curdeius updated the diff for D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
  • Use precise compiler versions in UNSUPPORTED.
Jun 19 2020, 1:02 AM · Unknown Object (Project)

Jun 18 2020

curdeius added inline comments to D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
Jun 18 2020, 5:24 AM · Unknown Object (Project)
curdeius added a comment to D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..

Ok, so clang 8 doesn't support consteval. It also doesn't have required builtins (__builtin_FILE etc.). consteval works ok on clang 9+.
How can I mark tests as unsupported when the builtins are not supported? (a good example would be column.pass.cpp test that I disabled for gcc that doesn't have __builtin_COLUMN)

Jun 18 2020, 3:46 AM · Unknown Object (Project)
curdeius added inline comments to D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
Jun 18 2020, 3:46 AM · Unknown Object (Project)
curdeius updated the diff for D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
  • Rebase.
  • Address review comments.
Jun 18 2020, 3:46 AM · Unknown Object (Project)

Jun 17 2020

curdeius accepted D82016: [clang-format] [PR462254] fix indentation of default and break correctly in whitesmiths style.

Great!

Jun 17 2020, 11:50 AM · Restricted Project, Restricted Project

Jun 3 2020

curdeius accepted D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.

For a second, I thought that you could simplify the code by removing this @try condition (and calling the function FormatTokenLexer::tryTransformTryUsageForC() only if isCppOnly, but given that Objective is a superset of C, it's probably safer to keep it the way it's done now.

Jun 3 2020, 7:06 AM · Restricted Project, Restricted Project
curdeius accepted D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.

LGTM.
Keep in mind I'm not the code owner, I don't know if another approval is required.

Jun 3 2020, 7:05 AM · Restricted Project, Restricted Project
curdeius added inline comments to D80895: [libcxx] adds operator<=> for basic_string.
Jun 3 2020, 6:00 AM
curdeius added a comment to D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases.

Nice. Should we test other non-C keywords as well?
Out of curiosity, where does "@try" come from?

Jun 3 2020, 5:27 AM · Restricted Project, Restricted Project
curdeius added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
Jun 3 2020, 4:53 AM · Unknown Object (Project)
curdeius added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

I would have nothing against if you'd added this option and we kept current behaviour by default.
The only drawback is the (bit of) complexity it adds bit that seems justified to me.

Jun 3 2020, 4:53 AM · Restricted Project, Restricted Project

Jun 2 2020

curdeius added inline comments to D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator.
Jun 2 2020, 3:23 PM · Restricted Project, Restricted Project
curdeius added a comment to D80950: [clang-format] [PR44542,38872] String << String always get a forced newline..

The change seems to me technically sound, but I'm not sure of the scope of its effects. There might be users that rely on this behaviour. On the other hand, adding an option to keep the old behaviour doesn't seem appropriate, and personally I consider the old behaviour as a bug.

Jun 2 2020, 2:50 PM · Restricted Project, Restricted Project
curdeius added inline comments to D80902: [libcxx] adds lexicographical_compare_three_way.
Jun 2 2020, 2:50 PM · Unknown Object (Project)

May 30 2020

curdeius added a comment to D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace.

OK, great. Thanks for all the information.

May 30 2020, 5:16 AM · Restricted Project, Restricted Project
curdeius accepted D77505: [libc++] Implement <numbers>.

LGTM. But you need to wait for a review from somebody from libc++ group.

May 30 2020, 5:16 AM · Unknown Object (Project)

May 29 2020

curdeius accepted D80830: [clang-format] [PR46130] When editing a file with unbalance {} the namespace comment fixer can incorrectly comment the wrong closing brace.

LGTM.
It may be silly, but the fact that this code runs over all the tokens makes me think: do we have any performance-related non-regression tests for clang-format?

May 29 2020, 1:40 PM · Restricted Project, Restricted Project
curdeius accepted D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

LGTM! Thanks!

May 29 2020, 12:33 PM · Restricted Project, Restricted Project
curdeius added inline comments to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 29 2020, 8:07 AM · Restricted Project, Restricted Project
curdeius requested changes to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 29 2020, 8:06 AM · Restricted Project, Restricted Project
curdeius added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

That looks nicer indeed. Thanks.
Just some minor nitty-gritty comments.

May 29 2020, 8:06 AM · Restricted Project, Restricted Project
curdeius added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

@MyDeveloperDay, I've played around with the script, you can take as much as you judge useful from here: https://github.com/mkurdej/llvm-project/tree/arcpatch-D80627.

May 29 2020, 3:13 AM · Restricted Project, Restricted Project
curdeius added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

@MyDeveloperDay , I know it's a strange request, but could you change (or remove) the background color for 100% case.
I'm partially color-blind and having red and green background in the same table is really hard to distinguish. I guess I'm not alone.
I'd suggest using something like light blue, it doesn't need to stand out anyway.

May 29 2020, 2:08 AM · Restricted Project, Restricted Project

May 28 2020

curdeius added inline comments to D77505: [libc++] Implement <numbers>.
May 28 2020, 3:25 PM · Unknown Object (Project)
curdeius requested changes to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

First of all, very nice idea. :)
Second, could you please make sure that the script is compatible with Python 3?
Also, in order to clean up a bit the generation of the RST (to avoid the repetition of all this output.write() stuff), you can use multiline strings """, or in general, take inspiration from e.g. https://github.com/llvm/llvm-project/blob/master/libcxx/utils/generate_feature_test_macro_components.py#L720.
Lastly, it would be nice to add last update date somewhere.

May 28 2020, 2:54 PM · Restricted Project, Restricted Project
curdeius added inline comments to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 28 2020, 9:15 AM · Restricted Project, Restricted Project
curdeius added inline comments to D69764: [clang-format] Add East/West Const fixer capability.
May 28 2020, 8:42 AM · Restricted Project, Restricted Project

May 27 2020

curdeius added a comment to D69764: [clang-format] Add East/West Const fixer capability.

One last thought, how about making the config a bit more future-proof and instead of ConstPlacement accept what was discussed some time ago:

QualifierStyle:
   -   const:     Right

and restrict it to const for the moment?
Maybe renaming to QualifierPlacement or something more appropriate.

May 27 2020, 4:56 PM · Restricted Project, Restricted Project
curdeius added inline comments to D69764: [clang-format] Add East/West Const fixer capability.
May 27 2020, 4:56 PM · Restricted Project, Restricted Project

May 26 2020

curdeius added a comment to D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses.

Minor remarks.

May 26 2020, 5:54 AM · Restricted Project, Restricted Project

May 25 2020

curdeius committed rGd1dbda10cefe: [libc++] [LWG3201] Update status page: lerp should be marked noexcept. (authored by curdeius).
[libc++] [LWG3201] Update status page: lerp should be marked noexcept.
May 25 2020, 1:56 PM
curdeius committed rGbc93c2d72e84: [Transforms] Fix typos. NFC (authored by curdeius).
[Transforms] Fix typos. NFC
May 25 2020, 1:56 PM
curdeius closed D80456: [libc++] [LWG3201] Update status page: lerp should be marked noexcept..
May 25 2020, 1:56 PM · Unknown Object (Project)
curdeius abandoned D80441: [libc++] Turn off formatting of files generated by generate_feature_test_macro_components.py. NFC.

Ok. I'll create another revision with necessary .clang-format (and related) changes.

May 25 2020, 1:56 PM · Unknown Object (Project)

May 23 2020

curdeius committed rG174322c2737d: [libc++] Mark __cpp_lib_hardware_interference_size as unimplemented. This fxes… (authored by curdeius).
[libc++] Mark __cpp_lib_hardware_interference_size as unimplemented. This fxes…
May 23 2020, 5:48 AM
curdeius closed D80431: [libc++] Mark __cpp_lib_hardware_interference_size as unimplemented. This fxes bug PR41423..
May 23 2020, 5:48 AM · Unknown Object (Project)
curdeius added a comment to D80441: [libc++] Turn off formatting of files generated by generate_feature_test_macro_components.py. NFC.

Ok, fair enough. I'll abandon this revision then.
Should we then update .clang-format (at least for the directory where auto-generated tests are) or update the python script so that it matches libc++ style?
For the former, IndentPPDirectives should be set to AfterHash.

May 23 2020, 5:47 AM · Unknown Object (Project)
curdeius retitled D80456: [libc++] [LWG3201] Update status page: lerp should be marked noexcept. from [libc++] [LWG3201] lerp should be marked noexcept. to [libc++] [LWG3201] Update status page: lerp should be marked noexcept..
May 23 2020, 5:47 AM · Unknown Object (Project)
curdeius added a reviewer for D80456: [libc++] [LWG3201] Update status page: lerp should be marked noexcept.: EricWF.
May 23 2020, 5:47 AM · Unknown Object (Project)

May 22 2020

curdeius added a comment to D80456: [libc++] [LWG3201] Update status page: lerp should be marked noexcept..

I have a small doubt. Should <cmath> include lerp in its synopsis? It's currently missing. I can add it in this patch if needed.

May 22 2020, 1:24 PM · Unknown Object (Project)
curdeius created D80456: [libc++] [LWG3201] Update status page: lerp should be marked noexcept..
May 22 2020, 1:24 PM · Unknown Object (Project)
curdeius created D80441: [libc++] Turn off formatting of files generated by generate_feature_test_macro_components.py. NFC.
May 22 2020, 8:01 AM · Unknown Object (Project)
curdeius committed rGeddcce0814f9: [CMake] Fix typos. NFC (authored by curdeius).
[CMake] Fix typos. NFC
May 22 2020, 5:52 AM
curdeius committed rG9301e3aaca59: [Target] Fix typos. NFC (authored by curdeius).
[Target] Fix typos. NFC
May 22 2020, 5:51 AM
Herald added a reviewer for D80431: [libc++] Mark __cpp_lib_hardware_interference_size as unimplemented. This fxes bug PR41423.: jfb.
May 22 2020, 4:45 AM · Unknown Object (Project)
curdeius added a comment to D78427: [libcxx] Add c++20 <numbers>.

I've just realized that there is already D77505. You should probably think about helping to incorporate your changes into this other PR and abandon this one.

May 22 2020, 3:36 AM · Unknown Object (Project)
curdeius planned changes to D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..

Thanks for the review.

May 22 2020, 12:37 AM · Unknown Object (Project)

May 21 2020

curdeius committed rG0c148430cf61: Reland [libc++] [LWG3321] Mark "year_month_day_last::day() specification does… (authored by curdeius).
Reland [libc++] [LWG3321] Mark "year_month_day_last::day() specification does…
May 21 2020, 1:00 PM
curdeius closed D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..
May 21 2020, 1:00 PM · Unknown Object (Project)
curdeius added a comment to D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions.

I like these changes.
I have mixed feelings about isCpp() & co.
As @MyDeveloperDay said, I'd like it mean C++ only. I find it confusing that it means C++ or ObjC (even if the latter is a superset of the former). I'd rather see it spelt as isCppOrObjC() even if it's verbose but at least removes all confusion IMO.

May 21 2020, 6:59 AM · Restricted Project, Restricted Project
curdeius updated the diff for D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
  • Add new header to CMake, double-include test and module map.
May 21 2020, 6:59 AM · Unknown Object (Project)
curdeius created D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20..
May 21 2020, 6:58 AM · Unknown Object (Project)
curdeius updated the diff for D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..
  • Revert "Define _NOEXCEPT to nothing for debug_less tests to avoid throwing in noexcept function."
  • Reorder include.
May 21 2020, 5:22 AM · Unknown Object (Project)
curdeius updated the diff for D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..
  • Rebase on master.
May 21 2020, 5:22 AM · Unknown Object (Project)

May 20 2020

curdeius added a comment to D80309: [clang-format][docfix] Update predefined styles in docs.

Nice!

May 20 2020, 12:02 PM · Restricted Project, Restricted Project

May 15 2020

curdeius committed rG182adf120ccf: [libc++] [span] [P1976] Update status page. NFC (authored by curdeius).
[libc++] [span] [P1976] Update status page. NFC
May 15 2020, 5:53 AM
curdeius added a comment to D74577: [libcxx][span] Implement P1976R2.

I've updated the status page in commit 182adf120ccffe937d95d5b447f6506f82f615ec. I guess it was an oversight.

May 15 2020, 5:53 AM · Unknown Object (Project)
curdeius added inline comments to D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly.
May 15 2020, 5:53 AM · Restricted Project, Restricted Project
curdeius updated the diff for D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..
  • Define _NOEXCEPT to nothing for debug_less tests to avoid throwing in noexcept function.
May 15 2020, 5:53 AM · Unknown Object (Project)
curdeius added a comment to D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..

Well, I redefined _NOEXCEPT to nothing, but there are hacks involved.
First of all, libc++ headers include <__config> that defines _NOEXCEPT unconditionally. So I needed to make it conditional.
Secondly, to make this work I replaced noexcept with _NOEXCEPT on day() method in <chrono>.
And yeah, then I defined _NOEXCEPT to nothing, but it seems to me a dangerous endeavour.

May 15 2020, 5:53 AM · Unknown Object (Project)

May 13 2020

curdeius added a comment to D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..

FYI, there are about 130 occurrences of #define _LIBCPP_ASSERT in tests, but debug_less.pass.cpp is the only place where throw is used (in other cases, exit is called).

May 13 2020, 9:10 AM · Unknown Object (Project)
curdeius added a comment to D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..

Do you know what was the purpose of redefining it?

May 13 2020, 9:10 AM · Unknown Object (Project)
curdeius updated the diff for D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..

Reopen this revision as there was a failure in test/libcxx/algorithms/debug_less.pass.cpp that defined _LIBCPP_ASSERT macro to throw.
The proposed fix includes <chrono> before redefining this macro.

May 13 2020, 5:21 AM · Unknown Object (Project)
curdeius reopened D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..

Reopening revision due to failures in test/libcxx/algorithms/debug_less.pass.cpp.

May 13 2020, 5:21 AM · Unknown Object (Project)
curdeius committed rGab61fe41505c: Revert "[libc++] [LWG3321] Mark "year_month_day_last::day() specification does… (authored by curdeius).
Revert "[libc++] [LWG3321] Mark "year_month_day_last::day() specification does…
May 13 2020, 4:48 AM
curdeius added a reverting change for rGe25a2601aaa9: [libc++] [LWG3321] Mark "year_month_day_last::day() specification does not…: rGab61fe41505c: Revert "[libc++] [LWG3321] Mark "year_month_day_last::day() specification does….
May 13 2020, 4:48 AM
curdeius committed rGe25a2601aaa9: [libc++] [LWG3321] Mark "year_month_day_last::day() specification does not… (authored by curdeius).
[libc++] [LWG3321] Mark "year_month_day_last::day() specification does not…
May 13 2020, 3:12 AM
curdeius closed D70346: [libc++] [LWG3231] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion..
May 13 2020, 3:11 AM · Unknown Object (Project)

May 7 2020

curdeius planned changes to D79555: [libc++] [P0415] [C++20] - Constexpr for std::complex..
May 7 2020, 4:19 PM · Unknown Object (Project)
curdeius added a comment to D79555: [libc++] [P0415] [C++20] - Constexpr for std::complex..

@ldionne, I'd appreciate if you (or somebody else) could tell me what you think about the way I test the constexpr. I wanted to avoid duplication but on a second thought, I think that run-time tests can actually go through compile-time (constexpr) branch and so leave the non-constexpr branch untested.
Another thing in which I'd need guidance is how to test the primary implementation (not specializations for float, double, long double). Is there another floating-point type I can use in tests? Maybe some sort of short float?
Oh, and should integral types be tested with complex<T>?

May 7 2020, 10:47 AM · Restricted Project