Page MenuHomePhabricator
People curdeius

curdeius (Marek Kurdej)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2013, 1:59 AM (503 w, 2 d)

Recent Activity
View All

Nov 3 2022

curdeius added inline comments to D137338: Fix dupe word typos.
Nov 3 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

curdeius added inline comments to D124516: [libc++] Implement `std::expected` P0323R12.
Oct 21 2022, 1:31 PM · Restricted Project, Restricted Project

Sep 9 2022

curdeius added inline comments to D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays.
Sep 9 2022, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine.

LGTM after fixing the last comment.

Sep 9 2022, 1:25 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine.
Sep 9 2022, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine.
Sep 9 2022, 5:55 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2022

curdeius added reviewers for D133236: [clang-format] Use utf-8 for JSON object load: owenpan, HazardyKnusperkeks, curdeius.
Sep 5 2022, 3:03 AM · Restricted Project, Restricted Project, Restricted Project
curdeius retitled D133236: [clang-format] Use utf-8 for JSON object load from [Clang][Tools] Use utf-8 for JSON object load to [clang-format] Use utf-8 for JSON object load.
Sep 5 2022, 3:02 AM · Restricted Project, Restricted Project, Restricted Project
curdeius retitled D133087: [clang-format] [doc] Fix example of wrapping class definitions from [clang-format][NFC][Docs] fix wrong example of warping class definitions to [clang-format] [doc] Fix example of wrapping class definitions.
Sep 5 2022, 1:42 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D132762: [clang-format] Allow `throw` to be a keyword in front of casts.

@rymiel, please provide your name and email address for the commit message, so that we can land it for you.

Sep 5 2022, 12:42 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D132295: [clang-format] Change heuristic for locating lambda template arguments.

@rymiel, please provide your name and email address for the commit message, so that we can land it for you.

Sep 5 2022, 12:38 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D132189: [clang-format] Don't put `noexcept` on empty line following constructor.

@rymiel, please provide your name and email address for the commit message, so that we can land it for you.

Sep 5 2022, 12:36 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D126365: [git-clang-format] Stop ignoring changes for files with space in path.

@Eitot, please provide your name and email address for the commit message.

Sep 5 2022, 12:33 AM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D126365: [git-clang-format] Stop ignoring changes for files with space in path.
Sep 5 2022, 12:32 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D131978: [clang-format] Concepts: allow identifiers after negation.

@rymiel, please provide your name and email address for the commit message, so that we can land it for you.

Sep 5 2022, 12:32 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D129926: [clang-format] Handle constructor invocations after new operator in C# correct.

@eoanermine, please provide your name and email address for the commit message.

Sep 5 2022, 12:28 AM · Restricted Project, Restricted Project, Restricted Project

Jul 23 2022

curdeius accepted D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas.
Jul 23 2022, 9:41 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D130417: [clang-format] Missing space between trailing return type 'auto' and left brace.
Jul 23 2022, 9:39 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D130411: [clang-format] Fix a hang when formatting C# $@ string literals.
Jul 23 2022, 9:37 PM · Restricted Project, Restricted Project, Restricted Project

Jul 21 2022

curdeius added a comment to D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas.

Could you please add full git context?
Was the problem due to misannotation of auto? If so, could you add an annotator test?

Jul 21 2022, 2:50 PM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D130299: [clang-format] FIX: Misannotation 'auto' as trailing return type in lambdas.
Jul 21 2022, 2:45 PM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2022

curdeius accepted D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest.
Jul 20 2022, 2:18 PM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

curdeius accepted D130136: [clang-format] Indent tokens after hash only if it starts a line.

LGTM.

Jul 19 2022, 10:07 PM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2022

curdeius accepted D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest.
Jul 18 2022, 12:18 AM · Restricted Project, Restricted Project, Restricted Project

Jul 17 2022

curdeius added inline comments to D129940: [clang-format] Fix misannotation of colon in presence of requires clause.
Jul 17 2022, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129934: [clang-format][docs] Fix incorrect 'clang-format 4' option markers.
Jul 17 2022, 2:45 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129926: [clang-format] Handle constructor invocations after new operator in C# correct.

LGTM.

Jul 17 2022, 1:00 AM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D129926: [clang-format] Handle constructor invocations after new operator in C# correct.
Jul 17 2022, 12:56 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129940: [clang-format] Fix misannotation of colon in presence of requires clause.

Ok for me if it's OK for Owen.

Jul 17 2022, 12:54 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129942: [clang-format] Indent TT_CtorInitializerColon after requires clauses.
Jul 17 2022, 12:51 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129946: [clang-format] Mark constexpr lambdas as lambda.
Jul 17 2022, 12:50 AM · Restricted Project, Restricted Project, Restricted Project

Jul 16 2022

curdeius accepted D129921: [clang-format] Never remove braces in macro definitions.

Nice finding! LGTM

Jul 16 2022, 1:38 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2022

curdeius added inline comments to D129845: [clang-format] Allow custom attributes in access specifiers.
Jul 15 2022, 5:47 AM · Restricted Project, Restricted Project, Restricted Project
curdeius retitled D129845: [clang-format] Allow custom attributes in access specifiers from Allow custom attributes in access specifiers to [clang-format] Allow custom attributes in access specifiers.
Jul 15 2022, 5:46 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D129845: [clang-format] Allow custom attributes in access specifiers.
Jul 15 2022, 5:42 AM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D129845: [clang-format] Allow custom attributes in access specifiers.
Jul 15 2022, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D129466: [clang-format][NFC] Replace most of std::vector with SmallVector.
Jul 15 2022, 2:09 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2022

curdeius accepted D129742: [clang-format] Fix invalid-code-generation by RemoveBracesLLVM.
Jul 14 2022, 8:34 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129771: [clang-format] distinguish multiplication after brace-init from pointer.
Jul 14 2022, 8:31 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127270: [clang-format] Add space in placement new expression.
Jul 14 2022, 8:29 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D129466: [clang-format][NFC] Replace most of std::vector with SmallVector.
Jul 14 2022, 3:18 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2022

curdeius accepted D129563: [docs] Document git-clang-format.
In D129563#3645343, @thakis wrote:

(does anyone know why git-clang-format isn't implemented in terms of clang-format-diff.py? I suppose it's easier to use if it's standalone?)

Jul 13 2022, 10:29 AM · Restricted Project, Restricted Project
curdeius accepted D129628: [clang-format] Fix aligning of java-style declarations.
Jul 13 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2022

curdeius requested changes to D129443: [clang-format] Add option for aligning requires clause body.

Haven't you forgotten to add formatting tests? :)

Jul 10 2022, 10:15 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D129443: [clang-format] Add option for aligning requires clause body: Restricted Project, MyDeveloperDay, owenpan, HazardyKnusperkeks, curdeius.
Jul 10 2022, 10:13 PM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2022

curdeius accepted D129348: [clang-format] Fix an assertion failure on -lines=0:n.

👍

Jul 8 2022, 12:20 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

curdeius accepted D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker.
Jul 7 2022, 1:37 AM · Restricted Project, Restricted Project, Restricted Project
curdeius committed rG14c30c70c459: [clang-format] Avoid crash in LevelIndentTracker. (authored by curdeius).
[clang-format] Avoid crash in LevelIndentTracker.
Jul 7 2022, 1:16 AM · Restricted Project, Restricted Project
curdeius closed D129064: [clang-format] Avoid crash in LevelIndentTracker..
Jul 7 2022, 1:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2022

curdeius updated the diff for D129064: [clang-format] Avoid crash in LevelIndentTracker..

Address comments.

Jul 6 2022, 2:32 AM · Restricted Project, Restricted Project, Restricted Project

Jul 4 2022

curdeius added a project to D129064: [clang-format] Avoid crash in LevelIndentTracker.: Restricted Project.
Jul 4 2022, 2:35 AM · Restricted Project, Restricted Project, Restricted Project
curdeius requested review of D129064: [clang-format] Avoid crash in LevelIndentTracker..
Jul 4 2022, 2:34 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129057: [clang-format] Break on AfterColon only if not followed by comment.

LGTM. Thanks for addressing my comments.

Jul 4 2022, 12:55 AM · Restricted Project, Restricted Project, Restricted Project

Jul 3 2022

curdeius added inline comments to D129057: [clang-format] Break on AfterColon only if not followed by comment.
Jul 3 2022, 10:20 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D129057: [clang-format] Break on AfterColon only if not followed by comment.
Jul 3 2022, 10:19 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129050: [clang-format] Update documentation.
Jul 3 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D128984: [clang-format] Tweak help text a bit.
Jul 3 2022, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2022

curdeius accepted D128574: [clang-format] Quit analyzing solution space for large state count.
Jun 26 2022, 1:03 PM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2022

curdeius accepted D128496: [clang-format] Further improve requires clause detection.

LGTM with Owen's suggestion.

Jun 24 2022, 1:16 AM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2022

curdeius updated the summary of D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Jun 21 2022, 9:57 PM · Restricted Project, Restricted Project, Restricted Project

Jun 16 2022

curdeius added inline comments to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Jun 16 2022, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
curdeius retitled D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct from [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct to [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct.
Jun 16 2022, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2022

curdeius accepted D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp.
Jun 15 2022, 5:11 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2022

curdeius added a comment to D127270: [clang-format] Add space in placement new expression.

Does this patch really fix https://github.com/llvm/llvm-project/issues/54703?
If so, please add test for it. Otherwise remove the link from the summary (and if possible handle it in another review).

Jun 14 2022, 11:10 PM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D127270: [clang-format] Add space in placement new expression.
Jun 14 2022, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127685: [clang-format] Never analyze insert/remove braces in the same pass.
Jun 14 2022, 10:27 PM · Restricted Project, Restricted Project, Restricted Project

Jun 13 2022

curdeius accepted D127614: [clang-format] Handle more cases for RemoveBracesLLVM.
Jun 13 2022, 1:11 AM · Restricted Project, Restricted Project, Restricted Project

Jun 10 2022

curdeius added a comment to D127484: [clang-format] Use tabs on GNU style.

It seems like a breaking change that may be painful for users of GNU style. @MyDeveloperDay, wdyt?

Jun 10 2022, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D127484: [clang-format] Use tabs on GNU style: curdeius, MyDeveloperDay, owenpan, HazardyKnusperkeks.
Jun 10 2022, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127532: [clang-format] Fix a bug in RemoveBracesLLVM.
Jun 10 2022, 2:54 PM · Restricted Project, Restricted Project, Restricted Project

Jun 9 2022

curdeius accepted D127390: [clang-format][NFC] Remove unused FormatStyle members.

Good finding!

Jun 9 2022, 4:21 AM · Restricted Project, Restricted Project, Restricted Project

Jun 8 2022

curdeius accepted D127366: [clang-format][NFC] Format lib/Format and unittests/Format in clang.

LGTM.

Jun 8 2022, 11:36 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127260: [clang-format] Remove braces of else blocks that embody an if block.

Still looks good. Was there a particular case where the previous version didn't work?

Jun 8 2022, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D126365: [git-clang-format] Stop ignoring changes for files with space in path.

@Eitot, do you need help landing this?

Jun 8 2022, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2022

curdeius accepted D127260: [clang-format] Remove braces of else blocks that embody an if block.

LGTM. Thanks!

Jun 7 2022, 11:45 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D127270: [clang-format] Add space in placement new expression.

Apart from some missing tests, looks promising!

Jun 7 2022, 11:21 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D127270: [clang-format] Add space in placement new expression: curdeius, owenpan, HazardyKnusperkeks.
Jun 7 2022, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D127260: [clang-format] Remove braces of else blocks that embody an if block.
Jun 7 2022, 11:17 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127183: [clang-format] Skip parsing a block if it's nested too deep.
Jun 7 2022, 4:12 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2022

curdeius accepted D127054: [clang-format] Handle attributes for for/while loops.

Great!

Jun 5 2022, 12:20 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

curdeius accepted D126365: [git-clang-format] Stop ignoring changes for files with space in path.

Ok, I'm not blocking this patch. I'll take a look to see whether we can add some tests.

Jun 1 2022, 6:05 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM.
Jun 1 2022, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2022

curdeius committed rG8f70d16c9ab2: [clang-format] Handle attributes in enum declaration. (authored by tchatow).
[clang-format] Handle attributes in enum declaration.
May 26 2022, 6:44 AM · Restricted Project, Restricted Project
curdeius closed D125848: [clang-format] Handle attributes in enum declaration..
May 26 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
curdeius committed rGd4d28f2ace76: [clang-format] Fix QualifierAlignment with global namespace qualified types. (authored by curdeius).
[clang-format] Fix QualifierAlignment with global namespace qualified types.
May 26 2022, 6:02 AM · Restricted Project, Restricted Project
curdeius closed D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types..
May 26 2022, 6:02 AM · Restricted Project, Restricted Project

May 25 2022

curdeius accepted D126438: [clang-format] Fix an invalid code generation in RemoveBracesLLVM.

LGTM. Good catch for this bug!

May 25 2022, 11:03 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D125848: [clang-format] Handle attributes in enum declaration..

LGTM. Thanks a lot!
Do you have commit rights or need some help landing this?

May 25 2022, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock().

LGTM.

May 25 2022, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock().
May 25 2022, 4:11 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a reviewer for D126365: [git-clang-format] Stop ignoring changes for files with space in path: curdeius.
May 25 2022, 4:06 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D126365: [git-clang-format] Stop ignoring changes for files with space in path.

Would it be possible to add a test please?

May 25 2022, 4:06 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D126365: [git-clang-format] Stop ignoring changes for files with space in path: MyDeveloperDay, owenpan, HazardyKnusperkeks.
May 25 2022, 4:05 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

curdeius added inline comments to D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/.
May 23 2022, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D125848: [clang-format] Handle attributes in enum declaration..

Could you please add test cases with non-empty enums both with and without comments please like in the bug report?

May 23 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
curdeius closed D126132: [clang-format] Fix a crash on lambda trailing return type.

Closing as it landed in https://github.com/llvm/llvm-project/commit/130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba.

May 23 2022, 9:02 AM · Restricted Project, Restricted Project, Restricted Project

May 22 2022

curdeius accepted D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/.

Ok. So we mainly missed braces on complex conditionals. LGTM.

May 22 2022, 2:08 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126132: [clang-format] Fix a crash on lambda trailing return type.

LGTM. It seems it has landed already.

May 22 2022, 12:16 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2022

curdeius accepted D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine".
May 21 2022, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

curdeius added a comment to D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types..

If you can think of other cases that may misbehave, I'll be happy to test (and fix) these.

May 20 2022, 3:31 PM · Restricted Project, Restricted Project