User Details
- User Since
- Jul 29 2013, 1:59 AM (503 w, 2 d)
Nov 3 2022
Oct 21 2022
Sep 9 2022
LGTM after fixing the last comment.
Sep 5 2022
@rymiel, please provide your name and email address for the commit message, so that we can land it for you.
@rymiel, please provide your name and email address for the commit message, so that we can land it for you.
@rymiel, please provide your name and email address for the commit message, so that we can land it for you.
@Eitot, please provide your name and email address for the commit message.
@rymiel, please provide your name and email address for the commit message, so that we can land it for you.
@eoanermine, please provide your name and email address for the commit message.
Jul 23 2022
Jul 21 2022
Could you please add full git context?
Was the problem due to misannotation of auto? If so, could you add an annotator test?
Jul 20 2022
Jul 19 2022
LGTM.
Jul 18 2022
Jul 17 2022
LGTM.
Ok for me if it's OK for Owen.
Jul 16 2022
Nice finding! LGTM
Jul 15 2022
Jul 14 2022
Jul 13 2022
Jul 10 2022
Haven't you forgotten to add formatting tests? :)
Jul 8 2022
👍
Jul 7 2022
Jul 6 2022
Address comments.
Jul 4 2022
LGTM. Thanks for addressing my comments.
Jul 3 2022
Jun 26 2022
Jun 24 2022
LGTM with Owen's suggestion.
Jun 21 2022
Jun 16 2022
Jun 15 2022
Jun 14 2022
Does this patch really fix https://github.com/llvm/llvm-project/issues/54703?
If so, please add test for it. Otherwise remove the link from the summary (and if possible handle it in another review).
Jun 13 2022
Jun 10 2022
It seems like a breaking change that may be painful for users of GNU style. @MyDeveloperDay, wdyt?
Jun 9 2022
Good finding!
Jun 8 2022
LGTM.
Still looks good. Was there a particular case where the previous version didn't work?
@Eitot, do you need help landing this?
Jun 7 2022
LGTM. Thanks!
Apart from some missing tests, looks promising!
Jun 5 2022
Great!
Jun 1 2022
Ok, I'm not blocking this patch. I'll take a look to see whether we can add some tests.
May 26 2022
May 25 2022
LGTM. Good catch for this bug!
LGTM. Thanks a lot!
Do you have commit rights or need some help landing this?
LGTM.
Would it be possible to add a test please?
May 23 2022
Could you please add test cases with non-empty enums both with and without comments please like in the bug report?
Closing as it landed in https://github.com/llvm/llvm-project/commit/130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba.
May 22 2022
Ok. So we mainly missed braces on complex conditionals. LGTM.
LGTM. It seems it has landed already.
May 21 2022
May 20 2022
If you can think of other cases that may misbehave, I'll be happy to test (and fix) these.