Page MenuHomePhabricator

curdeius (Marek Kurdej)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2013, 1:59 AM (466 w, 2 d)

Recent Activity

Today

curdeius updated the diff for D129064: [clang-format] Avoid crash in LevelIndentTracker..

Address comments.

Wed, Jul 6, 2:32 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 4

curdeius added a project to D129064: [clang-format] Avoid crash in LevelIndentTracker.: Restricted Project.
Mon, Jul 4, 2:35 AM · Restricted Project, Restricted Project, Restricted Project
curdeius requested review of D129064: [clang-format] Avoid crash in LevelIndentTracker..
Mon, Jul 4, 2:34 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129057: [clang-format] Break on AfterColon only if not followed by comment.

LGTM. Thanks for addressing my comments.

Mon, Jul 4, 12:55 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jul 3

curdeius added inline comments to D129057: [clang-format] Break on AfterColon only if not followed by comment.
Sun, Jul 3, 10:20 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D129057: [clang-format] Break on AfterColon only if not followed by comment.
Sun, Jul 3, 10:19 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D129050: [clang-format] Update documentation.
Sun, Jul 3, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D128984: [clang-format] Tweak help text a bit.
Sun, Jul 3, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 26

curdeius accepted D128574: [clang-format] Quit analyzing solution space for large state count.
Sun, Jun 26, 1:03 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

curdeius accepted D128496: [clang-format] Further improve requires clause detection.

LGTM with Owen's suggestion.

Fri, Jun 24, 1:16 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

curdeius updated the summary of D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Tue, Jun 21, 9:57 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 16

curdeius added inline comments to D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct.
Thu, Jun 16, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
curdeius retitled D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct from [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct to [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct.
Thu, Jun 16, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 15

curdeius accepted D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp.
Wed, Jun 15, 5:11 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

curdeius added a comment to D127270: [clang-format] Add space in placement new expression.

Does this patch really fix https://github.com/llvm/llvm-project/issues/54703?
If so, please add test for it. Otherwise remove the link from the summary (and if possible handle it in another review).

Tue, Jun 14, 11:10 PM · Restricted Project, Restricted Project, Restricted Project
curdeius updated the summary of D127270: [clang-format] Add space in placement new expression.
Tue, Jun 14, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127685: [clang-format] Never analyze insert/remove braces in the same pass.
Tue, Jun 14, 10:27 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

curdeius accepted D127614: [clang-format] Handle more cases for RemoveBracesLLVM.
Mon, Jun 13, 1:11 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 10

curdeius added a comment to D127484: [clang-format] Use tabs on GNU style.

It seems like a breaking change that may be painful for users of GNU style. @MyDeveloperDay, wdyt?

Fri, Jun 10, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D127484: [clang-format] Use tabs on GNU style: curdeius, MyDeveloperDay, owenpan, HazardyKnusperkeks.
Fri, Jun 10, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127532: [clang-format] Fix a bug in RemoveBracesLLVM.
Fri, Jun 10, 2:54 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 9

curdeius accepted D127390: [clang-format][NFC] Remove unused FormatStyle members.

Good finding!

Thu, Jun 9, 4:21 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 8

curdeius accepted D127366: [clang-format][NFC] Format lib/Format and unittests/Format in clang.

LGTM.

Wed, Jun 8, 11:36 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127260: [clang-format] Remove braces of else blocks that embody an if block.

Still looks good. Was there a particular case where the previous version didn't work?

Wed, Jun 8, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D126365: [git-clang-format] Stop ignoring changes for files with space in path.

@Eitot, do you need help landing this?

Wed, Jun 8, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 7

curdeius accepted D127260: [clang-format] Remove braces of else blocks that embody an if block.

LGTM. Thanks!

Tue, Jun 7, 11:45 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D127270: [clang-format] Add space in placement new expression.

Apart from some missing tests, looks promising!

Tue, Jun 7, 11:21 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D127270: [clang-format] Add space in placement new expression: curdeius, owenpan, HazardyKnusperkeks.
Tue, Jun 7, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D127260: [clang-format] Remove braces of else blocks that embody an if block.
Tue, Jun 7, 11:17 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D127183: [clang-format] Skip parsing a block if it's nested too deep.
Tue, Jun 7, 4:12 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2022

curdeius accepted D127054: [clang-format] Handle attributes for for/while loops.

Great!

Jun 5 2022, 12:20 AM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

curdeius accepted D126365: [git-clang-format] Stop ignoring changes for files with space in path.

Ok, I'm not blocking this patch. I'll take a look to see whether we can add some tests.

Jun 1 2022, 6:05 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126758: [clang-format] Handle do-while loops for RemoveBracesLLVM.
Jun 1 2022, 3:26 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2022

curdeius committed rG8f70d16c9ab2: [clang-format] Handle attributes in enum declaration. (authored by tchatow).
[clang-format] Handle attributes in enum declaration.
May 26 2022, 6:44 AM · Restricted Project, Restricted Project
curdeius closed D125848: [clang-format] Handle attributes in enum declaration..
May 26 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
curdeius committed rGd4d28f2ace76: [clang-format] Fix QualifierAlignment with global namespace qualified types. (authored by curdeius).
[clang-format] Fix QualifierAlignment with global namespace qualified types.
May 26 2022, 6:02 AM · Restricted Project, Restricted Project
curdeius closed D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types..
May 26 2022, 6:02 AM · Restricted Project, Restricted Project

May 25 2022

curdeius accepted D126438: [clang-format] Fix an invalid code generation in RemoveBracesLLVM.

LGTM. Good catch for this bug!

May 25 2022, 11:03 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D125848: [clang-format] Handle attributes in enum declaration..

LGTM. Thanks a lot!
Do you have commit rights or need some help landing this?

May 25 2022, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock().

LGTM.

May 25 2022, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock().
May 25 2022, 4:11 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a reviewer for D126365: [git-clang-format] Stop ignoring changes for files with space in path: curdeius.
May 25 2022, 4:06 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D126365: [git-clang-format] Stop ignoring changes for files with space in path.

Would it be possible to add a test please?

May 25 2022, 4:06 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D126365: [git-clang-format] Stop ignoring changes for files with space in path: MyDeveloperDay, owenpan, HazardyKnusperkeks.
May 25 2022, 4:05 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

curdeius added inline comments to D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/.
May 23 2022, 2:37 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D125848: [clang-format] Handle attributes in enum declaration..

Could you please add test cases with non-empty enums both with and without comments please like in the bug report?

May 23 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
curdeius closed D126132: [clang-format] Fix a crash on lambda trailing return type.

Closing as it landed in https://github.com/llvm/llvm-project/commit/130a9cc0a5e25e3be8ff3738518e86ae3ae0b5ba.

May 23 2022, 9:02 AM · Restricted Project, Restricted Project, Restricted Project

May 22 2022

curdeius accepted D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/.

Ok. So we mainly missed braces on complex conditionals. LGTM.

May 22 2022, 2:08 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126132: [clang-format] Fix a crash on lambda trailing return type.

LGTM. It seems it has landed already.

May 22 2022, 12:16 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2022

curdeius accepted D125959: [clang-format] Fix a bug in "AfterControlStatement: MultiLine".
May 21 2022, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

curdeius added a comment to D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types..

If you can think of other cases that may misbehave, I'll be happy to test (and fix) these.

May 20 2022, 3:31 PM · Restricted Project, Restricted Project
curdeius requested review of D126096: [clang-format] Fix QualifierAlignment with global namespace qualified types..
May 20 2022, 3:29 PM · Restricted Project, Restricted Project
curdeius accepted D125961: [clang-format] Don't break lines after pragma region.

Thanks! LGTM.

May 20 2022, 6:20 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D125961: [clang-format] Don't break lines after pragma region.

Thanks for the patch!
Could you please add a unit test in unittest/Format/FormatTest.cpp instead of in lit-based test/?
Is there a bug report that your patch fixes?

Sure - I didn't know clang-format used unittests instead.

May 20 2022, 5:10 AM · Restricted Project, Restricted Project, Restricted Project
curdeius requested changes to D125961: [clang-format] Don't break lines after pragma region.

Thanks for the patch!
Could you please add a unit test in unittest/Format/FormatTest.cpp instead of in lit-based test/?
Is there a bug report that your patch fixes?

May 20 2022, 4:59 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added reviewers for D125961: [clang-format] Don't break lines after pragma region: MyDeveloperDay, owenpan, HazardyKnusperkeks, curdeius.
May 20 2022, 4:54 AM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D126052: [clang-format] Handle "complex" conditionals in RemoveBracesLLVM.

LGTM

May 20 2022, 4:25 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2022

curdeius reopened D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

Reverted for now.

May 17 2022, 10:28 PM · Restricted Project, Restricted Project
curdeius added a reverting change for rG50cd52d93572: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro…: rG573a5b58001d: Revert "[clang-format] Fix WhitespaceSensitiveMacros not being honoured when….
May 17 2022, 10:28 PM · Restricted Project, Restricted Project
curdeius committed rG573a5b58001d: Revert "[clang-format] Fix WhitespaceSensitiveMacros not being honoured when… (authored by curdeius).
Revert "[clang-format] Fix WhitespaceSensitiveMacros not being honoured when…
May 17 2022, 10:28 PM · Restricted Project, Restricted Project
curdeius added a reverting change for D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.: rG573a5b58001d: Revert "[clang-format] Fix WhitespaceSensitiveMacros not being honoured when….
May 17 2022, 10:28 PM · Restricted Project, Restricted Project

May 16 2022

curdeius added a comment to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

It looks like this regressed the following example by adding an unwanted level of indentation to the #elif B branch:

Sure, I'll have a look.
It seems that even this:

MACRO_BEGIN
#if A
int f();
#else
int f();
#endif

gets misindented:

MACRO_BEGIN
#if A
int f();
#else
    int
    f();
#endif
May 16 2022, 1:01 PM · Restricted Project, Restricted Project
curdeius committed rGe57f57841fbb: [clang-format] fix alignment w/o binpacked args (authored by cha5on).
[clang-format] fix alignment w/o binpacked args
May 16 2022, 1:25 AM · Restricted Project, Restricted Project
curdeius closed D125162: [clang-format] fix alignment w/o binpacked args.
May 16 2022, 1:25 AM · Restricted Project, Restricted Project, Restricted Project
curdeius committed rGe20bc892b6fa: [clang-format] Fix PointerAlignment: Right not working with tab indentation. (authored by curdeius).
[clang-format] Fix PointerAlignment: Right not working with tab indentation.
May 16 2022, 12:42 AM · Restricted Project, Restricted Project
curdeius closed D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation..
May 16 2022, 12:42 AM · Restricted Project, Restricted Project

May 15 2022

curdeius accepted D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily.

LGTM. I like it! Thanks!

May 15 2022, 6:27 AM · Restricted Project, Restricted Project, Restricted Project

May 13 2022

curdeius accepted D125593: [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM.

LGTM. Good finding!

May 13 2022, 10:46 PM · Restricted Project, Restricted Project, Restricted Project
curdeius added inline comments to D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation..
May 13 2022, 1:21 PM · Restricted Project, Restricted Project
curdeius updated the summary of D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation..
May 13 2022, 2:42 AM · Restricted Project, Restricted Project
curdeius requested review of D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation..
May 13 2022, 2:41 AM · Restricted Project, Restricted Project

May 12 2022

curdeius accepted D125510: [clang-format][NFC] Format unit tests with insert/remove braces.
May 12 2022, 11:07 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D125162: [clang-format] fix alignment w/o binpacked args.

LGTM. Tell us if you need help landing this.
Thanks a lot for your contribution!

May 12 2022, 11:03 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D125451: [clang-format] Handle comments below r_brace in RemoveBracesLLVM.
May 12 2022, 4:46 AM · Restricted Project, Restricted Project, Restricted Project

May 11 2022

curdeius added inline comments to D125137: [clang-format] Don't remove braces if a 1-statement body would wrap.
May 11 2022, 1:16 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D125137: [clang-format] Don't remove braces if a 1-statement body would wrap.

LGTM with nits.

May 11 2022, 12:35 PM · Restricted Project, Restricted Project, Restricted Project
curdeius committed rGdab5e10ea5db: [clang-format] fix nested angle brackets parse inside concept definition (authored by predelnik).
[clang-format] fix nested angle brackets parse inside concept definition
May 11 2022, 5:03 AM · Restricted Project, Restricted Project
curdeius closed D123896: [clang-format] fix nested angle brackets parse inside concept definition.
May 11 2022, 5:03 AM · Restricted Project, Restricted Project
curdeius updated the summary of D123896: [clang-format] fix nested angle brackets parse inside concept definition.
May 11 2022, 2:57 AM · Restricted Project, Restricted Project
curdeius added a comment to D123896: [clang-format] fix nested angle brackets parse inside concept definition.

Do you need help landing this?

May 11 2022, 2:55 AM · Restricted Project, Restricted Project

May 10 2022

curdeius requested changes to D125162: [clang-format] fix alignment w/o binpacked args.
May 10 2022, 12:37 AM · Restricted Project, Restricted Project, Restricted Project
curdeius added a comment to D125162: [clang-format] fix alignment w/o binpacked args.

Thanks for creating the bug report. A few more comments.

May 10 2022, 12:37 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

curdeius committed rG85ec8a9ac141: [clang-format] Correctly handle SpaceBeforeParens for builtins. (authored by curdeius).
[clang-format] Correctly handle SpaceBeforeParens for builtins.
May 9 2022, 2:43 AM · Restricted Project, Restricted Project
curdeius closed D125085: [clang-format] Correctly handle SpaceBeforeParens for builtins..
May 9 2022, 2:42 AM · Restricted Project, Restricted Project
curdeius updated the diff for D125085: [clang-format] Correctly handle SpaceBeforeParens for builtins..

Address comment: simplify.

May 9 2022, 2:04 AM · Restricted Project, Restricted Project
curdeius committed rG50cd52d93572: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro… (authored by curdeius).
[clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro…
May 9 2022, 2:00 AM · Restricted Project, Restricted Project
curdeius closed D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..
May 9 2022, 1:59 AM · Restricted Project, Restricted Project

May 7 2022

curdeius added a comment to D125162: [clang-format] fix alignment w/o binpacked args.

FYI, I like to have a bug report because people that encounter the same problem (in an older release) can find it easily, and see if/when it was fixed. It also avoid working on the same thing by different people.

May 7 2022, 4:52 AM · Restricted Project, Restricted Project, Restricted Project
curdeius requested changes to D125162: [clang-format] fix alignment w/o binpacked args.

Thanks for working on this!
Is there a bug report somewhere? If not, may you create one please?

May 7 2022, 4:49 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

curdeius requested review of D125085: [clang-format] Correctly handle SpaceBeforeParens for builtins..
May 6 2022, 2:30 AM · Restricted Project, Restricted Project
curdeius added inline comments to D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..
May 6 2022, 1:58 AM · Restricted Project, Restricted Project
curdeius updated the diff for D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline..

Simplify. Address comments.

May 6 2022, 1:56 AM · Restricted Project, Restricted Project

May 5 2022

curdeius accepted D125064: [clang-format][NFC] Make all TokenAnnotator member functions const.

LGTM

May 5 2022, 10:24 PM · Restricted Project, Restricted Project, Restricted Project

May 4 2022

curdeius added a comment to D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments.

Just one last thought, shouldn't we have a test case close to what was reported in the issue? I.e. with PP directives.

May 4 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments.

LGTM!

May 4 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2022

curdeius accepted D124868: [clang-format] Fix a bug in AlignConsecutiveAssignments.

Looks ok, but please let someone else have a look too.

May 3 2022, 12:46 PM · Restricted Project, Restricted Project, Restricted Project
curdeius committed rGc819dce2d304: [clang-format] Add a regression test for aligning macros with keywords. (authored by curdeius).
[clang-format] Add a regression test for aligning macros with keywords.
May 3 2022, 2:10 AM · Restricted Project, Restricted Project

May 2 2022

curdeius accepted D124818: [clang-format][NFC] Clean up tryToParseLambdaIntroducer().

LGTM.

May 2 2022, 10:23 PM · Restricted Project, Restricted Project, Restricted Project
curdeius accepted D124589: [clang-format] Fix a bug that misformats Access Specifier after *[].
May 2 2022, 1:26 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

curdeius added a comment to D116527: [clang-format] Fix indentation for array variables with alignment of consecutive assignments and declarations..

Feel free to revert and add a regression test please. I'll take a look.

Apr 28 2022, 2:28 AM · Restricted Project, Restricted Project