Page MenuHomePhabricator

curdeius (Marek Kurdej)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2013, 1:59 AM (316 w, 1 d)

Recent Activity

Dec 18 2018

curdeius added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

LGTM.
Any ideas for improvement, @JonasToth?
I'd rather have it merged and improve on it later if there are ideas on how to do it better.

Dec 18 2018, 1:42 AM · Restricted Project

Dec 14 2018

curdeius added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 14 2018, 12:49 AM · Restricted Project

Dec 11 2018

curdeius added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 11 2018, 2:40 AM · Restricted Project
curdeius added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

A few more ideas for enhancements.

Dec 11 2018, 1:01 AM · Restricted Project

Dec 10 2018

curdeius accepted D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

LGTM. But I'm not a code owner here and I don't know if you need an acceptance of one of them.
Great job.

Dec 10 2018, 8:57 AM · Restricted Project
curdeius requested changes to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 10 2018, 8:36 AM · Restricted Project
curdeius added a comment to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Some more minor remarks. I'll give this check a try to see how it behaves on some of my projects.
I agree that a high rate of false positives is possible (and is a bit of spoiler) but I wouldn't reject this IMO useful check because of that.
Anyway, everything looks pretty clean for me.

Dec 10 2018, 7:00 AM · Restricted Project
curdeius requested changes to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.

Just a few minor remarks and a possible workaround for testing CHECK-FIXES: [[nodiscard]].

Dec 10 2018, 1:29 AM · Restricted Project

Oct 19 2018

curdeius updated the diff for D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

Fixed diff.

Oct 19 2018, 12:21 AM

Oct 18 2018

curdeius updated the diff for D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

Applied changes as per comments.

Oct 18 2018, 9:11 AM
curdeius added a comment to D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

Actually, I can make it an option for this check to skip or not constexpr ifs, WDYT?

Oct 18 2018, 2:02 AM
curdeius added a comment to D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..

I think it would be good to add some more explanation as to *why* that else has to be kept.

Oct 18 2018, 2:01 AM

Oct 17 2018

curdeius created D53372: [clang-tidy] Resolve readability-else-after-return false positive for constexpr if..
Oct 17 2018, 6:28 AM

Sep 28 2017

curdeius created D38357: [Support/Regex] Handle tabulators and escaped chars in square brackets..
Sep 28 2017, 7:10 AM

Sep 27 2017

curdeius closed D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..
Sep 27 2017, 12:53 AM

Sep 26 2017

curdeius accepted D35743: [clang-format] Adjust space around &/&& of structured bindings.

Thanks for the changes. LGTM.

Sep 26 2017, 3:30 PM · Restricted Project
curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

Any thoughts on this?

Sep 26 2017, 3:30 PM

Sep 21 2017

curdeius added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

Could you add just one more test for PAS_Middle please? A single line will be just enough.
Otherwise, LGTM.

Sep 21 2017, 4:25 AM · Restricted Project

Sep 20 2017

curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

That's precisely what I've written, but, as I'd said before, such tests pass already without any modification in NamespaceEndCommentsFixer.

Sep 20 2017, 8:16 AM
curdeius abandoned D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman..

This was fixed by https://reviews.llvm.org/rL312904 and other commits.

Sep 20 2017, 5:44 AM

Sep 19 2017

curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

I confirm what I observed before: when invoking tests in unittests/Format/NamespaceEndCommentsFixerTest.cpp, the const AnnotatedLine *line parameter in getNamespaceToken gets one big line that includes both namespace and { (something like namespace\n{\n..., whereas in tests invoked from unittests/Format/FormatTests.cpp, there is a separate line with namespace\n and another one with {\n.

Sep 19 2017, 8:41 AM
curdeius abandoned D37980: [clang-format] Better parsing of lambda captures with initializer expressions..

Ok. Nice patch. You can close https://bugs.llvm.org/show_bug.cgi?id=19986 now.

Sep 19 2017, 7:25 AM
curdeius updated the diff for D37980: [clang-format] Better parsing of lambda captures with initializer expressions..

Minor: use FormatToken::isNot instead of !FormatToken::is.

Sep 19 2017, 2:59 AM
curdeius added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

There is one big missing thing here: PointerAlignment. Actually only PAS_Left is taken into account.
There are 3 possible options:
Left: auto& [a, b] = f();
Middle: auto & [a, b] = f();
Right: auto &[a, b] = f();

Sep 19 2017, 2:48 AM · Restricted Project

Sep 18 2017

curdeius added a comment to D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..

Could you please move the test that adds a namespace end comment to unittests/Format/NamespaceEndCommentsFixerTest.cpp?

Sep 18 2017, 9:02 AM
curdeius created D37980: [clang-format] Better parsing of lambda captures with initializer expressions..
Sep 18 2017, 8:48 AM

Sep 15 2017

curdeius updated the summary of D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..
Sep 15 2017, 7:50 AM
curdeius created D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true..
Sep 15 2017, 7:48 AM

Sep 7 2017

curdeius abandoned D31334: [clang-format] Add options for indenting preprocessor directives.

Superseded by rL312125.

Sep 7 2017, 7:33 AM
curdeius closed D37132: [clang-format] Add support for C++17 structured bindings..
Sep 7 2017, 7:30 AM

Aug 29 2017

curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Fix: use do-while loop.

Aug 29 2017, 6:43 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Extract method.

Aug 29 2017, 6:25 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Fix line endings again.

Aug 29 2017, 6:17 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Revert unintended format changes.

Aug 29 2017, 6:15 AM
curdeius updated the diff for D37132: [clang-format] Add support for C++17 structured bindings..

Fix line endings.

Aug 29 2017, 5:52 AM

Aug 25 2017

curdeius created D37132: [clang-format] Add support for C++17 structured bindings..
Aug 25 2017, 1:08 AM

Mar 28 2017

curdeius added a comment to D31334: [clang-format] Add options for indenting preprocessor directives.

Thanks Daniel.

Mar 28 2017, 7:55 AM

Mar 24 2017

curdeius updated the diff for D31334: [clang-format] Add options for indenting preprocessor directives.

Fix omitted dereference.

Mar 24 2017, 9:06 AM
curdeius created D31334: [clang-format] Add options for indenting preprocessor directives.
Mar 24 2017, 8:31 AM

Mar 23 2017

curdeius closed D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..
Mar 23 2017, 9:44 AM
curdeius added a comment to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Do you have commit rights?

Mar 23 2017, 9:38 AM
curdeius updated the diff for D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Trim spaces only everywhere. Fix test.

Mar 23 2017, 2:29 AM

Mar 22 2017

curdeius added a comment to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Hi Alex, is it OK now?

Mar 22 2017, 6:47 AM
curdeius updated the diff for D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Trim only spaces.

Mar 22 2017, 6:45 AM

Mar 9 2017

curdeius added a comment to D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..

Hi Alex and sorry for the late reply.

Mar 9 2017, 2:55 AM

Mar 3 2017

curdeius updated subscribers of D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..
Mar 3 2017, 4:16 AM
curdeius abandoned D5157: Add short documentation note about __has_feature(modules)..
Mar 3 2017, 3:59 AM
curdeius created D30567: [clang-tidy] Fix treating non-space whitespaces in checks list..
Mar 3 2017, 3:49 AM

Oct 19 2016

curdeius closed D25770: [clang-tidy] Add cert-err09-cpp check alias..
Oct 19 2016, 7:37 AM
curdeius retitled D25770: [clang-tidy] Add cert-err09-cpp check alias. from to [clang-tidy] Add cert-err09-cpp check alias..
Oct 19 2016, 7:09 AM

Oct 14 2016

curdeius closed D25558: [clang-tidy] Fix readability-braces-around-statements false positive.
Oct 14 2016, 1:19 AM · Restricted Project
curdeius updated the diff for D25558: [clang-tidy] Fix readability-braces-around-statements false positive.

Remove blank line.

Oct 14 2016, 1:18 AM · Restricted Project

Oct 13 2016

curdeius retitled D25558: [clang-tidy] Fix readability-braces-around-statements false positive from to [clang-tidy] Fix readability-braces-around-statements false positive.
Oct 13 2016, 7:11 AM · Restricted Project

Sep 8 2016

curdeius added inline comments to D24192: [clang-refactor] introducing clang-refactor.
Sep 8 2016, 5:41 AM

Sep 7 2016

curdeius added a comment to D24192: [clang-refactor] introducing clang-refactor.

For the moment, just a few nitty-gritty comments inline.
What I miss here is (as already pointed by someone) an example on how to write a new module, register it etc.

Sep 7 2016, 2:18 AM

Jun 13 2016

curdeius updated subscribers of D21279: Fix some issues in clang-format's AlignConsecutive modes.
Jun 13 2016, 3:20 AM · Restricted Project

May 18 2016

curdeius added a comment to D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths..

Nice job! Thanks for taking my remarks into account.

May 18 2016, 11:51 AM
curdeius added a comment to D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths..

Some minor remarks. Sorry for being finicky :).

May 18 2016, 12:45 AM

May 3 2016

curdeius added a comment to D18919: [Clang-tidy] Add check "modernize use using" .

I'm really interested in the manner this check works when a typedef has multiple declarations in it (same example as in the comment):

typedef int m_int, *m_int_p, &m_int_r, m_int_arr[10], (&m_int_fun)(int, int);
May 3 2016, 7:46 AM

Apr 8 2016

curdeius added a comment to D18136: boost-use-to-string check.

Minor remark.

Apr 8 2016, 12:13 AM

Nov 9 2015

curdeius added a comment to D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman..

Ping?

Nov 9 2015, 1:02 AM

Oct 20 2015

curdeius added a comment to D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman..

Applied comments.

Oct 20 2015, 1:34 AM
curdeius updated the diff for D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman..
  • AllowShortFunctionsOnASingleLine: true didn't work with BreakBeforeBraces: Linux/Allman.
  • Add test checking that non-empty functions in styles with BraceWrapping.AfterFunction = true don't get merged into one line. Fix the merge condition.
Oct 20 2015, 1:30 AM

Oct 19 2015

curdeius closed D13549: Added new options to ClangFormat VSIX package..
Oct 19 2015, 3:10 AM

Oct 16 2015

curdeius added a comment to D13549: Added new options to ClangFormat VSIX package..

Where is the code in the CL that handles extracting that value from a JSON string? Because it looks like you're just building an array list of the trivial non-JSON style names, so why couldn't that be an enum? I don't know mucha bout clang-format, but looking at the comments it seems like the JSON only comes into play when you're reading a .clang-format file, and in that case the value of the enum would be Style.File (until you finish reading that, at which case you set it to Style.LLVM etc).

The Style option is actually passed to clang-format -style parameter and it's clang-format that parses it. It can be a predefined type (one of: 'none', 'file', 'LLVM', etc.) or a JSON (or JSON-like?) string.

Oct 16 2015, 9:07 AM
curdeius retitled D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman. from [clang-format] AllowShortFunctionsOnASingleLine: true didn't work with BreakBeforeBraces: Linux/Allman. to [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman..
Oct 16 2015, 7:29 AM
curdeius retitled D13811: [clang-format] AllowShortFunctionsOnASingleLine: true/Empty didn't work with BreakBeforeBraces: Linux/Allman. from to [clang-format] AllowShortFunctionsOnASingleLine: true didn't work with BreakBeforeBraces: Linux/Allman..
Oct 16 2015, 7:28 AM
curdeius added a comment to D13549: Added new options to ClangFormat VSIX package..

Hi Zachary, just to answer your comments. I have done it on purpose not to use enum, because clang-format style can be actually a JSON string, e.g. {BasedOnStyle: "LLVM", IndentWidth: 4}, so it wouldn't translate into an enum (to my knowledge at least). Besides, I would like to have the possibility not to add a new enum value if there is a new style in clang-format.
Please correct me if I'm wrong about enums.

Oct 16 2015, 12:53 AM

Oct 15 2015

curdeius added a comment to D13549: Added new options to ClangFormat VSIX package..

Ping?

Oct 15 2015, 1:01 AM

Oct 13 2015

curdeius added a comment to D13549: Added new options to ClangFormat VSIX package..

Applied comments and done some minor clean up.

Oct 13 2015, 8:06 AM
curdeius updated the diff for D13549: Added new options to ClangFormat VSIX package..

Applied Aaron's comments. Removed unused using.

Oct 13 2015, 8:04 AM
curdeius added inline comments to D13549: Added new options to ClangFormat VSIX package..
Oct 13 2015, 7:39 AM

Oct 12 2015

curdeius added a comment to D13549: Added new options to ClangFormat VSIX package..

Assume-Filename option will now give an error when there are quotes in the filename.

Oct 12 2015, 8:13 AM
curdeius updated the diff for D13549: Added new options to ClangFormat VSIX package..

Add option converters for filenames (prohibiting quotes) and styles (giving a list of predefined styles).

Oct 12 2015, 8:11 AM
curdeius added inline comments to D13549: Added new options to ClangFormat VSIX package..
Oct 12 2015, 3:15 AM
curdeius added inline comments to D13549: Added new options to ClangFormat VSIX package..
Oct 12 2015, 2:39 AM
curdeius added a comment to D13549: Added new options to ClangFormat VSIX package..

Applied suggestions from comments.

Oct 12 2015, 2:26 AM
curdeius updated the diff for D13549: Added new options to ClangFormat VSIX package..

Add FIXME comment.

Oct 12 2015, 2:23 AM
curdeius updated the diff for D13549: Added new options to ClangFormat VSIX package..

Escape only '<' and '&'.
Remove unrelated changes from the revision.

Oct 12 2015, 2:20 AM
curdeius added inline comments to D13549: Added new options to ClangFormat VSIX package..
Oct 12 2015, 1:41 AM
curdeius updated the diff for D13549: Added new options to ClangFormat VSIX package..

Fix description formatting.

Oct 12 2015, 1:13 AM

Oct 8 2015

curdeius updated D13549: Added new options to ClangFormat VSIX package..
Oct 8 2015, 6:09 AM
curdeius updated the diff for D13549: Added new options to ClangFormat VSIX package..

Escape XML-reserved characters.

Oct 8 2015, 6:08 AM
curdeius abandoned D5185: Using __isascii (POSIX) instead of isascii (deprecated)..
Oct 8 2015, 3:29 AM
curdeius set the repository for D13549: Added new options to ClangFormat VSIX package. to rL LLVM.
Oct 8 2015, 3:28 AM
curdeius retitled D13549: Added new options to ClangFormat VSIX package. from to Added new options to ClangFormat VSIX package..
Oct 8 2015, 3:28 AM

Oct 7 2015

curdeius set the repository for D13507: Fix link and format. NFC. to rL LLVM.
Oct 7 2015, 6:09 AM
curdeius retitled D13507: Fix link and format. NFC. from to Fix link and format. NFC..
Oct 7 2015, 6:08 AM

Oct 6 2015

curdeius resigned from auditing rL215557: Header guard canonicalization, clang part..

Out of date.

Oct 6 2015, 1:41 AM

Sep 9 2015

curdeius set the repository for D12729: [clang-tidy] Fix bug 22785 - readability-braces-around-statements check doesn't work well with macros. to rL LLVM.
Sep 9 2015, 7:42 AM
curdeius retitled D12729: [clang-tidy] Fix bug 22785 - readability-braces-around-statements check doesn't work well with macros. from Fix http://llvm.org/PR22785. to [clang-tidy] Fix bug 22785 - readability-braces-around-statements check doesn't work well with macros..
Sep 9 2015, 7:42 AM
curdeius retitled D12729: [clang-tidy] Fix bug 22785 - readability-braces-around-statements check doesn't work well with macros. from to Fix http://llvm.org/PR22785..
Sep 9 2015, 7:40 AM

Sep 8 2015

curdeius retitled D12687: Fix run-clang-tidy.py. Do not add "-*" to the list of checks. Make consistent the list of enabled checks and the checks in use. Moreover, removing "-*" makes the behaviour consistent with clang-tidy and allows user to use .clang-tidy configuration... from to Fix run-clang-tidy.py. Do not add "-*" to the list of checks. Make consistent the list of enabled checks and the checks in use. Moreover, removing "-*" makes the behaviour consistent with clang-tidy and allows user to use .clang-tidy configuration....
Sep 8 2015, 1:04 AM

Sep 4 2015

curdeius added a comment to D12632: [clang-tidy] Fix llvm-include-order check on Windows..
Sep 4 2015, 8:21 AM
curdeius updated D12632: [clang-tidy] Fix llvm-include-order check on Windows..
Sep 4 2015, 7:27 AM
curdeius retitled D12632: [clang-tidy] Fix llvm-include-order check on Windows. from to [clang-tidy] Fix llvm-include-order check on Windows..
Sep 4 2015, 7:26 AM
curdeius added a comment to D12629: [clang-tidy] Fix add_new_check.py..

Can you land it please?
I don't have write access.

Sep 4 2015, 7:17 AM
curdeius retitled D12629: [clang-tidy] Fix add_new_check.py. from Fix add_new_check.py. to [clang-tidy] Fix add_new_check.py..
Sep 4 2015, 1:06 AM
curdeius retitled D12629: [clang-tidy] Fix add_new_check.py. from to Fix add_new_check.py..
Sep 4 2015, 1:06 AM

Sep 3 2015

curdeius abandoned D12521: Fix MSVC2015 compilation error..

Corrected in http://reviews.llvm.org/rL246582.

Sep 3 2015, 8:47 AM