Page MenuHomePhabricator
People nicolasvasilache

nicolasvasilache (Nicolas Vasilache)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 2:24 AM (321 w, 17 h)

Recent Activity
View All

Today

nicolasvasilache accepted D147206: [mlir][transform] Add optional error checking to TrackingListener.
Thu, Mar 30, 2:09 AM · Restricted Project, Restricted Project

Yesterday

nicolasvasilache added a comment to D144401: [mlir][bufferization] Add bufferization.eliminate_empty_tensors transform op.

can this land independently of its parents in the stack ?

Wed, Mar 29, 12:20 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D144401: [mlir][bufferization] Add bufferization.eliminate_empty_tensors transform op.
Wed, Mar 29, 12:19 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D147099: [mlir][Vector] Add canonicalization pattern for vector.transpose(vector.constant_mask).
Wed, Mar 29, 11:24 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D144430: [mlir][Vector] Remove lhs and rhs masks from vector.contract.

I don't recall when/ why this was added but thanks for the cleanup!

Wed, Mar 29, 11:23 AM · Restricted Project, Restricted Project
nicolasvasilache added a reviewer for D147166: [mlir][Linalg] Fix Generalize transform: ThomasRaoux.
Wed, Mar 29, 9:13 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D147166: [mlir][Linalg] Fix Generalize transform.
Wed, Mar 29, 9:08 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146857: [mlir][Vector] Add mapIterationSpaceDimToAllOperandDims to Linalg interface.
Wed, Mar 29, 12:22 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146856: [mlir][Vector] Enable masked vectorization of linalg.fill.
Wed, Mar 29, 12:22 AM · Restricted Project, Restricted Project

Tue, Mar 28

nicolasvasilache accepted D147048: [mlir][Tensor] Use helper function for `getDroppedDims`.

thanks!

Tue, Mar 28, 12:02 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D147051: [mlir][Vector] Remove vector transfer/tensor slice canonicalization pattern.

Fantastic, thank you!

Tue, Mar 28, 12:01 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D147038: [mlir][transform] TransformStateExtension: Replace op/value handles separately.
Tue, Mar 28, 4:58 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D147039: [mlir][transform] Add TrackingListener.
Tue, Mar 28, 4:57 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D147038: [mlir][transform] TransformStateExtension: Replace op/value handles separately.

Looks good but is this really NFC ?

Tue, Mar 28, 4:52 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D147027: [mlir] Add another test case for 1:N type conversion facilities. (NFC).
Tue, Mar 28, 1:18 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146959: [mlir][scf] Implement structural conversion for 1:N type conversions..
Tue, Mar 28, 1:18 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG7cf203e73922: [mlir][Linalg][Transform] Drop spurious assertion in packGreedilyOp (authored by nicolasvasilache).
[mlir][Linalg][Transform] Drop spurious assertion in packGreedilyOp
Tue, Mar 28, 12:59 AM · Restricted Project, Restricted Project

Mon, Mar 27

nicolasvasilache committed rG15f52c1502e6: [mlir][Linalg][Transform] Add support to let `transform.structured. (authored by nicolasvasilache).
[mlir][Linalg][Transform] Add support to let `transform.structured.
Mon, Mar 27, 11:37 PM · Restricted Project, Restricted Project
nicolasvasilache closed D146969: [mlir][Linalg][Transform] Add support to let `transform.structured.pack_greedily` pad to the next multiple of a static constant.
Mon, Mar 27, 11:37 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D146961: [mlir] support external named transform libraries.

LGTM, thanks!

Mon, Mar 27, 9:07 AM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D146969: [mlir][Linalg][Transform] Add support to let `transform.structured.pack_greedily` pad to the next multiple of a static constant: ThomasRaoux, springerm.
Mon, Mar 27, 8:45 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146969: [mlir][Linalg][Transform] Add support to let `transform.structured.pack_greedily` pad to the next multiple of a static constant.

Add negative tests

Mon, Mar 27, 8:45 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146969: [mlir][Linalg][Transform] Add support to let `transform.structured.pack_greedily` pad to the next multiple of a static constant.
Mon, Mar 27, 8:01 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG352d6fe1eb22: [mlir][Linalg] NFC - Move transform utilities related to subcomputation… (authored by nicolasvasilache).
[mlir][Linalg] NFC - Move transform utilities related to subcomputation…
Mon, Mar 27, 3:49 AM · Restricted Project, Restricted Project

Sun, Mar 26

nicolasvasilache accepted D146868: [mlir][bufferize] Fix tracking of erased ops.
Sun, Mar 26, 12:20 PM · Restricted Project, Restricted Project

Sat, Mar 25

nicolasvasilache committed rG553cebde0669: [mlir][Vector] Use a RewriterBase for IR rewrites in VectorTransferOpTransforms (authored by nicolasvasilache).
[mlir][Vector] Use a RewriterBase for IR rewrites in VectorTransferOpTransforms
Sat, Mar 25, 1:49 AM · Restricted Project, Restricted Project

Fri, Mar 24

nicolasvasilache accepted D146724: [mlir][MemRef] Add patterns to extract address computations.
Fri, Mar 24, 9:41 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D144678: [mlir][linalg] Refactor convolution to img2col conversion to use gather semantics.
Fri, Mar 24, 9:36 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Thanks much!

Fri, Mar 24, 6:27 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.
Fri, Mar 24, 4:34 AM · Restricted Project, Restricted Project
nicolasvasilache requested changes to D146724: [mlir][MemRef] Add patterns to extract address computations.

sorry clicked too soon, added some comments

Fri, Mar 24, 4:33 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146724: [mlir][MemRef] Add patterns to extract address computations.

thanks for adding vector.transfer too, LGTM!

Fri, Mar 24, 4:24 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Update commit message

Fri, Mar 24, 2:09 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Drop untested transforms for now

Fri, Mar 24, 2:07 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Missed a spot

Fri, Mar 24, 2:06 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Get rid of TestVectorTransferFullPartialSplitPatterns

Fri, Mar 24, 2:03 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Get rid of TestVectorTransferLoweringPatterns

Fri, Mar 24, 1:43 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Add notifications

Fri, Mar 24, 1:27 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Get rid of https://reviews.llvm.org/D146755

Fri, Mar 24, 1:00 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Reorder transforms alphabetically.

Fri, Mar 24, 12:53 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Add declareDependentDialect<LLVM::LLVMDialect>(); and fix test

Fri, Mar 24, 12:48 AM · Restricted Project, Restricted Project

Thu, Mar 23

nicolasvasilache added inline comments to D144678: [mlir][linalg] Refactor convolution to img2col conversion to use gather semantics.
Thu, Mar 23, 11:57 PM · Restricted Project, Restricted Project
nicolasvasilache planned changes to D146700: [mlir][Vector] Retire brittle canonicalizations of insert/extract slice with vector.transfer.

Sorry, this is actually a WIP that I wanted to disseminate, not yet ready

Thu, Mar 23, 11:52 PM · Restricted Project, Restricted Project
nicolasvasilache updated subscribers of D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

@ftynse @qcolombet what is the magic incantation to auto-declare produced dialects without having to declare dependent dialects ?

Thu, Mar 23, 3:42 PM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Revert spurious formatting changes

Thu, Mar 23, 3:40 PM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Get rid of TestVectorTransposeLowering

Thu, Mar 23, 3:38 PM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Get rid of TestVectorContractionLowering

Thu, Mar 23, 3:20 PM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

DCE

Thu, Mar 23, 1:54 PM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.

Drop one-off test pass option for multi-reduction lowering.

Thu, Mar 23, 1:47 PM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms: ThomasRaoux, springerm.
Thu, Mar 23, 1:27 PM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146755: [mlir][Vector][Transforms] Improve the control over individual vector lowerings and transforms.
Thu, Mar 23, 1:27 PM · Restricted Project, Restricted Project
nicolasvasilache committed rG2bc4c3e920ee: [mlir][Vector] NFC - Reorganize vector patterns (authored by nicolasvasilache).
[mlir][Vector] NFC - Reorganize vector patterns
Thu, Mar 23, 11:30 AM · Restricted Project, Restricted Project
nicolasvasilache closed D146736: [mlir][Vector] NFC - Reorganize vector patterns.
Thu, Mar 23, 11:30 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146736: [mlir][Vector] NFC - Reorganize vector patterns.

Bazel build fixes

Thu, Mar 23, 11:30 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D146736: [mlir][Vector] NFC - Reorganize vector patterns.
In D146736#4217377, @ThomasRaoux wrote:

The re-oragnization looks good to me. I assume no changes in the patterns so I haven't looked into them.

Thu, Mar 23, 11:20 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146736: [mlir][Vector] NFC - Reorganize vector patterns.
Thu, Mar 23, 11:03 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146736: [mlir][Vector] NFC - Reorganize vector patterns.
Thu, Mar 23, 11:02 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146736: [mlir][Vector] NFC - Reorganize vector patterns.

Rebase

Thu, Mar 23, 11:01 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG73bec2b2c3c9: [mlir][Vector] Retire one old filter-based test (authored by nicolasvasilache).
[mlir][Vector] Retire one old filter-based test
Thu, Mar 23, 11:01 AM · Restricted Project, Restricted Project
nicolasvasilache closed D146742: [mlir][Vector] Retire one old filter-based test.
Thu, Mar 23, 11:00 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146742: [mlir][Vector] Retire one old filter-based test.

Rebase

Thu, Mar 23, 10:54 AM · Restricted Project, Restricted Project
nicolasvasilache added a reviewer for D146742: [mlir][Vector] Retire one old filter-based test: ThomasRaoux.
Thu, Mar 23, 10:49 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146742: [mlir][Vector] Retire one old filter-based test.
Thu, Mar 23, 10:49 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146736: [mlir][Vector] NFC - Reorganize vector patterns.

Update

Thu, Mar 23, 10:43 AM · Restricted Project, Restricted Project
nicolasvasilache planned changes to D146736: [mlir][Vector] NFC - Reorganize vector patterns.
Thu, Mar 23, 10:12 AM · Restricted Project, Restricted Project
nicolasvasilache added a reviewer for D146736: [mlir][Vector] NFC - Reorganize vector patterns: ThomasRaoux.
Thu, Mar 23, 9:59 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146736: [mlir][Vector] NFC - Reorganize vector patterns.

Update

Thu, Mar 23, 9:58 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146736: [mlir][Vector] NFC - Reorganize vector patterns.
Thu, Mar 23, 9:52 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D146724: [mlir][MemRef] Add patterns to extract address computations.

Thanks, LGTM, make sense to keep the interface work for later.

Thu, Mar 23, 8:02 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG4dc72d47ce88: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns (authored by nicolasvasilache).
[mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns
Thu, Mar 23, 4:04 AM · Restricted Project, Restricted Project
nicolasvasilache closed D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.
Thu, Mar 23, 4:03 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.

Build fixes

Thu, Mar 23, 4:03 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.

Build fixes

Thu, Mar 23, 4:01 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.

Address comments.

Thu, Mar 23, 3:53 AM · Restricted Project, Restricted Project
nicolasvasilache added a reviewer for D146700: [mlir][Vector] Retire brittle canonicalizations of insert/extract slice with vector.transfer: springerm.
Thu, Mar 23, 1:23 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146700: [mlir][Vector] Retire brittle canonicalizations of insert/extract slice with vector.transfer.

Update commit message.

Thu, Mar 23, 1:23 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146700: [mlir][Vector] Retire brittle canonicalizations of insert/extract slice with vector.transfer.
Thu, Mar 23, 1:22 AM · Restricted Project, Restricted Project

Wed, Mar 22

nicolasvasilache updated the diff for D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.

Rebase.

Wed, Mar 22, 5:35 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG255ba1c334b8: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and… (authored by nicolasvasilache).
[mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and…
Wed, Mar 22, 5:31 AM · Restricted Project, Restricted Project
nicolasvasilache closed D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.
Wed, Mar 22, 5:31 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.

Address comments.

Wed, Mar 22, 5:23 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.
Wed, Mar 22, 5:23 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.

@springerm please note the comments around deprecating canonicalization patterns, these have impacts on bufferization and I expect we'll need to test and relayer things properly to avoid spurious copies.

Wed, Mar 22, 5:06 AM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns: qcolombet, springerm, ftynse, ThomasRaoux.
Wed, Mar 22, 5:05 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146624: [mlir][Tensor] Add a FoldTensorSubsetOps pass and patterns.
Wed, Mar 22, 5:04 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.

Update

Wed, Mar 22, 2:30 AM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols: ftynse, springerm, bondhugula, qcolombet.
Wed, Mar 22, 2:24 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.
Wed, Mar 22, 2:22 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D143910: [mlir][tensor] Add transform to make tensor.pad/empty loop-independent.

Does this update change the way this is supposed to interact with HoistPadding ?
Or in other words, how do you see this interacting with HoistPadding ?

Wed, Mar 22, 12:21 AM · Restricted Project, Restricted Project

Tue, Mar 21

nicolasvasilache committed rG829446cb459f: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps (authored by nicolasvasilache).
[mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps
Tue, Mar 21, 10:28 PM · Restricted Project, Restricted Project
nicolasvasilache closed D146515: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps.
Tue, Mar 21, 10:27 PM · Restricted Project, Restricted Project
nicolasvasilache accepted D146601: [mlir][affine] Prevent vectorizer test from crash without any map.

thanks!

Tue, Mar 21, 10:20 PM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D146515: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps.

Address and rebase

Tue, Mar 21, 10:17 PM · Restricted Project, Restricted Project
nicolasvasilache committed rG20294bf6c148: [mlir][Transform] NFC - Add more advanced debug spew to help hunt down… (authored by nicolasvasilache).
[mlir][Transform] NFC - Add more advanced debug spew to help hunt down…
Tue, Mar 21, 6:18 AM · Restricted Project, Restricted Project
nicolasvasilache closed D146509: [mlir][Transform] NFC - Add more advanced debug spew to help hunt down potential misuses.
Tue, Mar 21, 6:18 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D146515: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps.

Note the automatic d -> s promotion due to affine scoping rules.
I would personally prefer to trigger the promotion explicitly rather than have it apply everywhere all the time but this has not been a hard blocker recently.

Tue, Mar 21, 5:53 AM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D146515: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps: ftynse, bondhugula, springerm, ThomasRaoux, mravishankar.
Tue, Mar 21, 4:44 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D146515: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps.
Tue, Mar 21, 4:44 AM · Restricted Project, Restricted Project
nicolasvasilache resigned from D145368: [mlir] Add a pattern to fold single- and zero-iteration scf.forall ops..

thanks for picking up the slack @herhut , won't have time to look deeper atm so please go with this

Tue, Mar 21, 3:51 AM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D146509: [mlir][Transform] NFC - Add more advanced debug spew to help hunt down potential misuses: ftynse, springerm.
Tue, Mar 21, 3:22 AM · Restricted Project, Restricted Project