Page MenuHomePhabricator

nicolasvasilache (Nicolas Vasilache)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 2:24 AM (207 w, 5 d)

Recent Activity

Today

nicolasvasilache accepted D95305: [mlir][Linalg] Add canonicalization for init_tensor -> subtensor op..
Tue, Jan 26, 1:12 PM · Restricted Project
nicolasvasilache updated the diff for D95441: [mlir] Extend semantic of OffsetSizeAndStrideOpInterface..

Fix test.

Tue, Jan 26, 1:09 PM · Restricted Project
nicolasvasilache requested review of D95475: [mlir][DO NOT COMMIT] Demonstrate i1 memref data layout issue..
Tue, Jan 26, 1:01 PM · Restricted Project
nicolasvasilache requested review of D95441: [mlir] Extend semantic of OffsetSizeAndStrideOpInterface..
Tue, Jan 26, 6:21 AM · Restricted Project

Yesterday

nicolasvasilache committed rG90ebc489ded3: Add vp2intersect to AVX512 dialect. (authored by springerm).
Add vp2intersect to AVX512 dialect.
Mon, Jan 25, 11:37 PM
nicolasvasilache closed D95301: Add vp2intersect to AVX512 dialect..
Mon, Jan 25, 11:37 PM · Restricted Project
nicolasvasilache updated the summary of D95301: Add vp2intersect to AVX512 dialect..
Mon, Jan 25, 11:29 PM · Restricted Project
nicolasvasilache committed rG05d5125d8a9f: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands. (authored by nicolasvasilache).
[mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands.
Mon, Jan 25, 6:21 AM
nicolasvasilache closed D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..
Mon, Jan 25, 6:21 AM · Restricted Project
nicolasvasilache updated the diff for D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..

Rebase.

Mon, Jan 25, 6:16 AM · Restricted Project
nicolasvasilache committed rG52e25523a98f: [mlir][Linalg] Fix incorrect erase order (authored by nicolasvasilache).
[mlir][Linalg] Fix incorrect erase order
Mon, Jan 25, 6:13 AM
nicolasvasilache added inline comments to D95243: [mlir][Linalg] Add a hoistPaddingOnTensors transformation.
Mon, Jan 25, 5:50 AM · Restricted Project
nicolasvasilache committed rG68eee55ce6a4: [mlir][Linalg] Address missed review item (authored by nicolasvasilache).
[mlir][Linalg] Address missed review item
Mon, Jan 25, 5:49 AM
nicolasvasilache added inline comments to D95301: Add vp2intersect to AVX512 dialect..
Mon, Jan 25, 5:08 AM · Restricted Project
nicolasvasilache updated the diff for D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..

Address and rebase.

Mon, Jan 25, 4:59 AM · Restricted Project
nicolasvasilache added inline comments to D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..
Mon, Jan 25, 4:49 AM · Restricted Project
nicolasvasilache committed rGdbf9bedf4079: [mlir][Linalg] Add a hoistPaddingOnTensors transformation (authored by nicolasvasilache).
[mlir][Linalg] Add a hoistPaddingOnTensors transformation
Mon, Jan 25, 4:42 AM
nicolasvasilache closed D95243: [mlir][Linalg] Add a hoistPaddingOnTensors transformation.
Mon, Jan 25, 4:42 AM · Restricted Project
nicolasvasilache added inline comments to D95243: [mlir][Linalg] Add a hoistPaddingOnTensors transformation.
Mon, Jan 25, 4:02 AM · Restricted Project
nicolasvasilache updated the diff for D95243: [mlir][Linalg] Add a hoistPaddingOnTensors transformation.

class -> struct

Mon, Jan 25, 3:54 AM · Restricted Project
nicolasvasilache updated the diff for D95243: [mlir][Linalg] Add a hoistPaddingOnTensors transformation.

Address review.

Mon, Jan 25, 3:49 AM · Restricted Project
nicolasvasilache committed rG3747eb9c85b3: [mlir][Linalg] Add a padding option to Linalg tiling (authored by nicolasvasilache).
[mlir][Linalg] Add a padding option to Linalg tiling
Mon, Jan 25, 1:21 AM
nicolasvasilache closed D95149: [mlir][Linalg] Add a padding option to Linalg tiling.
Mon, Jan 25, 1:21 AM · Restricted Project

Sun, Jan 24

nicolasvasilache updated the diff for D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..

Keep a ValueRange based builder around.

Sun, Jan 24, 2:03 PM · Restricted Project
nicolasvasilache requested review of D95317: [mlir][Linalg] Drop SliceOp.
Sun, Jan 24, 1:07 PM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Undo bad fix and fix use-after-move properly.

Sun, Jan 24, 12:37 PM · Restricted Project
nicolasvasilache requested review of D95316: [mlir] Fix subview verifier..
Sun, Jan 24, 12:28 PM · Restricted Project
nicolasvasilache updated the diff for D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..

Address.

Sun, Jan 24, 11:40 AM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Fix use after move.

Sun, Jan 24, 11:35 AM · Restricted Project
nicolasvasilache accepted D95301: Add vp2intersect to AVX512 dialect..

Looks great, thanks @springerm !

Sun, Jan 24, 11:13 AM · Restricted Project
nicolasvasilache added a comment to D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

I am not disputing that this is useful, but at least within IREE, I am not sure we can actually set a static tile size at the time of tiling. In IREE with the linalg on tensors path the tile size has to by dynamic during tile and distribute since it is done at the Flow dialect level where no backend specific information is available. The static tile size picked while tiling might not be one that is best for the backend that is targeted (information that is available only at the HAL level). So making this padding as part of the tiling transformation might not work out for IREE. My understanding then is that if we separate out the padding parts from the tiling transformation itself then it has the same constraints/restrictions as promotion, but with the advantage of SSA use-def chains.

Sun, Jan 24, 10:56 AM · Restricted Project
nicolasvasilache updated the diff for D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..

Fix test.

Sun, Jan 24, 8:11 AM · Restricted Project
nicolasvasilache requested review of D95310: [mlir] Generalize OpFoldResult usage in ops with offsets, sizes and operands..
Sun, Jan 24, 7:55 AM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Attempt to appease win, 3rd take..

Sun, Jan 24, 6:24 AM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Attempt to appeas win, again..

Sun, Jan 24, 4:56 AM · Restricted Project
nicolasvasilache added a comment to D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

It should be easy to extend promotion to abort if it doesnt figure out the static sizes when "promotion" is applied to ops with tensor semantics.

Sun, Jan 24, 4:46 AM · Restricted Project

Fri, Jan 22

nicolasvasilache added a comment to D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

This feels like it is promotion on tensors with the linalg.simple_pad (for now and linalg.pad later) being used instead of the alloc(...) ; copy(...) method. So the tensor "promotion" and buffer promotion are living in entirely different places. Ill go deeper into this code, but my read of the tests informs this comment.

Fri, Jan 22, 2:22 PM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Address comments.

Fri, Jan 22, 2:18 PM · Restricted Project
nicolasvasilache requested review of D95243: [mlir][Linalg] Add a hoistPaddingOnTensors transformation.
Fri, Jan 22, 8:52 AM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Attempt to appease win.

Fri, Jan 22, 1:54 AM · Restricted Project
nicolasvasilache accepted D95211: [mlir][StandardOps] Fix typos in the td file..
Fri, Jan 22, 1:39 AM · Restricted Project
nicolasvasilache added a reviewer for D95149: [mlir][Linalg] Add a padding option to Linalg tiling: ftynse.
Fri, Jan 22, 1:08 AM · Restricted Project
nicolasvasilache updated the diff for D95149: [mlir][Linalg] Add a padding option to Linalg tiling.

Drop ValueOrAttr.

Fri, Jan 22, 1:08 AM · Restricted Project
nicolasvasilache added inline comments to D95149: [mlir][Linalg] Add a padding option to Linalg tiling.
Fri, Jan 22, 12:51 AM · Restricted Project

Thu, Jan 21

nicolasvasilache accepted D95208: [mlir][Linalg] NFC: Refactor LinalgDependenceGraphElem to allow representing dependence from producer result to consumer..
Thu, Jan 21, 11:55 PM · Restricted Project
nicolasvasilache accepted D95153: [mlir][Linalg] Make Fill operation work on tensors..
Thu, Jan 21, 1:33 PM · Restricted Project
nicolasvasilache accepted D93704: [mlir][Linalg] Introduce linalg.pad_tensor op..
Thu, Jan 21, 1:29 PM · Restricted Project
nicolasvasilache requested review of D95149: [mlir][Linalg] Add a padding option to Linalg tiling.
Thu, Jan 21, 9:53 AM · Restricted Project
nicolasvasilache added a comment to D93704: [mlir][Linalg] Introduce linalg.pad_tensor op..

This looks good.
Can you please add one test per verifier failure to test/Dialect/Linalg/invalid.mlir ?
Once these are in, this is good to go.

Thu, Jan 21, 9:49 AM · Restricted Project

Wed, Jan 20

nicolasvasilache added a comment to D94966: [mlir][linalg] Define a depthwise 2-D convolution op.

+1 on the negative tests but IIRC there is no size check/verifier automatically generated from the affine maps?
This is generally something we want for all linalg ops but it is missing atm.

Wed, Jan 20, 2:30 PM · Restricted Project
nicolasvasilache committed rG555a395f2ccd: [mlir] NFC - Fix unused variable in non-debug mode (authored by nicolasvasilache).
[mlir] NFC - Fix unused variable in non-debug mode
Wed, Jan 20, 2:22 PM
nicolasvasilache requested changes to D93704: [mlir][Linalg] Introduce linalg.pad_tensor op..

Thanks for pushing on this Hanhan.
The impl. needs to be a little more involved to allow different numbers of low and high padding values.
You'll also need extra builders and accessors to make things easier to manipulate, they can be added on a per need basis.
You can look at Subview/Subtensor and the OffsetSizesAndStridesInterface for similarly looking code.
Refactorings to reuse code are most welcome, if reasonable.

Wed, Jan 20, 12:55 PM · Restricted Project
nicolasvasilache committed rG8dd58a509cc8: [mlir][Linalg] NFC - Fully compose map and operands when creating AffineMin in… (authored by nicolasvasilache).
[mlir][Linalg] NFC - Fully compose map and operands when creating AffineMin in…
Wed, Jan 20, 12:37 PM
nicolasvasilache committed rG866cb2603904: [mlir] Fix SubTensorInsertOp semantics (authored by nicolasvasilache).
[mlir] Fix SubTensorInsertOp semantics
Wed, Jan 20, 12:17 PM
nicolasvasilache closed D95076: [mlir] Fix SubTensorInsertOp semantics.
Wed, Jan 20, 12:17 PM · Restricted Project
nicolasvasilache updated the diff for D95076: [mlir] Fix SubTensorInsertOp semantics.

Address nit

Wed, Jan 20, 12:16 PM · Restricted Project
nicolasvasilache updated the diff for D95076: [mlir] Fix SubTensorInsertOp semantics.

Address nit.

Wed, Jan 20, 12:14 PM · Restricted Project
nicolasvasilache added a reviewer for D95076: [mlir] Fix SubTensorInsertOp semantics: ThomasRaoux.
Wed, Jan 20, 12:01 PM · Restricted Project
nicolasvasilache requested review of D95076: [mlir] Fix SubTensorInsertOp semantics.
Wed, Jan 20, 12:01 PM · Restricted Project
nicolasvasilache committed rGc075572646a9: [mlir][Linalg] NFC - Expose getSmallestBoundingIndex as an utility function (authored by nicolasvasilache).
[mlir][Linalg] NFC - Expose getSmallestBoundingIndex as an utility function
Wed, Jan 20, 11:53 AM
nicolasvasilache committed rGf5d8eb085af9: [mlir][Linalg] NFC - getAssumedNonShapedOperands now returns OperandRange (authored by nicolasvasilache).
[mlir][Linalg] NFC - getAssumedNonShapedOperands now returns OperandRange
Wed, Jan 20, 11:24 AM

Tue, Jan 19

nicolasvasilache committed rG93a873dfc9ee: [mlir][Affine] Revisit and simplify composeAffineMapAndOperands. (authored by nicolasvasilache).
[mlir][Affine] Revisit and simplify composeAffineMapAndOperands.
Tue, Jan 19, 5:56 AM
nicolasvasilache closed D94920: [mlir][Affine] Revisit and simplify composeAffineMapAndOperands..
Tue, Jan 19, 5:56 AM · Restricted Project
nicolasvasilache added inline comments to D94920: [mlir][Affine] Revisit and simplify composeAffineMapAndOperands..
Tue, Jan 19, 5:49 AM · Restricted Project
nicolasvasilache updated the diff for D94920: [mlir][Affine] Revisit and simplify composeAffineMapAndOperands..

Address.

Tue, Jan 19, 5:49 AM · Restricted Project

Mon, Jan 18

nicolasvasilache updated the diff for D94920: [mlir][Affine] Revisit and simplify composeAffineMapAndOperands..

clang-tidy

Mon, Jan 18, 11:05 AM · Restricted Project
nicolasvasilache requested review of D94920: [mlir][Affine] Revisit and simplify composeAffineMapAndOperands..
Mon, Jan 18, 10:09 AM · Restricted Project
nicolasvasilache requested changes to D94843: [mlir][affine] Fix crash when composing affine_expr with symbol multiplying dim.

This is an unreasonable relaxation IMO.
I'm looking into rewriting the part that requires AffineNormalizer, stay tuned.

Mon, Jan 18, 3:40 AM · Restricted Project
nicolasvasilache accepted D94812: [mlir][python] Swap shape and element_type order for MemRefType..
Mon, Jan 18, 1:06 AM · Restricted Project

Sat, Jan 16

nicolasvasilache accepted D94598: [mlir] Fix cross-compilation (Linalg ODS gen).
Sat, Jan 16, 5:50 AM · Restricted Project
nicolasvasilache accepted D94852: [mlir][sparse] improved sparse runtime support library.
Sat, Jan 16, 5:00 AM · Restricted Project

Thu, Jan 14

nicolasvasilache accepted D93076: [mlir][Linalg] Add canonicalization of linalg op -> dim op..

Thanks!

Thu, Jan 14, 11:33 AM · Restricted Project
nicolasvasilache accepted D94548: [mlir][linalg] Add docstring support for named op spec.
Thu, Jan 14, 6:40 AM · Restricted Project

Wed, Jan 13

nicolasvasilache accepted D94632: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an operation.

Thanks!

Wed, Jan 13, 1:46 PM · Restricted Project
nicolasvasilache added a comment to D93076: [mlir][Linalg] Add canonicalization of linalg op -> dim op..

ok, my apologies, this looks great, I'll do a proper review in a bit but consider it landed :)

Wed, Jan 13, 7:50 AM · Restricted Project
nicolasvasilache added a comment to D94551: [mlir][sparse] add vectorization strategies to sparse compiler.

On one hand, it's great to see minimal additional patterns translate to new capabilities, very nice!

Wed, Jan 13, 1:01 AM · Restricted Project
nicolasvasilache accepted D94335: [mlir][linalg] Use attributes in named ops' indexing maps.
Wed, Jan 13, 12:17 AM · Restricted Project

Tue, Jan 12

nicolasvasilache committed rG80f078548868: [mlir][Linalg] NFC - Refactor fusion APIs (authored by nicolasvasilache).
[mlir][Linalg] NFC - Refactor fusion APIs
Tue, Jan 12, 6:32 AM
nicolasvasilache closed D94493: [mlir][Linalg] NFC - Refactor fusion APIs.
Tue, Jan 12, 6:32 AM · Restricted Project
nicolasvasilache retitled D94493: [mlir][Linalg] NFC - Refactor fusion APIs from BEGIN_PUBLIC [mlir][Linalg] NFC - Refactor fusion APIs to [mlir][Linalg] NFC - Refactor fusion APIs.
Tue, Jan 12, 6:28 AM · Restricted Project
nicolasvasilache requested review of D94493: [mlir][Linalg] NFC - Refactor fusion APIs.
Tue, Jan 12, 6:02 AM · Restricted Project
nicolasvasilache added a comment to D94441: [mlir][vector] verify memref of vector memory ops.

LGTM, thanks!

Tue, Jan 12, 2:11 AM · Restricted Project

Sun, Jan 10

nicolasvasilache committed rGa92248600ec4: [mlir] NFC - Drop spurious assertion on symbols during… (authored by nicolasvasilache).
[mlir] NFC - Drop spurious assertion on symbols during…
Sun, Jan 10, 6:07 AM

Sat, Jan 9

nicolasvasilache accepted D94352: [mlir][vector] modified scatter/gather syntax, pass_thru mandatory.
Sat, Jan 9, 9:20 AM · Restricted Project
nicolasvasilache added a comment to D94335: [mlir][linalg] Use attributes in named ops' indexing maps.

There are a few typos in the commit message.

Sat, Jan 9, 8:45 AM · Restricted Project
nicolasvasilache accepted D94240: [mlir][linalg] Support parsing attributes in named op spec.
Sat, Jan 9, 8:42 AM · Restricted Project

Fri, Jan 8

nicolasvasilache accepted D94318: [mlir][vector] Add memory effects to transfer_read transfer_write ops.
Fri, Jan 8, 11:31 AM · Restricted Project

Wed, Jan 6

nicolasvasilache accepted D94148: [mlir][vector] Support transfer op on tensor optimizations.
Wed, Jan 6, 10:01 AM · Restricted Project
nicolasvasilache accepted D94115: [mlir] Add hoisting transformation for transfer ops on tensor.
Wed, Jan 6, 8:21 AM · Restricted Project
nicolasvasilache accepted D93904: [mlir][vector] Support unrolling for transfer ops using tensors.

Looks good but let's please simplify the Value source part.

Wed, Jan 6, 7:41 AM · Restricted Project
nicolasvasilache added inline comments to D94148: [mlir][vector] Support transfer op on tensor optimizations.
Wed, Jan 6, 4:59 AM · Restricted Project
nicolasvasilache accepted D93774: [mlir][Linalg] Fix reshape fusion to reshape the outs instead of creating new tensors..

Great, much nicer, thanks!

Wed, Jan 6, 3:20 AM · Restricted Project

Tue, Jan 5

nicolasvasilache accepted D93077: [mlir][Linalg] NFC: Verify tiling on linalg.generic operation on tensors..

+1 for the extra test.

Tue, Jan 5, 12:23 PM · Restricted Project
nicolasvasilache added a comment to D93076: [mlir][Linalg] Add canonicalization of linalg op -> dim op..

Going through my unreviewed stack, note that with the revamp of linalg on tensors @pifon2a sent a diff today that implements the functionality with out tensors,

Tue, Jan 5, 11:58 AM · Restricted Project
nicolasvasilache accepted D94093: [mlir][Linalg] Add a test case that consumer has "reduction" loops..
Tue, Jan 5, 8:52 AM · Restricted Project
nicolasvasilache accepted D94079: [mlir] Add canonicalization pattern out_tensor->linalg->dim to out_tensor->dim..

Thanks @pifon2a !

Tue, Jan 5, 5:17 AM · Restricted Project

Wed, Dec 30

nicolasvasilache accepted D93831: fix affine_map compose with multi-symbols.
Wed, Dec 30, 9:09 AM · Restricted Project
nicolasvasilache committed rG9b5a3d67b496: [mlir] Fix indexing of first offset operand in ops that implement… (authored by nicolasvasilache).
[mlir] Fix indexing of first offset operand in ops that implement…
Wed, Dec 30, 8:58 AM
nicolasvasilache closed D93947: [mlir] Fix indexing of first offset operand in ops that implement OffsetSizeAndStrideOpInterface.
Wed, Dec 30, 8:57 AM · Restricted Project
nicolasvasilache requested review of D93947: [mlir] Fix indexing of first offset operand in ops that implement OffsetSizeAndStrideOpInterface.
Wed, Dec 30, 8:44 AM · Restricted Project