- User Since
- Feb 2 2017, 2:24 AM (228 w, 17 h)
Avoid DenseMap update-while-iterating, which hopfully will fix Windows.
Add constness to relevant places in the analysis following-up on update-while-iterating issue.
Fix one test in comprehensive-func-bufferize which did not consider ReturnOp to read and resulted in a spurious clobber.
Address River's comments.
Discussed as part of the review of https://reviews.llvm.org/D104110
Finish the implementation and make tests green again.
Mon, Jun 14
LGTM, thanks @rriddle !
Sun, Jun 13
Fri, Jun 11
I wouldn't shay away form changing the pretty form (in a followup CL as it will involve a bunch of updates).
This still requires a bit more work and tests but should already be reviewable.
Very nice stack coming to a resolution, thanks much for splitting all these up!
Drop spurious test file.
Thu, Jun 10
Wed, Jun 9
Great, let's land this!
Mon, Jun 7
Fri, Jun 4
Thanks @stephenneuendorffer !
Note that this will prob be handled by allowing vector<T> in the longer term https://llvm.discourse.group/t/should-we-have-0-d-vectors/3097.
Could you please add a TODO along those lines ?
This CL feels like it's doing too much at once, can we please split the generic pattern from the 3 inittensor-less patterns ?
Thu, Jun 3
Wed, Jun 2
Great, thanks for splitting these up !
Tue, Jun 1
Mon, May 31
LGTM, thanks for modernizing this!
Please add some tests.
Sun, May 30
Thanks for attacking this @antiagainst !
I haven't looked at the details yet but the low/hi padding composition looks like what I'd expect.
Thu, May 27
Wed, May 26
A folder would be better because createOrFold cleans a lot of things up by construction without relying on calling a canonicalization pass in weird places.
In this particular this is fine for now because coarse-grained canonicalization is fine.
Let's add a proper folding hook and use createAndFold please, this has multiple benefits over all clients using internal op-specific knowledge.
Tue, May 25
Approved modulo moving the piece of code that looks like a pad helper.
Thanks for your contribution!