Page MenuHomePhabricator

nicolasvasilache (Nicolas Vasilache)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 2:24 AM (282 w, 6 d)

Recent Activity

Today

nicolasvasilache requested review of D129185: [mlir][Transform][WIP] MAake applyToOne return a DiagnosedSilenceableFailure.
Wed, Jul 6, 3:49 AM · Restricted Project, Restricted Project

Yesterday

nicolasvasilache added inline comments to D129144: [mlir][memref] Improve type inference for rank-reducing subviews.
Tue, Jul 5, 9:28 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D129090: [mlir] Structured transforms: introduce op splitting.
Tue, Jul 5, 8:31 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D129145: [mlir][interfaces][NFC] Remove ViewLikeInterface::expandToRank.
Tue, Jul 5, 7:18 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D129144: [mlir][memref] Improve type inference for rank-reducing subviews.

LGTM conditioned on reusing helpers rather than reinventing.

Tue, Jul 5, 7:18 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D129143: [mlir][tensor][bufferize][NFC] Clean up test case.
Tue, Jul 5, 7:07 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D129110: [mlir] Transform dialect: introduce merge_handles op.

Generally looks good modulo the fact that this does not specify what happens with null handles.
I suspect we want to introduce NoOp before we can really use this new op you propose here?

Tue, Jul 5, 2:58 AM · Restricted Project, Restricted Project
nicolasvasilache committed rGdf5c981be35a: [mlir][Linalg] Add DropUnitDims support for tensor::ParallelInsertSliceOp. (authored by nicolasvasilache).
[mlir][Linalg] Add DropUnitDims support for tensor::ParallelInsertSliceOp.
Tue, Jul 5, 1:36 AM · Restricted Project, Restricted Project
nicolasvasilache closed D129091: [mlir][Linalg] Add DropUnitDims support for tensor::ParallelInsertSliceOp..
Tue, Jul 5, 1:36 AM · Restricted Project, Restricted Project

Mon, Jul 4

nicolasvasilache added reviewers for D129091: [mlir][Linalg] Add DropUnitDims support for tensor::ParallelInsertSliceOp.: ftynse, springerm.
Mon, Jul 4, 9:51 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D129091: [mlir][Linalg] Add DropUnitDims support for tensor::ParallelInsertSliceOp..
Mon, Jul 4, 9:50 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

would be nice to refactor to directly call into a new verifyContractionOpImpl helper in the same way that we have tensor::verifyInsertSliceOp

Mon, Jul 4, 9:36 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D129087: CombineContractBroadcast should not create dims unused in LHS+RHS.
Mon, Jul 4, 9:34 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG2fde26dfcabe: [mlir][Linalg][NFC] Make getReassociationMapForFoldingUnitDims a visible helper… (authored by nicolasvasilache).
[mlir][Linalg][NFC] Make getReassociationMapForFoldingUnitDims a visible helper…
Mon, Jul 4, 9:00 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D129087: CombineContractBroadcast should not create dims unused in LHS+RHS.
Mon, Jul 4, 8:44 AM · Restricted Project, Restricted Project
nicolasvasilache accepted rGaa78c5298ea3: Fix MLIR Python CMake bug causing duplicate sources target..

thanks!

Mon, Jul 4, 7:18 AM · Restricted Project, Restricted Project
nicolasvasilache committed rGc9fb3c6ea6cc: [mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of… (authored by nicolasvasilache).
[mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of…
Mon, Jul 4, 2:38 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128985: [mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of InsertSliceOp.
Mon, Jul 4, 2:38 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128985: [mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of InsertSliceOp.

Rebase

Mon, Jul 4, 2:37 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG7fbf55c927f2: [mlir][Tensor] Move ParallelInsertSlice to the tensor dialect (authored by nicolasvasilache).
[mlir][Tensor] Move ParallelInsertSlice to the tensor dialect
Mon, Jul 4, 1:53 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128920: [mlir][Tensor] Move ParallelInsertSlice to the tensor dialect.
Mon, Jul 4, 1:53 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128920: [mlir][Tensor] Move ParallelInsertSlice to the tensor dialect.

Rebase ad update BUILD.bazel

Mon, Jul 4, 12:43 AM · Restricted Project, Restricted Project

Fri, Jul 1

nicolasvasilache accepted D128978: [MLIR][Linalg] Update filename to reflect implementation (NFC).
Fri, Jul 1, 5:41 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128985: [mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of InsertSliceOp.

Update doc.

Fri, Jul 1, 5:28 AM · Restricted Project, Restricted Project
nicolasvasilache added reviewers for D128985: [mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of InsertSliceOp: ftynse, ThomasRaoux, springerm.
Fri, Jul 1, 5:24 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128985: [mlir][Tensor] Update ParallelInsertSlicOp semantics to match that of InsertSliceOp.
Fri, Jul 1, 5:23 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128920: [mlir][Tensor] Move ParallelInsertSlice to the tensor dialect.

Rebase.

Fri, Jul 1, 12:24 AM · Restricted Project, Restricted Project
nicolasvasilache committed rGb994d388aeb2: [mlir][SCF] Add a ParallelCombiningOpInterface to decouple scf… (authored by nicolasvasilache).
[mlir][SCF] Add a ParallelCombiningOpInterface to decouple scf…
Fri, Jul 1, 12:19 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128857: [mlir][SCF] Add a ParallelCombiningOpInterface to decouple scf::PerformConcurrently from its contained operations.
Fri, Jul 1, 12:18 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG6a57d8fba5b3: [mlir][vector] Untangle TransferWriteDistribution and avoid crashing in the 0-D… (authored by nicolasvasilache).
[mlir][vector] Untangle TransferWriteDistribution and avoid crashing in the 0-D…
Fri, Jul 1, 12:15 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128793: [mlir][vector] Untangle TransferWriteDistribution and avoid crashing in the 0-D case..
Fri, Jul 1, 12:15 AM · Restricted Project, Restricted Project

Thu, Jun 30

nicolasvasilache accepted D128925: Useful error when input dim is unused by LHS/RHS..

thanks! please also add a test to invalid.mlir to test we report this.

Thu, Jun 30, 9:02 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128920: [mlir][Tensor] Move ParallelInsertSlice to the tensor dialect.

Better isolate specific canonicalization test from the rest of the infra.

Thu, Jun 30, 8:37 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128920: [mlir][Tensor] Move ParallelInsertSlice to the tensor dialect.
Thu, Jun 30, 8:23 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128857: [mlir][SCF] Add a ParallelCombiningOpInterface to decouple scf::PerformConcurrently from its contained operations.

Rebase + fixes.

Thu, Jun 30, 7:38 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128857: [mlir][SCF] Add a ParallelCombiningOpInterface to decouple scf::PerformConcurrently from its contained operations.

Add another helper method.

Thu, Jun 30, 3:45 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG178f9bd63c9e: [mlir][Linalg] Uniformize SplitReduction transforms and add option to use… (authored by nicolasvasilache).
[mlir][Linalg] Uniformize SplitReduction transforms and add option to use…
Thu, Jun 30, 3:32 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.
Thu, Jun 30, 3:32 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

Rebase.

Thu, Jun 30, 3:13 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

I am not sure introducing an allocation semantics op at this level makes sense for all use cases. AFAICS, the bufferization allocation op should only be introduced "close to bufferization" and that might not be the case for all use cases. Definitely is not the case for within IREE. At the very least it should be optional to use this op.

Thu, Jun 30, 3:00 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

Refactor transforms and make alloc_tensor optional.

Thu, Jun 30, 2:59 AM · Restricted Project, Restricted Project

Wed, Jun 29

nicolasvasilache requested review of D128857: [mlir][SCF] Add a ParallelCombiningOpInterface to decouple scf::PerformConcurrently from its contained operations.
Wed, Jun 29, 2:39 PM · Restricted Project, Restricted Project
nicolasvasilache committed rG0fb24a85cb7e: [mlir][Tensor] Improve documentation of verification behavior of InsertSliceOp. (authored by nicolasvasilache).
[mlir][Tensor] Improve documentation of verification behavior of InsertSliceOp.
Wed, Jun 29, 7:53 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128803: [mlir][Tensor][NFC] Better document rank-reducing behavior of ExtractSliceOp and cleanup.
Wed, Jun 29, 7:41 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128803: [mlir][Tensor][NFC] Better document rank-reducing behavior of ExtractSliceOp and cleanup.

Landed as 741f8f2bede58573560372bc219b2dec9a1d6643

Wed, Jun 29, 7:41 AM · Restricted Project, Restricted Project
nicolasvasilache committed rG741f8f2bede5: [mlir][Tensor][NFC] Better document rank-reducing behavior of ExtractSliceOp… (authored by nicolasvasilache).
[mlir][Tensor][NFC] Better document rank-reducing behavior of ExtractSliceOp…
Wed, Jun 29, 7:39 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D128803: [mlir][Tensor][NFC] Better document rank-reducing behavior of ExtractSliceOp and cleanup.
Wed, Jun 29, 4:28 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128803: [mlir][Tensor][NFC] Better document rank-reducing behavior of ExtractSliceOp and cleanup.
Wed, Jun 29, 4:19 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128793: [mlir][vector] Untangle TransferWriteDistribution and avoid crashing in the 0-D case..
Wed, Jun 29, 2:03 AM · Restricted Project, Restricted Project

Tue, Jun 28

nicolasvasilache added inline comments to D128739: Fix CombineContractBroadcast folding reduction iterators..
Tue, Jun 28, 1:25 PM · Restricted Project, Restricted Project
nicolasvasilache committed rGa48bdee6866c: q[mlir][Vector] Add a ShapeCastOp(BroadcastOp) canonicalization pattern (authored by nicolasvasilache).
q[mlir][Vector] Add a ShapeCastOp(BroadcastOp) canonicalization pattern
Tue, Jun 28, 9:50 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128734: [mlir][Vector] Add a ShapeCastOp(BroadcastOp) canonicalization pattern.
Tue, Jun 28, 9:49 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128734: [mlir][Vector] Add a ShapeCastOp(BroadcastOp) canonicalization pattern.

Drop prefix case that is potentially dangerous.

Tue, Jun 28, 8:49 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128734: [mlir][Vector] Add a ShapeCastOp(BroadcastOp) canonicalization pattern.
Tue, Jun 28, 8:31 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

Fix missing paren.

Tue, Jun 28, 5:57 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

Cleanup.

Tue, Jun 28, 5:45 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.

Drop spurious files.

Tue, Jun 28, 5:28 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128722: [mlir][Linalg] Make SplitReduction use bufferize::AllocTensor.
Tue, Jun 28, 5:27 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128666: [mlir][SCF][bufferize][NFC] Implement resolveConflicts for ParallelInsertSliceOp.
Tue, Jun 28, 3:10 AM · Restricted Project, Restricted Project

Mon, Jun 27

nicolasvasilache committed rGa0f843fdafa7: [SCF] Add thread_dim_mapping attribute to scf.foreach_thread (authored by nicolasvasilache).
[SCF] Add thread_dim_mapping attribute to scf.foreach_thread
Mon, Jun 27, 4:59 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128633: [SCF] Add thread_dim_mapping attribute to scf.foreach_thread.
Mon, Jun 27, 4:59 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D128633: [SCF] Add thread_dim_mapping attribute to scf.foreach_thread.
Mon, Jun 27, 4:59 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128633: [SCF] Add thread_dim_mapping attribute to scf.foreach_thread.

Rebase and address comment.

Mon, Jun 27, 4:58 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128633: [SCF] Add thread_dim_mapping attribute to scf.foreach_thread.
Mon, Jun 27, 4:46 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128274: [mlir][bufferization] Add `memory_space` op attribute.

Thanks! Please update the title before landing.

Mon, Jun 27, 3:10 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128275: [mlir][bufferization][NFC] Change signature of getMemRefType.
Mon, Jun 27, 12:57 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D128443: [mlir] introduce multi-sized tiling transformation.
Mon, Jun 27, 12:54 AM · Restricted Project, Restricted Project

Sun, Jun 26

nicolasvasilache updated subscribers of rGd57163957926: [mlir][Linalg] SplitReduction implementation without tensor::ExpandShapeOp.

Sorry @kazu, just saw this, thanks for fixing!

Sun, Jun 26, 6:19 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128575: Adding a new variant of DepthwiseConv2D.
Sun, Jun 26, 6:08 AM · Restricted Project, Restricted Project

Sat, Jun 25

nicolasvasilache accepted D128530: [mlir] Transform dialect: separate dependent and generated dialects.
Sat, Jun 25, 6:54 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128422: [mlir][SCF][bufferize][NFC] Bufferize scf.for terminator separately.
Sat, Jun 25, 6:49 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128581: [mlir][SCF][bufferize] Bufferize scf.if/execute_region terminators separately.
Sat, Jun 25, 6:48 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128580: [mlir][SCF][bufferize][NFC] Bufferize parallel_insert_slice separately.
Sat, Jun 25, 6:43 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128579: [mlir][shape][bufferize][NFC] Bufferize block terminators separately.
Sat, Jun 25, 6:42 AM · Restricted Project, Restricted Project

Fri, Jun 24

nicolasvasilache accepted D128545: [mlir][vector] Relax transfer_write vector distribution pattern.
Fri, Jun 24, 11:51 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D128443: [mlir] introduce multi-sized tiling transformation.
Fri, Jun 24, 10:21 AM · Restricted Project, Restricted Project
nicolasvasilache added inline comments to D128443: [mlir] introduce multi-sized tiling transformation.
Fri, Jun 24, 9:59 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128443: [mlir] introduce multi-sized tiling transformation.

I wonder if there is an opportunity to split this PR in a few smaller and more composable pieces.

Fri, Jun 24, 9:58 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128443: [mlir] introduce multi-sized tiling transformation.

High level comment, could we use TilingInterface for this. The advantage is that you don't need to couple this to the looping construct. I hope to purge the implicit coupling of scf within the implementation of tiling in Linalg. I found that separating the looping constructs from the tiling implementation makes things much simpler. It might help here as well

I looked at the interface and it seems that it would be more involved to implement this over the interface rather than here because of the exponentially expanding loop structure. So it would be preferable to me to have the actual tiling approach reviewed and exercised first, before eventually porting it to the interface in a separate commit.

Fri, Jun 24, 8:50 AM · Restricted Project, Restricted Project
nicolasvasilache requested changes to D125718: [mlir][bufferize] Improve handling of to_memref ops during analysis.

Can you document the reason for this special casing?
Wouldn't this be better as a helper function that a client could call explicitly to know that bufferization won't do anything for them and they can avoid calling it in the first place ?
I am very concerned of anything that gives the impression to_memref and his twin are ok to have in this pass.

Fri, Jun 24, 8:50 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128423: [mlir][bufferize] Infer memory space in all bufferization patterns.

Nice!

Fri, Jun 24, 8:45 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128422: [mlir][SCF][bufferize][NFC] Bufferize scf.for terminator separately.

Can we split into 1PR per op plz, also drop the NFC as tests are changing.

Fri, Jun 24, 8:44 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128420: [mlir][bufferization][NFC] Bufferize with PostOrder traversal.

ok, but please drop the NFC part, the tests are changing.

Fri, Jun 24, 8:30 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128275: [mlir][bufferization][NFC] Change signature of getMemRefType.

We want to go away from affine map to specify layout (see in particular https://discourse.llvm.org/t/rfc-remove-bare-pointer-calling-convention/63419 ) and a bunch of other relates posts.
Can this PR just add the form you want for the address space?

Fri, Jun 24, 8:29 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128277: [mlir][bufferization][NFC] Add error handling to getBuffer.
Fri, Jun 24, 8:27 AM · Restricted Project, Restricted Project
nicolasvasilache accepted D128278: [mlir][bufferize][NFC] Change signature of allocateTensorForShapedValue.
Fri, Jun 24, 8:27 AM · Restricted Project, Restricted Project
nicolasvasilache requested changes to D128274: [mlir][bufferization] Add `memory_space` op attribute.
Fri, Jun 24, 8:26 AM · Restricted Project, Restricted Project
nicolasvasilache committed rGf6c79c6ae49f: [mlir][Vector]Fix bug where vector::WarpExecuteOnLane0Op are created with 2… (authored by nicolasvasilache).
[mlir][Vector]Fix bug where vector::WarpExecuteOnLane0Op are created with 2…
Fri, Jun 24, 7:34 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128534: [mlir][Vector]Fix bug where vector::WarpExecuteOnLane0Op are created with 2 blocks in the region.
Fri, Jun 24, 7:34 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128534: [mlir][Vector]Fix bug where vector::WarpExecuteOnLane0Op are created with 2 blocks in the region.
Fri, Jun 24, 7:32 AM · Restricted Project, Restricted Project

Thu, Jun 23

nicolasvasilache committed rG8c6da7648393: [mlir][Transform] Fix applyToOne corner case when no op is matched. (authored by nicolasvasilache).
[mlir][Transform] Fix applyToOne corner case when no op is matched.
Thu, Jun 23, 12:19 PM · Restricted Project, Restricted Project
nicolasvasilache closed D128456: [mlir][Transform] Fix applyToOne corner case when no op is matched..
Thu, Jun 23, 12:19 PM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128456: [mlir][Transform] Fix applyToOne corner case when no op is matched..
Thu, Jun 23, 12:16 PM · Restricted Project, Restricted Project
nicolasvasilache committed rG4c7225d19a9d: [mlir][Transform] Fix implementation of the generic apply that is based on… (authored by nicolasvasilache).
[mlir][Transform] Fix implementation of the generic apply that is based on…
Thu, Jun 23, 5:30 AM · Restricted Project, Restricted Project
nicolasvasilache closed D128414: [mlir][Transform] Fix implementation of the generic apply that is based on applyToOne..
Thu, Jun 23, 5:29 AM · Restricted Project, Restricted Project
nicolasvasilache added a comment to D128414: [mlir][Transform] Fix implementation of the generic apply that is based on applyToOne..

Address.

Thu, Jun 23, 5:27 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128414: [mlir][Transform] Fix implementation of the generic apply that is based on applyToOne..

Address comments.

Thu, Jun 23, 5:27 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128414: [mlir][Transform] Fix implementation of the generic apply that is based on applyToOne..

Drop spurious dump.

Thu, Jun 23, 4:58 AM · Restricted Project, Restricted Project
nicolasvasilache updated the diff for D128414: [mlir][Transform] Fix implementation of the generic apply that is based on applyToOne..

Finish impl and add tests.

Thu, Jun 23, 4:53 AM · Restricted Project, Restricted Project
nicolasvasilache requested review of D128414: [mlir][Transform] Fix implementation of the generic apply that is based on applyToOne..
Thu, Jun 23, 2:34 AM · Restricted Project, Restricted Project