Page MenuHomePhabricator

nicolasvasilache (Nicolas Vasilache)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 2:24 AM (228 w, 17 h)

Recent Activity

Today

nicolasvasilache requested review of D104490: [mlir][Linalg] Add support for scf::ForOp in comprehensive bufferization (7/n).
Thu, Jun 17, 2:47 PM · Restricted Project
nicolasvasilache accepted D104449: [mlir][linalg] Purge linalg.indexed_generic..
Thu, Jun 17, 5:42 AM · Restricted Project

Yesterday

nicolasvasilache updated the diff for D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).

Avoid DenseMap update-while-iterating, which hopfully will fix Windows.
Add constness to relevant places in the analysis following-up on update-while-iterating issue.
Fix one test in comprehensive-func-bufferize which did not consider ReturnOp to read and resulted in a spurious clobber.

Wed, Jun 16, 12:05 PM · Restricted Project
nicolasvasilache committed rGa1678987d982: [mlir] NFC - Drop newline form BlockArgument printing. (authored by nicolasvasilache).
[mlir] NFC - Drop newline form BlockArgument printing.
Wed, Jun 16, 6:29 AM
nicolasvasilache closed D104368: [mlir] NFC - Drop newline form BlockArgument printing..
Wed, Jun 16, 6:29 AM · Restricted Project
nicolasvasilache updated the diff for D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).

Address River's comments.

Wed, Jun 16, 4:39 AM · Restricted Project
nicolasvasilache added inline comments to D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).
Wed, Jun 16, 4:39 AM · Restricted Project
nicolasvasilache added a comment to D104368: [mlir] NFC - Drop newline form BlockArgument printing..

Discussed as part of the review of https://reviews.llvm.org/D104110

Wed, Jun 16, 4:16 AM · Restricted Project
nicolasvasilache added inline comments to D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).
Wed, Jun 16, 4:16 AM · Restricted Project
nicolasvasilache requested review of D104368: [mlir] NFC - Drop newline form BlockArgument printing..
Wed, Jun 16, 4:15 AM · Restricted Project
nicolasvasilache updated the diff for D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).

Finish the implementation and make tests green again.

Wed, Jun 16, 3:58 AM · Restricted Project
nicolasvasilache updated the summary of D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).
Wed, Jun 16, 3:57 AM · Restricted Project

Mon, Jun 14

nicolasvasilache added a comment to D104160: [mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op.

LGTM, thanks @rriddle !

Mon, Jun 14, 11:59 AM · Restricted Project

Sun, Jun 13

nicolasvasilache accepted D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.
Sun, Jun 13, 11:05 PM · Restricted Project

Fri, Jun 11

nicolasvasilache added a comment to D104109: [mlir][linalg] Add support for scalar input operands..

I wouldn't shay away form changing the pretty form (in a followup CL as it will involve a bunch of updates).

Fri, Jun 11, 8:55 AM · Restricted Project
nicolasvasilache added inline comments to D102962: [mlir][VectorToGPU] First step to convert vector ops to GPU MMA ops.
Fri, Jun 11, 8:03 AM · Restricted Project
nicolasvasilache added a comment to D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).

This still requires a bit more work and tests but should already be reviewable.

Fri, Jun 11, 5:40 AM · Restricted Project
nicolasvasilache accepted D102962: [mlir][VectorToGPU] First step to convert vector ops to GPU MMA ops.

Very cool!

Fri, Jun 11, 5:30 AM · Restricted Project
nicolasvasilache added a comment to D103735: [mlir] Vectorize linalg.pad_tensor consumed by transfer_read.

Very nice stack coming to a resolution, thanks much for splitting all these up!

Fri, Jun 11, 5:12 AM · Restricted Project
nicolasvasilache accepted D104109: [mlir][linalg] Add support for scalar input operands..

Very nice!

Fri, Jun 11, 5:11 AM · Restricted Project
nicolasvasilache accepted D103891: [mlir][linalg] Prepare pad to static bounding box for scalar operands..
Fri, Jun 11, 5:10 AM · Restricted Project
nicolasvasilache accepted D103890: [mlir][linalg] Prepare drop unit dims for scalar operands..
Fri, Jun 11, 5:10 AM · Restricted Project
nicolasvasilache accepted D104025: [mlir][[linalg] Remove deprecated structured op interface methods..

Nice!

Fri, Jun 11, 5:09 AM · Restricted Project
nicolasvasilache accepted D103780: [mlir] Vectorize linalg.pad_tensor consumed by subtensor_insert.
Fri, Jun 11, 5:08 AM · Restricted Project
nicolasvasilache accepted D103735: [mlir] Vectorize linalg.pad_tensor consumed by transfer_read.
Fri, Jun 11, 5:08 AM · Restricted Project
nicolasvasilache accepted D103879: [mlir][linalg] Lower PadTensorOps with non-constant pad value.
Fri, Jun 11, 5:06 AM · Restricted Project
nicolasvasilache accepted D103791: [mlir][linalg] Vectorize linalg.pad_op source copying (improved).
Fri, Jun 11, 5:05 AM · Restricted Project
nicolasvasilache accepted D103747: [mlir][linalg] Vectorize linalg.pad_op source copying (static source shape).
Fri, Jun 11, 5:04 AM · Restricted Project
nicolasvasilache accepted D103137: [mlir][linalg] Vectorize linalg.pad_tensor consumed by transfer_write.
Fri, Jun 11, 5:00 AM · Restricted Project
nicolasvasilache added reviewers for D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n): silvas, benvanik, rriddle, herhut, pifon2a, mravishankar.
Fri, Jun 11, 4:54 AM · Restricted Project
nicolasvasilache accepted D103778: [mlir][linalg] Fold linalg.pad_tensor if src type == result type.
Fri, Jun 11, 4:53 AM · Restricted Project
nicolasvasilache updated the diff for D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).

Drop spurious test file.

Fri, Jun 11, 4:52 AM · Restricted Project
nicolasvasilache requested review of D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).
Fri, Jun 11, 4:51 AM · Restricted Project

Thu, Jun 10

nicolasvasilache accepted D103946: [mlir] make LLVMPointerType implement the data layout type interface.
Thu, Jun 10, 2:06 AM · Restricted Project

Wed, Jun 9

nicolasvasilache accepted D102504: 2d Arm Neon sdot op, and lowering to the intrinsic..

Great, let's land this!

Wed, Jun 9, 11:38 PM · Restricted Project
nicolasvasilache added inline comments to D102504: 2d Arm Neon sdot op, and lowering to the intrinsic..
Wed, Jun 9, 2:24 PM · Restricted Project
nicolasvasilache accepted D103984: Folds linalg.pad_tensor with zero padding.
Wed, Jun 9, 2:21 PM · Restricted Project
nicolasvasilache accepted D102504: 2d Arm Neon sdot op, and lowering to the intrinsic..
Wed, Jun 9, 1:01 PM · Restricted Project

Mon, Jun 7

nicolasvasilache accepted D103763: [mlir] Add offset/stride helper functions to OffsetSizeAndStrideOpInterface.
Mon, Jun 7, 1:54 AM · Restricted Project
nicolasvasilache accepted D103781: [mlir][linalg] Add padding helper functions to PadTensorOp.
Mon, Jun 7, 1:54 AM · Restricted Project
nicolasvasilache accepted D103520: [mlir][linalg] Cleanup LinalgOp usage in comprehensive bufferization..
Mon, Jun 7, 1:12 AM · Restricted Project

Fri, Jun 4

nicolasvasilache accepted D103715: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns.
Fri, Jun 4, 1:37 PM · Restricted Project
nicolasvasilache accepted D103679: [mlir][linalg] Lower PadTensorOp to InitTensorOp + FillOp + SubTensorInitOp.
Fri, Jun 4, 7:43 AM · Restricted Project
nicolasvasilache accepted D103681: [mlir][linalg] Refactor PadTensorOpVectorizationPattern (NFC).
Fri, Jun 4, 7:38 AM · Restricted Project
nicolasvasilache accepted D103432: [mlir] Handle cases where transform_read should turn into a scalar load.

Thanks @stephenneuendorffer !
Note that this will prob be handled by allowing vector<T> in the longer term https://llvm.discourse.group/t/should-we-have-0-d-vectors/3097.
Could you please add a TODO along those lines ?

Fri, Jun 4, 4:21 AM · Restricted Project
nicolasvasilache added inline comments to D103679: [mlir][linalg] Lower PadTensorOp to InitTensorOp + FillOp + SubTensorInitOp.
Fri, Jun 4, 3:17 AM · Restricted Project
nicolasvasilache added a comment to D103137: [mlir][linalg] Vectorize linalg.pad_tensor consumed by transfer_write.

This CL feels like it's doing too much at once, can we please split the generic pattern from the 3 inittensor-less patterns ?

Fri, Jun 4, 3:08 AM · Restricted Project
nicolasvasilache added inline comments to D103590: [mlir][linalg] Fold away empty PadTensorOp in canonicalizer.
Fri, Jun 4, 2:54 AM · Restricted Project
nicolasvasilache accepted D103590: [mlir][linalg] Fold away empty PadTensorOp in canonicalizer.
Fri, Jun 4, 2:52 AM · Restricted Project
nicolasvasilache accepted D103673: [mlir][linalg] Cleanup left over uses of deprecated LinalgOp methods..
Fri, Jun 4, 1:14 AM · Restricted Project

Thu, Jun 3

nicolasvasilache accepted D103599: [mlir] Mark VectorToSCF patterns as recursive.
Thu, Jun 3, 2:42 AM · Restricted Project
nicolasvasilache accepted D103450: [mlir][linalg] Cleanup LinalgOp usage in promotion..
Thu, Jun 3, 2:16 AM · Restricted Project
nicolasvasilache accepted D103531: [mlir][linalg] Cleanup LinalgOp usage in generalization..
Thu, Jun 3, 2:16 AM · Restricted Project
nicolasvasilache accepted D103530: [mlir][linalg] Cleanup LinalgOp usage in bufferize, detensorize, and interchange..
Thu, Jun 3, 2:16 AM · Restricted Project
nicolasvasilache accepted D103528: [mlir][linalg] Cleanup LinalgOp usage in test passes..
Thu, Jun 3, 2:16 AM · Restricted Project
nicolasvasilache accepted D103518: [mlir][linalg] Cleanup LinalgOp usage in scalar inlining..
Thu, Jun 3, 2:15 AM · Restricted Project
nicolasvasilache accepted D103506: [mlir][linalg] Cleanup LinalgOp usage in op declarations..
Thu, Jun 3, 2:15 AM · Restricted Project
nicolasvasilache accepted D103453: [mlir][linalg] Cleanup LinalgOp usage in loop lowering..
Thu, Jun 3, 2:15 AM · Restricted Project
nicolasvasilache accepted D103448: [mlir][linalg] Cleanup LinalgOp usage in drop unit dims..
Thu, Jun 3, 2:15 AM · Restricted Project
nicolasvasilache retitled D103448: [mlir][linalg] Cleanup LinalgOp usage in drop unit dims. from [mlir][linalg] Cleanup LinalgOp usage in drop unit dims (NFC). to [mlir][linalg] Cleanup LinalgOp usage in drop unit dims..
Thu, Jun 3, 12:07 AM · Restricted Project
nicolasvasilache retitled D103453: [mlir][linalg] Cleanup LinalgOp usage in loop lowering. from [mlir][linalg] Cleanup LinalgOp usage in loop lowering (NFC). to [mlir][linalg] Cleanup LinalgOp usage in loop lowering..
Thu, Jun 3, 12:07 AM · Restricted Project
nicolasvasilache retitled D103506: [mlir][linalg] Cleanup LinalgOp usage in op declarations. from [mlir][linalg] Cleanup LinalgOp usage in op declarations (NFC). to [mlir][linalg] Cleanup LinalgOp usage in op declarations..
Thu, Jun 3, 12:06 AM · Restricted Project
nicolasvasilache retitled D103518: [mlir][linalg] Cleanup LinalgOp usage in scalar inlining. from [mlir][linalg] Cleanup LinalgOp usage in scalar inlining (NFC). to [mlir][linalg] Cleanup LinalgOp usage in scalar inlining..
Thu, Jun 3, 12:06 AM · Restricted Project
nicolasvasilache retitled D103520: [mlir][linalg] Cleanup LinalgOp usage in comprehensive bufferization. from [mlir][linalg] Cleanup LinalgOp usage in comprehensive bufferization (NFC). to [mlir][linalg] Cleanup LinalgOp usage in comprehensive bufferization..
Thu, Jun 3, 12:06 AM · Restricted Project
nicolasvasilache retitled D103528: [mlir][linalg] Cleanup LinalgOp usage in test passes. from [mlir][linalg] Cleanup LinalgOp usage in test passes (NFC). to [mlir][linalg] Cleanup LinalgOp usage in test passes..
Thu, Jun 3, 12:06 AM · Restricted Project
nicolasvasilache retitled D103530: [mlir][linalg] Cleanup LinalgOp usage in bufferize, detensorize, and interchange. from [mlir][linalg] Cleanup LinalgOp usage in bufferize, detensorize, and interchange (NFC). to [mlir][linalg] Cleanup LinalgOp usage in bufferize, detensorize, and interchange..
Thu, Jun 3, 12:06 AM · Restricted Project
nicolasvasilache retitled D103531: [mlir][linalg] Cleanup LinalgOp usage in generalization. from [mlir][linalg] Cleanup LinalgOp usage in generalization (NFC). to [mlir][linalg] Cleanup LinalgOp usage in generalization..
Thu, Jun 3, 12:06 AM · Restricted Project
nicolasvasilache retitled D103450: [mlir][linalg] Cleanup LinalgOp usage in promotion. from [mlir][linalg] Cleanup LinalgOp usage in promotion (NFC). to [mlir][linalg] Cleanup LinalgOp usage in promotion..
Thu, Jun 3, 12:06 AM · Restricted Project

Wed, Jun 2

nicolasvasilache accepted D103548: [mlir] Split linalg reshape ops into expand/collapse..

Great, thanks for splitting these up !

Wed, Jun 2, 12:18 PM · Restricted Project

Tue, Jun 1

nicolasvasilache accepted D102666: [mlir] Support tensor types in non-unrolled VectorToSCF.
Tue, Jun 1, 1:23 AM · Restricted Project
nicolasvasilache accepted D102668: [mlir] Support tensor types in unrolled VectorToSCF.
Tue, Jun 1, 1:21 AM · Restricted Project
nicolasvasilache accepted D103436: [mlir][linalg] Cleanup LinalgOp usage in sparse compiler (NFC)..
Tue, Jun 1, 12:42 AM · Restricted Project
nicolasvasilache accepted D103411: [mlir][linalg] Cleanup LinalgOp usage in dependence analysis (NFC)..
Tue, Jun 1, 12:41 AM · Restricted Project
nicolasvasilache accepted D103410: [mlir][linalg] Cleanup LinalgOp usage in vectorization (NFC)..
Tue, Jun 1, 12:40 AM · Restricted Project
nicolasvasilache accepted D103437: [mlir][linalg] Cleanup LinalgOp usage in fusion (NFC)..
Tue, Jun 1, 12:39 AM · Restricted Project
nicolasvasilache accepted D103438: [mlir][linalg] Cleanup LinalgOp usage in tiling (NFC)..
Tue, Jun 1, 12:39 AM · Restricted Project

Mon, May 31

nicolasvasilache accepted D103404: [mlir][linalg] Cleanup LinalgOp usage in verification (NFC)..
Mon, May 31, 5:36 AM · Restricted Project
nicolasvasilache accepted D103394: [mlir][linalg] Update Structured Op Interface (NFC)..

LGTM, thanks for modernizing this!

Mon, May 31, 5:34 AM · Restricted Project
nicolasvasilache updated subscribers of D102962: [mlir][VectorToGPU] First step to convert vector ops to GPU MMA ops.
Mon, May 31, 2:17 AM · Restricted Project
nicolasvasilache accepted D103219: [mlir] Updated depthwise conv to support kernel dilation.
Mon, May 31, 1:42 AM · Restricted Project
nicolasvasilache updated subscribers of D103243: [mlir][linalg] Support tiling and fusing linalg.pad_tensor.

@gysit @springerm FYI

Mon, May 31, 1:30 AM · Restricted Project
nicolasvasilache accepted D103253: [mlir][vector] Fold inbound attribute for transfer op with permutations.
Mon, May 31, 1:00 AM · Restricted Project
nicolasvasilache accepted D103133: [mlir] Support permutation maps in vector transfer op folder.
Mon, May 31, 12:54 AM · Restricted Project
nicolasvasilache added a comment to D103137: [mlir][linalg] Vectorize linalg.pad_tensor consumed by transfer_write.

Please add some tests.

Mon, May 31, 12:51 AM · Restricted Project

Sun, May 30

nicolasvasilache added a comment to D103243: [mlir][linalg] Support tiling and fusing linalg.pad_tensor.

Thanks for attacking this @antiagainst !
I haven't looked at the details yet but the low/hi padding composition looks like what I'd expect.

Sun, May 30, 11:47 PM · Restricted Project

Thu, May 27

nicolasvasilache committed rGce4f99e7f272: [mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n) (authored by nicolasvasilache).
[mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n)
Thu, May 27, 5:51 AM
nicolasvasilache closed D102512: [mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n).
Thu, May 27, 5:51 AM · Restricted Project
nicolasvasilache updated the diff for D102512: [mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n).

Address comment.

Thu, May 27, 5:36 AM · Restricted Project
nicolasvasilache added inline comments to D102512: [mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n).
Thu, May 27, 5:22 AM · Restricted Project
nicolasvasilache updated the summary of D102512: [mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n).
Thu, May 27, 5:20 AM · Restricted Project
nicolasvasilache updated the diff for D102512: [mlir][Linalg] Add comprehensive bufferization support for subtensor (5/n).

Update.

Thu, May 27, 5:20 AM · Restricted Project

Wed, May 26

nicolasvasilache accepted D103132: [mlir][linalg] Derive padded subtensor shape from linalg op outputs.

A folder would be better because createOrFold cleans a lot of things up by construction without relying on calling a canonicalization pass in weird places.
In this particular this is fine for now because coarse-grained canonicalization is fine.

Wed, May 26, 11:30 PM · Restricted Project
nicolasvasilache accepted D103226: [mlir] Support dialect-wide canonicalization pattern registration.
Wed, May 26, 11:19 PM · Restricted Project
nicolasvasilache accepted D103161: [mlir] Add `distributionTypes` to LinalgTilingOptions..
Wed, May 26, 5:43 AM · Restricted Project
nicolasvasilache requested changes to D103132: [mlir][linalg] Derive padded subtensor shape from linalg op outputs.

Let's add a proper folding hook and use createAndFold please, this has multiple benefits over all clients using internal op-specific knowledge.

Wed, May 26, 2:12 AM · Restricted Project

Tue, May 25

nicolasvasilache accepted D103110: [NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg.index.
Tue, May 25, 1:09 PM · Restricted Project
nicolasvasilache accepted D103104: [mlir] Add an optional distributionTypes attribute to TiledLoopOp..
Tue, May 25, 11:01 AM · Restricted Project
nicolasvasilache accepted D102775: [mlir][linalg] Update Linalg.md (NFC)..
Tue, May 25, 9:09 AM · Restricted Project
nicolasvasilache accepted D102804: [mlir][linalg] Transform PadTensorOp into InitOp, FillOp, GenericOp.

Approved modulo moving the piece of code that looks like a pad helper.
Thanks for your contribution!

Tue, May 25, 6:55 AM · Restricted Project
nicolasvasilache accepted D102746: [mlir] Disallow certain transfer ops in VectorToSCF.
Tue, May 25, 2:05 AM · Restricted Project