- User Since
- Feb 2 2017, 2:24 AM (282 w, 6 d)
LGTM conditioned on reusing helpers rather than reinventing.
Generally looks good modulo the fact that this does not specify what happens with null handles.
I suspect we want to introduce NoOp before we can really use this new op you propose here?
Mon, Jul 4
would be nice to refactor to directly call into a new verifyContractionOpImpl helper in the same way that we have tensor::verifyInsertSliceOp
Rebase ad update BUILD.bazel
Fri, Jul 1
Thu, Jun 30
thanks! please also add a test to invalid.mlir to test we report this.
Better isolate specific canonicalization test from the rest of the infra.
Rebase + fixes.
Add another helper method.
Refactor transforms and make alloc_tensor optional.
Wed, Jun 29
Landed as 741f8f2bede58573560372bc219b2dec9a1d6643
Tue, Jun 28
Drop prefix case that is potentially dangerous.
Fix missing paren.
Drop spurious files.
Mon, Jun 27
Rebase and address comment.
Thanks! Please update the title before landing.
Sun, Jun 26
Sorry @kazu, just saw this, thanks for fixing!
Sat, Jun 25
Fri, Jun 24
I wonder if there is an opportunity to split this PR in a few smaller and more composable pieces.
Can you document the reason for this special casing?
Wouldn't this be better as a helper function that a client could call explicitly to know that bufferization won't do anything for them and they can avoid calling it in the first place ?
I am very concerned of anything that gives the impression to_memref and his twin are ok to have in this pass.
Can we split into 1PR per op plz, also drop the NFC as tests are changing.
ok, but please drop the NFC part, the tests are changing.
We want to go away from affine map to specify layout (see in particular https://discourse.llvm.org/t/rfc-remove-bare-pointer-calling-convention/63419 ) and a bunch of other relates posts.
Can this PR just add the form you want for the address space?
Thu, Jun 23
Drop spurious dump.
Finish impl and add tests.